Timeline
Oct 21, 2019:
- 11:05 PM Changeset in webkit [251419] by
-
- 2 edits in trunk/Source/WebKit
Add some PencilKit extension points
https://bugs.webkit.org/show_bug.cgi?id=202962
<rdar://problem/56269759>
Reviewed by Andy Estes.
This is the WebKit part corresponding to <rdar://problem/56261392>.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]): Call extension point.
(-[WKContentView cleanupInteraction]): Ditto.
- 10:44 PM Changeset in webkit [251418] by
-
- 3 edits1 delete in trunk
Rolling out r251411: Fix is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=203230
Not reviewed.
JSTests:
- stress/incorrect-exception-assertion-in-operationRegExpExecNonGlobalOrSticky.js: Removed.
Source/JavaScriptCore:
- dfg/DFGOperations.cpp:
- 9:58 PM Changeset in webkit [251417] by
-
- 10 edits in trunk/LayoutTests
Multiple fast/scrolling/ios tests failing with unexpected scrollbars appearing in result
https://bugs.webkit.org/show_bug.cgi?id=203223
Reviewed by Wenson Hsieh.
Hide scrollbars in iOS iframe scrolling ref tests.
- fast/scrolling/ios/hit-testing-iframe-006.html:
- fast/scrolling/ios/mixing-user-and-programmatic-scroll-002.html:
- fast/scrolling/ios/mixing-user-and-programmatic-scroll-003.html:
- fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html:
- fast/scrolling/ios/scroll-iframe-001.html:
- fast/scrolling/ios/scroll-iframe-002.html:
- fast/scrolling/ios/scroll-iframe-003.html:
- fast/scrolling/ios/scroll-iframe-004.html:
- platform/ios-wk2/TestExpectations:
- 9:51 PM Changeset in webkit [251416] by
-
- 10 edits1 add in trunk
Suspend dedicated worker threads while in the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203186
<rdar://problem/56447493>
Reviewed by Ryosuke Niwa.
Source/WebCore:
When a page with a (dedicated) Worker enters the back/forward cache, we now
pause the worker thread, and resume it only when taking the page out of the
back/forward cache. This avoids having the worker use CPU while the page is
in the cache.
- workers/Worker.cpp:
(WebCore::Worker::suspend):
(WebCore::Worker::resume):
- workers/Worker.h:
- workers/WorkerGlobalScopeProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::suspend):
(WebCore::WorkerMessagingProxy::resume):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
- workers/WorkerMessagingProxy.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::suspend):
(WebCore::WorkerThread::resume):
(WebCore::WorkerThread::stop):
- workers/WorkerThread.h:
LayoutTests:
Extend layout test coverage.
- fast/workers/resources/worker-setInterval.js: Added.
(onmessage):
(setInterval):
- fast/workers/worker-page-cache.html:
- 9:45 PM Changeset in webkit [251415] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, rolling out r251381.
This broke an internal build.
Reverted changeset:
"Add some PencilKit extension points"
https://bugs.webkit.org/show_bug.cgi?id=202962
https://trac.webkit.org/changeset/251381
- 9:32 PM Changeset in webkit [251414] by
-
- 3 edits in trunk/Source/WebCore
Fix the build
- platform/mock/MockAudioDestinationCocoa.cpp:
- platform/mock/MockAudioDestinationCocoa.h:
- 9:05 PM Changeset in webkit [251413] by
-
- 45 edits in trunk
[Cocoa] Move ui-serif, ui-monospaced, and ui-rounded out from behind SPI
https://bugs.webkit.org/show_bug.cgi?id=203129
Reviewed by Tim Horton.
Source/WebCore:
https://github.com/w3c/csswg-drafts/issues/4107 resolved to name these new fonts
ui-serif, ui-monospaced, and ui-rounded. This patch renames them, and removes the SPI
to access these fonts.
Tests: fast/text/design-system-ui*.html
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::shouldAllowDesignSystemUIFonts const): Deleted.
- css/CSSFontFace.h:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::load):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::initializeFontStyle):
- page/Settings.yaml:
- platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::makeFlagsKey):
- platform/graphics/FontDescription.cpp:
(WebCore::m_shouldAllowUserInstalledFonts):
(WebCore::m_shouldAllowDesignSystemUIFonts): Deleted.
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::shouldAllowUserInstalledFonts const):
(WebCore::FontDescription::setShouldAllowUserInstalledFonts):
(WebCore::FontDescription::operator== const):
(WebCore::FontDescription::shouldAllowDesignSystemUIFonts const): Deleted.
(WebCore::FontDescription::setShouldAllowDesignSystemUIFonts): Deleted.
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::platformFontLookupWithFamily):
(WebCore::fontWithFamilySpecialCase):
- platform/graphics/cocoa/FontDescriptionCocoa.cpp:
(WebCore::matchSystemFontUse):
(WebCore::FontCascadeDescription::effectiveFamilyCount const):
(WebCore::FontCascadeDescription::effectiveFamilyAt const):
- platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::systemFontParameters):
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _shouldAllowDesignSystemUIFonts]): Deleted.
(-[WKPreferences _setShouldAllowDesignSystemUIFonts:]): Deleted.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
LayoutTests:
Update the tests to use the new names, and to not set the setting.
- fast/text/design-system-ui-10-expected-mismatch.html:
- fast/text/design-system-ui-10.html:
- fast/text/design-system-ui-11.html:
- fast/text/design-system-ui-12.html:
- fast/text/design-system-ui-13.html:
- fast/text/design-system-ui-14.html:
- fast/text/design-system-ui-15.html:
- fast/text/design-system-ui-16.html:
- fast/text/design-system-ui-2-expected.html:
- fast/text/design-system-ui-2.html:
- fast/text/design-system-ui-3-expected-mismatch.html:
- fast/text/design-system-ui-3.html:
- fast/text/design-system-ui-4-expected-mismatch.html:
- fast/text/design-system-ui-4.html:
- fast/text/design-system-ui-5-expected-mismatch.html:
- fast/text/design-system-ui-5.html:
- fast/text/design-system-ui-6-expected.html:
- fast/text/design-system-ui-6.html:
- fast/text/design-system-ui-7-expected.html:
- fast/text/design-system-ui-7.html:
- fast/text/design-system-ui-8-expected-mismatch.html:
- fast/text/design-system-ui-8.html:
- fast/text/design-system-ui-9-expected-mismatch.html:
- fast/text/design-system-ui-9.html:
- fast/text/design-system-ui-expected.html:
- fast/text/design-system-ui.html:
- 8:56 PM Changeset in webkit [251412] by
-
- 4 edits in trunk/LayoutTests
[WK1] Layout Test legacy-animation-engine/compositing/backing/transform-transition-from-outside-view.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=184611
Reviewed by Zalan Bujtas.
In WebKit1, the transform on the layer is not consistent, so filter it out of the layer tree dump (it's not the important part).
- legacy-animation-engine/compositing/backing/transform-transition-from-outside-view-expected.txt:
- legacy-animation-engine/compositing/backing/transform-transition-from-outside-view.html:
- platform/mac-wk1/TestExpectations:
- 6:55 PM Changeset in webkit [251411] by
-
- 3 edits1 add in trunk
Fix incorrect assertion in operationRegExpExecNonGlobalOrSticky().
https://bugs.webkit.org/show_bug.cgi?id=203230
<rdar://problem/56460749>
Reviewed by Robin Morisset.
JSTests:
- stress/incorrect-exception-assertion-in-operationRegExpExecNonGlobalOrSticky.js: Added.
Source/JavaScriptCore:
operationRegExpExecNonGlobalOrSticky() was asserting no exception when
createRegExpMatchesArray() returns null. createRegExpMatchesArray() only returns
null when RegExp::matchInline() returns -1. The only way RegExp::matchInline()
can return -1 is via a throwError() helper which throws an exception. The other
return path in RegExp::matchInline() explicitly ASSERT(result >= -1). Hence, the
assertion in operationRegExpExecNonGlobalOrSticky() is wrong.
- dfg/DFGOperations.cpp:
- 6:48 PM Changeset in webkit [251410] by
-
- 4 edits in trunk/Tools
[results.webkit.org] Change dot and lengend dot use same mechanism to center text and image
https://bugs.webkit.org/show_bug.cgi?id=203216
Reviewed by Jonathan Bedard.
- resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
- resultsdbpy/resultsdbpy/view/static/library/css/index.html:
- resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
(.dot *):
(.dot img, .dot .text):
(.dot>img, .dot>.text):
(.dot.small img, .dot.small .text):
(.dot.small>img, .dot.small>.text):
(.dot.medium img, .dot.medium .text):
(.dot.medium>img, .dot.medium>.text):
(.dot.large img, .dot.large .text):
(.dot.large>img, .dot.large>.text):
(.lengend>.item .dot):
(.lengend>.item .dot img, .lengend>.item .dot .text):
(.lengend>.item .dot>img, .lengend>.item .dot>.text):
(.dot.small *): Deleted.
(.dot img, .dot.small img): Deleted.
(.dot.medium *): Deleted.
(.dot.medium img): Deleted.
(.dot.large *): Deleted.
(.dot.large img): Deleted.
(.lengend>.item .dot .text): Deleted.
(.lengend>.item .dot img): Deleted.
- 6:34 PM Changeset in webkit [251409] by
-
- 24 edits in trunk
Move service worker registration matching for navigation loads to network process
https://bugs.webkit.org/show_bug.cgi?id=203144
Patch by youenn fablet <youenn@apple.com> on 2019-10-21
Reviewed by Chris Dumez.
Source/WebCore:
For regular loads, we no longer match service worker registration explicitly.
This is now done by NetworkResourceLoader explicitly.
We still need to explicitely match registrations in those two cases:
- There is an app cache resource that can be used. We will use it only if there is no registration.
- There is a resource from the meory cache that can be used. We will match the registration to make sure
the document is controlled by the right service worker. The load will still be served from the memory cache.
Since DocumentLoader is no longer matching registration, we need a way from NetworkProcess to inform that there is
a matching registration and that the document is controlled.
For that purpose, DocumentLoader is adding itself in a global map with the temporary document identifier as the key.
Adding to the map happens when loading the main resource and removal from the map happens when destroying the DocumentLoader.
For this to happen properly, the temporary document identifier is kept the same for the lifetime of the DocumentLoader.
Registration matching was postponed until service worker registration is done.
Since we no longer do registration matching in WebProcess, we need to wait in NetworkProcess for that to happen.
We introduce a way for SWServer to notify when import is completed for that purpose.
Covered by existing tests.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::fromTemporaryDocumentIdentifier):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::setControllingServiceWorkerRegistration):
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::startLoadingMainResource):
(WebCore::DocumentLoader::unregisterTemporaryServiceWorkerClient):
(WebCore::DocumentLoader::loadMainResource):
- loader/DocumentLoader.h:
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::canLoadMainResource):
- loader/appcache/ApplicationCacheHost.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::~SWServer):
(WebCore::SWServer::registrationStoreImportComplete):
(WebCore::SWServer::whenImportIsCompleted):
(WebCore::SWServer::doRegistrationMatching):
- workers/service/server/SWServer.h:
(WebCore::SWServer::isImportCompleted const):
Source/WebKit:
Create a WebSWServerConnection whenever receiving a load request in NetworkProcess.
This connection is used to check for service worker registration in case of navigation loads.
Similarly, we create a WebSWClientConnection whenever WebProcess needs it, including when receiving WebSWClientConnection messages from NetworkProcess.
This for instance happens when service worker registration import is complete to fill the shared registration origin store.
Delay loads until SWServer has finished importing its registrations.
This is needed since we might otherwise not intercept loads that could be intercepted.
Waiting for importing registrations was previously ensured by WebProcess getting a matching registration in DocumentLoader.
NetworkResourceLoader is now checking for service worker interception in case of redirections for navigations.
This is needed as redirections could end up using a new registration.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::establishSWServerConnection):
(WebKit::NetworkConnectionToWebProcess::swConnection):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::NetworkResourceLoader::startWithServiceWorker):
(WebKit::NetworkResourceLoader::serviceWorkerDidNotHandle):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::start):
(WebKit::ServiceWorkerFetchTask::startFetch):
(WebKit::ServiceWorkerFetchTask::continueFetchTaskWith):
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
(WebKit::ServiceWorkerFetchTask::takeRequest):
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::controlClient):
(WebKit::WebSWServerConnection::createFetchTask):
- NetworkProcess/ServiceWorker/WebSWServerConnection.h:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::WebSWClientConnection):
(WebKit::WebSWClientConnection::registrationReady):
(WebKit::WebSWClientConnection::documentIsControlled):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWClientConnection.messages.in:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
We are now creating a WebSWClientConnection whenever receiving a WebSWClientConnection message
from NetworkProcess. It is free to do so given it no longer requires sending some IPC.
Update the tests accordingly.
A future patch will remove the service worker registration bit feature and corresponding test.
- 6:33 PM Changeset in webkit [251408] by
-
- 3 edits1 add in trunk
ValuePow's constant folding rule differs from what the runtime does
https://bugs.webkit.org/show_bug.cgi?id=203220
<rdar://problem/56181441>
Reviewed by Yusuke Suzuki.
JSTests:
- value-pow-ai-rule-should-box-the-same-way-as-the-runtime.js: Added.
(foo):
Source/JavaScriptCore:
The constant folding rule for ValuePow was boxing the result using jsDoubleNumber,
where the runtime function was boxing the result using jsNumber. This patch makes
it so that constant folding agrees with what the runtime is doing.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- 6:31 PM Changeset in webkit [251407] by
-
- 2 edits in trunk/Tools
TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndInputView is failing on iPad simulator
https://bugs.webkit.org/show_bug.cgi?id=203053
Reviewed by Wenson Hsieh.
Make ScrollableWithOverflowHiddenAndInputView only test the results on iPhones. Test is not designed for ipad.
- TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
(TestWebKitAPI::TEST):
- 6:16 PM Changeset in webkit [251406] by
-
- 2 edits in trunk/PerformanceTests
[GTK] Perf test SVG/UnderTheSeeBenchmark.html timeouts.
https://bugs.webkit.org/show_bug.cgi?id=203229
Unreviewed gardening.
- Skipped: Mark 2 new tests timing out in the GTK perf bot.
- 6:12 PM Changeset in webkit [251405] by
-
- 6 edits in trunk/LayoutTests
Update Web Platform Test css/css-lists/content-property/marker-text-matches-armenian.html
https://bugs.webkit.org/show_bug.cgi?id=203130
<rdar://problem/51525184>
Reviewed by Alex Christensen.
Apply https://github.com/web-platform-tests/wpt/commit/b2d4cb4a64ae072dfc6feb888dd77575927f5ae2
LayoutTests/imported/w3c:
- web-platform-tests/css/css-lists/content-property/marker-text-matches-armenian-expected.html:
- web-platform-tests/css/css-lists/content-property/marker-text-matches-armenian.html:
LayoutTests:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 5:53 PM Changeset in webkit [251404] by
-
- 12 edits in trunk/Source
Remove IDBBackingStoreTemporaryFileHandler
https://bugs.webkit.org/show_bug.cgi?id=203128
Reviewed by Alex Christensen.
Source/WebCore:
IDBBackingStoreTemporaryFileHandler has only one member function, and implementation of that is to delete
files. To keep the same behavior, we can remove this class and delete the temporary files at the places where
objects of this class were used.
By doing this, we no longer need to pass the NetworkProcess/InProcessIDBServer all the way down to
SQLiteIDBBackingStore that is used only on background thread.
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::create):
(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::createBackingStore):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::SQLiteIDBBackingStore):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
(WebCore::IDBServer::SQLiteIDBBackingStore::temporaryFileHandler const): Deleted.
- Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
(WebCore::IDBServer::SQLiteIDBTransaction::moveBlobFilesIfNecessary):
(WebCore::IDBServer::SQLiteIDBTransaction::deleteBlobFilesIfNecessary):
(WebCore::IDBServer::SQLiteIDBTransaction::abort):
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::InProcessIDBServer):
(WebCore::InProcessIDBServer::accessToTemporaryFileComplete): Deleted.
- Modules/indexeddb/shared/InProcessIDBServer.h:
Source/WebKit:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::createIDBServer):
(WebKit::NetworkProcess::accessToTemporaryFileComplete): Deleted.
- NetworkProcess/NetworkProcess.h:
- 5:51 PM Changeset in webkit [251403] by
-
- 3 edits1 add in trunk
Fix missing exception check in JSON Stringifier.
https://bugs.webkit.org/show_bug.cgi?id=203227
<rdar://problem/56459854>
Reviewed by Keith Miller.
JSTests:
- stress/missing-exception-check-in-josn-stringifier.js: Added.
Source/JavaScriptCore:
- runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
- 5:43 PM Changeset in webkit [251402] by
-
- 1 edit4 moves in trunk/LayoutTests
http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction-database.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=202852
<rdar://problem/56195888>
Patch by Kate Cheney <Kate Cheney> on 2019-10-21
Reviewed by Alex Christensen.
Fixed test flakiness caused by the resource remaining in the cache
between tests, therefore not creating a new isolated session and
failing the text diff. This patch adds a php header to each file to
prevent the resource from being stored in the cache.
- http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction-database.php: Renamed from LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction-database.html.
- http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction.php: Renamed from LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction.html.
- http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction-database.php: Renamed from LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction-database.html.
- http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction.php: Renamed from LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction.html.
- 5:22 PM Changeset in webkit [251401] by
-
- 3 edits in trunk/Tools
results.webkit.org: Add ability to display time on bubbles
https://bugs.webkit.org/show_bug.cgi?id=203202
<rdar://problem/56436621>
Rubber-stamped by Aakash Jain.
- resultsdbpy/resultsdbpy/view/static/js/timeline.js: Add switch to show times under each bubble.
- resultsdbpy/resultsdbpy/view/templates/search.html: Correctly update timeline on callback.
- 5:17 PM Changeset in webkit [251400] by
-
- 9 edits1 copy in trunk/Source/JavaScriptCore
Rolling out r251226: Causes a build speed regression.
https://bugs.webkit.org/show_bug.cgi?id=203219
Not reviewed.
Apparently, compilers aren't very fast at compiling constexpr function invocations.
Rolling this out while I rework the patch to not have this build speed regression.
- API/glib/JSCOptions.cpp:
(jscOptionsSetValue):
(jscOptionsGetValue):
(jsc_options_foreach):
(jsc_options_get_option_group):
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- runtime/JSCConfig.h:
- runtime/OptionEntry.h: Copied from Source/JavaScriptCore/runtime/OptionEntry.h.
- runtime/Options.cpp:
(JSC::Options::isAvailable):
(JSC::overrideOptionWithHeuristic):
(JSC::scaleJITPolicy):
(JSC::recomputeDependentOptions):
(JSC::Options::initialize):
(JSC::Options::setOptionWithoutAlias):
(JSC::Options::dumpAllOptions):
(JSC::Options::dumpOption):
(JSC::Option::dump const):
(JSC::Option::operator== const):
(JSC::optionTypeSpecificIndex): Deleted.
(JSC::Option::Option): Deleted.
(JSC::Option::defaultOption const): Deleted.
- runtime/Options.h:
(JSC::Option::Option):
(JSC::Option::id const):
(JSC::Option::name const):
(JSC::Option::description const):
(JSC::Option::type const):
(JSC::Option::availability const):
(JSC::Option::isOverridden const):
(JSC::Option::defaultOption const):
(JSC::Option::boolVal):
(JSC::Option::unsignedVal):
(JSC::Option::doubleVal):
(JSC::Option::int32Val):
(JSC::Option::optionRangeVal):
(JSC::Option::optionStringVal):
(JSC::Option::gcLogLevelVal):
(JSC::Option::idIndex const): Deleted.
(JSC::optionTypeSpecificIndex): Deleted.
- runtime/OptionsList.h:
(JSC::OptionRange::operator= ): Deleted.
(JSC::OptionRange::rangeString const): Deleted.
(JSC::countNumberOfJSCOptionsOfType): Deleted.
- 5:04 PM Changeset in webkit [251399] by
-
- 5 edits in trunk/Source/JavaScriptCore
Fix issues when setting public length on ArrayWithContiguous type butterflies.
https://bugs.webkit.org/show_bug.cgi?id=203211
<rdar://problem/56476097>
Reviewed by Keith Miller and Saam Barati.
For ArrayWithContiguous type butterflies, SlotVisitor scans up to the public
length of the butterfly. When setting a new public length, if the new public
length is greater than the current, we should always writeBarrier after the
setting of the new public length. Otherwise, there can be a race where the GC
scans the butterfly after new values have been written to it but before the
public length as been updated. As a result, the new values never get scanned.
For the DFG and FTL, the StoreBarrierInsertionPhase is responsible for inserting
the writeBarriers after the node. Hence, the writeBarrier is guaranteed to be
after the publicLength has been updated.
- runtime/JSArray.cpp:
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::shiftCountWithAnyIndexingType):
- runtime/JSArrayInlines.h:
(JSC::JSArray::pushInline):
- runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
(JSC::JSObject::reallocateAndShrinkButterfly):
- runtime/JSObject.h:
(JSC::JSObject::setIndexQuickly):
- 4:56 PM Changeset in webkit [251398] by
-
- 2 edits in trunk/LayoutTests
[ Mac ] Layout Test legacy-animation-engine/compositing/backing/transform-transition-from-outside-view.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=203225
Unreviewed test gardening
- platform/mac-wk2/TestExpectations:
- 4:51 PM Changeset in webkit [251397] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (~r251067): http/tests/workers/service/registration-clear-redundant-worker.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=203218
Unreviewed Test Gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 4:47 PM Changeset in webkit [251396] by
-
- 12 edits2 adds in trunk
Add MediaCapabilities support for DolbyVision codecs.
https://bugs.webkit.org/show_bug.cgi?id=203170
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/dovi-codec-parameters.html
Add support for parsing DolbyVision (DoVi) style codec profile strings.
- platform/cocoa/VideoToolboxSoftLink.cpp:
- platform/cocoa/VideoToolboxSoftLink.h:
- platform/graphics/HEVCUtilities.cpp:
(WebCore::codecStringForDoViCodecType):
(WebCore::profileIDForAlphabeticDoViProfile):
(WebCore::isValidDoViProfileID):
(WebCore::maximumLevelIDForDoViProfileID):
(WebCore::isValidProfileIDForCodecName):
(WebCore::parseDoViCodecParameters):
- platform/graphics/HEVCUtilities.h:
- platform/graphics/cocoa/HEVCUtilitiesCocoa.h:
- platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:
(WebCore::codecStringToCodecTypeMap):
(WebCore::CFStringArrayToNumberVector):
(WebCore::validateDoViParameters):
- platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:
(WebCore::createMediaPlayerDecodingConfigurationCocoa):
- testing/Internals.cpp:
(WebCore::Internals::parseDoViCodecParameters):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/dovi-codec-parameters-expected.txt: Added.
- media/dovi-codec-parameters.html: Added.
- 4:30 PM Changeset in webkit [251395] by
-
- 16 edits in trunk/Source/JavaScriptCore
Web Inspector: make ObjC protocol dispatcher commands optional and add
respondsToSelectorchecks to allow other inspector clients to choose what they implement
https://bugs.webkit.org/show_bug.cgi?id=203197
Reviewed by Joseph Pecoraro.
This will help eliminate internal build failures, and will also allow other clients to
remove all of their commands that previously just responded with an "unsupported" error.
- inspector/scripts/codegen/objc_generator_templates.py:
- inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:
(ObjCBackendDispatcherImplementationGenerator._generate_handler_implementation_for_command):
(ObjCBackendDispatcherImplementationGenerator._generate_responds_to_selector_for_command): Added.
Add arespondsToSelectorcheck before attempting to call the delegate function.
- inspector/scripts/codegen/generate_objc_header.py:
(ObjCHeaderGenerator._generate_command_protocols):
Mark all commands as@optional.
- inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/generic/expected/command-targetType-matching-domain-debuggableType.json-result:
- inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/generic/expected/domain-debuggableTypes.json-result:
- inspector/scripts/tests/generic/expected/domain-targetType-matching-domain-debuggableType.json-result:
- inspector/scripts/tests/generic/expected/domain-targetTypes.json-result:
- inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/generic/expected/enum-values.json-result:
- inspector/scripts/tests/generic/expected/event-targetType-matching-domain-debuggableType.json-result:
- inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
- 4:23 PM Changeset in webkit [251394] by
-
- 3 edits1 add in trunk
JSON.parse has bad is array assert
https://bugs.webkit.org/show_bug.cgi?id=203207
<rdar://problem/56366913>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/json-parse-array-prototype-is-array-assert.js: Added.
(assert):
Source/JavaScriptCore:
In r250860, we updated JSON.parse to be more spec compliant with how it
handles arrays. However, we also updated an assertion in an improper way,
where our assert was not accounting for the check we performed to take
that control flow path.
- runtime/JSONObject.cpp:
(JSC::Walker::walk):
- 4:17 PM Changeset in webkit [251393] by
-
- 1 copy in tags/Safari-608.4.2
Tag Safari-608.4.2.
- 3:47 PM Changeset in webkit [251392] by
-
- 6 edits in trunk
Throw the right exception upon memory exhaustion in Array::slice
https://bugs.webkit.org/show_bug.cgi?id=202650
Reviewed by Saam Barati.
JSTests:
- stress/array-slice-memory-exhaustion.js: Added.
(foo):
Source/JavaScriptCore:
Trivial change: just use tryCreate instead of create, and throw an exception if it fails.
No security implication: we were just crashing instead of throwing a catchable exception.
- runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::slice const):
(JSC::ArrayBuffer::sliceImpl const):
- runtime/ArrayBuffer.h:
- runtime/JSArrayBufferPrototype.cpp:
(JSC::arrayBufferProtoFuncSlice):
- 3:33 PM Changeset in webkit [251391] by
-
- 10 edits in trunk
Resource Load Statistics: Update cookie blocking in NetworkStorageSession after first user interaction
https://bugs.webkit.org/show_bug.cgi?id=203195
<rdar://problem/56464567>
Reviewed by Alex Christensen and Chris Dumez.
Source/WebKit:
This change makes sure that the state of cookie blocking in
WebCore:: NetworkStorageSession is immediately updated if the logged
user interaction was new for this domain. It adds a completion
handler to WebResourceLoadStatisticsStore::logUserInteraction() so
that the call properly waits for everything to be updated.
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::CompletionHandler<void):
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::logUserInteraction):
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction):
LayoutTests:
This patch removes the explicit calls to testRunner.statisticsUpdateCookieBlocking() since
they are no longer needed. This makes sure the changed code is tested.
- http/tests/resourceLoadStatistics/third-party-cookie-blocking-on-sites-without-user-interaction-database.html:
- http/tests/resourceLoadStatistics/third-party-cookie-blocking-on-sites-without-user-interaction.html:
- 3:31 PM Changeset in webkit [251390] by
-
- 17 edits in trunk
Dispatch AR event on the originating anchor element
https://bugs.webkit.org/show_bug.cgi?id=203198
<rdar://55743929>
Reviewed by Simon Fraser.
Source/WebCore:
Expose an ElementContext on the SystemPreviewInfo, so that
when something happens in the AR QuickLook an event can be
fired on the originating <a> element.
- dom/Document.cpp:
(WebCore::Document::dispatchSystemPreviewActionEvent): Make sure
we dispatch only to the HTMLAnchorElement.
- dom/Document.h:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
- loader/FrameLoaderTypes.h:
(WebCore::SystemPreviewInfo::encode const):
(WebCore::SystemPreviewInfo::decode):
- testing/Internals.cpp:
(WebCore::Internals::elementIdentifier const):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Use the ElementContext on SystemPreviewInfo.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _triggerSystemPreviewActionOnElement:frame:page:]):
(-[WKWebView _triggerSystemPreviewActionOnFrame:page:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
- UIProcess/SystemPreviewController.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::systemPreviewActionTriggered):
Tools:
Improve this test, most importantly so that it
actually works :)
Retrieve the ElementIdentifier for the <a> element,
and trigger a system preview action on it.
- TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
(-[TestSystemPreviewTriggeredHandler userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html:
- 3:13 PM Changeset in webkit [251389] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, re-enable a couple of passing layout tests
- platform/ios/TestExpectations:
- platform/ipad/TestExpectations:
- 3:12 PM Changeset in webkit [251388] by
-
- 21 edits1 move1 delete in trunk/Source
Move ElementContext from WebKit to WebCore
https://bugs.webkit.org/show_bug.cgi?id=203210
<rdar://problem/56475682>
Reviewed by Simon Fraser.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- dom/RadioButtonGroups.h:
Source/WebKit:
- Scripts/webkit/messages.py:
- Shared/DocumentEditingContext.h:
- Shared/DocumentEditingContext.mm:
(IPC::ArgumentCoder<WebKit::DocumentEditingContextRequest>::decode):
- Shared/ElementContext.cpp: Removed.
- Shared/ElementContext.h: Removed.
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultCSSOMViewScrollingAPIEnabled):
- Shared/WebsitePoliciesData.cpp:
(WebKit::WebsitePoliciesData::decode):
- Shared/ios/InteractionInformationAtPosition.h:
- Sources.txt:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _requestTextInputContextsInRect:completionHandler:]):
- UIProcess/API/Cocoa/_WKTextInputContext.mm:
(-[_WKTextInputContext _initWithTextInputContext:]):
(-[_WKTextInputContext _textInputContext]):
- UIProcess/API/Cocoa/_WKTextInputContextInternal.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::textInputContextsInRect):
(WebKit::WebPageProxy::focusTextInputContext):
- UIProcess/WebPageProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::textInputContextsInRect):
(WebKit::WebPage::focusTextInputContext):
(WebKit::WebPage::elementForContext const):
(WebKit::WebPage::contextForElement const):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::startInteractionWithElementContextOrPosition):
- 3:07 PM Changeset in webkit [251387] by
-
- 2 edits in trunk/LayoutTests
editing/selection/ios/selection-handles-in-readonly-input.html times out
https://bugs.webkit.org/show_bug.cgi?id=203203
<rdar://problem/47710799>
Reviewed by Tim Horton.
This test began to fail in iOS 13, since we (intentionally) no longer show a keyboard when focusing
readonly
inputs. The test is intended to verify that moving selection handles inside a readonly input field will not
cause the selection to disappear, but it currently waits forever for the keyboard to appear after initially
tapping a readonly input field.
We can fix this test by instead using a tap-and-half gesture to select the text ('aa').
- editing/selection/ios/selection-handles-in-readonly-input.html:
- 3:05 PM Changeset in webkit [251386] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION(r251227): Uncaught Exception: undefined is not an object (evaluating 'agent.enable')
https://bugs.webkit.org/show_bug.cgi?id=203208
Reviewed by Joseph Pecoraro.
- UserInterface/Controllers/AppController.js:
(WI.AppController.prototype.activateExtraDomains):
- 2:36 PM Changeset in webkit [251385] by
-
- 5 edits2 adds in trunk
Setting border-radius on <video> element clips top and left sections of video
https://bugs.webkit.org/show_bug.cgi?id=202049
<rdar://problem/55570024>
Reviewed by Dean Jackson.
Source/WebCore:
updateClippingStrategy() is called both when we're setting a mask layer on m_layer,
and on m_contentsClippingLayer, and they disagreed on the coordinate space that
the rounded rect was in. r246845 fixed rounded-rect scrollers, but broke video.
Fix by declaring that the rounded rect is relative to the bounds of the layer
argument. We don't try to size the shape layer to the rounded rect, because in some
configurations (e.g. scroller with left scrollbar) the rounded rect hangs outside
the clipping layer.
Test: compositing/video/video-border-radius-clipping.html
- platform/graphics/FloatRoundedRect.h:
(WebCore::FloatRoundedRect::setLocation):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateClippingStrategy):
(WebCore::GraphicsLayerCA::updateContentsRects): The rounded rect is relative to the contentsClippingLayer,
so set its location to zero.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateChildClippingStrategy): negate the offset, as we do in updateGeometry which
has similar code.
LayoutTests:
- compositing/video/video-border-radius-clipping-expected.html: Added.
- compositing/video/video-border-radius-clipping.html: Added.
- 2:28 PM Changeset in webkit [251384] by
-
- 18 edits1 add in trunk
ServiceWorker tests should use TCPServer instead of WKURLSchemeHandler
https://bugs.webkit.org/show_bug.cgi?id=203141
Reviewed by Youenn Fablet.
Source/WebCore:
This makes the tests more like what users will see,
and it allows us to not consult custom schemes when loading service workers,
which is preventing us from moving logic to the NetworkProcess. See bug 203055.
Also, I now remove test-only code that's not used anymore.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::SWServer):
(WebCore::SWServer::canHandleScheme const):
- workers/service/server/SWServer.h:
Source/WebKit:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::addWebsiteDataStore):
(WebKit::NetworkProcess::swServerForSession):
(WebKit::NetworkProcess::addServiceWorkerSession):
- NetworkProcess/NetworkProcess.h:
- Shared/WebsiteDataStoreParameters.cpp:
(WebKit::WebsiteDataStoreParameters::encode const):
(WebKit::WebsiteDataStoreParameters::decode):
- Shared/WebsiteDataStoreParameters.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:
(-[_WKWebsiteDataStoreConfiguration registerURLSchemeServiceWorkersCanHandleForTesting:]): Deleted.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::copy):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(WebKit::WebsiteDataStoreConfiguration::serviceWorkerRegisteredSchemes const): Deleted.
(WebKit::WebsiteDataStoreConfiguration::registerServiceWorkerScheme): Deleted.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
(-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
(-[SWSchemes handledRequests]): Deleted.
(-[SWSchemes webView:startURLSchemeTask:]): Deleted.
(-[SWSchemes webView:stopURLSchemeTask:]): Deleted.
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerTCPServer.h: Added.
(ServiceWorkerTCPServer::ServiceWorkerTCPServer):
(ServiceWorkerTCPServer::request):
(ServiceWorkerTCPServer::requestWithLocalhost):
(ServiceWorkerTCPServer::requestWithFragment):
(ServiceWorkerTCPServer::userAgentsChecked):
(ServiceWorkerTCPServer::requestWithFormat):
- TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
(-[StorageSchemes webView:startURLSchemeTask:]): Deleted.
(-[StorageSchemes webView:stopURLSchemeTask:]): Deleted.
- 2:17 PM Changeset in webkit [251383] by
-
- 10 edits in trunk/Tools
Python 3: Add support in webkitpy.common.config
https://bugs.webkit.org/show_bug.cgi?id=202463
Reviewed by Dewei Zhu.
- Scripts/test-webkitpy-python3: Add webkitpy.common.config to the test list.
- Scripts/webkitpy/common/config/committers.py:
(Contributor.init): Convert lists to maps.
(Contributor.str): str will always return the native string type.
(Contributor.unicode): Use .format() string.
(CommitterList._exclusive_contributors): Convert filter to list.
(CommitterList._exclusive_committers): Ditto.
(CommitterList.contributors_by_search_string): Ditto.
- Scripts/webkitpy/common/config/committervalidator_unittest.py: Use full import paths.
- Scripts/webkitpy/common/config/contributionareas_unittest.py: Use full import paths.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.makeArgs): Use 'in' instead of has_key.
- Scripts/webkitpy/common/config/urls_unittest.py:
- Scripts/webkitpy/common/unicode_compatibility.py:
(encode_for): Encode string for type.
- Scripts/webkitpy/thirdparty/BeautifulSoup.py: Make html5lib import auto-install compatible.
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook.find_module): Add html5lib.
(AutoinstallImportHook._install_html5lib): Make html5lib a stand-alone installed package.
(AutoinstallImportHook._install_mechanize): Install html5lib.
(AutoinstallImportHook._install_beautifulsoup): Ditto.
- 2:16 PM Changeset in webkit [251382] by
-
- 4 edits in trunk/Source
macCatalyst: Swipe navigation gestures do not work
https://bugs.webkit.org/show_bug.cgi?id=203205
<rdar://problem/54617473>
Reviewed by Wenson Hsieh.
Source/WebKit:
- UIProcess/ios/ViewGestureControllerIOS.mm:
(-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):
Use a different gesture recognizer for swipe in macCatalyst that behaves
more like the macOS implementation, based on scrolling instead of the
gesture coming from a screen edge.
Source/WTF:
- wtf/Platform.h:
Add a new HAVE.
- 2:07 PM Changeset in webkit [251381] by
-
- 2 edits in trunk/Source/WebKit
Add some PencilKit extension points
https://bugs.webkit.org/show_bug.cgi?id=202962
<rdar://problem/56269759>
Reviewed by Andy Estes.
This is the WebKit part corresponding to <rdar://problem/56261392>.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]): Call extension point.
(-[WKContentView cleanupInteraction]): Ditto.
- 1:47 PM Changeset in webkit [251380] by
-
- 4 edits1 delete in trunk/LayoutTests
Update expected result for fast/repaint/placeholder-after-caps-lock-hidden.html
https://bugs.webkit.org/show_bug.cgi?id=203005
<rdar://problem/51826131>
Reviewed by Simon Fraser.
Rebase iOS result. The test fast/repaint/placeholder-after-caps-lock-hidden.html is only supported
in Modern WebKit and only on Mac and iOS, which implement uiController.toggleCapsLock(), at the time
of writing.
- platform/ios-wk2/TestExpectations: Mark test as PASS.
- platform/ios-wk2/fast/repaint/placeholder-after-caps-lock-hidden-expected.txt:
- platform/ios/TestExpectations: Remove entry so that we fallback to platform-independent TestExpectations
and skip the test because the test is only supported on Modern WebKit.
- platform/ios/fast/events/ios/placeholder-after-caps-lock-hidden-expected.txt: Removed; erroneously added
file for non-existent test.
- 1:43 PM Changeset in webkit [251379] by
-
- 10 edits in trunk/Source
Web Inspector: Provide a flag for technology preview builds
https://bugs.webkit.org/show_bug.cgi?id=203164
<rdar://problem/56202164>
Reviewed by Devin Rousso.
Source/WebCore:
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::isExperimentalBuild):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Test/Test.js:
- UserInterface/Base/Main.js:
- UserInterface/Base/Setting.js:
(WI.isTechnologyPreviewBuild):
(WI.arePreviewFeaturesEnabled):
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
In non-TechnologyPreview builds, if there are Preview Features provide a
setting switch that can be used to match the TechnologyPreview features.
- 1:25 PM Changeset in webkit [251378] by
-
- 7 edits7 adds in trunk
[SVG2]: Add 'auto' behavior to the 'width' and 'height' properties of the SVG <image> element
https://bugs.webkit.org/show_bug.cgi?id=202013
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-10-21
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/svg/geometry/svg-image-intrinsic-size-with-cssstyle-auto-dynamic-image-change-expected.txt:
- web-platform-tests/svg/geometry/svg-image-intrinsic-size-with-cssstyle-auto-expected.txt:
Source/WebCore:
The spec page is: https://www.w3.org/TR/SVG/geometry.html#Sizing
Handle the case if the 'width' or the 'height' of an SVG <image> or both
are missing.
Tests: svg/custom/image-width-height-auto-dynamic.svg
svg/custom/image-width-height-auto-initial.svg
svg/custom/image-width-height-length-initial.svg
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::calculateObjectBoundingBox const):
(WebCore::RenderSVGImage::updateImageViewport):
- rendering/svg/RenderSVGImage.h:
LayoutTests:
- svg/custom/image-width-height-auto-dynamic-expected.svg: Added.
- svg/custom/image-width-height-auto-dynamic.svg: Added.
- svg/custom/image-width-height-auto-initial-expected.svg: Added.
- svg/custom/image-width-height-auto-initial.svg: Added.
- svg/custom/image-width-height-length-initial-expected.svg: Added.
- svg/custom/image-width-height-length-initial.svg: Added.
- svg/custom/resources/100x200-green.png: Added.
- 1:19 PM Changeset in webkit [251377] by
-
- 23 edits8 adds in trunk
[Clipboard API] Implement ClipboardItem.getType() for platform clipboard items
https://bugs.webkit.org/show_bug.cgi?id=203168
Reviewed by Tim Horton.
Source/WebCore:
This patch completes support for ClipboardItem.getType().
Tests: editing/async-clipboard/clipboard-change-data-while-getting-type.html
editing/async-clipboard/clipboard-get-type-with-old-items.html
editing/async-clipboard/clipboard-item-get-type-basic.html
ClipboardTests.ReadMultipleItems
- Modules/async-clipboard/Clipboard.cpp:
(WebCore::Clipboard::getType):
Implement getType(). If the given clipboard item is being tracked as one of the active clipboard items, then
allow it to read data from the platform pasteboard. We use existing pasteboard reading methods and classes
(PasteboardPlainText and WebContentMarkupReader) to ask the platform pasteboard for text and markup data,
respectively, and go through readURL() for "text/uri-list".
Before exposing any data to the page, we additionally check that the change count of the pasteboard is still
what we started with when setting up the current session. If this is not the case, we reject the promise and
immediately clear out the session.
(WebCore::Clipboard::activePasteboard):
- Modules/async-clipboard/Clipboard.h:
- dom/DataTransfer.h:
Drive-by tweak: make the WebContentReadingPolicy enum class narrower.
- platform/Pasteboard.h:
Add an enum flag for allowing or ignoring the platform URL type when reading plain text from the platform
pasteboard. We use this in Clipboard::getType() to ignore URLs on the platform pasteboard when plain text, since
the plain text reader would otherwise prefer URLs over plain text by default, and read the URL type instead of
the plain text type.
- platform/StaticPasteboard.h:
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::read):
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read):
- platform/libwpe/PasteboardLibWPE.cpp:
(WebCore::Pasteboard::read):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::read):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::read):
Tools:
Add support for the new layout tests, as well as a new API test.
- DumpRenderTree/ios/UIScriptControllerIOS.h:
- DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::copyText):
Implement UIScriptController.copyText in WebKit1. This is used in one of the new layout tests, which passes in
WebKit1 on macOS and iOS.
- DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
(-[LocalPasteboard declareTypes:owner:]):
(-[LocalPasteboard addTypes:owner:]):
(-[LocalPasteboard _addTypesWithoutUpdatingChangeCount:owner:]):
Adjust logic when declaring types on the platform pasteboard, such that it behaves more like the platform; when
declaring types, even if the owner doesn't change, the change count should still get bumped up by 1.
- DumpRenderTree/mac/UIScriptControllerMac.h:
- DumpRenderTree/mac/UIScriptControllerMac.mm:
(WTR::UIScriptControllerMac::copyText):
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm: Added.
(-[TestWKWebView readClipboard]):
(createWebViewForClipboardTests):
(writeMultipleObjectsToPlatformPasteboard):
Add a new API test to verify that clipboard items contain the right data when writing multiple items (each with
different sets of types) to the platform pasteboard using native APIs.
- TestWebKitAPI/Tests/WebKitCocoa/clipboard.html: Added.
- WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
(-[LocalPasteboard declareTypes:owner:]):
(-[LocalPasteboard addTypes:owner:]):
(-[LocalPasteboard _addTypesWithoutUpdatingChangeCount:owner:]):
LayoutTests:
Add 3 new layout tests.
- editing/async-clipboard/clipboard-change-data-while-getting-type-expected.txt: Added.
- editing/async-clipboard/clipboard-change-data-while-getting-type.html: Added.
Add a layout test to verify that if the pasteboard changes right after the page has obtained clipboard items,
the page should not be able to fetch the new contents of the pasteboard using these clipboard items.
- editing/async-clipboard/clipboard-get-type-with-old-items.html: Added.
- editing/async-clipboard/clipboard-get-type-with-old-items-expected.txt: Added.
Add a layout test to verify that after attempting to get data from invalid (stale) items, the page is still
capable of reading data from valid clipboard items.
- editing/async-clipboard/clipboard-item-get-type-basic-expected.txt: Added.
- editing/async-clipboard/clipboard-item-get-type-basic.html: Added.
Add a layout test to verify that after writing multiple types to the clipboard using the DataTransfer API, we
should be able to read them back using the async clipboard API, as a single ClipboardItem, and also get data out
of the clipboard item using ClipboardItem.getType.
- editing/async-clipboard/resources/async-clipboard-helpers.js:
- platform/win/TestExpectations:
- resources/ui-helper.js:
(window.UIHelper.async.copyText):
(window.UIHelper):
- 1:09 PM Changeset in webkit [251376] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: replace all uses of
window.*Agentwith a target-specific call
https://bugs.webkit.org/show_bug.cgi?id=201149
Reviewed by Matt Baker.
Most of these were changed in r251227, but a few appear to have slipped through the cracks.
- UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager.prototype.debuggerDidResume):
- UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype._createTypeTokenAnnotator):
(WI.SourceCodeTextEditor.prototype._createBasicBlockAnnotator):
- 1:00 PM Changeset in webkit [251375] by
-
- 4 edits in trunk/LayoutTests
scrollingcoordinator/ios/ui-scrolling-tree.html is a Flaky Failure on iPad
https://bugs.webkit.org/show_bug.cgi?id=203119
rdar://problem/52970947
Reviewed by Wenson Hsieh.
iPad viewport heuristics (WebPage::immediatelyShrinkToFitContent()) run on a zero-delay
timer after page load, which races with this test getting the UI-side scrolling tree
and makes the test flakey.
Fix by turning off the heuristics with "contentMode=mobile". Also fix the test
to use UIHelper to get the scrolling tree.
- platform/ipad/TestExpectations:
- platform/ipad/scrollingcoordinator/ios/ui-scrolling-tree-expected.txt:
- scrollingcoordinator/ios/ui-scrolling-tree.html:
- 12:34 PM Changeset in webkit [251374] by
-
- 8 edits in trunk/Tools
Python 3: Add support in webkitpy.common.net
https://bugs.webkit.org/show_bug.cgi?id=202464
Reviewed by Dewei Zhu.
- Scripts/test-webkitpy-python3: Add webkitpy.common.net.
- Scripts/webkitpy/common/net/credentials_unittest.py: Replace raw_input with input for Python3.
- Scripts/webkitpy/common/net/ewsserver.py:
- Scripts/webkitpy/common/net/resultsjsonparser.py:
(ParsedJSONResults.init): Sort results by test name.
- Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
(test_basic): Sort results by test name.
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer._fetch_url):
- Scripts/webkitpy/common/net/unittestresults_unittest.py:
- 12:25 PM Changeset in webkit [251373] by
-
- 3 edits in trunk/Source/JavaScriptCore
[WinCairo][PlayStation] Add automation support for RemoteInspector SocketServer implementation.
https://bugs.webkit.org/show_bug.cgi?id=199070
Reviewed by Ross Kirsling.
Added handler for StartAutomationSession event from WebDriver and preparing for automation session.
- inspector/remote/RemoteInspector.h:
- inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::listingForAutomationTarget const):
(Inspector::RemoteInspector::sendAutomaticInspectionCandidateMessage):
(Inspector::RemoteInspector::requestAutomationSession):
(Inspector::RemoteInspector::dispatchMap):
(Inspector::RemoteInspector::startAutomationSession):
- 12:15 PM Changeset in webkit [251372] by
-
- 5 edits in trunk/Source
Remove all uses of untagCodePtr in debugging code.
https://bugs.webkit.org/show_bug.cgi?id=203188
<rdar://problem/56453043>
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- runtime/JSCPtrTag.cpp:
(JSC::tagForPtr):
Source/WTF:
We want the ability to always assert on failure to authenticate in untagCodePtr
(though we don't currently do that yet).
- wtf/PtrTag.cpp:
(WTF::tagForPtr):
- wtf/PtrTag.h:
(WTF::retagCodePtrImpl):
(WTF::tagCFunctionPtrImpl):
(WTF::untagCFunctionPtrImpl):
(WTF::assertIsCFunctionPtr):
(WTF::isTaggedWith):
- 12:06 PM Changeset in webkit [251371] by
-
- 3 edits1 add in trunk
Post increment/decrement should only call ToNumber once
https://bugs.webkit.org/show_bug.cgi?id=202711
Reviewed by Saam Barati.
JSTests:
- stress/postinc-custom-valueOf.js: Added.
(postInc):
(postDec):
Source/JavaScriptCore:
The problem is that we first called ToNumber on the object being incremented (to have the result that we'll eventually return), but we then do emitIncOrDec on the original object, which can call ToNumber again.
Instead we must do the ToNumber once, then copy its result, emitIncOrDec on the copy, put the copy back in the original location, and finally return the old value.
Since the result of ToNumber is guaranteed not to be an object, emitIncOrDec won't call ToNumber a second time.
- bytecompiler/NodesCodegen.cpp:
(JSC::emitPostIncOrDec):
- 11:59 AM Changeset in webkit [251370] by
-
- 3 edits in trunk/Source/WebKit
Add more release logging for "Unexpectedly resumed" assertion
https://bugs.webkit.org/show_bug.cgi?id=203196
Reviewed by Geoffrey Garen.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::processDidResume):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::processTaskStateDidChange):
- 11:59 AM Changeset in webkit [251369] by
-
- 11 edits2 adds in trunk
[iOS WK2] Support hiding iframe scrollbars via ::-webkit-scrollbar style
https://bugs.webkit.org/show_bug.cgi?id=203178
Reviewed by Dean Jackson.
Source/WebCore:
::-webkit-scrollbar {
display: none;
}
is supported for overflow:scroll, but not for iframes. To make the latter work,
two fixes were necessary.
First, FrameView had to implement horizontalScrollbarHiddenByStyle()/verticalScrollbarHiddenByStyle().
This is a little tricky on iOS because we never create RenderScrollbars, so we have to consult
pseudo-styles directly; a bit of refactoring makes that cleaner.
Second, ScrollableAreaParameters was failing to check horizontalScrollbarHiddenByStyle/verticalScrollbarHiddenByStyle
in operator==, meaning that these data often didn't make it to the UI process.
Test: fast/scrolling/ios/scrollbar-hiding-iframes.html
- page/FrameView.cpp:
(WebCore::FrameView::rootElementForCustomScrollbarPartStyle const):
(WebCore::FrameView::createScrollbar):
(WebCore::FrameView::styleHidesScrollbarWithOrientation const):
(WebCore::FrameView::horizontalScrollbarHiddenByStyle const):
(WebCore::FrameView::verticalScrollbarHiddenByStyle const):
(WebCore::FrameView::updateScrollCorner):
- page/FrameView.h:
- page/scrolling/ScrollingCoordinatorTypes.h:
(WebCore::ScrollableAreaParameters::operator== const):
- platform/Scrollbar.h:
(WebCore::Scrollbar::isHiddenByStyle const):
- rendering/RenderLayer.cpp:
(WebCore::scrollbarHiddenByStyle):
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::getScrollbarPseudoStyle const):
(WebCore::RenderScrollbar::isHiddenByStyle const):
(WebCore::RenderScrollbar::getScrollbarPseudoStyle): Deleted.
- rendering/RenderScrollbar.h:
LayoutTests:
Tests that dumps the scrolling tree.
- fast/scrolling/ios/scrollbar-hiding-iframes-expected.txt: Added.
- fast/scrolling/ios/scrollbar-hiding-iframes.html: Added.
- 11:34 AM Changeset in webkit [251368] by
-
- 5 edits1 add in trunk/Tools
EWS should have a way to retry a patch
https://bugs.webkit.org/show_bug.cgi?id=196599
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-app/ews/models/build.py:
(Build): Add the retried field to keep track of whether a build is requested to be retried or not.
(Build.set_retried): Method to set the retried field.
- BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Added the 'Retry failed builds' button.
- BuildSlaveSupport/ews-app/ews/views/retrypatch.py:
(RetryPatch.post): Added a check if the build is already retried. Also, set the retried flag appropriately.
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Updated the status-bubble to in-progress while waiting for build to be retried.
(StatusBubble._build_bubbles_for_patch): Display the retry button only if there are failed builds.
- BuildSlaveSupport/ews-app/ews/migrations/0002_build_retried.py: Added database migration.
- 11:15 AM UsingGitWithWebKit edited by
- Update to use HTTPS URL for svn repository. (diff)
- 9:29 AM Changeset in webkit [251367] by
-
- 11 edits4 adds2 deletes in trunk
Share code between AudioDestinationIOS and AudioDestinationMac
https://bugs.webkit.org/show_bug.cgi?id=203047
<rdar://problem/56340866>
Reviewed by Eric Carlson.
Source/WebCore:
Introduce AudioDestinationCocoa to share code between iOS and Mac.
Most code is now shared, except for the configuration of the audio unit which is slightly different between Mac and iOS.
Introduce MockAudioDestinationCocoa to allow more code coverage of the shared code.
This could also allow us to validate dynamic changes in frame rate, number of frames to process...
Add Internals API to enable the mock destination.
Covered by added test.
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/audio/cocoa/AudioDestinationCocoa.cpp: Added.
(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestination::maxChannelCount):
(WebCore::AudioDestinationCocoa::AudioDestinationCocoa):
(WebCore::AudioDestinationCocoa::~AudioDestinationCocoa):
(WebCore::AudioDestinationCocoa::start):
(WebCore::AudioDestinationCocoa::stop):
(WebCore::AudioDestinationCocoa::setIsPlaying):
(WebCore::AudioDestinationCocoa::setAudioStreamBasicDescription):
(WebCore::assignAudioBuffersToBus):
(WebCore::AudioDestinationCocoa::render):
(WebCore::AudioDestinationCocoa::inputProc):
- platform/audio/cocoa/AudioDestinationCocoa.h: Added.
(WebCore::AudioDestinationCocoa::outputUnit):
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationCocoa::configure):
(WebCore::AudioDestinationCocoa::processBusAfterRender):
- platform/audio/ios/AudioDestinationIOS.h: Removed.
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestinationCocoa::configure):
(WebCore::AudioDestinationCocoa::processBusAfterRender):
- platform/audio/mac/AudioDestinationMac.h: Removed.
- platform/mock/MockAudioDestinationCocoa.cpp: Added.
(WebCore::MockAudioDestinationCocoa::MockAudioDestinationCocoa):
(WebCore::MockAudioDestinationCocoa::start):
(WebCore::MockAudioDestinationCocoa::stop):
(WebCore::MockAudioDestinationCocoa::tick):
- platform/mock/MockAudioDestinationCocoa.h: Added.
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::useMockAudioDestinationCocoa):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- fast/mediastream/getUserMedia-webaudio-expected.txt:
- fast/mediastream/getUserMedia-webaudio.html:
- 8:17 AM Changeset in webkit [251366] by
-
- 13 edits3 adds in trunk
XMLHttpRequest should not prevent entering the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203107
<rdar://problem/56438647>
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Rebaseline a new WPT tests that are passing now that we properly check that the
Document is fully active in open().
- web-platform-tests/xhr/open-url-multi-window-2-expected.txt:
- web-platform-tests/xhr/open-url-multi-window-5-expected.txt:
- web-platform-tests/xhr/open-url-multi-window-6-expected.txt:
Source/WebCore:
Improve XMLHttpRequest for back/forward cache suspension:
- We no longer cancel pending loads in the suspend() method as this may fire events.
- Simplify XMLHttpRequestProgressEventThrottle to use SuspendableTimers to dispatch events that are deferred by suspension or throttling.
Test: http/tests/navigation/page-cache-xhr-in-loading-iframe.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::open):
Add check to throw a InvalidStateError if the associated document is not fully active,
as per https://xhr.spec.whatwg.org/#dom-xmlhttprequest-open (Step 2). This avoids
dispatching events after ActiveDOMObject::stop() has been called and brings a few more
passes on WPT tests.
(WebCore::XMLHttpRequest::dispatchEvent):
(WebCore::XMLHttpRequest::suspend):
(WebCore::XMLHttpRequest::resume):
(WebCore::XMLHttpRequest::shouldPreventEnteringBackForwardCache_DEPRECATED const): Deleted.
(WebCore::XMLHttpRequest::resumeTimerFired): Deleted.
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchReadyStateChangeEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEventWhenPossible):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEventsAfterResuming):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEventTimerFired):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):
(WebCore::XMLHttpRequestProgressEventThrottle::resume):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent): Deleted.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents): Deleted.
(WebCore::XMLHttpRequestProgressEventThrottle::fired): Deleted.
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch const): Deleted.
- xml/XMLHttpRequestProgressEventThrottle.h:
LayoutTests:
Add more test coverage.
- TestExpectations:
- fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html:
- http/tests/navigation/page-cache-xhr-in-loading-iframe-expected.txt: Added.
- http/tests/navigation/page-cache-xhr-in-loading-iframe.html: Added.
- http/tests/navigation/resources/page-cache-xhr-in-loading-iframe.html: Added.
- 6:28 AM Changeset in webkit [251365] by
-
- 27 edits1 copy2 adds in trunk
[MSE][GStreamer] Revert WebKitMediaSrc rework temporarily
https://bugs.webkit.org/show_bug.cgi?id=203078
Reviewed by Carlos Garcia Campos.
.:
- Source/cmake/GStreamerChecks.cmake:
Source/WebCore:
While the WebKitMediaSrc rework fixed a number of tests and introduced
design improvements in MSE, it also exposed a number of bugs related
to the playbin3 switch.
Fixing these has been turned tricky, so in order to not keep known
user-facing bugs, I'm reverting it for now until a workable solution
is available.
- platform/GStreamer.cmake:
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::refGPtr<GstMiniObject>): Deleted.
(WTF::derefGPtr<GstMiniObject>): Deleted.
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition const):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::paused const):
(WebCore::MediaPlayerPrivateGStreamer::updateTracks):
(WebCore::MediaPlayerPrivateGStreamer::enableTrack):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::videoSinkCapsChangedCallback):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideoCaps):
(WebCore::MediaPlayerPrivateGStreamer::sourceSetup):
(WebCore::MediaPlayerPrivateGStreamer::handleSyncMessage):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::configurePlaySink):
(WebCore::MediaPlayerPrivateGStreamer::invalidateCachedPosition): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize const):
(WebCore::MediaPlayerPrivateGStreamerBase::sizeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSizeFromCaps const): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::doSamplesHaveDifferentNaturalSizes const): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
- platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink):
- platform/graphics/gstreamer/mse/AppendPipeline.h:
(WebCore::AppendPipeline::appsinkCaps):
(WebCore::AppendPipeline::track):
(WebCore::AppendPipeline::streamType):
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::~MediaPlayerPrivateGStreamerMSE):
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::MediaPlayerPrivateGStreamerMSE::pause):
(WebCore::MediaPlayerPrivateGStreamerMSE::seek):
(WebCore::MediaPlayerPrivateGStreamerMSE::configurePlaySink):
(WebCore::MediaPlayerPrivateGStreamerMSE::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamerMSE::notifySeekNeedsDataForTime):
(WebCore::MediaPlayerPrivateGStreamerMSE::doSeek):
(WebCore::MediaPlayerPrivateGStreamerMSE::maybeFinishSeek):
(WebCore::MediaPlayerPrivateGStreamerMSE::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamerMSE::seeking const):
(WebCore::MediaPlayerPrivateGStreamerMSE::setReadyState):
(WebCore::MediaPlayerPrivateGStreamerMSE::waitForSeekCompleted):
(WebCore::MediaPlayerPrivateGStreamerMSE::seekCompleted):
(WebCore::MediaPlayerPrivateGStreamerMSE::sourceSetup):
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):
(WebCore::MediaPlayerPrivateGStreamerMSE::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamerMSE::mediaSourceClient):
(WebCore::MediaPlayerPrivateGStreamerMSE::unblockDurationChanges):
(WebCore::MediaPlayerPrivateGStreamerMSE::durationChanged):
(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):
(WebCore::MediaPlayerPrivateGStreamerMSE::markEndOfStream):
(WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
(WebCore::MediaPlayerPrivateGStreamerMSE::play): Deleted.
(WebCore::MediaPlayerPrivateGStreamerMSE::reportSeekCompleted): Deleted.
(WebCore::MediaPlayerPrivateGStreamerMSE::didEnd): Deleted.
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
- platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:
(WebCore::MediaSourceClientGStreamerMSE::addSourceBuffer):
(WebCore::MediaSourceClientGStreamerMSE::markEndOfStream):
(WebCore::MediaSourceClientGStreamerMSE::removedFromMediaSource):
(WebCore::MediaSourceClientGStreamerMSE::flush):
(WebCore::MediaSourceClientGStreamerMSE::enqueueSample):
(WebCore::MediaSourceClientGStreamerMSE::allSamplesInTrackEnqueued):
(WebCore::MediaSourceClientGStreamerMSE::isReadyForMoreSamples): Deleted.
(WebCore::MediaSourceClientGStreamerMSE::notifyClientWhenReadyForMoreSamples): Deleted.
- platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:
- platform/graphics/gstreamer/mse/MediaSourceGStreamer.cpp:
(WebCore::MediaSourceGStreamer::markEndOfStream):
(WebCore::MediaSourceGStreamer::unmarkEndOfStream):
(WebCore::MediaSourceGStreamer::waitForSeekCompleted):
(WebCore::MediaSourceGStreamer::seekCompleted):
- platform/graphics/gstreamer/mse/MediaSourceGStreamer.h:
- platform/graphics/gstreamer/mse/PlaybackPipeline.cpp: Added.
(getStreamByTrackId):
(getStreamBySourceBufferPrivate):
(pushSample):
(WebCore::PlaybackPipeline::setWebKitMediaSrc):
(WebCore::PlaybackPipeline::webKitMediaSrc):
(WebCore::PlaybackPipeline::addSourceBuffer):
(WebCore::PlaybackPipeline::removeSourceBuffer):
(WebCore::PlaybackPipeline::attachTrack):
(WebCore::PlaybackPipeline::reattachTrack):
(WebCore::PlaybackPipeline::notifyDurationChanged):
(WebCore::PlaybackPipeline::markEndOfStream):
(WebCore::PlaybackPipeline::flush):
(WebCore::PlaybackPipeline::enqueueSample):
(WebCore::PlaybackPipeline::allSamplesInTrackEnqueued):
(WebCore::PlaybackPipeline::pipeline):
- platform/graphics/gstreamer/mse/PlaybackPipeline.h: Copied from Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h.
- platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::enqueueSample):
(WebCore::SourceBufferPrivateGStreamer::isReadyForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::setReadyForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::notifyReadyForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::notifyClientWhenReadyForMoreSamples):
- platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
- platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(disabledAppsrcNeedData):
(disabledAppsrcEnoughData):
(disabledAppsrcSeekData):
(enabledAppsrcEnoughData):
(enabledAppsrcSeekData):
(getStreamByAppsrc):
(webkitMediaSrcChain):
(webkit_media_src_init):
(webKitMediaSrcFinalize):
(webKitMediaSrcSetProperty):
(webKitMediaSrcGetProperty):
(webKitMediaSrcDoAsyncStart):
(webKitMediaSrcDoAsyncDone):
(webKitMediaSrcChangeState):
(webKitMediaSrcGetSize):
(webKitMediaSrcQueryWithParent):
(webKitMediaSrcUpdatePresentationSize):
(webKitMediaSrcLinkStreamToSrcPad):
(webKitMediaSrcLinkSourcePad):
(webKitMediaSrcFreeStream):
(webKitMediaSrcCheckAllTracksConfigured):
(webKitMediaSrcUriGetType):
(webKitMediaSrcGetProtocols):
(webKitMediaSrcGetUri):
(webKitMediaSrcSetUri):
(webKitMediaSrcUriHandlerInit):
(seekNeedsDataMainThread):
(notifyReadyForMoreSamplesMainThread):
(webKitMediaSrcSetMediaPlayerPrivate):
(webKitMediaSrcSetReadyForSamples):
(webKitMediaSrcPrepareSeek):
(WebKitMediaSrcPrivate::streamByName): Deleted.
(): Deleted.
(WTF::refGPtr<WebKitMediaSrcPad>): Deleted.
(WTF::derefGPtr<WebKitMediaSrcPad>): Deleted.
(webkit_media_src_pad_class_init): Deleted.
(Stream::Stream): Deleted.
(Stream::StreamingMembers::StreamingMembers): Deleted.
(Stream::StreamingMembers::durationEnqueued const): Deleted.
(findPipeline): Deleted.
(webkit_media_src_class_init): Deleted.
(debugProbe): Deleted.
(copyCollectionAndAddStream): Deleted.
(copyCollectionWithoutStream): Deleted.
(gstStreamType): Deleted.
(webKitMediaSrcAddStream): Deleted.
(webKitMediaSrcRemoveStream): Deleted.
(webKitMediaSrcActivateMode): Deleted.
(webKitMediaSrcPadLinked): Deleted.
(webKitMediaSrcStreamNotifyLowWaterLevel): Deleted.
(webKitMediaSrcLoop): Deleted.
(webKitMediaSrcEnqueueObject): Deleted.
(webKitMediaSrcEnqueueSample): Deleted.
(webKitMediaSrcEnqueueEvent): Deleted.
(webKitMediaSrcEndOfStream): Deleted.
(webKitMediaSrcIsReadyForMoreSamples): Deleted.
(webKitMediaSrcNotifyWhenReadyForMoreSamples): Deleted.
(webKitMediaSrcStreamFlushStart): Deleted.
(webKitMediaSrcStreamFlushStop): Deleted.
(webKitMediaSrcFlush): Deleted.
(webKitMediaSrcSeek): Deleted.
(countStreamsOfType): Deleted.
- platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.h:
- platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h: Added.
Tools:
- Scripts/webkitpy/style/checker.py:
LayoutTests:
- platform/gtk/TestExpectations:
- 2:53 AM Changeset in webkit [251364] by
-
- 2 edits in trunk/Tools
Unreviewed. Mark some more WTF unit tests as slow for GTK and WPE
- TestWebKitAPI/glib/TestExpectations.json:
- 2:30 AM Changeset in webkit [251363] by
-
- 2 edits in trunk/Source/WebKit
[GTK] Objects category in emoji picker is empty
https://bugs.webkit.org/show_bug.cgi?id=203189
Reviewed by Adrian Perez de Castro.
There's a typo in the first emopi name of objects section.
- UIProcess/API/gtk/WebKitEmojiChooser.cpp:
(webkitEmojiChooserSetupEmojiSections): uted speaker -> muted speaker
- 2:21 AM Changeset in webkit [251362] by
-
- 3 edits in trunk/Source/WebKit
[GTK][WPE] IconDatabase is not thread safe yet
https://bugs.webkit.org/show_bug.cgi?id=202980
Reviewed by Adrian Perez de Castro.
Current implementation is safer, but we still need to protect members used by both threads.
- UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::populatePageURLToIconURLMap):
(WebKit::IconDatabase::clearLoadedIconsTimerFired):
(WebKit::IconDatabase::checkIconURLAndSetPageURLIfNeeded):
(WebKit::IconDatabase::loadIconForPageURL):
(WebKit::IconDatabase::iconURLForPageURL):
(WebKit::IconDatabase::setIconForPageURL):
(WebKit::IconDatabase::clear):
- UIProcess/API/glib/IconDatabase.h:
- 1:25 AM Changeset in webkit [251361] by
-
- 43 edits in trunk/Source
Clean up some includes to improve WebKit2 build speed
https://bugs.webkit.org/show_bug.cgi?id=203071
Reviewed by Wenson Hsieh.
Source/WebCore:
No new tests, just shuffling code around.
- bindings/js/WindowProxy.cpp:
(WebCore::WindowProxy::WindowProxy):
(WebCore::WindowProxy::~WindowProxy):
(WebCore::WindowProxy::detachFromFrame):
(WebCore::WindowProxy::destroyJSWindowProxy):
(WebCore::WindowProxy::createJSWindowProxy):
(WebCore::WindowProxy::jsWindowProxiesAsVector const):
(WebCore::WindowProxy::clearJSWindowProxiesNotMatchingDOMWindow):
(WebCore::WindowProxy::setDOMWindow):
(WebCore::WindowProxy::attachDebugger):
(WebCore::WindowProxy::jsWindowProxies const):
(WebCore::WindowProxy::releaseJSWindowProxies):
(WebCore::WindowProxy::setJSWindowProxies):
- bindings/js/WindowProxy.h:
(WebCore::WindowProxy::existingJSWindowProxy const):
(WebCore::WindowProxy::jsWindowProxies const): Deleted.
(WebCore::WindowProxy::releaseJSWindowProxies): Deleted.
(WebCore::WindowProxy::setJSWindowProxies): Deleted.
- platform/graphics/cocoa/IOSurface.h:
- platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::~IOSurface):
Source/WebKit:
This is worth about 6% on WebKit2, and unlocks another 8% improvement
down the line (but which is less mechanical).
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkSocketChannel.h:
- NetworkProcess/WebStorage/StorageArea.h:
- NetworkProcess/WebStorage/StorageManager.cpp:
- NetworkProcess/WebStorage/StorageManagerSet.cpp:
- Platform/IPC/Connection.h:
- Shared/API/APIURL.h:
- Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- UIProcess/API/APIAttachment.h:
- UIProcess/API/Cocoa/_WKInspector.mm:
- UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h:
- UIProcess/TextCheckerCompletion.cpp:
- UIProcess/TextCheckerCompletion.h:
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::addNetworkProcess):
(WebKit::WebUserContentControllerProxy::removeNetworkProcess):
- UIProcess/UserContent/WebUserContentControllerProxy.h:
(WebKit::WebUserContentControllerProxy::addNetworkProcess): Deleted.
(WebKit::WebUserContentControllerProxy::removeNetworkProcess): Deleted.
- WebProcess/Automation/WebAutomationSessionProxy.h:
- WebProcess/Network/NetworkProcessConnection.cpp:
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- WebProcess/Plugins/Plugin.cpp:
- WebProcess/Plugins/Plugin.h:
- WebProcess/WebProcess.cpp:
- 12:16 AM Changeset in webkit [251360] by
-
- 2 edits in trunk/Tools
[GTK][WPE] Check we don't leak the WebKitWebContext in all tests
https://bugs.webkit.org/show_bug.cgi?id=202981
Reviewed by Žan Doberšek.
Also include the number of references left in leaks report.
- TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::Test):
(Test::~Test):
- 12:16 AM Changeset in webkit [251359] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Unreviewed. Fix build warning: unused parameter ‘Foo’ [-Wunused-parameter] since r251320.
Patch by Joonghun Park <jh718.park@samsung.com> on 2019-10-21
- dom/Element.cpp:
(WebCore::shouldIgnoreMouseEvent):
Oct 20, 2019:
- 6:55 PM Changeset in webkit [251358] by
-
- 4 edits1 copy in trunk/Source/WebKit
Improve serialization logic
https://bugs.webkit.org/show_bug.cgi?id=203039
<rdar://problem/55631691>
Reviewed by Alex Christensen.
Check that the SecItemRequestData only contains relevant types for
CFNetwork uses.
- Platform/spi/Cocoa/SecItemSPI.h: Added.
- Shared/mac/SecItemRequestData.cpp:
(WebKit::arrayContainsInvalidType): Added.
(WebKit::dictionaryContainsInvalidType): Added.
(WebKit::validTypeIDs): Added.
(WebKit::isValidType): Added.
(WebKit::SecItemRequestData::decode): Check types during decode.
- Shared/mac/SecItemRequestData.h:
- WebKit.xcodeproj/project.pbxproj:
- 6:44 PM Changeset in webkit [251357] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, drop debug logging that was inadvertently committed with r251327.
- history/BackForwardCache.cpp:
- 5:44 PM Changeset in webkit [251356] by
-
- 3 edits in branches/safari-608-branch/Source/WebCore
Cherry-pick r251188. rdar://problem/56340816
WebAudioSourceProviderAVFObjC::provideInput should set its WebAudioBufferList parameters correctly
https://bugs.webkit.org/show_bug.cgi?id=202930
<rdar://problem/56006776>
Reviewed by Eric Carlson.
Source/WebCore:
There is a time where the bus channel number and audio source channel numbers may be different.
In case the bus channel number is less than the audio source channel number, initialization of
the WebAudioBufferList might not be fully done.
In that case, output silence and return early.
Reduce the number of frames to process based on the number of frames the output audio bus plans to process.
Partially covered by new API test (this a race so we cannot reproduce the crash easily).
- Modules/webaudio/MediaStreamAudioSourceNode.cpp: (WebCore::MediaStreamAudioSourceNode::process): Make sure to process the number of frames the output bus expect.
- platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm: (WebCore::WebAudioSourceProviderAVFObjC::provideInput):
Tools:
Add a test that has an audio track that goes from 1 to 2 channels while being piped to a WebAudio pipeline.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: (-[GUMMessageHandler userContentController:didReceiveScriptMessage:]): (TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit/getUserMedia-webaudio.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:44 PM Changeset in webkit [251355] by
-
- 2 edits in branches/safari-608-branch/Source/WebKit
Cherry-pick r250773. rdar://problem/56271900
WebPageProxy::updatePlayingMediaDidChange should protect from a null m_userMediaPermissionRequestManager
https://bugs.webkit.org/show_bug.cgi?id=202628
<rdar://problem/55935091>
Reviewed by Eric Carlson.
On process swap on navigation or process crash, m_userMediaPermissionRequestManager is made null.
At the same time, the media state is set back to not playing.
Future calls of updatePlayingMediaDidChange should not have any capture state change until getUserMedia/getDisplayMedia
is called, which would create m_userMediaPermissionRequestManager.
But this assumption is not always true given that the media state is computed as process-wide in MediaStreamTrack::captureState on iOS.
The above behavior is fixed as part of https://bugs.webkit.org/show_bug.cgi?id=202627.
Since the call to updatePlayingMediaDidChange is triggered straight from IPC, it should not be trusted and a null check should be added.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updatePlayingMediaDidChange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:44 PM Changeset in webkit [251354] by
-
- 5 edits1 add in branches/safari-608-branch
Cherry-pick r249538. rdar://problem/56426429
LazyClassStructure::setConstructor should not store the constructor to the global object
https://bugs.webkit.org/show_bug.cgi?id=201484
<rdar://problem/50400451>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/web-assembly-constructors-should-not-override-global-object-property.js: Added.
Source/JavaScriptCore:
LazyClassStructure::setConstructor sets the constructor as a property of the global object.
This became a problem when it started being used for WebAssembly constructors, such as Module
and Instance, since they are properties of the WebAssembly object, not the global object. That
resulted in properties of the global object replaced whenever a lazy WebAssembly constructor
was first accessed. e.g.
globalThis.Module = x;
WebAssembly.Module;
globalThis.Module === WebAssembly.Module;
- runtime/LazyClassStructure.cpp: (JSC::LazyClassStructure::Initializer::setConstructor):
- runtime/LazyClassStructure.h:
- runtime/Lookup.h: (JSC::reifyStaticProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:40 PM Changeset in webkit [251353] by
-
- 37 edits2 adds in branches/safari-608-branch
Apply patch. rdar://problem/56427498
- 4:24 PM Changeset in webkit [251352] by
-
- 1 edit in branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h
Apply patch. rdar://problem/55954224
- 10:33 AM Changeset in webkit [251351] by
-
- 1 edit in branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
Unreviewed build fix. rdar://problem/55927251
- 10:33 AM Changeset in webkit [251350] by
-
- 16 edits2 copies1 move3 adds in branches/safari-608-branch
Cherry-pick r250589. rdar://problem/55927251
Storage Access API: document.hasStorageAccess() should return true when the cookie policy allows access
https://bugs.webkit.org/show_bug.cgi?id=202435
<rdar://problem/55718526>
Reviewed by Brent Fulgham.
Source/WebCore:
WebKit's Storage Access API implementation has so far only looked at whether ITP is
blocking cookie access or not. However, the default cookie policy is still in
effect underneath ITP. document.hasStorageAccess() should return true if the
third-party:
a) is not classified by ITP, and
b) has cookies which implies it can use cookies as third-party according to the
default cookie policy.
Tests: http/tests/storageAccess/has-storage-access-false-by-default-ephemeral.html
http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral.html
http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies.html
- platform/network/NetworkStorageSession.h:
- platform/network/cocoa/NetworkStorageSessionCocoa.mm: (WebCore::NetworkStorageSession::hasCookies const):
- platform/network/curl/NetworkStorageSessionCurl.cpp: (WebCore::NetworkStorageSession::hasCookies const):
Not yet implemented. Always says false.
- platform/network/soup/NetworkStorageSessionSoup.cpp: (WebCore::NetworkStorageSession::hasCookies const):
Not yet implemented. Always says false.
Source/WebKit:
WebKit's Storage Access API implementation has so far only looked at whether ITP is
blocking cookie access or not. However, the default cookie policy is still in
effect underneath ITP. document.hasStorageAccess() should return true if the
third-party:
a) is not classified by ITP, and
b) has cookies which implies it can use cookies as third-party according to the
default cookie policy.
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp: (WebKit::ResourceLoadStatisticsMemoryStore::hasStorageAccess):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::hasCookies):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::hasStorageAccess):
- NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
Tools:
This change makes sure topPrivatelyControlledDomain() correctly handles domains
with leading dots, as often used in cookie domains.
- TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: (TestWebKitAPI::TEST_F):
LayoutTests:
WebKit's Storage Access API implementation has so far only looked at whether ITP is
blocking cookie access or not. However, the default cookie policy is still in
effect underneath ITP. document.hasStorageAccess() should return true if the
third-party:
a) is not classified by ITP, and
b) has cookies which implies it can use cookies as third-party according to the
default cookie policy.
- http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-expected.txt: Added.
- http/tests/storageAccess/has-storage-access-false-by-default-ephemeral.html: Copied from LayoutTests/http/tests/storageAccess/has-storage-access-true-if-feature-off.html.
- http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral-expected.txt: Added.
- http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral.html: Copied from LayoutTests/http/tests/storageAccess/has-storage-access-true-if-feature-off.html.
- http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-expected.txt: Added.
- http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies.html: Renamed from LayoutTests/http/tests/storageAccess/has-storage-access-true-if-feature-off.html.
- platform/ios/TestExpectations:
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:33 AM Changeset in webkit [251349] by
-
- 8 edits2 copies2 adds in branches/safari-608-branch
Cherry-pick r251086. rdar://problem/56237429
[Cocoa] REGRESSION (r245672): Contenteditable with optical sizing freezes Safari
https://bugs.webkit.org/show_bug.cgi?id=202262
Reviewed by Tim Horton.
Source/WebKit:
r250640 didn't go far enough. We need to apply the same fix everywhere [NSFontDescriptor fontDescriptorWithFontAttributes:] is called.
- Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::decodeFontInternal):
- Shared/Cocoa/CoreTextHelpers.h: Added.
- Shared/Cocoa/CoreTextHelpers.mm: Added. (fontDescriptorWithFontAttributes):
- SourcesCocoa.txt:
- UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::updateFontManagerIfNeeded):
- UIProcess/mac/WebPopupMenuProxyMac.mm: (WebKit::WebPopupMenuProxyMac::showPopupMenu):
- WebKit.xcodeproj/project.pbxproj:
LayoutTests:
- fast/forms/contenteditable-font-optical-size-expected.txt: Added.
- fast/forms/contenteditable-font-optical-size.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:33 AM Changeset in webkit [251348] by
-
- 12 edits in branches/safari-608-branch
Cherry-pick r250887. rdar://problem/56061121
Partially undo r250811
https://bugs.webkit.org/show_bug.cgi?id=202715
<rdar://problem/56084287>
Reviewed by Chris Dumez.
Source/WebCore:
This patch changes the SerializedScriptValue to always wrap CryptoKey objects again.
CryptoKey objects could belong to an array or another object. In those cases, IDBObjectStore
cannot set the flag for the embedded Cryptokey objects. Neither can postMessage to unset
the flag. Therefore, there is no way to separate the serialization process into two and
this patch restores the old behaviour. However, the hardening part of r250811 is kept
and therefore the crash should still be prevented.
No new test, updated existing test
- Modules/indexeddb/IDBObjectStore.cpp: (WebCore::IDBObjectStore::putOrAdd): (WebCore::JSC::setIsWrappingRequiredForCryptoKey): Deleted.
- bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
- crypto/CryptoKey.h: (WebCore::CryptoKey::allows const): (WebCore::CryptoKey::isWrappingRequired const): Deleted. (WebCore::CryptoKey::setIsWrappingRequired): Deleted. (): Deleted.
- dom/ScriptExecutionContext.h:
Tools:
- TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html: Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.
LayoutTests:
Some rebaselines.
- crypto/workers/subtle/ec-postMessage-worker-expected.txt:
- crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
- crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:33 AM Changeset in webkit [251347] by
-
- 3 edits in branches/safari-608-branch/LayoutTests
Cherry-pick r250844. rdar://problem/56061121
Unreviewed, test gardening
- TestExpectations:
- platform/ios-simulator/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:33 AM Changeset in webkit [251346] by
-
- 3 edits2 adds in branches/safari-608-branch
Cherry-pick r250929. rdar://problem/56280990
RunResolver::rangeForRendererWithOffsets should check for range end
https://bugs.webkit.org/show_bug.cgi?id=202761
<rdar://problem/55917924>
Reviewed by Antti Koivisto.
Source/WebCore:
This patch ensures that when rangeForRenderer comes back with a collapsed run (empty range), rangeForRendererWithOffsets returns an empty range as well.
Test: fast/text/simple-line-layout-range-check-end.html
- rendering/SimpleLineLayoutResolver.cpp: (WebCore::SimpleLineLayout::RunResolver::rangeForRendererWithOffsets const):
LayoutTests:
- fast/text/simple-line-layout-range-check-end-expected.txt: Added.
- fast/text/simple-line-layout-range-check-end.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:33 AM Changeset in webkit [251345] by
-
- 5 edits in branches/safari-608-branch
Cherry-pick r250833. rdar://problem/56280706
Apply patch. rdar://problem/55920073
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-608.3.10.1-branch@250833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:33 AM Changeset in webkit [251344] by
-
- 23 edits3 adds in branches/safari-608-branch
Cherry-pick r250811. rdar://problem/56061121
Only wrapping CryptoKeys for IDB during serialization
https://bugs.webkit.org/show_bug.cgi?id=202500
<rdar://problem/52445927>
Reviewed by Chris Dumez.
Source/WebCore:
Wrapping CryptoKeys during IDB serialization is a legacy request from Netflix when WebKit was an
early adopter. It is not necessary for other kinds of serialization. However, given existing keys
stored in users' idb are wrapped, the wrapping/unwrapping mechanism cannot be easily discarded.
Therefore, this patch restricts the wrapping/unwrapping mechanism to idb only.
To do so, a isWrappingRequired flag is added to CryptoKey such that whenever idb sees a CryptoKey,
it can set it. SerializedScriptValue will then only wrap a CryptoKey when this flag is set. Otherwise,
a new tag UnwrappedCryptoKeyTag is used to store unwrapped CryptoKeys in order to keep the old CryptoKeyTag
binaries intact. For deserialization, each type will be deserialized differently.
Besides the above, this patch also hardens WorkerGlobalScope::wrapCryptoKey/unwrapCryptoKey for
any potential racy issues. CryptoBooleanContainer is introduced to capture boolean in the lambda.
workerGlobalScope is replaced with workerMessagingProxy. Now, every variables captured in the lambdas
should be either a copy or a thread safe ref of the original object.
Test: crypto/workers/subtle/aes-indexeddb.html
- Modules/indexeddb/IDBObjectStore.cpp: (WebCore::JSC::setIsWrappingRequiredForCryptoKey): (WebCore::IDBObjectStore::putOrAdd):
- bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
- crypto/CryptoKey.h: (WebCore::CryptoKey::isWrappingRequired const): (WebCore::CryptoKey::setIsWrappingRequired):
- dom/ScriptExecutionContext.h:
- workers/WorkerGlobalScope.cpp: (WebCore::CryptoBooleanContainer::create): (WebCore::CryptoBooleanContainer::boolean const): (WebCore::CryptoBooleanContainer::setBoolean): (WebCore::WorkerGlobalScope::wrapCryptoKey): (WebCore::WorkerGlobalScope::unwrapCryptoKey):
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h: (WebCore::WorkerLoaderProxy::isWorkerMessagingProxy const):
- workers/WorkerMessagingProxy.h: (isType):
Tools:
Modifies IndexedDB.StructuredCloneBackwardCompatibility test to include CryptoKeys.
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: (-[StructuredCloneBackwardCompatibilityNavigationDelegate _webCryptoMasterKeyForWebView:]): (TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3:
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm:
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal:
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html:
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html:
LayoutTests:
Adds a new test aes-indexeddb.html to do idb in workers and makes
other tests more deterministic.
- crypto/workers/subtle/aes-indexeddb-expected.txt: Added.
- crypto/workers/subtle/aes-indexeddb.html: Added.
- crypto/workers/subtle/ec-postMessage-worker-expected.txt:
- crypto/workers/subtle/ec-postMessage-worker.html:
- crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
- crypto/workers/subtle/hrsa-postMessage-worker.html:
- crypto/workers/subtle/resources/aes-indexeddb.js: Added.
- crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
- crypto/workers/subtle/rsa-postMessage-worker.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:33 AM Changeset in webkit [251343] by
-
- 11 edits in branches/safari-608-branch/Source/WebKit
Cherry-pick r250780. rdar://problem/56061126
Provide options for DTTZ to happen in more situations
https://bugs.webkit.org/show_bug.cgi?id=202634
<rdar://problem/55732762>
Reviewed by Antoine Quint.
Add two options that can be enabled to trigger double tap zooming
in more places.
Firstly, an option to keep listening for a double-tap-to-zoom if the
first tap found a click handler on the body or document element. The
tap will still be dispatched. This is probably the most common case
for disabling a DTTZ.
Secondly, an option to always keep listening for a double-tap-to-zoom,
even if there was a clickable (non-root) element under the first tap.
- Shared/WebPreferences.yaml: Add ZoomOnDoubleTapWhenRoot and AlwaysZoomOnDoubleTap.
- UIProcess/PageClient.h: The message from the WebProcess now tells the UIProcess if the tapped element was a root-level (document or body).
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::handleSmartMagnificationInformationForPotentialTap):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]): (-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:nodeIsRootLevel:]): Handle the two new options.
- UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::handleSmartMagnificationInformationForPotentialTap):
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::potentialTapAtPosition): Check if the tap was on a root-level element.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:33 AM Changeset in webkit [251342] by
-
- 6 edits in branches/safari-608-branch/Source/WebKit
Cherry-pick r250755. rdar://problem/56061126
Use a better name than allowFastClicksEverywhere
https://bugs.webkit.org/show_bug.cgi?id=202607
<rdar://problem/55997133>
Reviewed by Tim Horton.
This preference name is quite confusing. Change it to
PreferFasterClickOverDoubleTap.
- Shared/WebPreferences.yaml:
- Shared/WebPreferencesDefaultValues.h:
- UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::preferFasterClickOverDoubleTap const): (WebKit::WebPageProxy::allowsFastClicksEverywhere const): Deleted.
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:]):
- UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:33 AM Changeset in webkit [251341] by
-
- 3 edits in branches/safari-608-branch/Source/WebKit
Cherry-pick r250751. rdar://problem/56280731
Unreviewed, build fix after r250729
- UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
- UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:33 AM Changeset in webkit [251340] by
-
- 24 edits6 copies2 adds in branches/safari-608-branch
Cherry-pick r250729. rdar://problem/56280731
[WebAuthn] Implement _WKWebAuthenticationPanel SPI
https://bugs.webkit.org/show_bug.cgi?id=202559
<rdar://problem/55932094>
Reviewed by Brent Fulgham.
Source/WebKit:
This patch implements _WKWebAuthenticationPanel SPI. Here is the structure:
1) API::WebAuthenticationPanel is the APIObject of _WKWebAuthenticationPanel. It is owned by AuthenticatorManager.
The lifetime of _WKWebAuthenticationPanel on the other hand is managed by clients. This binding is the surface
where clients could interact with WebKit's WebAuthentication implementation.
2) API::WebAuthenticationPanelClient is a base class representing _WKWebAuthenticationPanelDelegate. Its subclass
WebKit::WebAuthenticationPanelClient implements bridges to _WKWebAuthenticationPanelDelegate methods. It is owned by
API::WebAuthenticationPanel. A weak pointer of WebKit::WebAuthenticationPanelClient is kept in _WKWebAuthenticationPanel
to get the _WKWebAuthenticationPanelDelegate set by clients or nil otherwise. This binding is the surface where WebKit
interacts with clients.
3) WebAuthenticationPanelFlags is the mirror of enums within _WKWebAuthenticationPanel.
Implementation wise, this patch implements:
1) -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:], this is bridged from
the regular UIDelegate route. Noted, WKFrameInfo is nil for now, a follow up on Bug 202563 will take care of it. This
will be called from AuthenticatorManager::runPanel() which gates the start of discovery on the callback. For clients
that don't implement the delegate, the callback will always be called with _WKWebAuthenticationPanelResultUnavailable
to allow WebKit run on non-UI mode. A specific C API hack is added to always return _WKWebAuthenticationPanelResultPresented
in WebKitTestRunner for layout tests.
2) -[_WKWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:] will be implemented in Bug 200932.
3) -[_WKWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:], this is bridged from
API::WebAuthenticationPanel/API::WebAuthenticationPanelClient. This will be called whenever AuthenticatorManager::m_pendingCompletionHandler
is invoked. Depending on the respond, _WKWebAuthenticationResult will be returned accordingly. To facilitate that,
invokePendingCompletionHandler is crafted to bundle those two operations.
4) -[_WKWebAuthenticationPanel cancel] will be implemented in Bug 191523.
Besides the above, this patch also silents the NFC action sheet.
- Platform/spi/Cocoa/NearFieldSPI.h:
- Shared/API/APIObject.h:
- Shared/Cocoa/APIObject.mm: (API::Object::newObject):
- Sources.txt:
- SourcesCocoa.txt:
- UIProcess/API/APIUIClient.h: (API::UIClient::runWebAuthenticationPanel):
- UIProcess/API/APIWebAuthenticationPanel.cpp: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm. (API::WebAuthenticationPanel::create): (API::WebAuthenticationPanel::WebAuthenticationPanel): (API::WebAuthenticationPanel::setClient):
- UIProcess/API/APIWebAuthenticationPanel.h: Copied from Source/WebKit/UIProcess/WebAuthentication/WebAuthenticationRequestData.h.
- UIProcess/API/APIWebAuthenticationPanelClient.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h. (API::WebAuthenticationPanelClient::dismissPanel const):
- UIProcess/API/C/WKPage.cpp: (WKPageSetPageUIClient):
- UIProcess/API/C/WKPageUIClient.h:
- UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm: (-[_WKWebAuthenticationPanel dealloc]): (-[_WKWebAuthenticationPanel relyingPartyID]): (-[_WKWebAuthenticationPanel delegate]): (-[_WKWebAuthenticationPanel setDelegate:]): (-[_WKWebAuthenticationPanel _apiObject]): (-[_WKWebAuthenticationPanel _initWithRelayingPartyID:]): Deleted.
- UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::setDelegate): (WebKit::webAuthenticationPanelResult): (WebKit::UIDelegate::UIClient::runWebAuthenticationPanel):
- UIProcess/WebAuthentication/AuthenticatorManager.cpp: (WebKit::WebCore::isFeatureEnabled): (WebKit::WebCore::getRpId): (WebKit::AuthenticatorManager::handleRequest): (WebKit::AuthenticatorManager::respondReceived): (WebKit::AuthenticatorManager::startDiscovery): (WebKit::AuthenticatorManager::initTimeOutTimer): (WebKit::AuthenticatorManager::timeOutTimerFired): (WebKit::AuthenticatorManager::runPanel): (WebKit::AuthenticatorManager::startRequest): (WebKit::AuthenticatorManager::invokePendingCompletionHandler): (WebKit::AuthenticatorManagerInternal::collectTransports): Deleted. (WebKit::AuthenticatorManagerInternal::processGoogleLegacyAppIdSupportExtension): Deleted.
- UIProcess/WebAuthentication/AuthenticatorManager.h: (WebKit::AuthenticatorManager::pendingCompletionHandler): Deleted.
- UIProcess/WebAuthentication/Cocoa/NfcConnection.mm: (WebKit::NfcConnection::NfcConnection):
- UIProcess/WebAuthentication/Cocoa/NfcService.mm: (WebKit::NfcService::platformStartDiscovery):
- UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.h: Copied from Source/WebKit/UIProcess/WebAuthentication/WebAuthenticationRequestData.h.
- UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm: Copied from Source/WebKit/UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp. (WebKit::WebAuthenticationPanelClient::WebAuthenticationPanelClient): (WebKit::wkWebAuthenticationResult): (WebKit::WebAuthenticationPanelClient::dismissPanel const):
- UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp: (WebKit::MockAuthenticatorManager::respondReceivedInternal):
- UIProcess/WebAuthentication/WebAuthenticationPanelFlags.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h.
- UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp: (WebKit::WebAuthenticatorCoordinatorProxy::makeCredential): (WebKit::WebAuthenticatorCoordinatorProxy::getAssertion):
- WebKit.xcodeproj/project.pbxproj:
Tools:
This patch adds a very limited test case to _WKWebAuthenticationPanel.
Bug 202560 and Bug 202565 will follow up to write more tests.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: Added. (-[TestWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:]): (-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]): (TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html: Added.
- WebKitTestRunner/TestController.cpp: (WTR::runWebAuthenticationPanel): (WTR::TestController::createWebViewWithOptions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:32 AM Changeset in webkit [251339] by
-
- 2 edits in branches/safari-608-branch/Source/WebCore
Cherry-pick r250716. rdar://problem/56280993
AppleTV named as XSS-payloads trigger when AirPlay is used
https://bugs.webkit.org/show_bug.cgi?id=202534
<rdar://55931262>
Reviewed by Eric Carlson.
Ensure we escape an AirPlay's device name before inserting its name into the DOM.
- Modules/modern-media-controls/media/placard-support.js: (PlacardSupport.prototype._updateAirPlayPlacard): (PlacardSupport): (escapeHTML):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:32 AM Changeset in webkit [251338] by
-
- 5 edits in branches/safari-608-branch/Source/WebCore
Cherry-pick r250694. rdar://problem/56061131
[iOS] WebContent process can be interrupted during suspension; loses "Now Playing" status
https://bugs.webkit.org/show_bug.cgi?id=202537
<rdar://problem/55952707>
Reviewed by Eric Carlson.
Always deactivate the AVAudioSession when the last playing PlatformAudioSession ends playback and the application is in the background.
- platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::removeSession): (WebCore::PlatformMediaSessionManager::processWillSuspend): (WebCore::PlatformMediaSessionManager::maybeDeactivateAudioSession):
- platform/audio/PlatformMediaSessionManager.h: (WebCore::PlatformMediaSessionManager::isApplicationInBackground const):
- platform/audio/ios/MediaSessionManagerIOS.h:
- platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::sessionWillEndPlayback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:32 AM Changeset in webkit [251337] by
-
- 5 edits in branches/safari-608-branch/Source
Cherry-pick r250642. rdar://problem/56280704
[iOS] When hit testing for a context menu interaction, do not consider whether the element is contenteditable
https://bugs.webkit.org/show_bug.cgi?id=202498
<rdar://problem/54723131>
Reviewed by Tim Horton.
Source/WebCore:
When the user selects a context menu action, WebKit performs a hit test in order to find the
acted-on element on the page. This is separate from the hit test performed to generate the
context menu's targeted preview. Since an arbitrary amount of time can elapse between
preview generation and action selection, this second hit-tests might return a different
element.
One case where we know a different element can be returned is in apps that dynamically
enable and disable editing. If editing is disabled when the first hit test occurs but is
enabled when the second one occurs, different elements will be returned due to
Frame::qualifyingNodeAtViewportLocation preferring to return the root editable element when
the approximate node is contenteditable.
While the appropriate long-term fix is to only hit-test once and use that element for both
preview generation and action selection, this patch implements a short-term fix to address
the specific problem in rdar://problem/54723131 by disabling the contenteditable behavior
described above for context menu interaction hit testing.
The long-term fix is tracked by <https://webkit.org/b/202499>.
- page/Frame.h:
- page/ios/FrameIOS.mm: (WebCore::Frame::qualifyingNodeAtViewportLocation): (WebCore::Frame::approximateNodeAtViewportLocationLegacy): (WebCore::ancestorRespondingToClickEventsNodeQualifier): (WebCore::Frame::nodeRespondingToClickEvents): (WebCore::Frame::nodeRespondingToDoubleClickEvent): (WebCore::Frame::nodeRespondingToInteraction): (WebCore::Frame::nodeRespondingToScrollWheelEvents):
Source/WebKit:
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::startInteractionWithElementAtPosition): Changed to call WebCore::Frame::nodeRespondingToInteraction.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:32 AM Changeset in webkit [251336] by
-
- 2 edits in branches/safari-608-branch/Source/JavaScriptCore
Cherry-pick r250629. rdar://problem/56280996
FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes
https://bugs.webkit.org/show_bug.cgi?id=202493
Reviewed by Saam Barati.
I added this optimization for DFG but forgot to do it for the FTL
at the same time. This patch rectifies that.
- ftl/FTLOSRExitCompiler.cpp: (JSC::FTL::compileStub):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:32 AM Changeset in webkit [251335] by
-
- 4 edits2 adds in branches/safari-608-branch
Cherry-pick r250585. rdar://problem/56280995
ObjectAllocationSinkingPhase shouldn't insert hints for allocations which are no longer valid
https://bugs.webkit.org/show_bug.cgi?id=199361
<rdar://problem/52454940>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/allocation-sinking-hints-are-valid-ssa-2.js: Added. (main.fn): (main.executor): (main):
- stress/allocation-sinking-hints-are-valid-ssa.js: Added. (main.fn): (main.executor): (main):
Source/JavaScriptCore:
In a prior fix to the object allocation sinking phase, I added code where we
made sure to insert PutHints over Phis for fields of an object at control flow
merge points. However, that code didn't consider that the base of the PutHint
may no longer be a valid heap location. This could cause us to emit invalid
SSA code by referring to a node which does not dominate the PutHint location.
This patch fixes the bug to only emit the PutHints when valid.
This patch also makes it so that DFGValidate actually validates that the graph
is in valid SSA form. E.g, any use of a node N must be dominated by N.
- dfg/DFGObjectAllocationSinkingPhase.cpp:
- dfg/DFGValidate.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:32 AM Changeset in webkit [251334] by
-
- 6 edits2 adds in branches/safari-608-branch
Cherry-pick r250431. rdar://problem/55927251
Storage Access API: document.hasStorageAccess() should return false by default
https://bugs.webkit.org/show_bug.cgi?id=202281
<rdar://problem/55718526>
Reviewed by Alex Christensen.
document.hasStorageAccess() should return false by default so that it only
returns true if the context has asked for and been granted storage access.
Source/WebKit:
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: (WebKit::ResourceLoadStatisticsDatabaseStore::hasStorageAccess):
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp: (WebKit::ResourceLoadStatisticsMemoryStore::hasStorageAccess):
LayoutTests:
- http/tests/storageAccess/has-storage-access-false-by-default-expected.txt: Added.
- http/tests/storageAccess/has-storage-access-false-by-default.html: Added.
- platform/ios/TestExpectations:
The new test is marked as [ Pass ].
- platform/mac-wk2/TestExpectations:
The new test is marked as [ Pass ].
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:32 AM Changeset in webkit [251333] by
-
- 8 edits in branches/safari-608-branch
Cherry-pick r250416. rdar://problem/55954224
SubFrameSOAuthorizationSession should ensure messages are posted in the right order to the parent frame
https://bugs.webkit.org/show_bug.cgi?id=202061
<rdar://problem/55485666>
Reviewed by Youenn Fablet.
Source/WebKit:
This patch ensures messages that signal the process of SOAuthorization interception are posted in
the right order to the parent frame. Before this patch, there are chances that SOAuthorizationDidCancel
could be posted to the parent before SOAuthorizationDidStart. There are few causes that lead to
this race condition:
1) SubFrameSOAuthorizationSession::beforeStart posts SOAuthorizationDidStart in the next runloop. So
extension could have the chance to invoke SubFrameSOAuthorizationSession::fallBackToWebPathInternal
before SOAuthorizationDidStart is posted.
2) Even if the order is right in the UI process, it is not guaranteed that Web process will strictly
follow the order as the loading process is async.
To fix the issue:
1) SubFrameSOAuthorizationSession::beforeStart now posts SOAuthorizationDidStart in the same runloop.
2) Observer is introduced in FrameLoadState such that SubFrameSOAuthorizationSession could know if
the loading is finished. With this new capacity, SubFrameSOAuthorizationSession can ensure it only
posts next message when the previous message has been posted.
Implementation wise, a deque to queue requests is provided to maintain order.
1) When new request is added to the deque, SubFrameSOAuthorizationSession will only load the request
if it is the only element in the deque. Otherwise, it does nothing.
2) When SubFrameSOAuthorizationSession receives didFinishLoad, it pops the head of the queue and loads
the next request in the queue if any.
The above design should guarantee all requests are loaded in sequence.
- UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h:
- UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm: (WebKit::SubFrameSOAuthorizationSession::SubFrameSOAuthorizationSession): (WebKit::SubFrameSOAuthorizationSession::~SubFrameSOAuthorizationSession): (WebKit::SubFrameSOAuthorizationSession::fallBackToWebPathInternal): (WebKit::SubFrameSOAuthorizationSession::completeInternal): (WebKit::SubFrameSOAuthorizationSession::beforeStart): (WebKit::SubFrameSOAuthorizationSession::didFinishLoad): (WebKit::SubFrameSOAuthorizationSession::appendRequestToLoad): (WebKit::SubFrameSOAuthorizationSession::loadRequestToFrame): (WebKit::SubFrameSOAuthorizationSession::loadDataToFrame): Deleted. (WebKit::SubFrameSOAuthorizationSession::postDidCancelMessageToParent): Deleted.
- UIProcess/FrameLoadState.cpp: (WebKit::FrameLoadState::addObserver): (WebKit::FrameLoadState::removeObserver): (WebKit::FrameLoadState::didFinishLoad):
- UIProcess/FrameLoadState.h:
Tools:
Adds tests that check the order of messages posted by SubFrameSOAuthorizationSession.
- TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: (-[TestSOAuthorizationScriptMessageHandler userContentController:didReceiveScriptMessage:]): (resetState): (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:32 AM Changeset in webkit [251332] by
-
- 3 edits1 add in branches/safari-608-branch
Cherry-pick r249959. rdar://problem/56280989
CheckArray on DirectArguments/ScopedArguments does not filter out slow put array storage
https://bugs.webkit.org/show_bug.cgi?id=201853
<rdar://problem/53805461>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/direct-arguments-check-array-filter-type.js: Added. (foo):
Source/JavaScriptCore:
We were claiming CheckArray for ScopedArguments/DirectArguments was filtering
out SlowPutArrayStorage. It does no such thing. We just check that the object
is either ScopedArguments/DirectArguments.
- dfg/DFGArrayMode.h: (JSC::DFG::ArrayMode::arrayModesThatPassFiltering const): (JSC::DFG::ArrayMode::arrayModesWithIndexingShapes const): (JSC::DFG::ArrayMode::arrayModesWithIndexingShape const): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:32 AM Changeset in webkit [251331] by
-
- 15 edits3 adds in branches/safari-608-branch
Cherry-pick r249517. rdar://problem/56000099
Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
https://bugs.webkit.org/show_bug.cgi?id=201368
rdar://problem/40529867
Reviewed by Ryosuke Niwa.
Source/WebCore:
Dark mode content that is pasted should have the inline styles inverse color
transformed by the color filter to match the color filtered document contents.
Layout Test: editing/pasteboard/paste-dark-mode-color-filtered.html
API Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent
- editing/EditingStyle.cpp: (WebCore::EditingStyle::inverseTransformColorIfNeeded): Added caret-color to the transformed properties.
- editing/ReplaceSelectionCommand.cpp: (WebCore::fragmentNeedsColorTransformed): Added. (WebCore::ReplaceSelectionCommand::inverseTransformColor): Added. (WebCore::ReplaceSelectionCommand::doApply): Call fragmentNeedsColorTransformed() and inverseTransformColor().
- editing/ReplaceSelectionCommand.h:
Tools:
Added Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: (createWebViewWithCustomPasteboardDataSetting): Added argument to enable color filter.
- TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm: (createWebViewWithCustomPasteboardDataEnabled): Added argument to enable color filter.
- TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html: Added.
- TestWebKitAPI/cocoa/TestWKWebView.h:
- TestWebKitAPI/cocoa/TestWKWebView.mm: (-[TestWKWebView forceDarkMode]):
LayoutTests:
- TestExpectations:
- editing/pasteboard/paste-dark-mode-color-filtered-expected.txt: Added.
- editing/pasteboard/paste-dark-mode-color-filtered.html: Added.
- platform/ios-12/TestExpectations:
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:09 AM Changeset in webkit [251330] by
-
- 3 edits in trunk/Source/WebCore
[LFC][IFC] Make InlineTextItem reusable when 'segment break' behavior changes
https://bugs.webkit.org/show_bug.cgi?id=203184
<rdar://problem/56438945>
Reviewed by Antti Koivisto.
InlineTextItem::isWhitespace should dynamically check for 'preserve new line' behavior. This way we don't have to rebuild the inline item list
when the related style property value changes.
- layout/inlineformatting/InlineTextItem.cpp:
(WebCore::Layout::isWhitespaceCharacter):
(WebCore::Layout::moveToNextNonWhitespacePosition):
(WebCore::Layout::InlineTextItem::createAndAppendTextItems):
(WebCore::Layout::InlineTextItem::createWhitespaceItem):
(WebCore::Layout::InlineTextItem::createNonWhitespaceItem):
(WebCore::Layout::InlineTextItem::createSegmentBreakItem):
(WebCore::Layout::InlineTextItem::createEmptyItem):
(WebCore::Layout::InlineTextItem::InlineTextItem):
(WebCore::Layout::InlineTextItem::split const):
(WebCore::Layout::InlineTextItem::isWhitespace const):
(WebCore::Layout::isSoftLineBreak): Deleted.
- layout/inlineformatting/InlineTextItem.h:
(WebCore::Layout::InlineTextItem::isSegmentBreak const):
(WebCore::Layout::InlineTextItem::isWhitespace const): Deleted.
- 7:56 AM Changeset in webkit [251329] by
-
- 8 edits in trunk/Source/WebCore
[LFC][IFC] Move the collapsed bit from InlineItems to runs
https://bugs.webkit.org/show_bug.cgi?id=203183
Reviewed by Antti Koivisto.
<rdar://problem/56437181>
Let's not store the collapsed bit on the InlineTextItem. All we need to know is whether the InlineTextItem content is collapsible or not.
Also when only the white-space property changes (going from preserve whitespace to not and vice versa) we don't actually need to rebuild the
InlinItem list since they don't carry any layout dependent information.
This patch also fixes leading/trailing content preservation.
- layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::Run::canBeExtended const):
(WebCore::Layout::shouldPreserveTrailingContent):
(WebCore::Layout::shouldPreserveLeadingContent):
(WebCore::Layout::Line::appendTextContent):
- layout/inlineformatting/InlineLine.h:
(WebCore::Layout::Line::Run::isCollapsed const):
(WebCore::Layout::Line::Run::setIsCollapsed):
- layout/inlineformatting/InlineLineLayout.cpp:
(WebCore::Layout::inlineItemWidth):
- layout/inlineformatting/InlineTextItem.cpp:
(WebCore::Layout::InlineTextItem::createAndAppendTextItems):
(WebCore::Layout::InlineTextItem::InlineTextItem):
(WebCore::Layout::InlineTextItem::split const):
- layout/inlineformatting/InlineTextItem.h:
(WebCore::Layout::InlineTextItem::isCollapsible const):
(WebCore::Layout::InlineTextItem::isCollapsed const): Deleted.
- layout/inlineformatting/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::isTrimmableContent): Deleted.
- layout/inlineformatting/text/TextUtil.h:
Oct 19, 2019:
- 4:50 PM Changeset in webkit [251328] by
-
- 3 edits in trunk/LayoutTests
Flaky Test: fast/events/resize-subframe-in-rendering-update.html
https://bugs.webkit.org/show_bug.cgi?id=203140
<rdar://problem/56415948>
Reviewed by Wenson Hsieh.
Removed the assertion in setTimeout to avoid flakiness. There isn't a way to deterministically order
callbacks of setTimeout and requestAnimationFrame for this test for now.
- fast/events/resize-subframe-in-rendering-update-expected.txt:
- fast/events/resize-subframe-in-rendering-update.html:
- 4:41 PM Changeset in webkit [251327] by
-
- 9 edits2 adds in trunk
FileReader should not prevent entering the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203106
Reviewed by Geoffrey Garen.
Source/WebCore:
FileReader should not prevent entering the back/forward cache. To support this,
its implementation now uses a SuspendableTaskQueue to dispatch events.
Test: fast/files/file-reader-back-forward-cache.html
- dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::isAllowedToRunScript const):
- dom/ActiveDOMObject.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
- fileapi/FileReader.cpp:
(WebCore::FileReader::FileReader):
(WebCore::FileReader::stop):
(WebCore::FileReader::hasPendingActivity const):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::abort):
(WebCore::FileReader::didStartLoading):
(WebCore::FileReader::didReceiveData):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):
(WebCore::FileReader::fireEvent):
- fileapi/FileReader.h:
LayoutTests:
Add layout test coverage.
- TestExpectations:
- fast/files/file-reader-back-forward-cache-expected.txt: Added.
- fast/files/file-reader-back-forward-cache.html: Added.
- 12:56 PM Changeset in webkit [251326] by
-
- 12 edits in trunk/Source
[GTK][WPE] Fix non-unified builds after r250857
https://bugs.webkit.org/show_bug.cgi?id=203145
Reviewed by Carlos Garcia Campos.
Source/WebCore:
No new tests needed.
- Modules/async-clipboard/ClipboardItem.cpp: Add missing inclusion of the Clipboard.h header.
- Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp: Add missing inclusion of the
ClipboardItem.h header.
- Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp: Add missing inclusions of
the Clipboard.h, ClipboardItem.h, and JSDOMPromiseDeferred.h headers.
- dom/AbstractEventLoop.h: Add missing inclusion of the wtf/RefCounted.h header.
- dom/WindowEventLoop.h: Add missing inclusion of the DocumentIdentifier.h header.
- dom/IdleCallbackController.h: Add missing forward-declaration for the Document class.
- dom/RadioButtonGroups.h: Add needed inclusion of of the wtf/text/AtomStringHash.h header,
needed because AtomString is used as key for a HashMap; remove the (now unneeded) of the
wtf/Forward.h header.
- page/WheelEventTestMonitor.cpp: Add missing inclusion of the wtf/OptionSet.h header.
- rendering/style/ShadowData.cpp: Add missing inclusion of the wtf/text/TextStream.h header.
Source/WebKit:
- UIProcess/WebProcessProxy.cpp: Add missing inclusion of the WebBackForwardCache.h header.
- 11:40 AM Changeset in webkit [251325] by
-
- 3 edits in trunk/Source/WTF
Add support to TextStream for dumping HashMap<> and HashSet<>
https://bugs.webkit.org/show_bug.cgi?id=202969
Reviewed by Dean Jackson.
Make it possible to output HashMap<> and HashSet<> to TextStream,
so long as key and value types are streamable. Also implement operator<<(char)
so that chars show as ASCII, rather than numbers.
- wtf/text/TextStream.cpp:
(WTF::TextStream::operator<<):
- wtf/text/TextStream.h:
(WTF::operator<<):
- 8:46 AM Changeset in webkit [251324] by
-
- 9 copies1 add in releases/Apple/Safari Technology Preview/Safari Technology Preview 94
Added a tag for Safari Technology Preview release 94.
- 8:41 AM Changeset in webkit [251323] by
-
- 8 copies1 add in releases/Apple/iOS 13.1.3
Added a tag for iOS 13.1.3.
- 1:31 AM Changeset in webkit [251322] by
-
- 11 edits4 adds in trunk
Integrate media query evaluation into HTML5 event loop
https://bugs.webkit.org/show_bug.cgi?id=203134
<rdar://problem/56396316>
Reviewed by Antti Koivisto.
Source/WebCore:
Moved the code to call media query listeners to HTML5 event loop's step to update the rendering:
https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering
Tests: fast/media/mq-inverted-colors-live-update-for-listener.html
fast/media/mq-prefers-reduced-motion-live-update-for-listener.html
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::evaluateAll): Renamed from styleResolverChanged.
- css/MediaQueryMatcher.h:
- dom/Document.cpp:
(WebCore::Document::updateElementsAffectedByMediaQueries): Split from evaluateMediaQueryList.
This function is still called right after each layout update so that picture element may start
requesting newly selected image resources without having to wait for a rendering update.
But this function will no longer execute arbitrary scripts.
(WebCore::Document::evaluateMediaQueriesAndReportChanges): Split from evaluateMediaQueryList.
Evaluates media query listeners.
- dom/Document.h:
- inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setEmulatedMedia): Force the evaluation of media queries for now
but this code should really be scheduling a rendering update instead so added a FIXME.
- page/Frame.cpp:
(WebCore::Frame::setPrinting): Evaluate media queries. We should consider invoking the full
algorithm to update the rendering here. e.g. intersection observer may add more contents.
- page/Page.cpp:
(WebCore::Page::updateRendering): Call evaluateMediaQueriesAndReportChanges.
LayoutTests:
Added tests for listening to accessiblity related media queries without having any style rules
get affected by those media queries so that we can catch any future regressions. For now,
changing accessiblity settings seem to always schedule a rendering update so there is nothing to do
when these accessibility settings do change.
- fast/media/media-query-list-07.html: Fixed the test to be compatible with new behavior.
- fast/media/mq-inverted-colors-live-update-for-listener-expected.txt: Added.
- fast/media/mq-inverted-colors-live-update-for-listener.html: Added.
- fast/media/mq-prefers-reduced-motion-live-update-for-listener-expected.txt: Added.
- fast/media/mq-prefers-reduced-motion-live-update-for-listener.html: Added.
Oct 18, 2019:
- 11:31 PM Changeset in webkit [251321] by
-
- 8 edits1 add in trunk
[JSC] DFG::CommonData modification by DFG reallyAdd should be guarded by CodeBlock's lock
https://bugs.webkit.org/show_bug.cgi?id=203177
Reviewed by Mark Lam.
JSTests:
- stress/dfg-really-add-locking.js: Added.
Source/JavaScriptCore:
When doing DFG reallyAdd, DFG::JITCode is already set in CodeBlock and DFG::CommonData can be
reachable from CodeBlock. So concurrent collector can trace entries of DFG::CommonData while DFG reallyAdd
is modifying it. It would be possible that we install DFG::JITCode after performing DFG reallyAdd, but for now,
we just protect DFG reallyAdd's DFG::CommonData modification by CodeBlock's lock so that concurrent collector
does not trace them in a racy manner.
- dfg/DFGDesiredGlobalProperties.cpp:
(JSC::DFG::DesiredGlobalProperties::reallyAdd):
- dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::reallyAdd):
- dfg/DFGDesiredTransitions.cpp:
(JSC::DFG::DesiredTransition::reallyAdd):
- dfg/DFGDesiredWatchpoints.cpp:
(JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):
(JSC::DFG::SymbolTableAdaptor::add):
(JSC::DFG::FunctionExecutableAdaptor::add):
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::add):
- dfg/DFGDesiredWatchpoints.h:
(JSC::DFG::SetPointerAdaptor::add):
- dfg/DFGDesiredWeakReferences.cpp:
(JSC::DFG::DesiredWeakReferences::reallyAdd):
- 10:48 PM Changeset in webkit [251320] by
-
- 11 edits2 adds in trunk/Source
macCatalyst: Cursor should send mouse events, not touch events
https://bugs.webkit.org/show_bug.cgi?id=203175
<rdar://problem/56321134>
Reviewed by Simon Fraser.
Source/WebCore:
- dom/Element.cpp:
(WebCore::shouldIgnoreMouseEvent):
(WebCore::Element::dispatchMouseEvent):
- page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::reset):
Share more code between platforms that support touch events and platforms that don't;
we want to be able to dispatch pointer events that originate from mouse events
in macCatalyst despite touch events being enabled (by virtue of being iOS WebKit),
so un-ifdef that code.
Source/WebKit:
- Platform/spi/ios/UIKitSPI.h:
- Shared/NativeWebMouseEvent.h:
- Shared/ios/NativeWebMouseEventIOS.mm:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
Add a NativeWebMouseEvent constructor that doesn't actually wrap a native event,
for creating totally-synthetic events.
- UIProcess/ios/WKMouseGestureRecognizer.h: Added.
- UIProcess/ios/WKMouseGestureRecognizer.mm: Added.
(webEventModifiersForUIKeyModifierFlags):
(-[WKMouseGestureRecognizer initWithTarget:action:]):
(-[WKMouseGestureRecognizer setView:]):
(-[WKMouseGestureRecognizer lastMouseEvent]):
(-[WKMouseGestureRecognizer lastMouseLocation]):
(-[WKMouseGestureRecognizer mouseTouch]):
(-[WKMouseGestureRecognizer _wantsHoverEvents]):
(-[WKMouseGestureRecognizer reset]):
(-[WKMouseGestureRecognizer _shouldReceiveTouch:forEvent:recognizerView:]):
(-[WKMouseGestureRecognizer _shouldReceivePress:]):
(-[WKMouseGestureRecognizer createMouseEventWithType:]):
(-[WKMouseGestureRecognizer touchesBegan:withEvent:]):
(-[WKMouseGestureRecognizer touchesMoved:withEvent:]):
(-[WKMouseGestureRecognizer touchesEnded:withEvent:]):
(-[WKMouseGestureRecognizer touchesCancelled:withEvent:]):
(-[WKMouseGestureRecognizer _hoverEntered:withEvent:]):
(-[WKMouseGestureRecognizer _hoverMoved:withEvent:]):
(-[WKMouseGestureRecognizer _hoverExited:withEvent:]):
(-[WKMouseGestureRecognizer _hoverCancelled:withEvent:]):
(-[WKMouseGestureRecognizer locationInView:]):
(-[WKMouseGestureRecognizer canPreventGestureRecognizer:]):
(-[WKMouseGestureRecognizer canBePreventedByGestureRecognizer:]):
Instead of just using UIHoverGestureRecognizer, introduce a new gesture
recognizer that does what it did, but also supports cases where the button
is pressed (so, mousedown and mouseup instead of just mousemove),
and synthesizes mouse events for all state transitions. These events
should look roughly identical to what a non-macCatalyst app would get
in AppKit's mouseUp/mouseDown/mouseMoved NSResponder methods.
- SourcesCocoa.txt:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _showShareSheet:inRect:completionHandler:]):
(-[WKContentView _mouseGestureRecognizerChanged:]):
(webEventFlagsForUIKeyModifierFlags): Deleted.
(-[WKContentView _hoverGestureRecognizerChanged:]): Deleted.
- WebKit.xcodeproj/project.pbxproj:
Make use of WKMouseGestureRecognizer to plumb the synthesized events directly
to the macOS-style "handleMouseEvent" codepath, instead of going through
the touch events path (and then subsequently generating synthetic clicks).
Also, ensure that other gesture recognizers ignore the mouse "touch" entirely
by returning NO in shouldReceiveTouch.
- 7:28 PM Changeset in webkit [251319] by
-
- 6 edits in trunk/Source/WebCore
Make it possible to query scrollbar pseudo-style without having a scrollbar
https://bugs.webkit.org/show_bug.cgi?id=203174
Reviewed by Tim Horton.
A future patch needs the ability to query scrollbar pseudo-style without having
a scrollbar, and it was ugly to pass a live RenderScrollbar into CSS style resolution
functions. Instead, pass in a pure-data object that has information about the scrollbar.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- css/SelectorChecker.h:
- css/SelectorCheckerTestFunctions.h:
(WebCore::scrollbarMatchesEnabledPseudoClass):
(WebCore::scrollbarMatchesDisabledPseudoClass):
(WebCore::scrollbarMatchesHoverPseudoClass):
(WebCore::scrollbarMatchesActivePseudoClass):
(WebCore::scrollbarMatchesHorizontalPseudoClass):
(WebCore::scrollbarMatchesVerticalPseudoClass):
(WebCore::scrollbarMatchesDecrementPseudoClass):
(WebCore::scrollbarMatchesIncrementPseudoClass):
(WebCore::scrollbarMatchesStartPseudoClass):
(WebCore::scrollbarMatchesEndPseudoClass):
(WebCore::scrollbarMatchesDoubleButtonPseudoClass):
(WebCore::scrollbarMatchesSingleButtonPseudoClass):
(WebCore::scrollbarMatchesNoButtonPseudoClass):
(WebCore::scrollbarMatchesCornerPresentPseudoClass):
- css/StyleResolver.h:
(WebCore::PseudoStyleRequest::PseudoStyleRequest):
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::getScrollbarPseudoStyle):
- 6:18 PM Changeset in webkit [251318] by
-
- 118 edits7 deletes in trunk
[SVG2]: Remove the SVGExternalResourcesRequired interface
https://bugs.webkit.org/show_bug.cgi?id=191293
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-10-18
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/svg/import/types-dom-04-b-manual.svg:
Use the preserveAlpha property of <feConvolveMatrix> element to test
SVGAnimatedBoolean.
Source/WebCore:
The spec page is: https://www.w3.org/TR/SVG/changes.html.
r251290 made externalResourcesRequired have no effect on firing the load
event. All the control was moved to SVGURIReference. This patch will remove
this interface entirely to conform with SVG2 specs and other browsers.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::SVGAElement):
(WebCore::SVGAElement::parseAttribute):
(WebCore::SVGAElement::svgAttributeChanged):
- svg/SVGAElement.h:
- svg/SVGAElement.idl:
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::isSupportedAttribute):
(WebCore::SVGAnimationElement::parseAttribute):
- svg/SVGAnimationElement.h:
- svg/SVGAnimationElement.idl:
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::SVGCircleElement):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
- svg/SVGCircleElement.h:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::parseAttribute):
(WebCore::SVGClipPathElement::svgAttributeChanged):
- svg/SVGClipPathElement.h:
- svg/SVGClipPathElement.idl:
- svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::SVGCursorElement):
(WebCore::SVGCursorElement::parseAttribute):
- svg/SVGCursorElement.h:
- svg/SVGCursorElement.idl:
- svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::SVGDefsElement):
- svg/SVGDefsElement.h:
- svg/SVGDefsElement.idl:
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::SVGEllipseElement):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
- svg/SVGEllipseElement.h:
- svg/SVGEllipseElement.idl:
- svg/SVGExternalResourcesRequired.cpp: Removed.
- svg/SVGExternalResourcesRequired.h: Removed.
- svg/SVGExternalResourcesRequired.idl: Removed.
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::SVGFEImageElement):
(WebCore::SVGFEImageElement::parseAttribute):
- svg/SVGFEImageElement.h:
- svg/SVGFEImageElement.idl:
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::SVGFilterElement):
(WebCore::SVGFilterElement::parseAttribute):
(WebCore::SVGFilterElement::svgAttributeChanged):
- svg/SVGFilterElement.h:
- svg/SVGFilterElement.idl:
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::SVGFontElement):
- svg/SVGFontElement.h:
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::SVGGElement):
(WebCore::SVGGElement::parseAttribute): Deleted.
(WebCore::SVGGElement::svgAttributeChanged): Deleted.
- svg/SVGGElement.h:
- svg/SVGGElement.idl:
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::SVGGradientElement):
(WebCore::SVGGradientElement::parseAttribute):
- svg/SVGGradientElement.h:
- svg/SVGGradientElement.idl:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
- svg/SVGImageElement.h:
- svg/SVGImageElement.idl:
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::SVGLineElement):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGLineElement.h:
- svg/SVGLineElement.idl:
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::SVGMPathElement):
(WebCore::SVGMPathElement::parseAttribute):
(WebCore::SVGMPathElement::svgAttributeChanged):
- svg/SVGMPathElement.h:
- svg/SVGMPathElement.idl:
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::SVGMarkerElement):
(WebCore::SVGMarkerElement::parseAttribute):
(WebCore::SVGMarkerElement::svgAttributeChanged):
- svg/SVGMarkerElement.h:
- svg/SVGMarkerElement.idl:
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::SVGMaskElement):
(WebCore::SVGMaskElement::parseAttribute):
(WebCore::SVGMaskElement::svgAttributeChanged):
- svg/SVGMaskElement.h:
- svg/SVGMaskElement.idl:
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
- svg/SVGPathElement.h:
- svg/SVGPathElement.idl:
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::SVGPatternElement):
(WebCore::SVGPatternElement::parseAttribute):
(WebCore::SVGPatternElement::svgAttributeChanged):
- svg/SVGPatternElement.h:
- svg/SVGPatternElement.idl:
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::SVGPolyElement):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGPolyElement.h:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.idl:
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::SVGRectElement):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
- svg/SVGRectElement.h:
- svg/SVGRectElement.idl:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::svgAttributeChanged):
- svg/SVGSVGElement.h:
- svg/SVGSVGElement.idl:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::SVGScriptElement):
(WebCore::SVGScriptElement::parseAttribute):
(WebCore::SVGScriptElement::svgAttributeChanged):
- svg/SVGScriptElement.h:
- svg/SVGScriptElement.idl:
- svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::SVGSwitchElement):
- svg/SVGSwitchElement.h:
- svg/SVGSwitchElement.idl:
- svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::SVGSymbolElement):
(WebCore::SVGSymbolElement::parseAttribute):
(WebCore::SVGSymbolElement::svgAttributeChanged): Deleted.
- svg/SVGSymbolElement.h:
- svg/SVGSymbolElement.idl:
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::SVGTextContentElement):
(WebCore::SVGTextContentElement::parseAttribute):
(WebCore::SVGTextContentElement::svgAttributeChanged):
- svg/SVGTextContentElement.h:
- svg/SVGTextContentElement.idl:
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::svgAttributeChanged):
- svg/SVGUseElement.h:
- svg/SVGUseElement.idl:
- svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::SVGViewElement):
(WebCore::SVGViewElement::parseAttribute):
(WebCore::SVGViewElement::svgAttributeChanged):
- svg/SVGViewElement.h:
- svg/SVGViewElement.idl:
LayoutTests:
- platform/gtk/TestExpectations:
The script-change-externalResourcesRequired-while-loading.svg has to be
removed and it was flaky on all platforms.
- platform/gtk/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual-expected.txt:
- platform/ios/TestExpectations:
- platform/ios/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/win/TestExpectations:
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual-expected.txt:
- platform/wpe/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- svg/W3C-SVG-1.1-SE/types-dom-04-b.svg:
Use the preserveAlpha property of <feConvolveMatrix> element to test
SVGAnimatedBoolean.
- svg/animations/animate-externalResourcesRequired-no-load-event-expected.txt: Removed.
- svg/animations/animate-externalResourcesRequired-no-load-event.html: Removed.
- svg/custom/path-domsubtreemodified-crash.html:
- svg/dom/SVGAnimatedBoolean-expected.txt:
- svg/dom/SVGAnimatedBoolean.html:
Use the preserveAlpha property of <feConvolveMatrix> element to test
SVGAnimatedBoolean.
- svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading-expected.txt: Removed.
- svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg: Removed.
- svg/dom/SVGScriptElement/script-load-and-error-events.svg:
- svg/dom/SVGScriptElement/script-onerror-bubbling.svg:
- svg/dom/SVGScriptElement/script-reexecution.svg:
- svg/dynamic-updates/SVGUseElement-dom-href1-attr.html:
- 6:02 PM Changeset in webkit [251317] by
-
- 22 edits1 copy1 move1 add in trunk
[WebAuthn] Warn users when no credentials are found
https://bugs.webkit.org/show_bug.cgi?id=203147
<rdar://problem/55931123>
Reviewed by Brent Fulgham.
Source/WebKit:
This patch returns _WKWebAuthenticationPanelUpdateNoCredentialsFound to client via
-[_WKWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:] when either
CtapAuthenticator receives kCtap2ErrNoCredentials or U2fAuthenticator exhausts the
allow list.
This patch also enhances CtapAuthenticator::tryDowngrade to check if the CTAP command
can be converted to U2F commands to ensure kCtap2ErrNoCredentials is returned if it
is the case. Otherwise, after downgrading, U2fAuthenticator will return NotSupportedError
given it can't convert the commands.
- UIProcess/API/APIUIClient.h:
- UIProcess/API/APIWebAuthenticationPanelClient.h:
(API::WebAuthenticationPanelClient::updatePanel const):
- UIProcess/WebAuthentication/Authenticator.h:
- UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::authenticatorStatusUpdated):
- UIProcess/WebAuthentication/AuthenticatorManager.h:
- UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.h:
- UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:
(WebKit::WebAuthenticationPanelClient::WebAuthenticationPanelClient):
(WebKit::wkWebAuthenticationPanelUpdate):
(WebKit::WebAuthenticationPanelClient::updatePanel const):
- UIProcess/WebAuthentication/WebAuthenticationFlags.h: Renamed from Source/WebKit/UIProcess/WebAuthentication/WebAuthenticationPanelFlags.h.
- UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
- UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::continueGetAssertionAfterResponseReceived):
(WebKit::CtapAuthenticator::tryDowngrade):
- UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:
(WebKit::U2fAuthenticator::issueSignCommand):
- WebKit.xcodeproj/project.pbxproj:
Tools:
Adds new tests for _WKWebAuthenticationPanelUpdateNoCredentialsFound.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-cancel.html:
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-no-credentials.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html:
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html:
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-u2f-no-credentials.html: Added.
LayoutTests:
Adds new tests for CtapAuthenticator::tryDowngrade enhancement.
- http/wpt/webauthn/public-key-credential-get-failure-hid.https-expected.txt:
- http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:
- 5:47 PM Changeset in webkit [251316] by
-
- 17 edits in trunk
[Clipboard API] Refactor Pasteboard::read() to take an optional item index
https://bugs.webkit.org/show_bug.cgi?id=203161
Reviewed by Tim Horton.
Source/WebCore:
Adds an optional
itemIndexargument to Pasteboard::read(PasteboardPlainText&) and
Pasteboard::read(PasteboardWebContentReader&, WebContentReadingPolicy). See below for more details.
Tests: CopyHTML.ItemTypesWhenCopyingWebContent
PasteWebArchive.WebArchiveTypeIdentifier
- editing/mac/EditorMac.mm:
(WebCore::Editor::dataSelectionForPasteboard):
Recognize "com.apple.webarchive" alongside "Apple Web Archive pasteboard type" when writing and reading from the
platform pasteboard on macOS. We add support for this here because the existing private type cannot be written
to an NSPasteboardItem, since it does not conform to a valid UTI format. Luckily, there already exists a UTI
that represents a web archive, so we can use it instead.
We need to write and read web archive data from NSPasteboardItem in order to support the case where there are
multiple items in the pasteboard that contain different web archive data.
- platform/Pasteboard.h:
- platform/StaticPasteboard.h:
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::read):
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read):
Read the string from
itemIndexif specified; otherwise, fall back to index 0. This could actually be fixed in
the future to scan all pasteboard items for a suitable string instead of falling back on the first item, but for
now, we maintain the existing behavior.
(WebCore::Pasteboard::readRespectingUTIFidelities):
If an
itemIndexis specified, ignore all other item indices when looking for suitable content.
- platform/libwpe/PasteboardLibWPE.cpp:
(WebCore::Pasteboard::read):
- platform/mac/DragDataMac.mm:
(WebCore::DragData::containsCompatibleContent const):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::write):
(WebCore::readStringAtPreferredItemIndex):
(WebCore::readBufferAtPreferredItemIndex):
Add helper methods to read strings and buffers from the pasteboard, at an optional
itemIndexif specified.
(WebCore::Pasteboard::read):
Adopt the helper functions when reading plain text and web content, and respect the given
itemIndex. To do
this, we need to read both legacy and modern types from the pasteboard, instead of just legacy types. This is
because NSPasteboardItem on macOS only accepts and provides data in the form of modern pasteboard types.
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
(WebCore::PlatformPasteboard::readBuffer const):
(WebCore::PlatformPasteboard::readString const):
Fix these methods to accept platform pasteboard types instead of MIME types, to match the behavior of existing
readBuffer and readString methods in PlatformPasteboardIOS.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::read):
Source/WebKit:
- Shared/mac/PasteboardTypes.mm:
(WebKit::PasteboardTypes::forEditing):
(WebKit::PasteboardTypes::forSelection):
Support "com.apple.webarchive" alongside the private "Apple Web Archive pasteboard type".
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::setPromisedDataForImage):
Tools:
Add a couple of new API tests to verify that the web archive type identifier ("com.apple.webarchive") is (1)
written to the pasteboard when copying a rich text selection, and (2) is read when attempting to paste web
content.
- TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
- TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
- 5:44 PM Changeset in webkit [251315] by
-
- 11 edits in trunk/Source/WebCore
[ASAN] Fix WebGPU tests after r250258
https://bugs.webkit.org/show_bug.cgi?id=203133
<rdar://problem/56379008>
Reviewed by Joseph Pecoraro.
- platform/graphics/gpu/GPUObjectBase.h:
(WebCore::GPUObjectBase::~GPUObjectBase): Added.
Add a default virtual destructor since this class class is the one that isRefCountedand
theWebGPUPipelinesubclass is virtual.
- Modules/webgpu/WebGPUPipeline.h:
(WebCore::WebGPUPipeline::scriptExecutionContext const): Deleted.
- Modules/webgpu/WebGPUPipeline.cpp:
(WebCore::WebGPUPipeline::WebGPUPipeline):
(WebCore::WebGPUPipeline::contextDestroyed): Added.
MakeWebGPUPipelinea subclass ofContextDestructionObserverso that the raw pointer to
the associatedScriptExecutionContextis properly cleared and isn't UAFd.
- Modules/webgpu/WebGPUComputePipeline.h:
- Modules/webgpu/WebGPUComputePipeline.cpp:
(WebCore::WebGPUComputePipeline::create):
(WebCore::WebGPUComputePipeline::WebGPUComputePipeline):
(WebCore::WebGPUComputePipeline::cloneShaderModules):
(WebCore::WebGPUComputePipeline::recompile):
- Modules/webgpu/WebGPURenderPipeline.h:
- Modules/webgpu/WebGPURenderPipeline.cpp:
(WebCore::WebGPURenderPipeline::create):
(WebCore::WebGPURenderPipeline::WebGPURenderPipeline):
(WebCore::WebGPURenderPipeline::cloneShaderModules):
(WebCore::WebGPURenderPipeline::recompile):
- Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::createRenderPipeline):
(WebCore::WebGPUDevice::createComputePipeline):
Rework how Web Inspector preserves related shader modules so that there isn't as much wasted
space in the class layout, as we can use theRefPtritself instead of anOptional.
- Modules/webgpu/WebGPUBuffer.idl:
Now that
GPUObjectBasehas a virtual destructor, it has a vtable, which means that this
object also does and therefore cannot be marked withImplementationLacksVTable.
- inspector/InspectorShaderProgram.cpp:
(WebCore::shaderForType):
(WebCore::InspectorShaderProgram::requestShaderSource):
(WebCore::InspectorShaderProgram::updateShader):
(WebCore::InspectorShaderProgram::buildObjectForShaderProgram):
- 5:41 PM Changeset in webkit [251314] by
-
- 2 edits in trunk/LayoutTests
[ Mac Debug WK1 ] REGRESSION (r251262?): fast/scrolling/latching/scroll-select-bottom-test.html is a Flaky Failure
https://bugs.webkit.org/show_bug.cgi?id=203176
Unreviewed Test Gardening.
- platform/mac-wk1/TestExpectations:
- 4:58 PM Changeset in webkit [251313] by
-
- 2 edits in trunk/LayoutTests
[ Mac WK1 ] REGRESSION (r251261): Layout Test inspector/console/webcore-logging.html is consistently Failing
https://bugs.webkit.org/show_bug.cgi?id=203173
Unreviewed Test Gardening.
- platform/mac-wk1/TestExpectations:
- 4:55 PM Changeset in webkit [251312] by
-
- 5 edits in trunk/Tools
Python 3: Add support in webkitpy.common.watchlist
https://bugs.webkit.org/show_bug.cgi?id=202473
Reviewed by Dewei Zhu.
- Scripts/test-webkitpy-python3: Add webkitpy.common.watchlist.
- Scripts/webkitpy/common/watchlist/watchlist.py:
(WatchList.find_matching_definitions): Use items instead of iteritems.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
(WatchListTest.test_filename_definition_no_matches): Back-slash needs to be escaped.
(WatchListTest.test_filename_definition): Ditto.
(WatchListTest.test_cc_rules_simple): Ditto.
(WatchListTest.test_cc_rules_complex): Ditto.
(WatchListTest.test_cc_and_message_rules_complex): Ditto.
(WatchListTest.test_cc_and_message_rules_no_matches): Ditto.
(WatchListTest.test_more_and_less_match): Ditto.
(WatchListTest.test_complex_match): Ditto.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
(WatchListParserTest.test_bad_definition): Back-slash needs to be escaped.
(WatchListParserTest.test_bad_filename_regex): Ditto.
(WatchListParserTest.test_bad_more_regex): Ditto.
(WatchListParserTest.test_bad_match_type): Ditto.
(WatchListParserTest.test_match_type_typo): Ditto.
(WatchListParserTest.test_empty_cc_rule): Ditto.
(WatchListParserTest.test_cc_rule_with_invalid_email): Ditto.
(WatchListParserTest.test_cc_rule_with_secondary_email): Ditto.
(WatchListParserTest.test_empty_message_rule): Ditto.
(WatchListParserTest.test_unused_defintion): Ditto.
(WatchListParserTest.test_cc_rule_with_undefined_defintion_with_suggestion): Ditto.
- 4:46 PM Changeset in webkit [251311] by
-
- 2 edits in trunk/LayoutTests
Layout Test inspector/layers/layers-for-node.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=203171
unreviewed test gardening
- platform/mac/TestExpectations:
- 4:42 PM Changeset in webkit [251310] by
-
- 2 edits in trunk/Tools
Remove myself from the CMake watchlist
https://bugs.webkit.org/show_bug.cgi?id=203166
Patch by Raphael Kubo da Costa <rakuco@webkit.org> on 2019-10-18
Reviewed by Aakash Jain.
- Scripts/webkitpy/common/config/watchlist:
- 4:36 PM Changeset in webkit [251309] by
-
- 4 edits in trunk
[iOS] REGRESSION(r251269): fast/events/ios/rotation/do-not-shrink-to-fit-content-after-rotation.html and fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html fail
https://bugs.webkit.org/show_bug.cgi?id=203162
<rdar://problem/56418459>
Reviewed by Simon Fraser.
Source/WebKit:
Synchronously update the rendering before the orientation change and other viewport size updates.
Otherwise, resize event will be dispatched in the middle of orientation animation,
and would result in non-determistic results.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
LayoutTests:
Rebaselined the test now that the order of execution of orientationchange and resize events have changed.
- fast/events/ios/rotation/layout-viewport-during-safari-type-rotation-expected.txt:
- 4:34 PM Changeset in webkit [251308] by
-
- 4 edits1 add in trunk/Source/WebCore
Refactor AbstractEventLoop out of WindowEventLoop
https://bugs.webkit.org/show_bug.cgi?id=203136
<rdar://problem/56396749>
Reviewed by Antti Koivisto.
Extract AbstractEventLoop out of WindowEventLoop as a preparation for adding WorkerEventLoop.
Also replaced m_activeTaskCount with a boolean m_isScheduledToRun since it doesn't need to count.
- WebCore.xcodeproj/project.pbxproj:
- dom/AbstractEventLoop.cpp: Added.
- dom/AbstractEventLoop.h: Added.
(WebCore::AbstractEventLoop): Added.
- dom/WindowEventLoop.cpp:
(WebCore::WindowEventLoop::WindowEventLoop): Deleted. Use the default constructor in the header instead.
(WebCore::WindowEventLoop::queueTask):
(WebCore::WindowEventLoop::suspend):
(WebCore::WindowEventLoop::resume):
(WebCore::WindowEventLoop::scheduleToRunIfNeeded): Extracted out of queueTask.
(WebCore::WindowEventLoop::run):
- dom/WindowEventLoop.h:
- 4:32 PM Changeset in webkit [251307] by
-
- 4 edits in trunk/Source
[JSC] Make ConcurrentJSLock Lock even if ENABLE_CONCURRENT_JS=OFF
https://bugs.webkit.org/show_bug.cgi?id=202892
Reviewed by Mark Lam.
Source/JavaScriptCore:
We are using ConcurrentJSLock to guard data structure against concurrent compilers.
But these data structures should be guarded by GC concurrent collector, so we are using this ConcurrentJSLock
to guard them against concurrent collector too.
The problem is that ENABLE(CONCURRENT_JS) relies on ENABLE(DFG_JIT). If we configure JSC with the options like,
ENABLE_DFG_JIT 0
ENABLE_FTL_JIT 0
Then, the built JSC becomes
ENABLE_CONCURRENT_JS 0
But, Concurrent GC is enabled.
This is wrong due to several reasons.
- Baseline JIT can produce JIT related data structures that are traced by concurrent collector. In the above options, these data structures are not guarded by lock.
- Baseline JIT also has concurrent JIT compiler. But ENABLE_CONCURRENT_JS does not reflect this.
In this patch, we fix two things.
- We should make ConcurrentJSLock always Lock. In 64bit environment we are supporting actively (including watchOS ARM64_32), we are enabling ENABLE(JIT) regardless of we are actually using JIT. So, anyway, this is already a Lock. Flipping these bits does not matter in 32bit architectures since they do not have concurrent compilers anyway. This makes things simpler: it is always a Lock. And concurrent collector can use it.
- We should make
ENABLE(CONCURRENT_JS)ON whenENABLE(JIT)is true, to reflect the fact that Baseline JIT has concurrent compiler.
- runtime/ConcurrentJSLock.h:
(JSC::ConcurrentJSLocker::ConcurrentJSLocker):
Source/WTF:
BaselineJIT also has concurrent compiler. ENABLE(CONCURRENT_JS) should not rely on ENABLE(DFG_JIT).
It should rely on ENABLE(JIT) instead.
- wtf/Platform.h:
- 3:54 PM Changeset in webkit [251306] by
-
- 16 edits2 adds in trunk
Web Inspector: Elements: allow WebKit engineers to edit UserAgent shadow trees
https://bugs.webkit.org/show_bug.cgi?id=203159
Reviewed by Brian Burg.
Source/JavaScriptCore:
- inspector/protocol/DOM.json:
Add
setAllowEditingUserAgentShadowTreescommand.
Source/WebCore:
Test: inspector/dom/setAllowEditingUserAgentShadowTrees.html
- inspector/agents/InspectorDOMAgent.h:
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::assertEditableNode):
(WebCore::InspectorDOMAgent::setInspectedNode):
(WebCore::InspectorDOMAgent::setAllowEditingUserAgentShadowTrees): Added.
Source/WebInspectorUI:
- UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.initializeTarget):
(WI.DOMManager.supportsEditingUserAgentShadowTrees): Added.
- UserInterface/Models/CSSStyleDeclaration.js:
(WI.CSSStyleDeclaration.prototype.get editable):
- UserInterface/Views/ContextMenuUtilities.js:
(WI.appendContextMenuItemsForDOMNode):
- UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype.get editable):
(WI.DOMTreeElement.prototype._startEditingTarget):
(WI.DOMTreeElement.prototype.populateDOMNodeContextMenu):
- UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel):
(WI.GeneralStyleDetailsSidebarPanel.prototype._showPanel):
(WI.GeneralStyleDetailsSidebarPanel.prototype._handleNodeChanged): Added.
- UserInterface/Views/StyleDetailsPanel.js:
(WI.StyleDetailsPanel.prototype.get supportsNewRule): Added.
(WI.StyleDetailsPanel.prototype.markAsNeedsRefresh):
(WI.StyleDetailsPanel.prototype.refresh):
- UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.get supportsNewRule): Added.
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.newRuleButtonClicked):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.newRuleButtonContextMenu):
Don't show the "Add Rule" button if the selected node is inside a UserAgent shadow tree.
- UserInterface/Base/Setting.js:
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createEngineeringSettingsView):
LayoutTests:
- inspector/dom/setAllowEditingUserAgentShadowTrees.html: Added.
- inspector/dom/setAllowEditingUserAgentShadowTrees-expected.txt: Added.
- 3:45 PM Changeset in webkit [251305] by
-
- 3 edits in trunk/Source/WebCore
Document::m_closeAfterStyleRecalc is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=203143
Reviewed by Antti Koivisto.
Removed the code to defer implicit close until the style recalc is done
since we call FrameLoader::checkCompleted asynchronously via a timer these days.
- dom/Document.cpp:
(WebCore::Document::resolveStyle):
(WebCore::Document::implicitClose):
- dom/Document.h:
- 3:45 PM Changeset in webkit [251304] by
-
- 5 edits in trunk/Source/WebKit
[iOS] "Unexpectedly Resumed" process assertion may cause us to get terminated
https://bugs.webkit.org/show_bug.cgi?id=203046
<rdar://problem/56179592>
Reviewed by Geoffrey Garen.
This patch implements the following to avoid getting terminated:
- Schedule the task to release the assertion on a background thread instead of the main thread so that we end up releasing the task even if the main thread is somehow hung.
- Add an invalidation handler to the process assertion which releases the assertion upon expiration.
- UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::processWasUnexpectedlyUnsuspended):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::processDidResume):
- WebProcess/WebProcess.h:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::processTaskStateDidChange):
- 3:29 PM Changeset in webkit [251303] by
-
- 10 edits2 adds in trunk
texImage2D for a half-float texture only accepts null
https://bugs.webkit.org/show_bug.cgi?id=169999
<rdar://problem/31713571>
Reviewed by Simon Fraser.
Source/WebCore:
After we initially implemented this, the extension was
modified such that texImage2D could upload to half-float
from a Uint16 array.
Test: fast/canvas/webgl/oes-texture-half-float-uint16.html
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateArrayBufferType): Accept
Uint16.
LayoutTests:
Add a new test, and update the expected results of existing tests.
- fast/canvas/webgl/oes-texture-half-float-uint16-expected.txt: Added.
- fast/canvas/webgl/oes-texture-half-float-uint16.html: Added.
- webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt:
- webgl/2.0.0/conformance2/extensions/ext-color-buffer-float-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt:
- 3:27 PM Changeset in webkit [251302] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Elements: $0 is shown for the wrong node when selecting elements in a user agent shadow tree
https://bugs.webkit.org/show_bug.cgi?id=203155
Reviewed by Matt Baker.
Rather than naively using the last selected node (from
WI.TreeOutline), we should wait
to see if the inspected page's DOM agent allows the selected node to be used as the
inspected node, and if so then to show the$0.
- UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.setInspectedNode):
- UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView):
- UserInterface/Views/DOMTreeOutline.js:
(WI.DOMTreeOutline.prototype._handleInspectedNodeChanged): Added.
- UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom li.inspected-node > span::after): Added.
(.tree-outline.dom:focus li.inspected-node.selected > span::after): Added.
(.tree-outline.dom.show-last-selected li.last-selected > span::after): Deleted.
(.tree-outline.dom.show-last-selected:focus li.last-selected > span::after): Deleted.
- UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.selectionControllerSelectionDidChange):
- 3:23 PM Changeset in webkit [251301] by
-
- 2 edits in trunk/LayoutTests
fast/events/ios/forward-delete-in-editable.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=203049
<rdar://problem/52969457>
Reviewed by Wenson Hsieh.
Now that <rdar://problem/45772078> is fixed we can write the test such that we check the test
result after we receive a DOM key up for the forward delete. Currently the test makes use of a
workaround that incorrectly assumes that the keyboard will call back into WebKit to perform the
forward deletion before the web process blur()s the field. This is not guaranteed to happen.
Instead wait until we receive a DOM key up for the delete key.
- fast/events/ios/forward-delete-in-editable.html:
- 3:21 PM Changeset in webkit [251300] by
-
- 2 edits in trunk/LayoutTests
Layout Test http/tests/security/contentSecurityPolicy/iframe-allowed-when-loaded-via-javascript-url.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=202481
<rdar://problem/55916200>
Reviewed by Youenn Fablet.
Have the iframe's document call testRunner.notifyDone() instead of assuming that the document will
be loaded by the next turn of the event loop.
- http/tests/security/contentSecurityPolicy/iframe-allowed-when-loaded-via-javascript-url.html:
- 3:16 PM Changeset in webkit [251299] by
-
- 4 edits in trunk
REGRESSION (r241747): [iOS] Adjust default SVG focus ring width to match width for HTML documents
https://bugs.webkit.org/show_bug.cgi?id=203011
Reviewed by Wenson Hsieh.
Source/WebCore:
Update default user agent stylesheet for SVG documents (i.e. .svg resources) to use the same 3px
outline width for focused elements as we do for HTML documents.
This makes the test imported/blink/svg/custom/focus-ring-2.svg pass on iOS.
- css/svg.css:
LayoutTests:
Remove the test imported/blink/svg/custom/focus-ring-2.svg now that it passes, again.
- platform/ios/TestExpectations:
- 3:00 PM Changeset in webkit [251298] by
-
- 21 edits3 copies3 moves4 adds1 delete in trunk
Add experimental HDR MediaCapabilities support.
https://bugs.webkit.org/show_bug.cgi?id=203113
Reviewed by Eric Carlson.
Source/WebCore:
Tests: media/mediacapabilities/mock-decodingInfo-hdr.html
platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr.html
Add support for MediaCapabilities.decodeInfo() HDR support detection.
Add new enum IDL types to MediaCapabilities and remove old unused ones. Add
mock implementation for HDR detection. Add Cocoa platform implementation.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/mediacapabilities/ColorGamut.idl:
- Modules/mediacapabilities/HdrMetadataType.idl:
- Modules/mediacapabilities/ScreenLuminance.h:
- Modules/mediacapabilities/TransferFunction.idl:
- Modules/mediacapabilities/VideoConfiguration.idl:
- Scripts/GenerateSettings.rb:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGenerator.pm:
(WK_ucfirst):
- bindings/scripts/CodeGeneratorJS.pm:
(ToMethodName):
- page/Settings.yaml:
- platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:
(WebCore::createMediaPlayerDecodingConfigurationCocoa):
- platform/mediacapabilities/ColorGamut.h:
- platform/mediacapabilities/HdrMetadataType.h:
- platform/mediacapabilities/TransferFunction.h:
- platform/mediacapabilities/VideoConfiguration.h:
- platform/mock/MediaEngineConfigurationFactoryMock.cpp:
(WebCore::canDecodeMedia):
(WebCore::canEncodeMedia):
Source/WebKit:
Add experimental hdrMediaCapabilitiesEnabled preference.
- Shared/WebPreferences.yaml:
LayoutTests:
- media/mediacapabilities/mock-decodingInfo-alphaChannel-expected.txt:
- media/mediacapabilities/mock-decodingInfo-hdr-expected.txt: Added.
- media/mediacapabilities/mock-decodingInfo-hdr.html: Added.
- platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr-expected.txt: Added.
- platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr.html: Added.
- 2:33 PM Changeset in webkit [251297] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION(r251254): Elements: forced pseudo-class indicator isn't visible for selected nodes
https://bugs.webkit.org/show_bug.cgi?id=203158
Reviewed by Matt Baker.
- UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom li > :not(.selection-area)): Added.
(.tree-outline.dom li > span): Deleted.
- 2:30 PM Changeset in webkit [251296] by
-
- 2 edits in trunk/Tools
Unreviewed, remove an extraneous header import after r251279
Address a post-landing review comment.
- DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
- 1:55 PM Changeset in webkit [251295] by
-
- 58 edits3 copies2 deletes in trunk
[WebAuthn] Implement AuthenticatorCancel
https://bugs.webkit.org/show_bug.cgi?id=191523
<rdar://problem/55920204>
Reviewed by Brent Fulgham.
Source/WebCore:
Covered by new tests in existing test files.
- Modules/credentialmanagement/CredentialsContainer.cpp:
(WebCore::CredentialsContainer::get):
(WebCore::CredentialsContainer::isCreate):
- Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):
- Modules/webauthn/AuthenticatorCoordinator.h:
- Modules/webauthn/AuthenticatorCoordinatorClient.cpp: Removed.
- Modules/webauthn/AuthenticatorCoordinatorClient.h:
- Modules/webauthn/PublicKeyCredential.cpp:
(WebCore::PublicKeyCredential::tryCreate):
- Modules/webauthn/PublicKeyCredential.h:
- Modules/webauthn/PublicKeyCredentialData.h:
- Modules/webauthn/fido/DeviceRequestConverter.h:
- Modules/webauthn/fido/FidoHidMessage.cpp:
(fido::FidoHidMessage::FidoHidMessage):
- Modules/webauthn/fido/FidoHidPacket.cpp:
(fido::FidoHidInitPacket::getSerializedData const):
(fido::FidoHidContinuationPacket::getSerializedData const):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- testing/MockWebAuthenticationConfiguration.h:
(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::decode):
- testing/MockWebAuthenticationConfiguration.idl:
Adds a new option to test AuthenticatorCancel.
Source/WebKit:
This patch implement two ways to cancel a pending WebAuthn ceremony:
1) Via navigation activities. Activities include i) main frame navigation, ii) main frame reload,
iii) main frame destruction, iv) sub frame navigation, and v) sub frame destruction. All the above
activities will cancel any pending WebAuthn ceremony that is associated with the frame. To prove
the association, a GlobalFrameIdentifier is bridged into WebAuthenticationRequestData. Navigation
cancel is done in WebPageProxy::didStartProvisionalLoadForFrameShared, and destruction cancel is done
in WebProcessProxy::didDestroyFrame and WebPageProxy::resetState.
2) Via UI. This path is simply bridged -[_WKWebAuthenticationPanel cancel] into AuthenticatorManager.
Noted, this patch follows the spec to wait until time out to notify RPs.
References: i) Step 20 of https://www.w3.org/TR/webauthn/#createCredential, ii) Step 18 of
https://www.w3.org/TR/webauthn/#getAssertion
As for what the cancel actually does, it:
1) stops any HID/NFC scanning;
2) sends CTAPHID_CANCEL to any HID authenticators that have been added. Reference:
https://fidoalliance.org/specs/fido-v2.0-ps-20190130/fido-client-to-authenticator-protocol-v2.0-ps-20190130.html#usb-hid-cancel
Sending CTAPHID_CANCEL, however, is not trivial. An abstract class FidoAuthenticator is crafted to
do this labor for both CtapAuthenticator and U2fAuthenticator during the time of destructions.
Noted: The CtapHidDriver is the only CtapDriver implements the cancel method. Since the message
is sent during state reset, lifecycle of the HidConenction and HidService which manage the underlying
IOHIDDeviceRef is very hard to hold. This is required for the regular async sender. Therefore,
HidConnection::sendSync is crafted to send the message synchronously to get rid of the tediousness
of managing those lifecycles.
P.S. Vector::grow doesn't initialize POD types. Therefore, this patch also appends it with memset
for FidoHidPacket.
P.S.S. This patch also simplifies AuthenticatorCoordinatorClient by: i) moving code from AuthenticatorCoordinatorClient
to WebAuthenticatorCoordinatorClient, and ii) using sendWithAsyncReply. The latter allows us to
get rid of the complex mechanism of ensuring the right reply is returned.
- DerivedSources.make:
- Sources.txt:
- UIProcess/API/APIWebAuthenticationPanel.cpp:
(API::WebAuthenticationPanel::create):
(API::WebAuthenticationPanel::WebAuthenticationPanel):
(API::WebAuthenticationPanel::cancel const):
- UIProcess/API/APIWebAuthenticationPanel.h:
- UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(-[_WKWebAuthenticationPanel cancel]):
- UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::cancelRequest):
(WebKit::AuthenticatorManager::clearState):
(WebKit::AuthenticatorManager::runPanel):
(WebKit::AuthenticatorManager::resetState):
- UIProcess/WebAuthentication/AuthenticatorManager.h:
- UIProcess/WebAuthentication/Cocoa/HidConnection.h:
(WebKit::HidConnection::isInitialized const):
(WebKit::HidConnection::setIsInitialized):
- UIProcess/WebAuthentication/Cocoa/HidConnection.mm:
(WebKit::HidConnection::~HidConnection):
(WebKit::HidConnection::initialize):
(WebKit::HidConnection::terminate):
(WebKit::HidConnection::sendSync):
(WebKit::HidConnection::send):
(WebKit::HidConnection::registerDataReceivedCallback):
- UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::initialize):
(WebKit::MockHidConnection::terminate):
(WebKit::MockHidConnection::sendSync):
(WebKit::MockHidConnection::send):
(WebKit::MockHidConnection::feedReports):
- UIProcess/WebAuthentication/Mock/MockHidConnection.h:
- UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
(WebKit::WebAuthenticatorCoordinatorProxy::makeCredential):
(WebKit::WebAuthenticatorCoordinatorProxy::getAssertion):
(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
(WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable):
(WebKit::WebAuthenticatorCoordinatorProxy::requestReply): Deleted.
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
- UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::CtapAuthenticator):
(WebKit::CtapAuthenticator::makeCredential):
(WebKit::CtapAuthenticator::getAssertion):
(WebKit::CtapAuthenticator::tryDowngrade):
- UIProcess/WebAuthentication/fido/CtapAuthenticator.h:
- UIProcess/WebAuthentication/fido/CtapDriver.h:
(WebKit::CtapDriver::cancel):
- UIProcess/WebAuthentication/fido/CtapHidDriver.cpp:
(WebKit::CtapHidDriver::Worker::write):
(WebKit::CtapHidDriver::Worker::read):
(WebKit::CtapHidDriver::Worker::returnMessage):
(WebKit::CtapHidDriver::Worker::reset):
(WebKit::CtapHidDriver::Worker::cancel):
(WebKit::CtapHidDriver::continueAfterChannelAllocated):
(WebKit::CtapHidDriver::continueAfterResponseReceived):
(WebKit::CtapHidDriver::returnResponse):
(WebKit::CtapHidDriver::reset):
(WebKit::CtapHidDriver::cancel):
- UIProcess/WebAuthentication/fido/CtapHidDriver.h:
- UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp: Copied from Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.cpp.
(WebKit::FidoAuthenticator::FidoAuthenticator):
(WebKit::FidoAuthenticator::~FidoAuthenticator):
(WebKit::FidoAuthenticator::driver const):
(WebKit::FidoAuthenticator::releaseDriver):
- UIProcess/WebAuthentication/fido/FidoAuthenticator.h: Copied from Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.cpp.
- UIProcess/WebAuthentication/fido/FidoService.cpp:
(WebKit::FidoService::continueAfterGetInfo):
- UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:
(WebKit::U2fAuthenticator::U2fAuthenticator):
(WebKit::U2fAuthenticator::issueCommand):
- UIProcess/WebAuthentication/fido/U2fAuthenticator.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didDestroyFrame):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:
(WebKit::WebAuthenticatorCoordinator::WebAuthenticatorCoordinator):
(WebKit::WebAuthenticatorCoordinator::makeCredential):
(WebKit::WebAuthenticatorCoordinator::getAssertion):
(WebKit::WebAuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable):
(WebKit::WebAuthenticatorCoordinator::~WebAuthenticatorCoordinator): Deleted.
- WebProcess/WebAuthentication/WebAuthenticatorCoordinator.h:
- WebProcess/WebAuthentication/WebAuthenticatorCoordinator.messages.in: Removed.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::fromCoreFrame):
- WebProcess/WebPage/WebFrame.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-cancel.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html.
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html:
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html:
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html:
LayoutTests:
Modified one of the error message that is no longer emitted.
- http/wpt/webauthn/public-key-credential-create-failure.https.html:
- http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
- http/wpt/webauthn/public-key-credential-get-failure.https.html:
- http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
- 12:44 PM Changeset in webkit [251294] by
-
- 3 edits in trunk/LayoutTests
Flaky Test: fast/events/resize-subframe-in-rendering-update.html
https://bugs.webkit.org/show_bug.cgi?id=203140
Reviewed by Simon Fraser.
The flakiness was caused by the race condition between rAF and setTimeout. In many cases,
setTimeout was getting scheduled after the next rAF and prevented some assertions to run in time.
Fixed the flakiness by moving setTimeout to outside the setTimeout in which tests run so that
those assertions would always run.
Rebaselined the test since these assertions in setTimeout are now always included in the results.
- fast/events/resize-subframe-in-rendering-update-expected.txt:
- fast/events/resize-subframe-in-rendering-update.html:
- 12:18 PM Changeset in webkit [251293] by
-
- 2 edits in trunk/Tools
Cleanup: Stop setting -ApplePersistenceIgnoreState when running debug Mac WebKit
https://bugs.webkit.org/show_bug.cgi?id=203156
Reviewed by Jonathan Bedard.
This is no longer needed. The new value has been supported since 2014.
- Scripts/webkitdirs.pm:
(argumentsForRunAndDebugMacWebKitApp):
- 11:54 AM Changeset in webkit [251292] by
-
- 5 edits in trunk/Source/WebCore
Add TextStream dumping for BasicShape types
https://bugs.webkit.org/show_bug.cgi?id=203150
Reviewed by Zalan Bujtas.
Add dumping for the classes, and make the BasicShape enum an enum class.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeCircle::dump const):
(WebCore::BasicShapeEllipse::dump const):
(WebCore::BasicShapePolygon::dump const):
(WebCore::BasicShapePath::dump const):
(WebCore::BasicShapeInset::dump const):
(WebCore::operator<<):
- rendering/style/BasicShapes.h:
(WebCore::BasicShapeCenterCoordinate::BasicShapeCenterCoordinate):
- 11:46 AM Changeset in webkit [251291] by
-
- 2 edits in trunk/Source/WebCore
ElementRuleCollector function signature cleanups
https://bugs.webkit.org/show_bug.cgi?id=203153
<rdar://problem/56412684>
Unreviewed followup.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::transferMatchedRules):
Try to appease MSVC.
- 11:29 AM Changeset in webkit [251290] by
-
- 28 edits4 adds12 deletes in trunk
Load event must be fired only for the SVG structurally external elements and the outermost SVG element
https://bugs.webkit.org/show_bug.cgi?id=203044
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-10-18
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/svg/geometry/svg-image-intrinsic-size-with-cssstyle-auto-expected.txt:
The timeout issues are now fixed. webkit.org/b/202013 will fix the other
failures.
- web-platform-tests/svg/images/20x20.png: Added.
Add an image which is referenced by these tests:
web-platform-tests/svg/import/styling-pres-02-f-manual.svg
web-platform-tests/svg/import/struct-use-01-t-manual.svg
web-platform-tests/svg/import/interact-events-02-b-manual.svg
- web-platform-tests/svg/linking/scripted/href-script-element-expected.txt:
Source/WebCore:
The SVG1.1 spec for SVGLoad event is:
The SVG2 spec for the load event is:
https://www.w3.org/TR/SVG/changes.html#interact
https://www.w3.org/TR/SVG/interact.html
SVG2 removes the SVGExternalResourcesRequired interface. It also simplifies
the rules for firing the load event and made them consistent with the HTML
specs. The plan is to remove SVGExternalResourcesRequired in a following
patch. This patch makes SVGExternalResourcesRequired have no effect on the
load event firing rules. It moves all the functionalities to SVGURIReference
as a step towards removing the SVGExternalResourcesRequired interface.
Test: svg/custom/image-load-event.html
- dom/Document.cpp:
(WebCore::Document::implicitClose):
Do not use the SVGLoad term. It has been removed from the specs.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
- dom/ScriptElement.h:
(WebCore::ScriptElement::errorOccurred const):
(WebCore::ScriptElement::setErrorOccurred):
Add a method to track the occurrence of loading error. errorOccurred()
haveFiredLoadEvent() means no pending loading activity. - svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::dispatchLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): Deleted.
- svg/SVGDocumentExtensions.h:
Do not use the SVGLoad term.
- svg/SVGElement.cpp:
(WebCore::SVGElement::sendLoadEventIfPossible):
(WebCore::SVGElement::loadEventTimerFired):
(WebCore::SVGElement::loadEventTimer):
(WebCore::SVGElement::finishParsingChildren):
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Deleted.
(WebCore::SVGElement::sendSVGLoadEventIfPossibleAsynchronously): Deleted.
(WebCore::SVGElement::svgLoadEventTimerFired): Deleted.
(WebCore::SVGElement::svgLoadEventTimer): Deleted.
- svg/SVGElement.h:
finishParsingChildren() won't fire 'load' event anymore. The 'load' event
will be fired explicitly for the outermost SVG element from Document::implicitClose().
- svg/SVGExternalResourcesRequired.cpp:
(WebCore::SVGExternalResourcesRequired::svgAttributeChanged):
(WebCore::SVGExternalResourcesRequired::dispatchLoadEvent): Deleted.
(WebCore::SVGExternalResourcesRequired::insertedIntoDocument): Deleted.
(WebCore::SVGExternalResourcesRequired::finishParsingChildren): Deleted.
(WebCore::SVGExternalResourcesRequired::haveLoadedRequiredResources const): Deleted.
- svg/SVGExternalResourcesRequired.h:
(WebCore::SVGExternalResourcesRequired::setHaveFiredLoadEvent): Deleted.
(WebCore::SVGExternalResourcesRequired::isParserInserted const): Deleted.
(WebCore::SVGExternalResourcesRequired::haveFiredLoadEvent const): Deleted.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::haveLoadedRequiredResources):
- svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::dispatchLoadEvent):
The value of externalResourcesRequired() no longer controls firing the
'load' event.
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::SVGScriptElement):
(WebCore::SVGScriptElement::insertedIntoAncestor):
(WebCore::SVGScriptElement::dispatchErrorEvent):
(WebCore::SVGScriptElement::finishParsingChildren): Deleted.
- svg/SVGScriptElement.h:
dispatchErrorEvent() is now a virtual function. Let SVGScriptElement
overrides it so it can track when the loader finishes its activity.
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::SVGStyleElement):
- svg/SVGStyleElement.h:
- svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::contextElement const):
(WebCore::SVGURIReference::parseAttribute):
(WebCore::SVGURIReference::haveLoadedRequiredResources const):
(WebCore::SVGURIReference::dispatchLoadEvent):
- svg/SVGURIReference.h:
(WebCore::SVGURIReference::haveFiredLoadEvent const):
(WebCore::SVGURIReference::setHaveFiredLoadEvent):
(WebCore::SVGURIReference::errorOccurred const):
(WebCore::SVGURIReference::setErrorOccurred):
SVGURIReference will decide whether the 'load' event can be fired or not.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::insertedIntoAncestor):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::finishParsingChildren): Deleted.
(WebCore::SVGUseElement::isValid const): Deleted.
(WebCore::SVGUseElement::haveLoadedRequiredResources): Deleted.
(WebCore::SVGUseElement::setHaveFiredLoadEvent): Deleted.
(WebCore::SVGUseElement::haveFiredLoadEvent const): Deleted.
(WebCore::SVGUseElement::svgLoadEventTimer): Deleted.
- svg/SVGUseElement.h:
SVGUseElement needs to track firing the load event or error occurrence
the same way SVGImageElement and SVGScriptElement do.
LayoutTests:
- fast/dom/crash-moving-subtree-between-documents.html:
- fast/dom/focus-style-resolution.html:
- fast/html/marquee-reparent-check.html:
The SVGElement element should not fire "load" event. Set the HTML <body>
element's "onload" event handler to be the function which was set to the
SVGElement's "onload" event handler.
- svg/custom/image-load-event-expected.html: Added.
- svg/custom/image-load-event.html: Added.
Images with external resources or data URIs must fire load events once
the data is loaded or decoded.
- svg/custom/loadevents-async-expected.txt: Removed.
- svg/custom/loadevents-async.html: Removed.
- svg/custom/loadevents-capturing-expected.txt: Removed.
- svg/custom/loadevents-capturing.svg: Removed.
- svg/custom/loadevents-externalresourcesrequired-displaynone-expected.txt: Removed.
- svg/custom/loadevents-externalresourcesrequired-displaynone.svg: Removed.
- svg/custom/loadevents-externalresourcesrequired-expected.txt: Removed.
- svg/custom/loadevents-externalresourcesrequired.svg: Removed.
- svg/custom/loadevents-normal-displaynone-expected.txt: Removed.
- svg/custom/loadevents-normal-displaynone.svg: Removed.
- svg/custom/loadevents-normal-expected.txt: Removed.
- svg/custom/loadevents-normal.svg: Removed.
These tests were implementing the SVG1.1 SVGLoad event interactivity:
https://www.w3.org/TR/SVG11/interact.html where every SVG element had to
fire the SVGLoad event once it parsed its closing tag. SVG structurally
external elements were firing load events when the corresponding external
resources had finished loading but only if externalResourcesRequired = true.
- svg/dom/SVGScriptElement/script-load-and-error-events.svg:
This test had two wrong assumptions:
1) The SVG structurally external element fires a load event when parsing
the children finishes. Then they may fire another load or error event if
externalResourcesRequired = true.
2) The outermost SVG element will not fire its load event unless all the
children fires their load events correctly.
- 11:08 AM Changeset in webkit [251289] by
-
- 4 edits in trunk/Source/WebCore
ElementRuleCollector function signature cleanups
https://bugs.webkit.org/show_bug.cgi?id=203153
Reviewed by Zalan Bujtas.
Many functions in ElementRuleCollector take repetitive arguments that can be removed:
- Make includeEmptyRules argument a class member
- Remove RuleRange argument, update the ranges in rule transfer step.
- css/ElementRuleCollector.cpp:
(WebCore::MatchRequest::MatchRequest):
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::transferMatchedRules):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchesAnyAuthorRules):
(WebCore::ElementRuleCollector::collectMatchingAuthorRules):
(WebCore::ElementRuleCollector::matchAuthorShadowPseudoElementRules):
(WebCore::ElementRuleCollector::matchHostPseudoClassRules):
(WebCore::ElementRuleCollector::matchSlottedPseudoElementRules):
(WebCore::ElementRuleCollector::matchPartPseudoElementRules):
(WebCore::ElementRuleCollector::matchPartPseudoElementRulesForScope):
(WebCore::ElementRuleCollector::collectMatchingShadowPseudoElementRules):
(WebCore::ElementRuleCollector::collectSlottedPseudoElementRulesForSlot):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::matchUARules):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::ElementRuleCollector::matchAllRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
- css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::setIncludeEmptyRules):
(WebCore::ElementRuleCollector::transferMatchedRules):
Range update happens now here based on the supplied argument.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
- 10:35 AM Changeset in webkit [251288] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r251262): Layout Test scrollingcoordinator/ios/non-stable-viewport-scroll.html is a Flaky Failure
https://bugs.webkit.org/show_bug.cgi?id=203157
Unreviewed Test Gardening.
- platform/ios-simulator-wk2/TestExpectations: Marked
scrollingcoordinator/ios/non-stable-viewport-scroll.html as flaky
- 9:58 AM Changeset in webkit [251287] by
-
- 3 edits in trunk/LayoutTests
[iOS] Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is frequently failing or timing out (198185)
https://bugs.webkit.org/show_bug.cgi?id=198185
<rdar://problem/51074251>
Patch by Kate Cheney <Kate Cheney> on 2019-10-18
Reviewed by Youenn Fablet.
Fixes a flaky failure caused by test results being checked before data
records have finished processing. This patch uses a callback to
ensure data processing has finished before continuing.
- http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html:
- platform/ios-wk2/TestExpectations:
- 9:28 AM Changeset in webkit [251286] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: Layout Test webgl/many-contexts.html is a flaky timeout on Mojave
https://bugs.webkit.org/show_bug.cgi?id=198867
Unreviewed test gardening
- platform/mac/TestExpectations:
- 9:20 AM Changeset in webkit [251285] by
-
- 9 edits in trunk
[CSS Shadow Parts] :part rules should be able to override style attribute
https://bugs.webkit.org/show_bug.cgi?id=202919
Reviewed by Zalan Bujtas.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-shadow-parts/simple-inline-expected.txt:
Source/WebCore:
Element inline style was simply appended to the matching declaration list and not sorted with the rest of the author style.
This used to work because before CSS Shadow Parts feature inline style would always win.
Fixing this involves refactoring the rule collection code to remove this assumption.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::addMatchedRule):
Both initialize and update ranges here.
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::addElementStyleProperties):
Both initialize and update ranges here.
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
Split out transfering to a separate function.
(WebCore::ElementRuleCollector::transferMatchedRules):
Add a parameter to limit transfer to rules from a scope.
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchesAnyAuthorRules):
Replace hasMatchedRules() with a more specific function. This can use collectMatchingAuthorRules and avoids unnecessary sorting step.
(WebCore::ElementRuleCollector::collectMatchingAuthorRules):
Split out collecting the rules from matchAuthorRules. Like other collect functions, this doesn't do any sorting.
(WebCore::ElementRuleCollector::matchAllRules):
Add element inline style before transfering rules from the containing host scope.
(WebCore::ElementRuleCollector::addElementInlineStyleProperties):
Factor adding inline style into a function.
- 9:14 AM Changeset in webkit [251284] by
-
- 2 edits in trunk/Source/WebCore
[LFC][TFC] Include horizontal spacing when checking for the extra horizontal space
https://bugs.webkit.org/show_bug.cgi?id=203154
<rdar://problem/56408032>
Reviewed by Antti Koivisto.
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace):
- 9:12 AM Changeset in webkit [251283] by
-
- 2 edits in trunk/Source/WebCore
[LFC][TFC] Fix table's total horizontal spacing computation
https://bugs.webkit.org/show_bug.cgi?id=203151
<rdar://problem/56406930>
Reviewed by Antti Koivisto.
The horizontal spacing value sets the gaps between
- first column and the left edge of the table's content box
- between 2 columns
- last column and the right edge of the table's content box
In case of 'n' columns, the number of gaps is 'n + 1'.
- layout/tableformatting/TableGrid.h:
(WebCore::Layout::TableGrid::totalHorizontalSpacing const):
- 9:11 AM Changeset in webkit [251282] by
-
- 4 edits in trunk/Source/WebCore
[LFC][TFC] Cache table's width constraint values.
https://bugs.webkit.org/show_bug.cgi?id=203135
<rdar://problem/56396352>
Reviewed by Antti Koivisto.
This patch ensures that when computedIntrinsicWidthConstraints is called from both the preferred width and the actual layout codepaths during a layout frame, we don't
end up building up the grid twice.
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::TableFormattingContext::computePreferredWidthForColumns):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace):
- layout/tableformatting/TableGrid.cpp:
(WebCore::Layout::TableGrid::widthConstraints):
(WebCore::Layout::TableGrid::widthConstraints const): Deleted.
- layout/tableformatting/TableGrid.h:
(WebCore::Layout::TableGrid::hasComputedWidthConstraints const):
- 9:09 AM Changeset in webkit [251281] by
-
- 4 edits in trunk/Source/WebCore
[LFC][BFC] TableFormattingContext::computedIntrinsicWidthConstraints should not expect a valid containing block's width
https://bugs.webkit.org/show_bug.cgi?id=203131
<rdar://problem/56394676>
Reviewed by Antti Koivisto.
When TableFormattingContext::computedIntrinsicWidthConstraints is called by the preferred width computation (<div style="float: left"><table>)
the containing block's width is not yet set (it gets computed based on the preferred width) so computedIntrinsicWidthConstraints should not be relying
on it. Let's move that logic out to TableFormattingContext::layoutInFlowContent() where it belongs.
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::TableFormattingContext::ensureTableGrid):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace):
(WebCore::Layout::TableFormattingContext::computedTableWidth): Deleted.
(WebCore::Layout::TableFormattingContext::distributeExtraHorizontalSpace): Deleted.
- layout/tableformatting/TableFormattingContext.h:
- 7:54 AM Changeset in webkit [251280] by
-
- 2 edits in trunk/Source/WebCore
[LFC][BFC] Fix block level formatting root inflow box height computation
https://bugs.webkit.org/show_bug.cgi?id=203085
<rdar://problem/56372306>
Reviewed by Antti Koivisto.
Section 10.6.7 (https://www.w3.org/TR/CSS22/visudet.html#root-height) defines the height computation for block level formatting context roots.
We already use it for floats, out-of-flow and block level boxes when overflow computes to not "visible".
This patch makes generic in-flow non-replaced BFC roots (e.g. principal block container box for <table>) compute their heights according to 10.6.7.
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- 7:24 AM Changeset in webkit [251279] by
-
- 27 edits1 copy6 adds in trunk
[Clipboard API] Support navigator.clipboard.read()
https://bugs.webkit.org/show_bug.cgi?id=203021
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline a web platform test, now that Clipboard.read() no longer immediately rejects.
- web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https-expected.txt:
Source/WebCore:
Add support for navigator.clipboard.read(), which returns a promise that resolves to a list of ClipboardItems.
See below for more details.
Tests: editing/async-clipboard/clipboard-change-data-while-reading.html
editing/async-clipboard/clipboard-read-basic.html
- Modules/async-clipboard/Clipboard.cpp:
(WebCore::Clipboard::read):
Implement read(). This makes two calls to the platform pasteboard: the first to get the current change count,
and if the change count is different from the changeCount used for the last read() call (or there are no
existing clipboard items being tracked), then we request pasteboard item information for all items on the
pasteboard, and use this information to create new clipboard items. Otherwise, if the changeCount is still valid
for the current list of clipboard items, simply return these clipboard items.
If the changeCount ends up being different in between the initial changeCount request and when the pasteboard
item information is received, we immediately bail with a NotAllowedError. The new layout test
clipboard-change-data-while-reading.html exercises this scenario.
(WebCore::Clipboard::getType):
(WebCore::Clipboard::frame const):
- Modules/async-clipboard/Clipboard.h:
- Modules/async-clipboard/ClipboardItem.cpp:
(WebCore::ClipboardItem::blobFromString):
(WebCore::ClipboardItem::ClipboardItem):
(WebCore::ClipboardItem::create):
(WebCore::ClipboardItem::navigator):
Refactor this so that each clipboard item itself has a WeakPtr to its Navigator. This avoids having to follow
the weak pointer to the Clipboard to get to the Clipboard's navigator during garbage collection when computing
reachability from opaque roots, since this may happen on a background (GC) thread.
(WebCore::ClipboardItem::clipboard):
- Modules/async-clipboard/ClipboardItem.h:
- Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
(WebCore::ClipboardItemBindingsDataSource::getType):
(WebCore::blobFromString): Deleted.
Move this to ClipboardItem, and make it a static method.
- Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp:
(WebCore::ClipboardItemPasteboardDataSource::ClipboardItemPasteboardDataSource):
(WebCore::ClipboardItemPasteboardDataSource::getType):
- Modules/async-clipboard/ClipboardItemPasteboardDataSource.h:
Move a couple of member variables (index and changeCount) out of ClipboardItem. Instead of having each
ClipboardItem keep track of this information, have the Clipboard that owns the ClipboardItem keep this
information. This means that reading data from ClipboardItem will (in a future patch) work by having the item
ask its Clipboard object to read data on its behalf.
- platform/Pasteboard.cpp:
(WebCore::Pasteboard::allPasteboardItemInfo const):
(WebCore::Pasteboard::pasteboardItemInfo const):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::readBuffer):
(WebCore::Pasteboard::readURL):
Add some null checks to handle the case where there is no pasteboard strategy.
Tools:
Make adjustments to WebKitTestRunner and DumpRenderTree to support the new layout tests. See below for more
details.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
(-[LocalPasteboard pasteboardItems]):
Fixes an existing issue with the mock NSPasteboard used for layout tests. Currently, our logic for converting
the contents of the platform pasteboard to NSPasteboardItem simply writes the pasteboard data as-is to
NSPasteboardItems. However, these pasteboard types may be legacy pasteboard types, in which case
NSPasteboardItem will simply handle the call to-setData:forType:as a no-op. AppKit has logic in this
scenario to canonicalize these legacy pasteboard types to their modern counterparts, but this is absent in
DumpRenderTreePasteboard and WebKitTestRunnerPasteboard.
Address this by teaching the mock pasteboards to convert legacy types to modern types when generating platform
pasteboard items.
- TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
- TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::copyText):
Add a new UIScriptController method to write a string to the platform pasteboard. This patch adds support for
this new testing hook on macOS and iOS, in WebKit2 (WebKitTestRunner).
- TestRunnerShared/mac/NSPasteboardAdditions.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.h.
- TestRunnerShared/mac/NSPasteboardAdditions.mm: Added.
(+[NSPasteboard _modernPasteboardType:]):
Add a helper to convert legacy pasteboard types (and dynamic UTIs that map to legacy pasteboard types) to
modern pasteboard types, suitable for writing to NSPasteboardItems on macOS.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/ios/UIScriptControllerIOS.h:
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::copyText):
- WebKitTestRunner/mac/UIScriptControllerMac.h:
- WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptControllerMac::copyText):
- WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
Apply the same fix for WebKitTestRunner's mock NSPasteboard.
(-[LocalPasteboard _clearContentsWithoutUpdatingChangeCount]):
(-[LocalPasteboard clearContents]):
Make -clearContents clear out all the contents on the mock pasteboard, instead of crashing in AppKit.
(-[LocalPasteboard declareTypes:owner:]):
(-[LocalPasteboard pasteboardItems]):
LayoutTests:
- editing/async-clipboard/clipboard-change-data-while-reading-expected.txt: Added.
- editing/async-clipboard/clipboard-change-data-while-reading.html: Added.
Add a new layout test to verify that if the platform pasteboard changes in the middle of a DOM paste access
request, the promise returned by Clipboard.read() should reject, and the page should not receive any clipboard
items.
- editing/async-clipboard/clipboard-read-basic-expected.txt: Added.
- editing/async-clipboard/clipboard-read-basic.html: Added.
Add a new layout test to exercise Clipboard.read(). Since we don't support reading data from clipboard items
yet, this only checks the types of each pasteboard item. This test additionally ensures that the ClipboardItems
returned from the API are the same between calls to Clipboard.read() if the data hasn't changed.
- editing/async-clipboard/resources/async-clipboard-helpers.js:
(writeToClipboardUsingDataTransfer):
Add a new helper to synchronously write data to the clipboard using execCommand and DataTransfer API.
(async.triggerProgrammaticPaste):
Add a new helper to trigger programmatic paste by activating the given element or location. Also receives an
array of options (which, for now, just supports a single option to change the pasteboard when granting DOM paste
access).
- platform/ios-wk1/TestExpectations: Skip clipboard-change-data-while-reading.html for now in WebKit1.
- platform/mac-wk1/TestExpectations: Skip clipboard-change-data-while-reading.html for now in WebKit1.
- platform/win/TestExpectations: Skip the new layout tests on Windows for now.
- 3:40 AM Changeset in webkit [251278] by
-
- 2 edits in trunk/Source/WebKit
Avoid crashes on GCC-compiled binaries by avoiding a use-after-move
that's the result of differring call conventions.
Rubber-stamped by Carlos Garcia Campos.
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::startFetch): Copy the SW identifier from
the ServiceWorkerFetchTask before it's moved into the lambda.
- 1:35 AM Changeset in webkit [251277] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Update libwebrtc third-party abseilcpp to M78
https://bugs.webkit.org/show_bug.cgi?id=202726
<rdar://problem/56147823>
Unreviewed.
- Source/third_party/abseil-cpp/absl/strings/string_view.h:
(absl::string_view::CheckLengthInternal):
Build fix for debug bots.
- 1:29 AM Changeset in webkit [251276] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Clang][Windows] Options.cpp(317,25): error: no matching function for call to 'optionTypeSpecificIndex'
https://bugs.webkit.org/show_bug.cgi?id=203142
Unreviewed build fix
clang-cl reported a compilation error for MSVC bug workaround code of optionTypeSpecificIndex.
runtime\Options.cpp(294,12): error: variables defined in a constexpr function must be initialized
size_t index;
- runtime/Options.cpp:
(JSC::optionTypeSpecificIndex): Initialize the variable 'index'.
Oct 17, 2019:
- 10:01 PM Changeset in webkit [251275] by
-
- 6 edits in trunk
Don't put pages that have not reached the non-visually empty layout milestone in the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203108
<rdar://problem/56375671>
Reviewed by Geoff Garen.
Source/WebCore:
We don't want to go back to a visually empty page on back/forward navigation.
- history/BackForwardCache.cpp:
(WebCore::canCacheFrame):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::visuallyEmptyKey):
- page/DiagnosticLoggingKeys.h:
LayoutTests:
- http/tests/navigation/page-cache-pending-load.html:
Tweak test to add the stylesheet to the body instead of the head since a document
with a pending stylesheet before the body qualifies as visually empty. The test
would be flaky otherwise.
- 9:35 PM Changeset in webkit [251274] by
-
- 7 edits1 add in trunk
Add missing checks after calls to the sameValue() JSValue comparator.
https://bugs.webkit.org/show_bug.cgi?id=203126
<rdar://problem/56366561>
Reviewed by Saam Barati.
JSTests:
- stress/validate-exception-check-in-proxy-object-put.js: Added.
Source/JavaScriptCore:
- runtime/JSFunction.cpp:
(JSC::JSFunction::defineOwnProperty):
- runtime/JSObject.cpp:
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::validateAndApplyPropertyDescriptor):
- runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::equalTo const):
- runtime/ProxyObject.cpp:
(JSC::performProxyGet):
(JSC::ProxyObject::performPut):
(JSC::ProxyObject::performSetPrototype):
(JSC::ProxyObject::performGetPrototype):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::defineOwnProperty):
- 9:24 PM Changeset in webkit [251273] by
-
- 11 edits5 copies2 moves3 adds in trunk
Only include "deep color" in layer tree dumps if a tests requests it
https://bugs.webkit.org/show_bug.cgi?id=203125
Reviewed by Tim Horton.
Source/WebCore:
Layer tree dumping tests can fail when run on different devices because the "deep color"
property on layers is device-dependent. Stop dumping this by default, and have one test
that sets the bit. iphone-7 is the only device we test that has deep color support.
Tests: compositing/contents-format/deep-color-backing-store.html
compositing/contents-format/ipad/deep-color-backing-store.html
compositing/contents-format/iphone-7/deep-color-backing-store.html
- page/Frame.h:
- platform/graphics/GraphicsLayerClient.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
- testing/Internals.cpp:
(WebCore::toLayerTreeFlags):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- TestExpectations:
- compositing/contents-format/deep-color-backing-store-expected.txt: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.
- compositing/contents-format/deep-color-backing-store.html: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html.
- compositing/contents-format/ipad/deep-color-backing-store-expected.txt: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.
- compositing/contents-format/ipad/deep-color-backing-store.html: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html.
- compositing/contents-format/iphone-7/deep-color-backing-store-expected.txt: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.
- compositing/contents-format/iphone-7/deep-color-backing-store.html: Renamed from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html.
- platform/ipad/TestExpectations:
- platform/iphone-7/TestExpectations: Added.
- platform/mac-wk1/compositing/contents-format/deep-color-backing-store-expected.txt: Renamed from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.
- 7:27 PM Changeset in webkit [251272] by
-
- 6 edits in trunk/LayoutTests
REGRESSION (r243347) Layout tests fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on* are flakey
https://bugs.webkit.org/show_bug.cgi?id=203122
rdar://problem/50058173
Reviewed by Wenson Hsieh.
Rewrite these tests to wait for scrolling to finish, since the overflow is now accelerated and we need
to wait for momentum to end.
Also have them use UIHelper, factoring a function to work with overflow as well as document scroll.
- fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt:
- fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html:
- fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt:
- fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html:
- resources/ui-helper.js:
(window.UIHelper.callFunctionAndWaitForEvent):
(window.UIHelper.callFunctionAndWaitForScrollToFinish):
(window.UIHelper.callFunctionAndWaitForTargetScrollToFinish.return.new.Promise):
(window.UIHelper.callFunctionAndWaitForTargetScrollToFinish):
(window.UIHelper.callFunctionAndWaitForScrollToFinish.return.new.Promise): Deleted.
- 5:42 PM Changeset in webkit [251271] by
-
- 4 edits1 add in trunk
GetByVal and PutByVal on ArrayStorage need to use the same AbstractHeap
https://bugs.webkit.org/show_bug.cgi?id=203124
<rdar://problem/55988183>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/licm-array-storage-get-and-put-by-val.js: Added.
(assert):
(foo):
Source/JavaScriptCore:
- dfg/DFGAbstractHeap.h:
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- 5:29 PM Changeset in webkit [251270] by
-
- 3 edits5 adds in trunk
ctx.font = "" asserts in CSS parser
https://bugs.webkit.org/show_bug.cgi?id=203127
<rdar://problem/56391016>
Reviewed by Devin Rousso.
Source/WebCore:
The HTML specification says:
"values that cannot be parsed as CSS font values are ignored", so
return early if we get an empty string, otherwise the CSS parser
will assert. This was the only case I could find where we sidestepped
most of the parsing infrastructure and injected a raw string.
Test: http/wpt/2dcontext/text-styles/2d.text.font.parse.invalid.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
LayoutTests:
Copy the updated test from my WPT pull request. Once this
is merged into WPT, we won't need this version.
- http/wpt/2dcontext/text-styles/2d.text.font.parse.invalid-expected.txt: Added.
- http/wpt/2dcontext/text-styles/2d.text.font.parse.invalid.html: Added.
- http/wpt/resources/canvas-tests.css: Added.
- http/wpt/resources/canvas-tests.js: Added.
- 5:15 PM Changeset in webkit [251269] by
-
- 9 edits2 adds in trunk
Integrate resize event with HTML5 event loop
https://bugs.webkit.org/show_bug.cgi?id=202964
Reviewed by Geoffrey Garen.
Source/WebCore:
Dispatch resize events in "run the resize steps" during the "update the rendering":
https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering
Exisitng code in WebCore which was dispatching or scheduling dispatching of resize events now simply sets
a flag on document and schedules a rendering update. In Page::updateRendering, we fire resize events on
any documents with this flag set.
Test: fast/events/resize-subframe-in-rendering-update.html
- dom/Document.cpp:
(WebCore::Document::setNeedsDOMWindowResizeEvent): Added.
(WebCore::Document::setNeedsVisualViewportResize): Added.
(WebCore::Document::runResizeSteps): Added. https://drafts.csswg.org/cssom-view/#run-the-resize-steps
- dom/Document.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::resizeTo const):
- page/FrameView.cpp:
(WebCore::FrameView::sendResizeEventIfNeeded): Now sets m_needsDOMWindowResizeEvent on Document instead of
enqueuing a resize event.
- page/Page.cpp:
(WebCore::Page::updateRendering): Call runResizeSteps on each document.
(WebCore::Page::collectDocuments): Added.
- page/Page.h:
- page/VisualViewport.cpp:
(WebCore::VisualViewport::enqueueResizeEvent):
LayoutTests:
Added a regression test and fixed an existing test to work with the new behavior.
- fast/events/resize-subframe-in-rendering-update-expected.txt: Added.
- fast/events/resize-subframe-in-rendering-update.html: Added.
- fast/shadow-dom/trusted-event-scoped-flags.html:
- 5:02 PM Changeset in webkit [251268] by
-
- 2 edits in trunk/Source/bmalloc
[bmalloc] Bug fix for wait time when it's in mini mode.
https://bugs.webkit.org/show_bug.cgi?id=203121
Reviewed by Yusuke Suzuki.
Since r243144, m_waitTime is never changed on mini mode.
- bmalloc/Scavenger.cpp:
(bmalloc::Scavenger::threadRunLoop):
- 4:42 PM Changeset in webkit [251267] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r251255.
This is causing the existing back/forward tests to be flaky
Reverted changeset:
"Don't put pages that have not reached the non-visually empty
layout milestone in the back/forward cache"
https://bugs.webkit.org/show_bug.cgi?id=203108
https://trac.webkit.org/changeset/251255
- 4:38 PM Changeset in webkit [251266] by
-
- 1 edit1 add in trunk/LayoutTests
Land a missing test baseline
- fast/forms/ios/inputmode-none-with-hardware-keyboard-expected.txt: Added.
- 3:53 PM Changeset in webkit [251265] by
-
- 3 edits1 add in trunk/PerformanceTests
Have a CLI version of JetStream 2 to run on watchOS
https://bugs.webkit.org/show_bug.cgi?id=202998
<rdar://problem/56208554>
Reviewed by Tadeu Zagallo.
This patch adds a CLI version of JS2 to run on watchOS. We run most subtests
from the browser version of JS2, but skip a few tests that are particularly
long running, like WSL and some of WTB. We also don't run the Wasm tests
as we don't JIT on watchOS. Each test runs for fewer iterations in the watch
version. 15 is the default iteration count. This benchmark runs in 7 minutes on
a Series 4 watch.
- JetStream2/JetStreamDriver.js:
(getIterationCount):
(getWorstCaseCount):
(Driver.prototype.async.start):
(Driver.prototype.resultsJSON):
(Driver.prototype.dumpJSONResultsIfNeeded):
(Driver.prototype.async.reportScoreToRunBenchmarkRunner):
(DefaultBenchmark):
- JetStream2/RexBench/UniPoker/benchmark.js:
(Benchmark.prototype.validate):
(Benchmark):
- JetStream2/watch-cli.js: Added.
- 3:45 PM Changeset in webkit [251264] by
-
- 2 edits in trunk/Source/JavaScriptCore
Harden capacity checks in DFG::LocalCSEPhase::SmallMap.
https://bugs.webkit.org/show_bug.cgi?id=203123
<rdar://problem/56339943>
Change addPure() and addImpure() to use RELEASE_ASSERT in their capacity checks.
Reviewed by Keith Miller.
- dfg/DFGCSEPhase.cpp:
- 3:18 PM Changeset in webkit [251263] by
-
- 60 edits in trunk
Use constexpr in more places and remove some unnecessary external linkage.
https://bugs.webkit.org/show_bug.cgi?id=203115
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- API/JSWrapperMap.mm:
- heap/MarkedBlock.cpp:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
- inspector/ScriptCallStack.h:
- interpreter/CLoopStack.h:
- interpreter/CallFrame.h:
- interpreter/ShadowChicken.h:
- jit/AssemblyHelpers.cpp:
(JSC::emitRandomThunkImpl):
- jit/GPRInfo.cpp:
- jit/GPRInfo.h:
- jit/JIT.h:
- jit/PCToCodeOriginMap.cpp:
- jit/SpecializedThunkJIT.h:
- jit/ThunkGenerators.cpp:
(JSC::roundThunkGenerator):
- jit/UnusedPointer.h:
- llint/LLIntData.h:
- llint/LLIntPCRanges.h:
- parser/Lexer.h:
- parser/Nodes.h:
- runtime/CodeCache.cpp:
- runtime/CodeCache.h:
- runtime/ErrorInstance.h:
- runtime/JSAsyncFunction.h:
- runtime/JSAsyncGeneratorFunction.h:
- runtime/JSBoundFunction.h:
- runtime/JSCallee.h:
- runtime/JSFunction.h:
- runtime/JSGeneratorFunction.h:
- runtime/JSNativeStdFunction.h:
- runtime/JSRunLoopTimer.cpp:
(): Deleted.
- runtime/JSRunLoopTimer.h:
- runtime/ProxyObject.h:
- runtime/Watchdog.cpp:
(): Deleted.
- runtime/Watchdog.h:
- wasm/js/WebAssemblyFunction.h:
- wasm/js/WebAssemblyFunctionBase.h:
- wasm/js/WebAssemblyWrapperFunction.h:
Source/WebCore:
No new tests because this patch adds no new functionality.
- html/track/TextTrackCueGeneric.cpp:
- html/track/VTTCue.cpp:
- page/EventHandler.cpp:
(WebCore::SyntheticTouchPoint::SyntheticTouchPoint):
- page/FrameTree.h:
- page/scrolling/ScrollingMomentumCalculator.cpp:
(WebCore::projectedInertialScrollDistance):
- platform/graphics/FontTaggedSettings.h:
- platform/graphics/Region.cpp:
- platform/graphics/filters/FELighting.cpp:
- rendering/TableLayout.h:
- rendering/svg/SVGRenderingContext.h:
Source/WebKit:
- UIProcess/API/APIContentRuleListStore.h:
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
Source/WTF:
Also removed unused lockSpinLimit in Threading.h.
- wtf/MD5.h:
- wtf/SHA1.h:
- wtf/StackBounds.h:
- wtf/Threading.h:
Tools:
- TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
- 3:15 PM Changeset in webkit [251262] by
-
- 12 edits in trunk
[ Mojave+ ] Layout Test compositing/fixed-with-main-thread-scrolling.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=198757
Reviewed by Tim Horton.
Source/WebCore:
WheelEventTestMonitor depends on "deferral reasons" getting added and removed, such that there is always
at least one reason active until scrolling quiesces.
WheelEventTestMonitor made the incorrect assumption that every call into ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent()
would result in a scroll change making it to the main thread, so it would defer "ScrollingThreadSyncNeeded" there,
and rely on AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll() to remove that deferral reason.
That assumption is wrong, because wheel events may coalesce, or have no impact on scroll position if already scrolled
to the max/min extent (e.g. when rubber banding).
Fix by adding a new "HandlingWheelEvent" deferral reason for the duration that the scrolling thread is processing an wheel event,
and then having ScrollingThreadSyncNeeded just represent the phase where any resulting scroll is being sent to the UI process.
These phases should always overlap.
This required moving isMonitoringWheelEvents() from the root scrolling node to the ScrollingTree.
- page/WheelEventTestMonitor.cpp:
(WebCore::operator<<):
- page/WheelEventTestMonitor.h:
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitTreeState):
- page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::isMonitoringWheelEvents const):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren):
- page/scrolling/ScrollingTreeScrollingNode.h:
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):
- page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
(WebCore::ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::deferWheelEventTestCompletionForReason const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::removeWheelEventTestCompletionDeferralForReason const):
LayoutTests:
Remove expectation for compositing/fixed-with-main-thread-scrolling.html.
- platform/mac-wk2/TestExpectations:
- 3:05 PM Changeset in webkit [251261] by
-
- 10 edits in trunk
Using version 1 CFRunloopSource for faster task dispatch
https://bugs.webkit.org/show_bug.cgi?id=202874
Reviewed by Geoffrey Garen.
Source/WTF:
We used CFRunLoopWakeUp to wake up runloop to process source, which seems to be slow according to profiling. To
avoid calling CFRunLoopWakeUp, we should use version 1 CFRunloopSource instead of version 0. This patch brings
about 15% speedup for test PerformanceTests/IndexedDB/basic/objectstore-get.html.
- wtf/RunLoop.cpp:
(WTF::RunLoop::initializeWebRunLoop):
(WTF::RunLoop::web):
- wtf/RunLoop.h:
- wtf/cf/RunLoopCF.cpp:
(WTF::RunLoop::performWork):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):
- wtf/cocoa/MainThreadCocoa.mm:
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::initializeWebThread):
(-[JSWTFMainThreadCaller call]): Deleted.
Tools:
Fix a flaky test.
- TestWebKitAPI/Tests/WebKit/getUserMedia.html:
LayoutTests:
Fix a flaky test.
- inspector/css/pseudo-creation-expected.txt:
- inspector/css/pseudo-creation.html:
- 2:44 PM Changeset in webkit [251260] by
-
- 2 edits in trunk/PerformanceTests
[Linux] Avoid usage of <sys/sysctl.h> in MallocBench
https://bugs.webkit.org/show_bug.cgi?id=203109
Reviewed by Carlos Alberto Lopez Perez.
- MallocBench/MallocBench/CPUCount.cpp: Only include <sys/sysctl.h> if
the sysctl() function will be used.
- 2:39 PM Changeset in webkit [251259] by
-
- 4 edits in trunk/Tools
Python 3: Add support in webkitpy.common.net.buildbot
https://bugs.webkit.org/show_bug.cgi?id=202466
Reviewed by Stephanie Lewis.
- Scripts/test-webkitpy-python3: Add webkitpy.common.net.buildbot to the test list.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Builder.url_encoded_name): Call compatible urllib quote.
(Builder.revision_build_pairs_with_results): Convert iterator to list before returning.
(Build.results_url): Call compatible urllib quote.
(BuildBot._parse_last_build_cell):renderContents needs to be decoded in Python 3.
(BuildBot._parse_current_build_cell): BeautifulSoup and bs4 render breaks differently.
(BuildBot._fetch_build_dictionary): Call compatible urllib quote.
- Scripts/webkitpy/common/net/regressionwindow.py:
(RegressionWindow.revisions): Convert range(...) to list.
- 2:22 PM Changeset in webkit [251258] by
-
- 6 edits4 adds in trunk
Make requestIdleCallback suspendable
https://bugs.webkit.org/show_bug.cgi?id=203023
Reviewed by Chris Dumez.
Source/WebCore:
Make requestIdleCallback suspendable by making WindowEventLoop itself suspendable.
Because WindowEventLoop can be shared across documents, we don't want to make it an ActiveDOMObject.
Instead, we would make CachedFrameBase::restore and CachedFrame manually invoke suspend & resume.
Test: requestidlecallback/requestidlecallback-in-page-cache.html
- dom/Document.h:
(WebCore::Document::eventLoopIfExists): Added. This should probably go away once most of the event loop
is implemented since we're almost always going to have this object then.
- dom/WindowEventLoop.cpp:
(WebCore::WindowEventLoop::queueTask): Because m_tasks may contain tasks of suspended documents,
we check m_activeTaskCount, which is only positive when there is a task for non-suspended documents,
to decide whether we schedule a callback or not.
(WebCore::WindowEventLoop::suspend): Added. No-op for now.
(WebCore::WindowEventLoop::resume): Added. Schedule a callback if there is a task associated with
this document.
(WebCore::WindowEventLoop::run): Skip a task for a suspended document, and add it back to m_tasks along
with other tasks that got scheduled by running the current working set of tasks.
- dom/WindowEventLoop.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):
LayoutTests:
- requestidlecallback/requestidlecallback-in-page-cache-expected.txt: Added.
- requestidlecallback/requestidlecallback-in-page-cache.html: Added.
- requestidlecallback/resources: Added.
- requestidlecallback/resources/page-cache-helper.html: Added.
- 2:20 PM Changeset in webkit [251257] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix for newer versions of MSVC.
Rubber stamped by Mark Lam.
Some versions of MSVC optimize the inline optimization of
index away, triggering an uninitialized variable error. This
change avoids this problem.
- runtime/Options.cpp:
(JSC::optionTypeSpecificIndex):
- 2:02 PM Changeset in webkit [251256] by
-
- 2 edits in trunk/Tools
[ews] status bubbles should show details from all the builds in case build is retried
https://bugs.webkit.org/show_bug.cgi?id=203117
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Display messages from all the builds (including retried builds) for a patch on a queue.
(StatusBubble._steps_messages_from_multiple_builds): Method to generate status using information from all the retried builds.
(StatusBubble.get_all_builds_for_queue): Method to get all the builds instead of just the latest one.
(StatusBubble.get_latest_build_for_queue): Modified to use the new get_all_builds_for_queue() method.
- 1:31 PM Changeset in webkit [251255] by
-
- 4 edits in trunk/Source/WebCore
Don't put pages that have not reached the non-visually empty layout milestone in the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203108
Reviewed by Geoffrey Garen.
We don't want to go back to a visually empty page on back/forward navigation.
- history/BackForwardCache.cpp:
(WebCore::canCacheFrame):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::visuallyEmptyKey):
- page/DiagnosticLoggingKeys.h:
- 1:21 PM Changeset in webkit [251254] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Elements: selection shouldn't be dimmed by shadow trees
https://bugs.webkit.org/show_bug.cgi?id=203057
Reviewed by Joseph Pecoraro.
- UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom li .selection-area):
(.tree-outline.dom li > span): Added.
Don't force the.selection-areato be behind (z-index: -1;) the rest of the content, as
that also puts it behind anybackground-color. Instead, we should make all the content in
everyWI.DOMTreeElementbe above (z-index: 1;) the rest of the content, including the
.selection-areaand any parent'sbackground-color.
- 12:23 PM Changeset in webkit [251253] by
-
- 1 edit1 add in trunk/LayoutTests/imported/w3c
Remove duplicate MathML tests
https://bugs.webkit.org/show_bug.cgi?id=202979
Patch by Rob Buis <rbuis@igalia.com> on 2019-10-17
Reviewed by Frédéric Wang.
Commit r251187 removed operators/mo-form-fallback-expected.html by
accident, add it again.
- web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback-expected.html: Added.
- 12:21 PM Changeset in webkit [251252] by
-
- 14 edits2 adds in trunk
transform-box: content-box, stroke-box missing
https://bugs.webkit.org/show_bug.cgi?id=201892
Patch by Dirk Schulze <krit@webkit.org> on 2019-10-17
Reviewed by Simon Fraser.
Source/WebCore:
Added the keywords content-box and stroke-box to the
transform-box CSS property.
Those keywords were added to the spec after the implementation
in WebKit.
Test: transforms/transform-box.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TransformBox const):
- css/CSSProperties.json:
- css/CSSValueKeywords.in:
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
- rendering/RenderLayer.cpp:
(WebCore::computeReferenceBox):
(WebCore::transformBoxToCSSBoxType):
(WebCore::RenderLayer::currentTransform const):
- rendering/style/RenderStyleConstants.h:
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::animatedLocalTransform const):
LayoutTests:
- fast/css/transform-box-parsing.html:
- svg/transforms/svg-transform-box-expected.html:
- svg/transforms/svg-transform-box.html:
- transforms/transform-box-expected.html: Added.
- transforms/transform-box.html: Added.
- 12:06 PM Changeset in webkit [251251] by
-
- 4 edits in trunk/LayoutTests
[iOS Sim] Layout Test scrollingcoordinator/ios/ui-scroll-fixed.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196612
rdar://problem/49612867
Reviewed by Antti Koivisto.
This test hit a really obscure bug where a combination of an immediate scroll, and
an ancestor reposition left the layer position of a position:fixed layer unchanged.
The position of this layer in the UI process had been previously modified by
the scrolling tree for the scroll, but because the WebContent-side mutations left
the actual position unchanged, we'd never apply a new position via a commit, so left
the layer in the wrong location.
Removing the m_wasScrolledByDelegatedScrollingSincePreviousCommit check in ScrollingTree::applyLayerPositionsAfterCommit()
fixes this, but has perf implications. Alternative fixes require complex state tracking.
Since this is so hard to hit with noisy user scrolling, just change the test to avoid
the perfect storm of scrolls and offsets.
- platform/ios-simulator-wk2/TestExpectations:
- scrollingcoordinator/ios/ui-scroll-fixed-expected.html:
- scrollingcoordinator/ios/ui-scroll-fixed.html:
- 11:49 AM Changeset in webkit [251250] by
-
- 2 edits in trunk/Tools
[GTK] Explicitly use Python 2 in jhbuild-wrapper
https://bugs.webkit.org/show_bug.cgi?id=202790
Reviewed by Adrian Perez de Castro.
jhbuildutils.py requires Python 2 for the moment, so using just
pythonfails in distros where Python 3 is the default.
- jhbuild/jhbuild-wrapper:
- 11:19 AM Changeset in webkit [251249] by
-
- 3 edits in trunk/Source/WebCore
SincResampler does not need to create a new AudioBus for each consumeSource call
https://bugs.webkit.org/show_bug.cgi?id=202983
Reviewed by Eric Carlson.
Allocate an internal AudioBus once and for all.
No observable change of behavior.
- platform/audio/SincResampler.cpp:
(WebCore::SincResampler::consumeSource):
- platform/audio/SincResampler.h:
- 11:18 AM Changeset in webkit [251248] by
-
- 1 edit23 adds in trunk/Source/ThirdParty/libwebrtc
Add libwebrtc third-party pfft
https://bugs.webkit.org/show_bug.cgi?id=202733
Reviewed by Eric Carlson.
Initial check-in of pfft which is now used in libwebrtc.
- Source/third_party/pffft: Added.
- 11:15 AM Changeset in webkit [251247] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r251231.
This test is still very flakey on all platforms.
Reverted changeset:
"[GStreamer] media/video-seek-after-end.html is no longer
flakey"
https://bugs.webkit.org/show_bug.cgi?id=203079
https://trac.webkit.org/changeset/251231
- 11:13 AM Changeset in webkit [251246] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r251245.
Addressing this issue differently
Reverted changeset:
"Marking media/video-seek-after-end.html as failing"
https://bugs.webkit.org/show_bug.cgi?id=203111
https://trac.webkit.org/changeset/251245
- 10:52 AM Changeset in webkit [251245] by
-
- 2 edits in trunk/LayoutTests
Marking media/video-seek-after-end.html as failing
https://bugs.webkit.org/show_bug.cgi?id=203111
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 10:35 AM Changeset in webkit [251244] by
-
- 115 edits in trunk/Source/WebCore
Deprecate ActiveDOMObject::canSuspendForDocumentSuspension()
https://bugs.webkit.org/show_bug.cgi?id=203086
Reviewed by Geoffrey Garen.
Rename ActiveDOMObject::canSuspendForDocumentSuspension() to shouldPreventEnteringBackForwardCache_DEPRECATED()
to make it clear that no new overrides should be added and that it is no longer OK to prevent the page from
entering the back/forward cache. Also provide a default implementation that returns false so that well-behaved
classes no longer need to override this.
- Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::ApplePaySession::canSuspendForDocumentSuspension const): Deleted.
- Modules/applepay/ApplePaySession.h:
- Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::canSuspendForDocumentSuspension const): Deleted.
- Modules/cache/DOMCache.h:
- Modules/cache/DOMCacheStorage.cpp:
(WebCore::DOMCacheStorage::canSuspendForDocumentSuspension const): Deleted.
- Modules/cache/DOMCacheStorage.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::MediaKeySession::canSuspendForDocumentSuspension const): Deleted.
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp:
(WebCore::WebKitMediaKeySession::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::WebKitMediaKeySession::canSuspendForDocumentSuspension const): Deleted.
- Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:
- Modules/entriesapi/FileSystemDirectoryReader.cpp:
(WebCore::FileSystemDirectoryReader::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::FileSystemDirectoryReader::canSuspendForDocumentSuspension const): Deleted.
- Modules/entriesapi/FileSystemDirectoryReader.h:
- Modules/entriesapi/FileSystemEntry.cpp:
(WebCore::FileSystemEntry::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::FileSystemEntry::canSuspendForDocumentSuspension const): Deleted.
- Modules/entriesapi/FileSystemEntry.h:
- Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::FetchRequest::canSuspendForDocumentSuspension const): Deleted.
- Modules/fetch/FetchRequest.h:
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::FetchResponse::canSuspendForDocumentSuspension const): Deleted.
- Modules/fetch/FetchResponse.h:
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::page const):
(WebCore::Geolocation::canSuspendForDocumentSuspension const): Deleted.
- Modules/geolocation/Geolocation.h:
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::canSuspendForDocumentSuspension const): Deleted.
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::canSuspendForDocumentSuspension const): Deleted.
- Modules/indexeddb/IDBIndex.h:
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::canSuspendForDocumentSuspension const): Deleted.
- Modules/indexeddb/IDBObjectStore.h:
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::canSuspendForDocumentSuspension const): Deleted.
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::canSuspendForDocumentSuspension const): Deleted.
- Modules/indexeddb/IDBTransaction.h:
- Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::MediaRecorder::canSuspendForDocumentSuspension const): Deleted.
- Modules/mediarecorder/MediaRecorder.h:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::canSuspendForDocumentSuspension const): Deleted.
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::canSuspendForDocumentSuspension const): Deleted.
- Modules/mediasource/SourceBuffer.h:
- Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::canSuspendForDocumentSuspension const): Deleted.
- Modules/mediasource/SourceBufferList.h:
- Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::canSuspendForDocumentSuspension const): Deleted.
- Modules/mediastream/MediaDevices.h:
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::MediaStream::canSuspendForDocumentSuspension const): Deleted.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::MediaStreamTrack::canSuspendForDocumentSuspension const): Deleted.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::RTCDTMFSender::canSuspendForDocumentSuspension const): Deleted.
- Modules/mediastream/RTCDTMFSender.h:
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::RTCPeerConnection::canSuspendForDocumentSuspension const): Deleted.
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::UserMediaRequest::canSuspendForDocumentSuspension const): Deleted.
- Modules/mediastream/UserMediaRequest.h:
- Modules/notifications/Notification.cpp:
(WebCore::Notification::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::Notification::canSuspendForDocumentSuspension const): Deleted.
- Modules/notifications/Notification.h:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::PaymentRequest::canSuspendForDocumentSuspension const): Deleted.
- Modules/paymentrequest/PaymentRequest.h:
- Modules/paymentrequest/PaymentResponse.cpp:
(WebCore::PaymentResponse::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::PaymentResponse::canSuspendForDocumentSuspension const): Deleted.
- Modules/paymentrequest/PaymentResponse.h:
- Modules/pictureinpicture/PictureInPictureWindow.cpp:
(WebCore::PictureInPictureWindow::canSuspendForDocumentSuspension const): Deleted.
- Modules/pictureinpicture/PictureInPictureWindow.h:
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::AudioContext::canSuspendForDocumentSuspension const): Deleted.
- Modules/webaudio/AudioContext.h:
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::DatabaseContext::canSuspendForDocumentSuspension const): Deleted.
- Modules/webdatabase/DatabaseContext.h:
- Modules/webgpu/GPUCanvasContext.h:
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::canSuspendForDocumentSuspension const): Deleted.
- Modules/websockets/WebSocket.h:
- Modules/webvr/VRDisplay.cpp:
(WebCore::VRDisplay::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::VRDisplay::canSuspendForDocumentSuspension const): Deleted.
- Modules/webvr/VRDisplay.h:
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::WebAnimation::canSuspendForDocumentSuspension const): Deleted.
- animation/WebAnimation.h:
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::canSuspendForDocumentSuspension const): Deleted.
- css/FontFaceSet.h:
- dom/ActiveDOMObject.h:
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueueBase<T>::canSuspendForDocumentSuspension const): Deleted.
- dom/GenericEventQueue.h:
- dom/MessagePort.cpp:
(WebCore::MessagePort::canSuspendForDocumentSuspension const): Deleted.
- dom/MessagePort.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjectsForDocumentSuspension):
- fileapi/FileReader.cpp:
(WebCore::FileReader::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::FileReader::canSuspendForDocumentSuspension const): Deleted.
- fileapi/FileReader.h:
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::canSuspendForDocumentSuspension const): Deleted.
- html/HTMLMarqueeElement.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canSuspendForDocumentSuspension const): Deleted.
- html/HTMLMediaElement.h:
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::canSuspendForDocumentSuspension const): Deleted.
- html/HTMLSourceElement.h:
- html/ImageBitmap.cpp:
- html/PublicURLManager.cpp:
(WebCore::PublicURLManager::canSuspendForDocumentSuspension const): Deleted.
- html/PublicURLManager.h:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::canSuspendForDocumentSuspension const): Deleted.
- html/canvas/WebGLRenderingContextBase.h:
- html/track/TrackListBase.cpp:
(WebCore::TrackListBase::canSuspendForDocumentSuspension const): Deleted.
- html/track/TrackListBase.h:
- page/EventSource.cpp:
(WebCore::EventSource::canSuspendForDocumentSuspension const): Deleted.
- page/EventSource.h:
- page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::canSuspendForDocumentSuspension const): Deleted.
- page/IntersectionObserver.h:
- page/ResizeObserver.cpp:
(WebCore::ResizeObserver::canSuspendForDocumentSuspension const): Deleted.
- page/ResizeObserver.h:
- page/SuspendableTimer.cpp:
(WebCore::SuspendableTimerBase::canSuspendForDocumentSuspension const): Deleted.
- page/SuspendableTimer.h:
- platform/SuspendableTaskQueue.cpp:
(WebCore::SuspendableTaskQueue::canSuspendForDocumentSuspension const): Deleted.
- platform/SuspendableTaskQueue.h:
- testing/Internals.cpp:
- workers/Worker.cpp:
(WebCore::Worker::canSuspendForDocumentSuspension const): Deleted.
- workers/Worker.h:
- workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::canSuspendForDocumentSuspension const): Deleted.
- workers/service/ServiceWorker.h:
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::canSuspendForDocumentSuspension const): Deleted.
- workers/service/ServiceWorkerContainer.h:
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::canSuspendForDocumentSuspension const): Deleted.
- workers/service/ServiceWorkerRegistration.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::XMLHttpRequest::canSuspendForDocumentSuspension const): Deleted.
- xml/XMLHttpRequest.h:
- 10:08 AM Changeset in webkit [251243] by
-
- 4 edits in trunk/Source/WebCore
[LFC][TFC] Table formatting context accesses geometry information from parent BFC
https://bugs.webkit.org/show_bug.cgi?id=203082
<rdar://problem/56370827>
Reviewed by Antti Koivisto.
Tables are wrapped in a 2 level formatting context structure. A <table> element initiates a block formatting context for its principal table box
where the caption and the table content live. It also initiates a table wrapper box which establishes the table formatting context.
In many cases the TFC needs access to the parent (generated) BFC.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::geometryForBox const):
- layout/FormattingContext.h:
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::computedTableWidth):
- 10:02 AM Changeset in webkit [251242] by
-
- 7 edits in trunk/LayoutTests
Two fast/scrolling/ios/touch-scroll* tests failing in iOS 13
https://bugs.webkit.org/show_bug.cgi?id=203070
rdar://problem/51756254
Reviewed by Wenson Hsieh.
For some reason the uiController.dragFromPointToPoint() in these tests was too long
to trigger scrolling (maybe an OS change). Fix them to use UIHelper and a shorter
duration, and also to not be sensitive to the exact distance scrolled.
- fast/scrolling/ios/touch-scroll-pointer-events-none-expected.txt:
- fast/scrolling/ios/touch-scroll-pointer-events-none.html:
- fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt:
- fast/scrolling/ios/touch-scroll-visibility-hidden.html:
- platform/ios-wk2/TestExpectations:
- resources/ui-helper.js:
(window.UIHelper.dragFromPointToPoint):
- 9:52 AM Changeset in webkit [251241] by
-
- 2 edits2 adds in trunk/LayoutTests
REGRESSION (r245483) [iPad Simulator] 2 Layout tests fast/scrolling/ios/overflow-scroll-inherited.html fast/scrolling/ios/overflow-scrolling-touch-enabled-stacking.html are failing
https://bugs.webkit.org/show_bug.cgi?id=203069
rdar://problem/51868813
Reviewed by Zalan Bujtas.
Add new result for overflow-scroll-inherited.html, since -webkit-overflow-scrolling:touch is a no-op
on iPad on iOS 13.
We can't have different image references for different devices, so keep overflow-scrolling-touch-enabled-stacking.html
as an image failure.
- platform/ipad-12/fast/scrolling/ios/overflow-scroll-inherited-expected.txt: Added.
- platform/ipad/TestExpectations:
- platform/ipad/fast/scrolling/ios/overflow-scroll-inherited-expected.txt: Added.
- 9:46 AM Changeset in webkit [251240] by
-
- 3 edits1 add3 deletes in trunk/LayoutTests
Make fast/text/font-cursive-italic-cjk.html more robust
https://bugs.webkit.org/show_bug.cgi?id=203072
Reviewed by Alexey Proskuryakov.
Instead of naming STKaiti by name, we can just use an -expected-mismatch test.
- fast/text/font-cursive-italic-cjk-2-expected.html: Removed.
- fast/text/font-cursive-italic-cjk-2.html: Removed.
- fast/text/font-cursive-italic-cjk-expected-mismatch.html: Added.
- fast/text/font-cursive-italic-cjk-expected.html: Removed.
- fast/text/font-cursive-italic-cjk.html:
- platform/mac/TestExpectations:
- 9:38 AM Changeset in webkit [251239] by
-
- 6 edits in trunk/Source/WebCore
[LFC][Painting] Add support for image/background image painting
https://bugs.webkit.org/show_bug.cgi?id=203054
<rdar://problem/56347733>
Reviewed by Antti Koivisto.
In addition to image rendering, this patch also addresses various run/decoration painting issues.
- layout/displaytree/DisplayPainter.cpp:
(WebCore::Display::paintBoxDecoration):
(WebCore::Display::paintInlineContent):
(WebCore::Display::absoluteDisplayBox):
(WebCore::Display::paintBoxDecorationAndChildren):
(WebCore::Display::Painter::paint):
- layout/displaytree/DisplayRun.h:
(WebCore::Display::Run::setImage):
(WebCore::Display::Run::image const):
- layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::appendNonReplacedInlineBox):
(WebCore::Layout::Line::appendReplacedInlineBox):
- layout/layouttree/LayoutReplaced.h:
(WebCore::Layout::Replaced::setCachedImage):
(WebCore::Layout::Replaced::cachedImage const):
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLayoutBox):
- 9:28 AM Changeset in webkit [251238] by
-
- 11 edits in trunk/Source/WebCore
[LFC][IFC] Add Display::Run/LineBox mapping
https://bugs.webkit.org/show_bug.cgi?id=203051
<rdar://problem/56342487>
Reviewed by Antti Koivisto.
Mapping enables us to paint baseline aligned runs on the current line. This is temporary until after we figure out the final run/line structure.
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
- layout/Verification.cpp:
(WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- layout/displaytree/DisplayPainter.cpp:
(WebCore::Display::paintInlineContent):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):
- layout/inlineformatting/InlineFormattingContextQuirks.cpp:
(WebCore::Layout::InlineFormattingContext::Quirks::lineDescentNeedsCollapsing const):
- layout/inlineformatting/InlineFormattingState.h:
(WebCore::Layout::InlineFormattingState::addLineBox):
(WebCore::Layout::InlineFormattingState::lineBoxForRun const):
(WebCore::Layout::InlineFormattingState::addInlineRun):
- layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::Run::Run):
(WebCore::Layout::Line::alignContentVertically):
(WebCore::Layout::Line::adjustBaselineAndLineHeight):
- layout/inlineformatting/InlineLine.h:
(WebCore::Layout::Line::Run::displayRun const):
(WebCore::Layout::Line::Run::logicalRect const):
(WebCore::Layout::Line::Run::adjustLogicalTop):
(WebCore::Layout::Line::Run::moveVertically):
(WebCore::Layout::Line::Run::moveHorizontally):
(WebCore::Layout::Line::Run::expand):
- layout/inlineformatting/InlineLineBox.h:
- layout/inlineformatting/InlineLineLayout.h:
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::outputInlineRuns):
- 9:24 AM Changeset in webkit [251237] by
-
- 4 edits in trunk/Source
[Web Animations] Enable the Web Animations JavaScript API by default
https://bugs.webkit.org/show_bug.cgi?id=203075
Patch by Antoine Quint <Antoine Quint> on 2019-10-17
Reviewed by Antti Koivisto.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
Source/WebKit:
- Shared/WebPreferences.yaml:
- 9:04 AM Changeset in webkit [251236] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix watchOS and tvOS builds after r251224
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::shouldTreatAtLeastOneTypeAsFile):
Move the
shouldTreatAtLeastOneTypeAsFilehelper function out of thePASTEBOARD_SUPPORTS_ITEM_PROVIDERS
section, and into generic iOS-family code so that it can be used inpasteboardMayContainFilePaths.
- 8:47 AM Changeset in webkit [251235] by
-
- 2 edits in trunk/PerformanceTests
[GTK] Perf test IndexedDB/basic/index-cursor-delete.html timeouts
https://bugs.webkit.org/show_bug.cgi?id=203083
Unreviewed gardening.
- Skipped: Skip a test that is timing out on the GTK perf bot.
- 8:14 AM Changeset in webkit [251234] by
-
- 2 edits in trunk/Tools
Check values of variables before extracting index in perl
https://bugs.webkit.org/show_bug.cgi?id=202333
Patch by Paulo Matos <Paulo Matos> on 2019-10-17
Reviewed by Jonathan Bedard.
If compiler doesn't properly report the host and target it was
compiled for, lacking better information we just go ahead and assume
there is no cross compilation involved.
- Scripts/webkitdirs.pm:
(isCrossCompilation):
- 8:08 AM Changeset in webkit [251233] by
-
- 1 edit1 add in trunk/Tools
Add a driver for MiniBrowser running with WPE for
benchmark_runner
https://bugs.webkit.org/show_bug.cgi?id=202994
Reviewed by Žan Doberšek.
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowserwpe_driver.py: Added.
(WPEMiniBrowserDriver):
(WPEMiniBrowserDriver.launch_url):
(WPEMiniBrowserDriver.launch_driver):
- 7:51 AM Changeset in webkit [251232] by
-
- 2 edits in trunk/Tools
run-buildbot-test: sqlalchemy exception when upgrading the database
https://bugs.webkit.org/show_bug.cgi?id=202927
Reviewed by Adrian Perez de Castro.
Update the version of sqlalchemy-migrate for pip used for the test.
That fixes the exception when upgrading the database.
- BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
- 4:28 AM Changeset in webkit [251231] by
-
- 2 edits in trunk/LayoutTests
[GStreamer] media/video-seek-after-end.html is no longer flakey
https://bugs.webkit.org/show_bug.cgi?id=203079
Unreviewed test gardening
- 3:29 AM Changeset in webkit [251230] by
-
- 3 edits in trunk/Source/WebCore
MultiChannelResampler does not need to recreate a ChannelProvider for every process call
https://bugs.webkit.org/show_bug.cgi?id=202982
Reviewed by Eric Carlson.
We no longer allocate a new ChannelProvider for every process call.
No observable change of behavior.
- platform/audio/MultiChannelResampler.cpp:
(WebCore::MultiChannelResampler::ChannelProvider::ChannelProvider):
(WebCore::MultiChannelResampler::ChannelProvider::setProvider):
(WebCore::MultiChannelResampler::MultiChannelResampler):
(WebCore::MultiChannelResampler::process):
- platform/audio/MultiChannelResampler.h:
- 2:05 AM Changeset in webkit [251229] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network: updates when toggling resource caching should be sent to every connected target
https://bugs.webkit.org/show_bug.cgi?id=203025
Reviewed by Joseph Pecoraro.
- UserInterface/Base/Main.js:
(WI._resourceCachingDisabledSettingChanged):
- 1:12 AM Changeset in webkit [251228] by
-
- 2 edits in trunk/Source/WebKit
[GTK][WPE] File and Directory Entries API is not enabled
https://bugs.webkit.org/show_bug.cgi?id=202796
Reviewed by Adrian Perez de Castro.
Enable by default the DirectoryUpload runtime setting that is
used to enable the APIs of the File and Directory Entries API.
Enable also the DataTransferItemsEnabled runtime setting that
exposes the DataTransferItem API. This makes the manual tests
available at https://w3c-test.org/entries-api mostly pass on
platform GTK (those tests need also the DataTransferItem API
to enable the drag-and-drop).
The bug <https://webkit.org/b/98940> for DataTransferItem API
remains open because the layout test editing/pasteboard/data-transfer-items.html
is still not passing completely. However other manual tests for
DataTransferItem pass after enabling it.
- Shared/WebPreferencesDefaultValues.h:
- 1:00 AM Changeset in webkit [251227] by
-
- 238 edits7 copies3 moves23 adds5 deletes in trunk
Web Inspector: rework frontend agent construction to allow commands/events to be controlled by the related target's type
https://bugs.webkit.org/show_bug.cgi?id=200384
<rdar://problem/53850352>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/scripts/codegen/generate_js_backend_commands.py:
(JSBackendCommandsGenerator.generate_domain):
(JSBackendCommandsGenerator.generate_domain.generate_parameter_object):
- inspector/scripts/codegen/models.py:
(validate_target_types): Added.
(Protocol.parse_domain):
(Protocol.parse_command):
(Protocol.parse_event):
(Domain.init):
(Domains):
(Command.init):
(Event.init):
- inspector/protocol/ApplicationCache.json:
- inspector/protocol/Audit.json:
- inspector/protocol/CPUProfiler.json:
- inspector/protocol/CSS.json:
- inspector/protocol/Canvas.json:
- inspector/protocol/Console.json:
- inspector/protocol/DOM.json:
- inspector/protocol/DOMDebugger.json:
- inspector/protocol/DOMStorage.json:
- inspector/protocol/Database.json:
- inspector/protocol/Debugger.json:
- inspector/protocol/Heap.json:
- inspector/protocol/IndexedDB.json:
- inspector/protocol/Inspector.json:
- inspector/protocol/LayerTree.json:
- inspector/protocol/Memory.json:
- inspector/protocol/Network.json:
- inspector/protocol/Page.json:
- inspector/protocol/Recording.json:
- inspector/protocol/Runtime.json:
- inspector/protocol/ScriptProfiler.json:
- inspector/protocol/Security.json:
- inspector/protocol/ServiceWorker.json:
- inspector/protocol/Target.json:
- inspector/protocol/Timeline.json:
- inspector/protocol/Worker.json:
Add
debuggableTypesandtargetTypesarrays to domains/commands/events that are used when
generating InspectorBackendCommands.js for more accurate compatibility checks.
- inspector/InspectorTarget.h:
- inspector/agents/InspectorTargetAgent.h:
- inspector/agents/InspectorTargetAgent.cpp:
(Inspector::targetTypeToProtocolType):
(Inspector::InspectorTargetAgent::exists): Deleted.
RemoveTarget.existsnow that the frontend can do proper feature checking.
- inspector/remote/RemoteControllableTarget.h:
- inspector/remote/RemoteInspectionTarget.h:
- inspector/remote/RemoteInspectorConstants.h:
- inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::listingForInspectionTarget const):
- inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::listingForInspectionTarget const):
- inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::listingForInspectionTarget const):
Split theWebdebuggable type intoPage(WebCore::Page) andWebPage(WebKit::WebPageProxy).
- inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/generic/command-targetType-matching-domain-debuggableType.json: Added.
- inspector/scripts/tests/generic/domain-availability.json: Removed.
- inspector/scripts/tests/generic/domain-debuggableTypes.json: Added.
- inspector/scripts/tests/generic/domain-targetType-matching-domain-debuggableType.json: Added.
- inspector/scripts/tests/generic/domain-targetTypes.json: Added.
- inspector/scripts/tests/generic/event-targetType-matching-domain-debuggableType.json: Added.
- inspector/scripts/tests/generic/expected/command-targetType-matching-domain-debuggableType.json-result: Added.
- inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/generic/expected/domain-debuggableTypes.json-result: Added.
- inspector/scripts/tests/generic/expected/domain-targetType-matching-domain-debuggableType.json-result: Added.
- inspector/scripts/tests/generic/expected/domain-targetTypes.json-result: Added.
- inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/generic/expected/enum-values.json-result:
- inspector/scripts/tests/generic/expected/event-targetType-matching-domain-debuggableType.json-result: Added.
- inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/generic/expected/fail-on-command-targetType-matching-domain-debuggableType.json-error: Added.
- inspector/scripts/tests/generic/expected/fail-on-command-targetTypes-type.json-error: Added.
- inspector/scripts/tests/generic/expected/fail-on-command-targetTypes-value.json-error: Added.
- inspector/scripts/tests/generic/expected/fail-on-domain-availability-type.json-error: Removed.
- inspector/scripts/tests/generic/expected/fail-on-domain-availability-value.json-error: Removed.
- inspector/scripts/tests/generic/expected/fail-on-domain-availability.json-error: Removed.
- inspector/scripts/tests/generic/expected/fail-on-domain-debuggableTypes-type.json-error: Added.
- inspector/scripts/tests/generic/expected/fail-on-domain-debuggableTypes-value.json-error: Added.
- inspector/scripts/tests/generic/expected/fail-on-domain-targetType-matching-domain-debuggableType.json-error: Added.
- inspector/scripts/tests/generic/expected/fail-on-domain-targetTypes-type.json-error: Added.
- inspector/scripts/tests/generic/expected/fail-on-domain-targetTypes-value.json-error: Added.
- inspector/scripts/tests/generic/expected/fail-on-event-targetType-matching-domain-debuggableType.json-error: Added.
- inspector/scripts/tests/generic/expected/fail-on-event-targetTypes-type.json-error: Added.
- inspector/scripts/tests/generic/expected/fail-on-event-targetTypes-value.json-error: Added.
- inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
- inspector/scripts/tests/generic/expected/version.json-result:
- inspector/scripts/tests/generic/fail-on-command-targetType-matching-domain-debuggableType.json: Added.
- inspector/scripts/tests/generic/fail-on-command-targetTypes-type.json: Added.
- inspector/scripts/tests/generic/fail-on-command-targetTypes-value.json: Added.
- inspector/scripts/tests/generic/fail-on-domain-debuggableTypes-type.json: Added.
- inspector/scripts/tests/generic/fail-on-domain-debuggableTypes-value.json: Added.
- inspector/scripts/tests/generic/fail-on-domain-targetType-matching-domain-debuggableType.json: Added.
- inspector/scripts/tests/generic/fail-on-domain-targetTypes-type.json: Added.
- inspector/scripts/tests/generic/fail-on-domain-targetTypes-value.json: Added.
- inspector/scripts/tests/generic/fail-on-event-targetType-matching-domain-debuggableType.json: Added.
- inspector/scripts/tests/generic/fail-on-event-targetTypes-type.json: Added.
- inspector/scripts/tests/generic/fail-on-event-targetTypes-value.json: Added.
- inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
Update test results, as well as added new tests for
debuggableTypesandtargetTypes.
Source/WebCore:
- inspector/InspectorFrontendClient.h:
(WebCore::InspectorFrontendClient::backendCommandsURL): Deleted.
(WebCore::InspectorFrontendClient::debuggableType): Deleted.
- inspector/InspectorFrontendClientLocal.h:
- page/PageDebuggable.h:
(WebCore::PageDebuggable::type const):
- testing/Internals.cpp:
(WebCore::InspectorStubFrontend::debuggableType const): Added.
Split theWebdebuggable type intoPage(WebCore::Page) andWebPage(WebKit::WebPageProxy).
Source/WebInspectorUI:
InspectorBackend.domains.${domain}isn't a truly valid way to feature check, as it
indicates what's supported by the WebKit framework underlying whatever's currently being
inspected, not what the current inspection target supports.
As an example, inspecting an iOS
JSContextwill still showInspectorBackend.domains.DOM
as theDOMAgentis supported by WebKit, even thoughJSContexts have no concept of the
DOM. In this example, however,window.DOMAgentwould NOT exist, as theavailability
check for theDOMdomain wouldn't pass, meaning that the agent never gets connected.
In order to do proper feature checking,
InspectorBackend.domainsneeds to be accurate
depending on the debuggable type. Furthermore, each target underneath that debuggable needs
to be able to "choose" what commands/events are supported based on that target's type.
This patch modifies how InspectorBackendCommands.js ties into
InspectorBackend. Rather
than directly creating anInspectorBackend.Agentfor each domain, we now create more of a
"blueprint" of the domain, and wait to actually create anInspectorBackend.Agentuntil we
have aWI.Target(and therefore anInspectorBackend.Connection). Each "concept" of the
protocol now directly maps to an object.
- InspectorBackend.Domain
- InspectorBackend.Command
- InspectorBackend.Event
- InspectorBackend.Dispatcher
When a
WI.Targetis created, it gets the list ofInspectorBackend.Domainthat support
thatWI.Target's type (specified in the protocol JSON files) and generates an
InspectorBackend.Agentfor each, which in turn generates anInspectorBackend.Callable
for each supportedInspectorBackend.Commandand instantiatesInspectorBackend.Dispatcher.
Activating a
InspectorBackend.Domainmeans it's visible forInspectorBackendfeature
checking. This must be done this way for older ITML backends that will still appear as
"JSContext" targets and therefore go through the "extra domains" path. Ideally, the process
of registering a domain should be enough to activate it. <https://webkit.org/b/201150>
Feature checking can now only be done via
hasDomain,hasCommand, andhasEventon
InspectorBackendor a specificWI.Target, and there are different implications for each:
InspectorBackend.hasDomain(DOM)asks whether theDOMdomain is supported by the current debuggable, but says nothing about whether anyWI.TargetsupportDOM.target.hasDomain("DOM")asks whether the giventargetsupportsDOM, which is limited byInspectorBackend.hasDomain("DOM").
Now that
InspectorBackend.Agentis only created by aWI.Target, it's no longer valid to
writewindow.DOMAgent, as there is no "global" agent. All protocol logic _must_ go through
aWI.Target. <https://webkit.org/b/201149>
Debuggable Types:
- JavaScript (JSC::JSGlobalObject)
- Page (WebCore::Page)
- ServiceWorker (WebCore::ServiceWorkerThreadProxy)
- WebPage (WebKit::WebPageProxy)
Target Types:
- JavaScript (direct connection)
- Page (multi-target connection to any Worker)
- ServiceWorker (direct connection)
- WebPage (multi-target connection to 1+ Page)
- Worker (direct connection, only available for Page debuggables)
- UserInterface/Base/DebuggableType.js:
- UserInterface/Base/TargetType.js: Copied from Source/WebInspectorUI/UserInterface/Base/DebuggableType.js.
- UserInterface/Protocol/Connection.js:
- UserInterface/Protocol/InspectorBackend.js:
- UserInterface/Protocol/ApplicationCacheObserver.js:
- UserInterface/Protocol/CPUProfilerObserver.js:
- UserInterface/Protocol/CSSObserver.js:
- UserInterface/Protocol/CanvasObserver.js:
- UserInterface/Protocol/ConsoleObserver.js:
- UserInterface/Protocol/DOMObserver.js:
- UserInterface/Protocol/DOMStorageObserver.js:
- UserInterface/Protocol/DatabaseObserver.js:
- UserInterface/Protocol/DebuggerObserver.js:
- UserInterface/Protocol/HeapObserver.js:
- UserInterface/Protocol/InspectorObserver.js:
- UserInterface/Protocol/LayerTreeObserver.js:
- UserInterface/Protocol/MemoryObserver.js:
- UserInterface/Protocol/NetworkObserver.js:
- UserInterface/Protocol/PageObserver.js:
- UserInterface/Protocol/RuntimeObserver.js:
- UserInterface/Protocol/ScriptProfilerObserver.js:
- UserInterface/Protocol/TargetObserver.js:
- UserInterface/Protocol/TimelineObserver.js:
- UserInterface/Protocol/WorkerObserver.js:
All observers now extend from
InspectorBackend.Dispatcherand have a separate instance for
eachInspectorBackend.Agent, each having their own_target.
- UserInterface/Protocol/Target.js:
- UserInterface/Protocol/DirectBackendTarget.js:
- UserInterface/Protocol/JavaScriptContextTarget.js: Removed.
- UserInterface/Protocol/MultiplexingBackendTarget.js:
- UserInterface/Protocol/PageTarget.js:
- UserInterface/Protocol/WorkerTarget.js:
Agents are now created per-target instead of copied from the "global" list. This means that
agents can have a different set of commands/events depending on the associated target.
- UserInterface/Base/Main.js:
- UserInterface/Base/Utilities.js:
- UserInterface/Controllers/AppController.js:
- UserInterface/Controllers/AppControllerBase.js:
- UserInterface/Controllers/ApplicationCacheManager.js:
- UserInterface/Controllers/AuditManager.js:
- UserInterface/Controllers/BreakpointPopoverController.js:
- UserInterface/Controllers/CSSManager.js:
- UserInterface/Controllers/CanvasManager.js:
- UserInterface/Controllers/ConsoleManager.js:
- UserInterface/Controllers/DOMDebuggerManager.js:
- UserInterface/Controllers/DOMManager.js:
- UserInterface/Controllers/DOMStorageManager.js:
- UserInterface/Controllers/DatabaseManager.js:
- UserInterface/Controllers/DebuggerManager.js:
- UserInterface/Controllers/HeapManager.js:
- UserInterface/Controllers/IndexedDBManager.js:
- UserInterface/Controllers/JavaScriptLogViewController.js:
- UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
- UserInterface/Controllers/LayerTreeManager.js:
- UserInterface/Controllers/MemoryManager.js:
- UserInterface/Controllers/NetworkManager.js:
- UserInterface/Controllers/RuntimeManager.js:
- UserInterface/Controllers/TargetManager.js:
- UserInterface/Controllers/TimelineManager.js:
- UserInterface/Controllers/WorkerManager.js:
- UserInterface/Main.html:
- UserInterface/Models/AuditTestBase.js:
- UserInterface/Models/AuditTestCase.js:
- UserInterface/Models/AuditTestCaseResult.js:
- UserInterface/Models/CPUInstrument.js:
- UserInterface/Models/CPUTimelineRecord.js:
- UserInterface/Models/CSSCompletions.js:
- UserInterface/Models/CSSStyleSheet.js:
- UserInterface/Models/Canvas.js:
- UserInterface/Models/DOMNode.js:
- UserInterface/Models/DOMNodeStyles.js:
- UserInterface/Models/DOMStorageObject.js:
- UserInterface/Models/DOMTree.js:
- UserInterface/Models/DatabaseObject.js:
- UserInterface/Models/FPSInstrument.js:
- UserInterface/Models/GarbageCollection.js:
- UserInterface/Models/HeapAllocationsInstrument.js:
- UserInterface/Models/Instrument.js:
- UserInterface/Models/MediaInstrument.js:
- UserInterface/Models/MemoryInstrument.js:
- UserInterface/Models/MemoryPressureEvent.js:
- UserInterface/Models/MemoryTimelineRecord.js:
- UserInterface/Models/Recording.js:
- UserInterface/Models/Resource.js:
- UserInterface/Models/ScriptInstrument.js:
- UserInterface/Models/ScriptSyntaxTree.js:
- UserInterface/Models/ScriptTimelineRecord.js:
- UserInterface/Models/ShaderProgram.js:
- UserInterface/Models/SourceMapResource.js:
- UserInterface/Models/TimelineRecording.js:
- UserInterface/Protocol/RemoteObject.js:
- UserInterface/Test.html:
- UserInterface/Test/FrontendTestHarness.js:
- UserInterface/Test/Test.js:
- UserInterface/Test/TestAppController.js:
- UserInterface/Views/AuditNavigationSidebarPanel.js:
- UserInterface/Views/AuditTabContentView.js:
- UserInterface/Views/CanvasTabContentView.js:
- UserInterface/Views/ContextMenuUtilities.js:
- UserInterface/Views/CookieStorageContentView.js:
- UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
- UserInterface/Views/DOMTreeContentView.js:
- UserInterface/Views/ElementsTabContentView.js:
- UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js:
- UserInterface/Views/Layers3DContentView.js:
- UserInterface/Views/LayersTabContentView.js:
- UserInterface/Views/LayoutTimelineView.js:
- UserInterface/Views/LogContentView.js:
- UserInterface/Views/NetworkTabContentView.js:
- UserInterface/Views/NetworkTableContentView.js:
- UserInterface/Views/NetworkTimelineView.js:
- UserInterface/Views/ObjectTreeView.js:
- UserInterface/Views/QuickConsole.js:
- UserInterface/Views/ResourceDetailsSidebarPanel.js:
- UserInterface/Views/ScriptClusterTimelineView.js:
- UserInterface/Views/ScriptDetailsTimelineView.js:
- UserInterface/Views/ScriptTreeElement.js:
- UserInterface/Views/SearchSidebarPanel.js:
- UserInterface/Views/SearchTabContentView.js:
- UserInterface/Views/SettingsTabContentView.js:
- UserInterface/Views/SourceCodeTextEditor.js:
- UserInterface/Views/SourcesNavigationSidebarPanel.js:
- UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
- UserInterface/Views/SpreadsheetStyleProperty.js:
- UserInterface/Views/StorageTabContentView.js:
- UserInterface/Views/TimelineRecordingContentView.js:
- UserInterface/Views/TimelineTabContentView.js:
- UserInterface/Views/Toolbar.js:
- UserInterface/Views/WebSocketContentView.js:
- UserInterface/Views/WorkerTreeElement.js:
Replace all instances of
window.DomainAgentwithtarget.DomainAgent, wheretargetis
either derived from an associated model object orWI.assumingMainTarget().
Split theWI.DebuggableType.Webdebuggable type intoWI.DebuggableType.Page(WebCore::Page)
andWI.DebuggableType.WebPage(WebKit::WebPageProxy).
- UserInterface/Protocol/Legacy/*:
- Versions/*:
Update protocol files for older versions of iOS.
- .eslintrc:
- Localizations/en.lproj/localizedStrings.js:
Source/WebKit:
- WebProcess/WebPage/RemoteWebInspectorUI.h:
(WebKit::WebInspectorUI::backendCommandsURL const): Added.
(WebKit::WebInspectorUI::debuggableType const): Added.
(WebKit::WebInspectorUI::backendCommandsURL): Deleted.
(WebKit::WebInspectorUI::debuggableType): Deleted.
- WebProcess/WebPage/WebInspectorUI.h:
(WebKit::WebInspectorUI::backendCommandsURL const): Added.
(WebKit::WebInspectorUI::debuggableType const): Added.
- UIProcess/WebPageDebuggable.h:
(WebKit::WebPageDebuggable::type const):
- UIProcess/glib/RemoteInspectorClient.cpp:
(WebKit::RemoteInspectorClient::RemoteInspectorClient):
- UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
- UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
(debuggableTypeString):
Split theWebdebuggable type intoPage(WebCore::Page) andWebPage(WebKit::WebPageProxy).
Source/WebKitLegacy/mac:
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorFrontendClient::debuggableType const): Added.
Split theWebdebuggable type intoPage(WebCore::Page) andWebPage(WebKit::WebPageProxy).
Source/WebKitLegacy/win:
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorFrontendClient::debuggableType const): Added.
Split theWebdebuggable type intoPage(WebCore::Page) andWebPage(WebKit::WebPageProxy).
LayoutTests:
- inspector/canvas/requestShaderSource-webgl.html:
- inspector/canvas/updateShader-webgl:
- inspector/page/overrideSetting.html:
- inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
- inspector/page/overrideSetting-MockCaptureDevicesEnabled.html:
- inspector/runtime/parse.html:
Replace all instances of
DomainAgent.EnumwithInspectorBackend.domains.Domain.Enum.
- inspector/audit/run.html:
- inspector/audit/version.html:
- inspector/recording/version.html:
Use new
InspectorBackendmethods.
- inspector/unit-tests/target-manager.html:
- inspector/unit-tests/target-manager-expected.txt:
- inspector/worker/console-basic.html:
- inspector/worker/debugger-pause.html:
- inspector/worker/debugger-scripts.html:
- inspector/worker/debugger-shared-breakpoint.html:
- inspector/worker/resources-in-worker.html:
- inspector/worker/resources/dom-debugger-utilities.js:
- inspector/worker/runtime-basic.html:
- http/tests/inspector/worker/blob-script-with-cross-domain-imported-scripts.html:
Replace
WI.Target.TypewithWI.TargetType.
- inspector/dom/inspect.html:
- inspector/dom/inspect-expected.txt:
Rewrite test since faking events from the backend now requires a target.
- inspector/unit-tests/set-utilities.html:
- inspector/unit-tests/set-utilities-expected.txt:
Add tests for
Set.prototype.addAll.
