Timeline
May 10, 2020:
- 11:57 PM Changeset in webkit [261468] by
-
- 7 edits in trunk
Fix base64.any.html test
https://bugs.webkit.org/show_bug.cgi?id=211671
Patch by Rob Buis <rbuis@igalia.com> on 2020-05-10
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update improved test expectation.
- web-platform-tests/fetch/data-urls/base64.any-expected.txt:
- web-platform-tests/fetch/data-urls/base64.any.worker-expected.txt:
Source/WebCore:
Fix base64.any.html test by extending DataURLDecoder with a
forgiving-base64 decode mode [1], as used by the Fetch
data: URL processor algorithm [2].
Behavior matches Chrome and Firefox.
[1] https://infra.spec.whatwg.org/#forgiving-base64-decode
[2] https://fetch.spec.whatwg.org/#data-url-processor
Test: imported/w3c/web-platform-tests/fetch/data-urls/base64.any.html
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL):
- platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::decodeBase64):
(WebCore::DataURLDecoder::decode):
- platform/network/DataURLDecoder.h:
- 11:14 PM Changeset in webkit [261467] by
-
- 4 edits in trunk/Source
Add copy constructor and assignment operator to Ref<>
https://bugs.webkit.org/show_bug.cgi?id=211705
Reviewed by Sam Weinig.
Source/WebCore:
- dom/BoundaryPoint.h: As a test of the change to Ref, remove the explicit
copy and move constructors and assignment operators, relying on the defaults
instead, which are now exactly what we want.
Source/WTF:
As recently discussed in some WebKit bug patch review, we think that Ref and RefPtr
should have the same design, except for whether the value can be null. Ref had a
more ambitious approach to avoiding reference count churn, requiring a
call to copyRef to make any copying explicit, partly by analogy with raw C
references, which also can't be copied (but they can't be moved either). We choose
to change Ref to match RefPtr and to take the risk of additional churn. This makes
it easier to use Ref in contexts like collection classes and structures. An
alternative would be to go the other direction, and make RefPtr require a call to
copyRef: seems like an obviously worse option.
- wtf/Ref.h: Add the copy constructor and assignment operator.
These follow a similar pattern to the move constructor and assignment operator.
Also add a deprecation comment before copyRef, which we will eventually remove.
- 10:16 PM Changeset in webkit [261466] by
-
- 4 edits in trunk
Update user agent quirk for bankofamerica.com
https://bugs.webkit.org/show_bug.cgi?id=211700
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-05-10
Reviewed by Carlos Garcia Campos.
Source/WebCore:
The Mac platform quirk isn't working anymore. The Chrome quirk works.
- platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):
(WebCore::urlRequiresMacintoshPlatform):
Tools:
- TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):
- 9:46 PM Changeset in webkit [261465] by
-
- 2 edits in trunk/Source/WTF
Use alias template to define
match_constness_tin Wtf/wtp/TypeCasts.h
https://bugs.webkit.org/show_bug.cgi?id=211698
Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-05-10
Reviewed by Yusuke Suzuki.
- wtf/TypeCasts.h:
(WTF::downcast):
- 7:36 PM Changeset in webkit [261464] by
-
- 166 edits in trunk/Source/JavaScriptCore
[clang-tidy] Run modernize-use-nullptr over JSC
https://bugs.webkit.org/show_bug.cgi?id=211706
Reviewed by Darin Adler.
- API/APICallbackFunction.h:
- API/JSAPIGlobalObject.h:
- API/JSBase.cpp:
- API/JSCallbackObjectFunctions.h:
- API/JSClassRef.cpp:
- API/JSContextRef.cpp:
- API/JSObjectRef.cpp:
- API/JSScriptRef.cpp:
- API/JSValueRef.cpp:
- API/JSWeakObjectMapRefPrivate.cpp:
- API/tests/ExecutionTimeLimitTest.cpp:
- API/tests/PingPongStackOverflowTest.cpp:
- assembler/AbstractMacroAssembler.h:
- assembler/CPU.cpp:
- bytecode/CodeBlock.cpp:
- bytecode/DeleteByIdVariant.cpp:
- bytecode/GetByIdVariant.cpp:
- bytecode/InByIdVariant.cpp:
- bytecode/InlineCallFrame.cpp:
- bytecode/LazyOperandValueProfile.cpp:
- bytecode/PutByIdVariant.cpp:
- bytecode/ValueProfile.h:
- bytecode/ValueRecovery.cpp:
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
- debugger/DebuggerScope.h:
- dfg/DFGAbstractValue.cpp:
- dfg/DFGAdjacencyList.h:
- dfg/DFGArgumentPosition.h:
- dfg/DFGArrayifySlowPathGenerator.h:
- dfg/DFGAvailability.h:
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGCPSRethreadingPhase.cpp:
- dfg/DFGCompilationKey.h:
- dfg/DFGConstantFoldingPhase.cpp:
- dfg/DFGDisassembler.cpp:
- dfg/DFGDoubleFormatState.h:
- dfg/DFGEdge.h:
- dfg/DFGFixupPhase.cpp:
- dfg/DFGFrozenValue.cpp:
- dfg/DFGGenerationInfo.h:
- dfg/DFGGraph.h:
- dfg/DFGInPlaceAbstractState.cpp:
- dfg/DFGIntegerCheckCombiningPhase.cpp:
- dfg/DFGLazyJSValue.cpp:
- dfg/DFGNode.h:
- dfg/DFGOSREntrypointCreationPhase.cpp:
- dfg/DFGOSRExit.cpp:
- dfg/DFGOperations.cpp:
- dfg/DFGSilentRegisterSavePlan.h:
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT64.cpp:
- dfg/DFGStructureAbstractValue.cpp:
- dfg/DFGTransition.cpp:
- dfg/DFGTypeCheckHoistingPhase.cpp:
- dfg/DFGWorklist.cpp:
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLAvailableRecovery.h:
- ftl/FTLExitValue.cpp:
- ftl/FTLFormattedValue.h:
- ftl/FTLJITCode.cpp:
- ftl/FTLLink.cpp:
- ftl/FTLLowerDFGToB3.cpp:
- ftl/FTLLoweredNodeValue.h:
- ftl/FTLOSREntry.cpp:
- ftl/FTLOSRExitCompiler.cpp:
- ftl/FTLTypedPointer.h:
- ftl/FTLValueFromBlock.h:
- ftl/FTLValueRange.h:
- heap/GCSegmentedArray.h:
- heap/Handle.h:
- heap/HandleSet.h:
- heap/HandleTypes.h:
- heap/HeapSnapshotBuilder.cpp:
- heap/MarkedBlockInlines.h:
- heap/Strong.h:
- heap/WeakImpl.h:
- heap/WeakInlines.h:
- heap/WeakSet.cpp:
- heap/WeakSet.h:
- interpreter/CallFrame.cpp:
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
- interpreter/ProtoCallFrame.h:
- interpreter/StackVisitor.cpp:
- interpreter/StackVisitor.h:
- jit/AssemblyHelpers.h:
- jit/CCallHelpers.h:
- jit/JITCode.cpp:
- jit/JITOperations.cpp:
- jit/Repatch.cpp:
- jit/ThunkGenerators.cpp:
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
- parser/ASTBuilder.h:
- parser/Lexer.cpp:
- parser/Lexer.h:
- parser/Nodes.cpp:
- parser/Nodes.h:
- parser/Parser.cpp:
- parser/Parser.h:
- parser/ParserArena.cpp:
- parser/ParserArena.h:
- parser/ParserFunctionInfo.h:
- parser/SyntaxChecker.h:
- parser/UnlinkedSourceCode.h:
- profiler/ProfilerBytecodeSequence.cpp:
- profiler/ProfilerCompilation.cpp:
- profiler/ProfilerDatabase.cpp:
- profiler/ProfilerOSRExitSite.cpp:
- profiler/ProfilerOriginStack.cpp:
- runtime/ArgList.h:
- runtime/ArrayPrototype.cpp:
- runtime/ClonedArguments.cpp:
- runtime/CommonSlowPaths.cpp:
- runtime/Completion.h:
- runtime/DataView.h:
- runtime/DatePrototype.cpp:
- runtime/DirectEvalExecutable.cpp:
- runtime/DumpContext.cpp:
- runtime/FunctionExecutable.cpp:
- runtime/IndirectEvalExecutable.cpp:
- runtime/JSArray.cpp:
- runtime/JSArrayBufferView.cpp:
- runtime/JSCJSValue.cpp:
- runtime/JSCJSValueInlines.h:
- runtime/JSCell.cpp:
- runtime/JSDataView.cpp:
- runtime/JSDestructibleObject.h:
- runtime/JSFunction.cpp:
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
- runtime/JSONObject.cpp:
- runtime/JSObject.cpp:
- runtime/JSObject.h:
- runtime/JSScope.cpp:
- runtime/JSScope.h:
- runtime/LiteralParser.cpp:
- runtime/OptionsList.h:
- runtime/PropertyDescriptor.cpp:
- runtime/PropertyMapHashTable.h:
- runtime/PropertySlot.h:
- runtime/PutPropertySlot.h:
- runtime/RegExpMatchesArray.h:
- runtime/RegExpPrototype.cpp:
- runtime/StringPrototype.cpp:
- runtime/Structure.cpp:
- runtime/Structure.h:
- runtime/TestRunnerUtils.cpp:
- runtime/TypedArrayType.cpp:
- runtime/VM.cpp:
- runtime/Watchdog.cpp:
- runtime/Watchdog.h:
- runtime/WriteBarrier.h:
- testRegExp.cpp:
- tools/JSDollarVM.cpp:
- wasm/WasmSlowPaths.cpp:
- yarr/RegularExpression.h:
- yarr/YarrInterpreter.cpp:
- yarr/YarrJIT.cpp:
- yarr/YarrJIT.h:
- yarr/YarrPattern.cpp:
- yarr/YarrPattern.h:
- 7:08 PM Changeset in webkit [261463] by
-
- 2 edits in trunk/Source/WebKitLegacy/win
[WinCairo][WK1] requestAnimationFrame doesn't work since r261113
https://bugs.webkit.org/show_bug.cgi?id=211702
Reviewed by Darin Adler.
Since r261113 (Bug 204713), WinCairo WK1 is failing some rAF tests
even though AppleWin isn't.
WinCairo also should do m_page->updateRendering() in
WebView::flushPendingGraphicsLayerChangesSoon as well as AppleWin.
- WebView.cpp:
(WebView::flushPendingGraphicsLayerChangesSoon): Call
updateRendering.
- 4:56 PM Changeset in webkit [261462] by
-
- 11 edits in trunk
Add ENABLE_PERIODIC_MEMORY_MONITOR flag.
https://bugs.webkit.org/show_bug.cgi?id=211704
Reviewed by Yusuke Suzuki.
.:
Define ENABLE_PERIODIC_MEMORY_MONITOR flags in specific platform's options.
Enable it for PlayStation port.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsPlayStation.cmake:
- Source/cmake/OptionsWPE.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/WebKit:
No new tests because there's no behavior change.
Replace PLATFORM() macros with ENABLE() macro.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Source/WTF:
Define ENABLE_PERIODIC_MEMORY_MONITOR flags in specific platform file.
- wtf/PlatformEnable.h:
- wtf/PlatformEnableCocoa.h:
- 3:37 PM Changeset in webkit [261461] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r261270): Broke build with python3
https://bugs.webkit.org/show_bug.cgi?id=211699
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-05-10
Reviewed by Yusuke Suzuki.
Remove the problematic print statement. It causes the script to fail. If fixed, it spams the
build output. We only print messages during the build when there are problems to be fixed.
- Scripts/generate-message-receiver.py:
(main):
- 2:35 PM Changeset in webkit [261460] by
-
- 14 edits in trunk/Source
Remove now-unneeded HAVE(CORE_VIDEO)
https://bugs.webkit.org/show_bug.cgi?id=211677
Reviewed by Dan Bernstein.
Source/WebCore:
- page/cocoa/MemoryReleaseCocoa.mm:
- platform/cocoa/CoreVideoSoftLink.cpp: Remove HAVE(CORE_VIDEO).
- platform/cocoa/CoreVideoSoftLink.h: Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastImage): Ditto.
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::getRGBAImageData const): Ditto.
- platform/graphics/cv/PixelBufferConformerCV.cpp: Ditto.
- platform/graphics/cv/PixelBufferConformerCV.h: Ditto.
- platform/graphics/cv/TextureCacheCV.h: Ditto.
- platform/graphics/cv/TextureCacheCV.mm: Ditto.
- platform/graphics/cv/VideoTextureCopierCV.cpp: Ditto.
- platform/graphics/cv/VideoTextureCopierCV.h: Ditto.
Source/WTF:
- wtf/PlatformHave.h: Remove HAVE_CORE_VIDEO.
- 2:21 PM Changeset in webkit [261459] by
-
- 2 edits in trunk/Source/WebCore
Tighten up logic in DocumentTimelinesController::updateAnimationsAndSendEvents
https://bugs.webkit.org/show_bug.cgi?id=211668
Reviewed by Antoine Quint.
- animation/DocumentTimelinesController.cpp:
(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):
Use Ref instead of RefPtr. Use Ref even in timelinesToUpdate; no harm in doing
a little bit of extra ref'ing. Use copyToVector when iterating relevantAnimations
since it could be a problem if the current animation was removed from the
ListHashSet while we are iterating it and there is no obvious reason that can't
happen. Use makeRef instead of makeRefPtr. Take advantage of the behavior of
the Optional operator<, which already treats nullopt as less than any non-nullopt
value, and remove unnecessary checks that weere doing the same thing explicitly.
This fixes a mistake where we were returning true when both are nullopt, which
could harm the stability of the sort, in theory. Add a null check of the timeline
when iterating completedTransitions, since there is no obvious guarantee they
could not have been removed as a side effect earlier.
- 2:21 PM Changeset in webkit [261458] by
-
- 2 edits in trunk/Source/WebCore
Use makeReversedRange and get rid of one-off ReverseView
https://bugs.webkit.org/show_bug.cgi?id=211675
Reviewed by Sam Weinig.
- editing/markup.cpp:
(WebCore::ReverseView): Deleted.
(WebCore::StyledMarkupAccumulator::takeResults): Use makeReversedRange.
- 12:28 PM Changeset in webkit [261457] by
-
- 25 edits in trunk/Source
Clicking a tel:// link on iPad with a trackpad presents different UI than tapping on it
https://bugs.webkit.org/show_bug.cgi?id=211686
<rdar://problem/57941589>
Reviewed by Wenson Hsieh.
Source/WebCore:
- dom/MouseRelatedEvent.h:
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::canPresentDataDetectorsUIForElement):
(WebCore::DataDetection::shouldCancelDefaultAction): Deleted.
Rename shouldCancelDefaultAction to canPresentDataDetectorsUIForElement.
This bit indicates whether a given element should invoke DD UI instead of
doing its default action, so either name is OK, but it feels better to
have it in the affirmative direction.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
Determine if tapping on an anchor should invoke DataDetectors UI instead
of performing the default action, and short-circuit if that is possible.
- loader/EmptyClients.h:
- page/ChromeClient.h:
Source/WebKit:
Previously, iOS WebKit had code in handleTap, handleTwoFingerTapAtPoint, and commitPotentialTap,
which introspected the hit element /before/ dispatching the tap (or synthetic click) to the DOM,
short circuiting all normal event handling machinery in order to prevent the default action
and present the Data Detectors UI for the given link.
There's one immediate problem with this, which is that there is no similar code in the direct
click event handler path, which we now use for trackpad/mouse input on iPad. There's also a
secondary problem (which we have not seen in practice), which is that pages cannot preventDefault
to avoid launching the Data Detectors UI on a link, like they could to prevent an ordinary
link from being followed.
In order to resolve both issues and reduce duplication of logic, move the code that introspects
the element and invokes Data Detectors UI from high-level WebKit event dispatch code (where it
doesn't really belong) down to WebCore's default click event handler for anchors, right next to
the code that would ordinarily cause a navigation. This way, no matter how we get here, whether
by synthetic click or real click, we'll invoke the Data Detectors UI.
One alternative considered at length: we could actually let the navigation happen, and instead
handle the switch in navigation policy code, but there are a few reasons that did not seem ideal:
1) We'd need to plumb platform-specific data structures through a ton of FrameLoader code.
2) Clients often block non-HTTP(S) navigations, so in order to keep the feature functional,
we'd have to disregard the client's policy decision, defeating much of the purpose of making
use of the navigation mechanism in the first place.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::showDataDetectorsUIForPositionInformation):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::showDataDetectorsUIForPositionInformation):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::showDataDetectorsUIForElement):
Plumb showDataDetectorsUIForPositionInformation from iOS WebKit's ChromeClient
implementation all the way to WKContentView.
- UIProcess/ios/WKActionSheetAssistant.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showDataDetectorsUIForPositionInformation:]):
(-[WKActionSheetAssistant contextMenuInteraction:configurationForMenuAtLocation:]):
(-[WKActionSheetAssistant contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]):
(-[WKActionSheetAssistant showDataDetectorsSheet]): Deleted.
Make it possible to push InteractionInformationAtPosition into WKActionSheetAssistant,
instead of having it always pull a fresh one upon invocation, so that we can use the
position information passed along with the showDataDetectorsUIForPositionInformation message.
(-[WKActionSheetAssistant _contextMenuInteraction:overrideSuggestedActionsForConfiguration:]):
(-[WKActionSheetAssistant suggestedActionsForContextMenuWithPositionInformation:]):
Fix an existing bug where Data Detectors context menus would show extra default actions,
by moving our implementation of the -_contextMenuInteraction:overrideSuggestedActionsForConfiguration:
delegate here, sharing it with WKContentViewInteraction.
In a future patch, we should reconsider having three separate UIContextMenuInteractions.
Also, remove the contextMenuPresentationLocationForActionSheetAssistant: delegate,
since it will be wrong in the case of pushed-in position information, and instead
use the position information's original hit test point.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showDataDetectorsUI]):
(-[WKContentView _showDataDetectorsUIForPositionInformation:]):
(-[WKContentView _actionForLongPressFromPositionInformation:]):
(-[WKContentView _didNotHandleTapAsClick:]):
(-[WKContentView dataDetectionContextForPositionInformation:]):
(-[WKContentView dataDetectionContextForActionSheetAssistant:positionInformation:]):
(-[WKContentView _showDataDetectorsSheet]): Deleted.
(-[WKContentView currentPositionInformation]): Deleted.
(-[WKContentView dataDetectionContextForActionSheetAssistant:]): Deleted.
Instead of exposing an unnecessary -currentPositionInformation getter on WKActionSheetAssistant,
provide it as an argument to the WKActionSheetAssistantDelegate methods that actually need it.
(-[WKContentView contextMenuPresentationLocationForActionSheetAssistant:]): Deleted.
(-[WKContentView _contextMenuInteraction:overrideSuggestedActionsForConfiguration:]):
Adopt WKActionSheetAssistant's suggestedActions mechanism so we can share code.
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView _showActionSheetForURL:atLocation:withAnnotationRect:]):
(-[WKPDFView dataDetectionContextForActionSheetAssistant:positionInformation:]):
(-[WKPDFView dataDetectionContextForActionSheetAssistant:]): Deleted.
Adapt to some WKActionSheetAssistantDelegate changes.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleTap):
(WebKit::WebPage::handleTwoFingerTapAtPoint):
(WebKit::WebPage::commitPotentialTap):
Remove the aforementioned short-circuiting paths for Data Detectors links.
Source/WebKitLegacy/ios:
- WebCoreSupport/WebChromeClientIOS.h:
- 3:17 AM Changeset in webkit [261456] by
-
- 3 edits in trunk/LayoutTests
[GTK] Gardening, update test expectations
https://bugs.webkit.org/show_bug.cgi?id=211694
Unreviewed gardening.
Gardening of flaky failures.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- 12:26 AM Changeset in webkit [261455] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
[ iOS wk2 and Mac wk2 ] imported/w3c/web-platform-tests/fetch/stale-while-revalidate/frame-removal.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209281
Patch by Rob Buis <rbuis@igalia.com> on 2020-05-10
Reviewed by Darin Adler.
Since it is difficult to estimate when the revalidations are received
in relation to the frame loads, add two polling loops to make sure
revalidations have been received before proceding with the next
test step. This is similar to what fetch.html does.
- web-platform-tests/fetch/stale-while-revalidate/frame-removal.html:
- web-platform-tests/fetch/stale-while-revalidate/resources/stale-frame.py:
(main):
May 9, 2020:
- 8:44 PM Changeset in webkit [261454] by
-
- 2 edits in trunk/Source/WebKit
Attempt #2 to fix internal iOS build
- UIProcess/ios/WKMouseGestureRecognizer.mm:
- Use ALLOW_DEPRECATED_IMPLEMENTATIONS_{BEGIN,END}.
- 8:36 PM Changeset in webkit [261453] by
-
- 2 edits in trunk
Remove duplicate ChangeLog entries committed by accident.
- 8:08 PM Changeset in webkit [261452] by
-
- 3 edits in trunk/Source/WebKit
Attemp to fix internal iOS build
- Platform/spi/ios/UIKitSPI.h:
- Define @class UIHoverEvent using header if available, else fall back to local class definition.
- Define methods separately from class definition.
- UIProcess/ios/WKMouseGestureRecognizer.mm:
(-[WKMouseGestureRecognizer setView:]):
- Use new method if it is available.
- 8:08 PM Changeset in webkit [261451] by
-
- 2 edits in trunk
XML external entity resources should only be loaded from XML MIME types
<https://webkit.org/b/211488>
<rdar://problem/62869515>
Reviewed by Darin Adler.
Source/WebCore:
Tests: dom/xhtml/level3/core/entitygetinputencoding03.xhtml
dom/xhtml/level3/core/entitygetinputencoding04.xhtml
dom/xhtml/level3/core/entitygetxmlencoding02.xhtml
dom/xhtml/level3/core/entitygetxmlencoding03.xhtml
dom/xhtml/level3/core/entitygetxmlencoding04.xhtml
dom/xhtml/level3/core/entitygetxmlversion03.xhtml
dom/xhtml/level3/core/entitygetxmlversion04.xhtml
dom/xhtml/level3/core/nodegetbaseuri16.xhtml
dom/xhtml/level3/core/nodegetbaseuri19.xhtml
dom/xhtml/level3/core/nodegetbaseuri20.xhtml
fast/parser/external-entities-in-xslt.xml
fast/xsl/dtd-in-source-document.xml
fast/xsl/xslt-second-level-import.xml
http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml
http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml
- html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::href const):
- Add comment about keeping code in sync with openFunc() in XMLDocumentParserLibxml2.cpp.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseMIMEType const):
- Add comment about keeping code in sync with externalEntityMimeTypeAllowed() in XMLDocumentParserLibxml2.cpp.
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::externalEntityMimeTypeAllowed):
- Rename from externalEntityMimeTypeAllowedByNosniff().
- Change to only allow XML MIME types regardless of nosniff option.
- Add fallback path to determine MIME type for file:/// URLs to make layout tests work properly. Logic taken from XMLHttpRequest::responseMIMEType(). Not sure if there was a good place to share it.
(WebCore::openFunc):
- Fix relative URLs by providing the document's URL as a base. Also provide an encoding if needed. Logic taken from HTMLBaseElement::href(). (Not sure if there was a good place to share it.) This was required to fix loading of external entity resources in the dom/xhtml/level3/core tests, which hadn't been loading these resources for a while. Ultimately this didn't matter--except for new error messages being printed in test results--because the tests fail due to missing DOM features for XHTML documents).
- Change the fix for Bug 21963 into an empty URL check since setting FetchOptions.mode to Mode::SameOrigin prevents a redirect from loading a resource outside the document's origin. The previous check worked, but the relaxed check in externalEntityMimeTypeAllowed() caused the XML MIME type warning to be output on redirects to non-same-origin URLs. I didn't see a way to check for a cross-origin loading error.
- Add a console message for a cross-origin load failing.
- Update for function rename.
- Remove double negative from console message for an invalid MIME type.
(WebCore::externalEntityMimeTypeAllowedByNosniff):
- Rename to externalEntityMimeTypeAllowed().
LayoutTests:
To fix these layout tests, the following changes were made:
- Rename *.ent files to *.ent.xml so that an XML MIME type would be given to the resources when loading from a file:/// URL.
- Similarly, rename *.dtd files to *.dtd.xml.
- Update tests to refer to new entity/dtd file names.
- There are more *.dtd and *.ent files that weren't renamed. I will fix those in a follow-up patch. They weren't needed to fix any tests, so may be unused.
- dom/xhtml/level3/core/entitygetinputencoding03.xhtml:
- dom/xhtml/level3/core/entitygetinputencoding04.xhtml:
- dom/xhtml/level3/core/entitygetxmlencoding02.xhtml:
- dom/xhtml/level3/core/entitygetxmlencoding03.xhtml:
- dom/xhtml/level3/core/entitygetxmlencoding04.xhtml:
- dom/xhtml/level3/core/entitygetxmlversion03.xhtml:
- dom/xhtml/level3/core/entitygetxmlversion04.xhtml:
- dom/xhtml/level3/core/resources/external_foo.ent.xml: Rename from LayoutTests/dom/xhtml/level3/core/external_foo.ent.xml.
- dom/xhtml/level3/core/resources/external_foobr.ent.xml: Rename from LayoutTests/dom/xhtml/level3/core/external_foobr.ent.xml.
- dom/xhtml/level3/core/resources/external_widget.ent.xml: Rename from LayoutTests/dom/xhtml/level3/core/external_widget.ent.xml.
- dom/xhtml/level3/core/nodegetbaseuri16.xhtml:
- dom/xhtml/level3/core/nodegetbaseuri19.xhtml:
- dom/xhtml/level3/core/nodegetbaseuri20.xhtml:
- fast/parser/external-entities.xml:
- fast/parser/resources/external-entities.dtd.xml: Rename from LayoutTests/fast/parser/resources/external-entities.dtd.
- fast/parser/resources/external-entities.xsl:
- fast/xsl/dtd-in-source-document.xml:
- fast/xsl/resources/dtd-in-source-document.dtd.xml: Rename from LayoutTests/fast/xsl/resources/dtd-in-source-document.dtd.
- fast/xsl/resources/xslt-second-level-import.xsl:
- fast/xsl/resources/xslt-second-level-import.xsl.dtd.xml: Rename from LayoutTests/fast/xsl/resources/xslt-second-level-import.xsl.dtd.
- http/tests/security/contentTypeOptions/nosniff-xml-external-entity-expected.txt:
- http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml:
- Add test cases without "X-Content-Type-Options: nosniff" header.
- http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt:
- Add newly expected console error messages about cross-origin resource load failures.
- 8:05 PM Changeset in webkit [261450] by
-
- 5 edits in trunk
[macOS] Search field on mayoclinic.org/forms/us-resident-appointment clips the submit button
https://bugs.webkit.org/show_bug.cgi?id=211673
<rdar://problem/62572501>
Reviewed by Tim Horton.
Source/WebCore:
Allow search fields to be style-able, but only if the CSS
bordervalue is non-default.
Note that there was a previous attempt to achieve something similar in r157443 by adding search fields to the
base class implementation ofRenderTheme::isControlStyled; however, this patch wasn't actually accompanied by
support for rendering native search fields with a non-default background, which meant that customizing just the
background of a search field would cause the entire search field to opt out of the native search field
appearance (a pill with rounded corners on macOS).
However, in the case where the border is customized on macOS, it is incorrect to use the default search field
appearance, since the search field cell just consists of a border; as such, there should be little compatibility
risk of a web page unexpectedly getting the fallback (non-native) appearance for a search field, due to having
custom border styles.
This also makes the behavior of search fields match that of text fields, textareas, and list boxes (multi-option
selects) on macOS, in terms of what is needed in order to bail out of native appearance rendering.
Rebaselined existing tests: fast/css/text-input-with-webkit-border-radius.html
fast/forms/search-styled.html
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::isControlStyled const): Add SearchFieldPart.
LayoutTests:
Rebaseline a couple of layout tests that contain search fields with custom CSS border styles.
- platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/mac/fast/forms/search-styled-expected.txt:
- 6:21 PM Changeset in webkit [261449] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, reverting r261389.
https://bugs.webkit.org/show_bug.cgi?id=211678
Introduced page loading regression. (Requested by perarne on
#webkit).
Reverted changeset:
"[iOS] Update message filtering rules in the WebContent
process' sandbox"
https://bugs.webkit.org/show_bug.cgi?id=211188
https://trac.webkit.org/changeset/261389
- 5:48 PM Changeset in webkit [261448] by
-
- 2 edits in trunk/Source/WTF
Delete some dead code in WorkQueueCocoa.cpp
https://bugs.webkit.org/show_bug.cgi?id=211676
Reviewed by Chris Dumez.
- wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::targetQueueForQOSClass): Deleted.
- 5:05 PM Changeset in webkit [261447] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r258493): CRASH running fast/mediastream/RTCPeerConnection tests
https://bugs.webkit.org/show_bug.cgi?id=211666
<rdar://problem/63055644>
Reviewed by Eric Carlson.
MockMediaStreamTrack advertises that it's a webrtc::VideoTrackInterface, but doesn't inherit from
that interface, leading to a crash when its pointer is cast to webrtc::VideoTrackInterface and a
virtual method called on the resulting pointer. Since it's only used in one place, and since there's
an existing mock webrtc::VideoTrackInterface object in that same file, remove MockMediaStreamTrack
and replace the one place it's used with MockLibWebRTCVideoTrack.
- testing/MockLibWebRTCPeerConnection.h:
(WebCore::MockMediaStreamTrack::state const): Deleted.
- 5:02 PM Changeset in webkit [261446] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] REGRESSION (r259139): webgl/2.0.0/conformance2/rendering/framebuffer-completeness-unaffected.html is failing
https://bugs.webkit.org/show_bug.cgi?id=209740
Patch by Kenneth Russell <kbr@chromium.org> on 2020-05-09
Reviewed by Darin Adler.
Reenable framebuffer-completeness-unaffected.html, which is now
passing after several other bug fixes.
- platform/mac/TestExpectations:
- 5:02 PM Changeset in webkit [261445] by
-
- 2 edits in trunk/LayoutTests
[ Mojave wk1 Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html is timing out.
https://bugs.webkit.org/show_bug.cgi?id=209837
Patch by Kenneth Russell <kbr@chromium.org> on 2020-05-09
Reviewed by Darin Adler.
Remove flaky timeout suppression for
texImage2D-mse-flipY-true.html, which has been passing reliably
for over a month.
- platform/mac-wk1/TestExpectations:
- 4:35 PM Changeset in webkit [261444] by
-
- 7 edits in trunk
[CMake] Use WEBKIT_EXECUTABLE in MallocBench
https://bugs.webkit.org/show_bug.cgi?id=211665
Reviewed by Yusuke Suzuki.
.:
Add the PerformanceTest subdirectory for all ports when in DEVELOPER_MODE.
- CMakeLists.txt:
PerformanceTests:
Cleanup MallocBench definitions using WEBKIT_EXECUTABLE. Notify developers
that MallocBench is unavailable only if bmalloc is being used but the platform
does not have the functionality required.
- CMakeLists.txt:
- MallocBench/MallocBench/CMakeLists.txt:
Source/bmalloc:
Only build mbmalloc if its possible to run MallocBench.
- CMakeLists.txt:
- 4:20 PM Changeset in webkit [261443] by
-
- 22 edits6 moves in trunk
XML external entity resources should only be loaded from XML MIME types
<https://webkit.org/b/211488>
<rdar://problem/62869515>
Reviewed by Darin Adler.
Source/WebCore:
Tests: dom/xhtml/level3/core/entitygetinputencoding03.xhtml
dom/xhtml/level3/core/entitygetinputencoding04.xhtml
dom/xhtml/level3/core/entitygetxmlencoding02.xhtml
dom/xhtml/level3/core/entitygetxmlencoding03.xhtml
dom/xhtml/level3/core/entitygetxmlencoding04.xhtml
dom/xhtml/level3/core/entitygetxmlversion03.xhtml
dom/xhtml/level3/core/entitygetxmlversion04.xhtml
dom/xhtml/level3/core/nodegetbaseuri16.xhtml
dom/xhtml/level3/core/nodegetbaseuri19.xhtml
dom/xhtml/level3/core/nodegetbaseuri20.xhtml
fast/parser/external-entities-in-xslt.xml
fast/xsl/dtd-in-source-document.xml
fast/xsl/xslt-second-level-import.xml
http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml
http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml
- html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::href const):
- Add comment about keeping code in sync with openFunc() in XMLDocumentParserLibxml2.cpp.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseMIMEType const):
- Add comment about keeping code in sync with externalEntityMimeTypeAllowed() in XMLDocumentParserLibxml2.cpp.
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::externalEntityMimeTypeAllowed):
- Rename from externalEntityMimeTypeAllowedByNosniff().
- Change to only allow XML MIME types regardless of nosniff option.
- Add fallback path to determine MIME type for file:/// URLs to make layout tests work properly. Logic taken from XMLHttpRequest::responseMIMEType(). Not sure if there was a good place to share it.
(WebCore::openFunc):
- Fix relative URLs by providing the document's URL as a base. Also provide an encoding if needed. Logic taken from HTMLBaseElement::href(). (Not sure if there was a good place to share it.) This was required to fix loading of external entity resources in the dom/xhtml/level3/core tests, which hadn't been loading these resources for a while. Ultimately this didn't matter--except for new error messages being printed in test results--because the tests fail due to missing DOM features for XHTML documents).
- Change the fix for Bug 21963 into an empty URL check since setting FetchOptions.mode to Mode::SameOrigin prevents a redirect from loading a resource outside the document's origin. The previous check worked, but the relaxed check in externalEntityMimeTypeAllowed() caused the XML MIME type warning to be output on redirects to non-same-origin URLs. I didn't see a way to check for a cross-origin loading error.
- Add a console message for a cross-origin load failing.
- Update for function rename.
- Remove double negative from console message for an invalid MIME type.
(WebCore::externalEntityMimeTypeAllowedByNosniff):
- Rename to externalEntityMimeTypeAllowed().
LayoutTests:
To fix these layout tests, the following changes were made:
- Rename *.ent files to *.ent.xml so that an XML MIME type would be given to the resources when loading from a file:/// URL.
- Similarly, rename *.dtd files to *.dtd.xml.
- Update tests to refer to new entity/dtd file names.
- There are more *.dtd and *.ent files that weren't renamed. I will fix those in a follow-up patch. They weren't needed to fix any tests, so may be unused.
- dom/xhtml/level3/core/entitygetinputencoding03.xhtml:
- dom/xhtml/level3/core/entitygetinputencoding04.xhtml:
- dom/xhtml/level3/core/entitygetxmlencoding02.xhtml:
- dom/xhtml/level3/core/entitygetxmlencoding03.xhtml:
- dom/xhtml/level3/core/entitygetxmlencoding04.xhtml:
- dom/xhtml/level3/core/entitygetxmlversion03.xhtml:
- dom/xhtml/level3/core/entitygetxmlversion04.xhtml:
- dom/xhtml/level3/core/resources/external_foo.ent.xml: Rename from LayoutTests/dom/xhtml/level3/core/external_foo.ent.xml.
- dom/xhtml/level3/core/resources/external_foobr.ent.xml: Rename from LayoutTests/dom/xhtml/level3/core/external_foobr.ent.xml.
- dom/xhtml/level3/core/resources/external_widget.ent.xml: Rename from LayoutTests/dom/xhtml/level3/core/external_widget.ent.xml.
- dom/xhtml/level3/core/nodegetbaseuri16.xhtml:
- dom/xhtml/level3/core/nodegetbaseuri19.xhtml:
- dom/xhtml/level3/core/nodegetbaseuri20.xhtml:
- fast/parser/external-entities.xml:
- fast/parser/resources/external-entities.dtd.xml: Rename from LayoutTests/fast/parser/resources/external-entities.dtd.
- fast/parser/resources/external-entities.xsl:
- fast/xsl/dtd-in-source-document.xml:
- fast/xsl/resources/dtd-in-source-document.dtd.xml: Rename from LayoutTests/fast/xsl/resources/dtd-in-source-document.dtd.
- fast/xsl/resources/xslt-second-level-import.xsl:
- fast/xsl/resources/xslt-second-level-import.xsl.dtd.xml: Rename from LayoutTests/fast/xsl/resources/xslt-second-level-import.xsl.dtd.
- http/tests/security/contentTypeOptions/nosniff-xml-external-entity-expected.txt:
- http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml:
- Add test cases without "X-Content-Type-Options: nosniff" header.
- http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt:
- Add newly expected console error messages about cross-origin resource load failures.
- 4:10 PM Changeset in webkit [261442] by
-
- 10 edits1 copy2 moves in trunk/Source
Adapt LocalCurrentGraphicsContext for iOS
<https://webkit.org/b/211660>
Reviewed by Darin Adler.
Source/WebCore:
- PlatformMac.cmake:
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- Update build files for:
- Rename of LocalCurrentGraphicsContext.mm to LocalCurrentGraphicsContextMac.mm.
- Move of LocalCurrentGraphicsContext.h from platform/mac to platform/cocoa.
- Addition of LocalCurrentGraphicsContextIOS.mm.
- platform/cocoa/LocalCurrentGraphicsContext.h: Renamed from Source/WebCore/platform/mac/LocalCurrentGraphicsContext.h.
- Make this work for iOS by using PLATFORM(COCOA) for the outer guard and USE(APPKIT) for the Mac-specific bits.
- Use RetainPtr<> for NSGraphicsContext to clean up code in LocalCurrentGraphicsContextMac.mm.
(WebCore::LocalCurrentGraphicsContext::cgContext):
- Inline from LocalCurrentGraphicsContextMac.mm.
- platform/ios/LocalCurrentGraphicsContextIOS.mm: Copied from Source/WebCore/platform/mac/LocalCurrentGraphicsContext.mm.
(WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
(WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
- Implement based on LocalCurrentGraphicsContextMac.mm. Use UIGraphics{GetCurrent,Pop,Push}Context() functions added to UIKitSoftLink.h.
- platform/mac/LocalCurrentGraphicsContextMac.mm: Renamed from Source/WebCore/platform/mac/LocalCurrentGraphicsContext.mm.
(WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
- Use m_savedGraphicsContext instead of graphicsContext in the body of the constructor.
- Remove set-to-nil/retain of m_savedNSGraphicsContext since that is handled by RetainPtr<> now.
(WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
- Remove release of m_savedNSGraphicsContext since that is handled by RetainPtr<> now.
(WebCore::LocalCurrentGraphicsContext::cgContext): Delete.
- Inline into header to share implementation with iOS.
Source/WebCore/PAL:
- pal/ios/UIKitSoftLink.h:
- pal/ios/UIKitSoftLink.mm:
- Add soft linking of UIGraphics{GetCurrent,Pop,Push}Context() functions.
Source/WebKit:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::convertPlatformImageToBitmap):
- Use LocalCurrentGraphicsContext for both iOS and Mac code paths.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
- Switch from PLATFORM(MAC) and PLATFORM(IOS_FAMIY) to USE(APPKIT) to separate platform code.
(WebKit::convertDragImageToBitmap):
(WebKit::convertImageToBitmap): Delete.
(WebKit::convertCGImageToBitmap): Delete.
- Combine Mac-specific convertImageToBitmap() and iOS-specific convertCGImageToBitmap() into a single method using DragImage type and special-casing one line of code.
(WebKit::WebDragClient::startDrag):
(WebKit::WebDragClient::didConcludeEditDrag):
- Combine iOS and Mac methods into a singe method.
- 3:40 PM Changeset in webkit [261441] by
-
- 11 edits in trunk/Source/JavaScriptCore
Fix build errors and warnings for non-unified JSCOnly
https://bugs.webkit.org/show_bug.cgi?id=211655
Reviewed by Darin Adler and Yusuke Suzuki.
- bytecode/BytecodeDumper.cpp:
(JSC::isConstantRegisterIndex): Deleted.
Remove unused function.
- llint/LLIntEntrypoint.cpp:
- llint/LLIntThunks.cpp:
- llint/LLIntThunks.h:
- runtime/AggregateErrorConstructor.cpp:
- runtime/AggregateErrorPrototype.cpp:
- wasm/js/WebAssemblyFunction.cpp:
Fix includes.
- tools/JSDollarVM.cpp:
Deal with "unused constant" warnings for needsDestruction.
- wasm/WasmLLIntPlan.cpp:
- wasm/WasmSignature.cpp:
Remove unused constants.
- 3:29 PM Changeset in webkit [261440] by
-
- 2 edits in trunk/Source/WTF
Add iterator checking to ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=211669
Reviewed by Anders Carlsson.
HashSet and HashMap have iterator checking in debug builds.
Add similar checking to ListHashSet, controlled by the same
macro, CHECK_HASHTABLE_ITERATORS. Use WeakPtr to make the
implementation simple.
- wtf/ListHashSet.h: Make ListHashSet and ListHashSetNode derive
from CanMakeWeakPtr. Add m_weakSet and m_weakPosition members to
ListHashSetConstIterator, and assert their values at the appropriate
times so we will get a breakpoint or crash.
- 1:15 PM Changeset in webkit [261439] by
-
- 2 edits in trunk/Source/WebCore
Fix null-dereference in DocumentTimelinesController::updateAnimationsAndSendEvents
https://bugs.webkit.org/show_bug.cgi?id=211667
Reviewed by Antoine Quint.
- animation/DocumentTimelinesController.cpp:
(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents): Add null
check before removing animationsToRemove, which may already have been removed
since any arbitrary change could occur while animations are firing.
- 9:07 AM Changeset in webkit [261438] by
-
- 2 edits in trunk/Source/WebCore
Add missing null-check of page in ResourceLoader::loadDataURL
https://bugs.webkit.org/show_bug.cgi?id=211589
rdar://57213601
Reviewed by Anders Carlsson.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL): Add null check before using page.
- 9:04 AM Changeset in webkit [261437] by
-
- 15 edits in trunk
Streamline MarkupAccumulator to improve efficiency a bit
https://bugs.webkit.org/show_bug.cgi?id=211656
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- b3/air/AirFixPartialRegisterStalls.h: Fix spelling of "explicitly".
Source/WebCore:
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendCharactersReplacingEntities): Corrected early
exit so it returns any time the length is 0. For some reason the code before
wouldn't do the early return when offset is non-zero, which is unnecessary.
(WebCore::MarkupAccumulator::appendString): Deleted.
(WebCore::MarkupAccumulator::appendStringView): Deleted.
(WebCore::MarkupAccumulator::appendEndTag): Use variadic append to cut down
on memory allocations.
(WebCore::MarkupAccumulator::totalLength): Deleted.
(WebCore::MarkupAccumulator::concatenateMarkup): Deleted.
(WebCore::MarkupAccumulator::takeMarkup): Added.
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue): Use variadic
append to cut down on memory allocations. Also use char instead of UChar so
the string building code doesn't have to do an 8/16 bit check.
(WebCore::shouldAddNamespaceElement): Prepend a literal, don't bother to
make a String just to append to another String. Also made this a
non-member function.
(WebCore::shouldAddNamespaceAttribute): Made this a non-member function.
(WebCore::MarkupAccumulator::appendNamespace): Fix hash table usage
to use add instead of get followed by set to avoid double hashing.
Use variadic append to cut down on memory allocation.
(WebCore::MarkupAccumulator::appendText): Tweaked style to make this a
one-line function.
(WebCore::appendComment): Deleted.
(WebCore::appendXMLDeclaration): Made this a non-member function.
Use variadic append to cut down on memory allocation.
(WebCore::appendDocumentType): Made this a non-member function.
Use variadic append to cut down on memory allocation.
(WebCore::MarkupAccumulator::appendCDATASection): Deleted.
(WebCore::MarkupAccumulator::appendNonElementNode): Moved the bodies of
appendComment, appendProcessingInstruction, and appendCDATASection in
here since they can all be one-line variadic append calls.
- editing/MarkupAccumulator.h:
(WebCore::MarkupAccumulator::length const): Changed the return type
of length to be unsigned since that's what StringBuilder returns.
Made isAllASCII call StringBuilder::isAllASCII. Replaced appendString
and appendStringView with variadic append. Removed many functions
that no longer need to be member functions. Made appendAttributeValue
a static member function. Made appendNamespace private. Made
m_serializationSyntax const.
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Use append
instead of appenString.
(WebCore::StyledMarkupAccumulator::isAllASCII const): Added. Before
the code would only check the StringBuilder, but we also need to
check m_reversedPrecedingMarkup.
(WebCore::StyledMarkupAccumulator::takeResults): Use CheckedUint32
since StringBuilder's reserveCapacity function takes unsigned, not
size_t. The old code, using totalLength, would just pass a size_t
and let it get chopped off, which didn't do any harm, but it seems
strange to compute a 64-bit value just to chop off the lower 32
bits. An alternative is to compute the 32-bit value and just let
it overflow. Use a modern for loop by defining a ReverseView
template rather than writing a confusing backwards loop. Use the
new takeMarkup instead of concatenateMarkup.
(WebCore::StyledMarkupAccumulator::appendText): Tweak coding
style a little bit.
(WebCore::StyledMarkupAccumulator::appendStartTag): Ditto.
(WebCore::StyledMarkupAccumulator::appendNodeToPreserveMSOList):
Use variadic append to cut down on memory allocations.
(WebCore::propertyMissingOrEqualToNone): Tweak coding style a bit.
(WebCore::serializePreservingVisualAppearanceInternal): Use
append instead of appendString.
(WebCore::shouldPreserveMSOLists): Take a StringView instead of a
String to eliminate unnecessary memory allocation in call to substring.
(WebCore::sanitizedMarkupForFragmentInDocument): Use makeString
instead of StringBuilder to cut down on memory allocation.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::resetDefaultButton): Fix spelling error
in the word "explicitly".
- mathml/MathMLOperatorDictionary.cpp:
(WebCore::MathMLOperatorDictionary::search): Ditto.
- page/PageSerializer.cpp:
(WebCore::PageSerializer::SerializerMarkupAccumulator::SerializerMarkupAccumulator):
Use variadic append instead of appendString to cut down on
memory allocations.
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint): Fix spelling error in the word
"explicitly".
Source/WTF:
- wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::isAllASCII const): Added.
- wtf/text/StringBuilder.h: Added isAllASCII.
Tools:
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST): Fix spellling error in the word "explicitly".
- 9:02 AM Changeset in webkit [261436] by
-
- 5 edits in trunk/Source
Remove HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI
https://bugs.webkit.org/show_bug.cgi?id=211662
rdar://problem/63048713
Reviewed by Darin Adler.
Source/WebKit:
Remove this platform conditional and unconditionally use -[UIScrolView _flashScrollIndicatorsForAxes:
persistingPreviousFlashes:]. All supported platforms with UIScrollView have this SPI, and the conditional
was excluding Mac Catalyst, making WKKeyboardScrollViewAnimator send a message to its scroll view that
is no longer implemented.
- Platform/spi/ios/UIKitSPI.h:
Remove the declaration of the now unused -_flashScrollIndicatorsPersistingPreviousFlashes:.
- UIProcess/ios/WKKeyboardScrollingAnimator.mm:
(axesForDelta):
(-[WKKeyboardScrollViewAnimator scrollToContentOffset:animated:]):
Source/WTF:
- wtf/PlatformHave.h:
- 4:10 AM Changeset in webkit [261435] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening, update test expectations
https://bugs.webkit.org/show_bug.cgi?id=211664
Gardening of flaky failures and failures reintroduced after latest
patches reverted.
- platform/gtk/TestExpectations:
- 1:07 AM Changeset in webkit [261434] by
-
- 3 edits2 adds in trunk
Nullptr crash in LegacyWebArchive::createPropertyListRepresentation when copying selected range that contains surrogate characters
https://bugs.webkit.org/show_bug.cgi?id=211658
<rdar://problem/62844424>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Added check for null LegacyWebArchive in LegacyWebArchive::createFromSelection. Return nullptr when creation fails.
Test: webarchive/copy-surrogate-char-crash.html
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createFromSelection):
LayoutTests:
Added a regression test for the crash.
- webarchive/copy-surrogate-char-crash-expected.txt: Added.
- webarchive/copy-surrogate-char-crash.html: Added.
- 12:00 AM Changeset in webkit [261433] by
-
- 5 edits in trunk
Fix wpt shadow-dom/slots-fallback-in-document.html
https://bugs.webkit.org/show_bug.cgi?id=211640
Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-05-09
Reviewed by Ryosuke Niwa.
By specs, HTMLSlotElement.assignedNodes() should not count children of
a slot in a document tree for flattened assigned nodes.
https://html.spec.whatwg.org/multipage/scripting.html#dom-slot-assignednodes
https://dom.spec.whatwg.org/#find-flattened-slotables
As sideeffect, this patch also fix wpt
shadow-dom/slots-outside-shadow-dom-expected.html
LayoutTests/imported/w3c:
- web-platform-tests/shadow-dom/slots-fallback-in-document-expected.txt:
- web-platform-tests/shadow-dom/slots-outside-shadow-dom-expected.txt:
Source/WebCore:
Test: web-platform-tests/shadow-dom/slots-fallback-in-document.html
web-platform-tests/shadow-dom/slots-outside-shadow-dom.html
- html/HTMLSlotElement.cpp:
(WebCore::flattenAssignedNodes):
May 8, 2020:
- 10:32 PM Changeset in webkit [261432] by
-
- 2 edits1 delete in trunk/LayoutTests
[GTK] Gardening, update expectations after revert of r261341 and r261392
https://bugs.webkit.org/show_bug.cgi?id=211661
Unreviewed gardening.
- platform/gtk/TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/intrinsic_sizes-expected.txt: Removed.
- 9:17 PM Changeset in webkit [261431] by
-
- 2 edits in trunk/Source/WebCore
Fix build error on PlatStation port after r261132
https://bugs.webkit.org/show_bug.cgi?id=211659
Unreviewed build fix after r261132.
- page/scrolling/ScrollingTreeGestureState.cpp:
- 6:43 PM Changeset in webkit [261430] by
-
- 4 edits in trunk
Array.prototype.concat fast path checks should not be observable
https://bugs.webkit.org/show_bug.cgi?id=211643
Reviewed by Ross Kirsling.
JSTests:
While test262 has complete coverage for @@isConcatSpreadable getters in prototype
chain, Proxy cases are covered by stress/array-concat-fast-spread-proxy.js and
stress/array-concat-spread-proxy.js.
- test262/expectations.yaml: Mark 2 test cases as passing.
Source/JavaScriptCore:
This change utilizes @tryGetByIdWithWellKnownSymbol intrinsic to make
off the spec Symbol.isConcatSpreadable lookups unobservable to userland code,
aligning JSC with V8 and SpiderMonkey.
Since @tryGetById uses PropertySlot::getPureResult(), which returns
null
for Proxy Get? traps and JS getters (covered by stress/try-get-by-id.js),
we can safely compare its resultundefined. Also, this allows us to remove
@isProxyObject check as Proxy argument is never a fast path anyway.
This patch is neutral on microbenchmarks/concat-append-one.js.
- builtins/ArrayPrototype.js:
(concat):
- 6:21 PM Changeset in webkit [261429] by
-
- 7 edits35 deletes in trunk
Remove empty directories from from svn.webkit.org repository
<https://webkit.org/b/211644>
Reviewed by Darin Adler.
- 6:13 PM Changeset in webkit [261428] by
-
- 14 edits1 move in trunk
[WTF] Share Linux's MemoryPressureHandler among other Unix ports
https://bugs.webkit.org/show_bug.cgi?id=208955
Reviewed by Yusuke Suzuki.
Source/bmalloc:
Added FreeBSD implementation of memoryFootprint().
- bmalloc/AvailableMemory.cpp:
(bmalloc::memoryStatus):
- bmalloc/AvailableMemory.h:
(bmalloc::isUnderMemoryPressure):
- bmalloc/bmalloc.h:
Source/WTF:
Renamed MemoryPressureHandlerLinux to MemoryPressureHandlerUnix and added FreeBSD implementation
of memory status functions. Change PlayStation port to use it from generic implementation.
- wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::MemoryPressureHandler):
- wtf/MemoryPressureHandler.h:
- wtf/PlatformGTK.cmake:
- wtf/PlatformJSCOnly.cmake:
- wtf/PlatformPlayStation.cmake:
- wtf/PlatformWPE.cmake:
- wtf/generic/MemoryFootprintGeneric.cpp:
(WTF::memoryFootprint):
- wtf/unix/MemoryPressureHandlerUnix.cpp: Renamed from Source\WTF\wtf\linux\MemoryPressureHandlerLinux.cpp.
(WTF::processMemoryUsage):
Tools:
Fix unneeded library dependency.
- TestWebKitAPI/CMakeLists.txt:
- 5:02 PM Changeset in webkit [261427] by
-
- 10 edits2 adds in trunk
Async overflow scroll: sometimes a <select> becomes non-scrollable
https://bugs.webkit.org/show_bug.cgi?id=211433
<rdar://problem/62338474>
Reviewed by Dean Jackson.
Source/WebCore:
Scrollable <select>s (RenderListBox) contribute to the non-fast scrollable region, so
wheel events inside them are propagated to the main thread. If the select is scrolled
to the end, the event will propagate to the enclosing scroller, then then FrameView::wheelEvent()
may send it back to the scrolling thread. If the scrolling thread is processing such an event
after the main thread, it should not perform any latching on the main thread.
Test: scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe.html
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::handleWheelEvent):
- page/scrolling/ScrollingTree.h:
- page/scrolling/ScrollingTreeLatchingController.cpp:
(WebCore::ScrollingTreeLatchingController::receivedWheelEvent):
(WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const):
(WebCore::ScrollingTreeLatchingController::nodeDidHandleEvent):
(WebCore::ScrollingTreeLatchingController::clearLatchedNode):
- page/scrolling/ScrollingTreeLatchingController.h:
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):
- page/scrolling/ThreadedScrollingTree.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::handleWheelEvent):
- platform/PlatformWheelEvent.cpp:
(WebCore::operator<<):
LayoutTests:
- scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe-expected.txt: Added.
- scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe.html: Added.
- 5:02 PM Changeset in webkit [261426] by
-
- 1 edit4 adds in trunk/LayoutTests
Overflow scrollers in iframes don't get mouseMovedInContentArea()
https://bugs.webkit.org/show_bug.cgi?id=211347
<rdar://problem/62784560>
Reviewed by Tim Horton.
Land some tests that were missing from r261382.
- fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered-expected.txt: Added.
- fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered.html: Added.
- fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal-expected.txt: Added.
- fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal.html: Added.
- 5:00 PM Changeset in webkit [261425] by
-
- 1 edit2 adds in trunk/LayoutTests
[LFC][TFC] The fixed logical width should be used as the max width for a cell
https://bugs.webkit.org/show_bug.cgi?id=211610
Unreviewed test gardening.
Add a baseline for Windows.
- platform/win/fast/layoutformattingcontext/table-simple-with-fixed-widht-and-inline-content-expected.txt: Added.
- 4:20 PM Changeset in webkit [261424] by
-
- 8 edits in trunk/Source
Remove now-unneeded HAVE(AVFOUNDATION_LOADER_DELEGATE)
https://bugs.webkit.org/show_bug.cgi?id=211646
Reviewed by Eric Carlson.
Source/WebCore:
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::requestResource): Remove check of
HAVE(AVFOUNDATION_LOADER_DELEGATE) in a place where it also checks PLATFORM(MAC).
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
Remove HAVE(AVFOUNDATION_LOADER_DELEGATE) in Cocoa-only code.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Ditto.
(WebCore::globalLoaderDelegateQueue): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest): Ditto.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Ditto.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm: Ditto.
Source/WTF:
- wtf/PlatformHave.h: Don't set HAVE_AVFOUNDATION_LOADER_DELEGATE.
- 4:11 PM Changeset in webkit [261423] by
-
- 2 edits in trunk/Source/WebKit
Regression(r210945): No attachment when sharing to mail
https://bugs.webkit.org/show_bug.cgi?id=211651
<rdar://problem/63040170>
Reviewed by Tim Horton.
When failing to determine foreground state, the code before r210945 was assuming
'foreground', while the code in r210945 assume 'background'. This causes things
to not render properly when we fail to determine the foreground state.
This patch merely restores pre-r210945 behavior. I will investigate why we are
unable to determinate the host application PID for the MailCompositionService.
- UIProcess/ApplicationStateTracker.mm:
(WebKit::isApplicationForeground):
- 4:11 PM Changeset in webkit [261422] by
-
- 3 edits1 add in trunk
TextureMapper should skip clipping a content layer if it's not needed
https://bugs.webkit.org/show_bug.cgi?id=210787
Patch by Tomoki Imai <Tomoki Imai> on 2020-05-08
Reviewed by Don Olmstead.
Source/WebCore:
This patch follows up r260174.
We don't need to clip a content layer if the clipping rect contains the content rect.
This patch doesn't change the behavior but saves stencil indices.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintSelf):
LayoutTests:
This patch follows up r260174 by updating the test expectation.
- platform/gtk/compositing/video/video-object-fit-expected.txt: Added.
- 3:56 PM Changeset in webkit [261421] by
-
- 5 edits in trunk/Tools
webkitpy: 'iPhone SE' should match 'iPhone SE 1st generation'
https://bugs.webkit.org/show_bug.cgi?id=211642
<rdar://problems/62986242>
Rubber-stamped by Aakash Jain.
- Scripts/webkitpy/xcode/device_type.py:
(DeviceType):
(DeviceType.standardized_hardware_type): Strip '1st generation' from models.
(DeviceType.eq): Use standardized hardware type.
(DeviceType.contains): Ditto.
(DeviceType.hash): Ditto.
- Scripts/webkitpy/xcode/device_type_unittest.py:
(DeviceTypeTest):
(DeviceTypeTest.test_generation_matching):
- Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._get_device_identifier_for_type): Handle case where the requests model does not
end with '(1st generation)', but the simctl model does.
- Scripts/webkitpy/xcode/simulated_device_unittest.py:
- 3:09 PM Changeset in webkit [261420] by
-
- 1 copy in tags/Safari-610.1.12
Tag Safari-610.1.12.
- 3:04 PM Changeset in webkit [261419] by
-
- 7 edits in branches/safari-610.1.12-branch
Revert r260642. rdar://problem/63037576
- 2:41 PM Changeset in webkit [261418] by
-
- 2 edits in trunk/Tools
TestWebKitAPI.WebKit.AllowsContentJavaScript fails on iPad simulator
https://bugs.webkit.org/show_bug.cgi?id=207874
Unreviewed test gardening.
- TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
Disable the test for iOS.
- 2:21 PM Changeset in webkit [261417] by
-
- 1 edit1 delete in trunk/PerformanceTests
Remove no-longer-used PerformanceTests/StitchMarker
https://bugs.webkit.org/show_bug.cgi?id=211639
Reviewed by Ryosuke Niwa.
Having this test around can be confusing since it contains old versions
of many WebKit source files, which will show up when searching the source
tree. And since we're not using it, we don't need to keep a copy of it
in the tip of tree in the repository.
- StitchMarker: Removed.
- 2:16 PM Changeset in webkit [261416] by
-
- 3 edits2 adds in trunk
[iOS] Text-style fonts aren't locale-specific
https://bugs.webkit.org/show_bug.cgi?id=211438
<rdar://problem/51654163>
Reviewed by Sam Weinig.
Source/WebCore:
Simply hook up the locale to the Core Text function.
It turns out that this patch actually has no behavior change,
because this locale is only used for font fallback, but WebKit
does its own font fallback and we already pass the locale into
CTFontCopyDefaultCascadeListForLanguages(). However, for
symmetry with CTFontCreateUIFontWithLanguage() it's a good idea
to just supply it anyway. Just in case.
Test: platform/ios/fast/text/lang-text-style.html
- platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::createTextStyleFont):
LayoutTests:
This test actually already passes. But it's a good idea to make
sure that it continues to pass in the future.
- platform/ios/fast/text/lang-text-style-expected-mismatch.html: Added.
- platform/ios/fast/text/lang-text-style.html: Added.
- 2:14 PM Changeset in webkit [261415] by
-
- 3 edits in trunk/Tools
check-webkit-style false positive for [readability/naming/protected] with method declaration
<https://webkit.org/b/210682>
Reviewed by Darin Adler.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
- Don't check for invalid protector name if the capitalized protected name is the same as the original protected name, indicating it's a type name.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_names):
- Add test cases.
- 1:57 PM Changeset in webkit [261414] by
-
- 2 edits in trunk/Tools
Fix build on platforms without network framework.
https://bugs.webkit.org/show_bug.cgi?id=211603
- TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
Add HAVE(NETWORK_FRAMEWORK) around test that uses network framework.
- 1:48 PM Changeset in webkit [261413] by
-
- 106 edits in trunk
[WebGL2] Complete new texture upload entry points in WebGL2RenderingContext
https://bugs.webkit.org/show_bug.cgi?id=208875
Patch by Kenneth Russell <kbr@chromium.org> on 2020-05-08
Reviewed by Dean Jackson.
Source/WebCore:
Implement the remaining texture upload entry points - mainly for
3D textures - in WebGL2RenderingContext. Add support for uploading
from the pixel unpack buffer.
Refactor the WebGL 2.0 binding points into WebGL2RenderingContext,
where they had previously been in the base class. Refactor
validation code to override the base class where necessary.
Refactor getParameter into WebGLRenderingContextBase and override
it in WebGL2RenderingContext, eliminating duplicate code and
fixing bugs.
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::~WebGL2RenderingContext):
(WebCore::WebGL2RenderingContext::getInt64Parameter):
(WebCore::WebGL2RenderingContext::validateBufferTarget):
(WebCore::WebGL2RenderingContext::validateBufferTargetCompatibility):
(WebCore::WebGL2RenderingContext::validateBufferDataTarget):
(WebCore::WebGL2RenderingContext::validateAndCacheBufferBinding):
(WebCore::WebGL2RenderingContext::validateTexImageBinding):
(WebCore::WebGL2RenderingContext::validateTexture3DBinding):
(WebCore::WebGL2RenderingContext::copyBufferSubData):
(WebCore::WebGL2RenderingContext::bindFramebuffer):
(WebCore::WebGL2RenderingContext::deleteFramebuffer):
(WebCore::WebGL2RenderingContext::getTexParameter):
(WebCore::WebGL2RenderingContext::texStorage2D):
(WebCore::WebGL2RenderingContext::texStorage3D):
(WebCore::WebGL2RenderingContext::texImage2D):
(WebCore::WebGL2RenderingContext::texImage3D):
(WebCore::WebGL2RenderingContext::texSubImage2D):
(WebCore::WebGL2RenderingContext::texSubImage3D):
(WebCore::WebGL2RenderingContext::bindBufferBase):
(WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGL2RenderingContext::validateFramebufferTarget):
(WebCore::WebGL2RenderingContext::getFramebufferBinding):
(WebCore::WebGL2RenderingContext::getReadFramebufferBinding):
(WebCore::WebGL2RenderingContext::restoreCurrentFramebuffer):
(WebCore::WebGL2RenderingContext::getParameter):
(WebCore::WebGL2RenderingContext::uncacheDeletedBuffer):
(WebCore::WebGL2RenderingContext::validateFramebufferFuncParameters): Deleted.
- html/canvas/WebGL2RenderingContext.h:
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::setTarget):
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::attach):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::isBound const):
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters): Deleted.
(WebCore::WebGLRenderingContext::getParameter): Deleted.
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::~WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::validateBufferTarget):
(WebCore::WebGLRenderingContextBase::validateBufferDataTarget):
(WebCore::WebGLRenderingContextBase::validateAndCacheBufferBinding):
(WebCore::WebGLRenderingContextBase::bindBuffer):
(WebCore::WebGLRenderingContextBase::bindFramebuffer):
(WebCore::WebGLRenderingContextBase::bindTexture):
(WebCore::WebGLRenderingContextBase::checkFramebufferStatus):
(WebCore::WebGLRenderingContextBase::uncacheDeletedBuffer):
(WebCore::WebGLRenderingContextBase::deleteFramebuffer):
(WebCore::WebGLRenderingContextBase::deleteRenderbuffer):
(WebCore::WebGLRenderingContextBase::deleteTexture):
(WebCore::WebGLRenderingContextBase::framebufferRenderbuffer):
(WebCore::WebGLRenderingContextBase::framebufferTexture2D):
(WebCore::WebGLRenderingContextBase::getParameter):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::copyTexImage2D):
(WebCore::WebGLRenderingContextBase::texParameter):
(WebCore::WebGLRenderingContextBase::getBoundReadFramebufferColorFormat):
(WebCore::WebGLRenderingContextBase::getBoundReadFramebufferWidth):
(WebCore::WebGLRenderingContextBase::getBoundReadFramebufferHeight):
(WebCore::WebGLRenderingContextBase::validateFramebufferTarget):
(WebCore::WebGLRenderingContextBase::getFramebufferBinding):
(WebCore::WebGLRenderingContextBase::getReadFramebufferBinding):
(WebCore::WebGLRenderingContextBase::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContextBase::validateBufferDataParameters):
(WebCore::WebGLRenderingContextBase::setFramebuffer):
(WebCore::WebGLRenderingContextBase::restoreCurrentFramebuffer):
(WebCore::WebGLRenderingContextBase::getInt64Parameter): Deleted.
- html/canvas/WebGLRenderingContextBase.h:
LayoutTests:
All of the 3D texture tests in
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/ and
webgl/2.0.0/conformance2/textures/image_data/ now pass, and
several others progress, including some which now pass completely.
Rebaseline all of these.
Skip webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/
temporarily to reduce the size of these rebaselines, as the
failures are likely caused by non-WebGL browser bugs. Filed Bug
211484 to track re-enabling them.
- TestExpectations:
- platform/mac/webgl/fingerprinting-strings-expected.txt:
- webgl/2.0.0/conformance/state/gl-enable-enum-test-expected.txt:
- webgl/2.0.0/conformance2/buffers/buffer-copying-contents-expected.txt:
- webgl/2.0.0/conformance2/buffers/buffer-copying-restrictions-expected.txt:
- webgl/2.0.0/conformance2/buffers/buffer-type-restrictions-expected.txt:
- webgl/2.0.0/conformance2/buffers/uniform-buffers-expected.txt:
- webgl/2.0.0/conformance2/misc/expando-loss-2-expected.txt:
- webgl/2.0.0/conformance2/misc/getextension-while-pbo-bound-stability-expected.txt:
- webgl/2.0.0/conformance2/misc/object-deletion-behaviour-2-expected.txt:
- webgl/2.0.0/conformance2/misc/views-with-offsets-expected.txt:
- webgl/2.0.0/conformance2/renderbuffers/framebuffer-texture-layer-expected.txt:
- webgl/2.0.0/conformance2/rendering/blitframebuffer-test-expected.txt:
- webgl/2.0.0/conformance2/rendering/canvas-resizing-with-pbo-bound-expected.txt:
- webgl/2.0.0/conformance2/rendering/out-of-bounds-index-buffers-after-copying-expected.txt:
- webgl/2.0.0/conformance2/state/gl-get-calls-expected.txt:
- webgl/2.0.0/conformance2/state/gl-getstring-expected.txt:
- webgl/2.0.0/conformance2/state/gl-object-get-calls-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r11f_g11f_b10f-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r11f_g11f_b10f-rgb-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r16f-red-float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r16f-red-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r32f-red-float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r8-red-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r8ui-red_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rg16f-rg-float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rg16f-rg-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rg32f-rg-float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rg8-rg-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rg8ui-rg_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb16f-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb16f-rgb-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb32f-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb565-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb565-rgb-unsigned_short_5_6_5-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb5_a1-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb5_a1-rgba-unsigned_short_5_5_5_1-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb8-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb9_e5-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb9_e5-rgb-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba16f-rgba-float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba16f-rgba-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba32f-rgba-float-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba4-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba4-rgba-unsigned_short_4_4_4_4-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba8-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-srgb8-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-r11f_g11f_b10f-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-r11f_g11f_b10f-rgb-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-r16f-red-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-r16f-red-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-r32f-red-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-r8-red-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-r8ui-red_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rg16f-rg-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rg16f-rg-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rg32f-rg-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rg8-rg-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rg8ui-rg_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb16f-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb16f-rgb-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb32f-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb565-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb565-rgb-unsigned_short_5_6_5-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb5_a1-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb5_a1-rgba-unsigned_short_5_5_5_1-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb8-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb9_e5-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb9_e5-rgb-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba16f-rgba-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba16f-rgba-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba32f-rgba-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba4-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba4-rgba-unsigned_short_4_4_4_4-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba8-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-srgb8-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_data/tex-3d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/copy-texture-image-webgl-specific-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/gl-get-tex-parameter-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/tex-image-and-sub-image-with-array-buffer-view-sub-source-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/tex-input-validation-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/tex-storage-2d-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/tex-storage-and-subimage-3d-expected.txt:
- webgl/2.0.0/conformance2/textures/misc/tex-unpack-params-expected.txt:
- 1:46 PM Changeset in webkit [261412] by
-
- 18 edits2 adds in trunk
Implement web-share v2 for files
https://bugs.webkit.org/show_bug.cgi?id=209265
Reviewed by Andy Estes.
LayoutTests/imported/w3c:
Updated test expectations for new behavior.
- ios-wk2/imported/w3c/web-platform-tests/web-share/canShare-files.https-expected.txt :
- mac-wk2/imported/w3c/web-platform-tests/web-share/canShare-files.https-expected.txt :
Source/WebCore:
Modified existing tests for new behavior.
Added support for handling of files in share/canShare,
and implemented asynchronous reading of data from blobs on
disk into memory.
- WebCore.xcodeproj/project.pbxproj:
- page/Navigator.cpp:
(WebCore::Navigator::canShare):
(WebCore::Navigator::share):
(WebCore::Navigator::finishedLoad):
- page/Navigator.h:
- page/ReadShareDataAsync.cpp: Added.
(WebCore::ReadShareDataAsync::readInternal):
(WebCore::ReadShareDataAsync::ReadShareDataAsync):
(WebCore::ReadShareDataAsync::~ReadShareDataAsync):
(WebCore::ReadShareDataAsync::start):
(WebCore::ReadShareDataAsync::didFinishLoading):
(WebCore::ReadShareDataAsync::didReceiveData):
(WebCore::ReadShareDataAsync::didStartLoading):
(WebCore::ReadShareDataAsync::didFail):
- page/ReadShareDataAsync.hpp: Added.
- page/ShareData.h:
Source/WebKit:
Added support for passing file objects over IPC and
sharing of files to share sheet.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Vector<RawFile>>::encode):
(IPC::ArgumentCoder<Vector<RawFile>>::decode):
(IPC::ArgumentCoder<ShareDataWithParsedURL>::encode):
(IPC::ArgumentCoder<ShareDataWithParsedURL>::decode):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/Cocoa/ShareableFileWrite.h: Added.
- UIProcess/Cocoa/ShareableFileWrite.mm: Added.
(+[WKShareableFileWrite getSharingDirectoryPath]):
(+[WKShareableFileWrite getFileDirectoryForSharing]):
(+[WKShareableFileWrite removeFileDirectoryForSharing]):
(+[WKShareableFileWrite setQuarantineInformationForFilePath:]):
(+[WKShareableFileWrite applyQuarantineSandboxAndDownloadFlagsToFileAtPath:]):
(+[WKShareableFileWrite createFilename:]):
(+[WKShareableFileWrite writeFileToShareableURL:data:]):
- UIProcess/Cocoa/WKShareSheet.mm:
(-[WKShareSheet presentWithParameters:inRect:completionHandler:]):
(-[WKShareSheet _didCompleteWithSuccess:]):
- WebKit.xcodeproj/project.pbxproj:
LayoutTests:
Modified to no longer use url of image.
- fast/web-share/share-with-files.html:
- 1:43 PM Changeset in webkit [261411] by
-
- 3 edits in trunk/Source/WebKit
Revise sandbox to stop logging some commonly-used properties
https://bugs.webkit.org/show_bug.cgi?id=211636
<rdar://problem/63014244>
Reviewed by Per Arne Vollan.
Further living on and testing has shown a handful of sysctl entries that are in regular use, and do not need
to be logged or considered for removal. This patch has no change in behavior, just reduces logging.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- 1:41 PM Changeset in webkit [261410] by
-
- 2 edits in trunk/LayoutTests
REGRESSION [ iOS ] fast/forms/validationMessage.html is flaky and timing out
https://bugs.webkit.org/show_bug.cgi?id=206630
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 1:27 PM Changeset in webkit [261409] by
-
- 14 edits2 deletes in trunk
Unreviewed, reverting r261341 and r261392.
Caused multiple regression test failures
Reverted changesets:
"Poster set after playback begins should be ignored"
https://bugs.webkit.org/show_bug.cgi?id=211464
https://trac.webkit.org/changeset/261341
"REGRESSION(r261341): imported/w3c/web-platform-
tests/html/semantics/embedded-content/the-video-
element/intrinsic_sizes.htm is failing"
https://bugs.webkit.org/show_bug.cgi?id=211612
https://trac.webkit.org/changeset/261392
- 1:20 PM Changeset in webkit [261408] by
-
- 18 edits2 deletes in trunk/Tools
Delete old ews client side code
https://bugs.webkit.org/show_bug.cgi?id=211638
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- Scripts/webkitpy/common/config/urls.py: Removed old ews server url.
- Scripts/webkitpy/common/net/statusserver.py: Removed.
- Scripts/webkitpy/common/net/statusserver_mock.py: Removed.
- Scripts/webkitpy/tool/bot/botinfo.py:
- Scripts/webkitpy/tool/bot/botinfo_unittest.py:
- Scripts/webkitpy/tool/bot/flakytestreporter.py:
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/perfalizer.py:
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue._log_from_script_error_for_upload): Deleted.
(AbstractQueue._update_status_for_script_error): Deleted.
(AbstractPatchQueue._update_status): Deleted.
(AbstractPatchQueue._release_work_item): Deleted.
(AbstractPatchQueue._did_pass): Deleted.
(AbstractPatchQueue._did_fail): Deleted.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractQueueTest._assert_run_webkit_patch):
(AbstractQueueTest.test_no_iteration_count):
(PatchProcessingQueueTest.test_upload_results_archive_for_patch):
(AbstractQueueTest._assert_log_message): Deleted.
(AbstractQueueTest.test_log_from_script_error_for_upload): Deleted.
(AbstractPatchQueueTest): Deleted.
(NeedsUpdateSequence): Deleted.
(NeedsUpdateSequence._run): Deleted.
(StyleQueueTest): Deleted.
(StyleQueueTest.test_style_queue_with_style_exception): Deleted.
- Scripts/webkitpy/tool/commands/queuestest.py:
(QueuesTest._default_begin_work_queue_logs):
(QueuesTest._default_begin_work_queue_stderr): Deleted.
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/mocktool.py:
- 1:10 PM Changeset in webkit [261407] by
-
- 10 edits in trunk
Make WKWebViewConfiguration._alwaysRunsAtForegroundPriority an alias for _clientNavigationsRunAtForegroundPriority
https://bugs.webkit.org/show_bug.cgi?id=211632
Reviewed by Darin Adler.
Make WKWebViewConfiguration._alwaysRunsAtForegroundPriority an alias for _clientNavigationsRunAtForegroundPriority.
_alwaysRunsAtForegroundPriority is a frequent source of process assertion leaks that get blamed on WebKit. Clients
are using this in order to be able to do loads in background views so _clientNavigationsRunAtForegroundPriority
should suffice and is not leak prone since the process assertion is released after the navigation has completed.
- UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::copy const):
- UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::alwaysRunsAtForegroundPriority const): Deleted.
(API::PageConfiguration::setAlwaysRunsAtForegroundPriority): Deleted.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _alwaysRunsAtForegroundPriority]):
(-[WKWebViewConfiguration _setAlwaysRunsAtForegroundPriority:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::updateThrottleState):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/WebPageProxy.h:
- 1:08 PM Changeset in webkit [261406] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a regression test for bug 211541
https://bugs.webkit.org/show_bug.cgi?id=211635
Reviewed by Geoffrey Garen.
- fast/box-shadow/box-shadow-huge-area-crash-expected.html: Added.
- fast/box-shadow/box-shadow-huge-area-crash.html: Added.
- 1:05 PM Changeset in webkit [261405] by
-
- 2 edits in trunk/Source/WebKit
Revert r260390
https://bugs.webkit.org/show_bug.cgi?id=210759
<rdar://problem/62608140>
r260390 was intended to stop hitting some assertions in ~PendingFrameLoad, but it seems to have caused a regression.
Reverting it and removing the invalid assertions.
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::~PendingFrameLoad):
(WebKit::NetworkCache::SpeculativeLoadManager::~SpeculativeLoadManager):
- 12:59 PM Changeset in webkit [261404] by
-
- 2 edits in trunk/LayoutTests
media/video-zoom.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=211631
Reviewed by Eric Carlson.
Remove the 1.5s early timeout check here; with the additional 150ms per video element timeout elsewhere
in the test, this is short enough to cause flaky failures on busy bots.
- media/video-zoom.html:
- 12:45 PM Changeset in webkit [261403] by
-
- 2 edits in branches/safari-610.1.12-branch/Source/WebKit
Revert r260787. rdar://problem/63032130
- 12:39 PM Changeset in webkit [261402] by
-
- 4 edits in trunk
Limit HTTP referer to 4kb
https://bugs.webkit.org/show_bug.cgi?id=211603
<rdar://problem/56768823>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-05-08
Reviewed by Chris Dumez.
Source/WebCore:
Use the origin if it's longer, unless the origin is too long.
This matches the behavior of other browsers.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1557346
Tested by API tests.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setHTTPReferrer):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
(TEST):
- 12:11 PM Changeset in webkit [261401] by
-
- 2 edits in branches/safari-609-branch/Tools
Cherry-pick r260484. rdar://problem/62140724
Bindings-test should not depend on current working directory.
https://bugs.webkit.org/show_bug.cgi?id=210831
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/bindings/main.py: (BindingsTests.main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:36 AM Changeset in webkit [261400] by
-
- 2 edits in trunk/Source/WebCore
SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN
https://bugs.webkit.org/show_bug.cgi?id=211539
Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-05-08
Reviewed by Simon Fraser.
Corrected the comment.
No new test needed.
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createRasterShape):
- 10:57 AM Changeset in webkit [261399] by
-
- 4 edits in trunk
Fix urlsearchparams-delete.html
https://bugs.webkit.org/show_bug.cgi?id=211456
Patch by Rob Buis <rbuis@igalia.com> on 2020-05-08
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
Update improved test expectation.
- web-platform-tests/url/urlsearchparams-delete-expected.txt:
Source/WebCore:
Step 2 of URLSearchParams.delete algorithm [1] indicates
we should run the update steps, even if no name-value
pairs were removed.
Behavior matches Chrome and Firefox.
[1] https://url.spec.whatwg.org/#dom-urlsearchparams-delete
Test: web-platform-tests/url/urlsearchparams-delete.html
- html/URLSearchParams.cpp:
(WebCore::URLSearchParams::remove):
- 10:57 AM Changeset in webkit [261398] by
-
- 12 edits2 adds in trunk
[iOS] caret appears in the middle of a search field when field is focused on agoda.com
https://bugs.webkit.org/show_bug.cgi?id=211591
<rdar://problem/60605873>
Reviewed by Antoine Quint.
Source/WebCore:
See WebKit/ChangeLog for more details.
Test: editing/selection/ios/caret-rect-after-animating-focused-text-field.html
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::finishNotificationSteps):
Add plumbing to call out to the WebKit client layer after an animation finishes running.
- dom/Node.h:
- editing/VisibleSelection.h:
WEBCORE_EXPORT a couple of methods.
- page/ChromeClient.h:
(WebCore::ChromeClient::animationDidFinishForElement):
Source/WebKit:
The main search field on the mobile version of this website begins offscreen, with a CSS transform that moves it
to the far right; tapping the button element that (visually) has a search-field-like appearance on the front
page programmatically focuses the real offscreen search field, and animates it onscreen by changing the CSS
transform attribute to remove the x-axis translation.
On iOS, the caret rect is computed and sent to the UI process via editor state updates; however, the editor
state is computed immediately after focusing the input field. As such, the caret rect at this moment is computed
in the middle of the animation, leaving it stuck in an unpredictable location.
To fix this, add plumbing to call into the WebKit client layer when an animation has ended. On iOS, if the
selection is visible (i.e. a ranged selection, or editable caret), then check to see whether the element that
has finished animating contains either endpoint of the selection. If so, then schedule a followup editor state
update to push updated selection information to the UI process.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::animationDidFinishForElement):
- WebProcess/WebCoreSupport/WebChromeClient.h:
Add a new client hook for when animations end.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::animationDidFinishForElement):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
Add logic to schedule a new editor state update if needed, after an animation ends that might affect either
the start or end of the selection.
(WebKit::WebPage::animationDidFinishForElement):
LayoutTests:
Add a new layout test to verify that the caret view eventually becomes visible when after a focused text field
containing the caret is animated.
- editing/selection/ios/caret-rect-after-animating-focused-text-field-expected.txt: Added.
- editing/selection/ios/caret-rect-after-animating-focused-text-field.html: Added.
- 10:56 AM Changeset in webkit [261397] by
-
- 2 edits in trunk/Tools
Allow run-safari to launch an iPad simulator
https://bugs.webkit.org/show_bug.cgi?id=211606
<rdar://problem/63002849>
Reviewed by Jon Lee.
Add an "--ipad-simulator" command line option to run-safari.
- Scripts/webkitdirs.pm:
(argumentsForConfiguration):
(determineXcodeSDK): Mark the device idiom depending on the command line argument.
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
(findOrCreateSimulatorForIOSDevice): Create an iPad Pro simulator if requested.
- 10:53 AM Changeset in webkit [261396] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r260228): Linker warning about limitsNavigationsToAppBoundDomains property overriding instance methods from class
<https://webkit.org/b/211393>
Reviewed by Brent Fulgham.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration limitsNavigationsToAppBoundDomains]):
(-[WKWebViewConfiguration setLimitsNavigationsToAppBoundDomains:]):
- Move from WKPrivate category to main category to fix linker warnings.
- 10:35 AM Changeset in webkit [261395] by
-
- 11 edits2 adds in trunk
Preserve character set information when writing to the pasteboard when copying rich text
https://bugs.webkit.org/show_bug.cgi?id=211524
Reviewed by Darin Adler.
Source/WebCore:
This patch is a followup to r261247, which introduced a workaround for Cocoa platforms to automatically add a
meta charsetwhen writing HTML data to the platform pasteboard. When copying a rich text selection, we use a
different codepath when sanitizing DOM content - that is,serializePreservingVisualAppearance.
The previous change also introduced an enum,
AddMetaCharsetIfNeeded, to limit applying this workaround to only
when we're writing HTML to the clipboard. However, it should be harmless to include this when reading sanitized
HTML as well, so we can also simplify this code by removing theAddMetaCharsetIfNeededenum (and all of its
uses).
Test: CopyHTML.SanitizationPreservesCharacterSetInSelectedText
- Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
(WebCore::ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::sanitizeDataIfNeeded):
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::setDataFromItemList):
- editing/MarkupAccumulator.h:
(WebCore::MarkupAccumulator::isAllASCII const):
- editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::sanitizeMarkupWithArchive):
(WebCore::WebContentReader::readHTML):
(WebCore::WebContentMarkupReader::readHTML):
- editing/markup.cpp:
(WebCore::sanitizeMarkup):
(WebCore::serializePreservingVisualAppearanceInternal):
Move the
meta charsetworkaround from sanitizedMarkupForFragmentInDocument to
serializePreservingVisualAppearanceInternal, such that HTML data written to the pasteboard when copying rich
text can be used to load a web view, without losing the fact that the copied content was UTF-8 encoded.
(WebCore::sanitizedMarkupForFragmentInDocument):
- editing/markup.h:
Tools:
Add a new API test to verify that the HTML data written to the pasteboard when copying a rich text selection
can be converted into anNSAttributedStringthat contains correctly encoded non-Latin characters.
- TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
LayoutTests:
Rebaseline several layout tests.
- platform/ios/editing/pasteboard/onpaste-text-html-expected.txt:
- platform/mac/editing/pasteboard/onpaste-text-html-expected.txt: Added.
- platform/mac/fast/events/ondrop-text-html-expected.txt: Added.
- 10:33 AM Changeset in webkit [261394] by
-
- 5 edits in trunk
REGRESSION(r259209) Webview's pending URL is null after restoring session state
https://bugs.webkit.org/show_bug.cgi?id=211626
<rdar://problem/62992262>
Reviewed by Alex Christensen.
Source/WebKit:
The issue was that WebPageProxy::goToBackForwardItem() would behave differently whether
the page has a running process or not. In particular, when the page did not have a
running process, goToBackForwardItem() would return early and call launchProcessWithItem()
instead. Unlike goToBackForwardItem(), launchProcessWithItem() would fail to set the
pending API request.
To address the issue, I am getting rid of launchProcessWithItem() and merging its logic
into goToBackForwardItem() instead. Both methods shared a lot of code anyway and having
2 separate code paths that may diverge is error prone.
Change is covered by new API test.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::launchProcessWithItem): Deleted.
- UIProcess/WebPageProxy.h:
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
(TestWebKitAPI::TEST):
- 10:31 AM Changeset in webkit [261393] by
-
- 40 edits in trunk/Source/WTF
[clang-tidy] Run modernize-use-nullptr over WTF
https://bugs.webkit.org/show_bug.cgi?id=211628
Reviewed by Yusuke Suzuki.
Use the fix option in clang-tidy to ensure nullptr is being used across WTF.
- wtf/Assertions.cpp:
- wtf/BumpPointerAllocator.h:
(WTF::BumpPointerPool::BumpPointerPool):
(WTF::BumpPointerPool::create):
(WTF::BumpPointerAllocator::BumpPointerAllocator):
- wtf/DataLog.cpp:
(WTF::setDataFile):
- wtf/DateMath.cpp:
(WTF::parseES5DatePortion):
(WTF::parseES5TimePortion):
- wtf/FastMalloc.cpp:
(WTF::fastZeroedMalloc):
(WTF::fastStrDup):
(WTF::tryFastZeroedMalloc):
(WTF::isFastMallocEnabled):
(WTF::fastMallocGoodSize):
(WTF::fastAlignedMalloc):
(WTF::tryFastAlignedMalloc):
(WTF::fastAlignedFree):
(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::fastRealloc):
(WTF::tryFastRealloc):
(WTF::releaseFastMallocFreeMemory):
(WTF::releaseFastMallocFreeMemoryForThisThread):
(WTF::fastMallocStatistics):
(WTF::fastMallocSize):
(WTF::fastCommitAlignedMemory):
(WTF::fastDecommitAlignedMemory):
(WTF::fastEnableMiniMode):
(WTF::fastDisableScavenger):
(WTF::fastMallocDumpMallocStats):
(WTF::AvoidRecordingScope::avoidRecordingCount):
(WTF::AvoidRecordingScope::AvoidRecordingScope):
(WTF::AvoidRecordingScope::~AvoidRecordingScope):
(WTF::MallocCallTracker::MallocSiteData::MallocSiteData):
(WTF::MallocCallTracker::singleton):
(WTF::MallocCallTracker::MallocCallTracker):
(WTF::MallocCallTracker::recordMalloc):
(WTF::MallocCallTracker::recordRealloc):
(WTF::MallocCallTracker::recordFree):
(WTF::MallocCallTracker::dumpStats):
- wtf/HashTable.h:
(WTF::KeyTraits>::inlineLookup):
(WTF::KeyTraits>::lookupForWriting):
(WTF::KeyTraits>::fullLookupForWriting):
(WTF::KeyTraits>::add):
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::findAndRemoveFreeSpace):
- wtf/ParallelJobsGeneric.cpp:
- wtf/RandomDevice.cpp:
(WTF::RandomDevice::cryptographicallyRandomValues):
- wtf/RawPointer.h:
(WTF::RawPointer::RawPointer):
- wtf/RedBlackTree.h:
- wtf/SHA1.cpp:
(WTF::SHA1::hexDigest):
- wtf/SchedulePair.h:
(WTF::SchedulePair::SchedulePair):
- wtf/StackTrace.cpp:
(WTFGetBacktrace):
(WTF::StackTrace::dump const):
- wtf/StringExtras.h:
(strnstr):
- wtf/Variant.h:
- wtf/Vector.h:
(WTF::VectorBufferBase::deallocateBuffer):
(WTF::VectorBufferBase::releaseBuffer):
(WTF::VectorBufferBase::VectorBufferBase):
- wtf/cf/CFURLExtras.cpp:
(WTF::createCFURLFromBuffer):
(WTF::getURLBytes):
- wtf/cf/CFURLExtras.h:
- wtf/cf/FileSystemCF.cpp:
(WTF::FileSystem::pathAsURL):
- wtf/dtoa/double-conversion.cc:
- wtf/dtoa/utils.h:
(WTF::double_conversion::BufferReference::BufferReference):
- wtf/text/CString.cpp:
(WTF::CString::mutableData):
- wtf/text/CString.h:
- wtf/text/StringBuffer.h:
(WTF::StringBuffer::release):
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::createUninitializedInternal):
(WTF::StringImpl::reallocateInternal):
- wtf/text/StringImpl.h:
(WTF::StringImpl::constructInternal<LChar>):
(WTF::StringImpl::constructInternal<UChar>):
(WTF::StringImpl::characters<LChar> const):
(WTF::StringImpl::characters<UChar> const):
(WTF::find):
(WTF::reverseFindLineTerminator):
(WTF::reverseFind):
(WTF::equalIgnoringNullity):
(WTF::codePointCompare):
(WTF::isSpaceOrNewline):
(WTF::lengthOfNullTerminatedString):
(WTF::StringImplShape::StringImplShape):
(WTF::StringImpl::isolatedCopy const):
(WTF::StringImpl::isAllASCII const):
(WTF::StringImpl::isAllLatin1 const):
(WTF::isAllSpecialCharacters):
(WTF::isSpecialCharacter const):
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::create8BitIfPossible):
(WTF::StringImpl::createSubstringSharingImpl):
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::adopt):
(WTF::StringImpl::cost const):
(WTF::StringImpl::costDuringGC):
(WTF::StringImpl::setIsAtom):
(WTF::StringImpl::setHash const):
(WTF::StringImpl::ref):
(WTF::StringImpl::deref):
(WTF::StringImpl::copyCharacters):
(WTF::StringImpl::at const):
(WTF::StringImpl::allocationSize):
(WTF::StringImpl::maxInternalLength):
(WTF::StringImpl::tailOffset):
(WTF::StringImpl::requiresCopy const):
(WTF::StringImpl::tailPointer const):
(WTF::StringImpl::tailPointer):
(WTF::StringImpl::substringBuffer const):
(WTF::StringImpl::substringBuffer):
(WTF::StringImpl::assertHashIsCorrect const):
(WTF::StringImpl::StaticStringImpl::StaticStringImpl):
(WTF::StringImpl::StaticStringImpl::operator StringImpl&):
(WTF::equalIgnoringASCIICase):
(WTF::startsWithLettersIgnoringASCIICase):
(WTF::equalLettersIgnoringASCIICase):
- wtf/text/TextBreakIterator.cpp:
(WTF::initializeIterator):
(WTF::setContextAwareTextForIterator):
(WTF::openLineBreakIterator):
- wtf/text/TextBreakIterator.h:
(WTF::LazyLineBreakIterator::get):
- wtf/text/WTFString.cpp:
(WTF::charactersToFloat):
- wtf/text/cf/StringImplCF.cpp:
(WTF::StringWrapperCFAllocator::allocate):
(WTF::StringWrapperCFAllocator::create):
(WTF::StringImpl::createCFString):
- wtf/text/icu/UTextProviderLatin1.cpp:
(WTF::uTextLatin1Clone):
(WTF::openLatin1ContextAwareUTextProvider):
- wtf/text/icu/UTextProviderUTF16.cpp:
(WTF::openUTF16ContextAwareUTextProvider):
- wtf/win/FileSystemWin.cpp:
(WTF::FileSystemImpl::makeAllDirectories):
(WTF::FileSystemImpl::storageDirectory):
(WTF::FileSystemImpl::openTemporaryFile):
(WTF::FileSystemImpl::openFile):
(WTF::FileSystemImpl::writeToFile):
(WTF::FileSystemImpl::readFromFile):
(WTF::FileSystemImpl::deleteNonEmptyDirectory):
- wtf/win/LanguageWin.cpp:
(WTF::localeInfo):
- wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform):
- wtf/win/OSAllocatorWin.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::reserveAndCommit):
- wtf/win/RunLoopWin.cpp:
(WTF::RunLoop::run):
(WTF::RunLoop::iterate):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::cycle):
(WTF::RunLoop::TimerBase::start):
- wtf/win/ThreadingWin.cpp:
(WTF::Thread::establishHandle):
- 10:30 AM Changeset in webkit [261392] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r261341): imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm is failing
https://bugs.webkit.org/show_bug.cgi?id=211612
<rdar://problem/63024081>
Unreviewed test gardening.
- TestExpectations: Mark test as Flakey. A proper fix is tracked by https://bugs.webkit.org/show_bug.cgi?id=211630.
- 10:14 AM Changeset in webkit [261391] by
-
- 9 edits1 add in trunk/LayoutTests
Code pattern in GC tests in LayoutTests is broken
https://bugs.webkit.org/show_bug.cgi?id=211595
Reviewed by Saam Barati.
LayoutTests have several tests which attempt to ensure that document is not leaked. But they are broken since these tests are not correctly
handling conservative GC of JavaScriptCore. These tests are taking a following approach.
- Allocate *one* iframe doing something inside it.
- Remove iframe from the parent document to make it released.
- Repeatedly invoke GC and test whether (1)'s document gets collected.
This is not the right approach. Since JavaScriptCore has conservative GC, it is easily possible that (1)'s pointer value remains in some of
conservative roots: CPU registers, stack etc. And JavaScriptCore conservative GC scans it and keeps it alive. The above approach makes the
test super flaky and any unrelated changes in JavaScriptCore and C compiler can make this test failed.
This is not a problem in practice. Web pages are executing various kind of code and they clobber conservative roots. However, tests in
LayoutTests are too simple to keep it alive accidentally.
The right approach for conservative GC is the following.
- Allocate *many* iframes doing something inside them with loop. By creating iframes with loop, for every iteration, it is likely that the same CPU registers and stack locations are overwritten by the last created iframe reference. This dramatically reduces the possibility for GC to find these addresses in conservative roots.
- Remove iframes from the parent document to make them released.
- Repeatedly invoke GC and test whether *one of (1) iframes* gets collected at least. Theoretically this is still possible that completely unrelated integer value in conservative roots can point to the reference of (1). By allocating many iframes in (1) and testing one of them, we can reduce the possibility of this conflict.
This patch adds testDocumentIsNotLeaked helper function to enforce this pattern. And rewrite broken tests with this helper to make it less-flaky.
- highlight/highlight-world-leak.html:
- http/tests/IndexedDB/collect-IDB-objects.https.html:
- http/tests/media/clearkey/collect-webkit-media-session.html:
- http/tests/media/media-stream/collect-media-devices.https.html:
- http/tests/resources/gc.js: Added.
(window.gc.gcRec):
(window.gc.window.gc):
(nukeArray):
(async testDocumentIsNotLeaked):
- intersection-observer/no-document-leak.html:
- performance-api/performance-observer-no-document-leak.html:
- resources/gc.js:
(nukeArray):
(async testDocumentIsNotLeaked):
- webanimations/leak-document-with-web-animation.html:
- 10:13 AM Changeset in webkit [261390] by
-
- 6 edits in trunk
WKWebView.title should be safe browsing warning's title during a safe browsing warning
https://bugs.webkit.org/show_bug.cgi?id=211403
Patch by Alex Christensen <achristensen@webkit.org> on 2020-05-08
Reviewed by Tim Horton.
Source/WebKit:
Add a new property to PageLoadState, which allows the title to be set underneath it.
That way, once the safe browsing warning is closed, we can update the title to what it would've been,
including any changes that happened while the warning was open.
Covered by an API test. I also manually verified this fixes rdar://problem/56201982
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::commitChanges):
(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::didCommitLoad):
(WebKit::PageLoadState::title const):
(WebKit::PageLoadState::setTitleFromSafeBrowsingWarning):
- UIProcess/PageLoadState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(TEST):
- 9:55 AM Changeset in webkit [261389] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Update message filtering rules in the WebContent process' sandbox
https://bugs.webkit.org/show_bug.cgi?id=211188
Reviewed by Brent Fulgham.
Based on telemetry and local testing, update the message filtering rules in the WebContent process' sandbox on iOS.
Messages that have not been observed being in use should be denied.
No new tests, covered by existing tests.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 9:48 AM Changeset in webkit [261388] by
-
- 2 edits in trunk/Source/WebKit
Turn processDidBecomeUnresponsive logging into error logging
https://bugs.webkit.org/show_bug.cgi?id=211629
Reviewed by Youenn Fablet.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidBecomeUnresponsive):
- 9:33 AM Changeset in webkit [261387] by
-
- 4 edits in trunk/Source
[Cocoa] Close connections to Launch Services after revoking extension
https://bugs.webkit.org/show_bug.cgi?id=211594
Reviewed by Brent Fulgham.
Source/WebCore/PAL:
Declare _LSDService class.
- pal/spi/cocoa/LaunchServicesSPI.h:
Source/WebKit:
In <https://trac.webkit.org/changeset/258915/webkit>, connections to the Launch Services database mapping
services were denied, by creating a temporary extension. After revoking this extension in the WebContent
process, it is important to close any open connections to Launch Services initiated by the mapping.
No new tests, covered by existing UTI/MIME type tests.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 9:23 AM Changeset in webkit [261386] by
-
- 2 edits in trunk/Source/WTF
Make callBufferProducingFunction safer to use by adding a compile-time assertion
https://bugs.webkit.org/show_bug.cgi?id=211599
Reviewed by Ross Kirsling.
- wtf/unicode/icu/ICUHelpers.h:
(WTF::CallBufferProducingFunction::argumentTuple): Add a static_assert that
checks these are just simple types, aside from the Vector for the buffer.
This would have caught the UpconvertedCharacters problem fixed earlier today.
- 9:17 AM Changeset in webkit [261385] by
-
- 3 edits in trunk/Source/WebCore
Fix for crashes in LayoutTests in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=211622
Reviewed by Chris Fleizach.
Several LayoutTests.
Return the root from the isolated tree when it is really ready.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rootObject):
Some code cleanup.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clickPoint):
- 9:16 AM WebKitEmacsTips edited by
- (diff)
- 9:03 AM WebKitEmacsTips created by
- 8:55 AM WebKitGTK edited by
- (diff)
- 8:39 AM Changeset in webkit [261384] by
-
- 20 edits in trunk/Source/WTF
WTF headers should compile independently
https://bugs.webkit.org/show_bug.cgi?id=211608
Reviewed by Yusuke Suzuki.
When a WTF header is included on its own within a source file it should compile.
These issues were found when working on a tooling build for running static
analysis over WTF. Forward declarations were used whenever possible otherwise
an include was used.
Additionally fix some errors found by Clang 10.
- wtf/AggregateLogger.h:
- wtf/CallbackAggregator.h:
- wtf/Dominators.h:
- wtf/HashIterators.h:
- wtf/IndexSparseSet.h:
- wtf/LoggingHashMap.h:
- wtf/LoggingHashTraits.h:
- wtf/RunLoopTimer.h:
- wtf/Stopwatch.h:
- wtf/Threading.h:
- wtf/cf/RunLoopTimerCF.cpp:
- wtf/persistence/PersistentCoder.h:
- wtf/text/LineBreakIteratorPoolICU.h:
- wtf/text/NullTextBreakIterator.h:
- wtf/text/StringOperators.h:
- wtf/text/StringToIntegerConversion.h:
- wtf/text/cf/TextBreakIteratorCF.h:
- wtf/text/icu/TextBreakIteratorICU.h:
- wtf/text/win/WCharStringExtras.h:
- 8:21 AM Changeset in webkit [261383] by
-
- 6 edits2 adds in trunk
[GTK][WPE] Create common glib expectation file
https://bugs.webkit.org/show_bug.cgi?id=211183
Reviewed by Carlos Garcia Campos.
Tools:
- Scripts/webkitpy/port/gtk.py:
(GtkPort._search_paths): Add glib to expectations search path
(GtkPort.test_expectations_file_position): Update test
- Scripts/webkitpy/port/gtk_unittest.py:
(GtkPortTest.test_default_baseline_search_path): Update test
(GtkPortTest.test_port_specific_expectations_files): Update test and
make check-webkit-style happier
- Scripts/webkitpy/port/wpe.py:
(WPEPort._search_paths): Add glib to expectations search path
(WPEPort.test_expectations_file_position): Update test
- Scripts/webkitpy/port/wpe_unittest.py:
(WPEPortTest.test_default_baseline_search_path): Update test
(WPEPortTest.test_port_specific_expectations_files): Update test and
make check-webkit-style happier
LayoutTests:
- platform/glib/TestExpectations: Added.
- 8:02 AM Changeset in webkit [261382] by
-
- 13 edits in trunk
Overflow scrollers in iframes don't get mouseMovedInContentArea()
https://bugs.webkit.org/show_bug.cgi?id=211347
<rdar://problem/62784560>
Reviewed by Tim Horton.
Source/WebCore:
We never dispatched mouseMovedInContentArea() on ScrollableAreas in subframes, so overlay scrollbar
interactions there were broken. This is because the code ran from EventHandler::mouseMoved(), which
only runs for the main frame.
Instead, move the mouseMovedInContentArea() dispatch down into updateMouseEventTargetNode() which
is run for each subframe. notifyScrollableAreasOfMouseEvents() takes an event name so we only dispatch
for mouseMove events. There's some complexity here related to whether the old and new ScrollableArea
targets are nested; this code doesn't try to do the right thing with nesting, but does handle the mouse
moving between the scrollable main frame and an overflow region.
enclosingScrollableArea() is fixed to return the FrameView. enclosingScrollableLayer() is flawed, as noted
in the RenderLayer.h comment.
Tests: fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered.html
fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal.html
- page/EventHandler.cpp:
(WebCore::EventHandler::enclosingScrollableArea):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::pointerCaptureElementDidChange):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::notifyScrollableAreasOfMouseEvents):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::enclosingScrollableArea): Deleted.
(WebCore::EventHandler::notifyScrollableAreasOfMouseEnterExit): Deleted.
- page/EventHandler.h:
- page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::dispatchSyntheticMouseOut):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::debugDescription const):
- rendering/RenderLayer.h:
LayoutTests:
The ordering of callbacks in the scroll-animator tests changed, but in ways that don't materially
affect behavior. Two new real overlay scrollbar tests.
- fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered-expected.txt: Added.
- fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered.html: Added.
- fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal-expected.txt: Added.
- fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal.html: Added.
- fast/scrolling/scroll-animator-basic-events-expected.txt:
- fast/scrolling/scroll-animator-overlay-scrollbars-clicked-expected.txt:
- fast/scrolling/scroll-animator-overlay-scrollbars-hovered-expected.txt:
- fast/scrolling/scroll-animator-select-list-events-expected.txt:
- 7:24 AM Changeset in webkit [261381] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: media/track/track-in-band-metadata-display-order.html
https://bugs.webkit.org/show_bug.cgi?id=206226
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 7:08 AM Changeset in webkit [261380] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] http/tests/IndexedDB/collect-IDB-objects.https.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207571
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 7:02 AM Changeset in webkit [261379] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 ] http/tests/cache-storage/cache-representation.https.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=207665
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 7:02 AM Changeset in webkit [261378] by
-
- 3 edits2 adds in trunk
[LFC][TFC] The fixed logical width should be used as the max width for a cell
https://bugs.webkit.org/show_bug.cgi?id=211610
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/layoutformattingcontext/table-simple-with-fixed-widht-and-inline-content.html
- layout/tableformatting/TableFormattingContextGeometry.cpp:
(WebCore::Layout::TableFormattingContext::Geometry::intrinsicWidthConstraintsForCell):
LayoutTests:
- fast/layoutformattingcontext/table-simple-with-fixed-widht-and-inline-content-expected.txt: Added.
- fast/layoutformattingcontext/table-simple-with-fixed-widht-and-inline-content.html: Added.
- 6:51 AM Changeset in webkit [261377] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: [ iOS wk2 ] fast/forms/input-text-scroll-left-on-blur.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209812
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 6:46 AM Changeset in webkit [261376] by
-
- 2 edits in trunk/LayoutTests
[ Mojave wk1 Release ] platform/mac/media/media-source/videoplaybackquality-decompressionsession.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209866
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 5:42 AM Changeset in webkit [261375] by
-
- 13 edits1 copy4 adds in trunk/Source
Handle remote audio capture IPC messages in a background thread
https://bugs.webkit.org/show_bug.cgi?id=211583
Reviewed by Eric Carlson.
Source/WebCore:
- platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:
(WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples):
Add assertion to check that we are not running on the main thread.
Source/WebKit:
We introduce RemoteCaptureSampleManager which is responsible to get remote capture sample IPC messages and treat them from a background thread.
It is currently used to handle audio capture IPC messages.
We move UserMediaCaptureManager::Source in its own file and rename it to RemoteRealtimeMediaSource.
Covered by existing tests.
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- PlatformMac.cmake:
- SourcesCocoa.txt:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp: Added.
(WebKit::RemoteCaptureSampleManager::RemoteCaptureSampleManager):
(WebKit::RemoteCaptureSampleManager::~RemoteCaptureSampleManager):
(WebKit::RemoteCaptureSampleManager::setConnection):
(WebKit::RemoteCaptureSampleManager::addSource):
(WebKit::RemoteCaptureSampleManager::removeSource):
(WebKit::RemoteCaptureSampleManager::dispatchToThread):
(WebKit::RemoteCaptureSampleManager::storageChanged):
(WebKit::RemoteCaptureSampleManager::audioSamplesAvailable):
- WebProcess/cocoa/RemoteCaptureSampleManager.h: Added.
- WebProcess/cocoa/RemoteCaptureSampleManager.messages.in: Added.
- WebProcess/cocoa/RemoteRealtimeMediaSource.cpp: Added.
(WebKit::RemoteRealtimeMediaSource::RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::~RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::whenReady):
(WebKit::RemoteRealtimeMediaSource::didFail):
(WebKit::RemoteRealtimeMediaSource::setAsReady):
(WebKit::RemoteRealtimeMediaSource::clone):
(WebKit::RemoteRealtimeMediaSource::setCapabilities):
(WebKit::RemoteRealtimeMediaSource::setSettings):
(WebKit::RemoteRealtimeMediaSource::remoteAudioSamplesAvailable):
(WebKit::RemoteRealtimeMediaSource::remoteVideoSampleAvailable):
(WebKit::RemoteRealtimeMediaSource::connection):
(WebKit::RemoteRealtimeMediaSource::startProducingData):
(WebKit::RemoteRealtimeMediaSource::stopProducingData):
(WebKit::RemoteRealtimeMediaSource::setShouldApplyRotation):
(WebKit::RemoteRealtimeMediaSource::capabilities):
(WebKit::RemoteRealtimeMediaSource::applyConstraints):
(WebKit::RemoteRealtimeMediaSource::applyConstraintsSucceeded):
(WebKit::RemoteRealtimeMediaSource::applyConstraintsFailed):
(WebKit::RemoteRealtimeMediaSource::hasEnded):
(WebKit::RemoteRealtimeMediaSource::stopBeingObserved):
(WebKit::RemoteRealtimeMediaSource::requestToEnd):
- WebProcess/cocoa/RemoteRealtimeMediaSource.h: Added.
(WebKit::RemoteRealtimeMediaSource::identifier const):
(WebKit::RemoteRealtimeMediaSource::settings const):
(WebKit::RemoteRealtimeMediaSource::setShouldCaptureInGPUProcess):
(WebKit::RemoteRealtimeMediaSource::shouldCaptureInGPUProcess const):
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::createCaptureSource):
(WebKit::UserMediaCaptureManager::cloneSource):
(WebKit::UserMediaCaptureManager::cloneVideoSource):
(WebKit::UserMediaCaptureManager::AudioFactory::createAudioCaptureSource):
(WebKit::UserMediaCaptureManager::AudioFactory::setShouldCaptureInGPUProcess):
(WebKit::UserMediaCaptureManager::VideoFactory::createVideoCaptureSource):
(WebKit::UserMediaCaptureManager::DisplayFactory::createDisplayCaptureSource):
- WebProcess/cocoa/UserMediaCaptureManager.h:
- WebProcess/cocoa/UserMediaCaptureManager.messages.in:
- 4:55 AM WebKitGTK/2.28.x edited by
- (diff)
- 4:36 AM Changeset in webkit [261374] by
-
- 2 edits in trunk/Tools
Add myself as committer to contributors.json
Patch by Paulo Matos <Paulo Matos> on 2020-05-08
- Scripts/webkitpy/common/config/contributors.json:
- 3:54 AM Changeset in webkit [261373] by
-
- 20 edits in trunk
Video capture does not get unmuted in case of tab switch on iOS
https://bugs.webkit.org/show_bug.cgi?id=211509
Reviewed by Eric Carlson.
Source/WebCore:
Remove setInterrupted and related code.
Instead, directly use setMuted(true/false) of the source of capture tracks.
To ensure we validate that the active source is tied to a track of the document,
we add RealtimeSource::isSameAs which handles the case of a RealtimeVideoSource wrapping an AVVideoCaptureSource.
There might be multiple video tracks with each one its RealtimeVideoSource using the same AVVideoCaptureSource.
We mute the AVVideoCaptureSource directly to make sure all linked tracks will get muted/unmuted at the same time.
Tests to be fixed.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::isSourceCapturingForDocument):
(WebCore::MediaStreamTrack::updateCaptureAccordingToMutedState):
- Modules/mediastream/MediaStreamTrack.h:
- dom/Document.cpp:
(WebCore::Document::visibilityStateChanged):
- platform/mediastream/RealtimeMediaSource.cpp:
- platform/mediastream/RealtimeMediaSource.h:
- platform/mediastream/RealtimeMediaSourceCenter.cpp:
- platform/mediastream/RealtimeMediaSourceCenter.h:
- platform/mediastream/RealtimeMediaSourceFactory.h:
- platform/mediastream/RealtimeVideoSource.h:
- platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
- platform/mediastream/mac/CoreAudioCaptureSource.h:
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
Source/WebKit:
Remove no longer needed code.
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::VideoFactory::setActiveSource):
- WebProcess/cocoa/UserMediaCaptureManager.h:
LayoutTests:
- platform/ios/TestExpectations:
Disable GPU process test since we are not able yet to mute/unmute handle multiple video tracks
with different sources as can be done if capture is done out of process.
- platform/ios/mediastream/video-muted-in-background-tab.html:
Update test to ensure the track is producing content.
- 3:23 AM Changeset in webkit [261372] by
-
- 2 edits in trunk/JSTests
Unreviewed, reverting r261010.
Test skipped for all ARM. no evidence of this affecting iOS
Reverted changeset:
"Skip on ARM and MIPS stress/array-buffer-view-watchpoint-can-
be-fired-in-really-add-in-dfg.js added after r260990"
https://bugs.webkit.org/show_bug.cgi?id=211304
https://trac.webkit.org/changeset/261010
- 1:52 AM WebKitGTK/2.28.x edited by
- (diff)
- 1:49 AM WebKitGTK/2.28.x edited by
- (diff)
- 1:47 AM Changeset in webkit [261371] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed. Fix GTK4 build after r261370
- UIProcess/API/gtk/WebKitScriptDialogGtk.cpp:
(webkitScriptDialogIsUserHandled):
- 1:21 AM Changeset in webkit [261370] by
-
- 6 edits in trunk/Source/WebKit
[WPE][WebDriver] Implement user prompt support
https://bugs.webkit.org/show_bug.cgi?id=207372
Reviewed by Carlos Garcia Campos.
Provide a default implementation for WebDriver dialog commands.
This implementation will mimic the expected browser behavior of
accepting/dismissing the dialogs, while not exposing any new API.
- UIProcess/API/glib/WebKitScriptDialogPrivate.h:
- Expose new private function to check whether the dialog is using a
default implementation or is handled by the user.
- UIProcess/API/glib/WebKitWebView.cpp:
- Avoid default WebDriver behavior if the dialog is user-handled.
(webkitWebViewSetCurrentScriptDialogUserInput):
(webkitWebViewAcceptCurrentScriptDialog):
(webkitWebViewDismissCurrentScriptDialog):
- UIProcess/API/gtk/WebKitScriptDialogGtk.cpp:
(webkitScriptDialogIsUserHandled):
- Return whether the dialog is user handled.
- UIProcess/API/wpe/WebKitScriptDialogWPE.cpp:
- Added basic behavior for the WebDriver dialog callbacks for WPE.
(webkitScriptDialogAccept):
(webkitScriptDialogDismiss):
(webkitScriptDialogSetUserInput):
(webkitScriptDialogIsUserHandled):
- UIProcess/API/wpe/WebKitWebViewWPE.cpp:
(webkitWebViewScriptDialog):
- Hold a dialog ref if the webview is controlled by automation and ends
up calling the default "script-dialog" event handler.
- 1:06 AM Changeset in webkit [261369] by
-
- 3 edits1 add in trunk/LayoutTests
[GTK][WPE] Gardening, update expectations and baselines after r261341
https://bugs.webkit.org/show_bug.cgi?id=211616
Unreviewed gardening.
- platform/gtk/TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/intrinsic_sizes-expected.txt: Added.
- platform/wpe/TestExpectations:
May 7, 2020:
- 10:48 PM Changeset in webkit [261368] by
-
- 5 edits4 adds in trunk
MayBegin wheel event in a <select> doesn't flash the scrollers
https://bugs.webkit.org/show_bug.cgi?id=211605
Reviewed by Antti Koivisto.
Source/WebCore:
We need to special-case scrollable <select> elements, because they are ScrollableAreas
which are never asynchronously scrolled, so the ScrollingTree never dispatches the handleWheelEventPhase()
which is necessary to flash overlay scrollbars. Scrollable <select> elements are always in the
non-fast scrollable region.
Fix findEnclosingScrollableContainer() to return a ScrollableArea for the "maybegin" and "canceled" events
that have no delta.
Remove some "inline" and make some things references.
Tests: fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered.html
fast/scrolling/mac/scrollbars/select-overlay-scrollbar-reveal.html
- page/EventHandler.cpp:
(WebCore::handleWheelEventPhaseInScrollableArea):
(WebCore::didScrollInScrollableArea):
(WebCore::handleWheelEventInAppropriateEnclosingBox):
(WebCore::shouldGesturesTriggerActive):
(WebCore::EventHandler::eventLoopHandleMouseUp):
(WebCore::EventHandler::eventLoopHandleMouseDragged):
- page/mac/EventHandlerMac.mm:
(WebCore::findEnclosingScrollableContainer):
(WebCore::EventHandler::determineWheelEventTarget):
- testing/Internals.cpp:
(WebCore::Internals::scrollableAreaForNode): Fix to find the ScrollableArea for RenderListBoxes.
LayoutTests:
- fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered-expected.txt: Added.
- fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered.html: Added.
- fast/scrolling/mac/scrollbars/select-overlay-scrollbar-reveal-expected.txt: Added.
- fast/scrolling/mac/scrollbars/select-overlay-scrollbar-reveal.html: Added.
- 9:23 PM Changeset in webkit [261367] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening two poster tests and a webgl failure
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 7:33 PM Changeset in webkit [261366] by
-
- 7 edits1 add in trunk
[WebAuthn] Roll back newly created credentials if an error occurs
https://bugs.webkit.org/show_bug.cgi?id=183530
<rdar://problem/43357305>
Reviewed by Brent Fulgham.
Source/WebKit:
We should clean up any newly created credentials if an error occurs before the relying party
registers the identity. Otherwise we are left with a dangling credential.
Covered by API tests.
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.h:
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
(WebKit::LocalAuthenticator::receiveException const):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-no-attestation.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html:
- 7:22 PM Changeset in webkit [261365] by
-
- 2 edits in trunk/Tools
run-javascriptcore-tests with remote should be verbose
https://bugs.webkit.org/show_bug.cgi?id=211596
Reviewed by Alexey Proskuryakov.
Our iOS testing bots could use this better output.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests):
- 7:14 PM Changeset in webkit [261364] by
-
- 11 edits in trunk/Source
Unreviewed, reverting r261252.
Reland r260684 now that a proper fix has landed in Reader
Reverted changeset:
"REGRESSION (r260684): Reader background is lost after
multitasking"
https://bugs.webkit.org/show_bug.cgi?id=211533
https://trac.webkit.org/changeset/261252
- 6:54 PM Changeset in webkit [261363] by
-
- 6 edits2 adds in trunk
SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN
https://bugs.webkit.org/show_bug.cgi?id=211539
Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-05-07
Reviewed by Geoffrey Garen.
Source/WebCore:
Removed the RELEASE_ASSERT because its possible for imageData to be null when imageRect size is huge value.
Test: fast/shapes/shape-outside-floats/shape-outside-imagedata-overflow.html
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createRasterShape):
LayoutTests:
Added a regression test and enabled it only for WK1.
- TestExpectations:
- fast/shapes/shape-outside-floats/shape-outside-imagedata-overflow-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-imagedata-overflow.html: Added.
- platform/ios-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 6:04 PM Changeset in webkit [261362] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Timelines: visible outline after clicking the close X button
https://bugs.webkit.org/show_bug.cgi?id=211604
<rdar://problem/62998871>
Reviewed by Timothy Hatcher.
Never display focus outline for TreeOutline items.
- UserInterface/Views/TreeOutline.css:
(.tree-outline .item):
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.selected):
- 5:39 PM Changeset in webkit [261361] by
-
- 2 edits in trunk/Source/WebKit
Build Fix for MacCatalyst
https://bugs.webkit.org/show_bug.cgi?id=211601
Reviewed by Tim Horton.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _removeContextMenuViewIfPossible]):
- 4:54 PM Changeset in webkit [261360] by
-
- 2 edits in trunk/Source/WebKit
Crash under WebKit::XPCServiceMain
https://bugs.webkit.org/show_bug.cgi?id=211600
<rdar://problem/62875458>
Reviewed by Darin Adler.
Made the following changes:
- Crash under strcmp() could in theory happen if expectedBundleVersion.UTF8String was null, which could happen if expectedBundleVersion was null. I now use higher level String types for the versions, make sure they are not null and use String comparison to compare them.
- Call CRASH() instead of builtin_trap(), to guarantee that we crash with a SIGTRAP (see comment next to CRASH() macro).
- Move CRASH() call to a crashDueWebKitFrameworkVersionMismatch() never inlined function to make it clear when it crashes due to a framework version mismatch and distinguish from proper crashes.
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::crashDueWebKitFrameworkVersionMismatch):
(WebKit::XPCServiceMain):
- 4:52 PM Changeset in webkit [261359] by
-
- 12 edits8 deletes in branches/safari-610.1.12-branch
Revert r261056. rdar://problem/62937746
- 4:52 PM Changeset in webkit [261358] by
-
- 539 edits19 adds160 deletes in branches/safari-610.1.12-branch/Source/ThirdParty/ANGLE
Cherry-pick r261262. rdar://problem/62998321
Update ANGLE to 2020-03-27
https://bugs.webkit.org/show_bug.cgi?id=209689
Reverting r259589. It caused
https://bugs.webkit.org/show_bug.cgi?id=210992
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261357] by
-
- 2 edits in branches/safari-610.1.12-branch/Source/WebKit
Revert r260390. rdar://problem/62998314
- 4:50 PM Changeset in webkit [261356] by
-
- 2 edits in branches/safari-610.1.12-branch/Source/WebInspectorUI
Cherry-pick r261183. rdar://problem/62995520
Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'this.InspectorAgent.initialized')
https://bugs.webkit.org/show_bug.cgi?id=211434
Reviewed by Joseph Pecoraro.
- UserInterface/Protocol/Target.js:
(WI.Target.prototype.initialize):
Workertargets don't (and are not expected to) have anInspectordomain.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261355] by
-
- 22 edits2 deletes in branches/safari-610.1.12-branch/Source/WebInspectorUI
Cherry-pick r261108. rdar://problem/62995520
Web Inspector: drop support for iOS 8.*
https://bugs.webkit.org/show_bug.cgi?id=211312
Reviewed by Daniel Bates.
- UserInterface/Controllers/DOMManager.js: (WI.DOMManager.prototype.highlightSelector):
- UserInterface/Controllers/NetworkManager.js: (WI.NetworkManager.prototype.resourceRequestWillBeSent):
- UserInterface/Controllers/RuntimeManager.js: (WI.RuntimeManager.prototype.initializeTarget): (WI.RuntimeManager.prototype.evaluateInInspectedWindow):
- UserInterface/Controllers/TimelineManager.js: (WI.TimelineManager.defaultTimelineTypes): (WI.TimelineManager.prototype._loadNewRecording):
- UserInterface/Models/DOMNodeStyles.js: (WI.DOMNodeStyles.parseSelectorListPayload):
- UserInterface/Models/FPSInstrument.js: (WI.FPSInstrument): Deleted. (WI.FPSInstrument.supported): Deleted.
- UserInterface/Models/ObjectPreview.js: (WI.ObjectPreview.fromPayload):
- UserInterface/Models/ProfileNode.js: (WI.ProfileNode): (WI.ProfileNode.prototype.get startTime): (WI.ProfileNode.prototype.get endTime): (WI.ProfileNode.prototype.computeCallInfoForTimeRange): (WI.ProfileNode.prototype.get calls): Deleted. (WI.ProfileNode.prototype.computeCallInfoForTimeRange.totalTimeInRange): Deleted.
- UserInterface/Models/Resource.js: (WI.Resource.prototype.get initiatedResources): (WI.Resource.prototype.get originalRequestWillBeSentTimestamp): Deleted.
- UserInterface/Models/ResourceTimingData.js: (WI.ResourceTimingData.fromPayload):
- UserInterface/Models/ScriptTimelineRecord.js: (WI.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeFromPayload):
- UserInterface/Models/TimelineRecording.js: (WI.TimelineRecording): (WI.TimelineRecording.prototype.computeElapsedTime): (WI.TimelineRecording.prototype.setLegacyBaseTimestamp): Deleted.
- UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js: Removed.
- UserInterface/Protocol/RemoteObject.js: (WI.RemoteObject.fromPayload): (WI.RemoteObject.prototype.getDisplayablePropertyDescriptors):
- UserInterface/Protocol/Target.js: (WI.Target.prototype.initialize):
- UserInterface/Views/ObjectTreePropertyTreeElement.js: (WI.ObjectTreePropertyTreeElement.prototype._updateProperties): (WI.ObjectTreePropertyTreeElement):
- UserInterface/Views/ObjectTreeView.js: (WI.ObjectTreeView.prototype._updateProperties):
- UserInterface/Views/ScriptTimelineDataGridNode.js: (WI.ScriptTimelineDataGridNode.prototype.get data):
- UserInterface/Views/SourceCodeTextEditor.js: (WI.SourceCodeTextEditor.prototype._createTypeTokenAnnotator): (WI.SourceCodeTextEditor.prototype._createBasicBlockAnnotator):
- UserInterface/Views/SourcesNavigationSidebarPanel.js: (WI.SourcesNavigationSidebarPanel.prototype._updatePauseReasonSection):
- UserInterface/Views/TimelineOverview.js: (WI.TimelineOverview):
- UserInterface/Views/TimelineTabContentView.js: (WI.TimelineTabContentView): (WI.TimelineTabContentView.prototype.closed): (WI.TimelineTabContentView.prototype.restoreFromCookie):
- Versions/Inspector-iOS-8.0.json: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261354] by
-
- 13 edits1 add in branches/safari-610.1.12-branch
Cherry-pick r261296. rdar://problem/62995467
Unreviewed, reverting r260769.
https://bugs.webkit.org/show_bug.cgi?id=211578
Introduced regressions related to sharing (Requested by
perarne on #webkit).
Reverted changeset:
"[Cocoa] After r258891, r255119 can be reverted"
https://bugs.webkit.org/show_bug.cgi?id=211083
https://trac.webkit.org/changeset/260769
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261353] by
-
- 2 edits in branches/safari-610.1.12-branch/Source/WebKit
Cherry-pick r261263. rdar://problem/62995496
Unreviewed, reverting r260689.
https://bugs.webkit.org/show_bug.cgi?id=211542
"Caused regressions deleting text and filling password fields"
(Requested by ddkilzer on #webkit).
Reverted changeset:
"WebPasteboardProxy::getPasteboardStringsForType() and
WebPasteboardProxy::readURLFromPasteboard() should check
return value of SharedMemory::createHandle()"
https://bugs.webkit.org/show_bug.cgi?id=211002
https://trac.webkit.org/changeset/260689
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261352] by
-
- 11 edits in branches/safari-610.1.12-branch/Source
Cherry-pick r261252. rdar://problem/62995461
REGRESSION (r260684): Reader background is lost after multitasking
https://bugs.webkit.org/show_bug.cgi?id=211533
<rdar://problem/62941837>
Unreviewed, revert r260684 due to regression.
Source/WebCore:
- dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners):
- page/FrameView.cpp: (WebCore::FrameView::sendResizeEventIfNeeded):
- page/Page.h: (WebCore::Page::shouldFireResizeEvents const): (WebCore::Page::setShouldFireResizeEvents):
Source/WebKit:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setShouldFireResizeEvents):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKApplicationStateTrackingView.mm: (-[WKApplicationStateTrackingView _willBeginSnapshotSequence]): (-[WKApplicationStateTrackingView _didCompleteSnapshotSequence]):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setShouldFireResizeEvents):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261351] by
-
- 2 edits in branches/safari-610.1.12-branch/Source/WebCore
Cherry-pick r261245. rdar://problem/62995531
REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange
https://bugs.webkit.org/show_bug.cgi?id=211523
<rdar://problem/62860203>
Reviewed by Darin Adler.
- page/TextIndicator.cpp: (WebCore::estimatedTextColorsForRange): TextIterator's node() getter can return null. r260753 accidentally refactored away the null check.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261350] by
-
- 13 edits4 adds in branches/safari-610.1.12-branch
Cherry-pick r261147. rdar://problem/62995512
[JSC] DFG NotCellUse is used without considering about BigInt32
https://bugs.webkit.org/show_bug.cgi?id=211395
Reviewed by Saam Barati.
JSTests:
- stress/non-cell-nor-bigint-should-be-emitted-for-to-number-target-if-bigint-appears.js: Added. (shouldThrow): (test): (i.shouldThrow):
- stress/non-cell-nor-bigint-should-reject-bigint.js: Added. (shouldBe): (test):
- stress/should-not-emit-double-rep-for-bigint.js: Added. (foo):
- stress/urshift-value-to-int32-should-reject-bigint.js: Added. (shouldThrow): (test): (i.shouldThrow):
Source/JavaScriptCore:
When we see CompareXXX(BigInt32, Double), we are emitting CompareXXX(DoubleRep(BigInt:NotCellUse), Double). But this has two problems.
- We should emit CompareXXX(UntypedUse, UntypedUse) in this case.
- DoubleRep(NotCellUse) does not support converting BigInt32 to double. Since DoubleRep's semantics is for ToNumber, it should not accept BigInt32 since it should throw an error. However, DoubleRep currently assumes that NotCellUse value can be converted to double without any errors.
To keep DoubleRep's semantics ToNumber, we replace NotCellUse with NotCellNorBigIntUse, which rejects BigInt32. This patch also uses NotCellNorBigIntUse
for ValueToInt32 because of the same reason.
For CompareXXX and CompareEq nodes, we can optimize it if we introduce new DoubleRepAcceptingBigInt32 DFG node which can convert BigInt32 to Double, since
CompareXXX and CompareEq are not requiring toNumber semantics. This should be done in a separate bug https://bugs.webkit.org/show_bug.cgi?id=211407.
- bytecode/SpeculatedType.h: (JSC::isNotCellNorBigIntSpeculation):
- dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::fixIntConvertingEdge): (JSC::DFG::FixupPhase::fixupChecksInBlock):
- dfg/DFGNode.h: (JSC::DFG::Node::shouldSpeculateNotCellNorBigInt):
- dfg/DFGSafeToExecute.h: (JSC::DFG::SafeToExecuteEdge::operator()):
- dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileValueToInt32): (JSC::DFG::SpeculativeJIT::compileDoubleRep): (JSC::DFG::SpeculativeJIT::speculateNotCellNorBigInt): (JSC::DFG::SpeculativeJIT::speculate):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGUseKind.cpp: (WTF::printInternal):
- dfg/DFGUseKind.h: (JSC::DFG::typeFilterFor): (JSC::DFG::checkMayCrashIfInputIsEmpty):
- ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileDoubleRep): (JSC::FTL::DFG::LowerDFGToB3::compileValueToInt32): (JSC::FTL::DFG::LowerDFGToB3::numberOrNotCellNorBigIntToInt32): (JSC::FTL::DFG::LowerDFGToB3::speculate): (JSC::FTL::DFG::LowerDFGToB3::speculateNotCellNorBigInt): (JSC::FTL::DFG::LowerDFGToB3::numberOrNotCellToInt32): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261349] by
-
- 2 edits in branches/safari-610.1.12-branch/Source/WebKit
Cherry-pick r261146. rdar://problem/62995486
REGRESSION (r260791?): Assert not reached in ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() and ResourceLoadStatisticsDatabaseStore::addMissingTablesIfNecessary()
https://bugs.webkit.org/show_bug.cgi?id=211305
<rdar://problem/62737871>
Reviewed by Alex Christensen.
This patch adds a busy timeout for the ITP database to allow for
some concurrency flexibility when running many WebKitTestRunner tests, which
recreate the ITP database store very often to test both the memory and
database stores.
With the timeout, an attempt to write to the database when another
thread is holding the lock will keep attempting to insert for 5
seconds as long as the statement execution returns SQLITE_BUSY.
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: (WebKit::ResourceLoadStatisticsDatabaseStore::openITPDatabase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261348] by
-
- 2 edits in branches/safari-610.1.12-branch/LayoutTests
Cherry-pick r261122. rdar://problem/62995479
REGRESSION (r261109): [ Mac ] inspector/css/getAllStyleSheets.html is failing
https://bugs.webkit.org/show_bug.cgi?id=211405
<rdar://problem/62863843>
Unreviewed, remove unnecessary call to function that no longer exists.
- inspector/css/getAllStyleSheets.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261347] by
-
- 2 edits in branches/safari-610.1.12-branch/LayoutTests
Cherry-pick r261121. rdar://problem/62995508
REGRESSION (r261108): [ Mac ] inspector/timeline/timeline-recording.html is failing
https://bugs.webkit.org/show_bug.cgi?id=211404
<rdar://problem/62863766>
Unreviewed, update test expectation.
- inspector/timeline/timeline-recording-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261346] by
-
- 2 edits in branches/safari-610.1.12-branch/Source/WebKit
Cherry-pick r261187. rdar://problem/62993016
Check for app-bound domains should confirm WKAppBoundDomains key exists when checking for default app-bound protocols.
https://bugs.webkit.org/show_bug.cgi?id=211451
<rdar://problem/62715316
Reviewed by Brent Fulgham.
Checks for WKAppBoundDomains key before treating a protocol as
app-bound. This is a regression in expected behavior after making
In-App Browser privacy opt-in based on the presence of the key.
Also moves the check for special protocols inside of the completion handler for
ensureAppBoundDomains to make sure the check for the key has finished.
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::beginAppBoundDomainCheck): Added a comment to clarify why we need to check for both an empty app-bound domains list and the presence of the key for testing purposes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [261345] by
-
- 3 edits in branches/safari-610.1.12-branch/Source/WebKit
Cherry-pick r261140. rdar://problem/62993055
[iOS] Make sure TestController::statisticsResetToConsistentState() does not hang due to process suspension
https://bugs.webkit.org/show_bug.cgi?id=211421
Reviewed by Maciej Stachowiak.
We have evidence of hangs in TestController::statisticsResetToConsistentState() on iOS and we suspect it
is due to process suspension. To address the issue, this patch updates the IPCs being sent as a result of
a call to statisticsResetToConsistentState() to take a background assertion while waiting for the IPC
response.
- UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::setUseITPDatabase): (WebKit::NetworkProcessProxy::resetCacheMaxAgeCapForPrevalentResources): (WebKit::NetworkProcessProxy::resetParametersToDefaultValues): (WebKit::NetworkProcessProxy::scheduleClearInMemoryAndPersistent): (WebKit::NetworkProcessProxy::resetCrossSiteLoadsWithLinkDecorationForTesting): (WebKit::NetworkProcessProxy::setShouldDowngradeReferrerForTesting): (WebKit::NetworkProcessProxy::setShouldBlockThirdPartyCookiesForTesting): (WebKit::NetworkProcessProxy::setShouldEnbleSameSiteStrictEnforcementForTesting): (WebKit::NetworkProcessProxy::setFirstPartyWebsiteDataRemovalModeForTesting):
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::setShouldBlockThirdPartyCookiesForTesting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:22 PM Changeset in webkit [261344] by
-
- 5 edits in trunk
Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'mimeType.endsWith')
https://bugs.webkit.org/show_bug.cgi?id=211593
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
- UserInterface/Views/ResourceClusterContentView.js:
(WI.ResourceClusterContentView.prototype._normalizeMIMETypeForDOM):
LayoutTests:
- inspector/unit-tests/mimetype-utilities.html:
- inspector/unit-tests/mimetype-utilities-expected.txt:
Add some tests for
parseMIMEType.
- 4:17 PM Changeset in webkit [261343] by
-
- 8 edits in trunk/Source
Remove AudioMediaStreamTrackRenderer::muted
https://bugs.webkit.org/show_bug.cgi?id=211289
Reviewed by Eric Carlson.
Source/WebCore:
- platform/mediastream/AudioMediaStreamTrackRenderer.h:
muted is unnecessary since we are using start/stop instead.
Source/WebKit:
muted is unnecessary since we are using start/stop instead.
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
- WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:
- WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h:
- 4:08 PM Changeset in webkit [261342] by
-
- 3 edits in trunk/Source/WebCore
[macOS] Playhead in Touch Bar continues when loading stalls
https://bugs.webkit.org/show_bug.cgi?id=211585
<rdar://problem/33893306>
Reviewed by Darin Adler.
- platform/cocoa/PlaybackSessionModelMediaElement.h:
- platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::updateForEventName): Listen for
waitingEvent
andcanplayevents. Don't claim to be playing when stalled.
(WebCore::PlaybackSessionModelMediaElement::isStalled const): New.
- 4:05 PM Changeset in webkit [261341] by
-
- 12 edits2 adds in trunk
Poster set after playback begins should be ignored
https://bugs.webkit.org/show_bug.cgi?id=211464
Reviewed by Jer Noble.
Source/WebCore:
Redo the poster frame logic to use the
show poster flaglogic from the spec.
Test: media/video-poster-set-after-playback.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_showPoster.
(WebCore::HTMLMediaElement::prepareForLoad): m_displayMode was removed.
(WebCore::HTMLMediaElement::selectMediaResource): Call setShowPosterFlag.
(WebCore::HTMLMediaElement::loadResource): Remove calls to setDisplayMode and updateDisplayState,
they have been deleted.
(WebCore::HTMLMediaElement::waitForSourceChange): Call setShowPosterFlag. Update spec text.
(WebCore::HTMLMediaElement::noneSupported): Call setShowPosterFlag.
(WebCore::HTMLMediaElement::mediaLoadingFailed): Remove call to updateDisplayState.
(WebCore::HTMLMediaElement::setReadyState): Ditto.
(WebCore::HTMLMediaElement::seekWithTolerance): Call setShowPosterFlag.
(WebCore::HTMLMediaElement::seekTask): Check m_showPoster, not displayMode.
(WebCore::HTMLMediaElement::playInternal): Call setShowPosterFlag.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Don't check displayMode.
(WebCore::HTMLMediaElement::updatePlayState): No more setDisplayMode.
(WebCore::HTMLMediaElement::userCancelledLoad): Call setShowPosterFlag.
(WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): Deleted.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::showPosterFlag const):
(WebCore::HTMLMediaElement::setShowPosterFlag):
(WebCore::HTMLMediaElement::displayMode const): Deleted.
(WebCore::HTMLMediaElement::setDisplayMode): Deleted.
(WebCore::HTMLMediaElement::updateDisplayState): Deleted.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::didAttachRenderers): No more updateDisplayState.
(WebCore::HTMLVideoElement::parseAttribute): Ditto. Call updateFromElement when poster is removed.
(WebCore::HTMLVideoElement::shouldDisplayPosterImage const): New.
(WebCore::HTMLVideoElement::mediaPlayerFirstVideoFrameAvailable): New, update player and
renderer if the poster isn't supposed to be visible.
(WebCore::HTMLVideoElement::setDisplayMode): Deleted.
(WebCore::HTMLVideoElement::updateDisplayState): Deleted.
- html/HTMLVideoElement.h:
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::failedToLoadPosterImage const): New.
- rendering/RenderVideo.h:
- testing/Internals.cpp:
(WebCore::Internals::elementShouldDisplayPosterImage const):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/video-poster-set-after-playback-expected.txt: Added.
- media/video-poster-set-after-playback.html: Added.
- 4:01 PM Changeset in webkit [261340] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Sources: Breakpoints status not remembered/restored correctly
https://bugs.webkit.org/show_bug.cgi?id=211558
Reviewed by Joseph Pecoraro.
- UserInterface/Controllers/DOMDebuggerManager.js:
(WI.DOMDebuggerManager.prototype.initializeTarget):
- 3:59 PM Changeset in webkit [261339] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Storage: double clicking on a cookie field doesn't start editing it
https://bugs.webkit.org/show_bug.cgi?id=211598
Reviewed by Timothy Hatcher.
- UserInterface/Views/CookieStorageContentView.js:
(WI.CookieStorageContentView):
(WI.CookieStorageContentView.prototype.tableCellContextMenuClicked):
(WI.CookieStorageContentView.prototype.tablePopulateCell):
(WI.CookieStorageContentView.prototype._showCookiePopover):
(WI.CookieStorageContentView.prototype._handleSetCookieButtonClick):
Add a"dblclick"event listener to each cell that shows aWI.CookiePopoverfor that cell
and automatically select the current value of that field in theWI.Cookie. Unify the few
different ways to show aWI.CookiePopover.
- UserInterface/Views/CookiePopover.js:
(WI.CookiePopover.prototype.show.createRow):
Provide a way to programmatically trigger the focusing of an editor once shown.
- Localizations/en.lproj/localizedStrings.js:
- 3:58 PM Changeset in webkit [261338] by
-
- 2 edits in trunk/Source/WebCore
In Document::willBeRemovedFromFrame, clear FrameSelection before Editor so the selection is removed.
https://bugs.webkit.org/show_bug.cgi?id=211551
Reviewed by Geoffrey Garen.
Covered by existing tests.
- dom/Document.cpp:
(WebCore::Document::willBeRemovedFromFrame):
- 2:48 PM Changeset in webkit [261337] by
-
- 8 edits in trunk/Source
Versioning.
- 2:44 PM Changeset in webkit [261336] by
-
- 10 edits in trunk/Source/WebCore
[Web Animations] imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=211232
<rdar://problem/62650227>
Reviewed by Dean Jackson.
The flakiness came from this porting of the test:
animA.finished.then(() => { animB.cancel() });
animB.finished.then(() => { animA.cancel() });
Sometimes, animA and animB would finish in different frames even though they were designed to finish at the
same time. If this happened, animA.finished would resolve and trigger animB.cancel, which then rejected
animB.finished. This happened because animB was attached to a DocumentTimeline created by script which isn't
the main DocumenTimeline accessed via document.timeline. Some curious code would handle syncing of the
various timelines such that they would use a shared timebase. This was in DocumentTimeline::currentTime():
auto& mainDocumentTimeline = m_document->timeline();
if (&mainDocumentTimeline != this) {
if (auto mainDocumentTimelineCurrentTime = mainDocumentTimeline.currentTime())
return *mainDocumentTimelineCurrentTime - m_originTime;
return WTF::nullopt;
}
We now move the currentTime caching at the DocumentTimelinesController level which ensures all DocumentTimeline
objects attached to a given Document use the exact same currentTime(). This prompted some overdue refactoring
where also all the related animation suspension code is moved from DocumentTimeline up to DocumentTimelinesController.
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::detachFromDocument):
(WebCore::DocumentTimeline::suspendAnimations):
(WebCore::DocumentTimeline::resumeAnimations):
(WebCore::DocumentTimeline::animationsAreSuspended const):
(WebCore::DocumentTimeline::currentTime):
(WebCore::DocumentTimeline::scheduleAnimationResolution):
(WebCore::DocumentTimeline::documentWillUpdateAnimationsAndSendEvents):
(WebCore::DocumentTimeline::animationsAreSuspended): Deleted.
(WebCore::DocumentTimeline::liveCurrentTime const): Deleted.
(WebCore::DocumentTimeline::cacheCurrentTime): Deleted.
(WebCore::DocumentTimeline::maybeClearCachedCurrentTime): Deleted.
- animation/DocumentTimeline.h:
- animation/DocumentTimelinesController.cpp:
(WebCore::DocumentTimelinesController::detachFromDocument):
(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):
(WebCore::DocumentTimelinesController::suspendAnimations):
(WebCore::DocumentTimelinesController::resumeAnimations):
(WebCore::DocumentTimelinesController::animationsAreSuspended const):
(WebCore::DocumentTimelinesController::liveCurrentTime const):
(WebCore::DocumentTimelinesController::currentTime):
(WebCore::DocumentTimelinesController::cacheCurrentTime):
(WebCore::DocumentTimelinesController::maybeClearCachedCurrentTime):
- animation/DocumentTimelinesController.h:
- dom/Document.cpp:
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::resume):
- dom/Document.h:
- page/Frame.cpp:
(WebCore::Frame::clearTimers):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
- page/Page.cpp:
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
- testing/Internals.cpp:
(WebCore::Internals::animationsAreSuspended const):
(WebCore::Internals::suspendAnimations const):
(WebCore::Internals::resumeAnimations const):
- 2:39 PM Changeset in webkit [261335] by
-
- 1 copy in branches/safari-610.1.12-branch
New branch.
- 2:02 PM Changeset in webkit [261334] by
-
- 8 edits6 adds in trunk
REGRESSION (r252161): Animation of box-shadow with border-radius set is flashy
https://bugs.webkit.org/show_bug.cgi?id=211530
<rdar://problem/62570229>
Reviewed by Zalan Bujtas.
Source/WebCore:
Drawing inset box shadows with spread was broken, and in some cases generated invalid
rounded rects, causing inset shadows with border-radius to lose the radius.
First, with split inlines, the spread was not getting removed from the excluded edges.
Fix in the includeLogicalLeftEdge/includeLogicalRightEdge clauses, adding shiftXEdgeBy()/shiftYEdgeBy() helpers
to LayoutRect to simplify logic.
Second, when computing the rounded hole rect, we'd use the result of style.getRoundedInnerBorderFor()
but that doesn't take shadow spread into account, so we'd build a rounded rect with a rect that
accounted for spread, but radii computed without. That could result in unrenderable rounded rects.
Fix by calling style.getRoundedInnerBorderFor() a second time if we have spread; this will fix
up the radii for spread.
Tests: fast/box-shadow/inset-box-shadow-fractional-radius.html
fast/box-shadow/inset-shadow-split-inline.html
fast/box-shadow/inset-spread-box-shadow-split-inline.html
- platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::shiftXEdgeBy):
(WebCore::LayoutRect::shiftYEdgeBy):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
LayoutTests:
Some ref tests for inset shadows with border radius, with spread, and when on
split inlines.
- fast/box-shadow/inset-box-shadow-expected.html:
- fast/box-shadow/inset-box-shadow-fractional-radius-expected.html: Added.
- fast/box-shadow/inset-box-shadow-fractional-radius.html: Added.
- fast/box-shadow/inset-box-shadow.html:
- fast/box-shadow/inset-shadow-split-inline-expected.html: Added.
- fast/box-shadow/inset-shadow-split-inline.html: Added.
- fast/box-shadow/inset-spread-box-shadow-split-inline-expected.html: Added.
- fast/box-shadow/inset-spread-box-shadow-split-inline.html: Added.
- 1:57 PM Changeset in webkit [261333] by
-
- 39 edits in trunk/Source
Remove unused USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
https://bugs.webkit.org/show_bug.cgi?id=211582
Reviewed by Fujii Hironori.
After r261264 all ports implemented USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR.
Source/WebCore:
- page/ChromeClient.h:
(WebCore::ChromeClient::createDisplayRefreshMonitor const):
- page/Page.cpp:
(WebCore::Page::windowScreenDidChange):
- page/RenderingUpdateScheduler.cpp:
(WebCore::RenderingUpdateScheduler::RenderingUpdateScheduler):
(WebCore::RenderingUpdateScheduler::adjustRenderingUpdateFrequency):
(WebCore::RenderingUpdateScheduler::scheduleTimedRenderingUpdate):
(WebCore::RenderingUpdateScheduler::windowScreenDidChange):
- page/RenderingUpdateScheduler.h:
- platform/graphics/DisplayRefreshMonitor.cpp:
- platform/graphics/DisplayRefreshMonitor.h:
- platform/graphics/DisplayRefreshMonitorClient.cpp:
- platform/graphics/DisplayRefreshMonitorClient.h:
- platform/graphics/DisplayRefreshMonitorManager.cpp:
- platform/graphics/DisplayRefreshMonitorManager.h:
- platform/graphics/GraphicsLayerUpdater.cpp:
(WebCore::GraphicsLayerUpdater::GraphicsLayerUpdater):
(WebCore::GraphicsLayerUpdater::scheduleUpdate):
(WebCore::GraphicsLayerUpdater::screenDidChange):
(WebCore::GraphicsLayerUpdater::displayRefreshFired):
(WebCore::GraphicsLayerUpdater::createDisplayRefreshMonitor const):
- platform/graphics/GraphicsLayerUpdater.h:
- platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp:
- platform/graphics/gtk/DisplayRefreshMonitorGtk.h:
- platform/graphics/ios/DisplayRefreshMonitorIOS.h:
- platform/graphics/ios/DisplayRefreshMonitorIOS.mm:
- platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
- platform/graphics/mac/DisplayRefreshMonitorMac.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::createDisplayRefreshMonitor const):
- rendering/RenderLayerCompositor.h:
Source/WebKit:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::ThreadedCompositor):
(WebKit::m_displayRefreshMonitor):
(WebKit::ThreadedCompositor::invalidate):
(WebKit::ThreadedCompositor::sceneUpdateFinished):
(WebKit::ThreadedCompositor::displayRefreshMonitor):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createDisplayRefreshMonitor const):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::createDisplayRefreshMonitor):
- WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::createDisplayRefreshMonitor):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:
(WebKit::LayerTreeHost::deviceOrPageScaleFactorChanged):
- WebProcess/WebPage/DrawingArea.cpp:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h:
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm:
- WebProcess/WebPage/mac/DrawingAreaMac.cpp:
Source/WTF:
- wtf/PlatformUse.h:
- 1:15 PM Changeset in webkit [261332] by
-
- 2 edits in trunk/Tools
webkitpy: Use apple_additions certificate path if available
https://bugs.webkit.org/show_bug.cgi?id=211584
Rubber-stamped by Aakash Jain
- Scripts/webkitpy/results/upload.py:
(Upload):
(Upload.certificate_chain): Certificate chain to be used, prefer apple_additions
over certifi.
(Upload.upload): Use Upload.certificate_chain().
(Upload.upload_archive): Ditto.
- 1:15 PM Changeset in webkit [261331] by
-
- 2 edits in trunk/Source/JavaScriptCore
Simplify preprocessor guards in GCMemoryOperations.h
https://bugs.webkit.org/show_bug.cgi?id=211588
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-05-07
Reviewed by Darin Adler.
If we adjust the guards a bit, then we don't need to repeat the fallback path.
- heap/GCMemoryOperations.h:
(JSC::gcSafeMemmove):
(JSC::gcSafeZeroMemory):
- 1:07 PM Changeset in webkit [261330] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk1 ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-text.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=209201
Unreviewed test gardening.
Remove flaky expectation since the test is consistently passing.
- platform/mac-wk1/TestExpectations:
- 1:04 PM Changeset in webkit [261329] by
-
- 3 edits in trunk/LayoutTests
[ macOS debug ] REGRESSION (r259463): http/tests/media/clearkey/collect-webkit-media-session.html is failing
https://bugs.webkit.org/show_bug.cgi?id=209989
Unreviewed test gardening.
Remove failure expectations for tests that are now consistently passing.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 1:03 PM WebKitGTK/2.28.x edited by
- (diff)
- 12:49 PM Changeset in webkit [261328] by
-
- 7 edits in trunk/Source
Give the DFG and FTL WorkList threads more stack space on ASAN builds.
https://bugs.webkit.org/show_bug.cgi?id=211535
<rdar://problem/62947884>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::ThreadBody::ThreadBody):
- Mark the AutomaticThread as ThreadType::Compiler.
Source/WTF:
- Add the ability to set the ThreadType for AutomaticThreads.
- Give ThreadType::Compiler (which currently only used for the DFG anf FTL WorkList threads) a larger stack for OS(DARWIN) on ASAN builds.
This is needed because ASAN is a memory hungry beast, and we want the ASAN
builds to get to exercise the same amount of code a regular build will (instead
of failing out early with a stack overflow error).
- wtf/AutomaticThread.cpp:
(WTF::AutomaticThread::AutomaticThread):
(WTF::AutomaticThread::start):
- wtf/AutomaticThread.h:
- wtf/Threading.cpp:
(WTF::stackSize):
- wtf/Threading.h:
- 12:36 PM Changeset in webkit [261327] by
-
- 2 edits in trunk/Source/WebCore
Add watchOS media controls assets
https://bugs.webkit.org/show_bug.cgi?id=211508
Unreviewed. Cleaning up some stray logging.
- WebCore.xcodeproj/project.pbxproj:
- 12:30 PM Changeset in webkit [261326] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r251875): Crash in JSC::StructureIDTable::get on ppc64le: gcSafeMemcpy broken on JSVALUE64 platforms other than x86_64 and aarch64
https://bugs.webkit.org/show_bug.cgi?id=210685
Patch by Daniel Kolesa <daniel@octaforge.org> on 2020-05-07
Reviewed by Michael Catanzaro.
Fix gcSafeMemcpy on non-x86_64/aarch64 64-bit architectures.
We were hitting an incorrect x86_64 assertion on values larger than
mediumCutoff on JSVALUE64 architectures other than x86_64 and aarch64,
as the control flow is wrong.
- heap/GCMemoryOperations.h:
(JSC::gcSafeMemcpy):
- 12:25 PM Changeset in webkit [261325] by
-
- 6 edits in trunk/Source
Add stack checks to the DFG and FTL bytecode parser.
https://bugs.webkit.org/show_bug.cgi?id=211547
<rdar://problem/62958880>
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
Inlining can cause some level of recursion of the DFG bytecode parser. We should
do a stack check at each inlining check before recursing. If a stack overflow
appears to be imminent, then just refuse to inline, and therefore, don't recurse
deeper into the parser.
This issue is more noticeable on ASan debug builds where stack frames can be
humongous.
Removed the SUPPRESS_ASAN on cloberrize() and the associated comment from r260692.
It was a mis-diagnosis. The stack checks are what we need.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleVarargsInlining):
(JSC::DFG::ByteCodeParser::handleInlining):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGGraph.h:
Source/WTF:
Added a StackCheck::Scope RAII object to help verify that the default reserved
zone size is at least adequate for known work loads. If this the StackCheck::Scope
assertions fail, then we either need more stack checks, or the reserved zone size
needs to be increased.
Note that the assertions are usually only on in Debug builds. Ideally, we would
want to measure the reserved zone size with a Release build. To do that, we
can just set VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE to 1 unconditionally in
StackCheck.h and rebuild.
- wtf/StackCheck.h:
(WTF::StackCheck::Scope::Scope):
(WTF::StackCheck::Scope::~Scope):
(WTF::StackCheck::Scope::isSafeToRecurse):
(WTF::StackCheck::StackCheck):
- 12:12 PM Changeset in webkit [261324] by
-
- 2 edits in trunk/Tools
Unreviewed, reverting r260959.
https://bugs.webkit.org/show_bug.cgi?id=211587
"Causes MiniBrowser to crash when closing a window" (Requested
by ddkilzer on #webkit).
Reverted changeset:
"REGRESSION (r176862, r210483): Leaks of
BrowserWindowController in MiniBrowser/mac/AppDelegate.m"
https://bugs.webkit.org/show_bug.cgi?id=211243
https://trac.webkit.org/changeset/260959
- 11:55 AM Changeset in webkit [261323] by
-
- 5 edits in trunk/Source
Add some missing null checks for DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=211544
rdar://62843516
Reviewed by Anders Carlsson.
Source/WebCore:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted): Use some more RefPtr,
and check for null before calling DocumentLoader::responseMIMEType.
Also removed a comment that made no sense, and an assertion that was
there for no reason, left over from some point in history where it
made sense.
- loader/HistoryController.cpp:
(WebCore::FrameLoader::HistoryController::updateForRedirectWithLockedBackForwardList):
Add checks for null before calling urlForHistory and isClientRedirect.
Source/WebKit:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Add a null check before calling DocumentLoader::response.
- 11:42 AM Changeset in webkit [261322] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
Fix Google Maps rendering corruption in simulator with ANGLE
https://bugs.webkit.org/show_bug.cgi?id=211398
glReadPixels call needs to respect the row stride of the IOSurface.
Patch by James Darpinian <James Darpinian> on 2020-05-07
Reviewed by Alex Christensen.
- src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.h:
- src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:
(rx::IOSurfaceSurfaceEAGL::IOSurfaceSurfaceEAGL):
(rx::IOSurfaceSurfaceEAGL::releaseTexImage):
- 11:38 AM Changeset in webkit [261321] by
-
- 1 edit3 adds in trunk/LayoutTests
Add a test for
REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange
https://bugs.webkit.org/show_bug.cgi?id=211532
Reviewed by Wenson Hsieh.
- fast/text-indicator/text-indicator-estimated-color-with-implicit-newline-expected.txt: Added.
- fast/text-indicator/text-indicator-estimated-color-with-implicit-newline.html: Added.
- platform/ios/fast/text-indicator/text-indicator-estimated-color-with-implicit-newline-expected.txt: Added.
This test would trigger the null deref fixed in r261245.
- 11:37 AM Changeset in webkit [261320] by
-
- 21 edits2 copies in trunk
Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code
https://bugs.webkit.org/show_bug.cgi?id=211525
Reviewed by Anders Carlsson.
Source/WebCore:
- editing/mac/TextUndoInsertionMarkupMac.h: Remove
NSTextInputContext_Private.h usage. Moving to NSTextInputContextSPI.h
instead. Also remove #pragma once since this is an Objective-C-only
header, not for cross-platform use.
- editing/mac/TextUndoInsertionMarkupMac.mm: Above, plus move
NSUndoManager_Private.h to NSUndoManagerSPI.h.
Source/WebCore/PAL:
- PAL.xcodeproj/project.pbxproj: Added NSTextInputContextSPI.h and NSUndoManagerSPI.h.
- pal/PlatformMac.cmake: Ditto.
- pal/spi/mac/NSTextInputContextSPI.h: Added.
- pal/spi/mac/NSUndoManagerSPI.h: Added.
Source/WebKit:
- UIProcess/Cocoa/WebViewImpl.mm: Use NSTextInputContextSPI.h.
(WebKit::WebViewImpl::validAttributesForMarkedText): Removed
USE(INSERTION_UNDO_GROUPING) from the macOS-specific code here.
(WebKit::WebViewImpl::insertText): Ditto.
- UIProcess/PageClient.h: Ditto.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::registerInsertionUndoGrouping): Deleted.
This function is not needed at all on iOS.
- UIProcess/mac/PageClientImplMac.h: Removed USE(INSERTION_UNDO_GROUPING).
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::registerInsertionUndoGrouping): Ditto.
Source/WebKitLegacy/mac:
- WebView/WebHTMLView.mm: Use NSTextInputContextSPI.h.
(-[WebHTMLView validAttributesForMarkedText]): Removed USE(INSERTION_UNDO_GROUPING).
(-[WebHTMLView insertText:]): Ditto.
Tools:
- DumpRenderTree/mac/TextInputControllerMac.m: Use NSTextInputContextSPI.h.
(-[TextInputController stringWithUndoGroupingInsertion:]): Removed
SUPPORT_INSERTION_UNDO_GROUPING.
- DumpRenderTree/mac/UIScriptControllerMac.mm: Use NSTextInputContextSPI.h.
- TestRunnerShared/spi/AppKitTestSPI.h: Removed
NSTextInputContext_Private.h, clients can use NSTextInputContextSPI.h.
- TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Ditto.
- TestWebKitAPI/Tests/mac/CandidateTests.mm: Use NSTextInputContextSPI.h.
- TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Ditto.
- 11:24 AM Changeset in webkit [261319] by
-
- 5 edits4 deletes in trunk/Tools
Delete code for old commit queue
https://bugs.webkit.org/show_bug.cgi?id=211581
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/common/config/committervalidator.py: Removed.
- Scripts/webkitpy/common/config/committervalidator_unittest.py: Removed.
- Scripts/webkitpy/tool/bot/commitqueuetask.py: Removed.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Removed.
- Scripts/webkitpy/tool/commands/queues.py:
(PatchProcessingQueue._upload_results_archive_for_patch):
(CommitQueue): Deleted.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(NeedsUpdateSequence._run):
(TestCommitQueue): Deleted.
(AlwaysCommitQueueTool): Deleted.
(SecondThoughtsCommitQueue): Deleted.
(CommitQueueTest): Deleted.
(test_did_pass_testing_ews): Deleted.
- Scripts/webkitpy/tool/steps/validatechangelogs.py:
- Scripts/webkitpy/tool/steps/validatereviewer.py:
- 11:21 AM Changeset in webkit [261318] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 ] http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209154
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 11:12 AM Changeset in webkit [261317] by
-
- 3 edits6 adds in trunk/Source/WebCore
[Conditional=] not working for operations in WebGLRenderingContextBase.idl
https://bugs.webkit.org/show_bug.cgi?id=211528
Reviewed by Chris Dumez.
When an IDL interface under a given Condition defined an operation with
another Condition the generated source file should guard the operation
with both the Condition from the interface and the one from the
operation. This was working fine for sole interfaces but not for those
who were inheriting from a base one, i.e., it was not working for
supplemental interfaces.
Added a new minimalistic binding test showcasing the problem.
- bindings/scripts/CodeGenerator.pm:
(ProcessSupplementalDependencies): Add Conditionals from both interface and operation.
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::jsTestGlobalObjectTestOperationConditionalConstructorGetter): Updated result.
(WebCore::jsTestGlobalObjectTestOperationConditionalConstructor): Ditto.
(WebCore::setJSTestGlobalObjectTestOperationConditionalConstructorSetter): Ditto.
(WebCore::setJSTestGlobalObjectTestOperationConditionalConstructor): Ditto.
- bindings/scripts/test/JS/JSTestOperationBase.cpp: Added.
- bindings/scripts/test/JS/JSTestOperationBase.h: Added.
- bindings/scripts/test/JS/JSTestOperationConditional.cpp: Added.
- bindings/scripts/test/JS/JSTestOperationConditional.h: Added.
- bindings/scripts/test/TestOperationBase.idl: Added.
- bindings/scripts/test/TestOperationConditional.idl: Added.
- 11:07 AM Changeset in webkit [261316] by
-
- 2 edits in trunk/Tools
Unreviewed, reverting r261286.
Tests are still crashing / failing
Reverted changeset:
"Unskip the test since it should now be passing"
https://trac.webkit.org/changeset/261286
- 11:02 AM Changeset in webkit [261315] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION (r261257): Lifetime problem with upconverted characters in toLocaleCase
https://bugs.webkit.org/show_bug.cgi?id=211580
rdar://62980449
Reviewed by Yusuke Suzuki.
The problem comes from the fact that callBufferProducingFunction is moving the same
arguments multiple times. At the moment, this works around the only practical
problem with that, but later it should be fixed in callBufferProducingFunction.
- runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::initializeDateTimeFormat): Work around mistakes in how
callBufferProducingFunction works with arguments by calling get() explicitly on the
result of upconvertedCharacters. Later we could fix callBufferProducingFunction to
be safer, but for now this solves the problem.
- runtime/StringPrototype.cpp:
(JSC::toLocaleCase): Ditto.
- 11:01 AM Changeset in webkit [261314] by
-
- 7 edits in trunk
[Wheel event region] Include listeners on Window
https://bugs.webkit.org/show_bug.cgi?id=211577
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/scrolling/mac/wheel-event-listener-region-window.html
- dom/EventTarget.h:
- dom/Node.h:
- style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::computeEventListenerRegionTypes):
Take EventTarget so this can be used with DOMWindow.
- style/StyleAdjuster.h:
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
LayoutTests:
- fast/scrolling/mac/wheel-event-listener-region-window-expected.txt: Added.
- fast/scrolling/mac/wheel-event-listener-region-window.html: Added.
- 11:00 AM Changeset in webkit [261313] by
-
- 4 edits2 adds in trunk
Fix ArrayMode nodes after r261260
https://bugs.webkit.org/show_bug.cgi?id=211543
Reviewed by Yusuke Suzuki.
I accidentally ran tests with a release build rather than
release+assert when uploading r261260. This patch skips the
CheckArray node in the ArrayMode clobbersTop() logic before
Fixup. And also marks a GetArrayLength in the TypedArray
intrsinics as ExitOK.
This patch also relands r261260.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicGetter):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- 10:58 AM Changeset in webkit [261312] by
-
- 7 edits in branches/safari-609-branch
Apply patch. rdar://problem/62977667
- 10:58 AM Changeset in webkit [261311] by
-
- 2 edits in branches/safari-609-branch/Source/WebKit
Cherry-pick r260474. rdar://problem/62977672
PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=210813
Reviewed by Eric Carlson.
Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
because that process is not a UI Application.
- UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController videoControlsManagerDidChange]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:58 AM Changeset in webkit [261310] by
-
- 5 edits in branches/safari-609-branch/Source/WebCore
Cherry-pick r260480. rdar://problem/62977665
Cherry-pick r260301. rdar://problem/62083309
[WebGL] Confirm there are no errors when setting up framebuffers
https://bugs.webkit.org/show_bug.cgi?id=210632
<rdar://problem/61916680>
Reviewed by Simon Fraser.
We're seeing crashes on macOS inside GraphicsContextGL::reshape().
Specifically when we submit work at the end of the function via
glFlush.
At the moment the cause is a mystery, because we should bail out
before then if the multisample renderbuffer was not complete. In
the hope that it helps somewhat, add a call to glGetError to double
check that there isn't anything horribly wrong before we talk to
the GPU.
- html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::WebGL2RenderingContext): If the underlying GCGL context was marked as "LOST" during initialization, skip the rest of our initialization.
- html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::WebGLRenderingContext):
- html/canvas/WebGLRenderingContextBase.cpp: Ditto. (WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Check for a GL error during setup and, if there is one, skip directly into a LOST state. (WebCore::GraphicsContext3D::reshape):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-609.2.9.1-branch@260480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:58 AM Changeset in webkit [261309] by
-
- 8 edits in branches/safari-609-branch/Source/WebKit
Apply patch. rdar://problem/62977657
- 10:58 AM Changeset in webkit [261308] by
-
- 6 edits in branches/safari-609-branch/Source/WebKit
Apply patch. rdar://problem/62977647
- 10:58 AM Changeset in webkit [261307] by
-
- 2 edits in branches/safari-609-branch/Source/WebKit
Apply patch. rdar://problem/62272254
- 10:45 AM Changeset in webkit [261306] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r261056): [ Mac WK1 ] inspector/console/console-api.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=211386
Reviewed by Darin Adler.
Address additional review feedback.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
- 10:37 AM Changeset in webkit [261305] by
-
- 6 edits in trunk/Source/WebKit
Drop dead platformPrepareToSuspend / platformProcessDidResume in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=211579
Reviewed by Geoffrey Garen.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::resume):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformPrepareToSuspend): Deleted.
(WebKit::NetworkProcess::platformProcessDidResume): Deleted.
- NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::platformPrepareToSuspend): Deleted.
(WebKit::NetworkProcess::platformProcessDidResume): Deleted.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformPrepareToSuspend): Deleted.
(WebKit::NetworkProcess::platformProcessDidResume): Deleted.
- 10:21 AM Changeset in webkit [261304] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/scroll-restoration-order.html as flaky on iOS.
This test has been flaky on iOS since its import.
- platform/ios-wk2/TestExpectations:
- 10:17 AM Changeset in webkit [261303] by
-
- 6 edits in trunk/Source/WebKit
ContextMenu: entire webpage pops and disappears to generate preview of embedded image
https://bugs.webkit.org/show_bug.cgi?id=211272
<rdar://problem/62482013>
Reviewed by Tim Horton.
The ActionSheetAssistant is always around, so using the presence of one
to determine if we need to remove the _contextMenuHintContainerView is incorrect
and causes it to be around on the next invocation of the context menu, and
causing the failure of the creation of a new preview, which then will default to
popping the whole page. We need to ask the ActionSheetAssistant if it is actively showing
anything, and then correctly clean up the _contextMenuHintContainerView after the
end of the interactions for FileUploadMenu and ActionSheetAssistant are done with their
interactions.
- UIProcess/ios/WKActionSheetAssistant.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant removeContextMenuInteraction]):
(-[WKActionSheetAssistant hasContextMenuInteraction]):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView removeContextMenuViewIfPossibleForActionSheetAssistant:]):
(-[WKContentView _canRemoveContextMenuView]):
(-[WKContentView _removeContextMenuViewIfPossible]):
(-[WKContentView contextMenuInteraction:willEndForConfiguration:animator:]):
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel removeContextMenuInteraction]):
- 10:14 AM Changeset in webkit [261302] by
-
- 4 edits2 adds in trunk
[LFC[TFC] Adjust the table wrapper box style
https://bugs.webkit.org/show_bug.cgi?id=211574
Reviewed by Antti Koivisto.
Source/WebCore:
The computed values of properties 'position', 'float', 'margin-*', 'top', 'right', 'bottom', and 'left'
on the table element are used on the table wrapper box and not the table box; all other values of non-inheritable
properties are used on the table box and not the table wrapper box.
https://www.w3.org/TR/CSS22/tables.html#model
Test: fast/layoutformattingcontext/table-simple-with-border.html
- layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::isBlockContainerBox const):
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::TreeBuilder::buildTableStructure):
LayoutTests:
- fast/layoutformattingcontext/table-simple-with-border-expected.txt: Added.
- fast/layoutformattingcontext/table-simple-with-border.html: Added.
- 10:05 AM Changeset in webkit [261301] by
-
- 8 edits in branches/safari-609-branch/Source
Versioning.
- 9:51 AM Changeset in webkit [261300] by
-
- 6 edits in trunk/Source/WebCore
Make debug build run in accessibility isolated tree mode = 1.
https://bugs.webkit.org/show_bug.cgi?id=211567
Reviewed by Chris Fleizach.
- Removed several unnecessary ASSERTs that prevent debug builds to run
in isolated tree mode = 1, i.e., isolated tree mode on main thread.
- AXIsolatedObject::children and updateBackingStore need to be executed
on both threads.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::detachRemoteParts):
(WebCore::AXIsolatedObject::children): Need to update the children
regardless of the thread in which it is invoked. Pending, must add a
lock to prevent thread collision.
(WebCore::AXIsolatedObject::updateBackingStore): Need to update the
backing store regardless of the thread in whhich it is invoked.
- accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::generateSubtree):
(WebCore::AXIsolatedTree::setRootNodeID):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm: Enable
isolated tree mode = 1.
(-[WebAccessibilityObjectWrapperBase detach]):
(-[WebAccessibilityObjectWrapperBase axBackingObject]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Use makeString
instead of String concatenation as pointed out by Darin Adler in bug 210914.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
- 9:50 AM Changeset in webkit [261299] by
-
- 20 edits in trunk/Source/WebKit
Simplify several IPC sending call sites in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=211575
Reviewed by Alex Christensen.
Simplify several IPC sending call sites in the UIProcess by leveraging the fact
that WebPageProxy subclasses IPC::MessageSender.
- UIProcess/Cocoa/TextCheckingController.mm:
(WebKit::TextCheckingController::replaceRelativeToSelection):
(WebKit::TextCheckingController::removeAnnotationRelativeToSelection):
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection):
(WebKit::WebPageProxy::insertDictatedTextAsync):
(WebKit::WebPageProxy::speakingErrorOccurred):
(WebKit::WebPageProxy::boundaryEventOccurred):
(WebKit::WebPageProxy::voicesDidChange):
- UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):
- UIProcess/Inspector/RemoteWebInspectorProxy.cpp:
(WebKit::RemoteWebInspectorProxy::setDiagnosticLoggingAvailable):
- UIProcess/Inspector/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::setDiagnosticLoggingAvailable):
- UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp:
(WebKit::remoteFileReplaceContentsCallback):
- UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:
(WebKit::fileReplaceContentsCallback):
- UIProcess/Inspector/mac/RemoteWebInspectorProxyMac.mm:
(WebKit::RemoteWebInspectorProxy::platformSave):
(WebKit::RemoteWebInspectorProxy::platformAppend):
- UIProcess/Inspector/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformSave):
(WebKit::WebInspectorProxy::platformAppend):
- UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
(WebKit::NotificationPermissionRequestManagerProxy::createRequest):
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::captureDevicesChanged):
(WebKit::UserMediaPermissionRequestManagerProxy::denyRequest):
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::collapseSelection):
- UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::willEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::didEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::willExitFullScreen):
(WebKit::WebFullScreenManagerProxy::didExitFullScreen):
(WebKit::WebFullScreenManagerProxy::setAnimatingFullScreen):
(WebKit::WebFullScreenManagerProxy::requestExitFullScreen):
(WebKit::WebFullScreenManagerProxy::saveScrollPosition):
(WebKit::WebFullScreenManagerProxy::restoreScrollPosition):
(WebKit::WebFullScreenManagerProxy::setFullscreenInsets):
(WebKit::WebFullScreenManagerProxy::setFullscreenAutoHideDuration):
(WebKit::WebFullScreenManagerProxy::setFullscreenControlsHidden):
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::getCenterForZoomGesture):
- UIProcess/ios/SmartMagnificationController.mm:
(WebKit::SmartMagnificationController::handleSmartMagnificationGesture):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView ensurePositionInformationIsUpToDate:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::handleTwoFingerTapAtPoint):
(WebKit::WebPageProxy::handleStylusSingleTapAtPoint):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::willStartUserTriggeredZooming):
(WebKit::WebPageProxy::potentialTapAtPosition):
(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::cancelPotentialTap):
(WebKit::WebPageProxy::tapHighlightAtPosition):
(WebKit::WebPageProxy::handleTap):
(WebKit::WebPageProxy::didRecognizeLongPress):
(WebKit::WebPageProxy::handleDoubleTapForDoubleClickAtPoint):
(WebKit::WebPageProxy::inspectorNodeSearchMovedToPosition):
(WebKit::WebPageProxy::inspectorNodeSearchEndedAtPosition):
(WebKit::WebPageProxy::blurFocusedElement):
(WebKit::WebPageProxy::setIsShowingInputViewForFocusedElement):
(WebKit::WebPageProxy::setFocusedElementValue):
(WebKit::WebPageProxy::setFocusedElementValueAsNumber):
(WebKit::WebPageProxy::setFocusedElementSelectedIndex):
(WebKit::WebPageProxy::computePagesForPrintingAndDrawToPDF):
(WebKit::WebPageProxy::contentSizeCategoryDidChange):
(WebKit::WebPageProxy::generateSyntheticEditingCommand):
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::handleMagnificationGestureEvent):
(WebKit::ViewGestureController::handleSmartMagnificationGesture):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::setMainFrameIsScrollable):
(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):
(WebKit::WebPageProxy::fontAtSelection):
(WebKit::WebPageProxy::stringSelectionForPasteboard):
(WebKit::WebPageProxy::dataSelectionForPasteboard):
(WebKit::WebPageProxy::readSelectionFromPasteboard):
(WebKit::WebPageProxy::replaceSelectionWithPasteboardData):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
(WebKit::WebPageProxy::acceptsFirstMouse):
- 9:39 AM Changeset in webkit [261298] by
-
- 5 edits2 adds in trunk
[LFC][TFC] Set section [top, left] used position.
https://bugs.webkit.org/show_bug.cgi?id=211546
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/layoutformattingcontext/table-simple-with-padding.html
- layout/Verification.cpp:
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):
- layout/tableformatting/TableFormattingContext.h:
LayoutTests:
- fast/layoutformattingcontext/table-simple-with-padding-expected.txt: Added.
- fast/layoutformattingcontext/table-simple-with-padding.html: Added.
- 9:38 AM Changeset in webkit [261297] by
-
- 5 edits2 adds in trunk
[Wheel event region] Include listeners on Document
https://bugs.webkit.org/show_bug.cgi?id=211571
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/scrolling/mac/wheel-event-listener-region-document.html
- style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::computeEventListenerRegionTypes):
(WebCore::Style::computeEventListenerRegionTypes): Deleted.
Make public and take Node instead of Element.
- style/StyleAdjuster.h:
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
Gather event region bits from Document too.
LayoutTests:
- fast/scrolling/mac/wheel-event-listener-region-document-expected.txt: Added.
- fast/scrolling/mac/wheel-event-listener-region-document.html: Added.
- 9:29 AM Changeset in webkit [261296] by
-
- 13 edits1 add in trunk
Unreviewed, reverting r260769.
https://bugs.webkit.org/show_bug.cgi?id=211578
Introduced regressions related to sharing (Requested by
perarne on #webkit).
Reverted changeset:
"[Cocoa] After r258891, r255119 can be reverted"
https://bugs.webkit.org/show_bug.cgi?id=211083
https://trac.webkit.org/changeset/260769
- 9:23 AM Changeset in webkit [261295] by
-
- 1 edit2 deletes in trunk/LayoutTests
Unreviewed, reverting r261251.
Test is failing on iOS
Reverted changeset:
"Add a test for `REGRESSION (r260753): Frequent crashes under
TextIndicator's estimatedTextColorsForRange`"
https://bugs.webkit.org/show_bug.cgi?id=211532
https://trac.webkit.org/changeset/261251
- 9:21 AM Changeset in webkit [261294] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] Fix string.format invocation
Reviewed by Philippe Normand.
- flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
- 9:19 AM Changeset in webkit [261293] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, reverting r261260.
Caused 26 JSC test failures
Reverted changeset:
"DFG ByVal nodes with ArrayModes should clobberTop until Fixup
phase runs."
https://bugs.webkit.org/show_bug.cgi?id=211531
https://trac.webkit.org/changeset/261260
- 9:14 AM Changeset in webkit [261292] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source.html as flaky.
This test has been flaky since import from WPT.
- 9:00 AM Changeset in webkit [261291] by
-
- 3 edits in trunk/Source/WebCore
Fix assertions seen when trying to draw an absurdly large shadow
https://bugs.webkit.org/show_bug.cgi?id=211541
rdar://62843377
Reviewed by Geoffrey Garen.
- platform/graphics/IntSize.h:
(WebCore::IntSize::unclampedArea const): Return uint64_t instead of
size_t. Two 32-bit positive integers multiplied fit in a 64-bit integer,
but there's no guarantee they fit in a "pointer sized" integer.
- platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::drawRectShadow): When comparing an IntSize area with
a FloatSize area, avoid checked overflow by using IntSize::unclampedArea,
which returns something we can compare with a float. Using IntSize::area
meant we'd intentionally crash the process if the area number doesn't fit
in a 32-bit int, which is not important or helpful.
(WebCore::ShadowBlur::drawRectShadowWithTiling): Make sure
ScratchBuffer::scheduleScratchBufferPurge is always called after
ScratchBuffer::getScratchBuffer, even it returns nullptr. An alternative
would have been to change the logic inside getScratchBuffer, but this
seems easier to get right, and no need to optimize the failure case.
(WebCore::ShadowBlur::drawInsetShadowWithTiling): Ditto.
- 8:37 AM Changeset in webkit [261290] by
-
- 3 edits in trunk/Source/WebCore
Fix potential threading issue in AudioMediaStreamTrackRendererCocoa::render
https://bugs.webkit.org/show_bug.cgi?id=211560
Reviewed by Eric Carlson.
When the audio description is updated, the audio renderer is creating a new AudioSampleDataSource.
The refing of the source in the render method is not sufficient to protect agains the change.
For that purpose, we keep a separate reference to the source that is only used in the render method/render thread.
We add a boolean that tells the render method whether to update its source reference.
As long as the source reference is not updated, no new source will be created n the method processing the pushed samples.
- platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:
(WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples):
(WebCore::AudioMediaStreamTrackRendererCocoa::render):
- platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.h:
- 8:32 AM Changeset in webkit [261289] by
-
- 3 edits1 delete in trunk/LayoutTests
[GTK][WPE] Gardening, update test expectations
https://bugs.webkit.org/show_bug.cgi?id=211573
Review of several test failures that could be closed. Updated test
expectations accordingly.
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- platform/wpe/imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-001-expected.txt: Removed.
- 8:01 AM Changeset in webkit [261288] by
-
- 17 edits in trunk/Source/WebKit
[iOS] AuxiliaryProcessProxy::sendWithAsyncReply() should prevent auxiliary process suspension while processing the IPC
https://bugs.webkit.org/show_bug.cgi?id=209928
Reviewed by Youenn Fablet.
AuxiliaryProcessProxy::sendWithAsyncReply() should prevent auxiliary process suspension
on iOS while processing the IPC. If the process is suspended either before or during
the IPC, this could result in hangs. This is a speculative fix for the flaky timeouts
we see on many tests on iOS only. We know that missing activities with
sendWithAsyncReply has caused test timeouts in the past (Bug 211421).
- UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::sendMessage):
- UIProcess/AuxiliaryProcessProxy.h:
(WebKit::AuxiliaryProcessProxy::sendWithAsyncReply):
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::getGPUProcessConnection):
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
(WebKit::NetworkProcessProxy::setUseITPDatabase):
(WebKit::NetworkProcessProxy::resetCacheMaxAgeCapForPrevalentResources):
(WebKit::NetworkProcessProxy::resetParametersToDefaultValues):
(WebKit::NetworkProcessProxy::scheduleClearInMemoryAndPersistent):
(WebKit::NetworkProcessProxy::resetCrossSiteLoadsWithLinkDecorationForTesting):
(WebKit::NetworkProcessProxy::setAppBoundDomainsForResourceLoadStatistics):
(WebKit::NetworkProcessProxy::setShouldDowngradeReferrerForTesting):
(WebKit::NetworkProcessProxy::setThirdPartyCookieBlockingMode):
(WebKit::NetworkProcessProxy::setShouldEnbleSameSiteStrictEnforcementForTesting):
(WebKit::NetworkProcessProxy::setFirstPartyWebsiteDataRemovalModeForTesting):
(WebKit::NetworkProcessProxy::sendPrepareToSuspend):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/ProcessThrottler.h:
(WebKit::ProcessThrottler::Activity::Activity):
(WebKit::ProcessThrottler::Activity::isQuietActivity const):
(WebKit::ProcessThrottler::Activity::invalidate):
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):
- UIProcess/WebBackForwardCacheEntry.cpp:
(WebKit::WebBackForwardCacheEntry::~WebBackForwardCacheEntry):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookie):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::setCookies):
(WebKit::WebCookieManagerProxy::getAllCookies):
(WebKit::WebCookieManagerProxy::getCookies):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getProcessDisplayName):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setThirdPartyCookieBlockingMode):
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::WebProcessProxy::sendPrepareToSuspend):
(WebKit::WebProcessProxy::activePagesDomainsForTesting):
(WebKit::WebProcessProxy::establishServiceWorkerContext):
- UIProcess/WebProcessProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::insertTextPlaceholder):
(WebKit::WebPageProxy::removeTextPlaceholder):
(WebKit::WebPageProxy::requestAutocorrectionData):
(WebKit::WebPageProxy::requestEvasionRectsAboveSelection):
(WebKit::WebPageProxy::updateSelectionWithDelta):
(WebKit::WebPageProxy::requestDocumentEditingContext):
(WebKit::WebPageProxy::insertDroppedImagePlaceholders):
- 7:47 AM Changeset in webkit [261287] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] Doesn't generate crash logs on the bots
https://bugs.webkit.org/show_bug.cgi?id=211568
Patch by Philippe Normand <pnormand@igalia.com> on 2020-05-07
Reviewed by Carlos Alberto Lopez Perez.
- flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox): Bind-mount the
WEBKIT_CORE_DUMPS_DIRECTORY so that the crash-log generator is
able to write crash log reports there.
- 7:37 AM Changeset in webkit [261286] by
-
- 2 edits in trunk/Tools
Unskip the test since it should now be passing
Unreviewed test gardening.
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
- 7:29 AM Changeset in webkit [261285] by
-
- 2 edits in trunk/Source/WebCore
Fix for crash in AXIsolatedObject::identifierAttribute.
https://bugs.webkit.org/show_bug.cgi?id=211565
Reviewed by Chris Fleizach.
Covered by existing tests.
When adding the identifierAttribute property to the AXIsolatedObject's
properties map, must make an isolatedCopy of it in order to retrieve it
on the secondary thread.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
- 7:26 AM Changeset in webkit [261284] by
-
- 2 edits in trunk/Source/WebKit
[GTK] REGRESSION(r260996): Pressing <Tab> in an HTTP authentication dialog makes the dialog lose focus
https://bugs.webkit.org/show_bug.cgi?id=211555
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-05-07
Reviewed by Philippe Normand.
Bring back webkitWebViewBaseFocus to GTK3. I made it GTK4 only by mistake in r260996.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseFocus):
(webkit_web_view_base_class_init):
- 7:16 AM Changeset in webkit [261283] by
-
- 3 edits in trunk/LayoutTests
[GTK][WPE] Gardening, update test expectations after r261251
https://bugs.webkit.org/show_bug.cgi?id=211570
Unreviewed gardening.
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 6:42 AM Changeset in webkit [261282] by
-
- 4 edits in trunk
[GTK] Test failures after Flatpak upgrade
https://bugs.webkit.org/show_bug.cgi?id=211497
Reviewed by Adrian Perez de Castro.
Tools:
- flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox): Don't set WEBKIT_TOP_LEVEL. I'm
not sure why it's needed at all. If it needs to be set it should
be /app/webkit/ anyway. Setting it to /app triggers test failures
due to invalid computed paths by internals' pathToLocalResource().
LayoutTests:
- platform/gtk/TestExpectations: Unflag fixed tests. The webgl
failures seem more related to bug #211338 actually.
- 6:12 AM Changeset in webkit [261281] by
-
- 3 edits in trunk/LayoutTests
[GTK] Gardening, update baselines after r261248
https://bugs.webkit.org/show_bug.cgi?id=211562
Unreviewed gardening.
- accessibility/gtk/object-attributes-expected.txt:
- platform/gtk/accessibility/lists-expected.txt:
- 5:41 AM Changeset in webkit [261280] by
-
- 3 edits in trunk/Tools
Unreviewed. Fix GTK4 build with current GTK
GtkWindow and GtkOverlay aren't a GtkContainer anymore.
- MiniBrowser/gtk/BrowserTab.c:
(browserTabConstructed):
- MiniBrowser/gtk/BrowserWindow.c:
(browser_window_init):
- 4:16 AM Changeset in webkit [261279] by
-
- 13 edits2 adds in trunk
Add basic support for generating accurate wheel event listener region
https://bugs.webkit.org/show_bug.cgi?id=211512
Reviewed by Simon Fraser.
Source/WebCore:
Add fake properties for wheel event listeners to RenderStyle and use them to
generate regions in EventRegion. There is a separate region for non-passive
wheel event listeners (that will require synchronous handling).
The generated regions are not used for anything in this patch.
Style is not yet invalided on event listener additions and removals.
Test: fast/scrolling/mac/wheel-event-listener-region-basic.html
- dom/Node.h:
- rendering/EventRegion.cpp:
(WebCore::EventRegion::unite):
(WebCore::EventRegion::uniteEventListeners):
(WebCore::EventRegion::dump const):
- rendering/EventRegion.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::eventListenerRegionTypes const):
(WebCore::RenderStyle::setEventListenerRegionTypes):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
- rendering/style/StyleRareInheritedData.h:
- style/StyleAdjuster.cpp:
(WebCore::Style::computeEventListenerRegionTypes):
(WebCore::Style::Adjuster::adjust const):
LayoutTests:
- fast/scrolling/mac/wheel-event-listener-region-basic-expected.txt: Added.
- fast/scrolling/mac/wheel-event-listener-region-basic.html: Added.
- 2:36 AM Changeset in webkit [261278] by
-
- 4 edits in trunk/Source/WebKit
[GTK] Build warning fixes
Rubber-stamped by Žan Doberšek.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseGrabFocus):
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::getGPUProcessConnection):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
- 2:23 AM Changeset in webkit [261277] by
-
- 13 edits in trunk/Source
Sending WebRTC network packets should not go through the main thread
https://bugs.webkit.org/show_bug.cgi?id=211291
Reviewed by Eric Carlson.
Source/WebCore:
Covered by existing tests.
- Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::filterSDP const):
Fix a case where the SDP would be badly formatted if we do not have yet a MDNS name for the corresponding IP address.
Small refactoring to use early returns.
- platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::getStaticFactoryAndThreads):
- platform/mediastream/libwebrtc/LibWebRTCProvider.h:
Add the ability for WebKit LibWebRTCProvider to do some processing on creation of the RTC threads.
Source/WebKit:
Following on receiving RTC packets from a background thread, we also send RTC packets from a background thread.
Creation of the sockets also happens in a background thread.
LibWebRTCNetwork is getting the connection whenever a new connection to network process is created.
It will then hop to the RTC network thread to set the IPC connection to the libwebrtc socket factory.
At creation of the socket, we get the IPC connection to the network process and keep a ref in the RTC socket.
In case network process crashed and the IPC connection of the RTC network is null, we hop to the main thread to create a new IPC connection.
This will fail the creation of the socket (as well as new ones as well) as long as the IPC connection to network process is not valid again.
Covered by existing tests.
- WebProcess/Network/webrtc/LibWebRTCNetwork.cpp:
(WebKit::LibWebRTCNetwork::setAsActive):
(WebKit::LibWebRTCNetwork::setConnection):
(WebKit::LibWebRTCNetwork::dispatchToThread):
- WebProcess/Network/webrtc/LibWebRTCNetwork.h:
(WebKit::LibWebRTCNetwork::connection):
(WebKit::LibWebRTCNetwork::isActive const):
- WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
(WebKit::LibWebRTCProvider::startedNetworkThread):
- WebProcess/Network/webrtc/LibWebRTCProvider.h:
- WebProcess/Network/webrtc/LibWebRTCSocket.cpp:
(WebKit::LibWebRTCSocket::SendTo):
(WebKit::LibWebRTCSocket::Close):
(WebKit::LibWebRTCSocket::SetOption):
(WebKit::LibWebRTCSocket::suspend):
- WebProcess/Network/webrtc/LibWebRTCSocket.h:
- WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:
(WebKit::LibWebRTCSocketFactory::setConnection):
(WebKit::LibWebRTCSocketFactory::connection):
(WebKit::LibWebRTCSocketFactory::createServerTcpSocket):
(WebKit::LibWebRTCSocketFactory::createUdpSocket):
(WebKit::LibWebRTCSocketFactory::createClientTcpSocket):
(WebKit::LibWebRTCSocketFactory::createNewConnectionSocket):
(WebKit::LibWebRTCSocketFactory::addSocket):
(WebKit::LibWebRTCSocketFactory::removeSocket):
(WebKit::LibWebRTCSocketFactory::forSocketInGroup):
- WebProcess/Network/webrtc/LibWebRTCSocketFactory.h:
- 2:05 AM Changeset in webkit [261276] by
-
- 2 edits in trunk/Source/WebKit
[GTK4] Stop using the GtkWidget.destroy vfunc
https://bugs.webkit.org/show_bug.cgi?id=211553
Reviewed by Carlos Garcia Campos.
No new tests needed.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDestroy): Removed.
(webkitWebViewBaseDispose): Bring in the code from the removed function, adapt
to use g_clear_pointer() to destroy the nested dialog.
(webkit_web_view_base_class_init): Do not set the GtkWidget.destroy vfunc.
- 1:40 AM Changeset in webkit [261275] by
-
- 4 edits in trunk
[WPE][Qt] Enable by default
https://bugs.webkit.org/show_bug.cgi?id=211517
Patch by Philippe Normand <pnormand@igalia.com> on 2020-05-07
Reviewed by Adrian Perez de Castro.
.:
- Source/cmake/OptionsWPE.cmake: Now that the EWS and bots use the
Flatpak SDK, Qt5 libs are available so we can enable the module
and have bots run its tests.
Source/WebKit:
- PlatformWPE.cmake: Fix WPEQt build.
- 1:33 AM Changeset in webkit [261274] by
-
- 4 edits158 adds in trunk
[Flatpak SDK] Import build definitions
https://bugs.webkit.org/show_bug.cgi?id=211448
Reviewed by Carlos Alberto Lopez Perez.
To build the SDK, run
Tools/Scripts/webkit-flatpak-sdk --build,
this can take hours and use gigabytes of your hard-drive. To build
a single recipe, use something like:
Tools/Scripts/bst-wrapper build sdk/gtk.bst
To enter the Buildstream SDK shell and debug stuff when hacking on
a specific dependency,Tools/Scripts/bst-wrapper shell sdk/gtk.bst.
To test your changes in WebKit:
`shell
$ Tools/Scripts/webkit-flatpak -u --repo=Tools/buildstream/repo
$ Tools/Scripts/run-minibrowser --gtk --flatpak-repo=Tools/buildstream/repo <url>
...
`
bst-wrapper has the same options as bst itself, documented on
https://docs.buildstream.build/1.4.2/index.html.
Internally the bst-wrapper will install Buildstream and a few
other python dependencies in a local virtualenv managed by pipenv.
This is all abstracted though, in theory direct access to the
pipenv environment shouldn't be needed.
- Scripts/bst-wrapper: Added.
- Scripts/webkit-flatpak-sdk: Added.
- buildstream/Makefile: Added.
- buildstream/Pipfile: Added.
- buildstream/Pipfile.lock: Added.
- buildstream/elements/filtered-openh264.bst: Added.
- buildstream/elements/filtered.bst: Added.
- buildstream/elements/flatpak-platform-extensions.bst: Added.
- buildstream/elements/flatpak-runtimes.bst: Added.
- buildstream/elements/flatpak/platform-arch-libs-debug.bst: Added.
- buildstream/elements/flatpak/platform-arch-libs.bst: Added.
- buildstream/elements/flatpak/platform-image.bst: Added.
- buildstream/elements/flatpak/platform-locale.bst: Added.
- buildstream/elements/flatpak/platform.bst: Added.
- buildstream/elements/flatpak/sdk-arch-libs-debug.bst: Added.
- buildstream/elements/flatpak/sdk-arch-libs.bst: Added.
- buildstream/elements/flatpak/sdk-debug.bst: Added.
- buildstream/elements/flatpak/sdk-docs.bst: Added.
- buildstream/elements/flatpak/sdk-image.bst: Added.
- buildstream/elements/flatpak/sdk-locale.bst: Added.
- buildstream/elements/flatpak/sdk.bst: Added.
- buildstream/elements/freedesktop-sdk.bst: Added.
- buildstream/elements/manifests/platform-manifest.bst: Added.
- buildstream/elements/manifests/sdk-manifest.bst: Added.
- buildstream/elements/qt5.bst: Added.
- buildstream/elements/qt5/qtbase.bst: Added.
- buildstream/elements/qt5/qtdeclarative.bst: Added.
- buildstream/elements/qt5/qtquickcontrols.bst: Added.
- buildstream/elements/qt5/qtquickcontrols2.bst: Added.
- buildstream/elements/qt5/qtwayland.bst: Added.
- buildstream/elements/qt5/qtx11extras.bst: Added.
- buildstream/elements/sdk-build-depends/libusb.bst: Added.
- buildstream/elements/sdk-build-depends/sassc.bst: Added.
- buildstream/elements/sdk-build-depends/utf8proc.bst: Added.
- buildstream/elements/sdk-depends/libsass.bst: Added.
- buildstream/elements/sdk-platform.bst: Added.
- buildstream/elements/sdk.bst: Added.
- buildstream/elements/sdk/adwaita-icon-theme.bst: Added.
- buildstream/elements/sdk/at-spi2-atk.bst: Added.
- buildstream/elements/sdk/at-spi2-core.bst: Added.
- buildstream/elements/sdk/atk.bst: Added.
- buildstream/elements/sdk/brotli.bst: Added.
- buildstream/elements/sdk/capnp.bst: Added.
- buildstream/elements/sdk/enchant-2.bst: Added.
- buildstream/elements/sdk/glib-networking.bst: Added.
- buildstream/elements/sdk/glib.bst: Added.
- buildstream/elements/sdk/gobject-introspection.bst: Added.
- buildstream/elements/sdk/graphene.bst: Added.
- buildstream/elements/sdk/graphviz.bst: Added.
- buildstream/elements/sdk/gst-libav.bst: Added.
- buildstream/elements/sdk/gst-plugins-bad.bst: Added.
- buildstream/elements/sdk/gst-plugins-base.bst: Added.
- buildstream/elements/sdk/gst-plugins-good.bst: Added.
- buildstream/elements/sdk/gst-plugins-ugly.bst: Added.
- buildstream/elements/sdk/gstreamer.bst: Added.
- buildstream/elements/sdk/gtk+-3.bst: Added.
- buildstream/elements/sdk/gtk.bst: Added.
- buildstream/elements/sdk/icecc.bst: Added.
- buildstream/elements/sdk/intltool.bst: Added.
- buildstream/elements/sdk/krb5.bst: Added.
- buildstream/elements/sdk/libcap-ng.bst: Added.
- buildstream/elements/sdk/libevent.bst: Added.
- buildstream/elements/sdk/libgcrypt.bst: Added.
- buildstream/elements/sdk/libmanette.bst: Added.
- buildstream/elements/sdk/libnotify.bst: Added.
- buildstream/elements/sdk/libopenh264.bst: Added.
- buildstream/elements/sdk/libsecret.bst: Added.
- buildstream/elements/sdk/libsoup.bst: Added.
- buildstream/elements/sdk/libsrtp2.bst: Added.
- buildstream/elements/sdk/libusrsctp.bst: Added.
- buildstream/elements/sdk/libwpe.bst: Added.
- buildstream/elements/sdk/libzstd.bst: Added.
- buildstream/elements/sdk/lzo2.bst: Added.
- buildstream/elements/sdk/openjpeg.bst: Added.
- buildstream/elements/sdk/openxr.bst: Added.
- buildstream/elements/sdk/os-release.bst: Added.
- buildstream/elements/sdk/patchelf.bst: Added.
- buildstream/elements/sdk/psmisc.bst: Added.
- buildstream/elements/sdk/pycairo.bst: Added.
- buildstream/elements/sdk/pygobject.bst: Added.
- buildstream/elements/sdk/python2-pycairo.bst: Added.
- buildstream/elements/sdk/python2-pygobject.bst: Added.
- buildstream/elements/sdk/python2-six.bst: Added.
- buildstream/elements/sdk/python2-subprocess32.bst: Added.
- buildstream/elements/sdk/python2.bst: Added.
- buildstream/elements/sdk/rr.bst: Added.
- buildstream/elements/sdk/sccache.bst: Added.
- buildstream/elements/sdk/shared-mime-info.bst: Added.
- buildstream/elements/sdk/subversion.bst: Added.
- buildstream/elements/sdk/v4lutils.bst: Added.
- buildstream/elements/sdk/woff2.bst: Added.
- buildstream/elements/sdk/wpebackend-fdo.bst: Added.
- buildstream/elements/sdk/x264.bst: Added.
- buildstream/elements/sdk/xorg-server.bst: Added.
- buildstream/elements/test-infra.bst: Added.
- buildstream/elements/test-infra/apr-util.bst: Added.
- buildstream/elements/test-infra/apr.bst: Added.
- buildstream/elements/test-infra/httpd.bst: Added.
- buildstream/elements/test-infra/perl-cgi-pm.bst: Added.
- buildstream/elements/test-infra/perl-http-date-pm.bst: Added.
- buildstream/elements/test-infra/php.bst: Added.
- buildstream/elements/test-infra/webkitgtk-test-dicts.bst: Added.
- buildstream/elements/test-infra/webkitgtk-test-fonts.bst: Added.
- buildstream/files/krb5/krb5.conf: Added.
- buildstream/files/os-release/issue.in: Added.
- buildstream/files/os-release/issue.net.in: Added.
- buildstream/files/os-release/org.webkit.Platform.appdata.xml.in: Added.
- buildstream/files/os-release/org.webkit.Sdk.appdata.xml.in: Added.
- buildstream/files/os-release/os-release.in: Added.
- buildstream/patches/fdo-0001-Update-gcc-to-9.3.0.patch: Added.
- buildstream/patches/fdo/0001-Add-Jack.patch: Added.
- buildstream/patches/fdo/0001-components-xdg-desktop-portal.bst-Update-to-1.6.0.patch: Added.
- buildstream/patches/fdo/0001-ffmpeg-Add-MS-MPEG-DivX-variants.patch: Added.
- buildstream/patches/fdo/0002-Update-PipeWire-to-0.3.1.patch: Added.
- buildstream/patches/fdo/0002-ffmpeg-Add-VP6-and-Sorenson-Spark-video-codecs.patch: Added.
- buildstream/patches/fdo/0003-Add-Bluez.patch: Added.
- buildstream/patches/fdo/0003-ffmpeg-Add-Intel-Indeo-and-Cinepak-video-support.patch: Added.
- buildstream/patches/fdo/0004-ffmpeg-Add-MPEG-2-video-decoder.patch: Added.
- buildstream/patches/fdo/0005-ffmpeg-Add-msmpeg4v3-support.patch: Added.
- buildstream/patches/gst-libav-stop-caching-codecs.patch: Added.
- buildstream/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
- buildstream/patches/gst-plugins-base-0001-glupload-Fix-fallback-from-direct-dmabuf-to-dmabuf-u.patch: Added.
- buildstream/patches/gst-plugins-base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Added.
- buildstream/patches/gst-plugins-base-0002-glupload-fix-segfault.patch: Added.
- buildstream/patches/gst-plugins-good-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Added.
- buildstream/patches/gtk-meson-Bump-to-latest-version-of-the-3.24-branch.patch: Added.
- buildstream/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
- buildstream/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Added.
- buildstream/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
- buildstream/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added.
- buildstream/patches/libsecret-b53e9876f4611525b7a8f69a3110fbec51dcede0.patch: Added.
- buildstream/patches/nettle-no-debug.diff: Added.
- buildstream/patches/qtbase-avoid-hardcoding-kernel-version.patch: Added.
- buildstream/patches/qtbase-revert-correct-handling-for-xdg-runtime-dir.patch: Added.
- buildstream/patches/qtbase-use-wayland-on-gnome.patch: Added.
- buildstream/patches/qtdeclarative-use-python3.patch: Added.
- buildstream/patches/qtwayland-use-gnome-platform-theme-on-gnome-based-desktops.patch: Added.
- buildstream/patches/sccache-no-selenium.patch: Added.
- buildstream/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
- buildstream/project.conf: Added.
- buildstream/utils/generate-version: Added.
- gtk/install-dependencies:
- wpe/install-dependencies:
- 12:49 AM Changeset in webkit [261273] by
-
- 6 edits in trunk/Source/WebCore
[WebXR] Implement simulateUserActivation()
https://bugs.webkit.org/show_bug.cgi?id=211516
Reviewed by Youenn Fablet.
simulateUserActivation() is the method used by the WebXR Test API to
mock a user activation and thus let WebXR API think that the user is
behind the request that is going to be made in the function passed as
argument.
No new tests added as the imported WebXR web-platform-tests already make
use of this API.
- testing/WebXRTest.cpp:
(WebCore::WebXRTest::simulateUserActivation): Implemented.
- testing/WebXRTest.h: Added Document parameter.
- testing/WebXRTest.idl: Call with Document.
- testing/XRSimulateUserActivationFunction.h: Removed function params.
- testing/XRSimulateUserActivationFunction.idl: Ditto.
- 12:34 AM Changeset in webkit [261272] by
-
- 3 edits in trunk/LayoutTests
[GTK][WPE] Gardening, update test expectations after r259705
https://bugs.webkit.org/show_bug.cgi?id=211552
Unreviewed gardening.
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 12:00 AM Changeset in webkit [261271] by
-
- 8 edits in trunk
Fix broken exceptionFuzz tests.
https://bugs.webkit.org/show_bug.cgi?id=211550
Reviewed by Yusuke Suzuki.
JSTests:
The tests should not be relying on setting a JSC Option at runtime because the
options are already frozen by then. Instead, we set the needed
--useExceptionFuzz=true option from the command line.
- exceptionFuzz/3d-cube.js:
- exceptionFuzz/date-format-xparb.js:
- exceptionFuzz/earley-boyer.js:
Source/JavaScriptCore:
Remove the bad and now unused utility function to set Options::useExceptionFuzz().
- tools/JSDollarVM.cpp:
(JSC::JSDollarVM::finishCreation):
(JSC::functionEnableExceptionFuzz): Deleted.
Tools:
Pass the --useExceptionFuzz=true option from the command line for runExceptionFuzz.
- Scripts/run-jsc-stress-tests:
May 6, 2020:
- 11:36 PM Changeset in webkit [261270] by
-
- 7 edits1 add in trunk/Source/WebKit
Fix webkitpy tests after r261254
https://bugs.webkit.org/show_bug.cgi?id=211112
test.messages.in was accidentally deleted instead of moved, and messages_unittest.py needed to be told of the new locations of results.
The rest is just running the generator to update results.
- Scripts/MessageNames.cpp:
(IPC::description):
(IPC::receiverName):
(IPC::isValidMessageName):
- Scripts/MessageNames.h:
- Scripts/testMessageReceiver.cpp:
(Messages::WebPage::GetPluginProcessConnection::send):
(Messages::WebPage::TestMultipleAttributes::send):
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):
- Scripts/testMessages.h:
(Messages::WebPage::messageReceiverName):
(Messages::WebPage::LoadURL::name):
(Messages::WebPage::LoadURL::LoadURL):
(Messages::WebPage::LoadURL::arguments const):
(Messages::WebPage::LoadSomething::name):
(Messages::WebPage::LoadSomething::LoadSomething):
(Messages::WebPage::LoadSomething::arguments const):
(Messages::WebPage::TouchEvent::name):
(Messages::WebPage::TouchEvent::TouchEvent):
(Messages::WebPage::TouchEvent::arguments const):
(Messages::WebPage::AddEvent::name):
(Messages::WebPage::AddEvent::AddEvent):
(Messages::WebPage::AddEvent::arguments const):
(Messages::WebPage::LoadSomethingElse::name):
(Messages::WebPage::LoadSomethingElse::LoadSomethingElse):
(Messages::WebPage::LoadSomethingElse::arguments const):
(Messages::WebPage::DidReceivePolicyDecision::name):
(Messages::WebPage::DidReceivePolicyDecision::DidReceivePolicyDecision):
(Messages::WebPage::DidReceivePolicyDecision::arguments const):
(Messages::WebPage::Close::name):
(Messages::WebPage::Close::arguments const):
(Messages::WebPage::PreferencesDidChange::name):
(Messages::WebPage::PreferencesDidChange::PreferencesDidChange):
(Messages::WebPage::PreferencesDidChange::arguments const):
(Messages::WebPage::SendDoubleAndFloat::name):
(Messages::WebPage::SendDoubleAndFloat::SendDoubleAndFloat):
(Messages::WebPage::SendDoubleAndFloat::arguments const):
(Messages::WebPage::SendInts::name):
(Messages::WebPage::SendInts::SendInts):
(Messages::WebPage::SendInts::arguments const):
(Messages::WebPage::CreatePlugin::name):
(Messages::WebPage::CreatePlugin::CreatePlugin):
(Messages::WebPage::CreatePlugin::arguments const):
(Messages::WebPage::RunJavaScriptAlert::name):
(Messages::WebPage::RunJavaScriptAlert::RunJavaScriptAlert):
(Messages::WebPage::RunJavaScriptAlert::arguments const):
(Messages::WebPage::GetPlugins::name):
(Messages::WebPage::GetPlugins::GetPlugins):
(Messages::WebPage::GetPlugins::arguments const):
(Messages::WebPage::GetPluginProcessConnection::name):
(Messages::WebPage::GetPluginProcessConnection::GetPluginProcessConnection):
(Messages::WebPage::GetPluginProcessConnection::arguments const):
(Messages::WebPage::TestMultipleAttributes::name):
(Messages::WebPage::TestMultipleAttributes::arguments const):
(Messages::WebPage::TestParameterAttributes::name):
(Messages::WebPage::TestParameterAttributes::TestParameterAttributes):
(Messages::WebPage::TestParameterAttributes::arguments const):
(Messages::WebPage::TemplateTest::name):
(Messages::WebPage::TemplateTest::TemplateTest):
(Messages::WebPage::TemplateTest::arguments const):
(Messages::WebPage::SetVideoLayerID::name):
(Messages::WebPage::SetVideoLayerID::SetVideoLayerID):
(Messages::WebPage::SetVideoLayerID::arguments const):
(Messages::WebPage::DidCreateWebProcessConnection::name):
(Messages::WebPage::DidCreateWebProcessConnection::DidCreateWebProcessConnection):
(Messages::WebPage::DidCreateWebProcessConnection::arguments const):
(Messages::WebPage::InterpretKeyEvent::name):
(Messages::WebPage::InterpretKeyEvent::InterpretKeyEvent):
(Messages::WebPage::InterpretKeyEvent::arguments const):
(Messages::WebPage::DeprecatedOperation::name):
(Messages::WebPage::DeprecatedOperation::DeprecatedOperation):
(Messages::WebPage::DeprecatedOperation::arguments const):
(Messages::WebPage::ExperimentalOperation::name):
(Messages::WebPage::ExperimentalOperation::ExperimentalOperation):
(Messages::WebPage::ExperimentalOperation::arguments const):
(Messages::None::messageReceiverName): Deleted.
- Scripts/testMessagesReplies.h:
- Scripts/webkit/messages_unittest.py:
- Scripts/webkit/test.messages.in: Added.
- 11:18 PM Changeset in webkit [261269] by
-
- 3 edits in trunk/Source/WebKit
Context Menus presented from the wrong location when presented from sub-frames
https://bugs.webkit.org/show_bug.cgi?id=211537
<rdar://problem/60390846>
Reviewed by Tim Horton.
The calculation for bounds for selection Information did not take frames into account,
so if a frame was used, the location would not be correct in the context of the whole
page, so the presentation location ended up being way off.
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel showDocumentPickerMenu]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::boundsPositionInformation):
(WebKit::selectionPositionInformation):
- 10:37 PM Changeset in webkit [261268] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, reverting r260737.
Change not needed after r261267.
Reverted changeset:
"[GTK] Gardening, skipping more inspector tests."
https://trac.webkit.org/changeset/260737
- 10:34 PM Changeset in webkit [261267] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, reverting r260713.
Change not needed after r260844.
Reverted changeset:
"[GTK] Gardening, temporarily skip WebInspector tests after
r210942 and r260696"
https://bugs.webkit.org/show_bug.cgi?id=211035
https://trac.webkit.org/changeset/260713
- 10:12 PM Changeset in webkit [261266] by
-
- 5 edits in trunk/LayoutTests
[GTK] Gardening, dump stderr in console log for several web-animation tests
https://bugs.webkit.org/show_bug.cgi?id=211549
Unreviewed gardening.
- platform/gtk/TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- 10:08 PM Changeset in webkit [261265] by
-
- 2 edits in trunk/WebDriverTests
[WebDriver] gardening flaky test.
Unreviewed test gardening.
- TestExpectations.json:
- 8:40 PM Changeset in webkit [261264] by
-
- 5 edits2 adds in trunk/Source
[Win] Implement DisplayRefreshMonitor by using RunLoop::Timer
https://bugs.webkit.org/show_bug.cgi?id=211431
Reviewed by Don Olmstead.
Source/WebCore:
- PlatformWin.cmake:
- platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::createDefaultDisplayRefreshMonitor):
- platform/graphics/win/DisplayRefreshMonitorWin.cpp: Added.
(WebCore::DisplayRefreshMonitorWin::create):
(WebCore::DisplayRefreshMonitorWin::DisplayRefreshMonitorWin):
(WebCore::DisplayRefreshMonitorWin::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorWin::displayLinkFired):
- platform/graphics/win/DisplayRefreshMonitorWin.h: Added.
Source/WTF:
USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR is turned off only for Windows ports.
Turn it on, and add DisplayRefreshMonitorWin.
I'll remove USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR macro in a follow-up patch.
- wtf/PlatformUse.h:
- 7:13 PM Changeset in webkit [261263] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, reverting r260689.
https://bugs.webkit.org/show_bug.cgi?id=211542
"Caused regressions deleting text and filling password fields"
(Requested by ddkilzer on #webkit).
Reverted changeset:
"WebPasteboardProxy::getPasteboardStringsForType() and
WebPasteboardProxy::readURLFromPasteboard() should check
return value of SharedMemory::createHandle()"
https://bugs.webkit.org/show_bug.cgi?id=211002
https://trac.webkit.org/changeset/260689
- 5:27 PM Changeset in webkit [261262] by
-
- 539 edits19 adds160 deletes in trunk/Source/ThirdParty/ANGLE
Update ANGLE to 2020-03-27
https://bugs.webkit.org/show_bug.cgi?id=209689
Reverting r259589. It caused
https://bugs.webkit.org/show_bug.cgi?id=210992
- 5:18 PM Changeset in webkit [261261] by
-
- 7 edits in trunk/Source
[ContentObservation] Shutterstock search bar is not activated on the first tap
https://bugs.webkit.org/show_bug.cgi?id=211529
<rdar://problem/58843932>
Reviewed by Simon Fraser.
Source/WebCore:
- page/Quirks.cpp:
(WebCore::Quirks::shouldIgnoreContentObservationForSyntheticClick const):
- page/Quirks.h:
Source/WebKit:
Shutterstock has a “initial click” action which converts some “actionable” elements (<a>) to some other “actionable” elements (<button>).
If this initial click also happens to be on an element that triggers content observation (input), we see those changes as actionable content and not proceed with the click event (stay at hover).
Any subsequent click works as expected.
It’s very difficult to eliminate such false positives since all we see is that some "actionable" content is going away while some "actionable" content is being created.
This quirk ensures that the first tap on the page does not trigger content observation. (It also means that any hover menu gets submitted on the first tap, but apparently
the Shutterstock top menu bar works fine with click events.)
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didStartPageTransition):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleSyntheticClick):
- 5:00 PM Changeset in webkit [261260] by
-
- 5 edits in trunk
DFG ByVal nodes with ArrayModes should clobberTop until Fixup phase runs.
https://bugs.webkit.org/show_bug.cgi?id=211531
Reviewed by Yusuke Suzuki.
JSTests:
- stress/for-of-get-by-val-marks-clobbers-exit-state.js: Added.
(foo):
- stress/put-by-val-correctly-clobbers-exit-state-when-misprofiling-index.js: Added.
(let.foo.vm.createBuiltin):
Source/JavaScriptCore:
When parsing bytecode we may pick a relatively constrained
ArrayMode based on our profiling. Some of these modes may not
clobber exit state. However, Fixup sometimes wants to widen this
to a more generic mode based on other data. This causes us to
think it was valid to exit immediately after the
GetByVal/HasIndexedProperty, which would be wrong with the wider
ArrayMode. We may also incorrectly insert invalidition points
if clobberize gives us the wrong data.
To fix this clobberize should say All ByVal nodes clobberTop()
until after fixup. Additionally, this patch adds an assertion that
nodes don't go from not clobbering exit state to clobbering exit
state during fixup.
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::performFixup):
- dfg/DFGGraph.h:
- 4:50 PM Changeset in webkit [261259] by
-
- 11 edits1 copy in trunk/Source/WebKit
Use CocoaColor in more places instead of platform defines
https://bugs.webkit.org/show_bug.cgi?id=211527
Reviewed by Darin Adler and Tim Horton.
Use CocoaColor (added in r261247) in more places, and also introduce
CocoaFont.hand use it to simplify some
existing code that uses platform ifdefs for UIFont, NSFont, UIFontDescriptor and NSFontDescriptor.
No change in behavior.
- Platform/cocoa/CocoaColor.h:
- Platform/cocoa/CocoaFont.h: Copied from Source/WebKit/Platform/cocoa/CocoaColor.h.
- Platform/cocoa/CocoaImage.h:
Change
@classes toOBJC_CLASS, so that this header can be safely imported in C++ code.
- Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::typeFromObject):
(IPC::isSerializableValue):
(IPC::encodeFontInternal):
(IPC::encodeObject):
(IPC::platformColorClass): Deleted.
(IPC::platformFontClass): Deleted.
- Shared/Cocoa/CoreTextHelpers.h:
- Shared/Cocoa/CoreTextHelpers.mm:
(WebKit::fontWithAttributes):
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
- UIProcess/Cocoa/WKSafeBrowsingWarning.h:
- UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
(fontOfSize):
(colorForItem):
(-[WKSafeBrowsingBox setSafeBrowsingBackgroundColor:]):
(-[WKSafeBrowsingWarning showDetailsClicked]):
(-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::updateFontManagerIfNeeded):
- WebKit.xcodeproj/project.pbxproj:
- 4:16 PM Changeset in webkit [261258] by
-
- 3 edits2 adds in trunk
Nullptr crash in indentOutdentCommand::formatRange with asynchronous commands: indent and insert list.
https://bugs.webkit.org/show_bug.cgi?id=211466
<rdar://problem/62845430>
Reviewed by Geoffrey Garen.
Source/WebCore:
Check for null outerBlock returned by splitTreeToNode and bail out.
Test: fast/editing/indent-then-insertUL-crash.html
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::indentIntoBlockquote):
LayoutTests:
Added a regression test for the crash.
- fast/editing/indent-then-insertUL-crash-expected.txt: Added.
- fast/editing/indent-then-insertUL-crash.html: Added.
- 4:01 PM Changeset in webkit [261257] by
-
- 11 edits in trunk/Source
Make a helper for the pattern of ICU functions that may need to be called twice to populate a buffer
https://bugs.webkit.org/show_bug.cgi?id=211499
Reviewed by Ross Kirsling.
Source/JavaScriptCore:
- runtime/IntlDateTimeFormat.cpp:
(JSC::defaultTimeZone): Use callBufferProducingFunction.
(JSC::canonicalizeTimeZoneName): Ditto.
(JSC::IntlDateTimeFormat::initializeDateTimeFormat): Ditto.
(JSC::IntlDateTimeFormat::format const): Ditto.
(JSC::IntlDateTimeFormat::formatToParts const): Ditto.
- runtime/IntlLocale.cpp:
(JSC::LocaleIDBuilder::toCanonical): Ditto.
(JSC::IntlLocale::language): Ditto.
(JSC::IntlLocale::script): Ditto.
(JSC::IntlLocale::region): Ditto.
- runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::format const): Ditto.
(JSC::IntlNumberFormat::formatToParts const): Ditto.
- runtime/IntlObject.cpp:
(JSC::languageTagForLocaleID): Ditto.
- runtime/IntlRelativeTimeFormat.cpp:
(JSC::IntlRelativeTimeFormat::formatInternal const): Ditto.
(JSC::IntlRelativeTimeFormat::formatToParts const): Ditto.
- runtime/StringPrototype.cpp:
(JSC::toLocaleCase): Ditto.
Source/WebCore:
- editing/TextIterator.cpp:
(WebCore::normalizeCharacters): Use callBufferProducingFunction.
Source/WTF:
This first cut version is ready to be used in most, but not all, of the places we use the
needsToGrowToProduceBuffer function. The places it is not right for yet are ones that have
special considerations because of null character termination or destinations that are
not a Vector. Later we can refine that further, if we like, and possibly use something
similar in call sites that use needsToGrowToProduceCString as well.
- wtf/unicode/icu/ICUHelpers.h:
(WTF::needsToGrowToProduceBuffer): Changed to constexpr, since we can.
(WTF::needsToGrowToProduceCString): Ditto.
(WTF::CallBufferProducingFunction::findVector): Added. Implementation detail
of callBufferProducingFunction.
(WTF::CallBufferProducingFunction::argumentTuple): Ditto.
(WTF::callBufferProducingFunction): Added.
- 3:56 PM Changeset in webkit [261256] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION (r261056): [ Mac WK1 ] inspector/console/console-api.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=211386
Reviewed by Tim Horton.
This bug was caused by the failure to clear the delegate on an NSScrollerImp when, for testing,
we flip between the native scrollbar theme, and the mock scrollbar theme.
The crux of the fix is to have ScrollAnimatorMac's scrollerImpForScrollbar() call a
static function on ScrollbarThemeMac to get the painters, rather than going through
the possibly-null ScrollbarThemeMac instance.
A belt-and-braces fix in ScrollbarThemeMac::unregisterScrollbar() always clears the delegate
on the NSScrollerImp when unregistering a scrollbar.
Finally, modernize code in various places.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::scrollerImpForScrollbar):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::scrollbarMap):
(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::paint):
- 3:55 PM Changeset in webkit [261255] by
-
- 3 edits2 adds in trunk
Nullptr crash in InsertListCommand::doApply with user-select:none elements
https://bugs.webkit.org/show_bug.cgi?id=211534
<rdar://problem/62898521>
Reviewed by Geoffrey Garen.
Source/WebCore:
Check for empty position in InsertListCommand::doApply when searching for the start of
last paragraph in the selected range. Skip listifying individual paragraphs in the range.
Test: editing/inserting/insert-list-user-select-none-crash.html
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
LayoutTests:
Added a regression test for the crash.
- editing/inserting/insert-list-user-select-none-crash-expected.txt: Added.
- editing/inserting/insert-list-user-select-none-crash.html: Added.
- 3:54 PM Changeset in webkit [261254] by
-
- 65 edits2 copies9 moves2 adds3 deletes in trunk/Source
Reduce IPC overhead for message receiver name and message name to 2 bytes
https://bugs.webkit.org/show_bug.cgi?id=211112
Patch by Alex Christensen <achristensen@webkit.org> on 2020-05-06
Reviewed by Chris Dumez.
Source/WebKit:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::didReceiveInvalidMessage):
- GPUProcess/GPUConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveInvalidMessage):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didReceiveMessage):
(WebKit::NetworkProcess::didReceiveSyncMessage):
- NetworkProcess/ios/NetworkConnectionToWebProcessIOS.mm:
(WebKit::NetworkConnectionToWebProcess::paymentCoordinatorAddMessageReceiver): Deleted.
(WebKit::NetworkConnectionToWebProcess::paymentCoordinatorRemoveMessageReceiver): Deleted.
- Platform/IPC/Connection.cpp:
(IPC::Connection::WaitForMessageState::WaitForMessageState):
(IPC::Connection::addWorkQueueMessageReceiver):
(IPC::Connection::removeWorkQueueMessageReceiver):
(IPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(IPC::Connection::addThreadMessageReceiver):
(IPC::Connection::removeThreadMessageReceiver):
(IPC::Connection::dispatchThreadMessageReceiverMessage):
(IPC::Connection::createSyncMessageEncoder):
(IPC::Connection::sendMessage):
(IPC::Connection::waitForMessage):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::waitForSyncReply):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::dispatchSyncMessage):
(IPC::Connection::dispatchDidReceiveInvalidMessage):
(IPC::Connection::dispatchMessage):
(IPC::Connection::dispatchMessageToWorkQueueReceiver):
(IPC::Connection::dispatchMessageToThreadReceiver):
(IPC::Connection::dispatchIncomingMessages):
- Platform/IPC/Connection.h:
(IPC::Connection::send):
(IPC::Connection::sendWithAsyncReply):
(IPC::Connection::sendSync):
(IPC::Connection::waitForAndDispatchImmediately):
- Platform/IPC/Decoder.cpp:
- Platform/IPC/Decoder.h:
(IPC::Decoder::messageReceiverName const):
(IPC::Decoder::messageName const):
(IPC::Decoder::decode):
(IPC::Decoder::operator>>):
- Platform/IPC/Encoder.cpp:
(IPC::Encoder::Encoder):
(IPC::Encoder::encodeHeader):
- Platform/IPC/Encoder.h:
- Platform/IPC/HandleMessage.h:
(IPC::handleMessageAsync):
- Platform/IPC/MessageReceiverMap.cpp:
(IPC::MessageReceiverMap::addMessageReceiver):
(IPC::MessageReceiverMap::removeMessageReceiver):
(IPC::MessageReceiverMap::dispatchMessage):
(IPC::MessageReceiverMap::dispatchSyncMessage):
- Platform/IPC/MessageReceiverMap.h:
- Platform/IPC/MessageSender.h:
- Platform/IPC/cocoa/ConnectionCocoa.mm:
(IPC::Connection::open):
(IPC::Connection::sendMessage):
(IPC::Connection::sendOutgoingMessage):
(IPC::Connection::receiveSourceEventHandler):
- Platform/IPC/cocoa/MachMessage.cpp:
(IPC::MachMessage::create):
(IPC::MachMessage::MachMessage):
- Platform/IPC/cocoa/MachMessage.h:
(IPC::MachMessage::messageReceiverName const):
(IPC::MachMessage::messageName const):
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveInvalidMessage):
- PluginProcess/WebProcessConnection.h:
- Scripts/Makefile:
- Scripts/generate-message-receiver.py:
(main):
- Scripts/webkit/LegacyMessages-expected.h: Removed.
- Scripts/webkit/LegacyMessagesReplies-expected.h: Removed.
- Scripts/webkit/MessageNames.cpp: Added.
(IPC::description):
- Scripts/webkit/MessageNames.h: Added.
(IPC::receiverName):
(WTF::isValidEnum):
- Scripts/webkit/MessageReceiver-expected.cpp: Removed.
- Scripts/webkit/MessageReceiverSuperclass-expected.cpp: Removed.
- Scripts/webkit/Messages-expected.h: Removed.
- Scripts/webkit/MessagesReplies-expected.h: Removed.
- Scripts/webkit/MessagesRepliesSuperclassReplies-expected.h: Removed.
- Scripts/webkit/MessagesSuperclass-expected.h: Removed.
- Scripts/webkit/messages.py:
- Scripts/webkit/test-legacy-messages.in: Removed.
- Scripts/webkit/test-legacy.messages.in: Copied from Source/WebKit/Scripts/webkit/test-legacy-messages.in.
- Scripts/webkit/test-legacyMessageReceiver.cpp: Added.
(Messages::WebPage::GetPluginProcessConnection::send):
(Messages::WebPage::TestMultipleAttributes::send):
(WebKit::WebPage::didReceiveWebPageMessage):
(WebKit::WebPage::didReceiveSyncWebPageMessage):
- Scripts/webkit/test-legacyMessages.h: Added.
(Messages::WebPage::messageReceiverName):
(Messages::WebPage::LoadURL::name):
(Messages::WebPage::LoadURL::LoadURL):
(Messages::WebPage::LoadURL::arguments const):
(Messages::WebPage::LoadSomething::name):
(Messages::WebPage::LoadSomething::LoadSomething):
(Messages::WebPage::LoadSomething::arguments const):
(Messages::WebPage::TouchEvent::name):
(Messages::WebPage::TouchEvent::TouchEvent):
(Messages::WebPage::TouchEvent::arguments const):
(Messages::WebPage::AddEvent::name):
(Messages::WebPage::AddEvent::AddEvent):
(Messages::WebPage::AddEvent::arguments const):
(Messages::WebPage::LoadSomethingElse::name):
(Messages::WebPage::LoadSomethingElse::LoadSomethingElse):
(Messages::WebPage::LoadSomethingElse::arguments const):
(Messages::WebPage::DidReceivePolicyDecision::name):
(Messages::WebPage::DidReceivePolicyDecision::DidReceivePolicyDecision):
(Messages::WebPage::DidReceivePolicyDecision::arguments const):
(Messages::WebPage::Close::name):
(Messages::WebPage::Close::arguments const):
(Messages::WebPage::PreferencesDidChange::name):
(Messages::WebPage::PreferencesDidChange::PreferencesDidChange):
(Messages::WebPage::PreferencesDidChange::arguments const):
(Messages::WebPage::SendDoubleAndFloat::name):
(Messages::WebPage::SendDoubleAndFloat::SendDoubleAndFloat):
(Messages::WebPage::SendDoubleAndFloat::arguments const):
(Messages::WebPage::SendInts::name):
(Messages::WebPage::SendInts::SendInts):
(Messages::WebPage::SendInts::arguments const):
(Messages::WebPage::CreatePlugin::name):
(Messages::WebPage::CreatePlugin::CreatePlugin):
(Messages::WebPage::CreatePlugin::arguments const):
(Messages::WebPage::RunJavaScriptAlert::name):
(Messages::WebPage::RunJavaScriptAlert::RunJavaScriptAlert):
(Messages::WebPage::RunJavaScriptAlert::arguments const):
(Messages::WebPage::GetPlugins::name):
(Messages::WebPage::GetPlugins::GetPlugins):
(Messages::WebPage::GetPlugins::arguments const):
(Messages::WebPage::GetPluginProcessConnection::name):
(Messages::WebPage::GetPluginProcessConnection::GetPluginProcessConnection):
(Messages::WebPage::GetPluginProcessConnection::arguments const):
(Messages::WebPage::TestMultipleAttributes::name):
(Messages::WebPage::TestMultipleAttributes::arguments const):
(Messages::WebPage::TestParameterAttributes::name):
(Messages::WebPage::TestParameterAttributes::TestParameterAttributes):
(Messages::WebPage::TestParameterAttributes::arguments const):
(Messages::WebPage::TemplateTest::name):
(Messages::WebPage::TemplateTest::TemplateTest):
(Messages::WebPage::TemplateTest::arguments const):
(Messages::WebPage::SetVideoLayerID::name):
(Messages::WebPage::SetVideoLayerID::SetVideoLayerID):
(Messages::WebPage::SetVideoLayerID::arguments const):
(Messages::WebPage::DidCreateWebProcessConnection::name):
(Messages::WebPage::DidCreateWebProcessConnection::DidCreateWebProcessConnection):
(Messages::WebPage::DidCreateWebProcessConnection::arguments const):
(Messages::WebPage::InterpretKeyEvent::name):
(Messages::WebPage::InterpretKeyEvent::InterpretKeyEvent):
(Messages::WebPage::InterpretKeyEvent::arguments const):
(Messages::WebPage::DeprecatedOperation::name):
(Messages::WebPage::DeprecatedOperation::DeprecatedOperation):
(Messages::WebPage::DeprecatedOperation::arguments const):
(Messages::WebPage::ExperimentalOperation::name):
(Messages::WebPage::ExperimentalOperation::ExperimentalOperation):
(Messages::WebPage::ExperimentalOperation::arguments const):
- Scripts/webkit/test-legacyMessagesReplies.h: Added.
- Scripts/webkit/test-messages.in: Removed.
- Scripts/webkit/test-superclass-messages.in: Removed.
- Scripts/webkit/test-superclass.messages.in: Copied from Source/WebKit/Scripts/webkit/test-superclass-messages.in.
- Scripts/webkit/test-superclassMessageReceiver.cpp: Added.
(Messages::WebPage::TestAsyncMessage::callReply):
(Messages::WebPage::TestAsyncMessage::cancelReply):
(Messages::WebPage::TestAsyncMessage::send):
(Messages::WebPage::TestAsyncMessageWithNoArguments::callReply):
(Messages::WebPage::TestAsyncMessageWithNoArguments::cancelReply):
(Messages::WebPage::TestAsyncMessageWithNoArguments::send):
(Messages::WebPage::TestAsyncMessageWithMultipleArguments::callReply):
(Messages::WebPage::TestAsyncMessageWithMultipleArguments::cancelReply):
(Messages::WebPage::TestAsyncMessageWithMultipleArguments::send):
(Messages::WebPage::TestSyncMessage::send):
(Messages::WebPage::TestSynchronousMessage::send):
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):
- Scripts/webkit/test-superclassMessages.h: Added.
(Messages::WebPage::messageReceiverName):
(Messages::WebPage::LoadURL::name):
(Messages::WebPage::LoadURL::LoadURL):
(Messages::WebPage::LoadURL::arguments const):
(Messages::WebPage::TestAsyncMessage::name):
(Messages::WebPage::TestAsyncMessage::asyncMessageReplyName):
(Messages::WebPage::TestAsyncMessage::TestAsyncMessage):
(Messages::WebPage::TestAsyncMessage::arguments const):
(Messages::WebPage::TestAsyncMessageWithNoArguments::name):
(Messages::WebPage::TestAsyncMessageWithNoArguments::asyncMessageReplyName):
(Messages::WebPage::TestAsyncMessageWithNoArguments::arguments const):
(Messages::WebPage::TestAsyncMessageWithMultipleArguments::name):
(Messages::WebPage::TestAsyncMessageWithMultipleArguments::asyncMessageReplyName):
(Messages::WebPage::TestAsyncMessageWithMultipleArguments::arguments const):
(Messages::WebPage::TestSyncMessage::name):
(Messages::WebPage::TestSyncMessage::TestSyncMessage):
(Messages::WebPage::TestSyncMessage::arguments const):
(Messages::WebPage::TestSynchronousMessage::name):
(Messages::WebPage::TestSynchronousMessage::TestSynchronousMessage):
(Messages::WebPage::TestSynchronousMessage::arguments const):
- Scripts/webkit/test-superclassMessagesReplies.h: Added.
- Scripts/webkit/test.messages.in: Added.
- Scripts/webkit/testMessageReceiver.cpp: Added.
- Scripts/webkit/testMessages.h: Added.
(Messages::None::messageReceiverName):
- Scripts/webkit/testMessagesReplies.h: Added.
- Shared/ApplePay/WebPaymentCoordinatorProxy.h:
- Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::WebPaymentCoordinatorProxy):
(WebKit::WebPaymentCoordinatorProxy::~WebPaymentCoordinatorProxy):
- Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::addMessageReceiver):
(WebKit::AuxiliaryProcess::removeMessageReceiver):
(WebKit::AuxiliaryProcess::didReceiveInvalidMessage):
- Shared/AuxiliaryProcess.h:
(WebKit::AuxiliaryProcess::addMessageReceiver):
(WebKit::AuxiliaryProcess::removeMessageReceiver):
- Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::didReceiveInvalidMessage):
- SourcesCocoa.txt:
- UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::addMessageReceiver):
(WebKit::AuxiliaryProcessProxy::removeMessageReceiver):
(WebKit::AuxiliaryProcessProxy::logInvalidMessage):
- UIProcess/AuxiliaryProcessProxy.h:
(WebKit::AuxiliaryProcessProxy::addMessageReceiver):
(WebKit::AuxiliaryProcessProxy::removeMessageReceiver):
(WebKit::AuxiliaryProcessProxy::send):
(WebKit::AuxiliaryProcessProxy::sendWithAsyncReply):
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::paymentCoordinatorAddMessageReceiver): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorRemoveMessageReceiver): Deleted.
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::didReceiveInvalidMessage):
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveInvalidMessage):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didReceiveInvalidMessage):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::didReceiveMessage):
- UIProcess/SuspendedPageProxy.cpp:
(WebKit::messageNamesToIgnoreWhileSuspended):
(WebKit::SuspendedPageProxy::didReceiveMessage):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::didReceiveInvalidMessage):
(WebKit::WebProcessPool::addMessageReceiver):
(WebKit::WebProcessPool::removeMessageReceiver):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::shouldSendPendingMessage):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
- UIProcess/WebProcessProxy.h:
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::didReceiveInvalidMessage):
- WebProcess/GPU/GPUProcessConnection.h:
- WebProcess/Inspector/WebInspector.h:
- WebProcess/Inspector/WebInspectorUI.h:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveInvalidMessage):
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveInvalidMessage):
- WebProcess/Plugins/PluginProcessConnection.h:
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
Source/WTF:
- wtf/EnumTraits.h:
- 3:43 PM Changeset in webkit [261253] by
-
- 13 edits2 deletes in trunk
Unreviewed, reverting r261239.
Caused fast/events/wheel-event-outside-body.html to assert on
macOS WK1
Reverted changeset:
"Add basic support for generating accurate wheel event
listener region"
https://bugs.webkit.org/show_bug.cgi?id=211512
https://trac.webkit.org/changeset/261239
- 3:05 PM Changeset in webkit [261252] by
-
- 11 edits in trunk/Source
REGRESSION (r260684): Reader background is lost after multitasking
https://bugs.webkit.org/show_bug.cgi?id=211533
<rdar://problem/62941837>
Unreviewed, revert r260684 due to regression.
Source/WebCore:
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
- page/FrameView.cpp:
(WebCore::FrameView::sendResizeEventIfNeeded):
- page/Page.h:
(WebCore::Page::shouldFireResizeEvents const):
(WebCore::Page::setShouldFireResizeEvents):
Source/WebKit:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setShouldFireResizeEvents):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKApplicationStateTrackingView.mm:
(-[WKApplicationStateTrackingView _willBeginSnapshotSequence]):
(-[WKApplicationStateTrackingView _didCompleteSnapshotSequence]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setShouldFireResizeEvents):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 2:54 PM Changeset in webkit [261251] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test for
REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange
https://bugs.webkit.org/show_bug.cgi?id=211532
Reviewed by Wenson Hsieh.
- fast/text-indicator/text-indicator-estimated-color-with-implicit-newline-expected.txt: Added.
- fast/text-indicator/text-indicator-estimated-color-with-implicit-newline.html: Added.
This test would trigger the null deref fixed in r261245.
- 1:59 PM Changeset in webkit [261250] by
-
- 5 edits3 adds in trunk
ResourceLoadStatistics data summary call should create a web process pool if one doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=211520
<rdar://problem/59869619>
Reviewed by Chris Dumez.
Source/WebKit:
Ensures that a process pool and network process exist when requesting
resource load statistics data.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):
Tools:
Added API test coverage.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
Removed stray comment from previous test.
(TEST):
- TestWebKitAPI/basicITPDatabase.db: Added.
- TestWebKitAPI/basicITPDatabase.db-shm: Added.
- TestWebKitAPI/basicITPDatabase.db-wal: Added.
New database resource with 2 entries: apple.com and webkit.org, with
webkit.org registered as a subframe of apple.com
- 1:35 PM Changeset in webkit [261249] by
-
- 3 edits in trunk/Source/WebKit
Better surfacing of the presenting parent PID in the Network process
https://bugs.webkit.org/show_bug.cgi?id=211495
<rdar://problem/62917205>
Reviewed by Youenn Fablet.
In Bug 205295, NetworkResourceLoader logging was improved, with one of
the changes being that the PID of parent process that invoked the
Network process was logged at the start of
NetworkResourceLoader::start(). However, there was an execution path
that skipped calling start()
(NetworkConnectionToWebProcess::scheduleResourceLoad ->
NetworkResourceLoader::startWithServiceWorker ->
serviceWorkerDidNotHandle -> restartNetworkLoad -> startNetworkLoad),
and so the the logging would not show the parent PID. This logging is
needed for diagnostic purposes, so tweak the logging a little bit more
in order to ensure we emit it. In this change, logging is added to
various loading-related NetworkConnectionToWebProcess entry points
(not just scheduleResourceLoad) in order to (a) ensure we emit the
logging we want and (b) to give a clearer picture of what operations
are being invoked in the Network process.
No new tests -- no new or changed functionality.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::hasUploadStateChanged):
(WebKit::NetworkConnectionToWebProcess::resolveBlobReferences):
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad):
(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::preconnectTo):
(WebKit::NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::start):
- 1:11 PM Changeset in webkit [261248] by
-
- 16 edits1 add in trunk
AX: Implement accessibility of HTML 5.1 Drag & Drop
https://bugs.webkit.org/show_bug.cgi?id=211415
<rdar://problem/22695531>
Reviewed by Joanmarie Diggs.
Source/WebCore:
Support HTML5 drag and drop. Support dropzone attribute.
Add new notifications for VoiceOver to consume.
It appears that most of the dragging tests are skipped because of eventSender issues.
I think this test could do a little more if those issues were resolved. Specifically, not all
the notifications are seen that are expected.
Test: accessibility/mac/draggable.html
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIAAttributes const):
(WebCore::AccessibilityObject::isAXHidden const):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::supportsDropping const):
(WebCore::AccessibilityRenderObject::supportsDragging const):
(WebCore::AccessibilityRenderObject::isGrabbed):
(WebCore::AccessibilityRenderObject::determineDropEffects):
(WebCore::AccessibilityRenderObject::supportsARIADropping const): Deleted.
(WebCore::AccessibilityRenderObject::supportsARIADragging const): Deleted.
(WebCore::AccessibilityRenderObject::isARIAGrabbed): Deleted.
(WebCore::AccessibilityRenderObject::determineARIADropEffects): Deleted.
- accessibility/AccessibilityRenderObject.h:
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- html/HTMLAttributeNames.in:
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::draggingElement const):
- page/EventHandler.h:
LayoutTests:
- accessibility/mac/draggable-expected.txt: Added.
- accessibility/mac/draggable.html: Added.
- 1:02 PM Changeset in webkit [261247] by
-
- 11 edits1 add in trunk
Cut and paste from Google Doc to Notes in several (non-Latin) languages doesn't work
https://bugs.webkit.org/show_bug.cgi?id=211498
<rdar://problem/56675345>
Reviewed by Darin Adler.
Source/WebCore:
When copying text in Google Docs, the page uses
DataTransfer.setDatato write text/html data to the system
pasteboard. This markup string includes a meta tag withcharset="utf-8", indicating that the HTML string that
was copied should be interpreted as UTF-8 data.
However, before we write this data to the system pasteboard, we first sanitize it by loading it in a separate
page, and then build the final sanitized markup string to write by iterating over only visible content in the
main document of this page. Importantly, this last step skips over the meta element containing the charset.
Later, when pasting in Notes or TextEdit, both apps use
-[NSAttributedString initWithData:...:]to convert the
HTML data on the pasteboard into an NSAttributedString. This takes the NSPasteboard's HTML data (a blob of
NSData) and synchronously loads it in a new legacy WebKit view by calling `-[WebFrame
loadData:MIMEType:textEncodingName:baseURL:], passing innil` as the text encoding name. Since WebKit is only
given a blob of data and no particular encoding, we fall back to default Latin-1 encoding, which produces
gibberish for CJK text.
To fix this, we automatically insert a
<meta charset="utf-8">tag when writing HTML to the pasteboard, if the
sanitized markup contains non-ASCII characters.
Test: CopyHTML.SanitizationPreservesCharacterSet
- Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
(WebCore::ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::sanitizeDataIfNeeded):
Pass in AddMetaCharsetIfNeeded::Yes.
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::setDataFromItemList):
Pass in AddMetaCharsetIfNeeded::Yes here too.
- editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::sanitizeMarkupWithArchive):
(WebCore::WebContentReader::readHTML):
(WebCore::WebContentMarkupReader::readHTML):
- editing/markup.cpp:
(WebCore::sanitizeMarkup):
Add a new enum so that we only add the extra meta tag when sanitizing content that is being written to the
system pasteboard through one of the clipboard DOM APIs.
(WebCore::sanitizedMarkupForFragmentInDocument):
- editing/markup.h:
Source/WebKit:
Add a new header to allow Cocoa code to reason about UIColors and NSColors on iOS and macOS (respectively)
without requiring platform ifdefs. A followup patch will adopt this in several places in WebKit, where we
currently need ifdefs for iOS and macOS.
- Platform/cocoa/CocoaColor.h: Added.
- WebKit.xcodeproj/project.pbxproj:
Tools:
Add a test to verify that when writing markup to the clipboard via DOM API, if non-ASCII characters appear in
the written markup, they can still be converted toNSAttributedStrings containing the expected non-Latin text.
- TestWebKitAPI/Configurations/Base.xcconfig:
Adjust header search paths so that we can import CocoaColor.h in WebKit.
- TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
(readHTMLDataFromPasteboard):
(readHTMLStringFromPasteboard):
(readHTMLFromPasteboard): Deleted.
- 12:57 PM Changeset in webkit [261246] by
-
- 4 edits2 adds in trunk
pointermove event sometimes has incorrect pointerType of 'mouse' on touch interactions
https://bugs.webkit.org/show_bug.cgi?id=210716
<rdar://problem/62084817>
Patch by Antoine Quint <Antoine Quint> on 2020-05-06
Reviewed by Darin Adler.
Source/WebKit:
Set the SyntheticClickType to OneFingerTap when creating a synthetic "mousemove" event for a synthetic "click" event as part of a tap.
On top of being more indicative of the actual action that triggered the synthetic event, it also has the added quality that it will
not yield a "pointermove" event.
Test: pointerevents/ios/click-no-pointermove.html
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::dispatchSyntheticMouseMove):
LayoutTests:
Add a new test that checks that with content observation enabled a tap on a <button> element
dispatches synthetic mousemove and click events but no pointermove event.
- pointerevents/ios/click-no-pointermove-expected.txt: Added.
- pointerevents/ios/click-no-pointermove.html: Added.
- pointerevents/utils.js:
(target_test):
- 12:36 PM Changeset in webkit [261245] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange
https://bugs.webkit.org/show_bug.cgi?id=211523
<rdar://problem/62860203>
Reviewed by Darin Adler.
- page/TextIndicator.cpp:
(WebCore::estimatedTextColorsForRange):
TextIterator's node() getter can return null. r260753 accidentally refactored away the null check.
- 12:09 PM Changeset in webkit [261244] by
-
- 2 edits in trunk/LayoutTests
Two 'tests' are running with out expectation files that are not real tests.
https://bugs.webkit.org/show_bug.cgi?id=208477
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: Skip the test that seems to create these files.
- 12:09 PM Changeset in webkit [261243] by
-
- 2 edits in trunk/Tools
REGRESSION (r260278): TestWebKitAPI.Fullscreen.Delegate is timing out on macOS bots
https://bugs.webkit.org/show_bug.cgi?id=210676
Unreviewed test gardening.
- TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm:
(TestWebKitAPI::TEST): Skip the test to get the bots to green.
- 11:44 AM Changeset in webkit [261242] by
-
- 38 edits7 adds in trunk
Exempt app-bound domains from ITP's website data deletion and third-party cookie blocking between themselves
https://bugs.webkit.org/show_bug.cgi?id=210674
<rdar://problem/61950767>
Reviewed by Chris Dumez.
Source/WebCore:
This change adds functionality to NetworkStorageSession to allow it to exempt
app-bound domains from third-party cookie blocking.
Tests: http/tests/resourceLoadStatistics/exemptDomains/app-bound-domains-exempt-from-cookie-blocking-between-each-other.html
http/tests/resourceLoadStatistics/exemptDomains/app-bound-domains-exempt-from-website-data-deletion-database.html
http/tests/resourceLoadStatistics/exemptDomains/app-bound-domains-exempt-from-website-data-deletion.html
- platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::shouldBlockCookies const):
(WebCore::NetworkStorageSession::shouldExemptDomainPairFromThirdPartyCookieBlocking const):
(WebCore::NetworkStorageSession::setAppBoundDomains):
(WebCore::NetworkStorageSession::resetAppBoundDomains):
- platform/network/NetworkStorageSession.h:
Source/WebKit:
This change forwards information about app-bound domains to ITP and web
processes so that they can be exempt from website data deletion and
third-party cookie blocking between themselves.
App-bound domains are configured statically and apply to all website
data stores. Therefore the setting needs to be forwarded to all
website data stores and ITP functionality in all network and web
content processes. This is done through the new static function
WebsiteDataStore::setAppBoundDomainsForITPIfInitialized().
Since app-bound domains are loaded lazily from disk and on a background
thread, this patch forwards them in ResourceLoadStatisticsParameters if
they've already been loaded. Then every time app-bound domains are
updated, they are forwarded to ITP. This ensures that ITP will have them
as soon as possible.
Setting app-bound domains for the purposes of ITP automatically switches
ITP's cookie blocking policy to the new
WebCore::ThirdPartyCookieBlockingMode::AllExceptBetweenAppBoundDomains.
This is done in WebResourceLoadStatisticsStore::setAppBoundDomains().
The C API changes are for test purposes.
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::registrableDomainsToDeleteOrRestrictWebsiteDataFor):
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::setAppBoundDomains):
(WebKit::ResourceLoadStatisticsStore::resetParametersToDefaultValues):
(WebKit::ResourceLoadStatisticsStore::shouldExemptFromWebsiteDataDeletion const):
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
(WebKit::ResourceLoadStatisticsStore::standaloneApplicationDomain const): Deleted.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::setAppBoundDomains):
(WebKit::WebResourceLoadStatisticsStore::resetParametersToDefaultValues):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::setAppBoundDomainsForResourceLoadStatistics):
(WebKit::NetworkProcess::setThirdPartyCookieBlockingMode):
(WebKit::NetworkProcess::setShouldBlockThirdPartyCookiesForTesting): Deleted.
Renamed setThirdPartyCookieBlockingMode.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
- Shared/ResourceLoadStatisticsParameters.h:
(WebKit::ResourceLoadStatisticsParameters::encode const):
(WebKit::ResourceLoadStatisticsParameters::decode):
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetAppBoundDomainsForTesting):
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::setAppBoundDomainsForResourceLoadStatistics):
(WebKit::NetworkProcessProxy::setThirdPartyCookieBlockingMode):
(WebKit::NetworkProcessProxy::setShouldBlockThirdPartyCookiesForTesting): Deleted.
Renamed setThirdPartyCookieBlockingMode.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setThirdPartyCookieBlockingMode):
(WebKit::WebProcessProxy::setShouldBlockThirdPartyCookiesForTesting): Deleted.
Renamed setThirdPartyCookieBlockingMode.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::initializeAppBoundDomains):
(WebKit::WebsiteDataStore::ensureAppBoundDomains const):
(WebKit::WebsiteDataStore::appBoundDomainsIfInitialized):
This function allows fetching of app-bound domains without triggering
the lazy loading. This is just to allow speculative configuration of ITP
right when it's created — if any app-bound domains are already configured,
forward them to ITP via ResourceLoadStatisticsParameters.
(WebKit::WebsiteDataStore::setAppBoundDomainsForTesting):
This function is Cocoa-specific and only accepts localhost and 127.0.0.1
to be configured as app-bound domains.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldBlockThirdPartyCookiesForTesting):
(WebKit::WebsiteDataStore::setThirdPartyCookieBlockingMode):
(WebKit::WebsiteDataStore::parameters):
(WebKit::WebsiteDataStore::forwardAppBoundDomainsToITPIfInitialized):
(WebKit::WebsiteDataStore::setAppBoundDomainsForITP):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setThirdPartyCookieBlockingMode):
(WebKit::WebProcess::setShouldBlockThirdPartyCookiesForTesting): Deleted.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
Tools:
This change adds a new TestRunner function
setAppBoundDomain() which takes an array of origin
strings and sets them to app-bound domains.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAppBoundDomains):
(WTR::TestRunner::didSetAppBoundDomainsCallback):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::AppBoundDomainsCallbackContext::AppBoundDomainsCallbackContext):
(WTR::didSetAppBoundDomainsCallback):
(WTR::TestController::setAppBoundDomains):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didSetAppBoundDomains):
- WebKitTestRunner/TestInvocation.h:
LayoutTests:
- http/tests/resourceLoadStatistics/exemptDomains/app-bound-domains-exempt-from-cookie-blocking-between-each-other-expected.txt: Added.
- http/tests/resourceLoadStatistics/exemptDomains/app-bound-domains-exempt-from-cookie-blocking-between-each-other.html: Added.
- http/tests/resourceLoadStatistics/exemptDomains/app-bound-domains-exempt-from-website-data-deletion-database-expected.txt: Added.
- http/tests/resourceLoadStatistics/exemptDomains/app-bound-domains-exempt-from-website-data-deletion-database.html: Added.
- http/tests/resourceLoadStatistics/exemptDomains/app-bound-domains-exempt-from-website-data-deletion-expected.txt: Added.
- http/tests/resourceLoadStatistics/exemptDomains/app-bound-domains-exempt-from-website-data-deletion.html: Added.
- 11:43 AM Changeset in webkit [261241] by
-
- 3 edits2 deletes in trunk/Tools
Delete code for feeder queue
https://bugs.webkit.org/show_bug.cgi?id=211518
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/tool/bot/feeders.py: Removed.
- Scripts/webkitpy/tool/bot/feeders_unittest.py: Removed.
- Scripts/webkitpy/tool/commands/queues.py:
(FeederQueue): Deleted.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(TestFeederQueue): Deleted.
(FeederQueueTest): Deleted.
(PatchProcessingQueueTest): Deleted.
- 11:32 AM Changeset in webkit [261240] by
-
- 3 edits2 adds in trunk
[iOS] ASSERTION FAILED: !(_keyboardFlags & WebEventKeyboardInputModifierFlagsChanged) in -[WebEvent charactersIgnoringModifiers] when pressing modifier on PDF
https://bugs.webkit.org/show_bug.cgi?id=211472
Reviewed by Darin Adler.
Source/WebKit:
Do not ask for event character string for a flags changed event: they don't have one.
Test: fast/events/ios/pdf-modifer-key-down-crash.html
- UIProcess/ios/WKKeyboardScrollingAnimator.mm:
(-[WKKeyboardScrollingAnimator keyboardScrollForEvent:]):
LayoutTests:
Add a test.
- fast/events/ios/pdf-modifer-key-down-crash-expected.txt: Added.
- fast/events/ios/pdf-modifer-key-down-crash.html: Added.
- 11:00 AM Changeset in webkit [261239] by
-
- 13 edits2 adds in trunk
Add basic support for generating accurate wheel event listener region
https://bugs.webkit.org/show_bug.cgi?id=211512
Reviewed by Simon Fraser.
Source/WebCore:
Add fake properties for wheel event listeners to RenderStyle and use them to
generate regions in EventRegion. There is a separate region for non-passive
wheel event listeners (that will require synchronous handling).
The generated regions are not used for anything in this patch.
Style is not yet invalided on event listener additions and removals.
Test: fast/scrolling/mac/wheel-event-listener-region-basic.html
- dom/Node.h:
- rendering/EventRegion.cpp:
(WebCore::EventRegion::unite):
(WebCore::EventRegion::uniteEventListeners):
(WebCore::EventRegion::dump const):
- rendering/EventRegion.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::eventListenerRegionTypes const):
(WebCore::RenderStyle::setEventListenerRegionTypes):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
- rendering/style/StyleRareInheritedData.h:
- style/StyleAdjuster.cpp:
(WebCore::Style::computeEventListenerRegionTypes):
(WebCore::Style::Adjuster::adjust const):
LayoutTests:
- fast/scrolling/mac/wheel-event-listener-region-basic-expected.txt: Added.
- fast/scrolling/mac/wheel-event-listener-region-basic.html: Added.
- 10:32 AM Changeset in webkit [261238] by
-
- 2 edits in trunk/Source/WebKit
[MacCatalyst] Processes should check for network entitlement as we do for macOS apps
https://bugs.webkit.org/show_bug.cgi?id=211474
<rdar://problem/61182060>
Reviewed by Alexey Proskuryakov.
We should make the same entitlement checks in MacCatalyst as we do for macOS.
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::checkEntitlements):
- 10:14 AM Changeset in webkit [261237] by
-
- 9 edits in trunk/Source/WebInspectorUI
Web Inspector: Layers: the text at the bottom of the details sidebar can get squished
https://bugs.webkit.org/show_bug.cgi?id=211486
Reviewed by Brian Burg.
- UserInterface/Views/Sidebar.js:
(WI.Sidebar.prototype.get minimumWidth):
Ask both thethis._navigationBarandthis._selectedSidebarPanelinstead of just one.
- UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel.prototype.get minimumWidth): Added.
- UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.get minimumWidth): Addede.
- UserInterface/Views/BoxModelDetailsSectionRow.js:
(WI.BoxModelDetailsSectionRow):
(WI.BoxModelDetailsSectionRow.prototype.get minimumWidth): Added.
(WI.BoxModelDetailsSectionRow.prototype._updateMetrics):
- UserInterface/Views/BoxModelDetailsSectionRow.css:
(.details-section .row.box-model):
Keep track of the outermost box and provide a way to report its width.
- UserInterface/Views/LayerDetailsSidebarPanel.js:
(WI.LayerDetailsSidebarPanel):
(WI.LayerDetailsSidebarPanel.prototype.get minimumWidth): Added.
(WI.LayerDetailsSidebarPanel.prototype._buildBottomBar):
(WI.LayerDetailsSidebarPanel.prototype._updateBottomBar):
- UserInterface/Views/LayerDetailsSidebarPanel.css:
(.panel.details.layer .bottom-bar):
(.panel.details.layer .bottom-bar > div):
Cache the width of the items in the bottom bar and use it inget minimumWidth.
- 9:38 AM WebKitGTK/Debugging edited by
- (diff)
- 9:36 AM WebKitGTK/Debugging edited by
- (diff)
- 9:30 AM Changeset in webkit [261236] by
-
- 2 edits in trunk/LayoutTests
fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS
https://bugs.webkit.org/show_bug.cgi?id=211515
<rdar://problem/61180247>
Reviewed by Darin Adler.
Update test to navigate to fast/history/resources/page-cache-helper.html instead of
a data URL which calls history.back() on load. Unlike the data URL, page-cache-helper.html
only navigates back in a 0-timer after the load event has fired. This is important to
guarantee that the current history item has been created before navigating back. If we
navigate back too early, then the current history item is still the one for the previous
page and we end up navigating back to the previous test, which would cause the timeout.
- fast/overflow/horizontal-scroll-after-back.html:
- 9:29 AM Changeset in webkit [261235] by
-
- 5 edits9 deletes in trunk/LayoutTests
Remove orphaned WPT expectations & unused harness
https://bugs.webkit.org/show_bug.cgi?id=211454
Reviewed by Darin Adler.
- wpt/html/dom/interfaces was renamed to wpt/html/dom/idlharness.
- wpt/dom/nodes/Document-createEvent was superseded by HTTPS version.
- w3c/resources/WebIDLParser.js is unused.
LayoutTests/imported/w3c:
- resources/WebIDLParser.js: Removed.
- web-platform-tests/dom/nodes/Document-createEvent-expected.txt: Removed.
- web-platform-tests/html/dom/interfaces-expected.txt: Removed.
- web-platform-tests/html/dom/interfaces.worker-expected.txt: Removed.
- web-platform-tests/html/dom/interfaces.worker.html: Removed.
LayoutTests:
- TestExpectations:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/interfaces.worker-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Removed.
- platform/mac-wk1/TestExpectations:
- platform/wpe/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Removed.
- tests-options.json:
- 9:24 AM Changeset in webkit [261234] by
-
- 6 edits in trunk/Source
Remove now-unneeded USE(GRAMMAR_CHECKING)
https://bugs.webkit.org/show_bug.cgi?id=211452
Reviewed by Anders Carlsson.
Source/WebCore:
- editing/Editor.cpp:
(WebCore::Editor::advanceToNextMisspelling): Remove USE(GRAMMAR_CHECKING).
(WebCore::Editor::isSelectionUngrammatical): Ditto.
(WebCore::Editor::markMisspellingsOrBadGrammar): Ditto.
(WebCore::Editor::markBadGrammar): Ditto.
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::markAllBadGrammar): Ditto.
(WebCore::checkTextOfParagraph): Ditto. Also correct misspelling of the
word "misspelling".
- editing/TextCheckingHelper.h: Ditto.
Source/WTF:
- wtf/PlatformUse.h: Don't set USE_GRAMMAR_CHECKING.
- 9:15 AM Changeset in webkit [261233] by
-
- 24 edits in trunk/Source
ASSERT_WITH_MESSAGE(m_isOwnedByMainThread == isMainThread()) when web inspecting
https://bugs.webkit.org/show_bug.cgi?id=203638
<rdar://problem/56761893>
Reviewed by Brian Burg.
Source/JavaScriptCore:
Mark the
InspectorEnvironment::executionStopwatchabstract function asconstand have it
return aStopwatch&instead of aRefPtr<Stopwatch>&as callers assume that it exists.
By not using aRefPtr, an additionalcopyRefcan be avoided.
- inspector/InspectorEnvironment.h:
- inspector/JSGlobalObjectInspectorController.h:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::executionStopwatch const): Added.
(Inspector::JSGlobalObjectInspectorController::executionStopwatch): Deleted.
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::didPause):
(Inspector::InspectorDebuggerAgent::breakpointActionProbe):
(Inspector::InspectorDebuggerAgent::didContinue):
- inspector/agents/InspectorHeapAgent.cpp:
(Inspector::InspectorHeapAgent::snapshot):
(Inspector::InspectorHeapAgent::willGarbageCollect):
(Inspector::InspectorHeapAgent::didGarbageCollect):
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::startTracking):
(Inspector::InspectorScriptProfilerAgent::willEvaluateScript):
(Inspector::InspectorScriptProfilerAgent::didEvaluateScript):
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
- runtime/SamplingProfiler.h:
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::SamplingProfiler):
- runtime/VM.h:
- runtime/VM.cpp:
(JSC::VM::ensureSamplingProfiler):
Source/WebCore:
Mark the
InspectorEnvironment::executionStopwatchabstract function asconstand have it
return aStopwatch&instead of aRefPtr<Stopwatch>&as callers assume that it exists.
By not using aRefPtr, an additionalcopyRefcan be avoided.
- inspector/InspectorController.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::executionStopwatch const): Added.
(WebCore::InspectorController::executionStopwatch): Deleted.
- inspector/WorkerInspectorController.h:
(WebCore::WorkerInspectorController::executionStopwatch const): Added.
(WebCore::WorkerInspectorController::executionStopwatch): Deleted.
- inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::InspectorAnimationAgent::startTracking):
(WebCore::InspectorAnimationAgent::stopTracking):
(WebCore::InspectorAnimationAgent::willApplyKeyframeEffect):
(WebCore::InspectorAnimationAgent::stopTrackingDeclarativeAnimation):
- inspector/agents/InspectorCPUProfilerAgent.cpp:
(WebCore::InspectorCPUProfilerAgent::startTracking):
(WebCore::InspectorCPUProfilerAgent::stopTracking):
(WebCore::InspectorCPUProfilerAgent::collectSample):
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::mediaMetricsTimerFired):
- inspector/agents/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::startTracking):
(WebCore::InspectorMemoryAgent::stopTracking):
(WebCore::InspectorMemoryAgent::didHandleMemoryPressure):
(WebCore::InspectorMemoryAgent::collectSample):
- inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::buildObjectForTiming):
(WebCore::InspectorNetworkAgent::timestamp):
(WebCore::InspectorNetworkAgent::didFinishLoading):
- inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::timestamp):
- inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::timestamp):
Source/WTF:
- wtf/Stopwatch.h:
(WTF::Stopwatch::elapsedTime const): Added.
(WTF::Stopwatch::elapsedTimeSince const): Added.
(WTF::Stopwatch::elapsedTime): Deleted.
(WTF::Stopwatch::elapsedTimeSince): Deleted.
- 9:01 AM Changeset in webkit [261232] by
-
- 29 edits in trunk
Eliminate checks of USE(DICTATION_ALTERNATIVES) in Cocoa-specific code
https://bugs.webkit.org/show_bug.cgi?id=211460
Reviewed by Anders Carlsson.
Source/WebCore:
- editing/cocoa/AlternativeTextContextController.h: Remove USE(DICTATION_ALTERNATIVES).
Also remove unnecessary use of RetainPtr and add a FIXME. Also remove #pragma once
since this header is only imported from Objective-C++ sources.
- editing/cocoa/AlternativeTextContextController.mm: Ditto.
- editing/cocoa/AlternativeTextUIController.h: Ditto.
- editing/cocoa/AlternativeTextUIController.mm: Ditto.
- editing/mac/TextAlternativeWithRange.h: Ditto.
- editing/mac/TextAlternativeWithRange.mm: Ditto.
Source/WebKit:
- UIProcess/Cocoa/PageClientImplCocoa.h: Remove USE(DICTATION_ALTERNATIVES).
Also remove unnecessary use of RetainPtr.
- UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::PageClientImplCocoa): Ditto.
(WebKit::PageClientImplCocoa::pageClosed): Ditto.
(WebKit::PageClientImplCocoa::dictationAlternatives): Ditto.
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::insertDictatedTextAsync): Ditto.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::validAttributesForMarkedText): Ditto.
(WebKit::WebViewImpl::insertText): Ditto.
- UIProcess/PageClient.h: Ditto.
- UIProcess/ios/PageClientImplIOS.h: Ditto.
- UIProcess/ios/PageClientImplIOS.mm: Ditto.
- UIProcess/ios/WKContentViewInteraction.mm: Ditto.
- UIProcess/mac/PageClientImplMac.h: Ditto.
- UIProcess/mac/PageClientImplMac.mm: Ditto.
- WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp: Ditto.
Source/WebKitLegacy/mac:
- WebCoreSupport/WebAlternativeTextClient.h: Removed USE(DICTATION_ALTERNATIVES).
- WebCoreSupport/WebAlternativeTextClient.mm:
(WebAlternativeTextClient::dictationAlternatives): Ditto.
- WebView/WebHTMLView.mm: Ditto.
- WebView/WebView.mm: Ditto. Also use modern for loop.
- WebView/WebViewData.h: Ditto.
- WebView/WebViewData.mm: Ditto.
- WebView/WebViewInternal.h: Ditto.
Tools:
- TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Remove USE(DICTATION_ALTERNATIVES).
- 8:39 AM Changeset in webkit [261231] by
-
- 8 edits in trunk/Tools
Python3: Support Python3 in Tools/webkitpy/benchmark_runner
https://bugs.webkit.org/show_bug.cgi?id=211249
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
(BenchmarkBuilder._fetch_remote_archive):
- Scripts/webkitpy/benchmark_runner/benchmark_results.py:
(BenchmarkResults._format_values):
(BenchmarkResults._subtest_values_by_config_iteration):
- Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(istext):
(BenchmarkRunner._run_benchmark):
(BenchmarkRunner._merge):
(BenchmarkRunner.show_results):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.launch_url):
- Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
(HTTPServerDriver):
- Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver.serve):
(SimpleHTTPServerDriver._wait_for_http_server):
- Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(parse_args):
(list_benchmark_plans):
- Scripts/webkitpy/style/checker.py:
(CheckerDispatcher._create_checker):
- 8:32 AM Changeset in webkit [261230] by
-
- 3 edits in trunk/Source/WebKit
[GTK] Cleanup KeyBindingTranslator on WebView disposal
https://bugs.webkit.org/show_bug.cgi?id=211465
Reviewed by Carlos Garcia Campos.
Fixes assertion in debug mode when a test failed and the widget
followed a destruction pattern where KeyBindingTranslator would be
destroyed before the container widget is cleaned up.
Also renamed the method from 'destroyed' to 'invalidate' to try to
better convey the action being performed on the KeyBindingTranslator.
Covered by existing tests.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerRemove): Update method name.
(webkitWebViewBaseDispose): Cleanup keyBindingTranslator when
disposing this widget.
- UIProcess/gtk/KeyBindingTranslator.h:
(WebKit::KeyBindingTranslator::invalidate): Renamed from destroyed.
(WebKit::KeyBindingTranslator::destroyed): Deleted.
- 8:30 AM Changeset in webkit [261229] by
-
- 3 edits in trunk/Source/WebCore
Factor EventHandler code that sends mouseEnteredContentArea/mouseExitedContentArea into its own function
https://bugs.webkit.org/show_bug.cgi?id=211494
Reviewed by Antti Koivisto.
mouseEnteredContentArea/mouseEnteredContentArea are used only to notify overlay scrollbars
of state changes. Factor the code that calls these functions into a separate EventHandler
function, and refactor it for clarity, now we know that both lastElementUnderMouse and elementUnderMouse
must belong to this EventHandler's Frame's Document.
- page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::notifyScrollableAreasOfMouseEnterExit):
- page/EventHandler.h:
- 8:00 AM Changeset in webkit [261228] by
-
- 5 edits in trunk/Source
Reduce HAVE(HOSTED_CORE_ANIMATION)
https://bugs.webkit.org/show_bug.cgi?id=211423
Reviewed by Anders Carlsson.
Source/WebKit:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess): Removed redundant #if
checking both HAVE(HOSTED_CORE_ANIMATION) and !PLATFORM(IOS_FAMILY).
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess): Removed unnecessary
HAVE(HOSTED_CORE_ANIMATION) check in code that is only compiled for macOS.
Source/WTF:
- wtf/PlatformHave.h: Simplified conditional to just PLATFORM(MAC)
for HOSTED_CORE_ANIMATION.
- 7:30 AM Changeset in webkit [261227] by
-
- 5 edits2 deletes in trunk/Tools
Delete code for QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=211504
Reviewed by Jonathan Bedard.
- QueueStatusServer: Removed.
- BuildSlaveSupport/ews-build/steps.py:
(CheckPatchRelevance): Removed QueueStatusServer.
- Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
(CheckPatchRelevance): Removed QueueStatusServer.
- Scripts/webkitpy/common/net/statusserver.py: Removed implementation of most methods. Will delete it completely
in subsequent patch along-with all its callers.
- Scripts/webkitpy/common/net/statusserver_unittest.py: Removed.
- Scripts/webkitpy/test/main.py:
- 7:18 AM Changeset in webkit [261226] by
-
- 3 edits in trunk/Source/WebCore
[LFC] BlockFormattingContext::computeHeightAndMargin should special case the table box
https://bugs.webkit.org/show_bug.cgi?id=211493
Reviewed by Antti Koivisto.
By the time we get to BlockFormattingContext::computeHeightAndMargin(), the used valued for the table height is already been computed.
(Table box height is mostly content driven, and both the computed height and the min/max pair are taken into account
while we are laying out the table content).
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
- 7:15 AM Changeset in webkit [261225] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r261163): [ Mac WK2 ] webrtc/libwebrtc/descriptionGetters.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=211455
<rdar://problem/62895451>
Reviewed by Eric Carlson.
- webrtc/libwebrtc/descriptionGetters.html:
Sanitize SDP before comparison as port information and candidates are no longer blocked by main thread.
- 7:04 AM Changeset in webkit [261224] by
-
- 2 edits4 adds in trunk/Source/WebCore
Add watchOS media controls assets
https://bugs.webkit.org/show_bug.cgi?id=211508
<rdar://problem/62926565>
Patch by Antoine Quint <Antoine Quint> on 2020-05-06
Reviewed by Eric Carlson.
- Modules/modern-media-controls/images/watchOS/ActivityIndicatorSpriteCompact@2x.png: Added.
- Modules/modern-media-controls/images/watchOS/InvalidCompact.pdf: Added.
- Modules/modern-media-controls/images/watchOS/PlayCompact.pdf: Added.
- WebCore.xcodeproj/project.pbxproj:
- 7:04 AM Changeset in webkit [261223] by
-
- 3 edits in trunk/Source/WebCore
[LFC][BFC] FormattingContext::ConstraintsForInFlowContent should include the computed value of height
https://bugs.webkit.org/show_bug.cgi?id=211487
Reviewed by Antti Koivisto.
When the formatting context root has fixed height, the computed value should be passed in to the formatting context layout
as the available vertical space.
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::constraintsForInFlowContent):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraVerticalSpace):
- 6:33 AM Changeset in webkit [261222] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening, expected to fail but passed
https://bugs.webkit.org/show_bug.cgi?id=211510
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 6:05 AM Changeset in webkit [261221] by
-
- 6 edits6 adds2 deletes in trunk/LayoutTests
[WPE] Gardening, update baselines after r261219
https://bugs.webkit.org/show_bug.cgi?id=211507
Unreviewed gardening.
- platform/wpe/fast/css/font-face-opentype-expected.txt: Updated after r261190.
- platform/wpe/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt: Added after r260139.
- platform/wpe/imported/w3c/web-platform-tests/css/css-animations/animation-base-response-001-expected.txt: Added after r260662.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-grad-08-b-manual-expected.txt: Updated after r261191.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/text-altglyph-01-b-manual-expected.txt: Updated after r261191.
- platform/wpe/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any-expected.txt: Added after r260690.
- platform/wpe/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any.worker-expected.txt: Added after r260690.
- platform/wpe/storage/domstorage/sessionstorage/blocked-file-access-expected.txt: Removed.
- platform/wpe/svg/batik/text/xmlSpace-expected.txt: Updated after r261154.
- 2:30 AM Changeset in webkit [261220] by
-
- 10 edits3 adds in trunk
[WebXR] Implement isSessionSupported()
https://bugs.webkit.org/show_bug.cgi?id=211187
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
- web-platform-tests/webxr/xrDevice_isSessionSupported_immersive.https-expected.txt: Added.
- web-platform-tests/webxr/xrDevice_isSessionSupported_immersive_unsupported.https-expected.txt: Added.
- web-platform-tests/webxr/xrDevice_isSessionSupported_inline.https-expected.txt: Added.
Source/WebCore:
The isSessionSupported() method queries if a given mode may be supported
by the UA and device capabilities. Apart from the needed machinery in
the webxr Module we're adding an OpenXR implementation of the
enumerateImmersiveXRDevices() method required by isSessionSupported().
The method is not completely implemented as it lacks a few action at its
very end, like firing events. They'll be implemented in follow up
patches as they require additional changes.
Some OpenXR runtimes as Monado always enumerate at least one device even
if none is connected. This dummy device might interfere with tests
execution (as there will be more devices than expected) so we're adding
a testMode to WebXRSystem which does not query platform for existing
devices.
Added expected results and unskipped some WPT that are now passing.
- Modules/webxr/WebXRSystem.cpp:
(WebCore::WebXRSystem::ensureImmersiveXRDeviceIsSelected): Asks platform
code for the list of attached XR devices and properly set the active
immersive device if any.
(WebCore::WebXRSystem::isSessionSupported): Partially implemented.
(WebCore::WebXRSystem::registerSimulatedXRDeviceForTesting): Set the
passed in mock device as either the current active immersive or inline
device.
(WebCore::WebXRSystem::unregisterSimulatedXRDeviceForTesting): Removes
the passed in mock device from the list of immersive devices.
- Modules/webxr/WebXRSystem.h:
- html/FeaturePolicy.cpp:
(WebCore::policyTypeName): Handle XRSpatialTracking.
(WebCore::FeaturePolicy::parse): Parse "xr-spatial-tracking".
(WebCore::FeaturePolicy::allows const): Handle XRSpatialTracking.
- html/FeaturePolicy.h: Added XRSpatialTracking.
- platform/xr/PlatformXR.h:
(PlatformXR::Instance::immersiveXRDevices const): Keep a list of immersive devices.
- platform/xr/openxr/PlatformXR.cpp:
(PlatformXR::Instance::Impl::collectSupportedSessionModes): Gather supported session
modes for a given device from OpenXR.
(PlatformXR::Instance::enumerateImmersiveXRDevices): Collect devices from OpenXR. We
are currently asking for HMD devices.
LayoutTests:
- platform/wpe/TestExpectations: Added some skipped tests that are now passing.
- 1:28 AM Changeset in webkit [261219] by
-
- 6 edits2 adds in trunk/LayoutTests
GTK] Gardening, update expectations and baselines after r261191
https://bugs.webkit.org/show_bug.cgi?id=211502
Unreviewed gardening.
embedded-credentials.tentative.sub-expected.txt is passing more tests
than the general baseline since r260937.
- platform/gtk/TestExpectations:
- platform/gtk/fast/css/font-face-opentype-expected.txt: Updated after r261190.
- platform/gtk/imported/w3c/web-platform-tests/fetch/security/embedded-credentials.tentative.sub-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/svg/import/pservers-grad-08-b-manual-expected.txt: Updated after r261191.
- platform/gtk/imported/w3c/web-platform-tests/svg/import/text-altglyph-01-b-manual-expected.txt: Updated after r261191.
- platform/gtk/svg/batik/text/xmlSpace-expected.txt: Updated after r261154.
- 1:09 AM Changeset in webkit [261218] by
-
- 2 edits in trunk/Source/WebCore
[Web Animations] Coordinate "update animations and send events" procedure across multiple timelines
https://bugs.webkit.org/show_bug.cgi?id=202109
Unreviewed.
Remove an unused function.
- animation/AnimationTimeline.h:
(WebCore::AnimationTimeline::allAnimations const): Deleted.
- 1:06 AM Changeset in webkit [261217] by
-
- 6 edits in trunk
Fix animation ordering to make imported/w3c/web-platform-tests/css/css-animations/Element-getAnimations.tentative.html pass
https://bugs.webkit.org/show_bug.cgi?id=211468
<rdar://problem/62732578>
Reviewed by David Kilzer.
LayoutTests/imported/w3c:
Mark the final two failures in imported/w3c/web-platform-tests/css/css-animations/Element-getAnimations.tentative.html as PASS.
- web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt:
Source/WebCore:
The "Animation composite order" section of the CSS Animations Level 2 specification (https://drafts.csswg.org/css-animations-2/#animation-composite-order)
defines the relative composite order of animations. We bake this into compareAnimationsByCompositeOrder(), but this function would not yield consistent
results if it is called in a non-stable sort, because if both CSSAnimation objects passed to this function have the same backing Animation object, they
would not return the same value if passed in a different order. The Web Animations spec always ensures that procedures that sort using the composite
order are called as part of a stable sort. So we change all call sites to use std::stable_sort and add an assertion in case we have two CSSAnimation
objects with the same backing Animation objects to catch cases like this in the future.
Finally, since we already know only relevant animations can find their way into the output of Document::getAnimations(), we also ensure we iterate over
m_animations (which holds only relevant animations) rather than m_allAnimations (which may not).
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::getAnimations const):
- animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::ensureEffectsAreSorted):
- animation/WebAnimationUtilities.cpp:
(WebCore::compareAnimationsByCompositeOrder):
