Timeline



May 25, 2020:

9:48 PM Changeset in webkit [262136] by Wenson Hsieh
  • 2 edits in trunk/Tools

[iOS] ActionSheetTests.DataDetectorsLinkIsNotPresentedAsALink is failing consistently
https://bugs.webkit.org/show_bug.cgi?id=212363
<rdar://problem/63508866>

Reviewed by Tim Horton.

This test began to consistently throw an exception after <https://trac.webkit.org/r261157>, due to how
UserInterfaceSwizzler always instantiates the shared UIApplication. This apparently causes -[WKContentView
resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets:] to return nil instead of a replica view. As a
result, we crash under createFallbackTargetedPreview as we're attempting to assemble a targeted preview for
the context menu interaction.

Since this seems to only affect this particular API test, work around it by swizzling out
-resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets: in this API test to return a non-null UIView.

  • TestWebKitAPI/Tests/ios/ActionSheetTests.mm:

(TestWebKitAPI::swizzledResizableSnapshotViewFromRect):
(TestWebKitAPI::TEST):

8:44 PM Changeset in webkit [262135] by Diego Pino Garcia
  • 11 edits in trunk/LayoutTests

[WPE] Gardening, update baselines after r262127
https://bugs.webkit.org/show_bug.cgi?id=212365

Unreviewed gardening.

  • platform/wpe/fast/html/details-no-summary4-expected.txt:
  • platform/wpe/fast/html/details-open-javascript-expected.txt:
  • platform/wpe/fast/html/details-open2-expected.txt:
  • platform/wpe/fast/html/details-open4-expected.txt:
  • platform/wpe/fast/html/details-replace-summary-child-expected.txt:
  • platform/wpe/fast/html/details-replace-text-expected.txt:
  • platform/wpe/fast/html/details-writing-mode-expected.txt:
  • platform/wpe/fast/html/details-writing-mode-mixed-expected.txt:
  • platform/wpe/fast/writing-mode/fieldsets-expected.txt:
  • platform/wpe/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
8:30 PM Changeset in webkit [262134] by Diego Pino Garcia
  • 70 edits in trunk/LayoutTests

[GTK] Gardening, update baselines after r262127
https://bugs.webkit.org/show_bug.cgi?id=212364

Unreviewed gardening.

  • platform/glib/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/glib/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/glib/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
  • platform/glib/fast/css-generated-content/details-summary-before-after-expected.txt:
  • platform/glib/fast/html/details-add-child-1-expected.txt:
  • platform/glib/fast/html/details-add-child-2-expected.txt:
  • platform/glib/fast/html/details-add-details-child-1-expected.txt:
  • platform/glib/fast/html/details-add-details-child-2-expected.txt:
  • platform/glib/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-1-expected.txt:
  • platform/glib/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-10-expected.txt:
  • platform/glib/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-2-expected.txt:
  • platform/glib/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-3-expected.txt:
  • platform/glib/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-4-expected.txt:
  • platform/glib/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-5-expected.txt:
  • platform/glib/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-6-expected.txt:
  • platform/glib/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-7-expected.txt:
  • platform/glib/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-8-expected.txt:
  • platform/glib/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-9-expected.txt:
  • platform/glib/fast/html/details-add-summary-child-1-expected.txt:
  • platform/glib/fast/html/details-add-summary-child-2-expected.txt:
  • platform/glib/fast/html/details-marker-style-expected.txt:
  • platform/glib/fast/html/details-nested-1-expected.txt:
  • platform/glib/fast/html/details-nested-2-expected.txt:
  • platform/glib/fast/html/details-no-summary1-expected.txt:
  • platform/glib/fast/html/details-no-summary2-expected.txt:
  • platform/glib/fast/html/details-no-summary3-expected.txt:
  • platform/glib/fast/html/details-open1-expected.txt:
  • platform/glib/fast/html/details-open3-expected.txt:
  • platform/glib/fast/html/details-open5-expected.txt:
  • platform/glib/fast/html/details-open6-expected.txt:
  • platform/glib/fast/html/details-position-expected.txt:
  • platform/glib/fast/html/details-remove-child-1-expected.txt:
  • platform/glib/fast/html/details-remove-child-2-expected.txt:
  • platform/glib/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-1-expected.txt:
  • platform/glib/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-2-expected.txt:
  • platform/glib/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-3-expected.txt:
  • platform/glib/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-4-expected.txt:
  • platform/glib/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-5-expected.txt:
  • platform/glib/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-6-expected.txt:
  • platform/glib/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/glib/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/glib/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/glib/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt:
  • platform/gtk/fast/html/details-replace-text-expected.txt:
  • platform/gtk/fast/html/details-writing-mode-expected.txt:
  • platform/gtk/fast/html/details-writing-mode-mixed-expected.txt:
  • platform/gtk/fast/writing-mode/fieldsets-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
5:27 PM Changeset in webkit [262133] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Use an Optional<> for LayerFragment::boundingBox
https://bugs.webkit.org/show_bug.cgi?id=212358

Reviewed by Zalan Bujtas.

Replace a bool + LayoutRect with Optional<LayoutRect>.

  • rendering/LayerFragment.h:

(WebCore::LayerFragment::setRects):
(WebCore::LayerFragment::moveBy):
(WebCore::LayerFragment::intersect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayer.h:
5:26 PM Changeset in webkit [262132] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Make isTableRow() an inline function
https://bugs.webkit.org/show_bug.cgi?id=212360

Reviewed by Darin Adler.

isTableCell() is a virtual function that's called in some hot code paths, like RenderLayer::localBoundingBox(),
so make it inline by using a spare bit on RenderObject.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isTableCaption const):
(WebCore::RenderObject::isTableRow const):
(WebCore::RenderObject::setIsTableRow):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::RenderTableRow):

  • rendering/RenderTableRow.h:
5:03 PM Changeset in webkit [262131] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Expose more network metrics to WebCoreNSURLSession
https://bugs.webkit.org/show_bug.cgi?id=212359
<rdar://problem/62909440>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-05-25
Reviewed by Darin Adler.

Source/WebCore:

  • platform/network/NetworkLoadMetrics.h:

(WebCore::NetworkLoadMetrics::isolatedCopy const):
(WebCore::NetworkLoadMetrics::operator== const):
(WebCore::NetworkLoadMetrics::encode const):
(WebCore::NetworkLoadMetrics::decode):

  • platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionTaskTransactionMetrics networkProtocolName]):
(-[WebCoreNSURLSessionTaskTransactionMetrics isReusedConnection]):
(-[WebCoreNSURLSessionTaskTransactionMetrics cellular]):
(-[WebCoreNSURLSessionTaskTransactionMetrics expensive]):
(-[WebCoreNSURLSessionTaskTransactionMetrics constrained]):
(-[WebCoreNSURLSessionTaskTransactionMetrics multipath]):

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

Source/WTF:

  • wtf/PlatformHave.h:
1:51 PM WPTExportProcess edited by clopez@igalia.com
(diff)
1:39 PM Changeset in webkit [262130] by Oriol Brufau
  • 10 edits in trunk

[css-grid] Prevent grid-template-rows from serializing adjacent <line-names>
https://bugs.webkit.org/show_bug.cgi?id=212345

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Update test expectations.

  • web-platform-tests/css/css-grid/parsing/grid-shorthand-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-shorthand-valid-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-shorthand-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt:

Source/WebCore:

The parser for the grid-template shorthand has this code:

Persists between loop iterations so we can use the same value for
consecutive <line-names> values
RefPtr<CSSGridLineNamesValue> lineNames;

However, this wasn't working because of a lineNames.releaseNonNull() at
the end of the loop. So each iteration started with a null lineNames, and
consecutive <line-names> values were not merged together.

Tests: fast/css-grid-layout/grid-template-shorthand-get-set.html

imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand-valid.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid.html

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeGridTemplateRowsAndAreasAndColumns):

LayoutTests:

Update test expectations.

  • fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt:
  • fast/css-grid-layout/grid-template-shorthand-get-set.html:
1:35 PM WPTExportProcess created by clopez@igalia.com
12:25 PM Changeset in webkit [262129] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Extended Color Cleanup: Assert !isExtended() in Color::asSimpleColor()...finally
https://bugs.webkit.org/show_bug.cgi?id=212357

Reviewed by Simon Fraser.

Reap the reward of the cleanup, and add the ASSERT(!isExtended()) to Color::asSimpleColor()
as was the original goal of this effort. Only tree non-checked places remained and were
trivial to add isExtended() checks for.

  • platform/graphics/Color.cpp:

(WebCore::Color::nameForRenderTreeAsText const):
Use ExtenedColor::cssText() for the RenderTree representation. It is stable
and as good as any, no need to re-invent the wheel here.

(WebCore::Color::light const):
(WebCore::Color::dark const):
Add isExtended() checks before doing white/black checks,

  • platform/graphics/Color.h:

(WebCore::Color::asSimpleColor const):
Add ASSERT.

11:30 AM Changeset in webkit [262128] by weinig@apple.com
  • 34 edits in trunk

Extended Color Cleanup: Use the name SimpleColor consistently
https://bugs.webkit.org/show_bug.cgi?id=212337

Reviewed by Anders Carlsson.
Source/WebCore:


  • Removes RGBA32 type alias, updating all remaining users of it.
  • Renames functions that take/return SimpleColor to use the name SimpleColor rather than RGB (e.g. makeRGBA -> makeSimpleColor)
  • Moves hex color parsing from Color to SimpleColor, as that is the type it returns. Also took the opportunity to make it return an Optional<SimpleColor> instead of using a bool/out parameter.
  • Move Color::compositionFill to editing/CompositionHighlight.h It makes no real sense to keep it in Color.h
  • Replaces rgb() function in Color with asSimpleColor() for symmetry with asExtended().
  • Replaced std::max(a, std::min(value, b)) with std::clamp(value, a, b) for clarity.
  • css/parser/CSSParserFastPaths.cpp:

(WebCore::fastParseColorInternal):
(WebCore::CSSParserFastPaths::parseColor):

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
(WebCore::CSSPropertyParserHelpers::parseHexColor):

  • editing/CompositionHighlight.h:
  • editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):

  • html/ColorInputType.cpp:

(WebCore::parseSimpleColorValue):

  • html/HTMLElement.cpp:

(WebCore::parseColorStringWithCrazyLegacyRules):

  • platform/adwaita/ScrollbarThemeAdwaita.cpp:
  • platform/adwaita/ThemeAdwaita.cpp:

(WebCore::ThemeAdwaita::activeSelectionForegroundColor const):
(WebCore::ThemeAdwaita::activeSelectionBackgroundColor const):
(WebCore::ThemeAdwaita::inactiveSelectionForegroundColor const):

  • platform/graphics/Color.cpp:

(WebCore::differenceSquared):
(WebCore::Color::Color):
(WebCore::Color::operator=):
(WebCore::Color::serialized const):
(WebCore::Color::cssText const):
(WebCore::Color::nameForRenderTreeAsText const):
(WebCore::Color::light const):
(WebCore::Color::dark const):
(WebCore::Color::blend const):
(WebCore::Color::blendWithWhite const):
(WebCore::Color::colorWithAlpha const):
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const):
(WebCore::Color::invertedColorWithAlpha const):
(WebCore::Color::colorSpaceAndComponents const):
(WebCore::Color::toSRGBASimpleColorLossy const):
(WebCore::blend):
(WebCore::Color::tagAsValid):
(WebCore::parseHexColorInternal): Deleted.
(WebCore::Color::parseHexColor): Deleted.
(WebCore::Color::asExtended const): Deleted.

  • platform/graphics/Color.h:

(WebCore::Color::Color):
(WebCore::Color::isHashTableDeletedValue const):
(WebCore::Color::isValid const):
(WebCore::Color::isOpaque const):
(WebCore::Color::isVisible const):
(WebCore::Color::alpha const):
(WebCore::Color::alphaAsFloat const):
(WebCore::Color::isSemantic const):
(WebCore::Color::isExtended const):
(WebCore::Color::setIsSemantic):
(WebCore::operator==):
(WebCore::equalIgnoringSemanticColor):
(WebCore::Color::hash const):
(WebCore::Color::asExtended const):
(WebCore::Color::asSimpleColor const):
(WebCore::Color::setSimpleColor):
(WebCore::Color::isBlackColor):
(WebCore::Color::isWhiteColor):
(WebCore::Color::encode const):
(WebCore::Color::decode):
(WebCore::Color::setRGB): Deleted.
(WebCore::Color::rgb const): Deleted.

  • platform/graphics/ColorUtilities.h:

(WebCore::clampedColorComponent):

  • platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::blendPixel):
(WebCore::ImageBackingStore::pixelValue const):

  • platform/graphics/SimpleColor.cpp:

(WebCore::makePremultipliedSimpleColor):
(WebCore::makeUnpremultipliedSimpleColor):
(WebCore::makeSimpleColorFromFloats):
(WebCore::makeSimpleColorFromHSLA):
(WebCore::makeSimpleColorFromCMYKA):
(WebCore::parseHexColorInternal):
(WebCore::SimpleColor::parseHexColor):
(WebCore::makePremultipliedRGBA): Deleted.
(WebCore::makeUnPremultipliedRGBA): Deleted.
(WebCore::makeRGBA32FromFloats): Deleted.
(WebCore::makeRGBAFromHSLA): Deleted.
(WebCore::makeRGBAFromCMYKA): Deleted.

  • platform/graphics/SimpleColor.h:

(WebCore::roundAndClampColorChannel):
(WebCore::colorFloatToSimpleColorByte):
(WebCore::makeSimpleColor):
(WebCore::colorFloatToRGBAByte): Deleted.
(WebCore::makeRGB): Deleted.
(WebCore::makeRGBA): Deleted.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::makeSimpleColorFromARGBCFArray):
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes):
(WebCore::makeRGBA32FromARGBCFArray): Deleted.

  • platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp:

(WebCore::ImageBufferCairoImageSurfaceBackend::platformTransformColorSpace):

  • platform/graphics/cairo/NativeImageCairo.cpp:

(WebCore::nativeImageSinglePixelSolidColor):

  • platform/graphics/cg/ColorCG.cpp:

(WebCore::makeSimpleColorFromCGColor):
(WebCore::Color::Color):
(WebCore::cachedCGColor):
(WebCore::makeRGBAFromCGColor): Deleted.

  • platform/graphics/gtk/ColorGtk.cpp:

(WebCore::Color::Color):

  • platform/graphics/mac/ColorMac.mm:

(WebCore::makeSimpleColorFromNSColor):
(WebCore::colorFromNSColor):
(WebCore::semanticColorFromNSColor):
(WebCore::makeRGBAFromNSColor): Deleted.

  • platform/graphics/win/ColorDirect2D.cpp:

(WebCore::Color::Color):

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawDotsForDocumentMarker):

  • platform/graphics/win/PlatformContextDirect2D.cpp:

(WebCore::PlatformContextDirect2D::brushWithColor):

  • platform/ios/ColorIOS.mm:

(WebCore::colorFromUIColor):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionBackground):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintResizer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::patternForTouchAction):
(WebCore::patternForEventListenerRegionType):

  • rendering/RenderThemeAdwaita.cpp:
  • rendering/RenderThemeMac.mm:

(WebCore::menuBackgroundColor):

Source/WebKit:

  • UIProcess/ios/WKContentViewInteraction.mm:

(compositionHighlights):
Update for new name of CompositionHighlight::defaultCompositionFillColor.

Tools:

  • TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):
Update test for rename of makeRGBAFromHSLA to makeSimpleColorFromHSLA.

9:41 AM Changeset in webkit [262127] by Alan Bujtas
  • 230 edits
    1 copy
    3 adds in trunk

[Subpixel layout] Bad scrolling on mercurynews.com article
https://bugs.webkit.org/show_bug.cgi?id=201038
<rdar://problem/28489812>

Reviewed by Dean Jackson.

Source/WebCore:

The scrolling is caused by the mismatching subpixel handling between block and inline content.
Inline content (and in this particular case ascent/descent handling) is still integral based while block content supports fractional pixel values.
When the (inline)line height relies on the (block)inline-block height, we need to make sure that the computed line height encloses the inline-block.
This patch changes the rounding behavior of computed the line height from floor to round.

Test: fast/inline/hidpi-inline-block-is-subpixel-while-line-is-not.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::baselinePosition const):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox const):

LayoutTests:

  • fast/inline/hidpi-inline-block-is-subpixel-while-line-is-not-expected.html: Added.
  • fast/inline/hidpi-inline-block-is-subpixel-while-line-is-not.html: Added.
  • platform/ios/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/ios/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/ios/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/ios/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/ios/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/ios/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/ios/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/ios/fast/borders/fieldsetBorderRadius-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/fieldsetBorderRadius-expected.txt.
  • platform/ios/fast/forms/select-item-background-clip-expected.txt:
  • platform/ios/fast/gradients/list-item-gradient-expected.txt:
  • platform/ios/fast/html/details-add-child-1-expected.txt:
  • platform/ios/fast/html/details-add-child-2-expected.txt:
  • platform/ios/fast/html/details-add-details-child-1-expected.txt:
  • platform/ios/fast/html/details-add-details-child-2-expected.txt:
  • platform/ios/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-1-expected.txt:
  • platform/ios/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-10-expected.txt:
  • platform/ios/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-2-expected.txt:
  • platform/ios/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-3-expected.txt:
  • platform/ios/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-4-expected.txt:
  • platform/ios/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-5-expected.txt:
  • platform/ios/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-6-expected.txt:
  • platform/ios/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-7-expected.txt:
  • platform/ios/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-8-expected.txt:
  • platform/ios/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-9-expected.txt:
  • platform/ios/fast/html/details-add-summary-child-1-expected.txt:
  • platform/ios/fast/html/details-add-summary-child-2-expected.txt:
  • platform/ios/fast/html/details-marker-style-expected.txt:
  • platform/ios/fast/html/details-marker-style-mixed-expected.txt:
  • platform/ios/fast/html/details-nested-1-expected.txt:
  • platform/ios/fast/html/details-nested-2-expected.txt:
  • platform/ios/fast/html/details-no-summary1-expected.txt:
  • platform/ios/fast/html/details-no-summary2-expected.txt:
  • platform/ios/fast/html/details-no-summary3-expected.txt:
  • platform/ios/fast/html/details-no-summary4-expected.txt:
  • platform/ios/fast/html/details-open-javascript-expected.txt:
  • platform/ios/fast/html/details-open1-expected.txt:
  • platform/ios/fast/html/details-open2-expected.txt:
  • platform/ios/fast/html/details-open3-expected.txt:
  • platform/ios/fast/html/details-open4-expected.txt:
  • platform/ios/fast/html/details-open5-expected.txt:
  • platform/ios/fast/html/details-open6-expected.txt:
  • platform/ios/fast/html/details-position-expected.txt:
  • platform/ios/fast/html/details-remove-child-1-expected.txt:
  • platform/ios/fast/html/details-remove-child-2-expected.txt:
  • platform/ios/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-1-expected.txt:
  • platform/ios/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-2-expected.txt:
  • platform/ios/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-3-expected.txt:
  • platform/ios/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-4-expected.txt:
  • platform/ios/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-5-expected.txt:
  • platform/ios/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-6-expected.txt:
  • platform/ios/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/ios/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/ios/fast/html/details-replace-summary-child-expected.txt:
  • platform/ios/fast/html/details-replace-text-expected.txt:
  • platform/ios/fast/html/details-writing-mode-expected.txt:
  • platform/ios/fast/html/details-writing-mode-mixed-expected.txt:
  • platform/ios/fast/writing-mode/fieldsets-expected.txt:
  • platform/ios/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/ios/mathml/presentation/mo-stretch-expected.txt:
  • platform/ios/mathml/presentation/roots-expected.txt:
  • platform/mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
  • platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt:
  • platform/mac/fast/forms/basic-buttons-expected.txt:
  • platform/mac/fast/html/details-add-child-1-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-add-details-child-1-expected.txt:
  • platform/mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-expected.txt:
  • platform/mac/fast/html/details-add-summary-child-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-child-2-expected.txt:
  • platform/mac/fast/html/details-marker-style-expected.txt:
  • platform/mac/fast/html/details-nested-1-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-no-summary1-expected.txt:
  • platform/mac/fast/html/details-no-summary2-expected.txt:
  • platform/mac/fast/html/details-no-summary3-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open1-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open3-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-open5-expected.txt:
  • platform/mac/fast/html/details-open6-expected.txt:
  • platform/mac/fast/html/details-position-expected.txt:
  • platform/mac/fast/html/details-remove-child-1-expected.txt:
  • platform/mac/fast/html/details-remove-child-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/mac/fast/html/details-replace-text-expected.txt:
  • platform/mac/fast/html/details-writing-mode-expected.txt:
  • platform/mac/fast/writing-mode/fieldsets-expected.txt:
  • platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
9:03 AM Changeset in webkit [262126] by Diego Pino Garcia
  • 5 edits
    1 move
    1 delete in trunk/LayoutTests

[WPE] Gardening, update test expectations after r262120
https://bugs.webkit.org/show_bug.cgi?id=212353

Unreviewed gardening.

  • platform/glib/TestExpectations:
  • platform/glib/fast/canvas/webgl/webgl-compressed-texture-astc-expected.txt: Renamed from LayoutTests/platform/gtk/fast/canvas/webgl/webgl-compressed-texture-astc-expected.txt.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/canvas/webgl/readPixels-float-expected.txt: Removed.
  • platform/wpe/TestExpectations:
  • platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt: Emit baseline after r260075.
7:47 AM Changeset in webkit [262125] by commit-queue@webkit.org
  • 4 edits in trunk

Use child text content when determining whether to bail early in running a script
https://bugs.webkit.org/show_bug.cgi?id=182695

Patch by Rob Buis <rbuis@igalia.com> on 2020-05-25
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update improved test results.

  • web-platform-tests/html/semantics/scripting-1/the-script-element/emptyish-script-elements-expected.txt:

Source/WebCore:

Check that the text content is not empty instead of just checking
for the first child [1].

Behavior matches Chrome and Firefox.

[1] https://html.spec.whatwg.org/#prepare-a-script step 5 and 6

Test: web-platform-tests/html/semantics/scripting-1/the-script-element/emptyish-script-elements.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

7:18 AM Changeset in webkit [262124] by svillar@igalia.com
  • 7 edits in trunk

[css-flex] Allow indefinite size flex items to be definite wrt resolving percentages inside them
https://bugs.webkit.org/show_bug.cgi?id=212264

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-flexbox/percentage-heights-003-expected.txt: There were 3 subtests

marked as failures. All of them work fine now.

Source/WebCore:

Implement https://github.com/w3c/csswg-drafts/commit/5b5db39d21f3658ae2f4d7992daaf822aca178d8 which modified
the way percentages were resolved in flexible items with indefinite sizes. From now on we can pretend that
they're really definite.

This allows us to mark 3 tests which were testing percentages in flex items as correct.

Based on Blink's crrev.com/1247184 by <cbiesinger@chromium.org>

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution): Do only check flex container main size
definiteness when computing the main size for percentage resolution, no need to check flex basis at all.

LayoutTests:

  • css3/flexbox/definite-main-size-expected.txt: Updated expectation.
  • css3/flexbox/definite-main-size.html: Updated comment.
6:58 AM Changeset in webkit [262123] by Diego Pino Garcia
  • 3 edits in trunk/LayoutTests

[GTK] Gardening, update test expectations after r262060
https://bugs.webkit.org/show_bug.cgi?id=212346

Unreviewed gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
6:34 AM Changeset in webkit [262122] by youenn@apple.com
  • 3 edits in trunk/Source/WebCore

AVVideoCaptureSource should notify of video samples in a background thread
https://bugs.webkit.org/show_bug.cgi?id=212072

Reviewed by Eric Carlson.

Do not hop to the main thread to send samples.
Instead, directly call the observer callback.
Manually tested.

  • platform/mediastream/mac/AVVideoCaptureSource.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):

4:58 AM Changeset in webkit [262121] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Flatpak][GStreamer] compilation fails when GST_BUILD_PATH is defined
https://bugs.webkit.org/show_bug.cgi?id=212343

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2020-05-25
Reviewed by Philippe Normand.

Flatpak's command has to be expressed before gst-env declaration.

  • flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

4:31 AM Changeset in webkit [262120] by Adrian Perez de Castro
  • 3 edits in trunk/Source/WebCore

Non-unified build fixes, late May 2020 edition
https://bugs.webkit.org/show_bug.cgi?id=212342

Unreviewed build fix.

No new tests needed.

  • loader/ImageLoader.h: Add missing inclusion of Element.h and remove forward declaration.
  • page/PageConfiguration.h: Add missing inclusion of ShouldRelaxThirdPartyCookieBlocking.h
3:10 AM Changeset in webkit [262119] by Adrian Perez de Castro
  • 4 edits in trunk

[WPE][WKTR] Fix typo in EventSenderProxyWPE
https://bugs.webkit.org/show_bug.cgi?id=212340

Reviewed by Carlos Garcia Campos.

Tools:

  • WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:

(WTR::wpeKeySymForKeyRef): Fix typo rightArror -> rightArrow.

LayoutTests:

  • platform/wpe/TestExpectations: fast/events/keydown-numpad-keys.html is now passing.
1:37 AM Changeset in webkit [262118] by Diego Pino Garcia
  • 2 edits
    4 adds in trunk/LayoutTests

[GTK][WPE] Gardening, emit baselines for update-the-source-set.html after r261929.
https://bugs.webkit.org/show_bug.cgi?id=212216

Unreviewed gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt: Added.
1:33 AM Changeset in webkit [262117] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

REGRESSION(r262057): [Flatpak SDK] sccache-dist server no longer starting
https://bugs.webkit.org/show_bug.cgi?id=212326

Patch by Philippe Normand <pnormand@igalia.com> on 2020-05-25
Reviewed by Žan Doberšek.

A few mount points were missing in the sandbox created by
flatpak run preventing the sccache-dist server to start and keep running.

  • flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

  • flatpak/webkit-bwrap:
1:31 AM Changeset in webkit [262116] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Flatpak SDK] Fixup icecc support
https://bugs.webkit.org/show_bug.cgi?id=212301

Patch by Philippe Normand <pnormand@igalia.com> on 2020-05-25
Reviewed by Žan Doberšek.

  • flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): Allow homedir access from the
sandbox, this is needed because the icecc toolchains paths refer
to the host environment, not the sandbox.
(WebkitFlatpak.pack_toolchain): Fix byte-string formatting issue, happening in Python3.

1:16 AM Changeset in webkit [262115] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK4] SDK contains too old GTK4
https://bugs.webkit.org/show_bug.cgi?id=212334

Patch by Philippe Normand <pnormand@igalia.com> on 2020-05-25
Reviewed by Adrian Perez de Castro.

  • buildstream/elements/sdk/gtk.bst: Update GTK4 to 3.98.4.
12:52 AM Changeset in webkit [262114] by youenn@apple.com
  • 5 edits in trunk/Source/WebCore

MediaPlayerPrivateMediaStreamAVFObjC::m_activeVideoTrack should be a VideoTrackPrivateMediaStream
https://bugs.webkit.org/show_bug.cgi?id=212129

Reviewed by Eric Carlson.

Instead of looking in the map when wanting to get the VideoTrackPrivateMediaStream corresponding to the active video track,
store directly the VideoTrackPrivateMediaStream as the active video track and use streamTrack() to get the corresponding MediaStreamTrack.
Small refactoring to use more Ref<>.
Covered by existing tests.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::videoSampleAvailable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::sampleBufferDisplayLayerStatusDidChange):
(WebCore::updateTracksOfType):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::checkSelectedVideoTrack):

  • platform/mediastream/AudioTrackPrivateMediaStream.h:
  • platform/mediastream/VideoTrackPrivateMediaStream.h:

May 24, 2020:

11:28 PM Changeset in webkit [262113] by youenn@apple.com
  • 3 edits in trunk/Source/WebCore

Do not allocate a WebAudioBufferList in the AudioContext rendering thread
https://bugs.webkit.org/show_bug.cgi?id=212132

Reviewed by Eric Carlson.

Instead of allocating the buffer in the rendering thread, we do that in the audio sample producer thread.
Also, we do it only once versus one for each rendering call previously.
Covered by existing tests.

  • platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h:
  • platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):
(WebCore::WebAudioSourceProviderAVFObjC::unprepare):

11:25 PM Changeset in webkit [262112] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebKit

Remove NetworkProcess/FileAPI
https://bugs.webkit.org/show_bug.cgi?id=212335

Patch by Rob Buis <rbuis@igalia.com> on 2020-05-24
Reviewed by Sam Weinig.

Remove NetworkProcess/FileAPI, the only file it contains is unused.
It seems this could have been removed in r248593.

  • NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: Removed.
12:29 PM Changeset in webkit [262111] by Wenson Hsieh
  • 3 edits in trunk/Source/WebCore

Add some missing includes due to unified sources
https://bugs.webkit.org/show_bug.cgi?id=212306

Reviewed by Anders Carlsson.

  • Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp: Include EnterPictureInPictureEvent.h.
  • platform/PictureInPictureObserver.h: Include WeakPtr and forward declare the IntSize class.
12:13 PM Changeset in webkit [262110] by weinig@apple.com
  • 6 edits
    2 adds in trunk/Source/WebCore

Extended Color Cleanup: Move SimpleColor into its own files
https://bugs.webkit.org/show_bug.cgi?id=212309

Reviewed by Simon Fraser.

Move SimpleColor into its own files. It's about time.

  • Headers.cmake:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Color.cpp:

(WebCore::premultipliedChannel): Deleted.
(WebCore::unpremultipliedChannel): Deleted.
(WebCore::makePremultipliedRGBA): Deleted.
(WebCore::makeUnPremultipliedRGBA): Deleted.
(WebCore::colorFloatToRGBAByte): Deleted.
(WebCore::makeRGBA32FromFloats): Deleted.
(WebCore::makeRGBAFromHSLA): Deleted.
(WebCore::makeRGBAFromCMYKA): Deleted.
(WebCore::SimpleColor::serializationForHTML const): Deleted.
(WebCore::decimalDigit): Deleted.
(WebCore::fractionDigitsForFractionalAlphaValue): Deleted.
(WebCore::SimpleColor::serializationForCSS const): Deleted.
(WebCore::RGBA32::serializationForRenderTreeAsText const): Deleted.

  • platform/graphics/Color.h:

(WebCore::SimpleColor::SimpleColor): Deleted.
(WebCore::SimpleColor::value const): Deleted.
(WebCore::SimpleColor::redComponent const): Deleted.
(WebCore::SimpleColor::greenComponent const): Deleted.
(WebCore::SimpleColor::blueComponent const): Deleted.
(WebCore::SimpleColor::alphaComponent const): Deleted.
(WebCore::SimpleColor::alphaComponentAsFloat const): Deleted.
(WebCore::SimpleColor::isOpaque const): Deleted.
(WebCore::SimpleColor::isVisible const): Deleted.
(WebCore::SimpleColor::colorWithAlpha const): Deleted.
(WebCore::SimpleColor::get const): Deleted.
(WebCore::roundAndClampColorChannel): Deleted.
(WebCore::fastMultiplyBy255): Deleted.
(WebCore::fastDivideBy255): Deleted.
(WebCore::makeRGB): Deleted.
(WebCore::makeRGBA): Deleted.

  • platform/graphics/SimpleColor.cpp: Copied from platform/graphics/Color.cpp.

(WebCore::SimpleColor::serializationForRenderTreeAsText const):
(): Deleted.
(WebCore::colorFloatToRGBAByte): Deleted.
(WebCore::parseHexColorInternal): Deleted.
(WebCore::Color::parseHexColor): Deleted.
(WebCore::differenceSquared): Deleted.
(WebCore::findNamedColor): Deleted.
(WebCore::Color::Color): Deleted.
(WebCore::Color::operator=): Deleted.
(WebCore::Color::serialized const): Deleted.
(WebCore::Color::cssText const): Deleted.
(WebCore::RGBA32::serializationForRenderTreeAsText const): Deleted.
(WebCore::Color::nameForRenderTreeAsText const): Deleted.
(WebCore::Color::light const): Deleted.
(WebCore::Color::dark const): Deleted.
(WebCore::Color::isDark const): Deleted.
(WebCore::Color::lightness const): Deleted.
(WebCore::blendComponent): Deleted.
(WebCore::Color::blend const): Deleted.
(WebCore::Color::blendWithWhite const): Deleted.
(WebCore::Color::colorWithAlphaMultipliedBy const): Deleted.
(WebCore::Color::colorWithAlphaMultipliedByUsingAlternativeRounding const): Deleted.
(WebCore::Color::colorWithAlpha const): Deleted.
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const): Deleted.
(WebCore::Color::colorSpaceAndComponents const): Deleted.
(WebCore::Color::toSRGBASimpleColorLossy const): Deleted.
(WebCore::Color::toSRGBAComponentsLossy const): Deleted.
(WebCore::extendedColorsEqual): Deleted.
(WebCore::blend): Deleted.
(WebCore::blendWithoutPremultiply): Deleted.
(WebCore::Color::tagAsValid): Deleted.
(WebCore::Color::asExtended const): Deleted.
(WebCore::operator<<): Deleted.

  • platform/graphics/SimpleColor.h: Copied from platform/graphics/Color.h.

(WebCore::SimpleColor::alphaComponentAsFloat const):
(WebCore::SimpleColor::colorWithAlpha const):
(WebCore::SimpleColor::get const):
(WebCore::colorFloatToRGBAByte):
(WebCore::Color::Color): Deleted.
(WebCore::Color::isHashTableDeletedValue const): Deleted.
(WebCore::Color::~Color): Deleted.
(WebCore::Color::isValid const): Deleted.
(WebCore::Color::isOpaque const): Deleted.
(WebCore::Color::isVisible const): Deleted.
(WebCore::Color::red const): Deleted.
(WebCore::Color::green const): Deleted.
(WebCore::Color::blue const): Deleted.
(WebCore::Color::alpha const): Deleted.
(WebCore::Color::alphaAsFloat const): Deleted.
(WebCore::Color::opaqueColor const): Deleted.
(WebCore::Color::isSemantic const): Deleted.
(WebCore::Color::isExtended const): Deleted.
(WebCore::Color::setRGB): Deleted.
(WebCore::Color::setIsSemantic): Deleted.
(WebCore::equalIgnoringSemanticColor): Deleted.
(WebCore::Color::hash const): Deleted.
(WebCore::Color::colorWithAlphaMultipliedByUsingAlternativeRounding const): Deleted.
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const): Deleted.
(WebCore::Color::rgb const): Deleted.
(WebCore::Color::isBlackColor): Deleted.
(WebCore::Color::isWhiteColor): Deleted.
(WebCore::Color::encode const): Deleted.
(WebCore::Color::decode): Deleted.

10:25 AM WebKitEmacsTips edited by Philippe Normand
(diff)
10:15 AM Changeset in webkit [262109] by Alan Bujtas
  • 4 edits
    2 adds in trunk

[LFC][TFC] Ignore section borders even when border collapse is off.
https://bugs.webkit.org/show_bug.cgi?id=212336

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-thead-border-ignore.html

  • layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):

LayoutTests:

  • fast/layoutformattingcontext/table-simple-thead-border-ignore-expected.html: Added.
  • fast/layoutformattingcontext/table-simple-thead-border-ignore.html: Added.
8:53 AM Changeset in webkit [262108] by weinig@apple.com
  • 28 edits in trunk

Extended Color Cleanup: Stop allowing direct access to the underlying SimpleColor (it is almost always incorrect with respect to extended colors)
https://bugs.webkit.org/show_bug.cgi?id=212184

Reviewed by Dean Jackson.

Source/WebCore:

  • Makes Color::rgb() private, removing a class of extended color bugs from users of the Color class. To get the equivilent functionality, users of the class must now use toSRGBASimpleColorLossy() which does actually does the conversion to sRGB if necessary and makes it clear to the caller that precision is being lost.
  • Removes Color::red()/green()/blue() entirely. They were just calling down to Color::rgb(), and going forward, it won't make sense to think about rgb components of Colors in general, since some extended color spaces don't deal in them (e.g. Lab) Color::alpha() was kept (and fixed to work even with ExtendedColor) since all ExtendedColors do need to have alpha.
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::colorValue const):
Use toSRGBASimpleColorLossy() to get access to color components.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getAttributeSetForAccessibilityObject):
Use toSRGBASimpleColorLossy() to get access to color components.

  • accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::colorValue const):
Use toSRGBASimpleColorLossy() to get access to color components.

  • css/DeprecatedCSSOMRGBColor.h:

Use toSRGBASimpleColorLossy() to get access to color components.

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionsWindowCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionsBackgroundCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionsTextColor const):
User Color::colorWithAlpha() to avoid the need to muck with components directly.

  • platform/graphics/Color.cpp:

(WebCore::differenceSquared):
Use rgb() directly, which is ok, since this is explicitly checking isExtended().
This code is still wrong (there is a FIXME) as it assumes the two colors are in
the same color space.

(WebCore::Color::Color):
Add constructor which takes an ExtendedColor to allow functions like
Color::invertedColorWithAlpha to delegate their functionality to ExtendedColor.

(WebCore::Color::light const):
Use new SimpleColor::colorWithAlpha() to avoid hardcoding constants here.

(WebCore::Color::blend const):
(WebCore::Color::blendWithWhite const):
Use toSRGBASimpleColorLossy() to get access to color components. These
are still not ideal implementations, as they don't preserve extended colors
as well as they could, but now they don't return bogus values for extended
colors. Minor cleanup bringing constants and lambda inside the function they
are used in.

(WebCore::Color::colorWithAlpha const):
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const):
Minor cleanups to use a more consistent style and make use of the new
SimpleColor::colorWithAlpha.

(WebCore::Color::invertedColorWithAlpha const):
Added. Used to avoid direct component usage in line box code.

(WebCore::Color::semanticColor const):
Added. Hopefully temporary. Used by RenderThemeIOS.mm to convert
a Color from a map into a Color with the semantic bit set. This
should not be necessary as every color in the map should already
have it set, but to avoid uncessary possible behavior changes this
preserves that functionality until it can be researched further.
Fixing coders to preserve the semantic bit may be required to
elliminate the need.

(WebCore::Color::colorSpaceAndComponents const):
Use rgb() rather than the individual components which have been removed.

  • platform/graphics/Color.h:

(WebCore::SimpleColor::alphaComponentAsFloat const):
Added. Needed by DeprecatedCSSOMRGBColor and useful to Color.

(WebCore::SimpleColor::colorWithAlpha const):
Useful to simplify Color::colorWithAlpha implementations and
in Color::dark().

(WebCore::SimpleColor::get const):
Added tuple interface to SimpleColor to support structure bindings.
NOTE: Unlike the storage of SimpleColor (ARGB), this produces the
bindings in the more familiar [r,g,b,a] to match FloatComponents.

(WebCore::Color::alpha const):
Made work with ExtendedColor as well.

(WebCore::Color::red const): Deleted.
(WebCore::Color::green const): Deleted.
(WebCore::Color::blue const): Deleted.
Removed.

(CGColorRef cachedCGColor):
(int differenceSquared):
Made friends so they could use Color::rgb().

(WebCore::Color::rgb const):
Made private.

  • platform/graphics/ExtendedColor.cpp:

(WebCore::ExtendedColor::invertedColorWithAlpha const):

  • platform/graphics/ExtendedColor.h:

Added invertedColorWithAlpha to allow inversion to be encapsulated.
When future color spaces are added, we may need to choose per-colorspace
algorithms for this instead of the trivial one used today.

  • platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:

(WebCore::PlatformCAAnimationCocoa::setFromValue):
(WebCore::PlatformCAAnimationCocoa::setToValue):
(WebCore::PlatformCAAnimationCocoa::setValues):
Use toSRGBASimpleColorLossy() to get access to color components.

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(PlatformCAAnimationWin::setFromValue):
(PlatformCAAnimationWin::setToValue):
(PlatformCAAnimationWin::setValues):
Use toSRGBASimpleColorLossy() to get access to color components.

  • platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawFocusRing):
Use Color::colorWithAlpha() to avoid needing access to components.

  • platform/graphics/cpu/arm/filters/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):
Use toSRGBASimpleColorLossy() to get access to color components.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::clearColor):
Use toSRGBASimpleColorLossy() to get access to color components.

  • platform/graphics/win/Direct2DOperations.cpp:

(WebCore::Direct2D::drawGlyphs):
Use colorWithAlphaMultipliedBy() to avoid needing access to components.

  • platform/graphics/win/FontCGWin.cpp:

(WebCore::FontCascade::drawGlyphs):
Use colorWithAlphaMultipliedBy() to avoid needing access to components.

  • platform/graphics/win/FontCascadeDirect2D.cpp:

(WebCore::FontCascade::drawGlyphs):
Use colorWithAlphaMultipliedBy() to avoid needing access to components.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paintSelection):
Use invertedColorWithAlpha() to avoid needing access to components.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::resolveStyleForMarkedText):
Use invertedColorWithAlpha() to avoid needing access to components.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):
Use opaqueColor() to avoid needing access to components.

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::systemColor const):
Use opaqueColor() to avoid needing access to components.

  • svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:

(WebCore::SVGAnimationColorFunction::animate):
Use toSRGBASimpleColorLossy() to get access to color components.

Source/WebKit:

  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::animationValueFromKeyframeValue):
Use toSRGBASimpleColorLossy() to get access to color components.

Tools:

  • TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):
Use toSRGBASimpleColorLossy() to get access to color components.

8:34 AM Changeset in webkit [262107] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[LFC][TFC] Take sections into account when computing collapsed border.
https://bugs.webkit.org/show_bug.cgi?id=212311

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-collapsed-tbody-border.html

  • layout/Verification.cpp:

(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree):

  • layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::computeBorderAndPaddingForTableBox):

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):

  • layout/tableformatting/TableGrid.cpp:

(WebCore::Layout::TableGrid::Section::Section):
(WebCore::Layout::TableGrid::appendCell):

  • layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::Section::box const):
(WebCore::Layout::TableGrid::sections const):
(WebCore::Layout::TableGrid::sections):

LayoutTests:

  • fast/layoutformattingcontext/table-simple-collapsed-tbody-border-expected.html: Added.
  • fast/layoutformattingcontext/table-simple-collapsed-tbody-border.html: Added.
8:23 AM Changeset in webkit [262106] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][TFC] Take collapsed in-between row border into account when computing cell height
https://bugs.webkit.org/show_bug.cgi?id=212307

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-collapsed-row-border2.html

  • layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::computedCellBorder const):

LayoutTests:

  • fast/layoutformattingcontext/table-simple-collapsed-row-border2-expected.html: Added.
  • fast/layoutformattingcontext/table-simple-collapsed-row-border2.html: Added.
8:07 AM Changeset in webkit [262105] by Carlos Garcia Campos
  • 2 edits
    1 delete in trunk/Source/WebKit

Unreviewed. Remove unused file since r261570

I forgot to remove DragAndDropHandler.h.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/gtk/DragAndDropHandler.h: Removed.

May 23, 2020:

1:53 PM Changeset in webkit [262104] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][TFC] Take row border into account when computing collapsed borders.
https://bugs.webkit.org/show_bug.cgi?id=212305

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-collapsed-row-border.html

  • layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::computeBorderAndPaddingForTableBox):

LayoutTests:

  • fast/layoutformattingcontext/table-simple-collapsed-row-border-expected.html: Added.
  • fast/layoutformattingcontext/table-simple-collapsed-row-border.html: Added.
1:13 PM Changeset in webkit [262103] by Jack Lee
  • 2 edits in trunk/Source/WebCore
ASSERTION FAILED: (!s_current
&m_view != &s_current->m_view) in RenderTreeBuilder::RenderTreeBuilder

https://bugs.webkit.org/show_bug.cgi?id=212163

Unreviewed. Improve readability. Replace comments with curly brackets for scoping.

  • dom/Document.cpp:

(WebCore::Document::updateRenderTree):

12:47 PM Changeset in webkit [262102] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][TFC] Maximum constraint of a cell should never be smaller than the minimum width
https://bugs.webkit.org/show_bug.cgi?id=212304

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-fixed-width-with-wide-content.html

  • layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::intrinsicWidthConstraintsForCell):

LayoutTests:

  • fast/layoutformattingcontext/table-simple-fixed-width-with-wide-content-expected.html: Added.
  • fast/layoutformattingcontext/table-simple-fixed-width-with-wide-content.html: Added.
10:10 AM Changeset in webkit [262101] by Alan Bujtas
  • 4 edits
    2 adds in trunk

[LFC][TFC] Used height of a cell is the maximum of the computed and the content height.
https://bugs.webkit.org/show_bug.cgi?id=212302

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-tall-cell-content-with-fixed-height.html

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):

  • layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::cellHeigh const):

LayoutTests:

  • fast/layoutformattingcontext/table-simple-tall-cell-content-with-fixed-height-expected.html: Added.
  • fast/layoutformattingcontext/table-simple-tall-cell-content-with-fixed-height.html: Added.
9:35 AM Changeset in webkit [262100] by Caio Lima
  • 8 edits in trunk

[bmalloc] Fix OOM errors on MIPS after r261667
https://bugs.webkit.org/show_bug.cgi?id=212016

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:
  • stress/big-int-mod-memory-stress.js:
  • stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js:

Source/bmalloc:

The way we were calculating newBegin and newEnd on
ObjectTypeTable::set when index is out of bounds didn't consider
cases where bits->begin() - bits->count() or index - ObjectTypeTable::Bits::bitCountPerWord * 4
can underflow and bits->end() + bits->count() can overflow.
Given that, the value used is going to be index or index + 1.
Since we extend the size of bitvector everytime we have an OOB, this can cause a pathological case
that memory will keep extending quite often until systems reachs OOM.
It is reproducible on ARMv7 and MIPS architectures on
stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js,
stress/big-int-mod-memory-stress.js and some other tests.
This patch is including a verification if those operations are going
to overflow/underflow, and properly set newBegin to 0 and newEnd
to UINT_MAX when we observe such behavior.

  • bmalloc/ObjectTypeTable.cpp:

(bmalloc::ObjectTypeTable::set):

LayoutTests:

  • js/script-tests/stack-overflow-regexp.js:
9:21 AM Changeset in webkit [262099] by cturner@igalia.com
  • 2 edits in trunk/Source/WebKit

Error sending IPC message: Broken pipe
https://bugs.webkit.org/show_bug.cgi?id=206052

Reviewed by Adrian Perez de Castro.

The Connection implementation on *nix was not handling socket
shutdowns gracefully, this was leading to many IPC error messages
being printed. It looks like the "errors" were actually
application issues, trying to send messages during socket shutdown
sequences, rather than more serious message drop problems.

Unclear how to autotest this, but manual testing opening lots of tabs
definitely hits these codepaths.

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::readyReadHandler): Handle ECONNRESET by cleanly
closing the connection.
(IPC::Connection::sendOutputMessage): Ditto, also handle the
wrinkle that for "reasons", Linux can return EPIPE when it means
ECONNRESET.

7:57 AM Changeset in webkit [262098] by Paulo Matos
  • 48 edits in trunk/Source/JavaScriptCore

Fix non-unified builds for x86_64
https://bugs.webkit.org/show_bug.cgi?id=212297

Reviewed by Adrian Perez de Castro.

  • b3/B3BasicBlock.cpp:
  • b3/B3CaseCollection.cpp:
  • b3/B3DuplicateTails.cpp:
  • b3/B3EnsureLoopPreHeaders.cpp:
  • b3/B3FenceValue.cpp:
  • b3/B3HoistLoopInvariantValues.cpp:
  • b3/B3LegalizeMemoryOffsets.cpp:
  • b3/B3LowerMacrosAfterOptimizations.cpp:
  • b3/B3LowerToAir.cpp:
  • b3/B3MathExtras.cpp:
  • b3/B3MemoryValue.cpp:
  • b3/B3Procedure.cpp:
  • b3/B3StackmapValue.cpp:
  • b3/B3SwitchValue.cpp:
  • b3/B3UseCounts.cpp:
  • b3/B3Validate.cpp:
  • b3/B3VariableValue.cpp:
  • b3/B3WasmAddressValue.cpp:
  • b3/B3WasmBoundsCheckValue.cpp:
  • ftl/FTLCommonValues.cpp:
  • ftl/FTLCompile.cpp:
  • ftl/FTLOSREntry.cpp:
  • ftl/FTLOSRExitCompiler.cpp:
  • wasm/WasmInstance.cpp:
  • wasm/WasmStreamingParser.cpp:
  • wasm/js/JSToWasm.cpp:
  • wasm/js/JSToWasmICCallee.cpp:
  • wasm/js/JSWebAssembly.cpp:
  • wasm/js/JSWebAssemblyCodeBlock.cpp:
  • wasm/js/WebAssemblyCompileErrorConstructor.cpp:
  • wasm/js/WebAssemblyCompileErrorPrototype.cpp:
  • wasm/js/WebAssemblyFunction.cpp:
  • wasm/js/WebAssemblyFunctionBase.cpp:
  • wasm/js/WebAssemblyGlobalPrototype.cpp:
  • wasm/js/WebAssemblyInstanceConstructor.cpp:
  • wasm/js/WebAssemblyInstancePrototype.cpp:
  • wasm/js/WebAssemblyLinkErrorConstructor.cpp:
  • wasm/js/WebAssemblyLinkErrorPrototype.cpp:
  • wasm/js/WebAssemblyMemoryConstructor.cpp:
  • wasm/js/WebAssemblyMemoryPrototype.cpp:
  • wasm/js/WebAssemblyModuleConstructor.cpp:
  • wasm/js/WebAssemblyModulePrototype.cpp:
  • wasm/js/WebAssemblyModuleRecord.cpp:
  • wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:
  • wasm/js/WebAssemblyRuntimeErrorPrototype.cpp:
  • wasm/js/WebAssemblyTableConstructor.cpp:
  • wasm/js/WebAssemblyTablePrototype.cpp:
6:34 AM Changeset in webkit [262097] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[LFC][TFC] Non-collapsing row border should not make the table wider/taller
https://bugs.webkit.org/show_bug.cgi?id=212263

Reviewed by Antti Koivisto.

Source/WebCore:

Non-collapsing row border eats into the content box but oddly it does not
constraint the cell boxes, so we can end up with smaller row content box than
the cell box it contains.

Test: fast/layoutformattingcontext/table-simple-row-border.html

  • layout/LayoutUnits.h:

(WebCore::Layout::Edges::width const):
(WebCore::Layout::Edges::height const):
(WebCore::Layout::HorizontalEdges::width const): Deleted.
(WebCore::Layout::VerticalEdges::height const): Deleted.

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):

  • layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::intrinsicWidthConstraintsForCell):

LayoutTests:

  • fast/layoutformattingcontext/table-simple-row-border-expected.html: Added.
  • fast/layoutformattingcontext/table-simple-row-border.html: Added.

May 22, 2020:

10:55 PM Changeset in webkit [262096] by yoshiaki.jitsukawa@sony.com
  • 5 edits in trunk

[PlayStation] Enable JSC shell to run
https://bugs.webkit.org/show_bug.cgi?id=212294

Reviewed by Ross Kirsling.

.:

  • Source/cmake/OptionsPlayStation.cmake:

Source/JavaScriptCore:

  • shell/PlatformPlayStation.cmake:

Set working directory for Visual Studio

  • shell/playstation/Initializer.cpp:

Load libJavaScriptCore as we now build it as SHARED.

10:53 PM Changeset in webkit [262095] by Jack Lee
  • 8 edits
    3 adds in trunk
ASSERTION FAILED: (!s_current
&m_view != &s_current->m_view) in RenderTreeBuilder::RenderTreeBuilder

https://bugs.webkit.org/show_bug.cgi?id=212163
<rdar://problem/57028096>

Reviewed by Geoffrey Garen.

Source/WebCore:

Calling ~PostResolutionCallbackDisabler() before completing render tree updating and releasing RenderTreeBuilder
triggers this assertion. Therefore we added a utility function "updateRenderTree" in which PostResolutionCallback
is delayed until RenderTreeUpdater is released and m_inRenderTreeUpdate is cleared.

Test: fast/rendering/nested-render-tree-update-crash.html

  • Headers.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::updateRenderTree):
(WebCore::Document::resolveStyle):
(WebCore::Document::updateTextRenderer):

  • dom/Document.h:
  • rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::RenderTreeUpdater):
(WebCore::RenderTreeUpdater::commit):

  • rendering/updating/RenderTreeUpdater.h:

LayoutTests:

Added a regression test for the crash.

  • fast/rendering/nested-render-tree-update-crash-expected.txt: Added.
  • fast/rendering/nested-render-tree-update-crash.html: Added.
9:23 PM Changeset in webkit [262094] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Stuttery overflow scrolling in slow-scrolling regions (facebook messenger, feedly.com)
https://bugs.webkit.org/show_bug.cgi?id=212291
<rdar://problem/61940624>

Reviewed by Tim Horton.

Now that we do scrolling tree commits on the main thread, ThreadedScrollingTree::scrollingTreeNodeDidScroll()
can be called on the main thread. In this case, don't do an RunLoop::main().dispatch() which introduces
asynchrony; just call into the ScrollingCoordinator synchronously.

Do some minor refactoring to move noteScrollingThreadSyncCompleteForNode() into updateScrollPositionAfterAsyncScroll().

Hard to test because it involves scrolling thread/main thread interactions.

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::synchronizeStateFromScrollingTree):
(WebCore::AsyncScrollingCoordinator::scheduleUpdateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScrollTimerFired):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):

9:03 PM Changeset in webkit [262093] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Nullptr deref in WebCore::RenderTreeBuilder::Block::attachIgnoringContinuation when parent and beforeChild are siblings
https://bugs.webkit.org/show_bug.cgi?id=212116
<rdar://problem/62993844>

Reviewed by Simon Fraser.

Source/WebCore:

This patch fixes the case when a nested fragmented context has a spanner and we try to form a continuation while this nested fragmented context is being destroyed.

  1. The continuation is triggered by a style change that turns a previously out-of-flow block container into an inflow box

(and the parent inline level container can't have the box as a direct child anymore).

  1. An unrelated style change nukes the nested fragmented context. We need to "re-assign" the spanner to the parent fragment.

These 2 changes are split into 2 phases; first we take care of the tree mutation triggered by the continuation (updateRendererStyle), while
we do the fragmented context cleanup (updateAfterDescendants) in a separate step.
This 2 phase setup confuses the "where to put this spanner" logic.

This patch addresses the issue by keeping the spanner inside the about-to-be-destroyed fragmented context while forming the continuation (phase #1) and let the second phase (updateAfterDescendants)
deal with the spanner moving.

Test: fast/multicol/nested-multicol-with-spanner-and-continuation.html

  • rendering/updating/RenderTreeBuilderMultiColumn.cpp:

(WebCore::isValidColumnSpanner):

LayoutTests:

  • fast/multicol/nested-multicol-with-spanner-and-continuation-expected.txt: Added.
  • fast/multicol/nested-multicol-with-spanner-and-continuation.html: Added.
8:31 PM Changeset in webkit [262092] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

WTF::isValidEnum() has a typo in static_assert making it a tautological comparison
<https://webkit.org/b/212290>

Reviewed by Yusuke Suzuki.

  • wtf/EnumTraits.h:

(WTF::isValidEnum): Use sizeof(std::underlying_type_t<E>)
instead of std::underlying_type_t<E>() to fix the bug.

7:26 PM Changeset in webkit [262091] by commit-queue@webkit.org
  • 4 edits in trunk

[ANGLE - iOS] webgl/1.0.3/conformance/extensions/ext-sRGB.html is failing
https://bugs.webkit.org/show_bug.cgi?id=212277

Patch by Kenneth Russell <kbr@chromium.org> on 2020-05-22
Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

Properly translate GL_EXT_sRGB enums to ES 3.0 enums when
GL_EXT_sRGB is not supported.

  • src/libANGLE/renderer/gl/formatutilsgl.cpp:

(rx::nativegl::GetNativeInternalFormat):
(rx::nativegl::GetNativeFormat):

LayoutTests:

Remove failure expectation for the layout test on iOS.

  • platform/ios/TestExpectations:
5:54 PM Changeset in webkit [262090] by yoshiaki.jitsukawa@sony.com
  • 1 edit in trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake

Unreviewed build fix for Visual Studio JSC-only build.

5:52 PM Changeset in webkit [262089] by James Savage
  • 1 edit
    19 adds in trunk/Source/WebKit

Create Swift overlay for WebKit framework
https://bugs.webkit.org/show_bug.cgi?id=211270
<rdar://problem/60549174>

Reviewed by Brady Eidson.

Provides Swift-only overlay methods for our NS_REFINED_FOR_SWIFT API.
The overlay does not provide different API than its Objective-C counterparts,
so overlay testing focuses on ensuring that the overlay produces the
expected interface, and provides the expected mappings to and from ObjC.

The overlay is defined in a separate Xcode project (from WebKit) by
recommendation from the Swift team. Due to build system constraints this
project cannot be a sibbling of WebKit.xcodeproj, and must live in a
subdirectory. However, because it generally acts as part of the WebKit
framework, it still uses the same Version.xcconfig and source file
locations as standard WebKit sources.

  • SwiftOverlay/Configurations/Base.xcconfig: Added. Set some default

warnings and product configuration.

  • SwiftOverlay/Configurations/WebKitSwiftOverlay-maccatalyst.xcconfig: Added.

Override SDK configurations to build for Catalyst.

  • SwiftOverlay/Configurations/WebKitSwiftOverlay.xcconfig: Added.

These flags were all provided by the Xcode template.

  • SwiftOverlay/Configurations/WebKitSwiftOverlayTests-maccatalyst.xcconfig: Added.

See above.

  • SwiftOverlay/Configurations/WebKitSwiftOverlayTests.xcconfig: Added.

See above.

  • SwiftOverlay/SwiftOverlay/install-swiftmodules.sh: Added. Provided by the

Swift team.

  • SwiftOverlay/Tests/WebKitSwiftOverlayTests-Info.plist: Added.
  • SwiftOverlay/Tests/WebKitTests.swift: Added.

(WebKitTests.testAPI): This ensures that the function names come through as we

expect them to. It also ensures that the functions were correctly set to
public visiblity.

(WebKitTests.testWKPDFConfigurationRect): This does the same as the above, but

also exercises the null <-> nil conversion, and that regular values are
correctly round tripped to Objective-C.

  • SwiftOverlay/WebKitSwiftOverlay.xcodeproj/project.pbxproj: Added.
  • SwiftOverlay/WebKitSwiftOverlay.xcodeproj/xcshareddata/xcschemes/Everything (Catalyst).xcscheme: Added.
  • SwiftOverlay/WebKitSwiftOverlay.xcodeproj/xcshareddata/xcschemes/Everything.xcscheme: Added.
  • UIProcess/API/Cocoa/WebKitSwiftOverlay.swift: Added.

(WKPDFConfiguration.rect): Provide mapping of CGRect.null to nil for Swift.
(WKWebView.callAsyncJavaScript(_:arguments:in:completion:)): Provide a Result
in the completion handler, and default value for arguments.
(WKWebView.evaluateJavaScript(_:in:completion:)): Ditto.
(WKWebView.createPDF(configuration:completionHandler:)): Provide a Swift function

that takes a Result<Data, Error> instead of (Data?, Error?) tuple. Provide
a default value for the configuration.

(WKWebView.createWebArchiveData(completionHandler:)): See above.
(WKWebView.find(_:configuration:completionHandler:)): See above.

4:50 PM Changeset in webkit [262088] by Alexey Shvayka
  • 4 edits in trunk

Array.prototype.splice doesn't set "length" of returned object
https://bugs.webkit.org/show_bug.cgi?id=212285

Reviewed by Darin Adler.

JSTests:

  • test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This change implements step 12 of Array.prototype.splice [1], which is observable
if result object is not JSArray, aligning JSC with V8 and SpiderMonkey.

Only slow path of splice() is affected by this patch; zero-argument case already
performs setLength(). Microbenchmarks are neutral.

[1]: https://tc39.es/ecma262/#sec-array.prototype.splice

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSplice):

4:21 PM Changeset in webkit [262087] by Chris Dumez
  • 5 edits in trunk/Source

RELEASE_ASSERT() that InitializeWebKit2() is getting called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=212283

Reviewed by Alex Christensen.

Source/WebKit:

RELEASE_ASSERT() that InitializeWebKit2() is getting called on the main thread, behind
a linked-on-after check. In r217137, we tried to add a dispatch_sync() to the main thread to
work around the issue but it was a hack and it can cause deadlocks. It is best to force
developers to fix their code by crashing.

  • Shared/Cocoa/WebKit2InitializeCocoa.mm:

(WebKit::runInitializationCode):
(WebKit::InitializeWebKit2):

  • UIProcess/Cocoa/VersionChecks.h:

Source/WTF:

  • wtf/spi/darwin/dyldSPI.h:
3:52 PM Changeset in webkit [262086] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove failure expectation for webgl/1.0.3/conformance/extensions/webgl-depth-texture.html on iOS
https://bugs.webkit.org/show_bug.cgi?id=212284

Patch by Kenneth Russell <kbr@chromium.org> on 2020-05-22
Reviewed by Dean Jackson.

Remove failure expectations for this test on iOS since it's now
passing completely, as on other platforms.

  • platform/ios/webgl/1.0.3/conformance/extensions/webgl-depth-texture-expected.txt: Removed.
3:50 PM Changeset in webkit [262085] by Chris Dumez
  • 4 edits
    2 adds in trunk

Revoking an object URL immediately after triggering navigation causes navigation to fail
https://bugs.webkit.org/show_bug.cgi?id=212279
<rdar://problem/63553090>

Reviewed by Geoffrey Garen.

Source/WebCore:

When doing a policy check for a Blob URL, we clone the blob and create a new temporary Blob URL
that stays alive for the duration of the policy check. We made sure to update the ResourceRequest
URL with the new Blob URL, however, we were failing to update the DocumentLoader's request.
As a result, if the client responded with Policy USE, the DocumentLoader would still attempt to
navigate to the old Blob URL.

Test: fast/loader/revoke-blob-url-after-navigation.html

  • loader/PolicyChecker.cpp:

(WebCore::FrameLoader::PolicyChecker::extendBlobURLLifetimeIfNecessary const):
(WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy):
(WebCore::FrameLoader::PolicyChecker::checkNewWindowPolicy):

  • loader/PolicyChecker.h:

LayoutTests:

Add layout test coverage.

  • fast/loader/revoke-blob-url-after-navigation-expected.txt: Added.
  • fast/loader/revoke-blob-url-after-navigation.html: Added.
3:43 PM Changeset in webkit [262084] by commit-queue@webkit.org
  • 6 edits in trunk

Make download resume workaround forgiving of changes in CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=212273

Patch by Alex Christensen <achristensen@webkit.org> on 2020-05-22
Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

They broke my workaround. See rdar://problem/63512518

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:]):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3:31 PM Changeset in webkit [262083] by sbarati@apple.com
  • 33 edits
    2 adds in trunk

in_by_val inside structure property for-in loop should use an opcode like has_structure_property but for "in"
https://bugs.webkit.org/show_bug.cgi?id=212239

Reviewed by Tadeu Zagallo.

JSTests:

  • microbenchmarks/in-by-val-inside-for-in-loop.js: Added.

(assert):
(count):

  • stress/in-by-val-inside-for-in-loop.js: Added.

(assert):
(test1.count):
(test1):
(test2.count):
(test2):
(test3.count):
(test3):
(test4.count):
(test4):
(test5.count):
(test5):
(test6.count):
(test6):
(test7.count):
(test7):
(test8.count):
(test8):

Source/JavaScriptCore:

There is code inside Speedometer 2 that is like:

`
for (let p in o) {

if (p in o2)

...

}
`

Where o and o2 frequently share the same structure. Elm does this when it's
diffing two objects. We already optimize o2[p] (get_by_val) in the above loop
for structure properties. This patch adds that same optimization for in_by_val.
Because we already emit a "structure" loop for for-in, where we iterate structure
properties, the fast path for the above, where o and o2 have the same
structure is simply a structure check followed by return true.

This patch introduces the new opcode: op_in_structure_property. Its fast path is identical
to op_has_structure_property. Its slow path, however, behaves like "in", which
uses the HasProperty internal method, unlike op_has_structure_property,
which uses the GetOwnProperty internal method. This behavior difference is
observable using Proxy.

This a 5% perf improvement in the Elm subtest in Speedometer 2.

  • bytecode/BytecodeList.rb:
  • bytecode/BytecodeUseDef.cpp:

(JSC::computeUsesForBytecodeIndexImpl):
(JSC::computeDefsForBytecodeIndexImpl):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitInByVal):
(JSC::rewriteOp):
(JSC::StructureForInContext::finalize):

  • bytecompiler/BytecodeGenerator.h:

(JSC::StructureForInContext::addInInst):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInStructureProperty):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileHasStructurePropertyImpl):
(JSC::FTL::DFG::LowerDFGToB3::compileHasStructureProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileInStructureProperty):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_in_structure_property):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_in_structure_property):

  • llint/LLIntOffsetsExtractor.cpp:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::hasPropertyGeneric const):

  • runtime/JSPropertyNameEnumerator.h:
3:27 PM Changeset in webkit [262082] by Russell Epstein
  • 1 copy in tags/Safari-610.1.14.1

Tag Safari-610.1.14.1.

3:25 PM Changeset in webkit [262081] by Russell Epstein
  • 1 delete in tags/Safari-610.1.14.1

Delete tag.

3:08 PM Changeset in webkit [262080] by Russell Epstein
  • 8 edits in branches/safari-610.1.14-branch/Source

Versioning.

3:03 PM Changeset in webkit [262079] by Russell Epstein
  • 1 copy in tags/Safari-610.1.14.1

Tag Safari-610.1.14.1.

2:56 PM Changeset in webkit [262078] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

[ iOS wk2 Release ] editing/async-clipboard/clipboard-item-get-type-basic.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=212281

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
2:54 PM Changeset in webkit [262077] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Storage: don't request the list of IndexedDB database names multiple times for the same security origin
https://bugs.webkit.org/show_bug.cgi?id=212253
<rdar://problem/62945903>

Reviewed by Joseph Pecoraro.

This can happen if additional frames are added that share the same security origin as the
main frame. Simply maintain a Set of security origins that've already been requested for
and ignore any repeat requests.

  • UserInterface/Controllers/IndexedDBManager.js:

(WI.IndexedDBManager):
(WI.IndexedDBManager.prototype._reset):

2:52 PM Changeset in webkit [262076] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Make sure we clean up CFTimerRefs when destroying scrolling tree nodes
https://bugs.webkit.org/show_bug.cgi?id=212278
<rdar://problem/63548212>

Reviewed by Tim Horton.

When destroying scrolling tree nodes, make sure we explicitly stop the RunLoop::Timers,
and do this for all nodes when clearing the m_nodeMap, not just for orphaned nodes as
was done in r262042.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitTreeState):
(WebCore::ScrollingTree::updateTreeFromStateNodeRecursive):
(WebCore::ScrollingTree::removeAllNodes):

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::willBeDestroyed):
(WebCore::ScrollingTreeNode::wasRemovedFromTree): Deleted.

  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::willBeDestroyed):
(WebCore::ScrollingTreeFrameScrollingNodeMac::wasRemovedFromTree): Deleted.

  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:

(WebCore::ScrollingTreeOverflowScrollingNodeMac::willBeDestroyed):
(WebCore::ScrollingTreeOverflowScrollingNodeMac::wasRemovedFromTree): Deleted.

2:45 PM Changeset in webkit [262075] by Wenson Hsieh
  • 7 edits in trunk/Source/WebKit

[IPC] Add support for specifying Async WantsConnection in message files
https://bugs.webkit.org/show_bug.cgi?id=212276

Reviewed by Alex Christensen.

Augments the IPC message receiver generation script to allow for "Async WantsConnection" in .message.in files.
Currently, specifying this in a message causes the connection argument to be passed twice when handling the
IPC message. This is because normal async IPC messages without replies normally don't have the IPC::Connection
argument, and use the overloaded handleMessage(Connection& connection, ...) version of handleMessage when
WantsConnection is specified.

However, in the Async reply case, we already pass in the IPC::Connection. Instead of overloading the method
signature, we introduce a different method instead, named handleMessageAsyncWantsConnection, which forwards
the given IPC::Connection along to the member function.

Test: TestAsyncMessageWithConnection

  • Platform/IPC/HandleMessage.h:

(IPC::handleMessageAsyncWantsConnection):

Add another variant of the message receiver template, for the case where the message receiver wants a connection.
This is similar to handleMessageSynchronousWantsConnection, above.

  • Scripts/test-superclassMessageReceiver.cpp:

(Messages::WebPage::TestAsyncMessageWithConnection::callReply):
(Messages::WebPage::TestAsyncMessageWithConnection::cancelReply):
(Messages::WebPage::TestAsyncMessageWithConnection::send):
(WebKit::WebPage::didReceiveMessage):

  • Scripts/test-superclassMessages.h:

(Messages::WebPage::TestAsyncMessageWithConnection::name):
(Messages::WebPage::TestAsyncMessageWithConnection::asyncMessageReplyName):
(Messages::WebPage::TestAsyncMessageWithConnection::TestAsyncMessageWithConnection):
(Messages::WebPage::TestAsyncMessageWithConnection::arguments const):

  • Scripts/webkit/messages.py:
  • Scripts/webkit/messages_unittest.py:
  • Scripts/webkit/test-superclass.messages.in:
2:30 PM Changeset in webkit [262074] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk

[ANGLE - iOS] fast/canvas/webgl/webgl-depth-texture.html is failing
https://bugs.webkit.org/show_bug.cgi?id=212271

Patch by Kenneth Russell <kbr@chromium.org> on 2020-05-22
Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

Use ES 3.0 sized internal formats for unsized depth/stencil
textures when the OES_depth_texture extension is unavailable - as
is the case in iOS's ES 3.0 driver.

  • src/libANGLE/renderer/gl/formatutilsgl.cpp:

(rx::nativegl::GetNativeInternalFormat):

LayoutTests:

Remove expected failure of webgl-depth-texture on iOS.

  • platform/ios/fast/canvas/webgl/webgl-depth-texture-expected.txt: Removed.
2:03 PM Changeset in webkit [262073] by Andres Gonzalez
  • 2 edits in trunk/Source/WebCore

Updates to the isolated tree must happen before posting notifications to clients.
https://bugs.webkit.org/show_bug.cgi?id=212266

Reviewed by Chris Fleizach.

Multiple tests.

In AXObjectCache::notificationPostTimerFired we were updating the
isolated tree after the notifications were posted to the platform
clients. This caused that in some cases when the client requested info
as the result of those notifications, the isolated tree was out-of-date.
In this patch updateIsolatedTree is called before notifying platform clients.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::notificationPostTimerFired):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::updateIsolatedTree):

1:52 PM Changeset in webkit [262072] by aestes@apple.com
  • 1 edit in trunk/Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm

Attempt to fix the Catalina build after r262069.

1:33 PM Changeset in webkit [262071] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Excessive hang time in iOS Safari under waitForDidUpdateActivityState
https://bugs.webkit.org/show_bug.cgi?id=212272
<rdar://problem/62787789>

Reviewed by Andy Estes.

  • UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateActivityState):
Make the view state change timeout equivalent on iOS and macOS.

We believe that it is preferable to paint white than block the UI
process main thread for half a second. Reduce the timeout on iOS
to be the same as it has been for years on macOS.

1:16 PM Changeset in webkit [262070] by weinig@apple.com
  • 9 edits in trunk/Source/WebCore

Extended Color Cleanup: Make alpha premultiplication code more consistent and clear regarding what works with extended colors
https://bugs.webkit.org/show_bug.cgi?id=212265

Reviewed by Simon Fraser.

  • Adds premultiplied(const FloatComponents&) to do premutiplication directly on FloatComponents rather than doing it on the ints and losing precision.
  • Makes non-FloatComponent alpha premultiplication all take place only for SimpleColors as that is what callers need. The existing premulitplication for ExtendedColors in blend() was incorrect as it never did a conversion to sRGB.
  • Adds new toSRGBASimpleColorLossy() (to complement toSRGBAComponentsLossy()). Will make it easy to find all the conversions in the future.
  • Broke non-premultiplying blend() out of blend() (removing parameter) and made a new blendWithoutPremultiply() function for it (no callers needed to make this decision dynamically).
  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::computeStops):
Use blendWithoutPremultiply() explicitly.

  • platform/graphics/Color.h:
  • platform/graphics/Color.cpp:

(WebCore::makePremultipliedRGBA): Renamed from premultipliedARGBFromColor and now only operates on SimpleColors.
(WebCore::makeUnPremultipliedRGBA): Renamed from colorFromPremultipliedARGB and now only operates on SimpleColors.
(WebCore::colorFromPremultipliedARGB): Deleted.
(WebCore::premultipliedARGBFromColor): Deleted.

(WebCore::Color::toSRGBASimpleColorLossy const):
Added. Useful for finding all non-colorspace preserving users of the color channels.

(WebCore::blend):
(WebCore::blendWithoutPremultiply):
Split these out from each other. Made blend() use toSRGBASimpleColorLossy() and do all
operations on SimpleColors directly. The old code that preported to work with extended
colors was nonsense as it didn't actually take the colorspaces into account, just grabbed
the channels regardless of space.

  • platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp:

(WebCore::ImageBufferCairoImageSurfaceBackend::platformTransformColorSpace):
Adopt update premulitiplication names and stay in SimpleColor for entire conversion.

  • platform/graphics/cairo/NativeImageCairo.cpp:

(WebCore::nativeImageSinglePixelSolidColor):
Adopt update premulitiplication names.

  • platform/graphics/ColorUtilities.cpp:

(WebCore::premultiplied):

  • platform/graphics/ColorUtilities.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawBorder):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawSolidColor):
Add and adopt premultiplied(const FloatComponents&).

1:10 PM Changeset in webkit [262069] by aestes@apple.com
  • 18 edits
    6 copies
    2 adds in trunk

[Apple Pay] Add new ApplePayInstallmentConfiguration members
https://bugs.webkit.org/show_bug.cgi?id=212160
<rdar://problem/60703650>

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/ssl/applepay/ApplePayInstallmentItems.https.html

  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj: Added IDLs, headers, and derived sources for

ApplePayInstallment{Item,ItemType,RetailChannel}.

  • Modules/applepay/ApplePayInstallmentConfiguration.idl:
  • Modules/applepay/ApplePayInstallmentConfigurationWebCore.h: Added items,

applicationMetadata, and retailChannel members. Added missing conditionals to
merchantIdentifier and referrerIdentifier.

  • Modules/applepay/ApplePayInstallmentItem.h:
  • Modules/applepay/ApplePayInstallmentItem.idl:
  • Modules/applepay/ApplePayInstallmentItemType.h:
  • Modules/applepay/ApplePayInstallmentItemType.idl:
  • Modules/applepay/ApplePayInstallmentRetailChannel.h:
  • Modules/applepay/ApplePayInstallmentRetailChannel.idl: Added.
  • Modules/applepay/ApplePayRequestBase.cpp:

(WebCore::convertAndValidate): Changed to call PaymentInstallmentConfiguration::create,
returning an exception if present.

  • Modules/applepay/PaymentInstallmentConfiguration.mm:

(WebCore::fromDecimalNumber): Allowed for a large maximum number of fractional digits to
support formatting high-precision currency and APRs (note that this formatter is only used
for test support).

(WebCore::applePayItemType):
(WebCore::platformItemType): Added to convert between PKInstallmentItemType and
ApplePayInstallmentItemType.

(WebCore::applePayRetailChannel):
(WebCore::platformRetailChannel): Added to convert between PKInstallmentRetailChannel and
ApplePayInstallmentRetailChannel.

(WebCore::makeNSArrayElement):
(WebCore::makeVectorElement): Added to convert between NSArray<PKPaymentInstallmentItem *>
and Vector<ApplePayInstallmentItem>.

(WebCore::createPlatformConfiguration): Added a parameter for passing in applicationMetadata
as an NSDictionary. Set properties on PKPaymentInstallmentConfiguration for new
ApplePayInstallmentConfiguration members.
(WebCore::PaymentInstallmentConfiguration::create): Added; converts the applicationMetadata
JSON string (if present) to an NSDictionary, returning a TypeError if the JSON string does
not deserialize to an NSDictionary (as PassKit requires).
(WebCore::PaymentInstallmentConfiguration::PaymentInstallmentConfiguration): Added a
parameter for passing in applicationMetadata as an NSDictionary. Made private.
(WebCore::PaymentInstallmentConfiguration::applePayInstallmentConfiguration const): Set
members on ApplePayInstallmentConfiguration for new PKPaymentInstallmentConfiguration
properties.

  • Modules/applepay/PaymentInstallmentConfigurationWebCore.h:

Source/WebCore/PAL:

  • pal/cocoa/PassKitSoftLink.h:
  • pal/cocoa/PassKitSoftLink.mm: Added soft-linking macros for PKPaymentInstallmentItem.

Source/WTF:

  • wtf/PlatformEnableCocoa.h: Defined ENABLE_APPLE_PAY_INSTALLMENT_IDENTIFIERS.

LayoutTests:

  • http/tests/ssl/applepay/ApplePayInstallmentItems.https-expected.txt:
  • http/tests/ssl/applepay/ApplePayInstallmentItems.https.html: Added.
  • platform/mac-wk2/TestExpectations: Skipped test on Mojave and Catalina.
11:57 AM Changeset in webkit [262068] by Paulo Matos
  • 2 edits in trunk/Tools

Add support for [no-]use-ccache option in build-jsc
https://bugs.webkit.org/show_bug.cgi?id=212259

Reviewed by Mark Lam.

  • Scripts/build-jsc:
11:55 AM Changeset in webkit [262067] by Alan Coon
  • 2 edits in branches/safari-610.1.14-branch/Source/WebCore

Cherry-pick r261823. rdar://problem/63548563

[Win] Fix AppleWin build
https://bugs.webkit.org/show_bug.cgi?id=212030

Reviewed by Brent Fulgham.

The build fails because the number of bitfields in GreaterThanOrSameSizeAsStyleRareInheritedData does not match the
actual number of bitfields in StyleRareInheritedData.

  • rendering/style/StyleRareInheritedData.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:27 AM Changeset in webkit [262066] by commit-queue@webkit.org
  • 44 edits
    1 add in trunk

Add SPI to unblock third party cookies from WKWebViews with ResourceLoadStatistics turned on
https://bugs.webkit.org/show_bug.cgi?id=212058
<rdar://problem/60595539>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-05-22
Reviewed by John Wilander.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • loader/CookieJar.cpp:

(WebCore::shouldRelaxThirdPartyCookieBlocking):
(WebCore::CookieJar::cookies const):
(WebCore::CookieJar::setCookies):
(WebCore::CookieJar::cookieRequestHeaderFieldValue const):
(WebCore::CookieJar::getRawCookies const):

  • page/Page.cpp:

(WebCore::m_shouldRelaxThirdPartyCookieBlocking):

  • page/Page.h:

(WebCore::Page::shouldRelaxThirdPartyCookieBlocking const):

  • page/PageConfiguration.h:
  • platform/network/CacheValidation.cpp:

(WebCore::cookieRequestHeaderFieldValue):

  • platform/network/NetworkStorageSession.cpp:

(WebCore::NetworkStorageSession::shouldBlockCookies const):
(WebCore::NetworkStorageSession::maxAgeCacheCap):

  • platform/network/NetworkStorageSession.h:
  • platform/network/ShouldRelaxThirdPartyCookieBlocking.h: Added.
  • platform/network/cf/NetworkStorageSessionCFNetWin.cpp:

(WebCore::NetworkStorageSession::setCookiesFromDOM const):
(WebCore::NetworkStorageSession::cookiesForDOM const):
(WebCore::NetworkStorageSession::cookieRequestHeaderFieldValue const):
(WebCore::NetworkStorageSession::getRawCookies const):

  • platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::cookiesForURL const):
(WebCore::NetworkStorageSession::cookiesForSession const):
(WebCore::NetworkStorageSession::cookiesForDOM const):
(WebCore::NetworkStorageSession::cookieRequestHeaderFieldValue const):
(WebCore::NetworkStorageSession::setCookiesFromDOM const):
(WebCore::NetworkStorageSession::getRawCookies const):

  • platform/network/curl/NetworkStorageSessionCurl.cpp:

(WebCore::NetworkStorageSession::setCookiesFromDOM const):
(WebCore::NetworkStorageSession::cookiesForDOM const):
(WebCore::NetworkStorageSession::getRawCookies const):
(WebCore::NetworkStorageSession::cookieRequestHeaderFieldValue const):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::createCurlRequest):

  • platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::setCookiesFromDOM const):
(WebCore::NetworkStorageSession::getRawCookies const):
(WebCore::cookiesForSession):
(WebCore::NetworkStorageSession::cookiesForDOM const):
(WebCore::NetworkStorageSession::cookieRequestHeaderFieldValue const):

Source/WebKit:

This value makes NetworkDataTaskCocoa::blockCookies() not do anything for certain WKWebViews.

  • NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::create):

  • NetworkProcess/NetworkLoadParameters.h:
  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::blockCookies):
(WebKit::NetworkDataTaskCocoa::unblockCookies):
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy const):

  • UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::setAllowAllThirdPartyCookies):
(API::PageConfiguration::allowAllThirdPartyCookies const):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _allowAllThirdPartyCookies]):
(-[WKWebViewConfiguration _setAllowAllThirdPartyCookies:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::addParametersShared):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):

Tools:

I also add _test_waitForAlert to make tests less verbose.

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/cocoa/HTTPServer.h:

(TestWebKitAPI::Connection::Connection):

  • TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::HTTPServer):
(TestWebKitAPI::dataFromString):
(TestWebKitAPI::nullTerminatedRequest):
(TestWebKitAPI::HTTPServer::request const):
(TestWebKitAPI::Connection::receive const):
(TestWebKitAPI::Connection::send const):

  • TestWebKitAPI/cocoa/TestUIDelegate.h:
  • TestWebKitAPI/cocoa/TestUIDelegate.mm:

(-[WKWebView _test_waitForAlert]):

11:19 AM Changeset in webkit [262065] by Chris Dumez
  • 2 edits in trunk/Tools

[WKTR] Make TestController::resetStateToConsistentValues() more robust against failures to navigate to about:blank
https://bugs.webkit.org/show_bug.cgi?id=212268
<rdar://problem/63493074>

Reviewed by Geoffrey Garen.

Make TestController::resetStateToConsistentValues() more robust against failures to navigate to about:blank.

In <rdar://problem/63493074>, we have evidence that TestController::resetStateToConsistentValues() sometimes
fails to load about:blank, likely due to an unresponsive WebProcess. When this happens, WebKitTestRunner
reports the test as timing out and logs this on stderr:
"""
<unknown> - TestController::run - Failed to reset state to consistent values
#PROCESS UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 57421)
"""

This is unfortunate because this does not indicate that anything is particularly wrong with the test in
question. Rather, it indicates that the WebProcess is unresponsive (likely due to a hang caused by a
previous test), which prevents WebKitTestRunner to reset the state in order to run the test.

I propose that if we fail to load about:blank once, we log an error message to stderr but then terminate
the WebProcess and try once again, to make WebKitTestRunner more robust.
I have verified the change locally, by injecting a script in resetStateToConsistentValues() that causes
a WebProcess hang. Before my change, the test would time out and the same logging as in
<rdar://problem/63493074> would show. After my change though, the test would pass successfully despite the
WebProcess hang.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

11:01 AM Changeset in webkit [262064] by keith_miller@apple.com
  • 3 edits
    1 add in trunk

Checkpoint inlined call return handler needs an exception check when dispatching
https://bugs.webkit.org/show_bug.cgi?id=212104

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/for-of-done-getter-osr-exits-inlined-to-value-getter-with-exception.js: Added.

(let.d.get done):
(let.d.get value):
(foo):
(catch):

Source/JavaScriptCore:

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::dispatchToNextInstruction):
(JSC::LLInt::slow_path_checkpoint_osr_exit_from_inlined_call):
(JSC::LLInt::slow_path_checkpoint_osr_exit):

10:35 AM Changeset in webkit [262063] by ChangSeok Oh
  • 3 edits
    6 adds in trunk/Tools

[GTK] jhbuild is broken with GCC 10.0
https://bugs.webkit.org/show_bug.cgi?id=212256

Reviewed by Carlos Alberto Lopez Perez.

GCC 10.0 enables -fno-common as default, so many 'multiple definitions' failures occur
in building dependencies via jhbuild. This patch addresses them by back-porting patches
from corresponding source repositories.

  • gstreamer/jhbuild.modules:
  • gstreamer/patches/libsrtp-Fix-building-with-gcc-10.patch: Added.
  • gstreamer/patches/orc-satisfy-fno-common-under-gcc10.patch: Added.
  • gtk/jhbuild.modules:
  • gtk/patches/at-spi2-atk-tests-Replace-common-variable-with-usual-external.patch: Added.
  • gtk/patches/at-spi2-atk-tests-fix-child_pid-reference.patch: Added.
  • gtk/patches/mesa-gallium-build-fix-to-make-gcc-10-happy.patch: Added.
  • gtk/patches/xserver-Fix-building-with-fno-common.patch: Added.
10:32 AM Changeset in webkit [262062] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

Gardening after r262056

Unreviewed.

9:45 AM Changeset in webkit [262061] by Oriol Brufau
  • 4 edits in trunk

Don't put out-of-flow boxes in anonymous flex/grid items
https://bugs.webkit.org/show_bug.cgi?id=205386

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

A single anonymous flex/grid item should just contain a contiguous
sequence of text runs.

This patch is based on https://crrev.com/533825 from Chromium.

Tests: imported/w3c/web-platform-tests/css/css-flexbox/anonymous-flex-item-004.html

imported/w3c/web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html

  • rendering/updating/RenderTreeBuilderBlock.cpp:

(WebCore::RenderTreeBuilder::Block::attachIgnoringContinuation):

LayoutTests:

Expect tests to pass.

9:42 AM Changeset in webkit [262060] by mmaxfield@apple.com
  • 6 edits
    3 adds in trunk/LayoutTests

[Cocoa] fast/text/font-collection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=212172
<rdar://problem/63466187>

Unreviewed.

The test is failing because the collection font file placed one of its table
directories after the table data. This is a valid file, so this patch doesn't
delete the test, but it also duplicates the test with a new collection font
file that doesn't have this construction. The duplicate test should pass on
all OSes.

  • fast/text/font-collection-2-expected.html: Copied from LayoutTests/fast/text/font-collection.html.
  • fast/text/font-collection-2.html: Added. Add some extra characters just to make sure things are working properly.
  • fast/text/font-collection-expected.html:
  • fast/text/font-collection.html: Ditto.
  • fast/text/resources/collection2.ttc: Added.
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
9:41 AM Changeset in webkit [262059] by Ryan Haddad
  • 1 edit
    4 adds in trunk/LayoutTests

Cannot style ::selection for a flex container
https://bugs.webkit.org/show_bug.cgi?id=209822

Unreviewed test gardening.

Add baselines for macOS and iOS.

  • platform/ios/editing/selection/selection-display-block-sibling-expected.txt: Added.
  • platform/ios/editing/selection/selection-display-flex-expected.txt: Added.
  • platform/mac/editing/selection/selection-display-block-sibling-expected.txt: Added.
  • platform/mac/editing/selection/selection-display-flex-expected.txt: Added.
8:17 AM Changeset in webkit [262058] by Chris Dumez
  • 3 edits
    3 adds in trunk

Regression(r254859) DOM storage event gets fired at the frame that caused the storage modification
https://bugs.webkit.org/show_bug.cgi?id=211503
<rdar://problem/62983284>

Reviewed by Maciej Stachowiak.

Source/WebKit:

r254859 refactored StorageAreaMap's dispatchSessionStorageEvent() &
dispatchLocalStorageEvent() to share more code by moving that code to
a new framesForEventDispatching() static function. However,
framesForEventDispatching() was always using the session storage no
matter the call site. It should be using the local storage when called
from dispatchLocalStorageEvent().

Test: storage/domstorage/events/storage-event-not-in-originator.html

  • WebProcess/WebStorage/StorageAreaMap.cpp:

(WebKit::framesForEventDispatching):
(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
(WebKit::StorageAreaMap::dispatchLocalStorageEvent):

LayoutTests:

Add layout test coverage.

  • storage/domstorage/events/resources/storage-event-not-in-originator-frame.html: Added.
  • storage/domstorage/events/storage-event-not-in-originator-expected.txt: Added.
  • storage/domstorage/events/storage-event-not-in-originator.html: Added.
7:58 AM Changeset in webkit [262057] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

[Flatpak SDK] Add bubblewrap ... wrapper
https://bugs.webkit.org/show_bug.cgi?id=212077

Patch by Philippe Normand <pnormand@igalia.com> on 2020-05-22
Reviewed by Carlos Alberto Lopez Perez.

The bind-mounts are now handled through webkit-bwrap.

  • flatpak/flatpakutils.py:

(WebkitFlatpak.execute_command):
(WebkitFlatpak.run_in_sandbox):

  • flatpak/webkit-bwrap: Added.
7:12 AM Changeset in webkit [262056] by clopez@igalia.com
  • 445 edits
    3 copies
    2 moves
    523 adds
    166 deletes in trunk/LayoutTests

[css-grid] Update WPT imported tests and deduplicate common tests
https://bugs.webkit.org/show_bug.cgi?id=212187

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

patch

  • resources/resource-files.json:
  • web-platform-tests/css/css-grid/META.yml:
  • web-platform-tests/css/css-grid/abspos/absolute-positioning-definite-sizes-001.html:
  • web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-containing-block-001.html:
  • web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html:
  • web-platform-tests/css/css-grid/abspos/descendant-static-position-001-expected.html: Added.
  • web-platform-tests/css/css-grid/abspos/descendant-static-position-001.html: Added.
  • web-platform-tests/css/css-grid/abspos/descendant-static-position-002-expected.html: Added.
  • web-platform-tests/css/css-grid/abspos/descendant-static-position-002.html: Added.
  • web-platform-tests/css/css-grid/abspos/descendant-static-position-003-expected.html: Added.
  • web-platform-tests/css/css-grid/abspos/descendant-static-position-003.html: Added.
  • web-platform-tests/css/css-grid/abspos/descendant-static-position-004-expected.html: Added.
  • web-platform-tests/css/css-grid/abspos/descendant-static-position-004.html: Added.
  • web-platform-tests/css/css-grid/abspos/empty-grid-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/abspos/empty-grid-001.html: Added.
  • web-platform-tests/css/css-grid/abspos/grid-positioned-children-writing-modes-001-expected.html:
  • web-platform-tests/css/css-grid/abspos/grid-positioned-children-writing-modes-001.html:
  • web-platform-tests/css/css-grid/abspos/grid-positioned-items-background-001.html:
  • web-platform-tests/css/css-grid/abspos/grid-positioned-items-background-rtl-001.html:
  • web-platform-tests/css/css-grid/abspos/grid-positioned-items-implicit-grid-001.html:
  • web-platform-tests/css/css-grid/abspos/grid-positioned-items-implicit-grid-line-001.html:
  • web-platform-tests/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html:
  • web-platform-tests/css/css-grid/abspos/grid-sizing-positioned-items-001.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-001.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-002.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-003.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-004.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-005.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-006.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-007.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-008.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-009.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-011.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-012.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-013.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-014.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-015.html:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-016.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-001.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-002.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-003.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-004.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-005.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-006.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-007.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-008.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-009.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-010.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-011.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-012.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-013.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-014.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-015.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-016.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-items-crash.html: Added.
  • web-platform-tests/css/css-grid/abspos/positioned-grid-items-should-not-create-implicit-tracks-001.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-items-should-not-take-up-space-001.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-items-sizing-001-expected.html:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-items-sizing-001.html:
  • web-platform-tests/css/css-grid/abspos/support/positioned-grid-descendants.js:

(export.runTests):

  • web-platform-tests/css/css-grid/abspos/support/w3c-import.log:
  • web-platform-tests/css/css-grid/abspos/w3c-import.log:
  • web-platform-tests/css/css-grid/alignment/grid-align-baseline-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-align-baseline-vertical-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-align-baseline-vertical.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-align-baseline.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-align-content-distribution-vertical-lr.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-content-distribution-vertical-rl.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-content-distribution.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-content-vertical-lr.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-content-vertical-rl.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-content.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-justify-margin-border-padding-vertical-lr.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-justify-margin-border-padding-vertical-rl.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-justify-margin-border-padding.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-justify-overflow.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-justify-stretch-with-orthogonal-flows.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-justify-stretch.html:
  • web-platform-tests/css/css-grid/alignment/grid-align-stretching-replaced-items.html:
  • web-platform-tests/css/css-grid/alignment/grid-align.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-008.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-009.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-010.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-011.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-012.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-013.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-014.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-015.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-016.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-017.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-018.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-019.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-020.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-021.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-022.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-023.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-024.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-025.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-026.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-027.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-028.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-029.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-030.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-031.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-032.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-033.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-034.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-035.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-036.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008.html:
  • web-platform-tests/css/css-grid/alignment/grid-baseline-001-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-expected.html.
  • web-platform-tests/css/css-grid/alignment/grid-baseline-001.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline.html.
  • web-platform-tests/css/css-grid/alignment/grid-baseline-002-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-margins-1-expected.html.
  • web-platform-tests/css/css-grid/alignment/grid-baseline-002.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-margins-1.html.
  • web-platform-tests/css/css-grid/alignment/grid-baseline-003-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-margins-2-expected.html.
  • web-platform-tests/css/css-grid/alignment/grid-baseline-003.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-margins-2.html.
  • web-platform-tests/css/css-grid/alignment/grid-baseline-004-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-must-respect-grid-order-expected.txt.
  • web-platform-tests/css/css-grid/alignment/grid-baseline-004.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-must-respect-grid-order.html.
  • web-platform-tests/css/css-grid/alignment/grid-baseline-align-cycles-001-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-baseline-align-cycles-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-008.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-009.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-010.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-011.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-012.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-013.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-014.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-015.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-016.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-017.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-container-auto-margins-scrollbars-001-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-container-scroll-accounts-for-auto-margin-expected.html.
  • web-platform-tests/css/css-grid/alignment/grid-container-auto-margins-scrollbars-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-container-baseline-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-and-self-alignment-001-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-content-alignment-and-self-alignment-expected.txt.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-and-self-alignment-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-and-self-alignment-002-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-and-self-alignment-002.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-auto-sized-tracks-001-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks-expected.txt.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-auto-sized-tracks-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-overflow-001-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow-expected.txt.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-overflow-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-with-span-001-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-content-alignment-with-span-expected.txt.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-with-span-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-with-span-vertical-lr-001-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr-expected.txt.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-with-span-vertical-lr-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-with-span-vertical-rl-001-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl-expected.txt.
  • web-platform-tests/css/css-grid/alignment/grid-content-alignment-with-span-vertical-rl-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-fit-content-tracks-dont-stretch-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-gutters-and-alignment.html:
  • web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-item-alignment-with-orthogonal-flows-vertical-lr.html:
  • web-platform-tests/css/css-grid/alignment/grid-item-alignment-with-orthogonal-flows-vertical-rl.html:
  • web-platform-tests/css/css-grid/alignment/grid-item-alignment-with-orthogonal-flows.html:
  • web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-vertical-lr.html:
  • web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-vertical-rl.html:
  • web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment.html:
  • web-platform-tests/css/css-grid/alignment/grid-item-content-baseline-001-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-content-baseline-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-content-baseline-002-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-content-baseline-002.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-content-baseline-003-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-content-baseline-003.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-content-baseline-004-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-content-baseline-004.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-001-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-002-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-002.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-003-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-003.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-004-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-004.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-self-baseline-001-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-item-self-baseline-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-008.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-009.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-010.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-011.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-012.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-013.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-014.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-015.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-016.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-017.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-001-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-002-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-002.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-003-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-003.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-004-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-004.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-008.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-009.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-010.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-011.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-012.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-008.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-009.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-010.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-011.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-012.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-013.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-014.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-015.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-016.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-008.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-009.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-010.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-011.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-012.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-013.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-014.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-015.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-016.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-input-range-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-input-range.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-008.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-009.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-010.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-011.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-012.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-013.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-014.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-015.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-lr-016.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-003.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-004.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-005.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-006.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-007.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-008.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-009.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-010.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-011.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-012.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-013.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-014.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-015.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-stretch-vertical-rl-016.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-001-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-self-baseline-01-expected.html.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-002-b-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-self-baseline-02-b-expected.html.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-002-b.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-002-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-002.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-003-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-003.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-004-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-004.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-005-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-self-baseline-05-expected.html.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-005.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-006-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-006.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-007-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-self-baseline-07-expected.html.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-007.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-001.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-002.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-003.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-004.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-005.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-006.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-007.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-008.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-009.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-010.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-011.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-012.html:
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-001-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-002-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-002.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-003-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-003.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-004-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-004.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-005-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-005.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-006-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-006.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-007-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-07-expected.html.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-007.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-001-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-002-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-002.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-003-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-003.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-004-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-004.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-005-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-005.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-006-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-006.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-007-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-007.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-001-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-002-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-002.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-003-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-003.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-004-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-004.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-005-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-005.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-006-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-006.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-007-expected.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-007.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/w3c-import.log:
  • web-platform-tests/css/css-grid/alignment/test-expected.txt: Removed.
  • web-platform-tests/css/css-grid/alignment/w3c-import.log:
  • web-platform-tests/css/css-grid/animation/grid-template-columns-001-expected.html: Added.
  • web-platform-tests/css/css-grid/animation/grid-template-columns-001.html: Added.
  • web-platform-tests/css/css-grid/animation/grid-template-columns-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-grid/animation/grid-template-columns-interpolation.html: Added.
  • web-platform-tests/css/css-grid/animation/grid-template-rows-001-expected.html: Added.
  • web-platform-tests/css/css-grid/animation/grid-template-rows-001.html: Added.
  • web-platform-tests/css/css-grid/animation/grid-template-rows-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-grid/animation/grid-template-rows-interpolation.html: Added.
  • web-platform-tests/css/css-grid/animation/w3c-import.log: Added.
  • web-platform-tests/css/css-grid/anonymous-grid-items-001-expected.html: Added.
  • web-platform-tests/css/css-grid/anonymous-grid-items-001.html: Added.
  • web-platform-tests/css/css-grid/chrome-bug-001-expected.html: Added.
  • web-platform-tests/css/css-grid/chrome-bug-001.html: Added.
  • web-platform-tests/css/css-grid/chrome-crash-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/chrome-crash-001.html: Added.
  • web-platform-tests/css/css-grid/grid-child-percent-basis-resize-1-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-child-percent-basis-resize-1.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/explicit-grid-size-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/explicit-grid-size-001.html: Renamed from LayoutTests/fast/css-grid-layout/explicit-grid-size.html.
  • web-platform-tests/css/css-grid/grid-definition/flex-content-distribution-001-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/flex-content-distribution-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/flex-content-distribution-001.html: Renamed from LayoutTests/fast/css-grid-layout/flex-content-distribution.html.
  • web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-columns-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-columns-001.html: Renamed from LayoutTests/fast/css-grid-layout/flex-content-resolution-columns.html.
  • web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-columns-002-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-columns-002.html: Renamed from LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html.
  • web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-rows-001-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-container-percentage-columns-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-rows-001.html: Renamed from LayoutTests/fast/css-grid-layout/flex-content-resolution-rows.html.
  • web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-rows-002-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-rows-002.html: Renamed from LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html.
  • web-platform-tests/css/css-grid/grid-definition/flex-factor-sum-less-than-1-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-definition/flex-factor-sum-less-than-1-001.html: Renamed from LayoutTests/fast/css-grid-layout/flex-factor-sum-less-than-1.html.
  • web-platform-tests/css/css-grid/grid-definition/flex-item-grid-container-percentage-rows-001-expected.html: Renamed from LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows-expected.html.
  • web-platform-tests/css/css-grid/grid-definition/flex-item-grid-container-percentage-rows-001.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/fr-unit-expected.html:
  • web-platform-tests/css/css-grid/grid-definition/fr-unit-with-percentage-expected.html:
  • web-platform-tests/css/css-grid/grid-definition/fr-unit-with-percentage.html:
  • web-platform-tests/css/css-grid/grid-definition/fr-unit.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-add-item-with-positioned-items-crash.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-add-positioned-block-item-after-inline-item-crash.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-fill-columns-001-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-container-percentage-columns-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-fill-columns-001.html: Renamed from LayoutTests/fast/css-grid-layout/grid-auto-fill-columns.html.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-fill-rows-001-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-container-percentage-columns-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-fill-rows-001.html: Renamed from LayoutTests/fast/css-grid-layout/grid-auto-fill-rows.html.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-container-percentage-columns-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html: Renamed from LayoutTests/fast/css-grid-layout/grid-auto-fit-columns.html.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-rows-001-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-container-percentage-columns-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-rows-001.html: Renamed from LayoutTests/fast/css-grid-layout/grid-auto-fit-rows.html.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-intrinsic-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-intrinsic-001.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-multiple-values-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-multiple-values-002.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-multiple-values-003-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-multiple-values-003.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-positioned-container-001-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-auto-repeat-positioned-container-expected.html.
  • web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-positioned-container-001.html: Renamed from LayoutTests/fast/css-grid-layout/grid-auto-repeat-positioned-container.html.
  • web-platform-tests/css/css-grid/grid-definition/grid-change-fit-content-argument-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-change-intrinsic-size-with-auto-repeat-tracks-001-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-change-intrinsic-size-with-auto-repeat-tracks-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/grid-change-intrinsic-size-with-auto-repeat-tracks-001.html: Renamed from LayoutTests/fast/css-grid-layout/grid-change-intrinsic-size-with-auto-repeat-tracks.html.
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-support-flexible-lengths-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-support-flexible-lengths-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-support-grid-template-areas-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-support-grid-template-columns-rows-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-support-grid-template-columns-rows-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-support-named-grid-lines-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-support-named-grid-lines-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-support-repeat-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-support-repeat-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-template-columns-rows-resolved-values-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-template-columns-rows-resolved-values-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-template-columns-rows-resolved-values-001.tentative-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-inline-template-columns-rows-resolved-values-001-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/grid-inline-template-columns-rows-resolved-values-001.tentative.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-inline-template-columns-rows-resolved-values-001.html.
  • web-platform-tests/css/css-grid/grid-definition/grid-limits-001.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-support-flexible-lengths-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-support-flexible-lengths-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-support-grid-template-columns-rows-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-support-grid-template-columns-rows-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-support-named-grid-lines-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-support-named-grid-lines-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-support-named-grid-lines-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-support-named-grid-lines-002.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-support-named-grid-lines-003-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-support-named-grid-lines-003.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-support-repeat-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-support-repeat-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-support-repeat-002.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-template-columns-fit-content-001-expected.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-template-columns-fit-content-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-template-columns-rows-changes-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-template-columns-rows-changes-001.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-template-columns-rows-resolved-values-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-definition/grid-template-columns-rows-resolved-values-001.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-template-columns-rows-resolved-values-001.tentative-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-template-columns-rows-resolved-values-001-expected.txt.
  • web-platform-tests/css/css-grid/grid-definition/grid-template-columns-rows-resolved-values-001.tentative.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-template-columns-rows-resolved-values-001.html.
  • web-platform-tests/css/css-grid/grid-definition/grid-template-rows-fit-content-001-expected.html:
  • web-platform-tests/css/css-grid/grid-definition/grid-template-rows-fit-content-001.html:
  • web-platform-tests/css/css-grid/grid-definition/support/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-item-non-auto-height-stretch-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-item-non-auto-height-stretch-001.html: Added.
  • web-platform-tests/css/css-grid/grid-item-non-auto-height-stretch-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-item-non-auto-height-stretch-002.html: Added.
  • web-platform-tests/css/css-grid/grid-item-non-auto-height-stretch-003-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-item-non-auto-height-stretch-003.html: Added.
  • web-platform-tests/css/css-grid/grid-item-non-auto-height-stretch-004-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-item-non-auto-height-stretch-004.html: Added.
  • web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-automatic-minimum-intrinsic-aspect-ratio-001-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio-expected.txt.
  • web-platform-tests/css/css-grid/grid-items/grid-automatic-minimum-intrinsic-aspect-ratio-001.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-inline-items-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-items-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-items-003.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-items-inline-blocks-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-auto-placement-001-expected.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-auto-placement-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-auto-placement-002-expected.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-auto-placement-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-auto-placement-003-expected.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-auto-placement-003.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-auto-placement-004-expected.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-auto-placement-004.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-auto-placement-005-expected.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-auto-placement-005.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-painting-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-painting-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-painting-003.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-painting-004.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-order-property-painting-005.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-003.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-004.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-005.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-overlapped-items-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-overlapped-items-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-overlapped-items-003.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-overlapped-items-004.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-overlapped-items-005.html:
  • web-platform-tests/css/css-grid/grid-items/grid-inline-z-axis-ordering-overlapped-items-006.html:
  • web-platform-tests/css/css-grid/grid-items/grid-item-margins-and-writing-modes-001-expected.html: Renamed from LayoutTests/imported/blink/fast/css-grid-layout/grid-item-margins-and-writing-modes-expected.html.
  • web-platform-tests/css/css-grid/grid-items/grid-item-margins-and-writing-modes-001.html: Renamed from LayoutTests/imported/blink/fast/css-grid-layout/grid-item-margins-and-writing-modes.html.
  • web-platform-tests/css/css-grid/grid-items/grid-item-overflow-auto-max-height-percentage-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-overflow-auto-max-height-percentage.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-percentage-sizes-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-percentage-sizes-001.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-percentage-sizes-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-percentage-sizes-002.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-percentage-sizes-003-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-percentage-sizes-003.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-rel-pos-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-rel-pos-001.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-rel-pos-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-rel-pos-002.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-script-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-script-001.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-003.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-inline-blocks-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-013.html:
  • web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-021.html:
  • web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022.html:
  • web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023.html:
  • web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-024.html:
  • web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-025.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-auto-placement-001-expected.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-auto-placement-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-auto-placement-002-expected.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-auto-placement-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-auto-placement-003-expected.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-auto-placement-003.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-auto-placement-004-expected.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-auto-placement-004.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-auto-placement-005-expected.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-auto-placement-005.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-painting-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-painting-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-painting-003.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-painting-004.html:
  • web-platform-tests/css/css-grid/grid-items/grid-order-property-painting-005.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-003.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-004.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-005.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-overlapped-items-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-overlapped-items-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-overlapped-items-003.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-overlapped-items-004.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-overlapped-items-005.html:
  • web-platform-tests/css/css-grid/grid-items/grid-z-axis-ordering-overlapped-items-006.html:
  • web-platform-tests/css/css-grid/grid-items/percentage-size-subitems-001-expected.html:
  • web-platform-tests/css/css-grid/grid-items/remove-svg-grid-item-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/remove-svg-grid-item-001.html: Added.
  • web-platform-tests/css/css-grid/grid-items/support/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-items/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-layout-properties-expected.txt:
  • web-platform-tests/css/css-grid/grid-layout-properties.html:
  • web-platform-tests/css/css-grid/grid-model/column-property-should-not-apply-on-grid-container-001-expected.html: Renamed from LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container-expected.html.
  • web-platform-tests/css/css-grid/grid-model/column-property-should-not-apply-on-grid-container-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/compute-intrinsic-widths-scrollbar-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-model/compute-intrinsic-widths-scrollbar-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/display-grid-expected.html:
  • web-platform-tests/css/css-grid/grid-model/display-grid.html:
  • web-platform-tests/css/css-grid/grid-model/display-inline-grid-expected.html:
  • web-platform-tests/css/css-grid/grid-model/display-inline-grid.html:
  • web-platform-tests/css/css-grid/grid-model/fixed-width-intrinsic-width-should-exclude-scrollbar-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-model/fixed-width-intrinsic-width-should-exclude-scrollbar-001.html: Renamed from LayoutTests/fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-002.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-003-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-003.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-004-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-004.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-005-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-005.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-006-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-006.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-007-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-007.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-008-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-008.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-button-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-button-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-container-margin-border-padding-scrollbar-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/grid-model/grid-container-margin-border-padding-scrollbar-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html:
  • web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html:
  • web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-expected.html:
  • web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html:
  • web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-expected.html:
  • web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html:
  • web-platform-tests/css/css-grid/grid-model/grid-container-scrollbars-sizing-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-container-scrollbars-sizing-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-container-scrollbars-sizing-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-container-scrollbars-sizing-002.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-display-grid-001.html:
  • web-platform-tests/css/css-grid/grid-model/grid-display-inline-grid-001.html:
  • web-platform-tests/css/css-grid/grid-model/grid-float-001.html:
  • web-platform-tests/css/css-grid/grid-model/grid-float-002-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-float-002.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-floats-no-intrude-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-floats-no-intrude-002.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-gutters-and-flex-content-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/grid-model/grid-gutters-and-flex-content-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-gutters-and-tracks-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-gutters-and-tracks-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-gutters-as-percentage-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-gutters-as-percentage-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-inline-float-001.html:
  • web-platform-tests/css/css-grid/grid-model/grid-inline-vertical-align-001.html:
  • web-platform-tests/css/css-grid/grid-model/grid-layout-stale-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-layout-stale-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-layout-stale-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-layout-stale-002.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-margins-no-collapse-002-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-item-margins-not-collapse-expected.html.
  • web-platform-tests/css/css-grid/grid-model/grid-margins-no-collapse-002.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-min-max-height-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/grid-model/grid-min-max-height-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-overflow-padding-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-overflow-padding-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-overflow-padding-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-overflow-padding-002.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-size-shrink-to-fit-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-size-shrink-to-fit-001.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-support-display-001.html:
  • web-platform-tests/css/css-grid/grid-model/grid-vertical-align-001.html:
  • web-platform-tests/css/css-grid/grid-model/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-tracks-stretched-with-different-flex-factors-sum-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-tracks-stretched-with-different-flex-factors-sum.html: Added.
  • web-platform-tests/css/css-grid/implicit-grids/grid-support-grid-auto-columns-rows-003-expected.html: Added.
  • web-platform-tests/css/css-grid/implicit-grids/grid-support-grid-auto-columns-rows-003.html: Added.
  • web-platform-tests/css/css-grid/implicit-grids/w3c-import.log:
  • web-platform-tests/css/css-grid/layout-algorithm/auto-margins-ignored-during-track-sizing-001-expected.html: Renamed from LayoutTests/fast/css-grid-layout/auto-margins-ignored-during-track-sizing-expected.html.
  • web-platform-tests/css/css-grid/layout-algorithm/auto-margins-ignored-during-track-sizing-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/flex-and-intrinsic-sizes-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/flex-and-intrinsic-sizes-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/flex-sizing-columns-min-max-width-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/layout-algorithm/flex-sizing-columns-min-max-width-001.html: Renamed from LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width.html.
  • web-platform-tests/css/css-grid/layout-algorithm/flex-sizing-rows-min-max-height-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/layout-algorithm/flex-sizing-rows-min-max-height-001.html: Renamed from LayoutTests/fast/css-grid-layout/flex-sizing-rows-min-max-height.html.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-automatic-minimum-for-auto-columns-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-automatic-minimum-for-auto-columns-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-automatic-minimum-for-auto-rows-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-automatic-minimum-for-auto-rows-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-container-percentage-001-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-container-percentage-columns-expected.txt.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-container-percentage-001.html: Renamed from LayoutTests/fast/css-grid-layout/grid-container-percentage-columns.html.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-container-percentage-002-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-container-percentage-columns-expected.txt.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-container-percentage-002.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-find-fr-size-gutters-001.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-find-fr-size-gutters-002.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-intrinsic-size-with-orthogonal-items.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-item-margin-auto-columns-rows-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-item-margin-auto-columns-rows-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-item-margin-auto-columns-rows-vertical-lr-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-item-margin-auto-columns-rows-vertical-lr-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-item-margin-auto-columns-rows-vertical-rl-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-item-margin-auto-columns-rows-vertical-rl-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001-expected.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001-expected.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001-expected.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001-expected.html:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001.html:
  • web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-content-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-content-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-content-002-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-content-002.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-content-003-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-content-003.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-content-004-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-content-004.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-tracks-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-tracks-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-tracks-multi-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-tracks-multi-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-tracks-stretch-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-tracks-stretch-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-tracks-stretch-002-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-align-tracks-stretch-002.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-002-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-002.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-003-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-003.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-004-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-004.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-005-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-005.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-006-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-fragmentation-006.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-gap-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-gap-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-item-content-baseline-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-item-content-baseline-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-item-self-baseline-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-item-self-baseline-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-item-self-baseline-002a-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-item-self-baseline-002a.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-item-self-baseline-002b-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-item-self-baseline-002b.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-placement-named-lines-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-placement-named-lines-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-placement-named-lines-002-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-placement-named-lines-002.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-template-columns-computed-withcontent-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-withcontent-expected.txt.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-template-columns-computed-withcontent.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-withcontent.html.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-002-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-002.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-003-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-003.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-004-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-004.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-005-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-005.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-006-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-intrinsic-sizing-006.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-002-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-002.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-003-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-003.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-004-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-004.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-005-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-005.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-006-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-006.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-007-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-item-placement-007.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-content-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-content-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-content-002-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-content-002.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-content-003-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-content-003.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-content-004-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-content-004.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-tracks-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-tracks-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-tracks-multi-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-tracks-multi-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-tracks-stretch-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-tracks-stretch-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-tracks-stretch-002-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-justify-tracks-stretch-002.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-order-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-order-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-order-002-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-order-002.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-parsing-expected.txt: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-parsing.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-subgrid-001-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-subgrid-001.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-subgrid-002-expected.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/masonry-subgrid-002.html: Added.
  • web-platform-tests/css/css-grid/masonry.tentative/w3c-import.log: Added.
  • web-platform-tests/css/css-grid/parsing/grid-area-invalid-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-area-invalid.html:
  • web-platform-tests/css/css-grid/parsing/grid-shorthand-valid-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-shorthand-valid.html:
  • web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-withcontent-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-withcontent.html:
  • web-platform-tests/css/css-grid/parsing/grid-template-columns-invalid-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-columns-invalid.html:
  • web-platform-tests/css/css-grid/parsing/grid-template-repeat-auto-computed-withcontent-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-template-repeat-auto-computed-withcontent-001.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-template-repeat-auto-computed-withcontent-002-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-template-repeat-auto-computed-withcontent-002.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-withcontent-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-withcontent.html:
  • web-platform-tests/css/css-grid/parsing/grid-template-rows-invalid-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-rows-invalid.html:
  • web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid.html:
  • web-platform-tests/css/css-grid/parsing/w3c-import.log:
  • web-platform-tests/css/css-grid/placement/grid-auto-flow-sparse-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/placement/grid-auto-flow-sparse-001.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-auto-placement-implicit-tracks-001-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt.
  • web-platform-tests/css/css-grid/placement/grid-auto-placement-implicit-tracks-001.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-container-change-grid-tracks-recompute-child-positions-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/placement/grid-container-change-grid-tracks-recompute-child-positions-001.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-container-change-named-grid-recompute-child-positions-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/placement/grid-container-change-named-grid-recompute-child-positions-001.html: Renamed from LayoutTests/fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-002-expected.xht: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-002.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-003-expected.xht: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-003.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-004-expected.xht: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-004.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-005-expected.xht: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-005.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-006-expected.xht: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-006.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-007-expected.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-placement-using-named-grid-lines-007.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-template-areas-must-keep-named-columns-order-001-expected.html: Added.
  • web-platform-tests/css/css-grid/placement/grid-template-areas-must-keep-named-columns-order-001.html: Added.
  • web-platform-tests/css/css-grid/placement/w3c-import.log:
  • web-platform-tests/css/css-grid/subgrid/abs-pos-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/abs-pos-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/abs-pos-002-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/abs-pos-002.html: Added.
  • web-platform-tests/css/css-grid/subgrid/abs-pos-003-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/abs-pos-003.html: Added.
  • web-platform-tests/css/css-grid/subgrid/auto-track-sizing-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/auto-track-sizing-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/baseline-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/baseline-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/contain-strict-nested-subgrid-crash.html: Added.
  • web-platform-tests/css/css-grid/subgrid/contain-strict-subgrid-crash.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-002-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-002.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-003-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-003.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-004-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-004.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-005-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-005.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-006-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-006.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-007-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-007.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-008-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-008.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-009-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-009.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-larger-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-larger-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-larger-002-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-larger-002.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-normal-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-normal-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-smaller-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-gap-smaller-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-template-computed-nogrid-expected.txt: Added.
  • web-platform-tests/css/css-grid/subgrid/grid-template-computed-nogrid.html: Added.
  • web-platform-tests/css/css-grid/subgrid/item-percentage-height-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/item-percentage-height-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-002-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-002.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-003-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-003.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-004-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-004.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-005-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-005.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-006-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-006.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-007-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-007.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-008-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/line-names-008.html: Added.
  • web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-002-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-002.html: Added.
  • web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-003-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-003.html: Added.
  • web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-004-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-004.html: Added.
  • web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-002-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-002.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-002-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-002.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-003-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-003.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-004-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-004.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-005-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-005.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-006-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-006.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-007-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-007.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-008-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-008.html: Added.
  • web-platform-tests/css/css-grid/subgrid/subgrid-item-block-size-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/subgrid-item-block-size-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/subgrid-mbp-overflow-001-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/subgrid-mbp-overflow-001.html: Added.
  • web-platform-tests/css/css-grid/subgrid/subgrid-mbp-overflow-002-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/subgrid-mbp-overflow-002.html: Added.
  • web-platform-tests/css/css-grid/subgrid/subgrid-mbp-overflow-003-expected.html: Added.
  • web-platform-tests/css/css-grid/subgrid/subgrid-mbp-overflow-003.html: Added.
  • web-platform-tests/css/css-grid/subgrid/w3c-import.log: Added.
  • web-platform-tests/css/css-grid/support/grid-alignment.css: Removed.
  • web-platform-tests/css/css-grid/support/grid-child-utils.js: Added.

(GridChildHelper):
(GridChildHelper.prototype.runTest):

  • web-platform-tests/css/css-grid/support/grid.css: Removed.
  • web-platform-tests/css/css-grid/support/style-change.js: Removed.
  • web-platform-tests/css/css-grid/support/w3c-import.log:
  • web-platform-tests/css/css-grid/table-grid-item-dynamic-001-expected.html: Added.
  • web-platform-tests/css/css-grid/table-grid-item-dynamic-001.html: Added.
  • web-platform-tests/css/css-grid/test-plan/index.html:
  • web-platform-tests/css/css-grid/w3c-import.log:

LayoutTests:

This updates the WPT css-flexbox imported tests and deduplicates
our old versions of this tests in favor of the WPT ones.

Below is the complete list of tests deduplicated.
Format is: WPT-test-name => old-test(s) removed

imported/w3c/web-platform-tests/css/css-grid/abspos/empty-grid-001.html => fast/css-grid-layout/empty-grid.html
imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-items-crash.html => imported/blink/fast/css-grid-layout/positioned-grid-items-crash.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-baseline-001.html => fast/css-grid-layout/grid-baseline.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-baseline-002.html => fast/css-grid-layout/grid-baseline-margins-1.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-baseline-003.html => fast/css-grid-layout/grid-baseline-margins-2.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-baseline-004.html => fast/css-grid-layout/grid-baseline-must-respect-grid-order.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-auto-margins-scrollbars-001.html => fast/css-grid-layout/grid-container-scroll-accounts-for-auto-margin.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-and-self-alignment-001.html => fast/css-grid-layout/grid-content-alignment-and-self-alignment.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-and-self-alignment-002.html => fast/css-grid-layout/grid-content-alignment-and-self-alignment-spanning.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-auto-sized-tracks-001.html => fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-overflow-001.html => fast/css-grid-layout/grid-content-alignment-overflow.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-with-span-001.html => fast/css-grid-layout/grid-content-alignment-with-span.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-with-span-vertical-lr-001.html => fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-with-span-vertical-rl-001.html => fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-001.html => fast/css-grid-layout/grid-self-baseline-01.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-002-b.html => fast/css-grid-layout/grid-self-baseline-02-b.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-002.html => fast/css-grid-layout/grid-self-baseline-02.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-003.html => fast/css-grid-layout/grid-self-baseline-03.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-004.html => fast/css-grid-layout/grid-self-baseline-04.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-005.html => fast/css-grid-layout/grid-self-baseline-05.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-006.html => fast/css-grid-layout/grid-self-baseline-06.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-007.html => fast/css-grid-layout/grid-self-baseline-07.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-001.html => fast/css-grid-layout/grid-self-baseline-horiz-01.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-002.html => fast/css-grid-layout/grid-self-baseline-horiz-02.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-003.html => fast/css-grid-layout/grid-self-baseline-horiz-03.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-004.html => fast/css-grid-layout/grid-self-baseline-horiz-04.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-005.html => fast/css-grid-layout/grid-self-baseline-horiz-05.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-006.html => fast/css-grid-layout/grid-self-baseline-horiz-06.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-007.html => fast/css-grid-layout/grid-self-baseline-horiz-07.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-001.html => fast/css-grid-layout/grid-self-baseline-vertical-lr-01.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-002.html => fast/css-grid-layout/grid-self-baseline-vertical-lr-02.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-003.html => fast/css-grid-layout/grid-self-baseline-vertical-lr-03.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-004.html => fast/css-grid-layout/grid-self-baseline-vertical-lr-04.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-005.html => fast/css-grid-layout/grid-self-baseline-vertical-lr-05.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-006.html => fast/css-grid-layout/grid-self-baseline-vertical-lr-06.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-007.html => fast/css-grid-layout/grid-self-baseline-vertical-lr-07.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-001.html => fast/css-grid-layout/grid-self-baseline-vertical-rl-01.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-002.html => fast/css-grid-layout/grid-self-baseline-vertical-rl-02.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-003.html => fast/css-grid-layout/grid-self-baseline-vertical-rl-03.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-004.html => fast/css-grid-layout/grid-self-baseline-vertical-rl-04.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-005.html => fast/css-grid-layout/grid-self-baseline-vertical-rl-05.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-006.html => fast/css-grid-layout/grid-self-baseline-vertical-rl-06.html
imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-007.html => fast/css-grid-layout/grid-self-baseline-vertical-rl-07.html
imported/w3c/web-platform-tests/css/css-grid/anonymous-grid-items-001.html => fast/css-grid-layout/anonymous-grid-items.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/explicit-grid-size-001.html => fast/css-grid-layout/explicit-grid-size.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/flex-content-distribution-001.html => fast/css-grid-layout/flex-content-distribution.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-columns-001.html => fast/css-grid-layout/flex-content-resolution-columns.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-columns-002.html => fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-rows-001.html => fast/css-grid-layout/flex-content-resolution-rows.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/flex-content-resolution-rows-002.html => fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/flex-factor-sum-less-than-1-001.html => fast/css-grid-layout/flex-factor-sum-less-than-1.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/flex-item-grid-container-percentage-rows-001.html => fast/css-grid-layout/flex-item-grid-container-percentage-rows.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-add-item-with-positioned-items-crash.html => fast/css-grid-layout/grid-add-item-with-positioned-items.html imported/blink/fast/css-grid-layout/grid-add-item-with-positioned-items.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-add-positioned-block-item-after-inline-item-crash.html => fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fill-columns-001.html => fast/css-grid-layout/grid-auto-fill-columns.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fill-rows-001.html => fast/css-grid-layout/grid-auto-fill-rows.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html => fast/css-grid-layout/grid-auto-fit-columns.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-rows-001.html => fast/css-grid-layout/grid-auto-fit-rows.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-intrinsic-001.html => fast/css-grid-layout/grid-auto-repeat-intrinsic.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-positioned-container-001.html => fast/css-grid-layout/grid-auto-repeat-positioned-container.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-change-intrinsic-size-with-auto-repeat-tracks-001.html => fast/css-grid-layout/grid-change-intrinsic-size-with-auto-repeat-tracks.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-automatic-minimum-intrinsic-aspect-ratio-001.html => fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-margins-and-writing-modes-001.html => imported/blink/fast/css-grid-layout/grid-item-margins-and-writing-modes.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-script-001.html => imported/blink/fast/css-grid-layout/grid-element-bad-cast-addchild.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/remove-svg-grid-item-001.html => imported/blink/fast/css-grid-layout/grid-element-remove-svg-child.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/column-property-should-not-apply-on-grid-container-001.html => fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/compute-intrinsic-widths-scrollbar-001.html => fast/css-grid-layout/compute-intrinsic-widths-scrollbar.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/fixed-width-intrinsic-width-should-exclude-scrollbar-001.html => fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-margin-border-padding-scrollbar-001.html => fast/css-grid-layout/grid-container-margin-border-padding-scrollbar.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbars-sizing-002.html => fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-float-002.html => fast/css-grid-layout/floating-not-effect-on-grid-items.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-floats-no-intrude-002.html => fast/css-grid-layout/float-not-protruding-into-next-grid-item.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-margins-no-collapse-002.html => fast/css-grid-layout/grid-item-margins-not-collapse.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/auto-margins-ignored-during-track-sizing-001.html => fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/flex-sizing-columns-min-max-width-001.html => fast/css-grid-layout/flex-sizing-columns-min-max-width.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/flex-sizing-rows-min-max-height-001.html => fast/css-grid-layout/flex-sizing-rows-min-max-height.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-automatic-minimum-for-auto-columns-001.html => fast/css-grid-layout/grid-automatic-minimum-for-auto-columns.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-automatic-minimum-for-auto-rows-001.html => fast/css-grid-layout/grid-automatic-minimum-for-auto-rows.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-container-percentage-001.html => fast/css-grid-layout/grid-container-percentage-columns.html
imported/w3c/web-platform-tests/css/css-grid/placement/grid-container-change-named-grid-recompute-child-positions-001.html => fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html

  • TestExpectations:
  • fast/css-grid-layout/anonymous-grid-items-expected.html: Removed.
  • fast/css-grid-layout/anonymous-grid-items.html: Removed.
  • fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html: Removed.
  • fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html: Removed.
  • fast/css-grid-layout/compute-intrinsic-widths-scrollbar-expected.txt: Removed.
  • fast/css-grid-layout/compute-intrinsic-widths-scrollbar.html: Removed.
  • fast/css-grid-layout/empty-grid-expected.txt: Removed.
  • fast/css-grid-layout/empty-grid.html: Removed.
  • fast/css-grid-layout/explicit-grid-size-expected.txt: Removed.
  • fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid-expected.txt: Removed.
  • fast/css-grid-layout/flex-and-minmax-content-resolution-columns-expected.txt: Removed.
  • fast/css-grid-layout/flex-content-resolution-columns-expected.txt: Removed.
  • fast/css-grid-layout/flex-content-resolution-rows-expected.txt: Removed.
  • fast/css-grid-layout/flex-factor-sum-less-than-1-expected.txt: Removed.
  • fast/css-grid-layout/flex-item-grid-container-percentage-rows.html: Removed.
  • fast/css-grid-layout/flex-sizing-columns-min-max-width-expected.txt: Removed.
  • fast/css-grid-layout/flex-sizing-rows-min-max-height-expected.txt: Removed.
  • fast/css-grid-layout/float-not-protruding-into-next-grid-item-expected.html: Removed.
  • fast/css-grid-layout/float-not-protruding-into-next-grid-item.html: Removed.
  • fast/css-grid-layout/floating-not-effect-on-grid-items-expected.txt: Removed.
  • fast/css-grid-layout/floating-not-effect-on-grid-items.html: Removed.
  • fast/css-grid-layout/grid-add-item-with-positioned-items-expected.txt: Removed.
  • fast/css-grid-layout/grid-add-item-with-positioned-items.html: Removed.
  • fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt: Removed.
  • fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html: Removed.
  • fast/css-grid-layout/grid-auto-fill-columns-expected.txt: Removed.
  • fast/css-grid-layout/grid-auto-fill-rows-expected.txt: Removed.
  • fast/css-grid-layout/grid-auto-fit-columns-expected.txt: Removed.
  • fast/css-grid-layout/grid-auto-fit-rows-expected.txt: Removed.
  • fast/css-grid-layout/grid-auto-repeat-intrinsic-expected.txt: Removed.
  • fast/css-grid-layout/grid-auto-repeat-intrinsic.html: Removed.
  • fast/css-grid-layout/grid-automatic-minimum-for-auto-columns-expected.txt: Removed.
  • fast/css-grid-layout/grid-automatic-minimum-for-auto-columns.html: Removed.
  • fast/css-grid-layout/grid-automatic-minimum-for-auto-rows-expected.txt: Removed.
  • fast/css-grid-layout/grid-automatic-minimum-for-auto-rows.html: Removed.
  • fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html: Removed.
  • fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child-expected.txt: Removed.
  • fast/css-grid-layout/grid-container-margin-border-padding-scrollbar-expected.txt: Removed.
  • fast/css-grid-layout/grid-container-margin-border-padding-scrollbar.html: Removed.
  • fast/css-grid-layout/grid-container-scroll-accounts-for-auto-margin.html: Removed.
  • fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width-expected.txt: Removed.
  • fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html: Removed.
  • fast/css-grid-layout/grid-content-alignment-and-self-alignment-spanning-expected.txt: Removed.
  • fast/css-grid-layout/grid-content-alignment-and-self-alignment-spanning.html: Removed.
  • fast/css-grid-layout/grid-content-alignment-and-self-alignment.html: Removed.
  • fast/css-grid-layout/grid-content-alignment-overflow.html: Removed.
  • fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html: Removed.
  • fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html: Removed.
  • fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html: Removed.
  • fast/css-grid-layout/grid-content-alignment-with-span.html: Removed.
  • fast/css-grid-layout/grid-item-margins-not-collapse.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-01.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-02-b.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-02-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-02.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-03-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-03.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-04-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-04.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-05.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-06-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-06.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-07.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-01-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-01.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-02-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-02.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-03-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-03.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-04-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-04.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-05-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-05.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-06-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-06.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-horiz-07.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-01-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-01.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-02-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-02.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-03-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-03.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-04-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-04.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-05-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-05.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-06-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-06.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-07-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-07.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-01-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-01.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-02-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-02.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-03-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-03.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-04-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-04.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-05-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-05.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-06-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-06.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-07-expected.html: Removed.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-07.html: Removed.
  • imported/blink/fast/css-grid-layout/grid-add-item-with-positioned-items-expected.txt: Removed.
  • imported/blink/fast/css-grid-layout/grid-add-item-with-positioned-items.html: Removed.
  • imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt: Removed.
  • imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html: Removed.
  • imported/blink/fast/css-grid-layout/grid-element-bad-cast-addchild-expected.txt: Removed.
  • imported/blink/fast/css-grid-layout/grid-element-bad-cast-addchild.html: Removed.
  • imported/blink/fast/css-grid-layout/grid-element-remove-svg-child-expected.txt: Removed.
  • imported/blink/fast/css-grid-layout/grid-element-remove-svg-child.html: Removed.
  • imported/blink/fast/css-grid-layout/positioned-grid-items-crash-expected.txt: Removed.
  • imported/blink/fast/css-grid-layout/positioned-grid-items-crash.html: Removed.
  • platform/ios-simulator/TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/wincairo/TestExpectations:
6:56 AM Changeset in webkit [262055] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

REGRESSION (r261978): Cannot click on links with trackpad on iPad
https://bugs.webkit.org/show_bug.cgi?id=212262

Reviewed by Andy Estes.

No new tests; our current WKMouseGestureRecognizer testing strategy
unfortunately bypasses this particular problem.

  • UIProcess/ios/WKMouseGestureRecognizer.mm:

(-[WKMouseGestureRecognizer _hoverEntered:withEvent:]):
(-[WKMouseGestureRecognizer _hoverMoved:withEvent:]):
(-[WKMouseGestureRecognizer _hoverExited:withEvent:]):
(-[WKMouseGestureRecognizer _hoverCancelled:withEvent:]):
Don't call super in any of the hover callbacks now that we derive from
UIHoverGestureRecognizer. We want to wholly own the state of the gesture,
including differences from UIHoverGestureRecognizer behavior such as
remaining in the recognizing state while the trackpad button is pressed.
We don't need any of the code in the default implementation, so just
override it entirely. This returns behavior to what it was like before r261978.

5:50 AM Changeset in webkit [262054] by Paulo Matos
  • 15 edits in trunk/Source/JavaScriptCore

Fix non-unified builds for i386 build
https://bugs.webkit.org/show_bug.cgi?id=212258

Reviewed by Adrian Perez de Castro.

  • API/JSContextRef.cpp:
  • bytecode/IntrinsicGetterAccessCase.cpp:
  • inspector/InjectedScriptHost.cpp:
  • llint/LLIntData.cpp:
  • llint/LLIntThunks.cpp:
  • runtime/Exception.cpp:
  • runtime/ExecutableBase.cpp:
  • runtime/JSBigInt.cpp:
  • runtime/JSInternalPromiseConstructor.cpp:
  • runtime/JSString.cpp:
  • runtime/ScopedArgumentsTable.cpp:
  • runtime/ScriptExecutable.cpp:
  • runtime/SparseArrayValueMap.cpp:
  • runtime/StructureRareData.cpp:
4:29 AM Changeset in webkit [262053] by Paulo Matos
  • 2 edits in trunk/Source/JavaScriptCore

Fix typo in JSCVirtualMachine documentation

Unreviewed Typo Fix.

  • API/glib/JSCVirtualMachine.cpp:
4:28 AM Changeset in webkit [262052] by jfernandez@igalia.com
  • 2 edits in trunk/Tools

[Flatpak SDK] CCACHE_ env vars are not forwarded to the sandbox environment
https://bugs.webkit.org/show_bug.cgi?id=212257

Reviewed by Philippe Normand.

Added the "CCACHE" prefix to the ones the SDK should keep from the
user's environment, and forwarded to the Flatpak sandbox.

  • flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

4:15 AM Changeset in webkit [262051] by timothy_horton@apple.com
  • 6 edits in trunk

iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back
https://bugs.webkit.org/show_bug.cgi?id=212243
<rdar://problem/59127764>

Reviewed by Wenson Hsieh.

Source/WebCore:

New API Tests: WebKit.ShiftTabTakesFocusFromEditableWebView and WebKit.TabDoesNotTakeFocusFromEditableWebView

  • page/FocusController.cpp:

(WebCore::FocusController::relinquishFocusToChrome):
(WebCore::FocusController::advanceFocusInDocumentOrder):

  • page/FocusController.h:

Factor out the code that decides whether the Chrome might accept focus,
and transfers focus out to the Chrome, for use in EventHandler.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultTabEventHandler):
In the case where we are shift-tabbing out of an editable web view,
allow focus to pass to the Chrome. Previously, we would not allow this,
because tabKeyCyclesThroughElements is false in editable web views.
However, focus exiting the web view entirely needn't be covered by
"cycles through elements" behavior.
We can't do this for plain "tab", because that needs to be allowed to
insert a tab character instead.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[FocusDelegate _webView:takeFocus:]):
(-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

3:17 AM WikiStart edited by Philippe Normand
(diff)
3:14 AM Sccache created by Philippe Normand
1:37 AM Changeset in webkit [262050] by Diego Pino Garcia
  • 3 edits in trunk/LayoutTests

[WPE] Gardening, update test expectations after r262047
https://bugs.webkit.org/show_bug.cgi?id=212255

Unreviewed gardening.

Gardened WPE failures that were already gardened in GTK test expectations
by moving them to GLib test expectations.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
1:34 AM Changeset in webkit [262049] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

Cannot style ::selection for a flex container
https://bugs.webkit.org/show_bug.cgi?id=209822

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-05-22
Reviewed by Antti Koivisto.

Source/WebCore:

When needing to query for pseudostyles, RenderText used to unconditionally check the parent's pseudostyles. The parent of
RenderText objects is often an anonymous box, depending on the presence of siblings, display type, etc. This is problematic
as pseudostyles are associated with an element of the DOM, meaning RenderText elements would often fail to find any pseudostyle
thanks to their anonymous parent.

This patch changes RenderText to traverse its tree of ancestry upwards until it finds a non-anonymous ancestor and gets those pseudostyles,
rather than unconditionally trying to get pseudostyles from its direct parent.

Blink does something similar when retrieving pseudostyles:

https://github.com/chromium/chromium/blob/793cb59c18334f8b506863192bf630776da0f4d2/third_party/blink/renderer/core/paint/selection_painting_utils.cc#L54

Tests: editing/selection/selection-display-block-sibling.html

editing/selection/selection-display-flex.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::firstNonAnonymousAncestor const):

  • rendering/RenderObject.h:
  • rendering/RenderText.h:

(WebCore::RenderText::getCachedPseudoStyle const): getCachedPseudoStyle from first non-anonymous ancestor, rather than only checking the direct parent.
(WebCore::RenderText::selectionBackgroundColor const): Retrieve selectionBackgroundColor from first non-anonymous ancestor rather than only checking the direct parent.
(WebCore::RenderText::selectionForegroundColor const): Retrieve selectionForegroundColor from first non-anonymous ancestor rather than only checking the direct parent.
(WebCore::RenderText::selectionEmphasisMarkColor const): Retrieve selectionEmphasisMarkColor from first non-anonymous ancestor rather than only checking the direct parent.
(WebCore::RenderText::selectionPseudoStyle const): Retrieve selectionPseudoStyle from first non-anonymous ancestor rather than only checking the direct parent.

LayoutTests:

Add tests verifying ::selection pseudoelement styling is properly applied on direct text-children of a display: flex; div and on
direct text-children of a display: block div with siblings.

  • editing/selection/selection-display-block-sibling.html: Added.
  • editing/selection/selection-display-flex.html: Added.
  • platform/gtk/editing/selection/selection-display-block-sibling-expected.png: Added.
  • platform/gtk/editing/selection/selection-display-block-sibling-expected.txt: Added.
  • platform/gtk/editing/selection/selection-display-flex-expected.png: Added.
  • platform/gtk/editing/selection/selection-display-flex-expected.txt: Added.

May 21, 2020:

11:24 PM Changeset in webkit [262048] by Diego Pino Garcia
  • 4 edits in trunk/LayoutTests

[WPE] Gardening, update test expectations after r261992
https://bugs.webkit.org/show_bug.cgi?id=212254

r261992 enabled several tests under fast/ directory. Many tests that
were meant to fail are passing now. Most of these tests were passing
already in GTK, so I moved the entries for the common tests passing to GLib
and leave local to WPE the tests passing in that platform.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
9:42 PM Changeset in webkit [262047] by Wenson Hsieh
  • 5 edits in trunk

DataTransfer.files contains multiple files when pasting a single image with multiple representations
https://bugs.webkit.org/show_bug.cgi?id=212245
<rdar://problem/60240436>

Reviewed by Tim Horton.

Source/WebCore:

When pasting or dropping a single image that is backed by multiple representations in NSPasteboard (or
UIPasteboard), we currently report more than one File to the page via DataTransfer.files. This is because
Pasteboard::read(PasteboardFileReader&), which is responsible for converting the contents of the pasteboard
into a list of files, currently iterates over every pasteboard type and adds each of them as a file. This is
wrong when an item has multiple type representations.

To differentiate the case where a single item has multiple representations from the case where it has multiple
pasteboard items, we use allPasteboardItemInfo() instead to grab a per-item list of types from the pasteboard
on Cocoa platforms, and only create at most 1 file per item using the highest fidelity type that contains data.

Test: PasteImage.PasteImageWithMultipleRepresentations

  • platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::read):

Tools:

  • DumpRenderTree/mac/DumpRenderTreePasteboard.mm:

(-[LocalPasteboard _clearContentsWithoutUpdatingChangeCount]):
(-[LocalPasteboard _addTypesWithoutUpdatingChangeCount:owner:]):
(-[LocalPasteboard writeObjects:]):
(-[LocalPasteboard pasteboardItems]):

Adjust DumpRenderTree's LocalPasteboard so that it lazily populates the pasteboard when constructing
NSPasteboardItems. To do this, we need to make a few adjustments:

  1. When reifying NSPasteboardItems from LocalPasteboard, ask the owner (WebHTMLView) to provide pasteboard

data for each pasteboard type that was promised by WebKit, but was not eagerly written to the pasteboard.

  1. Cache pasteboard items that were created, so that we don't repeatedly ask WebHTMLView to provide

pasteboard data. WebHTMLView doesn't currently support this, and suffers from a bug where TIFF data may
only be provided once. This was fixed for WebKit2, but not for WebKit1.

  1. Maintain a separate hash list of original pasteboard types (which may not be UTIs) that were handed to

LocalPasteboard by WebKit. We use these original types in step (1).

  • TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:

Add a new API test to verify that one file is exposed via the DataTranfer when the pasteboard contains a single
image with two image representations, but two files are exposed when the pasteboard contains two images, each
with a single representation.

(writeImageDataToPasteboard):

Overload this helper method with two additional variants: one that takes a dictionary of pasteboard types to
data, and another that takes an array of dictionaries, each representing a single item's types and data.

9:12 PM Changeset in webkit [262046] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix rare scrolling thread crash firing the m_delayedRenderingUpdateDetectionTimer timer
https://bugs.webkit.org/show_bug.cgi?id=212250

Reviewed by Tim Horton.

It seems that we can fire the m_delayedRenderingUpdateDetectionTimer timer after the
ScrollingTree has been destroyed (possibly because it's destroyed on another thread
and CFRunLoopTimerRef isn't threadsafe), so explicitly clear the timer in invalidate()
while holding m_treeMutex.

  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::invalidate):

8:52 PM Changeset in webkit [262045] by weinig@apple.com
  • 5 edits in trunk/Source

Extended Color Cleanup: Move Color coder definitions to Color to allow for future encaspulation improvements
https://bugs.webkit.org/show_bug.cgi?id=212247

Reviewed by Simon Fraser.

Move IPC encoder/decoder definitions from WebKit down into Color itself to move closer
to making Color::rgb() private.

Source/WebCore:

  • platform/graphics/Color.h:

(WebCore::Color::encode const):
(WebCore::Color::decode):

Source/WebKit:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Color>::encode): Deleted.
(IPC::ArgumentCoder<Color>::decode): Deleted.

  • Shared/WebCoreArgumentCoders.h:
8:26 PM Changeset in webkit [262044] by dino@apple.com
  • 4 edits in trunk

PVRTC compressed textures are failing with ANGLE backend
https://bugs.webkit.org/show_bug.cgi?id=212240
<rdar://problem/63517385>

Reviewed by Ken Russell (representing ANGLE).

Source/ThirdParty/ANGLE:

The values used for the PVRTC formats were incorrect.

  • src/libANGLE/formatutils.cpp:

(gl::BuildInternalFormatInfoMap):

LayoutTests:

Merge the upstream change to this test.

  • webgl/1.0.3/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-pvrtc.html:
7:21 PM Changeset in webkit [262043] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Scrolling thread scrolls on sync-scrolling scrollers don't get to the main thread
https://bugs.webkit.org/show_bug.cgi?id=212225

Fix builds that use Nicosia after r262041.

  • page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::currentScrollPositionChanged):

  • page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h:
7:18 PM Changeset in webkit [262042] by Simon Fraser
  • 15 edits in trunk/Source/WebCore

Fix some thread safety issues with ScrollController timers
https://bugs.webkit.org/show_bug.cgi?id=212238

Reviewed by Wenson Hsieh.

There were some problems with the timers fired by ScrollController, used for rubber-banding
and scroll snap.

First, they could fire on the main thread when we intended them to fire on the scrolling thread.
This happened because in r260716 I made the scrolling tree commit on the main thread, so we'd
construct the ScrollingTreeScrollingNodeDelegateMac and its ScrollController there and its
timers would grab the main thread runloop. Fix by creating the timers on demand.

Secondly, the timer callbacks called into scrolling tree code, but without taking
the scrolling tree lock,
and without any guarantee that the node would stay alive for the duration of the callback.
Fix by having the ScrollControllerClient create the timers, allowing the client to have
a callback wrapper that locks, and to ensure object lifetime (or make a weak ref). Now
that scrolling tree nodes could be extended by a pending timer, we need to explicitly
clear the timers when nodes are removed from the tree.

Finally, rename some confusingly named ScrollControllerClient functions.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitTreeState):

  • page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::treeMutex):

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::wasBeRemovedFromTree):

  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::wasBeRemovedFromTree):

  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:

(WebCore::ScrollingTreeOverflowScrollingNodeMac::wasBeRemovedFromTree):

  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::nodeWillBeDestroyed):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::createTimer):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::didStopRubberbandSnapAnimation):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::willStartScrollSnapAnimation):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::didStopScrollSnapAnimation):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::stopSnapRubberbandTimer): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::startScrollSnapTimer): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::stopScrollSnapTimer): Deleted.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::createTimer):

  • platform/ScrollAnimator.h:
  • platform/cocoa/ScrollController.h:

(WebCore::ScrollControllerTimer::ScrollControllerTimer):
(WebCore::ScrollControllerClient::willStartRubberBandSnapAnimation):
(WebCore::ScrollControllerClient::didStopRubberbandSnapAnimation):
(WebCore::ScrollControllerClient::willStartScrollSnapAnimation):
(WebCore::ScrollControllerClient::didStopScrollSnapAnimation):
(WebCore::ScrollControllerClient::startSnapRubberbandTimer): Deleted.
(WebCore::ScrollControllerClient::stopSnapRubberbandTimer): Deleted.
(WebCore::ScrollControllerClient::startScrollSnapTimer): Deleted.
(WebCore::ScrollControllerClient::stopScrollSnapTimer): Deleted.

  • platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::ScrollController):
(WebCore::ScrollController::stopAllTimers):
(WebCore::ScrollController::handleWheelEvent):
(WebCore::ScrollController::snapRubberBandTimerFired):
(WebCore::ScrollController::isRubberBandInProgress const):
(WebCore::ScrollController::isScrollSnapInProgress const):
(WebCore::ScrollController::startSnapRubberbandTimer):
(WebCore::ScrollController::stopSnapRubberbandTimer):
(WebCore::ScrollController::snapRubberBand):
(WebCore::ScrollController::scheduleStatelessScrollSnap):
(WebCore::ScrollController::statelessSnapTransitionTimerFired):
(WebCore::ScrollController::startScrollSnapTimer):
(WebCore::ScrollController::stopScrollSnapTimer):

  • platform/mac/ScrollAnimatorMac.h:
7:17 PM Changeset in webkit [262041] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Scrolling thread scrolls on sync-scrolling scrollers don't get to the main thread
https://bugs.webkit.org/show_bug.cgi?id=212225

Reviewed by Tim Horton.

Some scrolls on nodes with synchronousScrollingReasons failed to set the m_scrolledSinceLastCommit bit,
because ScrollingTreeFrameScrollingNodeMac::currentScrollPositionChanged() bypassed a call to the superclass.

Fix by passing ScrollingLayerPositionAction so that it can just call super.

This will be tested by existing tests after some upcoming scroll snap changes.

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::currentScrollPositionChanged):

  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::currentScrollPositionChanged):

7:17 PM Changeset in webkit [262040] by rmorisset@apple.com
  • 13 edits in trunk

Various compile-time boolean flags could/should be marked constexpr
https://bugs.webkit.org/show_bug.cgi?id=212244

Reviewed by Mark Lam.

Source/JavaScriptCore:

This trivial patch saves roughly 16kB from the JavaScriptCore binary in release mode.

  • b3/B3OptimizeAssociativeExpressionTrees.cpp:
  • b3/air/AirAllocateRegistersByGraphColoring.cpp:
  • b3/air/AirSimplifyCFG.cpp:

(JSC::B3::Air::simplifyCFG):

  • b3/air/AirTmpWidth.cpp:

(JSC::B3::Air::TmpWidth::recompute):

  • dfg/DFGPredictionPropagationPhase.cpp:
  • heap/GCIncomingRefCountedInlines.h:

(JSC::GCIncomingRefCounted<T>::filterIncomingReferences):

  • heap/Heap.cpp:

(JSC::Heap::updateAllocationLimits):

  • wasm/WasmEntryPlan.cpp:

Source/WTF:

  • wtf/ParkingLot.cpp:

Tools:

  • TestWebKitAPI/Tests/WTF/Condition.cpp:
5:39 PM Changeset in webkit [262039] by rmorisset@apple.com
  • 3 edits
    1 delete in trunk/Source/JavaScriptCore

Remove AssemblerBufferWithConstantPool.h (as it has been dead for years)
https://bugs.webkit.org/show_bug.cgi?id=212241

Reviewed by Yusuke Suzuki.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AssemblerBufferWithConstantPool.h: Removed.
5:20 PM Changeset in webkit [262038] by Peng Liu
  • 33 edits in trunk

Fix issues of the Picture-in-Picture API under stress tests
https://bugs.webkit.org/show_bug.cgi?id=212191

Reviewed by Eric Carlson.

Source/WebCore:

The current implementation of the Picture-in-Picture API is not robust under stress tests.
Changing the video presentation mode of a video element between inline and picture-in-picture
continuously may corrupt the internal states of the video element.

This patch refactors the approach to tracking the progress of video presentation mode changes
and make sure no new requestPictureInPicture() or exitPictureInPicture() will trigger
a presentation mode change unless the previous operations are completed.

This patch also removes the code for testing purposes in the HTMLVideoElement class.

Covered by existing tests.

  • html/HTMLMediaElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::toPresentationMode):
(WebCore::HTMLVideoElement::setFullscreenMode):
(WebCore::HTMLVideoElement::fullscreenModeChanged):
(WebCore::HTMLVideoElement::didEnterFullscreen):
(WebCore::HTMLVideoElement::didExitFullscreen):
(WebCore::HTMLVideoElement::setPictureInPictureObserver):
(WebCore::HTMLVideoElement::setVideoFullscreenFrame):
(WebCore::HTMLVideoElement::didBecomeFullscreenElement): Deleted.
(WebCore::HTMLVideoElement::setPictureInPictureAPITestEnabled): Deleted.

  • html/HTMLVideoElement.h:
  • testing/Internals.cpp:

(WebCore::Internals::setPictureInPictureAPITestEnabled): Deleted.

  • testing/Internals.h:
  • testing/Internals.idl:

Remove setPictureInPictureAPITestEnabled().

Source/WebKit:

  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::enterFullscreen):
Mock the behavior of the VideoFullscreenInterface[AVKit|Mac] regarding
the Picture-in-Picture mode support.

  • WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::didEnterFullscreen):
(WebKit::VideoFullscreenManager::didCleanupFullscreen):
Add callbacks for the end of entering/exiting fullscreen.

LayoutTests:

Refactor the layout tests for the Picture-in-Picture API with the Mock VideoPresentation Mode.

  • media/picture-in-picture/picture-in-picture-api-css-selector-expected.txt:
  • media/picture-in-picture/picture-in-picture-api-css-selector.html:
  • media/picture-in-picture/picture-in-picture-api-enter-pip-1-expected.txt:
  • media/picture-in-picture/picture-in-picture-api-enter-pip-1.html:
  • media/picture-in-picture/picture-in-picture-api-enter-pip-2-expected.txt:
  • media/picture-in-picture/picture-in-picture-api-enter-pip-2.html:
  • media/picture-in-picture/picture-in-picture-api-enter-pip-3-expected.txt:
  • media/picture-in-picture/picture-in-picture-api-enter-pip-3.html:
  • media/picture-in-picture/picture-in-picture-api-enter-pip-4-expected.txt:
  • media/picture-in-picture/picture-in-picture-api-enter-pip-4.html:
  • media/picture-in-picture/picture-in-picture-api-events-expected.txt:
  • media/picture-in-picture/picture-in-picture-api-events.html:
  • media/picture-in-picture/picture-in-picture-api-exit-pip-1-expected.txt:
  • media/picture-in-picture/picture-in-picture-api-exit-pip-1.html:
  • media/picture-in-picture/picture-in-picture-api-exit-pip-2-expected.txt:
  • media/picture-in-picture/picture-in-picture-api-exit-pip-2.html:
  • media/picture-in-picture/picture-in-picture-api-pip-window-expected.txt:
  • media/picture-in-picture/picture-in-picture-api-pip-window.html:
  • media/picture-in-picture/picture-in-picture-events-expected.txt:
  • media/picture-in-picture/picture-in-picture-events.html:
  • media/picture-in-picture/picture-in-picture-interruption-expected.txt:
  • media/picture-in-picture/picture-in-picture-interruption.html:
5:13 PM Changeset in webkit [262037] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Fix misspelling -- m_releaseNetwrokActivityTimer --> m_releaseNetworkActivityTimer
https://bugs.webkit.org/show_bug.cgi?id=212237

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-05-21
Reviewed by Simon Fraser.

No new tests required -- simply fixing a misspelling.

  • UIProcess/Cocoa/NavigationState.h: Rename m_releaseNetwrokActivityTimer to m_releaseNetworkActivityTimer
  • UIProcess/Cocoa/NavigationState.mm: Rename m_releaseNetwrokActivityTimer to m_releaseNetworkActivityTimer

(WebKit::NavigationState::NavigationState):
(WebKit::NavigationState::releaseNetworkActivity):
(WebKit::NavigationState::didChangeIsLoading):

5:12 PM Changeset in webkit [262036] by commit-queue@webkit.org
  • 430 edits
    41 adds
    1 delete in trunk/Source/ThirdParty/ANGLE

Roll ANGLE to 2020-05-21
https://bugs.webkit.org/show_bug.cgi?id=212228

Patch by Kenneth Russell <kbr@chromium.org> on 2020-05-21
Reviewed by Dean Jackson.

Roll ANGLE to 96a80283cc0fe604d03c0bc0b3f9eb100edd22f9 in the
upstream repository using jdarpinian's excellent update-angle.sh
script.

Manually undo the fix from Bug 210992, which was fixed differently
upstream.

4:33 PM Changeset in webkit [262035] by weinig@apple.com
  • 20 edits in trunk/Source

Extended Color Cleanup: Remove trivial uses of Color::rgb()
https://bugs.webkit.org/show_bug.cgi?id=212231

Source/WebCore:

Reviewed by Darin Adler

Replaces a few unnecessary uses of Color::rgb():

  • Uses of an idiom where code round-tripped a Color via Color(myColor.rgb()). This is not compatible with extended colors and seems to be unnecessary.
  • Uses of colorWithOverrideAlpha(). This function requires a SimpleColor, so required using color.rgb(). We can't transition to Color::colorWithAlpha due to a slightly different rounding of the alpha, so a new function Color::colorWithAlphaUsingAlternativeRounding was added to which implements the alternative rounding. A later change can reconcile the two versions.
  • Creation of D2D1::ColorF. D2D1::ColorF has a constructor that takes a four floats that is used instead.
  • Comparing two colors using rgb() for each to avoid comparing the semantic bit. equalIgnoringSemanticColor exists for just this use.
  • editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::colorPropertyValueForNode):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::addHTMLColorToStyle):

  • html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::setStrokeStyle):
(WebCore::CanvasRenderingContext2DBase::setFillStyle):
(WebCore::CanvasRenderingContext2DBase::setShadow):

  • html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::createFromStringWithOverrideAlpha):

  • html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::updateCueFromCueData):

  • platform/graphics/Color.cpp:

(WebCore::Color::colorWithAlphaMultipliedByUsingAlternativeRounding const):
(WebCore::Color::colorWithAlpha const):
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const):
(WebCore::colorWithOverrideAlpha): Deleted.

  • platform/graphics/Color.h:

(WebCore::colorWithOverrideAlpha): Deleted.

  • platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::prepareCairoContextSource):

  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::platformApplySoftware):

  • platform/graphics/win/ColorDirect2D.cpp:

(WebCore::Color::operator D2D1_COLOR_F const):
(WebCore::Color::operator D2D1_VECTOR_4F const):

  • platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::colorWithGlobalAlpha const):

  • platform/mac/ThemeMac.mm:

(WebCore::drawCellFocusRingWithFrameAtTime):

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintFileUploadIconDecorations):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::platformFocusRingColor const):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

  • svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::stopColorIncludingOpacity const):

Source/WebKit:

Reviewed by Darin Adler.

  • UIProcess/API/ios/WKWebViewIOS.mm:

(scrollViewBackgroundColor):
Replace colorWithOverrideAlpha() with Color::colorWithAlphaUsingAlternativeRounding() to avoid
unnecessary use of Color::rgb()

4:16 PM Changeset in webkit [262034] by mark.lam@apple.com
  • 2 edits in trunk/Tools

Rename some variables in Bitmap API test for consistency and better readability.
https://bugs.webkit.org/show_bug.cgi?id=212235

Reviewed by Saam Barati.

This patch renames the following:

bitmap0 => bitmapZeroes
bitmapFilled => bitmapOnes
bitmap3 => bitmap2Clone
bitmapSmallZeroed => smallBitmapZeroes
bitmapSmallFilled => smallBitmapOnes
bitmapSmall1 => smallBitmap1
bitmapSmall2 => smallBitmap2

Apart from these renamings, there are no other code changes.

  • TestWebKitAPI/Tests/WTF/Bitmap.cpp:

(TestWebKitAPI::testBitmapSize):
(TestWebKitAPI::testBitmapConstructedEmpty):
(TestWebKitAPI::testBitmapSetGet):
(TestWebKitAPI::testBitmapTestAndSet):
(TestWebKitAPI::testBitmapTestAndClear):
(TestWebKitAPI::testBitmapConcurrentTestAndSet):
(TestWebKitAPI::testBitmapConcurrentTestAndClear):
(TestWebKitAPI::testBitmapClear):
(TestWebKitAPI::testBitmapClearAll):
(TestWebKitAPI::testBitmapInvert):
(TestWebKitAPI::testBitmapFindRunOfZeros):
(TestWebKitAPI::testBitmapCount):
(TestWebKitAPI::testBitmapIsEmpty):
(TestWebKitAPI::testBitmapIsFull):
(TestWebKitAPI::testBitmapMerge):
(TestWebKitAPI::testBitmapFilter):
(TestWebKitAPI::testBitmapExclude):
(TestWebKitAPI::testBitmapConcurrentFilter):
(TestWebKitAPI::testBitmapSubsumes):
(TestWebKitAPI::testBitmapForEachSetBit):
(TestWebKitAPI::testBitmapFindBit):
(TestWebKitAPI::testBitmapIteration):
(TestWebKitAPI::testBitmapMergeAndClear):
(TestWebKitAPI::testBitmapSetAndClear):
(TestWebKitAPI::testBitmapSetEachNthBit):
(TestWebKitAPI::testBitmapOperatorEqual):
(TestWebKitAPI::testBitmapOperatorNotEqual):
(TestWebKitAPI::testBitmapOperatorAssignment):
(TestWebKitAPI::testBitmapOperatorBitOrAssignment):
(TestWebKitAPI::testBitmapOperatorBitAndAssignment):
(TestWebKitAPI::testBitmapOperatorBitXorAssignment):
(TestWebKitAPI::testBitmapHash):

3:59 PM Changeset in webkit [262033] by Oriol Brufau
  • 6 edits
    2 adds in trunk

[css-grid] Don't create renderers for whitespace nodes
https://bugs.webkit.org/show_bug.cgi?id=212220

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Import WPT test.

  • web-platform-tests/css/css-grid/grid-items/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-items/whitespace-in-grid-item-001-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/whitespace-in-grid-item-001.html: Added.

Source/WebCore:

Even with 'white-space: pre' we shouldn't create RenderTexts
for whitespace-only nodes in grid layout, according to
https://drafts.csswg.org/css-grid/#grid-items

This patch is based on https://codereview.chromium.org/16888008

Tests: fast/text/simple-line-layout-with-zero-sized-font.html

imported/w3c/web-platform-tests/css/css-grid/grid-items/whitespace-in-grid-item-001.html

  • rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::textRendererIsNeeded):

LayoutTests:

Update test expectation.

  • fast/text/simple-line-layout-with-zero-sized-font-expected.txt:
3:30 PM Changeset in webkit [262032] by achristensen@apple.com
  • 7 edits in trunk/Source/WebKit

Use an OptionSet instead of uint8_t for MessageFlags
https://bugs.webkit.org/show_bug.cgi?id=212230
<rdar://problem/63496543>

Reviewed by Darin Adler.

I also reduce the encoding size of OptionSet.

  • Platform/IPC/ArgumentCoders.h:

(IPC::ArgumentCoder<OptionSet<T>>::encode):
(IPC::ArgumentCoder<OptionSet<T>>::decode):

  • Platform/IPC/Decoder.cpp:

(IPC::Decoder::isSyncMessage const):
(IPC::Decoder::shouldDispatchMessageWhenWaitingForSyncReply const):
(IPC::Decoder::shouldUseFullySynchronousModeForTesting const):

  • Platform/IPC/Decoder.h:
  • Platform/IPC/Encoder.cpp:

(IPC::Encoder::isSyncMessage const):
(IPC::Encoder::shouldDispatchMessageWhenWaitingForSyncReply const):
(IPC::Encoder::setIsSyncMessage):
(IPC::Encoder::setShouldDispatchMessageWhenWaitingForSyncReply):
(IPC::Encoder::setFullySynchronousModeForTesting):
(IPC::Encoder::messageFlags):
(IPC::Encoder::messageFlags const):

  • Platform/IPC/Encoder.h:
  • Platform/IPC/MessageFlags.h:

(): Deleted.

3:25 PM Changeset in webkit [262031] by Diego Pino Garcia
  • 3 edits in trunk/LayoutTests

[GTK] Gardening, update expectations after r262016
https://bugs.webkit.org/show_bug.cgi?id=212234

Unreviewed gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
3:12 PM Changeset in webkit [262030] by mark.lam@apple.com
  • 4 edits in trunk

Add more Bitmap methods.
https://bugs.webkit.org/show_bug.cgi?id=212190
<rdar://problem/63481333>

Reviewed by Robin Morisset.

Source/WTF:

Specifically,

setEachNthBit - sets every Nth bit starting at a specified start bit
operator= - assignment
operator|= - bit or and assignment
operator&= - bit and and assignment
operator= - bit xor and assignment

  • wtf/Bitmap.h:

Tools:

Added test coverage for the new WTF::Bitmap methods.

  • TestWebKitAPI/Tests/WTF/Bitmap.cpp:

(TestWebKitAPI::testBitmapSetEachNthBit):
(TestWebKitAPI::testBitmapOperatorAssignment):
(TestWebKitAPI::testBitmapOperatorBitOrAssignment):
(TestWebKitAPI::testBitmapOperatorBitAndAssignment):
(TestWebKitAPI::testBitmapOperatorBitXorAssignment):
(TestWebKitAPI::TEST):

2:25 PM Changeset in webkit [262029] by dino@apple.com
  • 1 edit in trunk/LayoutTests/platform/ios/TestExpectations

Update description.

  • platform/ios/TestExpectations:
2:20 PM Changeset in webkit [262028] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix rare crash in TileGrid::platformCALayerShowRepaintCounter()
https://bugs.webkit.org/show_bug.cgi?id=212182
<rdar://problem/55618414>

Reviewed by Darin Adler.

Crash data suggest that owner() can be null in platformCALayerShowRepaintCounter(),
so null-check in these functions.

  • platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::platformCALayerDeviceScaleFactor const):
(WebCore::TileGrid::platformCALayerShowDebugBorders const):
(WebCore::TileGrid::platformCALayerShowRepaintCounter const):
(WebCore::TileGrid::isUsingDisplayListDrawing const):

2:20 PM Changeset in webkit [262027] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark some webgl video tests as skipped
now that they timeout rather than failing instantly.

  • platform/ios/TestExpectations:
1:40 PM Changeset in webkit [262026] by youenn@apple.com
  • 5 edits
    2 adds in trunk

Incorrect location.origin in blob workers
https://bugs.webkit.org/show_bug.cgi?id=211876
<rdar://problem/63284717>

Reviewed by Sihui Liu.

Source/WebCore:

Instead of computing the origin from the location URL in worker, get it directly from the WorkerGlobalScope origin.
This ensures we unwrap properly blob URLs.

Test: http/tests/security/contentSecurityPolicy/worker-blob-location.html

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::location const):

  • workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::origin const):

  • workers/WorkerLocation.h:

(WebCore::WorkerLocation::create):
(WebCore::WorkerLocation::url const):
(WebCore::WorkerLocation::WorkerLocation):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/worker-blob-location-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-blob-location.html: Added.
1:27 PM Changeset in webkit [262025] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening, remove expectations for tests that are consistently passing.

  • platform/ios-wk2/TestExpectations:
1:22 PM Changeset in webkit [262024] by wilander@apple.com
  • 20 edits in trunk/Source

Storage Access API: Allow configurable storage access scope
https://bugs.webkit.org/show_bug.cgi?id=212114
<rdar://problem/63423063>

Reviewed by Alex Christensen.

The scope of storage access as per-frame or per-page was discussed in the
standards process here: https://github.com/privacycg/storage-access/issues/3

The decision was to have per-page storage access by default. Recent feedback
from Google and conversation with Mozilla suggest that we might want to
support the caller choosing the scope.

This patch adds support for different scope configurations while keeping the
existing default as per-frame. A later patch will switch the default and add
test cases for per-page scope.

Source/WebCore:

A new struct is added WebCore::RequestStorageAccessResult which carries full
information about the storage access request result.

A new enum is added WebCore::StorageAccessScope to encode per-frame and
per-page access.

No new tests. No changed functionality. Tests already exist.

  • dom/DocumentStorageAccess.cpp:

(WebCore::DocumentStorageAccess::requestStorageAccess):

  • dom/DocumentStorageAccess.h:

(WebCore::RequestStorageAccessResult::encode const):
(WebCore::RequestStorageAccessResult::decode):

  • page/ChromeClient.h:

(WebCore::ChromeClient::requestStorageAccess):

Source/WebKit:

Most of the changes is piping through the new enum
WebCore::StorageAccessScope from the call side to encode per-frame and
per-page access, and piping through the new struct
WebCore::RequestStorageAccessResult on the return side which carries full
information about the storage access request result.

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::CompletionHandler<void):

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::requestStorageAccess):
(WebKit::ResourceLoadStatisticsMemoryStore::requestStorageAccessUnderOpener):
(WebKit::ResourceLoadStatisticsMemoryStore::grantStorageAccess):
(WebKit::ResourceLoadStatisticsMemoryStore::grantStorageAccessInternal):

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
  • NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessEphemeral):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccessEphemeral):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccessInStorageSession):

Renamed from WebResourceLoadStatisticsStore::grantStorageAccess()
to reduce confusion since we already have another function called
WebResourceLoadStatisticsStore::grantStorageAccess().

(WebKit::WebResourceLoadStatisticsStore::callGrantStorageAccessHandler):

  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::requestStorageAccess):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • Scripts/webkit/messages.py:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::requestStorageAccess):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestStorageAccess):

  • WebProcess/WebPage/WebPage.h:
1:14 PM Changeset in webkit [262023] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Null Ptr Deref @ WebCore::ResourceResponse::platformLazyInit
https://bugs.webkit.org/show_bug.cgi?id=212224

Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-05-21
Reviewed by Geoffrey Garen.

Source/WebKitLegacy/mac:

Its possible that client can cancel the load implicitly or explicitly after its informed that load is committed, but code continues to assume that
loading is still in progress. This was cause of crash.
Added nullptr check before dereferencing the documentLoader, after client calls the commit load.

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation receivedData:withDataSource:]):

LayoutTests:

Added a regression test.

  • media/continue-load-after-client-cancellation-crash-expected.txt: Added.
  • media/continue-load-after-client-cancellation-crash.html: Added.
12:52 PM Changeset in webkit [262022] by yoshiaki.jitsukawa@sony.com
  • 29 edits
    8 copies
    7 adds in trunk

[PlayStation] Add minimal WKView API to enable TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=211868

Reviewed by Alex Christensen.

Enable TestWebKitAPI

.:

  • Source/cmake/OptionsPlayStation.cmake:

Disable FullScreen API and ContextMenus.

Source/WebCore:

  • PlatformPlayStation.cmake:

Add WebKitRequirements library to WebCore_CopySharedLibs.

Source/WebKit:

  • Platform/IPC/Connection.h:
  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::platformInvalidate):
(IPC::Connection::open):
Add SocketMonitor to monitor received messages.

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:

Add PlayStation specific members: WebProcess and NetworkProcess paths, and user ID.

  • UIProcess/Launcher/ProcessLauncher.h:

Add PlayStation specific members: Process path and user ID.

  • NetworkProcess/EntryPoint/playstation/NetworkProcessMain.cpp: Copied from Tools\TestWebKitAPI\playstation\main.cpp.

(loadLibraryOrExit):
(main):

  • PlatformPlayStation.cmake:
  • Shared/API/c/playstation/WKEventPlayStation.cpp: Added.

(WKKeyboardEventMake):
(WKMouseEventMake):
(WKWheelEventMake):

  • Shared/API/c/playstation/WKEventPlayStation.h: Added.
  • UIProcess/API/C/playstation/WKAPICastPlayStation.h:

(WebKit::toAPI<>):
(WebKit::toImpl<>):

  • UIProcess/API/C/playstation/WKContextConfigurationPlayStation.cpp: Copied from Tools\TestWebKitAPI\playstation\PlatformUtilitiesPlayStation.cpp.

(WKContextConfigurationSetWebProcessPath):
(WKContextConfigurationCopyWebProcessPath):
(WKContextConfigurationSetNetworkProcessPath):
(WKContextConfigurationCopyNetworkProcessPath):
(WKContextConfigurationSetUserId):
(WKContextConfigurationGetUserId):

  • UIProcess/API/C/playstation/WKContextConfigurationPlayStation.h: Copied from Source\WebKit\UIProcess\API\C\playstation\WKView.h.
  • UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp: Added.

(WKPageHandleKeyboardEvent):
(WKPageHandleMouseEvent):
(WKPageHandleWheelEvent):

  • UIProcess/API/C/playstation/WKPagePrivatePlayStation.h: Copied from Source\WebKit\UIProcess\API\C\playstation\WKView.h.
  • UIProcess/API/C/playstation/WKView.cpp: Copied from Source\WebKit\WebProcess\InjectedBundle\playstation\InjectedBundlePlayStation.cpp.

(WKViewCreate):
(WKViewGetPage):

  • UIProcess/API/C/playstation/WKView.h:
  • UIProcess/Launcher/playstation/ProcessLauncherPlayStation.cpp:

(WebKit::defaultProcessPath):
(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getLaunchOptions):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions):

  • UIProcess/playstation/PageClientImpl.cpp: Added.

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::requestScroll):
(WebKit::PageClientImpl::viewScrollPosition):
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::processDidExit):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::pageClosed):
(WebKit::PageClientImpl::preferencesDidChange):
(WebKit::PageClientImpl::toolTipChanged):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::handleDownloadRequest):
(WebKit::PageClientImpl::didChangeContentSize):
(WebKit::PageClientImpl::setCursor):
(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves):
(WebKit::PageClientImpl::didChangeViewportProperties):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
(WebKit::PageClientImpl::wheelEventWasNotHandledByWebCore):
(WebKit::PageClientImpl::convertToDeviceSpace):
(WebKit::PageClientImpl::convertToUserSpace):
(WebKit::PageClientImpl::screenToRootView):
(WebKit::PageClientImpl::rootViewToScreen):
(WebKit::PageClientImpl::accessibilityScreenToRootView):
(WebKit::PageClientImpl::rootViewToAccessibilityScreen):
(WebKit::PageClientImpl::doneWithKeyEvent):
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
(WebKit::PageClientImpl::updateAcceleratedCompositingMode):
(WebKit::PageClientImpl::fullScreenManagerProxyClient):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomContentProvider):
(WebKit::PageClientImpl::navigationGestureDidBegin):
(WebKit::PageClientImpl::navigationGestureWillEnd):
(WebKit::PageClientImpl::navigationGestureDidEnd):
(WebKit::PageClientImpl::willRecordNavigationSnapshot):
(WebKit::PageClientImpl::didRemoveNavigationGestureSnapshot):
(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
(WebKit::PageClientImpl::didFinishLoadForMainFrame):
(WebKit::PageClientImpl::didFailLoadForMainFrame):
(WebKit::PageClientImpl::didSameDocumentNavigationForMainFrame):
(WebKit::PageClientImpl::didChangeBackgroundColor):
(WebKit::PageClientImpl::isPlayingAudioWillChange):
(WebKit::PageClientImpl::isPlayingAudioDidChange):
(WebKit::PageClientImpl::refView):
(WebKit::PageClientImpl::derefView):
(WebKit::PageClientImpl::didRestoreScrollPosition):
(WebKit::PageClientImpl::userInterfaceLayoutDirection):
(WebKit::PageClientImpl::requestDOMPasteAccess):

  • UIProcess/playstation/PageClientImpl.h: Added.
  • UIProcess/playstation/WebProcessPoolPlayStation.cpp:

(WebKit::WebProcessPool::platformInitialize):

  • UIProcess/playstation/PlayStationWebView.cpp: Copied from Source\WebKit\UIProcess\playstation\WebProcessPoolPlayStation.cpp.

(WebKit::PlayStationWebView::create):
(WebKit::PlayStationWebView::PlayStationWebView):
(WebKit::PlayStationWebView::~PlayStationWebView):
(WebKit::PlayStationWebView::isActive const):
(WebKit::PlayStationWebView::isFocused const):
(WebKit::PlayStationWebView::isVisible const):

  • UIProcess/playstation/PlayStationWebView.h: Copied from Source\WebKit\WebProcess\InjectedBundle\playstation\InjectedBundlePlayStation.cpp.

(WebKit::PlayStationWebView::page):

  • WebProcess/EntryPoint/playstation/WebProcessMain.cpp: Copied from Tools\TestWebKitAPI\playstation\main.cpp.

(loadLibraryOrExit):
(main):

  • WebProcess/InjectedBundle/playstation/InjectedBundlePlayStation.cpp:

(WebKit::InjectedBundle::initialize):
(WebKit::InjectedBundle::setBundleParameter):

  • WebProcess/WebPage/AcceleratedSurface.cpp:

(WebKit::AcceleratedSurface::create):

Source/WTF:

  • wtf/PlatformPlayStation.cmake:

Link libc as a system library.

Tools:

  • TestWebKitAPI/PlatformPlayStation.cmake:
  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/playstation/PlatformUtilitiesPlayStation.cpp:

(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):

  • TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::initialize):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page const):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI::PlatformWebView::simulateButtonClick):

  • TestWebKitAPI/playstation/main.cpp:

(loadLibraryOrExit):
(main):
Add PlayStation Platform support.

  • TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:

(TestWebKitAPI::TEST):
Use the same expected default font preferences as GTK's.

12:04 PM Changeset in webkit [262021] by Peng Liu
  • 2 edits in trunk/LayoutTests

Layout test media/video-fullscreen-only-playback.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=212171

Reviewed by Jer Noble.

  • media/video-fullscreen-only-playback.html:
12:01 PM Changeset in webkit [262020] by Alan Coon
  • 1 edit in branches/safari-609-branch/Source/WTF/wtf/threads/Signals.cpp

Unreviewed build fix. rdar://problem/63461433

Use WTF_CPU_EFFECTIVE_ADDRESS_WIDTH on branch, rather than the undefined OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH).

12:00 PM Changeset in webkit [262019] by Chris Dumez
  • 2 edits in trunk/LayoutTests

compositing/show-composited-iframe-on-back-button.html is a flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=212221
<rdar://problem/63493074>

Reviewed by Alex Christensen.

I am unable to reproduce the flakiness locally so this is a speculative fix.
Stop using testRunner.queueLoad() / testRunner.queueBackNavigation() and instead
just navigate to page-cache-helper.html in JS, by setting window.location.
Also, call testRunner.waitUntilDone() and call testRunner.notifyDone() when the
page comes out of the back/forward cache.

  • compositing/show-composited-iframe-on-back-button.html:
11:52 AM Changeset in webkit [262018] by achristensen@apple.com
  • 8 edits in trunk/Tools

[macOS] TestWebKitAPI.WebKit.HTTPReferer is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=212180

Reviewed by Darin Adler.

Sometimes an HTTP request takes more than one call to nw_connection_receive to receive entirely.
Add a new abstraction Connection that wraps an nw_connection_t and knows how to read an entire request.
Use strnstr instead of null terminating and using strstr.

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerTCPServer.h:
  • TestWebKitAPI/cocoa/HTTPServer.h:

(TestWebKitAPI::Connection::receiveHTTPRequest):
(TestWebKitAPI::Connection::Connection):

  • TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::HTTPServer):
(TestWebKitAPI::dataFromString):
(TestWebKitAPI::vectorFromData):
(TestWebKitAPI::HTTPServer::respondToRequests):
(TestWebKitAPI::HTTPServer::request const):
(TestWebKitAPI::Connection::receiveHTTPRequest const):
(TestWebKitAPI::Connection::send const):
(TestWebKitAPI::Connection::terminate const):
(TestWebKitAPI::nullTerminatedRequest): Deleted.

11:37 AM Changeset in webkit [262017] by Alexey Shvayka
  • 8 edits in trunk

Use @isUndefinedOrNull instead of abstract equality with null
https://bugs.webkit.org/show_bug.cgi?id=210954

Reviewed by Yusuke Suzuki.

JSTests:

  • test262/expectations.yaml: Mark 16 test cases as passing.

Source/JavaScriptCore:

This patch:

a) Replaces 2 !== @undefined comparisons in String.prototype.{replace,replaceAll}
with @isUndefinedOrNull() as per spec [1], aligning JSC with V8 and SpiderMonkey.

b) Replaces 3 != @undefined and 7 != null comparisons with @isUndefinedOrNull()
as only the latter is correct with IsHTMLDDA? aka MasqueradesAsUndefined objects [2].

c) Removes @isDictionary() since it is unused, easy to inline and its name is quite
misleading: one might expect it to perform Structure::isDictionary().

[1]: https://tc39.es/ecma262/#sec-getmethod (step 3)
[2]: https://tc39.es/ecma262/#sec-IsHTMLDDA-internal-slot

  • builtins/ArrayConstructor.js:
  • builtins/GlobalOperations.js:

(globalPrivate.isDictionary): Deleted.

  • builtins/RegExpPrototype.js:

(Symbol.split): Unobservable as there is === null check in @regExpExec.

  • builtins/StringPrototype.js:

(match):
(replace):
(replaceAll):
(search):
(split):

  • builtins/TypedArrayConstructor.js:
11:03 AM Changeset in webkit [262016] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

ASSERTION FAILED: m_wrapper on fast/events/scoped/editing-commands.html
https://bugs.webkit.org/show_bug.cgi?id=209862
<rdar://problem/61164607>

Reviewed by Darin Adler.

Make sure ScopedEventQueue keeps its event targets alive using a GCReachableRef<Node>
so that it keeps alive both the target and its JS wrapper.

No new tests, covered by existing test.

  • dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::enqueueEvent):
(WebCore::ScopedEventQueue::dispatchEvent const):
(WebCore::ScopedEventQueue::dispatchAllEvents):

  • dom/ScopedEventQueue.h:
11:02 AM Changeset in webkit [262015] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebCore

SQLite database fails to close in SQLiteIDBBackingStore::databaseNameFromFile
https://bugs.webkit.org/show_bug.cgi?id=212090

Reviewed by Darin Adler.

We should finish SQLite statement before closing database.

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromFile):

10:44 AM Changeset in webkit [262014] by sbarati@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Add an option that exposes functions on the global object to turn on and off the sampling profiler and the super sampler
https://bugs.webkit.org/show_bug.cgi?id=212178

Reviewed by Yusuke Suzuki.

When profiling things like Speedometer inside the browser, it's important to
to only enable the super sampler and the sampling profiler around the code
that you want profiled. Otherwise, you will be profiling things that aren't
relevant to the benchmark score. This patch adds a new option, exposeProfilersOnGlobalObject,
which when true, will expose JS functions on the global object that allow
enabling/disabling the super sampler and the sampling profiler. This way,
we can change the Speedometer source code locally such that these profilers
are only sampling code accounted for in the benchmark score.

  • bytecode/SuperSampler.cpp:

(JSC::initializeSuperSampler):
(JSC::enableSuperSampler):
(JSC::disableSuperSampler):

  • bytecode/SuperSampler.h:
  • jsc.cpp:

(jscmain):

  • runtime/JSGlobalObject.cpp:

(JSC::enableSamplingProfiler):
(JSC::disableSamplingProfiler):
(JSC::enableSuperSampler):
(JSC::disableSuperSampler):
(JSC::JSGlobalObject::init):

  • runtime/OptionsList.h:
10:22 AM Changeset in webkit [262013] by Russell Epstein
  • 1 copy in tags/Safari-610.1.14

Tag Safari-610.1.14.

10:21 AM Changeset in webkit [262012] by ysuzuki@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] Fix 32bit JSBigInt with INT32_MAX < x <= UINT32_MAX
https://bugs.webkit.org/show_bug.cgi?id=212193

Reviewed by Mark Lam.

In 32bit architecture, we are creating one-length JSBigInt for INT32_MIN <= x <= INT32_MAX, and two-length JSBigInt otherwise.
This is wrong since one-length JSBigInt should cover from -UINT32_MAX <= x <= UINT32_MAX.

This patch fixes the bug and cleans up createFrom(VM&, int64_t). And it also adds JSBigInt::createFrom(VM&, uint64_t) in preparation for [1]
Currently, this path is not used while it was used previously because BigIntConstructor starts using JSBigInt::createFrom(VM&, double). But this
will be used in [1], and simply the existing implementation is wrong.

[1]: https://bugs.webkit.org/show_bug.cgi?id=190800

  • runtime/JSBigInt.cpp:

(JSC::JSBigInt::createFromImpl):
(JSC::JSBigInt::createFrom):

  • runtime/JSBigInt.h:
10:03 AM Changeset in webkit [262011] by Jacob Uphoff
  • 2 edits in trunk/LayoutTests

LayoutTest compositing/video/video-poster.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168953

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:00 AM Changeset in webkit [262010] by Truitt Savell
  • 3 edits in trunk/LayoutTests

REGRESSION (r261277): [ Mac iOS ] webrtc/datachannel/gather-candidates-networkprocess-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=212218

Unreviewed test gardening.

  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
9:50 AM Changeset in webkit [262009] by Diego Pino Garcia
  • 3 edits in trunk/LayoutTests

[GTK] webaudio/codec-tests/aac/vbr-128kbps-44khz.html is failing
https://bugs.webkit.org/show_bug.cgi?id=211770

Unreviewed gardening.

Test just needs to update audio baseline for target platform.

  • platform/glib/TestExpectations:
  • platform/gtk/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav:
9:42 AM Changeset in webkit [262008] by Jacob Uphoff
  • 3 edits in trunk/LayoutTests

[ iOS & macOS ] media/track/track-cue-missing.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=212219

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac/TestExpectations:
9:22 AM Changeset in webkit [262007] by Jacob Uphoff
  • 2 edits in trunk/LayoutTests

[ macOS ] REGRESSION: media/video-isplayingtoautomotiveheadunit.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=212215

Unreviewed test gardening.

  • platform/mac/TestExpectations:
9:16 AM Changeset in webkit [262006] by Kate Cheney
  • 4 edits in trunk/LayoutTests

Some http/tests/in-app-browser-privacy/ tests are timing out or failing
https://bugs.webkit.org/show_bug.cgi?id=212176
<rdar://problem/63452877>

Reviewed by Maciej Stachowiak.

These tests rely on a new network session load for each test resource.
When run in iterations, caching occurs, and the resource does not get
a new network session. This patch adds a random decoration value and
reloads each resource to ensure it is not cached.

  • http/tests/in-app-browser-privacy/app-bound-domain-gets-app-bound-session.html:
  • http/tests/in-app-browser-privacy/non-app-bound-domain-does-not-get-app-bound-session.html:
  • http/tests/in-app-browser-privacy/non-app-bound-iframe-under-app-bound-domain-is-app-bound.html:
9:12 AM Changeset in webkit [262005] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Address post review comments from Mitz after r262004.

  • Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::sandboxDataVaultParentDirectory):

9:08 AM Changeset in webkit [262004] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

[WK2] WebKit abandons compiled sandbox profiles
https://bugs.webkit.org/show_bug.cgi?id=212177
<rdar://problem/54613619>

Reviewed by Saam Barati.

WebKit generates new compiled sandbox profiles whenever sandbox profiles are updated or
whenever webkit directories change (which is super common for WebKitTestRunner). Previous
compiled sandbox profiles do not get deleted and therefore may accumulate.

To address the issue, we now save compiled sandbox profiles under _CS_DARWIN_USER_TEMP_DIR
instead of _CS_DARWIN_USER_CACHE_DIR. The system takes care of deleting the files under
_CS_DARWIN_USER_TEMP_DIR upon reboot or if they have not been accessed for 3 days.

  • Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::sandboxDataVaultParentDirectory):

9:04 AM Changeset in webkit [262003] by Doug Kelly
  • 10 edits in trunk/Source/WebCore

Dispatch pending events only for current page
https://bugs.webkit.org/show_bug.cgi?id=211975
<rdar://problem/58942759>

Reviewed by Chris Dumez.

Document::implicitClose() should not dispatch events globally. The EventSender class operates as a singleton pattern
for each event queue, so to add some means to restrict which documents are handling events, we can send the current
page pointer and only dispatch the event if the event is for the same page. Other events are simply re-enqueued
to be triggered at a later time.

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

  • dom/EventSender.h:

(WebCore::EventSender::timerFired):
(WebCore::EventSender<T>::dispatchPendingEvents):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::dispatchPendingLoadEvents):

  • html/HTMLLinkElement.h:
  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::dispatchPendingLoadEvents):

  • html/HTMLStyleElement.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvents):
(WebCore::ImageLoader::dispatchPendingLoadEvents):
(WebCore::ImageLoader::dispatchPendingErrorEvents):

  • loader/ImageLoader.h:

(WebCore::ImageLoader::document):

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::append):

8:43 AM Changeset in webkit [262002] by Russell Epstein
  • 2 edits in branches/safari-610.1.14-branch/Source/WebKit

Cherry-pick r261977. rdar://problem/63415448

[iOS] Fix message filter sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=212100
<rdar://problem/63407155>

Reviewed by Brent Fulgham.

A message needs to be added to the message filter in the WebContent sandbox on iOS.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:43 AM Changeset in webkit [262001] by Russell Epstein
  • 2 edits in branches/safari-610.1.14-branch/Source/WebKit

Cherry-pick r261884. rdar://problem/63415448

[iOS] Fix message filter sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=212100
<rdar://problem/63407155>

Reviewed by Andy Estes.

A message needs to be added to the message filter in the WebContent sandbox on iOS.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:42 AM Changeset in webkit [262000] by Wenson Hsieh
  • 5 edits in trunk/Source

Unreviewed, fix the iOS 13.4 build after r261978

Source/WebKit:

  • Platform/spi/ios/UIKitSPI.h:

Only declare _UIHoverEventRespondable if HAVE(UI_HOVER_EVENT_RESPONDABLE) is defined.

  • UIProcess/ios/WKMouseGestureRecognizer.mm:

If _UIHoverEventRespondable is not present, fall back to declaring internal methods on
UIHoverGestureRecognizer.

Source/WTF:

Add a HAVE() macro to guard usages of _UIHoverEventRespondable.

  • wtf/PlatformHave.h:
8:35 AM Changeset in webkit [261999] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

[macOS] Scrolling synchronization part 2: Have the scrolling thread detect when the main thread is slow to respond to start a rendering update
https://bugs.webkit.org/show_bug.cgi?id=212175

Reviewed by Tim Horton.

The scrolling thread now detects when a main thread rendering update is taking too long, going into
desynchronized mode when that happens.

However, there's another state that needs to be handled, which is the main thread being busy and
taking too long to start the rendering update. The scrolling thread gets a "displayDidRefresh" ping
and expects that the main thread will get the same ping, and use it to start the rendering update,
but a busy main thread won't respond to this ping promptly.

Detect this with a short-duration (1ms) timer that fires on the scrolling thread; if the timer fires
we go into desynchronized mode until the next update. The timer is canceled if the scrolling thread
receives the willStartRenderingUpdate().

  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::waitForRenderingUpdateCompletionOrTimeout):
(WebCore::ThreadedScrollingTree::scheduleDelayedRenderingUpdateDetectionTimer):
(WebCore::ThreadedScrollingTree::delayedRenderingUpdateDetectionTimerFired):
(WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread):

  • page/scrolling/ThreadedScrollingTree.h:
8:27 AM Changeset in webkit [261998] by yoshiaki.jitsukawa@sony.com
  • 2 edits in trunk/Source/WebKit

[ConnectionUnix] Set MSG_NOSIGNAL to avoid SIGPIPE
https://bugs.webkit.org/show_bug.cgi?id=211719

Reviewed by Don Olmstead.

Set MSG_NOSIGNAL to sendmsg()/resvmsg() in order to avoid
SIGPIPE when the other process disappears.

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::readBytesFromSocket):
(IPC::Connection::sendOutputMessage):

8:26 AM Changeset in webkit [261997] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r253926): webgl/2.0.0/conformance2/buffers/get-buffer-sub-data.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205667

Patch by Kenneth Russell <kbr@chromium.org> on 2020-05-21
Reviewed by Alexey Proskuryakov.

Remove get-buffer-sub-data.html suppression since it's now passing
reliably.

7:45 AM Changeset in webkit [261996] by svillar@igalia.com
  • 4 edits in trunk

Source/WebCore:
[css-grid] [css-flex] Width of table as grid/flex item is infinite when the sum of columns' width exceed 100%
https://bugs.webkit.org/show_bug.cgi?id=191365

Reviewed by Manuel Rego Casasnovas.

Automatic table layout algorithm generates infinite width tables
(tableMaxWidth to be more exact) when the sum of the columns percentages
exceed the 100% value and there is at least one non-percentage based
column with positive width as in those cases it's impossible to fulfill
the table constrains. That should not be done in the case of the table
being a flex or a grid item because they both define new formatting
contexts.

Based on Blink's crrev.com/1095220 by <mstensho@chromium.org>

  • rendering/AutoTableLayout.cpp:

(WebCore::shouldScaleColumnsForParent): return false when the table is
either a grid or a flex item.

LayoutTests:
[css-grid] width of table in a grid is incorrect when table cell has width:100%
https://bugs.webkit.org/show_bug.cgi?id=191365

Reviewed by Manuel Rego Casasnovas.

7:41 AM Changeset in webkit [261995] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[WPE] Gardening, update WAV baseline for webaudio test
https://bugs.webkit.org/show_bug.cgi?id=212212

Unreviewed gardening.

Baseline was updated on r261878 and since then the test started
failing. The test wasn't failing before though. In conclusion, it
seems the update from r261878 wasn't needed for this test.

  • platform/wpe/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav:
7:28 AM Changeset in webkit [261994] by Alan Bujtas
  • 5 edits in trunk

[ macOS debug ] REGRESSION: fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=212139
<rdar://problem/63447683>

Reviewed by Antti Koivisto.

Source/WebCore:

Uninitialized row baseline value caused unexpected cell height in nested tables.

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):

  • layout/tableformatting/TableGrid.h:

LayoutTests:

  • platform/mac/TestExpectations:
6:58 AM Changeset in webkit [261993] by Paulo Matos
  • 5 edits in trunk/Source/JavaScriptCore

Further non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=212195

Reviewed by Adrian Perez de Castro.

  • bytecode/InstanceOfStatus.cpp:
  • heap/MarkedSpace.cpp:
  • runtime/ObjectInitializationScope.cpp:
  • runtime/ThrowScope.cpp:
6:19 AM Changeset in webkit [261992] by zandobersek@gmail.com
  • 3 edits
    231 adds in trunk/LayoutTests

Unreviewed WPE gardening. Enabling a few subdirectories under fast/,
providing the necessary baselines as well as test expectations.

  • platform/wpe/TestExpectations:
  • platform/wpe/fast/attachment: 8 baselines added.
  • platform/wpe/fast/fast-mobile-scrolling: 2 baselines added.
  • platform/wpe/fast/scrolling: 2 baselines added.
  • platform/wpe/fast/spatial-navigation: 1 baseline added.
  • platform/wpe/fast/text: 211 baselines added.
5:33 AM Changeset in webkit [261991] by Alan Bujtas
  • 5 edits
    2 adds in trunk

[LFC][TFC] Collapse in-between cell borders
https://bugs.webkit.org/show_bug.cgi?id=212183

Reviewed by Antti Koivisto.

Source/WebCore:

This patch expands border collapsing to in-between cell borders.

Test: fast/layoutformattingcontext/table-simple-border-collapse3.html

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutCell):

  • layout/tableformatting/TableFormattingContext.h:
  • layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::computedCellBorder const):
(WebCore::Layout::TableFormattingContext::Geometry::intrinsicWidthConstraintsForCell):

LayoutTests:

  • fast/layoutformattingcontext/table-simple-border-collapse3-expected.html: Added.
  • fast/layoutformattingcontext/table-simple-border-collapse3.html: Added.
3:50 AM Changeset in webkit [261990] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty/ANGLE

EXT_color_buffer_half_float not exposed on iOS
https://bugs.webkit.org/show_bug.cgi?id=212181

Patch by Kenneth Russell <kbr@chromium.org> on 2020-05-21
Reviewed by Dean Jackson.

Remove OES_texture_half_float requirement for advertising
EXT_color_buffer_half_float in ANGLE. This is implicit in ES 3.0.

  • src/libANGLE/renderer/gl/formatutilsgl.cpp:

(rx::nativegl::BuildInternalFormatInfoMap):

3:38 AM Changeset in webkit [261989] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[WPE] Gardening, remove tests passing after 261987
https://bugs.webkit.org/show_bug.cgi?id=212196

Unreviewed gardening.

  • platform/wpe/TestExpectations:
3:08 AM Changeset in webkit [261988] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GTK] Gardening, remove tests passing after r261986
https://bugs.webkit.org/show_bug.cgi?id=212194

Unreviewed gardening.

  • platform/gtk/TestExpectations:
1:41 AM Changeset in webkit [261987] by Alexey Shvayka
  • 7 edits in trunk

Array.prototype.concat is incorrect with objects whose "length" exceeds 2 32 - 1
https://bugs.webkit.org/show_bug.cgi?id=212167

Reviewed by Saam Barati.

JSTests:

  • stress/array-prototype-concat-of-long-spliced-arrays.js:
  • stress/array-prototype-concat-of-long-spliced-arrays2.js:
  • test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch increases "length" limit of Array.prototype.concat result to @MAX_SAFE_INTEGER
and changes thrown error to TypeError, aligning JSC with the spec [1], V8, and SpiderMonkey.

Also, adds missing @MAX_SAFE_INTEGER overflow check in Array.from [2] (we implement similar
checks in other methods). SunSpider and microbenchmarks/concat-append-one.js are both neutral.

[1]: https://tc39.es/ecma262/#sec-array.prototype.concat (steps 5.c.iii, 5.d.ii)
[2]: https://tc39.es/ecma262/#sec-array.from (step 5.e.i)

  • builtins/ArrayConstructor.js:

(from):

  • builtins/ArrayPrototype.js:

(globalPrivate.concatSlowPath):

12:47 AM Changeset in webkit [261986] by eocanha@igalia.com
  • 17 edits in trunk

[GStreamer][GTK][WPE] Expose and honor the media content types requiring hardware support setting
https://bugs.webkit.org/show_bug.cgi?id=211950

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Provide the needed information about media content types requiring hardware support
when asking the MediaPlayer about what types are supported. This was already being done
from HTMLMediaElement for player selection, but not in MediaSource nor in
MediaSource::addSourceBuffer() when the webpage used the MSE API to check type support.
In order to ask for the mediaContentTypesRequiringHardwareSupport setting we need a
reference to the current Document in all the places where we need to check type support.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::addSourceBuffer): Provide hardware content types extra info.
(WebCore::MediaSource::isTypeSupported): Get hardware content types extra info from
ScriptExecutionContext and provide it to a new refactored private version of
isTypeSupported() which can also be reused from addSourceBuffer().

  • Modules/mediasource/MediaSource.h: Changed isTypeSupported() prototype to take

ScriptExecutionContext and added a new overloaded version of the method.

  • Modules/mediasource/MediaSource.idl: isTypeSupported() now provides a reference to

ScriptExecutionContext. It's the only way to access the required document settings from a
static method.

  • platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::isContentTypeSupported const): Factor ContentType
discrimination logic common to MediaPlayerPrivateGStreamer and
MediaPlayerPrivateGStreamerMSE.

  • platform/graphics/gstreamer/GStreamerRegistryScanner.h: Added new method.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::supportsType): Provide hardware content types extra
info when asking for type support.

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType): Ditto.

Source/WebKit:

Expose mediaContentTypesRequiringHardwareSupport as a setting on WPE and WebKitGTK.

  • UIProcess/API/glib/WebKitSettings.cpp:

(_WebKitSettingsPrivate::_WebKitSettingsPrivate):
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_media_content_types_requiring_hardware_support):
(webkit_settings_set_media_content_types_requiring_hardware_support):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/wpe/WebKitSettings.h:
  • UIProcess/API/wpe/docs/wpe-1.0-sections.txt:

Tools:

Exercise the new mediaContentTypesRequiringHardwareSupport setting.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

Note: See TracTimeline for information about the timeline view.