Context Navigation

← Previous Period
Next Period →

Timeline

Aug 3, 2020:

10:57 PM Changeset in webkit [265242] by Simon Fraser

4 edits in trunk/Source/WebCore

m_isEditableRegionEnabled should be reset in didCommitLoad, not didFinishLoad
https://bugs.webkit.org/show_bug.cgi?id=215115

Reviewed by Wenson Hsieh.

Resetting m_isEditableRegionEnabled in didFinishLoad() is too late because
inline script at the end of the <body> (e.g. in a layout test) will have already
run before the reset.

Fix by adding Page::didCommitLoad() and resetting m_isEditableRegionEnabled there.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchDidCommitLoad):

page/Page.cpp:

(WebCore::Page::didCommitLoad):
(WebCore::Page::didFinishLoad):

page/Page.h:

10:16 PM WPTUpdateBotDesign created by clopez@igalia.com

9:49 PM Changeset in webkit [265241] by mmaxfield@apple.com

4 edits in trunk/Source/WebCore

Unconditionally record string offsets in the fast text codepath
https://bugs.webkit.org/show_bug.cgi?id=215051

Reviewed by Darin Adler.

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769
and https://bugs.webkit.org/show_bug.cgi?id=206208.

The solution for https://bugs.webkit.org/show_bug.cgi?id=214769 requires applying
letter-spacing after text shaping. Today, we apply letter-spacing before text
shaping, which is wrong. However, if we want to apply letter-spacing after text
shaping, we will need a way of mapping back which shaped glyphs correspond to
which characters in the string, so we can apply letter-spacing to the correct
glyphs. Therefore, we need to record string offsets any time letter-spacing can
be applied (which is all the time - letter spacing can be applied on any element).

This also helps on the path toward https://bugs.webkit.org/show_bug.cgi?id=214769.
When we move off the complex text codepath, we will need these string offsets
to calculate things like what the text range of a selection is when the user has
selected some glyphs on the page.

There is no performance change because these string offsets were already being
calculated; the difference is just that we're storing them now. Also, we were
being wildly inefficient with the members of GlyphBuffer, giving them inline
sizes of 2048. I measured the median and mean of these strings in our Page Load
Test to be 6 and 7.4. So, I cut down the inline sizes down to 1024, so now we're
using less memory than we were before.

No new tests because there is no behavior change. The additional string offsets
are unused (for now). A subsequent patch will start using them.

platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::layoutText const):
(WebCore::FontCascade::drawEmphasisMarks const):
(WebCore::computeUnderlineType):
(WebCore::FontCascade::layoutSimpleText const):
(WebCore::FontCascade::layoutComplexText const):
(WebCore::FontCascade::dashesForIntersectionsWithRect const):

platform/graphics/FontCascade.h:
platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::clear):
(WebCore::GlyphBuffer::fonts):
(WebCore::GlyphBuffer::offsetsInString):
(WebCore::GlyphBuffer::fonts const):
(WebCore::GlyphBuffer::offsetsInString const):
(WebCore::GlyphBuffer::glyphAt const):
(WebCore::GlyphBuffer::advanceAt const):
(WebCore::GlyphBuffer::stringOffsetAt const):
(WebCore::GlyphBuffer::add):
(WebCore::GlyphBuffer::remove):
(WebCore::GlyphBuffer::makeHole):
(WebCore::GlyphBuffer::expandLastAdvance):
(WebCore::GlyphBuffer::shrink):
(WebCore::GlyphBuffer::swap):
(WebCore::GlyphBuffer::saveOffsetsInString): Deleted.
(WebCore::GlyphBuffer::offsetInString const): Deleted.

9:32 PM Changeset in webkit [265240] by mmaxfield@apple.com

5 edits in trunk/Source/WebCore

Rename WidthIterator::m_currentCharacter to WidthIterator::m_currentCharacterIndex
https://bugs.webkit.org/show_bug.cgi?id=215056

Reviewed by Darin Adler.

It represents an index, not a character.

No new tests because there is no behavior change.

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769
and https://bugs.webkit.org/show_bug.cgi?id=206208.

platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::offsetForPositionForSimpleText const):

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):

platform/graphics/WidthIterator.h:

(WebCore::WidthIterator::currentCharacterIndex const):
(WebCore::WidthIterator::currentCharacter const): Deleted.

9:02 PM Changeset in webkit [265239] by Lauro Moura

10 edits
1 delete in trunk/LayoutTests

[GTK][WPE] Gardening some failures and rebaseline.

Unreviewed test gardening.

LayoutTests/imported/w3c:

Rebaseline expectations after r264478 updated the interface
descriptions.

web-platform-tests/webxr/ar-module/idlharness.https.window-expected.txt:
web-platform-tests/webxr/idlharness.https.window-expected.txt:

LayoutTests:

platform/glib/TestExpectations:
platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY-expected.txt:
platform/gtk/TestExpectations:
platform/wpe/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
platform/wpe/mathml/opentype/opentype-stretchy-expected.txt: Removed.

7:33 PM Changeset in webkit [265238] by Wenson Hsieh

5 edits in trunk

Allow -accessoryDone to blur the focused element on iPad when AutoFilling strong passwords
https://bugs.webkit.org/show_bug.cgi?id=215105
<rdar://problem/65143984>

Reviewed by Tim Horton.

Source/WebKit:

-accessoryDone is now used to dismiss the strong password AutoFill keyboard after choosing a password on iOS,
due to how it hides the keyboard without causing the content view to resign first responder; being stuck in a
state where the content view is not first responder causes several issues when choosing strong passwords on iOS,
such as keyboard shortcuts no longer working.

On iPad, to ensure that -accessoryDone actually dismisses the keyboard, we need to additionally teach
-endEditingAndUpdateFocusAppearanceWithReason: (when given EndEditingReasonAccessoryDone) to allow the
focused element to blur when dismissing the strong password input view.

Test: KeyboardInputTests.TestWebViewAccessoryDoneDuringStrongPasswordAssistance

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView endEditingAndUpdateFocusAppearanceWithReason:]):

Refactor this logic into a local helper lambda with early returns, instead of using a single if statement.

Tools:

Add an API test that exercises the behavior change when run on iPad simulator.

TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
TestWebKitAPI/ios/UIKitSPI.h:

6:51 PM Changeset in webkit [265237] by Nikita Vasilyev

11 edits in trunk/Source/WebInspectorUI

Web Inspector: Change DataGrid and Table styles to closer match macOS
https://bugs.webkit.org/show_bug.cgi?id=214563
<rdar://problem/65841032>

Reviewed by Devin Rousso.

Remove vertical borders from table contents and only keep them on the table headers.
Use 1px borders instead of hairline (0.5px) borders to closer match macOS.
Refactoring: add "sorted" CSS class on sorted header columns to replace th:matches(.sort-ascending, .sort-descending) that is used 10 times with .sorted.

UserInterface/Views/CPUTimelineView.css:

(.timeline-view.cpu :matches(.area-chart, .stacked-area-chart) .markers > div):

UserInterface/Views/DataGrid.css:

(.data-grid):
--data-grid-column-border-start is no longer used, remove it.

(.data-grid.inline):
(.data-grid th):
(.data-grid th > .header-cell-content):
(body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content):
(body[dir=rtl] .data-grid th:not(:last-child) > .header-cell-content):
(.data-grid th.sortable:active):
(.data-grid th:matches(.sort-ascending, .sort-descending)):
(.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child):
(.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
(body[dir=ltr] .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
(body[dir=rtl] .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
Remove styles that are no longer relevant because columns don't have vertical borders anymore.

(.data-grid th.sort-ascending > .header-cell-content:first-child::after):
(.data-grid th.sort-descending > .header-cell-content:first-child::after):
(@media (prefers-color-scheme: dark) .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
Don't change the background color of the sorted header cells to match macOS.

(body[dir=ltr] .data-grid :matches(th, td):not(:last-child)): Deleted.
(body[dir=rtl] .data-grid :matches(th, td):not(:last-child)): Deleted.
(.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child): Deleted.
(.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after): Deleted.
(body[dir=ltr] .data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after): Deleted.
(body[dir=rtl] .data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after): Deleted.
(.data-grid th.sort-ascending > div:first-child::after): Deleted.
(.data-grid th.sort-descending > div:first-child::after): Deleted.
(.data-grid table:matches(.header, .data)): Deleted.
(body[dir=ltr] .data-grid :matches(th, td):first-child): Deleted.
(body[dir=rtl] .data-grid :matches(th, td):first-child): Deleted.
(@media (-webkit-min-device-pixel-ratio: 2) .data-grid table:matches(.header, .data)): Deleted.
(@media (-webkit-min-device-pixel-ratio: 2) .data-grid :matches(th, td):first-child): Deleted.
(@media (prefers-color-scheme: dark) .data-grid th.sortable:active): Deleted.
(@media (prefers-color-scheme: dark) .data-grid th.sort-ascending > div:first-child::after,): Deleted.

UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype.insertColumn):

UserInterface/Views/NetworkDetailView.css:

(body[dir=ltr] .network-table.showing-detail .network-detail):
(body[dir=rtl] .network-table.showing-detail .network-detail):
Now that columns don't have borders, add a vertical border to the Network details pane.

UserInterface/Views/NetworkTableContentView.css:

(.network-table > .table .header .cell.waterfall:matches(.sort-ascending, .sort-descending)):
(body[dir=ltr] .network-table > .table :not(.header) .cell.waterfall):
(body[dir=rtl] .network-table > .table :not(.header) .cell.waterfall):
Add a vertical border for the zeroth mark of the graph.

UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:

(.timeline-overview-graph.rendering-frame > .divider):

UserInterface/Views/Table.css:

(.table):
(.table > .header > .sortable:active):
(.table > .header > :matches(.sort-ascending, .sort-descending)):
(.table > .header .cell):
(.table > .header .cell:not(:first-child)::before):
(body[dir=ltr] .table > .header .cell:not(:first-child)::before):
(body[dir=rtl] .table > .header .cell:not(:first-child)::before):
(body[dir=ltr] .table .cell:not(:last-child)): Deleted.
(body[dir=rtl] .table .cell:not(:last-child)): Deleted.
(body[dir=ltr] .table .cell:first-child): Deleted.
(body[dir=rtl] .table .cell:first-child): Deleted.
(@media (prefers-color-scheme: dark) .table > .header > .sortable:active): Deleted.
(@media (prefers-color-scheme: dark) .table > .header > :matches(.sort-ascending, .sort-descending)): Deleted.

UserInterface/Views/TimelineDataGrid.css:

(.data-grid th.graph-column:matches(.sort-ascending, .sort-descending)):
(.data-grid.timeline th.graph-column > .timeline-ruler):
(body[dir=ltr] .data-grid.timeline td.graph-column):
(body[dir=rtl] .data-grid.timeline td.graph-column):
Add a vertical border for the zeroth mark of the graph.

(.data-grid.timeline td.graph-column .timeline-record-bar):
(@media (prefers-color-scheme: dark) .data-grid th:matches(.sort-ascending, .sort-descending)): Deleted.

UserInterface/Views/TimelineRuler.css:

(.timeline-ruler > .header > .divider > .label):
Reset font-weight from sorted column header.

(.timeline-ruler > .markers > .divider):

UserInterface/Views/Variables.css:

(:root):
(@media (prefers-color-scheme: dark) :root):
Use more precise color for --even-zebra-stripe-row-background-color.
Drive-by: remove unused --border-color-dark variable.

6:16 PM Changeset in webkit [265236] by Andres Gonzalez

2 edits in trunk/Source/WebCore/PAL

Check for the presence of libAccessibility before trying to load the _AXSIsolatedTreeMode function.
https://bugs.webkit.org/show_bug.cgi?id=215107
<rdar://problem/66192260>

Reviewed by Chris Fleizach.

pal/spi/cocoa/AccessibilitySupportSoftLink.h:

Trying to load _AXSIsolatedTreeMode when the library is not present
triggers an assert.

6:05 PM Changeset in webkit [265235] by youenn@apple.com

10 edits in trunk/Source

Move user gesture propagation over promise behind a feature flag
https://bugs.webkit.org/show_bug.cgi?id=215014

Reviewed by Eric Carlson.

Source/WebCore:

If runtime flag is false, disable user gesture propagation to the next micro task.

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::queueMicrotaskToEventLoop):

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::userGesturePromisePropagationEnabled const):
(WebCore::RuntimeEnabledFeatures::setUserGesturePromisePropagationEnabled):

Source/WebKit:

Add a preference, on by default.

Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(-[WebPreferences userGesturePromisePropagationEnabled]):
(-[WebPreferences setUserGesturePromisePropagationEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

5:36 PM Changeset in webkit [265234] by Hector Lopez

3 edits in trunk/LayoutTests

[ macOS iOS Release ] imported/w3c/web-platform-tests/css/css-animations/webkit-writing-mode-crash.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215110

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac/TestExpectations:

5:31 PM Changeset in webkit [265233] by Chris Dumez

17 edits
2 copies in trunk

Add constructor for AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=215096

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/webaudio/idlharness.https.window-expected.txt:
web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt:

Source/WebCore:

Add constructor for AudioBufferSourceNode as per:

https://www.w3.org/TR/webaudio/#DelayNode

This patch also adds support for the detune attribute on AudioBufferSourceNode,
which gets initialized by the constructor.

No new tests, rebaselined existing tests.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::create):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::reset):
(WebCore::AudioBufferSourceNode::totalPitchRate):

Modules/webaudio/AudioBufferSourceNode.h:
Modules/webaudio/AudioBufferSourceNode.idl:
Modules/webaudio/AudioBufferSourceOptions.h: Copied from Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl.
Modules/webaudio/AudioBufferSourceOptions.idl: Copied from Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl.
Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createBufferSource):

Sources.txt:
WebCore.xcodeproj/project.pbxproj:

5:24 PM Changeset in webkit [265232] by Simon Fraser

6 edits in trunk/Source/WebCore

Add an EventRegions log channel
https://bugs.webkit.org/show_bug.cgi?id=215092

Reviewed by Daniel Bates.

Add a log channel for EventRegions, add logging in some interesting places.

platform/Logging.h:
rendering/EventRegion.cpp:

(WebCore::EventRegion::unite):
(WebCore::EventRegion::uniteTouchActions):
(WebCore::EventRegion::uniteEventListeners):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateEventRegion):

5:15 PM Changeset in webkit [265231] by mmaxfield@apple.com

7 edits in trunk/Source/WebCore

Make FontCascade.drawText() return a FloatSize instead of a float
https://bugs.webkit.org/show_bug.cgi?id=215055

Reviewed by Darin Adler.

Advances are philosophically two-dimensional data structures.

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769
and https://bugs.webkit.org/show_bug.cgi?id=206208.

No new tests because there shouldn't be any behavior change. But in the weird
rare case where there might be, we should be defensive and handle it correctly.
I've never seen one of these cases, though.

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::drawElementTitle):

page/DebugPageOverlays.cpp:

(WebCore::drawRightAlignedText):

platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::drawText const):

platform/graphics/FontCascade.h:
platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawBidiText):

platform/graphics/GraphicsContext.h:

4:43 PM Changeset in webkit [265230] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Null check parentProcessConnection when creating a NetworkDataTaskCocoa
https://bugs.webkit.org/show_bug.cgi?id=215109
<rdar://problem/64853922>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-03
Reviewed by Chris Dumez.

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
Null check parentProcessConnection. Otherwise, we can dereference null and crash between disconnecting with the parent process and terminating,
which isn't the worst time to crash because we are trying to terminate anyways. But we may as well not crash.

3:53 PM Changeset in webkit [265229] by timothy_horton@apple.com

4 edits
1 add in trunk

Occasional crashes when running nested runloops while using UIWebView
https://bugs.webkit.org/show_bug.cgi?id=213067
<rdar://problem/64239727>

Reviewed by Darin Adler.

Source/WebCore:

New test: WebKitLegacy.NestedRunLoopUnderRunLoopObserverDoubleUnlock

platform/ios/wak/WebCoreThread.mm:

(MainRunLoopAutoUnlock):
(_WebThreadAutoLock):
Under certain circumstances, a CFRunLoopObserver that is already removed
can fire again (e.g. when removed in a nested runloop, it can be fired again
in the main runloop).

The WebThread code assumes that the auto-unlock observer is called exactly
once after being installed. If this is not the case, the main thread lock
count can underflow, wreaking havoc the next time we try to lock.
Instead of depending on CFRunLoop to do this for us, make it explicit
with a global boolean.

This leaves in place the somewhat-odd behavior that running a nested
runloop can cause the main runloop's WebThread lock to be dropped, because
a great deal of code (and tests) depend on this behavior (keeping the lock
held until the outer runloop spins would result in deadlock if the inner
runloop's loop condition depends on the WebThread being able to execute code).
However, this is not unique to this underflow case, and appears to be
extremely long-standing behavior, so maintaining it seems the best course of action.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitLegacy/ios/WebThreadLock.mm: Added.

Add a API test that fails before this change.

3:48 PM Changeset in webkit [265228] by Wenson Hsieh

36 edits in trunk

Remove the ENABLE_DATA_INTERACTION feature flag
https://bugs.webkit.org/show_bug.cgi?id=215091

Reviewed by Megan Gardner.

Source/cmake/OptionsFTW.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

ENABLE(DATA_INTERACTION) is an alias for PLATFORM(IOS_FAMILY) && ENABLE(DRAG_SUPPORT). It was used early on
when bringing drag and drop support to iPad in order to hide the feature from open source WebKit code, and has
not been necessary for several years.

page/DragController.cpp:

(WebCore::DragController::shouldUseCachedImageForDragImage const):

page/DragController.h:

(WebCore::DragController::canLoadDataFromDraggingPasteboard const):

page/EventHandler.cpp:

(WebCore::EventHandler::dragCancelled):
(WebCore::EventHandler::didStartDrag):

page/FocusController.cpp:

(WebCore::shouldClearSelectionWhenChangingFocusedElement):

page/mac/DragControllerMac.mm:
platform/DragImage.cpp:
platform/ios/WebItemProviderPasteboard.mm:

Source/WebCore/PAL:

pal/spi/ios/UIKitSPI.h:

Source/WebKit:

UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/DragDropInteractionState.h:
UIProcess/ios/DragDropInteractionState.mm:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:
UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView actionSheetAssistant:showCustomSheetForElement:]):

UIProcess/ios/WebPageProxyIOS.mm:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

Source/WebKitLegacy/mac:

WebCoreSupport/WebDragClient.mm:
WebView/WebView.mm:
WebView/WebViewData.h:
WebView/WebViewInternal.h:

Source/WTF:

wtf/PlatformEnable.h:
wtf/PlatformEnableCocoa.h:

Tools:

Scripts/webkitperl/FeatureList.pm:

3:41 PM Changeset in webkit [265227] by Chris Dumez

15 edits
2 copies in trunk

Add constructor for GainNode
https://bugs.webkit.org/show_bug.cgi?id=215093

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/webaudio/idlharness.https.window-expected.txt:
web-platform-tests/webaudio/the-audio-api/processing-model/cycle-without-delay-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:

Source/WebCore:

Add constructor for GainNode as per:

https://www.w3.org/TR/webaudio/#gainnode

No new tests, rebaselined existing tests.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createGain):

Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::create):
(WebCore::GainNode::GainNode):
(WebCore::GainNode::process):
(WebCore::GainNode::reset):

Modules/webaudio/GainNode.h:
Modules/webaudio/GainNode.idl:
Modules/webaudio/GainOptions.h: Copied from Source/WebCore/Modules/webaudio/GainNode.idl.
Modules/webaudio/GainOptions.idl: Copied from Source/WebCore/Modules/webaudio/GainNode.idl.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

3:34 PM Changeset in webkit [265226] by Truitt Savell

2 edits in trunk/LayoutTests

[ macOS iOS ] fast/images/async-image-body-background-image.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=175193

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-08-03

platform/ios-wk2/TestExpectations:

3:28 PM Changeset in webkit [265225] by Alan Coon

1 copy in tags/Safari-610.1.24

Tag Safari-610.1.24.

3:16 PM Changeset in webkit [265224] by BJ Burg

8 edits in trunk/Source/WebInspectorUI

Web Inspector: "Show transparency grid" string needs to be disambiguated for localization
https://bugs.webkit.org/show_bug.cgi?id=215101

Reviewed by Darin Adler.

Add two different string keys with the same English translation. This is specifically
needed for Portuguese, apparently.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView):

UserInterface/Views/GraphicsOverviewContentView.js:

(WI.GraphicsOverviewContentView):

UserInterface/Views/ImageResourceContentView.js:
UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):

UserInterface/Views/ResourceCollectionContentView.js:

(WI.ResourceCollectionContentView):

UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createSourcesSettingsView):

3:14 PM Changeset in webkit [265223] by Alan Coon

8 edits in trunk/Source

Versioning.

WebKit-610.1.26

2:49 PM Changeset in webkit [265222] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Fix the macCatalyst build

UIProcess/EndowmentStateTracker.mm:

(WebKit::EndowmentStateTracker::stateFromEndowments):

2:49 PM Changeset in webkit [265221] by Chris Dumez

17 edits
2 copies in trunk

Add constructor to DelayNode
https://bugs.webkit.org/show_bug.cgi?id=215083

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/webaudio/idlharness.https.window-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:

Source/WebCore:

Add constructor to DelayNode:

https://www.w3.org/TR/webaudio/#DelayNode

No new tests, rebaselined existing tests.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createDelay):

Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::process):

Modules/webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):
(WebCore::DelayNode::create):
(WebCore::DelayNode::delayTime):

Modules/webaudio/DelayNode.h:
Modules/webaudio/DelayNode.idl:
Modules/webaudio/DelayOptions.h: Copied from Source/WebCore/Modules/webaudio/DelayNode.idl.
Modules/webaudio/DelayOptions.idl: Copied from Source/WebCore/Modules/webaudio/DelayNode.idl.
Modules/webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

Modules/webaudio/DelayProcessor.h:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

2:35 PM Changeset in webkit [265220] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r243301): Network: initiator column missing
https://bugs.webkit.org/show_bug.cgi?id=215044

Reviewed by Brian Burg.

UserInterface/Views/NetworkTimelineView.js:

(WI.NetworkTimelineView):

2:05 PM Changeset in webkit [265219] by youenn@apple.com

1 edit
1 delete in trunk/Source/ThirdParty/libwebrtc

Remove libwebrtc protobuf copy
https://bugs.webkit.org/show_bug.cgi?id=215076
rdar://problem/66291604

Reviewed by Eric Carlson.

This is not used currently and contains code that is not up to date.

Source/third_party/protobuf: Removed.

2:04 PM Changeset in webkit [265218] by mmaxfield@apple.com

5 edits in trunk/Source/WebCore

Make WidthIterator::advance() return void
https://bugs.webkit.org/show_bug.cgi?id=215053

Reviewed by Darin Adler.

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769
and https://bugs.webkit.org/show_bug.cgi?id=206208.

This is a small simplification in the fast text codepath. It used to return
how many characters were consumed. However, this information is already
exposed by just calling currentCharacter() on the width iterator before and
after calling advance().

No new tests because there is no behavior change.

platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::drawText const):
(WebCore::FontCascade::displayListForTextRun const):
(WebCore::FontCascade::layoutSimpleText const):
(WebCore::FontCascade::adjustSelectionRectForSimpleText const):

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):

platform/graphics/WidthIterator.h:
rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::advanceSimpleText):

2:02 PM Changeset in webkit [265217] by berto@igalia.com

2 edits in trunk/Source/JavaScriptCore

[GTK] 2.29.4 fails to build in armhf
https://bugs.webkit.org/show_bug.cgi?id=214966

Reviewed by Michael Catanzaro.

SP register cannot be used as a destination register of SUB or ADD
on Thumb mode.

llint/LowLevelInterpreter32_64.asm:

2:01 PM Changeset in webkit [265216] by youenn@apple.com

3 edits in trunk/Source/WebCore

MediaRecorderPrivateWriter should ensure its writer input is ready for more data before appending new samples
https://bugs.webkit.org/show_bug.cgi?id=215081

Reviewed by Eric Carlson.

After r265192, we were checking whether the writer input was ready.
If so, we were pushing pending samples and then the new sample.
The issue is that pushing pending samples might make the writer input no longer ready.
Update the code to enqueue the sample if its writer input is not ready.
Add an ASSERT in appendCompressedVideoSampleBuffer to make sure this is the case.

Also make sure that we only enqueue the end of segment sample if video writer input is ready.

Make sure flushCompressedSampleBuffers is called directly by stopRecording only if not already flushing samples.
If we are not flushing, we proceed with the stop steps.
If not, we wait for the end of flushCompressedSampleBuffers to proceed with the stop steps.

platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::appendCompressedAudioSampleBufferIfPossible):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBufferIfPossible):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::flushCompressedSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::stopRecording):
(WebCore::MediaRecorderPrivateWriter::finishedFlushingSamples):
(WebCore::MediaRecorderPrivateWriter::doStopRecording):

1:59 PM Changeset in webkit [265215] by pvollan@apple.com

4 edits in trunk/Source

Finalize the list of MobileGestalt queries needed to populate the in-memory cache in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=215095
<rdar://problem/66034080>

Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

Declare constants for MobileGestalt questions.

pal/spi/ios/MobileGestaltSPI.h:

Source/WebKit:

When the MobileGestalt cache is invalid, we issue a temporary extension to the MobileGestalt daemon for the WebContent process,
which will populate the in-memory cache by doing a set of MobileGestalt queries before revoking the extension. This patch
finalizes the list of MobileGestalt queries needed to populate the in-memory cache in the WebContent process on iOS before
revoking the temporary extension to com.apple.mobilegestalt.xpc. This list was compiled by querying every possible MobileGestalt
key after the temporary extension was revoked, and make a note of all queries that were contacting the MobileGestalt daemon to
get the answer. The added queries in this patch should make the list complete, and ensures that all cachable values are in the
in-memory cache before revoking the extension, since every possible MobileGestalt query was tested. This again means that users
that have an invalid MobileGestalt cache, will have access to the exact same MobileGestalt values, as those users who have a
valid MobileGestalt cache.

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

1:45 PM Changeset in webkit [265214] by Ryan Haddad

2 edits in trunk/LayoutTests

Regression (r265160): http/tests/misc/gamepads-insecure.html fails consistently on windows
https://bugs.webkit.org/show_bug.cgi?id=215099

Unreviewed test gardening.

platform/win/TestExpectations: Skip this test on Windows since gamepad isn't supported.

1:40 PM Changeset in webkit [265213] by Wenson Hsieh

5 edits in trunk

[iOS 14] editing/selection/ios/select-all-non-editable-text-using-keyboard.html sometimes times out
https://bugs.webkit.org/show_bug.cgi?id=215089
<rdar://problem/66282806>

Reviewed by Tim Horton.

Source/WebKit:

Platform/spi/ios/UIKitSPI.h:

Tools:

Add some logging to try and diagnose this flaky test failure. The timeout only happens on iOS 14, and also does
not reproduce on my local machine. This patch tests a couple of hypotheses which may explain why the test times
out:

The test may be starting in a state where the content view is not first responder, or the view's window is

not the key window.

Synthesizing the modifier keydown HID event may be failing to change the live modifier flags on the

application's GSKeyboardRef (e.g. the issue that was fixed in <https://trac.webkit.org/r264907>).

WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::keyDown):

WebKitTestRunner/ios/mainIOS.mm:

(-[WebKitTestRunnerApp handleKeyHIDEvent:]):

1:38 PM Changeset in webkit [265212] by aakash_jain@apple.com

2 edits in trunk/Tools

Disable gtk-wk2 queue temporarily
https://bugs.webkit.org/show_bug.cgi?id=215098

Reviewed by Alexey Proskuryakov.

BuildSlaveSupport/ews-build/config.json:

1:29 PM Changeset in webkit [265211] by Wenson Hsieh

8 edits in trunk

REGRESSION (r264170): fast/events/touch/ios/long-press-on-image.html times out
https://bugs.webkit.org/show_bug.cgi?id=215075
<rdar://problem/66294637>

Reviewed by Megan Gardner.

Tools:

This test started timing out after r264170, due to the if (self.showingContextMenu) early return added inside
-[TestRunnerWKWebView _didShowContextMenu]. If this test is run after another test that attempts to show a
context menu but does not dismiss it, we will begin the test in a state where showingContextMenu is already
set to YES, which means that didShowContextMenuCallback will never be invoked.

To address this, force any context menu interactions on WKContentView to dismiss between tests. See below for
more details.

WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView immediatelyDismissContextMenuIfNeeded]):

When resetting state between tests, forcibly dismiss any context menus that were shown while running the
previous test and reset showingContextMenu back to NO.

(-[TestRunnerWKWebView contentView]):

Drive-by refactoring: add a readonly helper property to grab the WKWebView's content view for testing purposes,
and use this property instead of directly calling -valueForKeyPath: in a few places (see below).

WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage):

WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::notifyDone):
(WTR::TestController::platformResetStateToConsistentValues):

WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::platformContentView const):
(WTR::UIScriptControllerIOS::calendarType const):

LayoutTests:

Drive-by fix: this helper function had intended to use the didDismissContextMenuCallback property to register
callbacks for context menu dismissal, but instead, it sets a new property (didHideContextMenuCallback) on
UIScriptController that doesn't actually have any effect. The purpose of doing this is to make it safe to
invoke waitForInputSessionToDismiss() in the middle of the context menu dismissal animation when dismissing
date pickers on iOS. While it seems that none of our existing tests currently depend on this behavior in order
to pass, it still seems important to fix to avoid timing out when using this helper method in the future.

resources/ui-helper.js:

(window.UIHelper.waitForInputSessionToDismiss.return.new.Promise.):
(window.UIHelper.waitForInputSessionToDismiss.return.new.Promise):
(window.UIHelper.waitForInputSessionToDismiss):

12:22 PM Changeset in webkit [265210] by commit-queue@webkit.org

26 edits
2 adds in trunk

Added AudioBuffer Constructor
https://bugs.webkit.org/show_bug.cgi?id=214990

Patch by Clark Wang <clark_wang@apple.com> on 2020-08-03
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Re-baselined existing tests. Some now fail due to unsupported sampleRate.

web-platform-tests/webaudio/idlharness.https.window-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:

Source/WebCore:

Added AudioBuffer constructor according to spec: https://www.w3.org/TR/webaudio/#AudioBuffer-constructors.
Added in AudioBufferOptions files. Updated BaseAudioContext::createBuffer to use new constructor.

Re-baselined existing tests. Some fail now due to unsupported sampleRate.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::create):
(WebCore::AudioBuffer::AudioBuffer):

Modules/webaudio/AudioBuffer.h:
Modules/webaudio/AudioBuffer.idl:
Modules/webaudio/AudioBufferOptions.h: Added.
Modules/webaudio/AudioBufferOptions.idl: Added.
Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createBuffer):

Modules/webaudio/BaseAudioContext.h:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Re-baselined existing tests. Some now fail due to unsupported sampleRate.

TestExpectations:
webaudio/audiobuffer-crash-expected.txt:
webaudio/audiobuffersource-channels-expected.txt:

11:31 AM Changeset in webkit [265209] by Devin Rousso

4 edits in trunk

should be able to request an editing context for a given region of a given input
https://bugs.webkit.org/show_bug.cgi?id=215042
<rdar://problem/65561491>

Reviewed by Wenson Hsieh.

Source/WebKit:

Right now, it's only possible to request an editing context for either an entire input
element or a particular rect of the page. It should be possible to request an editing
context for a particular rect within a given input element as well (e.g. get one paragraph
or the currently selected text in a <textarea> instead of the entire thing).

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestDocumentEditingContext):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:

(TEST.DocumentEditingContext.SpatialRequest_RectEncompassingInput): Added.
(TEST.DocumentEditingContext.SpatialRequest_RectBeforeInput): Added.
(TEST.DocumentEditingContext.SpatialRequest_RectInsideInput): Added.
(TEST.DocumentEditingContext.SpatialRequest_RectAfterInput): Added.
(TEST.DocumentEditingContext.SpatialAndCurrentSelectionRequest_RectEncompassingInputWithSelection): Added.
(TEST.DocumentEditingContext.SpatialAndCurrentSelectionRequest_RectBeforeInputWithSelection): Added.
(TEST.DocumentEditingContext.SpatialAndCurrentSelectionRequest_RectBeforeSelectionInInput): Added.
(TEST.DocumentEditingContext.SpatialAndCurrentSelectionRequest_RectAfterSelectionInInput): Added.
(TEST.DocumentEditingContext.SpatialAndCurrentSelectionRequest_RectAfterInputWithSelection): Added.

11:19 AM Changeset in webkit [265208] by commit-queue@webkit.org

83 edits in trunk

[WebGL2] webgl/2.0.0/conformance[2]/textures/image_bitmap* failures
https://bugs.webkit.org/show_bug.cgi?id=211484

Patch by Kenneth Russell <kbr@chromium.org> on 2020-08-03
Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Rebaseline a test which is now passing.

web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY-expected.txt:

Source/WebCore:

Implement ImageBitmapOptions' ImageOrientation and
PremultiplyAlpha settings.

ImageOrientation="flipY" is supported directly while constructing
ImageBitmap's representation, ImageBuffer.

PremultiplyAlpha="premultiply" can not be supported via
ImageBuffer's graphics operations, so this attribute is stored on
ImageBitmap, serialized and deserialized when ImageBitmap is
transferred, and handled in the WebGL implementation.

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpImageBitmap):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readImageBitmap):
(WebCore::SerializedScriptValue::SerializedScriptValue):

bindings/js/SerializedScriptValue.h:

(WebCore::SerializedScriptValue::SerializedScriptValue):

html/ImageBitmap.cpp:

(WebCore::ImageBitmap::create):
(WebCore::ImageBitmap::detachBitmaps):
(WebCore::imageOrientationForOrientation):
(WebCore::ImageBitmap::createPromise):
(WebCore::ImageBitmap::createFromBuffer):

html/ImageBitmap.h:
html/OffscreenCanvas.cpp:

(WebCore::OffscreenCanvas::transferToImageBitmap):

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::texImageSourceHelper):

platform/graphics/ImageBuffer.h:

LayoutTests:

Rebaseline and/or enable several dozen WebGL tests under:

webgl/2.0.0/conformance[2]/textures/image_bitmap_from_blob/
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_canvas/
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_image/
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_video/

which are now passing.

TestExpectations:
webgl/2.0.0/conformance/textures/image_bitmap_from_canvas/tex-2d-rgb-rgb-unsigned_byte-expected.txt:
webgl/2.0.0/conformance/textures/image_bitmap_from_canvas/tex-2d-rgb-rgb-unsigned_short_5_6_5-expected.txt:
webgl/2.0.0/conformance/textures/image_bitmap_from_canvas/tex-2d-rgba-rgba-unsigned_byte-expected.txt:
webgl/2.0.0/conformance/textures/image_bitmap_from_canvas/tex-2d-rgba-rgba-unsigned_short_4_4_4_4-expected.txt:
webgl/2.0.0/conformance/textures/image_bitmap_from_canvas/tex-2d-rgba-rgba-unsigned_short_5_5_5_1-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r16f-red-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r16f-red-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r32f-red-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r8-red-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r8ui-red_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg16f-rg-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg16f-rg-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg32f-rg-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg8-rg-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg8ui-rg_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r11f_g11f_b10f-rgb-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r11f_g11f_b10f-rgb-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r16f-red-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r16f-red-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r32f-red-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r8-red-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r8ui-red_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rg16f-rg-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rg16f-rg-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rg32f-rg-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rg8-rg-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rg8ui-rg_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb16f-rgb-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb16f-rgb-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb32f-rgb-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb565-rgb-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb565-rgb-unsigned_short_5_6_5-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb5_a1-rgba-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb5_a1-rgba-unsigned_short_5_5_5_1-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb8-rgb-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb9_e5-rgb-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb9_e5-rgb-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba16f-rgba-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba16f-rgba-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba32f-rgba-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba4-rgba-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba4-rgba-unsigned_short_4_4_4_4-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba8-rgba-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-srgb8-rgb-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba16f-rgba-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba16f-rgba-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba32f-rgba-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-srgb8-rgb-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba16f-rgba-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba16f-rgba-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba32f-rgba-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba4-rgba-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba4-rgba-unsigned_short_4_4_4_4-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba8-rgba-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-srgb8-rgb-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r11f_g11f_b10f-rgb-float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r11f_g11f_b10f-rgb-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r8-red-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r8ui-red_integer-unsigned_byte-expected.txt:
webgl/TestExpectations:

11:00 AM Changeset in webkit [265207] by BJ Burg

2 edits in trunk/Source/WebCore

[WebDriver] window.print should not invoke native UI
https://bugs.webkit.org/show_bug.cgi?id=215084

Reviewed by Devin Rousso.

This could be handled at a higher level if there is a valid use case to allow printing,
but I'm not aware of one. For now, this fixes a script evaluation hang on Mac and iOS.

page/DOMWindow.cpp:

(WebCore::DOMWindow::print):
Don't call out to print delegates if this is a WebDriver-controlled page.

10:49 AM Changeset in webkit [265206] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Remove unused API in HighlightMap
https://bugs.webkit.org/show_bug.cgi?id=215078

Patch by Rob Buis <rbuis@igalia.com> on 2020-08-03
Reviewed by Sam Weinig.

Remove unused API in HighlightMap, this is probably not needed
anymore since the maplike code changed at some point.

Modules/highlight/HighlightMap.cpp:

(WebCore::HighlightMap::getGroupForKey): Deleted.

Modules/highlight/HighlightMap.h:

10:49 AM Changeset in webkit [265205] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WebGL2] Assert when restoring lost context
https://bugs.webkit.org/show_bug.cgi?id=214999

Patch by James Darpinian <James Darpinian> on 2020-08-03
Reviewed by Darin Adler.

Remove an assert that was wrong when restoring a lost context.

html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::initializeVertexArrayObjects):

10:30 AM Changeset in webkit [265204] by zhifei_fang@apple.com

2 edits in trunk/Tools

run-jsc-stress-test: Set DYLD_FRAMEWORK_PATH to "$(cd ../.vm; pwd)" because it escape shell words
https://bugs.webkit.org/show_bug.cgi?id=215077

Reviewed by Alexey Proskuryakov.

Scripts/run-jsc-stress-tests:

10:27 AM Changeset in webkit [265203] by Simon Fraser

1 edit
688 deletes in trunk/LayoutTests

Remove duplicate layout test results
https://bugs.webkit.org/show_bug.cgi?id=215069

Reviewed by Darin Adler.

Remove results deleted by check-for-duplicated-platform-test-results.

platform/glib/imported/w3c/web-platform-tests/cors/credentials-flag-expected.txt: Removed.
platform/glib/imported/w3c/web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt: Removed.
platform/glib/imported/w3c/web-platform-tests/css/css-sizing/percentage-height-in-flexbox-expected.txt: Removed.
platform/glib/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-expected.txt: Removed.
platform/glib/imported/w3c/web-platform-tests/eventsource/format-field-id-2-expected.txt: Removed.
platform/glib/imported/w3c/web-platform-tests/eventsource/format-field-id-expected.txt: Removed.
platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed.
platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed.
platform/glib/imported/w3c/web-platform-tests/svg/shapes/scripted/disabled-shapes-not-hit-expected.txt: Removed.
platform/gtk/fast/backgrounds/size/contain-and-cover-expected.txt: Removed.
platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
platform/gtk/fast/forms/fieldset/fieldset-elements-htmlcollection-expected.txt: Removed.
platform/gtk/fast/tokenizer/script_extra_close-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-computed-style-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-none-computed-style-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/animations/seeking-events-4-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt: Removed.
platform/gtk/media/video-controls-no-scripting-expected.txt: Removed.
platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
platform/gtk/svg/custom/circular-marker-reference-2-expected.txt: Removed.
platform/gtk/svg/custom/non-circular-marker-reference-expected.txt: Removed.
platform/ios-13/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Removed.
platform/ios-13/fast/forms/input-double-click-selection-gap-bug-expected.txt: Removed.
platform/ios-13/fast/inline/br-text-decoration-expected.txt: Removed.
platform/ios-13/fast/layers/inline-dirty-z-order-lists-expected.txt: Removed.
platform/ios-13/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt: Removed.
platform/ios-13/fast/text/international/bidi-LDB-2-CSS-expected.txt: Removed.
platform/ios-13/fast/text/international/bidi-LDB-2-HTML-expected.txt: Removed.
platform/ios-13/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt: Removed.
platform/ios-simulator/fast/canvas/webgl/copy-tex-image-and-sub-image-2d-bad-input-expected.txt: Removed.
platform/ios-simulator/webgl/2.0.0/conformance/buffers/buffer-uninitialized-expected.txt: Removed.
platform/ios-simulator/webgl/2.0.0/conformance/extensions/webgl-draw-buffers-framebuffer-unsupported-expected.txt: Removed.
platform/ios-simulator/webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt: Removed.
platform/ios-simulator/webgl/2.0.0/conformance/reading/read-pixels-test-expected.txt: Removed.
platform/ios-simulator/webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer-expected.txt: Removed.
platform/ios-simulator/webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit-expected.txt: Removed.
platform/ios-wk2/compositing/overflow/overflow-scroll-expected.txt: Removed.
platform/ios-wk2/compositing/overflow/scrollbar-painting-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Removed.
platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Removed.
platform/ios-wk2/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Removed.
platform/ios-wk2/fast/clip/014-expected.txt: Removed.
platform/ios-wk2/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.
platform/ios-wk2/fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Removed.
platform/ios-wk2/fast/forms/input-text-click-inside-expected.txt: Removed.
platform/ios-wk2/fast/forms/input-text-self-emptying-click-expected.txt: Removed.
platform/ios-wk2/fast/forms/tabbing-input-iframe-expected.txt: Removed.
platform/ios-wk2/fast/html/details-add-summary-1-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-add-summary-10-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-add-summary-2-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-add-summary-3-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-add-summary-4-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-add-summary-5-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-add-summary-6-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-add-summary-7-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-add-summary-8-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-add-summary-9-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-remove-summary-1-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-remove-summary-2-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-remove-summary-3-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-remove-summary-4-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-remove-summary-5-and-click-expected.txt: Removed.
platform/ios-wk2/fast/html/details-remove-summary-6-and-click-expected.txt: Removed.
platform/ios-wk2/fast/multicol/overflow-unsplittable-expected.txt: Removed.
platform/ios-wk2/fast/multicol/pagination/BottomToTop-bt-expected.txt: Removed.
platform/ios-wk2/fast/multicol/pagination/BottomToTop-lr-expected.txt: Removed.
platform/ios-wk2/fast/multicol/pagination/BottomToTop-rl-expected.txt: Removed.
platform/ios-wk2/fast/multicol/pagination/BottomToTop-tb-expected.txt: Removed.
platform/ios-wk2/fast/multicol/pagination/RightToLeft-bt-expected.txt: Removed.
platform/ios-wk2/fast/multicol/pagination/RightToLeft-lr-expected.txt: Removed.
platform/ios-wk2/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt: Removed.
platform/ios-wk2/fast/multicol/pagination/RightToLeft-rl-expected.txt: Removed.
platform/ios-wk2/fast/multicol/pagination/RightToLeft-tb-expected.txt: Removed.
platform/ios-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
platform/ios-wk2/fast/multicol/vertical-rl/column-rules-expected.txt: Removed.
platform/ios-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
platform/ios-wk2/fast/overflow/overflow-auto-position-absolute-expected.txt: Removed.
platform/ios-wk2/fast/overflow/paged-x-div-expected.txt: Removed.
platform/ios-wk2/fast/overflow/paged-x-div-with-column-gap-expected.txt: Removed.
platform/ios-wk2/http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt: Removed.
platform/ios-wk2/http/tests/security/anchor-download-block-crossorigin-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/html/interaction/focus/processing-model/preventScroll-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-dashoffset-computed-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linecap-computed-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linejoin-computed-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/web-share/canShare-insecure.http-expected.txt: Removed.
platform/ios/animations/3d/replace-filling-transform-expected.txt: Removed.
platform/ios/animations/animation-offscreen-to-onscreen-expected.txt: Removed.
platform/ios/animations/opacity-transform-animation-expected.txt: Removed.
platform/ios/animations/suspend-transform-animation-expected.txt: Removed.
platform/ios/compositing/contents-opaque/background-clip-expected.txt: Removed.
platform/ios/compositing/contents-opaque/background-color-expected.txt: Removed.
platform/ios/compositing/contents-opaque/table-parts-expected.txt: Removed.
platform/ios/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
platform/ios/compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt: Removed.
platform/ios/css3/calc/line-height-expected.txt: Removed.
platform/ios/fast/attachment/attachment-disabled-dom-expected.txt: Removed.
platform/ios/fast/attachment/attachment-dom-expected.txt: Removed.
platform/ios/fast/block/basic/quirk-percent-height-table-cell-expected.txt: Removed.
platform/ios/fast/borders/border-radius-different-width-001-expected.txt: Removed.
platform/ios/fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
platform/ios/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
platform/ios/fast/dynamic/001-expected.txt: Removed.
platform/ios/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
platform/ios/fast/events/constructors/keyboard-event-constructor-expected.txt: Removed.
platform/ios/fast/forms/005-expected.txt: Removed.
platform/ios/fast/multicol/span/before-child-anonymous-column-block-expected.txt: Removed.
platform/ios/fast/reflections/table-cell-expected.txt: Removed.
platform/ios/fast/replaced/table-percent-height-positioned-expected.txt: Removed.
platform/ios/fast/table/008-expected.txt: Removed.
platform/ios/fast/table/caption-relayout-expected.txt: Removed.
platform/ios/fast/table/growCellForImageQuirk-expected.txt: Removed.
platform/ios/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
platform/ios/fast/table/table-row-before-after-content-around-table-cell-expected.txt: Removed.
platform/ios/fast/table/table-row-outline-paint-expected.txt: Removed.
platform/ios/fast/table/table-row-split2-expected.txt: Removed.
platform/ios/fast/table/table-section-split2-expected.txt: Removed.
platform/ios/fast/table/table-split-expected.txt: Removed.
platform/ios/fast/table/table-split2-expected.txt: Removed.
platform/ios/fast/text/system-font-weight-expected.txt: Removed.
platform/ios/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
platform/ios/http/tests/security/contentSecurityPolicy/audio-redirect-blocked-expected.txt: Removed.
platform/ios/http/tests/security/contentSecurityPolicy/video-redirect-blocked-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/cors/access-control-expose-headers-parsing.window-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio-affects-container-width-when-height-changes-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-cross-origin-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/meter-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/xhr/getresponseheader-case-insensitive-expected.txt: Removed.
platform/ios/quicklook/numbers-expected.html: Removed.
platform/ios/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
platform/ios/swipe/basic-cached-back-swipe-expected.txt: Removed.
platform/ios/swipe/pushState-cached-back-swipe-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug120107-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug1271-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug13169-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug269566-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug277062-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug28933-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug2954-expected.txt: Removed.
platform/ios/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
platform/ios/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
platform/ios/webaudio/audiobuffersource-expected.wav: Removed.
platform/ios/webaudio/audiobuffersource-multi-channels-expected.wav: Removed.
platform/ios/webaudio/audiochannelmerger-stereo-expected.txt: Removed.
platform/ios/webaudio/audionode-channel-rules-expected.txt: Removed.
platform/ios/webaudio/audionode-connect-order-expected.txt: Removed.
platform/ios/webaudio/audioparam-connect-audioratesignal-expected.txt: Removed.
platform/ios/webaudio/audioparam-exponentialRampToValueAtTime-expected.txt: Removed.
platform/ios/webaudio/audioparam-linearRampToValueAtTime-expected.txt: Removed.
platform/ios/webaudio/audioparam-setTargetAtTime-expected.txt: Removed.
platform/ios/webaudio/audioparam-setValueAtTime-expected.txt: Removed.
platform/ios/webaudio/audioparam-setValueCurveAtTime-expected.txt: Removed.
platform/ios/webaudio/audioparam-summingjunction-expected.txt: Removed.
platform/ios/webaudio/audioprocessingevent-expected.txt: Removed.
platform/ios/webaudio/automatic-pull-node-expected.txt: Removed.
platform/ios/webaudio/biquad-allpass-expected.txt: Removed.
platform/ios/webaudio/biquad-bandpass-expected.txt: Removed.
platform/ios/webaudio/biquad-getFrequencyResponse-expected.txt: Removed.
platform/ios/webaudio/biquad-highpass-expected.txt: Removed.
platform/ios/webaudio/biquad-highshelf-expected.txt: Removed.
platform/ios/webaudio/biquad-lowpass-expected.txt: Removed.
platform/ios/webaudio/biquad-lowshelf-expected.txt: Removed.
platform/ios/webaudio/biquad-notch-expected.txt: Removed.
platform/ios/webaudio/biquad-peaking-expected.txt: Removed.
platform/ios/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Removed.
platform/ios/webaudio/convolution-mono-mono-expected.txt: Removed.
platform/ios/webaudio/delaynode-expected.txt: Removed.
platform/ios/webaudio/delaynode-max-default-delay-expected.txt: Removed.
platform/ios/webaudio/delaynode-max-nondefault-delay-expected.txt: Removed.
platform/ios/webaudio/delaynode-maxdelay-expected.txt: Removed.
platform/ios/webaudio/delaynode-scheduling-expected.txt: Removed.
platform/ios/webaudio/dynamicscompressor-basic-expected.txt: Removed.
platform/ios/webaudio/gain-basic-expected.txt: Removed.
platform/ios/webaudio/gain-expected.wav: Removed.
platform/ios/webaudio/javascriptaudionode-downmix8-2channel-input-expected.txt: Removed.
platform/ios/webaudio/javascriptaudionode-upmix2-8channel-input-expected.txt: Removed.
platform/ios/webaudio/javascriptaudionode-zero-input-channels-expected.txt: Removed.
platform/ios/webaudio/mediaelementaudiosourcenode-gc-expected.txt: Removed.
platform/ios/webaudio/mixing-expected.wav: Removed.
platform/ios/webaudio/oscillator-sine-expected.wav: Removed.
platform/ios/webaudio/panner-equalpower-expected.txt: Removed.
platform/ios/webaudio/panner-equalpower-stereo-expected.txt: Removed.
platform/ios/webaudio/realtimeanalyser-fft-scaling-expected.txt: Removed.
platform/ios/webaudio/sample-accurate-scheduling-expected.txt: Removed.
platform/ios/webaudio/stereo2mono-down-mixing-expected.txt: Removed.
platform/ios/webaudio/test-basic-expected.wav: Removed.
platform/ios/webaudio/up-mixing-mono-51-expected.wav: Removed.
platform/ios/webaudio/up-mixing-mono-stereo-expected.wav: Removed.
platform/ios/webaudio/up-mixing-stereo-51-expected.wav: Removed.
platform/ios/webaudio/waveshaper-expected.txt: Removed.
platform/ios/webaudio/waveshaper-oversample-2x-expected.txt: Removed.
platform/ios/webaudio/waveshaper-oversample-4x-expected.txt: Removed.
platform/ios/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt: Removed.
platform/ios/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt: Removed.
platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-expected.txt: Removed.
platform/mac-mojave/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https-expected.txt: Removed.
platform/mac-mojave/imported/w3c/web-platform-tests/xhr/getresponseheader-case-insensitive-expected.txt: Removed.
platform/mac-mojave/media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
platform/mac-wk1/compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt: Removed.
platform/mac-wk1/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
platform/mac-wk1/http/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-async-delegate-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/css/geometry/DOMMatrix2DInit-validate-fixup-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/joint-session-history/joint-session-history-only-fully-active-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/001-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/002-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-dashoffset-computed-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linecap-computed-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linejoin-computed-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-miterlimit-computed-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-opacity-computed-expected.txt: Removed.
platform/mac-wk1/inspector/model/remote-object/number-expected.txt: Removed.
platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt: Removed.
platform/mac-wk2/editing/style/unbold-in-bold-expected.txt: Removed.
platform/mac-wk2/fast/frames/flattening/frameset-flattening-simple-expected.txt: Removed.
platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt: Removed.
platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt: Removed.
platform/mac-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt: Removed.
platform/mac-wk2/imported/w3c/web-platform-tests/web-share/canShare-insecure.http-expected.txt: Removed.
platform/mac/accessibility/negative-tabindex-does-not-expose-label-expected.txt: Removed.
platform/mac/accessibility/svg-bounds-expected.txt: Removed.
platform/mac/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Removed.
platform/mac/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Removed.
platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Removed.
platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Removed.
platform/mac/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt: Removed.
platform/mac/compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Removed.
platform/mac/compositing/contents-format/subpixel-antialiased-text-traversal-expected.txt: Removed.
platform/mac/compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Removed.
platform/mac/compositing/contents-opaque/table-parts-expected.txt: Removed.
platform/mac/css2.1/t1508-c527-font-00-b-expected.txt: Removed.
platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt: Removed.
platform/mac/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
platform/mac/editing/selection/drag-start-event-client-x-y-expected.txt: Removed.
platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
platform/mac/fast/block/basic/quirk-percent-height-table-cell-expected.txt: Removed.
platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
platform/mac/fast/borders/border-radius-different-width-001-expected.txt: Removed.
platform/mac/fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
platform/mac/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
platform/mac/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
platform/mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Removed.
platform/mac/fast/css/caption-width-absolute-position-expected.txt: Removed.
platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
platform/mac/fast/css/caption-width-fixed-position-expected.txt: Removed.
platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
platform/mac/fast/css/caption-width-relative-position-expected.txt: Removed.
platform/mac/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
platform/mac/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Removed.
platform/mac/fast/css/image-rendering-expected.txt: Removed.
platform/mac/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
platform/mac/fast/dom/HTMLImageElement/resources/blue_rect.jpg: Removed.
platform/mac/fast/dom/adopt-attribute-crash-expected.txt: Removed.
platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
platform/mac/fast/dynamic/001-expected.txt: Removed.
platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
platform/mac/fast/events/document-elementFromPoint-expected.txt: Removed.
platform/mac/fast/flexbox/flex-hang-expected.txt: Removed.
platform/mac/fast/forms/005-expected.txt: Removed.
platform/mac/fast/images/repaint-subrect-grid-expected.txt: Removed.
platform/mac/fast/images/zoomed-img-size-expected.txt: Removed.
platform/mac/fast/invalid/018-expected.txt: Removed.
platform/mac/fast/lists/list-marker-before-content-table-expected.txt: Removed.
platform/mac/fast/loader/javascript-url-in-embed-expected.txt: Removed.
platform/mac/fast/multicol/break-properties-expected.txt: Removed.
platform/mac/fast/multicol/span/before-child-anonymous-column-block-expected.txt: Removed.
platform/mac/fast/multicol/vertical-lr/break-properties-expected.txt: Removed.
platform/mac/fast/multicol/vertical-rl/break-properties-expected.txt: Removed.
platform/mac/fast/parser/style-script-head-test-expected.txt: Removed.
platform/mac/fast/reflections/reflection-with-zoom-expected.txt: Removed.
platform/mac/fast/reflections/table-cell-expected.txt: Removed.
platform/mac/fast/repaint/float-overflow-expected.txt: Removed.
platform/mac/fast/repaint/float-overflow-right-expected.txt: Removed.
platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
platform/mac/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
platform/mac/fast/repaint/table-cell-overflow-expected.txt: Removed.
platform/mac/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
platform/mac/fast/repaint/table-col-background-expected.txt: Removed.
platform/mac/fast/repaint/table-outer-border-expected.txt: Removed.
platform/mac/fast/repaint/table-row-expected.txt: Removed.
platform/mac/fast/repaint/table-section-overflow-expected.txt: Removed.
platform/mac/fast/repaint/table-section-repaint-expected.txt: Removed.
platform/mac/fast/repaint/table-writing-modes-h-expected.txt: Removed.
platform/mac/fast/repaint/table-writing-modes-v-expected.txt: Removed.
platform/mac/fast/replaced/table-percent-height-positioned-expected.txt: Removed.
platform/mac/fast/table/008-expected.txt: Removed.
platform/mac/fast/table/031-expected.txt: Removed.
platform/mac/fast/table/032-expected.txt: Removed.
platform/mac/fast/table/border-collapsing/bug14274-expected.txt: Removed.
platform/mac/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Removed.
platform/mac/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Removed.
platform/mac/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt: Removed.
platform/mac/fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Removed.
platform/mac/fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Removed.
platform/mac/fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Removed.
platform/mac/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt: Removed.
platform/mac/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt: Removed.
platform/mac/fast/table/caption-relayout-expected.txt: Removed.
platform/mac/fast/table/growCellForImageQuirk-expected.txt: Removed.
platform/mac/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
platform/mac/fast/table/height-percent-test-expected.txt: Removed.
platform/mac/fast/table/height-percent-test-vertical-expected.txt: Removed.
platform/mac/fast/table/table-anonymous-cell-bug-expected.txt: Removed.
platform/mac/fast/table/table-anonymous-row-bug-expected.txt: Removed.
platform/mac/fast/table/table-anonymous-section-bug-expected.txt: Removed.
platform/mac/fast/table/table-before-child-style-update-expected.txt: Removed.
platform/mac/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Removed.
platform/mac/fast/table/table-cell-before-after-content-around-table-expected.txt: Removed.
platform/mac/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Removed.
platform/mac/fast/table/table-cell-split-expected.txt: Removed.
platform/mac/fast/table/table-insert-before-non-anonymous-block-expected.txt: Removed.
platform/mac/fast/table/table-row-before-after-content-around-block-expected.txt: Removed.
platform/mac/fast/table/table-row-before-after-content-around-table-cell-expected.txt: Removed.
platform/mac/fast/table/table-row-before-after-content-around-table-expected.txt: Removed.
platform/mac/fast/table/table-row-before-child-style-update-expected.txt: Removed.
platform/mac/fast/table/table-row-outline-paint-expected.txt: Removed.
platform/mac/fast/table/table-row-split2-expected.txt: Removed.
platform/mac/fast/table/table-row-style-not-updated-expected.txt: Removed.
platform/mac/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Removed.
platform/mac/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Removed.
platform/mac/fast/table/table-section-split2-expected.txt: Removed.
platform/mac/fast/table/table-split-expected.txt: Removed.
platform/mac/fast/table/table-split2-expected.txt: Removed.
platform/mac/fast/table/table-style-not-updated-expected.txt: Removed.
platform/mac/fast/table/wide-colspan-expected.txt: Removed.
platform/mac/fast/table/wide-column-expected.txt: Removed.
platform/mac/fast/text/whitespace/013-expected.txt: Removed.
platform/mac/fast/text/whitespace/014-expected.txt: Removed.
platform/mac/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
platform/mac/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Removed.
platform/mac/http/tests/inspector/network/resource-sizes-memory-cache-expected.txt: Removed.
platform/mac/imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large-expected.txt: Removed.
platform/mac/imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small-expected.txt: Removed.
platform/mac/imported/w3c/web-platform-tests/cors/access-control-expose-headers-parsing.window-expected.txt: Removed.
platform/mac/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed.
platform/mac/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed.
platform/mac/media/track/video-track-alternate-groups-expected.txt: Removed.
platform/mac/security/block-test-expected.txt: Removed.
platform/mac/security/block-test-no-port-expected.txt: Removed.
platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
platform/mac/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
platform/mac/svg/custom/fractional-rects-expected.txt: Removed.
platform/mac/svg/custom/js-update-container-expected.txt: Removed.
platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Removed.
platform/mac/svg/custom/viewBox-hit-expected.txt: Removed.
platform/mac/svg/hixie/text/001-expected.txt: Removed.
platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Removed.
platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Removed.
platform/mac/svg/text/text-hkern-expected.txt: Removed.
platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug120107-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug1271-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug13169-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug269566-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug277062-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug28933-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug29314-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug2954-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug56201-expected.txt: Removed.
platform/mac/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
platform/mac/userscripts/script-run-at-end-expected.txt: Removed.
platform/win-7sp0/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
platform/win-7sp0/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
platform/win-7sp0/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
platform/win-7sp0/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed.
platform/win-7sp0/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
platform/win/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
platform/win/css2.1/tables/table-anonymous-objects-181-expected.txt: Removed.
platform/win/editing/deleting/smart-delete-001-expected.txt: Removed.
platform/win/editing/deleting/smart-delete-002-expected.txt: Removed.
platform/win/editing/deleting/smart-delete-003-expected.txt: Removed.
platform/win/editing/deleting/smart-delete-004-expected.txt: Removed.
platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
platform/win/fast/block/basic/quirk-percent-height-table-cell-expected.txt: Removed.
platform/win/fast/borders/border-radius-different-width-001-expected.txt: Removed.
platform/win/fast/borders/table-borders-expected.txt: Removed.
platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
platform/win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed.
platform/win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
platform/win/fast/canvas/fallback-content-expected.txt: Removed.
platform/win/fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
platform/win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
platform/win/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
platform/win/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
platform/win/fast/css/button-height-expected.txt: Removed.
platform/win/fast/css/caption-width-absolute-position-expected.txt: Removed.
platform/win/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
platform/win/fast/css/caption-width-fixed-position-expected.txt: Removed.
platform/win/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
platform/win/fast/css/caption-width-relative-position-expected.txt: Removed.
platform/win/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
platform/win/fast/css/first-letter-block-form-controls-crash-expected.txt: Removed.
platform/win/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
platform/win/fast/css/percentage-non-integer-expected.txt: Removed.
platform/win/fast/css/relative-position-replaced-in-table-display-crash-expected.txt: Removed.
platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
platform/win/fast/dom/adopt-attribute-crash-expected.txt: Removed.
platform/win/fast/dom/adopt-node-crash-2-expected.txt: Removed.
platform/win/fast/dynamic/001-expected.txt: Removed.
platform/win/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
platform/win/fast/events/event-attribute-expected.txt: Removed.
platform/win/fast/events/ondragenter-expected.txt: Removed.
platform/win/fast/forms/005-expected.txt: Removed.
platform/win/fast/forms/access-key-for-all-elements-expected.txt: Removed.
platform/win/fast/forms/form-associated-element-crash3-expected.txt: Removed.
platform/win/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Removed.
platform/win/fast/invalid/012-expected.txt: Removed.
platform/win/fast/lists/list-marker-before-content-table-expected.txt: Removed.
platform/win/fast/multicol/renderer-positioned-assert-crash-expected.txt: Removed.
platform/win/fast/multicol/span/before-child-anonymous-column-block-expected.txt: Removed.
platform/win/fast/reflections/table-cell-expected.txt: Removed.
platform/win/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Removed.
platform/win/fast/repaint/float-overflow-expected.txt: Removed.
platform/win/fast/repaint/float-overflow-right-expected.txt: Removed.
platform/win/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
platform/win/fast/repaint/table-cell-overflow-expected.txt: Removed.
platform/win/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
platform/win/fast/repaint/table-col-background-expected.txt: Removed.
platform/win/fast/repaint/table-hover-on-link-expected.txt: Removed.
platform/win/fast/repaint/table-outer-border-expected.txt: Removed.
platform/win/fast/repaint/table-row-expected.txt: Removed.
platform/win/fast/repaint/table-section-overflow-expected.txt: Removed.
platform/win/fast/repaint/table-section-repaint-expected.txt: Removed.
platform/win/fast/repaint/table-writing-modes-h-expected.txt: Removed.
platform/win/fast/repaint/table-writing-modes-v-expected.txt: Removed.
platform/win/fast/replaced/005-expected.txt: Removed.
platform/win/fast/replaced/table-percent-height-positioned-expected.txt: Removed.
platform/win/fast/table/005-expected.txt: Removed.
platform/win/fast/table/006-expected.txt: Removed.
platform/win/fast/table/008-expected.txt: Removed.
platform/win/fast/table/013-expected.txt: Removed.
platform/win/fast/table/031-expected.txt: Removed.
platform/win/fast/table/032-expected.txt: Removed.
platform/win/fast/table/border-collapsing/002-expected.txt: Removed.
platform/win/fast/table/border-collapsing/002-vertical-expected.txt: Removed.
platform/win/fast/table/border-collapsing/bug14274-expected.txt: Removed.
platform/win/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Removed.
platform/win/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt: Removed.
platform/win/fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Removed.
platform/win/fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Removed.
platform/win/fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Removed.
platform/win/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt: Removed.
platform/win/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt: Removed.
platform/win/fast/table/caption-relayout-expected.txt: Removed.
platform/win/fast/table/dynamic-cellpadding-expected.txt: Removed.
platform/win/fast/table/growCellForImageQuirk-expected.txt: Removed.
platform/win/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
platform/win/fast/table/height-percent-test-expected.txt: Removed.
platform/win/fast/table/height-percent-test-vertical-expected.txt: Removed.
platform/win/fast/table/multiple-percent-height-rows-expected.txt: Removed.
platform/win/fast/table/table-anonymous-cell-bug-expected.txt: Removed.
platform/win/fast/table/table-anonymous-row-bug-expected.txt: Removed.
platform/win/fast/table/table-anonymous-section-bug-expected.txt: Removed.
platform/win/fast/table/table-before-child-style-update-expected.txt: Removed.
platform/win/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Removed.
platform/win/fast/table/table-cell-before-after-content-around-table-expected.txt: Removed.
platform/win/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Removed.
platform/win/fast/table/table-cell-split-expected.txt: Removed.
platform/win/fast/table/table-insert-before-non-anonymous-block-expected.txt: Removed.
platform/win/fast/table/table-row-before-after-content-around-block-expected.txt: Removed.
platform/win/fast/table/table-row-before-after-content-around-table-cell-expected.txt: Removed.
platform/win/fast/table/table-row-before-after-content-around-table-expected.txt: Removed.
platform/win/fast/table/table-row-before-child-style-update-expected.txt: Removed.
platform/win/fast/table/table-row-outline-paint-expected.txt: Removed.
platform/win/fast/table/table-row-split2-expected.txt: Removed.
platform/win/fast/table/table-row-style-not-updated-expected.txt: Removed.
platform/win/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Removed.
platform/win/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Removed.
platform/win/fast/table/table-section-split2-expected.txt: Removed.
platform/win/fast/table/table-split-expected.txt: Removed.
platform/win/fast/table/table-split2-expected.txt: Removed.
platform/win/fast/table/table-style-not-updated-expected.txt: Removed.
platform/win/fast/table/wide-colspan-expected.txt: Removed.
platform/win/fast/table/wide-column-expected.txt: Removed.
platform/win/fast/text/whitespace/013-expected.txt: Removed.
platform/win/fast/text/whitespace/014-expected.txt: Removed.
platform/win/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
platform/win/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
platform/win/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Removed.
platform/win/plugins/netscape-dom-access-and-reload-expected.txt: Removed.
platform/win/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Removed.
platform/win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Removed.
platform/win/svg/custom/glyph-setting-d-attribute-expected.png: Removed.
platform/win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed.
platform/win/svg/foreignObject/text-tref-02-b-expected.png: Removed.
platform/win/svg/text/kerning-expected.png: Removed.
platform/win/svg/text/multichar-glyph-expected.png: Removed.
platform/win/tables/mozilla/bugs/bug106795-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug120107-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug1220-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug1261-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug1271-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug13169-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug139524-1-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug139524-3-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug139524-4-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug15933-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug18440-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug2123-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug219693-1-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug219693-2-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug22513-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug2585-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug269566-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug277062-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug28933-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug29314-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug2954-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug46944-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug53690-1-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug53690-2-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug55789-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug56201-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug8361-expected.txt: Removed.
platform/win/tables/mozilla/bugs/bug97383-expected.txt: Removed.
platform/win/tables/mozilla/other/slashlogo-expected.txt: Removed.
platform/win/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
platform/win/tables/mozilla_expected_failures/bugs/bug1647-expected.txt: Removed.
platform/win/tables/mozilla_expected_failures/bugs/bug178855-expected.txt: Removed.
platform/win/tables/mozilla_expected_failures/bugs/bug72393-expected.txt: Removed.
platform/wincairo/css3/calc/line-height-expected.txt: Removed.
platform/wincairo/fast/dom/adopt-node-crash-2-expected.txt: Removed.
platform/wk2/http/tests/contentdispositionattachmentsandbox/cross-origin-frames-disabled-expected.txt: Removed.
platform/wk2/http/tests/contentextensions/block-everything-unless-domain-expected.txt: Removed.
platform/wk2/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: Removed.
platform/wk2/http/tests/security/drag-drop-local-file-expected.txt: Removed.
platform/wk2/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Removed.
platform/wk2/webarchive/loading/javascript-url-iframe-crash-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-computed-style-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-none-computed-style-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.https-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt: Removed.
platform/wpe/webgl/2.0.0/conformance/extensions/ext-sRGB-expected.txt: Removed.
platform/wpe/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt: Removed.

10:13 AM Changeset in webkit [265202] by Kate Cheney

7 edits in trunk/Source/WebKit

doesParentProcessHaveITPEnabled() check should match behavior in determineITPStateInternal() check
https://bugs.webkit.org/show_bug.cgi?id=215031
<rdar://problem/66384618>

Reviewed by Brent Fulgham.

Checking ITP state from a WebKit child process should have the same
behavior as checking it from the UI process. In order to do this,
we must pass the value of hasRequestedCrossWebsiteTrackingPermission
to the network process to know if an application has included the
NSCrossWebsiteTrackingUsageDescription value in their Info.plist.

NetworkProcess/NetworkSessionCreationParameters.cpp:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

NetworkProcess/NetworkSessionCreationParameters.h:
NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::activateSessionCleanup):

Shared/Cocoa/DefaultWebBrowserChecks.h:
Shared/Cocoa/DefaultWebBrowserChecks.mm:

(WebKit::hasRequestedCrossWebsiteTrackingPermission):
(WebKit::doesParentProcessHaveITPEnabled):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

9:59 AM Changeset in webkit [265201] by BJ Burg

2 edits in trunk/Tools

REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy
https://bugs.webkit.org/show_bug.cgi?id=215038

Reviewed by Jonathan Bedard.

Scripts/webkitpy/results/options.py:

(upload_options):
For compatibility, make it possible to create the option with a differently-named flag.

9:54 AM Changeset in webkit [265200] by Truitt Savell

2 edits in trunk/LayoutTests

[ macOS wk2 ] webrtc/datachannel/gather-candidates-networkprocess-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215088

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-08-03

platform/mac-wk2/TestExpectations:

9:42 AM Changeset in webkit [265199] by Adrian Perez de Castro

16 edits in trunk/Source

Non-unified build fixes, early August 20202 edition
https://bugs.webkit.org/show_bug.cgi?id=215082

Unreviewed build fix.

Source/JavaScriptCore:

dfg/DFGOSREntry.h: Add missing inclusion of CodeLocation.h
ftl/FTLGeneratedFunction.h: Ditto.
jit/CallFrameShuffler.h: Forward-declare CCallHelpers.

Source/WebCore:

No new tests needed.

accessibility/AccessibilityRenderObject.cpp: Add missing inclusion of Range.h.
dom/RadioButtonGroups.cpp: Ditto.
editing/Editing.cpp: Ditto.
editing/EditingStyle.cpp: Ditto.
editing/EditorCommand.cpp: Ditto.
editing/FrameSelection.cpp: Ditto.
editing/TypingCommand.cpp: Ditto.
editing/VisiblePosition.cpp: Add missing inclusion of SimpleRange.h.
rendering/HitTestResult.cpp: Add missing inclusion of Range.h.

Source/WebKit:

WebProcess/WebPage/FindController.h: Add missing inclusion of WebCore/SimpleRange.h.

9:18 AM Changeset in webkit [265198] by Antti Koivisto

5 edits
2 adds in trunk

REGRESSION(r259585) Text decoration color with value currentColor miscomputed in some cases
https://bugs.webkit.org/show_bug.cgi?id=215079

Reviewed by Zalan Bujtas.

Source/WebCore:

r259585 did some refactoring that broke a special case where text decoration color comes from
'-webkit-text-fill-color' property.

Test: fast/text/text-decoration-currentcolor-fill-color.html

rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::decorationColor):

Move resolving currentColor to RenderStyle.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::colorResolvingCurrentColor const):

Handle CSSPropertyTextDecorationColor as a special case here.

(WebCore::RenderStyle::visitedDependentColor const):

LayoutTests:

fast/text/text-decoration-currentcolor-fill-color-expected.html: Added.
fast/text/text-decoration-currentcolor-fill-color.html: Added.

9:03 AM Changeset in webkit [265197] by Truitt Savell

3 edits in trunk/LayoutTests

[ macOS wk2 Release ] media/video-background-tab-playback.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=209353

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-08-03

platform/mac-wk1/TestExpectations:
platform/mac/TestExpectations:

8:51 AM Changeset in webkit [265196] by commit-queue@webkit.org

18 edits
2 adds in trunk

Added Constructor to AnalyserNode
https://bugs.webkit.org/show_bug.cgi?id=215040

Patch by Clark Wang <clark_wang@apple.com> on 2020-08-03
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Re-baselined existing tests.

web-platform-tests/webaudio/idlharness.https.window-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-sizing-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analysernode-expected.txt:

Source/WebCore:

Introduced AnalyserNode constructor and AnalyserOptions according to spec:
https://www.w3.org/TR/webaudio/#AnalyserNode-constructors.

Re-baselined existing tests.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::create):
(WebCore::AnalyserNode::AnalyserNode):
(WebCore::AnalyserNode::setFftSize):
(WebCore::AnalyserNode::setMinMaxDecibels):
(WebCore::AnalyserNode::setMinDecibels):
(WebCore::AnalyserNode::setMaxDecibels):

Modules/webaudio/AnalyserNode.h:
Modules/webaudio/AnalyserNode.idl:
Modules/webaudio/AnalyserOptions.h: Added.
Modules/webaudio/AnalyserOptions.idl: Added.
Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createAnalyser):

Sources.txt:
WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Re-baselined existing tests.

webaudio/analyser-exception-expected.txt:

5:29 AM Changeset in webkit [265195] by commit-queue@webkit.org

2 edits in trunk/Tools

[WPE][GTK] run-minibrowser no longer assumes release configuration by default
https://bugs.webkit.org/show_bug.cgi?id=214961

Patch by Philippe Normand <pnormand@igalia.com> on 2020-08-03
Reviewed by Adrian Perez de Castro.

Scripts/webkitpy/port/base.py:

(Port.set_option_default): Ensure default value is set on optparsed options. In the case of
the default build configuration being set from the Port constructor, this wasn't done
properly. After fixing this, the WPE and GTK ports are correctly implicitely reusing the
build configuration option through the _build_path() method.

5:26 AM Changeset in webkit [265194] by commit-queue@webkit.org

2 edits in trunk/Tools

REGRESSION(r264096): [flatpak] Clean gst-build within build-webkit fails
https://bugs.webkit.org/show_bug.cgi?id=214080

Patch by Philippe Normand <pnormand@igalia.com> on 2020-08-03
Reviewed by Adrian Perez de Castro.

flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): Don't attempt to configure the gst-env when starting sccache-dist.

4:44 AM Changeset in webkit [265193] by Caio Lima

2 edits in trunk/JSTests

[JSC][MIPS] Test gardening July 31st edition
https://bugs.webkit.org/show_bug.cgi?id=215023

Unreviewed Gardening.

stress/typedarray-access-neutered.js:

3:09 AM Changeset in webkit [265192] by youenn@apple.com

3 edits in trunk/Source/WebCore

MediaRecorderPrivateWriter::appendEndOfVideoSampleDurationIfNeeded should only call requestMediaDataWhenReadyOnQueue once
https://bugs.webkit.org/show_bug.cgi?id=214972

Reviewed by Eric Carlson.

When processing a compressed sample, pass it to the writer if its ready.
Otherwise buffer it and retry passing it to the writer next time we have a sample.
When finishing a write, we call requestMediaDataWhenReadyOnQueue to finish passing samples that are still enqueued.

Covered by existing tests no longer triggering ObjC exception.

platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::appendCompressedAudioSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBufferIfPossible):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendCompressedSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::finishAppendingCompressedAudioSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::finishAppendingCompressedVideoSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::flushCompressedSampleBuffers):

Aug 2, 2020:

11:41 PM Changeset in webkit [265191] by Simon Fraser

6 edits in trunk/Tools

Improve the check-for-duplicated-platform-test-results script
https://bugs.webkit.org/show_bug.cgi?id=215072

Reviewed by Darin Adler.

check-for-duplicated-platform-test-results had some problems.

First, it defaulted to -wk1 results directories, and didn't check -wk2 directories, so
run the logic twice, with options.webkit_test_runner True and False.
Second, it only looked for results in the most specific fallback directory, so
with a fallback path like 'mac-mojave-wk1 -> mac-mojave -> mac-wk1 -> mac -> generic'
it would only remove results in mac-mojave-wk1, not in 'mac-mojave'.
Also add some logging to the script.

Scripts/check-for-duplicated-platform-test-results:

(remove_layout_test_path_prefix):
(check_duplicate.sha1):
(check_duplicate):
(platform_list):
(find_duplicates_in_path):
(find_duplicates_in_path.find_duplicates):
(check_platform):
(main):

Scripts/webkitpy/port/base.py:

(Port.supports_layout_tests): Some ports (iOS and watch device ports) don't support
testing with no associated device. Need to fix errors thrown from default_baseline_search_path().

Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.supports_layout_tests):

Scripts/webkitpy/port/watch_device.py:

(WatchDevicePort.supports_layout_tests):

Scripts/webkitpy/port/win.py: self._os_version is None when run on another platform.

(WinPort.default_baseline_search_path):
(WinCairoPort._search_paths):

5:47 PM Changeset in webkit [265190] by Darin Adler

59 edits in trunk/Source

Remove some member functions of Range and many calls to createLiveRange
https://bugs.webkit.org/show_bug.cgi?id=215070

Reviewed by Sam Weinig.

Source/WebCore:

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::nextBoundary): Remove createLiveRange.
(WebCore::AXObjectCache::previousBoundary): Ditto.

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Take SimpleRange.
(-[WebAccessibilityObjectWrapper positionForTextMarker:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textRectsFromMarkers:withText:]): Ditto.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Take SimpleRange.
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]): Ditto.

dom/DocumentMarkerController.cpp:

(WebCore::updateRenderedRectsForMarker): Renamed range to makeSimpleRange.
(WebCore::makeSimpleRange): Ditto.

dom/DocumentMarkerController.h: Update for the above.

dom/Range.cpp:

(WebCore::Range::text const): Use makeSimpleRange.
(WebCore::Range::shadowRoot const): Deleted.
(WebCore::intervalsSufficientlyOverlap): Deleted.
(WebCore::adjustLineHeightOfSelectionRects): Deleted.
(WebCore::coalesceSelectionRects): Deleted.
(WebCore::Range::collectSelectionRectsWithoutUnionInteriorLines const): Deleted.
(WebCore::Range::collectSelectionRects const): Deleted.

dom/Range.h: Update for the above. Also make pastLastNode private since it is

only used inside the Range class's implementation.

dom/SimpleRange.cpp:

(WebCore::SimpleRange::SimpleRange): Removed overload that takes a Range.

dom/SimpleRange.h: Update for the above. Removed both constructor overloads

that take a Range.

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::timerFired): Remove createLiveRange.
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord): Use
makeSimpleRange.
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
Remove createLiveRange.

editing/EditingStyle.cpp:

(WebCore::EditingStyle::styleAtSelectionStart): Remove createLiveRange.

editing/Editor.cpp:

(WebCore::Editor::performCutOrCopy): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
(WebCore::Editor::replaceRangeForSpellChecking): Ditto.
(WebCore::correctSpellcheckingPreservingTextCheckingParagraph): Ditto.
(WebCore::Editor::changeBackToReplacedString): Ditto.
(WebCore::Editor::countMatchesForText): Ditto.

editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply): Ditto.
(WebCore::InsertListCommand::doApplyForSingleParagraph): Change out
argument type to SimpleRange.

editing/InsertListCommand.h: Update for above.

editing/SpellChecker.cpp:

(WebCore::SpellChecker::isCheckable const): Rewrite questionable logic
to use intersectingNodes instead of firstNode.

editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findUngrammaticalPhrases const): Remove createLiveRange.

editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed): Ditto.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

editing/markup.cpp:

(WebCore::createFragmentFromText): Ditto.

editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAsChildOfElement): Use makeRangeSelectingNodeContents.

editing/win/EditorWin.cpp:

(WebCore::Editor::pasteWithPasteboard): Remove createLiveRange.

page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange): Use makeSimpleRange.
(WebCore::DOMSelection::deleteFromDocument): Remove createLiveRange.

page/DragController.cpp:

(WebCore::documentFragmentFromDragData): Take SimpleRange.
(WebCore::DragController::concludeEditDrag): Remove createLiveRange.
(WebCore::DragController::startDrag): Ditto.

page/TextIndicator.cpp:

(WebCore::selectionRects): Deleted.
(WebCore::initializeIndicator): Call collectSelectionRects directly here,
avoiding createLiveRange and using map to convert from Vector<SelectionRect>
to Vector<FloatRect>.

page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot const): Use makeSimpleRange.

platform/DragImage.cpp:

(WebCore::createDragImageForRange): Take SimpleRange.

platform/DragImage.h: Update createDragImageForRange to take SimpleRange.

platform/Pasteboard.h: Updated Windows-only layering-violating functions

to take SimpleRange.

platform/ios/DragImageIOS.mm:

(WebCore::createDragImageForRange): Take SimpleRange.

platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeRangeToDataObject): Take SimpleRange.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.

rendering/RenderObject.cpp:

(WebCore::intervalsSufficientlyOverlap): Added. Moved from Range. Mostly unchanged
but uses SimpleRange now instead of a live range, and intersectingNodes instead of
a loop using firstNode and pastLastNode.
(WebCore::adjustLineHeightOfSelectionRects): Ditto.
(WebCore::coalesceSelectionRects): Ditto.
(WebCore::RenderObject::collectSelectionRectsWithoutUnionInteriorLines): Ditto.
(WebCore::RenderObject::collectSelectionRectsInternal): Ditto.
(WebCore::RenderObject::collectSelectionRects): Ditto.

rendering/RenderObject.h: Update for above.

testing/Internals.cpp:

(WebCore::Internals::markerRangeForNode): Use makeSimplRange.
(WebCore::Internals::locationFromRange): Ditto.
(WebCore::Internals::lengthFromRange): Ditto.
(WebCore::Internals::rangeAsTextUsingBackwardsTextIterator): Ditto.
(WebCore::Internals::subrange): Ditto.
(WebCore::Internals::rangeOfStringNearLocation): Ditto.
(WebCore::Internals::textIndicatorForRange): Ditto.

Source/WebKit:

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:

(-[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]): Use makeSimpleRange.

WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(API::PageOverlayClientImpl::actionContextForResultAtPoint): Ditto.

WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange textRects]): Ditto.

WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:

(-[WKDOMTextIterator initWithRange:]): Ditto.

WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage): Ditto.

WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Remove createLiveRange.
(WebKit::WebPage::performDictionaryLookupForSelection): Ditto.

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll): Ditto.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPlatformEditorState const): Ditto.
(WebKit::WebPage::computeAndSendEditDragSnapshot): Ditto.
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Ditto.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Ditto.
(WebKit::WebPage::requestAutocorrectionData): Ditto.

Source/WebKitLegacy/ios:

WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame selectionRectsForCoreRange:]): Remove createLiveRange.
(-[WebFrame selectionRectsForRange:]): Use makeSimpleRange.

WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Ditto.
(-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
(+[DOMRange rangeForFirstPosition:second:]): Rename firstVP/secondVP
to firstPosition/secondPosition.

Source/WebKitLegacy/mac:

DOM/DOM.mm:

(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
Use makeSimpleRange.
(-[DOMRange textRects]): Ditto.

DOM/DOMDocument.mm: Update includes.
DOM/DOMRange.mm: Ditto.
DOM/DOMRangeInternal.h: Ditto.
DOM/DOMUIKitExtensions.mm: Ditto.
DOM/DOMUtility.mm: Ditto.

DOM/WebDOMOperations.mm:

(-[DOMRange webArchive]): Use makeSimpleRange.
(-[DOMRange markupString]): Ditto.

WebView/WebFrame.mm:

(-[WebFrame _stringForRange:]): Use makeSimpleRange.
(-[WebFrame _convertToDOMRange:]): Return a SimpleRange.
(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]): Ditto.
(-[WebFrame _convertNSRangeToDOMRange:]): Update for above.
(-[WebFrame _convertDOMRangeToNSRange:]): Use makeSimpleRange.
(-[WebFrame _selectNSRange:]): Update for above.
(-[WebFrame selectWithoutClosingTypingNSRange:]): Ditto.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use makeSimpleRange.
(-[WebFrame dictationResultMetadataForRange:]): Ditto.

WebView/WebFrameInternal.h: Update for above.

WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
Use makeSimpleRange.
(-[WebHTMLView attributedSubstringFromRange:]): Use auto.
(-[WebHTMLView _attributedStringFromDOMRange:]): Deleted.
(-[WebHTMLView attributedString]): Rewrote to use SimpleRange consistently.
(-[WebHTMLView selectedAttributedString]): Ditto.

WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _animationControllerForDataDetectedText]):
Use makeSimpleRange.

WebView/WebTextIterator.mm:

(-[WebTextIterator initWithRange:]): Ditto.

WebView/WebView.mm:

(-[WebView _didConcludeEditDrag]): Remove createLiveRange.

4:05 PM Changeset in webkit [265189] by ysuzuki@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix CLoop build
https://bugs.webkit.org/show_bug.cgi?id=215010

tools/SigillCrashAnalyzer.cpp:

1:49 PM Changeset in webkit [265188] by Wenson Hsieh

4 edits in trunk

Table data is incorrectly translated in some articles on en.wikipedia.org
https://bugs.webkit.org/show_bug.cgi?id=215071
<rdar://problem/66354013>

Reviewed by Darin Adler.

Source/WebCore:

Text in table cells sometimes end up in adjacent cells after translation, since adjacent cells are currently
extracted as different tokens in a single item; mitigate this by splitting text in table cells into different
text manipulation items instead.

Test: TextManipulation.StartTextManipulationExtractsTableCellsAsSeparateItems

editing/TextManipulationController.cpp:

(WebCore::isEnclosingItemBoundaryElement):

Tools:

Add a new API test to exercise the change.

TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

8:12 AM Changeset in webkit [265187] by Darin Adler

9 edits
1 add
52 deletes in trunk

Write a script to find duplicate files and delete some duplicate tests in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=215073

Reviewed by Anders Carlsson.

Tools:

Scripts/find-duplicate-files: Added. Basic script that uses MD5 digests

to find duplicate files.

Scripts/report-non-inclusive-language: Tweaked a tiny bit; use a variable.

LayoutTests:

TestExpectations: Removed expectations for removed tests.

css2.1/20110323/abspos-containing-block-initial-004d.htm.1: Removed.

The above was just a stray copy of a test with the wrong extension, so ignored.

css3/font-variant-petite-caps-synthesis-coverage-expected.html: Removed.
css3/font-variant-petite-caps-synthesis-coverage.html: Removed.
css3/font-variant-small-caps-synthesis-coverage-expected.html: Removed.
css3/font-variant-small-caps-synthesis-coverage.html: Removed.

These are duplicates of the same tests without the suffix "coverage".

fast/dom/Document/document-close-iframe-load-expected.txt: Removed.
fast/dom/Document/document-close-iframe-load.html: Removed.
fast/dom/Document/document-close-nested-iframe-load-expected.txt: Removed.
fast/dom/Document/document-close-nested-iframe-load.html: Removed.

These tests are also in the directory "fast/parser". Chose to delete this copy.

fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Removed.
fast/forms/label/labels-set-htmlFor-attribute.html: Removed.

This test also exists under the name "labels-change-...".

fast/loader/unload-form-about-blank-expected.txt: Removed.
fast/loader/unload-form-about-blank.html: Removed.

This test also exists under the name "unload-form-post-about-blank...".

fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
fast/ruby/before-table-doesnt-crash.html: Removed.

This is just a copy of the test "before-block-...", not a separate test.

http/tests/misc/submit-post-in-utf16be.html:

Used the iconv tool to turn this into a UTF-16BE input file so it tests
what it is intended to test. Before this was a UTF-16LE file.

imported/blink/001-a-expected.html: Removed.
imported/blink/001-a.html: Removed.
imported/blink/001-q-expected.html: Removed.
imported/blink/001-q.html: Removed.
imported/blink/001-s-expected.html: Removed.
imported/blink/001-s.html: Removed.

These are identical duplicates of tests that are in WPT.

imported/blink/animations/animation-events-prefixed-04-expected.txt: Removed.
imported/blink/animations/animation-events-prefixed-04.html: Removed.
imported/blink/animations/animation-events-unprefixed-04-expected.txt: Removed.
imported/blink/animations/animation-events-unprefixed-04.html: Removed.

These are duplicates of tests in the directory imported/blink/virtual/stable/animations-unprefixed.

imported/blink/css3/flexbox/relpos-with-scrollable-with-abspos-crash-expected.txt: Removed.
imported/blink/css3/flexbox/relpos-with-scrollable-with-abspos-crash.html: Removed.
imported/blink/fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt: Removed.
imported/blink/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html: Removed.
imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes-expected.html: Removed.
imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes.html: Removed.
imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran-expected.txt: Removed.
imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran.html: Removed.
imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started-expected.txt: Removed.
imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started.html: Removed.
imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase-expected.txt: Removed.
imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase.html: Removed.
imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-expected.txt: Removed.
imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive.html: Removed.
imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase-expected.txt: Removed.
imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase.html: Removed.
imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-expected.txt: Removed.
imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code.html: Removed.

These are identical duplicates of tests in the same named directories outside "imported/blink".
Maybe imported by Blink from WebKit and then back?

imported/blink/img_border_percent-expected.xhtml: Removed.
imported/blink/img_border_percent.xhtml: Removed.
imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-default-expected.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-default.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-zero-expected.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-zero.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-default-expected.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-default.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-zero-expected.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-zero.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/figure-expected.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/figure.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-layout-expected.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-layout.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-width-150percent-expected.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-width-150percent.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/replaced-elements/images/space-expected.html: Removed.
imported/blink/imported/web-platform-tests/html/rendering/replaced-elements/images/space.html: Removed.
imported/blink/object_border_perc-expected.xhtml: Removed.
imported/blink/object_border_perc.xhtml: Removed.
imported/blink/object_border_pixel-expected.xhtml: Removed.
imported/blink/object_border_pixel.xhtml: Removed.

These are identical duplicates of tests that are in WPT.

platform/gtk/TestExpectations: Removed expectations for removed tests.
platform/ios/TestExpectations: Ditto.
platform/win/TestExpectations: Ditto.
platform/wpe/TestExpectations: Ditto.

svg/dom/SVGLengthList-removeItem-expected.txt: Removed.
svg/dom/SVGLengthList-removeItem.xhtml: Removed.

This was a duplicate of the SVGLengthList-addItem test.

1:22 AM Changeset in webkit [265186] by commit-queue@webkit.org

16 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r265151.
https://bugs.webkit.org/show_bug.cgi?id=215074

Broke ARM64E JSC tests

Reverted changeset:

"validate untagArrayPtr"
https://bugs.webkit.org/show_bug.cgi?id=214953
https://trac.webkit.org/changeset/265151

Aug 1, 2020:

11:21 PM Changeset in webkit [265185] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Remove superfluous ResourceTiming constructor overload
https://bugs.webkit.org/show_bug.cgi?id=215063

Patch by Rob Buis <rbuis@igalia.com> on 2020-08-01
Reviewed by Sam Weinig.

Remove superfluous ResourceTiming constructor overload, we
can just call another overload from ResourceTiming::fromLoad.

loader/ResourceTiming.cpp:

(WebCore::ResourceTiming::fromLoad):

loader/ResourceTiming.h:

8:19 PM Changeset in webkit [265184] by Darin Adler

2 edits in trunk/LayoutTests

Remove test expectation for a WPT test that was removed
https://bugs.webkit.org/show_bug.cgi?id=215066
rdar://42904780

Reviewed by Sam Weinig.

platform/mac-wk1/TestExpectations: Removed failure expectation for

a WPT WebCryptoAPI test that no longer exists.

7:53 PM Changeset in webkit [265183] by beidson@apple.com

11 edits
1 copy
3 adds in trunk

Special HID mapping for the Logitech F310/F710 controllers.
https://bugs.webkit.org/show_bug.cgi?id=215050

Reviewed by Tim Horton.

Source/WebCore:

Covered by API test.

These two controllers match the standard mapping perfectly. Easy to support.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:

platform/gamepad/KnownGamepads.h:

platform/gamepad/mac/GamepadConstantsMac.h:

platform/gamepad/mac/HIDGamepad.cpp:

(WebCore::HIDGamepad::create):

platform/gamepad/mac/HIDGamepadElement.cpp:

(WebCore::HIDGamepadElement::HIDGamepadElement):

platform/gamepad/mac/HIDGamepadElement.h:

(WebCore::HIDGamepadElement::isAxis const):

platform/gamepad/mac/LogitechGamepad.cpp: Added.

(WebCore::LogitechGamepadHatswitch::gamepadValueChanged):
(WebCore::LogitechGamepad::LogitechGamepad):

platform/gamepad/mac/LogitechGamepad.h:

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

TestWebKitAPI/Tests/mac/HIDGamepads.mm:

TestWebKitAPI/mac/GamepadMappings/LogitechF310.mm: Added.

(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::logitechF310Mapping):

TestWebKitAPI/mac/GamepadMappings/LogitechF710.mm: Added.

(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::logitechF710Mapping):

TestWebKitAPI/mac/VirtualGamepad.h:

6:50 PM Changeset in webkit [265182] by jh718.park@samsung.com

2 edits in trunk/Source/WebCore

Unreviewed. Remove the build warnings below since r265150.
warning: unused parameter ‘foo’ [-Wunused-parameter]

No new tests, no new behaviors.

workers/service/server/SWServerJobQueue.cpp:

(WebCore::doCertificatesMatch):

6:18 PM Changeset in webkit [265181] by Darin Adler

3 edits in trunk/Source/WebKit

Fix and further refine makefile rule for WebKit messages generated files
https://bugs.webkit.org/show_bug.cgi?id=215064

Reviewed by Sam Weinig.

DerivedSources-output.xcfilelist: Updated for a file that was omitted

because of a typo in the makefile.

DerivedSources.make: Fix "addsufix" typo and reorganized things a bit.

3:55 PM Changeset in webkit [265180] by beidson@apple.com

13 edits
1 copy
2 adds in trunk

Special HID mapping for the Google Stadia controller
https://bugs.webkit.org/show_bug.cgi?id=215061

Reviewed by Tim Horton.

Source/WebCore:

New API test coverage.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/gamepad/GamepadConstants.h:
platform/gamepad/KnownGamepads.h:
platform/gamepad/mac/GamepadConstantsMac.h:

platform/gamepad/mac/HIDGamepad.cpp:

(WebCore::HIDGamepad::create):

platform/gamepad/mac/HIDGamepadElement.cpp:

(WebCore::HIDGamepadElement::HIDGamepadElement):
(WebCore::HIDGamepadHatswitch::gamepadValueChanged):
(WebCore::HIDGamepadHatswitch::normalizedValue):

platform/gamepad/mac/HIDGamepadElement.h:

(WebCore::HIDGamepadElement::isAxis const):
(WebCore::HIDGamepadHatswitch::HIDGamepadHatswitch):

platform/gamepad/mac/StadiaHIDGamepad.cpp: Added.

(WebCore::StadiaHIDGamepad::StadiaHIDGamepad):

platform/gamepad/mac/StadiaHIDGamepad.h:

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/mac/HIDGamepads.mm:

TestWebKitAPI/mac/GamepadMappings/GoogleStadia.mm: Added.

(TestWebKitAPI::publishReportCallback):

(TestWebKitAPI::VirtualGamepad::googleStadiaMapping):

TestWebKitAPI/mac/VirtualGamepad.h:

2:48 PM Changeset in webkit [265179] by commit-queue@webkit.org

7 edits in trunk/Source

Unreviewed, reverting r265097, r265113, and r265122.
https://bugs.webkit.org/show_bug.cgi?id=215065

Broke AppleSilicon Big Sur

Reverted changesets:

"Strip pointers instead of authing for byteOffset to not allow
for a possible way to guess data pac"
https://bugs.webkit.org/show_bug.cgi?id=214952
https://trac.webkit.org/changeset/265097

"Compute number of PAC bits from what the OS says its address
space is"
https://bugs.webkit.org/show_bug.cgi?id=214986
https://trac.webkit.org/changeset/265113

"Remove UB from nonPACBitsMask computation"
https://bugs.webkit.org/show_bug.cgi?id=214996
https://trac.webkit.org/changeset/265122

10:54 AM Changeset in webkit [265178] by Keith Rollin

2 edits in trunk/Source/WebKit

Prevent multiple invocations of generate-message-receiver.py
https://bugs.webkit.org/show_bug.cgi?id=215054

Reviewed by Darin Adler.

WebKit/DerivedSources.make is written such that
generate-message-receiver.py can be invoked N times, where N is the
value passed to -j. This results in the N invocations of
generate-message-receiver.py trying trying to generate the same set of
files at the same time, possibly leading to their being corrupted. We
have reports of generated files starting with a 4K block of NULs, and
this contention may be causing it. Address this by using a "pattern
rule" in the makefile, which is documented in GNU make's documentation
as the approach to take when there is one build rule that creates
multiple outputs, as is the case here.

See also <https://bugs.webkit.org/show_bug.cgi?id=166814> and
<http://trac.webkit.org/changeset/210507>.

No new tests -- no new or changed functionality.

DerivedSources.make:

10:51 AM Changeset in webkit [265177] by weinig@apple.com

3 edits in trunk/Source/WebCore

Convert LinkHeader to use StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=215017

Reviewed by Darin Adler.

Update LinkHeader parsing to use StringParsingBuffer and do some light cleanup.

loader/LinkHeader.cpp:

(WebCore::isSpaceOrTab):
(WebCore::isNotURLTerminatingChar):
(WebCore::isValidParameterNameChar):
(WebCore::isParameterValueEnd):
(WebCore::isParameterValueChar):
(WebCore::findURLBoundaries):
(WebCore::invalidParameterDelimiter):
(WebCore::validFieldEnd):
(WebCore::parseParameterDelimiter):
(WebCore::paramterNameFromString):
(WebCore::parseParameterName):
(WebCore::skipQuotesIfNeeded):
(WebCore::parseParameterValue):
(WebCore::findNextHeader):
(WebCore::LinkHeader::LinkHeader):
(WebCore::LinkHeaderSet::LinkHeaderSet):
(WebCore::LinkHeaderSet::init): Deleted.

loader/LinkHeader.h:

8:50 AM Changeset in webkit [265176] by Darin Adler

64 edits in trunk/Source

Remove Range::create and many more uses of live ranges
https://bugs.webkit.org/show_bug.cgi?id=215004

Reviewed by Sam Weinig.

Source/WebCore:

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange const):
Use makeSimpleRange.

accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Use SimpleRange.

accessibility/atk/WebKitAccessibleHyperlink.cpp:

(rangeLengthForObject): Take SimpleRange.
(webkitAccessibleHyperlinkGetStartIndex): Use makeSimpleRange.
(webkitAccessibleHyperlinkGetEndIndex): Ditto.

accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject): Ditto.

accessibility/atk/WebKitAccessibleUtil.cpp:

(objectFocusedAndCaretOffsetUnignored): Ditto.

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(+[WebAccessibilityTextMarker startOrEndTextMarkerForRange:isStart:cache:]):
Take SimpleRange.
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
Use makeSimpleRange.
(-[WebAccessibilityObjectWrapper _convertToDOMRange:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textMarkerRange]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textMarkerForPosition:]): Use auto.
(-[WebAccessibilityObjectWrapper misspellingTextMarkerRange:forward:]):
Remove createLiveRange.
(-[WebAccessibilityObjectWrapper rangeFromMarkers:withText:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textRectsFromMarkers:withText:]): Add createLiveRange.
(-[WebAccessibilityObjectWrapper rangeForTextMarkers:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForTextMarkers:isStart:]):
Use auto.
(-[WebAccessibilityObjectWrapper textMarkerRangeForMarkers:]): Get rid of local.
(-[WebAccessibilityObjectWrapper textMarkersForRange:]): Take SimpleRange.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilityTextOperationForParameterizedAttribute): Remove makeSimpleRange.
(accessibilityMisspellingSearchCriteriaForParameterizedAttribute): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textMarkerRangeFromRange:]): Take SimpleRange.
(textMarkerRangeFromRange): Ditto.
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForRange:isStart:]): Ditto.
(startOrEndTextmarkerForRange): Return SimpleRange.
(-[WebAccessibilityObjectWrapper rangeForTextMarkerRange:]): Ditto.
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
Use auto.
(-[WebAccessibilityObjectWrapper doAXAttributedStringForRange:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textMarkerRangeAtTextMarker:forUnit:]): Ditto.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): Ditto.

dom/DocumentMarkerController.cpp:

(WebCore::updateRenderedRectsForMarker): Use document marker range function.
(WebCore::range): Added.

dom/DocumentMarkerController.h: Update for above.

dom/Position.cpp: Removed unneeded Range.h include.

dom/Range.cpp:

(WebCore::Range::Range): Removed unused overload that takes start/end.
(WebCore::Range::create): Removed overloads that take start/end.
(WebCore::Range::setStart): Removed overload that takes Position.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::cloneRange const): Rewrote to use setStart/End since
that's what the constructor used to do.
(WebCore::Range::contains const): Use SimpleRange/createLiveRange
instead of makeRange. Soon this function will be deleted.
(WebCore::rangeOfContents): Deleted.
(WebCore::createLiveRange): Rewrote to use setStart/End since that's
what the constructor used to do.

dom/Range.h: Update for above removals.

dom/SimpleRange.h: Export commonInclusiveAncestor for use outside WebCore.

dom/StaticRange.cpp:

(WebCore::StaticRange::create): Added overload that copies the SimpleRange.

dom/StaticRange.h: Update for above.

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord): Use document
marker range function.

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Use makeSimpleRange.

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs): Ditto.
(WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
Ditto.

editing/EditingStyle.cpp:

(WebCore::EditingStyle::textDirectionForSelection): Use makeSimpleRange and
intersectingNodes.

editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment): Use makeRangeSelectingNodeContents.
(WebCore::Editor::updateMarkersForWordsAffectedByEditing): Use makeSimpleRange.
(WebCore::Editor::transpose): Ditto.
(WebCore::Editor::rangeOfString): Use makeRangeSelectingNodeContents.
(WebCore::Editor::handleAcceptedCandidate): Update since rangeForTextCheckingResult
now returns an Optional<SimpleRange>.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectRangeOnElement): Use SimpleRange.

editing/ReplaceRangeWithTextCommand.cpp:

(WebCore::ReplaceRangeWithTextCommand::ReplaceRangeWithTextCommand): Take
SimpleRange.
(WebCore::ReplaceRangeWithTextCommand::willApplyCommand): Update since
m_rangeToBeReplaced is a SimpleRange.
(WebCore::ReplaceRangeWithTextCommand::doApply): Ditto.
(WebCore::ReplaceRangeWithTextCommand::targetRanges const): Ditto.

editing/ReplaceRangeWithTextCommand.h: Update for above.

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::insertedContentRange const):
Return a SimpleRange.

editing/ReplaceSelectionCommand.h: Update for above.

editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand):
Take a SimpleRange.
(WebCore::SpellingCorrectionCommand::create): Moved here from header.

editing/SpellingCorrectionCommand.h: Update for above.

editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstMisspelledWordOrUngrammaticalPhrase const):
Use makeSimpleRange.

editing/TypingCommand.cpp:

(WebCore::TypingCommand::markMisspellingsAfterTyping): Use makeSimpleRange.
(WebCore::TypingCommand::willAddTypingToOpenCommand): Take SimpleRange.
(WebCore::TypingCommand::deleteKeyPressed): Remove createLiveRange.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

editing/TypingCommand.h: Update for above.

editing/VisiblePosition.cpp:

(WebCore::makeRange): Deleted.
(WebCore::startVisiblePosition): Deleted.
(WebCore::endVisiblePosition): Deleted.
(WebCore::setStart): Deleted.
(WebCore::setEnd): Deleted.

editing/VisiblePosition.h: Update for above. Also export makeSimpleRange

for use outside WebCore.

editing/VisibleUnits.cpp:

(WebCore::suffixLengthForRange): Take SimpleRange.
(WebCore::prefixLengthForRange): Ditto.
(WebCore::previousBoundary): Use makeSimpleRange.
(WebCore::nextBoundary): Ditto.

editing/VisibleUnits.h: Update for above.

editing/cocoa/DataDetection.mm:

(WebCore::buildQuery): Remove unused local variable.

editing/ios/EditorIOS.mm:

(WebCore::Editor::setDictationPhrasesAsChildOfElement): Use makeRangeSelectingNodeContents.

page/DOMSelection.cpp:

(WebCore::DOMSelection::getRangeAt): Use createLiveRange.

page/DragController.cpp:

(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret): Remove makeSimpleRange.

page/Frame.cpp:

(WebCore::Frame::rangeForPoint): Return SimpleRange.

page/Frame.h: Update for above.

page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot const): Use makeRangeSelectingNodeContents,
intersectingNodes, and makeSimpleRange.

testing/Internals.cpp:

(WebCore::Internals::markerRangeForNode): Use createLiveRange and the document
marker range function.

Source/WebKit:

WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(API::PageOverlayClientImpl::actionContextForResultAtPoint): Return a
structure that includes a SimpleRange.

WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::visibleRange): Use makeSimpleRange.

WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h: Use SimpleRange.
WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

(WebKit::TextCheckingControllerProxy::rangeAndOffsetRelativeToSelection): Use SimpleRange.
(WebKit::TextCheckingControllerProxy::replaceRelativeToSelection): Ditto.
(WebKit::TextCheckingControllerProxy::removeAnnotationRelativeToSelection): Ditto.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::characterIndexForPointAsync): Remove makeSimpleRange.
(WebKit::WebPage::deleteSurrounding): Use makeSimpleRange.

WebProcess/WebPage/WebPageOverlay.cpp:

(WebKit::WebPageOverlay::actionContextForResultAtPoint): Use return value instead of out argument.

WebProcess/WebPage/WebPageOverlay.h: Update for above.

WebProcess/WebPage/glib/WebPageGLib.cpp:

(WebKit::WebPage::getPlatformEditorState const): Use makeSimpleRange.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::computeEditableRootHasContentAndPlainText): Use makeSimpleRange.
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Removed unneeded null checks that
are already done by makeSimpleRange.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Use makeSimpleRange.
(WebKit::WebPage::requestDictationContext): Ditto.
(WebKit::WebPage::autocorrectionContext): Ditto.
(WebKit::linkIndicatorPositionInformation): Use makeRangeSelectingNodeContents.
(WebKit::dataDetectorLinkPositionInformation): Ditto.
(WebKit::WebPage::requestDocumentEditingContext): Use makeSimpleRange.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performImmediateActionHitTestAtLocation): Update for change to the
actionContextForResultAtPoint return value.

Source/WebKitLegacy/ios:

WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame wordAtPoint:]): Use makeSimpleRange.

WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Use document
marker range function.
(-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
(+[DOMRange rangeForFirstPosition:second:]): Use makeSimpleRange.

Source/WebKitLegacy/mac:

DOM/DOMUIKitExtensions.mm:

(-[DOMNode rangeOfContainingParagraph]): Use makeSimpleRange.

WebView/WebFrame.mm:

(-[WebFrame _characterRangeAtPoint:]): Update since rangeAtPoint takes a SimpleRange.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use document marker range function.

WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _defaultAnimationController]): Use makeRangeSelectingNodeContents.
(-[WebImmediateActionController _animationControllerForDataDetectedLink]): Ditto.

Source/WebKitLegacy/win:

AccessibleTextImpl.cpp:

(AccessibleText::scrollSubstringTo): Use makeSimpleRange.

6:40 AM Changeset in webkit [265175] by commit-queue@webkit.org

11 edits in trunk/Source/WebKit

Unreviewed, reverting r265171.
https://bugs.webkit.org/show_bug.cgi?id=215060

broke 2 mac api tests

Reverted changeset:

"[Mac] Add Experimental Feature preference for SW VP9"
https://bugs.webkit.org/show_bug.cgi?id=215043
https://trac.webkit.org/changeset/265171

1:02 AM Changeset in webkit [265174] by Megan Gardner

2 edits in trunk/Source/WebKit

Unable to select multiple lines of vertical text correctly
https://bugs.webkit.org/show_bug.cgi?id=213671
<rdar://problem/53753636>

Reviewed by Darin Adler.

In order to make for a better text selection experience, we pulled the selection position
down to be on the last line selectable, rather than snap the selection to a single position.
This made for a better selection experience on small text, but we failed to take
vertical text into account, and a user is locked into only selecting vertical text that ends below the
other anchor point of the selection. We should have the same behavior for vertical text, but correctly
calculated for X instead of Y.
This does not fix all cases, but it fixes the most glaring cases.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeForPointInRootViewCoordinates):

Jul 31, 2020:

11:09 PM Changeset in webkit [265173] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[Mac] AudioSessionRoutingArbitrator causes a launch time regression checking for CoreAudio muted state
https://bugs.webkit.org/show_bug.cgi?id=214993

Reviewed by Eric Carlson.

The initial query of isMuted() is only there to tell whether, when we get a notification that the mute state
changed, whether our internal state is dirty and we need to fire a notification. Instead, replace the bool member
with an Optional<bool>, so we know we need to fire a changed notification whenever the first mute state change
comes in.

platform/audio/mac/AudioSessionMac.mm:

(WebCore::AudioSession::AudioSession):
(WebCore::AudioSession::handleMutedStateChange):
(WebCore::AudioSessionPrivate::AudioSessionPrivate): Deleted.

10:57 PM Changeset in webkit [265172] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Unreviewed Windows build fix after r265167; add some missing includes.

page/Screen.cpp:

6:29 PM Changeset in webkit [265171] by jer.noble@apple.com

11 edits in trunk/Source/WebKit

[Mac] Add Experimental Feature preference for SW VP9
https://bugs.webkit.org/show_bug.cgi?id=215043
<rdar://problem/66400034>

Reviewed by Beth Dakin.

FeatureFlags/WebKit.plist:
Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):

Shared/WebPageCreationParameters.h:
Shared/WebPreferences.yaml:
Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultVP9SWDecoderEnabledOnBattery):

Shared/WebPreferencesDefaultValues.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::enableVP9Decoder):
(WebKit::WebProcess::enableVP9SWDecoder):

WebProcess/WebProcess.h:

5:36 PM Changeset in webkit [265170] by mmaxfield@apple.com

9 edits in trunk/Source/WebCore

Clean up text layout code a bit
https://bugs.webkit.org/show_bug.cgi?id=215013

Reviewed by Zalan Bujtas.

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769.

See file-specific ChangeLog entries for more information.

No tests because there is no behavior change.

platform/graphics/Font.h: Remove unnecessary declaration.
platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::layoutText const): Rename glyphBufferForTextRun() to layoutText().
Also, make it return a GlyphBuffer instead of taking a GlyphBuffer as an out param.
Its previous return, the initial advance, is now returned in GlyphBuffer::initialAdvance.
(WebCore::FontCascade::drawText const): Update to new signature of layoutText().
(WebCore::FontCascade::drawEmphasisMarks const): Inline drawEmphasisMarksForSimpleText()
and drawEmphasisMarksForComplexText(), since they're nearly identical. Update to the new
signature of layoutText().
(WebCore::FontCascade::displayListForTextRun const): Update to the new signature of
layoutText().
(WebCore::FontCascade::layoutSimpleText const): Make this return a new GlyphBuffer, instead
of taking one as an out param. Also, use accessors of WidthIterator instead of reaching
into its guts. The previous return value is now returned in GlyphBuffer::initialAdvance.
(WebCore::FontCascade::layoutComplexText const): Ditto.
(WebCore::FontCascade::floatWidthForSimpleText const): Use accessors of WidthIterator
instead of reaching into its guts.
(WebCore::FontCascade::adjustSelectionRectForSimpleText const): Ditto.
(WebCore::FontCascade::offsetForPositionForSimpleText const): Ditto.
(WebCore::FontCascade::dashesForIntersectionsWithRect const): Same as
FontCascade::drawEmphasisMarks() above.
(WebCore::FontCascade::glyphBufferForTextRun const): Renamed to layoutText().
(WebCore::FontCascade::getGlyphsAndAdvancesForSimpleText const): Renamed to
layoutSimpleText().
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText const): Renamed to
layoutComplexText().
(WebCore::FontCascade::drawEmphasisMarksForSimpleText const): Inlined into
drawEmphasisMarks().
(WebCore::FontCascade::drawEmphasisMarksForComplexText const): Ditto.

platform/graphics/FontCascade.h:
platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBufferAdvance::GlyphBufferAdvance):
(WebCore::GlyphBufferAdvance::operator FloatSize):

platform/graphics/TextRun.h: Remove unnecessary declaration.
platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Update for changes to WidthIterator.h

platform/graphics/WidthIterator.h: Rearrange the class members to sort them by size,

to get better packing. Also, make all member variables private, and initialize them
all with { } syntax.
(WebCore::WidthIterator::finalRoundingWidth const):
(WebCore::WidthIterator::currentCharacter const):

rendering/svg/SVGTextMetrics.cpp: Remove unnecessary include.

5:30 PM Changeset in webkit [265169] by commit-queue@webkit.org

22 edits
20 moves in trunk

Use more inclusive terminology in Tools
https://bugs.webkit.org/show_bug.cgi?id=214971

Patch by Alex Christensen <achristensen@webkit.org> on 2020-07-31
Reviewed by Sam Weinig.

Source/WebKitLegacy/win:

Interfaces/IWebViewPrivate.idl:

Rename some test-only API. This should not affect binary compatibility because everything is in the same locations, and the changed API is only used for tests.

WebView.h:
WebView.cpp:

Tools:

DumpRenderTree/TestRunner.cpp:

(addOriginAccessAllowListEntryCallback):
(removeOriginAccessAllowListEntryCallback):
(TestRunner::staticFunctions):
(addOriginAccessWhitelistEntryCallback): Deleted.
(removeOriginAccessWhitelistEntryCallback): Deleted.

DumpRenderTree/TestRunner.h:
DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::addOriginAccessAllowListEntry):
(TestRunner::removeOriginAccessAllowListEntry):
(TestRunner::addOriginAccessWhitelistEntry): Deleted.
(TestRunner::removeOriginAccessWhitelistEntry): Deleted.

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

DumpRenderTree/win/TestRunnerWin.cpp:

TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:

(removeOldInjectedContentAndResetLists):
(testUserContentManagerInjectedStyleSheet):
(testUserContentManagerInjectedScript):
(testUserContentManagerContentFilter):

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::addOriginAccessAllowListEntry):
(WTR::TestRunner::removeOriginAccessAllowListEntry):
(WTR::TestRunner::addOriginAccessWhitelistEntry): Deleted.
(WTR::TestRunner::removeOriginAccessWhitelistEntry): Deleted.

WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

http/tests/security/contentSecurityPolicy/report-blocked-file-uri.php:
http/tests/security/contentSecurityPolicy/xsl-redirect-allowed.html:
http/tests/security/contentSecurityPolicy/xsl-redirect-allowed2.html:
http/tests/security/contentSecurityPolicy/xsl-redirect-blocked.html:
http/tests/security/isolatedWorld/cross-origin-xhr.html:
http/tests/security/local-image-from-remote-allow-list-expected.txt: Copied from http/tests/security/local-image-from-remote-whitelisted-expected.txt.
http/tests/security/local-image-from-remote-allow-list.html: Copied from http/tests/security/local-image-from-remote-whitelisted.html.
http/tests/security/local-image-from-remote-whitelisted-expected.txt: Removed.
http/tests/security/local-image-from-remote-whitelisted.html: Removed.
http/tests/xmlhttprequest/access-control-basic-allow-list-request-headers-expected.txt: Copied from http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers-expected.txt.
http/tests/xmlhttprequest/access-control-basic-allow-list-request-headers.html: Copied from http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html.
http/tests/xmlhttprequest/access-control-basic-allow-list-response-headers-expected.txt: Copied from http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt.
http/tests/xmlhttprequest/access-control-basic-allow-list-response-headers.html: Copied from http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers.html.
http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers-expected.txt: Removed.
http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html: Removed.
http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt: Removed.
http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers.html: Removed.
http/tests/xmlhttprequest/origin-allow-list-all-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-all-expected.txt.
http/tests/xmlhttprequest/origin-allow-list-all.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-all.html.
http/tests/xmlhttprequest/origin-allow-list-exact-match-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-exact-match-expected.txt.
http/tests/xmlhttprequest/origin-allow-list-exact-match.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-exact-match.html.
http/tests/xmlhttprequest/origin-allow-list-https-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt.
http/tests/xmlhttprequest/origin-allow-list-https.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-https.html.
http/tests/xmlhttprequest/origin-allow-list-ip-addresses-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-expected.txt.
http/tests/xmlhttprequest/origin-allow-list-ip-addresses-with-subdomains-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt.
http/tests/xmlhttprequest/origin-allow-list-ip-addresses-with-subdomains.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html.
http/tests/xmlhttprequest/origin-allow-list-ip-addresses.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html.
http/tests/xmlhttprequest/origin-allow-list-removal-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt.
http/tests/xmlhttprequest/origin-allow-list-removal.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-removal.html.
http/tests/xmlhttprequest/origin-allow-list-subdomains-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-subdomains-expected.txt.
http/tests/xmlhttprequest/origin-allow-list-subdomains.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-subdomains.html.
http/tests/xmlhttprequest/origin-whitelisting-all-expected.txt: Removed.
http/tests/xmlhttprequest/origin-whitelisting-all.html: Removed.
http/tests/xmlhttprequest/origin-whitelisting-exact-match-expected.txt: Removed.
http/tests/xmlhttprequest/origin-whitelisting-exact-match.html: Removed.
http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt: Removed.
http/tests/xmlhttprequest/origin-whitelisting-https.html: Removed.
http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-expected.txt: Removed.
http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt: Removed.
http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html: Removed.
http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html: Removed.
http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt: Removed.
http/tests/xmlhttprequest/origin-whitelisting-removal.html: Removed.
http/tests/xmlhttprequest/origin-whitelisting-subdomains-expected.txt: Removed.
http/tests/xmlhttprequest/origin-whitelisting-subdomains.html: Removed.
platform/win/TestExpectations:
platform/wk2/TestExpectations:

4:41 PM Changeset in webkit [265168] by Chris Dumez

14 edits
2 copies
2 adds in trunk

Add OfflineAudioCompletionEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=214994

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

web-platform-tests/webaudio/idlharness.https.window-expected.txt:

Source/WebCore:

Add OfflineAudioCompletionEvent constructor, as per:

https://www.w3.org/TR/webaudio/#OfflineAudioCompletionEvent

Test: webaudio/OfflineAudioCompletionEvent-constructor.html

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::finishedRendering):

Modules/webaudio/OfflineAudioCompletionEvent.cpp:

(WebCore::OfflineAudioCompletionEvent::create):
(WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent):

Modules/webaudio/OfflineAudioCompletionEvent.h:
Modules/webaudio/OfflineAudioCompletionEvent.idl:
Modules/webaudio/OfflineAudioCompletionEventInit.h: Copied from Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.idl.
Modules/webaudio/OfflineAudioCompletionEventInit.idl: Copied from Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.idl.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add layout test coverage.

webaudio/OfflineAudioCompletionEvent-constructor-expected.txt: Added.
webaudio/OfflineAudioCompletionEvent-constructor.html: Added.

4:40 PM Changeset in webkit [265167] by jer.noble@apple.com

13 edits
2 adds in trunk

[Mac] YouTube does not offer HDR variants to devices which support HDR
https://bugs.webkit.org/show_bug.cgi?id=215022

Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/mac/media/media-source/is-type-supported-vp9-codec-check.html

There are three separate issues which block YouTube from offering HDR:

1) YouTube checks both valid and invalid VP9 strings through MediaSource.isTypeSupported(), and UAs

which answer true to even invalid VP9 strings are blocked from HDR. To solve this, we will now
send isTypeSupported() through the same code path as Media Capabilities.

2) YouTube's standard valid and invalid VP9 strings do not include the fullRangeVideoFlag field, which

would normally be tossed as invalid. We shouldn't relax our requirements globally, so we will
add a Quirk which relaxes the requriement that VP9 strings contain a fullRangeVideoFlag.

3) YouTube's HDR query checks that window.screen.pixelDepth is > 24. We obviously don't want to change

the value of this field globally, so we will add separate Quirk which sets window.screen.pixelDepth
to 25 (a totally nonsensical value) when HDR is available.

Each of these Quirks has a path towards removal for YouTube. The fullRangeVideoFlag field involves
YouTube updating their compatibility check to inculde the fullRangeVideoFlag. The pixelDepth check
can be replaced by the dynamic-range:high Media Query.

Modules/mediasource/MediaSource.cpp:

(WebCore::addVP9FullRangeVideoFlagToContentType):
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::removeSourceBuffer):
(WebCore::MediaSource::isTypeSupported):
(WebCore::MediaSource::onReadyStateChange):
(WebCore::MediaSource::activeRanges const):

Modules/mediasource/MediaSource.h:
page/Quirks.cpp:

(WebCore::Quirks::needsVP9FullRangeFlagQuirk const):
(WebCore::Quirks::needsHDRPixelDepthQuirk const):

page/Quirks.h:
page/Screen.cpp:

(WebCore::Screen::pixelDepth const):

platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::SourceBufferParserWebM::isContentTypeSupported):

platform/graphics/cocoa/VP9UtilitiesCocoa.h:
platform/graphics/cocoa/VP9UtilitiesCocoa.mm:

(WebCore::isVPCodecConfigurationRecordSupported):
(WebCore::validateVPParameters):

LayoutTests:

platform/mac/media/media-source/is-type-supported-vp9-codec-check-expected.txt: Added.
platform/mac/media/media-source/is-type-supported-vp9-codec-check.html: Added.
platform/mac/media/mediacapabilities/vp9-decodingInfo-sw-expected.txt:
platform/mac/media/mediacapabilities/vp9-decodingInfo-sw.html:

4:36 PM Changeset in webkit [265166] by Jonathan Bedard

3 edits in trunk/Tools

[test-webkitpy] Have CI use verbose logging
https://bugs.webkit.org/show_bug.cgi?id=215019
<rdar://problem/66383986>

Reviewed by Aakash Jain.

BuildSlaveSupport/ews-build/steps.py:

(RunWebKitPyPython2Tests): Add --verbose flag.
(RunWebKitPyPython3Tests): Ditto.

BuildSlaveSupport/ews-build/steps_unittest.py:

(test_success): Add --verbose flag to test-webkitpy command.
(test_unexpected_failure): Ditto.
(test_failure): Ditto.
(test_errors): Ditto.

3:56 PM Changeset in webkit [265165] by Chris Dumez

5 edits in trunk/Source

Add linked-on-after check to keep WebSQL working in UIWebView until apps are rebuilt with iOS 14 SDK
https://bugs.webkit.org/show_bug.cgi?id=215035
<rdar://problem/65003342>

Reviewed by Tim Horton.

Source/WebCore:

platform/RuntimeApplicationChecks.h:
platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isJesusCalling): Deleted.
(WebCore::IOSApplication::isFudget): Deleted.
(WebCore::IOSApplication::isFamilyHealthApp): Deleted.
Drop code that is no longer needed.

Source/WebKitLegacy/mac:

Add linked-on-after check to keep WebSQL working in UIWebView until apps are rebuilt with iOS 14 SDK.

WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

3:50 PM Changeset in webkit [265164] by Truitt Savell

2 edits in trunk/LayoutTests

[ macOS ] imported/w3c/web-platform-tests/css/css-scoping/css-scoping-shadow-dynamic-remove-style-detached.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215039

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-07-31

platform/mac/TestExpectations:

3:23 PM Changeset in webkit [265163] by Chris Dumez

6 edits in trunk/Source/WebKit

Launch time regression due to EndowmentStateTracker initialization in WebPageProxy constructor
https://bugs.webkit.org/show_bug.cgi?id=215029
<rdar://problem/66362333>

Reviewed by Geoffrey Garen.

EndowmentStateTracker was expensive and in a critical code path during MobileSafari app launch. Since
this code is new, this was a net app launch time regression. To address the regression, the following
changes were made:

We only need the EndowmentStateTracker to monitor if the app is user-facing or not, so that we can suspend / resume media playback as needed. As a result, it is unnecessary to start monitoring user-facing state changes as soon as the WebPageProxy is constructed. Instead, we now wait until media plays on the page for the first time.
It turns out that over 70% of CPU time in the EndowmentStateTracker constructor was spent getting the current endownment for the process. As a result, I updated the code to lazy populate those until they are requested for the first time.
The remaining 30% of CPU time in the EndowmentStateTracker constructor was spent constructing the RBSProcessMonitor. I moved the initialization of the RBSProcessMonitor from the constructor to EndowmentStateTracker::addClient() so that we only construct a monitor when we actually have our first client.
All this code was actually only useful for Catalyst app and was therefore doing work on iOS for no reason. I properly #ifdef'd out this code so that it now only applies to Catalyst apps.

UIProcess/EndowmentStateTracker.h:

(WebKit::EndowmentStateTracker::isVisible const):
(WebKit::EndowmentStateTracker::isUserFacing const):

UIProcess/EndowmentStateTracker.mm:

(WebKit::EndowmentStateTracker::stateFromEndowments):
(WebKit::EndowmentStateTracker::registerMonitorIfNecessary):
(WebKit::EndowmentStateTracker::addClient):
(WebKit::EndowmentStateTracker::ensureState const const):
(WebKit::EndowmentStateTracker::setState):
(WebKit::EndowmentStateTracker::EndowmentStateTracker): Deleted.
(WebKit::EndowmentStateTracker::setIsUserFacing): Deleted.
(WebKit::EndowmentStateTracker::setIsVisible): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::m_transcodingQueue):
(WebKit::WebPageProxy::updatePlayingMediaDidChange):

UIProcess/WebPageProxy.h:

3:23 PM Changeset in webkit [265162] by Chris Dumez

6 edits in trunk/Source/WebKit

Drop ProcessAssertion::Client and replace with a simple invalidation handler
https://bugs.webkit.org/show_bug.cgi?id=214976

Reviewed by Brady Eidson.

ProcessAssertion had a Client class with 2 functions:
(1) one to indicate that the assertion was invalidated
(2) one to indicate that the UI assertion is about to expire

While ProcessAssertion is used in several places, only the ProcessThrottler
ever sets itself as a client. The reason is that other call sites use
assertion types that do not expire. Also, (2) only makes sense for
ProcessAndUIAssertion, not for ProcessAssertion. Only the ProcessThrottler
is using a ProcessAndUIAssertion.

I think a better design is to have a simple invalidation handler on
the ProcessAssertion, that the call site can set if they are interested
in invalidation.

Similarly, I added a UIAssertion expiration handler on ProcessAndUIAssertion
so that the ProcessThrottler can know if the UIAssertion is about to expire.

This new design also matches more closely the system process assertion API
that ProcessAssertion / ProcessAndUIAssertion are wrapping.

This patch also fixes a bug found by Youenn Fablet where the ProcessThrottler
would only set its invalidation handler in didConnectToProcess(), instead of
doing it every time a new ProcessAssertion is created in setAssertionType().
The assertion type can change (e.g. from foreground to background) after the
process has launched.

UIProcess/ProcessAssertion.h:

(WebKit::ProcessAssertion::setInvalidationHandler):
(WebKit::ProcessAssertion::Client::~Client): Deleted.
(WebKit::ProcessAssertion::setClient): Deleted.
(WebKit::ProcessAssertion::client): Deleted.

UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::setAssertionType):
(WebKit::ProcessThrottler::didConnectToProcess):

UIProcess/ProcessThrottler.h:
UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::ProcessAssertion::processAssertionWasInvalidated):
(WebKit::ProcessAndUIAssertion::uiAssertionWillExpireImminently):

3:22 PM Changeset in webkit [265161] by Truitt Savell

3 edits in trunk/LayoutTests

[ macOS wk1 iOS wk2 Release ] imported/w3c/web-platform-tests/websockets/cookies/third-party-cookie-accepted.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215033

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-07-31

platform/ios-simulator-wk2/TestExpectations:
platform/mac-wk1/TestExpectations:

3:14 PM Changeset in webkit [265160] by beidson@apple.com

3 edits
2 adds in trunk

Log a warning to the dev console when gamepads are accessed from an insecure context.
https://bugs.webkit.org/show_bug.cgi?id=214995

Reviewed by Tim Horton.

Source/WebCore:

Test: http/tests/misc/gamepads-insecure.html

Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::getGamepads): Insecure contexts should log that getGamepads() will

be going away in a future release. Just do it once, because getGamepads() is called frequently.

LayoutTests:

http/tests/misc/gamepads-insecure-expected.txt: Added.
http/tests/misc/gamepads-insecure.html: Added.

2:02 PM Changeset in webkit [265159] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

Move Options setter to where we allow access to the Options object
https://bugs.webkit.org/show_bug.cgi?id=215028

Reviewed by Saam Barati.

Right now jsc CLI crashes when assertions are enabled on iOS.

jsc.cpp:

(main):
(CommandLine::parseArguments):

1:39 PM Changeset in webkit [265158] by jiewen_tan@apple.com

2 edits in trunk/Source/WebKit

SOAuthorizationSession::dismissViewController could crash on calling WebPageProxy::platformWindow
https://bugs.webkit.org/show_bug.cgi?id=214816
<rdar://problem/65681530>

Reviewed by Youenn Fablet.

pageClient() called in WebPageProxy::platformWindow() could be null. Therefore, platformWindow()
needs to check m_pageClient instead.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformWindow):

1:19 PM Changeset in webkit [265157] by Aditya Keerthi

8 edits in trunk

[macOS] Date/time input types should have a textfield appearance
https://bugs.webkit.org/show_bug.cgi?id=214978

Reviewed by Wenson Hsieh.

Source/WebCore:

On iOS, date/time input types have a menulist-button appearance. However, this appearance
does not match the style of native date controls on macOS. The textfield appearance
with no focus ring brings us closer to a natively styled control.

rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::dateInputStyleSheet const):
(WebCore::RenderThemeMac::dateTimeLocalInputStyleSheet const):
(WebCore::RenderThemeMac::monthInputStyleSheet const):
(WebCore::RenderThemeMac::timeInputStyleSheet const):
(WebCore::RenderThemeMac::weekInputStyleSheet const):

LayoutTests:

Rebaselined tests for updated appearance.

platform/mac-wk2/fast/forms/date/date-input-rendering-basic-expected.txt:
platform/mac-wk2/fast/forms/time/time-input-rendering-basic-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt:

12:50 PM Changeset in webkit [265156] by beidson@apple.com

16 edits
5 copies
2 adds in trunk

Special HID mapping for the Dualshock 3 controller
<rdar://problem/66255198> and https://bugs.webkit.org/show_bug.cgi?id=214911

Reviewed by Tim Horton.

Source/WebCore:

Covered by API tests.

Move GamepadButtons into a GamepadConstants header
Add a "KnownGamepads" header to hold all vendor/product pairs that WebKit knows about
Add a Dualshock3 controller mapping based on its HID report
Add a basic DS3 test based on the HID report

Sources.txt:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:

platform/gamepad/GamepadConstants.cpp: Copied from Source/WebCore/platform/gamepad/mac/GenericHIDGamepad.h.

(WebCore::standardGamepadMappingString):

platform/gamepad/GamepadConstants.h: Added.

platform/gamepad/KnownGamepads.h: Copied from Source/WebCore/platform/gamepad/mac/GenericHIDGamepad.h.

platform/gamepad/cocoa/GameControllerGamepad.mm:

(WebCore::GameControllerGamepad::setupAsExtendedGamepad):

platform/gamepad/mac/Dualshock3HIDGamepad.cpp: Added.

(WebCore::Dualshock3HIDGamepad::Dualshock3HIDGamepad):

platform/gamepad/mac/Dualshock3HIDGamepad.h: Copied from Source/WebCore/platform/gamepad/mac/GenericHIDGamepad.h.

platform/gamepad/mac/GenericHIDGamepad.cpp:

(WebCore::GenericHIDGamepad::GenericHIDGamepad):
(WebCore::GenericHIDGamepad::id): Deleted.

platform/gamepad/mac/GenericHIDGamepad.h:

platform/gamepad/mac/HIDGamepad.cpp:

(WebCore::HIDGamepad::create):
(WebCore::HIDGamepad::HIDGamepad):
(WebCore::HIDGamepad::initialize):

platform/gamepad/mac/HIDGamepad.h:

platform/mac/HIDDevice.h:

(WebCore::HIDDevice::fullProductIdentifier const):

platform/mac/HIDElement.h:

(WebCore::HIDElement::fullUsage const):

Tools:

Add a virtual Dualshock3 and verify a few attributes about it.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/mac/HIDGamepads.mm:
TestWebKitAPI/mac/GamepadMappings/SonyDualShock3.mm: Added.

(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::sonyDualshock3Mapping):

TestWebKitAPI/mac/VirtualGamepad.h:

12:39 PM Changeset in webkit [265155] by achristensen@apple.com

3 edits in trunk/Source/WebCore

Fix Windows build.
https://bugs.webkit.org/show_bug.cgi?id=214988

platform/network/cf/CertificateInfo.h:
platform/network/cf/CertificateInfoCFNet.cpp:

12:24 PM Changeset in webkit [265154] by sbarati@apple.com

3 edits in trunk/Source/JavaScriptCore

Re-enable NO_SMT on Catalina
https://bugs.webkit.org/show_bug.cgi?id=215024

Reviewed by Alexey Proskuryakov.

runtime/Options.cpp:

(JSC::defaultTCSMValue):

runtime/OptionsList.h:

11:57 AM Changeset in webkit [265153] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

REGRESSION: [ iOS wk2 Debug ] imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxChannels.html is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=215025

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-07-31

platform/ios-simulator-wk2/TestExpectations:

11:47 AM Changeset in webkit [265152] by Chris Dumez

15 edits
4 copies in trunk

Add constructor for WaveShaperNode
https://bugs.webkit.org/show_bug.cgi?id=214989

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/webaudio/idlharness.https.window-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/ctor-waveshaper-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-simple-expected.txt:

Source/WebCore:

Add constructor for WaveShaperNode:

https://www.w3.org/TR/webaudio/#waveshapernode

No new tests, rebaselined existing tests.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createWaveShaper):

Modules/webaudio/OverSampleType.h: Copied from Source/WebCore/Modules/webaudio/WaveShaperNode.idl.
Modules/webaudio/OverSampleType.idl: Copied from Source/WebCore/Modules/webaudio/WaveShaperNode.idl.
Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::create):
(WebCore::WaveShaperNode::setCurve):
(WebCore::processorType):

Modules/webaudio/WaveShaperNode.h:

(WTF::LogArgument<WebCore::OverSampleType>::toString):

Modules/webaudio/WaveShaperNode.idl:
Modules/webaudio/WaveShaperOptions.h: Copied from Source/WebCore/Modules/webaudio/WaveShaperNode.idl.
Modules/webaudio/WaveShaperOptions.idl: Copied from Source/WebCore/Modules/webaudio/WaveShaperNode.idl.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

11:46 AM Changeset in webkit [265151] by sbarati@apple.com

16 edits in trunk/Source/JavaScriptCore

validate untagArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=214953

Reviewed by Keith Miller.

This patch adds validation to untagArrayPtr along paths where we don't
immediately store/load from the result.

This patch also changes the removeArrayPtrTag macro assembler function to
use shifts instead of xpacd to strip the tag, because it's faster.

assembler/MacroAssemblerARM64E.h:

(JSC::MacroAssemblerARM64E::untagArrayPtr):
(JSC::MacroAssemblerARM64E::removeArrayPtrTag):

assembler/testmasm.cpp:

(JSC::testCagePreservesPACFailureBit):

bytecode/AccessCase.cpp:

(JSC::AccessCase::generateWithGuard):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::cageTypedArrayStorage):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::untagArrayPtr):
(JSC::FTL::DFG::LowerDFGToB3::caged):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::cageWithoutUntagging):
(JSC::AssemblyHelpers::cageConditionallyAndUntag):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cageWithoutUntagging): Deleted.
(JSC::AssemblyHelpers::cageConditionally): Deleted.

jit/JITPropertyAccess.cpp:

(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::AirIRGenerator::addCallIndirect):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::B3IRGenerator::addCallIndirect):

wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToWasm):

wasm/js/JSToWasm.cpp:

(JSC::Wasm::createJSToWasmWrapper):

wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

10:54 AM Changeset in webkit [265150] by youenn@apple.com

13 edits in trunk

Update service worker if certificate info does not match when soft updating
https://bugs.webkit.org/show_bug.cgi?id=214988

Reviewed by Alex Christensen.

Source/WebCore:

In case service worker certificate info does not match, treat it as if the script changed.
This is a convenient way to update the service worker and the stored registration database.
Covered by API test.

platform/network/cf/CertificateInfo.h:
platform/network/cf/CertificateInfoCFNet.cpp:

(WebCore::certificatesMatch):

workers/service/server/SWServerJobQueue.cpp:

(WebCore::doCertificatesMatch):
(WebCore::SWServerJobQueue::scriptFetchFinished):

workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::certificateInfo const):

Source/WebKit:

Make sure service worker soft updater gathers certificate info.

NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp:

(WebKit::ServiceWorkerSoftUpdateLoader::loadFromNetwork):
(WebKit::ServiceWorkerSoftUpdateLoader::didReceiveResponse):

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::allowsSpecificHTTPSCertificateForHost):

Tools:

Update HTTPServer to pass two optional parameters:

A port number to listen to if provided
A custom server identity to use if provided

The API test is loading an URL on a first server.
This triggers registration of a service worker.
It then stops this server and launches a second server on the same port with a different certificate.
A second page is loaded on the same URL.
This triggers the case of updating a service worker certificate info.

TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:

(createTestIdentity):
(testIdentity):
(testIdentity2):

TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
TestWebKitAPI/cocoa/HTTPServer.h:
TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::listenerParameters):
(TestWebKitAPI::HTTPServer::HTTPServer):

10:44 AM Changeset in webkit [265149] by commit-queue@webkit.org

10 edits in trunk

-[WKWebsiteDataStore _renameOrigin:] needs to support IndexedDB renames
https://bugs.webkit.org/show_bug.cgi?id=214905
<rdar://problem/66247978>

Patch by Sihui Liu <sihui_liu@appe.com> on 2020-07-31
Reviewed by Alex Christensen.

Source/WebCore:

To do the renaming, we close all existing databases whose top origin is old origin, and move all files in
directory of old origin to that of new origin.

API test: WebKit.WebsiteDataStoreRenameOriginForIndexedDatabase

Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::closeDatabasesForOrigins):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):
(WebCore::IDBServer::IDBServer::renameOrigin):

Modules/indexeddb/server/IDBServer.h:

Source/WebKit:

NetworkProcess/IndexedDB/WebIDBServer.cpp:

(WebKit::WebIDBServer::renameOrigin):

NetworkProcess/IndexedDB/WebIDBServer.h:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::renameOriginInWebsiteData):

UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _renameOrigin:to:forDataOfTypes:completionHandler:]):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

10:27 AM Changeset in webkit [265148] by Chris Fleizach

2 edits in trunk/Source/WebCore

AX: Inteterminate progressbar reading as 50% with Voiceover
https://bugs.webkit.org/show_bug.cgi?id=214330
<rdar://problem/65570800>

Reviewed by Zalan Bujtas.

Expose indeterminate status to iOS API.

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityIsIndeterminate]):
(-[WebAccessibilityObjectWrapper accessibilityIsInDescriptionListTerm]):
(-[WebAccessibilityObjectWrapper accessibilityIsInDescriptionListDefinition]):

Drive by style fix.

10:26 AM Changeset in webkit [265147] by Alan Coon

8 edits in trunk/Source

Versioning.

WebKit-610.1.25

10:21 AM Changeset in webkit [265146] by Alan Coon

1 copy in branches/safari-610.1.24-branch

New branch.

10:09 AM Changeset in webkit [265145] by Peng Liu

4 edits in trunk/Source/WebCore

PIP on netflix.com shows only a gray window and spinner
https://bugs.webkit.org/show_bug.cgi?id=214899

Reviewed by Jer Noble.

Use an empty "seekableRanges" instead of a special "duration" value (NaN) to indicate
that seeking is not supported. With this change, the "duration" will always have a meaningful
value, so that WebAVPlayerController can work properly in the picture-in-picture mode.
Related change: https://trac.webkit.org/changeset/217858.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::supportsSeeking const):

platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::duration const):
(WebCore::PlaybackSessionModelMediaElement::seekableRanges const):

platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager canBeginTouchBarScrubbing]):

9:27 AM Changeset in webkit [265144] by Ryan Haddad

3 edits in trunk/Source/WebKit

Unreviewed Catalyst build fix.

WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h: I should have added the include here.
WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

9:10 AM Changeset in webkit [265143] by Jonathan Bedard

3 edits in trunk/Tools

[webkitcorepy] Changes to Tools/Scripts/libraries should trigger EWS
https://bugs.webkit.org/show_bug.cgi?id=214998
<rdar://problem/66355658>

Reviewed by Aakash Jain.

BuildSlaveSupport/ews-build/steps.py:

(CheckPatchRelevance): Add Tools/Scripts/libraries.

BuildSlaveSupport/ews-build/steps_unittest.py:

(TestCheckPatchRelevance.test_relevant_webkitpy_patch):
(TestCheckPatchRelevance.test_relevant_libraries_patch):

9:00 AM Changeset in webkit [265142] by keith_miller@apple.com

13 edits in trunk/Source/JavaScriptCore

Reduce over include usage in JSC
https://bugs.webkit.org/show_bug.cgi?id=215010

Reviewed by Mark Lam.

My first attempt to fix
https://bugs.webkit.org/show_bug.cgi?id=215009 by making it so we
don't include FastJITPermissions.h in TestWebKitAPI, was
unsuccessful. Mostly because I gave up after several hours of
building... I figure it's still worth it to land the last working
version I was able to get building.

assembler/MacroAssemblerCodeRef.h:
bytecode/CodeBlock.cpp:
bytecode/PolymorphicAccess.h:
inspector/agents/InspectorRuntimeAgent.cpp:
interpreter/CallFrame.h:
jit/ThunkGenerators.cpp:
llint/LLIntOffsetsExtractor.cpp:
runtime/TypeLocationCache.cpp:
runtime/VM.cpp:

(JSC::VM::getCTIStub):

runtime/VM.h:

(JSC::VM::getCTIStub): Deleted.

tools/JSDollarVM.cpp:

8:54 AM Changeset in webkit [265141] by keith_miller@apple.com

3 edits in trunk/Tools

Fix build around broken internal SDK for iOS 13
https://bugs.webkit.org/show_bug.cgi?id=215009

Reviewed by Mark Lam.

We need to manually include the private headers because the system tries to hide them from us even on internal builds...

TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:

8:36 AM Changeset in webkit [265140] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews] Add unit-tests for various builder factories
https://bugs.webkit.org/show_bug.cgi?id=214969

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/factories_unittest.py: Added unit-tests.

(TestBuildFactory.test_generic_build_factory):
(TestBuildFactory.test_gtk_build_factory):
(TestBuildFactory.test_wpe_factory):
(TestBuildFactory.test_wincairo_factory):

7:03 AM Changeset in webkit [265139] by pvollan@apple.com

8 edits in trunk/Source

[iOS] Issue a temporary extension to the MobileGestalt daemon when the MobileGestalt cache is invalid
https://bugs.webkit.org/show_bug.cgi?id=214965

Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

Declare MobileGestalt queestion identifier.

pal/spi/ios/MobileGestaltSPI.h:

Source/WebKit:

When the MobileGestalt cache is invalid, some MG queries will fail in the WebContent process, since it has no access to the daemon.
This can be fixed by issuing a temporary extension to the daemon, and having the WebContent process query all relevant MG values
while holding the extension. This will bring the values into the in-memory cache, which will be valid after the extension to the
daemon has been revoked. We will still attempt to rebuild the MG cache if invalid, but since we now have a workaround for when the
cache is invalid, we can do this on a secondary thread to avoid blocking the main thread. We also only attempt to rebuild once now,
instead of every time a WebContent process is started. Additionally, add IOKit property read access to "platform-name", since that
is needed by a MG query.

No new tests, since testing this depends on having an invalid cache, which is rare, and non-trivial to enforce in the test
environment.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

Shared/WebProcessCreationParameters.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::platformInitializeWebProcess):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

3:57 AM Changeset in webkit [265138] by Carlos Garcia Campos

11 edits
1 delete in trunk/Source

[GTK] Mouse wheel events on horizontal scrollbar not correctly handled when AC mode is forced
https://bugs.webkit.org/show_bug.cgi?id=207113

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Remove GTK specific code to invert scroll direction of wheel events.

page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::shouldSwapScrollDirection const): Deleted.

platform/SourcesGLib.txt:
platform/glib/EventHandlerGLib.cpp: Removed.

Source/WebKit:

Move the direction swap to the UI process before passing the event to the web
process. WebHitTestResultData::isScrollbar is now an enum with values No, Verttical, Horizontal. When a wheel
event is received in the widget we check whether we should invert the direction or not.

Shared/API/glib/WebKitHitTestResult.cpp:

(webkitHitTestResultCreate):
(webkitHitTestResultCompare):

Shared/WebHitTestResultData.cpp:

(WebKit::WebHitTestResultData::WebHitTestResultData):

Shared/WebHitTestResultData.h:
UIProcess/API/APIHitTestResult.h:

(API::HitTestResult::isScrollbar const):

UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewMouseTargetChanged):

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(shouldInvertDirectionForScrollEvent):
(webkitWebViewBaseScrollEvent):
(webkitWebViewBaseScroll):
(webkitWebViewBaseSetMouseIsOverScrollbar):

UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

2:00 AM Changeset in webkit [265137] by svillar@igalia.com

4 edits in trunk/Source/WebCore

[WebXR] Retrieve supported reference spaces from actual XR systems
https://bugs.webkit.org/show_bug.cgi?id=214187

Reviewed by Carlos Garcia Campos.

Each XR system supports a set of reference spaces which are used by WebXR to stablish
a spatial relationship with user's physical environment. The list of supported reference
spaces determine whether or not a session request succeeds or not, as it will refuse to
start a session with an unsupported reference space.

So far, no reference spaces were retrieved from the actual devices. This patch adds the
required OpenXR machinery to retrieve them. In particular, we have to create a XrSession
(although we don't have to start it) in order to retrieve the reference spaces. Since we
don't need it to show content to the user we can create it in headless mode and then discard
it afterwards when no longer needed.

Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::WebXRSession): Clarify a comment. Also s/TODO/FIXME/g.

platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::isExtensionSupported): New method to check whether a specific extension
is supported.
(PlatformXR::Instance::Impl::checkInstanceExtensionProperties const): renamed from
enumerateInstanceExtensionProperties(). Returns whether or not the call succeeded.
(PlatformXR::Instance::Impl::Impl): Pass the list of enabled extensions to the instance.
(PlatformXR::Instance::enumerateImmersiveXRDevices): Log the systems found.
(PlatformXR::OpenXRDevice::OpenXRDevice):
(PlatformXR::OpenXRDevice::enumerateReferenceSpaces const): New method to list the
supported reference spaces by the XR system.
(PlatformXR::OpenXRDevice::collectSupportedSessionModes): Store reference spaces as
enabled features for supported modes.
(PlatformXR::OpenXRDevice::collectConfigurationViews): Renamed from
enumerateConfigurationViews().
(PlatformXR::Instance::Impl::enumerateInstanceExtensionProperties const): Deleted.
(PlatformXR::OpenXRDevice::enumerateConfigurationViews): Deleted.

platform/xr/openxr/PlatformXROpenXR.h:

12:45 AM Changeset in webkit [265136] by ysuzuki@apple.com

3 edits in trunk/Source/JavaScriptCore

[JSC] Follow-up changes after r265036
https://bugs.webkit.org/show_bug.cgi?id=214982

Reviewed by Darin Adler.

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit): Remove dupe definitions in OSRExit.

jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_iterator_open): We should use emitJumpSlowCaseIfNotJSCell(regT1).

12:15 AM Changeset in webkit [265135] by youenn@apple.com

2 edits in trunk/Source/WebCore

Add LibWebRTCAudioModule logging
https://bugs.webkit.org/show_bug.cgi?id=214987

Reviewed by Eric Carlson.

platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:

(WebCore::LibWebRTCAudioModule::RegisterAudioCallback):
(WebCore::LibWebRTCAudioModule::StartPlayout):
(WebCore::LibWebRTCAudioModule::StopPlayout):

Jul 30, 2020:

11:16 PM Changeset in webkit [265134] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Optimize WebsiteDataStoreConfiguration::copy
https://bugs.webkit.org/show_bug.cgi?id=215012
<rdar://problem/64263406>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-07-30
Reviewed by Brady Eidson.

The WebsiteDataStoreConfiguration constructor does some read/write heavy things.
We only want to do these things if we are not just going to overwrite the strings with strings from another WebsiteDataStoreConfiguration.
No change in behavior, just making things faster.

UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:

(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
(WebKit::WebsiteDataStoreConfiguration::copy const):

UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:

(WebKit::WebsiteDataStoreConfiguration::create):

11:05 PM Changeset in webkit [265133] by Simon Fraser

2 edits in trunk/Source/WebCore

Minor RenderLayerCompositor::updateBackingAndHierarchy() cleanup
https://bugs.webkit.org/show_bug.cgi?id=215008

Reviewed by Zalan Bujtas.

Instead of setting child layers, and then adding another child (overflowControlLayer),
append overflowControlLayer to the vector and then set children.

No behavior change.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):

10:51 PM Changeset in webkit [265132] by sbarati@apple.com

2 edits in trunk/JSTests

Skip stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js
https://bugs.webkit.org/show_bug.cgi?id=215001

Reviewed by Darin Adler.

The test takes > 4 minutes when run on an idle machine. That's too long.

stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js:

9:49 PM Changeset in webkit [265131] by Simon Fraser

2 edits in trunk/Source/WTF

Have TimingScope track the max event duration
https://bugs.webkit.org/show_bug.cgi?id=215006

Reviewed by Tim Horton.

Have TimingScope track and print the longest event, as well as the count and
mean duration.

wtf/TimingScope.cpp:

(WTF::TimingScope::scopeDidEnd):

9:43 PM Changeset in webkit [265130] by Lauro Moura

2 edits in trunk/LayoutTests

[GTK][WPE] Garden three persistent failures from gtk release bot.

Unreviewed test gardening.

These were also affecting the debug and WPE bots.

platform/glib/TestExpectations:

8:44 PM Changeset in webkit [265129] by weinig@apple.com

15 edits in trunk/Source/WebCore

It would be nice if the predicate taking functions in ParsingUtilities.h didn't require specifying the character type
https://bugs.webkit.org/show_bug.cgi?id=215002

Reviewed by Darin Adler.

Remove the need for specifying the character type by providing overloads for LChar and UChar
explicitly.

html/parser/HTMLSrcsetParser.cpp:

(WebCore::parseImageCandidatesFromSrcsetAttribute):

html/parser/ParsingUtilities.h:

(WebCore::characterPredicate):

html/track/VTTScanner.h:

(WebCore::characterPredicate):

loader/LinkHeader.cpp:

(WebCore::findURLBoundaries):
(WebCore::invalidParameterDelimiter):
(WebCore::parseParameterDelimiter):
(WebCore::parseParameterName):
(WebCore::skipQuotesIfNeeded):
(WebCore::parseParameterValue):
(WebCore::findNextHeader):

loader/ResourceCryptographicDigest.cpp:

(WebCore::parseCryptographicDigestImpl):
(WebCore::parseEncodedCryptographicDigestImpl):

loader/SubresourceIntegrity.cpp:

(WebCore::splitOnSpaces):

loader/appcache/ApplicationCacheManifestParser.cpp:

(WebCore::parseApplicationCacheManifest):

page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::ContentSecurityPolicyDirectiveList::parseDirective):
(WebCore::ContentSecurityPolicyDirectiveList::parseReportURI):

page/csp/ContentSecurityPolicyMediaListDirective.cpp:

(WebCore::ContentSecurityPolicyMediaListDirective::parse):

page/csp/ContentSecurityPolicySourceList.cpp:

(WebCore::isSourceListNone):
(WebCore::ContentSecurityPolicySourceList::parse):
(WebCore::ContentSecurityPolicySourceList::parseSource):
(WebCore::ContentSecurityPolicySourceList::parseScheme):
(WebCore::ContentSecurityPolicySourceList::parseHost):
(WebCore::ContentSecurityPolicySourceList::parsePath):
(WebCore::ContentSecurityPolicySourceList::parsePort):
(WebCore::ContentSecurityPolicySourceList::parseNonceSource):

platform/DateComponents.cpp:

(WebCore::countDigits):

svg/SVGLengthList.cpp:

(WebCore::SVGLengthList::parse):

svg/SVGParserUtilities.cpp:

(WebCore::genericParseNumber):

svg/SVGParserUtilities.h:

(WebCore::skipOptionalSVGSpaces):

8:25 PM Changeset in webkit [265128] by Jonathan Bedard

2 edits in trunk/Tools

[webkitcorepy] Add an auto-installer (Unreviewed follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=214606

Unreviewed development nit.

.gitignore: Add Scripts/libraries/autoinstalled to .gitignore.

8:18 PM Changeset in webkit [265127] by Ryan Haddad

2 edits in trunk/Source/WebKit

Unreviewed second attempt to fix Catalyst build after r265084.

WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

7:05 PM Changeset in webkit [265126] by weinig@apple.com

3 edits in trunk/Source/WebCore

Convert DateComponents to use StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=213929

Reviewed by Darin Adler.

Switches string parsing in DateComponents to using StringParsingBuffer, making use of ParsingUtilities to streamline / simplify the code.
Moves a few constant values only used in DateComponents.cpp to DateComponents.cpp
Rename toInt in DateComponents.cpp to parseInt, and have use an Optional return value rather than bool + out-parameter.
Add new parseIntWithinLimits that also checks that parsed value is within specfied limits, as this is what almost all of the int parsing in DateComponents needs.

platform/DateComponents.cpp:

(WebCore::countDigits):
(WebCore::parseInt):
(WebCore::parseIntWithinLimits):
(WebCore::DateComponents::parseYear):
(WebCore::withinHTMLDateLimits):
(WebCore::createFromString):
(WebCore::DateComponents::fromParsingMonth):
(WebCore::DateComponents::fromParsingDate):
(WebCore::DateComponents::fromParsingWeek):
(WebCore::DateComponents::fromParsingTime):
(WebCore::DateComponents::fromParsingDateTimeLocal):
(WebCore::DateComponents::fromParsingDateTime):
(WebCore::DateComponents::parseTimeZone):
(WebCore::DateComponents::parseMonth):
(WebCore::DateComponents::parseDate):
(WebCore::DateComponents::parseWeek):
(WebCore::DateComponents::parseTime):
(WebCore::DateComponents::parseDateTimeLocal):
(WebCore::DateComponents::parseDateTime):
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
(WebCore::toInt): Deleted.

platform/DateComponents.h:

(WebCore::DateComponents::minimumYear): Deleted.
(WebCore::DateComponents::maximumYear): Deleted.

6:44 PM Changeset in webkit [265125] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

REGRESSION (r?): Web Inspector: Timelines: blue border below selected timeline when in edit mode
https://bugs.webkit.org/show_bug.cgi?id=214979
<rdar://problem/66338399>

Reviewed by Devin Rousso.

Color the top border after the selected item with the same background as the selected item.
When editing, don't color that border with the selected item background.

UserInterface/Views/TimelineOverview.css:

(.timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),):
(body:matches(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines .item.selected + .item):
(body:not(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines:focus-within .item.selected + .item):
(@media (prefers-color-scheme: dark) .timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:nth-child(even)):
(.timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted.
(body:not(.window-inactive, .window-docked-inactive) .timeline-overview > .tree-outline.timelines:focus-within .item.selected + .item): Deleted.
(@media (prefers-color-scheme: dark) .timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),): Deleted.
(@media (prefers-color-scheme: dark) .timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted.

6:14 PM Changeset in webkit [265124] by Fujii Hironori

2 edits in trunk/Tools

webkitpy: If LC_ALL is set to a empty string, svn doesn't use the password store
https://bugs.webkit.org/show_bug.cgi?id=214983

Reviewed by Darin Adler.

If LC_ALL is set to a empty string, svn doesn't use the password
store in my environment. I'm using svn with gpg-agent on Ubuntu
20.04 (svn version 1.13.0, gpg-agent 2.2.19).

r101274 (Bug 68691) has set LC_ALL to a empty string.

If I invoke 'svn ci' on my terminal, svn askes gpg-agent my
password as expected, but if I invoke 'LC_ALL= svn ci', svn askes
my password by itself.

Scripts/webkitpy/common/host.py:

(Host._engage_awesome_locale_hacks): Set the env var LC_ALL to 'en_US.UTF-8'.

5:42 PM Changeset in webkit [265123] by Jonathan Bedard

3 edits in trunk/Tools

[webkitcorepy] Make scripts called with sudo use a userspace autoinstall
https://bugs.webkit.org/show_bug.cgi?id=214981
<rdar://problem/66342996>

Reviewed by Dewei Zhu.

Sudo can bring havoc to the autoinstaller, because the directories it creates will belong
to the root user. We should ensure that the directories created by a sudo script call
are owned by the user that called sudo, when possible.

Scripts/libraries/webkitcorepy/webkitcorepy/init.py:
Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.install): Ensure that installed packages are not owned by root, if possible.
(AutoInstall.userspace_should_own): Ensure that a directory or file is not owned by root, if possible.
(AutoInstall.set_directory): Ensure that the directories containing auto-installed packages are not
owned by root, if possible.

5:17 PM Changeset in webkit [265122] by keith_miller@apple.com

4 edits in trunk/Source

Remove UB from nonPACBitsMask computation
https://bugs.webkit.org/show_bug.cgi?id=214996

Reviewed by Tadeu Zagallo.

For non-ARM64E we now set numberOfPACBits to zero, which was causing UB in our computation of the nonPACBitsMask.

Source/JavaScriptCore:

assembler/MacroAssemblerARM64E.h:

Source/WTF:

wtf/CagedPtr.h:

5:15 PM Changeset in webkit [265121] by Devin Rousso

1 edit
3 adds in trunk/Source/WebInspectorUI

Web Inspector: Add another Protocol Version (iOS 14.0)
https://bugs.webkit.org/show_bug.cgi?id=214991
<rdar://problem/59156892>

Reviewed by Brian Burg.

UserInterface/Protocol/Legacy/14.0/InspectorBackendCommands.js: Added.
Versions/Inspector-iOS-14.0.json: Added.

5:12 PM Changeset in webkit [265120] by Nikita Vasilyev

21 edits in trunk/Source/WebInspectorUI

Web Inspector: on Big Sur, match OS background, text, and border colors
https://bugs.webkit.org/show_bug.cgi?id=214366
<rdar://problem/65617290>

Reviewed by Devin Rousso.

Refactoring:

Remove --background-color-code because it was always the same value as --background-color-content.
Replace commonly hardcoded hsl(0, 0%, 97%) background with --background-color-intermediate.

UserInterface/Views/AnimationDetailsSidebarPanel.css:

(.sidebar > .panel.details.animation > .content > .details-section.animation-keyframes .details-section):
(.sidebar > .panel.details.animation > .content > .details-section.animation-keyframes .details-section .row.styles .CodeMirror):

UserInterface/Views/BoxShadowEditor.css:

(.box-shadow-editor > table > tr > td > input[type="text"]):

UserInterface/Views/BreakpointActionView.css:

(@media (prefers-color-scheme: dark) .breakpoint-action-eval-editor):

UserInterface/Views/BreakpointPopoverController.css:

(.edit-breakpoint-popover-condition):

UserInterface/Views/ChangesDetailsSidebarPanel.css:

(.sidebar > .panel.changes-panel .css-rule):

UserInterface/Views/ComputedStyleSection.css:

(.computed-style-section .computed-property-item.expanded):
(.computed-style-properties.details-section > .content,):

UserInterface/Views/ConsolePrompt.css:

(.console-prompt):
(.console-prompt > .CodeMirror-scroll):

UserInterface/Views/CookiePopover.css:

(.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"])):

UserInterface/Views/DetailsSection.css:

(.details-section .details-section):
(.details-section .details-section > .header):
Refactor. --background-color-content is the same color value.

(.details-section .details-section:not(.collapsed) > .header):
Refactor. --border-color-secondary is the same color value.

(.details-section > .content > .group:nth-child(even)):
(.details-section > .content > .group > .row:matches(.empty, .text)):
(@media (prefers-color-scheme: dark) .details-section > .header > label,):

UserInterface/Views/DividerNavigationItem.css:

(.navigation-bar .item.divider):
Don't use hairline dividers. MacOS Catalina and Big Sur don't use hairline borders.

UserInterface/Views/GraphicsOverviewContentView.css:

(.content-view.graphics-overview > section > .header):
(@media (prefers-color-scheme: dark) .content-view.graphics-overview):

UserInterface/Views/LocalResourceOverridePopover.css:

(.popover .local-resource-override-popover-content .editor):

UserInterface/Views/LogContentView.css:

(@media (prefers-color-scheme: dark) .console-messages):

UserInterface/Views/QuickConsole.css:

(.quick-console):

UserInterface/Views/ScopeChainDetailsSidebarPanel.css:

(@media (prefers-color-scheme: dark) .watch-expression-editor):

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration):
(.spreadsheet-css-declaration.locked):

UserInterface/Views/SyntaxHighlightingDefaultTheme.css:

(@media (prefers-color-scheme: dark) .cm-s-default,):

UserInterface/Views/TabBar.css:

(body.big-sur.docked .tab-bar > .border.bottom):

UserInterface/Views/URLBreakpointPopover.css:

(.popover .url-breakpoint-content > .editor-wrapper > .editor):

UserInterface/Views/Variables.css:

(:root):
Add --separator-color, which has the same semantics as separator color from Apple HIG
(https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/color/#dynamic-system-colors).
--border-color-secondary was only defined in the dark mode. Define it in the light mode, too.

(body.window-inactive):
Remove unused variable.

(body.big-sur):
(@media (prefers-color-scheme: dark) :root):
(@media (prefers-color-scheme: dark) body.big-sur):
(@media (prefers-color-scheme: dark) body.window-inactive):
(body.window-inactive *): Remove unnecessarily greedy selector.

4:54 PM Changeset in webkit [265119] by Ryan Haddad

2 edits in trunk/Source/WebCore

Unreviewed attempt to fix Catalyst build after r265084.

editing/cocoa/DictionaryLookup.mm:

4:35 PM Changeset in webkit [265118] by Devin Rousso

14 edits in trunk/Source/WebInspectorUI

Web Inspector: only show scrollbars when needed
https://bugs.webkit.org/show_bug.cgi?id=214980

Reviewed by Brian Burg.

Prefer overflow: auto; instead of overflow: scroll; wherever possible, as when using a
hardware mouse scrollbars are always shown for the latter, even when the content fits.

UserInterface/Debug/UncaughtExceptionReporter.css:

(.sheet-container):

UserInterface/Views/AuditTestContentView.css:

(.content-view-container > .content-view.audit-test):

UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview > .content-view.canvas.saved-recordings .tree-outline):

UserInterface/Views/CanvasSidebarPanel.css:

(.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content):

UserInterface/Views/DOMEventsBreakdownView.css:

(.waterfall-popover-content .dom-events-breakdown):

UserInterface/Views/DOMNodeEventsContentView.css:

(.dom-node-details.dom-events):

UserInterface/Views/GraphicsOverviewContentView.css:

(.content-view.graphics-overview):

UserInterface/Views/LocalRemoteObjectContentView.css:

(.content-view.local-remote-object):

UserInterface/Views/NetworkResourceDetailView.css:

(.content-view.resource-details):

UserInterface/Views/OpenResourceDialog.css:

(.open-resource-dialog > .tree-outline):

UserInterface/Views/SourceCodeTextEditor.css:

(.popover .debugger-popover-content > .body):

UserInterface/Views/CPUTimelineView.css:

(.timeline-view.cpu): Added.
(body .timeline-view.cpu): Deleted.

UserInterface/Views/MemoryTimelineView.css:

(.timeline-view.memory): Added.
(body .timeline-view.memory): Deleted.
Although !important is kind of a "hack", adding body to the selector is more of a "hack"
and is easier to unintentionally break.

4:31 PM Changeset in webkit [265117] by Wenson Hsieh

3 edits
2 adds in trunk

[iPadOS] Two taps are required to choose a country/region when creating an account on ea.com
https://bugs.webkit.org/show_bug.cgi?id=214984
<rdar://problem/66261490>

Reviewed by Devin Rousso.

Source/WebKit:

On the desktop version of the account creation page on ea.com, tapping a custom selection menu element
programmatically focuses a real select element that is positioned far outside the viewport. As a result, on
iPad, we still attempt to show a popover for this focused select at the element location. This popover is not
visible to the user, but on iOS 13, it still steals modal focus from the web view, which means that an
additional tap anywhere in the window is required to dismiss the (invisible) popover before the user can choose
one of the options in the custom in-page menu that is shown.

Furthermore, upon choosing one of these options, the page programmatically focuses the offscreen select again.
This causes us to re-present the offscreen popover, which requires yet another tap to dismiss on iOS 13.
However, on iOS 14, this actually results in a crash when attempting to scroll the popover's inner UITableView
to the selected row.

To fix both the crash on iOS 14 and the multiple redundant taps required to dismiss the popover on iOS 13, avoid
showing popovers altogether if the popover's presentation rect is outside the bounds of the content view, since
we cannot reasonably expect a user to interact with such a popover anyways.

Test: fast/forms/ios/repeatedly-focus-offscreen-select.html

UIProcess/ios/forms/WKFormPopover.mm:

(-[WKRotatingPopover presentPopoverAnimated:]):

LayoutTests:

Add a test that exercises both the crash and the UI bug on iPadOS. Note that this test already passes on iOS,
where we don't use popovers for focused selects.

fast/forms/ios/repeatedly-focus-offscreen-select-expected.txt: Added.
fast/forms/ios/repeatedly-focus-offscreen-select.html: Added.

4:22 PM Changeset in webkit [265116] by dino@apple.com

7 edits in trunk

[WebGL] Safari snapshots of WebGL content in the tab picker don't work
https://bugs.webkit.org/show_bug.cgi?id=214452
<rdar://problem/21243082>

Source/WebCore:

Original patch by Justin Fan. Reviewed by Darin Adler.

Test is in TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint): Will properly request a paint when a snapshot is requested.

html/HTMLCanvasElement.h:
html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::paintRenderingResultsToCanvas): Only clear the last snapshot if readPixels will succeed.

rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::paintReplaced):

Tools:

Test for snapshotting. Marked as PLATFORM(MAC) for now.

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:

(TEST):

4:08 PM Changeset in webkit [265115] by jer.noble@apple.com

19 edits
2 adds in trunk

[Cocoa] Adopt -[AVContentKeyRequest willOutputBeObscuredDueToInsufficientExternalProtectionForDisplays:]
https://bugs.webkit.org/show_bug.cgi?id=214659
<rdar://problem/63555006>

Reviewed by Darin Adler.
Source/WebCore:

Use the new WTF::Observer object as the listener type for notifying clients of display changes. When a displayChanged
event is observed, use the new AVContentKeyRequest -willOutputBeObscuredDueToInsufficientExternalProtectionForDisplays:
to set the keyStatus for that request appropriately.

Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::displayID):
(WebCore::MediaKeySession::displayChanged):

Modules/encryptedmedia/MediaKeySession.h:
dom/Document.cpp:

(WebCore::Document::windowScreenDidChange):
(WebCore::Document::addDisplayChangedObserver):

dom/Document.h:
platform/encryptedmedia/CDMInstanceSession.h:

(WebCore::CDMInstanceSession::displayChanged):

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(-[WebCoreFPSContentKeySessionDelegate contentKeySession:externalProtectionStatusDidChangeForContentKeyRequest:]):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::externalProtectionStatusDidChangeForContentKeyRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::displayChanged):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::externalProtectionStatusDidChangeForContentKeyRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateProtectionStatusForDisplayID):

Source/WebCore/PAL:

pal/spi/cocoa/AVFoundationSPI.h:

Source/WebKit:

Support clients in the GPU process asking for (and receiving updates to) the current displayID.

GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:

(WebKit::RemoteCDMInstanceSessionProxy::displayIDChanged):

GPUProcess/media/RemoteCDMInstanceSessionProxy.h:
GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in:

Source/WTF:

Add a new Observer template class. This allows classes to provide support for listeners without requiring
those listeners to subclass from a pure-virtual (and CanMakeWeakPtr capable) client class. Instead, clients
can just create one of these Observer objects, and pass a WeakPtr to that observer to the notifying object.
When the client object destroys the observer, it is automatically unregistered when the observing object
uses a WeakHashSet.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/Observer.h: Added.

(WTF::Observer<Out):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/Observer.cpp: Added.

(TestWebKitAPI::TEST):

3:27 PM Changeset in webkit [265114] by commit-queue@webkit.org

10 edits in trunk

[WebGL2] Buffer updates
https://bugs.webkit.org/show_bug.cgi?id=209511

Patch by James Darpinian <James Darpinian> on 2020-07-30
Reviewed by Dean Jackson.

Various fixes in bufferData, bufferSubData, and getBufferSubData. Passes all WebGL conformance tests in conformance/buffers/* and conformance2/buffers/*.

html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::sliceArrayBufferView):
(WebCore::WebGL2RenderingContext::getBufferSubData):

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::bufferData):
(WebCore::WebGLRenderingContextBase::bufferSubData):

html/canvas/WebGLRenderingContextBase.h:
html/canvas/WebGLRenderingContextBase.idl:

3:26 PM Changeset in webkit [265113] by keith_miller@apple.com

5 edits in trunk/Source

Compute number of PAC bits from what the OS says its address space is
https://bugs.webkit.org/show_bug.cgi?id=214986

Reviewed by Saam Barati.

Source/JavaScriptCore:

assembler/MacroAssemblerARM64E.h:

Source/WTF:

wtf/CagedPtr.h:
wtf/PtrTag.h:

3:17 PM Changeset in webkit [265112] by Caio Lima

3 edits
1 add in trunk

[JSC][32-bits] interator_next should check for EmptyValue instead of undefined to execute LLInt fast path
https://bugs.webkit.org/show_bug.cgi?id=214963

Reviewed by Yusuke Suzuki.

JSTests:

stress/invalidate-array-iterator-prototype-next.js: Added.

Source/JavaScriptCore:

There was a bug in previous implementation that allows execution of
interator_next fast path if we set ArrayIterator.prototype.next to

This happened because we were not properly checking ValueEmpty

from m_next. This patch is fixing such issue and doing the proper
verification.

llint/LowLevelInterpreter32_64.asm:

3:08 PM Changeset in webkit [265111] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 111

Added a tag for Safari Technology Preview release 111.

3:08 PM Changeset in webkit [265110] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 110

Added a tag for Safari Technology Preview release 110.

3:07 PM Changeset in webkit [265109] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 109

Added a tag for Safari Technology Preview release 109.

3:07 PM Changeset in webkit [265108] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 108

Added a tag for Safari Technology Preview release 108.

3:06 PM Changeset in webkit [265107] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 107

Added a tag for Safari Technology Preview release 107.

3:06 PM Changeset in webkit [265106] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 106

Added a tag for Safari Technology Preview release 106.

3:06 PM Changeset in webkit [265105] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 105

Added a tag for Safari Technology Preview release 105.

3:04 PM Changeset in webkit [265104] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 104

Added a tag for Safari Technology Preview release 104.

3:04 PM Changeset in webkit [265103] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 103

Added a tag for Safari Technology Preview release 103.

3:04 PM Changeset in webkit [265102] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 102

Added a tag for Safari Technology Preview release 102.

3:03 PM Changeset in webkit [265101] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 101

Added a tag for Safari Technology Preview release 101.

3:03 PM Changeset in webkit [265100] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 100

Added a tag for Safari Technology Preview release 100.

3:01 PM Changeset in webkit [265099] by Alan Coon

1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 99

Added a tag for Safari Technology Preview release 99.

2:51 PM Changeset in webkit [265098] by graouts@webkit.org

6 edits in trunk

[ iOS ] webanimations/accelerated-animation-with-easing.html is still flaky
https://bugs.webkit.org/show_bug.cgi?id=214327
<rdar://problem/65569237>

Reviewed by Dean Jackson.

Source/WebKit:

When we fixed bug 213495 in r263506, we started calling PlatformCAAnimation::setTimingFunction()
to set the animation-wide timing function of CSS Animations and JS-originated animations alike.
However, we neglected to update PlatformCAAnimationRemote, used on iOS, to be able to handle
both animation-wide timing functions as well as keyframe-specific timing functions. This patch
adds a new "timingFunction" member to PlatformCAAnimationRemote::Properties to allow for this
and this new member is used in setTimingFunction() and copyTimingFunctionFrom(). Finally, after
the animation is decoded in the UI process, we call -[CAKeyframeAnimation setTimingFunction:]
inside addAnimationToLayer() to use this animation-wide timing function.

This fixes the test added originally in r263506 which would only work flakily, a symptom of this
missing implementation on iOS.

WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h:
WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::encodeTimingFunction):
(WebKit::decodeTimingFunction):
(WebKit::PlatformCAAnimationRemote::Properties::encode const):
(WebKit::PlatformCAAnimationRemote::Properties::decode):
(WebKit::PlatformCAAnimationRemote::setTimingFunction):
(WebKit::PlatformCAAnimationRemote::copyTimingFunctionFrom):
(WebKit::addAnimationToLayer):
(WebKit::operator<<):

LayoutTests:

Remove the flaky expectation and remove the extra tolerance added in r263761 when it was thought that
this test was merely flaky and not completely broken on iOS as it turned out to be.

platform/ios-wk2/TestExpectations:
webanimations/accelerated-animation-with-easing.html:

2:44 PM Changeset in webkit [265097] by sbarati@apple.com

3 edits in trunk/Source/JavaScriptCore

Strip pointers instead of authing for byteOffset to not allow for a possible way to guess data pac
https://bugs.webkit.org/show_bug.cgi?id=214952

Reviewed by Keith Miller.

In the old way of doing things, we would auth the vector pointer before subtracting
the base from it. Since we never validated the auth, this allowed for a
potential data-PAC bypass by just repeatedly calling byteOffset in a loop
and observing the integer result of the operation.

Since byteOffset does no loads/stores, it suffices to just strip the PAC
bits before doing the subtraction. This eliminates any such attacks like
the above because the PAC bits are ignored.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetTypedArrayByteOffset):

2:44 PM Changeset in webkit [265096] by ddkilzer@apple.com

4 edits in trunk/Tools

check-webkit-style should enforce acronym capitalization at start/end of an identifier
<https://webkit.org/b/214954>

Reviewed by Jonathan Bedard.

DumpRenderTree/mac/DumpRenderTree.mm:

(shouldIgnoreWebCoreNodeLeaks):
(changeWindowScaleIfNeeded):

Fix case issues in variables using URL acronym.

Scripts/webkitpy/style/checkers/cpp.py:

(_check_identifier_name_for_acronyms): Add.

This contains the logic to report acronyms with invalid case at the start and at the end of an identifer.

(check_identifier_name_in_declaration):

Keep track of whether the identifer came from a class, namespace or struct.
Fix bug where auto variables would not be checked because auto was removed with other non-type keywords like inline, leaving no type for the variable. Add a comment to describe what this line is doing.
Fix bug when removing "new" that changed an identifier named "newURL" to "URL".
Add call to _check_identifier_name_for_acronyms() to implement the check.

(CppChecker):

Add 'readability/naming/acronym' to the list of active checkers.

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_identifier_names_with_acronyms):

Add tests. About half of the tests were taken from actual code that initially caused false positives during development.

2:28 PM Changeset in webkit [265095] by jer.noble@apple.com

11 edits in trunk

[Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.
https://bugs.webkit.org/show_bug.cgi?id=214807

Reviewed by Darin Adler.

PerformanceTests:

Look up the UTI type of the specified file, and create the appropriate SourceBufferParser
by passing in the ContentType (converted from UTI). Also, add a --rate-limit flag which
causes the decompression session to run at the same FPS as the underlying media.

DecoderTest/DecoderTest.xcodeproj/project.pbxproj:
DecoderTest/DecoderTest/main.mm:

(main):

Source/WebCore:

Export registerWebKitVP9Decoder() from VP9UtilitiesCocoa instead of LibWebRTCProvider to make it easier
for DecodeTest to import, as LibWebRTCProvider also pulls in a bunch of libwebrtc headers. Also, export
SourceBufferParser.h so DecoderTest can create parsers for fMP4 files.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/cocoa/VP9UtilitiesCocoa.h:
platform/graphics/cocoa/VP9UtilitiesCocoa.mm:

(WebCore::registerWebKitVP9Decoder):

Source/WebKit:

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::enableVP9Decoder):

2:24 PM Changeset in webkit [265094] by Beth Dakin

2 edits in trunk/Tools

Make report-non-inclusive-language ignore xcuserstate
https://bugs.webkit.org/show_bug.cgi?id=214985

Reviewed by Darin Adler.

Ignore xcuserstate since it introduces random noise.

Scripts/report-non-inclusive-language:

2:21 PM Changeset in webkit [265093] by commit-queue@webkit.org

14 edits in trunk/LayoutTests

[WebGL2] Enable conformance2/textures/{image,video} and related layout tests
https://bugs.webkit.org/show_bug.cgi?id=214977

Patch by Kenneth Russell <kbr@chromium.org> on 2020-07-30
Reviewed by Dean Jackson.

Enable dozens more WebGL 2.0 conformance tests, most
significantly:

webgl/2.0.0/conformance/textures/image/*
webgl/2.0.0/conformance[2]/textures/video/*

which are now passing completely.

TestExpectations:
webgl/2.0.0/conformance2/textures/video/tex-2d-r11f_g11f_b10f-rgb-float-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-r11f_g11f_b10f-rgb-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-r16f-red-float-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-r16f-red-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-r32f-red-float-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-rg16f-rg-float-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-rg16f-rg-half_float-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-rg32f-rg-float-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-rg8-rg-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-rg8ui-rg_integer-unsigned_byte-expected.txt:
webgl/2.0.0/conformance2/textures/video/tex-2d-rgb5_a1-rgba-unsigned_byte-expected.txt:

1:14 PM Changeset in webkit [265092] by rniwa@webkit.org

6 edits
2 adds in trunk

Clicking on a shadow DOM does not move the selection to the focused element when delegatesFocus is set to true
https://bugs.webkit.org/show_bug.cgi?id=214859
<rdar://problem/66192901>

Reviewed by Wenson Hsieh.

Source/WebCore:

The bug was caused by EventHandler moving the selection to where the user had clicked, not to where the focus
had been delegated, which is a uniquely WebKit behavior. Fixed the bug by revealing the focused element as done
in Element::focus in EventHandler::dispatchMouseEvent and avoid updating the selection to the clicked point
later in EventHandler::handleMousePressEventSingleClick by adding an early exit.

Test: fast/shadow-dom/delegates-focus-and-types-into-input.html

dom/Element.cpp:

(WebCore::Element::focus):
(WebCore::Element::revealFocusedElement): Extracted from Element::focus.

dom/Element.h:
page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick): Added an early exit when dispatchMouseEvent had
delegated the focus to an element different from the one the user had clicked.
(WebCore::EventHandler::dispatchMouseEvent): Added a code to reveal the newly focused element when the focus
had been delegated.

page/EventHandler.h:

LayoutTests:

Added a regression test.

fast/shadow-dom/delegates-focus-and-types-into-input-expected.txt: Added.
fast/shadow-dom/delegates-focus-and-types-into-input.html: Added.

11:25 AM Changeset in webkit [265091] by timothy_horton@apple.com

11 edits in trunk

Web content gets stuck in an inactive state (no cursor updates or text insertion caret) when activating a tab with a thumbnail visible
https://bugs.webkit.org/show_bug.cgi?id=214962
<rdar://problem/65670984>

Reviewed by Wenson Hsieh.

Source/WebCore:

New API test: WebKit.WKThumbnailViewResetsViewStateWhenUnparented

testing/Internals.cpp:

(WebCore::Internals::isPageActive const):

testing/Internals.h:
testing/Internals.idl:

Add a "view window is active" getter.

Source/WebKit:

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::setThumbnailView):
When WKThumbnailView is unparented, invalidate all activity state bits.
We do this because many of the functions that compute activity state bits
use the WKThumbnailView's window while it is parented. When it is unparented,
and we switch back to using the WKWebView's window, we mustn't get stuck
with activity state bits from WKThumbnailView's window.

This was particularly problematic in the case of the WKThumbnailViews
used for tab hover previews, because that window is not key, so we'd get
stuck with the inactive-window state, resulting in a lack of cursor updates,
a hidden text caret, the wrong selection color, etc.

UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::isViewWindowActive):
While writing the API test for this, I noticed that isViewWindowActive
returns YES if there is no key window AND WKWebView is unparented
([NSApp keyWindow] == activeWindow() == nil).
This seems completely insane (how can the window be active if it doesn't
exist?), and breaks the test, so ensure that we only say YES if we actually
have a window.

Tools:

TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:

(TestWebKitAPI::TEST):
Add a test ensuring that we go back to the active-window state after
unparenting a WKThumbnailView that was installed in an inactive window.

(-[WKThumbnailViewDelegate webView:didFinishNavigation:]): Deleted.

TestWebKitAPI/mac/OffscreenWindow.h:
TestWebKitAPI/mac/OffscreenWindow.mm:

(-[OffscreenWindow initWithSize:]):
(-[OffscreenWindow initWithSize:isKeyWindow:]):
(-[OffscreenWindow isKeyWindow]):

11:20 AM Changeset in webkit [265090] by ysuzuki@apple.com

2 edits in trunk/JSTests

Unreviewed, fix bottom-tuple.js test
https://bugs.webkit.org/show_bug.cgi?id=214956

Only thing we would like to check in this test is whether this does not crash.

wasm/stress/bottom-tuple.js:

(catch): Deleted.

10:30 AM Changeset in webkit [265089] by Peng Liu

2 edits in trunk/Source/WebKit

ASSERTION FAILED: !isInRoutingArbitrationForArbitrator(proxy) in WebKit::SharedArbitrator::beginRoutingArbitrationForArbitrator
https://bugs.webkit.org/show_bug.cgi?id=214904

Reviewed by Jer Noble.

Only add an AudioSessionRoutingArbitratorProxy to the WeakHashSet (m_arbitrators)
if the routing arbitration is completed successfully.

UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm:

(WebKit::SharedArbitrator::beginRoutingArbitrationForArbitrator):

10:12 AM Changeset in webkit [265088] by graouts@webkit.org

3 edits
2 adds in trunk

[iOS] Unable to swipe on IMDB.com after long press on image
https://bugs.webkit.org/show_bug.cgi?id=214968
<rdar://problem/66234421>

Reviewed by Wenson Hsieh.

Source/WebCore:

When a long press occurs on an <img>, a system drag interaction is initiated on iOS. In WebCore,
EventHandler::tryToBeginDragAtPoint() is called and a synthetic mouse event is produced, causing
handleMousePressEvent() to be called. Further down the call chain, dispatchPointerEventIfNeeded()
is called and a valid PointerEvent is generated in PointerCaptureController::pointerEventForMouseEvent()
with "pointerType" set to "mouse", even though there is already a touch interaction initiated.

We now check whether there are known touches before generating a PointerEvent for a MouseEvent.

In the case of IMDb, the page would keep track of "pointerdown" events to track whether a multi-touch
user gesture is in progress so that their slide shows can support two-finger zooming as well as
single-finger swiping. In the case of a long press, the second "pointerdown" event would trick
the code in thinking a zoom gesture was initiated and it never recovered.

Test: pointerevents/ios/long-press-yields-single-pointerdown-event.html

page/PointerCaptureController.cpp:

(WebCore::PointerCaptureController::pointerEventForMouseEvent):

LayoutTests:

Add a test that triggers a long press gesture on an <img> and checks a single "pointerdown" event
was dispatched. Prior to the WebCore change in this patch, two events would be dispatched.

pointerevents/ios/long-press-yields-single-pointerdown-event-expected.txt: Added.
pointerevents/ios/long-press-yields-single-pointerdown-event.html: Added.

9:36 AM Changeset in webkit [265087] by pvollan@apple.com

6 edits in trunk/Source/WebKit

Remember to check entitlement before communicating over XPC
https://bugs.webkit.org/show_bug.cgi?id=214825

Reviewed by Brent Fulgham.

Remember to check entitlement before communicating over XPC with another WebKit process. This needs to be done
to make sure that it really is a WebKit process on the other end.

NetworkProcess/NetworkProcess.cpp:

(WebKit::m_messagePortChannelRegistry):

Shared/Cocoa/XPCEndpoint.mm:

(WebKit::XPCEndpoint::XPCEndpoint):

Shared/Cocoa/XPCEndpointClient.mm:

(WebKit::XPCEndpointClient::setEndpoint):

WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::platformDidReceiveLoadParameters):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::handleXPCEndpointMessages const):

9:32 AM Changeset in webkit [265086] by Chris Dumez

57 edits in trunk

OfflineAudioContext.startRendering() should return a Promise
https://bugs.webkit.org/show_bug.cgi?id=214940

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

A lot of Web Audio web-platform-tests were unable to run properly due to OfflineAudioContext.startRendering()
not returning a Promise. Now that we fixed that, a lot of tests are actually running much further. We get a
lot of new PASS lines. We also get new FAIL lines too for subtests that are now running and failing but
previously could not even run.

web-platform-tests/webaudio/idlharness.https.window-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-gain-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-reuse-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-grain-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-one-sample-loop-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-start-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiosource-onended-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiosource-time-limits-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sample-accurate-scheduling-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-suspend-resume-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-order-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-connect-audioratesignal-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-summingjunction-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/setTargetAtTime-after-event-within-block-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/setValueAtTime-within-block-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-disconnect-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-input-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-input-non-default-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-channelsplitternode-interface/audiochannelsplitter-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolution-mono-mono-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delaynode-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delaynode-max-default-delay-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delaynode-max-nondefault-delay-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delaynode-maxdelay-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delaynode-maxdelaylimit-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delaynode-scheduling-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/test-pannernode-automation-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-expected.txt:

Source/WebCore:

OfflineAudioContext.startRendering() should return a Promise:

https://www.w3.org/TR/webaudio/#dom-offlineaudiocontext-startrendering

This is important as it was preventing a lot of web-platform-tests from running
properly and our test coverage was therefore really poor.

No new tests, rebaselined existing tests.

Modules/webaudio/AudioBuffer.idl:
Modules/webaudio/AudioDestinationNode.h:
Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::finishedRendering):

Modules/webaudio/BaseAudioContext.h:

(WebCore::BaseAudioContext::didFinishOfflineRendering):

Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::startRendering):

Modules/webaudio/DefaultAudioDestinationNode.h:
Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::startOfflineRendering):
(WebCore::OfflineAudioContext::didFinishOfflineRendering):

Modules/webaudio/OfflineAudioContext.h:
Modules/webaudio/OfflineAudioContext.idl:
Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::startRendering):

Modules/webaudio/OfflineAudioDestinationNode.h:

9:31 AM Changeset in webkit [265085] by Kate Cheney

5 edits
4 adds in trunk/Source/WebKit

REGRESSION (r264925): run-safari --debug no longer works
https://bugs.webkit.org/show_bug.cgi?id=214947
<rdar://problem/66297850>

Reviewed by Darin Adler.

Removing these APIs in WebKit caused older versions of Safari to
break. We should add back in empty functions to make this work.

No new tests. Manually verified this fix.

Shared/API/c/WKRenderLayer.cpp: Added.

(WKRenderLayerGetTypeID):
(WKRenderLayerGetRenderer):
(WKRenderLayerCopyRendererName):
(WKRenderLayerCopyElementTagName):
(WKRenderLayerCopyElementID):
(WKRenderLayerGetElementClassNames):
(WKRenderLayerGetAbsoluteBounds):
(WKRenderLayerIsClipping):
(WKRenderLayerIsClipped):
(WKRenderLayerIsReflection):
(WKRenderLayerGetCompositingLayerType):
(WKRenderLayerGetBackingStoreMemoryEstimate):
(WKRenderLayerGetNegativeZOrderList):
(WKRenderLayerGetNormalFlowList):
(WKRenderLayerGetPositiveZOrderList):
(WKRenderLayerGetFrameContentsLayer):

Shared/API/c/WKRenderLayer.h: Added.
Shared/API/c/WKRenderObject.cpp: Added.

(WKRenderObjectGetTypeID):
(WKRenderObjectCopyName):
(WKRenderObjectCopyTextSnippet):
(WKRenderObjectGetTextLength):
(WKRenderObjectCopyElementTagName):
(WKRenderObjectCopyElementID):
(WKRenderObjectGetElementClassNames):
(WKRenderObjectGetAbsolutePosition):
(WKRenderObjectGetFrameRect):
(WKRenderObjectGetChildren):

Shared/API/c/WKRenderObject.h: Added.
Sources.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderTree):
(WKBundlePageCopyRenderLayerTree):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

9:17 AM Changeset in webkit [265084] by Darin Adler

61 edits in trunk/Source

Further reduction in the use of live ranges, particularly in headers
https://bugs.webkit.org/show_bug.cgi?id=214793

Reviewed by Sam Weinig.

Source/WebCore:

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::performTextOperation): Do not call createLiveRange.
(WebCore::AccessibilityObject::replaceTextInRange): Ditto.

dom/SimpleRange.cpp: Moved makeSimpleRange functions to the header.
dom/SimpleRange.h: Reworked the makeSimpleRange implementation to avoid a mistake

which made template expansion infinitely recurse while compiling and crash the compiler.
Ended up moving all the code to the header. Should be a good thing; I expect it will
optimize well inlined.

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphs): Use makeSimpleRange.

editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithText): Do not call createLiveRange.
(WebCore::Editor::setComposition): Use SimpleRange.
(WebCore::Editor::stringForCandidateRequest const): Do not call createLiveRange.
(WebCore::Editor::handleAcceptedCandidate): Use auto intead of RefPtr<Range>.

editing/EditorCommand.cpp:

(WebCore::expandSelectionToGranularity): Do not call createLiveRange.
(WebCore::executeDeleteToMark): Ditto.
(WebCore::executeSelectToMark): Ditto.
(WebCore::valueFormatBlock): Ditto.

editing/FormatBlockCommand.cpp:

(WebCore::FormatBlockCommand::formatRange): Use makeSimpleRange.
(WebCore::FormatBlockCommand::elementForFormatBlockCommand): Take a
SimpleRange.

editing/FormatBlockCommand.h: Updated for above.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::moveTo): Deleted overload taking a live range.
(WebCore::FrameSelection::setSelectedRange): Take a SimpleRange.

editing/FrameSelection.h: Updated for above.

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment): Do not call
createLiveRange.

editing/VisibleUnits.cpp:

(WebCore::enclosingTextUnitOfGranularity): Return SimpleRange.
(WebCore::wordRangeFromPosition): Ditto.
(WebCore::closestWordBoundaryForPosition): Use SimpleRange.
(WebCore::rangeExpandedByCharactersInDirectionAtWordBoundary): Return
a SimpleRange.
(WebCore::rangeExpandedAroundPositionByCharacters): Ditto.
(WebCore::wordBoundaryForPositionWithoutCrossingLine): Use SimpleRange.

editing/VisibleUnits.h: Updated for above.

editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectItemAroundHitTestResult):
Use SimpleRange.

editing/cocoa/DictionaryLookup.mm:

(WebCore::DictionaryLookup::rangeForSelection): Use SimpleRange.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Ditto.

editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::getPasteboardTypesAndDataForAttachment):
Do not call createLiveRange.

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::WebContentReader::readPlainText): Ditto.

editing/gtk/WebContentReaderGtk.cpp:

(WebCore::WebContentReader::readPlainText): Ditto.

editing/libwpe/EditorLibWPE.cpp:

(WebCore::createFragmentFromPasteboardData): Ditto.

editing/mac/DictionaryLookupLegacy.mm:

(WebCore::DictionaryLookup::rangeAtHitTestResult): Use SimpleRange.

editing/markup.cpp:

(WebCore::serializePreservingVisualAppearance): Take SimpleRange.
(WebCore::contextPreservesNewline): Ditto.
(WebCore::createFragmentFromText): Ditto.

editing/markup.h: Updated for above.

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create): Take SimpleRange.

loader/archive/cf/LegacyWebArchive.h: Updated for above.

page/DragController.cpp:

(WebCore::DragController::performDragOperation): Use SimpleRange.
(WebCore::DragController::concludeEditDrag): Do not call createLiveRange.
(WebCore::selectElement): Use SimpleRange.
(WebCore::DragController::removeAllDroppedImagePlaceholders): Ditto.
(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret): Ditto.

page/DragController.h: Use SimpleRange.

page/Page.cpp:

(WebCore::Page::findTextMatches): Return vector of SimpleRange, in
structure so we have one return value instead of two out arguments.
Also renamed from findStringMatchingRanges.
(WebCore::Page::rangeOfString): Return SimpleRange.
(WebCore::replaceRanges): Do not call createLiveRange.
(WebCore::Page::replaceRangesWithText): Take SimpleRange.

page/Page.h: Updated for above.

page/ios/FrameIOS.mm:

(WebCore::Frame::wordsInCurrentParagraph const): Use SimpleRange.

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::isOverTextInsideFormControlElement const):
Use SimpleRange, and also use hasAnyPlainText instead of computing
the plain text string and checking if it's empty.

Source/WebKit:

Shared/API/c/mac/WKWebArchiveRef.cpp:

(WKWebArchiveCreateFromRange): Use makeSimpleRange.

Shared/APIWebArchive.h: Use SimpleRange.
Shared/APIWebArchive.mm:

(API::WebArchive::create): Take SimpleRange.

Shared/EditingRange.cpp:

(WebKit::EditingRange::toRange): Don't call createLiveRange.
(WebKit::EditingRange::fromRange): Take SimpleRange.

Shared/EditingRange.h: Updated for above.

WebProcess/InjectedBundle/API/APIInjectedBundleEditorClient.h:

Take SimpleRange, String, StyleProperties instead of
Range, StringImpl, CSSStyleDeclaration.

WebProcess/InjectedBundle/API/glib/WebKitWebEditor.cpp:

String instead of StringImpl.

WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:

(-[WKDOMDocument createDocumentFragmentWithText:]): Use SimpleRange.

WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange rangeByExpandingToWordBoundaryByCharacters:inDirection:]):
Use SimpleRange and createLiveRange.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]):
Updated for changes to bundle editor client.

WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::create): Deleted. Moved the
code into InjectedBundleRangeHandle::getOrCreate.
(WebKit::createHandle): Added. Makes a handle for a SimpleRange.

WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:

Updated for above.

WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::createHandle): Added. Makes a handle for a CSSStyleDeclaration.
(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
Updated for changes to bundle editor client.
(WebKit::InjectedBundlePageEditorClient::shouldEndEditing): Ditto.
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode): Ditto.
(WebKit::InjectedBundlePageEditorClient::shouldInsertText): Ditto.
(WebKit::InjectedBundlePageEditorClient::shouldDeleteRange): Ditto.
(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange): Ditto.
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle): Ditto.
(WebKit::InjectedBundlePageEditorClient::didBeginEditing): Ditto.
(WebKit::InjectedBundlePageEditorClient::didEndEditing): Ditto.
(WebKit::InjectedBundlePageEditorClient::didChange): Ditto.
(WebKit::InjectedBundlePageEditorClient::didChangeSelection): Ditto.
(WebKit::InjectedBundlePageEditorClient::willWriteToPasteboard): Ditto.
(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange): Ditto.
(WebKit::InjectedBundlePageEditorClient::performTwoStepDrop): Ditto.

WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:

Updated for above.

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldDeleteRange): Updated to call new
revised bundle editor client.
(WebKit::WebEditorClient::shouldBeginEditing): Ditto.
(WebKit::WebEditorClient::shouldEndEditing): Ditto.
(WebKit::WebEditorClient::shouldInsertNode): Ditto.
(WebKit::WebEditorClient::shouldInsertText): Ditto.
(WebKit::WebEditorClient::shouldChangeSelectedRange): Ditto.
(WebKit::WebEditorClient::shouldApplyStyle): Ditto.
(WebKit::WebEditorClient::willWriteSelectionToPasteboard): Ditto.
(WebKit::WebEditorClient::getClientPasteboardData): Ditto.
(WebKit::WebEditorClient::performTwoStepDrop): Ditto.
(WebKit::insertionPointFromCurrentSelection): Use SimpleRange.

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::replaceMatches): Use SimpleRange.
(WebKit::FindController::findString): Updated for change to
Page::findTextMatches function.
(WebKit::FindController::findStringMatches): Ditto.
(WebKit::FindController::getImageForFindMatch): Use SimpleRange.
(WebKit::FindController::selectFindMatch): Ditto.

WebProcess/WebPage/FindController.h: Updated for above.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getMarkedRangeAsync): Do not call createLiveRange.
(WebKit::WebPage::getSelectedRangeAsync): Ditto.
(WebKit::WebPage::characterIndexForPointAsync): Call makeSimpleRange.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::plainTextForContext): Changed overloads a bit to work
better with Optional<SimpleRange> and removed the ones that explicitly
take a Range, updating callers to compensate.
(WebKit::plainTextForDisplay): Ditto.
(WebKit::WebPage::getPlatformEditorState const): Use SimpleRange.
(WebKit::WebPage::getSelectionContext): Ditto.
(WebKit::WebPage::didConcludeEditDrag): Ditto.
(WebKit::WebPage::handleStylusSingleTapAtPoint): Ditto.
(WebKit::WebPage::selectWithGesture): Ditto.
(WebKit::rangeForPointInRootViewCoordinates): Return SimpleRange.
(WebKit::rangeAtWordBoundaryForPosition): Ditto.
(WebKit::WebPage::updateSelectionWithTouches): Use SimpleRange.
(WebKit::WebPage::selectWithTwoTouches): Ditto.
(WebKit::WebPage::extendSelection): Ditto.
(WebKit::WebPage::selectWordBackward): Ditto.
(WebKit::WebPage::moveSelectionByOffset): Ditto.
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Ditto.
(WebKit::WebPage::selectPositionAtPoint): Ditto.
(WebKit::WebPage::selectPositionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::moveSelectionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::rangeForGranularityAtPoint): Ditto.
(WebKit::WebPage::selectTextWithGranularityAtPoint): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPoint): Ditto.
(WebKit::WebPage::replaceSelectedText): Ditto.
(WebKit::WebPage::replaceDictatedText): Ditto.
(WebKit::WebPage::requestAutocorrectionData): Ditto.
(WebKit::WebPage::applyAutocorrectionInternal): Ditto.
(WebKit::WebPage::autocorrectionContext): Ditto.
(WebKit::dataDetectorLinkPositionInformation): Ditto.
(WebKit::WebPage::updateSelectionWithDelta): Ditto.
(WebKit::WebPage::focusTextInputContextAndPlaceCaret): Ditto.

Source/WebKitLegacy/ios:

WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition enclosingTextUnitOfGranularity:inDirectionIfAtBoundary:]):
Use SimpleRange.

Source/WebKitLegacy/mac:

DOM/DOMHTML.mm:

(-[DOMHTMLDocument createDocumentFragmentWithText:]): Use SimpleRange.

DOM/DOMUIKitExtensions.mm:

(-[DOMRange move:inDirection:]): Ditto.
(-[DOMRange extend:inDirection:]): Ditto.

DOM/WebDOMOperations.mm:

(-[DOMRange webArchive]): Ditto.

WebView/WebFrame.mm:

(-[WebFrame _firstRectForDOMRange:]): Moved a "*" to save a little work.
(-[WebFrame setSelectedDOMRange:affinity:closeTyping:userTriggered:]):
Use SimpleRange.
(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:matchStyle:]):
Ditto.
(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
Ditto.
(-[WebFrame _documentFragmentForText:]): Ditto.

WebView/WebView.mm:

(-[WebView DOMRangeOfString:relativeTo:options:]): Ditto.
(-[WebView setSelectedDOMRange:affinity:]): Ditto.

Source/WebKitLegacy/win:

AccessibleTextImpl.cpp: Added an include of Range.h.

9:04 AM Changeset in webkit [265083] by Truitt Savell

2 edits in trunk/LayoutTests

[ macOS wk1 ] imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_hoverable_pointers.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=214967

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-07-30

platform/mac-wk1/TestExpectations:

8:55 AM Changeset in webkit [265082] by Jonathan Bedard

6 edits in trunk/Tools

[Big Sur] Add limited Seed 3 support to EWS
https://bugs.webkit.org/show_bug.cgi?id=214874
<rdar://problem/66216190>

Reviewed by Aakash Jain.

BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble): Add AppleSilicon bubbles.

BuildSlaveSupport/ews-build/config.json: Add AppleSilicon device.
BuildSlaveSupport/ews-build/factories.py:

(macOSBuildOnlyFactory): Skip uploading to S3.

BuildSlaveSupport/ews-build/factories_unittest.py:

(TestBuildFactory.test_macos_build_only_factory):

BuildSlaveSupport/ews-build/loadConfig.py: Import macOSBuildOnlyFactory.

8:10 AM Changeset in webkit [265081] by commit-queue@webkit.org

22 edits in trunk

Remove non-inclusive terminology from WebKit variable names and test-only SPI
https://bugs.webkit.org/show_bug.cgi?id=214941

Patch by Alex Christensen <achristensen@webkit.org> on 2020-07-30
Reviewed by Michael Catanzaro.

Source/WebKit:

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::addOriginAccessAllowListEntry):
(WebKit::NetworkConnectionToWebProcess::removeOriginAccessAllowListEntry):
(WebKit::NetworkConnectionToWebProcess::resetOriginAccessAllowLists):
(WebKit::NetworkConnectionToWebProcess::addOriginAccessWhitelistEntry): Deleted.
(WebKit::NetworkConnectionToWebProcess::removeOriginAccessWhitelistEntry): Deleted.
(WebKit::NetworkConnectionToWebProcess::resetOriginAccessWhitelists): Deleted.

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

Shared/WebProcessCreationParameters.h:
UIProcess/API/glib/WebKitUserContent.cpp:

(_WebKitUserStyleSheet::_WebKitUserStyleSheet):
(webkit_user_style_sheet_new):
(webkit_user_style_sheet_new_for_world):
(_WebKitUserScript::_WebKitUserScript):
(webkit_user_script_new):
(webkit_user_script_new_for_world):

UIProcess/API/glib/WebKitWebContext.cpp:

(pathIsBlocked):
(webkit_web_context_add_path_to_sandbox):
(pathIsBlacklisted): Deleted.

UIProcess/API/gtk/WebKitUserContent.h:
UIProcess/API/wpe/WebKitUserContent.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::setupSeccomp):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setFontAllowList):

UIProcess/WebProcessPool.h:
WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleAddOriginAccessAllowListEntry):
(WKBundleRemoveOriginAccessAllowListEntry):
(WKBundleResetOriginAccessAllowLists):
(WKBundleAddOriginAccessWhitelistEntry): Deleted.
(WKBundleRemoveOriginAccessWhitelistEntry): Deleted.
(WKBundleResetOriginAccessWhitelists): Deleted.

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::addOriginAccessAllowListEntry):
(WebKit::InjectedBundle::removeOriginAccessAllowListEntry):
(WebKit::InjectedBundle::resetOriginAccessAllowLists):
(WebKit::InjectedBundle::addOriginAccessWhitelistEntry): Deleted.
(WebKit::InjectedBundle::removeOriginAccessWhitelistEntry): Deleted.
(WebKit::InjectedBundle::resetOriginAccessWhitelists): Deleted.

WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::addOriginAccessWhitelistEntry):
(WTR::TestRunner::removeOriginAccessWhitelistEntry):

1:53 AM Changeset in webkit [265080] by Carlos Garcia Campos

26 edits in trunk

[GTK4] Enable API tests
https://bugs.webkit.org/show_bug.cgi?id=214344

Reviewed by Adrian Perez de Castro.

Build API tests for GTK4 too.

Source/cmake/OptionsGTK.cmake:

Source/WebKit:

Use a custom KeyEvent struct to pass to the IM filter as a fake GdkEvent to be able to test input methods with
GTK4.

UIProcess/API/glib/InputMethodFilter.h:
UIProcess/API/gtk/InputMethodFilterGtk.cpp:

(WebKit::InputMethodFilter::platformEventKeyIsKeyPress const):
(WebKit::InputMethodFilter::filterKeyEvent):

UIProcess/API/gtk/WebKitWebViewBaseInternal.h:
UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:

(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::start):
(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::stop):

Tools:

Port API tests to GTK4. Context menu and option menu tests are still disabled for GTK4 because we plan to change
the API for GTK4 in those cases.

TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:

(beforeAll):

TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:

(webkitInputMethodContextMockFilterKeyEvent):

TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:

(beforeAll):

TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:

(checkMimeTypeForFilter):

TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebExtensionInputElementIsUserEdited):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:

(main):

TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:

(testContextMenuPopulateMenu):
(beforeAll):

TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:

(Clipboard::Clipboard):
(Clipboard::clear):
(Clipboard::containsText const):
(Clipboard::waitForText):
(Clipboard::readText):
(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(testWebViewEditorSelectAllNonEditable):
(testWebViewEditorSelectAllEditable):
(loadContentsAndTryToCutSelection):

TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::Test):

TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:

(WebViewTest::platformDestroy):
(WebViewTest::showInWindow):

TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:

(TestWebKitAPI::Util::isKeyDown):

TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::initialize):

12:21 AM Changeset in webkit [265079] by beidson@apple.com

24 edits
6 copies
3 adds in trunk

Refactor HID gamepad code to be much less fragile and much easier to hack on.
https://bugs.webkit.org/show_bug.cgi?id=214910

Reviewed by Darin Adler.

Source/WebCore:

Covered by API tests.

Currently - for HID device gamepads - we throw all buttons and axes against the wall and see what sticks.
Instead, for specific popular devices, we'd like to have device-specific mappings so the representation makes sense.

To support that work, this is a major refactoring of the HID gamepad code. It does the following:

Breaks out logic specific to IOHIDDeviceRef into HIDDevice

Breaks out logic specific to IOHIDElementRef into HIDElement

Moves responsibities of managing things to the right places (e.g. HIDElement manages its own current value directly)

Makes HIDGamepadElement derive from HIDElement directly

Moves device specific logic from HIDGamepad into a subclass of HID gamepad. Currently the only subclass is "generic" which encompasses HIDGamepad's old behavior

Changes button/value vectors from Vector<double> to Vector<SharedGamepadValue> so multiple objects can reference the value at once. e.g. HIDGamepadButton can simply update it's own SharedGamepadValue without knowing which HIDGamepad owns it or which index into the gamepad's value vector it should be mutating.

This will be critical in the "specific device mapping" work as some types of HIDElements actually drive more than one
gamepad button value.
e.g. a "direction pad axis" actually manages 2 button values, or a "hat-switch" direction pad manages 4 button values

This patch doesn't change any current behavior.

Modules/gamepad/Gamepad.cpp:

(WebCore::Gamepad::updateFromPlatformGamepad):

Sources.txt:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:

platform/Logging.h:

platform/gamepad/PlatformGamepad.h:

platform/gamepad/SharedGamepadValue.h: Copied from Source/WebKit/UIProcess/Gamepad/UIGamepad.h.

(WebCore::SharedGamepadValue::SharedGamepadValue):
(WebCore::SharedGamepadValue::setValue):
(WebCore::SharedGamepadValue::value const):
(WebCore::SharedGamepadValue::Data::Data):

platform/gamepad/cocoa/GameControllerGamepad.h:
platform/gamepad/cocoa/GameControllerGamepad.mm:

(WebCore::GameControllerGamepad::setupAsExtendedGamepad):
(WebCore::GameControllerGamepad::setupAsGamepad):

platform/gamepad/mac/GenericHIDGamepad.cpp: Added.

(WebCore::GenericHIDGamepad::GenericHIDGamepad):
(WebCore::GenericHIDGamepad::id):
(WebCore::GenericHIDGamepad::maybeAddGenericDesktopElement):
(WebCore::GenericHIDGamepad::maybeAddButtonElement):

platform/gamepad/mac/GenericHIDGamepad.h: Copied from Source/WebKit/WebProcess/Gamepad/WebGamepad.h.

platform/gamepad/mac/HIDGamepad.cpp:

(WebCore::HIDGamepad::create):
(WebCore::HIDGamepad::HIDGamepad):
(WebCore::HIDGamepad::initialize):
(WebCore::HIDGamepad::valueChanged):
(WebCore::HIDGamepad::getCurrentValueForElement): Deleted.
(WebCore::HIDGamepad::initElements): Deleted.
(WebCore::HIDGamepad::initElementsFromArray): Deleted.
(WebCore::HIDGamepad::maybeAddButton): Deleted.
(WebCore::HIDGamepad::maybeAddAxis): Deleted.

platform/gamepad/mac/HIDGamepad.h:

(WebCore::HIDGamepad::hidDevice const):
(WebCore::HIDGamepadElement::HIDGamepadElement): Deleted.
(WebCore::HIDGamepadElement::~HIDGamepadElement): Deleted.
(WebCore::HIDGamepadElement::isButton const): Deleted.
(WebCore::HIDGamepadElement::isAxis const): Deleted.
(WebCore::HIDGamepadButton::HIDGamepadButton): Deleted.
(WebCore::HIDGamepadAxis::HIDGamepadAxis): Deleted.

platform/gamepad/mac/HIDGamepadElement.cpp: Added.

(WebCore::HIDGamepadElement::HIDGamepadElement):
(WebCore::HIDGamepadElement::refreshCurrentValue):
(WebCore::HIDGamepadElement::normalizedValue):
(WebCore::HIDGamepadButton::gamepadValueChanged):
(WebCore::HIDGamepadAxis::gamepadValueChanged):
(WebCore::HIDGamepadAxis::normalizedValue):

platform/gamepad/mac/HIDGamepadElement.h: Copied from Source/WebCore/platform/gamepad/PlatformGamepad.h.

(WebCore::HIDGamepadElement::~HIDGamepadElement):
(WebCore::HIDGamepadElement::isButton const):
(WebCore::HIDGamepadElement::isAxis const):

platform/gamepad/mac/HIDGamepadProvider.mm:

(WebCore::HIDGamepadProvider::deviceAdded):

platform/gamepad/mac/MultiGamepadProvider.h:

platform/graphics/cocoa/SourceBufferParserWebM.cpp:

platform/mac/HIDDevice.cpp: Added.

(WebCore::HIDDevice::HIDDevice):
(WebCore::HIDDevice::uniqueInputElementsInDeviceTreeOrder const):

platform/mac/HIDDevice.h: Copied from Source/WebCore/platform/gamepad/PlatformGamepad.h.

(WebCore::HIDDevice::rawElement const):
(WebCore::HIDDevice::vendorID const):
(WebCore::HIDDevice::productID const):
(WebCore::HIDDevice::productName const):

platform/mac/HIDElement.cpp: Copied from Source/WebKit/UIProcess/Gamepad/UIGamepad.h.

(WebCore::HIDElement::HIDElement):
(WebCore::HIDElement::valueChanged):

platform/mac/HIDElement.h: Copied from Source/WebKit/UIProcess/Gamepad/UIGamepad.h.

(WebCore::HIDElement::rawElement const):
(WebCore::HIDElement::physicalMin const):
(WebCore::HIDElement::physicalMax const):
(WebCore::HIDElement::physicalValue const):
(WebCore::HIDElement::usage const):
(WebCore::HIDElement::usagePage const):
(WebCore::HIDElement::cookie const):