Timeline
Aug 18, 2020:
- 9:03 PM Changeset in webkit [265848] by
-
- 4 edits in trunk/LayoutTests
[GTK][WPE] Gardening
Unreviewed test gardening.
- platform/glib/TestExpectations:
- platform/wpe/TestExpectations:
- platform/wpe/webgl/1.0.3/conformance/context/methods-expected.txt:
Rebaselined after r265711.
- 8:15 PM Changeset in webkit [265847] by
-
- 6 edits in trunk/LayoutTests
[ macOS iOS ] fast/text/emoji-gender* text expectations change
https://bugs.webkit.org/show_bug.cgi?id=215636
Unreviewed test gardening.
- TestExpectations:
- platform/glib/TestExpectations:
- platform/ios-wk1/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 7:34 PM Changeset in webkit [265846] by
-
- 5 edits1 add in trunk
[run-webkit-tests] Rosetta specific test expectations
https://bugs.webkit.org/show_bug.cgi?id=215633
<rdar://problem/67353771>
Reviewed by Darin Adler.
Tools:
- Scripts/webkitpy/port/mac.py:
(MacPort.expectations_dict): Add special case for Rosetta expectations.
- Scripts/webkitpy/port/mac_unittest.py:
(MacTest.test_rosetta_expectations):
LayoutTests:
- platform/mac/TestExpectations: Move Rosetta expectations.
- platform/mac/TestExpectationsRosetta: Added.
- 7:24 PM Changeset in webkit [265845] by
-
- 5 edits in trunk
AudioBuffer.duration should use double precision
https://bugs.webkit.org/show_bug.cgi?id=215632
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT test now that more checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-expected.txt:
Source/WebCore:
AudioBuffer.duration should use double precision:
No new tests, rebaselined existing test.
- Modules/webaudio/AudioBuffer.h:
(WebCore::AudioBuffer::duration const):
- Modules/webaudio/AudioBuffer.idl:
- 6:28 PM Changeset in webkit [265844] by
-
- 5 edits in trunk/Source/WebCore
Rename replaceAllChildren to replaceAllChildrenWithNewText
https://bugs.webkit.org/show_bug.cgi?id=215634
Reviewed by Darin Adler.
Renamed ContainerNode::replaceAllChildren to replaceAllChildrenWithNewText and changed
the type of Argument from Ref<Node>&& to const String&.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceAllChildrenWithNewText):
- dom/ContainerNode.h:
- dom/Node.cpp:
(WebCore::Node::setTextContent):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerText):
- 5:59 PM Changeset in webkit [265843] by
-
- 1 copy in tags/Safari-610.1.28
Tag Safari-610.1.28.
- 5:54 PM Changeset in webkit [265842] by
-
- 12 edits in trunk
Fix for accessibility/mac/aria-expanded-notifications.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=215613
Reviewed by Darin Adler.
Source/WebCore:
Test: accessibility/mac/aria-expanded-notifications.html.
Refactored AXObjectCache::handleAriaExpandedChange so that it doesn't
call into AccessibilityObject to handle the notification, to then call
into AXObjectCache again. The new implementation is cleaner and more
straightforward.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::updateIsolatedTree): Updates the isolated tree
on the row expanded/collapsed-related notifications.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsRowCountChange const): Added.
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
Deleted, not needed any longer since it is handled in AXObjectCache where
it should.
- accessibility/AccessibilityRenderObject.h:
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData): Caches the
supportsRowCountChange property.
(WebCore::AXIsolatedObject::handleAriaExpandedChanged): Deleted, not
needed any longer.
- accessibility/isolatedtree/AXIsolatedObject.h:
LayoutTests:
- accessibility/mac/aria-expanded-notifications-expected.txt:
- accessibility/mac/aria-expanded-notifications.html: Removed unnecessary
call to accessibilityController.focusedElement. Some code cleanup.
- 4:49 PM Changeset in webkit [265841] by
-
- 33 edits in trunk
[WebGL2] Various parameters should be non-nullable in IDL
https://bugs.webkit.org/show_bug.cgi?id=215616
Patch by James Darpinian <James Darpinian> on 2020-08-18
Reviewed by Kenneth Russell.
Source/WebCore:
Fixes 5 conformance tests:
conformance/misc/error-reporting.html
conformance/misc/null-object-behaviour.html
conformance/misc/bad-arguments-test.html
conformance/textures/misc/tex-sub-image-2d-bad-args.html
conformance/programs/get-active-test.html
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::attachShader):
(WebCore::WebGLRenderingContextBase::bindAttribLocation):
(WebCore::WebGLRenderingContextBase::compileShader):
(WebCore::WebGLRenderingContextBase::detachShader):
(WebCore::WebGLRenderingContextBase::getActiveAttrib):
(WebCore::WebGLRenderingContextBase::getActiveUniform):
(WebCore::WebGLRenderingContextBase::getAttachedShaders):
(WebCore::WebGLRenderingContextBase::getAttribLocation):
(WebCore::WebGLRenderingContextBase::getProgramParameter):
(WebCore::WebGLRenderingContextBase::getProgramInfoLog):
(WebCore::WebGLRenderingContextBase::getShaderParameter):
(WebCore::WebGLRenderingContextBase::getShaderInfoLog):
(WebCore::WebGLRenderingContextBase::getShaderSource):
(WebCore::WebGLRenderingContextBase::getUniform):
(WebCore::WebGLRenderingContextBase::getUniformLocation):
(WebCore::WebGLRenderingContextBase::linkProgram):
(WebCore::WebGLRenderingContextBase::shaderSource):
(WebCore::WebGLRenderingContextBase::validateProgram):
- html/canvas/WebGLRenderingContextBase.h:
- html/canvas/WebGLRenderingContextBase.idl:
- inspector/InspectorShaderProgram.cpp:
(WebCore::InspectorShaderProgram::updateShader):
LayoutTests:
- fast/canvas/webgl/context-lost-expected.txt:
- fast/canvas/webgl/context-lost.html:
- fast/canvas/webgl/error-reporting-expected.txt:
- fast/canvas/webgl/error-reporting.html:
- fast/canvas/webgl/get-active-test-expected.txt:
- fast/canvas/webgl/get-active-test.html:
- fast/canvas/webgl/gl-object-get-calls-expected.txt:
- fast/canvas/webgl/gl-object-get-calls.html:
- fast/canvas/webgl/null-object-behaviour-expected.txt:
- fast/canvas/webgl/null-object-behaviour.html:
- inspector/canvas/recording-webgl-frameCount.html:
- inspector/canvas/recording-webgl-full-expected.txt:
- inspector/canvas/recording-webgl-full.html:
- inspector/canvas/recording-webgl-memoryLimit.html:
- inspector/canvas/recording-webgl-snapshots.html:
- inspector/canvas/recording-webgl2-frameCount.html:
- inspector/canvas/recording-webgl2-full.html:
- inspector/canvas/recording-webgl2-memoryLimit.html:
- inspector/canvas/recording-webgl2-snapshots.html:
- inspector/canvas/resources/recording-webgl.js:
(load):
- webgl/2.0.0/conformance/misc/bad-arguments-test-expected.txt:
- webgl/2.0.0/conformance/misc/error-reporting-expected.txt:
- webgl/2.0.0/conformance/misc/null-object-behaviour-expected.txt:
- webgl/2.0.0/conformance/programs/get-active-test-expected.txt:
- webgl/2.0.0/conformance/state/gl-object-get-calls-expected.txt:
- webgl/2.0.0/conformance/textures/misc/tex-sub-image-2d-bad-args-expected.txt:
- webgl/2.0.0/conformance2/state/gl-object-get-calls-expected.txt:
- 4:44 PM Changeset in webkit [265840] by
-
- 2 edits in trunk/Tools
Unreviewed, contributors.json is broken
- Scripts/webkitpy/common/config/contributors.json:
- 4:22 PM Changeset in webkit [265839] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Adding some Google folks to contributors.
- Scripts/webkitpy/common/config/contributors.json:
- 4:15 PM Changeset in webkit [265838] by
-
- 5 edits in trunk
PannerNode's rolloffFactor should be clamped to [0, 1] internally when distanceModel is "linear"
https://bugs.webkit.org/show_bug.cgi?id=215625
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
Source/WebCore:
PannerNode's rolloffFactor should be clamped to [0, 1] internally when distanceModel is "linear":
No new tests, rebaselined existing test.
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::setRolloffFactor):
- platform/audio/Distance.cpp:
(WebCore::DistanceEffect::linearGain):
- 4:01 PM Changeset in webkit [265837] by
-
- 2 edits in trunk/Websites/webkit.org
- languages.md: Fixed "Movaje" typo.
- 3:51 PM Changeset in webkit [265836] by
-
- 4 edits in trunk
ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext
https://bugs.webkit.org/show_bug.cgi?id=215624
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT test that is now passing.
- web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
Source/WebCore:
ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext.
If the context is an OfflineAudioContext, then it should pause processing until the script has finished
execution. This aligns our behavior with Blink and helps us pass more WPT tests.
No new tests, rebaselined existing test.
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):
- 3:18 PM Changeset in webkit [265835] by
-
- 4 edits in trunk
WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.
Source/WebKit:
We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.
However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.
Covered by an API test.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
(TestWebKitAPI::TEST):
- 2:44 PM Changeset in webkit [265834] by
-
- 3 edits in trunk/Source/WebCore
[Catalyst] Video should pause automatically when switching desktops
https://bugs.webkit.org/show_bug.cgi?id=215620
Reviewed by Jer Noble.
- platform/audio/ios/MediaSessionManagerIOS.h:
- platform/audio/ios/MediaSessionManagerIOS.mm: Don't override resetRestrictions
on Catalyst so we don't pause video in the background.
- 2:24 PM Changeset in webkit [265833] by
-
- 11 edits1 copy4 adds in trunk
[WebGL2] Pass user-defined-properties-on-context.html layout test
https://bugs.webkit.org/show_bug.cgi?id=215433
Patch by Kenneth Russell <kbr@chromium.org> on 2020-08-18
Reviewed by Yusuke Suzuki.
Source/WebCore:
Keep the canvas' rendering context alive from the canvas itself by
adding a custom mark function for HTMLCanvasElement, and adding a
new GenerateIsReachable=ImplCanvasBase extended IDL attribute,
used from all rendering context types (2D, WebGL, and WebGPU).
This patch does not touch OffscreenCanvas since the implementation
there seems to be incomplete and there are no associated tests of
GC behavior.
Tests: fast/canvas/2d.context.expando.html
webgpu/expando-properties.html
- Modules/webgpu/GPUCanvasContext.idl:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLCanvasElementCustom.cpp: Copied from Source/WebCore/html/canvas/WebGLRenderingContext.idl.
(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/IDLAttributes.json:
- html/HTMLCanvasElement.idl:
- html/canvas/WebGL2RenderingContext.idl:
- html/canvas/WebGLRenderingContext.idl:
LayoutTests:
Rebaseline user-defined-properties-on-context.html, which is now
fully passing.
Add tests of expando properties on 2D and WebGPU contexts. Add a
FIXME to the WebGPU test, as that specification no longer defines
a canvas rendering context.
- fast/canvas/2d.context.expando-expected.txt: Added.
- fast/canvas/2d.context.expando.html: Added.
- webgl/2.0.0/conformance/context/user-defined-properties-on-context-expected.txt:
- webgpu/expando-properties-expected.txt: Added.
- webgpu/expando-properties.html: Added.
- 2:13 PM Changeset in webkit [265832] by
-
- 4 edits in trunk
WaveShaperNode.curve setter should create a copy of the input array
https://bugs.webkit.org/show_bug.cgi?id=215615
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT test now that all checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:
Source/WebCore:
WaveShaperNode.curve setter should create a copy of the input array, so that follow-up modifications
of the array by the JS do not impact audio processing:
No new tests, rebaselined existing test.
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::setCurve):
- 1:58 PM Changeset in webkit [265831] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r262381): replaceChildren should not use DeferChildrenChanged::No
https://bugs.webkit.org/show_bug.cgi?id=215600
Reviewed by Antti Koivisto.
It's not correct to use DeferChildrenChanged::No when the new node may have an old parent.
Use DeferChildrenChanged::Yes instead.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceAllChildren): Added a release assertion to make sure
people don't start using this function incorrectly in the future.
(WebCore::ContainerNode::replaceChildren): Fixed the bug.
- 1:46 PM Changeset in webkit [265830] by
-
- 2 edits in trunk/Source/JavaScriptCore
Update byte offsets in JSString.h comment
https://bugs.webkit.org/show_bug.cgi?id=215621
Reviewed by Yusuke Suzuki.
- runtime/JSString.h:
- 1:22 PM Changeset in webkit [265829] by
-
- 2 edits in trunk/LayoutTests
Disable plug-in tests on Apple Silicon
Updating test expectation in include Rosetta
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:12 PM Changeset in webkit [265828] by
-
- 2 edits in trunk/LayoutTests
rdar://66861801 ([ Layout Tests] REGRESSION (r265487): svg/W3C-I18N/tspan-direction-rtl.svg is a constant failure)
Updating expectations in include Rosetta.
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 1:07 PM Changeset in webkit [265827] by
-
- 1 edit1 add in trunk/Websites/webkit.org
Document versions of C++ and Python
https://bugs.webkit.org/show_bug.cgi?id=215191
Reviewed by Jonathan Bedard.
- languages.md: Added.
- 10:53 AM Changeset in webkit [265826] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215614
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 10:08 AM Changeset in webkit [265825] by
-
- 2 edits in trunk/LayoutTests
rdar://67289434 ([ Rosetta Layout Tests ] REGRESSION (r265701): [ BigSur ] 3 webaudio/the-audio-api/the-audioparam-interface tests are a constant failure)
Should skip this only on Rosetta, not all Intel Big Sur Macs
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 10:00 AM Changeset in webkit [265824] by
-
- 11 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline webaudio WPT tests that are marked as flaky.
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:
- 9:59 AM Changeset in webkit [265823] by
-
- 9 edits in trunk
Turn off wheel event regions until we need them
https://bugs.webkit.org/show_bug.cgi?id=215586
Reviewed by Darin Adler.
Source/WebCore:
Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.
- page/scrolling/ScrollingTree.cpp:
- page/scrolling/ScrollingTree.h:
- page/scrolling/mac/ScrollingTreeMac.h:
- page/scrolling/mac/ScrollingTreeMac.mm:
Source/WTF:
Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.
- wtf/PlatformEnableCocoa.h:
LayoutTests:
Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.
- platform/mac-wk2/TestExpectations:
- 9:56 AM Changeset in webkit [265822] by
-
- 8 edits in trunk
Update platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html to account for low latency code path
https://bugs.webkit.org/show_bug.cgi?id=215601
Reviewed by Eric Carlson.
Source/WebCore:
Covered by existing/updated test.
- testing/Internals.cpp:
(WebCore::Internals::supportsVCPEncoder):
In case low latency code path is enabled, supportsVCPEncoder should return true.
LayoutTests:
Update test to check software encoder for both baseline and high profiles.
Move baseline/high profile selection routines to routines.js.
- platform/mac/webrtc/captureCanvas-webrtc-software-encoder-expected.txt:
- platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:
- webrtc/h264-baseline.html:
- webrtc/h264-high.html:
- webrtc/routines.js:
- 9:49 AM Changeset in webkit [265821] by
-
- 2 edits in trunk/LayoutTests
rdar://67281310 REGRESSION (r265639): [ BigSur ] 11 canvas layout tests are a constant failure)
Should skip this only on Rosetta, not all Intel Big Sur Macs
Clean up arm64 only gardening.
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 9:36 AM Changeset in webkit [265820] by
-
- 16 edits1 copy1 add in trunk
REGRESSION (Async overflow scrolling): No rubberbanding in overflow:scroll in the wheel event region
https://bugs.webkit.org/show_bug.cgi?id=215598
<rdar://problem/64895442>
Reviewed by Darin Adler.
Source/WebCore:
Scrolling in overflow:scroll inside the non-fast event region (e.g. inside an ancestor with a wheel event
handler) happens via ScrollAnimatorMac::handleWheelEvent() which calls ScrollableArea::setScrollOffsetFromAnimation()
which bounces to the scrolling thread via RenderLayer::requestScrollPositionUpdate(). We were clamping the
scroll offset here, thus disallowing the overscrolled offsets required for rubberbanding.
Fix is to allow clamping for user scrolls. Also add more logging.
Test: fast/scrolling/mac/rubberband-overflow-in-wheel-region.html
- dom/Element.cpp:
(WebCore::Element::dispatchWheelEvent):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::handleWheelEvent):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::handleWheelEvent):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
LayoutTests:
Remove an unneeded
var successfullyParsed = truein existing tests.
New test that detect rubberbanding.
- fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html:
- fast/scrolling/mac/async-scroll-overflow-rtl.html:
- fast/scrolling/mac/async-scroll-overflow-top-inset.html:
- fast/scrolling/mac/async-scroll-overflow.html:
- fast/scrolling/mac/hit-test-overflow-tiled-layer.html:
- fast/scrolling/mac/move-node-in-overflow-scroll.html:
- fast/scrolling/mac/overflow-scrolled-document.html:
- fast/scrolling/mac/overflow-zoomed-document.html:
- fast/scrolling/mac/overlapped-overflow-scroll.html:
- fast/scrolling/mac/rubberband-overflow-in-wheel-region-expected.txt: Added.
- fast/scrolling/mac/rubberband-overflow-in-wheel-region.html: Copied from LayoutTests/fast/scrolling/mac/overflow-scrolled-document.html.
- 9:31 AM Changeset in webkit [265819] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, null-deref fix after r265797.
MockAudioDestinationCocoa::tick() is calling AudioDestinationCocoa::inputProc()
with a null AudioTimeStamp struct so we need to deal with this.
- platform/audio/cocoa/AudioDestinationCocoa.cpp:
(WebCore::AudioDestinationCocoa::render):
- 9:20 AM Changeset in webkit [265818] by
-
- 2 edits in trunk/LayoutTests
[ macOS Mojave wk2 Debug ] fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215611
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 9:04 AM Changeset in webkit [265817] by
-
- 3 edits2 adds in trunk/Tools
Develop a mechanism to unsubscribe from ews emails
https://bugs.webkit.org/show_bug.cgi?id=215585
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/emails.json: Added.
- BuildSlaveSupport/ews-build/send_email.py:
(get_email_ids):
(send_email_to_patch_author): Do not email patch authors whose email is in unsubscribe list.
(send_email_to_bot_watchers):
- BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure):
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures):
- BuildSlaveSupport/ews-build/email_unittest.py: Added unit-tests.
(EmailsDotJSONTest.test_valid_emails_json):
(EmailsDotJSONTest.test_emails_json_required_categories_present):
- 9:01 AM Changeset in webkit [265816] by
-
- 2 edits in trunk/Source/WebKit
[Mac] Unhandled keyDown: events cause a system beep in full screen mode
https://bugs.webkit.org/show_bug.cgi?id=215596
<rdar://problem/65823962>
Reviewed by Darin Adler.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController noResponderFor:]):
- 8:39 AM Changeset in webkit [265815] by
-
- 3 edits in trunk/LayoutTests
[ macOS wk1 iOS ] imported/w3c/web-platform-tests/IndexedDB/transaction_bubble-and-capture.htm is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215608
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 8:16 AM Changeset in webkit [265814] by
-
- 3 edits in trunk/Source/WebKit
NetworkSocketChannel should delay sending back error message as done by NetworkSocketStream
https://bugs.webkit.org/show_bug.cgi?id=215563
Reviewed by Alex Christensen.
Apply same policy as NetworkSocketStream in case of WebSocket connection error.
Covered by http/tests/websocket/tests/hybi/closed-port-delay.html with NSURLSession WebSocket code path.
- NetworkProcess/NetworkSocketChannel.cpp:
(WebKit::NetworkSocketChannel::NetworkSocketChannel):
(WebKit::NetworkSocketChannel::didClose):
(WebKit::NetworkSocketChannel::didReceiveMessageError):
(WebKit::NetworkSocketChannel::sendDelayedError):
- NetworkProcess/NetworkSocketChannel.h:
- 8:09 AM Changeset in webkit [265813] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] webgpu/whlsl/do-while-loop-break.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215606
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 7:45 AM Changeset in webkit [265812] by
-
- 4 edits in trunk
The CSS specificity of :host() pseudo-classes is wrong
https://bugs.webkit.org/show_bug.cgi?id=202494
<rdar://problem/66292568>
Reviewed by Anders Carlsson.
Source/WebCore:
https://drafts.csswg.org/css-scoping/#host-selector
“The specificity of :host() is that of a pseudo-class, plus the specificity of its argument.”
- css/CSSSelector.cpp:
(WebCore::simpleSelectorSpecificityInternal):
LayoutTests:
- 2:54 AM Changeset in webkit [265811] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening. Update test baseline after r265749.
- platform/gtk/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
- 1:45 AM Changeset in webkit [265810] by
-
- 5 edits in trunk/Source/WebCore
Add a JS built-in routine to mark a promise as handled
https://bugs.webkit.org/show_bug.cgi?id=215558
Reviewed by Darin Adler.
Wrap long line of code inside a method to ease code readability.
No change of behavior.
- Modules/streams/ReadableStream.js:
(pipeThrough):
- Modules/streams/ReadableStreamInternals.js:
(readableStreamError):
(readableStreamReaderGenericRelease):
- Modules/streams/StreamInternals.js:
(markPromiseAsHandled):
(shieldingPromiseResolve):
- Modules/streams/WritableStreamInternals.js:
(setUpWritableStreamDefaultWriter):
(writableStreamRejectCloseAndClosedPromiseIfNeeded):
(writableStreamDefaultWriterEnsureClosedPromiseRejected):
(writableStreamDefaultWriterEnsureReadyPromiseRejected):
- 1:03 AM Changeset in webkit [265809] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GLib gardening. Skip more tests using plugins after r265753
- platform/glib/TestExpectations:
Aug 17, 2020:
- 7:48 PM Changeset in webkit [265808] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r265701): [ BigSur ] 3 webaudio/the-audio-api/the-audioparam-interface tests are a constant failure)
rdar://67289434
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 7:37 PM Changeset in webkit [265807] by
-
- 2 edits in trunk/LayoutTests
ASSERTION FAILURE: WebKit::AuthenticationManager::initializeConnection(IPC::Connection *)_block_invoke
https://bugs.webkit.org/show_bug.cgi?id=215025
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 7:31 PM Changeset in webkit [265806] by
-
- 3 edits in trunk/LayoutTests
[GTK][WPE] Update some expectations after closed bugs
Unreviewed test gardening.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- 7:22 PM Changeset in webkit [265805] by
-
- 73 edits3 adds in branches/safari-610.1-branch
Cherry-pick r265749. rdar://problem/67284454
JSDOMConstructorNotConstructable should be a constructor
https://bugs.webkit.org/show_bug.cgi?id=215554
<rdar://problem/65770688>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/FileAPI/file/send-file-form-expected.txt:
- web-platform-tests/FileAPI/file/send-file-form-iso-2022-jp.tentative-expected.txt:
- web-platform-tests/FileAPI/file/send-file-form-utf-8-expected.txt:
- web-platform-tests/FileAPI/file/send-file-form-windows-1252.tentative-expected.txt:
- web-platform-tests/FileAPI/file/send-file-form-x-user-defined.tentative-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-constructable-baseURL.tentative-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-constructable-disabled-regular-sheet-insertion-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-constructable-disallow-import.tentative-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-constructable-duplicate-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-constructable-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-modify-after-removal-expected.txt:
- web-platform-tests/custom-elements/Document-createElement-expected.txt:
- web-platform-tests/custom-elements/Document-createElementNS-expected.txt:
- web-platform-tests/custom-elements/HTMLElement-attachInternals-expected.txt:
- web-platform-tests/custom-elements/HTMLElement-constructor-expected.txt:
- web-platform-tests/custom-elements/builtin-coverage-expected.txt:
- web-platform-tests/custom-elements/customized-built-in-constructor-exceptions-expected.txt:
- web-platform-tests/custom-elements/htmlconstructor/newtarget-expected.txt:
- web-platform-tests/custom-elements/parser/serializing-html-fragments-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLAreaElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLBaseElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLButtonElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLCanvasElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLDataElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLDetailsElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLEmbedElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLFieldSetElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLImageElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLLIElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLLabelElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLMapElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLMediaElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLMetaElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLMeterElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLModElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLOListElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLOptGroupElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLParamElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLProgressElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLQuoteElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLSlotElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLStyleElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLTableCellElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLTableColElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLTimeElement-expected.txt:
- web-platform-tests/custom-elements/upgrading/Document-importNode-expected.txt:
- web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt:
- web-platform-tests/dom/nodes/Node-appendChild-cereactions-vs-script.window-expected.txt:
- web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:
- web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:
- web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub-expected.txt:
- web-platform-tests/service-workers/service-worker/data-transfer-files.https-expected.txt:
- web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt:
- web-platform-tests/user-timing/mark-entry-constructor.any-expected.txt:
- web-platform-tests/user-timing/mark-entry-constructor.any.worker-expected.txt:
- web-platform-tests/user-timing/structured-serialize-detail.any-expected.txt:
- web-platform-tests/user-timing/structured-serialize-detail.any.worker-expected.txt:
- web-platform-tests/webrtc/RTCIceTransport-extension.https-expected.txt:
Source/WebCore:
Test: js/dom/window-is-constructor.html
While JSDOMConstructorNotConstructable throws an error, still it should be a constructor, which means,
IsConstructor(JSDOMConstructorNotConstructable)should be true. To fix it, we add getConstructData
which configures a function throwing an error.
- bindings/js/JSDOMConstructorNotConstructable.h:
LayoutTests:
- editing/async-clipboard/clipboard-interfaces-expected.txt:
- editing/undo-manager/undo-manager-interfaces-expected.txt:
- fast/dom/MutationObserver/mutation-record-constructor-expected.txt:
- http/wpt/html/browsers/the-window-object/window-is-constructor-expected.txt: Added.
- http/wpt/html/browsers/the-window-object/window-is-constructor.html: Added.
- js/interface-objects-expected.txt:
- performance-api/paint-timing/paint-timing-apis-expected.txt:
- performance-api/performance-observer-api-expected.txt:
- performance-api/performance-timeline-api-expected.txt:
- performance-api/resource-timing-apis-expected.txt:
- performance-api/user-timing-apis-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLInputElement-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:22 PM Changeset in webkit [265804] by
-
- 2 edits in branches/safari-610.1-branch/Source/WebKit
Cherry-pick r265774. rdar://problem/67284328
[Cocoa] Avoid waiting for Launch Services on every load
https://bugs.webkit.org/show_bug.cgi?id=215569
Reviewed by Darin Adler.
Currently, we are waiting for the Launch Services database to be present on every load in the WebContent process.
It should be sufficient to wait only on the first load. Since we now are waiting only once per WebContent process,
increase the maximum wait time from 1s to 5s.
No new tests, covered by existing tests.
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::platformDidReceiveLoadParameters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:22 PM Changeset in webkit [265803] by
-
- 6 edits in branches/safari-610.1-branch/Source
Cherry-pick r265743. rdar://problem/67284428
Scrolling sync changes in r261985 regressed CPU usage by ~2 ms/s
https://bugs.webkit.org/show_bug.cgi?id=215529
<rdar://problem/66866163>
Reviewed by Geoff Garen.
Source/WebCore:
r261985 added two code paths that wake up the scrolling thread on every
rendering update (triggered by displayDidRefresh()). One is a ping from
the EventDispatcher thread, the other is a wake-and-block from the main
thread. If the scrolling thread isn't active (no wheel events received recently),
we can avoid both of these to reduce the number of CPU core wakeups.
- page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::isRecentlyActive): (WebCore::ScrollingTree::setRecentlyActive):
- page/scrolling/ScrollingTree.h:
- page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::willStartRenderingUpdate): (WebCore::ThreadedScrollingTree::displayDidRefresh):
Source/WebKit:
r261985 added two code paths that wake up the scrolling thread on every
rendering update (triggered by displayDidRefresh()). One is a ping from
the EventDispatcher thread, the other is a wake-and-block from the main
thread. If the scrolling thread isn't active (no wheel events received recently),
we can avoid both of these to reduce the number of CPU core wakeups.
- WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::wheelEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:21 PM Changeset in webkit [265802] by
-
- 4 edits in branches/safari-610.1-branch/Source/WebKit
Cherry-pick r265727. rdar://problem/67284319
Revert r263551
https://bugs.webkit.org/show_bug.cgi?id=215530
<rdar://problem/66961066>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-14
Reviewed by Geoffrey Garen.
I was hoping to fix many developers' bugs, but it caused hangs and more hangs, so back to the status quo.
https://bugs.webkit.org/show_bug.cgi?id=203547 will fix this the right way in the hopefully-not-too-distant future.
- UIProcess/API/APIHTTPCookieStore.cpp: (API::HTTPCookieStore::setCookies): (API::HTTPCookieStore::registerForNewProcessPoolNotifications): (API::HTTPCookieStore::flushDefaultUIProcessCookieStore):
- UIProcess/API/APIHTTPCookieStore.h:
- UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm: (API::HTTPCookieStore::flushDefaultUIProcessCookieStore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:21 PM Changeset in webkit [265801] by
-
- 2 edits in branches/safari-610.1-branch/Source/WebCore
Cherry-pick r265723. rdar://problem/67284292
Crash inside FrameLoader::defaultRequestCachingPolicy (null DocumentLoader)
<rdar://problem/42167093> and https://bugs.webkit.org/show_bug.cgi?id=215527
Reviewed by Darin Adler.
We have CrashTracer data, but despite my best efforts no way of reproducing.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultRequestCachingPolicy): If a PingLoader is sending a CSP violation report sometime after part of the Document's lifecycle, the FrameLoader as a null DocumentLoader here. Like everywhere else in FrameLoader, null check it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:21 PM Changeset in webkit [265800] by
-
- 2 edits in branches/safari-610.1-branch/Source/WebCore
Cherry-pick r265722. rdar://problem/67284309
RenderTextControlSingleLine::scroll* functions should not call Element::scroll* on the inner text content
https://bugs.webkit.org/show_bug.cgi?id=215516
<rdar://problem/64739768>
Reviewed by Simon Fraser.
Normally the RenderBox::content*, border*, padding* and scroll* functions grab the geometry information from the renderer itself.
The clients of these functions expect the geometry data to be consistent with the rest of the rendering context
(e.g coordinates are in the coordinate system of the containing block, paint time operations are not applied etc).
Also these functions are supposed to be const. They should not mutate the geometry or the render tree itself.
Forwarding ::scroll* calls to Element::scroll* can't guarantee neither of these above.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::scrollWidth const): (WebCore::RenderTextControlSingleLine::scrollHeight const): (WebCore::RenderTextControlSingleLine::scrollLeft const): (WebCore::RenderTextControlSingleLine::scrollTop const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:21 PM Changeset in webkit [265799] by
-
- 5 edits in branches/safari-610.1-branch
Cherry-pick r265645. rdar://problem/67285376
VoiceOver not able to invoke play button on some web sites.
https://bugs.webkit.org/show_bug.cgi?id=215484
<rdar://problem/62729643>
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/ios-simulator/has-touch-event-listener.html.
We were checking for the presence of listeners for touchstart and touchend
events only. Now we check for the presence of any touch-related event listener.
- accessibility/ios/AccessibilityObjectIOS.mm: (WebCore::AccessibilityObject::hasTouchEventListener const):
LayoutTests:
Expanded this test to check for all touch-related event listeners.
- accessibility/ios-simulator/has-touch-event-listener-expected.txt:
- accessibility/ios-simulator/has-touch-event-listener.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:21 PM Changeset in webkit [265798] by
-
- 3 edits in branches/safari-610.1-branch/Source/WebKit
Cherry-pick r265427. rdar://problem/67284328
Add required entitlement for Catalyst
https://bugs.webkit.org/show_bug.cgi?id=215244
Reviewed by Darin Adler.
The entitlement 'com.apple.private.webkit.use-xpc-endpoint' should be added to the WebContent process on Catalyst as well,
since it is needed on all Apple platforms. This entitlement is needed to support direct XPC communication between WebKit
processes, which is used to send the Launch Services database to the WebContent process from the Networking process. Also,
add some more logging related to this, to detect if it takes a long time for the WebContent process to receive the database.
- Scripts/process-entitlements.sh:
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::platformDidReceiveLoadParameters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:16 PM Changeset in webkit [265797] by
-
- 28 edits2 copies in trunk
AudioContext.getOutputTimestamp() is missing
https://bugs.webkit.org/show_bug.cgi?id=215591
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-getoutputtimestamp-expected.txt:
Source/WebCore:
AudioContext.getOutputTimestamp() is missing:
No new tests, rebaselined existing tests.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::getOutputTimestamp):
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::render):
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioTimestamp.h: Copied from Source/WebCore/Modules/webaudio/AudioContext.h.
- Modules/webaudio/AudioTimestamp.idl: Copied from Source/WebCore/Modules/webaudio/AudioContext.h.
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::handlePreRenderTasks):
(WebCore::BaseAudioContext::outputPosition):
- Modules/webaudio/BaseAudioContext.h:
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::offlineRender):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/audio/AudioIOCallback.h:
(WebCore::AudioIOPosition::encode const):
(WebCore::AudioIOPosition::decode):
- platform/audio/cocoa/AudioDestinationCocoa.cpp:
(WebCore::machAbsoluteTimeToMonotonicTime):
(WebCore::AudioDestinationCocoa::render):
(WebCore::AudioDestinationCocoa::inputProc):
- platform/audio/cocoa/AudioDestinationCocoa.h:
Source/WebKit:
- GPUProcess/media/RemoteAudioDestinationManager.cpp:
- WebProcess/GPU/media/RemoteAudioBusData.h:
(WebKit::RemoteAudioBusData::encode const):
(WebKit::RemoteAudioBusData::decode):
- WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::renderBuffer):
- 7:12 PM Changeset in webkit [265796] by
-
- 2 edits in trunk/WebDriverTests
[WPE][WebDriver] Gardening some failures
Unreviewed test gardening.
- TestExpectations.json:
- 7:07 PM Changeset in webkit [265795] by
-
- 3 edits in trunk/LayoutTests
WeakPtr threading assertion on editing/undo-manager/undo-manager-delete-stale-undo-items.html
https://bugs.webkit.org/show_bug.cgi?id=215221
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations: expectation removal
- platform/mac-wk2/TestExpectations: expectation removal
- 6:24 PM Changeset in webkit [265794] by
-
- 6 edits2 deletes in trunk
Improve channel mixing support in AudioBus
https://bugs.webkit.org/show_bug.cgi?id=215597
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT test now that all checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-channel-rules-expected.txt:
Source/WebCore:
Improve channel mixing support in AudioBus to match the specification:
Our implementation also matches Blink's:
No new tests, rebaselined existing test.
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):
(WebCore::AudioBus::speakersSumFromByUpMixing):
(WebCore::AudioBus::speakersSumFromByDownMixing):
- platform/audio/AudioBus.h:
LayoutTests:
Remove outdated test. A newer version of this test is present in web-platform-tests.
- webaudio/audionode-channel-rules-expected.txt: Removed.
- webaudio/audionode-channel-rules.html: Removed.
- 5:53 PM Changeset in webkit [265793] by
-
- 2 edits in trunk/LayoutTests
Removing added entry in error.
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:49 PM Changeset in webkit [265792] by
-
- 2 edits in trunk/Source/WebKit
Assert failure after r265715
https://bugs.webkit.org/show_bug.cgi?id=215592
Reviewed by Darin Adler.
The change set r265715 introduced an assert failure in AuthenticationManager::initializeConnection. This
happens because after r265715 the new XPC event handler set in AuthenticationManager::initializeConnection,
will no longer be called on the main thread. This patch addresses this issue by dispatching this work on
the main thread.
No new tests, covered by existing tests.
- Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
(WebKit::AuthenticationManager::initializeConnection):
- 5:43 PM Changeset in webkit [265791] by
-
- 2 edits in trunk/LayoutTests
Adding BigSur to existing test expectations
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:53 PM Changeset in webkit [265790] by
-
- 24 edits in branches/safari-610.1-branch
Cherry-pick r265289. rdar://problem/66944320
Update event regions only once per frame
https://bugs.webkit.org/show_bug.cgi?id=215132
<rdar://problem/66533779>
Reviewed by Darin Adler.
Source/WebCore:
Event regions (for touch-action, editable areas etc) were updated as part of
compositing updates, but we only need their output once per rendering update, so
move their computation out of RenderLayerCompositor::updateBackingAndHierarchy()
and into a new RenderLayer tree walk that is called from Page::doAfterUpdateRendering().
RenderLayerBacking stores a dirty bit to track when regions need to be updated.
Reduces the amount of time spent in rendering updates when scrolling on facebook.com
on iPad, which has lots of discontiguous touch-action regions.
- dom/Document.cpp: (WebCore::Document::updateEventRegions):
- dom/Document.h:
- page/Frame.cpp: (WebCore::Frame::layerTreeAsText const):
- page/Page.cpp: (WebCore::Page::doAfterUpdateRendering):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const): (WebCore::RenderLayerBacking::updateEventRegion):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateEventRegions): (WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
- rendering/RenderLayerCompositor.h:
LayoutTests:
Tests that dispatch mouseWheel events in a way that tests event regions need to wait
now for a rendering update.await UIHelper.animationFrame()is not enough, because
the function resumes inside a microtask at the end of the requestAnimationFrame callback,
which is before we've completed the rest of the rendering update, and thus before
the event regions have been updated.
In addition,
await UIHelper.animationFrame()followed by eventSender calls to issue
wheel events actually trigger Page::updateRendering() re-entrancy, via the
WKBundlePageForceRepaint() in EventSendingController::mouseScrollByWithWheelAndMomentumPhases().
To fix this, add and use UIHelper.renderingUpdate(), which waits for a rAF and uses a setTimeout()
to get past the end of the current rendering update.
- fast/scrolling/mac/absolute-in-overflow-scroll-dynamic-expected.html:
- fast/scrolling/mac/absolute-in-overflow-scroll-dynamic.html:
- fast/scrolling/mac/absolute-in-overflow-scroll.html:
- fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html:
- fast/scrolling/mac/async-scroll-overflow-rtl-zoomed.html:
- fast/scrolling/mac/async-scroll-overflow-top-inset.html:
- fast/scrolling/mac/async-scroll-overflow.html:
- fast/scrolling/mac/clip-path-hit-test.html:
- fast/scrolling/mac/move-node-in-overflow-scroll.html:
- fast/scrolling/mac/overflow-scrolled-document.html:
- fast/scrolling/mac/overflow-zoomed-document.html:
- fast/scrolling/mac/overlapped-overflow-scroll.html:
- resources/ui-helper.js: (window.UIHelper.async renderingUpdate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:53 PM Changeset in webkit [265789] by
-
- 6 edits in branches/safari-610.1-branch/Source/WebCore
Cherry-pick r265232. rdar://problem/66944320
Add an EventRegions log channel
https://bugs.webkit.org/show_bug.cgi?id=215092
Reviewed by Daniel Bates.
Add a log channel for EventRegions, add logging in some interesting places.
- platform/Logging.h:
- rendering/EventRegion.cpp: (WebCore::EventRegion::unite): (WebCore::EventRegion::uniteTouchActions): (WebCore::EventRegion::uniteEventListeners):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateEventRegion):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [265788] by
-
- 27 edits in branches/safari-610.1-branch/Source
Cherry-pick r265562. rdar://problem/66944332
Add the support to return to element fullscreen from picture-in-picture
https://bugs.webkit.org/show_bug.cgi?id=215305
Reviewed by Jer Noble.
Source/WebCore:
When a container element enters fullscreen (with the fullscreen API), a descendant
video element will enter the video fullscreen standby state so that it can enter
picture-in-picture on application suspend (r226217). But we cannot restore
to that state from the picture-in-picture mode when we click the "restore" button
on the top-right corner of the PiP window. Instead, the video element will return
to the inline mode.
However, when a video element enters video fullscreen first and then enters
picture-in-picture, we can let the video restore to fullscreen by clicking the
"restore" button on the top-right corner of the picture-in-picture window.
The inconsistent behaviors may confuse users who are not aware of the difference
between the fullscreen API (or element fullscreen) and video fullscreen.
This patch enables the support to restore to element fullscreen from picture-in-picture
mode so that users can have a consistent experience on element fullscreen and
video fullscreen.
- dom/FullscreenManager.h: Export requestFullscreenForElement() so that we can use it in WebKit code.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): (WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby):
- html/HTMLMediaElement.h:
- page/ChromeClient.h: (WebCore::ChromeClient::prepareForVideoFullscreen): Add the interface to request a video element to be prepared for the video fullscreen standby state.
- platform/cocoa/VideoFullscreenChangeObserver.h: Add prepareToExitFullscreen() and fullscreenWillReturnToInline().
- platform/cocoa/VideoFullscreenModel.h: (WebCore::VideoFullscreenModelClient::hasVideoChanged): (WebCore::VideoFullscreenModelClient::videoDimensionsChanged): (WebCore::VideoFullscreenModelClient::prepareToExitPictureInPicture): Some minor clean-ups and add function prepareToExitPictureInPicture().
- platform/ios/VideoFullscreenInterfaceAVKit.h:
- platform/ios/VideoFullscreenInterfaceAVKit.mm: (VideoFullscreenInterfaceAVKit::cleanupFullscreen): (VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStop): (VideoFullscreenInterfaceAVKit::didStartPictureInPicture): (VideoFullscreenInterfaceAVKit::willStopPictureInPicture): (VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStopWithCompletionHandler): (VideoFullscreenInterfaceAVKit::setReadyToStopPictureInPicture): (VideoFullscreenInterfaceAVKit::willEnterStandbyFromPictureInPicture): (VideoFullscreenInterfaceAVKit::setWillEnterStandbyFromPictureInPicture): (VideoFullscreenInterfaceAVKit::fullscreenMayReturnToInline): Deleted. When we enter picture-in-picture, we need to save the state and be prepared to restore to element fullscreen if needed.
Before we exit picture-in-picture, if the "restore" button is clicked, we need
to notify the client to prepare for the picture-in-picture stop, and call
VideoFullscreenInterfaceAVKit::setReadyToStopPictureInPicture(true) when the client
is ready.
Based on those changes, a client (e.g., WKFullScreenWindowControllerVideoFullscreenModelClient)
can coordinate with WKFullScreenWindowController to implement the "restore to
element fullscreen" feature.
- platform/ios/WebVideoFullscreenControllerAVKit.mm: (VideoFullscreenControllerContext::fullscreenWillReturnToInline): (VideoFullscreenControllerContext::fullscreenMayReturnToInline): Deleted.
Source/WebKit:
This patch replaces WKFullScreenViewControllerVideoFullscreenModelClient
with WKFullScreenWindowControllerVideoFullscreenModelClient. We need to do
that because the instance of WKFullScreenViewControllerVideoFullscreenModelClient
will be destroyed after the container element exits fullscreen while the video
element enters picture-in-picture.
The instance of WKFullScreenWindowControllerVideoFullscreenModelClient
will always exist when the WKFullScreenWindowController instance is alive,
so that it can receive callbacks from the VideoFullscreenInterfaceAVKit instance
to implement the "return to element fullscreen from picture-in-picture" feature.
This patch supports the following transitions:
element fullscreen -> picture-in-picture (through user gestures)
element fullscreen -> picture-in-picture (through the PiP button)
picture-in-picture -> element fullscreen (when the tab is visible)
picture-in-picture -> element fullscreen (when the tab is invisible)
picture-in-picture -> element fullscreen (when the browser is in background)
picture-in-picture -> inline (when the browser is in foreground)
exit picture-in-picture when the browser is in background
- UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
- UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: (WebKit::VideoFullscreenModelContext::fullscreenWillReturnToInline): (WebKit::VideoFullscreenModelContext::prepareToExitFullscreen): Notify clients to prepare for the stop of fullscreen/picture-in-picture. (WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID): Fix issues that increase the client count unnecessarily. (WebKit::VideoFullscreenManagerProxy::preparedToReturnToInline): Call m_page->fullscreenMayReturnToInline() earlier. (WebKit::VideoFullscreenManagerProxy::fullscreenMayReturnToInline): Ditto. (WebKit::VideoFullscreenManagerProxy::fullscreenWillReturnToInline): Notify VideoFullscreenManager to prepare for exiting picture-in-picture or video fullscreen and report the destination rectangle of the exit picture-in-picture or video fullscreen animations.
- UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::requestEnterFullScreen):
- UIProcess/WebFullScreenManagerProxy.h: Add a function requestEnterFullScreen() so that we can request an element to enter fullscreen from the UI process side.
- UIProcess/ios/fullscreen/WKFullScreenViewController.h:
- UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController initWithWebView:]): (-[WKFullScreenViewController dealloc]): (-[WKFullScreenViewController videoControlsManagerDidChange]): (-[WKFullScreenViewController setAnimatingViewAlpha:]): (-[WKFullScreenViewController _cancelAction:]): (WKFullScreenViewControllerVideoFullscreenModelClient::setParent): Deleted. (WKFullScreenViewControllerVideoFullscreenModelClient::setInterface): Deleted. (WKFullScreenViewControllerVideoFullscreenModelClient::interface const): Deleted. (-[WKFullScreenViewController willEnterPictureInPicture]): Deleted. (-[WKFullScreenViewController didEnterPictureInPicture]): Deleted. (-[WKFullScreenViewController failedToEnterPictureInPicture]): Deleted. Minor clean-ups and remove code related to WKFullScreenViewControllerVideoFullscreenModelClient.
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h:
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (WKFullScreenWindowControllerVideoFullscreenModelClient::setParent): (WKFullScreenWindowControllerVideoFullscreenModelClient::setInterface): (WKFullScreenWindowControllerVideoFullscreenModelClient::interface const): (-[WKFullScreenWindowController initWithWebView:]): (-[WKFullScreenWindowController dealloc]): (-[WKFullScreenWindowController enterFullScreen]): (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): (-[WKFullScreenWindowController requestEnterFullScreen]): (-[WKFullScreenWindowController requestExitFullScreen]): (-[WKFullScreenWindowController _completedExitFullScreen]): (-[WKFullScreenWindowController videoControlsManagerDidChange]): (-[WKFullScreenWindowController willEnterPictureInPicture]): (-[WKFullScreenWindowController didEnterPictureInPicture]): (-[WKFullScreenWindowController failedToEnterPictureInPicture]): (-[WKFullScreenWindowController prepareToExitPictureInPicture]): (-[WKFullScreenWindowController didExitPictureInPicture]): Add WKFullScreenWindowControllerVideoFullscreenModelClient and implement the support to "restore fullscreen from picture-in-picture".
- WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::enterFullScreenForElement): (WebKit::WebFullScreenManager::requestEnterFullScreen):
- WebProcess/FullScreen/WebFullScreenManager.h:
- WebProcess/FullScreen/WebFullScreenManager.messages.in: Add the interface requestEnterFullScreen() and the corresponding IPC message.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::prepareForVideoFullscreen):
- WebProcess/WebCoreSupport/WebChromeClient.h: Add the interface to prepare for video fullscreen standby. The web process can use this interface to create a VideoFullscreenManager instance to avoid the scenario that an IPC message comes from the VideoFullscreenManagerProxy but the VideoFullscreenManager instance is not constructed yet.
- WebProcess/cocoa/VideoFullscreenManager.h:
- WebProcess/cocoa/VideoFullscreenManager.messages.in:
- WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::fullscreenWillReturnToInline): (WebKit::VideoFullscreenManager::fullscreenMayReturnToInline): Deleted. Rename fullscreenMayReturnToInline() to fullscreenWillReturnToInline(). In the UI process side, fullscreenMayReturnToInline() is used by VideoFullscreenManagerProxy to notify applications regarding UI changes (e.g., switch browser tabs).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [265787] by
-
- 2 edits in branches/safari-610.1-branch/Source/ThirdParty/libwebrtc
Cherry-pick r265500. rdar://problem/66944395
Cherry-pick usrsctp 264ce452885bfed73348ba6b6f63693bc2f52a6e commit
https://bugs.webkit.org/show_bug.cgi?id=215378
<rdar://problem/66788144>
Reviewed by Eric Carlson.
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c: (sctp_handle_asconf):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [265786] by
-
- 2 edits in branches/safari-610.1-branch/Source/WebKit
Cherry-pick r265270. rdar://problem/66944311
Unreviewed build fix after r265263
https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>
- UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [265785] by
-
- 2 edits in branches/safari-610.1-branch/Source/WebKit
Cherry-pick r265263. rdar://problem/66944311
Limit 'com.apple.webkit.microphone' use to macOS and MacCatalyst
https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>
Reviewed by Eric Carlson.
We only need the 'com.apple.webkit.microphone' Sandbox Extension at startup on
macOS and MacCatalyst (and even on those platforms, only until <rdar://problem/29448368>
is fixed).
We should not issue this extension on the iOS family of targets.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [265784] by
-
- 14 edits2 adds in branches/safari-610.1-branch
Cherry-pick r265259. rdar://problem/66944362
AX: VoiceOver needs access to font styling at insertion point
https://bugs.webkit.org/show_bug.cgi?id=215129
Source/WebCore:
<rdar://problem/65114972>
Reviewed by Darin Adler.
Give access to relevant font styling properties at the insertion point so that VoiceOver can speak them
when text commands alter styling.
Test: accessibility/mac/resolved-text-editing.html
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::resolvedEditingStyles const):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper _accessibilityResolvedEditingStyles]):
- accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::resolvedEditingStyles const):
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (-[WebAccessibilityObjectWrapperBase baseAccessibilityResolvedEditingStyles]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Reviewed by Darin Adler.
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::attributeValueAsync):
LayoutTests:
Reviewed by Darin Adler.
- accessibility/mac/resolved-text-editing-expected.txt: Added.
- accessibility/mac/resolved-text-editing.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:24 PM Changeset in webkit [265783] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk1 ] webaudio/oscillator-square.html is a flaky failure
Nhttps://bugs.webkit.org/show_bug.cgi?id=215593
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:19 PM Changeset in webkit [265782] by
-
- 6 edits3 deletes in trunk
Unreviewed, reverting r265603.
Reverting per commiter because commit caused consisent crash
with test.
Reverted changeset:
"Font loads quickly followed by navigations may fail
indefinitely"
https://bugs.webkit.org/show_bug.cgi?id=215435
https://trac.webkit.org/changeset/265603
- 4:13 PM Changeset in webkit [265781] by
-
- 10 edits in trunk
AudioNode.disconnect() does not match the specification
https://bugs.webkit.org/show_bug.cgi?id=215578
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT test now that more checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-expected.txt:
Source/WebCore:
AudioNode.disconnect() did not match the specification. There were a lot of overloads in
the specification that we did not support:
No new tests, rebaselined existing tests.
- Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::connect): Deleted.
(WebCore::AudioBasicInspectorNode::disconnect): Deleted.
- Modules/webaudio/AudioBasicInspectorNode.h:
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):
- Modules/webaudio/AudioNode.h:
(WebCore::AudioNode::updatePullStatus):
- Modules/webaudio/AudioNode.idl:
- Modules/webaudio/AudioNodeOutput.h:
(WebCore::AudioNodeOutput::isConnectedTo const):
- 4:12 PM Changeset in webkit [265780] by
-
- 4 edits in trunk/LayoutTests
[ macOS iOS ] svg/animations/smil-leak-element-instances-noBaseValRef.svg is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215353
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-08-17
Reviewed by Jon Lee.
GCController.collect() is flaky. Calling this function from JS does not
guarantee the memory of all the deallocated objects is garbage-collected.
Multiple calls to GCController.collect() may be invoked to overcome this
problem. Putting idle time before requesting the numberOfLiveNodes()
might be needed as well.
The test adds 100 <use> elements. Each of them references a <rect> element
and adds an <animate> element to animate the 'x' property. This is a big
number of objects to be allocated, deallocated and garbage collected. To
overcome the flakiness of GCController.collect(), three <use> elements
can be added instead. This number of objects should be enough to test the
SVG animated properties do not leak. And at the same time the test won't
exercise the flakiness of GCController.collect().
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- svg/animations/smil-leak-element-instances-noBaseValRef.svg:
- 4:01 PM Changeset in webkit [265779] by
-
- 8 edits in branches/safari-610.1-branch/Source
Versioning.
WebKit-7610.1.28
- 3:44 PM Changeset in webkit [265778] by
-
- 2 edits in trunk/Tools
Stop webkitpy from warning about not having a 64-bit git on Apple silicon
https://bugs.webkit.org/show_bug.cgi?id=214718
Patch by Saagar Jha <saagar@saagarjha.com> on 2020-08-17
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git._executable_is_64bit): Loosen 64-bit check to succeed on systems that aren't x86_64.
- 3:26 PM Changeset in webkit [265777] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] media/modern-media-controls/volume-down-support/volume-down-support.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215587
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 3:21 PM Changeset in webkit [265776] by
-
- 1 copy in tags/Safari-610.1.27
Tag Safari-610.1.27.
- 3:10 PM Changeset in webkit [265775] by
-
- 17 edits5 adds in trunk
Have an OOB+SaneChain Array::Speculation
https://bugs.webkit.org/show_bug.cgi?id=215487
Reviewed by Yusuke Suzuki.
JSTests:
- microbenchmarks/oob-sane-chain-contiguous.js: Added.
- microbenchmarks/oob-sane-chain-double-read-undefined.js: Added.
- microbenchmarks/oob-sane-chain-double.js: Added.
- microbenchmarks/oob-sane-chain-int32.js: Added.
- stress/oob-sane-chain-negative-index.js: Added.
Source/JavaScriptCore:
This patch adds a new ArrayMode speculation in the DFG/FTL called OutOfBoundsSaneChain.
It allows us to do fast things when we go OOB, like simply return undefined.
This is because we install watchpoints on the prototype chain to ensure they
have no indexed properties. This patch implements OutOfBoundsSaneChain on
GetByVal over Int32/Double/Contiguous original JS arrays. We can extend it in
the future to non original JS arrays if we prove their prototype is Array.prototype.
To implement this properly, we also need to ensure that the index isn't negative,
as Array.prototype/Object.prototype may have negative indexed accessors. We
do this via speculation, and if we ever recompile, and see an exit because of
this, we will stop speculating OutOfBoundsSaneChain.
This is about 20% faster on crypto-md5-SP. And ~3-4x faster on the
microbenchmarks I created.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine const):
(JSC::DFG::arraySpeculationToString):
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::isInBoundsSaneChain const):
(JSC::DFG::ArrayMode::isOutOfBoundsSaneChain const):
(JSC::DFG::ArrayMode::isOutOfBounds const):
(JSC::DFG::ArrayMode::isEffectfulOutOfBounds const):
(JSC::DFG::ArrayMode::isInBounds const):
(JSC::DFG::ArrayMode::isSaneChain const): Deleted.
- dfg/DFGCSEPhase.cpp:
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::setSaneChainIfPossible):
(JSC::DFG::FixupPhase::convertToHasIndexedProperty):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileHasIndexedProperty):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValidate.cpp:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):
- 2:54 PM Changeset in webkit [265774] by
-
- 2 edits in trunk/Source/WebKit
[Cocoa] Avoid waiting for Launch Services on every load
https://bugs.webkit.org/show_bug.cgi?id=215569
Reviewed by Darin Adler.
Currently, we are waiting for the Launch Services database to be present on every load in the WebContent process.
It should be sufficient to wait only on the first load. Since we now are waiting only once per WebContent process,
increase the maximum wait time from 1s to 5s.
No new tests, covered by existing tests.
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::platformDidReceiveLoadParameters):
- 2:35 PM Changeset in webkit [265773] by
-
- 5 edits in trunk
[WTF] HashTable<Ref<K>, V>::HashTable(const HashTable& other) can't compile
https://bugs.webkit.org/show_bug.cgi?id=215550
Reviewed by Darin Adler.
Source/WTF:
Even though the copy constructor takes a const HashTable
reference, RefHashTraits::assignToEmpty takes non-const Ref<P>. It
seems that RefHashTraits::assignToEmpty and
Ref::assignToHashTableEmptyValue are unnecessary. Just remove them.
- wtf/HashTraits.h:
(WTF::RefHashTraits::assignToEmpty): Deleted.
- wtf/Ref.h:
(WTF::Ref::assignToHashTableEmptyValue): Deleted.
Tools:
- TestWebKitAPI/Tests/WTF/HashSet.cpp:
(TestWebKitAPI::TEST):
- 2:16 PM Changeset in webkit [265772] by
-
- 3 edits in trunk/LayoutTests
[ macOS iOS ] media/track/track-in-band-style.html is a flaky timeout and failure
https://bugs.webkit.org/show_bug.cgi?id=215583
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 1:53 PM Changeset in webkit [265771] by
-
- 5 edits in trunk/Tools
[resultsdbpy]: Depend on webkitcorepy
https://bugs.webkit.org/show_bug.cgi?id=215573
<rdar://problem/67250272>
Reviewed by Dewei Zhu.
- Scripts/libraries/resultsdbpy/resultsdbpy/init.py:
(_maybe_add_webkitcorepy_path): Attempt to add. webkitcorepy to the. Python path.
- Scripts/libraries/resultsdbpy/setup.py: Add webkitcorepy, remove webkitcorepy's dependencies.
- Scripts/libraries/webkitcorepy/setup.py: Add six as a dependency.
- Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Include. package name, bump version.
- 1:34 PM Changeset in webkit [265770] by
-
- 3 edits in trunk/LayoutTests
[ macOS iOS wk2 ] imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getStats.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215581
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 1:20 PM Changeset in webkit [265769] by
-
- 3 edits2 adds in trunk/Tools
[webkitcorepy] Add OutputCapture to webkitcorepy
https://bugs.webkit.org/show_bug.cgi?id=215380
<rdar://problem/66846384>
Reviewed by Dewei Zhu.
Although webkitpy has an OutputCapture class, that class does not separate logging from
stdout and stderr, which makes the API less useful. This version of the OutputCapture class
is inspired by the one in webkitpy, but with a cleaner interface.
- Scripts/libraries/webkitcorepy/README.md: Document usage of OutputCapture.
- Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Export LoggerCapture, OutputCapture and
OutputDuplicate as API, bump version.
- Scripts/libraries/webkitcorepy/webkitcorepy/output_capture.py: Added.
(LoggerCapture): Capture logs at some level for the duration of the interface.
(OutputCapture): Capture stdout, stderr and all logging channels for the duration of the interface.
(OutputCapture.ReplaceSysStream): Replace sys.stdout or sys.stderr for a block.
(OutputDuplicate): Context which can duplicate all output for a block of code. This is useful to both print and
capture logs.
(OutputDuplicate.Stream): File-like object that routes output to multiple file-like objects.
- Scripts/libraries/webkitcorepy/webkitcorepy/tests/output_capture_unittest.py: Added.
(LoggerCaptureTest):
(OutputCaptureTest):
(OutputOutputDuplicateTest):
- 12:54 PM Changeset in webkit [265768] by
-
- 3 edits in trunk/Tools
[TestWebKitAPI] Some WTF_HashMap tests are failing if TestWTF is executed directly
https://bugs.webkit.org/show_bug.cgi?id=215556
Reviewed by Darin Adler.
Some tests using RefLogger were failing if TestWTF is executed
directly without run-api-tests test driver script. Subsequent
tests were failing due to extra "deref(a) " which is a leftover of
the previous tests. Because run-api-tests is spawning a TestWTF
process for each test, it hides this issue.
- TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
Added blocks or calling clear() method to destroy local variables and added more
EXPECT_STREQ("deref(a) ", takeLogStr().c_str()).
- 12:29 PM Changeset in webkit [265767] by
-
- 2 edits in trunk/Tools
[WPE] Fix file url in WPEQt api test
https://bugs.webkit.org/show_bug.cgi?id=215577
Reviewed by Philippe Normand.
The test expects the load to fail, so avoid file://foo.html resolving
to file:///.
- TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp:
(TestLoadRequest::main):
- 12:29 PM Changeset in webkit [265766] by
-
- 3 edits in trunk/Tools
[webkitcorepy] Autoinstaller is very slow in git-svn checkouts
https://bugs.webkit.org/show_bug.cgi?id=215534
<rdar://problem/67120623>
Reviewed by Dewei Zhu.
- Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
- Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install): Download packages to a temporary directory so that setup.py runs faster.
- 12:14 PM Changeset in webkit [265765] by
-
- 6 edits in trunk
WaveShaperNode should not output silence when it has no input or when input is silence
https://bugs.webkit.org/show_bug.cgi?id=215574
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline existing test now that all checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/silent-inputs-expected.txt:
Source/WebCore:
WaveShaperNode should not output silence when it has no input or when input is silence.
It should still apply its curve to the silent input.
No new tests, rebaselined existing test.
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::disableOutputsIfNecessary):
Do not disable the WaveShaperNode's output when its has no input. The WaveShaperNode
may still provide non-silent output when it has no input.
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::propagatesSilence const):
- Modules/webaudio/WaveShaperNode.h:
Override propagatesSilence() to return false when the WaveShaperNode has a curve to apply,
so that we ask the node to process the input even when it is silence.
- 12:08 PM Changeset in webkit [265764] by
-
- 6 edits3 deletes in branches/safari-610.1-branch
Revert "Cherry-pick r265603. rdar://problem/67084483"
This reverts commit r265700.
- 12:00 PM Changeset in webkit [265763] by
-
- 31 edits in branches/safari-610.1-branch/Source/WebKit
Cherry-pick r265725. rdar://problem/67260862
Convert remaining SharedMemory::Handle to SharedMemory::IPCHandle
https://bugs.webkit.org/show_bug.cgi?id=215471
<rdar://problem/67024177>
Reviewed by David Kilzer.
Use the new struct for sending SharedMemory::Handle objects via IPC, so
we can include the exact size of data (SharedMemory::Handle::size()
rounds up to the nearest page), and verify these sizes match when decoding.
In many cases, the size is not sent as a separate argument via IPC, so
we can initialize the IPCHandle object with SharedMemory::Handle::size().
We can remove the additional size parameter when it exists, because
we are now passing IPCHandle which should include the size value.
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp: (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp: (WebKit::RemoteMediaRecorder::audioSamplesStorageChanged):
- GPUProcess/webrtc/RemoteMediaRecorder.h:
- GPUProcess/webrtc/RemoteMediaRecorder.messages.in: Send SharedMemory::IPCHandle object instead of SharedMemory::Handle over IPC.
- NetworkProcess/ServiceWorker/WebSWOriginStore.cpp: (WebKit::WebSWOriginStore::sendStoreHandle): Since no additional size parameter is being sent in this function, we can use handle.size() as the IPCHandle::dataSize parameter.
- Platform/SharedMemory.h: Remove encode/decode functions in SharedMemory::Handle.
- Platform/cocoa/SharedMemoryCocoa.cpp: (WebKit::SharedMemory::Handle::encode const): Deleted. (WebKit::SharedMemory::Handle::decode): Deleted.
- Platform/unix/SharedMemoryUnix.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode):
- Platform/win/SharedMemoryWin.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode): (WebKit::SharedMemory::Handle::encode const): Deleted. (WebKit::SharedMemory::Handle::decode): Deleted. Remove SharedMemory::Handle encode/decode functions so we will not ever send a SharedMemory::Handle object over IPC accidentally in the future.
- Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::Handle::encode const): (WebKit::ShareableBitmap::Handle::decode): Keep m_size here because it is an IntSize object and is useful to check width/height parameters in the SharableBitmap object.
- Shared/ShareableResource.cpp: (WebKit::ShareableResource::Handle::encode const): (WebKit::ShareableResource::Handle::decode):
- Shared/WebCompiledContentRuleListData.cpp: (WebKit::WebCompiledContentRuleListData::encode const): (WebKit::WebCompiledContentRuleListData::decode):
- Shared/WebCoreArgumentCoders.cpp: (IPC::encodeSharedBuffer): (IPC::decodeSharedBuffer):
- Shared/WebHitTestResultData.cpp: (WebKit::WebHitTestResultData::encode const): (WebKit::WebHitTestResultData::decode): More cases of converting between SharedMemory::Handle and SharedMemory::IPCHandle when encoding/decoding.
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
- UIProcess/VisitedLinkStore.cpp: (WebKit::VisitedLinkStore::sendStoreHandleToProcess):
- WebProcess/GPU/media/RemoteAudioBusData.h: (WebKit::RemoteAudioBusData::encode const): (WebKit::RemoteAudioBusData::decode): Since no additional size parameter is being sent in this function, we can use handle.size() as the IPCHandle::dataSize parameter.
- WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp: (WebKit::AudioMediaStreamTrackRenderer::storageChanged):
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp: (WebKit::MediaRecorderPrivate::storageChanged):
- WebProcess/Storage/WebSWClientConnection.cpp: (WebKit::WebSWClientConnection::setSWOriginTableSharedMemory):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWClientConnection.messages.in:
- WebProcess/WebPage/VisitedLinkTableController.cpp: (WebKit::VisitedLinkTableController::setVisitedLinkTable):
- WebProcess/WebPage/VisitedLinkTableController.h:
- WebProcess/WebPage/VisitedLinkTableController.messages.in:
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp: (WebKit::RemoteCaptureSampleManager::audioStorageChanged):
- WebProcess/cocoa/RemoteCaptureSampleManager.h:
- WebProcess/cocoa/RemoteCaptureSampleManager.messages.in: More cases of converting between SharedMemory::Handle and SharedMemory::IPCHandle when encoding/decoding.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:00 PM Changeset in webkit [265762] by
-
- 5 edits in branches/safari-610.1-branch/Source/WebKit
Cherry-pick r265638. rdar://problem/67260815
Create SharedMemory::IPCHandle object to validate the size of SharedMemory::Handle objects sent over IPC
https://bugs.webkit.org/show_bug.cgi?id=215288
<rdar://problem/60870795>
Reviewed by David Kilzer.
Part 1 of a multi-patch plan to convert all SharedMemory::Handle
objects being sent over IPC to use SharedMemory::IPCHandle objects instead.
- Platform/SharedMemory.h: (WebKit::SharedMemory::IPCHandle::IPCHandle):
- Platform/cocoa/SharedMemoryCocoa.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode): Validate the size of the data sent in the IPCHandle::decode() function.
- Platform/unix/SharedMemoryUnix.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode):
- Platform/win/SharedMemoryWin.cpp: Implement IPCHandle encode and decode for all platforms for when we remove SharedMemory::Handle encode/decode functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:51 AM Changeset in webkit [265761] by
-
- 2 edits in trunk/Source/WebKit
[Mac] Add Experimental Feature preference for SW VP9
https://bugs.webkit.org/show_bug.cgi?id=215043
<rdar://problem/66400034>
Reviewed by Darin Adler.
Follow up fix: during a rebase, a line deletion was dropped which causes the SW decoder to
always be registered regardless of the new setting.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::enableVP9Decoder):
(WebKit::WebProcess::enableVP9SWDecoder):
- 10:35 AM Changeset in webkit [265760] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] media/modern-media-controls/volume-up-support/volume-up-support.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215576
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 10:26 AM Changeset in webkit [265759] by
-
- 2 edits in trunk/Source/WTF
Bump HAVE_NSURLSESSION_WEBSOCKET requirement to BigSur for MacOS
https://bugs.webkit.org/show_bug.cgi?id=215517
Reviewed by Alex Christensen.
Catalina NSURLSession WebSocket is missing some features we need.
Bump it to Big Sur.
- wtf/PlatformHave.h:
- 10:07 AM Changeset in webkit [265758] by
-
- 2 edits in trunk/Source/WebKit
Remove message check in WebSocketTask::readNextMessage
https://bugs.webkit.org/show_bug.cgi?id=215561
Reviewed by Alex Christensen.
This if check was added as a workaround to cases where both error and message were null.
This is no longer the case as per running existing tests with NSURLSession WebSocket code path on BigSur.
- NetworkProcess/cocoa/WebSocketTaskCocoa.mm:
(WebKit::WebSocketTask::readNextMessage):
- 10:03 AM Changeset in webkit [265757] by
-
- 2 edits in trunk/Source/WebKit
Remove Cocoa WebSocketTask::send workaround
https://bugs.webkit.org/show_bug.cgi?id=215564
Reviewed by Alex Christensen.
Covered by existing tests run in Debug.
- NetworkProcess/cocoa/WebSocketTaskCocoa.mm:
(WebKit::WebSocketTask::sendString):
(WebKit::WebSocketTask::sendData):
- 9:33 AM Changeset in webkit [265756] by
-
- 10 edits in trunk/Source
Clean up DragApplicationFlags after switch to OptionSet<>
<https://webkit.org/b/215349>
Reviewed by Darin Adler.
Change WebCore::DragApplicationFlags to an enum class.
Source/WebCore:
No new tests since no change in behavior.
- page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::isCopyKeyDown):
- page/mac/DragControllerMac.mm:
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
- platform/DragData.h:
Source/WebKit:
- UIProcess/API/gtk/DropTargetGtk3.cpp:
(WebKit::DropTarget::drop):
- Switch to use OptionSet<WebCore::DragApplicationFlags>.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::applicationFlagsForDrag):
- WebProcess/WebPage/WebPage.h:
- Update forward declaration.
Source/WebKitLegacy/mac:
- WebView/WebView.mm:
(-[WebView applicationFlags:]): Deleted.
(-[WebView _applicationFlagsForDrag:]):
- Rename -applicationFlags: to -_applicationFlagsForDrag: since it's only used internally.
- Switch to return OptionSet<WebCore::DragApplicationFlags>.
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):
- Switch to calling -_applicationFlagsForDrag:.
- 7:06 AM Changeset in webkit [265755] by
-
- 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore/platform/gtk/po
Merge r265754 - [GTK][l10n] Updated Polish translation of WebKitGTK for 2.30
https://bugs.webkit.org/show_bug.cgi?id=215547
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2020-08-17
Rubber-stamped by Carlos Garcia Campos.
- pl.po:
- 7:05 AM Changeset in webkit [265754] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK][l10n] Updated Polish translation of WebKitGTK for 2.30
https://bugs.webkit.org/show_bug.cgi?id=215547
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2020-08-17
Rubber-stamped by Carlos Garcia Campos.
- pl.po:
- 5:41 AM Changeset in webkit [265753] by
-
- 41 edits12 deletes in trunk
[GTK][WPE] Remove support for NPAPI plugins
https://bugs.webkit.org/show_bug.cgi?id=215503
Reviewed by Darin Adler.
.:
- Source/cmake/OptionsGTK.cmake:
Source/WebKit:
- PlatformGTK.cmake:
- PluginProcess/unix/PluginControllerProxyUnix.cpp: Removed.
- PluginProcess/unix/PluginProcessMainUnix.cpp: Removed.
- PluginProcess/unix/PluginProcessUnix.cpp: Removed.
- Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp: Removed.
- Shared/Plugins/unix/PluginSearchPath.cpp: Removed.
- Shared/Plugins/unix/PluginSearchPath.h: Removed.
- SourcesGTK.txt:
- SourcesWPE.txt:
- UIProcess/API/glib/WebKitMimeInfo.cpp:
(webkit_mime_info_ref):
(webkit_mime_info_unref):
(webkit_mime_info_get_mime_type):
(webkit_mime_info_get_description):
(webkit_mime_info_get_extensions):
- UIProcess/API/glib/WebKitMimeInfoPrivate.h: Removed.
- UIProcess/API/glib/WebKitPlugin.cpp:
(webkit_plugin_get_name):
(webkit_plugin_get_description):
(webkit_plugin_get_path):
(webkit_plugin_get_mime_info_list):
- UIProcess/API/glib/WebKitPluginPrivate.h: Removed.
- UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_plugins):
(webkit_settings_set_enable_plugins):
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_set_additional_plugins_directory):
(webkit_web_context_get_plugins):
(webkit_web_context_get_plugins_finish):
- UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewLoadFail):
- UIProcess/API/glib/WebKitWebsiteData.cpp:
(recordContainsSupportedDataTypes):
(toWebKitWebsiteDataTypes):
- UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(toWebsiteDataTypes):
- UIProcess/API/gtk/WebKitError.h:
- UIProcess/API/gtk/WebKitMimeInfo.h:
- UIProcess/API/gtk/WebKitPlugin.h:
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/WebKitWebsiteData.h:
- UIProcess/API/wpe/WebKitError.h:
- UIProcess/API/wpe/WebKitMimeInfo.h:
- UIProcess/API/wpe/WebKitPlugin.h:
- UIProcess/API/wpe/WebKitSettings.h:
- UIProcess/API/wpe/WebKitWebContext.h:
- UIProcess/API/wpe/WebKitWebsiteData.h:
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bubblewrapSpawn):
- UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Plugins/gtk/PluginInfoCache.cpp: Removed.
- UIProcess/Plugins/gtk/PluginInfoCache.h: Removed.
- UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: Removed.
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp: Removed.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/gtk/WebPageProxyGtk.cpp:
- WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp: Removed.
- WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h: Removed.
- WebProcess/Plugins/Netscape/unix/PluginProxyUnix.cpp: Removed.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Removed.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h: Removed.
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/Plugins/PluginView.h:
Tools:
- PlatformGTK.cmake:
- TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):
- TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(beforeAll):
LayoutTests:
Skip tests using plugins and remove expectations.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/plugin-expected.txt: Removed.
- platform/gtk/http/tests/plugins/plugin-javascript-access-allow-all-plugins-expected.txt: Removed.
- platform/gtk/plugins/document-open-expected.txt: Removed.
- platform/gtk/plugins/embed-attributes-style-expected.png: Removed.
- platform/gtk/plugins/embed-attributes-style-expected.txt: Removed.
- platform/gtk/plugins/iframe-plugin-bgcolor-expected.png: Removed.
- platform/gtk/plugins/invalidate-rect-with-null-npp-argument-expected.txt: Removed.
- platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html: Removed.
- platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
- platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
- platform/gtk/plugins/nested-plugin-objects-expected.txt: Removed.
- platform/gtk/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
- platform/gtk/plugins/netscape-dom-access-expected.png: Removed.
- platform/gtk/plugins/netscape-dom-access-expected.txt: Removed.
- platform/gtk/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Removed.
- platform/gtk/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Removed.
- platform/gtk/plugins/plugin-clip-subframe-expected.txt: Removed.
- platform/gtk/plugins/plugin-initiate-popup-window-expected.txt: Removed.
- platform/gtk/plugins/plugin-javascript-access-expected.txt: Removed.
- platform/gtk/plugins/resize-from-plugin-expected.txt: Removed.
- platform/wpe/TestExpectations:
- 5:21 AM Changeset in webkit [265752] by
-
- 2 edits in trunk/Source/WebKit
Set Sec-WebSocket-Protocol for WebSocket NSURLSession code path
https://bugs.webkit.org/show_bug.cgi?id=215456
<rdar://problem/66996369>
Reviewed by Alex Christensen.
Covered by existing protocol tests with NSURLSession code path enabled.
http/tests/websocket/tests/hybi/set-protocol.html, http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html
Code change originating from Jiten Mehta.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):
Set Sec-WebSocket-Protocol to support WebSocket protocol negotiation.
- 4:04 AM Changeset in webkit [265751] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r265725) [GTK][WPE] Several http/tests timeout/failures
https://bugs.webkit.org/show_bug.cgi?id=215542
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-08-17
Reviewed by Sergio Villar Senin.
The problem is that ShareableResource is now using the dataSize member of IPCHandle to encode/decode the
resource size, but SharedMemoryUnix is not encoding/decoding dataSize.
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::IPCHandle::encode const):
(WebKit::SharedMemory::IPCHandle::decode):
- 12:38 AM Changeset in webkit [265750] by
-
- 2 edits in trunk/Tools
Update W3C test exporter to use Authorisation header instead of query parameter to validate GitHub account
https://bugs.webkit.org/show_bug.cgi?id=215548
Reviewed by Darin Adler.
- Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter._validate_and_save_token):
access_token query parameter is dbeing deprecated in favor of Authorization header.
Update script accordingly.
- 12:37 AM Changeset in webkit [265749] by
-
- 74 edits2 adds in trunk
JSDOMConstructorNotConstructable should be a constructor
https://bugs.webkit.org/show_bug.cgi?id=215554
<rdar://problem/65770688>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/FileAPI/file/send-file-form-expected.txt:
- web-platform-tests/FileAPI/file/send-file-form-iso-2022-jp.tentative-expected.txt:
- web-platform-tests/FileAPI/file/send-file-form-utf-8-expected.txt:
- web-platform-tests/FileAPI/file/send-file-form-windows-1252.tentative-expected.txt:
- web-platform-tests/FileAPI/file/send-file-form-x-user-defined.tentative-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-constructable-baseURL.tentative-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-constructable-disabled-regular-sheet-insertion-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-constructable-disallow-import.tentative-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-constructable-duplicate-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-constructable-expected.txt:
- web-platform-tests/css/cssom/CSSStyleSheet-modify-after-removal-expected.txt:
- web-platform-tests/custom-elements/Document-createElement-expected.txt:
- web-platform-tests/custom-elements/Document-createElementNS-expected.txt:
- web-platform-tests/custom-elements/HTMLElement-attachInternals-expected.txt:
- web-platform-tests/custom-elements/HTMLElement-constructor-expected.txt:
- web-platform-tests/custom-elements/builtin-coverage-expected.txt:
- web-platform-tests/custom-elements/customized-built-in-constructor-exceptions-expected.txt:
- web-platform-tests/custom-elements/htmlconstructor/newtarget-expected.txt:
- web-platform-tests/custom-elements/parser/serializing-html-fragments-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLAreaElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLBaseElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLButtonElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLCanvasElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLDataElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLDetailsElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLEmbedElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLFieldSetElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLImageElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLLIElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLLabelElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLMapElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLMediaElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLMetaElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLMeterElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLModElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLOListElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLOptGroupElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLParamElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLProgressElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLQuoteElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLSlotElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLStyleElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLTableCellElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLTableColElement-expected.txt:
- web-platform-tests/custom-elements/reactions/HTMLTimeElement-expected.txt:
- web-platform-tests/custom-elements/upgrading/Document-importNode-expected.txt:
- web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt:
- web-platform-tests/dom/nodes/Node-appendChild-cereactions-vs-script.window-expected.txt:
- web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:
- web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:
- web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub-expected.txt:
- web-platform-tests/service-workers/service-worker/data-transfer-files.https-expected.txt:
- web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt:
- web-platform-tests/user-timing/mark-entry-constructor.any-expected.txt:
- web-platform-tests/user-timing/mark-entry-constructor.any.worker-expected.txt:
- web-platform-tests/user-timing/structured-serialize-detail.any-expected.txt:
- web-platform-tests/user-timing/structured-serialize-detail.any.worker-expected.txt:
- web-platform-tests/webrtc/RTCIceTransport-extension.https-expected.txt:
Source/WebCore:
Test: js/dom/window-is-constructor.html
While JSDOMConstructorNotConstructable throws an error, still it should be a constructor, which means,
IsConstructor(JSDOMConstructorNotConstructable)should be true. To fix it, we add getConstructData
which configures a function throwing an error.
- bindings/js/JSDOMConstructorNotConstructable.h:
LayoutTests:
- editing/async-clipboard/clipboard-interfaces-expected.txt:
- editing/undo-manager/undo-manager-interfaces-expected.txt:
- fast/dom/MutationObserver/mutation-record-constructor-expected.txt:
- http/wpt/html/browsers/the-window-object/window-is-constructor-expected.txt: Added.
- http/wpt/html/browsers/the-window-object/window-is-constructor.html: Added.
- js/interface-objects-expected.txt:
- performance-api/paint-timing/paint-timing-apis-expected.txt:
- performance-api/performance-observer-api-expected.txt:
- performance-api/performance-timeline-api-expected.txt:
- performance-api/resource-timing-apis-expected.txt:
- performance-api/user-timing-apis-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLInputElement-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
- 12:31 AM Changeset in webkit [265748] by
-
- 5 edits in trunk
Make sure writableStreamDefaultWriterEnsureClosedPromiseRejected overwrite the closedPromise if needed
https://bugs.webkit.org/show_bug.cgi?id=215540
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/streams/writable-streams/aborting.any-expected.txt:
- web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt:
Source/WebCore:
Covered by rebased tests.
- Modules/streams/WritableStreamInternals.js:
(writableStreamDefaultWriterEnsureClosedPromiseRejected):
As per spec, if promise is already settled, we overwrite it to reject it.
- 12:26 AM Changeset in webkit [265747] by
-
- 6 edits in trunk
Check WritableStream underlyingSink methods
https://bugs.webkit.org/show_bug.cgi?id=215539
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt:
- web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.js:
(test):
- web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt:
Source/WebCore:
Covered by updated tests.
- Modules/streams/WritableStream.js:
(initializeWritableStream):
Aug 16, 2020:
- 11:29 PM Changeset in webkit [265746] by
-
- 11 edits in trunk/Source/WebCore
Fix some spelling and editorial issues
https://bugs.webkit.org/show_bug.cgi?id=215553
Reviewed by Darin Adler.
"Stretches" has a t in the middle, and "padding" is singular.
- inspector/InspectorOverlay.cpp:
(WebCore::buildRendererHighlight):
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::geometryForBox const):
- layout/FormattingContext.h:
- layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
- rendering/RenderTableCell.cpp:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
- 6:48 PM Changeset in webkit [265745] by
-
- 4 edits in trunk/LayoutTests
Remove several unnecessary timeouts in layout tests
https://bugs.webkit.org/show_bug.cgi?id=215552
Reviewed by Darin Adler.
Remove several
setTimeout(finishJSTest, s);calls in layout tests. These were probably added in the process of
developing or debugging these tests, and were not intended to be landed.
- editing/pasteboard/data-transfer-set-data-sanitize-html-when-dragging-in-null-origin.html:
- fast/forms/ios/show-and-dismiss-date-input.html:
- http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html:
- 1:40 PM Changeset in webkit [265744] by
-
- 33 edits6 adds in trunk
Remove OpIsObjectOrNull from ClassExprNode::emitBytecode()
https://bugs.webkit.org/show_bug.cgi?id=214525
Reviewed by Keith Miller.
Source/JavaScriptCore:
This patch:
- Replaces OpIsObjectOrNull in ClassExprNode::emitBytecode() [1] with emitIsObject() +
emitIsNull(), preventing DFG/FTL from throwing a TypeError if
document.allis the value of superclass "prototype" property, which aligns JSC with V8 and SpiderMonkey. Also, tweaks error message to reflect thatnullis allowed.
- Renames is_object_or_null bytecode op to typeof_is_object, fixing the confusing
operationObjectIsObject() name, and aligns it with typeof_is_undefined.
New name offers better semantics and clearly communicates the op should be avoided when
implementing new features because of
typeofbehavior with IsHTMLDDA objects [2].
[1]: https://tc39.es/ecma262/#sec-runtime-semantics-classdefinitionevaluation (step 5.g.ii)
[2]: https://tc39.es/ecma262/#sec-IsHTMLDDA-internal-slot-typeof
- bytecode/BytecodeList.rb:
- bytecode/BytecodeUseDef.cpp:
(JSC::computeUsesForBytecodeIndexImpl):
(JSC::computeDefsForBytecodeIndexImpl):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitEqualityOpImpl):
- bytecompiler/NodesCodegen.cpp:
(JSC::ClassExprNode::emitBytecode):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGHeapLocation.cpp:
(WTF::printInternal):
- dfg/DFGHeapLocation.h:
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileTypeOfIsObject):
(JSC::DFG::SpeculativeJIT::compileIsObjectOrNull): Deleted.
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileTypeOfIsObject):
(JSC::FTL::DFG::LowerDFGToB3::compileIsObjectOrNull): Deleted.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- llint/LowLevelInterpreter.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
- runtime/Operations.cpp:
(JSC::jsTypeofIsObject):
(JSC::jsIsObjectTypeOrNull): Deleted.
- runtime/Operations.h:
LayoutTests:
New tests are added for
document.allrather thanmakeMasquerader()since
the latter has sufficient test coverage and takes the short path as JSFunction.
- js/class-syntax-extends-expected.txt:
- js/dom/document-all-class-extends-expected.txt: Added.
- js/dom/document-all-class-extends.html: Added.
- js/dom/document-all-typeof-is-object-fold-expected.txt: Added.
- js/dom/document-all-typeof-is-object-fold.html: Added.
- js/dom/script-tests/document-all-class-extends.js: Added.
- js/dom/script-tests/document-all-typeof-is-object-fold.js: Added.
- js/script-tests/class-syntax-extends.js:
- 1:16 PM Changeset in webkit [265743] by
-
- 6 edits in trunk/Source
Scrolling sync changes in r261985 regressed CPU usage by ~2 ms/s
https://bugs.webkit.org/show_bug.cgi?id=215529
<rdar://problem/66866163>
Reviewed by Geoff Garen.
Source/WebCore:
r261985 added two code paths that wake up the scrolling thread on every
rendering update (triggered by displayDidRefresh()). One is a ping from
the EventDispatcher thread, the other is a wake-and-block from the main
thread. If the scrolling thread isn't active (no wheel events received recently),
we can avoid both of these to reduce the number of CPU core wakeups.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::isRecentlyActive):
(WebCore::ScrollingTree::setRecentlyActive):
- page/scrolling/ScrollingTree.h:
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::willStartRenderingUpdate):
(WebCore::ThreadedScrollingTree::displayDidRefresh):
Source/WebKit:
r261985 added two code paths that wake up the scrolling thread on every
rendering update (triggered by displayDidRefresh()). One is a ping from
the EventDispatcher thread, the other is a wake-and-block from the main
thread. If the scrolling thread isn't active (no wheel events received recently),
we can avoid both of these to reduce the number of CPU core wakeups.
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
- 12:11 PM Changeset in webkit [265742] by
-
- 4 edits in trunk
[AS Layout Tests] 6 WPT css-backgrounds tests consistently failing
https://bugs.webkit.org/show_bug.cgi?id=215533
rdar://66660924
Reviewed by Youenn Fablet.
Source/WebCore:
A static_cast from float to int, where the float value is larger than MAX_INT, produces
different results on x86_64 and arm64e. Unfortunately, fixing this exposed the fact
that we were accidentally passing the tests below on Intel.
This commit addresses the casting issue and marks the tests as now accurately
failing. Details on the new bug at: webkit.org/b/206753
Covered by:
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--contain--height.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--contain--width.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--contain--height.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--contain--width.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::containerSize const): Don't static_cast from float to int. Rather, use
the explicit IntSize constructor.
LayoutTests:
- TestExpectations: Mark some tests as failing.
- 1:16 AM Changeset in webkit [265741] by
-
- 2 edits in trunk/JSTests
Unreviewed, reduce iteration count more for non-JIT environments
If JSC does not have JIT, many iterations do not matter.
- stress/memcpy-typed-loops.js:
Aug 15, 2020:
- 3:53 PM Changeset in webkit [265740] by
-
- 5 edits in trunk
Live Web Content processes do not respect accent color if dynamically changed to "multicolor"
https://bugs.webkit.org/show_bug.cgi?id=215523
<rdar://problem/63941133>
Reviewed by Wenson Hsieh.
Source/WebKit:
- UIProcess/Cocoa/PreferenceObserver.mm:
(-[WKUserDefaults _notifyObserversOfChangeFromValuesForKeys:toValuesForKeys:]):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::setPreferenceValue):
The NSUserDefaults syncing mechanism does not propagate defaults that are
deleted or changed to nil.
Allow nil, and fix up an assert that would fire for the same reason.
Tools:
- TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
(deleteTestDefaults):
(TEST):
Fix some minor style issues with these tests.
Fix a bug where these tests would leak state between themselves by leaving defaults behind.
Change the NSUserDefaults key name so that it is abundantly obvious where it comes from when you see it in your defaults.
Leave a FIXME for the future that these tests should probably not be writing to the real persistent defaults.
Add a test that ensures that the observer correctly respects deletion of a default.
- 1:26 PM Changeset in webkit [265739] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merged r264676 - Update Chrome and Firefox versions in user agent quirks
https://bugs.webkit.org/show_bug.cgi?id=214595
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-07-21
Reviewed by Adrian Perez de Castro.
- platform/UserAgentQuirks.cpp:
(WebCore::UserAgentQuirks::stringForQuirk):
- 1:26 PM Changeset in webkit [265738] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merged r264986 - [GTK] Crash in Nicosia::GC3DLayer::makeContextCurrent due to failure in EGL display creation
https://bugs.webkit.org/show_bug.cgi?id=201507
Reviewed by Carlos Garcia Campos.
Ensure that EGL context and display creation failures are always
logged using RELEASE_LOG_INFO(), even for intermediate failures for
which a fallback will be tried next, in order to ease diagnosis of
related issues. Failure to create contexts at the end of the public
methods ::createContext() and ::createSharingContext() is still
logged with WTFLogAlways() to write a notice to standard error, and
let users/developers know that something failed and checking the
complete logs (e.g. with "journalctl" on Linux) may reveal more
information.
This also replaces the chains of "if" statements with a single
"switch" on the PlatformDisplay::Type enum, which makes the code
easier to follow and should be more robust as well.
No new tests needed.
- platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::getEGLConfig):
(WebCore::GLContextEGL::createWindowContext):
(WebCore::GLContextEGL::createSurfacelessContext):
(WebCore::GLContextEGL::createContext):
(WebCore::GLContextEGL::createSharingContext):
- 1:26 PM Changeset in webkit [265737] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit
Merged r265326 - [WPE][GTK] Wrong argument order for clone syscall seccomp filter on s390x
https://bugs.webkit.org/show_bug.cgi?id=215212
Reviewed by Michael Catanzaro.
Patch based on this Flatpak pull request:
https://github.com/flatpak/flatpak/pull/3777
No new tests needed.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::setupSeccomp): Add preprocessor guard to choose the correct
clone() system call argument on S390.
- 1:25 PM Changeset in webkit [265736] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/JavaScriptCore
Merged r265692 - [ARMv7][JSC] Conservative GC is not considering
r7as a root
https://bugs.webkit.org/show_bug.cgi?id=215512
Reviewed by Yusuke Suzuki.
Since
r7is a callee-saved register on ARMv7
we need to consider it as a conservative root.
See the statement "A subroutine must preserve
the contents of the registers r4-r8, r10, r11
and SP (and r9 in PCS variants that designate
r9 as v6) form page 15 of
https://developer.arm.com/documentation/ihi0042/f/.
- heap/RegisterState.h:
- 1:04 PM WebKitGTK/2.28.x edited by
- (diff)
- 11:40 AM Changeset in webkit [265735] by
-
- 19 edits1 copy in trunk/Source/WTF
Use std::call_once + LazyNeverDestroyed to initialize complex data structures
https://bugs.webkit.org/show_bug.cgi?id=215535
<rdar://problem/66774266>
Reviewed by Mark Lam.
NeverDestroyed<> is not thread-safe in Darwin build since it is not using C++11 thread-safe static variable semantics.
This patch uses LazyNeverDestroyed and call_once to initialize complex data structures so that we can ensure they are
initialized atomically.
We also move some of
singletondefinitions from headers to cpp files. This is important since this ensures that singleton
is only one instance which is generated in one translation unit.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/FastMalloc.cpp:
(WTF::MallocCallTracker::singleton):
- wtf/Language.cpp:
(WTF::observerMap):
(WTF::preferredLanguagesOverride):
- wtf/Logger.cpp:
(WTF::Logger::observers):
- wtf/Logger.h:
(WTF::Logger::observerLock):
(WTF::Logger::observers): Deleted.
- wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::singleton):
- wtf/MemoryPressureHandler.h:
- wtf/RunLoop.cpp:
(WTF::RunLoop::current):
- wtf/Threading.cpp:
(WTF::Thread::initializeInThread):
- wtf/URL.cpp:
(WTF::aboutBlankURL):
(WTF::aboutSrcDocURL):
- wtf/cf/LanguageCF.cpp:
(WTF::preferredLanguages):
- wtf/cocoa/NSURLExtras.mm:
(WTF::rangeOfURLScheme):
- wtf/text/LineBreakIteratorPoolICU.cpp: Copied from Source/WTF/wtf/Logger.cpp.
(WTF::LineBreakIteratorPool::sharedPool):
- wtf/text/LineBreakIteratorPoolICU.h:
(WTF::LineBreakIteratorPool::sharedPool): Deleted.
- wtf/text/StringView.cpp:
- wtf/text/TextBreakIterator.cpp:
(WTF::TextBreakIteratorCache::singleton):
- wtf/text/TextBreakIterator.h:
(WTF::TextBreakIteratorCache::singleton): Deleted.
- wtf/threads/Signals.cpp:
(WTF::activeThreads):
- 10:49 AM Changeset in webkit [265734] by
-
- 2 edits in trunk/Source/WebCore
Revert unnecessary change for https://bugs.webkit.org/show_bug.cgi?id=215521.
https://bugs.webkit.org/show_bug.cgi?id=215541
Reviewed by Chris Fleizach.
These additional checks are no longer necessary since makeSimpleRange
returns a null Optional if any of the VisiblePosition parameters is
null. Darin Adler already fixed the crasher in
https://bugs.webkit.org/show_bug.cgi?id=215521
with the patch
https://trac.webkit.org/changeset/265044/webkit.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rangeMatchesTextNearRange):
- 10:29 AM Changeset in webkit [265733] by
-
- 2 edits in trunk/LayoutTests
[GTK][WPE] Add provisional expectation to http/tests to allow the bots to run
Unreviewed test gardening.
- platform/glib/TestExpectations:
- 9:25 AM Changeset in webkit [265732] by
-
- 9 edits in trunk
WritableStream rejected promises should be marked as handled as per spec
https://bugs.webkit.org/show_bug.cgi?id=215501
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/streams/writable-streams/aborting.any-expected.txt:
- web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt:
- web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt:
- web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt:
- web-platform-tests/streams/writable-streams/close.any-expected.txt:
- web-platform-tests/streams/writable-streams/close.any.worker-expected.txt:
Source/WebCore:
Marking promises that got rejected as handled to ensure onunhandledrejection handler is not called erroneously.
Covered by rebased tests.
- Modules/streams/WritableStreamInternals.js:
(setUpWritableStreamDefaultWriter):
(writableStreamRejectCloseAndClosedPromiseIfNeeded):
(writableStreamDefaultWriterEnsureClosedPromiseRejected):
(writableStreamDefaultWriterEnsureReadyPromiseRejected):
- 6:32 AM WebKitGTK/2.30.x edited by
- (diff)
- 6:30 AM Changeset in webkit [265731] by
-
- 2 edits in releases/WebKitGTK/webkit-2.30/Source/JavaScriptCore
Merged r265692 - [ARMv7][JSC] Conservative GC is not considering
r7as a root
https://bugs.webkit.org/show_bug.cgi?id=215512
Reviewed by Yusuke Suzuki.
Since
r7is a callee-saved register on ARMv7
we need to consider it as a conservative root.
See the statement "A subroutine must preserve
the contents of the registers r4-r8, r10, r11
and SP (and r9 in PCS variants that designate
r9 as v6) form page 15 of
https://developer.arm.com/documentation/ihi0042/f/.
- heap/RegisterState.h:
- 6:22 AM Changeset in webkit [265730] by
-
- 1 copy in releases/WPE WebKit/webkit-2.29.90
WPE WebKit 2.29.90
- 6:22 AM Changeset in webkit [265729] by
-
- 4 edits in releases/WebKitGTK/webkit-2.30
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.29.90 release
.:
- Source/cmake/OptionsWPE.cmake: Bump version numbers.
Source/WebKit:
- wpe/NEWS: Add release notes for 2.29.90.
- 5:51 AM WebKitGTK/2.28.x edited by
- (diff)
- 5:50 AM WebKitGTK/2.30.x edited by
- (diff)
- 5:49 AM WebKitGTK/2.30.x edited by
- (diff)
- 1:39 AM Changeset in webkit [265728] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed non-unified source build fix
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp: Add missing OperandsInlines.h header.
Aug 14, 2020:
- 8:58 PM Changeset in webkit [265727] by
-
- 4 edits in trunk/Source/WebKit
Revert r263551
https://bugs.webkit.org/show_bug.cgi?id=215530
<rdar://problem/66961066>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-14
Reviewed by Geoffrey Garen.
I was hoping to fix many developers' bugs, but it caused hangs and more hangs, so back to the status quo.
https://bugs.webkit.org/show_bug.cgi?id=203547 will fix this the right way in the hopefully-not-too-distant future.
- UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::setCookies):
(API::HTTPCookieStore::registerForNewProcessPoolNotifications):
(API::HTTPCookieStore::flushDefaultUIProcessCookieStore):
- UIProcess/API/APIHTTPCookieStore.h:
- UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm:
(API::HTTPCookieStore::flushDefaultUIProcessCookieStore):
- 8:15 PM Changeset in webkit [265726] by
-
- 1 edit6 adds in trunk/LayoutTests
[GTK][WPE] Add platform baselines after r265701
Unreviewed test gardening.
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-tail-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt: Added.
- 6:46 PM Changeset in webkit [265725] by
-
- 31 edits in trunk/Source/WebKit
Convert remaining SharedMemory::Handle to SharedMemory::IPCHandle
https://bugs.webkit.org/show_bug.cgi?id=215471
<rdar://problem/67024177>
Reviewed by David Kilzer.
Use the new struct for sending SharedMemory::Handle objects via IPC, so
we can include the exact size of data (SharedMemory::Handle::size()
rounds up to the nearest page), and verify these sizes match when decoding.
In many cases, the size is not sent as a separate argument via IPC, so
we can initialize the IPCHandle object with SharedMemory::Handle::size().
We can remove the additional size parameter when it exists, because
we are now passing IPCHandle which should include the size value.
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
(WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
(WebKit::RemoteMediaRecorder::audioSamplesStorageChanged):
- GPUProcess/webrtc/RemoteMediaRecorder.h:
- GPUProcess/webrtc/RemoteMediaRecorder.messages.in:
Send SharedMemory::IPCHandle object instead of SharedMemory::Handle
over IPC.
- NetworkProcess/ServiceWorker/WebSWOriginStore.cpp:
(WebKit::WebSWOriginStore::sendStoreHandle):
Since no additional size parameter is being sent in this function, we
can use handle.size() as the IPCHandle::dataSize parameter.
- Platform/SharedMemory.h:
Remove encode/decode functions in SharedMemory::Handle.
- Platform/cocoa/SharedMemoryCocoa.cpp:
(WebKit::SharedMemory::Handle::encode const): Deleted.
(WebKit::SharedMemory::Handle::decode): Deleted.
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::IPCHandle::encode const):
(WebKit::SharedMemory::IPCHandle::decode):
- Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::IPCHandle::encode const):
(WebKit::SharedMemory::IPCHandle::decode):
(WebKit::SharedMemory::Handle::encode const): Deleted.
(WebKit::SharedMemory::Handle::decode): Deleted.
Remove SharedMemory::Handle encode/decode functions so we will not
ever send a SharedMemory::Handle object over IPC accidentally in the future.
- Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::encode const):
(WebKit::ShareableBitmap::Handle::decode):
Keep m_size here because it is an IntSize object and is useful to
check width/height parameters in the SharableBitmap object.
- Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::encode const):
(WebKit::ShareableResource::Handle::decode):
- Shared/WebCompiledContentRuleListData.cpp:
(WebKit::WebCompiledContentRuleListData::encode const):
(WebKit::WebCompiledContentRuleListData::decode):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeSharedBuffer):
(IPC::decodeSharedBuffer):
- Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::encode const):
(WebKit::WebHitTestResultData::decode):
More cases of converting between SharedMemory::Handle and
SharedMemory::IPCHandle when encoding/decoding.
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
- UIProcess/VisitedLinkStore.cpp:
(WebKit::VisitedLinkStore::sendStoreHandleToProcess):
- WebProcess/GPU/media/RemoteAudioBusData.h:
(WebKit::RemoteAudioBusData::encode const):
(WebKit::RemoteAudioBusData::decode):
Since no additional size parameter is being sent in this function, we
can use handle.size() as the IPCHandle::dataSize parameter.
- WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:
(WebKit::AudioMediaStreamTrackRenderer::storageChanged):
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
(WebKit::MediaRecorderPrivate::storageChanged):
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::setSWOriginTableSharedMemory):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWClientConnection.messages.in:
- WebProcess/WebPage/VisitedLinkTableController.cpp:
(WebKit::VisitedLinkTableController::setVisitedLinkTable):
- WebProcess/WebPage/VisitedLinkTableController.h:
- WebProcess/WebPage/VisitedLinkTableController.messages.in:
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
(WebKit::RemoteCaptureSampleManager::audioStorageChanged):
- WebProcess/cocoa/RemoteCaptureSampleManager.h:
- WebProcess/cocoa/RemoteCaptureSampleManager.messages.in:
More cases of converting between SharedMemory::Handle and
SharedMemory::IPCHandle when encoding/decoding.
- 6:24 PM Changeset in webkit [265724] by
-
- 4 edits3 adds in trunk
Web Inspector: Assertion Failed: Appended a string with newlines. This breaks the source map.
https://bugs.webkit.org/show_bug.cgi?id=215494
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
- UserInterface/Workers/Formatter/JSFormatter.js:
(JSFormatter.prototype._insertComment):
C-style comments can contain newlines, so useappendStringWithPossibleNewlines.
LayoutTests:
- inspector/formatting/resources/javascript-source-map-tests/2.js: Added.
- inspector/formatting/source-map-javascript-2.html: Added.
- inspector/formatting/source-map-javascript-2-expected.txt: Added.
With
appendStringWithPossibleNewlinesthe source map properly indents the comment inside
the function body so that the*all line up.
- 5:35 PM Changeset in webkit [265723] by
-
- 2 edits in trunk/Source/WebCore
Crash inside FrameLoader::defaultRequestCachingPolicy (null DocumentLoader)
<rdar://problem/42167093> and https://bugs.webkit.org/show_bug.cgi?id=215527
Reviewed by Darin Adler.
We have CrashTracer data, but despite my best efforts no way of reproducing.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultRequestCachingPolicy): If a PingLoader is sending a CSP violation
report sometime after part of the Document's lifecycle, the FrameLoader as a null DocumentLoader here.
Like everywhere else in FrameLoader, null check it.
- 5:28 PM Changeset in webkit [265722] by
-
- 2 edits in trunk/Source/WebCore
RenderTextControlSingleLine::scroll* functions should not call Element::scroll* on the inner text content
https://bugs.webkit.org/show_bug.cgi?id=215516
<rdar://problem/64739768>
Reviewed by Simon Fraser.
Normally the RenderBox::content*, border*, padding* and scroll* functions grab the geometry information from the renderer itself.
The clients of these functions expect the geometry data to be consistent with the rest of the rendering context
(e.g coordinates are in the coordinate system of the containing block, paint time operations are not applied etc).
Also these functions are supposed to be const. They should not mutate the geometry or the render tree itself.
Forwarding ::scroll* calls to Element::scroll* can't guarantee neither of these above.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::scrollWidth const):
(WebCore::RenderTextControlSingleLine::scrollHeight const):
(WebCore::RenderTextControlSingleLine::scrollLeft const):
(WebCore::RenderTextControlSingleLine::scrollTop const):
- 5:17 PM Changeset in webkit [265721] by
-
- 8 edits in branches/safari-610.1-branch
Cherry-pick r265709. rdar://problem/67106107
RTL: volume slider and icons are backwards
https://bugs.webkit.org/show_bug.cgi?id=215482
<rdar://problem/65730749>
Reviewed by Eric Carlson.
Source/WebCore:
- Modules/modern-media-controls/controls/inline-media-controls.js: (InlineMediaControls.prototype.layout): Flip the inline volume button when not in LTR.
- Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js: (MacOSFullscreenMediaControls.prototype.layout): (MacOSFullscreenMediaControls.prototype._volumeControlsForCurrentDirection): Added. Reverse the order of the fullscreen volume controls when not in LTR.
- Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css: (.media-controls.mac.fullscreen:not(.uses-ltr-user-interface-layout-direction) :is(.volume-down, .volume.slider, .volume-up)): Added. (.media-controls.mac.fullscreen:not(.uses-ltr-user-interface-layout-direction) .volume.slider): Deleted. Also flip the fullscreen volume up and volume down buttons.
LayoutTests:
MacOSFullscreenMediaControlsdefaults to havingusesLTRUserInterfaceLayoutDirectionbe
false, so flip the order of the volume controls to match the non-LTR UI.
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-styles.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:16 PM Changeset in webkit [265720] by
-
- 17 edits in branches/safari-610.1-branch/Source/WebKit
Cherry-pick r265702. rdar://problem/67106079
Convert SharedMemory::Handle to SharedMemory::IPCHandle WebPage image/pasteboard functions
https://bugs.webkit.org/show_bug.cgi?id=215478
<rdar://problem/67024582>
Reviewed by Chris Dumez.
Convert SharedMemory::Handle objects to SharedMemory::IPCHandle
objects which automatically verify the size of data being sent.
We can remove the additional size parameter being sent in many IPC
messages along with the handle, now that both are stored in the
IPCHandle struct.
- UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::setPromisedDataForImage):
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::getPasteboardBufferForType): No longer need size check, this is done in the IPCHandle::decode() function. (WebKit::WebPasteboardProxy::setPasteboardBufferForType): (WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPasteboardProxy.cpp: (WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebPasteboardProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::saveImageToLibrary):
- UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::dataSelectionForPasteboard): No longer need size check, this is done in the IPCHandle::decode() function. (WebKit::WebPageProxy::setPromisedDataForImage):
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::writeItemsToPasteboard):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::bufferForType): (WebKit::WebPlatformStrategies::setBufferForType): (WebKit::WebPlatformStrategies::readBufferFromPasteboard): No longer need size check, this is done in the IPCHandle::decode() function.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::WebDragClient::declareAndWriteDragImage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getDataSelectionForPasteboard): (WebKit::WebPage::performActionOnElement):
- WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getDataSelectionForPasteboard):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:16 PM Changeset in webkit [265719] by
-
- 2 edits in branches/safari-610.1-branch/Source/WebCore
Cherry-pick r265690. rdar://problem/67100613
The PiP button on the fullscreen youtube player disappears after starting a new video in a playlist
https://bugs.webkit.org/show_bug.cgi?id=215488
Reviewed by Eric Carlson.
When a fullscreen video player (e.g., YouTube.com) completes the current video and starts
the next one in a playlist, it may reuse the video element, so m_mediaElement of the
PlaybackSessionModelMediaElement instance won't change. However, the video element
will exit video fullscreen standby and then enter video fullscreen standby. Those
transitions are invisible to users. But the corresponding PlaybackSessionModelContext
instance will be destroyed and a new instance will be created.
By default, the member variable m_pictureInPictureSupported of the PlaybackSessionModelContext
instance is "false". After a new video starts to play, the function
PlaybackSessionModelMediaElement::setMediaElement() won't ask the PlaybackSessionManager
to send a PlaybackSessionManagerProxy::PictureInPictureSupportedChanged message
(because we don't change m_mediaElement) to notify the PlaybackSessionModelContext
instance in the UI process that m_pictureInPictureSupported should be "true". Therefore,
the PlaybackSessionModelContext instance will tell the WKFullScreenViewController instance
that picture-in-picture is not supported, which in turn will hide the picture-in-picture button.
With this patch, PlaybackSessionModelMediaElement::setMediaElement() will ask the
PlaybackSessionManager instance to send an IPC message if m_mediaElement is not nullptr
even we don't change the media element. So that the PlaybackSessionModelContext instance
in the UI process will always have a consistent state as the PlaybackSessionModelMediaElement
instance in the Web process.
- platform/cocoa/PlaybackSessionModelMediaElement.mm: (WebCore::PlaybackSessionModelMediaElement::setMediaElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:16 PM Changeset in webkit [265718] by
-
- 8 edits1 add in branches/safari-610.1-branch
Cherry-pick r265685. rdar://problem/67106093
OSRAvailabilityAnalysis shouldn't mark GetStack nodes directly as valid places for recovery
https://bugs.webkit.org/show_bug.cgi?id=215434
Reviewed by Saam Barati.
JSTests:
- stress/for-of-post-sinking-osr-availability.js: Added. (foo):
Source/JavaScriptCore:
It's somewhat subtle why we cannot use the node for the GetStack
itself in the Availability's node field. The reason is that if we
did we would need to make any phase that converts nodes to
GetStack availability aware. For instance, a place where this
could come up is in constant folding if you had a graph like the
following, which could arise from PutStack sinking:
BB#1:
@1: NewObject()
@2: MovHint(@1, inline-arg1)
@3: Jump(#2, #3)
BB#2:
@4: PutStack(@1, inline-arg1)
@5: GetMyArgumentByVal(inline-arg1)
@6: Jump(#3)
BB#3:
@7: InvalidationPoint()
If constant folding converts @5 to a GetStack then at @7
inline-arg1 won't be available since at the end of BB#1 our
availability is (@1, DeadFlush) and (@5,
FlushedAt(inline-arg1)). When that gets merged at BB#3 then the
availability will be (nullptr, ConflictingFlush).
This patch also makes validation check that availability is sane
at each pontential exit site if
Options::validateFTLOSRExitLiveness() is set. Since this is
actually a Phase we also need to make sure that we don't infinite
loop, so there is now a m_isValidating field on m_graph. The
validateOSRExitAvailability phase is also careful not to modify
the Graph, in order to avoid masking bugs when validating.
In a followup patch I intend to look into why MovHint elimination
will convert:
@2: MovHint(@0, loc1, bc#1, ExitInvalid)
@3: KillStack(loc1, bc#2, ExitValid)
@4: MovHint(@1 loc1, bc#2, ExitInvalid)
into
@2: ZombieHint(@0, loc1, bc#1, ExitInvalid)
@3: KillStack(loc1, bc#2, ExitValid)
@4: MovHint(@1 loc1, bc#2, ExitInvalid)
when loc1 is live in the bytecode at bc#2. But for now, the
validation rule works around this by only checking when mayExit
and the nodes exitOK agree exiting is possible.
- dfg/DFGGraph.h:
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp: (JSC::DFG::OSRAvailabilityAnalysisPhase::OSRAvailabilityAnalysisPhase): (JSC::DFG::OSRAvailabilityAnalysisPhase::run): (JSC::DFG::performOSRAvailabilityAnalysis): (JSC::DFG::validateOSRExitAvailability): (JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):
- dfg/DFGOSRAvailabilityAnalysisPhase.h:
- dfg/DFGPhase.h: (JSC::DFG::runPhase):
- dfg/DFGValidate.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:16 PM Changeset in webkit [265717] by
-
- 14 edits in branches/safari-610.1-branch/Source
Cherry-pick r265623. rdar://problem/67100650
REGRESSION (r260684): Messages YouTube inline video: after Multitasking away and Back, Audio is heard but icon indicates "muted"
https://bugs.webkit.org/show_bug.cgi?id=215453
<rdar://problem/66136673>
Reviewed by Tim Horton.
Source/WebCore:
r260684 silenced all JS events during the snapshot sequence that occurs whenever the user homes out of Safari.
This was meant to address compatibility with websites that did not expect various resize/orientationchange
events when homing out. However, the snapshot sequence is fairly long and this was causing us to silence JS
events which have nothing to do with the snapshot sequence, like window.postMessage()'s message events. This is
what caused this regression.
To address the issue, this patch basically reverts r260684 and deals with websites-compatibility issues via
less risky site-specific and event-specific quirks:
- We silence Window resize events on nytimes.com to address <rdar://problem/59763843>.
- We silence Window resize events and MediaQueryList change events on twitter.com to address <rdar://problem/58804852> and <rdar://problem/61731801>.
- css/MediaQueryMatcher.cpp: (WebCore::MediaQueryMatcher::evaluateAll):
- dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners):
- page/FrameView.cpp: (WebCore::FrameView::sendResizeEventIfNeeded):
- page/Page.h: (WebCore::Page::isTakingSnapshotsForApplicationSuspension const): (WebCore::Page::setIsTakingSnapshotsForApplicationSuspension): (WebCore::Page::shouldFireEvents const): Deleted. (WebCore::Page::setShouldFireEvents): Deleted.
- page/Quirks.cpp: (WebCore::Quirks::shouldSilenceWindowResizeEvents const): (WebCore::Quirks::shouldSilenceMediaQueryListChangeEvents const):
- page/Quirks.h:
Source/WebKit:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setIsDoingSnapshotSequence): (WebKit::WebPageProxy::setShouldFireEvents): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKApplicationStateTrackingView.mm: (-[WKApplicationStateTrackingView _willBeginSnapshotSequence]): (-[WKApplicationStateTrackingView _didCompleteSnapshotSequence]):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setIsDoingSnapshotSequence): (WebKit::WebPage::setShouldFireEvents): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:28 PM Changeset in webkit [265716] by
-
- 2 edits in trunk/Tools
[webkitcorepy] Add a NullHandler to logger
https://bugs.webkit.org/show_bug.cgi?id=215524
<rdar://problem/67102367>
Reviewed by Dewei Zhu.
- Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Add default logging handler to webkitcorepy.log.
- 4:27 PM Changeset in webkit [265715] by
-
- 6 edits2 adds in trunk/Source/WebKit
[Cocoa] Avoid changing XPC target queue inside XPC event handler
https://bugs.webkit.org/show_bug.cgi?id=215460
Reviewed by Darin Adler.
In WebProcess::handleXPCEndpointMessages we currently change the XPC target queue for the XPC bootstrap connection while
under the XPC event handler. This sometimes causes simulated crashes on iOS and should be avoided. According to the
documentation in https://developer.apple.com/documentation/xpc/1448786-xpc_connection_set_target_queue?language=objc,
there does not seem to be anything saying this is a programming error, but the simulated crash claims otherwise. This
patch addresses this issue by changing the initial target queue for the XPC bootstrap connection from the main thread
queue to a queue on a secondary thread. The WebKit initializer function needs to be called on the main thread, which
is done by synchronously dispatching the call on the main thread. This patch also stops changing the event handler for
the bootstrap connection, but instead adds the additional XPC handling to the current event handler.
No new tests, since this is covered by existing tests. The handling of the Launch Services XPC endpoint message that
this patch changes, is used to receive the Launch Services database from the Networking process. The Launch Services
database is used in MIME type mapping APIs, and many tests would fail if this database was not received in the
WebContent process.
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::platformDidReceiveLoadParameters):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
- WebProcess/WebProcess.h:
- WebProcess/cocoa/HandleXPCEndpointMessages.h: Added.
- WebProcess/cocoa/HandleXPCEndpointMessages.mm: Added.
(WebKit::handleXPCEndpointMessages):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::handleXPCEndpointMessages const): Deleted.
- 4:09 PM Changeset in webkit [265714] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Assertion Failed: removeEventListener cannot remove css-manager-style-sheet-added because it doesn't exist.
https://bugs.webkit.org/show_bug.cgi?id=215495
Reviewed by Joseph Pecoraro.
- UserInterface/Views/FrameTreeElement.js:
(WI.FrameTreeElement.prototype.ondetach):
Checkthis.listItemElement, which is equivalent toWI.View.prototype.didInitialLayoutforWI.TreeElement.
- 3:54 PM Changeset in webkit [265713] by
-
- 16 edits in trunk
OfflineAudioContext.destination has incorrect number of channels & channel count mode
https://bugs.webkit.org/show_bug.cgi?id=215522
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
Note that some tests are now failing when checking the audio channels on the OfflineAudioContext's destination.
Previously, there were no such channels to check since the channel count was always 0.
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-scheduling-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/gain-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/ctor-offlineaudiocontext-expected.txt:
Source/WebCore:
OfflineAudioContext.destination currently always has a number of channels that is 0, no
matter the numberOfChannels provided when constructing the OfflineAudioContext. The
channel count mode is also "max" instead of "explicit" (as per [1]).
[1] https://www.w3.org/TR/webaudio/#AudioDestinationNode
No new tests, rebaselined existing tests.
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::maxChannelCount const):
- Modules/webaudio/OfflineAudioDestinationNode.h:
- 3:42 PM Changeset in webkit [265712] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Assertion Failed: removeEventListener cannot remove frame-main-resource-did-change because it doesn't exist.
https://bugs.webkit.org/show_bug.cgi?id=215496
Reviewed by Joseph Pecoraro.
- UserInterface/Views/ChangesDetailsSidebarPanel.js:
(WI.ChangesDetailsSidebarPanel.prototype.shown):
(WI.ChangesDetailsSidebarPanel.prototype.attached): Added.
(WI.ChangesDetailsSidebarPanel.prototype.detached):
Move event listener toattach, which is guaranteed to be called beforedetach.
- 3:33 PM Changeset in webkit [265711] by
-
- 19 edits in trunk
[WebGL2] releaseShaderCompiler is not allowed to be supported in WebGL
https://bugs.webkit.org/show_bug.cgi?id=215432
Patch by James Darpinian <James Darpinian> on 2020-08-14
Reviewed by Dean Jackson.
Source/WebCore:
Fixes WebGL conformance tests methods.html and methods-2.html
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::releaseShaderCompiler): Deleted.
- html/canvas/WebGLRenderingContextBase.h:
- html/canvas/WebGLRenderingContextBase.idl:
- platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::releaseShaderCompiler): Deleted.
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:
(WebCore::GraphicsContextGLOpenGL::releaseShaderCompiler): Deleted.
- platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:
(WebCore::GraphicsContextGLOpenGL::releaseShaderCompiler): Deleted.
LayoutTests:
- webgl/1.0.3/conformance/context/methods-expected.txt:
- webgl/2.0.0/conformance/context/methods-expected.txt:
- webgl/2.0.0/conformance2/context/methods-2-expected.txt:
- 3:30 PM Changeset in webkit [265710] by
-
- 2 edits in trunk/LayoutTests
[WebGL2] Skip buggy conformance tests
https://bugs.webkit.org/show_bug.cgi?id=215466
Patch by James Darpinian <James Darpinian> on 2020-08-14
Reviewed by Dean Jackson.
- webgl/TestExpectations:
- 3:14 PM Changeset in webkit [265709] by
-
- 8 edits in trunk
RTL: volume slider and icons are backwards
https://bugs.webkit.org/show_bug.cgi?id=215482
<rdar://problem/65730749>
Reviewed by Eric Carlson.
Source/WebCore:
- Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls.prototype.layout):
Flip the inline volume button when not in LTR.
- Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
(MacOSFullscreenMediaControls.prototype.layout):
(MacOSFullscreenMediaControls.prototype._volumeControlsForCurrentDirection): Added.
Reverse the order of the fullscreen volume controls when not in LTR.
- Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:
(.media-controls.mac.fullscreen:not(.uses-ltr-user-interface-layout-direction) :is(.volume-down, .volume.slider, .volume-up)): Added.
(.media-controls.mac.fullscreen:not(.uses-ltr-user-interface-layout-direction) .volume.slider): Deleted.
Also flip the fullscreen volume up and volume down buttons.
LayoutTests:
MacOSFullscreenMediaControlsdefaults to havingusesLTRUserInterfaceLayoutDirectionbe
false, so flip the order of the volume controls to match the non-LTR UI.
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-styles.html:
- 3:06 PM Changeset in webkit [265708] by
-
- 57 edits in trunk
[WebGL2] expando-loss and expando-loss-2 conformance tests are failing
https://bugs.webkit.org/show_bug.cgi?id=214765
Patch by Kenneth Russell <kbr@chromium.org> on 2020-08-14
Reviewed by Yusuke Suzuki.
Re-land with locking fixes ysuzuki@ pointed out as necessary, and
advised heavily on.
Source/WebCore:
Use JSWebGLRenderingContext's and JSWebGL2RenderingContext's
existing visitAdditionalChildren hook, via JSCustomMarkFunction in
their IDL, to add opaque roots for all WebGLObjects latched in to
the context state, and all WebGLObjects they refer to. Extensions
were already previously handled.
In order to support JSC's concurrent marking, grab a
per-WebGL-context lock in visitAdditionalChildren, and in all
WebGL context- and object-related methods which modify compound
data structures like HashMaps and Vectors that are traversed by
visitAdditionalChildren and its callees. Add "const
AbstractLocker&" throughout WebGL's call hierarchy to guarantee
that this lock is held where needed. Add needed exception in
WebGLObjects' destructors to avoid recursive locking, and in
WebGLContextGroup destruction to avoid mutating objects that GC
might be traversing when a lock is no longer available on the
application's thread.
Add "GenerateIsReachable=Impl" to the IDL files of needed WebGL
objects (WebGLBuffer, WebGLTexture, etc.) so that they pay
attention to the opaque root state when determining liveness of
their JavaScript wrappers. Add a FIXME to objectGraphLock in
WebGLRenderingContextBase to consider rewriting this in a
lock-free manner.
Covered by existing WebGL conformance tests.
- bindings/js/JSWebGL2RenderingContextCustom.cpp:
(WebCore::JSWebGL2RenderingContext::visitAdditionalChildren):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitAdditionalChildren):
- html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::deleteVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::validateAndCacheBufferBinding):
(WebCore::WebGL2RenderingContext::bindFramebuffer):
(WebCore::WebGL2RenderingContext::deleteFramebuffer):
(WebCore::WebGL2RenderingContext::deleteQuery):
(WebCore::WebGL2RenderingContext::beginQuery):
(WebCore::WebGL2RenderingContext::endQuery):
(WebCore::WebGL2RenderingContext::deleteSampler):
(WebCore::WebGL2RenderingContext::bindSampler):
(WebCore::WebGL2RenderingContext::deleteSync):
(WebCore::WebGL2RenderingContext::deleteTransformFeedback):
(WebCore::WebGL2RenderingContext::bindTransformFeedback):
(WebCore::WebGL2RenderingContext::beginTransformFeedback):
(WebCore::WebGL2RenderingContext::setIndexedBufferBinding):
(WebCore::WebGL2RenderingContext::deleteVertexArray):
(WebCore::WebGL2RenderingContext::bindVertexArray):
(WebCore::WebGL2RenderingContext::addMembersToOpaqueRoots):
(WebCore::WebGL2RenderingContext::uncacheDeletedBuffer):
- html/canvas/WebGL2RenderingContext.h:
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::~WebGLBuffer):
(WebCore::WebGLBuffer::deleteObjectImpl):
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLBuffer.idl:
- html/canvas/WebGLContextGroup.cpp:
(WebCore::WebGLContextGroup::hasAContext const):
(WebCore::WebGLContextGroup::objectGraphLockForAContext):
(WebCore::WebGLContextGroup::detachAndRemoveAllObjects):
- html/canvas/WebGLContextGroup.h:
- html/canvas/WebGLContextObject.cpp:
(WebCore::WebGLContextObject::detachContext):
(WebCore::WebGLContextObject::objectGraphLockForContext):
- html/canvas/WebGLContextObject.h:
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::~WebGLFramebuffer):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):
(WebCore::WebGLFramebuffer::addMembersToOpaqueRoots):
(WebCore::WebGLFramebuffer::setAttachmentInternal):
(WebCore::WebGLFramebuffer::removeAttachmentInternal):
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLFramebuffer.idl:
- html/canvas/WebGLObject.cpp:
(WebCore::WebGLObject::runDestructor):
(WebCore::WebGLObject::deleteObject):
- html/canvas/WebGLObject.h:
- html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::~WebGLProgram):
(WebCore::WebGLProgram::deleteObjectImpl):
(WebCore::WebGLProgram::attachShader):
(WebCore::WebGLProgram::detachShader):
(WebCore::WebGLProgram::addMembersToOpaqueRoots):
- html/canvas/WebGLProgram.h:
- html/canvas/WebGLProgram.idl:
- html/canvas/WebGLQuery.cpp:
(WebCore::WebGLQuery::~WebGLQuery):
(WebCore::WebGLQuery::deleteObjectImpl):
- html/canvas/WebGLQuery.h:
- html/canvas/WebGLQuery.idl:
- html/canvas/WebGLRenderbuffer.cpp:
(WebCore::WebGLRenderbuffer::~WebGLRenderbuffer):
(WebCore::WebGLRenderbuffer::deleteObjectImpl):
- html/canvas/WebGLRenderbuffer.h:
- html/canvas/WebGLRenderbuffer.idl:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::attachShader):
(WebCore::WebGLRenderingContextBase::validateAndCacheBufferBinding):
(WebCore::WebGLRenderingContextBase::bindBuffer):
(WebCore::WebGLRenderingContextBase::bindFramebuffer):
(WebCore::WebGLRenderingContextBase::bindRenderbuffer):
(WebCore::WebGLRenderingContextBase::bindTexture):
(WebCore::WebGLRenderingContextBase::deleteObject):
(WebCore::WebGLRenderingContextBase::uncacheDeletedBuffer):
(WebCore::WebGLRenderingContextBase::setBoundVertexArrayObject):
(WebCore::WebGLRenderingContextBase::deleteBuffer):
(WebCore::WebGLRenderingContextBase::deleteFramebuffer):
(WebCore::WebGLRenderingContextBase::deleteProgram):
(WebCore::WebGLRenderingContextBase::deleteRenderbuffer):
(WebCore::WebGLRenderingContextBase::deleteShader):
(WebCore::WebGLRenderingContextBase::deleteTexture):
(WebCore::WebGLRenderingContextBase::detachShader):
(WebCore::WebGLRenderingContextBase::useProgram):
(WebCore::WebGLRenderingContextBase::vertexAttribPointer):
(WebCore::WebGLRenderingContextBase::detachAndRemoveAllObjects):
(WebCore::WebGLRenderingContextBase::setFramebuffer):
(WebCore::WebGLRenderingContextBase::addMembersToOpaqueRoots):
(WebCore::WebGLRenderingContextBase::objectGraphLock):
- html/canvas/WebGLRenderingContextBase.h:
(WebCore::WebGLRenderingContextBase::setBoundVertexArrayObject): Deleted.
- html/canvas/WebGLSampler.cpp:
(WebCore::WebGLSampler::~WebGLSampler):
(WebCore::WebGLSampler::deleteObjectImpl):
- html/canvas/WebGLSampler.h:
- html/canvas/WebGLSampler.idl:
- html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::~WebGLShader):
(WebCore::WebGLShader::deleteObjectImpl):
- html/canvas/WebGLShader.h:
- html/canvas/WebGLShader.idl:
- html/canvas/WebGLSharedObject.cpp:
(WebCore::WebGLSharedObject::detachContextGroup):
(WebCore::WebGLSharedObject::detachContextGroupWithoutDeletingObject):
(WebCore::WebGLSharedObject::hasGroupOrContext const):
(WebCore::WebGLSharedObject::objectGraphLockForContext):
- html/canvas/WebGLSharedObject.h:
- html/canvas/WebGLSync.cpp:
(WebCore::WebGLSync::~WebGLSync):
(WebCore::WebGLSync::deleteObjectImpl):
- html/canvas/WebGLSync.h:
- html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::~WebGLTexture):
(WebCore::WebGLTexture::deleteObjectImpl):
- html/canvas/WebGLTexture.h:
- html/canvas/WebGLTexture.idl:
- html/canvas/WebGLTransformFeedback.cpp:
(WebCore::WebGLTransformFeedback::~WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::deleteObjectImpl):
(WebCore::WebGLTransformFeedback::setProgram):
(WebCore::WebGLTransformFeedback::setBoundIndexedTransformFeedbackBuffer):
(WebCore::WebGLTransformFeedback::addMembersToOpaqueRoots):
(WebCore::WebGLTransformFeedback::unbindBuffer):
- html/canvas/WebGLTransformFeedback.h:
- html/canvas/WebGLTransformFeedback.idl:
- html/canvas/WebGLVertexArrayObject.cpp:
(WebCore::WebGLVertexArrayObject::~WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::deleteObjectImpl):
- html/canvas/WebGLVertexArrayObject.h:
- html/canvas/WebGLVertexArrayObject.idl:
- html/canvas/WebGLVertexArrayObjectBase.cpp:
(WebCore::WebGLVertexArrayObjectBase::setElementArrayBuffer):
(WebCore::WebGLVertexArrayObjectBase::setVertexAttribState):
(WebCore::WebGLVertexArrayObjectBase::unbindBuffer):
(WebCore::WebGLVertexArrayObjectBase::addMembersToOpaqueRoots):
- html/canvas/WebGLVertexArrayObjectBase.h:
- html/canvas/WebGLVertexArrayObjectOES.cpp:
(WebCore::WebGLVertexArrayObjectOES::~WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):
- html/canvas/WebGLVertexArrayObjectOES.h:
- html/canvas/WebGLVertexArrayObjectOES.idl:
LayoutTests:
Rebaseline expando-loss.html and expando-loss-2.html, which are
now fully passing.
Add a hook to js-test-pre.js which allows these tests to be run
correctly in the MiniBrowser by setting the following environment
variables:
export JSC_useDollarVM=1
export XPC_JSC_useDollarVM=1
- webgl/2.0.0/conformance/misc/expando-loss-expected.txt:
- webgl/2.0.0/conformance2/misc/expando-loss-2-expected.txt:
- webgl/2.0.0/resources/webgl_test_files/js/js-test-pre.js:
- 3:00 PM Changeset in webkit [265707] by
-
- 8 edits in trunk/Source/WebInspectorUI
Web Inspector: use
WI.DropZoneViewinstead ofhandleFileDrop
https://bugs.webkit.org/show_bug.cgi?id=215493
Reviewed by Joseph Pecoraro.
WI.DropZoneViewindicates that things can be dropped, whereashandleFileDrophas no UI.
- UserInterface/Base/Main.js:
(WI.contentLoaded):
(WI._handleDrop): Deleted.
- UserInterface/Views/AuditTabContentView.js:
(WI.AuditTabContentView.prototype.dropZoneShouldAppearForDragEvent): Added.
(WI.AuditTabContentView.prototype.dropZoneHandleDrop): Added.
(WI.AuditTabContentView.prototype.initialLayout):
(WI.AuditTabContentView.prototype.async handleFileDrop): Deleted.
- UserInterface/Views/GraphicsTabContentView.js:
(WI.GraphicsTabContentView.prototype.dropZoneShouldAppearForDragEvent): Added.
(WI.GraphicsTabContentView.prototype.dropZoneHandleDrop): Added.
(WI.GraphicsTabContentView.prototype.initialLayout):
(WI.GraphicsTabContentView.prototype.async handleFileDrop): Deleted.
- UserInterface/Views/NetworkTabContentView.js:
(WI.NetworkTabContentView.prototype.initialLayout):
(WI.NetworkTabContentView.prototype.dropZoneShouldAppearForDragEvent): Added.
(WI.NetworkTabContentView.prototype.dropZoneHandleDrop): Added.
(WI.NetworkTabContentView.prototype.async handleFileDrop): Deleted.
- UserInterface/Views/TimelineTabContentView.js:
(WI.TimelineTabContentView.prototype.dropZoneShouldAppearForDragEvent): Added.
(WI.TimelineTabContentView.prototype.dropZoneHandleDrop): Added.
(WI.TimelineTabContentView.prototype.initialLayout):
(WI.TimelineTabContentView.prototype.async handleFileDrop): Deleted.
- UserInterface/Views/GraphicsOverviewContentView.js:
(WI.GraphicsOverviewContentView.prototype.initialLayout):
(WI.GraphicsOverviewContentView.prototype.dropZoneShouldAppearForDragEvent): Deleted.
(WI.GraphicsOverviewContentView.prototype.dropZoneHandleDrop): Deleted.
Remove thisWI.DropZoneViewas it's now handled byWI.GraphicsTabContentView.
- Localizations/en.lproj/localizedStrings.js:
- 2:56 PM Changeset in webkit [265706] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, clean up some test expectations after r265639
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 2:55 PM Changeset in webkit [265705] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::AXObjectCache::rangeMatchesTextNearRange.
https://bugs.webkit.org/show_bug.cgi?id=215521
<rdar://problem/64773177>
Reviewed by Chris Fleizach.
The test accessibility/ios-simulator/text-marker-range-matches-text.html
exercises this code path, but doesn't reproduce this crash.
Added a check for nullity of the VisiblePositions before creating the
SimpleRange.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rangeMatchesTextNearRange):
- 2:42 PM Changeset in webkit [265704] by
-
- 1 copy in tags/Safari-610.2.1
Tag Safari-610.2.1.
- 1:47 PM Changeset in webkit [265703] by
-
- 2 edits in trunk/Tools
Gamepad.GCFVersusHID fails on Big Sur.
<rdar://problem/66948608> and https://bugs.webkit.org/show_bug.cgi?id=215520
Reviewed by Tim Horton.
- TestWebKitAPI/Tests/mac/HIDGamepads.mm: Accept two different names for the virtual Xbox One controller
- 1:41 PM Changeset in webkit [265702] by
-
- 17 edits in trunk/Source/WebKit
Convert SharedMemory::Handle to SharedMemory::IPCHandle WebPage image/pasteboard functions
https://bugs.webkit.org/show_bug.cgi?id=215478
<rdar://problem/67024582>
Reviewed by Chris Dumez.
Convert SharedMemory::Handle objects to SharedMemory::IPCHandle
objects which automatically verify the size of data being sent.
We can remove the additional size parameter being sent in many IPC
messages along with the handle, now that both are stored in the
IPCHandle struct.
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::setPromisedDataForImage):
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::getPasteboardBufferForType):
No longer need size check, this is done in the IPCHandle::decode()
function.
(WebKit::WebPasteboardProxy::setPasteboardBufferForType):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPasteboardProxy.cpp:
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebPasteboardProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::saveImageToLibrary):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::dataSelectionForPasteboard):
No longer need size check, this is done in the IPCHandle::decode()
function.
(WebKit::WebPageProxy::setPromisedDataForImage):
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::writeItemsToPasteboard):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
No longer need size check, this is done in the IPCHandle::decode()
function.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getDataSelectionForPasteboard):
(WebKit::WebPage::performActionOnElement):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getDataSelectionForPasteboard):
- 1:27 PM Changeset in webkit [265701] by
-
- 33 edits12 adds in trunk
Add support for suspending / resuming an OfflineAudioContext
https://bugs.webkit.org/show_bug.cgi?id=215417
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/active-processing.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-suspend-resume-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-channel-count.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/suspended-context-messageport.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-disconnect-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/current-time-block-size-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:
Source/WebCore:
Add support for suspending / resuming an OfflineAudioContext, as per:
- https://www.w3.org/TR/webaudio/#dom-offlineaudiocontext-suspend
- https://www.w3.org/TR/webaudio/#dom-offlineaudiocontext-resume
Tests: webaudio/offlineaudiocontext-suspend-resume-basic.html
webaudio/offlineaudiocontext-suspend-resume-eventhandler.html
webaudio/offlineaudiocontext-suspend-resume-graph-manipulation.html
webaudio/offlineaudiocontext-suspend-resume-promise.html
webaudio/offlineaudiocontext-suspend-resume-sequence.html
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::didSuspendRendering):
- Modules/webaudio/BaseAudioContext.h:
(WebCore::BaseAudioContext::shouldSuspend):
- Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::uninitialize):
(WebCore::OfflineAudioContext::startOfflineRendering):
(WebCore::OfflineAudioContext::suspendOfflineRendering):
(WebCore::OfflineAudioContext::resumeOfflineRendering):
(WebCore::OfflineAudioContext::shouldSuspend):
(WebCore::OfflineAudioContext::didSuspendRendering):
(WebCore::OfflineAudioContext::didFinishOfflineRendering):
- Modules/webaudio/OfflineAudioContext.h:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::startRendering):
(WebCore::OfflineAudioDestinationNode::offlineRender):
- Modules/webaudio/OfflineAudioDestinationNode.h:
LayoutTests:
Import tests for this feature from Blink since the WPT coverage is not great.
- webaudio/offlineaudiocontext-suspend-resume-basic-expected.txt: Added.
- webaudio/offlineaudiocontext-suspend-resume-basic.html: Added.
- webaudio/offlineaudiocontext-suspend-resume-eventhandler-expected.txt: Added.
- webaudio/offlineaudiocontext-suspend-resume-eventhandler.html: Added.
- webaudio/offlineaudiocontext-suspend-resume-graph-manipulation-expected.txt: Added.
- webaudio/offlineaudiocontext-suspend-resume-graph-manipulation.html: Added.
- webaudio/offlineaudiocontext-suspend-resume-promise-expected.txt: Added.
- webaudio/offlineaudiocontext-suspend-resume-promise.html: Added.
- webaudio/offlineaudiocontext-suspend-resume-sequence-expected.txt: Added.
- webaudio/offlineaudiocontext-suspend-resume-sequence.html: Added.
- webaudio/resources/audit-util.js: Added.
(compareBuffersWithConstraints):
(createImpulseBuffer):
(createLinearRampBuffer):
(createConstantBuffer):
(createStereoImpulseBuffer):
(timeToSampleFrame):
(grainLengthInSampleFrames):
(isValidNumber):
- webaudio/resources/audit.js: Added.
(_logError):
(_logPassed):
(_logFailed):
(_throwException):
(_generateDescription):
(_formatFailureEntry):
(_closeToThreshold):
(Should):
(Should.prototype._processArguments):
(Should.prototype._buildResultText):
(Should.prototype._finalize):
(Should.prototype._assert):
(Should.prototype.get result):
(Should.prototype.get detail):
(Should.prototype.exist):
(Should.prototype.throw):
(Should.prototype.notThrow):
(Should.prototype.beResolved):
(Should.prototype.beRejected):
(Should.prototype.beRejectedWith):
(Should.prototype.beTrue):
(Should.prototype.beFalse):
(Should.prototype.beEqualTo):
(Should.prototype.notBeEqualTo):
(Should.prototype.beNaN):
(Should.prototype.notBeNaN):
(Should.prototype.beGreaterThan):
(Should.prototype.beGreaterThanOrEqualTo):
(Should.prototype.beLessThan):
(Should.prototype.beLessThanOrEqualTo):
(Should.prototype.beConstantValueOf):
(Should.prototype.notBeConstantValueOf):
(Should.prototype.beEqualToArray):
(Should.prototype.containValues):
(Should.prototype.notGlitch):
(Should.prototype.beCloseTo):
(Should.prototype.beCloseToArray):
(Should.prototype.message):
(Should.prototype.haveOwnProperty):
(Should.prototype.notHaveOwnProperty):
(Should.prototype.inheritFrom):
(Task):
(Task.prototype.get label):
(Task.prototype.get state):
(Task.prototype.get result):
(Task.prototype.should):
(Task.prototype.run):
(Task.prototype.update):
(Task.prototype.done):
(Task.prototype.timeout):
(Task.prototype.isPassed):
(Task.prototype.toString):
(TaskRunner):
(TaskRunner.prototype._finish):
(TaskRunner.prototype.define):
(TaskRunner.prototype.run):
(loadFileFromUrl):
(return.createTaskRunner):
(window.Audit):
- 12:48 PM Changeset in webkit [265700] by
-
- 6 edits3 adds in branches/safari-610.1-branch
Cherry-pick r265603. rdar://problem/67084483
Font loads quickly followed by navigations may fail indefinitely
https://bugs.webkit.org/show_bug.cgi?id=215435
<rdar://problem/65560550>
Reviewed by Darin Adler.
Source/WebCore:
Font loads are coalesced using a zero-delay timer. However, that zero-delay timer
can fire while the page is in the middle of a navigation, which will cause the font
loads to fail. Then, the second page can request those same fonts, which are marked
as failed, and as such will never actually load/use the desired web font.
This patch just stops the zero-delay timer during navigations, and resumes it
when resuming the document. This means:
- The second page in the above story will not see that the font has failed, or even started, and will then re-request the font and load it successfully
- If the user goes "back" to the previous page, the zero-delay timer is restarted, the CachedFont realizes it's already succeeded, and the previous page is rendered as expected.
Test: fast/loader/font-load-timer.html
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::suspendFontLoadingTimer): (WebCore::CSSFontSelector::restartFontLoadingTimer):
- css/CSSFontSelector.h:
- dom/Document.cpp: (WebCore::Document::resume):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading):
LayoutTests:
1) The page has some content that has “font-family: WebFont” but there are no @font-face blocks on the page
2) In script, after the page has loaded, add an @font-face rule to the page with “font-family: WebFont” and some valid font URL
3) Synchronously, within the same turn of the run loop, trigger a synchronous layout of the element (using offsetWidth or something). This will add the font to the 0-delay time work list.
4) Synchronously, within the same turn of the run loop, navigate to a second page that doesn’t use the web font.
5) The second page waits some small-but-positive amount of time. This will cause the 0-delay timer to fire, but because the page is in the middle of navigating, the font load should fail.
6) The second page adds the same @font-face rule to itself using script. This should pull the same (failed) CachedResource object out of the memory cache.
7) Use the CSS Font Loading API to wait for the font load to complete
8) Make sure that the font is used on the second page (as a reference test). Today, the second page’s font load will fail because it pulled the failed font out of the memory cache. The test makes sure the second page’s font load succeeds.
- fast/loader/font-load-timer-expected.html: Added.
- fast/loader/font-load-timer.html: Added.
- fast/loader/resources/font-load-timer-navigation-destination.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:48 PM Changeset in webkit [265699] by
-
- 2 edits in branches/safari-610.1-branch/Source/WebInspectorUI
Cherry-pick r265597. rdar://problem/67084522
Web Inspector: REGRESSION(r259170): text inputs in box-shadow editor push sliders offscreen
https://bugs.webkit.org/show_bug.cgi?id=215436
Reviewed by Darin Adler.
- UserInterface/Views/BoxShadowEditor.js:
(WI.BoxShadowEditor.createInputRow):
Make sure the inputs are
type="text"so that CSS is able to distinguish them from sliders.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:48 PM Changeset in webkit [265698] by
-
- 2 edits in branches/safari-610.1-branch/Source/WebCore
Cherry-pick r265581. rdar://problem/67083937
First search on Google Maps shows black bar at top of map and blank strips through the middle
https://bugs.webkit.org/show_bug.cgi?id=214945
<rdar://problem/63374422>
Reviewed by Tim Horton.
On iOS with an attached keyboard, Google Maps appears to calculate
the viewport it will use for map display at a time when the Unified
Control Bar (keyboard accessories) is visible. If it then changes the
map location via the user submitting a search form, the resulting map
will be using the incorrect viewport as the control bar has disappeared.
This causes parts of the map display to get the wrong stencil masks, leaving
blank strips. This fixes itself as soon as you force the map to recalculate
its viewport (e.g. by rotating the device).
Rather than have Google Maps update its code to detect these viewport changes,
we're adding a Quirk to not use the control bar in these calculations.
- page/Quirks.cpp: (WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const): Return true for "*.google.com/maps/".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:48 PM Changeset in webkit [265697] by
-
- 4 edits in branches/safari-610.1-branch
Cherry-pick r265573. rdar://problem/67083969
Fail preconnect requests to deprecated TLS instead of allowing application to show warning
https://bugs.webkit.org/show_bug.cgi?id=215424
<rdar://problem/66784116>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-12
Reviewed by Geoffrey Garen.
Source/WebKit:
Preconnecting is just a suggestion, so if the content really wants to load something from the deprecated TLS server,
we will see the warning when the load actually happens.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST): (TestWebKitAPI::webViewWithNavigationDelegate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:48 PM Changeset in webkit [265696] by
-
- 2 edits in branches/safari-610.1-branch/Source/WebKit
Cherry-pick r265560. rdar://problem/67084214
WebPageProxy::registerEditCommand should be robust against invalid undo step identifiers
https://bugs.webkit.org/show_bug.cgi?id=215412
<rdar://problem/66296820>
Reviewed by Tim Horton.
Add a
MESSAGE_CHECKto avoid ever creating aWebEditCommandProxywith an invalid command identifier.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::registerEditCommand):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:48 PM Changeset in webkit [265695] by
-
- 8 edits in branches/safari-610.1-branch
Cherry-pick r265510. rdar://problem/67084518
Deferred WKUserScripts are exponentially injected on preloaded pages with frames.
https://bugs.webkit.org/show_bug.cgi?id=215382
rdar://problem/66837802
Reviewed by Sam Weinig.
Source/WebCore:
When defering a script in a frame it was previously added to a vector per-page.
Later when notified to inject the defered scripts, the page would iterate over all
the frames and evaluate the scripts on each frame. Since this vector had all the
frame's scripts the evaluations would be multiplied by the number of frames.
Now the defered scripts are stored per-frame and the page asks each frame to
inject the defered scripts.
- page/Frame.cpp: (WebCore::Frame::injectUserScripts): (WebCore::Frame::addUserScriptAwaitingNotification): (WebCore::Frame::injectUserScriptsAwaitingNotification):
- page/Frame.h:
- page/Page.cpp: (WebCore::Page::notifyToInjectUserScripts): (WebCore::Page::addUserScriptAwaitingNotification): Deleted.
- page/Page.h:
- page/Quirks.cpp: (WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm: (TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:48 PM Changeset in webkit [265694] by
-
- 6 edits2 adds in branches/safari-610.1-branch
Cherry-pick r265499. rdar://problem/67084446
[AutoTableLayout] REGRESSION(r263855) Paypal email is rendered right aligned on Safari
https://bugs.webkit.org/show_bug.cgi?id=215340
<rdar://problem/66540254>
Reviewed by Simon Fraser.
Source/WebCore:
Prior to r263855, these zero-length, non-empty columns had the preferred width value of 1px and the available space got distributed based on this made-up 1px value.
In this patch, we distribute the available horizontal space evenly among these zero-length, 'width: auto' columns.
Test: fast/table/zero-length-non-empty-columns-with-auto-width.html
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::layout):
LayoutTests:
- fast/table/zero-length-non-empty-columns-with-auto-width-expected.html: Added.
- fast/table/zero-length-non-empty-columns-with-auto-width.html: Added.
- platform/mac/fast/table/empty-cells-expected.txt: progression
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:48 PM Changeset in webkit [265693] by
-
- 7 edits in branches/safari-610.1-branch
Cherry-pick r265420. rdar://problem/67083903
REGRESSION (r260831): Web process crashes under Editor::setComposition() after navigating with marked text
https://bugs.webkit.org/show_bug.cgi?id=215315
<rdar://problem/64740092>
Reviewed by Darin Adler.
Source/WebCore:
To address a variety of crashes due to frames changing (or otherwise losing) their document while executing
editing commands, r260831 refactored the Editor class such that it extends the functionality of the Document
class, rather than the Frame class. In nearly all scenarios, this either leads to no behavior change or prevents
null pointer crashes, since a document is almost always attached to a frame when applying any editing commands.
However, there is one scenario where a document that has not yet been attached to its frame (and therefore does
not have a browsing context) will cause a null deref when trying to confirm an existing IME composition. The
logic added in <https://trac.webkit.org/r150291> will try and confirm any existing composition range on a
document right before committing provisional navigation. In the case where we are navigating back to a
previously visited page,m_frame's document inFrameLoader::commitProvisionalLoad()will not be attached
until the cached page's mainframe is opened underneathCachedPage::restore(). Since the call to
Editor::confirmComposition()currently happens before this step, we end up crashing while attempting to create
aUserTypingGestureIndicator. Note that even if we avoid this with a null check, we'll still end up crashing
shortly thereafter, underneathEditor::insertTextForConfirmedComposition. And even if this second crash is
avoided with another null check, we'll just end up with some version of webkit.org/b/59121, where the
composition range is present after navigation, but is out of sync with platform UI.
To fix the crash (and also not bring back bug #59121), we refactor this composition confirmation logic so that
it lives in Editor, and is also robust against the case where the document is not attached to a frame; we then
invoke this call after we're done committing the provisional load, so that any frame that is not yet attached
before commiting the load still has a chance to confirm its composition.
Test: WKWebViewMacEditingTests.ProcessSwapAfterSettingMarkedText
- editing/Editor.cpp: (WebCore::Editor::confirmCompositionAndNotifyClient):
Move functionality from
willTransitionToCommittedtoconfirmCompositionAndNotifyClient, a helper method that
will bail if the document is not attached, but otherwise confirm the active composition (if it exists).
- editing/Editor.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad):
Add a call to confirm the editor's current composition after we're done committing the load. Note that in the
case where we had a composition before committing the load, we'll end up confirming the composition earlier (in
the first call site), rather than confirming after the load has been committed. This means that this second call
will be a no-op, due to the editor not having any composition.
(WebCore::FrameLoader::willTransitionToCommitted): Deleted.
- loader/FrameLoader.h:
Tools:
Add a new API that exercises the crash by:
- Enabling PSON.
- Navigating to page A and inserting some marked text.
- Navigating to page B with a process swap (without confirming the marked text).
- Navigating back to page A, and verifying that the previoulsy marked text is now committed.
- TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:13 PM Changeset in webkit [265692] by
-
- 2 edits in trunk/Source/JavaScriptCore
[ARMv7][JSC] Conservative GC is not considering
r7as a root
https://bugs.webkit.org/show_bug.cgi?id=215512
Reviewed by Yusuke Suzuki.
Since
r7is a callee-saved register on ARMv7
we need to consider it as a conservative root.
See the statement "A subroutine must preserve
the contents of the registers r4-r8, r10, r11
and SP (and r9 in PCS variants that designate
r9 as v6) form page 15 of
https://developer.arm.com/documentation/ihi0042/f/.
- heap/RegisterState.h:
- 11:58 AM Changeset in webkit [265691] by
-
- 3 edits in trunk/Tools
Move WebGL bot from debug to release builds
https://bugs.webkit.org/show_bug.cgi?id=215509
Rubber-stamped by Darin Adler.
Make the switch to release builds since many of the tests are already slow, and running in debug configuration makes them even slower
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
- 11:57 AM Changeset in webkit [265690] by
-
- 2 edits in trunk/Source/WebCore
The PiP button on the fullscreen youtube player disappears after starting a new video in a playlist
https://bugs.webkit.org/show_bug.cgi?id=215488
Reviewed by Eric Carlson.
When a fullscreen video player (e.g., YouTube.com) completes the current video and starts
the next one in a playlist, it may reuse the video element, so m_mediaElement of the
PlaybackSessionModelMediaElement instance won't change. However, the video element
will exit video fullscreen standby and then enter video fullscreen standby. Those
transitions are invisible to users. But the corresponding PlaybackSessionModelContext
instance will be destroyed and a new instance will be created.
By default, the member variable m_pictureInPictureSupported of the PlaybackSessionModelContext
instance is "false". After a new video starts to play, the function
PlaybackSessionModelMediaElement::setMediaElement() won't ask the PlaybackSessionManager
to send a PlaybackSessionManagerProxy::PictureInPictureSupportedChanged message
(because we don't change m_mediaElement) to notify the PlaybackSessionModelContext
instance in the UI process that m_pictureInPictureSupported should be "true". Therefore,
the PlaybackSessionModelContext instance will tell the WKFullScreenViewController instance
that picture-in-picture is not supported, which in turn will hide the picture-in-picture button.
With this patch, PlaybackSessionModelMediaElement::setMediaElement() will ask the
PlaybackSessionManager instance to send an IPC message if m_mediaElement is not nullptr
even we don't change the media element. So that the PlaybackSessionModelContext instance
in the UI process will always have a consistent state as the PlaybackSessionModelMediaElement
instance in the Web process.
- platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::setMediaElement):
- 11:56 AM Changeset in webkit [265689] by
-
- 52 edits5 adds in trunk
Introduce ConstantSourceNode Interface
https://bugs.webkit.org/show_bug.cgi?id=215377
Patch by Clark Wang <clark_wang@apple.com> on 2020-08-14
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Re-baselined existing tests. Some fail further, mainly due to lack of support for automation rate in AudioParam.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/adding-events-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-close-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/automation-rate-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/event-insertion-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audioworklet-connections.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audioworklet.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-exponentialRampToValueAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-linearRampToValueAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setTargetAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueCurveAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/set-target-conv-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-process-frozen-array.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-basic-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-onended-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-output-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/ctor-constantsource-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/test-constantsourcenode-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delaynode-channel-count-1-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/maxdelay-rounding-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-azimuth-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/silent-inputs-expected.txt:
Source/WebCore:
Introduced new ConstantSourceNode interface according to spec:
https://www.w3.org/TR/webaudio/#ConstantSourceNode and with
guidance from Chromium implementation:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/modules/webaudio/constant_source_node.cc.
Re-baselined existing tests. Some fail further, mainly due to lack of support for automation rate in AudioParam.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/AudioNode.cpp:
(WebCore::convertEnumerationToString):
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createConstantSource):
- Modules/webaudio/BaseAudioContext.h:
- Modules/webaudio/BaseAudioContext.idl:
- Modules/webaudio/ConstantSourceNode.cpp: Added.
(WebCore::ConstantSourceNode::create):
(WebCore::ConstantSourceNode::ConstantSourceNode):
(WebCore::ConstantSourceNode::~ConstantSourceNode):
(WebCore::ConstantSourceNode::process):
(WebCore::ConstantSourceNode::propagatesSilence const):
- Modules/webaudio/ConstantSourceNode.h: Added.
- Modules/webaudio/ConstantSourceNode.idl: Added.
- Modules/webaudio/ConstantSourceOptions.h: Added.
- Modules/webaudio/ConstantSourceOptions.idl: Added.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
LayoutTests:
Added flaky tests.
- 11:56 AM Changeset in webkit [265688] by
-
- 7 edits in trunk
Unreviewed, revert r265213 and r265441
https://bugs.webkit.org/show_bug.cgi?id=215089
Source/WebKit:
This logging is no longer needed, since the test seems to be passing reliably in internal automation now.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView selectAllForWebView:]):
Tools:
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::keyDown):
LayoutTests:
- editing/selection/ios/select-all-non-editable-text-using-keyboard-expected.txt:
- editing/selection/ios/select-all-non-editable-text-using-keyboard.html:
- 11:55 AM Changeset in webkit [265687] by
-
- 2 edits in trunk/Source/WebCore
Simplify FrameLoader::open
https://bugs.webkit.org/show_bug.cgi?id=215505
Patch by Rob Buis <rbuis@igalia.com> on 2020-08-14
Reviewed by Darin Adler.
There is no need to set m_isComplete to false since the started() call
a few lines below does the same thing.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
- 11:53 AM Changeset in webkit [265686] by
-
- 2 edits in trunk/Source/WebCore
Simplify HTMLFrameElementBase::openURL
https://bugs.webkit.org/show_bug.cgi?id=215504
Patch by Rob Buis <rbuis@igalia.com> on 2020-08-14
Reviewed by Darin Adler.
The expression effectively uses the indirection document -> frame -> document, but
we can just use the document directly.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::openURL):
- 11:42 AM Changeset in webkit [265685] by
-
- 8 edits1 add in trunk
OSRAvailabilityAnalysis shouldn't mark GetStack nodes directly as valid places for recovery
https://bugs.webkit.org/show_bug.cgi?id=215434
Reviewed by Saam Barati.
JSTests:
- stress/for-of-post-sinking-osr-availability.js: Added.
(foo):
Source/JavaScriptCore:
It's somewhat subtle why we cannot use the node for the GetStack
itself in the Availability's node field. The reason is that if we
did we would need to make any phase that converts nodes to
GetStack availability aware. For instance, a place where this
could come up is in constant folding if you had a graph like the
following, which could arise from PutStack sinking:
BB#1:
@1: NewObject()
@2: MovHint(@1, inline-arg1)
@3: Jump(#2, #3)
BB#2:
@4: PutStack(@1, inline-arg1)
@5: GetMyArgumentByVal(inline-arg1)
@6: Jump(#3)
BB#3:
@7: InvalidationPoint()
If constant folding converts @5 to a GetStack then at @7
inline-arg1 won't be available since at the end of BB#1 our
availability is (@1, DeadFlush) and (@5,
FlushedAt(inline-arg1)). When that gets merged at BB#3 then the
availability will be (nullptr, ConflictingFlush).
This patch also makes validation check that availability is sane
at each pontential exit site if
Options::validateFTLOSRExitLiveness() is set. Since this is
actually a Phase we also need to make sure that we don't infinite
loop, so there is now a m_isValidating field on m_graph. The
validateOSRExitAvailability phase is also careful not to modify
the Graph, in order to avoid masking bugs when validating.
In a followup patch I intend to look into why MovHint elimination
will convert:
@2: MovHint(@0, loc1, bc#1, ExitInvalid)
@3: KillStack(loc1, bc#2, ExitValid)
@4: MovHint(@1 loc1, bc#2, ExitInvalid)
into
@2: ZombieHint(@0, loc1, bc#1, ExitInvalid)
@3: KillStack(loc1, bc#2, ExitValid)
@4: MovHint(@1 loc1, bc#2, ExitInvalid)
when loc1 is live in the bytecode at bc#2. But for now, the
validation rule works around this by only checking when mayExit
and the nodes exitOK agree exiting is possible.
- dfg/DFGGraph.h:
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::OSRAvailabilityAnalysisPhase::OSRAvailabilityAnalysisPhase):
(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::performOSRAvailabilityAnalysis):
(JSC::DFG::validateOSRExitAvailability):
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):
- dfg/DFGOSRAvailabilityAnalysisPhase.h:
- dfg/DFGPhase.h:
(JSC::DFG::runPhase):
- dfg/DFGValidate.cpp:
- 11:39 AM Changeset in webkit [265684] by
-
- 8 edits in trunk
Make sure OfflineAudioContext::startOfflineRendering() does lazy initialization
https://bugs.webkit.org/show_bug.cgi?id=215481
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/active-processing.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-channel-count.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/suspended-context-messageport.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/current-time-block-size-expected.txt:
Source/WebCore:
Make sure OfflineAudioContext::startOfflineRendering() does lazy initialization before
actually starting rendering. If lazy initialization has not happened yet (because no
audio nodes were created for this context yet), then rendering would fail with an
InvalidStateError, due to lack on initialization.
No new tests, rebaselined existing tests.
- Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::startOfflineRendering):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::offlineRender):
- 11:27 AM Changeset in webkit [265683] by
-
- 15 edits in trunk
Fix bad check in AudioBufferSourceNode::renderFromBuffer()
https://bugs.webkit.org/show_bug.cgi?id=215513
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-gain-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-one-sample-loop-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-method-chaining-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-method-chaining-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/setTargetAtTime-after-event-within-block-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/setValueAtTime-within-block-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-tail-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-disconnect-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:
Source/WebCore:
Fix bad check in AudioBufferSourceNode::renderFromBuffer() that is causing us to incorrectly output silence
and failing many WPT tests.
No new tests, rebaselined existing tests.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::renderFromBuffer):
- 11:24 AM Changeset in webkit [265682] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: add aria-label for [>>] overflow tab picker
https://bugs.webkit.org/show_bug.cgi?id=215342
<rdar://problem/66804113>
Patch by Patrick Angle <Patrick Angle> on 2020-08-14
Reviewed by Devin Rousso.
- UserInterface/Views/TabBar.js: Moved title for
tabPickerTabBarItemtotitleattribute instead of the unuseddisplayNameargument
(WI.TabBar):
- 11:19 AM Changeset in webkit [265681] by
-
- 6 edits in trunk
AudioBufferSourceNode.buffer setter should throw when the buffer was already set
https://bugs.webkit.org/show_bug.cgi?id=215510
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT test now that all checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels-expected.txt:
Source/WebCore:
AudioBufferSourceNode.buffer setter should throw when the buffer was already set:
Note that the setter for the WebKit-prefixed AudioBufferSourceNode still does not throw,
to ensure backward-compatibility.
No new tests, rebaselined existing test.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setBuffer):
- Modules/webaudio/AudioBufferSourceNode.h:
(WebCore::AudioBufferSourceNode::isWebKitAudioBufferSourceNode const):
- Modules/webaudio/WebKitAudioBufferSourceNode.h:
- 10:54 AM Changeset in webkit [265680] by
-
- 3 edits in trunk/LayoutTests
[ macOS iOS ] imported/w3c/web-platform-tests/user-timing/measure_navigation_timing.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215515
Unreviewed test gardening.
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 10:49 AM Changeset in webkit [265679] by
-
- 4 edits2 moves in branches/safari-610.1-branch/Tools
Cherry-pick r265271. rdar://problem/66945210
Move poseAsClass() into the TestRunnerShared directory
https://bugs.webkit.org/show_bug.cgi?id=215147
Reviewed by Tim Horton.
Move the duplicated implementations of
poseAsClass()out of WebKitTestRunner and DumpRenderTree,
and into helper files in TestRunnerShared instead.
No change in behavior.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/DumpRenderTree.mm: (poseAsClass): Deleted. (setPersistentUserStyleSheetLocation): Deleted.
- TestRunnerShared/cocoa/PoseAsClass.h: Renamed from Tools/WebKitTestRunner/mac/PoseAsClass.h.
- TestRunnerShared/cocoa/PoseAsClass.mm: Renamed from Tools/WebKitTestRunner/mac/PoseAsClass.mm. (swizzleAllMethods): (poseAsClass):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:38 AM Changeset in webkit [265678] by
-
- 5 edits in trunk
REGRESSION (r259184): Typing -- then Return into an email moves the selection by two lines
https://bugs.webkit.org/show_bug.cgi?id=215491
<rdar://problem/66938121>
Reviewed by Darin Adler.
Source/WebCore:
When inserting a newline after text that is about to be replaced (e.g. using smart dashes, or a system-wide text
replacement), logic inEditor::markAndReplaceForattempts to detect the fact that we've just inserted a new
paragraph (settingadjustSelectionForParagraphBoundariestotrue), and subsequently causes us to advance
the selection forward by 1 character after we're done handling the text replacement.
This logic appears to have been added to deal with the fact that prior to r259184,
TextIterator::subrange()
with a range that ended in a line break would not include the line break as a part of the resulting subrange.
For instance, suppose we're inserting a newline after "--", text replacement has just run and replaced the
two hyphens with a single dash (—), and there is a newline after the dash. The extended paragraph range consists
of the dash, followed by the line break after it ("—\n"), with aselectionOffsetof 2. The following code:
auto selectionRange = extendedParagraph.subrange({ 0, selectionOffset });
...would compute a
selectionRangethat encompasses only the "—", despite a selection offset of 2, causing the
following code to only move the selection to the end of the "—":
m_document.selection().moveTo(createLegacyEditingPosition(selectionRange.end), DOWNSTREAM);
This requires the logic in the
adjustSelectionForParagraphBoundariesto subsequently move the selection to the
line break, as the user would expect. However, after the changes in r259184, the subrange now (correctly)
returns a range that starts before the "—" and ends at the following line break. However, this also means that
the subsequent adjustment logic will cause us to advance unnecessarily!
To fix this, we remove the
adjustSelectionForParagraphBoundariescase altogether, since its only (apparent)
purpose is to work around the fact thatTextIterator::subrangedidn't include trailing line breaks before
r259184.
Test: editing/spelling/text-replacement-after-typing-to-word.html
- editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
LayoutTests:
Tweaks an existing layout test so that it additionally exercises this bug. The erroneous code was already hit
during this test, but it currently does not result in any behavioral difference because after inserting the
newline, the caret is already at the end of the editable root; this means that the redundant call to advance
the selection forward by 1 character ends up being a no-op, and the test passes.
To adjust the test so that it fails, we simply start the root editable container off with two lines instead of
just one, such that the test (without this fix) will cause the selection to end up at the very end of the root
editable container instead of the first line after the "?".
To check that the selection ends up in the right place, we also use
dump-as-markup.jsto dump the caret
position after inserting the newline.
- editing/spelling/text-replacement-after-typing-to-word-expected.txt:
- editing/spelling/text-replacement-after-typing-to-word.html:
- 10:34 AM Changeset in webkit [265677] by
-
- 7 edits in trunk
@font-face font-weight descriptor should reject bolder and lighter
https://bugs.webkit.org/show_bug.cgi?id=215359
Patch by Takeshi Kurosawa <taken.spc@gmail.com> on 2020-08-14
Reviewed by Darin Adler.
Both bolder and lighter are not allowed in font-weight descriptor. This patch splits
font-weight descriptor parsers from font-weight property parsers.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-fonts/variations/at-font-face-descriptors-expected.txt:
Source/WebCore:
Tested by existing (formerly failing) test: web-platform-tests/css/css-fonts/variations/at-font-face-descriptors.html:
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeFontWeightAbsoluteKeywordValue):
(WebCore::consumeFontWeightAbsoluteRange):
(WebCore::consumeFontWeightAbsolute):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
(WebCore::consumeFontWeightRange): Deleted.
LayoutTests:
- fast/text/font-face-javascript-expected.txt:
- fast/text/font-face-javascript.html:
- 10:26 AM Changeset in webkit [265676] by
-
- 13 edits in trunk
WritableStreamDefaultWriterEnsureReadyPromiseRejected should create a new readPromise if the current readyPromise is not pending
https://bugs.webkit.org/show_bug.cgi?id=215500
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
- web-platform-tests/streams/writable-streams/aborting.any-expected.txt:
- web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt:
- web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt:
- web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt:
- web-platform-tests/streams/writable-streams/close.any-expected.txt:
- web-platform-tests/streams/writable-streams/close.any.worker-expected.txt:
- web-platform-tests/streams/writable-streams/general.any-expected.txt:
- web-platform-tests/streams/writable-streams/general.any.worker-expected.txt:
- web-platform-tests/streams/writable-streams/reentrant-strategy.any-expected.txt:
- web-platform-tests/streams/writable-streams/reentrant-strategy.any.worker-expected.txt:
Source/WebCore:
Create new promise if current is not pending.
Also mark it as handled so that it does not end up call onunhandledrejection.
Covered by rebased tests.
- Modules/streams/WritableStreamInternals.js:
(writableStreamDefaultWriterEnsureClosedPromiseRejected):
- 10:22 AM Changeset in webkit [265675] by
-
- 9 edits in trunk/Source/WebInspectorUI
REGRESSION (r265224): Web Inspector: LOCALIZED STRING NOT FOUND next to the Image checkbox in the Sources prefs panel
https://bugs.webkit.org/show_bug.cgi?id=215387
<rdar://problem/66855263>
Patch by Patrick Angle <Patrick Angle> on 2020-08-14
Reviewed by Devin Rousso.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/LoadLocalizedStrings.js:
(WI.repeatedUIString.showTransparencyGridTooltip):
- UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView):
- UserInterface/Views/GraphicsOverviewContentView.js:
(WI.GraphicsOverviewContentView):
- UserInterface/Views/ImageResourceContentView.js:
- UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
- UserInterface/Views/ResourceCollectionContentView.js:
(WI.ResourceCollectionContentView):
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createSourcesSettingsView):
- 9:47 AM Changeset in webkit [265674] by
-
- 1 edit1 delete in trunk/LayoutTests
rdar://66995964 (REGRESSION (r265358): [ Win10 wk1 ] animations/steps-transform-rendering-updates.html is a constant failure (215454))
Rebaseline Test - Remore html file.
Unreviewed test gardening.
- platform/wincairo/animations/steps-transform-rendering-updates.html: Removed.
- 9:39 AM Changeset in webkit [265673] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events-onerror.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215506
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 9:33 AM Changeset in webkit [265672] by
-
- 5 edits in trunk/LayoutTests
[WPE] Gardening
Unreviewed test gardening.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- platform/wpe/fast/text/basic/013-expected.txt: Rebaselined.
- 8:33 AM Changeset in webkit [265671] by
-
- 1 edit2 adds in trunk/LayoutTests
rdar://66995964 (REGRESSION (r265358): [ Win10 wk1 ] animations/steps-transform-rendering-updates.html is a constant failure (215454))
Rebaseline Test - Remore test expectation.
Unreviewed test gardening.
- platform/wincairo/animations/steps-transform-rendering-updates-expected.txt: Added.
- platform/wincairo/animations/steps-transform-rendering-updates.html: Added.
- 8:27 AM Changeset in webkit [265670] by
-
- 2 edits in trunk/LayoutTests
rdar://66995964 (REGRESSION (r265358): [ Win10 wk1 ] animations/steps-transform-rendering-updates.html is a constant failure (215454))
Rebaseline Test - Remore test expectation.
Unreviewed test gardening.
- platform/wincairo/TestExpectations:
- 3:59 AM Changeset in webkit [265669] by
-
- 1 copy in releases/WebKitGTK/webkit-2.29.91
WebKitGTK 2.29.91
- 3:58 AM Changeset in webkit [265668] by
-
- 4 edits in releases/WebKitGTK/webkit-2.30
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.91 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.29.91.
- 3:58 AM Changeset in webkit [265667] by
-
- 5 edits2 deletes in releases/WebKitGTK/webkit-2.30/Source/WebCore
Revert r265658 - Merge r265630 - REGRESSION(r254506): [Freetype] Spektra variable font does not work properly
https://bugs.webkit.org/show_bug.cgi?id=215214
<rdar://problem/66984524>
Reviewed by Adrian Perez de Castro.
This regressed in r254506, when a font smoothing mode is passed to drawGlyphsToContext() a new cairo font
options is set, using the default font options and changing the antialiasing. This means the font options from
the font (the ones containing the variation settings) set in the context by cairo_set_scaled_font() are
lost. We should copy the scaled font options instead, then set the antialiasing and apply them.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawGlyphsToContext): Use cairo_scaled_font_get_font_options() instead of getDefaultCairoFontOptions().
- 3:08 AM Changeset in webkit [265666] by
-
- 3 edits in trunk/Tools
[Flatpak SK] Enable GNOME keyring support in subversion
https://bugs.webkit.org/show_bug.cgi?id=215498
Patch by Philippe Normand <pnormand@igalia.com> on 2020-08-14
Reviewed by Sergio Villar Senin.
- buildstream/elements/sdk/subversion.bst: Enable GNOME Keyring support, which pulls into libsecret.
- flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox): Allow session dbus access to the host secret service.
- 1:24 AM Changeset in webkit [265665] by
-
- 12 edits2 adds in trunk
[WebXR] Implement WebXRSession::updateRenderState()
https://bugs.webkit.org/show_bug.cgi?id=213555
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
New expectations.
- web-platform-tests/webxr/render_state_update.https-expected.txt: Added.
- web-platform-tests/webxr/render_state_vertical_fov_immersive.https-expected.txt: Added.
Source/WebCore:
Added an implementation which matches the current specs. The updateRenderState() is specially useful to set
the base layer in the session where WebXR contents would be rendered. Authors would normally do:
glCanvas.getContext("webgl").makeXRCompatible().then(() => {
xrSession.updateRenderState({ baseLayer: new XRWebGLLayer(xrSession, gl) });
});
The XRRenderStateInit has also been updated to the latest version of specs.
- Modules/webxr/WebXRRenderState.cpp:
(WebCore::WebXRRenderState::WebXRRenderState):
(WebCore::WebXRRenderState::depthNear const): Inlined.
(WebCore::WebXRRenderState::depthFar const): Ditto.
(WebCore::WebXRRenderState::inlineVerticalFieldOfView const): Ditto.
(WebCore::WebXRRenderState::baseLayer const): Ditto.
- Modules/webxr/WebXRRenderState.h:
(WebCore::WebXRRenderState::depthNear const): Inlined.
(WebCore::WebXRRenderState::setDepthNear): Ditto.
(WebCore::WebXRRenderState::depthFar const): Ditto.
(WebCore::WebXRRenderState::setDepthFar): Ditto.
(WebCore::WebXRRenderState::inlineVerticalFieldOfView const): Added.
(WebCore::WebXRRenderState::setInlineVerticalFieldOfView): Ditto.
(WebCore::WebXRRenderState::baseLayer const): Ditto.
(WebCore::WebXRRenderState::setBaseLayer): Ditto.
- Modules/webxr/WebXRSession.cpp:
(WebCore::isImmersive):
(WebCore::WebXRSession::updateRenderState): Implemented.
(WebCore::WebXRSession::referenceSpaceIsSupported const):
- Modules/webxr/WebXRSession.h: updateRenderState may throw exception.
- Modules/webxr/WebXRSession.idl: Ditto.
- Modules/webxr/WebXRWebGLLayer.h:
(WebCore::WebXRWebGLLayer::session): Added.
- Modules/webxr/XRRenderStateInit.h: Added layers and made many attributes optional.
- Modules/webxr/XRRenderStateInit.idl: Ditto.
LayoutTests:
- platform/wpe/TestExpectations: Added a couple of tests that pass now.
- 1:17 AM Changeset in webkit [265664] by
-
- 1 copy in releases/WebKitGTK/webkit-2.29.90
WebKitGTK 2.29.90
- 1:15 AM Changeset in webkit [265663] by
-
- 4 edits in releases/WebKitGTK/webkit-2.30
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.90 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.29.90.
