Timeline



Aug 22, 2020:

11:06 PM Changeset in webkit [266043] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, assertion was opposite
https://bugs.webkit.org/show_bug.cgi?id=215058

We should ensure that this is *not* zero.

  • runtime/IntlObject.cpp:

(JSC::parseVariantCode):

7:27 PM Changeset in webkit [266042] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[WPE] Rebaseline test after r265851

Updated the Render element name.

Unreviewed test gardening.

  • platform/wpe/fast/layers/video-layer-expected.txt:
6:51 PM Changeset in webkit [266041] by mmaxfield@apple.com
  • 3 edits in trunk/LayoutTests

Make fast/text/letter-spacing-shaping.html more robust
https://bugs.webkit.org/show_bug.cgi?id=215711

Unreviewed test gardening.

  • fast/text/letter-spacing-shaping-expected.html:
  • fast/text/letter-spacing-shaping.html:
6:15 PM Changeset in webkit [266040] by Alan Bujtas
  • 6 edits
    1 move in trunk/Source/WebCore

[LFC][IFC] adjustBaselineAndLineHeight should take the parent inline box.
https://bugs.webkit.org/show_bug.cgi?id=214406

Reviewed by Antti Koivisto.

This is in prepartion for supporting nested lineboxes required by certain vertical alignment values.

<div>text content</div> <- This content requires only one inline box, the root linebox.
<div>nested <span><span style="vertical-align: text-top">text</span> </span>content</div> <- the content [text] is vertically
aligned with the top of the _parent element_'s font and not the root inline box.

  1. Let's rename the LineBoxBuilder to InlineBox. We'll have a bunch of these.
  2. Pass in the parent inline to adjustBaselineAndLineHeight (currently there's only one inline box per line, the root inline box).
  • WebCore.xcodeproj/project.pbxproj:
  • layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineHeightConstraints const):

  • layout/inlineformatting/InlineLineBox.h: Renamed from Source/WebCore/layout/inlineformatting/InlineLineBoxBuilder.h.

(WebCore::Layout::LineBox::Baseline::height const):
(WebCore::Layout::LineBox::logicalRect const):
(WebCore::Layout::LineBox::scrollableOverflow const):
(WebCore::Layout::LineBox::logicalLeft const):
(WebCore::Layout::LineBox::logicalRight const):
(WebCore::Layout::LineBox::logicalTop const):
(WebCore::Layout::LineBox::logicalBottom const):
(WebCore::Layout::LineBox::logicalWidth const):
(WebCore::Layout::LineBox::logicalHeight const):
(WebCore::Layout::LineBox::resetDescent):
(WebCore::Layout::LineBox::setLogicalHeight):
(WebCore::Layout::LineBox::setLogicalWidth):
(WebCore::Layout::LineBox::setScrollableOverflow):
(WebCore::Layout::LineBox::moveHorizontally):
(WebCore::Layout::LineBox::expandHorizontally):
(WebCore::Layout::LineBox::shrinkHorizontally):
(WebCore::Layout::LineBox::expandVertically):
(WebCore::Layout::LineBox::shrinkVertically):
(WebCore::Layout::LineBox::isConsideredEmpty const):
(WebCore::Layout::LineBox::setIsConsideredEmpty):
(WebCore::Layout::LineBox::setIsConsideredNonEmpty):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::setLogicalHeightIfGreater):
(WebCore::Layout::LineBox::baseline const):
(WebCore::Layout::LineBox::setBaselineOffsetIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::setDescentIfGreater):
(WebCore::Layout::LineBox::baselineOffset const):
(WebCore::Layout::LineBox::resetBaseline):
(WebCore::Layout::LineBox::Baseline::Baseline):
(WebCore::Layout::LineBox::Baseline::setAscent):
(WebCore::Layout::LineBox::Baseline::setDescent):
(WebCore::Layout::LineBox::Baseline::reset):
(WebCore::Layout::LineBox::Baseline::ascent const):
(WebCore::Layout::LineBox::Baseline::descent const):

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):
(WebCore::Layout::LineBuilder::halfLeadingMetrics):

  • layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::lineBox const):

  • layout/inlineformatting/LineLayoutContext.h:
5:26 PM Changeset in webkit [266039] by ysuzuki@apple.com
  • 15 edits
    1 add in trunk

[JSC] Implement Intl Language Tag Parser
https://bugs.webkit.org/show_bug.cgi?id=215058

Reviewed by Ross Kirsling and Darin Adler.

JSTests:

  • stress/intl-collator.js:
  • stress/intl-datetimeformat.js:
  • stress/intl-language-tag.js: Added.

(shouldThrow):
(shouldNotThrow):

  • stress/intl-locale.js:
  • stress/intl-numberformat.js:
  • stress/intl-object.js:
  • stress/intl-pluralrules.js:
  • stress/intl-relativetimeformat.js:
  • stress/string-toLocaleLowerCase.js:
  • stress/string-toLocaleUpperCase.js:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch adds LanguageTagParser which performs isStructurallyValidLanguageTag[1] validation precisely.
The spec strictly defines acceptable format as language-tag and this is not the same to ICU's one and this
is even tested in test262. We should have LanguageTagParser to validate the input.

[1]: https://tc39.es/ecma402/#sec-isstructurallyvalidlanguagetag

  • runtime/IntlLocale.cpp:

(JSC::LocaleIDBuilder::initialize):
(JSC::IntlLocale::initializeLocale):

  • runtime/IntlObject.cpp:

(JSC::canonicalizeLocaleList):
(JSC::parseVariantCode):
(JSC::convertToUnicodeSingletonIndex):
(JSC::isUnicodeExtensionAttribute):
(JSC::isUnicodeExtensionKey):
(JSC::isUnicodeExtensionTypeComponent):
(JSC::isUnicodePUExtensionValue):
(JSC::isUnicodeOtherExtensionValue):
(JSC::isUnicodeTKey):
(JSC::isUnicodeTValueComponent):
(JSC::LanguageTagParser::LanguageTagParser):
(JSC::LanguageTagParser::isEOS):
(JSC::LanguageTagParser::next):
(JSC::LanguageTagParser::parseUnicodeLocaleId):
(JSC::LanguageTagParser::parseUnicodeLanguageId):
(JSC::LanguageTagParser::parseUnicodeExtensionAfterPrefix):
(JSC::LanguageTagParser::parseTransformedExtensionAfterPrefix):
(JSC::LanguageTagParser::parseOtherExtensionAfterPrefix):
(JSC::LanguageTagParser::parsePUExtensionAfterPrefix):
(JSC::LanguageTagParser::parseExtensionsAndPUExtensions):
(JSC::isStructurallyValidLanguageTag):
(JSC::isUnicodeLanguageId):

  • runtime/IntlObject.h:
3:45 PM Changeset in webkit [266038] by emilio
  • 4 edits
    96 adds in trunk/LayoutTests

Import css-content tests.
https://bugs.webkit.org/show_bug.cgi?id=215751

Reviewed by Antti Koivisto.

  • resources/import-expectations.json:
  • web-platform-tests/css/css-content/META.yml: Added.
  • web-platform-tests/css/css-content/attr-case-insensitive-expected.html: Added.
  • web-platform-tests/css/css-content/attr-case-insensitive.html: Added.
  • web-platform-tests/css/css-content/computed-value-expected.txt: Added.
  • web-platform-tests/css/css-content/computed-value.html: Added.
  • web-platform-tests/css/css-content/element-replacement-alt-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-alt.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-contents-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-contents.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-none-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-none.html: Added.
  • web-platform-tests/css/css-content/element-replacement-dynamic-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-dynamic.html: Added.
  • web-platform-tests/css/css-content/element-replacement-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-image-alt-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-image-alt.html: Added.
  • web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative.html: Added.
  • web-platform-tests/css/css-content/element-replacement.html: Added.
  • web-platform-tests/css/css-content/inheritance-expected.txt: Added.
  • web-platform-tests/css/css-content/inheritance.html: Added.
  • web-platform-tests/css/css-content/pseudo-element-inline-box-expected.html: Added.
  • web-platform-tests/css/css-content/pseudo-element-inline-box.html: Added.
  • web-platform-tests/css/css-content/quotes-001-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-001.html: Added.
  • web-platform-tests/css/css-content/quotes-002-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-002.html: Added.
  • web-platform-tests/css/css-content/quotes-003-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-003.html: Added.
  • web-platform-tests/css/css-content/quotes-004-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-004.html: Added.
  • web-platform-tests/css/css-content/quotes-005-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-005.html: Added.
  • web-platform-tests/css/css-content/quotes-006-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-006.html: Added.
  • web-platform-tests/css/css-content/quotes-007-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-007.html: Added.
  • web-platform-tests/css/css-content/quotes-008-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-008.html: Added.
  • web-platform-tests/css/css-content/quotes-009-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-009.html: Added.
  • web-platform-tests/css/css-content/quotes-010-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-010.html: Added.
  • web-platform-tests/css/css-content/quotes-011-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-011.html: Added.
  • web-platform-tests/css/css-content/quotes-012-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-012.html: Added.
  • web-platform-tests/css/css-content/quotes-013-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-013.html: Added.
  • web-platform-tests/css/css-content/quotes-014-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-014.html: Added.
  • web-platform-tests/css/css-content/quotes-015-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-015.html: Added.
  • web-platform-tests/css/css-content/quotes-016-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-016.html: Added.
  • web-platform-tests/css/css-content/quotes-017-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-017.html: Added.
  • web-platform-tests/css/css-content/quotes-018-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-018.html: Added.
  • web-platform-tests/css/css-content/quotes-019-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-019.html: Added.
  • web-platform-tests/css/css-content/quotes-020-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-020.html: Added.
  • web-platform-tests/css/css-content/quotes-021-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-021.html: Added.
  • web-platform-tests/css/css-content/quotes-022-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-022.html: Added.
  • web-platform-tests/css/css-content/quotes-023-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-023.html: Added.
  • web-platform-tests/css/css-content/quotes-024-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-024.html: Added.
  • web-platform-tests/css/css-content/quotes-025-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-025.html: Added.
  • web-platform-tests/css/css-content/quotes-026-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-026.html: Added.
  • web-platform-tests/css/css-content/quotes-027-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-027.html: Added.
  • web-platform-tests/css/css-content/quotes-028-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-028.html: Added.
  • web-platform-tests/css/css-content/quotes-029-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-029.html: Added.
  • web-platform-tests/css/css-content/quotes-030-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-030.html: Added.
  • web-platform-tests/css/css-content/quotes-031-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-031.html: Added.
  • web-platform-tests/css/css-content/quotes-032-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-032.html: Added.
  • web-platform-tests/css/css-content/quotes-033-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-033.html: Added.
  • web-platform-tests/css/css-content/quotes-034-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-034.html: Added.
  • web-platform-tests/css/css-content/resources/rect.svg: Added.
  • web-platform-tests/css/css-content/resources/w3c-import.log: Added.
  • web-platform-tests/css/css-content/w3c-import.log: Added.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/css/css-content/META.yml: Added.
  • web-platform-tests/css/css-content/attr-case-insensitive-expected.html: Added.
  • web-platform-tests/css/css-content/attr-case-insensitive.html: Added.
  • web-platform-tests/css/css-content/computed-value-expected.txt: Added.
  • web-platform-tests/css/css-content/computed-value.html: Added.
  • web-platform-tests/css/css-content/element-replacement-alt-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-alt.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-contents-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-contents.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-none-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-none.html: Added.
  • web-platform-tests/css/css-content/element-replacement-dynamic-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-dynamic.html: Added.
  • web-platform-tests/css/css-content/element-replacement-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-image-alt-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-image-alt.html: Added.
  • web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative.html: Added.
  • web-platform-tests/css/css-content/element-replacement.html: Added.
  • web-platform-tests/css/css-content/inheritance-expected.txt: Added.
  • web-platform-tests/css/css-content/inheritance.html: Added.
  • web-platform-tests/css/css-content/pseudo-element-inline-box-expected.html: Added.
  • web-platform-tests/css/css-content/pseudo-element-inline-box.html: Added.
  • web-platform-tests/css/css-content/quotes-001-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-001.html: Added.
  • web-platform-tests/css/css-content/quotes-002-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-002.html: Added.
  • web-platform-tests/css/css-content/quotes-003-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-003.html: Added.
  • web-platform-tests/css/css-content/quotes-004-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-004.html: Added.
  • web-platform-tests/css/css-content/quotes-005-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-005.html: Added.
  • web-platform-tests/css/css-content/quotes-006-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-006.html: Added.
  • web-platform-tests/css/css-content/quotes-007-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-007.html: Added.
  • web-platform-tests/css/css-content/quotes-008-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-008.html: Added.
  • web-platform-tests/css/css-content/quotes-009-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-009.html: Added.
  • web-platform-tests/css/css-content/quotes-010-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-010.html: Added.
  • web-platform-tests/css/css-content/quotes-011-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-011.html: Added.
  • web-platform-tests/css/css-content/quotes-012-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-012.html: Added.
  • web-platform-tests/css/css-content/quotes-013-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-013.html: Added.
  • web-platform-tests/css/css-content/quotes-014-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-014.html: Added.
  • web-platform-tests/css/css-content/quotes-015-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-015.html: Added.
  • web-platform-tests/css/css-content/quotes-016-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-016.html: Added.
  • web-platform-tests/css/css-content/quotes-017-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-017.html: Added.
  • web-platform-tests/css/css-content/quotes-018-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-018.html: Added.
  • web-platform-tests/css/css-content/quotes-019-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-019.html: Added.
  • web-platform-tests/css/css-content/quotes-020-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-020.html: Added.
  • web-platform-tests/css/css-content/quotes-021-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-021.html: Added.
  • web-platform-tests/css/css-content/quotes-022-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-022.html: Added.
  • web-platform-tests/css/css-content/quotes-023-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-023.html: Added.
  • web-platform-tests/css/css-content/quotes-024-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-024.html: Added.
  • web-platform-tests/css/css-content/quotes-025-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-025.html: Added.
  • web-platform-tests/css/css-content/quotes-026-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-026.html: Added.
  • web-platform-tests/css/css-content/quotes-027-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-027.html: Added.
  • web-platform-tests/css/css-content/quotes-028-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-028.html: Added.
  • web-platform-tests/css/css-content/quotes-029-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-029.html: Added.
  • web-platform-tests/css/css-content/quotes-030-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-030.html: Added.
  • web-platform-tests/css/css-content/quotes-031-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-031.html: Added.
  • web-platform-tests/css/css-content/quotes-032-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-032.html: Added.
  • web-platform-tests/css/css-content/quotes-033-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-033.html: Added.
  • web-platform-tests/css/css-content/quotes-034-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-034.html: Added.
  • web-platform-tests/css/css-content/resources/rect.svg: Added.
  • web-platform-tests/css/css-content/resources/w3c-import.log: Added.
  • web-platform-tests/css/css-content/w3c-import.log: Added.

LayoutTests:

3:34 PM Changeset in webkit [266037] by ysuzuki@apple.com
  • 5 edits in trunk

Unreviewed, workaround for old ICU headers in macOS Catalina bots
https://bugs.webkit.org/show_bug.cgi?id=209774

EWS and Catalina bots are inconsistent in terms of ICU header versions.
This patch adds a workaround which checks ICU header version too at runtime.

JSTests:

  • stress/intl-numberformat-unified-ja.js:

(vm.icuVersion.64.vm.icuHeaderVersion):
(vm.icuVersion): Deleted.

  • stress/intl-numberformat-unified.js:

(vm.icuVersion.64.vm.icuHeaderVersion):
(vm.icuVersion): Deleted.

Source/JavaScriptCore:

  • tools/JSDollarVM.cpp:

(JSC::functionICUHeaderVersion):
(JSC::JSDollarVM::finishCreation):

3:25 PM Changeset in webkit [266036] by Alexey Shvayka
  • 4 edits in trunk

The ThrowTypeError? function object must not be extensible
https://bugs.webkit.org/show_bug.cgi?id=108873

Reviewed by Yusuke Suzuki.

JSTests:

  • test262/expectations.yaml: Mark 8 test cases as passing.

Source/JavaScriptCore:

This patch:

  1. Sets the value of %ThrowTypeError% "name" property to the empty string, as required [1] for anonymous built-in functions.
  1. Calls JSObject::freeze() on %ThrowTypeError%, making it non-extensible and its "name" and "length" properties non-configurable to match the spec [2].

Both changes align JSC with V8 and SpiderMonkey.

[1]: https://tc39.es/ecma262/#sec-ecmascript-standard-built-in-objects
[2]: https://tc39.es/ecma262/#sec-%throwtypeerror%

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

1:41 PM Changeset in webkit [266035] by ysuzuki@apple.com
  • 8 edits
    3 adds in trunk

[ECMA-402] Intl.DateTimeFormat dateStyle/timeStyle missing in WebKit
https://bugs.webkit.org/show_bug.cgi?id=209776

Reviewed by Darin Adler and Ross Kirsling.

JSTests:

  • stress/intl-date-time-format-date-time-style-basic.js: Added.

(shouldBe):
(shouldBe.o.format):

  • stress/intl-date-time-format-date-time-style-hour-cycle.js: Added.

(shouldBe):
(shouldBe.o.format):

  • stress/intl-date-time-style-option-consistency.js: Added.

(shouldThrow):
(value.of.Object.entries):

  • test262/config.yaml:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements Intl.DateTimeFormat dateStyle and timeStyle options. When it is specified,
we query the best date-time format with these options to ICU instead of configuring each date-time
formats.

Since ECMA402 requires enforcement of hourCycle specified from the option, even if ICU ignores that.
So, after getting the appropriate pattern from ICU, we modify this pattern and re-create UDateFormat
from the modified pattern.

  • builtins/DatePrototype.js:

(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleDateString.toDateTimeOptionsDateDate):
(toLocaleDateString):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):

  • runtime/CommonIdentifiers.h:
  • runtime/IntlDateTimeFormat.cpp:

(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::formatStyleString):
(JSC::IntlDateTimeFormat::resolvedOptions const):

  • runtime/IntlDateTimeFormat.h:
1:30 PM Changeset in webkit [266034] by ysuzuki@apple.com
  • 2 edits in trunk/JSTests

Unreviewed, Catalina test262 bot is using older SDK than actual Catalina's one

We should update the bot. For now, skipping these tests.

  • test262/config.yaml:
1:16 PM Changeset in webkit [266033] by ysuzuki@apple.com
  • 7 edits
    3 adds in trunk

[ECMA-402] Implement Intl.DateTimeFormat.prototype.formatRange
https://bugs.webkit.org/show_bug.cgi?id=209778

Reviewed by Ross Kirsling.

JSTests:

test262 failures are due to either of

  1. formatRangeToParts is missing
  2. ICU version difference
  • stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js: Added.

(shouldBe):
(shouldThrow):
(vm.icuVersion):

  • stress/intl-datetimeformat-formatrange-relevant-extensions.js: Added.

(shouldBe):
(shouldThrow):

  • stress/intl-datetimeformat-formatrange.js: Added.

(shouldBe):
(shouldThrow):
(test):

  • test262/config.yaml:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch adds Intl.DateTimeFormat#formatRange. It takes two dates, and
generates formatted text which represents interval between these two dates.
We skip the implementation of Intl.DateTimeFormat#formatRangeToParts since
ICU udtitvfmt_formatToResult API is not getting stable state yet. We retrieve
pattern from UDateFormat, get skeleton from that pattern, and construct
UDateIntervalFormat from this skeleton.

  • runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::createDateIntervalFormatIfNecessary):
(JSC::IntlDateTimeFormat::formatRange):
(JSC::IntlDateTimeFormat::UDateFormatDeleter::operator() const): Deleted.

  • runtime/IntlDateTimeFormat.h:
  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeFuncFormatRange):

12:22 PM Changeset in webkit [266032] by ysuzuki@apple.com
  • 21 edits
    15 adds in trunk

[JSC] Add Intl.Segmenter
https://bugs.webkit.org/show_bug.cgi?id=213638

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-segmenter.js: Added.

(shouldBe):
(shouldNotThrow):
(func):

  • test262/config.yaml:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements Intl.Segmenter[1]. Intl.Segmenter offers access to ICU break iterator feature, which can break strings into grapheme cluster / words / sentences.

[1]: https://github.com/tc39/proposal-intl-segmenter

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • runtime/CommonIdentifiers.h:
  • runtime/IntlObject.cpp:

(JSC::createSegmenterConstructor):
(JSC::IntlObject::finishCreation):
(JSC::intlSegmenterAvailableLocales):

  • runtime/IntlObject.h:
  • runtime/IntlSegmentIterator.cpp: Added.

(JSC::IntlSegmentIterator::create):
(JSC::IntlSegmentIterator::createStructure):
(JSC::IntlSegmentIterator::IntlSegmentIterator):
(JSC::IntlSegmentIterator::finishCreation):
(JSC::IntlSegmentIterator::visitChildren):
(JSC::IntlSegmentIterator::next):

  • runtime/IntlSegmentIterator.h: Added.
  • runtime/IntlSegmentIteratorPrototype.cpp: Added.

(JSC::IntlSegmentIteratorPrototype::create):
(JSC::IntlSegmentIteratorPrototype::createStructure):
(JSC::IntlSegmentIteratorPrototype::IntlSegmentIteratorPrototype):
(JSC::IntlSegmentIteratorPrototype::finishCreation):
(JSC::IntlSegmentIteratorPrototypeFuncNext):

  • runtime/IntlSegmentIteratorPrototype.h: Added.
  • runtime/IntlSegmenter.cpp: Added.

(JSC::IntlSegmenter::create):
(JSC::IntlSegmenter::createStructure):
(JSC::IntlSegmenter::IntlSegmenter):
(JSC::IntlSegmenter::finishCreation):
(JSC::IntlSegmenter::initializeSegmenter):
(JSC::IntlSegmenter::segment const):
(JSC::IntlSegmenter::resolvedOptions const):
(JSC::IntlSegmenter::granularityString):
(JSC::IntlSegmenter::createSegmentDataObject):

  • runtime/IntlSegmenter.h: Added.
  • runtime/IntlSegmenterConstructor.cpp: Added.

(JSC::IntlSegmenterConstructor::create):
(JSC::IntlSegmenterConstructor::createStructure):
(JSC::IntlSegmenterConstructor::IntlSegmenterConstructor):
(JSC::IntlSegmenterConstructor::finishCreation):
(JSC::constructIntlSegmenter):
(JSC::callIntlSegmenter):
(JSC::IntlSegmenterConstructorSupportedLocalesOf):

  • runtime/IntlSegmenterConstructor.h: Added.
  • runtime/IntlSegmenterPrototype.cpp: Added.

(JSC::IntlSegmenterPrototype::create):
(JSC::IntlSegmenterPrototype::createStructure):
(JSC::IntlSegmenterPrototype::IntlSegmenterPrototype):
(JSC::IntlSegmenterPrototype::finishCreation):
(JSC::IntlSegmenterPrototypeFuncSegment):
(JSC::IntlSegmenterPrototypeFuncResolvedOptions):

  • runtime/IntlSegmenterPrototype.h: Added.
  • runtime/IntlSegments.cpp: Added.

(JSC::IntlSegments::create):
(JSC::IntlSegments::createStructure):
(JSC::IntlSegments::IntlSegments):
(JSC::IntlSegments::finishCreation):
(JSC::IntlSegments::containing):
(JSC::IntlSegments::createSegmentIterator):
(JSC::IntlSegments::visitChildren):

  • runtime/IntlSegments.h: Added.
  • runtime/IntlSegmentsPrototype.cpp: Added.

(JSC::IntlSegmentsPrototype::create):
(JSC::IntlSegmentsPrototype::createStructure):
(JSC::IntlSegmentsPrototype::IntlSegmentsPrototype):
(JSC::IntlSegmentsPrototype::finishCreation):
(JSC::IntlSegmentsPrototypeFuncContaining):
(JSC::IntlSegmentsPrototypeFuncIterator):

  • runtime/IntlSegmentsPrototype.h: Added.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::segmentIteratorStructure):
(JSC::JSGlobalObject::segmenterStructure):
(JSC::JSGlobalObject::segmentsStructure):

  • runtime/OptionsList.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WTF:

  • wtf/text/WTFString.cpp:

(WTF::String::charactersWithoutNullTermination const):
(WTF::String::charactersWithNullTermination const):

  • wtf/text/WTFString.h:
11:32 AM Changeset in webkit [266031] by ysuzuki@apple.com
  • 17 edits
    3 adds in trunk

[ECMA-402] Implement unified Intl.NumberFormat
https://bugs.webkit.org/show_bug.cgi?id=209774

Reviewed by Ross Kirsling and Darin Adler.

JSTests:

All test262 failures are due to old ICU version. Once ICU is updated, they will go away.

  • stress/intl-numberformat-unified-ja.js: Added.

(shouldBe):
(vm.icuVersion):

  • stress/intl-numberformat-unified.js: Added.

(shouldBe):
(vm.icuVersion):

  • stress/intl-numberformat.js:

(testNumberFormat):
(shouldBe.testNumberFormat.Intl.NumberFormat):

  • test262/config.yaml:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements updated Intl.NumberFormat. This update was proposed in [1], and integrated into ECMA-402 spec.
This patch adds support for missing features in the previous Intl.NumberFormat implementation. Adding "unit", "unitDisplay",
"signDisplay", "notation", and "currencySign". Then Intl.NumberFormat can now handle "unit" etc.

To support new features, we need to use UNumberFormatter which is available after ICU 64 (while it is offered in ICU 62, some
critical part are added in 64 too). So, we keep the old UNumberFormat based implementation which is used for [60, 64) since WebKit
currently supports ICU 60. Old implementation does not support new things. If ICU is 64 or later, Intl.NumberFormat starts using
UNumberFormatter, and implements all the specified features.

[1]: https://github.com/tc39/proposal-unified-intl-numberformat

(JSC::IntlCollator::UCollatorDeleter::operator() const): Deleted.

  • runtime/IntlCollator.h:
  • runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::UDateFormatDeleter::operator() const): Deleted.

  • runtime/IntlDateTimeFormat.h:
  • runtime/IntlNumberFormat.cpp:

(JSC::computeCurrencyDigits):
(JSC::sanctionedSimpleUnitIdentifier):
(JSC::WellFormedUnit::WellFormedUnit):
(JSC::wellFormedUnitIdentifier):
(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::format const):
(JSC::IntlNumberFormat::styleString):
(JSC::IntlNumberFormat::currencyDisplayString):
(JSC::IntlNumberFormat::notationString):
(JSC::IntlNumberFormat::currencySignString):
(JSC::IntlNumberFormat::unitDisplayString):
(JSC::IntlNumberFormat::compactDisplayString):
(JSC::IntlNumberFormat::signDisplayString):
(JSC::IntlNumberFormat::resolvedOptions const):
(JSC::partTypeString):
(JSC::IntlNumberFormat::formatToPartsInternal):
(JSC::IntlNumberFormat::formatToParts const):
(JSC::IntlNumberFormat::UNumberFormatDeleter::operator() const): Deleted.

  • runtime/IntlNumberFormat.h:
  • runtime/IntlNumberFormatInlines.h: Added.

(JSC::setNumberFormatDigitOptions):
(JSC::IntlFieldIterator::IntlFieldIterator):
(JSC::IntlFieldIterator::next):

  • runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::initializePluralRules):
(JSC::IntlPluralRules::resolvedOptions const):
(JSC::IntlPluralRules::UPluralRulesDeleter::operator() const): Deleted.
(JSC::IntlPluralRules::UNumberFormatDeleter::operator() const): Deleted.
(JSC::UEnumerationDeleter::operator() const): Deleted.

  • runtime/IntlPluralRules.h:
  • runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::formatToParts const):
(JSC::IntlRelativeTimeFormat::URelativeDateTimeFormatterDeleter::operator() const): Deleted.
(JSC::IntlRelativeTimeFormat::UNumberFormatDeleter::operator() const): Deleted.

  • runtime/IntlRelativeTimeFormat.h:
  • tools/JSDollarVM.cpp:

(JSC::functionICUVersion):

11:08 AM Changeset in webkit [266030] by ysuzuki@apple.com
  • 16 edits
    28 adds in trunk

Console object's @@toStringTag should be "console" instead of "Console"
https://bugs.webkit.org/show_bug.cgi?id=215750

Reviewed by Ross Kirsling.

LayoutTests/imported/w3c:

Import ToT wpt/console tests including @@toStringTag tests.

  • resources/import-expectations.json:
  • web-platform-tests/console/META.yml: Added.
  • web-platform-tests/console/console-is-a-namespace.any-expected.txt: Added.
  • web-platform-tests/console/console-is-a-namespace.any.html: Added.
  • web-platform-tests/console/console-is-a-namespace.any.js: Added.

(test):

  • web-platform-tests/console/console-is-a-namespace.any.worker-expected.txt: Added.
  • web-platform-tests/console/console-is-a-namespace.any.worker.html: Added.
  • web-platform-tests/console/console-label-conversion.any-expected.txt: Added.
  • web-platform-tests/console/console-label-conversion.any.html: Added.
  • web-platform-tests/console/console-label-conversion.any.js: Added.

(const.method.of.methods.test):

  • web-platform-tests/console/console-label-conversion.any.worker-expected.txt: Added.
  • web-platform-tests/console/console-label-conversion.any.worker.html: Added.
  • web-platform-tests/console/console-namespace-object-class-string.any-expected.txt: Added.
  • web-platform-tests/console/console-namespace-object-class-string.any.html: Added.
  • web-platform-tests/console/console-namespace-object-class-string.any.js: Added.

(test):
(test.t.t.add_cleanup):

  • web-platform-tests/console/console-namespace-object-class-string.any.worker-expected.txt: Added.
  • web-platform-tests/console/console-namespace-object-class-string.any.worker.html: Added.
  • web-platform-tests/console/console-tests-historical.any-expected.txt: Added.
  • web-platform-tests/console/console-tests-historical.any.html: Added.
  • web-platform-tests/console/console-tests-historical.any.js: Added.

(test):

  • web-platform-tests/console/console-tests-historical.any.worker-expected.txt: Added.
  • web-platform-tests/console/console-tests-historical.any.worker.html: Added.
  • web-platform-tests/console/idlharness.any-expected.txt: Added.
  • web-platform-tests/console/idlharness.any.html: Added.
  • web-platform-tests/console/idlharness.any.js: Added.
  • web-platform-tests/console/idlharness.any.worker-expected.txt: Added.
  • web-platform-tests/console/idlharness.any.worker.html: Added.
  • web-platform-tests/console/w3c-import.log: Added.

Source/JavaScriptCore:

Use "console" instead of "Console". Now, namespace object has @@toStringTag.
https://github.com/web-platform-tests/wpt/pull/24717

  • runtime/ConsoleObject.cpp:

LayoutTests:

  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/loader/window-properties-restored-from-page-cache-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • inspector/debugger/pause-for-internal-scripts-expected.txt:
  • inspector/debugger/stepping/stepping-internal-scripts-expected.txt:
  • js/console-expected.txt:
  • js/console.html:
  • platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt:
10:57 AM Changeset in webkit [266029] by ysuzuki@apple.com
  • 8 edits in trunk

[JSC] Enable Intl.DisplayNames
https://bugs.webkit.org/show_bug.cgi?id=215749

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-displaynames.js:
  • stress/intl-parse-unicode-subtags.js:
  • stress/intl-suppored-locales-of.js:
  • test262/config.yaml:

Source/JavaScriptCore:

Enable Intl.DisplayNames by default. This is already stage 4 and integrated into the spec.

  • runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

  • runtime/OptionsList.h:
9:16 AM Changeset in webkit [266028] by Darin Adler
  • 24 edits in trunk

Move node geometry functions from Range to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=215677

Reviewed by Zalan Bujtas.

Source/WebCore:

Moved functions that return quads and rectangles out of Range into RenderObject.
We could find another home for them, but for now they make sense as static member
functions there since RenderObject has the non-static member functions that they
call on multiple nodes. Mostly did not change the design of these functions much,
and was careful not to change behavior at all. But did change a few things:

  • Got rid of the functions that return a single unioned rectangle. Instead callers call unionRect at each call site.
  • Changed the "use selection height" boolean to a BoundingRectBehavior flag.
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::boundsForRects): Call unionRect(RenderObject::absoluteTextRects) instead
of Range::absoluteBoundingBox.

  • dom/DocumentMarkerController.cpp:

(WebCore::updateRenderedRectsForMarker): Instead of passing "true", pass
"RenderObject::BoundingRectBehavior::UseSelectionHeight".

  • dom/Range.cpp:

(WebCore::Range::absoluteBoundingBox const): Deleted.
(WebCore::Range::absoluteRectsForRangeInText const): Deleted.
(WebCore::Range::absoluteTextRects const): Deleted.
(WebCore::Range::getClientRects const): Call RenderObject::clientBorderAndTextRects.
(WebCore::Range::getBoundingClientRect const): Call
unionRect(RenderObject::clientBorderAndTextRects).
(WebCore::Range::borderAndTextRects const): Deleted.
(WebCore::Range::boundingRect const): Deleted.
(WebCore::Range::absoluteBoundingRect const): Deleted.

  • dom/Range.h: Updated for above.
  • dom/SimpleRange.cpp:

(WebCore::IntersectingNodeIterator::IntersectingNodeIterator): Fix bug affecting
empty ranges by calling enforceEndInvariant.
(WebCore::IntersectingNodeIterator::advance): Refactor to call enforceEndInvariant.
(WebCore::IntersectingNodeIterator::advanceSkippingChildren): Ditto.
(WebCore::IntersectingNodeIterator::enforceEndInvariant): Added.

  • dom/SimpleRange.h: Added enforceEndInvariant.
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::getClippedVisibleTextRectangles const): Instead of
passing a useSelectionHeight boolean, pass BoundingRectBehavior.

  • page/TextIndicator.cpp:

(WebCore::absoluteBoundingRectForRange): Call
unionRectIgnoringZeroRects(RenderObject::absoluteBorderAndTextRects).
(WebCore::initializeIndicator): Call RenderObject::absoluteTextRects.

  • platform/graphics/GeometryUtilities.cpp:

(WebCore::unionRectIgnoringZeroRects): Added.

  • platform/graphics/GeometryUtilities.h: Updated for above.
  • rendering/RenderLineBreak.h: Marked a lot of functions final.

Added a default value for the absoluteQuads out argument.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect): Tweaked code style a bit.
(WebCore::RenderObject::absoluteTextQuads): Replaced boolean useSelectionHeight
argument with a BoundingRectBehavior argument. Also added a downcast so the
call to RenderLineBreak::absoluteQuads is a non-virtual function call.
(WebCore::absoluteRectsForRangeInText): Added.
(WebCore::RenderObject::absoluteTextRects): Replaced boolean useSelectionHeight
argument with a BoundingRectBehavior argument.
(WebCore::nodeBefore): Added.
(WebCore::borderAndTextRects): Added.
(WebCore::RenderObject::absoluteBorderAndTextRects): Added.
(WebCore::RenderObject::clientBorderAndTextRects): Added.

  • rendering/RenderObject.h: Updated for above.

Source/WebKit:

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::boundingRectInWindowCoordinates const):
Call unionRectIgnoringZeroRects(RenderObject::absoluteBorderAndTextRects).
(WebKit::InjectedBundleRangeHandle::renderedImage): Call
unionRectIgnoringZeroRects(RenderObject::absoluteBorderAndTextRects).

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestEvasionRectsAboveSelection): Call
unionRect(RenderObject::absoluteTextRects).
(WebKit::WebPage::requestDocumentEditingContext): Call
unionRect(RenderObject::absoluteTextRects).

Source/WebKitLegacy/mac:

  • DOM/DOM.mm:

(-[DOMRange boundingBox]): Call unionRect(RenderObject::absoluteTextRects).

Source/WebKitLegacy/win:

  • AccessibleTextImpl.cpp:

(AccessibleText::scrollSubstringTo): Call
unionRect(RenderObject::absoluteTextRects) instead of
Range::absoluteBoundingBox.

LayoutTests:

  • fast/dom/Range/scale-page-bounding-client-rect.html: Fix this test that accidentally

depended on getting rects for an empty range (the contents of a div element with no
text inside it) to instead get rects for a non-empty element (the div element, not
just its contents). Test now works correctly, but results don't need to change.

  • fast/dom/Range/scale-page-client-rects.html: Ditto.
9:13 AM Changeset in webkit [266027] by Darin Adler
  • 6 edits in trunk/Source/WebCore

Make some small improvements involving sorting
https://bugs.webkit.org/show_bug.cgi?id=215617

Reviewed by Anders Carlsson.

  • contentextensions/DFA.cpp:

(WebCore::ContentExtensions::printTransitions): Fixed "incomming" spelling error.

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet): Use std::stable_sort instead of std::sort
because there is no guarantee that each image has different resolution and we want
repeatable behavior when they are the same.

  • page/Performance.cpp:

(WebCore::Performance::appendBufferedEntriesByType const): Removed the return
value since we don't need it any more.

  • page/Performance.h: Updated for above.
  • page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::observe): Use std::stable_sort only on the new
entries and then use std::inplace_merge. It's wasteful to re-sort the entire
array when adding entries. A little less elegant, but more efficient.

9:11 AM Changeset in webkit [266026] by Darin Adler
  • 35 edits
    1 add in trunk

Create documentOrder function, start refactoring to use it instead of Range::compare functions
https://bugs.webkit.org/show_bug.cgi?id=215551

Reviewed by Chris Dumez.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Make TextControlInnerElements.h Private so

we can use it from unit tests.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::text const): Tweak code slightly.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedTextRange const): Always use the native
text control's idea of the selected text range. There is no need to use the
document-based range with any of these native text controls. The check before would
almost always return true, except for unusual cases, particularly combo box, which
returns false for isARIATextControl. We may want to change isARIATextControl to
return true for combo box, but it's not necessary for this fix. Without this change,
a test involving a combo box was failing because changes caused
documentBasedSelectedTextRange to no longer accidentally do the right thing.

  • dom/BoundaryPoint.h: Added != and documentOrder.
  • dom/Document.h: Export allocation function and constructor so we can allocate

in a unit test.

  • dom/Node.cpp:

(WebCore::connectedInSameTreeScope): Renamed from areNodesConnectedInSameTreeScope.
(WebCore::Node::compareDocumentPosition): Updated for name change above.
(WebCore::depth): Changed to take a const& and to walk acrosss shadow host boundaries,
so this can be used in algorithms that are intended to work on the combined tree.
Has no effect when called on nodes that are not in a shadow tree.
(WebCore::commonInclusiveAncestorAndChildren): Refactored so this can be used by
callers that need to know the distinct ancestor children as well as the common
ancestor. Also revised it to work across shadow tree boundaries.
(WebCore::commonInclusiveAncestor): Updated to call commonInclusiveAncestorAndChildren.
(WebCore::isSiblingSubsequent): Added.
(WebCore::documentOrder): Added. Implemented using commonInclusiveAncestorAndChildren and
isSiblingSubsequent.

  • dom/Node.h: Updated for above. Also added PartialOrdering class, a compatible

subset of C++20's std::partial_ordering, for return value for documentOrder.

  • dom/Position.cpp:

(WebCore::Position::computeOffsetInContainerNode const): Removed clamping the
result to the length of the container node; not needed.
(WebCore::Position::previous const): Updated for name change.
(WebCore::Position::next const): Updated for name change.
(WebCore::Position::upstream const): Updated for name change.
(WebCore::Position::downstream const): Updated for name change.
(WebCore::commonInclusiveAncestor): Renamed from commonShadowIncludingAncestor
since this is now the same as the commonInclusiveAncestor that takes two nodes;
they now both take shadow trees into account.
(WebCore::makeContainerOffsetPosition): Added. Clearer way to construct
positions from containers and offsets. An alternative to makeDeprecatedLegacyPosition
for cases where we don't need the deprecated legacy behavior.
(WebCore::makeDeprecatedLegacyPosition): Renamed from createLegacyEditingPosition.
Adding the word "deprecated" to be clearer that this is not just "legacy" but also
something we are trying to get rid of. Changing from "create" to "make" because
this does not allocate memory on the heap.
(WebCore::documentOrder): Added. Still to do: more optimized implementation when
we can compare two positions without computing node offsets.

  • dom/Position.h: Updated for above.

(WebCore::minOffsetForNode): Deleted.

  • dom/RadioButtonGroups.cpp:

(WebCore::RadioButtonGroup::members const): Use documentOrder instead of
documentOrderComparator.

  • dom/Range.cpp:

(WebCore::areRangesEqual): Rewrote to not use Position.
(WebCore::rangesOverlap): Updated for name change.
(WebCore::Range::expand): Rewrote to not use Range::start/endPosition.
(WebCore::operator<<): Deleted.

  • dom/Range.h: Removed now-unused Range::start/endPosition, documentOrderComparator,

and TextStream operators.

  • dom/RangeBoundaryPoint.h: Removed now-unused RangeBoundaryPoint::toPosition.

Added makeBoundaryPoint function to convert RangeBoundaryPoint into BoundaryPoint.

  • dom/SimpleRange.cpp:

(WebCore::isOffsetBeforeChild): Added. For use by documentOrder.
(WebCore::documentOrder): Added.

  • editing/TextIterator.cpp:

(WebCore::characterCount): Use documentOrder instead of
Range::compareBoundaryPoints.

  • editing/VisiblePosition.cpp:

(WebCore::areVisiblePositionsInSameTreeScope): Updated for name change.

  • editing/VisiblePosition.h: Use assignment insteed of calling clear,

to possibly prepare to get rid of Position::clear in the future.
Added a documentORder function that takes two visible positions.

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::cacheAncestorsOfStartToBeConverted): Use
commonInclusiveAncestor instead of commonShadowIncludingAncestor.

  • editing/markup.cpp:

(WebCore::serializePreservingVisualAppearanceInternal): Ditto.

  • html/HTMLBodyElement.h: Export create function so it can used in unit tests.
  • html/HTMLDivElement.h: Ditto.
  • html/HTMLHtmlElement.h: Ditto.
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::create): Added so it can be used in unit tests.

  • html/HTMLTextAreaElement.h: Ditto. Also export the innerTextElement function

so it can be used in unit tests.

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange): Use makeDeprecatedLegacyPosition directly
rather than using Range::start/endPosition. This was the only place in WebCore
still using Range::start/endPosition and over time we would like to move from
makeDeprecatedLegacyPosition to makeContainerOffsetPosition, so it's good to
have it be explicit here rather than hidden inside the Range class.
(WebCore::DOMSelection::containsNode const): Added a check of containingShadowRoot.
This preserves the old behavior. Before, constructing the range resulted in
a collapsed range when the shadow tree was involved. This is a more direct way
to achieve the same result.

  • page/Page.cpp:

(WebCore::replaceRanges): Use documentOrder instead of comparePositions.
Eventually we will delete comparePositions.

Source/WebKit:

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange rangeByExpandingToWordBoundaryByCharacters:inDirection:]):
Use makeDeprecatedLegacyPosition instead of Range::start/endPosition.
This was the only place in the WebKit framework still using
Range::start/endPosition and over time we would like to move from
makeDeprecatedLegacyPosition to makeContainerOffsetPosition, so it's good
to have it be explicit here rather than hidden inside the Range class.

Source/WebKitLegacy/ios:

  • WebCoreSupport/WebVisiblePosition.mm:

(-[DOMRange startPosition]): Rewrote to not use Range::startPosition.
(-[DOMRange endPosition]): Rewrote to not use Range::endPosition.

Source/WebKitLegacy/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]):
Rewrite to use makeSimpleRange and makeContainerOffsetPosition. Simplifies
the null checks. Would love to remove the function but at this time it's
still used by Apple's Mail app (albeit in a peculiar way, always passing a
constant string).

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added DocumentOrder.cpp.
  • TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp: Added.

Relatively thorough test of three different documentOrder functions.
Could still use even more test cases involving different types of shadow trees.

7:33 AM Changeset in webkit [266025] by Philippe Normand
  • 14 edits in trunk

[GTK][WPE] Compilation warnings with clang/gcc 10
https://bugs.webkit.org/show_bug.cgi?id=215699

Reviewed by Darin Adler.

.:

  • Source/cmake/WebKitCompilerFlags.cmake: Disable tautological-compare and

misleading-indentation warnings triggering false-positive when building JSC.

Source/WebCore:

  • Modules/indexeddb/server/SQLiteIDBBackingStore.h: Mark class as final because its destructor is marked as such.

(WebCore::IDBServer::SQLiteIDBBackingStore::databaseDirectory const): Deleted.
(WebCore::IDBServer::SQLiteIDBBackingStore::sessionID const): Deleted.
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseRootDirectoryIsolatedCopy const): Deleted.

  • dom/messageports/MessagePortChannelProviderImpl.h: Ditto.
  • layout/Verification.cpp:

(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded): Remove spurious
matchingRuns assignment. I have no idea how this was supposed to work?

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode): Use FALLTHROUGH macro.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decodeFrame): Ditto.

Source/WebKit:

  • UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithTouchEvent): Use null input touch event enum value for touch event handling.

Tools:

  • TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Wrap m_geometry private field in GTK

ifdefs, this is not used in WPE.

  • WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::windowFrame): Return rect built with explicit initializers.

  • wpe/backends/WindowViewBackend.cpp: Supply additional touch client callbacks, mandated by the interface.
6:25 AM Changeset in webkit [266024] by Lauro Moura
  • 2 edits in trunk/Tools

Unreviewed, reverting r266012.

Fix API tests after r266020

Reverted changeset:

"[GLIB] Update checked exception after r265942"
https://bugs.webkit.org/show_bug.cgi?id=215738
https://trac.webkit.org/changeset/266012

1:27 AM Changeset in webkit [266023] by ysuzuki@apple.com
  • 2 edits in trunk/Tools

Unreviewed, add slackId to my contributors.json entry

Slack allows multiple users having the same name. How to identify one user in slack is using Slack member ID.
Try setting a slackId and leverage it via WKR / WebKitBot.

  • Scripts/webkitpy/common/config/contributors.json:

Aug 21, 2020:

6:32 PM Changeset in webkit [266022] by Alexey Shvayka
  • 2 edits in trunk/Source/JavaScriptCore

StrictEq should not care about masqueradesAsUndefinedWatchpoint
https://bugs.webkit.org/show_bug.cgi?id=215743

Reviewed by Yusuke Suzuki.

This patch removes masqueradesAsUndefinedWatchpoint handling for StrictEq
from fixupCompareStrictEqAndSameValue(), aligning it with SameValue.

According to the spec [1], only a few language constructs special-case
IsHTMLDDA? objects: ToBoolean, abstract equality, and typeof.

No behavior change.

[1]: https://tc39.es/ecma262/#sec-IsHTMLDDA-internal-slot

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupCompareStrictEqAndSameValue):

5:52 PM Changeset in webkit [266021] by Wenson Hsieh
  • 4 edits
    1 add in trunk

[macOS] Unable to copy text from the function browser panel in Numbers
https://bugs.webkit.org/show_bug.cgi?id=215740
<rdar://problem/65189303>

Reviewed by Darin Adler.

Source/WebKit:

On some versions of Xcode, using Interface Builder to set up WKWebViews causes the WKWebView to contain two
WKFlippedViews as subviews; one of these is created and added in the normal initialization path of the web view
underneath WebViewImpl's constructor, and the other is created and added underneath the superclass (NSView's)
-initWithCoder: implementation.

This causes issues when hit-testing WKWebView using the -hitTest: method, which is expected to return the
WKWebView itself instead of the inner WKFlippedView. The logic that tries to implement this behavior is in
WebViewImpl::hitTest, which calls into WKWebView's -hitTest: method and returns the WKWebView if the hit-
tested view ended up being equal to the m_layerHostingView. Since we end up with two layer hosting views (only
one of which is the real m_layerHostingView), we fail the check and end up returning the other WKFlippedView.
In the context of this bug, this erroneous hit-test causes AppKit to ask if the WKFlippedView can become the
first responder upon mousedown (which it cannot), and so the window's first responder remains the same (instead
of changing to WKWebView).

To fix this, adjust the constructor of WebViewImpl to avoid making an extra layer hosting view in the case where
decoding the WKWebView already initialized and placed the layer hosting view, and just use the existing one
instead.

Test: WKWebView.HitTestAfterInitializingFromCoder

  • UIProcess/Cocoa/WebViewImpl.mm:

(-[WKFlippedView initWithFrame:]):
(-[WKFlippedView initWithCoder:]):
(-[WKFlippedView _commonInitialize]):

Override both designated initialization codepaths so that we call the -_commonInitialize helper, which sets
the autoresizing mask. This was previously called immediately after creating the WKFlippedView in the
constructor of WebViewImpl.

(WebKit::WebViewImpl::WebViewImpl):

Tools:

Add a new API test that serializes a WKWebView, then deserializes it, and then verifies that calling -hitTest:
on the deserialized WKWebView grabs the WKWebView itself rather than the WKFlippedView underneath it.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WKWebViewCoders.mm: Added.
5:20 PM Changeset in webkit [266020] by Jonathan Bedard
  • 2 edits
    1 add in trunk/Tools

Regression (r265942): Layout-tests are hanging on iOS EWS
https://bugs.webkit.org/show_bug.cgi?id=215742
<rdar://problem/67584717>

Unreviewed infrastructure fix.

Partial revert of r265942, since EWS is raising objc exceptions after forking.

  • Scripts/webkitpy/common/timeout_context.py:

(Timeout):

  • Scripts/webkitpy/common/timeout_context_unittest.py: Added.

(TimeoutContextTests):

4:46 PM Changeset in webkit [266019] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r265965.
https://bugs.webkit.org/show_bug.cgi?id=215744

getCallData can be called from DFG concurrent compiler, but it
is not safe in DOM PluginObject

Reverted changeset:

"Use jsTypeofIsObject() in DFG AI and
operationTypeOfIsObject()"
https://bugs.webkit.org/show_bug.cgi?id=144457
https://trac.webkit.org/changeset/265965

4:07 PM Changeset in webkit [266018] by Alexey Shvayka
  • 10 edits in trunk

Align "length" properties of function prototypes with the spec
https://bugs.webkit.org/show_bug.cgi?id=215716

Reviewed by Ross Kirsling.

JSTests:

  • test262/expectations.yaml: Mark 8 test cases as passing.

Source/JavaScriptCore:

This change defines Function.prototype.length [1] as Configurable? and
removes "length" properties from other (async/generator) function prototypes
that are ordinary non-callable objects [2], aligning JSC with V8 and SpiderMonkey.

Also, adds inherits() ASSERT in FunctionPrototype::finishCreation()
to match (most of) the other built-ins.

[1]: https://tc39.es/ecma262/#sec-properties-of-the-function-prototype-object
[2]: https://tc39.es/ecma262/#sec-async-function-prototype-properties

  • runtime/AsyncFunctionPrototype.cpp:

(JSC::AsyncFunctionPrototype::finishCreation):

  • runtime/AsyncGeneratorFunctionPrototype.cpp:

(JSC::AsyncGeneratorFunctionPrototype::finishCreation):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::finishCreation):

  • runtime/GeneratorFunctionPrototype.cpp:

(JSC::GeneratorFunctionPrototype::finishCreation):

LayoutTests:

  • js/kde/prototype_length-expected.txt:
  • js/kde/script-tests/prototype_length.js:
3:49 PM Changeset in webkit [266017] by Simon Fraser
  • 2 edits in trunk/Tools

Fix the Color/ExtendedColor lldb data provider
https://bugs.webkit.org/show_bug.cgi?id=215735

Reviewed by Darin Adler.

Fix the data provider for Color after Color and ExtendedColor internals changed.

  • lldb/lldb_webkit.py:

(WebCoreColorProvider._to_string_extended):
(WebCoreColorProvider.to_string):

3:49 PM Changeset in webkit [266016] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Add some FIXMEs in the EventHandler wheel event handling code for all the things that are wrong
https://bugs.webkit.org/show_bug.cgi?id=215741

Reviewed by Wenson Hsieh.

There is much confusing code here. Trying to document the issues I've found.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

  • page/mac/EventHandlerMac.mm:

(WebCore::findEnclosingScrollableContainer):
(WebCore::EventHandler::determineWheelEventTarget):
(WebCore::EventHandler::processWheelEventForScrolling):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

2:30 PM Changeset in webkit [266015] by Alexey Shvayka
  • 5 edits in trunk

Define Intl[Symbol.toStringTag]
https://bugs.webkit.org/show_bug.cgi?id=215715

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-object.js:
  • test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch utilizes JSC_TO_STRING_TAG_WITHOUT_TRANSITION() to define Symbol.toStringTag
on Intl namespace object, implementing the recent spec change [1] and aligning JSC with V8.
Also, adds inherits() ASSERT to match (most of) the other built-ins.

[1]: https://github.com/tc39/ecma402/pull/487

  • runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

2:29 PM Changeset in webkit [266014] by aestes@apple.com
  • 4 edits in trunk/Source/WebKit

IPC::encodeSharedBuffer combines SharedBuffer data segments when copying to SharedMemory
https://bugs.webkit.org/show_bug.cgi?id=215737
<rdar://problem/67568099>

Reviewed by Darin Adler.

IPC::encodeSharedBuffer called SharedBuffer::data() when copying data into SharedMemory,
requiring the SharedBuffer to combine its data segments. This can be avoided by using
SharedMemory::copyBuffer() instead.

  • Platform/SharedMemory.cpp:

(WebKit::SharedMemory::copyBuffer): Modernized to use auto and range-based for loops.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeSharedBuffer): Used SharedMemory::copyBuffer() to create a copy of the buffer in
a new SharedMemory. Calling this function does not combine the buffer's data segments.

  • Platform/SharedMemory.h: Added a FIXME for how SharedMemory's factory functions could be

improved.

1:41 PM Changeset in webkit [266013] by Alexey Shvayka
  • 8 edits
    1 add in trunk

Function.prototype.bind should not clamp "length" to int32
https://bugs.webkit.org/show_bug.cgi?id=215733

Reviewed by Darin Adler.

JSTests:

  • microbenchmarks/function-bind-creation.js: Added.
  • test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch fixes to integer conversion of target function's "length" values
beyond UINT_MAX, aligning JSC with the spec [1], V8 and SpiderMonkey.

double is used instead of uint64_t to retain semantics of JS Number type [2]
and hold Infinity values. To avoid spreading double length over JSFunction::create()
and its subclasses, JSBoundFunction is modified to use JSFunction::finishCreation(VM&)
overload, removing 2 unused arguments and speeding up bound function creation by ~9%.

[1]: https://tc39.es/ecma262/#sec-function.prototype.bind (step 6.c.i)
[2]: https://tc39.es/ecma262/#sec-ecmascript-language-types-number-type

  • builtins/FunctionPrototype.js:

(bind):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):

  • runtime/JSBoundFunction.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::reifyLength):

  • runtime/JSGlobalObject.cpp:

(JSC::makeBoundFunction):

12:43 PM Changeset in webkit [266012] by Lauro Moura
  • 2 edits in trunk/Tools

[GLIB] Update checked exception after r265942
https://bugs.webkit.org/show_bug.cgi?id=215738

Reviewed by Carlos Alberto Lopez Perez.

Avoid aborting the full script on a timeout due to unchecked
exception.

  • glib/api_test_runner.py:

(TestRunner._run_google_test): Use exception from new timeout module.

12:16 PM Changeset in webkit [266011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Use closeReason provided in didCloseWithCode delegate for the NSURLSessionWebSocket code path
https://bugs.webkit.org/show_bug.cgi?id=215519

Patch by Jiten Mehta <jmehta@apple.com> on 2020-08-21
Reviewed by Youenn Fablet.

Covered by existing protocol tests with NSURLSession code path enabled.
http/tests/websocket/tests/hybi/workers/close-code-and-reason.html

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:webSocketTask:didCloseWithCode:reason:]):

11:28 AM Changeset in webkit [266010] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Merge two DOMURL constructors
https://bugs.webkit.org/show_bug.cgi?id=215734

Patch by Rob Buis <rbuis@igalia.com> on 2020-08-21
Reviewed by Darin Adler.

Merge two DOMURL constructors to make it match the relevant WebIDL:
https://url.spec.whatwg.org/#dom-url-url-url-base-base

  • html/DOMURL.cpp:

(WebCore::DOMURL::create):

  • html/DOMURL.h:
  • html/DOMURL.idl:
10:43 AM Changeset in webkit [266009] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix USE_ANGLE=0 build after "WebGLLayer clobbers TEXTURE_2D binding on iOS"
https://bugs.webkit.org/show_bug.cgi?id=211758

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-08-21
Reviewed by Kenneth Russell.

No new tests, build fix.

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getUniformIndices): Mark parameters unused
when USE_ANGLE=0

  • platform/graphics/cocoa/WebGLLayer.mm: Define scoped binding restorer

only for USE_ANGLE=1, since it's not used otherwise and it is implemented
in terms of ANGLE gl::... API.

  • platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:

Include Logging.h to make RELEASE_LOG(WebGL, ...) work.
Presumably this file is not compiled with USE_ANGLE=1 or
the unified build mechanism hides the error.

9:39 AM Changeset in webkit [266008] by Russell Epstein
  • 1 copy in tags/Safari-610.1.28.1.3

Tag Safari-610.1.28.1.3.

9:36 AM Changeset in webkit [266007] by Russell Epstein
  • 9 edits in branches/safari-610.1.28.1-branch/Source

Cherry-pick r265953. rdar://problem/67560218

Sandbox violation when calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=215701
<rdar://problem/67069826>

Reviewed by Geoffrey Garen.

The sandbox does not allow calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess.
createPrivateStorageSession() was calling [NSHTTPCookieStorage sharedHTTPCookieStorage] to retrieve
the cookieAcceptPolicy and createPrivateStorageSession() is used by the cookie cache in the WebProcess.
To address the issue, we now allow the caller of createPrivateStorageSession() to provide the
cookieAcceptPolicy and we have the cookie cache retrieve the cookieAcceptPolicy from the
NetworkProcessConnection.

Source/WebCore:

  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNetWin.cpp: (WebCore::createPrivateStorageSession):
  • platform/network/cocoa/NetworkStorageSessionCocoa.mm: (WebCore::createPrivateStorageSession):

Source/WebKit:

  • WebProcess/Network/NetworkProcessConnection.h: (WebKit::NetworkProcessConnection::cookieAcceptPolicy const):
  • WebProcess/WebPage/Cocoa/WebCookieCacheCocoa.mm: (WebKit::WebCookieCache::inMemoryStorageSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:34 AM Changeset in webkit [266006] by Russell Epstein
  • 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.3

9:25 AM Changeset in webkit [266005] by Russell Epstein
  • 2 edits in branches/safari-609-branch/Source/WTF

Cherry-pick r265252. rdar://problem/67080756

about: scheme URL constants should be backed by StaticStringImpl
https://bugs.webkit.org/show_bug.cgi?id=215113

Reviewed by Darin Adler.

  • wtf/URL.cpp: (WTF::aboutBlankURL): (WTF::aboutSrcDocURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:42 AM Changeset in webkit [266004] by Andres Gonzalez
  • 6 edits in trunk

Source/WebCore:
Range::contains does not work correctly when the common ancestor node is a Document.
https://bugs.webkit.org/show_bug.cgi?id=215714

Reviewed by Darin Adler.

Test: accessibility/mac/selected-visible-position-range.html.

For a Range with a Document object as common ancestor, Range::contains(otherRange)
would return false for any given other range in the same document. This
causes problems in VoiceOver navigation and Braille functionality in
the MacOS Mail.app.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const):
Use SimpleRange::isNull instead of repeating its implementation.

  • dom/Range.cpp:

(WebCore::Range::contains const): Compare the Documents of the ranges'
common ancesstor nodes instead of their ownerDocuments.

LayoutTests:
Range::contains(const Range&) should compare the Documents to which the Ranges belong, not the ownerDocuments.
https://bugs.webkit.org/show_bug.cgi?id=215714

Reviewed by Darin Adler.

Revamped the following test to check that a collapsed selection range is
set to the correct character offset in the text content. In addition,
properly used the Promise returned by waitFor in order to make the test
timing independent and work in isolated tree mode.

  • accessibility/mac/selected-visible-position-range-expected.txt:
  • accessibility/mac/selected-visible-position-range.html:
4:29 AM Changeset in webkit [266003] by aestes@apple.com
  • 48 edits
    3 copies in trunk/Source/WebKit

REGRESSION (r257667): 1.9x more CPU time in IPC::SharedBufferDataReference decoding during Netflix playback
https://bugs.webkit.org/show_bug.cgi?id=215232
<rdar://problem/66637920>

Reviewed by Geoff Garen.

Prior to r257667, an IPC message defined a IPC::SharedBufferDataReference argument to allow
its sender to easily encode SharedBuffer data as a DataReference. SharedBufferDataReference
cost the same to encode as a DataReference -- both copied data into the Encoder -- but did
so by iterating over the SharedBuffer's data segments rather than combining them into a
contiguous allocation. The message argument was received as a decoded IPC::DataReference,
which stores a pointer into the IPC::Decoder's buffer rather than making a copy.

In r257667, IPC::SharedBufferDataReference switched its encoder to use IPC::ArgumentCoder's
SharedBuffer specialization, which works by allocating a SharedMemory buffer, copying
SharedBuffer data into it, creating a SharedMemory::IPCHandle from it, and encoding the
handle. It makes only one copy like the old encoder did, but pays the added cost of
combining SharedBuffer data segments prior to copying by needlessly calling
SharedBuffer::data() (this should be fixed independently).

Since this serialization could no longer be decoded by DataReference's decoder,
SharedBufferDataReference implemented a decoder, also in terms of ArgumentCoder's SharedBuffer
specialization. It works by mapping a SharedMemory buffer from a decoded
SharedMemory::IPCHandle and copying that buffer into a new SharedBuffer. This copy is a cost
that the old decoder did not incur, but in some cases the message receiver would have made
such a copy anyway and can instead just ref the decoded SharedBuffer. In other cases though,
the receiver either made no copies or couldn't use the decoded SharedBuffer to avoid making
its own copy so creating the SharedBuffer was pure added cost.

There are additional costs from allocating, mapping, and deleting shared memory and Mach
send rights, but they are offset by savings due to smaller Encoder and Decoder buffers. The
additional SharedBuffer combining and copying is not offset elsewhere, and on net makes
sending and receiving IPC::SharedBufferDataReferences use up to 2x more CPU time when
playing a video on netflix.com in Safari.

Resolve this slowdown by reverting the argument encoding changes made to
IPC::SharedBufferDataReference in r257667. For compatibility with code added after r257667,
the current IPC::SharedBufferDataReference was copied to IPC::SharedBufferCopy and retains
the behavior of copying into a SharedBuffer when decoded. IPC::SharedBufferDataReference now
has the pre-r257667 behavior of decoding to an IPC::DataReference. Messages added after
r257667 whose receivers were designed to handle a SharedBuffer were changed to use
IPC::SharedBufferCopy, and all other receivers of messages with IPC::SharedBufferDataReference
arguments were changed to handle an IPC::DataReference.

  • GPUProcess/media/RemoteCDMInstanceProxy.cpp:
  • GPUProcess/media/RemoteCDMInstanceProxy.h:
  • GPUProcess/media/RemoteCDMInstanceProxy.messages.in:
  • GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
  • GPUProcess/media/RemoteCDMInstanceSessionProxy.h:
  • GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in:
  • GPUProcess/media/RemoteCDMProxy.cpp:
  • GPUProcess/media/RemoteCDMProxy.h:
  • GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
  • GPUProcess/media/RemoteLegacyCDMSessionProxy.h:
  • GPUProcess/media/RemoteLegacyCDMSessionProxy.messages.in:
  • UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::platformRegisterAttachment):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::registerAttachmentIdentifierFromData):
(WebKit::WebPageProxy::platformRegisterAttachment):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPasteboardProxy.h:
  • UIProcess/WebPasteboardProxy.messages.in:
  • UIProcess/gtk/WebPasteboardProxyGtk.cpp:
  • WebProcess/GPU/media/RemoteCDMInstance.cpp:
  • WebProcess/GPU/media/RemoteCDMInstanceSession.cpp:
  • WebProcess/GPU/media/RemoteCDMInstanceSession.h:
  • WebProcess/GPU/media/RemoteCDMInstanceSession.messages.in:
  • WebProcess/GPU/media/RemoteLegacyCDMSession.cpp:
  • WebProcess/GPU/media/RemoteLegacyCDMSession.h:
  • WebProcess/GPU/media/RemoteLegacyCDMSession.messages.in:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Replaced

IPC::SharedBufferDataReference with IPC::SharedBufferCopy.

  • NetworkProcess/NetworkResourceLoader.cpp:
  • NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
  • NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
  • NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
  • WebProcess/Network/WebResourceLoader.cpp:
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
  • WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: Removed the DidReceiveSharedBuffer

message and reverted the DidReceiveData message back to taking an
IPC::SharedBufferDataReference.

  • Platform/IPC/Encoder.h: Made Encoder::reserve(size_t) public so

SharedBufferCopy::encode(Encoder&) can call it.

  • Platform/IPC/HandleMessage.h: Restored the CodingType specialization that decodes

SharedBufferDataReference arguments as DataReferences.

  • Platform/IPC/SharedBufferCopy.cpp:
  • Platform/IPC/SharedBufferCopy.h: Copied from SharedBufferDataReference.h. Implemented the

interface and decoding behavior that SharedBufferDataReference had between r257667 and this
change.

  • Platform/IPC/SharedBufferDataReference.cpp:
  • Platform/IPC/SharedBufferDataReference.h: Reverted to the pre-r257667 interface and

decoding behvior.

  • Scripts/webkit/messages.py: Removed an unneeded special case.
  • Sources.txt:
  • WebKit.xcodeproj/project.pbxproj: Added SharedBuffer{Copy,DataReference}.cpp.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dataCallback):
(WebKit::WebPageProxy::finishedLoadingIcon):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h: Used const IPC::DataReference& in message receiver

signatures for SharedBufferDataReference arguments.

  • UIProcess/WebURLSchemeTask.cpp:
  • WebProcess/GPU/media/RemoteAudioBusData.h:
  • WebProcess/GPU/media/RemoteCDM.cpp:
  • WebProcess/Network/WebLoaderStrategy.cpp: Removed unused includes.
12:51 AM BuildingCairoOnWindows edited by Fujii Hironori
(diff)

Aug 20, 2020:

11:55 PM Changeset in webkit [266002] by Peng Liu
  • 2 edits in trunk/Source/WebKit

Mac Catalyst Apps require "playsinline" attribute to support playing videos in the inline mode
https://bugs.webkit.org/show_bug.cgi?id=215724

Reviewed by Tim Horton.

Currently WebKit::currentUserInterfaceIdiomIsPad() returns NO on Mac Catalyst apps.
Therefore, the behavior of Mac Catalyst apps regarding the inline media playback
support is not consistent with iPad apps.

This patch removes the usage of WebKit::currentUserInterfaceIdiomIsPad() to decide
the settings of the inline media playback support on Mac Catalyst apps.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):

11:55 PM Changeset in webkit [266001] by Fujii Hironori
  • 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

  • platform/wincairo/TestExpectations: Remove lines for removed tests.
11:46 PM Changeset in webkit [266000] by commit-queue@webkit.org
  • 8 edits in trunk

[GTK][WPE] Debug crashes in backdrop filter tests
https://bugs.webkit.org/show_bug.cgi?id=215209

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-08-20
Reviewed by Adrian Perez de Castro.

Source/WebCore:

This only happens in WKTR because RenderLayerCompositor::flushPendingLayerChanges() is called from
RenderLayerCompositor::layerTreeAsText(), so the coordinator doesn't know layers are being flushed and we don't
return early from notifyFlushRequired(). We don't really need to have a coordinator associated to the backdrop
layer, we just need to attach the layer to the coordinator to ensure it's updated.

  • platform/graphics/nicosia/NicosiaAnimation.cpp:

(Nicosia::Animation::applyInternal): Handle AnimatedPropertyWebkitBackdropFilter.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer): Detach also the backdrop layer.
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly): Attach the backdrop layer to the
coordinator if there's one.
(WebCore::CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers): Do not call this for the
backdrop layer.
(WebCore::CoordinatedGraphicsLayer::invalidateCoordinator): Set coordinator to nullptr.
(WebCore::CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded): Set the coordinator and attach
the layer. Also attach the backdrop layer.
(WebCore::CoordinatedGraphicsLayer::setCoordinator): Deleted.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::~CompositingCoordinator): Use invalidateCoordinator() instead of setCoordinator()
that has been removed.
(WebKit::CompositingCoordinator::createGraphicsLayer): Use setCoordinatorIncludingSubLayersIfNeeded() instead of
attaching the layer directly.
(WebKit::CompositingCoordinator::attachLayer): Do not call setCoordinator(), the caller is expected to set the
coordinator.

LayoutTests:

Remove expectations for tests that are now passing.

  • platform/glib/TestExpectations:
11:20 PM Changeset in webkit [265999] by Diego Pino Garcia
  • 2 edits in trunk/Tools

[EWS] Add more workers to GTK-WK2-Tests-EWS queue
https://bugs.webkit.org/show_bug.cgi?id=215408

Reviewed by Aakash Jain.

  • BuildSlaveSupport/ews-build/config.json:
9:53 PM Changeset in webkit [265998] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Mark several WebGL tests as failure after r265975.

  • platform/glib/TestExpectations:
8:50 PM Changeset in webkit [265997] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Replace IC on Proxy must write barrier Proxy's target
https://bugs.webkit.org/show_bug.cgi?id=215720

Reviewed by Yusuke Suzuki.

The put_by_id opcode in the baseline and the DFG/FTl will emit a writeBarrier
after the operation is complete. But it does this to the base object. In the
case of an IC with the base as a Proxy, we're not actually storing to the Proxy, but
instead, the Proxy's target. This patch makes it so our IC code writeBarriers
the Proxy's target. This fixed a crash when running Speedometer2.

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::canReplace const):
(JSC::AccessCase::generateImpl):

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::preserveLiveRegistersToStackForCallWithoutExceptions):

  • bytecode/PolymorphicAccess.h:
7:31 PM Changeset in webkit [265996] by pvollan@apple.com
  • 6 edits
    1 add in trunk

[macOS] Web pages are not responding correctly to changes in "Reduce motion" setting
https://bugs.webkit.org/show_bug.cgi?id=215664

Reviewed by Darin Adler.

Source/WebCore/PAL:

Declare "Reduce motion" preference key, as well as notification sent when the "Reduce motion" setting is changed.

  • pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

This happens because there is a race between the preference change and notification being received in the WebContent
process. This race is usually won by the notification, which then reads the wrong preference value when being handled.
This bug was introduced when access to the preference daemon was closed in the WebContent process, and preferences
were updated from the UI process. This patch addresses this issue by re-posting the notification when the preference
value is updated in the WebContent process.

API test: WebKit.AccessibilityReduceMotion

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::reduceMotionPreferenceKey):
(WebKit::dispatchSimulatedNotificationsForPreferenceChange):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm: Added.

(TEST):

7:10 PM Changeset in webkit [265995] by Hector Lopez
  • 2 edits in trunk/LayoutTests

REGRESSION(r156546): 18 media tests broken
https://bugs.webkit.org/show_bug.cgi?id=122021

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
6:39 PM Changeset in webkit [265994] by Alan Coon
  • 1 copy in tags/Safari-610.1.26.3

Tag Safari-610.1.26.3.

6:38 PM Changeset in webkit [265993] by Alan Coon
  • 3 edits
    2 adds in branches/safari-610.1.26-branch

Cherry-pick r265932. rdar://problem/67485356

Fix possible crash when webAnimationsCSSIntegrationEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=215668
<rdar://problem/67402003>

Reviewed by Dean Jackson.

Source/WebKit:

When webAnimationsCSSIntegrationEnabled is false, GraphicsLayerCA::setupAnimation() doesn't
set a timing function on the animation, causing a null de-ref when the animation is being encoded.
Fix the encoder to handle null timing functions.

Test: animations/legacy-encoding-timing-function.html

  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::Properties::encode const): (WebKit::PlatformCAAnimationRemote::Properties::decode):

LayoutTests:

  • animations/legacy-encoding-timing-function-expected.txt: Added.
  • animations/legacy-encoding-timing-function.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:36 PM Changeset in webkit [265992] by Alan Coon
  • 8 edits in branches/safari-610.1.26-branch/Source

Versioning.

WebKit-7610.1.26.3

6:33 PM Changeset in webkit [265991] by Chris Dumez
  • 12 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky webaudio tests.

  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
6:33 PM Changeset in webkit [265990] by Hector Lopez
  • 1 edit in trunk/LayoutTests/ChangeLog

[ macOS ] fast/repaint/list-item-equal-style-change-no-repaint.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215723

Unreviewed test gardening.

  • platform/mac/TestExpectations:
6:33 PM Changeset in webkit [265989] by Hector Lopez
  • 2 edits in trunk/LayoutTests

fast/repaint/list-item-equal-style-change-no-repaint.html
https://bugs.webkit.org/show_bug.cgi?id=215723

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:47 PM Changeset in webkit [265988] by Russell Epstein
  • 5 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67417186

B3 IntRange is incorrect for negative masks
https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

  • b3/B3ReduceStrength.cpp:
  • b3/testb3.h:
  • b3/testb3_1.cpp: (run):
  • b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:47 PM Changeset in webkit [265987] by Russell Epstein
  • 4 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r264643. rdar://problem/67027034

TryGetById clobberize rules are wrong.
https://bugs.webkit.org/show_bug.cgi?id=163834
<rdar://problem/65625807>

Reviewed by Keith Miller.

Theoretically, TryGetById can do the same things GetById does i.e. reify lazy
properties, read the stack, etc. Hence, its clobberize rule should be clobberTop
just like GetById. However, in practice, we don't currently use @tryGetById to
access anything on the stack (and probably never will). But as a conservative
measure, we'll just treat TryGetById like it can. In clobberize terms, this
means we declare TryGetById as doing read(World) (just like GetById) instead of
read(Heap).

  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
  • dfg/DFGClobberize.h: (JSC::DFG::clobberize):
  • dfg/DFGClobbersExitState.cpp: (JSC::DFG::clobbersExitState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:19 PM Changeset in webkit [265986] by Karl Rackler
  • 25 edits in branches/safari-610.1.28.0-branch/LayoutTests/imported/w3c

Unreviewed test gardening. Revert unnecessary baseline.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/processing-model/cycle-without-delay-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analysernode-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiosourcenode-interface/mediastreamaudiosourcenode-ctor-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
5:12 PM Changeset in webkit [265985] by Wenson Hsieh
  • 3 edits
    2 adds in trunk

REGRESSION (r263729): Carousel freezes on "fourth page"/fourth click on right arrow on netflix.com
https://bugs.webkit.org/show_bug.cgi?id=215655
<rdar://problem/65845979>

Reviewed by Dean Jackson.

Source/WebCore:

On netflix.com, when clicking on the left and right arrows in each movie or TV show carousel, the page attempts
to animate to the next page of the carousel using a CSS transform transition. The logic applies transform and
transition CSS properties to a container div, and adds a transitionend event listener which the page
expects to be invoked when the animation is complete. While waiting for this transitionend event, the script
also sets a boolean flag that prevents the carousel from being advanced to any other page. However, after the
changes in r263729, the carousel gets into a state where transition and transform styles are set, but the
animation never begins, and thus, no subsequent transitionend event is observed. This causes the page to
believe that the carousel is indefinitely animating, so it never unsets the boolean flag, which results in the
carousel being permanently stuck.

This occurs because we now have logic in AnimationTimeline::updateCSSTransitionsForElementAndProperty that
moves the CSSTransition from the element's map of running transitions to the map of completed transitions in
the case where the corresponding WebAnimation is already in Finished state. However, consider the case where
there is no matching backing animation (i.e. matchingBackingAnimation is nullptr); for instance, this can
happen if the transition CSS property is set to none in the middle of the transitionend event, as demonstrated
in the new layout test. Before the change, we would've removed the CSSTransition from the map of running
transitions and canceled it, but now, we instead move it to the map of completed transitions, where it remains
until the next CSS transition update is triggered (which would potentially be indefinitely long!).

On netflix.com, this next CSS transition update happens the page attempts to advance the carousel. Since the old
CSSTransition is still in the "completed" transitions map, we end up returning true when checking
propertyInStyleMatchesValueForTransitionInMap, and consequently never attempt to create a new CSSTransition
and add it to the map of running transitions in step 1 of the algorithm. As described above, this causes the
carousel to get stuck in a bad state.

To fix this, we simply revert to pre-r263729 behavior in the case where the matching backing animation was
already removed, and allow step 3 of the algorithm to cancel the running animation and remove it altogether
instead of moving it into the element's completed transitions map.

Test: animations/animation-followed-by-two-transitions.html

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):

LayoutTests:

Adds a layout test inspired by animation logic used in the broken carousel UI on netflix.com. This test can be
manually run by opening the test in a browser and verifying that the green square quickly slides across the
screen twice, and two transitionend events are observed in the process.

  • animations/animation-followed-by-two-transitions-expected.txt: Added.
  • animations/animation-followed-by-two-transitions.html: Added.
4:53 PM Changeset in webkit [265984] by Russell Epstein
  • 8 edits in branches/safari-609-branch/Source

Versioning.

WebKit-7609.4.1

4:48 PM Changeset in webkit [265983] by Jonathan Bedard
  • 4 edits in trunk/Tools

[webkitcorepy] Fix pip package
https://bugs.webkit.org/show_bug.cgi?id=215717
<rdar://problem/67512294>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitcorepy/MANIFEST.in: Add cacert.pem.
  • Scripts/libraries/webkitcorepy/setup.py: Include submodules.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Version bump.
4:34 PM Changeset in webkit [265982] by Karl Rackler
  • 3 edits in branches/safari-610.1.28.1-branch/LayoutTests

rdar://67367072 REGRESSION (r265805): [ Catalina / iOS ] 24 w3c/web-platform-tests/webaudio/ tests are a constant failure)
Adding test expectations for[ Catalina / iOS ]

Unreviewed test gardening.

  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
4:15 PM Changeset in webkit [265981] by Chris Dumez
  • 4 edits in trunk

AudioBufferSourceNode should use "final" values for playbackRate and detune
https://bugs.webkit.org/show_bug.cgi?id=215669

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt:

Source/WebCore:

AudioBufferSourceNode should use "final" values for playbackRate and detune to take into
account changes to the AudioParamTimeline (for example, when
AudioBufferSourceNode.playbackRate.setValueAtTime() is called).

No new tests, rebaselined existing test.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::totalPitchRate):

4:14 PM Changeset in webkit [265980] by Chris Dumez
  • 36 edits in trunk

AudioParam.automationRate attribute is missing
https://bugs.webkit.org/show_bug.cgi?id=215710

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/automation-rate-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:

Source/WebCore:

Add initial support for AudioParam.automationRate:

No new tests, rebaselined existing tests.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

  • Modules/webaudio/AudioListener.cpp:

(WebCore::AudioListener::AudioListener):

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::setAutomationRate):
(WebCore::AudioParam::calculateSampleAccurateValues):

  • Modules/webaudio/AudioParam.h:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

  • Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::ConstantSourceNode):
(WebCore::ConstantSourceNode::process):

  • Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::process):

  • Modules/webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

  • Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::GainNode):
(WebCore::GainNode::process):

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::calculateSampleAccuratePhaseIncrements):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::distanceConeGain):

  • Modules/webaudio/PannerNode.h:
  • Modules/webaudio/StereoPannerNode.cpp:

(WebCore::StereoPannerNode::StereoPannerNode):
(WebCore::StereoPannerNode::process):

  • Modules/webaudio/WebKitAudioBufferSourceNode.h:
  • Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
(WebCore::WebKitAudioPannerNode::distanceConeGain):

  • Modules/webaudio/WebKitAudioPannerNode.h:
  • Modules/webaudio/WebKitDynamicsCompressorNode.h:
4:12 PM Changeset in webkit [265979] by Karl Rackler
  • 3 edits in branches/safari-610.1.28.0-branch/LayoutTests

rdar://67367072 ([ safari-610.1-branch ] REGRESSION (r265805): [ Catalina / iOS ] 24 w3c/web-platform-tests/webaudio/ tests are a constant failure)
Adding test expectations for[ Catalina / iOS ]

Unreviewed test gardening.

  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
4:11 PM Changeset in webkit [265978] by Karl Rackler
  • 24 edits in branches/safari-610.1.28.0-branch/LayoutTests/imported/w3c/web-platform-tests/webaudio

rdar://67367072 ([ safari-610.1-branch ] REGRESSION (r265805): [ Jazz/Azul wk2 ] 24 w3c/web-platform-tests/webaudio/ tests are a constant failure)
Rebaseline failing test since required webaudio changes are not intended to be cherry-picked to the branch.

Unreviewed test gardening.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/processing-model/cycle-without-delay-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analysernode-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiosourcenode-interface/mediastreamaudiosourcenode-ctor-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
3:55 PM Changeset in webkit [265977] by James Savage
  • 3 edits in trunk/Source/WebKit

Could not find module 'WebKit' for target 'armv7-apple-ios'
<https://bugs.webkit.org/show_bug.cgi?id=215190>
<rdar://problem/65642049>

Reviewed by Brady Eidson.

The config changes here got added to the wrong config file. They need to
be for the overlay, not its tests.

  • SwiftOverlay/Configurations/WebKitSwiftOverlay.xcconfig:
  • SwiftOverlay/Configurations/WebKitSwiftOverlayTests.xcconfig:
3:51 PM Changeset in webkit [265976] by Alan Coon
  • 1 copy in tags/Safari-610.1.28.3.2

Tag Safari-610.1.28.3.2.

3:41 PM Changeset in webkit [265975] by commit-queue@webkit.org
  • 16 edits in trunk

[WebGL2] Pass context-lost-restored.html test
https://bugs.webkit.org/show_bug.cgi?id=215599

Patch by Kenneth Russell <kbr@chromium.org> on 2020-08-20
Reviewed by Dean Jackson.

Source/WebCore:

Support losing extensions, and restoring them via
WEBGL_lose_context.

Necessarily changed WebGLExtensions to be RefCounted rather than
managed via unique_ptr. Multiple instances of the same
WebGLExtension subclass can now be vended from a WebGL rendering
context, and WebGLExtensions can now outlive their rendering
context - they do not ref their context.

Extensions now hold a weak pointer to their
WebGLRenderingContextBase rather than a C++ reference. When an
extension's parent context is lost, that pointer is nulled out.
Extensions are forcibly lost upon WebGL context destruction.

WebGL extensions' IDLs still use
GenerateIsReachable=ImplWebGLRenderingContext, so that if the
context is still alive, the JavaScript wrappers for the extension
objects will be preserved. (If the extension is lost, the bindings
will fetch nullptr for the context, which won't be in the opaque
root set, so the JavaScript wrapper won't be artificially kept
alive.)

Covered by existing WebGL conformance tests.

  • html/canvas/ANGLEInstancedArrays.cpp:

(WebCore::ANGLEInstancedArrays::drawArraysInstancedANGLE):
(WebCore::ANGLEInstancedArrays::drawElementsInstancedANGLE):
(WebCore::ANGLEInstancedArrays::vertexAttribDivisorANGLE):

  • html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::createVertexArrayOES):
(WebCore::OESVertexArrayObject::deleteVertexArrayOES):
(WebCore::OESVertexArrayObject::isVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):

  • html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::getTranslatedShaderSource):

  • html/canvas/WebGLDrawBuffers.cpp:

(WebCore::WebGLDrawBuffers::drawBuffersWEBGL):

  • html/canvas/WebGLExtension.cpp:

(WebCore::WebGLExtension::WebGLExtension):
(WebCore::WebGLExtension::loseParentContext):

  • html/canvas/WebGLExtension.h:

(WebCore::WebGLExtension::context):
(WebCore::WebGLExtension::isLost):
(WebCore::WebGLExtension::ref): Deleted.
(WebCore::WebGLExtension::deref): Deleted.

  • html/canvas/WebGLLoseContext.cpp:

(WebCore::WebGLLoseContext::loseContext):
(WebCore::WebGLLoseContext::restoreContext):
(WebCore::WebGLLoseContext::loseParentContext):

  • html/canvas/WebGLLoseContext.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::~WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::loseContextImpl):
(WebCore::WebGLRenderingContextBase::loseExtensions):

  • html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

Rebaselined WebGL conformance tests which are now fully passing.

  • webgl/1.0.3/conformance/context/context-lost-restored-expected.txt:
  • webgl/2.0.0/conformance/context/context-lost-restored-expected.txt:
3:38 PM Changeset in webkit [265974] by Alan Coon
  • 1 copy in tags/Safari-610.1.28.1.2

Tag Safari-610.1.28.1.2.

3:37 PM Changeset in webkit [265973] by Alan Coon
  • 1 copy in tags/Safari-610.1.28.0.2

Tag Safari-610.1.28.0.2.

3:34 PM Changeset in webkit [265972] by Alan Coon
  • 1 copy in tags/Safari-610.1.26.2

Tag Safari-610.1.26.2.

3:32 PM Changeset in webkit [265971] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews] Handle bugs with unicode characters in title in ews emails
https://bugs.webkit.org/show_bug.cgi?id=215627

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ensure email_subject is unicode.
(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Ditto.
(ReRunWebKitTests.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_pre_existing_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

3:09 PM Changeset in webkit [265970] by Alan Coon
  • 2 edits in branches/safari-610.1.26-branch/Source/WebKit

Cherry-pick r265930. rdar://problem/67364266

Fix null pointer crashes in network process after r265835

https://bugs.webkit.org/show_bug.cgi?id=215626

<rdar://problem/67268892>

Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:09 PM Changeset in webkit [265969] by Alan Coon
  • 4 edits in branches/safari-610.1.26-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:57 PM Changeset in webkit [265968] by Alan Coon
  • 8 edits in branches/safari-610.1.26-branch/Source

Versioning.

WebKit-7610.1.26.2

2:39 PM Changeset in webkit [265967] by Lauro Moura
  • 41 edits
    1 move
    1 add
    1 delete in trunk/LayoutTests

[GTK][WPE] Rebaseline websocket tests after r265592

Unreviewed test gardening.

  • platform/glib/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt: Renamed from LayoutTests/platform/wpe/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt.
  • platform/glib/http/tests/websocket/tests/hybi/broken-utf8-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/close-before-open-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/close-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/closed-port-delay-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/error-event-ready-state-non-existent-url-with-server-responding-404-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-error-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-invalid-http-version-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-accept-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-extensions-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-protocol-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-status-line-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-null-char-in-status-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/imported/blink/permessage-deflate-invalid-parameter-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/invalid-encode-length-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/invalid-masked-frames-from-server-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/long-control-frame-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/long-invalid-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt: Added.
  • platform/glib/http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/too-long-payload-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/websocket-event-target-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
  • platform/gtk/http/tests/security/mixedContent/websocket/insecure-websocket-in-iframe-expected.txt:
  • platform/gtk/http/tests/security/mixedContent/websocket/insecure-websocket-in-main-frame-expected.txt:
  • platform/gtk/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt: Removed.
2:37 PM Changeset in webkit [265966] by Alexey Shvayka
  • 4 edits in trunk

Invalid early errors for class methods named "constructor" and "prototype"
https://bugs.webkit.org/show_bug.cgi?id=215413

Reviewed by Darin Adler.

JSTests:

  • test262/expectations.yaml: Mark 24 test cases as passing.

Source/JavaScriptCore:

This change removes invalid early syntax errors, allowing static async/generator
methods named "constructor" and instance async/generator methods named "prototype",
which aligns JSC with the spec [1], V8, and SpiderMonkey.

Also, removes a FIXME related to super() calls outside constructor that was
resolved in r181404 and is covered by test262 suite.

[1]: https://tc39.es/ecma262/#sec-class-definitions-static-semantics-early-errors

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

2:25 PM Changeset in webkit [265965] by Alexey Shvayka
  • 6 edits in trunk/Source/JavaScriptCore

Use jsTypeofIsObject() in DFG AI and operationTypeOfIsObject()
https://bugs.webkit.org/show_bug.cgi?id=144457

Reviewed by Saam Barati.

This patch:

  1. Refactors jsTypeofIsObject(), leveraging fast path of isCallable(), moves it to the header, and utilizes it in DFG AI and operationTypeOfIsObject() to eliminate code duplication.
  1. Splits jsTypeofIsFunction() into 2 methods to accomodate operationTypeOfIsFunction() calling it with JSObject* argument.
  1. Removes orphaned slow_path_is_object declaration.

No behavior change, typeof microbenchmarks are neutral.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGOperations.cpp:
  • runtime/CommonSlowPaths.h:
  • runtime/Operations.cpp:

(JSC::jsTypeofIsObject): Deleted.

  • runtime/Operations.h:

(JSC::jsTypeofIsObject):
(JSC::jsTypeofIsFunction):

2:08 PM Changeset in webkit [265964] by Aditya Keerthi
  • 5 edits in trunk/Source

Add runtime setting for editable components in date/time inputs
https://bugs.webkit.org/show_bug.cgi?id=215705

Reviewed by Wenson Hsieh.

Source/WebCore:

This setting controls the ability to edit individual components of date
and time input types. For example, <input type=date> will have three
editable components - year, month, and day.

  • page/Settings.yaml:

Source/WebKit:

Added DateTimeInputsEditableComponentsEnabled as a runtime setting. This
setting is enabled by default on macOS.

  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h:
2:02 PM Changeset in webkit [265963] by commit-queue@webkit.org
  • 4 edits in trunk

XMLHttpRequest.open should use USVString
https://bugs.webkit.org/show_bug.cgi?id=215704

Patch by Rob Buis <rbuis@igalia.com> on 2020-08-20
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update improved test result.

  • web-platform-tests/xhr/open-url-encoding-expected.txt:

Source/WebCore:

XMLHttpRequest.open should use USVString as mentioned in the FIXMEs and the spec [1].

Test: imported/w3c/web-platform-tests/xhr/open-url-encoding.html

[1] https://xhr.spec.whatwg.org/#ref-for-dom-xmlhttprequest-open

  • xml/XMLHttpRequest.idl:
1:44 PM Changeset in webkit [265962] by Chris Dumez
  • 25 edits
    7 adds in trunk

Introduce StereoPannerNode Interface
https://bugs.webkit.org/show_bug.cgi?id=215518

Patch by Clark Wang <clark_wang@apple.com> on 2020-08-20
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-baselined existing tests. Some now fail due to missing automation rate.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-method-chaining-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/automation-rate-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/ctor-stereopanner-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/stereopannernode-basic-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/stereopannernode-panning-expected.txt:

Source/WebCore:

Added StereoPannerNode according to spec: https://www.w3.org/TR/webaudio/#stereopannernode.
Used Chromium implementation for guidance: https://source.chromium.org/chromium/chromium/src/
+/master:third_party/blink/renderer/modules/webaudio/stereo_panner_node.cc.
Added in StereoPannerOptions and StereoPanner files as well. The latter used Chromium
implementation for guidance: https://source.chromium.org/chromium/chromium/src/+
/master:third_party/blink/renderer/platform/audio/stereo_panner.cc

Re-baselined existing tests. Some now fail due to missing automation rate.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/webaudio/AudioNode.cpp:

(WebCore::convertEnumerationToString):

  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createStereoPanner):

  • Modules/webaudio/BaseAudioContext.h:
  • Modules/webaudio/BaseAudioContext.idl:
  • Modules/webaudio/StereoPannerNode.cpp: Added.

(WebCore::StereoPannerNode::create):
(WebCore::StereoPannerNode::StereoPannerNode):
(WebCore::StereoPannerNode::~StereoPannerNode):
(WebCore::StereoPannerNode::process):
(WebCore::StereoPannerNode::initialize):
(WebCore::StereoPannerNode::uninitialize):
(WebCore::StereoPannerNode::listener):
(WebCore::StereoPannerNode::setChannelCount):
(WebCore::StereoPannerNode::setChannelCountMode):

  • Modules/webaudio/StereoPannerNode.h: Added.
  • Modules/webaudio/StereoPannerNode.idl: Added.
  • Modules/webaudio/StereoPannerOptions.h: Added.
  • Modules/webaudio/StereoPannerOptions.idl: Added.
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:
  • platform/audio/StereoPanner.cpp: Added.

(WebCore::StereoPanner::create):
(WebCore::StereoPanner::StereoPanner):
(WebCore::StereoPanner::panWithSampleAccurateValues):
(WebCore::StereoPanner::panToTargetValue):

  • platform/audio/StereoPanner.h: Added.

(WebCore::StereoPanner::~StereoPanner):

  • platform/graphics/cocoa/SourceBufferParserWebM.cpp:
1:37 PM Changeset in webkit [265961] by Alexey Shvayka
  • 11 edits
    1 move
    271 adds
    15 deletes in trunk/JSTests

Update test262 to commit e0a65ee75ef8
https://bugs.webkit.org/show_bug.cgi?id=215708

Reviewed by Yusuke Suzuki.

  • test262/expectations.yaml:
  • test262/harness/*: Updated.
  • test262/latest-changes-summary.txt:
  • test262/test/*: Updated.
  • test262/test262-Revision.txt:
1:37 PM Changeset in webkit [265960] by Diego Pino Garcia
  • 2 edits in trunk/Tools

[ews] Add 'jsc-mips-tests' bubble
https://bugs.webkit.org/show_bug.cgi?id=215697

This new bubble runs jscore-tests for JSC MIPS 32-bit. The former
'jsc-mips' bubble now reports about successful binary builds for the
same architecture.

Reviewed by Aakash Jain.

  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble):

1:06 PM Changeset in webkit [265959] by svillar@igalia.com
  • 5 edits in trunk/Source/WebCore

Unreviewed, reverting r265850.

Tests crash on debug builds

Reverted changeset:

"[WebXR] Make "in parallel" code run really in parallel"
https://bugs.webkit.org/show_bug.cgi?id=215642
https://trac.webkit.org/changeset/265850

12:57 PM Changeset in webkit [265958] by Diego Pino Garcia
  • 5 edits in trunk/Tools

[ews] Split JSC MIPS queue into separate builder and tester queue
https://bugs.webkit.org/show_bug.cgi?id=212009

Reviewed by Aakash Jain.

Currently there are two EWS JSC MIPS configured, one that runs as
buildAndTest and another one that runs as buildOnly.

This patch changes the buildAndTest bot to test, and makes the
bot fetch the binary product produced by the buildOnly bot.

  • BuildSlaveSupport/ews-build/config.json:
  • BuildSlaveSupport/ews-build/factories.py:

(JSCTestsFactory):
(JSCTestsFactory.init):

  • BuildSlaveSupport/ews-build/factories_unittest.py:

(TestLayoutTestsFactory.test_gtk_factory):
(TestJSCBuildFactory):
(TestJSCBuildFactory.test_jsc_mipsel_factory):
(TestJSCBuildFactory.test_jsc_armv7_factory):
(TestJSCBuildAndTestsFactory):
(TestJSCBuildAndTestsFactory.test_jsc_mipsel_factory):
(TestJSCBuildAndTestsFactory.test_jsc_armv7_factory):
(TestJSCTestsFactory):
(TestJSCTestsFactory.test_jsc_mipsel_factory):
(TestJSCTestsFactory.test_jsc_armv7_factory):

  • BuildSlaveSupport/ews-build/loadConfig.py:
12:32 PM Changeset in webkit [265957] by Jonathan Bedard
  • 3 edits
    2 adds in trunk/Tools

[webkitcorepy] Add subprocess_utils.run
https://bugs.webkit.org/show_bug.cgi?id=215702
<rdar://problem/67487751>

Reviewed by Dewei Zhu.

Python 3's subprocess.run API is much better than the multiple subprocess APIs that Python 2 provides. Rather than
requiring new scripts and libraries to be fully Python 3, we should provide a Python 2 API identical to subprocess.run.

  • Scripts/libraries/webkitcorepy/README.md: Document usage of subprocess_utils.run.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Export subprocess_utils, bump minor version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/subprocess_utils.py: Added.

(run): Declare Python 2 version of Python 3's subprocess.run API.
(TimeoutExpired): Ditto.
(CompletedProcess): Ditto.

  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/subprocess_utils_unittest.py: Added.

(SubprocessUtils):
(SubprocessUtils.test_run):
(SubprocessUtils.test_run_exit):
(SubprocessUtils.test_run_timeout):
(SubprocessUtils.test_run_timeout_context):

11:48 AM Changeset in webkit [265956] by Alan Coon
  • 8 edits in branches/safari-610.2.2-branch/Source

Revert "Versioning."

11:47 AM Changeset in webkit [265955] by Alan Coon
  • 1 copy in tags/Safari-610.2.2

Tag Safari-610.2.2.

11:37 AM Changeset in webkit [265954] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ iOS Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-createHTMLDocument-parse-error-external-classic.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215706

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
10:53 AM Changeset in webkit [265953] by Chris Dumez
  • 9 edits in trunk/Source

Sandbox violation when calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=215701
<rdar://problem/67069826>

Reviewed by Geoffrey Garen.

The sandbox does not allow calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess.
createPrivateStorageSession() was calling [NSHTTPCookieStorage sharedHTTPCookieStorage] to retrieve
the cookieAcceptPolicy and createPrivateStorageSession() is used by the cookie cache in the WebProcess.
To address the issue, we now allow the caller of createPrivateStorageSession() to provide the
cookieAcceptPolicy and we have the cookie cache retrieve the cookieAcceptPolicy from the
NetworkProcessConnection.

Source/WebCore:

  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNetWin.cpp:

(WebCore::createPrivateStorageSession):

  • platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::createPrivateStorageSession):

Source/WebKit:

  • WebProcess/Network/NetworkProcessConnection.h:

(WebKit::NetworkProcessConnection::cookieAcceptPolicy const):

  • WebProcess/WebPage/Cocoa/WebCookieCacheCocoa.mm:

(WebKit::WebCookieCache::inMemoryStorageSession):

10:30 AM Changeset in webkit [265952] by youenn@apple.com
  • 3 edits in trunk/Source/WebKit

Align console log message of new WebSocket code path with the legacy code path
https://bugs.webkit.org/show_bug.cgi?id=215695

Reviewed by Alex Christensen.

No observable change of behavior from the page.
Console log messages appear in expected.txt files when NSURLSession code path is enabled.

  • WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::connect):
(WebKit::WebSocketChannel::didReceiveMessageError):

  • WebProcess/Network/WebSocketChannel.h:
9:49 AM Changeset in webkit [265951] by youenn@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add a WebSocket test checking close with 1000
https://bugs.webkit.org/show_bug.cgi?id=215694

Reviewed by Alex Christensen.

http/tests/websocket/tests/hybi/client-close.html is not running consistently between Firefox, Chrome, WebKit legacy WebSocket and WebKit NSURLSession WebSocket.
Add another test that uses an explicit close code that runs consistently between Firefox, Chrome and WebKit legacy WebSocket.

  • http/tests/websocket/tests/hybi/client-close-2-expected.txt: Added.
  • http/tests/websocket/tests/hybi/client-close-2.html: Added.
  • http/tests/websocket/tests/hybi/client-close-2_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

9:44 AM Changeset in webkit [265950] by Alan Coon
  • 3 edits
    2 adds in branches/safari-610.1.28.0-branch

Cherry-pick r265932. rdar://problem/67485356

Fix possible crash when webAnimationsCSSIntegrationEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=215668
<rdar://problem/67402003>

Reviewed by Dean Jackson.

Source/WebKit:

When webAnimationsCSSIntegrationEnabled is false, GraphicsLayerCA::setupAnimation() doesn't
set a timing function on the animation, causing a null de-ref when the animation is being encoded.
Fix the encoder to handle null timing functions.

Test: animations/legacy-encoding-timing-function.html

  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::Properties::encode const): (WebKit::PlatformCAAnimationRemote::Properties::decode):

LayoutTests:

  • animations/legacy-encoding-timing-function-expected.txt: Added.
  • animations/legacy-encoding-timing-function.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:44 AM Changeset in webkit [265949] by Karl Rackler
  • 2 edits in trunk/LayoutTests

Test failing on Rosetta as well as AS - adding test expectation for Rosetta
https://bugs.webkit.org/show_bug.cgi?id=207150

Unreviewed test gardening.

  • platform/mac/TestExpectationsRosetta:
9:35 AM Changeset in webkit [265948] by Alan Coon
  • 5 edits in branches/safari-610.1.28.3-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67439277

B3 IntRange is incorrect for negative masks
https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

  • b3/B3ReduceStrength.cpp:
  • b3/testb3.h:
  • b3/testb3_1.cpp: (run):
  • b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:34 AM Changeset in webkit [265947] by Alan Coon
  • 8 edits in branches/safari-610.1.28.3-branch/Source

Versioning.

WebKit-7610.1.28.3.2

9:32 AM Changeset in webkit [265946] by Alan Coon
  • 5 edits in branches/safari-610.1.28.2-branch/Source/JavaScriptCore

Revert r265929. rdar://problem/67439277

9:28 AM Changeset in webkit [265945] by Karl Rackler
  • 2 edits in trunk/LayoutTests

Four separate reported tests failures: rdar://6453565 rdar://65848157 rdar://66660924 rdar://6684253
Tests failing on Rosetta as well as AS - adding test expectations for Rosetta

Unreviewed test gardening.

  • platform/mac/TestExpectationsRosetta:
9:22 AM Changeset in webkit [265944] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] fast/scrolling/mac/scrollbars/overlay-scrollbar-hovered.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215700

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:12 AM Changeset in webkit [265943] by Karl Rackler
  • 2 edits in trunk/LayoutTests

rdar://66661355 ([ASi Layout Tests] 3 compositing tests failing with 0.01% diffs)
Tests failing on Rosetta as well as AS - adding test expectations for Rosetta

Unreviewed test gardening.

  • platform/mac/TestExpectationsRosetta:
7:33 AM Changeset in webkit [265942] by Jonathan Bedard
  • 5 edits
    2 adds
    1 delete in trunk/Tools

[webkitcorepy] Move Timeout to webkitcorepy (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=215584
<rdar://problem/67270713>

Reviewed by Darin Adler and Dewei Zhu.

The Timeout class is a generally useful Python utility, it should not live inside webkitpy.

  • Scripts/libraries/webkitcorepy/README.md: Document Timeout object.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Expose Timeout object API, increment version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/mocks/time_.py:

(_MetaTime.enter): Replace timeout.py's ORIGINAL_SLEEP variable to speed up testing.

  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/timeout_unittest.py: Added.

(TimeoutTests): Added.

  • Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py: Added.

(Timeout): Class representing a stackable Timeout context.
(Timeout.Data): Class containing information about a specific deadline.
(Timeout.Exception): Exception belonging to the Timeout object.
(Timeout.DisableAlarm): For some block of code, disable Timeout alarms. This is useful because many APIs (such as
subprocess.run) define their own timeouts which do better cleanup than an interrupt would.
(Timeout.default_handler): Default Timeout handler which raises an exception.
(Timeout.current): Return the current Timeout.Data class, if one exists.
(Timeout.deadline): Return the closest deadline, if one exists.
(Timeout.difference): Return the number of seconds between the current time and the closest deadline.
(Timeout.check): Check if we have surpassed the closest deadline., raise an exception if we have.
(Timeout.bind): Create a signal based on the closest deadline.
(Timeout.sleep): Override the sleep function because if we ever request a sleep that is greater than the closest deadline,
we should imiediately trigger the timeout logic without waiting for the timeout to actually expire.
(Timeout.init): Create a Timeout context, 1 second by default.
(Timeout.enter):
(Timeout.exit):

  • Scripts/webkitpy/common/timeout_context.py:

(Timeout): Moved to webkitcorepy.

6:53 AM Changeset in webkit [265941] by Diego Pino Garcia
  • 1 edit
    1 move in trunk/LayoutTests

[GTK] Unreviewed test gardening. Move WPE baseline for collection-iterators.html test to GLIB.

  • platform/glib/fast/dom/collection-iterators-expected.txt: Renamed from LayoutTests/platform/wpe/fast/dom/collection-iterators-expected.txt.
6:06 AM Changeset in webkit [265940] by Lauro Moura
  • 6 edits in trunk

REGRESSION(r265856) [GTK][WPE] hybi websockets tests failing
https://bugs.webkit.org/show_bug.cgi?id=215679

Reviewed by Carlos Garcia Campos.

Source/WebKit:

r265856 changed WebSocketChannel to expect AbnormalClosure when the
closing handshake is not received.

Covered by existing tests.

  • NetworkProcess/soup/WebSocketTaskSoup.cpp:

(WebKit::WebSocketTask::didFail):

LayoutTests:

Rebaseline and update expectations.

  • platform/glib/TestExpectations:
  • platform/glib/http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
3:43 AM Changeset in webkit [265939] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

WebSocketTask::close should correctly compute reason byte size in UTF-8
https://bugs.webkit.org/show_bug.cgi?id=215645

Reviewed by Darin Adler.

Covered by http/tests/websocket/tests/hybi/close.html with NSURLSession code path enabled.

  • NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::close):
Instead of calling sizeInBytes, we should just get the utf8 CString and gets its size directly.

12:15 AM Changeset in webkit [265938] by Diego Pino Garcia
  • 12 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update baselines after r265851.

  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-playing-and-pause-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:

Aug 19, 2020:

11:26 PM Changeset in webkit [265937] by Russell Epstein
  • 2 edits in branches/safari-610.1.28.0-branch/Source/WebKit

Cherry-pick r265930. rdar://problem/67364266

Fix null pointer crashes in network process after r265835

https://bugs.webkit.org/show_bug.cgi?id=215626

<rdar://problem/67268892>

Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:26 PM Changeset in webkit [265936] by Russell Epstein
  • 4 edits in branches/safari-610.1.28.0-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:29 PM Changeset in webkit [265935] by Fujii Hironori
  • 2 edits in trunk/Source/WebKit

IPC message can't be decoded due to uninitialized NavigationActionData member variables with the latest MSVC
https://bugs.webkit.org/show_bug.cgi?id=215662

Reviewed by Darin Adler.

WinCairo WebKit2 is crashing in AuxiliaryProcess::didReceiveInvalidMessage
if it is compiled by the latest MSVC (Visual Studio 2019 16.7) with optimizer (/O2).

LockHistory is a bool based enum type. NavigationActionData
doesn't initialize the member variable of it. IPC::Encoder
converts a LockHistory value to the underlying type bool. The
uninitialized value is converted 0 or 1 in GCC, Clang and old
MSVC. However, the latest MSVC doesn't convert and IPC::Decoder
detects an invalid enum value.

  • Shared/NavigationActionData.h: Added initializes for userGestureTokenIdentifier, lockHistory and lockBackForwardList.
10:07 PM Changeset in webkit [265934] by ysuzuki@apple.com
  • 35 edits
    12 adds in trunk

[JSC] Add Object.getOwnPropertyNames caching as it is done for Object.keys, and accelerate Object.getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=215666

Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/get-own-property-descriptor.js: Added.

(object.get test):
(object.set test):

  • stress/get-own-property-names-bad-time.js: Added.

(shouldBe):
(test):

  • stress/get-own-property-names-dfg.js: Added.

(shouldBe):
(test):

  • stress/keys-bad-time.js: Added.

(shouldBe):
(test):

  • stress/keys-dfg.js: Added.

(shouldBe):
(test):

  • stress/object-get-own-property-names-cached-zero.js: Added.

(shouldBe):
(test):

  • stress/object-get-own-property-names-changed-attribute.js: Added.

(shouldBe):
(test):

  • stress/object-get-own-property-names-changed-index.js: Added.

(shouldBe):
(test):

  • stress/object-get-own-property-names-changed.js: Added.

(shouldBe):
(test):

  • stress/object-get-own-property-names-indexed-non-cache.js: Added.

(shouldBe):
(test):

  • stress/object-get-own-property-names-overrides-get-property-names.js: Added.

(shouldBe):
(test):
(noInline):

  • stress/object-keys-cache.js: Added.

(shouldBe):
(symbol):

Source/JavaScriptCore:

Object.getOwnPropertyNames is immutable for Structure if structure meets some conditions. And we have optimization for Object.keys.
This patch wires existing caching mechanism for Object.keys to Object.getOwnPropertyNames so that Object.getOwnPropertyNames has
full support of caching & inlined code in DFG / FTL.

We also pre-bake structure for the result of Object.getOwnPropertyDescriptor so that we do not need to perform hash table lookup every
time we create an object for Object.getOwnPropertyDescriptor. This makes Object.getOwnPropertyDescriptor 2x faster from the microbenchmark.

The above two optimization makes Speedometer2/Inferno-TodoMVC 7% faster, and it also optimizes Speedometer2/EmberJS-Debug by 5%.
In total, we can get 0.7 - 1.0% progression in Speedometer2.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectKeysOrObjectGetOwnPropertyNames):
(JSC::DFG::SpeculativeJIT::compileObjectKeys): Deleted.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectKeysOrObjectGetOwnPropertyNames):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectKeys): Deleted.

  • runtime/Intrinsic.cpp:

(JSC::intrinsicName):

  • runtime/Intrinsic.h:
  • runtime/IteratorOperations.cpp:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::dataPropertyDescriptorObjectStructure const):
(JSC::JSGlobalObject::accessorPropertyDescriptorObjectStructure const):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncOwnKeys):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorGetOwnPropertySymbols):
(JSC::objectConstructorKeys):
(JSC::ownPropertyKeys):
(JSC::constructObjectFromPropertyDescriptorSlow):

  • runtime/ObjectConstructor.h:

(JSC::createDataPropertyDescriptorObjectStructure):
(JSC::createAccessorPropertyDescriptorObjectStructure):
(JSC::constructObjectFromPropertyDescriptor):

  • runtime/ReflectObject.cpp:

(JSC::reflectObjectOwnKeys):

  • runtime/Structure.cpp:

(JSC::Structure::canCachePropertyNameEnumerator const):

  • runtime/Structure.h:
  • runtime/StructureInlines.h:

(JSC::Structure::setCachedPropertyNames):
(JSC::Structure::cachedPropertyNames const):
(JSC::Structure::cachedPropertyNamesIgnoringSentinel const):
(JSC::Structure::canCacheOwnPropertyNames const):
(JSC::Structure::setCachedOwnKeys): Deleted.
(JSC::Structure::cachedOwnKeys const): Deleted.
(JSC::Structure::cachedOwnKeysIgnoringSentinel const): Deleted.
(JSC::Structure::canCacheOwnKeys const): Deleted.

  • runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren):

  • runtime/StructureRareData.h:
  • runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::cachedPropertyNames const):
(JSC::StructureRareData::cachedPropertyNamesIgnoringSentinel const):
(JSC::StructureRareData::cachedPropertyNamesConcurrently const):
(JSC::StructureRareData::setCachedPropertyNames):
(JSC::StructureRareData::cachedOwnKeys const): Deleted.
(JSC::StructureRareData::cachedOwnKeysIgnoringSentinel const): Deleted.
(JSC::StructureRareData::cachedOwnKeysConcurrently const): Deleted.
(JSC::StructureRareData::setCachedOwnKeys): Deleted.

10:00 PM Changeset in webkit [265933] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

Improperly linearized PDFs show up as blank gray on Big Sur.
rdar://problem/67117968 and https://bugs.webkit.org/show_bug.cgi?id=215683

Reviewed by Darin Adler.

Will add a new test once an in-house expert helps us construct an example PDF that
we will have the legal right to commit.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::threadEntry): When PDFKit indicates a PDFDocument is *improperly* linearized

(as opposed to not linearized at all), we failed to appopriately notify the main thread that
it needs to start handling the PDF.
Failure to create a PDFDocument is equivalent to receiving the "nonlinearized sentinel", so
adding that call fixes this issue.

8:51 PM Changeset in webkit [265932] by Simon Fraser
  • 3 edits
    2 adds in trunk

Fix possible crash when webAnimationsCSSIntegrationEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=215668
<rdar://problem/67402003>

Reviewed by Dean Jackson.

Source/WebKit:

When webAnimationsCSSIntegrationEnabled is false, GraphicsLayerCA::setupAnimation() doesn't
set a timing function on the animation, causing a null de-ref when the animation is being encoded.
Fix the encoder to handle null timing functions.

Test: animations/legacy-encoding-timing-function.html

  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::PlatformCAAnimationRemote::Properties::encode const):
(WebKit::PlatformCAAnimationRemote::Properties::decode):

LayoutTests:

  • animations/legacy-encoding-timing-function-expected.txt: Added.
  • animations/legacy-encoding-timing-function.html: Added.
7:50 PM Changeset in webkit [265931] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[GTK][WPE] Gardening websocket failures

Unreviewed test gardening.

  • platform/glib/TestExpectations:
6:50 PM Changeset in webkit [265930] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Fix null pointer crashes in network process after r265835

https://bugs.webkit.org/show_bug.cgi?id=215626

<rdar://problem/67268892>

Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

6:26 PM Changeset in webkit [265929] by Alan Coon
  • 5 edits in branches/safari-610.1.28.2-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67439277

B3 IntRange is incorrect for negative masks
https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

  • b3/B3ReduceStrength.cpp:
  • b3/testb3.h:
  • b3/testb3_1.cpp: (run):
  • b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:25 PM Changeset in webkit [265928] by Alan Coon
  • 8 edits in branches/safari-610.1.28.2-branch/Source

Versioning.

WebKit-7610.1.28.2.2

6:22 PM Changeset in webkit [265927] by Alan Coon
  • 5 edits in branches/safari-610.1.28.1-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67439265

B3 IntRange is incorrect for negative masks
https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

  • b3/B3ReduceStrength.cpp:
  • b3/testb3.h:
  • b3/testb3_1.cpp: (run):
  • b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [265926] by Alan Coon
  • 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.2

6:15 PM Changeset in webkit [265925] by Alan Coon
  • 5 edits in branches/safari-610.1.28.0-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67439269

B3 IntRange is incorrect for negative masks
https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

  • b3/B3ReduceStrength.cpp:
  • b3/testb3.h:
  • b3/testb3_1.cpp: (run):
  • b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:15 PM Changeset in webkit [265924] by Alan Coon
  • 2 edits in branches/safari-610.1.28.0-branch/Source/WebCore

Cherry-pick r265890. rdar://problem/67439260

[iOS] Restore a 10_15_* user-agent string when requesting desktop site
https://bugs.webkit.org/show_bug.cgi?id=215657
<rdar://problem/67376157>

Reviewed by Tim Horton.

Reporting a major version of 11_0 causes numerous compatibility issues on websites that attempt to parse major
and minor versions from the user agent string. This partially reverts r263970, and replaces the string with
10_15_6, which matches the UA string of the latest shipped macOS version.

  • platform/ios/UserAgentIOS.mm: (WebCore::standardUserAgentWithApplicationName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:15 PM Changeset in webkit [265923] by Alan Coon
  • 6 edits in branches/safari-610.1.28.0-branch/Source/WebKit

Cherry-pick r265882. rdar://problem/67439284

REGRESSION (r261407): Sharing rich links from Twitter/Netflix via Messages is unreliable
https://bugs.webkit.org/show_bug.cgi?id=215656
<rdar://problem/67087352>

Reviewed by Tim Horton.

The WKWebView._clientNavigationsRunAtForegroundPriority SPI was not working for the
MessagesViewService because the view is unparented and PageClient::isApplicationVisible()
would not work return accurate results when [view window] returns nil. It is very
unfortunate to have to rely on the view or the view's window to determine application
visibility so this patch fixes this. We now rely on UIKit's visibility endowment to
determine if the UIProcess is visible, using RunningBoard API. I have verified that the
visibility endowment properly gets propagated from the host application to the view
service when the application is a view service and I have verified that this detects
the MessagesViewService as visible for the use-case at <rdar://problem/67087352>, which
causes the WKWebView._clientNavigationsRunAtForegroundPriority SPI to work as intended.

Note that when the application does not have the visibility endowment, we still allow
it to take a foreground assertion for client navigations if the process is allowed to
run in the background for an extended period of time, according to RunningBoard. This
allows the SPI to work for daemons (like maild) which rely on it.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runJavaScriptInFrameInScriptWorld):
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::canTakeForegroundAssertions): (WebKit::PageClientImpl::isApplicationVisible): Deleted.
  • UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::shouldForceForegroundPriorityForClientNavigation const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:12 PM Changeset in webkit [265922] by Alan Coon
  • 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.2

5:49 PM Changeset in webkit [265921] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ iOS wk2 Release ] http/tests/security/contentSecurityPolicy/worker-redirect-allowed.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215676

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
5:45 PM Changeset in webkit [265920] by Alan Coon
  • 1 copy in tags/Safari-610.1.28.3.1

Tag Safari-610.1.28.3.1.

5:45 PM Changeset in webkit [265919] by Alan Coon
  • 1 copy in tags/Safari-610.1.28.2.1

Tag Safari-610.1.28.2.1.

5:44 PM Changeset in webkit [265918] by Alan Coon
  • 1 copy in tags/Safari-610.1.28.1.1

Tag Safari-610.1.28.1.1.

5:43 PM Changeset in webkit [265917] by Alan Coon
  • 1 copy in tags/Safari-610.1.28.0.1

Tag Safari-610.1.28.0.1.

5:39 PM Changeset in webkit [265916] by Kate Cheney
  • 30 edits in trunk

Third party domains are not stored in the case of back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=215595
<rdar://problem/66642893>

Reviewed by Chris Dumez.

Source/WebCore:

Add a FrameLoaderClient function to store loaded third party
domains in a CachedPage in the case of back/forward navigations.

  • history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):

  • history/CachedPage.h:
  • loader/FrameLoaderClient.h:

Source/WebKit:

This patch adds the ability to retrieve loaded third party domains from the page
synchronously to be stored in the CachedPage in the case of a
back/forward navigation.

It also changes the functions loadedThirdPartyDomains and
getLoadedThirdPartyDomains to loadedSubresourceDomains and
getLoadedSubresourceDomains respectively based on the conversation from
https://bugs.webkit.org/show_bug.cgi?id=215595.

  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadedSubresourceDomains):
(WKPageClearLoadedSubresourceDomains):
(WKPageLoadedThirdPartyDomains): Deleted.
(WKPageClearLoadedThirdPartyDomains): Deleted.

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _loadedSubresourceDomainsFor:completionHandler:]):
(-[WKWebsiteDataStore _clearLoadedSubresourceDomainsFor:]):
(-[WKWebsiteDataStore _loadedThirdPartyDomainsFor:completionHandler:]): Deleted.
(-[WKWebsiteDataStore _clearLoadedThirdPartyDomainsFor:]): Deleted.

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getLoadedSubresourceDomains):
(WebKit::WebPageProxy::clearLoadedSubresourceDomains):
(WebKit::WebPageProxy::loadedThirdPartyDomains): Deleted.
(WebKit::WebPageProxy::clearLoadedThirdPartyDomains): Deleted.

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::loadedSubresourceDomains const):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::didLoadFromRegistrableDomain):
(WebKit::WebPage::getLoadedSubresourceDomains):
(WebKit::WebPage::clearLoadedSubresourceDomains):
(WebKit::WebPage::loadedThirdPartyDomains): Deleted.
(WebKit::WebPage::clearLoadedThirdPartyDomains): Deleted.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::loadedSubresourceDomains const):

  • WebProcess/WebPage/WebPage.messages.in:

Tools:

API test coverage, including a new scheme handler to load third party
domains. Also this patch changes the function name from
loadedThirdPartyDomains to loadedSubresourceDomains based on the
conversation from https://bugs.webkit.org/show_bug.cgi?id=215595.

  • TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(-[ResourceLoadStatisticsSchemeHandler webView:startURLSchemeTask:]):
(-[ResourceLoadStatisticsSchemeHandler webView:stopURLSchemeTask:]):
(TEST):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::loadedSubresourceDomains):
(WTR::TestRunner::callDidReceiveLoadedSubresourceDomainsCallback):
(WTR::TestRunner::loadedThirdPartyDomains): Deleted.
(WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback): Deleted.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::LoadedSubresourceDomainsCallbackContext::LoadedSubresourceDomainsCallbackContext):
(WTR::loadedSubresourceDomainsCallback):
(WTR::TestController::loadedSubresourceDomains):
(WTR::TestController::clearLoadedSubresourceDomains):
(WTR::LoadedThirdPartyDomainsCallbackContext::LoadedThirdPartyDomainsCallbackContext): Deleted.
(WTR::loadedThirdPartyDomainsCallback): Deleted.
(WTR::TestController::loadedThirdPartyDomains): Deleted.
(WTR::TestController::clearLoadedThirdPartyDomains): Deleted.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveLoadedSubresourceDomains):
(WTR::TestInvocation::didReceiveLoadedThirdPartyDomains): Deleted.

  • WebKitTestRunner/TestInvocation.h:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::loadedSubresourceDomains):
(WTR::TestController::clearLoadedSubresourceDomains):
(WTR::TestController::loadedThirdPartyDomains): Deleted.
(WTR::TestController::clearLoadedThirdPartyDomains): Deleted.

LayoutTests:

Updated layout tests to use the new function name.

  • http/tests/resourceLoadStatistics/loaded-registrable-domains-get-reported.html:
  • http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html:
5:31 PM Changeset in webkit [265915] by Alan Coon
  • 1 copy in tags/Safari-610.1.26.1

Tag Safari-610.1.26.1.

5:30 PM Changeset in webkit [265914] by Alan Coon
  • 4 edits in branches/safari-610.1.28.0-branch

Revert r265878. rdar://problem/67364266

5:28 PM Changeset in webkit [265913] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

[iOS] Update fast/text/opticalFontWithTextStyle.html for iOS 14
https://bugs.webkit.org/show_bug.cgi?id=215667
<rdar://problem/67103788>

Unreviewed test gardening.

  • platform/ios/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt:
5:27 PM Changeset in webkit [265912] by Alan Coon
  • 4 edits in branches/safari-610.1.26-branch

Revert r265900. rdar://problem/67364266

5:25 PM Changeset in webkit [265911] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

Update fast/selectors/lang-dynamic.html after r265487
https://bugs.webkit.org/show_bug.cgi?id=215665
<rdar://problem/67083106>

Unreviewed test gardening.

  • fast/selectors/lang-dynamic-expected.html:
5:22 PM Changeset in webkit [265910] by Karl Rackler
  • 2 edits in trunk/LayoutTests

rdar://65269589 ([ macOS and iOS ] media/vp9.html is failing consistently.)
Add exception of BigSur wk2 only to run test for macOS

Unreviewed test gardening

  • platform/mac-wk2/TestExpectations:
5:16 PM Changeset in webkit [265909] by Karl Rackler
  • 3 edits in trunk/LayoutTests

rdar://65269589 ([ macOS and iOS ] media/vp9.html is failing consistently.)
Change test expectation to skip macOS with the exception of BigSur wk2

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
4:56 PM Changeset in webkit [265908] by Chris Dumez
  • 18 edits in trunk

Blob is missing text() & arrayBuffer() operations
https://bugs.webkit.org/show_bug.cgi?id=215663

Reviewed by Geoff Garen.

LayoutTests/imported/w3c:

  • web-platform-tests/FileAPI/blob/Blob-array-buffer.any-expected.txt:
  • web-platform-tests/FileAPI/blob/Blob-array-buffer.any.worker-expected.txt:
  • web-platform-tests/FileAPI/blob/Blob-text.any-expected.txt:
  • web-platform-tests/FileAPI/blob/Blob-text.any.worker-expected.txt:
  • web-platform-tests/FileAPI/idlharness-expected.txt:
  • web-platform-tests/FileAPI/idlharness.worker-expected.txt:

Source/WebCore:

Implementation support for Blob.text() & Blob.arrayBuffer() as per specification:

The implementation relies on the pre-existing BlobLoader class but the following
changes were made:

  • Stop calling start() in the BlobLoader constructor and have the caller call start() explicitly after constructing the BlobLoader. This is important because the load may fail synchronously in some cases.
  • Add support for reading Blob as text. Previously, BlobLoader would only support reading the blob as an ArrayBuffer.
  • Use a CompletionHandler instead of a Function and make sure that it is always called.

No new tests, rebaselined existing tests.

  • fileapi/Blob.cpp:

(WebCore::Blob::~Blob):
(WebCore::Blob::loadBlob):
(WebCore::Blob::text):
(WebCore::Blob::arrayBuffer):

  • fileapi/Blob.h:
  • fileapi/Blob.idl:
  • fileapi/BlobLoader.h:

(WebCore::BlobLoader::BlobLoader):
(WebCore::BlobLoader::~BlobLoader):
(WebCore::BlobLoader::cancel):
(WebCore::BlobLoader::start):
(WebCore::BlobLoader::didFinishLoading):
(WebCore::BlobLoader::didFail):
(WebCore::BlobLoader::complete): Deleted.

  • fileapi/NetworkSendQueue.cpp:

(WebCore::NetworkSendQueue::enqueue):
(WebCore::NetworkSendQueue::clear):
(WebCore::NetworkSendQueue::processMessages):

  • page/ShareDataReader.cpp:

(WebCore::ShareDataReader::start):
(WebCore::ShareDataReader::didFinishLoading):
(WebCore::ShareDataReader::cancel):

4:25 PM Changeset in webkit [265907] by Alexey Shvayka
  • 55 edits
    6 adds in trunk

Introduce OpIsCallable bytecode and intrinsic
https://bugs.webkit.org/show_bug.cgi?id=215572

Reviewed by Ross Kirsling and Saam Barati.

JSTests:

  • stress/type-of-functions-and-objects.js:
  • test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This patch:

  1. Aligns slow_path_is_function with DFG/FTL implementations by introducing jsTypeofIsFunction() helper. This fixes typeof document.all === "function" to return false instead of true.
  1. Renames is_function bytecode op to typeof_is_function, aligning it with typeof_is_undefined and typeof_is_object. New name offers better semantics and clearly communicates the op should be avoided when implementing new features because of typeof behavior with IsHTMLDDA? objects [1].
  1. Adds is_callable bytecode op and utilizes it in built-ins via intrinsic, removing typeof callback === "function" checks. This prevents IsHTMLDDA? objects from being considered non-callable [2].

To preserve the fast path for JSFunctionType,
createFunctionThatMasqueradesAsUndefined() is relocated to InternalFunction.

typeof microbenchmarks are neutral.

[1]: https://tc39.es/ecma262/#sec-IsHTMLDDA-internal-slot-typeof
[2]: https://tc39.es/ecma262/#sec-array.prototype.map (step 3)

  • builtins/ArrayConstructor.js:
  • builtins/ArrayPrototype.js:

(reduce):
(reduceRight):
(every):
(forEach):
(filter):
(map):
(some):
(find):
(findIndex):
(sort):
(flatMap):

  • builtins/FunctionPrototype.js:

(overriddenName.string_appeared_here.symbolHasInstance):
(bind):

  • builtins/MapPrototype.js:

(forEach):

  • builtins/PromiseConstructor.js:

(all):
(allSettled):
(any):
(race):
(nakedConstructor.Promise):
(nakedConstructor.InternalPromise):

  • builtins/PromiseOperations.js:

(globalPrivate.newPromiseCapabilitySlow):
(globalPrivate.resolvePromise):
(globalPrivate.resolveWithoutPromise):

  • builtins/PromisePrototype.js:

(finally):
(globalPrivate.getThenFinally):
(globalPrivate.getCatchFinally):

  • builtins/ReflectObject.js:

(apply):

  • builtins/RegExpPrototype.js:

(globalPrivate.regExpExec):
(overriddenName.string_appeared_here.replace):

  • builtins/SetPrototype.js:

(forEach):

  • builtins/TypedArrayConstructor.js:
  • builtins/TypedArrayPrototype.js:

(every):
(find):
(findIndex):
(forEach):
(some):
(sort):
(reduce):
(reduceRight):
(map):
(filter):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/BytecodeList.rb:
  • bytecode/BytecodeUseDef.cpp:

(JSC::computeUsesForBytecodeIndexImpl):
(JSC::computeDefsForBytecodeIndexImpl):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEqualityOpImpl):
(JSC::BytecodeGenerator::emitIsCallable):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

  • dfg/DFGHeapLocation.h:
  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIsCallable):
(JSC::DFG::SpeculativeJIT::compileIsFunction): Deleted.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileIsCallable):
(JSC::FTL::DFG::LowerDFGToB3::compileIsFunction): Deleted.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JITOperations.h:
  • jsc.cpp:

(functionMakeMasquerader):

  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:
  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::createFunctionThatMasqueradesAsUndefined):

  • runtime/InternalFunction.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::createFunctionThatMasqueradesAsUndefined): Deleted.

  • runtime/JSFunction.h:
  • runtime/Operations.h:

(JSC::jsTypeofIsFunction):

Source/WebCore:

No new tests, no behavior change.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase const):

LayoutTests:

  • js/dom/document-all-is-callable-builtins-expected.txt: Added.
  • js/dom/document-all-is-callable-builtins.html: Added.
  • js/dom/document-all-typeof-is-function-fold-expected.txt: Added.
  • js/dom/document-all-typeof-is-function-fold.html: Added.
  • js/dom/script-tests/document-all-is-callable-builtins.js: Added.
  • js/dom/script-tests/document-all-typeof-is-function-fold.js: Added.
4:24 PM Changeset in webkit [265906] by Chris Dumez
  • 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline imported/w3c/web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform.html

  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
3:44 PM Changeset in webkit [265905] by Alan Coon
  • 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.3

3:36 PM Changeset in webkit [265904] by Peng Liu
  • 7 edits
    2 adds in trunk

A PiP window is closed when the video element is removed from DOM
https://bugs.webkit.org/show_bug.cgi?id=215594

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/remove-video-element-in-pip-from-document.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::pauseAfterDetachedTask):
When a video is playing in the picture-in-picture mode, do not pause it or exit the
picture-in-picture mode when detaching the video element from the DOM.
(WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
Always return true when the video is playing in the picture-in-picture mode.

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::willBeDestroyed):
Don't hide the player when destroying the renderer of an inline video.

LayoutTests:

  • TestExpectations:
  • media/remove-video-element-in-pip-from-document-expected.txt: Added.
  • media/remove-video-element-in-pip-from-document.html: Added.
  • platform/ipad/TestExpectations:
  • platform/mac-wk2/TestExpectations:
3:35 PM Changeset in webkit [265903] by Russell Epstein
  • 2 edits in branches/safari-610.2.2-branch/Source/WebKit

Cherry-pick r265792. rdar://problem/67420555

Assert failure after r265715
https://bugs.webkit.org/show_bug.cgi?id=215592

Reviewed by Darin Adler.

The change set r265715 introduced an assert failure in AuthenticationManager::initializeConnection. This
happens because after r265715 the new XPC event handler set in AuthenticationManager::initializeConnection,
will no longer be called on the main thread. This patch addresses this issue by dispatching this work on
the main thread.

No new tests, covered by existing tests.

  • Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: (WebKit::AuthenticationManager::initializeConnection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:35 PM Changeset in webkit [265902] by Russell Epstein
  • 2 edits in branches/safari-610.2.2-branch/Source/WebKit

Cherry-pick r265761. rdar://problem/67420550

[Mac] Add Experimental Feature preference for SW VP9
https://bugs.webkit.org/show_bug.cgi?id=215043
<rdar://problem/66400034>

Reviewed by Darin Adler.

Follow up fix: during a rebase, a line deletion was dropped which causes the SW decoder to
always be registered regardless of the new setting.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::enableVP9Decoder): (WebKit::WebProcess::enableVP9SWDecoder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:55 PM Changeset in webkit [265901] by Alan Coon
  • 3 edits
    2 adds in branches/safari-610.1.26-branch

Cherry-pick r265881. rdar://problem/67423220

REGRESSION(r265092): delegatesFocus causes WebKit to crash
https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

  • fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
  • fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:55 PM Changeset in webkit [265900] by Alan Coon
  • 4 edits in branches/safari-610.1.26-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:53 PM Changeset in webkit [265899] by Alan Coon
  • 8 edits in branches/safari-610.1.26-branch/Source

Versioning.

WebKit-7610.1.26.1

2:40 PM Changeset in webkit [265898] by Russell Epstein
  • 1 copy in branches/safari-610.1.26-branch

New branch.

2:30 PM Changeset in webkit [265897] by Russell Epstein
  • 4 edits in branches/safari-610.1.25.0-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:29 PM Changeset in webkit [265896] by Russell Epstein
  • 3 edits
    2 adds in branches/safari-610.1.25.0-branch

Cherry-pick r265881. rdar://problem/67423220

REGRESSION(r265092): delegatesFocus causes WebKit to crash
https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

  • fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
  • fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:26 PM Changeset in webkit [265895] by Russell Epstein
  • 8 edits in branches/safari-610.1.25.0-branch/Source

Versioning.

WebKit-7610.1.25.0.3

2:15 PM Changeset in webkit [265894] by Russell Epstein
  • 3 edits
    2 adds in branches/safari-610.1.28.0-branch

Cherry-pick r265881. rdar://problem/67423220

REGRESSION(r265092): delegatesFocus causes WebKit to crash
https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

  • fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
  • fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:57 PM Changeset in webkit [265893] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r265775): DFG ASSERTION FAILED: AI-clobberize disagreement; AI says FoldedClobber while clobberize says (Direct:[], Super:[])
https://bugs.webkit.org/show_bug.cgi?id=215639
<rdar://problem/67376432>

Reviewed by Robin Morisset.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

12:49 PM Changeset in webkit [265892] by Alan Coon
  • 1 copy in branches/safari-610.2.2-branch

New branch.

12:46 PM Changeset in webkit [265891] by Tadeu Zagallo
  • 5 edits in trunk/Source/JavaScriptCore

B3 IntRange is incorrect for negative masks
https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

  • b3/B3ReduceStrength.cpp:
  • b3/testb3.h:
  • b3/testb3_1.cpp:

(run):

  • b3/testb3_5.cpp:

(testCheckSubBitAnd):

12:44 PM Changeset in webkit [265890] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

[iOS] Restore a 10_15_* user-agent string when requesting desktop site
https://bugs.webkit.org/show_bug.cgi?id=215657
<rdar://problem/67376157>

Reviewed by Tim Horton.

Reporting a major version of 11_0 causes numerous compatibility issues on websites that attempt to parse major
and minor versions from the user agent string. This partially reverts r263970, and replaces the string with
10_15_6, which matches the UA string of the latest shipped macOS version.

  • platform/ios/UserAgentIOS.mm:

(WebCore::standardUserAgentWithApplicationName):

12:19 PM Changeset in webkit [265889] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS wk1 ] svg/custom/object-sizing-no-width-height.xhtml is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215658

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
12:10 PM Changeset in webkit [265888] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Mark 3 webaudio WPT tests as flaky instead of consistently failing.

Those tests are for WebAudio automation, which we do not support. The values being printed
on failure sometimes differ.

12:03 PM Changeset in webkit [265887] by Alan Coon
  • 7 edits in branches/safari-610.1.28.3-branch

Apply patch. rdar://problem/67415363

11:59 AM Changeset in webkit [265886] by Alan Coon
  • 8 edits in branches/safari-610.1.28.3-branch/Source

Versioning.

WebKit-7610.1.28.3.1

11:47 AM Changeset in webkit [265885] by Jonathan Bedard
  • 3 edits in trunk/Tools

[webkitcorepy] Failure to set index should not be fatal
https://bugs.webkit.org/show_bug.cgi?id=215653
<rdar://problem/67410416>

Reviewed by Stephanie Lewis.

  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py:
  • Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall.set_index): By default, log an error instead of raising an exception if an index is unreachable.

11:36 AM Changeset in webkit [265884] by Alan Coon
  • 1 copy in branches/safari-610.1.28.3-branch

New branch.

11:35 AM Changeset in webkit [265883] by Jonathan Bedard
  • 70 edits
    2 deletes in trunk/Tools

[webkitpy] Adopt webkitcorepy's OutputCapture
https://bugs.webkit.org/show_bug.cgi?id=215628
<rdar://problem/67353710>

Reviewed by Dewei Zhu.

Remove webkitpy's OutputCapture in favor of webkitcorepy's. The refactor retains the orginal
functionality of the old OutputCapture, but deletes some now unused code.

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/net/ewsserver_unittest.py:
  • Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/common/system/outputcapture.py: Removed.
  • Scripts/webkitpy/common/system/outputcapture_unittest.py: Removed.
  • Scripts/webkitpy/common/system/stack_utils_unittest.py:
  • Scripts/webkitpy/common/system/user_unittest.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
  • Scripts/webkitpy/performance_tests/perftest_unittest.py:
  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  • Scripts/webkitpy/port/base_unittest.py:
  • Scripts/webkitpy/port/config_unittest.py:
  • Scripts/webkitpy/port/darwin_testcase.py:
  • Scripts/webkitpy/port/gtk_unittest.py:
  • Scripts/webkitpy/port/ios_device_unittest.py:
  • Scripts/webkitpy/port/ios_simulator_unittest.py:
  • Scripts/webkitpy/port/leakdetector_unittest.py:
  • Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
  • Scripts/webkitpy/port/mac_unittest.py:
  • Scripts/webkitpy/port/port_testcase.py:
  • Scripts/webkitpy/port/server_process_unittest.py:
  • Scripts/webkitpy/port/watch_simulator_unittest.py:
  • Scripts/webkitpy/port/westondriver_unittest.py:
  • Scripts/webkitpy/port/win_unittest.py:
  • Scripts/webkitpy/port/wpe_unittest.py:
  • Scripts/webkitpy/port/xvfbdriver_unittest.py:
  • Scripts/webkitpy/style/checkers/python.py:
  • Scripts/webkitpy/style/main_unittest.py:
  • Scripts/webkitpy/test/finder_unittest.py:
  • Scripts/webkitpy/test/main_unittest.py:
  • Scripts/webkitpy/test/printer.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:
  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/multicommandtool_unittest.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
  • Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/commit_unittest.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
  • Scripts/webkitpy/w3c/test_converter_unittest.py:
  • Scripts/webkitpy/w3c/test_importer_unittest.py:
  • Scripts/webkitpy/w3c/test_parser_unittest.py:
11:33 AM Changeset in webkit [265882] by Chris Dumez
  • 6 edits in trunk/Source/WebKit

REGRESSION (r261407): Sharing rich links from Twitter/Netflix via Messages is unreliable
https://bugs.webkit.org/show_bug.cgi?id=215656
<rdar://problem/67087352>

Reviewed by Tim Horton.

The WKWebView._clientNavigationsRunAtForegroundPriority SPI was not working for the
MessagesViewService because the view is unparented and PageClient::isApplicationVisible()
would not work return accurate results when [view window] returns nil. It is very
unfortunate to have to rely on the view or the view's window to determine application
visibility so this patch fixes this. We now rely on UIKit's visibility endowment to
determine if the UIProcess is visible, using RunningBoard API. I have verified that the
visibility endowment properly gets propagated from the host application to the view
service when the application is a view service and I have verified that this detects
the MessagesViewService as visible for the use-case at <rdar://problem/67087352>, which
causes the WKWebView._clientNavigationsRunAtForegroundPriority SPI to work as intended.

Note that when the application does not have the visibility endowment, we still allow
it to take a foreground assertion for client navigations if the process is allowed to
run in the background for an extended period of time, according to RunningBoard. This
allows the SPI to work for daemons (like maild) which rely on it.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptInFrameInScriptWorld):

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::canTakeForegroundAssertions):
(WebKit::PageClientImpl::isApplicationVisible): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::shouldForceForegroundPriorityForClientNavigation const):

11:14 AM Changeset in webkit [265881] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r265092): delegatesFocus causes WebKit to crash
https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

  • fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
  • fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.
11:07 AM Changeset in webkit [265880] by Jonathan Bedard
  • 3 edits in trunk/Tools

[webkitcorepy] Don't overwrite foreign packages by default
https://bugs.webkit.org/show_bug.cgi?id=215654
<rdar://problem/67411393>

Reviewed by Darin Adler.

  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.is_cached): Consider a package cached if it is foreign and overwrite_foreign_packages is false.
(AutoInstall): Add overwrite_foreign_packages flag.

10:28 AM Changeset in webkit [265879] by Alan Coon
  • 7 edits in branches/safari-610.1.28.0-branch

Apply patch. rdar://problem/67364254

10:28 AM Changeset in webkit [265878] by Alan Coon
  • 4 edits in branches/safari-610.1.28.0-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:28 AM Changeset in webkit [265877] by Alan Coon
  • 4 edits in branches/safari-610.1.28.0-branch

Cherry-pick r265812. rdar://problem/67364276

The CSS specificity of :host() pseudo-classes is wrong
https://bugs.webkit.org/show_bug.cgi?id=202494
<rdar://problem/66292568>

Reviewed by Anders Carlsson.

Source/WebCore:

https://drafts.csswg.org/css-scoping/#host-selector

“The specificity of :host() is that of a pseudo-class, plus the specificity of its argument.”

  • css/CSSSelector.cpp: (WebCore::simpleSelectorSpecificityInternal):

LayoutTests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:26 AM Changeset in webkit [265876] by Jonathan Bedard
  • 3 edits in trunk/Tools

[webkitcorepy] Correct autoinstaller logging
https://bugs.webkit.org/show_bug.cgi?id=215650
<rdar://problem/67408049>

Reviewed by Stephanie Lewis.

  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.install): Log "Downloading" insteading of "Installing" before downloading a package.

10:23 AM Changeset in webkit [265875] by Alan Coon
  • 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.1

10:21 AM Changeset in webkit [265874] by Alan Coon
  • 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.1

10:17 AM Changeset in webkit [265873] by Alan Coon
  • 7 edits in branches/safari-610.1.28.1-branch

Apply patch. rdar://problem/67370822

10:17 AM Changeset in webkit [265872] by Alan Coon
  • 4 edits in branches/safari-610.1.28.1-branch

Cherry-pick r265835. rdar://problem/67364262

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:17 AM Changeset in webkit [265871] by Alan Coon
  • 4 edits in branches/safari-610.1.28.1-branch

Cherry-pick r265812. rdar://problem/67364273

The CSS specificity of :host() pseudo-classes is wrong
https://bugs.webkit.org/show_bug.cgi?id=202494
<rdar://problem/66292568>

Reviewed by Anders Carlsson.

Source/WebCore:

https://drafts.csswg.org/css-scoping/#host-selector

“The specificity of :host() is that of a pseudo-class, plus the specificity of its argument.”

  • css/CSSSelector.cpp: (WebCore::simpleSelectorSpecificityInternal):

LayoutTests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:13 AM Changeset in webkit [265870] by Aditya Keerthi
  • 2 edits in trunk/Source/WebCore

Remove use of ControlSize in ThemeMac
https://bugs.webkit.org/show_bug.cgi?id=215651

Reviewed by Sam Weinig.

ThemeMac contains incorrectly mixes the use of Carbon's ControlSize
and AppKit's NSControlSize. This inconsistency went unnoticed as
ControlSize is a UInt16, and NSControlSize is an NSUInteger.

No new tests as there is no change in behavior.

  • platform/mac/ThemeMac.mm:

(WebCore::controlSizeFromPixelSize):

This method always returns an NSControlSize, but it's declared return
type is a ControlSize. Correct the declared return type.

(WebCore::setControlSize):
(WebCore::paintStepper):
(WebCore::ThemeMac::inflateControlPaintRect const):

10:07 AM Changeset in webkit [265869] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests/imported/w3c

Implement PerfomanceObserverInit.buffered
https://bugs.webkit.org/show_bug.cgi?id=214883

Patch by Rob Buis <rbuis@igalia.com> on 2020-08-19
Reviewed by Darin Adler.

Sync case-sensitivity.any.js which was upstreamed to WPT
a bit differently than in r265390 and specifically managed to
use one timeout instead of multiple, making it a faster test.

  • web-platform-tests/performance-timeline/case-sensitivity.any-expected.txt:
  • web-platform-tests/performance-timeline/case-sensitivity.any.js:

(async_test):

  • web-platform-tests/performance-timeline/case-sensitivity.any.worker-expected.txt:
10:07 AM Changeset in webkit [265868] by Alan Coon
  • 7 edits in branches/safari-610.1.28.2-branch

Apply patch. rdar://problem/67373871

9:59 AM Changeset in webkit [265867] by Alan Coon
  • 8 edits in branches/safari-610.1.28.2-branch/Source

Versioning.

WebKit-7610.1.28.2.1

9:55 AM Changeset in webkit [265866] by Jonathan Bedard
  • 10 edits in trunk/Tools

[webkitpy] Use webkitcorepy's auto installer for selenium
https://bugs.webkit.org/show_bug.cgi?id=215648
<rdar://problem/67405967>

Reviewed by Darin Adler.

  • Scripts/webkitpy/init.py:
  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:

(LinuxChromeDriver.launch_driver): Implicitly use webkitcorepy's auto-installer.

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:

(LinuxFirefoxDriver.launch_driver): Ditto.

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeDriver.launch_driver): Ditto.
(OSXChromeCanaryDriver.launch_driver): Ditto.

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:

(OSXFirefoxDriver.launch_driver): Ditto.
(OSXFirefoxNightlyDriver.launch_driver): Ditto.

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launch_driver): Ditto.

  • Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:

(WebDriverBenchmarkRunner._run_one_test): Ditto.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Remove selenium.
(AutoinstallImportHook._install_selenium): Deleted.

  • Scripts/webkitpy/webdriver_plt/liveplt.py: Implicitly use webkitcorepy's auto-installer.
9:30 AM Changeset in webkit [265865] by Alan Coon
  • 1 copy in branches/safari-610.1.28.2-branch

New branch.

9:30 AM Changeset in webkit [265864] by Alan Coon
  • 1 copy in branches/safari-610.1.28.1-branch

New branch.

9:30 AM Changeset in webkit [265863] by Alan Coon
  • 1 copy in branches/safari-610.1.28.0-branch

New branch.

9:20 AM Changeset in webkit [265862] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS ] accessibility/mac/select-element-selection-with-optgroups.html is a flaky failure

https://bugs.webkit.org/show_bug.cgi?id=215649

Unreviewed test gardening.

  • platform/mac/TestExpectations:
9:11 AM Changeset in webkit [265861] by Karl Rackler
  • 3 edits in trunk/LayoutTests

rdar://problem/65269589 [ Mac and iOS ] media/vp9.html is failing consistently.
Moved test expectation from only mac wk1 to mac.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
9:03 AM Changeset in webkit [265860] by Aditya Keerthi
  • 7 edits
    2 adds in trunk

[macOS] Move stepper painting code off of Carbon API
https://bugs.webkit.org/show_bug.cgi?id=215619
<rdar://problem/41936617>

Reviewed by Darin Adler.

Source/WebCore:

Use CoreUI and AppKit SPI to paint steppers. There are two benefits to
this new approach.

  1. The stepper now has an appropriate appearance in dark mode.
  1. We move away from using the outdated Carbon API.

Note that we still cannot use NSStepperCell to paint steppers, since it
is not possible to draw one with the up button highlighted. However, the
approach used in this patch is shared by NSStepperCell.

Test: fast/forms/number/number-dark-appearance.html

  • platform/mac/ThemeMac.mm:

(WebCore::paintStepper):

Source/WebCore/PAL:

Add forward declarations for CoreUI SPI on non-internal SDKs.

Also grouped declarations by key and value pairs.

  • pal/spi/mac/CoreUISPI.h:

LayoutTests:

Added a test to verify that the stepper appearance is different under dark mode.

  • TestExpectations:
  • fast/forms/number/number-dark-appearance-expected-mismatch.html: Added.
  • fast/forms/number/number-dark-appearance.html: Added.
  • platform/mac/TestExpectations:
8:50 AM Changeset in webkit [265859] by Lauro Moura
  • 2 edits in trunk/Source/WebCore

[WebXR] Remove uneeded assert

Rubber-stamped by Sergio Villar Senin

context being a Document is tracked by the downcast when capturing.
Fixes debug build error complaining about not capturing context.

Covered by existing tests.

  • Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::requestReferenceSpace):

8:44 AM Changeset in webkit [265858] by svillar@igalia.com
  • 4 edits in trunk

[css-flexbox] min-height:auto not updated after an image loads when the image has a specified height and width.
https://bugs.webkit.org/show_bug.cgi?id=210475

Reviewed by Javier Fernandez.

Source/WebCore:

The flex layout algorithm needs the item's intrinsic size even if it has a specified size, that's
why the flex item size should be recomputed in the event of changes in its intrinsic size.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange): set the needs layout flag
also for replaced elements which happen to be flex items.

LayoutTests:

8:39 AM Changeset in webkit [265857] by achristensen@apple.com
  • 2 edits in trunk/Tools

[Catalina/iOS 13] TestWebKitAPI.TLSVersion.LegacySubresources is failing
https://bugs.webkit.org/show_bug.cgi?id=215640

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

This tests behavior using CFNetwork functionality which is only available to Big Sur, iOS 14, and updated versions of Catalina.

8:39 AM Changeset in webkit [265856] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

WebSocketChannel::didClose should correctly compute whether a closing handshake was received
https://bugs.webkit.org/show_bug.cgi?id=215644

Reviewed by Darin Adler.

Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled.

  • WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::didClose):
As noted by Jiten Mehta, absence of closing handshake from the server is notified by WebSocketChannel::CloseEventCodeAbnormalClosure.
Update check accordingly.

8:34 AM Changeset in webkit [265855] by svillar@igalia.com
  • 4 edits in trunk

[css-flexbox] Apply aspect ratios when computing flex-basis
https://bugs.webkit.org/show_bug.cgi?id=215570

Reviewed by Javier Fernandez.

Source/WebCore:

Aspect ratios (clamped by min/max restrictions) should be considered when computing flex-basis.

Based on Blink's crrev.com/c/1525444 & crrev.com/c/1672014 by <cbiesinger@chromium.org>

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeInnerFlexBaseSizeForChild):

LayoutTests:

8:02 AM Changeset in webkit [265854] by youenn@apple.com
  • 8 edits
    2 adds in trunk

Optimise resolution of promises with values in ReadableStream implementation
https://bugs.webkit.org/show_bug.cgi?id=215557
<rdar://problem/66828616>

Reviewed by Yusuke Suzuki.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/response/response-stream-with-broken-then.any-expected.txt:
  • web-platform-tests/fetch/api/response/response-stream-with-broken-then.any.worker-expected.txt:

Remaining test failure will be handled as part of pipeTo algorithm refresh.

Source/WebCore:

Instead of going through the slow @Promise.@resolve, we can directly use @fulfillPromise which is faster.
To make things consistent, we move from @newPromiseCapability to @newPromise.
Test: streams/readableStream-then.html

  • Modules/streams/ReadableByteStreamInternals.js:

(readableByteStreamControllerPull):
(readableStreamFulfillReadIntoRequest):
(readableByteStreamControllerPullInto):

  • Modules/streams/ReadableStreamInternals.js:

(readableStreamDefaultControllerPull):
(readableStreamClose):
(readableStreamFulfillReadRequest):
(readableStreamDefaultReaderRead):

  • Modules/streams/StreamInternals.js:

(createFulfilledPromise):

LayoutTests:

  • streams/readableStream-then-expected.txt: Added.
  • streams/readableStream-then.html: Added.
7:54 AM Changeset in webkit [265853] by Karl Rackler
  • 4 edits in trunk/LayoutTests

rdar://67353771 ([run-webkit-tests] Rosetta specific test expectations)
Placing original test expectations back in place and adding Rosetta specific expectations

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
7:46 AM Changeset in webkit [265852] by Lauro Moura
  • 7 edits
    1 delete in trunk/LayoutTests

[WPE] Gardening and rebaseline touch tests

Unreviewed test gardening.

LayoutTests/imported/w3c:

Move some WPE-specific baselines here as it is only tested there.

Also rebaseline after r265749 updated some constructor rules.

  • web-platform-tests/touch-events/historical-expected.txt:
  • web-platform-tests/touch-events/idlharness.window-expected.txt:
  • web-platform-tests/touch-events/touch-retargeting-expected.txt:
  • web-platform-tests/touch-events/touch-touchevent-constructor-expected.txt:

LayoutTests:

Updated some baselines in the toplevel directory as only WPE is
running them.

  • platform/glib/TestExpectations:
  • platform/wpe/imported/w3c/web-platform-tests/touch-events/historical-expected.txt: Removed.
  • platform/wpe/imported/w3c/web-platform-tests/touch-events/idlharness.window-expected.txt: Removed.
6:33 AM Changeset in webkit [265851] by svillar@igalia.com
  • 6 edits
    6 deletes in trunk

<button> should support display:inline-grid/grid/inline-flex/flex correctly
https://bugs.webkit.org/show_bug.cgi?id=209656

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Replaced FAIL expectation by PASS one. Both tests should pass now with no failures.

  • web-platform-tests/html/rendering/widgets/button-layout/flex-expected.txt:
  • web-platform-tests/html/rendering/widgets/button-layout/grid-expected.txt:

Source/WebCore:

Button elements with display type (inline-) flex or grid should be laid out as their
display type states and not as buttons. That's mentioned in the HTML spec here
https://html.spec.whatwg.org/multipage/rendering.html#button-layout.

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::createElementRenderer): let HTMLFormControlElement create
a renderer instead of using a RenderButton whenever display is (inline-)grid/flex.

LayoutTests:

  • platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/flex-expected.txt: Removed.
  • platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/grid-expected.txt: Removed.
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/flex-expected.txt: Removed.
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/grid-expected.txt: Removed.
  • platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/flex-expected.txt: Removed.
  • platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/grid-expected.txt: Removed.
6:11 AM Changeset in webkit [265850] by svillar@igalia.com
  • 5 edits in trunk/Source/WebCore

[WebXR] Make "in parallel" code run really in parallel
https://bugs.webkit.org/show_bug.cgi?id=215642

Reviewed by Carlos Garcia Campos.

As the HTML spec mentions https://html.spec.whatwg.org/multipage/infrastructure.html#in-parallel
"in parallel" means that the task should be run in parallel to the event loop using any available
mechanism (threads, processess...). We were instead queueing those tasks to be run in the main
thread causing freezes while initializing the whole OpenXR machinery.

  • Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::WebXRSession): create a WorkQueue.
(WebCore::WebXRSession::requestReferenceSpace): Dispatch to the work queue.

  • Modules/webxr/WebXRSession.h:
  • Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::WebXRSystem): create a WorkQueue.
(WebCore::WebXRSystem::isSessionSupported): Dispatch to the work queue.
(WebCore::WebXRSystem::requestSession): Ditto.

  • Modules/webxr/WebXRSystem.h:
2:12 AM Changeset in webkit [265849] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Skip more tests using plugins after r265753.

  • platform/gtk/TestExpectations:

Aug 18, 2020:

9:03 PM Changeset in webkit [265848] by Lauro Moura
  • 4 edits in trunk/LayoutTests

[GTK][WPE] Gardening

Unreviewed test gardening.

  • platform/glib/TestExpectations:
  • platform/wpe/TestExpectations:
  • platform/wpe/webgl/1.0.3/conformance/context/methods-expected.txt:

Rebaselined after r265711.

8:15 PM Changeset in webkit [265847] by Hector Lopez
  • 6 edits in trunk/LayoutTests

[ macOS iOS ] fast/text/emoji-gender* text expectations change
https://bugs.webkit.org/show_bug.cgi?id=215636

Unreviewed test gardening.

  • TestExpectations:
  • platform/glib/TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
7:34 PM Changeset in webkit [265846] by Jonathan Bedard
  • 5 edits
    1 add in trunk

[run-webkit-tests] Rosetta specific test expectations
https://bugs.webkit.org/show_bug.cgi?id=215633
<rdar://problem/67353771>

Reviewed by Darin Adler.

Tools:

  • Scripts/webkitpy/port/mac.py:

(MacPort.expectations_dict): Add special case for Rosetta expectations.

  • Scripts/webkitpy/port/mac_unittest.py:

(MacTest.test_rosetta_expectations):

LayoutTests:

  • platform/mac/TestExpectations: Move Rosetta expectations.
  • platform/mac/TestExpectationsRosetta: Added.
7:24 PM Changeset in webkit [265845] by Chris Dumez
  • 5 edits in trunk

AudioBuffer.duration should use double precision
https://bugs.webkit.org/show_bug.cgi?id=215632

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-expected.txt:

Source/WebCore:

AudioBuffer.duration should use double precision:

No new tests, rebaselined existing test.

  • Modules/webaudio/AudioBuffer.h:

(WebCore::AudioBuffer::duration const):

  • Modules/webaudio/AudioBuffer.idl:
6:28 PM Changeset in webkit [265844] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Rename replaceAllChildren to replaceAllChildrenWithNewText
https://bugs.webkit.org/show_bug.cgi?id=215634

Reviewed by Darin Adler.

Renamed ContainerNode::replaceAllChildren to replaceAllChildrenWithNewText and changed
the type of Argument from Ref<Node>&& to const String&.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAllChildrenWithNewText):

  • dom/ContainerNode.h:
  • dom/Node.cpp:

(WebCore::Node::setTextContent):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):

5:59 PM Changeset in webkit [265843] by Alan Coon
  • 1 copy in tags/Safari-610.1.28

Tag Safari-610.1.28.

5:54 PM Changeset in webkit [265842] by Andres Gonzalez
  • 12 edits in trunk

Fix for accessibility/mac/aria-expanded-notifications.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=215613

Reviewed by Darin Adler.

Source/WebCore:

Test: accessibility/mac/aria-expanded-notifications.html.

Refactored AXObjectCache::handleAriaExpandedChange so that it doesn't
call into AccessibilityObject to handle the notification, to then call
into AXObjectCache again. The new implementation is cleaner and more
straightforward.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::updateIsolatedTree): Updates the isolated tree
on the row expanded/collapsed-related notifications.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsRowCountChange const): Added.

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityObjectInterface.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
Deleted, not needed any longer since it is handled in AXObjectCache where
it should.

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData): Caches the
supportsRowCountChange property.
(WebCore::AXIsolatedObject::handleAriaExpandedChanged): Deleted, not
needed any longer.

  • accessibility/isolatedtree/AXIsolatedObject.h:

LayoutTests:

  • accessibility/mac/aria-expanded-notifications-expected.txt:
  • accessibility/mac/aria-expanded-notifications.html: Removed unnecessary

call to accessibilityController.focusedElement. Some code cleanup.

4:49 PM Changeset in webkit [265841] by commit-queue@webkit.org
  • 33 edits in trunk

[WebGL2] Various parameters should be non-nullable in IDL
https://bugs.webkit.org/show_bug.cgi?id=215616

Patch by James Darpinian <James Darpinian> on 2020-08-18
Reviewed by Kenneth Russell.

Source/WebCore:

Fixes 5 conformance tests:
conformance/misc/error-reporting.html
conformance/misc/null-object-behaviour.html
conformance/misc/bad-arguments-test.html
conformance/textures/misc/tex-sub-image-2d-bad-args.html
conformance/programs/get-active-test.html

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::attachShader):
(WebCore::WebGLRenderingContextBase::bindAttribLocation):
(WebCore::WebGLRenderingContextBase::compileShader):
(WebCore::WebGLRenderingContextBase::detachShader):
(WebCore::WebGLRenderingContextBase::getActiveAttrib):
(WebCore::WebGLRenderingContextBase::getActiveUniform):
(WebCore::WebGLRenderingContextBase::getAttachedShaders):
(WebCore::WebGLRenderingContextBase::getAttribLocation):
(WebCore::WebGLRenderingContextBase::getProgramParameter):
(WebCore::WebGLRenderingContextBase::getProgramInfoLog):
(WebCore::WebGLRenderingContextBase::getShaderParameter):
(WebCore::WebGLRenderingContextBase::getShaderInfoLog):
(WebCore::WebGLRenderingContextBase::getShaderSource):
(WebCore::WebGLRenderingContextBase::getUniform):
(WebCore::WebGLRenderingContextBase::getUniformLocation):
(WebCore::WebGLRenderingContextBase::linkProgram):
(WebCore::WebGLRenderingContextBase::shaderSource):
(WebCore::WebGLRenderingContextBase::validateProgram):

  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGLRenderingContextBase.idl:
  • inspector/InspectorShaderProgram.cpp:

(WebCore::InspectorShaderProgram::updateShader):

LayoutTests:

  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost.html:
  • fast/canvas/webgl/error-reporting-expected.txt:
  • fast/canvas/webgl/error-reporting.html:
  • fast/canvas/webgl/get-active-test-expected.txt:
  • fast/canvas/webgl/get-active-test.html:
  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html:
  • fast/canvas/webgl/null-object-behaviour-expected.txt:
  • fast/canvas/webgl/null-object-behaviour.html:
  • inspector/canvas/recording-webgl-frameCount.html:
  • inspector/canvas/recording-webgl-full-expected.txt:
  • inspector/canvas/recording-webgl-full.html:
  • inspector/canvas/recording-webgl-memoryLimit.html:
  • inspector/canvas/recording-webgl-snapshots.html:
  • inspector/canvas/recording-webgl2-frameCount.html:
  • inspector/canvas/recording-webgl2-full.html:
  • inspector/canvas/recording-webgl2-memoryLimit.html:
  • inspector/canvas/recording-webgl2-snapshots.html:
  • inspector/canvas/resources/recording-webgl.js:

(load):

  • webgl/2.0.0/conformance/misc/bad-arguments-test-expected.txt:
  • webgl/2.0.0/conformance/misc/error-reporting-expected.txt:
  • webgl/2.0.0/conformance/misc/null-object-behaviour-expected.txt:
  • webgl/2.0.0/conformance/programs/get-active-test-expected.txt:
  • webgl/2.0.0/conformance/state/gl-object-get-calls-expected.txt:
  • webgl/2.0.0/conformance/textures/misc/tex-sub-image-2d-bad-args-expected.txt:
  • webgl/2.0.0/conformance2/state/gl-object-get-calls-expected.txt:
4:44 PM Changeset in webkit [265840] by ysuzuki@apple.com
  • 2 edits in trunk/Tools

Unreviewed, contributors.json is broken

  • Scripts/webkitpy/common/config/contributors.json:
4:22 PM Changeset in webkit [265839] by dino@apple.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Adding some Google folks to contributors.

  • Scripts/webkitpy/common/config/contributors.json:
4:15 PM Changeset in webkit [265838] by Chris Dumez
  • 5 edits in trunk

PannerNode's rolloffFactor should be clamped to [0, 1] internally when distanceModel is "linear"
https://bugs.webkit.org/show_bug.cgi?id=215625

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:

Source/WebCore:

PannerNode's rolloffFactor should be clamped to [0, 1] internally when distanceModel is "linear":

No new tests, rebaselined existing test.

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::setRolloffFactor):

  • platform/audio/Distance.cpp:

(WebCore::DistanceEffect::linearGain):

4:01 PM Changeset in webkit [265837] by Darin Adler
  • 2 edits in trunk/Websites/webkit.org
  • languages.md: Fixed "Movaje" typo.
3:51 PM Changeset in webkit [265836] by Chris Dumez
  • 4 edits in trunk

ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext
https://bugs.webkit.org/show_bug.cgi?id=215624

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

  • web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:

Source/WebCore:

ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext.
If the context is an OfflineAudioContext, then it should pause processing until the script has finished
execution. This aligns our behavior with Blink and helps us pass more WPT tests.

No new tests, rebaselined existing test.

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):

3:18 PM Changeset in webkit [265835] by commit-queue@webkit.org
  • 4 edits in trunk

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(TestWebKitAPI::TEST):

2:44 PM Changeset in webkit [265834] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[Catalyst] Video should pause automatically when switching desktops
https://bugs.webkit.org/show_bug.cgi?id=215620

Reviewed by Jer Noble.

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm: Don't override resetRestrictions

on Catalyst so we don't pause video in the background.

2:24 PM Changeset in webkit [265833] by commit-queue@webkit.org
  • 11 edits
    1 copy
    4 adds in trunk

[WebGL2] Pass user-defined-properties-on-context.html layout test
https://bugs.webkit.org/show_bug.cgi?id=215433

Patch by Kenneth Russell <kbr@chromium.org> on 2020-08-18
Reviewed by Yusuke Suzuki.

Source/WebCore:

Keep the canvas' rendering context alive from the canvas itself by
adding a custom mark function for HTMLCanvasElement, and adding a
new GenerateIsReachable=ImplCanvasBase extended IDL attribute,
used from all rendering context types (2D, WebGL, and WebGPU).

This patch does not touch OffscreenCanvas since the implementation
there seems to be incomplete and there are no associated tests of
GC behavior.

Tests: fast/canvas/2d.context.expando.html

webgpu/expando-properties.html

  • Modules/webgpu/GPUCanvasContext.idl:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: Copied from Source/WebCore/html/canvas/WebGLRenderingContext.idl.

(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.json:
  • html/HTMLCanvasElement.idl:
  • html/canvas/WebGL2RenderingContext.idl:
  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

Rebaseline user-defined-properties-on-context.html, which is now
fully passing.

Add tests of expando properties on 2D and WebGPU contexts. Add a
FIXME to the WebGPU test, as that specification no longer defines
a canvas rendering context.

  • fast/canvas/2d.context.expando-expected.txt: Added.
  • fast/canvas/2d.context.expando.html: Added.
  • webgl/2.0.0/conformance/context/user-defined-properties-on-context-expected.txt:
  • webgpu/expando-properties-expected.txt: Added.
  • webgpu/expando-properties.html: Added.
2:13 PM Changeset in webkit [265832] by Chris Dumez
  • 4 edits in trunk

WaveShaperNode.curve setter should create a copy of the input array
https://bugs.webkit.org/show_bug.cgi?id=215615

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that all checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

Source/WebCore:

WaveShaperNode.curve setter should create a copy of the input array, so that follow-up modifications
of the array by the JS do not impact audio processing:

No new tests, rebaselined existing test.

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::setCurve):

1:58 PM Changeset in webkit [265831] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r262381): replaceChildren should not use DeferChildrenChanged::No
https://bugs.webkit.org/show_bug.cgi?id=215600

Reviewed by Antti Koivisto.

It's not correct to use DeferChildrenChanged::No when the new node may have an old parent.
Use DeferChildrenChanged::Yes instead.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAllChildren): Added a release assertion to make sure
people don't start using this function incorrectly in the future.
(WebCore::ContainerNode::replaceChildren): Fixed the bug.

1:46 PM Changeset in webkit [265830] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Update byte offsets in JSString.h comment
https://bugs.webkit.org/show_bug.cgi?id=215621

Reviewed by Yusuke Suzuki.

  • runtime/JSString.h:
1:22 PM Changeset in webkit [265829] by Karl Rackler
  • 2 edits in trunk/LayoutTests

Disable plug-in tests on Apple Silicon
Updating test expectation in include Rosetta

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:12 PM Changeset in webkit [265828] by Karl Rackler
  • 2 edits in trunk/LayoutTests

rdar://66861801 ([ Layout Tests] REGRESSION (r265487): svg/W3C-I18N/tspan-direction-rtl.svg is a constant failure)
Updating expectations in include Rosetta.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
1:07 PM Changeset in webkit [265827] by Darin Adler
  • 1 edit
    1 add in trunk/Websites/webkit.org

Document versions of C++ and Python
https://bugs.webkit.org/show_bug.cgi?id=215191

Reviewed by Jonathan Bedard.

  • languages.md: Added.
10:53 AM Changeset in webkit [265826] by Hector Lopez
  • 2 edits in trunk/LayoutTests

REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215614

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:08 AM Changeset in webkit [265825] by Karl Rackler
  • 2 edits in trunk/LayoutTests

rdar://67289434 ([ Rosetta Layout Tests ] REGRESSION (r265701): [ BigSur ] 3 webaudio/the-audio-api/the-audioparam-interface tests are a constant failure)
Should skip this only on Rosetta, not all Intel Big Sur Macs

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:00 AM Changeset in webkit [265824] by Chris Dumez
  • 11 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline webaudio WPT tests that are marked as flaky.

  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:
9:59 AM Changeset in webkit [265823] by Simon Fraser
  • 9 edits in trunk

Turn off wheel event regions until we need them
https://bugs.webkit.org/show_bug.cgi?id=215586

Reviewed by Darin Adler.
Source/WebCore:

Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.

  • page/scrolling/ScrollingTree.cpp:
  • page/scrolling/ScrollingTree.h:
  • page/scrolling/mac/ScrollingTreeMac.h:
  • page/scrolling/mac/ScrollingTreeMac.mm:

Source/WTF:

Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.

  • wtf/PlatformEnableCocoa.h:

LayoutTests:

Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.

  • platform/mac-wk2/TestExpectations:
9:56 AM Changeset in webkit [265822] by youenn@apple.com
  • 8 edits in trunk

Update platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html to account for low latency code path
https://bugs.webkit.org/show_bug.cgi?id=215601

Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing/updated test.

  • testing/Internals.cpp:

(WebCore::Internals::supportsVCPEncoder):
In case low latency code path is enabled, supportsVCPEncoder should return true.

LayoutTests:

Update test to check software encoder for both baseline and high profiles.
Move baseline/high profile selection routines to routines.js.

  • platform/mac/webrtc/captureCanvas-webrtc-software-encoder-expected.txt:
  • platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:
  • webrtc/h264-baseline.html:
  • webrtc/h264-high.html:
  • webrtc/routines.js:
9:49 AM Changeset in webkit [265821] by Karl Rackler
  • 2 edits in trunk/LayoutTests

rdar://67281310 REGRESSION (r265639): [ BigSur ] 11 canvas layout tests are a constant failure)
Should skip this only on Rosetta, not all Intel Big Sur Macs
Clean up arm64 only gardening.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
9:36 AM Changeset in webkit [265820] by Simon Fraser
  • 16 edits
    1 copy
    1 add in trunk

REGRESSION (Async overflow scrolling): No rubberbanding in overflow:scroll in the wheel event region
https://bugs.webkit.org/show_bug.cgi?id=215598
<rdar://problem/64895442>

Reviewed by Darin Adler.
Source/WebCore:

Scrolling in overflow:scroll inside the non-fast event region (e.g. inside an ancestor with a wheel event
handler) happens via ScrollAnimatorMac::handleWheelEvent() which calls ScrollableArea::setScrollOffsetFromAnimation()
which bounces to the scrolling thread via RenderLayer::requestScrollPositionUpdate(). We were clamping the
scroll offset here, thus disallowing the overscrolled offsets required for rubberbanding.

Fix is to allow clamping for user scrolls. Also add more logging.

Test: fast/scrolling/mac/rubberband-overflow-in-wheel-region.html

  • dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleWheelEvent):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

LayoutTests:

Remove an unneeded var successfullyParsed = true in existing tests.

New test that detect rubberbanding.

  • fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html:
  • fast/scrolling/mac/async-scroll-overflow-rtl.html:
  • fast/scrolling/mac/async-scroll-overflow-top-inset.html:
  • fast/scrolling/mac/async-scroll-overflow.html:
  • fast/scrolling/mac/hit-test-overflow-tiled-layer.html:
  • fast/scrolling/mac/move-node-in-overflow-scroll.html:
  • fast/scrolling/mac/overflow-scrolled-document.html:
  • fast/scrolling/mac/overflow-zoomed-document.html:
  • fast/scrolling/mac/overlapped-overflow-scroll.html:
  • fast/scrolling/mac/rubberband-overflow-in-wheel-region-expected.txt: Added.
  • fast/scrolling/mac/rubberband-overflow-in-wheel-region.html: Copied from LayoutTests/fast/scrolling/mac/overflow-scrolled-document.html.
9:31 AM Changeset in webkit [265819] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, null-deref fix after r265797.

MockAudioDestinationCocoa::tick() is calling AudioDestinationCocoa::inputProc()
with a null AudioTimeStamp struct so we need to deal with this.

  • platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestinationCocoa::render):

9:20 AM Changeset in webkit [265818] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS Mojave wk2 Debug ] fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215611

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:04 AM Changeset in webkit [265817] by aakash_jain@apple.com
  • 3 edits
    2 adds in trunk/Tools

Develop a mechanism to unsubscribe from ews emails
https://bugs.webkit.org/show_bug.cgi?id=215585

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/emails.json: Added.
  • BuildSlaveSupport/ews-build/send_email.py:

(get_email_ids):
(send_email_to_patch_author): Do not email patch authors whose email is in unsubscribe list.
(send_email_to_bot_watchers):

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_new_build_failure):
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures):

  • BuildSlaveSupport/ews-build/email_unittest.py: Added unit-tests.

(EmailsDotJSONTest.test_valid_emails_json):
(EmailsDotJSONTest.test_emails_json_required_categories_present):

9:01 AM Changeset in webkit [265816] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit

[Mac] Unhandled keyDown: events cause a system beep in full screen mode
https://bugs.webkit.org/show_bug.cgi?id=215596
<rdar://problem/65823962>

Reviewed by Darin Adler.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController noResponderFor:]):

8:39 AM Changeset in webkit [265815] by Hector Lopez
  • 3 edits in trunk/LayoutTests

[ macOS wk1 iOS ] imported/w3c/web-platform-tests/IndexedDB/transaction_bubble-and-capture.htm is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215608

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac-wk1/TestExpectations:
8:16 AM Changeset in webkit [265814] by youenn@apple.com
  • 3 edits in trunk/Source/WebKit

NetworkSocketChannel should delay sending back error message as done by NetworkSocketStream
https://bugs.webkit.org/show_bug.cgi?id=215563

Reviewed by Alex Christensen.

Apply same policy as NetworkSocketStream in case of WebSocket connection error.
Covered by http/tests/websocket/tests/hybi/closed-port-delay.html with NSURLSession WebSocket code path.

  • NetworkProcess/NetworkSocketChannel.cpp:

(WebKit::NetworkSocketChannel::NetworkSocketChannel):
(WebKit::NetworkSocketChannel::didClose):
(WebKit::NetworkSocketChannel::didReceiveMessageError):
(WebKit::NetworkSocketChannel::sendDelayedError):

  • NetworkProcess/NetworkSocketChannel.h:
8:09 AM Changeset in webkit [265813] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ] webgpu/whlsl/do-while-loop-break.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215606

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
7:45 AM Changeset in webkit [265812] by Antti Koivisto
  • 4 edits in trunk

The CSS specificity of :host() pseudo-classes is wrong
https://bugs.webkit.org/show_bug.cgi?id=202494
<rdar://problem/66292568>

Reviewed by Anders Carlsson.

Source/WebCore:

https://drafts.csswg.org/css-scoping/#host-selector

“The specificity of :host() is that of a pseudo-class, plus the specificity of its argument.”

  • css/CSSSelector.cpp:

(WebCore::simpleSelectorSpecificityInternal):

LayoutTests:

2:54 AM Changeset in webkit [265811] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update test baseline after r265749.

  • platform/gtk/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
1:45 AM Changeset in webkit [265810] by youenn@apple.com
  • 5 edits in trunk/Source/WebCore

Add a JS built-in routine to mark a promise as handled
https://bugs.webkit.org/show_bug.cgi?id=215558

Reviewed by Darin Adler.

Wrap long line of code inside a method to ease code readability.
No change of behavior.

  • Modules/streams/ReadableStream.js:

(pipeThrough):

  • Modules/streams/ReadableStreamInternals.js:

(readableStreamError):
(readableStreamReaderGenericRelease):

  • Modules/streams/StreamInternals.js:

(markPromiseAsHandled):
(shieldingPromiseResolve):

  • Modules/streams/WritableStreamInternals.js:

(setUpWritableStreamDefaultWriter):
(writableStreamRejectCloseAndClosedPromiseIfNeeded):
(writableStreamDefaultWriterEnsureClosedPromiseRejected):
(writableStreamDefaultWriterEnsureReadyPromiseRejected):

1:03 AM Changeset in webkit [265809] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GLib gardening. Skip more tests using plugins after r265753

  • platform/glib/TestExpectations:
Note: See TracTimeline for information about the timeline view.