Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 19, 2020:

11:40 PM Changeset in webkit [268715] by Ross Kirsling

• 8 edits in trunk/Source/JavaScriptCore

%TypedArray%#sort helper functions should be globalPrivate
​https://bugs.webkit.org/show_bug.cgi?id=217928

Reviewed by Yusuke Suzuki and Alexey Shvayka.

Following r267827, this patch ensures that %TypedArray%.prototype.sort's helper functions:

1. use parameters instead of capturing variables
2. are converted from local functions to globalPrivate ones

To this end, also expose Math.min as a link-time constant.

• builtins/ArrayPrototype.js:

(globalPrivate.sortMerge):
(globalPrivate.sortMin): Deleted.

• builtins/BuiltinNames.h:
• builtins/TypedArrayPrototype.js:

(globalPrivate.typedArrayElementCompare): Added.
(globalPrivate.typedArrayMerge): Added.
(globalPrivate.typedArrayMergeSort): Added.
(sort):
(sort.min): Deleted.
(sort.merge): Deleted.
(sort.mergeSort): Deleted.

• bytecode/LinkTimeConstant.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/MathObject.cpp:
• runtime/MathObject.h:

11:20 PM Changeset in webkit [268714] by graouts@webkit.org

• 3 edits in trunk/Source/WebCore

TranslateTransformOperation shouldn't take in a FloatSize to convert z as a double
​https://bugs.webkit.org/show_bug.cgi?id=217246

Reviewed by Darin Adler.

The method used to get z as a double didn't use the FloatSize parameter, so we remove it. Since there already is a z()
method without an argument returning the underlying Length, we rename the method returning a double to make it clear
what type of value it's returning a double, and given how the call sites converts to a float eventually, we return
a float directly. We also follow the same pattern for x and y.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::getTransformFunctionValue):

• platform/graphics/transforms/TranslateTransformOperation.h:

8:45 PM Changeset in webkit [268713] by sihui_liu@apple.com

• 6 edits
  21 adds in trunk/LayoutTests

Import speech tests from WPT
​https://bugs.webkit.org/show_bug.cgi?id=217910

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• web-platform-tests/speech-api/META.yml: Added.
• web-platform-tests/speech-api/SpeechRecognition-basics.https-expected.txt: Added.
• web-platform-tests/speech-api/SpeechRecognition-basics.https.html: Added.
• web-platform-tests/speech-api/SpeechSynthesis-speak-ownership-expected.txt: Added.
• web-platform-tests/speech-api/SpeechSynthesis-speak-ownership.html: Added.
• web-platform-tests/speech-api/SpeechSynthesis-speak-twice-expected.txt: Added.
• web-platform-tests/speech-api/SpeechSynthesis-speak-twice.html: Added.
• web-platform-tests/speech-api/SpeechSynthesis-speak-with-activation-succeeds-expected.txt: Added.
• web-platform-tests/speech-api/SpeechSynthesis-speak-with-activation-succeeds.html: Added.
• web-platform-tests/speech-api/SpeechSynthesis-speak-without-activation-fails.tentative-expected.txt: Added.
• web-platform-tests/speech-api/SpeechSynthesis-speak-without-activation-fails.tentative.html: Added.
• web-platform-tests/speech-api/SpeechSynthesisUtterance-basics.https-expected.txt: Added.
• web-platform-tests/speech-api/SpeechSynthesisUtterance-basics.https.html: Added.
• web-platform-tests/speech-api/historical-expected.txt: Added.
• web-platform-tests/speech-api/historical.html: Added.
• web-platform-tests/speech-api/idlharness.window-expected.txt: Added.
• web-platform-tests/speech-api/idlharness.window.html: Added.
• web-platform-tests/speech-api/idlharness.window.js: Added.
• web-platform-tests/speech-api/w3c-import.log: Added.
• web-platform-tests/speech-api/webspeech.js: Added.

(typeof):
(reco.onstart.onstartTest.step_func):
(reco.onend):
(neverFireEvent):
(this.count):
(this.test):
(this.done):
(CycleTest.this.startEvent):
(CycleTest.this.endEvent):
(CycleTest.this.done):
(CycleTest):

LayoutTests:

• TestExpectations:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

8:45 PM Changeset in webkit [268712] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Fix crash in RenderLayerBacking::updateClippingStackLayerGeometry()
​https://bugs.webkit.org/show_bug.cgi?id=217940
<rdar://problem/70316952>

Reviewed by Tim Horton.

Crash data suggest that entry.clipData.clippingLayer (which is a WeakRef<RenderLayer>)
can be null, so check it.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateClippingStackLayerGeometry):

7:52 PM Changeset in webkit [268711] by Peng Liu

• 2 edits in trunk/Source/WebKit

Two feature flag names are incorrect
​https://bugs.webkit.org/show_bug.cgi?id=217913

Reviewed by Eric Carlson.

• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCaptureAudioInGPUProcessEnabled): The correct feature flag
is gpu_process_media.
(WebKit::defaultVP9SWDecoderEnabledOnBattery): The correct feature flag
is sw_vp9_decoder_on_battery.

7:49 PM Changeset in webkit [268710] by Alexey Shvayka

• 92 edits
  3 adds in trunk

[WebIDL] %Interface%.prototype.constructor should be defined on Set? receiver
​https://bugs.webkit.org/show_bug.cgi?id=216533

Reviewed by Darin Adler.

JSTests:

• stress/custom-get-set-proto-chain-put.js: Added.

LayoutTests/imported/w3c:

• web-platform-tests/WebIDL/ecmascript-binding/interface-prototype-constructor-set-receiver-expected.txt: Added.
• web-platform-tests/WebIDL/ecmascript-binding/interface-prototype-constructor-set-receiver.html: Added.

Source/JavaScriptCore:

Before this change, a Set? performed on an %Interface% instance used to overwrite
%Interface%.prototype.constructor instead of defining own "constructor" property.

Since using CustomValue is essential for lazy initialization of WebIDL constructors,
and forwarding Set? with correct receiver would require further diverging
CustomValue setter signature from CustomAccessor counterpart, this patch makes a
CustomValue property without a setter to be treated as a data descriptor [1].

This avoids generating a "constructor" setter for every exposed WebIDL interface and
making an extra put() dispatch in putInlineSlow(). Changing the semantics is safe
because there were no setter-less CustomValue properties before this patch.

[1]: ​https://tc39.es/ecma262/#sec-ordinarysetwithowndescriptor (step 3.e.ii)

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

• runtime/CustomGetterSetter.cpp:

(JSC::callCustomSetter):

• runtime/CustomGetterSetter.h:
• runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitive): Add missing exception check.

• runtime/JSCustomGetterSetterFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

• runtime/JSObject.cpp:

(JSC::JSObject::putInlineSlow):

• runtime/Lookup.h:

(JSC::putEntry):

• runtime/PropertySlot.cpp:

(JSC::PropertySlot::customGetter const):

• runtime/PropertySlot.h:
• tools/JSDollarVM.cpp:

Source/WebCore:

1. Create a setter-less CustomGetterSetter instead of generating "constructor" setter.
2. Remove unused $needsConstructorTable variable.
3. Remove [LegacyNoInterfaceObject] branch as it's precluded by NeedsConstructorProperty.

Test: imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/interface-prototype-constructor-set-receiver.html

• bindings/scripts/CodeGeneratorJS.pm:

(GeneratePropertiesHashTable):
(GenerateImplementation):

• bindings/scripts/test/JS/*: Updated.

7:25 PM Changeset in webkit [268709] by Alexey Shvayka

• 6 edits in trunk

[WebIDL] convertRecord() should handle duplicate keys for USVString records
​https://bugs.webkit.org/show_bug.cgi?id=217612

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• web-platform-tests/url/urlsearchparams-constructor.any-expected.txt:
• web-platform-tests/url/urlsearchparams-constructor.any.js:
• web-platform-tests/url/urlsearchparams-constructor.any.worker-expected.txt:

Source/WebCore:

Before this patch, due to unpaired surrogates replacement in stringToUSVString(),
convertRecord() could append the same key multiple times, violating the spec [1].

This change adds duplicate handling while preserving common case performance,
and aligns WebKit with Blink and Gecko. Since a Proxy object can no longer return
duplicate keys [2], only USVString records needed to be fixed.

Test: imported/w3c/web-platform-tests/url/urlsearchparams-constructor.any.html

[1] ​https://heycam.github.io/webidl/#es-record (step 4.2.4 + example below)
[2] ​https://github.com/tc39/ecma262/pull/833

• bindings/js/JSDOMConvertRecord.h:

7:15 PM Changeset in webkit [268708] by Lauro Moura

• 7 edits in trunk

REGRESSION(r268115) [GTK] Build failures with GCC 7 (Ubuntu 18.04) and GCC 8 (Debian Buster)
​https://bugs.webkit.org/show_bug.cgi?id=217425

Reviewed by Carlos Alberto Lopez Perez.

.:

The root cause is lack of proper <filesystem> support in gcc7/8 (and
incompatibility with llvm's header that was included). As such, we
need to check whether to use <filesystem>, <experimental/filesystem>,
or fallback to the included header.

Note: In some systems like Ubuntu 20.04, gcc-8 can use gcc-9's
libstdc++ and link successfully, but running will fail as it should
actually link with its libstc++fs to provide the correct symbols. As
this is some corner case (Ubuntu's 20 default gcc is 9), LDFLAGS
can be used to overcome this.

• Source/cmake/OptionsCommon.cmake: Add a HAVE directive to

check whether <experimental/filesystem> is the filesystem impl
available.

• Source/cmake/WebKitCompilerFlags.cmake: Test first whether

<filesystem> can be used, with <experimental/filestystem> as fallback.

Source/WTF:

• wtf/StdFilesystem.h: Add fallback to <experimental/filesystem> if available.

Tools:

• WebKitTestRunner/CMakeLists.txt: Link with stdc++fs if using

<experimental/filesystem>.

7:08 PM Changeset in webkit [268707] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION (268605?): [ Mojave+ wk2 ] 4 wpt/service-workers tests are flaky failures
​https://bugs.webkit.org/show_bug.cgi?id=217938

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

7:03 PM Changeset in webkit [268706] by Hector Lopez

• 2 edits in trunk/LayoutTests

Test expectation added for http/wpt/service-workers/service-worker-spinning-install.https.html
​https://bugs.webkit.org/show_bug.cgi?id=217669

Unreviewed test gardening.

• platform/mac/TestExpectations:

5:52 PM Changeset in webkit [268705] by Ryan Haddad

• 9 edits
  2 adds in trunk/Tools

Unreviewed, reverting r268693.

Re-landing these changes as the underlying issue may have been
with CI infrastructure (and should now be resolved)

Reverted changeset:

"Unreviewed, reverting r268495, r268571, and r268682."
​https://bugs.webkit.org/show_bug.cgi?id=217723
​https://trac.webkit.org/changeset/268693

5:46 PM Changeset in webkit [268704] by Wenson Hsieh

• 7 edits in trunk

[MotionMark] Add state change items to represent changes to stroke and fill state
​https://bugs.webkit.org/show_bug.cgi?id=217911

Reviewed by Simon Fraser.

Source/WebCore:

Add two new display list items to represent changes to stroke thickness and/or stroke color, and fill color.
These state changes account for almost all of the state changes in MotionMark's canvas rendering subtests (i.e.
lines, arcs, and paths).

This significantly reduces the memory overhead caused by maintaining display list items in the web and GPU
processes when running Canvas Lines and Canvas Arcs. Currently, each SetState item is currently 120 bytes;
after this change, each state change item will decrease to either 24 (for SetFillColor) or 32 (for
SetStrokeState) bytes.

No change in behavior.

• platform/graphics/displaylists/DisplayList.h:

(WebCore::DisplayList::Item::isStateItem const): Deleted.
(WebCore::DisplayList::Item::isStateItemType): Deleted.

Remove a couple of unused methods, as well as an unused constexpr.

• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::Item::sizeInBytes):
(WebCore::DisplayList::SetFillColor::create):
(WebCore::DisplayList::SetFillColor::apply const):
(WebCore::DisplayList::operator<<):

Add the SetFillColor item, which represents a call to GraphicsContext::setFillColor.

(WebCore::DisplayList::SetStrokeState::create):
(WebCore::DisplayList::SetStrokeState::apply const):

Add the SetStrokeState item, which represents a call to GraphicsContext::setStrokeThickness and/or
GraphicsContext::setStrokeColor.

(WebCore::DisplayList::SetState::accumulate): Deleted.

Remove an unused method.

• platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::SetFillColor::color const):
(WebCore::DisplayList::SetFillColor::SetFillColor):
(WebCore::DisplayList::SetFillColor::encode const):
(WebCore::DisplayList::SetFillColor::decode):
(WebCore::DisplayList::SetStrokeState::color const):
(WebCore::DisplayList::SetStrokeState::hasColor const):
(WebCore::DisplayList::SetStrokeState::thickness const):
(WebCore::DisplayList::SetStrokeState::hasThickness const):

Instead of using two Optional<T> members, store two bool flags corresponding to thickness and stroke color.
This allows us to make the SetStrokeState item 32 bytes instead of 40 bytes, due to the extra padding that
would otherwise exist after each of the Optional members.

(WebCore::DisplayList::SetStrokeState::SetStrokeState):
(WebCore::DisplayList::SetStrokeState::encode const):
(WebCore::DisplayList::SetStrokeState::decode):
(WebCore::DisplayList::Item::encode const):
(WebCore::DisplayList::Item::decode):

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::containsOnlyStrokeColorOrThicknessChange):
(WebCore::DisplayList::containsOnlyFillColorChange):
(WebCore::DisplayList::createStateChangeItem):

Instead of always appending SetState items, append either SetStrokeState or SetFillColor if the only
changed flags are stroke thickness or stroke color, or fill color (respectively).

(WebCore::DisplayList::Recorder::willAppendItem):

LayoutTests:

• displaylists/canvas-display-list-expected.txt: Rebaseline an existing display list item dump test.

5:41 PM Changeset in webkit [268703] by Ryan Haddad

• 3 edits in trunk/LayoutTests

[mac-wk1] inspector/debugger/breakpoint-resolve-when-script-added.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=217934

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations: Mark test as flaky.
• platform/mac/TestExpectations: Remove previous entry marking it slow for debug.

5:29 PM Changeset in webkit [268702] by Jonathan Bedard

• 2 edits in trunk/Tools

[results.webkit.org] Refresh S3 context when token expires
​https://bugs.webkit.org/show_bug.cgi?id=217924
<rdar://problem/70381137>

Reviewed by Dewei Zhu.

• Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py:

(S3Archiver.init): Add _cached_token variable.
(S3Archiver.enter): Refresh S3 resource when the current token and cached token don't match.
(S3Archiver.exit): Clear out the cached token.

5:08 PM Changeset in webkit [268701] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Fix possible crash in GraphicsLayerCA::computeVisibleAndCoverageRect()
​https://bugs.webkit.org/show_bug.cgi?id=217930
<rdar://problem/70316943>

Reviewed by Tim Horton.

If we made a m_overflowControlsHostLayerAncestorClippingStack, make sure we unparent
its layers when tearing down the RenderLayerBacking, and when we determine that we
longer need a m_ancestorClippingStack (having a m_overflowControlsHostLayerAncestorClippingStack
implies that we have a m_ancestorClippingStack).

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::destroyGraphicsLayers):
(WebCore::RenderLayerBacking::updateAncestorClipping):

4:50 PM Changeset in webkit [268700] by Chris Dumez

• 38 edits in trunk/Source/WebCore

Replace execStateFrom*() functions with globalObject() overloads
​https://bugs.webkit.org/show_bug.cgi?id=217912

Reviewed by Darin Adler.

Introduce globalObject() overloads to replace existing execStateFrom*() functions.
This is a first step to promote code sharing. Ideally, code would not have to
differentiate workers from worklets as much as possible.

No new tests, no Web-facing behavior change.

• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::scriptExecutionContext const):

• bindings/js/ScriptState.cpp:

(WebCore::execStateFromWorkerOrWorkletGlobalScope):

• bindings/js/ScriptState.h:
• bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::globalScopeWrapper):

• bindings/js/WorkerScriptController.h:
• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::vm):
(WebCore::ScriptExecutionContext::execState):

• inspector/agents/worker/WorkerAuditAgent.cpp:

(WebCore::WorkerAuditAgent::injectedScriptForEval):

• inspector/agents/worker/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

• inspector/agents/worker/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::injectedScriptForEval):

• workers/WorkerOrWorkletScriptController.h:
• worklets/WorkletScriptController.cpp:

(WebCore::WorkletScriptController::globalScopeWrapper):

• worklets/WorkletScriptController.h:

4:49 PM Changeset in webkit [268699] by Alan Coon

• 1 copy in tags/Safari-610.2.11.51.3

Tag Safari-610.2.11.51.3.

4:48 PM Changeset in webkit [268698] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-createHTMLDocument-success-empty-src-module.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217931

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:04 PM Changeset in webkit [268697] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Adjust a comment about an antique way to override the UA on iOS

• platform/ios/UserAgentIOS.mm:

(WebCore::standardUserAgentWithApplicationName):
Reference ​https://bugs.webkit.org/show_bug.cgi?id=217927
which has a plan for getting rid of this (and mentions at least one
client who currently depends on this).

3:38 PM Changeset in webkit [268696] by Wenson Hsieh

• 4 edits in trunk/Source/WebCore

[MotionMark] Make DisplayList::FillPath discard its WebCore::Path after applying
​https://bugs.webkit.org/show_bug.cgi?id=217906

Reviewed by Tim Horton.

Let FillPath::apply clear out the platform CGPathRef in m_path after application to avoid accumulating a
pool of CGPathRefs for each Path that is being filled. This gives us a small (~1-2%) win on the Canvas Arcs
subtest in MotionMark, which processes ~1.7 million FillPath operations. To achieve this, instead of using
WTFMove, add a new helper method on Path to explicitly clear out the platform path pointer in the case where
it can be regenerated from inline data.

• platform/graphics/Path.h:

(WebCore::Path::releasePlatformPathIfPossible const):

• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::FillPath::apply const):
(WebCore::DisplayList::StrokePath::apply const):

• platform/graphics/displaylists/DisplayListItems.h:

3:12 PM Changeset in webkit [268695] by commit-queue@webkit.org

• 9 edits
  2 deletes in trunk

Unreviewed, reverting r267175 and r267779.
​https://bugs.webkit.org/show_bug.cgi?id=217923

Regressed NYTimes's DOM content loaded time by 400%

Reverted changesets:

"MutationObserverRegistration should be ref counted"
​https://bugs.webkit.org/show_bug.cgi?id=216528
​https://trac.webkit.org/changeset/267175

"Crash while loading a confluence page"
​https://bugs.webkit.org/show_bug.cgi?id=217111
​https://trac.webkit.org/changeset/267779

3:08 PM Changeset in webkit [268694] by Alan Coon

• 1 copy in tags/Safari-611.1.3.3

Tag Safari-611.1.3.3.

3:08 PM Changeset in webkit [268693] by Ryan Haddad

• 9 edits
  1 delete in trunk/Tools

Unreviewed, reverting r268495, r268571, and r268682.

Caused failures for some internal build configurations

Reverted changesets:

"[Testing] Generate test header key map for DumpRenderTree"
​https://bugs.webkit.org/show_bug.cgi?id=217723
​https://trac.webkit.org/changeset/268495

"Attempt to fix the build."
​https://trac.webkit.org/changeset/268571

"Switch to a static pattern for DumpRenderTree preferences
generation to avoid ambiguous rules"
​https://bugs.webkit.org/show_bug.cgi?id=217907
​https://trac.webkit.org/changeset/268682

3:07 PM Changeset in webkit [268692] by Hector Lopez

• 2 edits in trunk/LayoutTests

REGRESSION(r268615-268616?): [ Win10 wk1 EWS ] 3 animation tests are a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=217922

Unreviewed test gardening.

• platform/win/TestExpectations:

3:00 PM Changeset in webkit [268691] by commit-queue@webkit.org

• 18 edits
  2 copies
  2 adds in trunk/Source/WebInspectorUI

Web Inspector: Support three-column pane arrangement in Elements Tab
​https://bugs.webkit.org/show_bug.cgi?id=217396

Patch by Patrick Angle <Patrick Angle> on 2020-10-19
Reviewed by Devin Rousso.

The new multiple-sidebar layout for the Elements tab (and any other tab for which it is enabled in the future)
is achieved with a new WI.MultiSidebar, which is itself a WI.Sidebar and contains multiple new WI.SingleSidebar.
SingleSidebar replaces usage of the former Sidebar in favor of Sidebar being a common base shared between the
SingleSidebar and MultiSidebar.

A MultiSidebar supports showing multiple sidebars, and makes that decision based on the user having enabled
showing multiple sidebars and the WI.SidebarPanel.prototype.allowExclusivePresentation property on specific
SidebarPanels. The MultiSidebar manages these sidebars and their presentation, with some added properties to
manage the visibility of multiple sidebars. A MultiSidebar can display any number of sidebar panels
simultaneously. A MultiSidebar will always have a primarySidebar (although it may be collapsed), which is
where most panels will be presented. Additional panels that are marked as allowing exclusive presentation are
laid out in natural language order when the MultiSidebar's side is Leading and reverse order when it is
Trailing. This allows the sidebar to remain conceptually anchored, so the primarySidebar in the set does not
change locations when adding or removing other sidebars from the set.

The presentation of more than the primarySidebar is dependant on the following conditions:

1. The tab (e.g. Elements Tab) must allow the three-panel layout.
2. At least one panel in the MultiSidebar must allow exclusive presentation (e.g. Styles when enabled in

Experimental Settings).

3. There must be at least one other panel to keep in the primary sidebar.
4. There must be enough available space horizontally to satisfy the minimum width of both the primarySidebar

and any sidebar panels that will be shown by themselves.

This feature is behind an Experimental Feature setting, and is disabled by default.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/Main.js: Use new SingleSidebar and MultiSidebars, include each detail sidebar in maximum

width calculations, and listen for both width and collapse events.

• UserInterface/Base/Setting.js: Added setting for allowing Styles panel to be exclusive.
• UserInterface/Main.html:
• UserInterface/Views/ComputedStyleDetailsPanel.css: Hide shared elements between Styles and Computed when both

are visible.
(.multi-sidebar.showing-multiple > .sidebar > .panel.details.style-computed > .content > .pseudo-classes,):

• UserInterface/Views/ElementsTabContentView.js:

(WI.ElementsTabContentView.prototype.get allowMultipleDetailSidebars):

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.css: Show pseudo-class rules as if they were a navigation

bar only when shown exclusively. Otherwise, still allow them to wrap like normal.
(.panel.exclusive-presentation.details.css-style > .content > .pseudo-classes):
(.panel.exclusive-presentation.details.css-style > .content > .pseudo-classes > .group):
(.panel.exclusive-presentation.details.css-style > .content > .rules):
(.sidebar > .panel.details.css-style.style-rules > .content ~ :matches(.options-container, .class-list-container)): Removed.

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.js: If showing exclusively, prevent wrapping pseudo-class

rules by reporting their combined minimum width.
(WI.GeneralStyleDetailsSidebarPanel.prototype.get minimumWidth):

• UserInterface/Views/Main.css:

(#tab-browser): Match existing assumption for minimum tab-browser width.
(#details-sidebar): Match assumption for minimum sidebar width.

• UserInterface/Views/MultiSidebar.css: Added.

(.multi-sidebar):
(.multi-sidebar.trailing):
(.multi-sidebar.collapsed):

• UserInterface/Views/MultiSidebar.js: A Sidebar subclass that manages multiple SingleSidebars, and dynamically

presents them as space is available.
(WI.MultiSidebar):
(WI.MultiSidebar.prototype.get sidebars):
(WI.MultiSidebar.prototype.get primarySidebar):
(WI.MultiSidebar.prototype.get allowMultipleSidebars):
(WI.MultiSidebar.prototype.set allowMultipleSidebars):
(WI.MultiSidebar.prototype.get multipleSidebarsVisible):
(WI.MultiSidebar.prototype.set multipleSidebarsVisible):
(WI.MultiSidebar.prototype.addSidebar):
(WI.MultiSidebar.prototype.removeSidebar):
(WI.MultiSidebar.prototype.get selectedSidebarPanel):
(WI.MultiSidebar.prototype.set selectedSidebarPanel):
(WI.MultiSidebar.prototype.get collapsable):
(WI.MultiSidebar.prototype.set collapsable):
(WI.MultiSidebar.prototype.get minimumWidth):
(WI.MultiSidebar.prototype.get width):
(WI.MultiSidebar.prototype.didInsertSidebarPanel):
(WI.MultiSidebar.prototype.didRemoveSidebarPanel):
(WI.MultiSidebar.prototype.didSetCollapsed):
(WI.MultiSidebar.prototype.get _canShowMultipleSidebars):
(WI.MultiSidebar.prototype._updateMinimumWidthForMultipleSidebars):
(WI.MultiSidebar.prototype.get _hasWidthForMultipleSidebars):
(WI.MultiSidebar.prototype.get _hasSidebarPanelSupportingExclusive):
(WI.MultiSidebar.prototype._updateMultipleSidebarLayout):
(WI.MultiSidebar.prototype._canSidebarPanelBeExclusive):
(WI.MultiSidebar.prototype._makeSidebarPanelExclusive):
(WI.MultiSidebar.prototype._makeSidebarPanelNotExclusive):
(WI.MultiSidebar.prototype._nonExclusiveIndexOfSidebarPanel):
(WI.MultiSidebar.prototype._findSidebarForSidebarPanel):
(WI.MultiSidebar.prototype._addSidebarEventListeners):
(WI.MultiSidebar.prototype._removeSidebarEventListeners):
(WI.MultiSidebar.prototype._handleSidebarPanelSelected):
(WI.MultiSidebar.prototype._handleSidebarCollapsedStateDidChange):
(WI.MultiSidebar.prototype._handleSidebarWidthDidChange):
(WI.MultiSidebar.prototype._handleWindowResize):

• UserInterface/Views/RulesStyleDetailsSidebarPanel.js: If enabled in settings, allow Styles panel to be its own

sidebar.
(WI.RulesStyleDetailsSidebarPanel.prototype.get allowExclusivePresentation):
(WI.RulesStyleDetailsSidebarPanel):

• UserInterface/Views/SettingsTabContentView.js: Add setting for showing the Styles panel as its own sidebar.

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

• UserInterface/Views/Sidebar.css: Moved navigation and resizing to SingleSidebar.css.

(.sidebar):
(.sidebar.collapsed):
(.sidebar > .navigation-bar): Deleted.
(.sidebar.has-navigation-bar > .panel): Deleted.
(body[dir=ltr] .sidebar.right > .resizer,): Deleted.
(body[dir=ltr] .sidebar.left > .resizer,): Deleted.
(body[dir=ltr] .sidebar.left,): Deleted.
(body[dir=ltr] .sidebar.right,): Deleted.

• UserInterface/Views/Sidebar.js: Common base class for both SingleSidebar and MultiSidebar. Moved existing

navigation and resizing behavior to SingleSidebar.
(WI.Sidebar):
(WI.Sidebar.get sidebarPanels):
(WI.Sidebar.prototype.get side):
(WI.Sidebar.prototype.addSidebarPanel):
(WI.Sidebar.prototype.insertSidebarPanel):
(WI.Sidebar.prototype.removeSidebarPanel):
(WI.Sidebar.prototype.get selectedSidebarPanel):
(WI.Sidebar.prototype.set selectedSidebarPanel):
(WI.Sidebar.prototype.get collapsed):
(WI.Sidebar.prototype.set collapsed):
(WI.Sidebar.prototype.get collapsable):
(WI.Sidebar.prototype.set collapsable):
(WI.Sidebar.prototype.get minimumWidth):
(WI.Sidebar.prototype.get maximumWidth):
(WI.Sidebar.prototype.shouldInsertSidebarPanel):
(WI.Sidebar.prototype.didInsertSidebarPanel):
(WI.Sidebar.prototype.didRemoveSidebarPanel):
(WI.Sidebar.prototype.willSetSelectedSidebarPanel):
(WI.Sidebar.prototype.didSetSelectedSidebarPanel):
(WI.Sidebar.prototype.didSetCollapsed):
(WI.Sidebar.prototype._findSidebarPanel):
(WI.Sidebar.prototype.get width): Deleted.
(WI.Sidebar.prototype.set width): Deleted.
(WI.Sidebar.prototype.get sidebarPanels): Deleted.
(WI.Sidebar.prototype.findSidebarPanel): Deleted.
(WI.Sidebar.prototype.resizerDragStarted): Deleted.
(WI.Sidebar.prototype.resizerDragging): Deleted.
(WI.Sidebar.prototype.resizerDragEnded): Deleted.
(WI.Sidebar.prototype._recalculateWidth): Deleted.
(WI.Sidebar.prototype._navigationItemSelected): Deleted.

• UserInterface/Views/SidebarPanel.js: Support tracking exclusive display as well as enabling exclusive display.

(WI.SidebarPanel):
(WI.SidebarPanel.prototype.get exclusive):
(WI.SidebarPanel.prototype.set exclusive):
(WI.SidebarPanel.prototype.get allowExclusivePresentation):

• UserInterface/Views/SingleSidebar.css: Moved navigation and resizing from Sidebar.css.

(.single-sidebar > .navigation-bar):
(.single-sidebar.has-navigation-bar > .panel):
(body[dir=ltr] .single-sidebar.trailing > .resizer,):
(body[dir=ltr] .single-sidebar.leading > .resizer,):
(.single-sidebar.leading):
(.single-sidebar.trailing):

• UserInterface/Views/SingleSidebar.js: Added. Contains navigation and resizing previously in Sidebar.js.

(WI.SingleSidebar):
(WI.SingleSidebar.prototype.get allowResizingToCollapse):
(WI.SingleSidebar.prototype.set allowResizingToCollapse):
(WI.SingleSidebar.prototype.get minimumWidth):
(WI.SingleSidebar.prototype.get width):
(WI.SingleSidebar.prototype.set width):
(WI.SingleSidebar.prototype.shouldInsertSidebarPanel):
(WI.SingleSidebar.prototype.didInsertSidebarPanel):
(WI.SingleSidebar.prototype.didRemoveSidebarPanel):
(WI.SingleSidebar.prototype.willSetSelectedSidebarPanel):
(WI.SingleSidebar.prototype.didSetSelectedSidebarPanel):
(WI.SingleSidebar.prototype.didSetCollapsed):
(WI.SingleSidebar.prototype.resizerDragStarted):
(WI.SingleSidebar.prototype.resizerDragging):
(WI.SingleSidebar.prototype.resizerDragEnded):
(WI.SingleSidebar.prototype._recalculateWidth):
(WI.SingleSidebar.prototype._handleNavigationItemSelected):

• UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css: The last rule row should not show a bottom border,

otherwise a double-border is visible at the bottom of the sidebar.
(.sidebar > .panel.details.css-style > .content > .rules > :nth-last-child(1 of .spreadsheet-css-declaration)):

• UserInterface/Views/TabBrowser.js: Updated naming of handlers and added support for multiple detail sidebars.

(WI.TabBrowser):
(WI.TabBrowser._handleSidebarPanelSelected):
(WI.TabBrowser.prototype._handleSidebarWidthDidChange):
(WI.TabBrowser.prototype._handleMultiSidebarSidebarAdded):
(WI.TabBrowser.prototype._showDetailsSidebarPanelsForTabContentView):
(WI.TabBrowser._sidebarPanelSelected): Deleted.
(WI.TabBrowser.prototype._sidebarCollapsedStateDidChange): Deleted.
(WI.TabBrowser.prototype._sidebarWidthDidChange): Deleted.

• UserInterface/Views/TabContentView.js:

(WI.TabContentView.prototype.get allowMultipleDetailSidebars):

2:46 PM Changeset in webkit [268690] by Chris Dumez

• 5 edits in trunk/Source

[GPU Process] RemoteAudioDestination::render() should not need to dispatch to the main thread to do IPC
​https://bugs.webkit.org/show_bug.cgi?id=217920

Reviewed by Alex Christensen.

Source/WebKit:

RemoteAudioDestination::render() should not need to dispatch to the main thread to do IPC as this is bad
for performance and IPC::Connection::sendWithAsyncReply() already does locking internally for thread-safety.
The only thing that was preventing us from calling sendWithAsyncReply() from the audio rendering thread was
a threading assertion in CompletionHandler that made sure that the completion handler was always called on
the thread the completion handler was constructed on. To avoid this issue, I added a paramater to the
CompletionHandler constructor allowing the caller to indicate it expects the completion handler to get called
on the main thread. I am now using this new flag in sendWithAsyncReply() and at its call site in
RemoteAudioDestination::render().

No new tests, no Web-facing behavior change.

• GPUProcess/media/RemoteAudioDestinationManager.cpp:

(WebKit::RemoteAudioDestination::render):

• Platform/IPC/Connection.h:

(IPC::Connection::sendWithAsyncReply):

Source/WTF:

Add an optional parameter to the CompletionHandler constructor allowing the caller to indicate it expects
the completion handler to get call on the main thread instead of the construction thread.

• wtf/CompletionHandler.h:

(WTF::CompletionHandler<Out):

2:35 PM Changeset in webkit [268689] by aakash_jain@apple.com

• 3 edits in trunk/Tools

[ews] use -o while unzipping layout-test-results.zip
​https://bugs.webkit.org/show_bug.cgi?id=217914

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(ExtractTestResults.init):

• BuildSlaveSupport/ews-build/steps_unittest.py:

2:14 PM Changeset in webkit [268688] by commit-queue@webkit.org

• 4 edits in trunk

test262: test/language/expressions/conditional/in-branch-1.js
​https://bugs.webkit.org/show_bug.cgi?id=217879

Patch by Mark Cohen <​m@mpc.sh> on 2020-10-19
Reviewed by Darin Adler.

JSTests:

I fixed this test262 failure - see the JSC ChangeLog for more details.
All I've done in this directory is remove the expected failure from
test262/expectations.yaml.

• test262/expectations.yaml:

Source/JavaScriptCore:

The test262 test in question checks that the parser respects the +In
parameter on the left-hand AssignmentExpression (between ? and :)
in the ternary operator grammar. The relevant piece of the spec can be
found here (​https://tc39.es/ecma262/#sec-conditional-operator). The
test checks this by embedding a ternary with left-hand
AssignmentExpression that contains the in keyword in the
initializing statement of a for loop, where in would normally be
disallowed. All this patch does is unconditionally allow the in
keyword inside the left-hand AssignmentExpression of a ternary.

This also fixes a variable typo in parseForStatement.

• parser/Parser.cpp:

2:12 PM Changeset in webkit [268687] by Alan Coon

• 8 edits in branches/safari-611.1.3-branch/Source

Versioning.

WebKit-7611.1.3.3

2:10 PM Changeset in webkit [268686] by Antti Koivisto

• 13 edits
  47 adds
  4 deletes in trunk/LayoutTests

Update imported/w3c/web-platform-tests/css/selectors/
​https://bugs.webkit.org/show_bug.cgi?id=217905

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• web-platform-tests/css/selectors/first-line-bidi-001-expected.html: Added.
• web-platform-tests/css/selectors/first-line-bidi-001.html: Added.
• web-platform-tests/css/selectors/first-line-bidi-002-expected.html: Added.
• web-platform-tests/css/selectors/first-line-bidi-002.html: Added.
• web-platform-tests/css/selectors/focus-visible-007.html:
• web-platform-tests/css/selectors/focus-visible-011.html:
• web-platform-tests/css/selectors/is-where-error-recovery-expected.txt: Added.
• web-platform-tests/css/selectors/is-where-error-recovery.html: Added.
• web-platform-tests/css/selectors/is-where-not-expected.txt: Added.
• web-platform-tests/css/selectors/is-where-not.html: Added.
• web-platform-tests/css/selectors/is-where-parsing-expected.txt:
• web-platform-tests/css/selectors/is-where-parsing.html:
• web-platform-tests/css/selectors/is-where-pseudo-classes-expected.txt: Added.
• web-platform-tests/css/selectors/is-where-pseudo-classes.html: Added.
• web-platform-tests/css/selectors/is-where-pseudo-elements-expected.html: Added.
• web-platform-tests/css/selectors/is-where-pseudo-elements.html: Added.
• web-platform-tests/css/selectors/is-where-shadow-expected.txt: Added.
• web-platform-tests/css/selectors/is-where-shadow.html: Added.
• web-platform-tests/css/selectors/is-where-visited-expected.html: Added.
• web-platform-tests/css/selectors/is-where-visited.html: Added.
• web-platform-tests/css/selectors/not-links-expected.html:
• web-platform-tests/css/selectors/not-links.html:
• web-platform-tests/css/selectors/old-tests/css3-modsel-23.xml: Removed.
• web-platform-tests/css/selectors/old-tests/css3-modsel-24.xml: Removed.
• web-platform-tests/css/selectors/old-tests/css3-modsel-68.xml: Removed.
• web-platform-tests/css/selectors/old-tests/css3-modsel-69.xml: Removed.
• web-platform-tests/css/selectors/old-tests/w3c-import.log:
• web-platform-tests/css/selectors/parsing/parse-attribute-expected.txt: Added.
• web-platform-tests/css/selectors/parsing/parse-attribute.html: Added.
• web-platform-tests/css/selectors/parsing/parse-child-expected.txt: Added.
• web-platform-tests/css/selectors/parsing/parse-child.html: Added.
• web-platform-tests/css/selectors/parsing/parse-class-expected.txt: Added.
• web-platform-tests/css/selectors/parsing/parse-class.html: Added.
• web-platform-tests/css/selectors/parsing/parse-descendant-expected.txt: Added.
• web-platform-tests/css/selectors/parsing/parse-descendant.html: Added.
• web-platform-tests/css/selectors/parsing/parse-id-expected.txt: Added.
• web-platform-tests/css/selectors/parsing/parse-id.html: Added.
• web-platform-tests/css/selectors/parsing/parse-is-expected.txt: Added.
• web-platform-tests/css/selectors/parsing/parse-is.html: Added.
• web-platform-tests/css/selectors/parsing/parse-not-expected.txt: Added.
• web-platform-tests/css/selectors/parsing/parse-not.html: Added.
• web-platform-tests/css/selectors/parsing/parse-sibling-expected.txt: Added.
• web-platform-tests/css/selectors/parsing/parse-sibling.html: Added.
• web-platform-tests/css/selectors/parsing/parse-universal-expected.txt: Added.
• web-platform-tests/css/selectors/parsing/parse-universal.html: Added.
• web-platform-tests/css/selectors/parsing/parse-where-expected.txt: Added.
• web-platform-tests/css/selectors/parsing/parse-where.html: Added.
• web-platform-tests/css/selectors/parsing/w3c-import.log: Added.
• web-platform-tests/css/selectors/pseudo-enabled-disabled-expected.txt: Added.
• web-platform-tests/css/selectors/pseudo-enabled-disabled.html: Added.
• web-platform-tests/css/selectors/query/query-is-expected.txt: Added.
• web-platform-tests/css/selectors/query/query-is.html: Added.
• web-platform-tests/css/selectors/query/query-where-expected.txt: Added.
• web-platform-tests/css/selectors/query/query-where.html: Added.
• web-platform-tests/css/selectors/query/w3c-import.log: Added.
• web-platform-tests/css/selectors/w3c-import.log:
• web-platform-tests/css/support/query-testcommon.js: Added.

(test_query_selector):

• web-platform-tests/css/support/w3c-import.log:

LayoutTests:

• TestExpectations:

2:06 PM Changeset in webkit [268685] by Chris Dumez

• 7 edits
  2 adds in trunk/LayoutTests/imported/w3c

Resync web-platform-tests/webaudio from upstream
​https://bugs.webkit.org/show_bug.cgi?id=217909

Reviewed by Eric Carlson.

Resync web-platform-tests/webaudio from upstream 357b8f6365d9080a06.

• web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-constructor-options.https-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-constructor-options.https.html:
• web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-promises.https.html:
• web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/test-constantsourcenode.html:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/transferred-buffer-output-expected.txt: Added.
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/transferred-buffer-output.html: Added.
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/w3c-import.log:
• web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/offlineaudiocontext-detached-execution-context.tentative.html:

1:42 PM Changeset in webkit [268684] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Unreviewed test gardening for webkit.org/b/217862.

• platform/mac/TestExpectations: Mark the new test as slow for macOS debug queues.

1:31 PM Changeset in webkit [268683] by Truitt Savell

• 1 edit
  21 moves in trunk/LayoutTests

Fix name of test exepctations after r268679, change actual to expected
​https://bugs.webkit.org/show_bug.cgi?id=209813

Unreviewed test gardening.

• platform/mac-mojave/editing/selection/3690703-2-expected.txt: Renamed from LayoutTests/platform/mac-mojave/editing/selection/3690703-2-actual.txt.
• platform/mac-mojave/editing/selection/3690703-expected.txt: Renamed from LayoutTests/platform/mac-mojave/editing/selection/3690703-actual.txt.
• platform/mac-mojave/editing/selection/3690719-expected.txt: Renamed from LayoutTests/platform/mac-mojave/editing/selection/3690719-actual.txt.
• platform/mac-mojave/fast/block/basic/001-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/block/basic/001-actual.txt.
• platform/mac-mojave/fast/block/float/float-avoidance-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/block/float/float-avoidance-actual.txt.
• platform/mac-mojave/fast/css/rtl-ordering-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/css/rtl-ordering-actual.txt.
• platform/mac-mojave/fast/forms/basic-inputs-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/forms/basic-inputs-actual.txt.
• platform/mac-mojave/fast/forms/input-appearance-spinbutton-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/forms/input-appearance-spinbutton-actual.txt.
• platform/mac-mojave/fast/forms/input-disabled-color-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/forms/input-disabled-color-actual.txt.
• platform/mac-mojave/fast/forms/input-readonly-dimmed-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/forms/input-readonly-dimmed-actual.txt.
• platform/mac-mojave/fast/forms/option-text-clip-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/forms/option-text-clip-actual.txt.
• platform/mac-mojave/fast/forms/plaintext-mode-2-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/forms/plaintext-mode-2-actual.txt.
• platform/mac-mojave/fast/forms/select-change-listbox-to-popup-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/forms/select-change-listbox-to-popup-actual.txt.
• platform/mac-mojave/fast/forms/select-change-popup-to-listbox-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/forms/select-change-popup-to-listbox-actual.txt.
• platform/mac-mojave/fast/forms/textfield-outline-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/forms/textfield-outline-actual.txt.
• platform/mac-mojave/fast/text/indic-expected.txt: Renamed from LayoutTests/platform/mac-mojave/fast/text/indic-actual.txt.
• platform/mac-mojave/media/video-display-toggle-expected.txt: Renamed from LayoutTests/platform/mac-mojave/media/video-display-toggle-actual.txt.
• platform/mac-mojave/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/mac-mojave/media/video-volume-slider-actual.txt.
• platform/mac-mojave/tables/mozilla/bugs/bug30692-expected.txt: Renamed from LayoutTests/platform/mac-mojave/tables/mozilla/bugs/bug30692-actual.txt.
• platform/mac-mojave/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Renamed from LayoutTests/platform/mac-mojave/tables/mozilla/other/wa_table_thtd_rowspan-actual.txt.
• platform/mac-mojave/tables/mozilla/other/wa_table_tr_align-expected.txt: Renamed from LayoutTests/platform/mac-mojave/tables/mozilla/other/wa_table_tr_align-actual.txt.

12:40 PM Changeset in webkit [268682] by weinig@apple.com

• 3 edits in trunk/Tools

Switch to a static pattern for DumpRenderTree preferences generation to avoid ambiguous rules
​https://bugs.webkit.org/show_bug.cgi?id=217907

Reviewed by Simon Fraser.

• DumpRenderTree/DerivedSources-input.xcfilelist:

Add DerivedSources.make and generate-derived-sources.sh to ensure things get rebuilt when they change.

• DumpRenderTree/DerivedSources.make:

Switch to using a static pattern to avoid ambiguous and ciruclar rules.

12:07 PM Changeset in webkit [268681] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ WinCairo ] animations/needs-layout.html is a constant ImageOnlyFailure
​https://bugs.webkit.org/show_bug.cgi?id=217917

Unreviewed test gardening.

• platform/wincairo/TestExpectations:

12:04 PM Changeset in webkit [268680] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION(r265231): Overlay: node info sometimes draws on one line
​https://bugs.webkit.org/show_bug.cgi?id=217416

Patch by Patrick Angle <Patrick Angle> on 2020-10-19
Reviewed by Brian Burg.

No new tests - user interface fix.

Restored advancing to the next line for drawing two-line element titles (for elements with a Role).

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::drawElementTitle):

12:03 PM Changeset in webkit [268679] by Truitt Savell

• 1 edit
  26 adds in trunk/LayoutTests

Rebaseline tests for Mojave after the changes in r268520
​https://bugs.webkit.org/show_bug.cgi?id=209813

Unreviewed test gardening

• platform/mac-mojave/editing/selection/3690703-2-actual.txt: Added.
• platform/mac-mojave/editing/selection/3690703-actual.txt: Added.
• platform/mac-mojave/editing/selection/3690719-actual.txt: Added.
• platform/mac-mojave/fast/block/basic/001-actual.txt: Added.
• platform/mac-mojave/fast/block/float/float-avoidance-actual.txt: Added.
• platform/mac-mojave/fast/css/rtl-ordering-actual.txt: Added.
• platform/mac-mojave/fast/forms/basic-inputs-actual.txt: Added.
• platform/mac-mojave/fast/forms/input-appearance-spinbutton-actual.txt: Added.
• platform/mac-mojave/fast/forms/input-disabled-color-actual.txt: Added.
• platform/mac-mojave/fast/forms/input-readonly-dimmed-actual.txt: Added.
• platform/mac-mojave/fast/forms/option-text-clip-actual.txt: Added.
• platform/mac-mojave/fast/forms/plaintext-mode-2-actual.txt: Added.
• platform/mac-mojave/fast/forms/select-change-listbox-to-popup-actual.txt: Added.
• platform/mac-mojave/fast/forms/select-change-popup-to-listbox-actual.txt: Added.
• platform/mac-mojave/fast/forms/textfield-outline-actual.txt: Added.
• platform/mac-mojave/fast/text/indic-actual.txt: Added.
• platform/mac-mojave/media/video-display-toggle-actual.txt: Added.
• platform/mac-mojave/media/video-volume-slider-actual.txt: Added.
• platform/mac-mojave/tables/mozilla/bugs/bug30692-actual.txt: Added.
• platform/mac-mojave/tables/mozilla/other/wa_table_thtd_rowspan-actual.txt: Added.
• platform/mac-mojave/tables/mozilla/other/wa_table_tr_align-actual.txt: Added.

11:56 AM Changeset in webkit [268678] by Alan Coon

• 8 edits in trunk/Source

Versioning.

WebKit-7611.1.5

11:49 AM Changeset in webkit [268677] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ WinCairo ] animations/additive-transform-animations.html is a constant ImageOnlyFailure
​https://bugs.webkit.org/show_bug.cgi?id=217915

Unreviewed test gardening.

• platform/wincairo/TestExpectations:

11:42 AM Changeset in webkit [268676] by Alan Coon

• 1 copy in branches/safari-611.1.4-branch

New branch.

11:28 AM Changeset in webkit [268675] by Alan Coon

• 2 edits in branches/safari-610.2.11.51-branch/Source/WebKit

Cherry-pick r268570. rdar://problem/70447631

v2: WebKit::XPCServiceEventHandler block should call exit() on the main thread
<​https://webkit.org/b/217773>
<rdar://problem/70275659>

Reviewed by Geoff Garen.

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: (WebKit::XPCServiceEventHandler):
• Use NSRunLoop instead of libdispatch to run code on the main thread since libdispatch can randomly pick a new main thread when exit() is called on the original main thread.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:17 AM Changeset in webkit [268674] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Use feature flag to support Buildbot 2 code
​https://bugs.webkit.org/show_bug.cgi?id=217834

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/build.webkit.org-config/loadConfig.py:

(loadBuilderConfig):

11:15 AM Changeset in webkit [268673] by Jonathan Bedard

• 4 edits in trunk/Tools

[webkitpy] Use webkitcorepy's autoinstaller for keyring
​https://bugs.webkit.org/show_bug.cgi?id=217839
<rdar://problem/70389225>

Reviewed by Aakash Jain.

• Scripts/webkitpy/init.py: Add keyring.
• Scripts/webkitpy/common/net/credentials.py:
• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Remove _install_keyring.
(AutoinstallImportHook._install_keyring): Deleted.

11:12 AM Changeset in webkit [268672] by Alan Coon

• 3 edits in branches/safari-610.2.11.51-branch/Source/WebCore

Cherry-pick r266787. rdar://problem/70447326

AccessibilityMenuList and MenuListPopup notifications need to be posted asynchronously.
​https://bugs.webkit.org/show_bug.cgi?id=216309
<rdar://problem/68108824>

Reviewed by Chris Fleizach.

MenuList notifications were posted synchronously which triggers a DOM
layout and style update in the middle of an ongoing DOM mutation update.
This is unnecessary and, furthermore, causes crashes since the DOM
layout update cannot be re-entrant. This change makes these
notifications asynchronous.

• accessibility/AccessibilityMenuList.cpp: (WebCore::AccessibilityMenuList::didUpdateActiveOption):
• accessibility/AccessibilityMenuListPopup.cpp: (WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:10 AM Changeset in webkit [268671] by Alan Coon

• 8 edits in branches/safari-610.2.11.51-branch/Source

Versioning.

WebKit-7610.2.11.51.3

10:49 AM Changeset in webkit [268670] by Truitt Savell

• 22 edits
  16 copies
  4 adds in trunk/LayoutTests

Rebaseline tests for Big Sur after the changes in r268520
​https://bugs.webkit.org/show_bug.cgi?id=209813

Unreviewed test gardening.

• platform/mac-catalina/editing/selection/3690703-2-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-2-expected.txt.
• platform/mac-catalina/editing/selection/3690703-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-expected.txt.
• platform/mac-catalina/editing/selection/3690719-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690719-expected.txt.
• platform/mac-catalina/fast/block/float/float-avoidance-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/float-avoidance-expected.txt.
• platform/mac-catalina/fast/css/rtl-ordering-expected.txt: Copied from LayoutTests/platform/mac/fast/css/rtl-ordering-expected.txt.
• platform/mac-catalina/fast/forms/basic-inputs-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt.
• platform/mac-catalina/fast/forms/input-appearance-spinbutton-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt.
• platform/mac-catalina/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
• platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
• platform/mac-catalina/fast/forms/option-text-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/option-text-clip-expected.txt.
• platform/mac-catalina/fast/forms/select-change-listbox-to-popup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt.
• platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
• platform/mac-catalina/fast/forms/textfield-outline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-outline-expected.txt.
• platform/mac-catalina/media/video-display-toggle-expected.txt: Copied from LayoutTests/platform/mac/media/video-display-toggle-expected.txt.
• platform/mac-catalina/media/video-volume-slider-expected.txt: Copied from LayoutTests/platform/mac/media/video-volume-slider-expected.txt.
• platform/mac-catalina/tables/mozilla/bugs/bug30692-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt.
• platform/mac/editing/selection/3690703-2-expected.txt:
• platform/mac/editing/selection/3690703-expected.txt:
• platform/mac/editing/selection/3690719-expected.txt:
• platform/mac/fast/block/basic/001-expected.txt:
• platform/mac/fast/block/float/float-avoidance-expected.txt:
• platform/mac/fast/css/rtl-ordering-expected.txt:
• platform/mac/fast/forms/basic-inputs-expected.txt:
• platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
• platform/mac/fast/forms/input-disabled-color-expected.txt:
• platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac/fast/forms/option-text-clip-expected.txt:
• platform/mac/fast/forms/plaintext-mode-2-expected.txt:
• platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:
• platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac/fast/forms/textfield-outline-expected.txt:
• platform/mac/fast/text/indic-expected.txt:
• platform/mac/media/video-display-toggle-expected.txt:
• platform/mac/media/video-volume-slider-expected.txt:
• platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
• platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
• platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:

9:48 AM Changeset in webkit [268669] by commit-queue@webkit.org

• 27 edits
  1 copy in trunk/Source

[GPU Process] Clean the DisplayList recording of the NativeImage
​https://bugs.webkit.org/show_bug.cgi?id=217573

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-10-19
Reviewed by Simon Fraser.

Source/WebCore:

1) Move the definition of NativeImagePtr to a separate header file named

NativeImagePtr.

2) Remove the class ImageHandle and allow encoding and decoding NativeImagePtr

directly.

3) Remove the compilation directives around the DisplayList::DrawNativeImage

item and the method drawNativeImage().

4) Move the drawNativeImage() methods to the sources of their callers.

• Headers.cmake:
• WebCore.xcodeproj/project.pbxproj:
• loader/cache/MemoryCache.h:
• platform/graphics/BitmapImage.cpp:

(WebCore::drawNativeImage):

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawNativeImage):

• platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::drawNativeImage):

• platform/graphics/GraphicsContextImpl.h:
• platform/graphics/Image.h:
• platform/graphics/ImageBufferBackend.h:
• platform/graphics/NativeImage.h:
• platform/graphics/NativeImagePtr.h: Copied from Source/WebCore/platform/graphics/NativeImage.h.
• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::platformDrawNativeImage):
(WebCore::GraphicsContext::drawNativeImage): Deleted.

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformDrawNativeImage):
(WebCore::GraphicsContext::drawNativeImage): Deleted.

• platform/graphics/cg/NativeImageCG.cpp:

(WebCore::drawNativeImage): Deleted.

• platform/graphics/displaylists/DisplayList.h:
• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::Item::sizeInBytes):
(WebCore::DisplayList::DrawNativeImage::DrawNativeImage):
(WebCore::DisplayList::DrawNativeImage::apply const):
(WebCore::DisplayList::operator<<):

• platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawNativeImage::encode const):
(WebCore::DisplayList::DrawNativeImage::decode):
(WebCore::DisplayList::Item::encode const):
(WebCore::DisplayList::Item::decode):

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawNativeImage):

• platform/graphics/displaylists/DisplayListRecorder.h:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
• platform/graphics/nicosia/NicosiaImageBufferPipe.cpp:
• platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::platformDrawNativeImage):
(WebCore::GraphicsContext::drawNativeImage): Deleted.

Source/WebKit:

Support encoding and decoding NativeImagePtr directly.

• Scripts/webkit/messages.py:
• Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeNativeImage):
(IPC::encodeOptionalNativeImage):
(IPC::ArgumentCoder<NativeImagePtr>::encode):
(IPC::ArgumentCoder<NativeImagePtr>::decode):
(IPC::ArgumentCoder<NativeImageHandle>::encode): Deleted.
(IPC::ArgumentCoder<NativeImageHandle>::decode): Deleted.

• Shared/WebCoreArgumentCoders.h:
• Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::paint):

8:36 AM Changeset in webkit [268668] by graouts@webkit.org

• 9 edits in trunk/Source

Move remaining Web Animations runtime-enabled features to settings
​https://bugs.webkit.org/show_bug.cgi?id=217903

Reviewed by Sam Weinig.

Source/WebCore:

• animation/KeyframeEffect.cpp:

(WebCore::processKeyframeLikeObject):
(WebCore::processIterableKeyframes):
(WebCore::processPropertyIndexedKeyframes):
(WebCore::KeyframeEffect::getKeyframes):

• animation/KeyframeEffect.idl:
• animation/WebAnimation.idl:
• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebAnimationsCompositeOperationsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAnimationsCompositeOperationsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebAnimationsMutableTimelinesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAnimationsMutableTimelinesEnabled const): Deleted.

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WTF:

• Scripts/Preferences/WebPreferencesExperimental.yaml:

6:46 AM Changeset in webkit [268667] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Respect relayoutChildren flag
​https://bugs.webkit.org/show_bug.cgi?id=217902

Reviewed by Zalan Bujtas.

Ensure we layout replaced children when relayoutChildren is set.

Fixes fast/images/decode-render-static-image.html and others.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutLFCLines):

2:40 AM Changeset in webkit [268666] by svillar@igalia.com

• 19 edits
  1 move
  1 add
  4 deletes in trunk

Sanitize the usage of override sizes
​https://bugs.webkit.org/show_bug.cgi?id=217479

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

RenderBox had two values, overrideContentLogicalWidth and overrideContentLogicalHeight which were used by a variety of
layout systems (like tables, grid or flex) in different ways. Although names clearly stated that they were content sizes
the reality is that they were used as either border box sizes, content box sizes, or even content box + scrollbar sizes.

This patch addresses a comment in RenderBox which was precisely advocating for turning overrideContentLogicalXXX back into
overrideLogicalXXX. Most of the changes of this CL are just renames because the code has specific branches to handle specific
situations so it didn't actually matter which kind of size we were actually storing. However there are some tricky replacements
as in the case of flex, grid and tables that required careful modifications. It's critical for these layout systems to know
which size we're storing in the overrides because that would determine whether or not we need to add/substract things like borders,
paddings or scrollbar sizes to use them.

Note that apart from renaming the overrideContentLogicalXXX to overrideLogicalXXX we're "adding" overrideContentLogicalXXX to the
RenderBox interface, so it gives the impression that we are not renaming it. However the new implementation is quite different, they
retrieve the content box sizes from the override (border box) sizes we store.

As a nice side effect a new test is passing now after these changes.

• rendering/ComplexLineLayout.cpp:

(WebCore::ComplexLineLayout::updateRubyForJustifiedText): Renames.

• rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const): Renames.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeChildPreferredLogicalWidths const): Renames.
(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const): Ditto.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded): Renames + store the border box width instead of the content box's.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::hasOverrideLogicalHeight const): Renamed.
(WebCore::RenderBox::hasOverrideLogicalWidth const): Ditto.
(WebCore::RenderBox::setOverrideLogicalHeight): Ditto.
(WebCore::RenderBox::setOverrideLogicalWidth): Ditto.
(WebCore::RenderBox::clearOverrideLogicalHeight): Ditto.
(WebCore::RenderBox::clearOverrideLogicalWidth): Ditto.
(WebCore::RenderBox::clearOverrideContentSize): Ditto.
(WebCore::RenderBox::overrideLogicalWidth const): Ditto.
(WebCore::RenderBox::overrideLogicalHeight const): Ditto.
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const): Renames.
(WebCore::RenderBox::computeLogicalWidthInFragment const): Renames + return the stored override border box width directly.
(WebCore::RenderBox::cacheIntrinsicContentLogicalHeightForFlexItem const): Renames.
(WebCore::RenderBox::computeLogicalHeight const): Renames. Apart from that moved some code around so all branches work with
border box sizes instead of mixing them with content box sizes.
(WebCore::RenderBox::computePercentageLogicalHeight const): Return the content box size after removing computed paddings and
borders from the stored override size.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const): Renames + compute the borderbox size from the stored
override size.
(WebCore::RenderBox::availableLogicalHeightUsing const): Return the content box size after removing computed paddings and
borders from the stored override size.
(WebCore::RenderBox::hasOverrideContentLogicalHeight const): Deleted.
(WebCore::RenderBox::hasOverrideContentLogicalWidth const): Deleted.
(WebCore::RenderBox::setOverrideContentLogicalHeight): Deleted.
(WebCore::RenderBox::setOverrideContentLogicalWidth): Deleted.
(WebCore::RenderBox::clearOverrideContentLogicalHeight): Deleted.
(WebCore::RenderBox::clearOverrideContentLogicalWidth): Deleted.
(WebCore::RenderBox::overrideContentLogicalWidth const): Deleted.
(WebCore::RenderBox::overrideContentLogicalHeight const): Deleted.

• rendering/RenderBox.h:

(WebCore::RenderBox::overrideContentLogicalWidth const): "New" method. It existed before but it was renamed to overrideLogicalWidth.
We're adding a completely different implementation for this one.
(WebCore::RenderBox::overrideContentLogicalHeight const): Ditto.

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::widthForChild): New method to retrieve the border box width.
(WebCore::heightForChild): New method to retrieve the border box height.
(WebCore::contentWidthForChild): Use widthForChild() which handles overrides.
(WebCore::contentHeightForChild): Use heightForChild() which handles overrides.
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): Ditto.
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): Ditto.
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp): Do not substract border and padding before setting the override because
we now store the border box height not the content box height.

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::childIntrinsicLogicalWidth const): Renames.
(WebCore::RenderFlexibleBox::crossSizeForPercentageResolution): Return the content box size (does not include scrollbar).
(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution): Ditto.
(WebCore::RenderFlexibleBox::setOverrideMainAxisContentSizeForChild): Add border and padding before setting the override.
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Do not substract border and padding before setting the override as we are
storing border box sizes.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock): Renames.
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded): Renames + do not substract border and padding before setting the override
as we are storing border box sizes.

• rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::adjustInlineDirectionLineBounds const): Renames.

• rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth): Renames.

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::setOverrideLogicalHeightFromRowHeight): Renames + do not substract border and padding before setting the override
as we are storing border box sizes.
(WebCore::RenderTableCell::setOverrideContentLogicalHeightFromRowHeight): Deleted.

• rendering/RenderTableCell.h: Renames.
• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight): Renames.
(WebCore::RenderTableSection::relayoutCellIfFlexed): Ditto.

LayoutTests:

The percentage-size-subitems-001.html is passing now after making the overrides work properly.

Apart from that the override sanitization allowed us to remove platform specific expectations for the border-fit-2.html
test even for the GTK port which is working fine now.

• TestExpectations: Removed a test that passes now.
• css3/flexbox/flex-flow-auto-margins-no-available-space-assert.html: Fine tuned expectations.
• fast/borders/border-fit-2-expected.txt: Renamed from LayoutTests/platform/ios/fast/borders/border-fit-2-expected.txt.
• platform/gtk/TestExpectations: Removed two tests that pass now.
• platform/gtk/fast/borders/border-fit-2-expected.txt: Removed.
• platform/gtk/fast/borders/border-fit-expected.txt: Added.
• platform/mac/fast/borders/border-fit-2-expected.txt: Removed.
• platform/wincairo/fast/borders/border-fit-2-expected.txt: Removed.
• platform/wpe/fast/borders/border-fit-2-expected.txt: Removed.

2:24 AM Changeset in webkit [268665] by commit-queue@webkit.org

• 11 edits in trunk

axis in scroll-snap-type should be required
​https://bugs.webkit.org/show_bug.cgi?id=210468
<rdar://problem/61746766>

Patch by Martin Robinson <​mrobinson@igalia.com> on 2020-10-19
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-scroll-snap/parsing/scroll-snap-type-invalid-expected.txt: Update

expected results to note newly passing tests.

Source/WebCore:

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeScrollSnapType): The first value is either the scroll axis or 'none'.

• style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertScrollSnapType): If the first value is 'none',
the default values of ScrollSnapType should be fine. If we have a second value, use it.
Otherwise the default for strictness is "proximity."

LayoutTests:

• css3/scroll-snap/scroll-snap-inherit.html: Update test and results to reflect specification.
• css3/scroll-snap/scroll-snap-property-computed-style-expected.txt: Ditto.
• css3/scroll-snap/scroll-snap-property-computed-style.js: Ditto.
• css3/scroll-snap/scroll-snap-property-parsing-expected.txt: Ditto.
• css3/scroll-snap/scroll-snap-property-parsing.js: Ditto.

Oct 18, 2020:

10:18 PM Changeset in webkit [268664] by Fujii Hironori

• 2 edits in trunk/Source/WebKit

[WinCairo] sluggish page scrolling for wheel events since r268499
​https://bugs.webkit.org/show_bug.cgi?id=217850

Reviewed by Simon Fraser.

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent): Include
WheelEventProcessingSteps::MainThreadForScrolling to
processingSteps for !ENABLE(SCROLLING_THREAD).

8:51 PM Changeset in webkit [268663] by jh718.park@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Remove the duplicated IGNORE_WARNINGS_BEGIN("frame-address") calls from r268661.

No new tests, no new behaviors.

• domjit/JSDocumentDOMJIT.cpp:

(WebCore::DOMJIT::JSC_DEFINE_JIT_OPERATION):

8:45 PM Changeset in webkit [268662] by Lauro Moura

• 6 edits in trunk/Tools

webkitcorepy: Allow one package to require another package
​https://bugs.webkit.org/show_bug.cgi?id=217856

Reviewed by Jonathan Bedard.

In some cases a package may check whether another package is
installed without actually importing it, which would make
the AutoInstall to miss the dependency as it would not be
imported. An example is pytest autoload feature searching
for plugins like pytest_timeout.

So, this commit adds a new argument to autoinstall.Package:
implicit_deps. It is not intended to be a full fledged dependency
tracking system, just covering these corner cases.

This commit also downgrades pytest from 3.10 to 3.6 to match the
version used in WPT tests.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump mini

version.

• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.init): Add new implicit_deps argument.
(Package.install): Install implicit_deps.

• Scripts/webkitpy/init.py: Update pytest version and add

pytest_timeout dependency.

• Scripts/webkitpy/webdriver_tests/pytest_runner.py:

(run): Ignore DISABLE_AUTOLOAD as it was added in pytest 3.8 and go
back to implicitly loading pytest_timeout.

• Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:

(WebDriverTestRunnerSelenium.run): Add the harness error log messages
like the ones in the w3c runner from r268402.

8:05 PM Changeset in webkit [268661] by jh718.park@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Remove the build warning below since r267727.
warning: calling ‘void* builtin_frame_address(unsigned int)’ with a nonzero argument is unsafe [-Wframe-address]

No new tests, no new behaviors.

• domjit/JSDocumentDOMJIT.cpp:

(WebCore::DOMJIT::JSC_DEFINE_JIT_OPERATION):

11:45 AM Changeset in webkit [268660] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

[LFC][IFC][Quirk] No soft wrapping opportunity before/after image content when the root is a table cell
​https://bugs.webkit.org/show_bug.cgi?id=217894

Reviewed by Antti Koivisto.

This quirk behavior matches both FF and Chrome.

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::hasSoftWrapOpportunityAtImage const):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::isAtSoftWrapOpportunity):
(WebCore::Layout::LineBuilder::nextContentForLine):
(WebCore::Layout::LineBuilder::nextWrapOpportunity const):
(WebCore::Layout::nextWrapOpportunity): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:
• layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree):

9:11 AM Changeset in webkit [268659] by emilio

• 9 edits in trunk

Serialize aspect ratio with spaces around the slash.
​https://bugs.webkit.org/show_bug.cgi?id=217888

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• web-platform-tests/css/mediaqueries/aspect-ratio-serialization-expected.txt: Annotate progression.

Source/WebCore:

Tests: web-platform-tests/css/mediaqueries/aspect-ratio-serialization-expected.txt

• css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::customCSSText const): Add the spaces.

LayoutTests:

• fast/css/aspect-ratio-inheritance-expected.txt:
• fast/css/aspect-ratio-inheritance.html:
• fast/css/aspect-ratio-parsing-tests-expected.txt:
• fast/css/aspect-ratio-parsing-tests.html:

Adjust tests

6:35 AM Changeset in webkit [268658] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Do not create imaginary strut when in limited quirks mode
​https://bugs.webkit.org/show_bug.cgi?id=217889

Reviewed by Antti Koivisto.

Only standard mode produces imaginary strut (exclude both full and limited quirks mode).

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

6:25 AM Changeset in webkit [268657] by ddkilzer@apple.com

• 4 edits in trunk/Source

Fix -Wdeprecated-copy warnings in WTF and JavaScriptCore
<​https://webkit.org/b/217855>
<rdar://problem/67716914>

Reviewed by Darin Adler.

Source/JavaScriptCore:

• assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::LinkRecord::LinkRecord): Add.

• Implement the copy constructor since the compiler may not have implemented it the same way as the copy assignment operator.

(JSC::ARM64Assembler::LinkRecord::operator=):

• Fix return type of copy assignment operator and simplify it.

Source/WTF:

• wtf/Identified.h:

(WTF::IdentifiedBase::Identifier):

• Change to default since compiler will generate the same code.

(WTF::IdentifiedBase::operator=): Add.

• Add default copy assignment operator to keep it protected.

6:24 AM Changeset in webkit [268656] by Caio Lima

• 10 edits
  3 adds in trunk

[ESNext][JIT] Add support for UntypedUse on PutPrivateName's base operand
​https://bugs.webkit.org/show_bug.cgi?id=217373

Reviewed by Yusuke Suzuki.

JSTests:

• stress/get-private-name-with-primitive.js: Added.
• stress/put-private-name-untyped-use.js: Added.
• stress/put-private-name-with-primitive.js: Added.

Source/JavaScriptCore:

This patch is adding UntypedUse for PutPrivateName's base operand to
avoid a OSR when we have a non-cell base.
Also, it is fixing a bug on private field operations get_private_name and
put_private_name to call ToObject on base to properly support
class fields spec text[1][2].

[1] - ​https://tc39.es/proposal-class-fields/#sec-getvalue
[2] - ​https://tc39.es/proposal-class-fields/#sec-putvalue

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutPrivateName):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutPrivateName):

• jit/JITOperations.cpp:

(JSC::setPrivateField):
(JSC::definePrivateField):
(JSC::JSC_DEFINE_JIT_OPERATION):
(JSC::getPrivateName):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_private_name):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_private_name):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• runtime/CommonSlowPaths.cpp:

Previous implementation was wrongly considering that base was always
an object, causing segmentation fault when base was not an object.
We changed this to handle cases when base is not and object, following
what spec text specifies.

5:48 AM Changeset in webkit [268655] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Do not snap the vertical position of a render replaced to integral value
​https://bugs.webkit.org/show_bug.cgi?id=217885

Reviewed by Antti Koivisto.

Apparently legacy inline layout only snaps text content.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):

5:42 AM Changeset in webkit [268654] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Inline level boxes are at the incorrect position when line is horizontally aligned
​https://bugs.webkit.org/show_bug.cgi?id=217887

Reviewed by Antti Koivisto.

Inline boxes (as opposed to runs) are constructed after the horizontal alignment is computed so their position
already includes the horizontal offset. No need to offset the again at logicalRectForInlineLevelBox.

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::logicalRectForInlineLevelBox const):

5:33 AM Changeset in webkit [268653] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Add quirks mode for root inline box height stretching
​https://bugs.webkit.org/show_bug.cgi?id=217881

Reviewed by Antti Koivisto.

When the imaginary strut is not applicable (in quirks mode), the root inline box
is stretched as it gains either text or some other inline level box content.

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

Oct 17, 2020:

10:28 PM Changeset in webkit [268652] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKitLegacy/mac

REGRESSION (r25430): Fix -Wstring-concatenation warning from open source clang
<​https://webkit.org/b/217884>

Reviewed by Alexey Proskuryakov.

• WebView/WebPreferences.mm:

(cacheModelForMainBundle):

• Add missing comma to fix unwanted string concatenation.

5:48 PM Changeset in webkit [268651] by Darin Adler

• 2 edits in trunk/Source/WebCore

Remove "lazy offset" optmization from Range to prepare to derive it from SimpleRange
​https://bugs.webkit.org/show_bug.cgi?id=217878

Reviewed by Sam Weinig.

Rysouke has suggested that we change Range so it can derive from SimpleRange.
Specifically, AbstractRange will derive from SimpleRange, and both StaticRange
and Range will continue to derive from that, and almost all functions will be
non-virtual. Doing this means we will lose the likely-unimportant "lazy offset"
that Range has today, where boundary point offsets are only computed on demand.
This patch removes that optimization without changing anything else, so we can
do performance tests and bisecting on just this part of the change.

• dom/RangeBoundaryPoint.h: Rename m_offset and m_childBefore and don't use

an Optional for the offset any more.

5:46 PM Changeset in webkit [268650] by Ross Kirsling

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed fix for r268640
​https://bugs.webkit.org/show_bug.cgi?id=217883

It seems I made a late adjustment that test262 was unhappy with; this reverts just that line.

• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):

4:43 PM Changeset in webkit [268649] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r191637): Fix -Wmisleading-indentation warnings in open source clang
<​https://webkit.org/b/217882>

Reviewed by Tim Horton.

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::accessibilityAttributeValue):

• Fix indentation of source to match what it is doing.

1:33 PM Changeset in webkit [268648] by Darin Adler

• 19 edits
  3 copies
  1 add in trunk

Add AbstractRange
​https://bugs.webkit.org/show_bug.cgi?id=217846

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

• web-platform-tests/dom/idlharness.window-expected.txt:

Updated test result for progression.

Source/WebCore:

This makes us more accurately match the DOM specification, makes Range
and StaticRange objects slightly bigger since they now have a virtual
table pointer, and makes the AbstractRange methods a bit slower to call
from JavaScript since they are backed by C++ virtual functions.

• CMakeLists.txt: Added AbstractRange files.
• DerivedSources-input.xcfilelist: Ditto.
• DerivedSources-output.xcfilelist: Ditto.
• DerivedSources.make: Ditto.
• Headers.cmake: Ditto.
• Sources.txt: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.

Also removed reference to non-existent JSAudioNodeCustom.cpp and moved
JSStaticRange file from the Events group into the Ranges group.

• bindings/js/JSAbstractRangeCustom.cpp: Added.

(WebCore::toJS): Added. Just the default implementation. Would be
nice if we did not have to write this.
(WebCore::toJSNewlyCreated): Make either a StaticRange or Range
wrapper depending on whether this is a live range or not.

• bindings/js/JSEventCustom.cpp: Removed lots of unneeded includes.

(WebCore::toJS): Stopped using "using namespace JSC".

• bindings/js/WebCoreBuiltinNames.h: Added AbstractRange.

• dom/AbstractRange.cpp: Added.

(WebCore::makeSimpleRange): Added.

• dom/AbstractRange.h: Added.
• dom/AbstractRange.idl: Added.

• dom/Range.h: Changed to derive from AbstractRange instead of

from RefCounted. Also marked this final since it's now polymorphic.
Marked all the functions that override final as well, to check that
they correctly override the virtual functions in the base class.
Added private isLiveRange function override that returns true.
Added SPECIALIZE_TYPE_TRAITS_BEGIN/END so we can do is<Range>.

• dom/Range.idl: Removed ImplementationLacksVTable. Added

JSGenerateToNativeObject. Inherit from AbstractRange.
Removed the 5 attribute getters that are now inherited from AbstractRange.

• dom/StaticRange.h: Changed to derive from AbstractRange instead of

from RefCounted. Also marked this final since it's now polymorphic.
Added functions to override the ones from StaticRange, calling through
to the ones from SimpleRange (I thought there was a way to do this
with using, but I couldn't figure that out). Added private isLiveRange
function override that returns false. Added SPECIALIZE_TYPE_TRAITS_BEGIN/END
so we can do is<StaticRange>.

• dom/StaticRange.idl: Removed EnabledBySetting=InputEvents since

this should now always be included. I think we should probably remove the
InputEvents setting now entirely. Removed ImplementationLacksVTable.
Added JSGenerateToNativeObject. Inherit from AbstractRange.
Removed all 5 attribute getters, which are now inherited from AbstractRange.

11:30 AM Changeset in webkit [268647] by weinig@apple.com

• 6 edits
  4 adds in trunk/Source/WebKitLegacy

Source/WebKitLegacy:
[Preferences] Add infrastructure for generating preferences for Windows WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=217876

Reviewed by Simon Fraser.

• PlatformWin.cmake:

Add generation of WebPreferences.

Source/WebKitLegacy/win:
[Preferences] Add infrastructure for generating preferences for WWindows WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=217876

Reviewed by Simon Fraser.

• Scripts: Added.
• Scripts/PreferencesTemplates: Added.
• Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb: Added.
• Scripts/PreferencesTemplates/WebViewPreferencesChangedGenerated.cpp.erb: Added.

Adds mostly empty generated files to establish infrastructure for generation.

• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

• WebView.cpp:

(WebView::notifyPreferencesChanged):

• WebView.h:

Adopt generated files, which currently don't do anything.

11:28 AM Changeset in webkit [268646] by weinig@apple.com

• 2 edits in trunk/Source/WebKitLegacy/mac

Convert preferences in WebPreferencesPrivate.h to use @property syntax to make them more manageable
​https://bugs.webkit.org/show_bug.cgi?id=217877

Reviewed by Simon Fraser.

• WebView/WebPreferencesPrivate.h:

Switch to using the @property syntax. No behavior change intended, just a cleanup.

10:00 AM Changeset in webkit [268645] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Incorrect inline level box geometry
​https://bugs.webkit.org/show_bug.cgi?id=217875

Reviewed by Antti Koivisto.

While the generated runs have the correct geometry (they are painted at the correct position), the associated box
geometry is incorrect which results in broken render tree dumps and incorrect geometry related DOM values.
In this patch we use the correct LineBox API to get the InlineLevelBox's geometry (LineBox::InlineLevelBox::logicalRect is relative to the parent inline box and not relative to the line box).

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

7:36 AM Changeset in webkit [268644] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Atomic inline level box run height includes the vertical margin
​https://bugs.webkit.org/show_bug.cgi?id=217873

Reviewed by Antti Koivisto.

RenderBox::setLocation takes the border box location. Let's not include the margin before value.
(Atomic inline level box runs include the margin box per spec, see ​https://www.w3.org/TR/css-inline-3/#line-layout)

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):

7:20 AM Changeset in webkit [268643] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Remove redundant InlineFormattingContext::Geometry::LineRectAndLineBoxOffset
​https://bugs.webkit.org/show_bug.cgi?id=217872

Reviewed by Antti Koivisto.

After webkit.org/b/217832, the line box offset is always 0 (line space offsetting has moved to the inline box alignment).

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::computedLineLogicalRect const):

6:30 AM Changeset in webkit [268642] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][IFC] Introduce layout bounds based vertical alignment
​https://bugs.webkit.org/show_bug.cgi?id=217832

Reviewed by Antti Koivisto.

This patch introduces the layout bounds concept on the inline boxes.
It help with implementing ​https://www.w3.org/TR/css-inline-3/#line-layout (2.2. Layout Within Line Boxes)
where layout bounds are used extensively (essentially the layout bound drives the inline box's aligned vertical
position within the line box -as opposed to its logical height. Though they may match in many cases.)

With this patch nested inline boxes are positioned relative to their parent inline boxes and
LineBox::logicalRectForInlineLevelBox/logicalRectForTextRun resolves them to be relative to the line box (which then used for
generating display inline runs with relative to the line coordinates).

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::setVerticalGeometryForInlineBox const):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::alignInlineLevelBoxesVerticallyAndComputeLineBoxHeight):
(WebCore::Layout::InlineFormattingContext::Geometry::computedLineLogicalRect const):
(WebCore::Layout::LineBoxBuilder::adjustInlineBoxesLogicalHeight): Deleted.

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::logicalRectForTextRun const):
(WebCore::Layout::LineBox::logicalRectForInlineLevelBox const):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineLevelBox::LayoutBounds::height const):
(WebCore::Layout::LineBox::InlineLevelBox::setLayoutBounds):
(WebCore::Layout::LineBox::InlineLevelBox::layoutBounds const):
(WebCore::Layout::LineBox::InlineLevelBox::lineSpacing const): Deleted.
(WebCore::Layout::LineBox::InlineLevelBox::setLineSpacing): Deleted.

5:21 AM Changeset in webkit [268641] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Skip renderers with self-painting layers in painting code
​https://bugs.webkit.org/show_bug.cgi?id=217871

Reviewed by Zalan Bujtas.

Fixes fast/images/exif-orientation-background.html and similar.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):

2:59 AM Changeset in webkit [268640] by Ross Kirsling

• 25 edits
  1 move in trunk

Ensure %TypedArray% essential internal methods adhere to spec
​https://bugs.webkit.org/show_bug.cgi?id=217854

Reviewed by Yusuke Suzuki.

JSTests:

• stress/array-prototype-splice-making-typed-array.js:
• stress/array-species-config-array-constructor.js:
• stress/delete-property-dfg-inline.js:
• stress/float32array-out-of-bounds.js:
• stress/put-direct-index-broken-2.js:
• stress/typedarray-access-monomorphic-neutered.js:
• stress/typedarray-access-neutered.js:
• stress/typedarray-configure-index.js:
• stress/typedarray-functions-with-neutered.js:
• stress/typedarray-getownproperty.js: Renamed from JSTests/stress/typedarray-getownproperty-not-configurable.js.
• stress/typed-array-canonical-numeric-index-string.js:

Adjust tests.

• test262/expectations.yaml:

Address all test failures under built-ins/TypedArrayConstructors/internals.
Note that there are a slew of corrections needed for these test cases,
which were discovered in the course of working on this patch:
​https://github.com/tc39/test262/pull/2833#issuecomment-709635850
Accordingly, these remaining lines should all disappear in the future.

Source/JavaScriptCore:

This patch addresses ​https://github.com/tc39/ecma262/pull/2164,
which aligns detached buffer semantics in typed arrays with web reality.

In particular:

• HasProperty? must not throw
• IntegerIndexedElementGet (i.e. GetOwnProperty? and Get?) must not throw
• IntegerIndexedElementSet (i.e. DefineOwnProperty? and Set?) must not throw
• Integer-indexed elements must be Configurable? (to avoid breaking a HasProperty? invariant)
• Delete? must be overridden to return false for integer-indexed elements (which are *not* deletable)

This patch furthermore ensures that all of these essential internal methods have a spec-perfect implementation.

Note that there are a couple of interesting ripple effects here:

• The fill(), sort(), and set() methods should throw explicitly, but we'd been letting Get? throw instead.
• Other callback-taking methods should *not* throw anymore; they only did so implicitly via Get? and Set?.

• builtins/TypedArrayPrototype.js:

(fill):
(sort):

• runtime/JSGenericTypedArrayView.h:
• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::set):
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::deleteProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlotByIndex):
(JSC::JSGenericTypedArrayView<Adaptor>::deletePropertyByIndex):

• runtime/JSGlobalObjectFunctions.h:
• runtime/JSObjectInlines.h:

(JSC::JSObject::getPropertySlot):
(JSC::JSObject::getNonIndexPropertySlot):

• runtime/JSTypedArrays.cpp:

LayoutTests:

• fast/canvas/webgl/arraybuffer-transfer-of-control.html:
• js/dom/dfg-typed-array-neuter-expected.txt:
• js/dom/getOwnPropertyDescriptor-expected.txt:
• js/dom/script-tests/dfg-typed-array-neuter.js:
• js/resources/getOwnPropertyDescriptor.js:

Adjust tests.

1:16 AM Changeset in webkit [268639] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak SDK] flatpakutils.py reports "KeyError: 'gcc'" error if using with icecc and toolchains aren't generated yet
​https://bugs.webkit.org/show_bug.cgi?id=217799

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-10-17
Reviewed by Fujii Hironori.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): Gracefully exit with an error message when the icecc
configuration failed to complete.

12:06 AM Changeset in webkit [268638] by mmaxfield@apple.com

• 4 edits
  2 adds in trunk

REGRESSION(r268561): Synthetic oblique text is drawn upside-down
​https://bugs.webkit.org/show_bug.cgi?id=217867
<rdar://problem/70400846>

Reviewed by Darin Adler.

Source/WebCore:

I made a typo.

Test: fast/text/synthetic-oblique.html

• platform/graphics/FontCascade.h:

(WebCore::FontCascade::syntheticObliqueAngle):

• platform/graphics/coretext/FontCascadeCoreText.cpp:

(WebCore::computeOverallTextMatrix):

LayoutTests:

• fast/text/synthetic-oblique-expected.html: Added.
• fast/text/synthetic-oblique.html: Added.

Oct 16, 2020:

11:46 PM Changeset in webkit [268637] by commit-queue@webkit.org

• 16 edits
  3 moves in trunk/Source

Source/WebCore:
[GPU Process] Introduce RemoteResourceCache to manage the resources in the GPU Process
​https://bugs.webkit.org/show_bug.cgi?id=217554

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-10-16
Reviewed by Simon Fraser.

Add a new virtual method named ImageBuffer::flushDisplayList() which
applies a DisplayList to the ImageBuffer::context().

• platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::flushDisplayList):

Source/WebKit:
[GPU Process] Introduce RemoteResourceCacheProxy to manage the resources in the GPU Process
​https://bugs.webkit.org/show_bug.cgi?id=217554

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-10-16
Reviewed by Simon Fraser.

RemoteResourceCache will be responsible for caching the remote resources.
RemoteRenderingBackend will delegate all the resource caching to its
RemoteResourceCache.

We can get rid of RemoteImageBufferMessageHandler because all it does is
is sending messages to WebProcess. Removing it will simplify the interface
of RemoteImageBuffer. Sending the messages will be moved to RemoteRenderingBackend.

Rename flushDrawingContext() to flushDisplayList() because the name is
confusing. This function flushes a DisplayList to the context. No
DrawingContext is involved here and there is another function with the
same name which does not take any argument.

Rename ImageBufferFlushIdentifier to DisplayListFlushIdentifier to make
more general name and be ready for GPU DOM rendering.

Rename the RemoteRenderingBackendProxy messages: CreateImageBufferBackend
and CommitImageBufferFlushContext to be ImageBufferBackendWasCreated and
FlushDisplayListWasCommitted. We need to include passive verbs in them to
reflect that the actions were taken place in the GPU Process. They are
sent only to inform the Web Process with the current state.

• GPUProcess/graphics/RemoteImageBuffer.h:

(WebKit::RemoteImageBuffer::RemoteImageBuffer):
(WebKit::RemoteImageBuffer::apply):

• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::gpuConnectionToWebProcess const):
(WebKit::RemoteRenderingBackend::imageBufferBackendWasCreated):
(WebKit::RemoteRenderingBackend::flushDisplayListWasCommitted):
(WebKit::RemoteRenderingBackend::createImageBuffer):
(WebKit::RemoteRenderingBackend::flushDisplayList):
(WebKit::RemoteRenderingBackend::flushDisplayListAndCommit):
(WebKit::RemoteRenderingBackend::getImageData):
We should call the completion handler even if the ImageBuffer was not found.

(WebKit::RemoteRenderingBackend::releaseRemoteResource):
(WebKit::RemoteRenderingBackend::flushImageBufferDrawingContext): Deleted.
(WebKit::RemoteRenderingBackend::flushImageBufferDrawingContextAndCommit): Deleted.

• GPUProcess/graphics/RemoteRenderingBackend.h:

(WebKit::RemoteRenderingBackend::renderingBackendIdentifier const): Deleted.

• GPUProcess/graphics/RemoteRenderingBackend.messages.in:
• GPUProcess/graphics/RemoteResourceCache.cpp: Renamed from Source/WebKit/GPUProcess/graphics/RemoteImageBufferMessageHandler.cpp.

(WebKit::RemoteResourceCache::cacheImageBuffer):
(WebKit::RemoteResourceCache::cachedImageBuffer):
(WebKit::RemoteResourceCache::releaseRemoteResource):

• GPUProcess/graphics/RemoteResourceCache.h: Renamed from Source/WebKit/GPUProcess/graphics/RemoteImageBufferMessageHandler.h.
• Scripts/webkit/messages.py:
• Sources.txt:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/graphics/DisplayListFlushIdentifier.h: Renamed from Source/WebKit/WebProcess/GPU/graphics/ImageBufferFlushIdentifier.h.
• WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp:

(WebKit::RemoteImageBufferMessageHandlerProxy::waitForImageBufferBackendWasCreated):
(WebKit::RemoteImageBufferMessageHandlerProxy::waitForFlushDisplayListWasCommitted):
(WebKit::RemoteImageBufferMessageHandlerProxy::flushDisplayList):
(WebKit::RemoteImageBufferMessageHandlerProxy::flushDisplayListAndWaitCommit):
(WebKit::RemoteImageBufferMessageHandlerProxy::commitFlushContext):
(WebKit::RemoteImageBufferMessageHandlerProxy::waitForCreateImageBufferBackend): Deleted.
(WebKit::RemoteImageBufferMessageHandlerProxy::waitForCommitImageBufferFlushContext): Deleted.
(WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContext): Deleted.
(WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContextAndWaitCommit): Deleted.

• WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.h:
• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::waitForImageBufferBackendWasCreated):
(WebKit::RemoteRenderingBackendProxy::waitForFlushDisplayListWasCommitted):
(WebKit::RemoteRenderingBackendProxy::imageBufferBackendWasCreated):
(WebKit::RemoteRenderingBackendProxy::flushDisplayListWasCommitted):
(WebKit::RemoteRenderingBackendProxy::waitForCreateImageBufferBackend): Deleted.
(WebKit::RemoteRenderingBackendProxy::waitForCommitImageBufferFlushContext): Deleted.
(WebKit::RemoteRenderingBackendProxy::createImageBufferBackend): Deleted.
(WebKit::RemoteRenderingBackendProxy::commitImageBufferFlushContext): Deleted.

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in:

9:55 PM Changeset in webkit [268636] by Wenson Hsieh

• 6 edits in trunk

Add system trace points for flushing remote image buffers
​https://bugs.webkit.org/show_bug.cgi?id=217853

Reviewed by Simon Fraser.

Source/WebKit:

Add trace points to capture drawing context flushes. This encapsulates time spent encoding display lists in
preparation for IPC.

• WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp:

(WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContext):
(WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContextAndWaitCommit):

Source/WTF:

See WebKit ChangeLog for more details.

• wtf/SystemTracing.h:

Tools:

See WebKit ChangeLog for more details.

• Tracing/SystemTracePoints.plist:

9:39 PM Changeset in webkit [268635] by Devin Rousso

• 27 edits in trunk/Source

Web Inspector: rename Highlight so it doesn't conflict with CSS Highlight
​https://bugs.webkit.org/show_bug.cgi?id=217858

Reviewed by Megan Gardner.

No new tests as there is no behavior change since this is purely a rename.

Source/WebCore:

• inspector/InspectorOverlay.h:

(WebCore::InspectorOverlay::Highlight::setDataFromConfig): Added.
(WebCore::Highlight::Highlight): Deleted.
(WebCore::Highlight::setDataFromConfig): Deleted.

• inspector/InspectorOverlay.cpp:

(WebCore::buildRendererHighlight):
(WebCore::buildNodeHighlight):
(WebCore::buildQuadHighlight):
(WebCore::quadToPath):
(WebCore::drawOutlinedQuadWithClip):
(WebCore::drawOutlinedQuad):
(WebCore::drawFragmentHighlight):
(WebCore::drawShapeHighlight):
(WebCore::InspectorOverlay::getHighlight const):
(WebCore::InspectorOverlay::highlightNodeList):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::highlightQuad):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::drawBounds):
(WebCore::InspectorOverlay::drawElementTitle):

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightNodeList):
(WebCore::InspectorDOMAgent::highlightFrame):

• inspector/InspectorController.h:
• inspector/InspectorController.cpp:

(WebCore::InspectorController::getHighlight const):

• testing/Internals.cpp:

(WebCore::Internals::inspectorHighlightRects):

Source/WebKit:

• Scripts/webkit/messages.py:
• Shared/WebCoreArgumentCoders.h:
• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<InspectorOverlay::Highlight>::encode): Added.
(IPC::ArgumentCoder<InspectorOverlay::Highlight>::decode): Added.
(IPC::ArgumentCoder<Highlight>::encode): Deleted.
(IPC::ArgumentCoder<Highlight>::decode): Deleted.

• WebProcess/Inspector/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::showInspectorHighlight):

• UIProcess/ios/WKContentView.h:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView _showInspectorHighlight:]):

• UIProcess/WebPageProxy.messages.in:
• UIProcess/WebPageProxy.h:
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::showInspectorHighlight):

• UIProcess/PageClient.h:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::showInspectorHighlight):

• UIProcess/Inspector/ios/WKInspectorHighlightView.h:
• UIProcess/Inspector/ios/WKInspectorHighlightView.mm:

(-[WKInspectorHighlightView _layoutForNodeHighlight:offset:]):
(-[WKInspectorHighlightView _layoutForNodeListHighlight:]):
(-[WKInspectorHighlightView _layoutForRectsHighlight:]):
(-[WKInspectorHighlightView update:]):

Source/WebKitLegacy/mac:

• WebInspector/WebNodeHighlightView.mm:

(-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):
(-[WebNodeHighlightView _layoutForRectsHighlight:parent:]):
(-[WebNodeHighlightView layoutSublayers:]):

9:34 PM Changeset in webkit [268634] by Devin Rousso

• 4 edits
  2 adds in trunk

Web Inspector: REGRESSION(r266669): DOMBreakpoint.js:106:23: CONSOLE ASSERT ERROR domNode should not change once set
​https://bugs.webkit.org/show_bug.cgi?id=217865

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

• UserInterface/Models/DOMBreakpoint.js:

(WI.DOMBreakpoint.prototype.set domNode):
Adjust the assertion such that null is allowed if _domNode is already null.

• UserInterface/Base/Utilities.js:

(xor): Added.
Global utility function for doing a non-bitwise or that returns false if both values are
truthy/falsy and the truthy value if only one is truthy.

LayoutTests:

• inspector/unit-tests/utilities.html: Added.
• inspector/unit-tests/utilities-expected.txt: Added.

9:21 PM Changeset in webkit [268633] by rniwa@webkit.org

• 6 edits in trunk

IPC testing API should expose whether a given IPC message has sync reply or not
​https://bugs.webkit.org/show_bug.cgi?id=217861

Reviewed by Darin Adler.

Source/WebKit:

This patch adds IPC.messages.*.isSync to indicate whether a given IPC message has a sync reply or not.

Test: TestWebKitAPI.IPCTestingAPI.AlertIsSyncMessage

• Platform/IPC/MessageArgumentDescriptions.h:
• Scripts/webkit/messages.py:

(generate_js_value_conversion_function): Fixed a typo.
(generate_js_argument_descriptions): Ditto.
(generate_message_argument_description_implementation): Generate messageIsSync function.

• WebProcess/WebPage/IPCTestingAPI.cpp:

(WebKit::JSIPC::wrapperClass): Updated the class name to match the implementation.
(WebKit::IPCTestingAPI::JSIPC::messages): Added isSync as a boolean property on message description.

Tools:

Added a test for IPC.messages.*.isSync using RunJavaScriptAlert.

• TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:

(createWebViewWithIPCTestingAPI): Extracted to share more code between tests.
(IPCTestingAPI.AlertIsSyncMessage): Added.

9:18 PM Changeset in webkit [268632] by Peng Liu

• 16 edits
  2 moves
  2 adds
  1 delete in trunk/Source

[Media in GPU Process] Use CARingBuffer to transfer audio data of an audio destination from a web process to the GPU Process
​https://bugs.webkit.org/show_bug.cgi?id=217715

Reviewed by Jer Noble.

Source/WebCore:

Decouple the audio output unit management from AudioDestinationCocoa so that
we can run it remotely in other processes, like the GPU process.

No new tests, no behavior change.

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:

• platform/audio/AudioDestination.h: Export hardwareSampleRate().

• platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestination::create): Remove an unnecessary function call.
(WebCore::AudioDestinationCocoa::AudioDestinationCocoa): Add a parameter
configureAudioOutputUnit so that we can disable the AudioOutputUnitAdaptor in
AudioDestinationCocoa when we need to run the AudioOutputUnitAdaptor in another process.
(WebCore::AudioDestinationCocoa::start):
(WebCore::AudioDestinationCocoa::stop):
(WebCore::AudioDestinationCocoa::getAudioStreamBasicDescription):
Rename setAudioStreamBasicDescription() to getAudioStreamBasicDescription() because
the function essentially queries the description.
(WebCore::AudioDestinationCocoa::hasEnoughFrames const): Add this function
so that a subclass can check whether the FIFO has enough audio samples to render.
(WebCore::AudioDestinationCocoa::render): Replace the AudioTimeStamp* parameter
because we only need two fields of AudioTimeStamp in this function.
(WebCore::AudioDestinationCocoa::~AudioDestinationCocoa): Deleted.
(WebCore::AudioDestinationCocoa::setAudioStreamBasicDescription): Deleted.
(WebCore::AudioDestinationCocoa::inputProc): Deleted. This function is moved to
AudioOutputUnitAdaptor.

• platform/audio/cocoa/AudioDestinationCocoa.h:

(WebCore::AudioDestinationCocoa::outputUnit): Deleted.

• platform/audio/cocoa/AudioOutputUnitAdaptor.cpp: Added.

(WebCore::AudioOutputUnitAdaptor::AudioOutputUnitAdaptor):
(WebCore::AudioOutputUnitAdaptor::~AudioOutputUnitAdaptor):
(WebCore::AudioOutputUnitAdaptor::start):
(WebCore::AudioOutputUnitAdaptor::stop):
(WebCore::AudioOutputUnitAdaptor::inputProc):

• platform/audio/cocoa/AudioOutputUnitAdaptor.h: Added.
• platform/audio/ios/AudioOutputUnitAdaptorIOS.cpp: Renamed from Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp.

(WebCore::AudioOutputUnitAdaptor::configure):

• platform/audio/mac/AudioOutputUnitAdaptorMac.cpp: Renamed from Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp.

(WebCore::AudioOutputUnitAdaptor::configure):

• platform/mock/MockAudioDestinationCocoa.cpp:

(WebCore::MockAudioDestinationCocoa::tick):

Source/WebKit:

The current implementation of RemoteAudioDestination essentially runs the
AudioDestinationCocoa in the GPU process, which is not good because we are adding
AudioWorklet stuff into AudioDestinationCocoa, but the AudioWorklet stuff is
irrelevant to the GPU process.

What really needs to run in the GPU process (for Cocoa platforms at least) is the
audio output unit. This patch adds WebCore::AudioOutputUnitAdaptor and
WebCore::AudioUnitRenderer to implement that. With this patch, RemoteAudioDestination
in the GPU process is an AudioUnitRenderer and it embeds an AudioOutputUnitAdaptor
like AudioDestinationCocoa does in the Web process. Essentially, we run AudioOutputUnitAdaptor
remotely from the AudioDestinationCocoa's perspective.

Also, in the current implementation, the RemoteAudioDestinationProxy in a Web
process transfers audio data to the RemoteAudioDestination in the GPU process
with IPC messages (RemoteAudioBusData). This is not efficient because of the
large number of IPC messages for audio samples.

With this patch, RemoteAudioDestinationProxy (Web process) transfers audio samples
to RemoteAudioDestination(GPU process) with a CARingBuffer providing shared
buffers for the Web process and the GPU process.

• GPUProcess/media/RemoteAudioDestinationManager.cpp:

(WebKit::RemoteAudioDestination::create):
(WebKit::RemoteAudioDestination::~RemoteAudioDestination):
(WebKit::RemoteAudioDestination::audioSamplesStorageChanged):
(WebKit::RemoteAudioDestination::start):
(WebKit::RemoteAudioDestination::stop):
(WebKit::RemoteAudioDestination::isPlaying const):
(WebKit::RemoteAudioDestination::RemoteAudioDestination):
(WebKit::RemoteAudioDestination::storage):
(WebKit::RemoteAudioDestination::render):
(WebKit::RemoteAudioDestinationManager::createAudioDestination):
(WebKit::RemoteAudioDestinationManager::audioSamplesStorageChanged):
(WebKit::RemoteAudioDestination::isPlaying): Deleted.
(WebKit::RemoteAudioDestination::framesPerBuffer const): Deleted.

• GPUProcess/media/RemoteAudioDestinationManager.h:

(WebKit::RemoteAudioDestinationManager::didReceiveSyncMessageFromWebProcess):

• GPUProcess/media/RemoteAudioDestinationManager.messages.in:

Add a message AudioSamplesStorageChanged to support using CARingBuffer to
transmit audio samples to the GPU process.

• WebKit.xcodeproj/project.pbxproj:

• WebProcess/GPU/media/RemoteAudioBusData.h: Removed.

• WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:

(WebKit::RemoteAudioDestinationProxy::RemoteAudioDestinationProxy):
(WebKit::RemoteAudioDestinationProxy::start):
(WebKit::RemoteAudioDestinationProxy::stop):
(WebKit::RemoteAudioDestinationProxy::requestBuffer):
(WebKit::RemoteAudioDestinationProxy::renderOnRenderingThead):
(WebKit::RemoteAudioDestinationProxy::storageChanged):
(WebKit::RemoteAudioDestinationProxy::renderBuffer): Deleted.
(WebKit::RemoteAudioDestinationProxy::didChangeIsPlaying): Deleted.

• WebProcess/GPU/media/RemoteAudioDestinationProxy.h:

RemoteAudioDestinationProxy is a subclass of AudioDestinationCocoa. It pulls audio
samples from the WebAudio side and use a CARingBuffer to push audio samples to
the audio output unit (managed by RemoteAudioDestination) in the GPU process.

• WebProcess/GPU/media/RemoteAudioDestinationProxy.messages.in:

Add a message RequestBuffer, which can be used by RemoteAudioDestination to ask
for (pull) audio samples.

• WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:

(WebKit::AudioMediaStreamTrackRenderer::pushSamples): A minor fix to get rid of
a type conversion.

9:11 PM Changeset in webkit [268631] by Devin Rousso

• 6 edits in trunk

Web Inspector: REGRESSION(r266885): Controllers/ConsoleManager.js:177:27: CONSOLE ASSERT ERROR
​https://bugs.webkit.org/show_bug.cgi?id=217863

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

r266885 changed Console.getLoggingChannels to return any Console.ChannelSource that
existed, rather than a hardcoded list. Remove the similarly hardcoded list in the frontend.

• UserInterface/Controllers/ConsoleManager.js:

(WI.ConsoleManager):
(WI.ConsoleManager.prototype.initializeLogChannels):
(WI.ConsoleManager.prototype.get logChannelSources): Deleted.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype._messageAdded):

LayoutTests:

• inspector/console/webcore-logging.html:
• inspector/console/webcore-logging-expected.txt:

9:08 PM Changeset in webkit [268630] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r266885): LoggingChannel.js:31:23: CONSOLE ASSERT ERROR
​https://bugs.webkit.org/show_bug.cgi?id=217864

Reviewed by Timothy Hatcher.

r266885 changed Console.getLoggingChannels to return any Console.ChannelSource that
existed, rather than a hardcoded list. Remove the similarly hardcoded list in the frontend.

• UserInterface/Models/LoggingChannel.js:

(WI.LoggingChannel):

9:07 PM Changeset in webkit [268629] by Devin Rousso

• 3 edits
  3 adds in trunk

Web Inspector: REGRESSION(r266074): line-based JavaScript breakpoints don't hit after reload
​https://bugs.webkit.org/show_bug.cgi?id=217862

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::clearDebuggerBreakpointState):
Don't clear the list of protocol breakpoints when the global object changes. Protocol
breakpoints should only be cleared when individually removed or by Debugger.disable.

LayoutTests:

• inspector/debugger/resources/nested-calls.js: Added.

(inner):
(outer):

• inspector/debugger/breakpoint-resolve-when-script-added.html: Added.
• inspector/debugger/breakpoint-resolve-when-script-added-expected.txt: Added.

7:29 PM Changeset in webkit [268628] by jiewen_tan@apple.com

• 5 edits in trunk/Source

[WebAuthn] Add an experimental feature flag: WebAuthenticationModernEnabled
​https://bugs.webkit.org/show_bug.cgi?id=217843
<rdar://problem/70384187>

Reviewed by Brent Fulgham.

Source/WebKit:

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetWebAuthenticationModernEnabled):
(WKPreferencesGetWebAuthenticationModernEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WTF:

Add a new experimental feature flag to test the new WebAuthn process.

• Scripts/Preferences/WebPreferencesExperimental.yaml:

7:10 PM Changeset in webkit [268627] by dino@apple.com

• 2 edits in trunk/LayoutTests

Support accelerated animation of individual transform CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=217842
<rdar://problem/70391914>

Unreviewed. Mark some tests as failing on Mojave.

• platform/mac/TestExpectations:

6:50 PM Changeset in webkit [268626] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r266480): line-based JavaScript breakpoint tree element titles also show the file name
​https://bugs.webkit.org/show_bug.cgi?id=217859

Reviewed by Timothy Hatcher.

r266480 changed it such that WI.BreakpointTreeElement would only call updateTitles if
the constructor was not provided a title while also adding a fallback for title in the
constructor of WI.JavaScriptBreakpointTreeElement, ensuring that it would always be set
by the time it reached WI.BreakpointTreeElement, meaning that updateTitles would never
be called.

Since updateTitles was only implemented by WI.JavaScriptBreakpointTreeElement, remove
it from WI.BreakpointTreeElement and ensure that it is always called for non-special
JavaScript breakpoints (in addition to whenever the WI.SourceCodeLocation changes).

• UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.updateTitles): Deleted.

• UserInterface/Views/JavaScriptBreakpointTreeElement.js:

(WI.JavaScriptBreakpointTreeElement):
(WI.JavaScriptBreakpointTreeElement.prototype._updateTitles): Added.
(WI.JavaScriptBreakpointTreeElement.prototype._breakpointLocationDidChange):
(WI.JavaScriptBreakpointTreeElement.prototype.updateTitles): Deleted.

6:04 PM Changeset in webkit [268625] by Ryan Haddad

• 22 edits
  1 delete in trunk/LayoutTests

Unreviewed, reverting r268620.

Breaks tests for Catalina and Mojave

Reverted changeset:

"Rebaseline tests for Big Sur after the changes in r268520"
​https://bugs.webkit.org/show_bug.cgi?id=209813
​https://trac.webkit.org/changeset/268620

5:41 PM Changeset in webkit [268624] by Russell Epstein

• 1 copy in tags/Safari-610.3.4

Tag Safari-610.3.4.

5:23 PM Changeset in webkit [268623] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION (r262708): [ Mojave debug wk2 ] imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-stop.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=217857

Unreviewed test gardening.
Changing test expectation for Mojave+ coverage

• platform/mac-wk2/TestExpectations:

5:07 PM Changeset in webkit [268622] by Russell Epstein

• 1 copy in tags/Safari-610.2.11.51.2

Tag Safari-610.2.11.51.2.

5:06 PM Changeset in webkit [268621] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION (r262708): [ Mojave debug wk2 ] imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-stop.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=217857

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:49 PM Changeset in webkit [268620] by Truitt Savell

• 22 edits
  1 add in trunk/LayoutTests

Rebaseline tests for Big Sur after the changes in r268520
​https://bugs.webkit.org/show_bug.cgi?id=209813

Unreviewed test gardening.

• platform/mac/editing/selection/3690703-2-expected.txt:
• platform/mac/editing/selection/3690703-expected.txt:
• platform/mac/editing/selection/3690719-expected.txt:
• platform/mac/fast/block/basic/001-expected.txt:
• platform/mac/fast/block/float/float-avoidance-expected.txt:
• platform/mac/fast/css/rtl-ordering-expected.txt:
• platform/mac/fast/forms/basic-inputs-expected.txt:
• platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
• platform/mac/fast/forms/input-disabled-color-expected.txt:
• platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac/fast/forms/option-text-clip-expected.txt:
• platform/mac/fast/forms/plaintext-mode-2-expected.txt:
• platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:
• platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac/fast/forms/textfield-outline-expected.txt:
• platform/mac/fast/text/indic-expected.txt:
• platform/mac/fast/text/javascriptlink-frames-expected.txt: Added.
• platform/mac/media/video-display-toggle-expected.txt:
• platform/mac/media/video-volume-slider-expected.txt:
• platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
• platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
• platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:

4:07 PM Changeset in webkit [268619] by Karl Rackler

• 4 edits in trunk

Unreviewed, reverting r268178.

This reverts commit r268178 because it caused a test failure.

Reverted changeset:

"Fix image-loading-lazy-multiple-times.html"
​https://bugs.webkit.org/show_bug.cgi?id=216979
​https://trac.webkit.org/changeset/268178

3:57 PM Changeset in webkit [268618] by Russell Epstein

• 4 edits in branches/safari-610.2.11.51-branch/Source

Revert "Cherry-pick r268367. rdar://problem/70320656"

This reverts commit r268512.

3:57 PM Changeset in webkit [268617] by Russell Epstein

• 2 edits in branches/safari-610.2.11.51-branch/Source/WebKit

Revert "Cherry-pick r268377. rdar://problem/70320656"

This reverts commit r268513.

3:46 PM Changeset in webkit [268616] by graouts@webkit.org

• 7 edits in trunk

Enable individual CSS transform properties by default
​https://bugs.webkit.org/show_bug.cgi?id=217849
<rdar://problem/70052493>

Reviewed by Dean Jackson.

Source/WebKitLegacy/win:

• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

Source/WTF:

• Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

• DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

3:43 PM Changeset in webkit [268615] by graouts@webkit.org

• 17 edits
  10 adds in trunk

Support accelerated animation of individual transform CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=217842
<rdar://problem/70391914>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-transforms/animation/rotate-interpolation-expected.txt:
• web-platform-tests/css/css-transforms/animation/scale-interpolation-expected.txt:
• web-platform-tests/css/css-transforms/animation/translate-interpolation-expected.txt:

Source/WebCore:

In order to support accelerated animation of individual transform CSS properties, we make a list of the
various animations targeting animation-related properties in GraphicsLayerCA::updateAnimations() and apply
an animation for each of those properties in their expected application order – translate, scale, rotate and
then transform – using Core Animation's additive animation mode.

When one of those properties does not have an animation, we create a non-interpolating base transform value
animation set with both from and to values matching the value set in CSS for this particular property. We use
a new transformMatrixForProperty() method on the GraphicsLayerClient to obtain this value.

We also add a non-additive, non-interpolating identity transform first to make sure all the additive animations
build on top of a neutral transform and not the underlying value applied to the layer.

Finally, when GraphicsLayerCA::setTransform() is updated, we update the animations to ensure that any base
transform value animation is updated to match the current value of the CSS properties contributing to the
compound layer transform.

Tests: webanimations/accelerated-transform-related-animation-property-order.html

webanimations/accelerated-translate-animation-additional-animation-added-in-flight.html
webanimations/accelerated-translate-animation-underlying-transform-changed-in-flight.html
webanimations/accelerated-translate-animation-with-transform.html
webanimations/accelerated-translate-animation.html

• animation/CSSPropertyAnimation.cpp: Add the necessary animationIsAccelerated() overrides for each of the

individual CSS transform property animation wrappers to indicate that accelerated animations are supported.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::validateTransformOperations): Update the ASSERT to check that the animated property
is any of the transform-related properties.

• platform/graphics/GraphicsLayer.h:

(WebCore::TransformAnimationValue::TransformAnimationValue): Add a new constructor that takes a single TransformOperation*
value as input instead of a TransformOperations& so that the values coming from the individual CSS transform properties
can be used to create a TransformAnimationValue in RenderLayerBacking::startAnimation().

• platform/graphics/GraphicsLayerClient.h: Add the new animated property identifiers for the individual CSS transform properties.

(WebCore::animatedPropertyIsTransformOrRelated): Add a new utility to identify any of the transform-related animated property
identifiers.
(WebCore::GraphicsLayerClient::transformMatrixForProperty const): New method called from GraphicsLayerCA::updateAnimations()
to query the client, such as RenderLayerBacking, for the TransformationMatrix representing a given CSS property value to be
used for base transform value non-interpolating animations.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::propertyIdToString): Account for the new animated property identifiers.
(WebCore::GraphicsLayerCA::setTransform): If we are currently running a transform-related animation, a change in underlying
transform value means we must re-evaluate all transform-related animations to ensure that the base value transform animations
are current.
(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::updateAnimations): When updating animations, keep track of the most recent animation applicable to each
individual CSS transform property and the list of animations targeting the transform CSS property. Then, ensure those animations
are applied in the specified order – translate, scale, rotate and transform – by adding those animations as additive CA animations
with non-interpolating base transform value animations for each property that does not have a specified interpolating animation.
(WebCore::GraphicsLayerCA::isRunningTransformAnimation const): Ensure we also consider paused animations as "running" animations.
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations): Whether a transform animation needs to be run using the additive mode
is now determined in updateAnimations() so we remove all code related to working out whether animations ought to be additive.
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): We force the creation of CATransform3D values for individual
CSS transform properties since only this mode guarantees that additivity of such animations will yield the expected result where
the transforms are multiplied rather than simply adding float values of individual components.

• platform/graphics/ca/GraphicsLayerCA.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation): Ensure we start animations for the individual CSS transform properties.
(WebCore::RenderLayerBacking::graphicsLayerToCSSProperty):
(WebCore::RenderLayerBacking::cssToGraphicsLayerProperty):
(WebCore::RenderLayerBacking::transformMatrixForProperty const): Implement the new GraphicsLayerClient method to provide a
matrix that can be used as a value for non-interpolating base value transform animations in GraphicsLayerCA::updateAnimations()
for any of the transform-related CSS properties.

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const): Ensure that an animation for any of the transform-related
CSS properties yields composition of the target layer.
(WebCore::RenderLayerCompositor::isRunningTransformAnimation const):

• rendering/style/WillChangeData.cpp:

(WebCore::propertyTriggersCompositingOnBoxesOnly): Ensure that setting the will-change CSS property to any of the transform-related
CSS properties yields composition of the target.

LayoutTests:

Add some new tests that check animations of individual CSS transform properties can be performed,
checking on their relative order with the transform property, updating the transform property while
an animation is in flight and adding animations while in flight.

• TestExpectations:
• webanimations/accelerated-transform-related-animation-property-order-expected.html: Added.
• webanimations/accelerated-transform-related-animation-property-order.html: Added.
• webanimations/accelerated-translate-animation-additional-animation-added-in-flight-expected.html: Added.
• webanimations/accelerated-translate-animation-additional-animation-added-in-flight.html: Added.
• webanimations/accelerated-translate-animation-expected.html: Added.
• webanimations/accelerated-translate-animation-underlying-transform-changed-in-flight-expected.html: Added.
• webanimations/accelerated-translate-animation-underlying-transform-changed-in-flight.html: Added.
• webanimations/accelerated-translate-animation-with-transform-expected.html: Added.
• webanimations/accelerated-translate-animation-with-transform.html: Added.
• webanimations/accelerated-translate-animation.html: Added.

3:41 PM Changeset in webkit [268614] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION(268444?): [ Win10 wk1 ews ] transforms/2d/rotate-composited.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217812

Unreviewed test gardening.

• platform/win/TestExpectations:

3:23 PM Changeset in webkit [268613] by jiewen_tan@apple.com

• 11 edits in trunk

[WebAuthn] Remove experimental feature flag: WebAuthenticationLocalAuthenticatorEnabled
​https://bugs.webkit.org/show_bug.cgi?id=217796
<rdar://problem/70358912>

Reviewed by Brent Fulgham.

Source/WebCore:

• Modules/webauthn/PublicKeyCredential.cpp:

(WebCore::PublicKeyCredential::isUserVerifyingPlatformAuthenticatorAvailable):

• page/Settings.yaml:

Source/WebKit:

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetWebAuthenticationLocalAuthenticatorEnabled): Deleted.
(WKPreferencesGetWebAuthenticationLocalAuthenticatorEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::filterTransports const):
(WebKit::WebCore::isFeatureEnabled): Deleted.

Source/WTF:

The feature is now shipped. Let's remove the experimental feature flag.

• Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(TestWebKitAPI::TEST):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

• WebKitTestRunner/TestOptions.cpp:

(WTR::boolDefaultsMap):
(WTR::keyTypeMap):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::enableWebAuthentication const):
(WTR::TestOptions::enableWebAuthenticationLocalAuthenticator const): Deleted.

3:20 PM Changeset in webkit [268612] by commit-queue@webkit.org

• 12 edits
  13 moves
  1 add
  1 delete in trunk/Source/WebKit

[GPU Process] Exchange RemoteImageBuffer and RemoteImageBufferProxy
​https://bugs.webkit.org/show_bug.cgi?id=217809

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-10-16
Reviewed by Simon Fraser.

The names of the GPU rendering classes have been confusing. RemoteImageBuffer
should be the real object in the GPU Process because it owns the backend.
And RemoteImageBufferProxy should be a proxy to this object in the Web
Process. So we are going to exchange the following classes:

-- RemoteImageBuffer <-> RemoteImageBufferProxy
-- RemoteRenderingBackend <-> RemoteRenderingBackendProxy
-- RemoteImageBufferMessageHandler <-> RemoteImageBufferMessageHandlerProxy

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources.make:
• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::createRenderingBackend):
(WebKit::GPUConnectionToWebProcess::releaseRenderingBackend):

• GPUProcess/GPUConnectionToWebProcess.h:
• GPUProcess/graphics/PlatformRemoteImageBuffer.h: Renamed from Source/WebKit/WebProcess/GPU/graphics/PlatformRemoteImageBuffer.h.
• GPUProcess/graphics/RemoteImageBuffer.h: Renamed from Source/WebKit/GPUProcess/graphics/RemoteImageBufferProxy.h.

(WebKit::RemoteImageBuffer::create):
(WebKit::RemoteImageBuffer::RemoteImageBuffer):
(WebKit::RemoteImageBuffer::~RemoteImageBuffer):
(WebKit::RemoteImageBuffer::apply):

• GPUProcess/graphics/RemoteImageBufferMessageHandler.cpp: Renamed from Source/WebKit/GPUProcess/graphics/RemoteImageBufferMessageHandlerProxy.cpp.

(WebKit::RemoteImageBufferMessageHandler::RemoteImageBufferMessageHandler):
(WebKit::RemoteImageBufferMessageHandler::createBackend):
(WebKit::RemoteImageBufferMessageHandler::commitFlushContext):

• GPUProcess/graphics/RemoteImageBufferMessageHandler.h: Renamed from Source/WebKit/GPUProcess/graphics/RemoteImageBufferMessageHandlerProxy.h.

(WebKit::RemoteImageBufferMessageHandler::backend):

• GPUProcess/graphics/RemoteRenderingBackend.cpp: Renamed from Source/WebKit/GPUProcess/graphics/RemoteRenderingBackendProxy.cpp.

(WebKit::RemoteRenderingBackend::create):
(WebKit::RemoteRenderingBackend::RemoteRenderingBackend):
(WebKit::RemoteRenderingBackend::~RemoteRenderingBackend):
(WebKit::RemoteRenderingBackend::messageSenderConnection const):
(WebKit::RemoteRenderingBackend::messageSenderDestinationID const):
(WebKit::RemoteRenderingBackend::createImageBuffer):
(WebKit::RemoteRenderingBackend::releaseRemoteResource):
(WebKit::RemoteRenderingBackend::getImageData):
(WebKit::RemoteRenderingBackend::flushImageBufferDrawingContext):
(WebKit::RemoteRenderingBackend::flushImageBufferDrawingContextAndCommit):
(WebKit::RemoteRenderingBackend::gpuConnectionToWebProcess const):

• GPUProcess/graphics/RemoteRenderingBackend.h: Renamed from Source/WebKit/GPUProcess/graphics/RemoteRenderingBackendProxy.h.

(WebKit::RemoteRenderingBackend::renderingBackendIdentifier const):

• GPUProcess/graphics/RemoteRenderingBackend.messages.in: Renamed from Source/WebKit/GPUProcess/graphics/RemoteRenderingBackendProxy.messages.in.
• GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
• Sources.txt:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/graphics/PlatformRemoteImageBufferProxy.h: Renamed from Source/WebKit/GPUProcess/graphics/PlatformRemoteImageBufferProxy.h.
• WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.cpp: Removed.
• WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp: Added.

(WebKit::RemoteImageBufferMessageHandlerProxy::RemoteImageBufferMessageHandlerProxy):
(WebKit::RemoteImageBufferMessageHandlerProxy::~RemoteImageBufferMessageHandlerProxy):
(WebKit::RemoteImageBufferMessageHandlerProxy::getImageData const):
(WebKit::RemoteImageBufferMessageHandlerProxy::waitForCreateImageBufferBackend):
(WebKit::RemoteImageBufferMessageHandlerProxy::waitForCommitImageBufferFlushContext):
(WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContext):
(WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContextAndWaitCommit):
(WebKit::RemoteImageBufferMessageHandlerProxy::commitFlushContext):

• WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.h: Renamed from Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.h.

(WebKit::RemoteImageBufferMessageHandlerProxy::remoteResourceIdentifier const):
(WebKit::RemoteImageBufferMessageHandlerProxy::isPendingFlush const):

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h: Renamed from Source/WebKit/WebProcess/GPU/graphics/RemoteImageBuffer.h.

(WebKit::RemoteImageBufferProxy::create):
(WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy):
(WebKit::RemoteImageBufferProxy::RemoteImageBufferProxy):
(WebKit::RemoteImageBufferProxy::putImageData):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: Renamed from Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackend.cpp.

(WebKit::RemoteRenderingBackendProxy::create):
(WebKit::RemoteRenderingBackendProxy::RemoteRenderingBackendProxy):
(WebKit::RemoteRenderingBackendProxy::~RemoteRenderingBackendProxy):
(WebKit::RemoteRenderingBackendProxy::messageSenderConnection const):
(WebKit::RemoteRenderingBackendProxy::messageSenderDestinationID const):
(WebKit::RemoteRenderingBackendProxy::waitForCreateImageBufferBackend):
(WebKit::RemoteRenderingBackendProxy::waitForCommitImageBufferFlushContext):
(WebKit::RemoteRenderingBackendProxy::createImageBuffer):
(WebKit::RemoteRenderingBackendProxy::releaseRemoteResource):
(WebKit::RemoteRenderingBackendProxy::createImageBufferBackend):
(WebKit::RemoteRenderingBackendProxy::commitImageBufferFlushContext):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: Renamed from Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackend.h.

(WebKit::RemoteRenderingBackendProxy::renderingBackendIdentifier const):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in: Renamed from Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackend.messages.in.
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::ensureRemoteRenderingBackendProxy const):
(WebKit::WebChromeClient::createImageBuffer const):
(WebKit::WebChromeClient::ensureRemoteRenderingBackend const): Deleted.

• WebProcess/WebCoreSupport/WebChromeClient.h:

3:13 PM Changeset in webkit [268611] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GLIB][GTK] Unreviewed test expectations. Update test expectations after r268606.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

2:51 PM Changeset in webkit [268610] by Andres Gonzalez

• 7 edits in trunk/Source/WebCore

Revert AXCoreObject::topDocumentFrameView change that caused build failure on iOS debug.
​https://bugs.webkit.org/show_bug.cgi?id=217841

Reviewed by Chris Fleizach.

No change in functionality, reverting part of previous re-work.

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityObjectInterface.h:
• accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::convertRectToPlatformSpace const):
(WebCore::AccessibilityObject::topDocumentFrameView const): Deleted.

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityWebDocumentView]):

• accessibility/isolatedtree/AXIsolatedObject.h:
• accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::topDocumentFrameView const): Deleted.

2:16 PM BuildingGtk edited by Lauro Moura

Added info about reusing the UserFlatpak directory. (diff)

2:00 PM Changeset in webkit [268609] by Matt Lewis

• 2 edits in trunk/Tools

Move EWS to new SDKs: iOS 14.
​https://bugs.webkit.org/show_bug.cgi?id=217840

Reviewed by Aakash Jain.

• BuildSlaveSupport/ews-build/config.json:

1:10 PM Changeset in webkit [268608] by eric.carlson@apple.com

• 12 edits
  3 adds in trunk

[GPU Process] Implement VideoPlaybackMetrics
​https://bugs.webkit.org/show_bug.cgi?id=217439
<rdar://problem/60179370>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/video-playback-quality.html

• Headers.cmake:
• WebCore.xcodeproj/project.pbxproj:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getVideoPlaybackQuality):

• platform/graphics/MediaPlayer.h:
• platform/graphics/VideoPlaybackQualityMetrics.h: Added.

(WebCore::VideoPlaybackQualityMetrics::encode const):
(WebCore::VideoPlaybackQualityMetrics::decode):

Source/WebKit:

• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::outOfBandTrackSources):
(WebKit::RemoteMediaPlayerProxy::updateCachedState):
(WebKit::RemoteMediaPlayerProxy::setShouldUpdatePlaybackMetrics):

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::videoPlaybackQualityMetrics):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/RemoteMediaPlayerState.h:

(WebKit::RemoteMediaPlayerState::encode const):
(WebKit::RemoteMediaPlayerState::decode):

LayoutTests:

• media/video-playback-quality-expected.txt: Added.
• media/video-playback-quality.html: Added.

1:09 PM Changeset in webkit [268607] by eric.carlson@apple.com

• 17 edits in trunk/Source

[GPU Process] Implement mediaPlayerGetRawCookies
​https://bugs.webkit.org/show_bug.cgi?id=217739
<rdar://problem/70313370>

Reviewed by Youenn Fablet.

Source/WebCore:

Plumb mediaPlayerGetRawCookies through from the GPU process to the Web process,
which is used to provide site cookies to AVFoundation for AirPlay. This has always
been a synchronous API, which we don't want between processes, so change the interface
to take a completion handler and restructure the caller to use it.

Tested manually.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerGetRawCookies const):

• html/HTMLMediaElement.h:
• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::getRawCookies const):

• platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerGetRawCookies const):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):

Source/WebKit:

• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::mediaPlayerGetRawCookies const):

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::getRawCookies const):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:

12:44 PM Changeset in webkit [268606] by ddkilzer@apple.com

• 2 edits in trunk/Source/WTF

Open source clang warning: bitwise operation between different enumeration types [-Wenum-enum-conversion]
<​https://webkit.org/b/217805>
<rdar://problem/70250742>

Reviewed by Darin Adler.

• wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl::s_hashZeroValue): Add.
(WTF::StringImpl::StringImpl):

• Use s_hashZeroValue as first value in bitwise-or expression so that enums are converted automatically to unsigned values.

12:38 PM Changeset in webkit [268605] by jiewen_tan@apple.com

• 26 edits
  9 copies
  1 move
  19 adds
  1 delete in trunk/Source

[WebAuthn] Implement a dummy WebAuthnProcess
​https://bugs.webkit.org/show_bug.cgi?id=217559
<rdar://problem/70168749>

Reviewed by Brent Fulgham.

Source/WebCore:

No tests.

• en.lproj/Localizable.strings:

Provides a name for the WebAuthn process.

Source/WebKit:

Previous patch r268248 introduces a new daemon to handle all WebAuthn requests. However, after more deeper investigations, the daemon
story is not very compelling for WebKit. Here are the two major road blockers:
1) The major one is on macOS. New daemons cannot be installed without a system update. It means relocatable Safari (e.g. STP)
and staged Safari on downlevel OSes will not get this feature. And relocatable STP can only utilize the system daemon. This
seems a bummer especially for the STP case given it is heavily used to test latest web features.
2) Additional plumbing is needed for testing and engineering builds. This problem is specific to WebKit and is on both macOS and iOS.
WebKit doesn't build roots to test engineering builds, which is required to update the plist on the above location. Hence, a separate
configuration is needed to generate a different plist that points to the right engineering binary and additional scripts will be needed
to ask launchd to load the plist before running any tests. Some extra exercises are probably needed to not confuse launchd about the
engineering binary and system binary as well.

Given the above constraints, a new architecture is proposed to make the daemon a WebKit XPC service/process instead and leave the launchd
event handler to a new Safari daemon. The launchd related feature is only on iOS and therefore it really doesn't make sense to overcome
all the above macOS constraints. Having different architectures on iOS (a daemon) and on macOS (a XPC service) accordingly will introduce
tons of overhead for maintainance as well. That's why relying on a Safari daemon to do the job is the most reasonable option.

This patch therefore focuses on making the WebAuthn process happen and removes the WebAuthn daemon.

• CMakeLists.txt:
• Configurations/WebAuthnService.xcconfig: Renamed from Source/WebKit/Configurations/WebAuthenticationAgent.xcconfig.
• Configurations/WebKit.xcconfig:
• Daemons/WebAuthenticationAgent/WebAuthenticationAgent.entitlements: Removed.
• Daemons/WebAuthenticationAgent/com.apple.webkit.WebAuthenticationAgent.plist: Removed.
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:

Paperwork for building the new WebAuthn process.

• Platform/ExtraPrivateSymbolsForTAPI.h:
• Shared/AuxiliaryProcess.h:
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):

• Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::processStorageClass):
(WebKit::sandboxDirectory):
Paperwork for introducing the new WebAuthn process. Mostly copied from GPU process.

• Sources.txt:
• SourcesCocoa.txt:

Paperwork for building the new WebAuthn process.

• UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::getLaunchOptions):

• UIProcess/Launcher/ProcessLauncher.h:
• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName):
(WebKit::shouldLeakBoost):

• UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp: Added.

(WebKit::WebAuthnProcessProxy::singleton):
(WebKit::WebAuthnProcessProxy::WebAuthnProcessProxy):
(WebKit::WebAuthnProcessProxy::getLaunchOptions):
(WebKit::WebAuthnProcessProxy::connectionWillOpen):
(WebKit::WebAuthnProcessProxy::processWillShutDown):
(WebKit::WebAuthnProcessProxy::getWebAuthnProcessConnection):
(WebKit::WebAuthnProcessProxy::webAuthnProcessCrashed):
(WebKit::WebAuthnProcessProxy::didClose):
(WebKit::WebAuthnProcessProxy::didReceiveInvalidMessage):
(WebKit::WebAuthnProcessProxy::didFinishLaunching):
(WebKit::WebAuthnProcessProxy::updateProcessAssertion):

• UIProcess/WebAuthentication/WebAuthnProcessProxy.h: Added.
• UIProcess/WebAuthentication/WebAuthnProcessProxy.messages.in: Added.
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::getWebAuthnProcessConnection):

• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getWebAuthnProcessConnection):

• UIProcess/WebProcessProxy.h:
• UIProcess/WebProcessProxy.messages.in:
• WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-OSX.plist: Copied from Source/WebKit/Daemons/WebAuthenticationAgent/Info.plist.
• WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist: Renamed from Source/WebKit/Daemons/WebAuthenticationAgent/Info.plist.
• WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnServiceEntryPoint.mm: Copied from Source/WebKit/Daemons/WebAuthenticationAgent/main.mm.

(WebKit::WebAuthnServiceInitializerDelegate::WebAuthnServiceInitializerDelegate):
(WebKit::initializeAuxiliaryProcess<WebAuthnProcess>):
(WEBAUTHEN_SERVICE_INITIALIZER):

• WebAuthnProcess/WebAuthnConnectionToWebProcess.cpp: Added.

(WebKit::WebAuthnConnectionToWebProcess::create):
(WebKit::WebAuthnConnectionToWebProcess::WebAuthnConnectionToWebProcess):
(WebKit::WebAuthnConnectionToWebProcess::~WebAuthnConnectionToWebProcess):
(WebKit::WebAuthnConnectionToWebProcess::didClose):
(WebKit::WebAuthnConnectionToWebProcess::didReceiveInvalidMessage):

• WebAuthnProcess/WebAuthnConnectionToWebProcess.h: Copied from Source/WebKit/Daemons/WebAuthenticationAgent/main.mm.

(WebKit::WebAuthnConnectionToWebProcess::connection):
(WebKit::WebAuthnConnectionToWebProcess::WebAuthnProcessProcess):
(WebKit::WebAuthnConnectionToWebProcess::webProcessIdentifier const):

• WebAuthnProcess/WebAuthnConnectionToWebProcess.messages.in: Added.
• WebAuthnProcess/WebAuthnProcess.cpp: Added.

(WebKit::WebAuthnProcess::WebAuthnProcess):
(WebKit::WebAuthnProcess::~WebAuthnProcess):
(WebKit::WebAuthnProcess::createWebAuthnConnectionToWebProcess):
(WebKit::WebAuthnProcess::removeWebAuthnConnectionToWebProcess):
(WebKit::WebAuthnProcess::connectionToWebProcessClosed):
(WebKit::WebAuthnProcess::shouldTerminate):
(WebKit::WebAuthnProcess::didClose):
(WebKit::WebAuthnProcess::lowMemoryHandler):
(WebKit::WebAuthnProcess::initializeWebAuthnProcess):
(WebKit::WebAuthnProcess::prepareToSuspend):
(WebKit::WebAuthnProcess::processDidResume):
(WebKit::WebAuthnProcess::resume):
(WebKit::WebAuthnProcess::processDidTransitionToForeground):
(WebKit::WebAuthnProcess::processDidTransitionToBackground):
(WebKit::WebAuthnProcess::webProcessConnection const):

• WebAuthnProcess/WebAuthnProcess.h: Added.
• WebAuthnProcess/WebAuthnProcess.messages.in: Added.
• WebAuthnProcess/WebAuthnProcessCreationParameters.cpp: Copied from Source/WebKit/Daemons/WebAuthenticationAgent/main.mm.

(WebKit::WebAuthnProcessCreationParameters::encode const):
(WebKit::WebAuthnProcessCreationParameters::decode):

• WebAuthnProcess/WebAuthnProcessCreationParameters.h: Copied from Source/WebKit/Daemons/WebAuthenticationAgent/main.mm.
• WebAuthnProcess/ios/WebAuthnProcessIOS.mm: Copied from Source/WebKit/Daemons/WebAuthenticationAgent/main.mm.

(WebKit::WebAuthnProcess::initializeProcess):
(WebKit::WebAuthnProcess::initializeProcessName):
(WebKit::WebAuthnProcess::initializeSandbox):

• WebAuthnProcess/mac/WebAuthnProcessMac.mm: Added.

(WebKit::WebAuthnProcess::initializeProcess):
(WebKit::WebAuthnProcess::initializeProcessName):
(WebKit::WebAuthnProcess::initializeSandbox):
Paperwork for introducing the new WebAuthn process. Mostly copied from GPU process.

• WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in: Added.

The sandbox profile is originally from the GPU Process with IOKit related rules removed. Will tighten it again after the process is fully functional.

• WebKit.xcodeproj/project.pbxproj:

Paperwork for building the new WebAuthn process.

• WebProcess/WebAuthentication/WebAuthnProcessConnection.cpp: Copied from Source/WebKit/Daemons/WebAuthenticationAgent/main.mm.

(WebKit::WebAuthnProcessConnection::WebAuthnProcessConnection):
(WebKit::WebAuthnProcessConnection::~WebAuthnProcessConnection):
(WebKit::WebAuthnProcessConnection::didClose):
(WebKit::WebAuthnProcessConnection::didReceiveInvalidMessage):

• WebProcess/WebAuthentication/WebAuthnProcessConnection.h: Renamed from Source/WebKit/Daemons/WebAuthenticationAgent/main.mm.

(WebKit::WebAuthnProcessConnection::create):
(WebKit::WebAuthnProcessConnection::connection):

• WebProcess/WebAuthentication/WebAuthnProcessConnection.messages.in: Added.
• WebProcess/WebAuthentication/WebAuthnProcessConnectionInfo.h: Added.

(WebKit::WebAuthnProcessConnectionInfo::identifier const):
(WebKit::WebAuthnProcessConnectionInfo::releaseIdentifier):
(WebKit::WebAuthnProcessConnectionInfo::encode const):
(WebKit::WebAuthnProcessConnectionInfo::decode):

• WebProcess/WebProcess.cpp:

(WebKit::getWebAuthnProcessConnection):
(WebKit::WebProcess::ensureWebAuthnProcessConnection):
(WebKit::WebProcess::webAuthnProcessConnectionClosed):

• WebProcess/WebProcess.h:

(WebKit::WebProcess::existingWebAuthnProcessConnection):
Paperwork for introducing the new WebAuthn process. Mostly copied from GPU process.

12:37 PM Changeset in webkit [268604] by weinig@apple.com

• 11 edits
  2 adds in trunk/Tools

[Testing] Support configuring any preference from test headers for WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=217645

Reviewed by Tim Horton.

Support using any preference defined in any of the WebPreference*.yaml configuration files
as a test header command rather than limiting it to a hard coded subset by generating the
list of supported commands and their types from the yaml files themselves.

This currently only works for WebKitTestRunner, but will be made to work with DumpRenderTree
in subsequent changes.

• WebKitTestRunner/CMakeLists.txt:
• WebKitTestRunner/Configurations/Base.xcconfig:
• WebKitTestRunner/DerivedSources-input.xcfilelist:
• WebKitTestRunner/DerivedSources-output.xcfilelist:
• WebKitTestRunner/DerivedSources.make:
• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
• WebKitTestRunner/Scripts/PreferencesTemplates: Added.
• WebKitTestRunner/Scripts/PreferencesTemplates/TestOptionsGeneratedKeys.h.erb: Added.

Add generation of TestOptionsGeneratedKeys.h from the WebPreference*.yaml using
the shared GeneratePreferences.rb script in WTF.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
Move preference setting to the bottom of the file to allow any preference
to be overriden. Also adds in support for double, uint32_t, and string preferences
though none of those are currently being used.

• WebKitTestRunner/TestOptions.cpp:

(WTR::TestOptions::keyTypeMapping):
Use generated macro GENERATED_WEB_PREFERENCE_KEY_TYPE_MAPPINGS rather than hardcoding
all the preferences types.

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::boolWebPreferenceFeatures const):
(WTR::TestOptions::doubleWebPreferenceFeatures const):
(WTR::TestOptions::uint32WebPreferenceFeatures const):
(WTR::TestOptions::stringWebPreferenceFeatures const):
Expose accessors for preferences values for use in setting the actual preference
values. Rather than setting all preferences, we now only set preferences that have
been explicitly requested, using the default value for any that have not.

12:32 PM Changeset in webkit [268603] by don.olmstead@sony.com

• 18 edits
  1 copy
  1 add in trunk/Source/WebCore

[WebGPU] Centralize Platform Defines
​https://bugs.webkit.org/show_bug.cgi?id=217725

Reviewed by Myles C. Maxfield.

Centralize all the Metal forward declarations and GPU platform type definitions
into GPUPlatformTypesMetal.h. Each platform implementing WebGPU will have its own
version of the file which contains the same definitions. This file is then
referenced by GPUPlatformTypes.h.

This is in preparation for adding a Dawn based implementation which requires
more substantial definitions than the Metal backend.

No new tests. No change in behavior.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/gpu/GPUBindGroup.h:
• platform/graphics/gpu/GPUBindGroupAllocator.h:
• platform/graphics/gpu/GPUBindGroupLayout.h:
• platform/graphics/gpu/GPUBuffer.h:

(WebCore::GPUBuffer::platformBuffer const):

• platform/graphics/gpu/GPUCommandBuffer.h:
• platform/graphics/gpu/GPUComputePassEncoder.h:
• platform/graphics/gpu/GPUComputePipeline.h:
• platform/graphics/gpu/GPUDevice.h:
• platform/graphics/gpu/GPUPlatformTypes.h: Added.
• platform/graphics/gpu/GPUProgrammablePassEncoder.h:
• platform/graphics/gpu/GPUQueue.h:
• platform/graphics/gpu/GPURenderPassEncoder.h:
• platform/graphics/gpu/GPURenderPipeline.h:
• platform/graphics/gpu/GPUSampler.h:
• platform/graphics/gpu/GPUShaderModule.h:
• platform/graphics/gpu/GPUSwapChain.h:
• platform/graphics/gpu/GPUTexture.h:
• platform/graphics/gpu/cocoa/GPUPlatformTypesMetal.h: Added.

12:20 PM Changeset in webkit [268602] by jiewen_tan@apple.com

• 4 edits in trunk

[WebAuthn] Remove the "alg" field in the attestation statement
​https://bugs.webkit.org/show_bug.cgi?id=217720
<rdar://problem/70349734>

Reviewed by Brent Fulgham.

Source/WebKit:

This old field was used in an unreleased old attestation statement format and is not used by
the final attestation statement format that will be added to the spec:
​https://github.com/w3c/webauthn/pull/1491.

Therefore, remove it to resolve confusion.

Covered by existing tests.

• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):

LayoutTests:

• http/wpt/webauthn/public-key-credential-create-success-local.https.html:

12:18 PM Changeset in webkit [268601] by aakash_jain@apple.com

• 3 edits in trunk/Tools

[build.webkit.org Rename slave to worker in steps.py
​https://bugs.webkit.org/show_bug.cgi?id=217836

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/build.webkit.org-config/steps.py: Renamed slave to worker.
• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.

11:31 AM Changeset in webkit [268600] by Chris Dumez

• 11 edits in trunk

Move even more AudioContext-specific logic out of BaseAudioContext
​https://bugs.webkit.org/show_bug.cgi?id=217803

Reviewed by Eric Carlson.

Source/WebCore:

Move even more AudioContext-specific logic out of BaseAudioContext and
into AudioContext. In particular, all the logic related to autoplay
restrictions, audible state, and platform media session interruptions
only apply to AudioContext and not OfflineAudioContext.

No new tests, no Web-facing behavior change.

• Modules/webaudio/AudioContext.cpp:

(WebCore::shouldDocumentAllowWebAudioToAutoPlay):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::willPausePlayback):
(WebCore::AudioContext::mediaState const):
(WebCore::AudioContext::mayResumePlayback):
(WebCore::AudioContext::willBeginPlayback):
(WebCore::AudioContext::visibilityStateChanged):
(WebCore::AudioContext::suspend):
(WebCore::AudioContext::resume):
(WebCore::AudioContext::suspendPlayback):
(WebCore::AudioContext::hostingDocumentIdentifier const):
(WebCore::AudioContext::isSuspended const):
(WebCore::AudioContext::pageMutedStateDidChange):
(WebCore::AudioContext::mediaCanStart):
(WebCore::AudioContext::logger const):

• Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::behaviorRestrictions const):
(WebCore::AudioContext::addBehaviorRestriction):
(WebCore::AudioContext::removeBehaviorRestriction):
(WebCore::AudioContext::userGestureRequiredForAudioStart const):
(WebCore::AudioContext::pageConsentRequiredForAudioStart const):

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::BaseAudioContext):
(WebCore::BaseAudioContext::~BaseAudioContext):

• Modules/webaudio/BaseAudioContext.h:
• Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::startOfflineRendering):

• testing/Internals.cpp:

(WebCore::Internals::setAudioContextRestrictions):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

Update test that was trying to set the autoplay restrictions on an OfflineAudioContext
to make sure they did not apply. Now that the autoplay restrictions are on AudioContext
instead of BaseAudioContext, they definitely do not apply to OfflineAudioContext and it
is not even possible to set the restrictions on an OfflineAudioContext. I updated the
test to use webkitOfflineAudioContext when available since WebKitOfflineAudioContext
does inherit WebKitAudioContext.

• webaudio/offlineaudiocontext-restriction.html:

11:29 AM Changeset in webkit [268599] by weinig@apple.com

• 13 edits in trunk/Source

ENABLE_LEGACY_CSS_VENDOR_PREFIXES and RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled() don't do anything
​https://bugs.webkit.org/show_bug.cgi?id=217833

Reviewed by Simon Fraser.

Source/WebCore:

Remove support for ENABLE_LEGACY_CSS_VENDOR_PREFIXES, which only guarded code
that also checked legacyCSSVendorPrefixesEnabled(), which was never enabled.

• css/CSSStyleDeclaration.cpp:
• css/parser/CSSPropertyParser.cpp:

(WebCore::cssPropertyID):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled const): Deleted.

Source/WTF:

• wtf/PlatformEnable.h:
• wtf/PlatformEnableCocoa.h:

Remove support for ENABLE_LEGACY_CSS_VENDOR_PREFIXES, which only guarded code that was always disabled.

10:52 AM Changeset in webkit [268598] by Antti Koivisto

• 9 edits in trunk/Source/WebCore

[LFC][Integration] Allow images in inline content
​https://bugs.webkit.org/show_bug.cgi?id=217757

Reviewed by Zalan Bujtas.

Add support for inline images in integrated modern inline layout.
This patch doesn't yet enable the support (it is behind an ifdef).

• dom/Position.cpp:

(WebCore::Position::ensureLineBoxes const):

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):

• layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree):

• layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::updateReplacedDimensions):
(WebCore::LayoutIntegration::LineLayout::constructContent):
(WebCore::LayoutIntegration::LineLayout::prepareLayoutState):
(WebCore::LayoutIntegration::LineLayout::paint):

• layout/integration/LayoutIntegrationLineLayout.h:
• layout/layouttree/LayoutReplacedBox.h:

(WebCore::Layout::ReplacedBox::contentSizeForIntegration const):
(WebCore::Layout::ReplacedBox::setContentSizeForIntegration):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutLFCLines):

• rendering/RenderLineBreak.cpp:

10:49 AM Changeset in webkit [268597] by Jonathan Bedard

• 7 edits in trunk/Tools

[webkitpy] Use webkitcorepy's autoinstaller for plint
​https://bugs.webkit.org/show_bug.cgi?id=217793
<rdar://problem/70356095>

Rubber-stamped by Aakash Jain.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall): Support multiple aliases to a single library.
(AutoInstall.register):
(AutoInstall.install):
(AutoInstall.install_everything):

• Scripts/webkitpy/init.py: Add pylint, map install zope.interface when zope is imported.
• Scripts/webkitpy/style/checkers/python.py:

(Pylinter.run):

• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Remove _install_pylint().
(AutoinstallImportHook._install_pylint): Deleted.

• Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest.test_imports): mechanize and pylint are managed by the new autoinstaller.

10:45 AM Changeset in webkit [268596] by aakash_jain@apple.com

• 4 edits in trunk/Tools

[build.webkit.org] buildbot checkconfig fails when passwords.json is missing
​https://bugs.webkit.org/show_bug.cgi?id=217831

Reviewed by Darin Adler.

• BuildSlaveSupport/build.webkit.org-config/master.cfg: Set is_test_mode_enabled based on BUILDBOT_TESTING env variable.
• BuildSlaveSupport/build.webkit.org-config/loadConfig.py: Renamed test_mode_is_enabled to is_test_mode_enabled to

be consistent with EWS code.

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.

9:33 AM Changeset in webkit [268595] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Add copyright message to steps_unittest.py
​https://bugs.webkit.org/show_bug.cgi?id=217830

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

9:06 AM Changeset in webkit [268594] by aakash_jain@apple.com

• 5 edits
  1 delete in trunk/Tools

[build.webkit.org] Remove SVNMirror
​https://bugs.webkit.org/show_bug.cgi?id=217823

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/build.webkit.org-config/factories.py: Removed SVNMirror.
• BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
• BuildSlaveSupport/build.webkit.org-config/loadConfig.py: Ditto.

(WaitForSVNServer): Deleted.
(WaitForSVNServer.evaluateCommand): Deleted.

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
• BuildSlaveSupport/wait-for-SVN-server.py: Removed.

8:52 AM Changeset in webkit [268593] by sbarati@apple.com

• 3 edits
  1 add in trunk

Don't emit OpSpread with a constant as the destination
​https://bugs.webkit.org/show_bug.cgi?id=217800
<rdar://problem/69492311>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/spread-should-not-have-a-constant-as-dst.js: Added.

(foo):
(bar):

Source/JavaScriptCore:

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):

8:38 AM Changeset in webkit [268592] by youenn@apple.com

• 4 edits in trunk

sdpFmtLine should be missing from RTCRtpCodecCapability instead of being an empty string
​https://bugs.webkit.org/show_bug.cgi?id=217818

Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::toRTCRtpCapabilities):
If line is empty, make sure to return a null string instead.

LayoutTests:

• webrtc/video-mute-vp8.html:

8:27 AM Changeset in webkit [268591] by clopez@igalia.com

• 4 edits in trunk/Tools

[JHBuild] Update libwpe and wpebackend-fdo and add libmanette to minimal moduleset
​https://bugs.webkit.org/show_bug.cgi?id=217825

Reviewed by Adrian Perez de Castro.

libmanette 0.2.4 is required for enabling gamepad support, which
defaults to on since r268389 for developer builds. The version
shipped by ubuntu-20.04 is not enough (0.2.3), so we should include
this on the minimal moduleset which is used to generate the bundle
products on the packaging bots.

Seize to also update the libwpe and wpebackend-fdo libraries.

• gtk/jhbuild.modules:
• jhbuild/jhbuild-minimal.modules:
• wpe/jhbuild.modules:

8:22 AM Changeset in webkit [268590] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[GStreamer] Remove unused ElementType values from the registry scanner
​https://bugs.webkit.org/show_bug.cgi?id=217824

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-10-16
Reviewed by Xabier Rodriguez-Calvar.

r268576 introduced new values in the ElementType enum but they were unused and introduced
inconsistency in in fillMimeTypeSetFromCapsMapping(). If this function needs to be used for
encoding configurations it will need to be refactored but that's not a scenario I foresee,
so for now, remove unused enum values.

• platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::fillMimeTypeSetFromCapsMapping):

• platform/graphics/gstreamer/GStreamerRegistryScanner.h:

7:46 AM Changeset in webkit [268589] by commit-queue@webkit.org

• 3 edits
  154 deletes in trunk

Tools:
Match webkitpy.port.base.Port's merging of .webarchive/.txt
​https://bugs.webkit.org/show_bug.cgi?id=217795

Patch by Sam Sneddon <Sam Sneddon> on 2020-10-16
Reviewed by Alexey Proskuryakov.

• Scripts/check-for-duplicated-platform-test-results:

(check_duplicate): Check for both .webarchive and .txt
(check_platform): Don't call the function that probably just threw

LayoutTests:
Remove redundant baselines in platform/
​https://bugs.webkit.org/show_bug.cgi?id=217795

Patch by Sam Sneddon <Sam Sneddon> on 2020-10-16
Reviewed by Alexey Proskuryakov.

• platform/glib/animations/steps-transform-rendering-updates-expected.txt: Removed.
• platform/glib/fast/canvas/fallback-content-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/close-before-open-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/close-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/extensions-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/invalid-encode-length-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/invalid-masked-frames-from-server-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/long-control-frame-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/long-invalid-header-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/reserved-bits-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/too-long-payload-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/websocket-event-target-expected.txt: Removed.
• platform/glib/imported/w3c/web-platform-tests/css/css-values/minmax-angle-computed-expected.txt: Removed.
• platform/glib/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter-expected.txt: Removed.
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-tail-expected.txt: Removed.
• platform/glib/webaudio/Analyser/realtimeanalyser-fftsize-reset-expected.txt: Removed.
• platform/glib/webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt: Removed.
• platform/gtk/fast/css/pseudo-invalid-form-invalidation-optimization-expected.txt: Removed.
• platform/gtk/fast/css/pseudo-valid-form-invalidation-optimization-expected.txt: Removed.
• platform/gtk/fast/events/js-keyboard-event-creation-expected.txt: Removed.
• platform/gtk/fast/events/nested-window-event-expected.txt: Removed.
• platform/gtk/http/tests/security/mixedContent/websocket/insecure-websocket-in-iframe-expected.txt: Removed.
• platform/gtk/http/tests/security/mixedContent/websocket/insecure-websocket-in-main-frame-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/telephone-expected.txt: Removed.
• platform/ios-wk2/compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/5002441-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-3778059-fix-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-br-at-tabspan-001-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-br-at-tabspan-002-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-br-at-tabspan-003-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-br-quoted-001-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-br-quoted-002-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-br-quoted-003-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-br-quoted-004-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-br-quoted-005-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-br-quoted-006-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-div-020-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-div-022-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-div-026-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/insert-text-with-newlines-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/paragraph-separator-01-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/paragraph-separator-in-table-2-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/return-key-with-selection-001-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/return-key-with-selection-002-expected.txt: Removed.
• platform/ios-wk2/editing/inserting/return-key-with-selection-003-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/5601583-1-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/8145-2-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/bad-placeholder-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-4038267-fix-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-line-endings-001-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-line-endings-002-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-line-endings-003-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-line-endings-004-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-line-endings-005-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-line-endings-006-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-line-endings-007-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-line-endings-008-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-line-endings-009-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-line-endings-010-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-match-style-001-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-match-style-002-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-text-016-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/paste-text-019-expected.txt: Removed.
• platform/ios-wk2/editing/pasteboard/quirks-mode-br-1-expected.txt: Removed.
• platform/ios-wk2/editing/selection/editable-html-element-expected.txt: Removed.
• platform/ios-wk2/editing/selection/paragraph-granularity-expected.txt: Removed.
• platform/ios-wk2/editing/selection/select-all-iframe-expected.txt: Removed.
• platform/ios-wk2/editing/selection/selection-actions-expected.txt: Removed.
• platform/ios-wk2/editing/selection/word-granularity-expected.txt: Removed.
• platform/ios-wk2/editing/style/5046875-2-expected.txt: Removed.
• platform/ios-wk2/editing/style/block-styles-007-expected.txt: Removed.
• platform/ios-wk2/editing/style/create-block-for-style-001-expected.txt: Removed.
• platform/ios-wk2/editing/style/create-block-for-style-002-expected.txt: Removed.
• platform/ios-wk2/editing/style/create-block-for-style-003-expected.txt: Removed.
• platform/ios-wk2/editing/style/create-block-for-style-004-expected.txt: Removed.
• platform/ios-wk2/editing/style/create-block-for-style-013-expected.txt: Removed.
• platform/ios-wk2/editing/style/style-3998892-fix-expected.txt: Removed.
• platform/ios-wk2/editing/style/style-boundary-001-expected.txt: Removed.
• platform/ios-wk2/editing/style/style-boundary-004-expected.txt: Removed.
• platform/ios-wk2/editing/unsupported-content/list-delete-003-expected.txt: Removed.
• platform/ios-wk2/editing/unsupported-content/list-type-after-expected.txt: Removed.
• platform/ios-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
• platform/ios-wk2/fast/dom/focus-contenteditable-expected.txt: Removed.
• platform/ios-wk2/fast/forms/basic-textareas-expected.txt: Removed.
• platform/ios-wk2/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Removed.
• platform/ios-wk2/fast/forms/textarea-scrollbar-expected.txt: Removed.
• platform/ios-wk2/fast/forms/textarea-scrolled-type-expected.txt: Removed.
• platform/ios-wk2/fast/forms/textfield-outline-expected.txt: Removed.
• platform/ios-wk2/fast/frames/onlyCommentInIFrame-expected.txt: Removed.
• platform/ios-wk2/fast/inline-block/tricky-baseline-expected.txt: Removed.
• platform/ios-wk2/fast/overflow/overflow-float-stacking-expected.txt: Removed.
• platform/ios-wk2/fast/overflow/overflow-stacking-expected.txt: Removed.
• platform/ios-wk2/fast/overflow/overflow-x-y-expected.txt: Removed.
• platform/ios-wk2/fast/overflow/position-fixed-transform-clipping-expected.txt: Removed.
• platform/ios-wk2/fast/text/international/thai-baht-space-expected.txt: Removed.
• platform/ios-wk2/fast/transforms/transformed-caret-expected.txt: Removed.
• platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
• platform/ios/fast/canvas/set-colors-expected.txt: Removed.
• platform/ios/fast/scrolling/adjust-scroll-offset-on-zoom-expected.txt: Removed.
• platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt: Removed.
• platform/mac-catalina/fast/block/margin-collapse/103-expected.txt: Removed.
• platform/mac-catalina/fast/forms/button-table-styles-expected.txt: Removed.
• platform/mac-catalina/fast/forms/date/date-input-rendering-basic-expected.png: Removed.
• platform/mac-catalina/fast/forms/input-disabled-color-expected.txt: Removed.
• platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt: Removed.
• platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt: Removed.
• platform/mac-catalina/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
• platform/mac-mojave/fast/block/basic/001-expected.txt: Removed.
• platform/mac-mojave/fast/block/margin-collapse/103-expected.txt: Removed.
• platform/mac-mojave/fast/forms/button-table-styles-expected.txt: Removed.
• platform/mac-mojave/fast/forms/date/date-input-rendering-basic-expected.png: Removed.
• platform/mac-mojave/fast/forms/input-disabled-color-expected.txt: Removed.
• platform/mac-mojave/fast/forms/input-readonly-dimmed-expected.txt: Removed.
• platform/mac-mojave/fast/forms/plaintext-mode-2-expected.txt: Removed.
• platform/mac-mojave/fast/forms/select-change-popup-to-listbox-expected.txt: Removed.
• platform/mac-mojave/fast/text/indic-expected.txt: Removed.
• platform/mac-mojave/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Removed.
• platform/mac-mojave/tables/mozilla/other/wa_table_tr_align-expected.txt: Removed.
• platform/mac-wk2/fast/forms/time/time-appearance-basic-expected.txt: Removed.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter-expected.txt: Removed.
• platform/mac/fast/canvas/set-colors-expected.txt: Removed.
• platform/mac/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
• platform/mac/svg/custom/image-with-prefix-in-webarchive-expected.txt: Removed.
• platform/mac/svg/webarchive/svg-feimage-subresources-expected.txt: Removed.
• platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.txt: Removed.
• platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.txt: Removed.
• platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.txt: Removed.
• platform/mac/webarchive/archive-empty-frame-dom-expected.txt: Removed.
• platform/mac/webarchive/archive-empty-frame-source-expected.txt: Removed.
• platform/mac/webarchive/archive-with-unencoded-url-expected.txt: Removed.
• platform/mac/webarchive/css-page-rule-crash-expected.txt: Removed.
• platform/mac/webarchive/doctype-expected.txt: Removed.
• platform/mac/webarchive/ignore-noscript-if-scripting-enabled-expected.txt: Removed.
• platform/mac/webarchive/test-body-background-expected.txt: Removed.
• platform/mac/webarchive/test-css-import-expected.txt: Removed.
• platform/mac/webarchive/test-duplicate-resources-expected.txt: Removed.
• platform/mac/webarchive/test-frameset-expected.txt: Removed.
• platform/mac/webarchive/test-img-src-expected.txt: Removed.
• platform/mac/webarchive/test-input-src-expected.txt: Removed.
• platform/mac/webarchive/test-link-href-expected.txt: Removed.
• platform/mac/webarchive/test-object-data-expected.txt: Removed.
• platform/mac/webarchive/test-script-src-expected.txt: Removed.
• platform/mac/webarchive/test-table-background-expected.txt: Removed.
• platform/mac/webarchive/test-td-background-expected.txt: Removed.
• platform/mac/webarchive/test-xml-stylesheet-expected.txt: Removed.
• platform/win/animations/steps-transform-rendering-updates-expected.txt: Removed.
• platform/win/editing/style/apply-through-end-of-document-expected.txt: Removed.
• platform/win/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Removed.
• platform/wincairo/animations/steps-transform-rendering-updates-expected.txt: Removed.
• platform/wincairo/editing/style/apply-through-end-of-document-expected.txt: Removed.
• platform/wpe/http/tests/storageAccess/aggregate-sorted-data-with-storage-access-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/css/css-sizing/percentage-height-in-flexbox-expected.txt: Removed.

7:17 AM Changeset in webkit [268588] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION (r266932): [ Mojave+ wk2 ] fast/scrolling/latching/latched-scroll-into-nonfast-region.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217001

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

7:12 AM Changeset in webkit [268587] by commit-queue@webkit.org

• 8 edits in trunk/Source

REGRESSION(r267727): Warning spam from JSC_DECLARE_CUSTOM_GETTER
​https://bugs.webkit.org/show_bug.cgi?id=217585

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-10-16
Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

A small number of source files now need to use JSC_DECLARE_CUSTOM_GETTER_WITHOUT_WTF_INTERNAL.

• b3/testb3_5.cpp:
• b3/testb3_7.cpp:
• tools/JSDollarVM.cpp:

Source/WebCore:

SelectorCompiler.cpp needs the new JSC_DECLARE_JIT_OPERATION_WITHOUT_WTF_INTERNAL.

• cssjit/SelectorCompiler.cpp:

Source/WTF:

The problem is that the declarations are static, so WTF_INTERNAL is redundant with that.
(File-static declarations are of course local to the current file, and apparently GCC really
wants us to not hide symbols that don't need to be hidden.)

I considered remove WTF_INTERNAL from JSC_DECLARE_JIT_OPERATION and ensuring all uses are
static, but it's not possible because it is frequently used in header files. It should only
be static when used in .cpp files.

So I decided to split JSC_DECLARE_JIT_OPERATION into two versions, the current one that uses
WTF_INTERNAL, and JSC_DECLARE_JIT_OPERATION_WITHOUT_WTF_INTERNAL that doesn't. That is not a
great name, but it's only used in a couple places, so I guess that's OK.
JSC_DECLARE_CUSTOM_GETTER and JSC_DECLARE_CUSTOM_SETTER use this new version, since those
are only used in static declarations in .cpp files. A small number of source files also need
the version without the WTF_INTERNAL. All other users can continue to use original
JSC_DECLARE_JIT_OPERATION with WTF_INTERNAL and not worry about the ugly name.

I'm not terribly happy with this solution, and it's a little fragile too (you probably won't
directly use JSC_DECLARE_JIT_OPERATION_WITHOUT_WTF_INTERNAL in a place that needs
WTF_INTERNAL, but you might use JSC_DECLARE_CUSTOM_GETTER and JSC_DECLARE_CUSTOM_SETTER in
such a way!), but at least it will avoid the warning spam and allow us to see warnings for
real problems.

• wtf/PlatformCallingConventions.h:

6:21 AM Changeset in webkit [268586] by Philippe Normand

• 2 edits in trunk/Source/WebCore

Unreviewed, follow-up to r268576

Revert a chunk of r268576 that introduced a regression in audio-related tests.

• platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::fillMimeTypeSetFromCapsMapping): Add an ASSERT and
modify mime-type and codec hashmaps in-place.

6:03 AM Changeset in webkit [268585] by Andres Gonzalez

• 10 edits in trunk/Source/WebCore

Refactor [WebAccessibilityObjectWrapper convertRectToSpace] so that the platform-specific code is in their corresponding AX object platform implementations.
​https://bugs.webkit.org/show_bug.cgi?id=217785

Reviewed by Chris Fleizach.

No change in functionality, code refactor and cleanup.

[WebAccessibilityObjectWrapperBase convertRectToSpace] had two different
code paths for Mac and iOS, defeating the purpose of a base class.
This re-factoring Simplifies the wrapper code by moving the platform-
specific implementations to their corresponding AX object implementations
of convertRectToPlatformSpace.
Some code cleanup.

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityObjectInterface.h:
• accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::topDocumentFrameView const):
(WebCore::AccessibilityObject::convertRectToPlatformSpace const):

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityWebDocumentView]):

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::convertRectToPlatformSpace const):

• accessibility/isolatedtree/AXIsolatedObject.h:
• accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::topDocumentFrameView const):
(WebCore::AccessibilityObject::convertRectToPlatformSpace const):

• accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase convertRectToSpace:space:]):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper position]):

5:53 AM Changeset in webkit [268584] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION: [ Win10 wk1 ews ] transforms/2d/translate-change-composited.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217812

Unreviewed test gardening.

• platform/win/TestExpectations:

5:51 AM Changeset in webkit [268583] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update test expectations after r268575.

Added several failures from new added tests.

• platform/glib/TestExpectations:

5:45 AM Changeset in webkit [268582] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION: [ Win10 wk1 ews ] transforms/2d/rotate-change-composited.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217812

Unreviewed test gardening.

• platform/win/TestExpectations:

5:33 AM Changeset in webkit [268581] by clopez@igalia.com

• 2 edits in trunk/Tools

Ensure the tests are run with US/Pacific time zone
​https://bugs.webkit.org/show_bug.cgi?id=186612

Reviewed by Michael Catanzaro.

Some tests fail if the time zone is not set to US/Pacific, and
this causes issues for contributors living outside of that timezone.
Ideally we should fix those tests, but in the meantime setting this
environment variable before starting the layout tests seems like
an acceptable workaround. Note that something similar is also
already done for the JSC tests.

• Scripts/webkitpy/port/base.py:

(Port.setup_environ_for_server):

5:33 AM Changeset in webkit [268580] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION: [ Win10 wk1 ews ] transforms/2d/scale-change-composited.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217812

Unreviewed test gardening.

• platform/win/TestExpectations:

4:22 AM Changeset in webkit [268579] by Philippe Normand

• 5 edits in trunk/Source/WebCore

[GStreamer] Audio worklet support
​https://bugs.webkit.org/show_bug.cgi?id=217760

Reviewed by Xabier Rodriguez-Calvar.

This patch hooks WebAudio worklet rendering support into the GStreamer WebAudio backend.

• platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::start): Set the render callback if it was provided.

• platform/audio/gstreamer/AudioDestinationGStreamer.h:
• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcAllocateBuffersAndRenderAudio): Invoke the bus rendering through the
render callback if it was set.
(webkitWebAudioSourceSetDispatchToRenderThreadCallback):

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.h:

3:55 AM Changeset in webkit [268578] by commit-queue@webkit.org

• 16 edits
  1 copy
  1 add in trunk/Source/WebCore

Refactor WebGL implementation to use only GraphicsContextGL part 1
​https://bugs.webkit.org/show_bug.cgi?id=217213
<rdar://problem/69876105>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-10-16
Reviewed by Dean Jackson.

Part 1 of work towards WebGL implementation which uses
GraphicsContextGL abstract base class instead of
GraphicsContextGLOpenGL concrete class.

Move pixel data related static helper funcions from
GraphicsContextGLOpenGL to GraphicsContextGL. These are
normal pixel format calculation functions that do not have
concrete class implementation details. Move pixel pack related
structures to GraphicsContextGL.

Rename GraphicsContextGLOpenGL::ImageExtractor to
GraphicsContextGLImageExtractor. The GraphicsContextGL class
interface is already quite lengthy and the image extractor
is not very tied to the context class.

Introduce a virtual member function in GraphicsContextGL for
each call that is likely needed for the WebGL implementation.

No new tests, a refactor.

• WebCore.xcodeproj/project.pbxproj:
• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getPackPixelStoreParams const):
(WebCore::WebGL2RenderingContext::getUnpackPixelStoreParams const):

• html/canvas/WebGL2RenderingContext.h:
• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::texImageArrayBufferViewHelper):
(WebCore::WebGLRenderingContextBase::texImageImpl):
(WebCore::WebGLRenderingContextBase::getPackPixelStoreParams const):
(WebCore::WebGLRenderingContextBase::getUnpackPixelStoreParams const):

• html/canvas/WebGLRenderingContextBase.h:
• platform/graphics/GraphicsContextGL.cpp:

(WebCore::getDataFormat):
(WebCore::texelBytesForFormat):
(WebCore::packPixels):
(WebCore::GraphicsContextGL::computeFormatAndTypeParameters):
(WebCore::GraphicsContextGL::computeImageSizeInBytes):
(WebCore::GraphicsContextGL::possibleFormatAndTypeForInternalFormat):
(WebCore::GraphicsContextGL::packImageData):
(WebCore::GraphicsContextGL::extractImageData):
(WebCore::GraphicsContextGL::extractTextureData):

• platform/graphics/GraphicsContextGL.h:

(WebCore::GraphicsContextGL::Client::~Client):
(WebCore::GraphicsContextGL::addClient):
(WebCore::GraphicsContextGL::removeClient):
(WebCore::GraphicsContextGL::getInternalFramebufferSize const):

• platform/graphics/GraphicsContextGLImageExtractor.cpp: Copied from Source/WebCore/platform/graphics/win/GraphicsContextGLDirect2D.cpp.

(WebCore::GraphicsContextGLImageExtractor::GraphicsContextGLImageExtractor):

• platform/graphics/GraphicsContextGLImageExtractor.h: Added.

(WebCore::GraphicsContextGLImageExtractor::extractSucceeded):
(WebCore::GraphicsContextGLImageExtractor::imagePixelData):
(WebCore::GraphicsContextGLImageExtractor::imageWidth):
(WebCore::GraphicsContextGLImageExtractor::imageHeight):
(WebCore::GraphicsContextGLImageExtractor::imageSourceFormat):
(WebCore::GraphicsContextGLImageExtractor::imageAlphaOp):
(WebCore::GraphicsContextGLImageExtractor::imageSourceUnpackAlignment):
(WebCore::GraphicsContextGLImageExtractor::imageHtmlDomSource):

• platform/graphics/angle/GraphicsContextGLANGLE.cpp:
• platform/graphics/cairo/GraphicsContextGLCairo.cpp:

(WebCore::GraphicsContextGLImageExtractor::extractImage):

• platform/graphics/cg/GraphicsContextGLCG.cpp:

(WebCore::GraphicsContextGLImageExtractor::extractImage):

• platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::texImage2DResourceSafe):

• platform/graphics/opengl/GraphicsContextGLOpenGL.h:
• platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
• platform/graphics/win/GraphicsContextGLDirect2D.cpp:

(WebCore::GraphicsContextGLImageExtractor::extractImage):

2:48 AM Changeset in webkit [268577] by youenn@apple.com

• 22 edits
  5 adds in trunk/Source

Add support for GPUProcess WebAudio media element providers
​https://bugs.webkit.org/show_bug.cgi?id=217704

Reviewed by Eric Carlson.

Source/WebCore:

Update AudioSourceProviderAVFObjC so that a specific ring buffer can be provided and to be notified of new samples being pushed.

Covered by existing web audio tests run with GPUProcess.

• WebCore.xcodeproj/project.pbxproj:
• platform/audio/AudioSourceProvider.h:

(WebCore::AudioSourceProvider::isHandlingAVPlayer const):

• platform/audio/cocoa/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::pullSamplesInternal):
When we are too close to the end of available data, do as if we are paused and keep the same time entry for the next read operation.
This will basically make us wait for the next push of data before restarting to read succesfully.

• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:

(isType):

• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::prepare):
(WebCore::AudioSourceProviderAVFObjC::process):
(WebCore::AudioSourceProviderAVFObjC::setAudioCallback):
(WebCore::AudioSourceProviderAVFObjC::setRingBufferCreationCallback):

• platform/mediastream/mac/WebAudioSourceProviderCocoa.mm:

(WebCore::WebAudioSourceProviderCocoa::receivedNewAudioSamples):
We should use the input sample rate to compute the input media time.

Source/WebKit:

Introduce RemoteAudioSourceProviderManager which receives IPC messages from GPU process for web audio data.
RemoteAudioSourceProviderManager sends it to the identified RemoteAudioSourceProvider.

Introduce RemoteAudioSourceProviderProxy which is a client to the AV AudioSourceProviderAVFObjC.
RemoteAudioSourceProviderProxy will send IPC messages to RemoteAudioSourceProviderManager to send audio data and description.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• GPUProcess/media/RemoteAudioSourceProviderProxy.cpp: Added.

(WebKit::RemoteAudioSourceProviderProxy::create):
(WebKit::RemoteAudioSourceProviderProxy::RemoteAudioSourceProviderProxy):
(WebKit::RemoteAudioSourceProviderProxy::createRingBuffer):
(WebKit::RemoteAudioSourceProviderProxy::newAudioSamples):
(WebKit::RemoteAudioSourceProviderProxy::storageChanged):

• GPUProcess/media/RemoteAudioSourceProviderProxy.h: Added.
• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::~RemoteMediaPlayerProxy):
(WebKit::RemoteMediaPlayerProxy::createAudioSourceProvider):
(WebKit::RemoteMediaPlayerProxy::setShouldEnableAudioSourceProvider):

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
• SourcesCocoa.txt:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::audioSourceProviderManager):

• WebProcess/GPU/GPUProcessConnection.h:
• WebProcess/GPU/media/RemoteAudioSourceProvider.cpp:

(WebKit::RemoteAudioSourceProvider::create):
(WebKit::RemoteAudioSourceProvider::RemoteAudioSourceProvider):
(WebKit::RemoteAudioSourceProvider::close):
(WebKit::RemoteAudioSourceProvider::hasNewClient):

• WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp: Added.

(WebKit::RemoteAudioSourceProviderManager::RemoteAudioSourceProviderManager):
(WebKit::RemoteAudioSourceProviderManager::~RemoteAudioSourceProviderManager):
(WebKit::RemoteAudioSourceProviderManager::setConnection):
(WebKit::RemoteAudioSourceProviderManager::addProvider):
(WebKit::RemoteAudioSourceProviderManager::removeProvider):
(WebKit::RemoteAudioSourceProviderManager::dispatchToThread):
(WebKit::RemoteAudioSourceProviderManager::audioStorageChanged):
(WebKit::RemoteAudioSourceProviderManager::audioSamplesAvailable):
(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::RemoteAudio):
(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::setStorage):
(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::audioSamplesAvailable):

• WebProcess/GPU/media/RemoteAudioSourceProviderManager.h: Added.

(WebKit::RemoteAudioSourceProviderManager::create):

• WebProcess/GPU/media/RemoteAudioSourceProviderManager.messages.in: Added.
• WebProcess/cocoa/RemoteCaptureSampleManager.cpp:

1:52 AM Changeset in webkit [268576] by Philippe Normand

• 11 edits
  1 move in trunk

[GStreamer] Encoder probing support for the registry scanner
​https://bugs.webkit.org/show_bug.cgi?id=217750

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The scanner is now able to probe for platform encoders for the most common formats: avc1,
av1, ogg, theora, aac and opus. The muxers for webm and mp4 are also checked.

No new tests, existing mediacapabilities test cover this change.

• platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::GStreamerRegistryScanner):
(WebCore::GStreamerRegistryScanner::~GStreamerRegistryScanner):
(WebCore::GStreamerRegistryScanner::mimeTypeSet):
(WebCore::GStreamerRegistryScanner::isContainerTypeSupported const):
(WebCore::GStreamerRegistryScanner::hasElementForMediaType const):
(WebCore::GStreamerRegistryScanner::fillMimeTypeSetFromCapsMapping):
(WebCore::GStreamerRegistryScanner::initializeDecoders):
(WebCore::GStreamerRegistryScanner::initializeEncoders):
(WebCore::GStreamerRegistryScanner::isCodecSupported const):
(WebCore::GStreamerRegistryScanner::isContentTypeSupported const):
(WebCore::GStreamerRegistryScanner::areAllCodecsSupported const):
(WebCore::GStreamerRegistryScanner::isAVC1CodecSupported const):
(WebCore::GStreamerRegistryScanner::configurationNameForLogging const):
(WebCore::GStreamerRegistryScanner::isConfigurationSupported const):

• platform/graphics/gstreamer/GStreamerRegistryScanner.h:

(WebCore::GStreamerRegistryScanner::isDecodingSupported const):
(WebCore::GStreamerRegistryScanner::isEncodingSupported const):

• platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::supportsContainerType):
(WebCore::ImageDecoderGStreamer::canDecodeType):

• platform/graphics/gstreamer/MediaEngineConfigurationFactoryGStreamer.cpp:

(WebCore::createMediaPlayerEncodingConfigurationGStreamer):

• platform/graphics/gstreamer/MediaEngineConfigurationFactoryGStreamer.h:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):
(WebCore::MediaPlayerPrivateGStreamer::supportsType):

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::getSupportedTypes):
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):

• platform/mediacapabilities/MediaEngineConfigurationFactory.cpp:

(WebCore::factories):

LayoutTests:

• platform/glib/media/mediacapabilities-types-expected.txt: Renamed from LayoutTests/platform/gtk/media/mediacapabilities/mediacapabilities-types-expected.txt.

12:52 AM Changeset in webkit [268575] by jiewen_tan@apple.com

• 7 edits
  1 copy
  2 adds in trunk/Source

[WebAuthn] Move AppAttestInternal related code from WKA to OpenSource
​https://bugs.webkit.org/show_bug.cgi?id=217790
<rdar://problem/59613406>

Reviewed by Brent Fulgham.

Source/WebKit:

Covered by manual testing.

• Platform/spi/Cocoa/AppAttestSPI.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.mm.
• SourcesCocoa.txt:
• UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.h: Added.
• UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.mm: Added.
• UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:

(WebKit::LocalConnection::getAttestation const):

• UIProcess/WebAuthentication/Cocoa/LocalService.mm:

(WebKit::LocalService::isAvailable):

• WebKit.xcodeproj/project.pbxproj:

Source/WTF:

• wtf/PlatformHave.h:

12:22 AM Changeset in webkit [268574] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GLIB][GTK] Unreviewed test gardening. Update test expectations after r268573.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

12:09 AM Changeset in webkit [268573] by Diego Pino Garcia

• 2 edits
  1 move
  1 delete in trunk/LayoutTests

[GTK] Update expectations for editing/pasteboard/drop-text-without-selection.html after r267997

Unreviewed test gardening.

r267997 removed GTK expected baseline for editing/pasteboard/drop-text-without-selection.html, which was stale
after the test was converted into a reftest. After this change, GTK test bot reported the baseline as Missing.
The reason was that the reference test was in platform Mac. Also remove stale GTK expected image.

• editing/pasteboard/drop-text-without-selection-expected.html: Renamed from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.html.
• platform/gtk/TestExpectations:
• platform/gtk/editing/pasteboard/drop-text-without-selection-expected.png: Removed.

Oct 15, 2020:

8:11 PM Changeset in webkit [268572] by sbarati@apple.com

• 3 edits
  1 add in trunk

Don't assign a bogus register to Load/ForwardVarargs in AvailabilityAnalysis before stack layout
​https://bugs.webkit.org/show_bug.cgi?id=217789
<rdar://problem/69285703>

Reviewed by Keith Miller.

JSTests:

• stress/dont-assign-bogus-virtual-register-in-availability-analysis-before-stack-layout-runs.js: Added.

(bar):
(foo):

Source/JavaScriptCore:

There is code inside AvailabilityAnalysis phase that was assuming the
Load/ForwardVarargs data was already stack allocated. However, this isn't
guaranteed to be the case. However, we were doing virtual register math on
invalid virtual registers, leading to wonky results. The fix here is to
model it like we do GetStack/PutStack, where we say, before we do stack
allocation, we just tell availability analysis the flush format, but not
where it's flushed.

This was causing validation errors when merging these invalid FlushedAts with
the FlushedAts from GetStack/PutStack.

• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

6:51 PM Changeset in webkit [268571] by weinig@apple.com

• 2 edits in trunk/Tools

Attempt to fix the build.

• DumpRenderTree/DerivedSources.make: Don't use such fancy substitution, it wasn't working.

6:45 PM Changeset in webkit [268570] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

v2: WebKit::XPCServiceEventHandler block should call exit() on the main thread
<​https://webkit.org/b/217773>
<rdar://problem/70275659>

Reviewed by Geoff Garen.

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):

• Use NSRunLoop instead of libdispatch to run code on the main thread since libdispatch can randomly pick a new main thread when exit() is called on the original main thread.

6:39 PM Changeset in webkit [268569] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

iPhone apps and iPad apps linked before iOS 13 running on macOS get desktop UA unexpectedly
​https://bugs.webkit.org/show_bug.cgi?id=217798
<rdar://problem/70254509>

Reviewed by Wenson Hsieh.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingRecommended):
Share more of the code with iOS, for compatibility and consistency's sake:
iOS apps running on macOS should use the mobile UA if they are iPhone-only,
or if they were linked on an SDK earlier than iOS 13. This matches their
behavior on iPad.

6:28 PM Changeset in webkit [268568] by clopez@igalia.com

• 207 edits
  1 move
  2 adds in trunk/LayoutTests

[WPE] Rebaseline after r268520

Unreviewed gardening.

Rebaseline tests affected by r268520 for WPE.
For GTK this tests were rebaselined on r268545.

• platform/glib/fast/text/whitespace/029-expected.txt: Renamed from LayoutTests/platform/gtk/fast/text/whitespace/029-expected.txt.
• platform/wpe/css1/box_properties/float_on_text_elements-expected.txt:
• platform/wpe/css1/color_and_background/background_attachment-expected.txt:
• platform/wpe/css1/text_properties/text_indent-expected.txt:
• platform/wpe/fast/backgrounds/background-clip-text-expected.txt:
• platform/wpe/fast/block/basic/001-expected.txt:
• platform/wpe/fast/block/float/002-expected.txt:
• platform/wpe/fast/block/float/021-expected.txt:
• platform/wpe/fast/block/float/br-with-clear-2-expected.txt: Added.
• platform/wpe/fast/block/float/float-avoidance-expected.txt:
• platform/wpe/fast/block/margin-collapse/104-expected.txt:
• platform/wpe/fast/block/positioning/055-expected.txt:
• platform/wpe/fast/block/positioning/056-expected.txt:
• platform/wpe/fast/borders/inline-mask-overlay-image-outset-expected.txt:
• platform/wpe/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt:
• platform/wpe/fast/box-shadow/basic-shadows-expected.txt:
• platform/wpe/fast/clip/nestedTransparencyClip-expected.txt:
• platform/wpe/fast/clip/overflow-border-radius-combinations-expected.txt:
• platform/wpe/fast/clip/overflow-border-radius-composited-expected.txt:
• platform/wpe/fast/clip/overflow-border-radius-transformed-expected.txt:
• platform/wpe/fast/css-generated-content/inline-display-types-expected.txt:
• platform/wpe/fast/css/first-line-text-decoration-expected.txt:
• platform/wpe/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
• platform/wpe/fast/css/hsl-color-expected.txt:
• platform/wpe/fast/css/layerZOrderCrash-expected.txt:
• platform/wpe/fast/css/line-height-overflow-expected.txt:
• platform/wpe/fast/css/nth-child-dynamic-expected.txt:
• platform/wpe/fast/css/rtl-ordering-expected.txt:
• platform/wpe/fast/css/text-overflow-ellipsis-expected.txt:
• platform/wpe/fast/css/text-rendering-expected.txt:
• platform/wpe/fast/dom/HTMLElement/bdo-expected.txt:
• platform/wpe/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
• platform/wpe/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
• platform/wpe/fast/dom/HTMLTableElement/colSpan-expected.txt:
• platform/wpe/fast/dom/HTMLTableElement/createCaption-expected.txt:
• platform/wpe/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
• platform/wpe/fast/dom/children-nodes-expected.txt:
• platform/wpe/fast/dom/focus-contenteditable-expected.txt:
• platform/wpe/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt:
• platform/wpe/fast/encoding/utf-16-big-endian-expected.txt:
• platform/wpe/fast/encoding/utf-16-little-endian-expected.txt:
• platform/wpe/fast/encoding/xmacroman-encoding-test-expected.txt:
• platform/wpe/fast/frames/iframe-with-frameborder-expected.txt:
• platform/wpe/fast/frames/onlyCommentInIFrame-expected.txt:
• platform/wpe/fast/inline-block/contenteditable-baseline-expected.txt:
• platform/wpe/fast/inline-block/inline-block-vertical-align-expected.txt:
• platform/wpe/fast/inline/drawStyledEmptyInlines-expected.txt:
• platform/wpe/fast/invalid/021-expected.txt:
• platform/wpe/fast/layers/video-layer-expected.txt:
• platform/wpe/fast/line-grid/line-grid-contains-value-expected.txt:
• platform/wpe/fast/line-grid/line-grid-floating-expected.txt:
• platform/wpe/fast/line-grid/line-grid-inside-columns-expected.txt:
• platform/wpe/fast/line-grid/line-grid-into-columns-expected.txt:
• platform/wpe/fast/line-grid/line-grid-into-floats-expected.txt:
• platform/wpe/fast/line-grid/line-grid-positioned-expected.txt:
• platform/wpe/fast/multicol/float-paginate-complex-expected.txt:
• platform/wpe/fast/multicol/layers-in-multicol-expected.txt:
• platform/wpe/fast/multicol/max-height-columns-block-expected.txt:
• platform/wpe/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
• platform/wpe/fast/overflow/006-expected.txt:
• platform/wpe/fast/overflow/line-clamp-expected.txt:
• platform/wpe/fast/overflow/overflow-stacking-expected.txt:
• platform/wpe/fast/overflow/overflow-x-y-expected.txt:
• platform/wpe/fast/overflow/position-fixed-transform-clipping-expected.txt:
• platform/wpe/fast/overflow/table-overflow-float-expected.txt:
• platform/wpe/fast/replaced/selection-rect-transform-expected.txt:
• platform/wpe/fast/ruby/ruby-beforeafter-expected.txt:
• platform/wpe/fast/ruby/ruby-inline-table-expected.txt:
• platform/wpe/fast/ruby/ruby-length-expected.txt:
• platform/wpe/fast/ruby/ruby-run-break-expected.txt:
• platform/wpe/fast/ruby/ruby-runs-expected.txt:
• platform/wpe/fast/ruby/ruby-simple-expected.txt:
• platform/wpe/fast/ruby/ruby-simple-rp-expected.txt:
• platform/wpe/fast/table/009-expected.txt:
• platform/wpe/fast/table/040-expected.txt:
• platform/wpe/fast/table/040-vertical-expected.txt:
• platform/wpe/fast/table/cellindex-expected.txt:
• platform/wpe/fast/table/percent-heights-expected.txt:
• platform/wpe/fast/table/table-and-parts-outline-expected.txt:
• platform/wpe/fast/text/basic/012-expected.txt:
• platform/wpe/fast/text/basic/014-expected.txt:
• platform/wpe/fast/text/basic/generic-family-reset-expected.txt:
• platform/wpe/fast/text/capitalize-boundaries-expected.txt:
• platform/wpe/fast/text/complex-synthetic-bold-space-width-expected.txt:
• platform/wpe/fast/text/emoji-expected.txt:
• platform/wpe/fast/text/firstline/001-expected.txt:
• platform/wpe/fast/text/indic-expected.txt:
• platform/wpe/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
• platform/wpe/fast/text/international/bidi-layout-across-linebreak-expected.txt:
• platform/wpe/fast/text/international/bidi-listbox-atsui-expected.txt:
• platform/wpe/fast/text/international/bidi-listbox-expected.txt:
• platform/wpe/fast/text/international/bidi-menulist-expected.txt:
• platform/wpe/fast/text/international/hebrew-vowels-expected.txt:
• platform/wpe/fast/text/international/hindi-spacing-expected.txt:
• platform/wpe/fast/text/international/thai-baht-space-expected.txt:
• platform/wpe/fast/text/midword-break-after-breakable-char-expected.txt:
• platform/wpe/fast/text/svg-font-face-with-kerning-expected.txt:
• platform/wpe/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
• platform/wpe/fast/transforms/bounding-rect-zoom-expected.txt:
• platform/wpe/fast/writing-mode/english-bt-text-expected.txt:
• platform/wpe/fast/writing-mode/english-lr-text-expected.txt:
• platform/wpe/fast/writing-mode/english-rl-text-expected.txt:
• platform/wpe/fast/writing-mode/fieldsets-expected.txt:
• platform/wpe/fast/writing-mode/text-orientation-basic-expected.txt:
• platform/wpe/fast/xsl/xslt-enc-cyr-expected.txt:
• platform/wpe/fast/xsl/xslt-enc-expected.txt:
• platform/wpe/fast/xsl/xslt-enc16-expected.txt:
• platform/wpe/fast/xsl/xslt-enc16to16-expected.txt:
• platform/wpe/fonts/cursive-expected.txt:
• platform/wpe/fonts/default-expected.txt:
• platform/wpe/fonts/fantasy-expected.txt:
• platform/wpe/fonts/monospace-expected.txt:
• platform/wpe/fonts/sans-serif-expected.txt:
• platform/wpe/fonts/serif-expected.txt:
• platform/wpe/http/tests/loading/simple-subframe-expected.txt:
• platform/wpe/http/tests/misc/favicon-as-image-expected.txt:
• platform/wpe/http/tests/misc/frame-access-during-load-expected.txt:
• platform/wpe/http/tests/navigation/javascriptlink-frames-expected.txt:
• platform/wpe/http/tests/navigation/postredirect-basic-expected.txt:
• platform/wpe/http/tests/navigation/postredirect-goback1-expected.txt:
• platform/wpe/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
• platform/wpe/scrollbars/overflow-scrollbar-combinations-expected.txt:
• platform/wpe/svg/custom/getsvgdocument-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug106158-1-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug10633-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug113235-1-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug1188-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug1224-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug131020-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug131020_iframe-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug1318-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug1430-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug16012-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug17138-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug19599-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug20579-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug20804-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug23235-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug23299-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug25663-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug28928-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug2962-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug30332-1-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug30559-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug30692-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug32205-2-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug32205-3-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug4382-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug43854-2-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug4427-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug4527-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug46368-1-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug46368-2-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug5538-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug55694-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug5799-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug82946-1-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug8858-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug9123-1-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug92143-expected.txt:
• platform/wpe/tables/mozilla/core/bloomberg-expected.txt:
• platform/wpe/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
• platform/wpe/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_border_1-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_border_2-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_border_3-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_cellpadding-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_cellspacing-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_td_align_left-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_td_align_right-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_td_colspan-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_td_height-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_td_width-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_th_align_center-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_th_align_left-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_th_align_right-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_th_colspan-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_th_height-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_th_width-expected.txt:
• platform/wpe/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
• platform/wpe/tables/mozilla/other/wa_table_tr_align-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug11331-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug1262-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/core/col_span2-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/other/test4-expected.txt:
• platform/wpe/transforms/3d/hit-testing/backface-hit-test-expected.txt:
• platform/wpe/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt:
• platform/wpe/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
• platform/wpe/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt:
• platform/wpe/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt:
• platform/wpe/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
• platform/wpe/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
• platform/wpe/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
• platform/wpe/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt:
• platform/wpe/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:

6:07 PM Changeset in webkit [268567] by pvollan@apple.com

• 6 edits in trunk/Source/WebKit

[macOS] Issue temporary sandbox extension to the Launch Services daemon
​https://bugs.webkit.org/show_bug.cgi?id=217781
<rdar://problem/70350924>

Reviewed by Brent Fulgham.

To support blocking of the Launch Services daemon in the WebContent process, issue temporary sandbox extension to this service on macOS.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

• WebProcess/com.apple.WebProcess.sb.in:

6:01 PM Changeset in webkit [268566] by Keith Rollin

• 2 edits in trunk/Source/WebCore

Lessen the reliance on VPATH in WebCore/DerivedSources.make
​https://bugs.webkit.org/show_bug.cgi?id=217696
<rdar://problem/70279941>

Reviewed by Darin Adler.

Due to the way vpath/VPATH works in make, we can get into a
situation where necessarily IDL files are not copied to their correct
locations.

WebKit comes with many IDL files. When building for internal purposes,
Apple can add to or modify this set of IDL files. When creating
Engineering builds, these additional IDL files are copied to
.../WebKitBuild/<configuration>/usr/local/includes. When performing
Production builds, these IDL files are included in the SDK. This
arrangement can be seen in DerivedSources.make:

vpath %.idl $(BUILT_PRODUCTS_DIR)/usr/local/include $(SDKROOT)/usr/local/include

In order to get these IDL files into a location where they can be
uniformly found and handled, there is a step in DerivedSources.make
that copies them to the current directory, which is
WebKitBuild/<configuration>/DerivedSources/WebCore:

$(ADDITIONAL_BINDING_IDLS) : % : WebKitAdditions/%
cp $< .

The IDL files specified in ADDITIONAL_BINDING_IDLS are specified as
bare files names, meaning that vpath and VPATH are employed to find
them. Given the vpath specification previously shown, if the IDL files
can be found in $(BUILT_PRODUCTS_DIR)/usr/local/include, they are
copied locally. Otherwise, they should be found in
$(SDKROOT)/usr/local/include and copied locally.

As it turns out, vpath/VPATH resolution is performed not only on the
prerequisites of the build rule, but also the target (see section
4.5.3 of the GNU make manual). This means that the files specified
on the left side of the cp rule above are also searched for. And
since the standard IDL files (the ones that are being replaced with
the Apple-specific versions) can be found on VPATH as it's defined in
DerivedSources.make (specifically, in $(WebCore)/dom), then those
files participate in determining if the cp rule is executed.

Consider the normal build case: repositories are checked out (applying
the current modification timestamp to the files). During the build,
the files in $(ADDITIONAL_BINDING_IDLS) are copied to either
BUILT_PRODUCTS_DIR or to SDKROOT, which again modifies their
timestamps. We eventually get to the build rule for the cp
operation. Because the files in WebKitAdditions (be it in the local
build directory or the SDK) are *newer* than the checked-out ones in
$(WebCore)/dom due to their having been copied after they were
checked-out, then the cp command is invoked and then files are
copied to the current build directory.

However, consider a slightly different build case. In this case,
projects are checked out and built one at a time. So the project
producing the files in ADDITIONAL_BINDING_IDLS is checked out and then
the IDL files are copied to their intermediate location and have their
timestamps set to that time. Later, WebCore is checked out, and
DerivedSources.make is eventually invoked. Now, the files in
$(WebCore)/dom are *newer* than those in WebKitAdditions. make
determines that the IDL files are up-to-date and does not execute the
cp commands. The IDL files are not copied, and the build then either
fails (because of missing files) or proceeds incorrectly (because the
wrong IDL files are found).

The solution to this issue is to lessen the reliance on vpath/VPATH in
DerivedSources.make. Instead, be more explicit about where files can
be found and trim down vpath/VPATH to it's bare minimum. With
vpath/VPATH reduced, we remove the issue of files being accidentally
discovered that we don't want discovered.

The modifications effected to make this change are:

• Remove the definition of VPATH.
• Dynamically build up an idl-only "VPATH" as needed with the "vpath" directive.
• Manually look for the additional IDL files at their expected locations without using vpath/VPATH.
• For the files that used to be found on VPATH, specify their actual locations (typically by prefixing them with $(WebCore).
• (Cleanup) Consistently refer to local files with bare names (that is, remove the "./" that some files were prefixed with).
• (Cleanup) Use consistent spacing around "<" and ">" redirection symbols.
• (Cleanup) Remove some redundant prerequisites from the build rule involving IDL_INTERMEDIATE_PATTERNS.

No new tests -- no new or changed functionality.

• DerivedSources.make:

5:34 PM Changeset in webkit [268565] by Chris Dumez

• 8 edits in trunk/Source/WebCore

Move AudioContext-specific logic out of BaseAudioContext
​https://bugs.webkit.org/show_bug.cgi?id=217794

Reviewed by Geoffrey Garen.

Move AudioContext-specific logic out of BaseAudioContext and into the
AudioContext class. This required having WebKitAudioContext subclass
AudioContext instead of BaseAudioContext.

No new tests, no Web-facing behavior change.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::suspendRendering):
(WebCore::AudioContext::resumeRendering):
(WebCore::AudioContext::nodeWillBeginPlayback):
(WebCore::AudioContext::startRendering):
(WebCore::AudioContext::lazyInitialize):
(WebCore::AudioContext::willPausePlayback):

• Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::AudioContext):

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::lazyInitialize):

• Modules/webaudio/BaseAudioContext.h:

(WebCore::BaseAudioContext::nodeWillBeginPlayback):
(WebCore::BaseAudioContext::mediaSession const):

• Modules/webaudio/DefaultAudioDestinationNode.h:
• Modules/webaudio/WebKitAudioContext.cpp:

(WebCore::WebKitAudioContext::WebKitAudioContext):

• Modules/webaudio/WebKitAudioContext.h:

(WebCore::WebKitAudioContext::listener):

5:28 PM Changeset in webkit [268564] by weinig@apple.com

• 22 edits in trunk

CSSStyleDeclaration breaks JS spec (properties not showing up in Object.getOwnPropertyNames)
​https://bugs.webkit.org/show_bug.cgi?id=217623

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/css/cssom/cssstyledeclaration-properties-expected.txt:

Update test result now that it is passing.

Source/WebCore:

Replace named getter/setter based implementation of access to CSSStyleDeclaration property values
with a generated partial interface that lists all the properties exactly.

To keep things consistent with existing behavior, in addition to the spec'd properties, we also
maintain additional properties such as Epub* (in addition to the epub* properties the spec says
we should), and Css, css, Pos, pos, Pixel, and Pixel prefixed properties. As a follow up, we should
consider removing these as they are not supported by the standard or other browsers.

• CMakeLists.txt:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:

Generate CSSStyleDeclaration+PropertyNames.idl and ensure it is compile together with the other
bindings.

• css/makeprop.pl:

Add generation of CSSStyleDeclaration+PropertyNames.idl from CSSProperties.json.

• bindings/scripts/IDLAttributes.json:

Remove CallNamedSetterOnlyForSupportedProperties and DefaultDefineOwnProperty extended attributes,
which now have no users, and add the CSSProperty extended attribute, used to avoid unnecessary
implementation overhead for each property. Rather, in an analogous way to EventHandlers, the bindings
now directly pass in the associate CSSPropertyID to an appropriate CSSStyleDeclaration function.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateInvokeNamedPropertySetter):
(GeneratePut):
(GeneratePutByIndex):
(GenerateDefineOwnProperty):
Remove all use of CallNamedSetterOnlyForSupportedProperties.

(InstanceOverridesDefineOwnProperty):
Remove support for DefaultDefineOwnProperty, which is now unused.

(ToMethodName):
Match the actual setting name, and don't transform names that start with CSSOM.

(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
Add support for the new CSSProperty extended attribute which uses the passsed
value to to directly call CSSStyleDeclaration functions with a CSSPropertyID.

• css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::setPropertyValueInternal):
(WebCore::CSSStyleDeclaration::getPropertyValueInternalForPosOrPixelPrefixed):
(WebCore::CSSStyleDeclaration::setPropertyValueInternalForPosOrPixelPrefixed):
(WebCore::CSSStyleDeclaration::getCSSPropertyIDFromJavaScriptPropertyName):
(WebCore::CSSStyleDeclaration::namedItem): Deleted.
(WebCore::CSSStyleDeclaration::setNamedItem): Deleted.
(WebCore::CSSStyleDeclaration::supportedPropertyNames const): Deleted.

• css/CSSStyleDeclaration.h:

Replace old named getter/setter support code with new helpers which operate directly
on CSSPropertyIDs.

• css/CSSStyleDeclaration.idl:

Update to match the current spec (almost, still need to getPropertyPriority to not return
null) and remove custom named getter/setter operations.

LayoutTests:

• fast/css/style-enumerate-properties-expected.txt:
• fast/css/style-enumerate-properties.html:
• fast/dom/domListEnumeration-expected.txt:
• fast/dom/domListEnumeration.html:

Remove tests for iteration order, which is not standardized, and not consistent among
browsers.

• fast/dom/CSSStyleDeclaration/cssstyledeclaration-properties-descriptor-expected.txt:
• fast/dom/CSSStyleDeclaration/cssstyledeclaration-properties-descriptor.html:

Update now that the properties are proper attributes on the prototype.

• js/dom/put-override-should-not-use-ic.html:

Switch to using a DOMStringList as the object that overrides put, since CSSStyleDeclaration no longer does.

• transitions/transitions-parsing-expected.txt:
• transitions/transitions-parsing.html:

Remove Object.keys() aspect of the test, which is no longer meaningful since the
properties should no longer exist in the result set.

5:09 PM Changeset in webkit [268563] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS] Add telemetry for distributed notification service
​https://bugs.webkit.org/show_bug.cgi?id=217762
<rdar://problem/70341045>

Reviewed by Brent Fulgham.

Add telemetry with backtrace for the distributed notification service on macOS.

• WebProcess/com.apple.WebProcess.sb.in:

5:06 PM Changeset in webkit [268562] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

PDFPlugin.mm:2303:139: error: type 'SEL _Nullable' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing]
<​https://webkit.org/b/217791>
<rdar://problem/70349804>

Reviewed by Tim Horton.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::handleContextMenuEvent):

• Use !! to convert result to bool.

4:51 PM Changeset in webkit [268561] by mmaxfield@apple.com

• 4 edits in trunk/Source/WebCore

[Cocoa] Don't change the text matrix multiple times inside FontCascade::drawGlyphs()
​https://bugs.webkit.org/show_bug.cgi?id=217749

Reviewed by Simon Fraser.

FontCascade::drawGlyphs() may actually call CTFontDrawGlyphs() 4 times:
2 for synthetic bold, times 2 for emulated shadows that we draw ourselves.
Previously, each of these calls can have a different text matrix, because
showGlyphsWithAdvances() called CGContextSetTextPosition(), which affects
the text matrix.

This makes ​https://bugs.webkit.org/show_bug.cgi?id=217506 difficult, because
we don't actually track the text matrix inside the GraphicsContext. In that
patch, we call FontCascade::drawGlyphs() and intercept the resulting CGContext
calls. However, if we detect a modified text matrix inside those CGContext
calls, we have no way of knowing whether it was modified by WebKit or
internally inside Core Text. We need to know this, though, because the
modifications Core Text makes have to be preserved across to the GPU process,
but the modifications WebKit makes need to not be preserved (since the GPU
process will make them naturally).

Tracking the text matrix in the CGContext (a la the CTM) is unnecessary; all
we need to know is whether WebKit changed it or Core Text changed it. Therefore,
this patch migrates all the text matrix computation into standalone functions
that can be called from GPU Process infrastructure, so we can know what WebKit
does there (and also what Core Text does, by omission).

This only works, though, if the text matrix is identical for all the calls to
CTFontDrawGlyphs() inside FontCascade::drawGlyphs(). This patch enforces this
by emulating CGContextSetTextPosition() ourselves by adding a constant to
all the glyph positions. Performance is not a conern because we already iterate
over all the glyphs inside showGlyphsWithAdvances(), so we're already paying
the cost of the loop.

No new tests because there is no behavior change.

• platform/graphics/FontCascade.h:

(WebCore::FontCascade::syntheticObliqueAngle): Deleted.

• platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::showLetterpressedGlyphsWithAdvances):

• platform/graphics/coretext/FontCascadeCoreText.cpp:

(WebCore::rotateLeftTransform):
(WebCore::fillVectorWithHorizontalGlyphPositions):
(WebCore::fillVectorWithVerticalGlyphPositions):
(WebCore::showGlyphsWithAdvances):
(WebCore::computeOverallTextMatrix):
(WebCore::computeVerticalTextMatrix):
(WebCore::FontCascade::drawGlyphs):

4:41 PM Changeset in webkit [268560] by Chris Dumez

• 6 edits
  1 add in trunk/Source/WebCore

Cache JS arguments in AudioWorkletProcessor::process() for performance
​https://bugs.webkit.org/show_bug.cgi?id=217685

Reviewed by Geoffrey Garen.

Cache JS arguments in AudioWorkletProcessor::process() for performance.
Blink has the same optimization here:

• ​https://github.com/chromium/chromium/blob/master/third_party/blink/renderer/modules/webaudio/audio_worklet_processor.cc

No new tests, no Web-facing behavior change.

• Modules/webaudio/AudioWorkletProcessor.cpp:

(WebCore::busChannelCount):
(WebCore::constructFrozenJSArray):
(WebCore::copyDataFromJSArrayToBuses):
(WebCore::copyDataFromBusesToJSArray):
(WebCore::copyDataFromParameterMapToJSObject):
(WebCore::busTopologyMatchesJSArray):
(WebCore::parameterMapTopologyMatchesJSObject):
(WebCore::zeroJSArray):
(WebCore::AudioWorkletProcessor::buildJSArguments):
(WebCore::AudioWorkletProcessor::process):

• Modules/webaudio/AudioWorkletProcessor.h:

3:27 PM Changeset in webkit [268559] by Chris Dumez

• 5 edits in trunk/Source/WebCore

[Cocoa] Simplify logic for caching FFTSetups in FFTFrame
​https://bugs.webkit.org/show_bug.cgi?id=217782

Reviewed by Eric Carlson.

Simplify logic for caching FFTSetups in FFTFrame:

• Use a local static (NeverDestroyed) to cache the FFTSetups to avoid heap allocation and simplify logic a bit.
• Drop FFTFrame::cleanup() since it is dead code.

No new tests, no Web-facing behavior change.

• platform/audio/FFTFrame.h:
• platform/audio/FFTFrameStub.cpp:
• platform/audio/gstreamer/FFTFrameGStreamer.cpp:
• platform/audio/mac/FFTFrameMac.cpp:

(WebCore::FFTFrame::fftSetupForSize):

3:24 PM Changeset in webkit [268558] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Use std::fill_n() instead of for loops in ConstantSourceNode
​https://bugs.webkit.org/show_bug.cgi?id=217777

Reviewed by Eric Carlson.

Use std::fill_n() instead of for loops in ConstantSourceNode.

No new tests, no Web-facing behavior change.

• Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::process):

3:02 PM Changeset in webkit [268557] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Avoid double zero'ing of AudioArray in DelayDSPKernel constructors
​https://bugs.webkit.org/show_bug.cgi?id=217779

Reviewed by Darin Adler.

Avoid double zero'ing of AudioArray in DelayDSPKernel constructors.
The constructors were calling AudioArray::resize() to allocate the
array memory and then AudioArray::zero() to zero-out the memory.
The second step is unnecessary since AudioArray::resize() already
takes care of zeroing out the memory after allocation.

No new tests, no Web-facing behavior change.

• Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):

2:59 PM Changeset in webkit [268556] by Truitt Savell

• 6 edits
  7 adds in trunk/LayoutTests

Rebaseline tests for Catalina and iOS after the changes in r268520
​https://bugs.webkit.org/show_bug.cgi?id=209813

Unreviewed test gardening.

• platform/ios-wk2/fast/block/basic/001-expected.txt: Added.
• platform/mac-catalina/fast/block/basic/001-expected.txt: Added.
• platform/mac-catalina/fast/forms/button-table-styles-expected.txt:
• platform/mac-catalina/fast/forms/input-disabled-color-expected.txt:
• platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac-catalina/fast/forms/plaintext-mode-2-expected.txt:
• platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac-catalina/fast/text/indic-expected.txt: Added.
• platform/mac-catalina/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
• platform/mac-catalina/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.

2:26 PM Changeset in webkit [268555] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Use std::fill_n() instead of for loops in AudioParamTimeline
​https://bugs.webkit.org/show_bug.cgi?id=217775

Reviewed by Darin Adler.

Use std::fill_n() instead of for loops in AudioParamTimeline.

No new tests, no Web facing behavior change.

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::fillWithValue):
(WebCore::AudioParamTimeline::valuesForFrameRange):
(WebCore::AudioParamTimeline::valuesForFrameRangeImpl):
(WebCore::AudioParamTimeline::processExponentialRamp):
(WebCore::AudioParamTimeline::processCancelValues):
(WebCore::AudioParamTimeline::processSetTarget):
(WebCore::AudioParamTimeline::processSetValueCurve):

2:18 PM Changeset in webkit [268554] by Alan Coon

• 1 copy in tags/Safari-610.2.11.1.3

Tag Safari-610.2.11.1.3.

2:15 PM Changeset in webkit [268553] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Use std::fill_n() instead of for loops in AudioParam::calculateFinalValues()
​https://bugs.webkit.org/show_bug.cgi?id=217766

Reviewed by Geoffrey Garen.

Use std::fill_n() instead of for loops in AudioParam::calculateFinalValues().

No new tests, no Web-facing behavior change.

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateFinalValues):

1:56 PM Changeset in webkit [268552] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Add a fast codepath to compute the bounding rect of an inline arc path
​https://bugs.webkit.org/show_bug.cgi?id=217764

Reviewed by Tim Horton.

This is a followup to r268320, which added an implementation of Path::fastBoundingRect for the inline
ArcData case, but left Path::boundingRect as-is. This means that currently, a call to Path::boundingRect
in the case of a simple arc path (represented in ArcData) will cause a CGPath to be allocated and set up,
when we could instead just compute the exact bounds of the path using the center, radius, and start and end
angles.

• platform/graphics/Path.cpp:

(WebCore::computeArcBounds):

Add a helper function to compute the exact bounds of a circular arc. This helper works by first fitting the rect
to the start and end positions, and then extending to the top, left, bottom, or right edges as needed (i.e. if
the start and end angles intersect the top-, left-, bottom- or right-most points in the circle).

(WebCore::Path::boundingRectFromInlineData const):

1:40 PM Changeset in webkit [268551] by weinig@apple.com

• 63 edits in trunk/Source/WebCore

[WebIDL] Bindings do not support two attributes or functions with the same name only differing by case of first character
​https://bugs.webkit.org/show_bug.cgi?id=217776

Reviewed by Chris Dumez.

Due to needing to support cases like CSSStyleDeclaration#webkitAlignSelf and CSSStyleDeclaration#WebkitAlignSelf,
the naming convention for the c-wrapper functions in the generated bindings had to be updated to not ignore the
case of the leading character. The new convention uses a leading _ (unless the identifier already starts with one)
changing a function such as jsDOMWindowInstanceFunctionShowModalDialog to jsDOMWindowInstanceFunction_showModalDialog.

• bindings/js/JSDOMWindowCustom.cpp:
• bindings/js/JSLocationCustom.cpp:

Update for new c-function naming convention.

• bindings/scripts/CodeGeneratorJS.pm:

(MangleAttributeOrFunctionName):
(GetAttributeGetterName):
(GetAttributeSetterName):
(GetFunctionName):
Add a leading underscore to all mangled attribute and function names and remove
leading capitalization. This allows us to have attributes and functions with the
same name except for the capitalization of the first letter.

• bindings/scripts/test/JS/*:

Update bindings test results for new c-function naming scheme.

1:26 PM Changeset in webkit [268550] by Fujii Hironori

• 199 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

• platform/wincairo/css1/box_properties/float_on_text_elements-expected.txt:
• platform/wincairo/css1/color_and_background/background_attachment-expected.txt:
• platform/wincairo/css1/text_properties/text_indent-expected.txt:
• platform/wincairo/editing/deleting/5272440-expected.txt:
• platform/wincairo/editing/deleting/delete-3608445-fix-expected.txt:
• platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
• platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
• platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
• platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
• platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
• platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
• platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
• platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
• platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
• platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
• platform/wincairo/editing/deleting/delete-block-merge-contents-002-expected.txt:
• platform/wincairo/editing/deleting/delete-block-merge-contents-003-expected.txt:
• platform/wincairo/editing/deleting/delete-block-merge-contents-004-expected.txt:
• platform/wincairo/editing/deleting/delete-block-merge-contents-006-expected.txt:
• platform/wincairo/editing/deleting/delete-block-merge-contents-007-expected.txt:
• platform/wincairo/editing/deleting/delete-block-merge-contents-009-expected.txt:
• platform/wincairo/editing/deleting/delete-block-merge-contents-011-expected.txt:
• platform/wincairo/editing/deleting/delete-br-002-expected.txt:
• platform/wincairo/editing/deleting/delete-br-003-expected.txt:
• platform/wincairo/editing/deleting/delete-br-004-expected.txt:
• platform/wincairo/editing/deleting/delete-br-005-expected.txt:
• platform/wincairo/editing/deleting/delete-image-001-expected.txt:
• platform/wincairo/editing/deleting/delete-image-002-expected.txt:
• platform/wincairo/editing/deleting/delete-line-003-expected.txt:
• platform/wincairo/editing/deleting/delete-trailing-ws-002-expected.txt:
• platform/wincairo/editing/deleting/non-smart-delete-expected.txt:
• platform/wincairo/editing/execCommand/4641880-1-expected.txt:
• platform/wincairo/editing/execCommand/4641880-2-expected.txt:
• platform/wincairo/editing/execCommand/4916541-expected.txt:
• platform/wincairo/editing/execCommand/5080333-1-expected.txt:
• platform/wincairo/editing/execCommand/5080333-2-expected.txt:
• platform/wincairo/editing/execCommand/5569741-expected.txt:
• platform/wincairo/editing/execCommand/indent-selection-expected.txt:
• platform/wincairo/editing/execCommand/remove-list-from-range-selection-expected.txt:
• platform/wincairo/editing/input/emacs-ctrl-o-expected.txt:
• platform/wincairo/editing/inserting/4960120-2-expected.txt:
• platform/wincairo/editing/inserting/5002441-expected.txt:
• platform/wincairo/editing/inserting/5156401-2-expected.txt:
• platform/wincairo/editing/inserting/5510537-expected.txt:
• platform/wincairo/editing/inserting/5549929-3-expected.txt:
• platform/wincairo/editing/inserting/6703873-expected.txt:
• platform/wincairo/editing/inserting/break-blockquote-after-delete-expected.txt:
• platform/wincairo/editing/inserting/insert-3775316-fix-expected.txt:
• platform/wincairo/editing/inserting/insert-3778059-fix-expected.txt:
• platform/wincairo/editing/inserting/insert-br-001-expected.txt:
• platform/wincairo/editing/inserting/insert-br-002-expected.txt:
• platform/wincairo/editing/inserting/insert-br-003-expected.txt:
• platform/wincairo/editing/inserting/insert-br-004-expected.txt:
• platform/wincairo/editing/inserting/insert-br-005-expected.txt:
• platform/wincairo/editing/inserting/insert-br-007-expected.txt:
• platform/wincairo/editing/inserting/insert-br-at-tabspan-001-expected.txt:
• platform/wincairo/editing/inserting/insert-br-at-tabspan-002-expected.txt:
• platform/wincairo/editing/inserting/insert-br-at-tabspan-003-expected.txt:
• platform/wincairo/editing/inserting/insert-br-quoted-001-expected.txt:
• platform/wincairo/editing/inserting/insert-br-quoted-002-expected.txt:
• platform/wincairo/editing/inserting/insert-br-quoted-003-expected.txt:
• platform/wincairo/editing/inserting/insert-br-quoted-004-expected.txt:
• platform/wincairo/editing/inserting/insert-br-quoted-005-expected.txt:
• platform/wincairo/editing/inserting/insert-br-quoted-006-expected.txt:
• platform/wincairo/editing/inserting/insert-div-020-expected.txt:
• platform/wincairo/editing/inserting/insert-div-022-expected.txt:
• platform/wincairo/editing/inserting/insert-div-026-expected.txt:
• platform/wincairo/editing/inserting/insert-paragraph-03-expected.txt:
• platform/wincairo/editing/inserting/insert-text-with-newlines-expected.txt:
• platform/wincairo/editing/inserting/paragraph-separator-in-table-1-expected.txt:
• platform/wincairo/editing/inserting/paragraph-separator-in-table-2-expected.txt:
• platform/wincairo/editing/inserting/return-key-with-selection-001-expected.txt:
• platform/wincairo/editing/inserting/return-key-with-selection-002-expected.txt:
• platform/wincairo/editing/inserting/return-key-with-selection-003-expected.txt:
• platform/wincairo/editing/inserting/typing-around-br-001-expected.txt:
• platform/wincairo/editing/selection/3690703-2-expected.txt:
• platform/wincairo/editing/selection/3690703-expected.txt:
• platform/wincairo/editing/selection/3690719-expected.txt:
• platform/wincairo/editing/selection/4975120-expected.txt:
• platform/wincairo/editing/selection/5007143-2-expected.txt:
• platform/wincairo/editing/selection/5007143-expected.txt:
• platform/wincairo/editing/selection/drag-in-iframe-expected.txt:
• platform/wincairo/editing/selection/editable-html-element-expected.txt:
• platform/wincairo/editing/selection/extend-by-character-002-expected.txt:
• platform/wincairo/editing/selection/extend-by-character-004-expected.txt:
• platform/wincairo/editing/selection/extend-selection-bidi-expected.txt:
• platform/wincairo/editing/selection/focus_editable_html-expected.txt:
• platform/wincairo/editing/selection/image-before-linebreak-expected.txt:
• platform/wincairo/editing/selection/move-3875618-fix-expected.txt:
• platform/wincairo/editing/selection/move-backwords-by-word-001-expected.txt:
• platform/wincairo/editing/selection/move-by-character-002-expected.txt:
• platform/wincairo/editing/selection/move-by-character-004-expected.txt:
• platform/wincairo/editing/selection/move-by-sentence-linebreak-expected.txt:
• platform/wincairo/editing/selection/paragraph-granularity-expected.txt:
• platform/wincairo/editing/selection/replaced-boundaries-3-expected.txt:
• platform/wincairo/editing/selection/select-all-002-expected.txt:
• platform/wincairo/editing/selection/select-all-003-expected.txt:
• platform/wincairo/editing/selection/select-all-iframe-expected.txt:
• platform/wincairo/editing/selection/selectNode-expected.txt:
• platform/wincairo/editing/selection/selectNodeContents-expected.txt:
• platform/wincairo/editing/selection/selection-3748164-fix-expected.txt:
• platform/wincairo/editing/selection/selection-actions-expected.txt:
• platform/wincairo/editing/selection/word-granularity-expected.txt:
• platform/wincairo/editing/style/5046875-2-expected.txt:
• platform/wincairo/editing/style/block-styles-007-expected.txt:
• platform/wincairo/editing/style/create-block-for-style-001-expected.txt:
• platform/wincairo/editing/style/create-block-for-style-002-expected.txt:
• platform/wincairo/editing/style/create-block-for-style-003-expected.txt:
• platform/wincairo/editing/style/create-block-for-style-004-expected.txt:
• platform/wincairo/editing/style/create-block-for-style-013-expected.txt:
• platform/wincairo/editing/style/smoosh-styles-001-expected.txt:
• platform/wincairo/editing/style/smoosh-styles-003-expected.txt:
• platform/wincairo/editing/style/style-3998892-fix-expected.txt:
• platform/wincairo/editing/style/style-boundary-001-expected.txt:
• platform/wincairo/editing/style/style-boundary-002-expected.txt:
• platform/wincairo/editing/style/style-boundary-003-expected.txt:
• platform/wincairo/editing/style/style-boundary-004-expected.txt:
• platform/wincairo/editing/style/style-boundary-005-expected.txt:
• platform/wincairo/editing/unsupported-content/list-delete-001-expected.txt:
• platform/wincairo/editing/unsupported-content/list-delete-003-expected.txt:
• platform/wincairo/editing/unsupported-content/list-type-after-expected.txt:
• platform/wincairo/editing/unsupported-content/list-type-before-expected.txt:
• platform/wincairo/editing/unsupported-content/table-delete-002-expected.txt:
• platform/wincairo/editing/unsupported-content/table-type-after-expected.txt:
• platform/wincairo/editing/unsupported-content/table-type-before-expected.txt:
• platform/wincairo/fast/box-shadow/basic-shadows-expected.txt:
• platform/wincairo/fast/clip/nestedTransparencyClip-expected.txt:
• platform/wincairo/fast/clip/overflow-border-radius-combinations-expected.txt:
• platform/wincairo/fast/clip/overflow-border-radius-composited-expected.txt:
• platform/wincairo/fast/clip/overflow-border-radius-transformed-expected.txt:
• platform/wincairo/fast/css-generated-content/inline-display-types-expected.txt:
• platform/wincairo/fast/css-generated-content/table-row-group-to-inline-expected.txt:
• platform/wincairo/fast/css-generated-content/table-row-group-with-before-expected.txt:
• platform/wincairo/fast/css-generated-content/table-row-with-before-expected.txt:
• platform/wincairo/fast/css-generated-content/table-with-before-expected.txt:
• platform/wincairo/fast/css/001-expected.txt:
• platform/wincairo/fast/css/first-letter-first-line-hover-expected.txt:
• platform/wincairo/fast/css/first-line-text-decoration-expected.txt:
• platform/wincairo/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
• platform/wincairo/fast/css/focus-ring-detached-expected.txt:
• platform/wincairo/fast/css/font-smoothing-expected.txt:
• platform/wincairo/fast/css/hsl-color-expected.txt:
• platform/wincairo/fast/css/input-search-padding-expected.txt:
• platform/wincairo/fast/css/layerZOrderCrash-expected.txt:
• platform/wincairo/fast/css/line-height-overflow-expected.txt:
• platform/wincairo/fast/css/nth-child-dynamic-expected.txt:
• platform/wincairo/fast/css/outline-narrowLine-expected.txt:
• platform/wincairo/fast/css/rtl-ordering-expected.txt:
• platform/wincairo/fast/css/text-overflow-ellipsis-expected.txt:
• platform/wincairo/fast/css/text-rendering-expected.txt:
• platform/wincairo/fast/css/word-space-extra-expected.txt:
• platform/wincairo/fast/dom/HTMLElement/bdo-expected.txt:
• platform/wincairo/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
• platform/wincairo/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
• platform/wincairo/fast/dom/HTMLTableElement/colSpan-expected.txt:
• platform/wincairo/fast/dom/HTMLTableElement/createCaption-expected.txt:
• platform/wincairo/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
• platform/wincairo/fast/dom/children-nodes-expected.txt:
• platform/wincairo/fast/dom/focus-contenteditable-expected.txt:
• platform/wincairo/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt:
• platform/wincairo/fast/dynamic/genContentDestroyChildren-expected.txt:
• platform/wincairo/fast/events/standalone-image-drag-to-editable-expected.txt:
• platform/wincairo/fast/inline-block/001-expected.txt:
• platform/wincairo/fast/inline-block/006-expected.txt:
• platform/wincairo/fast/inline-block/contenteditable-baseline-expected.txt:
• platform/wincairo/fast/inline-block/inline-block-vertical-align-expected.txt:
• platform/wincairo/fast/inline-block/tricky-baseline-expected.txt:
• platform/wincairo/fast/line-grid/line-grid-contains-value-expected.txt:
• platform/wincairo/fast/line-grid/line-grid-floating-expected.txt:
• platform/wincairo/fast/line-grid/line-grid-inside-columns-expected.txt:
• platform/wincairo/fast/line-grid/line-grid-into-columns-expected.txt:
• platform/wincairo/fast/line-grid/line-grid-into-floats-expected.txt:
• platform/wincairo/fast/line-grid/line-grid-positioned-expected.txt:
• platform/wincairo/fast/reflections/reflection-direction-expected.txt:
• platform/wincairo/fast/text/basic/012-expected.txt:
• platform/wincairo/fast/text/basic/014-expected.txt:
• platform/wincairo/fast/text/basic/generic-family-reset-expected.txt:
• platform/wincairo/fast/text/capitalize-boundaries-expected.txt:
• platform/wincairo/fast/text/complex-synthetic-bold-space-width-expected.txt:
• platform/wincairo/fast/text/firstline/001-expected.txt:
• platform/wincairo/fast/text/indic-expected.txt:
• platform/wincairo/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
• platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt:
• platform/wincairo/fast/text/international/bidi-listbox-atsui-expected.txt:
• platform/wincairo/fast/text/international/bidi-listbox-expected.txt:
• platform/wincairo/fast/text/international/bidi-menulist-expected.txt:
• platform/wincairo/fast/text/international/hebrew-vowels-expected.txt:
• platform/wincairo/fast/text/international/hindi-spacing-expected.txt:
• platform/wincairo/fast/text/international/thai-baht-space-expected.txt:
• platform/wincairo/fast/text/midword-break-after-breakable-char-expected.txt:
• platform/wincairo/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
• platform/wincairo/fonts/cursive-expected.txt:
• platform/wincairo/fonts/default-expected.txt:
• platform/wincairo/fonts/monospace-expected.txt:
• platform/wincairo/fonts/sans-serif-expected.txt:
• platform/wincairo/fonts/serif-expected.txt:
• platform/wincairo/http/tests/misc/favicon-as-image-expected.txt:
• platform/wincairo/http/tests/misc/frame-access-during-load-expected.txt:

1:24 PM Changeset in webkit [268549] by Jonathan Bedard

• 7 edits in trunk/Tools

[webkitpy] Use webkitcorepy's autoinstaller for mechanize
​https://bugs.webkit.org/show_bug.cgi?id=217683
<rdar://problem/70272262>

Reviewed by Aakash Jain.

• Scripts/webkitpy/init.py: Add mechanize.
• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._get_browser):

• Scripts/webkitpy/common/net/buildbot/buildbot.py:
• Scripts/webkitpy/common/net/ewsserver.py:

(EWSServer.init):

• Scripts/webkitpy/common/net/networktransaction_unittest.py:

(NetworkTransactionTest._raise_500_error):
(NetworkTransactionTest._raise_URLError):
(NetworkTransactionTest._raise_404_error):

• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Remov _install_mechanize().
(AutoinstallImportHook._install_mechanize): Deleted.

12:55 PM Changeset in webkit [268548] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

[WinCairo][GraphicsLayerTextureMapper] css3/filters/backdrop/backdrop-filter-with-border-radius-and-reflection-remove.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=217746

Reviewed by Don Olmstead.

If replica layers is removed, replicaLayer() and can be null in
commitLayerChanges(). Null checking is needed.

• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::commitLayerChanges): Added null checking for maskLayer() and replicaLayer().

12:49 PM Changeset in webkit [268547] by graouts@webkit.org

• 6 edits
  6 adds in trunk

Updating an individual transform CSS property has no visual change when composited
​https://bugs.webkit.org/show_bug.cgi?id=217769
<rdar://problem/70344280>

Reviewed by Simon Fraser.

Source/WebCore:

Ensure that changes to the translate, scale and rotate CSS properties have the same
effect than when the transform property is changed for composited elements.

Tests: transforms/2d/rotate-change-composited.html

transforms/2d/scale-change-composited.html
transforms/2d/translate-change-composited.html

• platform/graphics/transforms/RotateTransformOperation.h:
• platform/graphics/transforms/ScaleTransformOperation.h:
• platform/graphics/transforms/TranslateTransformOperation.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::recompositeChangeRequiresGeometryUpdate):
(WebCore::styleHas3DTransformOperation):
(WebCore::styleTransformOperationsAreRepresentableIn2D):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform const):
(WebCore::RenderLayerCompositor::layerHas3DContent const):

LayoutTests:

Add new tests that check that changing the value of one of the individual transform
CSS properties when the element is composited yields a visual change.

• transforms/2d/rotate-change-composited-expected.html: Added.
• transforms/2d/rotate-change-composited.html: Added.
• transforms/2d/scale-change-composited-expected.html: Added.
• transforms/2d/scale-change-composited.html: Added.
• transforms/2d/translate-change-composited-expected.html: Added.
• transforms/2d/translate-change-composited.html: Added.

12:48 PM Changeset in webkit [268546] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

[WinCairo][GraphicsLayerTextureMapper] A parent layer's filter isn't applied to its child layer at the first paint
​https://bugs.webkit.org/show_bug.cgi?id=217748

Reviewed by Don Olmstead.

• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setFilters): Removed
unnecessary checking of m_layer.textureMapper().

12:39 PM Changeset in webkit [268545] by clopez@igalia.com

• 499 edits
  2 adds
  16 deletes in trunk/LayoutTests

[GTK] Rebaseline after r268520

Unreviewed gardening.

Merged some expectations on the general baseline that were common to GTK and Mac.
And added platform baselines for the others.

• fast/css/font-face-remote-expected.txt:
• fast/multicol/pagination-h-horizontal-bt-expected.txt:
• fast/multicol/pagination-h-horizontal-tb-expected.txt:
• fast/multicol/pagination-h-vertical-lr-expected.txt:
• fast/multicol/pagination-h-vertical-rl-expected.txt:
• fast/multicol/pagination-v-horizontal-bt-expected.txt:
• fast/multicol/pagination-v-horizontal-tb-expected.txt:
• fast/multicol/pagination-v-vertical-lr-expected.txt:
• fast/multicol/pagination-v-vertical-rl-expected.txt:
• fast/repaint/text-emphasis-h-expected.txt:
• fast/repaint/text-emphasis-v-expected.txt:
• fast/ruby/position-after-expected.txt:
• fast/text/decorations-transformed-expected.txt:
• fast/text/soft-hyphen-4-expected.txt:
• platform/glib/fast/backgrounds/border-radius-split-background-expected.txt:
• platform/glib/fast/backgrounds/border-radius-split-background-image-expected.txt:
• platform/glib/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
• platform/glib/fast/block/positioning/differing-writing-modes-expected.txt:
• platform/glib/fast/block/positioning/differing-writing-modes-replaced-expected.txt:
• platform/glib/fast/block/positioning/trailing-space-test-expected.txt:
• platform/glib/fast/borders/border-image-outset-split-inline-expected.txt:
• platform/glib/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt:
• platform/glib/fast/borders/border-styles-split-expected.txt:
• platform/glib/fast/css-generated-content/table-row-group-to-inline-expected.txt:
• platform/glib/fast/css-generated-content/table-row-group-with-before-expected.txt:
• platform/glib/fast/css-generated-content/table-row-with-before-expected.txt:
• platform/glib/fast/css-generated-content/table-with-before-expected.txt:
• platform/glib/fast/css/001-expected.txt:
• platform/glib/fast/css/first-letter-first-line-hover-expected.txt:
• platform/glib/fast/css/focus-ring-detached-expected.txt:
• platform/glib/fast/css/font-smoothing-expected.txt:
• platform/glib/fast/css/outline-narrowLine-expected.txt:
• platform/glib/fast/css/word-space-extra-expected.txt:
• platform/glib/fast/dynamic/genContentDestroyChildren-expected.txt:
• platform/glib/fast/frames/001-expected.txt:
• platform/glib/fast/hidpi/image-set-border-image-comparison-expected.txt:
• platform/glib/fast/inline-block/001-expected.txt:
• platform/glib/fast/inline-block/006-expected.txt:
• platform/glib/fast/inline-block/tricky-baseline-expected.txt:
• platform/glib/fast/inline/positionedLifetime-expected.txt:
• platform/glib/fast/invalid/010-expected.txt:
• platform/glib/fast/layers/overflow-scroll-auto-switch-expected.txt:
• platform/glib/fast/multicol/column-break-with-balancing-expected.txt:
• platform/glib/fast/multicol/column-count-with-rules-expected.txt:
• platform/glib/fast/multicol/float-paginate-empty-lines-expected.txt:
• platform/glib/fast/multicol/float-paginate-expected.txt:
• platform/glib/fast/multicol/paginate-block-replaced-expected.txt:
• platform/glib/fast/multicol/positioned-split-expected.txt:
• platform/glib/fast/multicol/table-vertical-align-expected.txt:
• platform/glib/fast/multicol/unsplittable-inline-block-expected.txt:
• platform/glib/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
• platform/glib/fast/multicol/vertical-lr/column-count-with-rules-expected.txt:
• platform/glib/fast/multicol/vertical-lr/float-paginate-expected.txt:
• platform/glib/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt:
• platform/glib/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
• platform/glib/fast/multicol/vertical-rl/column-count-with-rules-expected.txt:
• platform/glib/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
• platform/glib/fast/multicol/vertical-rl/float-paginate-expected.txt:
• platform/glib/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt:
• platform/glib/fast/overflow/002-expected.txt:
• platform/glib/fast/overflow/overflow-float-stacking-expected.txt:
• platform/glib/fast/reflections/reflection-direction-expected.txt:
• platform/glib/fast/replaced/007-expected.txt:
• platform/glib/fast/table/005-expected.txt:
• platform/glib/fast/table/039-expected.txt:
• platform/glib/fast/transforms/transformed-caret-expected.txt:
• platform/glib/fast/writing-mode/basic-vertical-line-expected.txt:
• platform/glib/fast/writing-mode/basic-vertical-line-mixed-expected.txt:
• platform/glib/fast/writing-mode/border-styles-vertical-lr-expected.txt:
• platform/glib/fast/writing-mode/border-styles-vertical-lr-mixed-expected.txt:
• platform/glib/fast/writing-mode/border-styles-vertical-rl-expected.txt:
• platform/glib/fast/writing-mode/border-styles-vertical-rl-mixed-expected.txt:
• platform/glib/scrollbars/basic-scrollbar-expected.txt:
• platform/glib/scrollbars/disabled-scrollbar-expected.txt:
• platform/glib/scrollbars/scrollbar-buttons-expected.txt:
• platform/glib/scrollbars/scrollbar-orientation-expected.txt:
• platform/glib/svg/as-image/animated-svg-as-image-expected.txt:
• platform/glib/svg/as-image/animated-svg-as-image-same-image-expected.txt:
• platform/glib/tables/mozilla/bugs/bug11026-expected.txt:
• platform/glib/tables/mozilla/bugs/bug149275-1-expected.txt:
• platform/glib/tables/mozilla/bugs/bug19061-1-expected.txt:
• platform/glib/tables/mozilla/bugs/bug19061-2-expected.txt:
• platform/glib/tables/mozilla/bugs/bug28341-expected.txt:
• platform/glib/tables/mozilla/bugs/bug4093-expected.txt:
• platform/glib/tables/mozilla/bugs/bug4284-expected.txt:
• platform/glib/tables/mozilla/bugs/bug43854-1-expected.txt:
• platform/glib/tables/mozilla/bugs/bug4849-2-expected.txt:
• platform/glib/tables/mozilla/bugs/bug5838-expected.txt:
• platform/glib/tables/mozilla/bugs/bug60992-expected.txt:
• platform/glib/tables/mozilla/bugs/bug625-expected.txt:
• platform/glib/tables/mozilla/bugs/bug6404-expected.txt:
• platform/glib/tables/mozilla/bugs/bug8950-expected.txt:
• platform/glib/tables/mozilla/bugs/bug92868-expected.txt:
• platform/glib/tables/mozilla/bugs/bug963-expected.txt:
• platform/glib/tables/mozilla/core/col_widths_fix_auto-expected.txt:
• platform/glib/tables/mozilla/marvin/table_row_align_center-expected.txt:
• platform/glib/tables/mozilla/marvin/table_row_align_left-expected.txt:
• platform/glib/tables/mozilla/marvin/table_row_align_right-expected.txt:
• platform/glib/tables/mozilla/marvin/tables_align_center-expected.txt:
• platform/glib/tables/mozilla/marvin/tables_align_left-expected.txt:
• platform/glib/tables/mozilla/marvin/tables_align_right-expected.txt:
• platform/glib/tables/mozilla/marvin/tables_border_0-expected.txt:
• platform/glib/tables/mozilla/marvin/tables_default-expected.txt:
• platform/glib/tables/mozilla/other/nestedTables-expected.txt:
• platform/glib/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
• platform/glib/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
• platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
• platform/gtk/css1/color_and_background/background_attachment-expected.txt:
• platform/gtk/css1/text_properties/text_indent-expected.txt:
• platform/gtk/editing/deleting/5272440-expected.txt:
• platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-002-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-003-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-004-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-006-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-007-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-009-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-011-expected.txt:
• platform/gtk/editing/deleting/delete-br-002-expected.txt:
• platform/gtk/editing/deleting/delete-br-003-expected.txt:
• platform/gtk/editing/deleting/delete-br-004-expected.txt:
• platform/gtk/editing/deleting/delete-br-005-expected.txt:
• platform/gtk/editing/deleting/delete-image-001-expected.txt:
• platform/gtk/editing/deleting/delete-image-002-expected.txt:
• platform/gtk/editing/deleting/delete-line-003-expected.txt:
• platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
• platform/gtk/editing/deleting/non-smart-delete-expected.txt:
• platform/gtk/editing/execCommand/4641880-1-expected.txt:
• platform/gtk/editing/execCommand/4641880-2-expected.txt:
• platform/gtk/editing/execCommand/4916541-expected.txt:
• platform/gtk/editing/execCommand/5080333-1-expected.txt:
• platform/gtk/editing/execCommand/5080333-2-expected.txt:
• platform/gtk/editing/execCommand/5569741-expected.txt:
• platform/gtk/editing/execCommand/indent-selection-expected.txt:
• platform/gtk/editing/execCommand/remove-list-from-range-selection-expected.txt:
• platform/gtk/editing/input/emacs-ctrl-o-expected.txt:
• platform/gtk/editing/inserting/4960120-2-expected.txt:
• platform/gtk/editing/inserting/5002441-expected.txt:
• platform/gtk/editing/inserting/5156401-2-expected.txt:
• platform/gtk/editing/inserting/5510537-expected.txt:
• platform/gtk/editing/inserting/5549929-3-expected.txt:
• platform/gtk/editing/inserting/6703873-expected.txt:
• platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
• platform/gtk/editing/inserting/insert-3778059-fix-expected.txt:
• platform/gtk/editing/inserting/insert-br-001-expected.txt:
• platform/gtk/editing/inserting/insert-br-002-expected.txt:
• platform/gtk/editing/inserting/insert-br-003-expected.txt:
• platform/gtk/editing/inserting/insert-br-004-expected.txt:
• platform/gtk/editing/inserting/insert-br-005-expected.txt:
• platform/gtk/editing/inserting/insert-br-007-expected.txt:
• platform/gtk/editing/inserting/insert-br-at-tabspan-001-expected.txt:
• platform/gtk/editing/inserting/insert-br-at-tabspan-002-expected.txt:
• platform/gtk/editing/inserting/insert-br-at-tabspan-003-expected.txt:
• platform/gtk/editing/inserting/insert-br-quoted-001-expected.txt:
• platform/gtk/editing/inserting/insert-br-quoted-002-expected.txt:
• platform/gtk/editing/inserting/insert-br-quoted-003-expected.txt:
• platform/gtk/editing/inserting/insert-br-quoted-004-expected.txt:
• platform/gtk/editing/inserting/insert-br-quoted-005-expected.txt:
• platform/gtk/editing/inserting/insert-br-quoted-006-expected.txt:
• platform/gtk/editing/inserting/insert-div-020-expected.txt:
• platform/gtk/editing/inserting/insert-div-022-expected.txt:
• platform/gtk/editing/inserting/insert-div-026-expected.txt:
• platform/gtk/editing/inserting/insert-paragraph-03-expected.txt:
• platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
• platform/gtk/editing/inserting/paragraph-separator-in-table-1-expected.txt:
• platform/gtk/editing/inserting/paragraph-separator-in-table-2-expected.txt:
• platform/gtk/editing/inserting/return-key-with-selection-001-expected.txt:
• platform/gtk/editing/inserting/return-key-with-selection-002-expected.txt:
• platform/gtk/editing/inserting/return-key-with-selection-003-expected.txt:
• platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
• platform/gtk/editing/pasteboard/5006779-expected.txt:
• platform/gtk/editing/pasteboard/5601583-1-expected.txt:
• platform/gtk/editing/pasteboard/8145-2-expected.txt:
• platform/gtk/editing/pasteboard/bad-placeholder-expected.txt:
• platform/gtk/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
• platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
• platform/gtk/editing/pasteboard/paste-line-endings-003-expected.txt:
• platform/gtk/editing/pasteboard/paste-line-endings-004-expected.txt:
• platform/gtk/editing/pasteboard/paste-line-endings-005-expected.txt:
• platform/gtk/editing/pasteboard/paste-line-endings-007-expected.txt:
• platform/gtk/editing/pasteboard/paste-line-endings-008-expected.txt:
• platform/gtk/editing/pasteboard/paste-line-endings-009-expected.txt:
• platform/gtk/editing/pasteboard/paste-line-endings-010-expected.txt:
• platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
• platform/gtk/editing/pasteboard/paste-match-style-002-expected.txt:
• platform/gtk/editing/pasteboard/paste-text-016-expected.txt:
• platform/gtk/editing/pasteboard/paste-text-019-expected.txt:
• platform/gtk/editing/pasteboard/quirks-mode-br-1-expected.txt:
• platform/gtk/editing/selection/3690703-2-expected.txt:
• platform/gtk/editing/selection/3690703-expected.txt:
• platform/gtk/editing/selection/3690719-expected.txt:
• platform/gtk/editing/selection/4975120-expected.txt:
• platform/gtk/editing/selection/5007143-2-expected.txt:
• platform/gtk/editing/selection/5007143-expected.txt:
• platform/gtk/editing/selection/drag-in-iframe-expected.txt:
• platform/gtk/editing/selection/editable-html-element-expected.txt:
• platform/gtk/editing/selection/extend-by-character-002-expected.txt:
• platform/gtk/editing/selection/extend-by-character-004-expected.txt:
• platform/gtk/editing/selection/extend-selection-bidi-expected.txt:
• platform/gtk/editing/selection/focus_editable_html-expected.txt:
• platform/gtk/editing/selection/image-before-linebreak-expected.txt:
• platform/gtk/editing/selection/move-3875618-fix-expected.txt:
• platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
• platform/gtk/editing/selection/move-by-character-002-expected.txt:
• platform/gtk/editing/selection/move-by-character-004-expected.txt:
• platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt:
• platform/gtk/editing/selection/paragraph-granularity-expected.txt:
• platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
• platform/gtk/editing/selection/select-all-002-expected.txt:
• platform/gtk/editing/selection/select-all-003-expected.txt:
• platform/gtk/editing/selection/select-all-iframe-expected.txt:
• platform/gtk/editing/selection/selectNode-expected.txt:
• platform/gtk/editing/selection/selectNodeContents-expected.txt:
• platform/gtk/editing/selection/selection-3748164-fix-expected.txt:
• platform/gtk/editing/selection/selection-actions-expected.txt:
• platform/gtk/editing/selection/word-granularity-expected.txt:
• platform/gtk/editing/style/5046875-2-expected.txt:
• platform/gtk/editing/style/block-styles-007-expected.txt:
• platform/gtk/editing/style/create-block-for-style-001-expected.txt:
• platform/gtk/editing/style/create-block-for-style-002-expected.txt:
• platform/gtk/editing/style/create-block-for-style-003-expected.txt:
• platform/gtk/editing/style/create-block-for-style-004-expected.txt:
• platform/gtk/editing/style/create-block-for-style-013-expected.txt:
• platform/gtk/editing/style/style-3998892-fix-expected.txt:
• platform/gtk/editing/style/style-boundary-001-expected.txt:
• platform/gtk/editing/style/style-boundary-002-expected.txt:
• platform/gtk/editing/style/style-boundary-003-expected.txt:
• platform/gtk/editing/style/style-boundary-004-expected.txt:
• platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
• platform/gtk/editing/unsupported-content/list-delete-003-expected.txt:
• platform/gtk/editing/unsupported-content/list-type-after-expected.txt:
• platform/gtk/editing/unsupported-content/list-type-before-expected.txt:
• platform/gtk/editing/unsupported-content/table-delete-002-expected.txt:
• platform/gtk/editing/unsupported-content/table-type-after-expected.txt:
• platform/gtk/editing/unsupported-content/table-type-before-expected.txt:
• platform/gtk/fast/backgrounds/background-clip-text-expected.txt:
• platform/gtk/fast/block/basic/001-expected.txt:
• platform/gtk/fast/block/float/002-expected.txt:
• platform/gtk/fast/block/float/021-expected.txt:
• platform/gtk/fast/block/float/br-with-clear-2-expected.txt:
• platform/gtk/fast/block/float/float-avoidance-expected.txt:
• platform/gtk/fast/block/margin-collapse/104-expected.txt:
• platform/gtk/fast/block/positioning/055-expected.txt:
• platform/gtk/fast/block/positioning/056-expected.txt:
• platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.txt:
• platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt:
• platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
• platform/gtk/fast/clip/nestedTransparencyClip-expected.txt:
• platform/gtk/fast/clip/overflow-border-radius-combinations-expected.txt:
• platform/gtk/fast/clip/overflow-border-radius-composited-expected.txt:
• platform/gtk/fast/clip/overflow-border-radius-transformed-expected.txt:
• platform/gtk/fast/css-generated-content/inline-display-types-expected.txt:
• platform/gtk/fast/css/first-line-text-decoration-expected.txt:
• platform/gtk/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
• platform/gtk/fast/css/hsl-color-expected.txt:
• platform/gtk/fast/css/input-search-padding-expected.txt:
• platform/gtk/fast/css/layerZOrderCrash-expected.txt:
• platform/gtk/fast/css/line-height-overflow-expected.txt:
• platform/gtk/fast/css/nth-child-dynamic-expected.txt:
• platform/gtk/fast/css/rtl-ordering-expected.txt:
• platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
• platform/gtk/fast/css/text-rendering-expected.txt:
• platform/gtk/fast/dom/HTMLElement/bdo-expected.txt:
• platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
• platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
• platform/gtk/fast/dom/HTMLTableElement/colSpan-expected.txt:
• platform/gtk/fast/dom/HTMLTableElement/createCaption-expected.txt:
• platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
• platform/gtk/fast/dom/children-nodes-expected.txt:
• platform/gtk/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt:
• platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
• platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
• platform/gtk/fast/encoding/xmacroman-encoding-test-expected.txt:
• platform/gtk/fast/forms/007-expected.txt:
• platform/gtk/fast/forms/basic-inputs-expected.txt:
• platform/gtk/fast/forms/basic-textareas-expected.txt:
• platform/gtk/fast/forms/blankbuttons-expected.txt:
• platform/gtk/fast/forms/button-table-styles-expected.txt:
• platform/gtk/fast/forms/caret-rtl-expected.txt:
• platform/gtk/fast/forms/color/input-appearance-color-expected.txt:
• platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
• platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
• platform/gtk/fast/forms/hidden-listbox-expected.txt:
• platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
• platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
• platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
• platform/gtk/fast/forms/input-appearance-focus-expected.txt:
• platform/gtk/fast/forms/input-appearance-height-expected.txt:
• platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
• platform/gtk/fast/forms/input-appearance-selection-expected.txt:
• platform/gtk/fast/forms/input-appearance-width-expected.txt:
• platform/gtk/fast/forms/input-baseline-expected.txt:
• platform/gtk/fast/forms/input-disabled-color-expected.txt:
• platform/gtk/fast/forms/input-first-letter-expected.txt:
• platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
• platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
• platform/gtk/fast/forms/input-spaces-expected.txt:
• platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
• platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.txt:
• platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
• platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
• platform/gtk/fast/forms/menulist-width-change-expected.txt:
• platform/gtk/fast/forms/negativeLineHeight-expected.txt:
• platform/gtk/fast/forms/option-index-expected.txt:
• platform/gtk/fast/forms/option-script-expected.txt:
• platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
• platform/gtk/fast/forms/option-text-clip-expected.txt:
• platform/gtk/fast/forms/placeholder-position-expected.txt:
• platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
• platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
• platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt:
• platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
• platform/gtk/fast/forms/searchfield-heights-expected.txt:
• platform/gtk/fast/forms/select-baseline-expected.txt:
• platform/gtk/fast/forms/select-block-background-expected.txt:
• platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
• platform/gtk/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/gtk/fast/forms/select-initial-position-expected.txt:
• platform/gtk/fast/forms/select-style-expected.txt:
• platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
• platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
• platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
• platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
• platform/gtk/fast/forms/textfield-outline-expected.txt:
• platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
• platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
• platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
• platform/gtk/fast/inline-block/contenteditable-baseline-expected.txt:
• platform/gtk/fast/inline-block/inline-block-vertical-align-expected.txt:
• platform/gtk/fast/inline/drawStyledEmptyInlines-expected.txt:
• platform/gtk/fast/invalid/021-expected.txt:
• platform/gtk/fast/layers/video-layer-expected.txt:
• platform/gtk/fast/line-grid/line-grid-contains-value-expected.txt:
• platform/gtk/fast/line-grid/line-grid-floating-expected.txt:
• platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt:
• platform/gtk/fast/line-grid/line-grid-into-columns-expected.txt:
• platform/gtk/fast/line-grid/line-grid-into-floats-expected.txt:
• platform/gtk/fast/line-grid/line-grid-positioned-expected.txt:
• platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
• platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
• platform/gtk/fast/multicol/max-height-columns-block-expected.txt:
• platform/gtk/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
• platform/gtk/fast/overflow/006-expected.txt:
• platform/gtk/fast/overflow/line-clamp-expected.txt:
• platform/gtk/fast/overflow/overflow-stacking-expected.txt:
• platform/gtk/fast/overflow/overflow-x-y-expected.txt:
• platform/gtk/fast/overflow/position-fixed-transform-clipping-expected.txt:
• platform/gtk/fast/overflow/table-overflow-float-expected.txt:
• platform/gtk/fast/repaint/block-selection-gap-stale-cache-2-expected.txt:
• platform/gtk/fast/repaint/block-selection-gap-stale-cache-expected.txt:
• platform/gtk/fast/repaint/make-children-non-inline-expected.txt:
• platform/gtk/fast/repaint/selection-after-remove-expected.txt:
• platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
• platform/gtk/fast/repaint/selection-gap-overflow-scroll-expected.txt:
• platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
• platform/gtk/fast/repaint/trailing-floats-root-line-box-overflow-expected.txt: Added.
• platform/gtk/fast/replaced/selection-rect-transform-expected.txt:
• platform/gtk/fast/ruby/ruby-inline-table-expected.txt:
• platform/gtk/fast/table/009-expected.txt:
• platform/gtk/fast/table/040-expected.txt:
• platform/gtk/fast/table/040-vertical-expected.txt:
• platform/gtk/fast/table/cellindex-expected.txt:
• platform/gtk/fast/table/percent-heights-expected.txt:
• platform/gtk/fast/table/table-and-parts-outline-expected.txt:
• platform/gtk/fast/text/basic/012-expected.txt:
• platform/gtk/fast/text/basic/014-expected.txt:
• platform/gtk/fast/text/basic/generic-family-reset-expected.txt:
• platform/gtk/fast/text/capitalize-boundaries-expected.txt:
• platform/gtk/fast/text/complex-synthetic-bold-space-width-expected.txt:
• platform/gtk/fast/text/firstline/001-expected.txt:
• platform/gtk/fast/text/indic-expected.txt:
• platform/gtk/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
• platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
• platform/gtk/fast/text/international/bidi-listbox-atsui-expected.txt:
• platform/gtk/fast/text/international/bidi-listbox-expected.txt:
• platform/gtk/fast/text/international/bidi-menulist-expected.txt:
• platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
• platform/gtk/fast/text/international/hindi-spacing-expected.txt:
• platform/gtk/fast/text/international/thai-baht-space-expected.txt:
• platform/gtk/fast/text/midword-break-after-breakable-char-expected.txt:
• platform/gtk/fast/text/whitespace/029-expected.txt: Added.
• platform/gtk/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
• platform/gtk/fast/transforms/bounding-rect-zoom-expected.txt:
• platform/gtk/fast/writing-mode/english-bt-text-expected.txt:
• platform/gtk/fast/writing-mode/english-lr-text-expected.txt:
• platform/gtk/fast/writing-mode/english-rl-text-expected.txt:
• platform/gtk/fast/writing-mode/fieldsets-expected.txt:
• platform/gtk/fast/writing-mode/text-orientation-basic-expected.txt:
• platform/gtk/fast/xsl/xslt-enc-cyr-expected.txt:
• platform/gtk/fast/xsl/xslt-enc-expected.txt:
• platform/gtk/fast/xsl/xslt-enc16-expected.txt:
• platform/gtk/fast/xsl/xslt-enc16to16-expected.txt:
• platform/gtk/fonts/cursive-expected.txt:
• platform/gtk/fonts/default-expected.txt:
• platform/gtk/fonts/fantasy-expected.txt:
• platform/gtk/fonts/monospace-expected.txt:
• platform/gtk/fonts/sans-serif-expected.txt:
• platform/gtk/fonts/serif-expected.txt:
• platform/gtk/http/tests/loading/simple-subframe-expected.txt:
• platform/gtk/http/tests/local/file-url-sent-as-referer-expected.txt:
• platform/gtk/http/tests/misc/favicon-as-image-expected.txt:
• platform/gtk/http/tests/misc/frame-access-during-load-expected.txt:
• platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
• platform/gtk/media/audio-controls-rendering-expected.txt:
• platform/gtk/media/video-display-toggle-expected.txt:
• platform/gtk/media/video-layer-crash-expected.txt:
• platform/gtk/media/video-transformed-expected.txt:
• platform/gtk/media/video-zoom-expected.txt:
• platform/gtk/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
• platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt:
• platform/gtk/svg/custom/getsvgdocument-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug106158-1-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug10633-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug113235-1-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug1224-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug131020_iframe-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug16012-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug17138-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug20579-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug20804-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug23235-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug23299-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug25663-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug2962-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug30332-1-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug30559-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug30692-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug32205-2-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug32205-3-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug43854-2-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug4427-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug5538-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug5799-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug82946-1-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug8858-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug9123-1-expected.txt:
• platform/gtk/tables/mozilla/core/bloomberg-expected.txt:
• platform/gtk/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
• platform/gtk/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_border_1-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_border_2-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_border_3-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_td_align_left-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_td_align_right-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_td_colspan-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_td_height-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_td_width-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_th_align_center-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_th_align_left-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_th_align_right-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_th_colspan-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_th_height-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_th_width-expected.txt:
• platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
• platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug11331-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/core/col_span2-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
• platform/gtk/transforms/3d/hit-testing/backface-hit-test-expected.txt:
• platform/gtk/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
• platform/ios/fast/css/font-face-remote-expected.txt: Removed.
• platform/ios/fast/ruby/position-after-expected.txt: Removed.
• platform/mac/fast/css/font-face-remote-expected.txt: Removed.
• platform/mac/fast/multicol/pagination-h-horizontal-bt-expected.txt: Removed.
• platform/mac/fast/multicol/pagination-h-horizontal-tb-expected.txt: Removed.
• platform/mac/fast/multicol/pagination-h-vertical-lr-expected.txt: Removed.
• platform/mac/fast/multicol/pagination-h-vertical-rl-expected.txt: Removed.
• platform/mac/fast/multicol/pagination-v-horizontal-bt-expected.txt: Removed.
• platform/mac/fast/multicol/pagination-v-horizontal-tb-expected.txt: Removed.
• platform/mac/fast/multicol/pagination-v-vertical-lr-expected.txt: Removed.
• platform/mac/fast/multicol/pagination-v-vertical-rl-expected.txt: Removed.
• platform/mac/fast/repaint/text-emphasis-h-expected.txt: Removed.
• platform/mac/fast/repaint/text-emphasis-v-expected.txt: Removed.
• platform/mac/fast/ruby/position-after-expected.txt: Removed.
• platform/mac/fast/text/decorations-transformed-expected.txt: Removed.
• platform/mac/fast/text/soft-hyphen-4-expected.txt: Removed.

12:24 PM Changeset in webkit [268544] by Simon Fraser

• 7 edits
  2 adds in trunk

Scrolls in the passive event region only send one wheel event to the DOM
​https://bugs.webkit.org/show_bug.cgi?id=217719

Reviewed by Tim Horton.
Source/WebCore:

When we hit the scrolling thread latching codepath, we'd always use { WheelEventProcessingSteps::ScrollingThread }
for the steps, but that caused us to not send DOM events.

Latching has to store the steps from when latching occurs (we should not re-hit-test
to get the region state on every event), so fix up ScrollingTreeLatchingController to
do that.

Test: fast/scrolling/latching/latched-scroll-in-passive-region.html

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::determineWheelEventProcessing):
(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::handleWheelEventWithNode):

• page/scrolling/ScrollingTree.h:
• page/scrolling/ScrollingTreeLatchingController.cpp:

(WebCore::ScrollingTreeLatchingController::receivedWheelEvent):
(WebCore::ScrollingTreeLatchingController::latchingDataForEvent const):
(WebCore::ScrollingTreeLatchingController::latchedNodeID const):
(WebCore::ScrollingTreeLatchingController::latchedNodeAndSteps const):
(WebCore::ScrollingTreeLatchingController::nodeDidHandleEvent):
(WebCore::ScrollingTreeLatchingController::nodeWasRemoved):
(WebCore::ScrollingTreeLatchingController::clearLatchedNode):
(WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const): Deleted.

• page/scrolling/ScrollingTreeLatchingController.h:
• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):

LayoutTests:

• fast/scrolling/latching/latched-scroll-in-passive-region-expected.txt: Added.
• fast/scrolling/latching/latched-scroll-in-passive-region.html: Added.

12:12 PM Changeset in webkit [268543] by ddkilzer@apple.com

• 2 edits in trunk/Source/WTF

WeakObjCPtr.h is not safe to include in C++ source files
<​https://webkit.org/b/217712>
<rdar://problem/70250667>

Reviewed by Darin Adler.

• wtf/WeakObjCPtr.h:

(WTF::WeakObjCPtr::get const):

• Move implementation outside of the class and wrap it in #ifdef OBJC/#endif. This makes the header safe to compile with other C++ sources, but will fail if get() is used in a C++ source file.

12:09 PM Changeset in webkit [268542] by Lauro Moura

• 2 edits in trunk/Tools

[Flatpak SDK] Check for installed packages in setup_buildir
​https://bugs.webkit.org/show_bug.cgi?id=217768

Reviewed by Philippe Normand.

During a cleanup of one of the bots, setup_builddir failed with a null
self.sdk member, which is set in get_packages.

While I could not reproduce it again, this commit prevents this by
checking whether the packages are installed before continuing the
original setup_builddir steps.

• flatpak/flatpakutils.py:

(WebkitFlatpak.setup_builddir): Check for installed packages.
(WebkitFlatpak.run_in_sandbox): Check for setup_builddir return code.
(WebkitFlatpak.check_installed_packages): Extracted from
setup_dev_env.
(WebkitFlatpak.setup_dev_env): Call extracted method.

11:43 AM Changeset in webkit [268541] by Andres Gonzalez

• 6 edits in trunk

Fix for multiple accessibility layout tests in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=217745

Reviewed by Chris Fleizach.

Source/WebCore:

Fix for the following tests in accessibility isolated tree mode:
accessibility/mac/abbr-acronym-tags.html
accessibility/mac/aria-image-emits-object-replacement.html
accessibility/mac/attributed-string-includes-highlighting.html
accessibility/mac/attributed-string/attributed-string-for-range-with-options.html
accessibility/mac/attributed-string/attributed-string-for-range.html
accessibility/mac/character-offset-visible-position-conversion-with-emoji.html
accessibility/mac/element-for-text-marker.html
accessibility/mac/listmarker-suffix.html
accessibility/mac/media-emits-object-replacement.html
accessibility/mac/stale-textmarker-crash.html
accessibility/mac/string-range-contains-listmarker.html
accessibility/mac/text-marker-for-index.html
accessibility/mac/text-marker-length.html
accessibility/mac/text-marker-paragraph-nav.html
accessibility/mac/text-marker-range-for-node-without-children.html
accessibility/mac/text-marker-sentence-nav.html
accessibility/mac/text-marker-word-nav-collapsed-whitespace.html
accessibility/mac/text-marker-word-nav.html
accessibility/mac/text-markers-for-input-with-placeholder.html
accessibility/mac/webkit-scrollarea-position.html
accessibility/text-marker/text-marker-previous-next.html
accessibility/text-marker/text-marker-range-stale-node-crash.html
accessibility/text-marker/text-marker-range-with-removed-node-crash.html
accessibility/text-marker/text-marker-with-user-select-none.html

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::convertFrameToSpace const):
(WebCore::AXIsolatedObject::elementRange const):

• accessibility/isolatedtree/AXIsolatedObject.h:
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper position]):

LayoutTests:

• accessibility/mac/attributed-string-includes-highlighting.html: Minor code cleanup.

11:26 AM Changeset in webkit [268540] by Russell Epstein

• 2 edits in branches/safari-610-branch/Source/WebCore

Apply patch. rdar://problem/70321689

11:21 AM Changeset in webkit [268539] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Vectorize StereoPanner's panToTargetValue()
​https://bugs.webkit.org/show_bug.cgi?id=217765

Reviewed by Geoffrey Garen.

Vectorize StereoPanner's panToTargetValue().

No new tests, no Web-facing behavior change.

• platform/audio/StereoPanner.cpp:

(WebCore::StereoPanner::panToTargetValue):

• platform/audio/VectorMath.cpp:

(WebCore::VectorMath::multiplyByScalar):
(WebCore::VectorMath::multiplyByScalarThenAddToOutput):
(WebCore::VectorMath::multiplyByScalarThenAddToVector):

• platform/audio/VectorMath.h:

11:19 AM Changeset in webkit [268538] by Jonathan Bedard

• 3 edits in trunk/Tools

[webkitscmpy] Unconditionally extract git-svn-id from commit message
​https://bugs.webkit.org/show_bug.cgi?id=217740
<rdar://problem/70313868>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
• Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git.commit): Unconditionally attempt to extract git-svn-id.

11:17 AM Changeset in webkit [268537] by Aditya Keerthi

• 2 edits in trunk/Source/WebKit

Crash in -[WKDateTimePicker setDateTimePickerToInitialValue]
​https://bugs.webkit.org/show_bug.cgi?id=217763
<rdar://problem/68635008>

Reviewed by Wenson Hsieh.

Crash occurs due to the use of an autoreleased NSString in
setDateTimePickerToInitialValue. To fix, make the variable
a RetainPtr.

• UIProcess/ios/forms/WKDateTimeInputControl.mm:

(-[WKDateTimePicker setDateTimePickerToInitialValue]):

11:07 AM Changeset in webkit [268536] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r268377. rdar://problem/70321875

Unreviewed build fix after r268367.

• Configurations/WebKit.xcconfig: Corrected the definition of WK_PDFKIT_LDFLAGS_maccatalyst.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:07 AM Changeset in webkit [268535] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r268376. rdar://problem/70321635

Cursor window is transparent - but not hidden - when cursor: none is specified
​https://bugs.webkit.org/show_bug.cgi?id=217639
<rdar://problem/70006186>

Reviewed by Simon Fraser.

• Platform/spi/mac/AppKitSPI.h:
• UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::setCursor): Adopt new AppKit SPI to actually hide the cursor when we set it to the "none" shape. This hiding lives until the next time the app-global cursor shape is changed by any client.] We'll re-set it the next time we set the "none" shape.

This is important, because on some platforms, hiding the cursor is a performance improvement
over simply making it transparent.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:07 AM Changeset in webkit [268534] by Alan Coon

• 4 edits in branches/safari-610-branch/Source

Cherry-pick r268367. rdar://problem/70321875

[macCatalyst] Enable WKPDFView
​https://bugs.webkit.org/show_bug.cgi?id=217403
<rdar://problem/48217791>

Reviewed by Tim Horton.

Source/WebKit:

• Configurations/WebKit.xcconfig: Linked PDFKit.framework when building for the Catalyst variant on Big Sur or later.

Source/WTF:

• wtf/PlatformEnableCocoa.h: Enabled WKPDFView when building for the Catalyst variant on Big Sur or later.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:07 AM Changeset in webkit [268533] by Alan Coon

• 5 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r268308. rdar://problem/70321629

[Mac] AirPlay menu does not show up when AirPlay button is clicked
​https://bugs.webkit.org/show_bug.cgi?id=217536
<rdar://problem/69973777>

Reviewed by Eric Carlson.

Source/WebCore:

PAL tries to soft-link the AVRoutePickerView from the AVFoundation framework, rather than the (correct)
AVKit framework. Remove AVRoutePickerView from AVFoundationSoftLink.h and use the already declared version
inside AVRoutePickerViewTargetPicker.mm.

• platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm: (WebCore::AVRoutePickerViewTargetPicker::isAvailable):

Source/WebCore/PAL:

• pal/cocoa/AVFoundationSoftLink.h:
• pal/cocoa/AVFoundationSoftLink.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:07 AM Changeset in webkit [268532] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r268246. rdar://problem/70321627

AX: Website Warning page is inaccessible
​https://bugs.webkit.org/show_bug.cgi?id=217489

Reviewed by Zalan Bujtas.

If we have a safe browsing window, we need to use that instead of the content view.

• UIProcess/Cocoa/WKSafeBrowsingWarning.h:
• UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::accessibilityAttributeValue):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:37 AM Changeset in webkit [268531] by Jonathan Bedard

• 4 edits in trunk/Tools

[webkitscmpy] Support <identifier>@ abbreviated idiom
​https://bugs.webkit.org/show_bug.cgi?id=217716
<rdar://problem/70299119>

Rubber-stamped by Aakash Jain.

• Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
• Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:

(Commit):
(Commit._parse_identifier): Support <identifier>@ shorthand.

• Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py:

(TestCommit.test_parse_identifier):

10:34 AM Changeset in webkit [268530] by Alan Coon

• 4 edits in branches/safari-610-branch/Source/WebCore/dom

Cherry-pick f9437de2cd47. rdar://70261677

Fix the build after cherry-picking r266909.

10:34 AM Changeset in webkit [268529] by Alan Coon

• 8 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266909. rdar://70261677

Source/WebCore:
Text replacements at the beginning of a second line are replaced too early
​https://bugs.webkit.org/show_bug.cgi?id=216327
<rdar://problem/68170353>

Reviewed by Darin Adler.

In the changes in r258871, using SimpleRanges instead of Range causing some side effects
when the replacements at the beginning of lines. The ranges that we are counting are backwards
and the return characters are being counted instead of being ignored. There is almost
certainly a better fix than this, but this patch restores the original logic that
was present when Range was being used, until a better fix can be worked out.

Test: editing/spelling/text-replacement-first-word-second-line.html

• editing/Editor.cpp: (WebCore::Editor::markAndReplaceFor):
• editing/TextCheckingHelper.cpp: (WebCore::TextCheckingParagraph::automaticReplacementStart const): (WebCore::TextCheckingParagraph::automaticReplacementLength const):
• editing/TextCheckingHelper.h:

LayoutTests:
Overlapping text replacements at the beginning of a line are replaced too early
​https://bugs.webkit.org/show_bug.cgi?id=216327

Reviewed by Darin Adler.

• editing/spelling/text-replacement-first-word-second-line-expected.txt: Added.
• editing/spelling/text-replacement-first-word-second-line.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:23 AM Changeset in webkit [268528] by Alexey Shvayka

• 4 edits in trunk

REGRESSION (r268489): test/built-ins/Object/entries/order-after-define-property.js failing on test262 bots
​https://bugs.webkit.org/show_bug.cgi?id=217738

Reviewed by Yusuke Suzuki.

JSTests:

• stress/object-entries.js:

Source/JavaScriptCore:

This change fixes an oversight of r268489 that caused Object.entries to
return a sparse array if its argument contained non-enumerable properties.

• builtins/ObjectConstructor.js:

(entries):

10:01 AM Changeset in webkit [268527] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION (r267662): [ Mojave+ debug wk1 ] webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=217761

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

9:27 AM Changeset in webkit [268526] by aakash_jain@apple.com

• 3 edits in trunk/Tools

EWS bot should fail if a new test is missing its result
​https://bugs.webkit.org/show_bug.cgi?id=177723

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(RunWebKitTests.evaluateResult):

• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.

9:27 AM Changeset in webkit [268525] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION: [ iOS wk2 ews ] media/now-playing-status-without-media.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217759

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

8:43 AM Changeset in webkit [268524] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION (r268178): [iOS] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217741

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

7:36 AM Changeset in webkit [268523] by Karl Rackler

• 2 edits in trunk/LayoutTests

[ Mojave wk1 ews ] media/remote-control-command-seek.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215325

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

6:46 AM Changeset in webkit [268522] by Chris Lord

• 24 edits in trunk/Source

[GTK][WPE] Add support for smooth scrolling animation with async scrolling
​https://bugs.webkit.org/show_bug.cgi?id=210382

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Respect smooth-scrolling setting and fix deadlock issues with async
scrolling on nicosia path.

No new tests, no functional change.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::scrollAnimatorEnabled const):

• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::ThreadedScrollingTree):

• page/scrolling/ThreadedScrollingTree.h:

(WebCore::ThreadedScrollingTree::scrollAnimatorEnabled const):

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ScrollingTreeFrameScrollingNodeNicosia):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ensureScrollAnimationKinetic):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ensureScrollAnimationSmooth):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::stopScrollAnimations):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionRelatedLayers):

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h:
• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ScrollingTreeOverflowScrollingNodeNicosia):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::repositionScrollingLayers):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ensureScrollAnimationKinetic):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ensureScrollAnimationSmooth):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::stopScrollAnimations):

• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h:
• platform/PlatformWheelEvent.h:
• platform/ScrollAnimation.h:
• platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::isActive const):

• platform/ScrollAnimationKinetic.h:
• platform/ScrollAnimationSmooth.cpp:

(WebCore::ScrollAnimationSmooth::scroll):
(WebCore::ScrollAnimationSmooth::isActive const):

• platform/ScrollAnimationSmooth.h:
• platform/generic/ScrollAnimatorGeneric.cpp:

(WebCore::ScrollAnimatorGeneric::ensureSmoothScrollingAnimation):

Source/WebKit:

Add hasPreciseScrollingDeltas to GTK/WPE wheel events.

No new tests needed.

• Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):

• Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode const):
(WebKit::WebWheelEvent::decode):

• Shared/WebWheelEvent.h:
• Shared/WebWheelEventCoalescer.cpp:

(WebKit::WebWheelEventCoalescer::canCoalesce):
(WebKit::WebWheelEventCoalescer::coalesce):

• Shared/gtk/NativeWebWheelEventGtk.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

• Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

• Shared/libwpe/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

4:36 AM Changeset in webkit [268521] by youenn@apple.com

• 19 edits
  1 copy
  2 moves
  3 adds in trunk/Source

Introduce a RemoteAudioSourceProvider to receive audio samples for web audio from GPUProcess
​https://bugs.webkit.org/show_bug.cgi?id=217710

Reviewed by Eric Carlson.

Source/WebCore:

Split WebAudioSourceProviderAVFObjC MediaStreamTrack specific bits in a separate MediaStreamTrackAudioSourceProviderAVFObjC class.
This allows reusing WebAudioSourceProviderAVFObjC for samples coming from audio playback living in GPUProcess.
No change of behavior.

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/audio/cocoa/AudioSampleBufferList.cpp:
• platform/audio/cocoa/AudioSampleBufferList.h:
• platform/audio/cocoa/AudioSampleDataSource.h:
• platform/audio/cocoa/AudioSampleDataSource.mm:
• platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::audioSourceProvider):

• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/WebAudioSourceProvider.h:
• platform/mediastream/mac/CoreAudioCaptureSource.cpp:
• platform/mediastream/mac/MediaStreamTrackAudioSourceProviderCocoa.cpp: Added.

(WebCore::MediaStreamTrackAudioSourceProviderCocoa::create):
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::MediaStreamTrackAudioSourceProviderCocoa):
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::~MediaStreamTrackAudioSourceProviderCocoa):
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::hasNewClient):
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::trackEnabledChanged):
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::audioSamplesAvailable):

• platform/mediastream/mac/MediaStreamTrackAudioSourceProviderCocoa.h: Added.
• platform/mediastream/mac/MockAudioSharedUnit.h:
• platform/mediastream/mac/MockAudioSharedUnit.mm:
• platform/mediastream/mac/WebAudioSourceProviderCocoa.h: Renamed from Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h.
• platform/mediastream/mac/WebAudioSourceProviderCocoa.mm: Renamed from Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm.

(WebCore::WebAudioSourceProviderCocoa::WebAudioSourceProviderCocoa):
(WebCore::WebAudioSourceProviderCocoa::~WebAudioSourceProviderCocoa):
(WebCore::WebAudioSourceProviderCocoa::setClient):
(WebCore::WebAudioSourceProviderCocoa::provideInput):
(WebCore::WebAudioSourceProviderCocoa::prepare):
(WebCore::WebAudioSourceProviderCocoa::receivedNewAudioSamples):

Source/WebKit:

Make use of WebAudioSourceProviderAVFObjC to implement RemoteAudioSourceProvider.
RemoteAudioSourceProvider currently implements an AudioSourceProvider but it is not yet connected to GPUProcess media players.
This will be implemented in a follow-up.

• SourcesCocoa.txt:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::~MediaPlayerPrivateRemote):
(WebKit::MediaPlayerPrivateRemote::audioSourceProvider):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/RemoteAudioSourceProvider.cpp: Added.

(WebKit::RemoteAudioSourceProvider::create):
(WebKit::RemoteAudioSourceProvider::RemoteAudioSourceProvider):
(WebKit::RemoteAudioSourceProvider::~RemoteAudioSourceProvider):
(WebKit::RemoteAudioSourceProvider::close):
(WebKit::RemoteAudioSourceProvider::hasNewClient):
(WebKit::RemoteAudioSourceProvider::audioSamplesAvailable):
(WebKit::RemoteAudioSourceProvider::logChannel const):

• WebProcess/GPU/media/RemoteAudioSourceProvider.h: Added.
• WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:

4:32 AM Changeset in webkit [268520] by Antti Koivisto

• 1066 edits
  69 copies
  33 adds in trunk

Remove <br> render tree dump quirk
​https://bugs.webkit.org/show_bug.cgi?id=209813

Reviewed by Zalan Bujtas.

Source/WebCore:

Stop lying about <br> box dimensions.

• layout/integration/LayoutIntegrationRunIterator.h:

(WebCore::LayoutIntegration::PathRun::baseline const): Deleted.
(WebCore::LayoutIntegration::PathRun::useLineBreakBoxRenderTreeDumpQuirk const): Deleted.

• layout/integration/LayoutIntegrationRunIteratorLegacyPath.h:

(WebCore::LayoutIntegration::RunIteratorLegacyPath::isLineBreak const):
(WebCore::LayoutIntegration::RunIteratorLegacyPath::baseline const): Deleted.
(WebCore::LayoutIntegration::RunIteratorLegacyPath::useLineBreakBoxRenderTreeDumpQuirk const): Deleted.

• layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::baseline const): Deleted.
(WebCore::LayoutIntegration::RunIteratorModernPath::useLineBreakBoxRenderTreeDumpQuirk const): Deleted.

• rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::boundingBoxForRenderTreeDump const): Deleted.

• rendering/RenderLineBreak.h:
• rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

LayoutTests:

• platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
• platform/mac/css1/color_and_background/background_attachment-expected.txt:
• platform/mac/css1/text_properties/text_indent-expected.txt:
• platform/mac/editing/deleting/5272440-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-002-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-003-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-004-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-006-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-007-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-009-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-011-expected.txt:
• platform/mac/editing/deleting/delete-br-003-expected.txt:
• platform/mac/editing/deleting/delete-image-001-expected.txt:
• platform/mac/editing/deleting/delete-image-002-expected.txt:
• platform/mac/editing/deleting/delete-line-003-expected.txt:
• platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
• platform/mac/editing/deleting/non-smart-delete-expected.txt:
• platform/mac/editing/execCommand/4641880-1-expected.txt:
• platform/mac/editing/execCommand/4641880-2-expected.txt:
• platform/mac/editing/execCommand/4916541-expected.txt:
• platform/mac/editing/execCommand/5080333-1-expected.txt:
• platform/mac/editing/execCommand/5080333-2-expected.txt:
• platform/mac/editing/execCommand/5569741-expected.txt:
• platform/mac/editing/execCommand/indent-selection-expected.txt:
• platform/mac/editing/execCommand/remove-list-from-range-selection-expected.txt:
• platform/mac/editing/input/emacs-ctrl-o-expected.txt:
• platform/mac/editing/inserting/4960120-2-expected.txt:
• platform/mac/editing/inserting/5002441-expected.txt:
• platform/mac/editing/inserting/5156401-2-expected.txt:
• platform/mac/editing/inserting/5510537-expected.txt:
• platform/mac/editing/inserting/5549929-3-expected.txt:
• platform/mac/editing/inserting/6703873-expected.txt:
• platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
• platform/mac/editing/inserting/insert-3778059-fix-expected.txt:
• platform/mac/editing/inserting/insert-br-at-tabspan-001-expected.txt:
• platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt:
• platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
• platform/mac/editing/inserting/insert-br-quoted-001-expected.txt:
• platform/mac/editing/inserting/insert-br-quoted-002-expected.txt:
• platform/mac/editing/inserting/insert-br-quoted-003-expected.txt:
• platform/mac/editing/inserting/insert-br-quoted-004-expected.txt:
• platform/mac/editing/inserting/insert-br-quoted-005-expected.txt:
• platform/mac/editing/inserting/insert-br-quoted-006-expected.txt:
• platform/mac/editing/inserting/insert-div-020-expected.txt:
• platform/mac/editing/inserting/insert-div-022-expected.txt:
• platform/mac/editing/inserting/insert-div-026-expected.txt:
• platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
• platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
• platform/mac/editing/inserting/paragraph-separator-in-table-1-expected.txt:
• platform/mac/editing/inserting/paragraph-separator-in-table-2-expected.txt:
• platform/mac/editing/inserting/return-key-with-selection-001-expected.txt:
• platform/mac/editing/inserting/return-key-with-selection-002-expected.txt:
• platform/mac/editing/inserting/return-key-with-selection-003-expected.txt:
• platform/mac/editing/pasteboard/4989774-expected.txt:
• platform/mac/editing/pasteboard/5006779-expected.txt:
• platform/mac/editing/pasteboard/5601583-1-expected.txt:
• platform/mac/editing/pasteboard/8145-2-expected.txt:
• platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
• platform/mac/editing/pasteboard/emacs-cntl-y-001-expected.txt:
• platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
• platform/mac/editing/pasteboard/paste-4038267-fix-expected.txt:
• platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-001-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-002-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-003-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-004-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-005-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-006-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-007-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-008-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-009-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-010-expected.txt:
• platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
• platform/mac/editing/pasteboard/paste-match-style-002-expected.txt:
• platform/mac/editing/pasteboard/paste-text-016-expected.txt:
• platform/mac/editing/pasteboard/paste-text-019-expected.txt:
• platform/mac/editing/pasteboard/quirks-mode-br-1-expected.txt:
• platform/mac/editing/selection/3690703-2-expected.txt:
• platform/mac/editing/selection/3690703-expected.txt:
• platform/mac/editing/selection/3690719-expected.txt:
• platform/mac/editing/selection/5007143-2-expected.txt:
• platform/mac/editing/selection/5007143-expected.txt:
• platform/mac/editing/selection/drag-in-iframe-expected.txt:
• platform/mac/editing/selection/editable-html-element-expected.txt:
• platform/mac/editing/selection/extend-by-character-002-expected.txt:
• platform/mac/editing/selection/extend-by-character-004-expected.txt:
• platform/mac/editing/selection/focus_editable_html-expected.txt:
• platform/mac/editing/selection/image-before-linebreak-expected.txt:
• platform/mac/editing/selection/move-3875618-fix-expected.txt:
• platform/mac/editing/selection/move-backwords-by-word-001-expected.txt:
• platform/mac/editing/selection/move-by-character-002-expected.txt:
• platform/mac/editing/selection/move-by-character-004-expected.txt:
• platform/mac/editing/selection/move-by-sentence-linebreak-expected.txt:
• platform/mac/editing/selection/paragraph-granularity-expected.txt:
• platform/mac/editing/selection/replaced-boundaries-3-expected.txt:
• platform/mac/editing/selection/select-all-002-expected.txt:
• platform/mac/editing/selection/select-all-003-expected.txt:
• platform/mac/editing/selection/select-all-iframe-expected.txt:
• platform/mac/editing/selection/selectNode-expected.txt:
• platform/mac/editing/selection/selectNodeContents-expected.txt:
• platform/mac/editing/selection/selection-3748164-fix-expected.txt:
• platform/mac/editing/selection/selection-actions-expected.txt:
• platform/mac/editing/selection/word-granularity-expected.txt:
• platform/mac/editing/style/5046875-2-expected.txt:
• platform/mac/editing/style/block-styles-007-expected.txt:
• platform/mac/editing/style/create-block-for-style-001-expected.txt:
• platform/mac/editing/style/create-block-for-style-002-expected.txt:
• platform/mac/editing/style/create-block-for-style-003-expected.txt:
• platform/mac/editing/style/create-block-for-style-004-expected.txt:
• platform/mac/editing/style/create-block-for-style-013-expected.txt:
• platform/mac/editing/style/smoosh-styles-001-expected.txt:
• platform/mac/editing/style/style-3998892-fix-expected.txt:
• platform/mac/editing/style/style-boundary-001-expected.txt:
• platform/mac/editing/style/style-boundary-004-expected.txt:
• platform/mac/editing/style/style-boundary-005-expected.txt:
• platform/mac/editing/unsupported-content/list-delete-001-expected.txt:
• platform/mac/editing/unsupported-content/list-delete-003-expected.txt:
• platform/mac/editing/unsupported-content/list-type-after-expected.txt:
• platform/mac/editing/unsupported-content/list-type-before-expected.txt:
• platform/mac/editing/unsupported-content/table-delete-002-expected.txt:
• platform/mac/editing/unsupported-content/table-type-after-expected.txt:
• platform/mac/editing/unsupported-content/table-type-before-expected.txt:
• platform/mac/fast/backgrounds/background-clip-text-expected.txt:
• platform/mac/fast/backgrounds/border-radius-split-background-image-expected.txt:
• platform/mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
• platform/mac/fast/block/float/002-expected.txt:
• platform/mac/fast/block/float/021-expected.txt:
• platform/mac/fast/block/margin-collapse/104-expected.txt:
• platform/mac/fast/block/positioning/056-expected.txt:
• platform/mac/fast/block/positioning/differing-writing-modes-expected.txt:
• platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.txt:
• platform/mac/fast/block/positioning/trailing-space-test-expected.txt:
• platform/mac/fast/borders/border-styles-split-expected.txt:
• platform/mac/fast/box-shadow/basic-shadows-expected.txt:
• platform/mac/fast/clip/nestedTransparencyClip-expected.txt:
• platform/mac/fast/clip/overflow-border-radius-combinations-expected.txt:
• platform/mac/fast/clip/overflow-border-radius-composited-expected.txt:
• platform/mac/fast/clip/overflow-border-radius-transformed-expected.txt:
• platform/mac/fast/css-generated-content/inline-display-types-expected.txt:
• platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.txt:
• platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt:
• platform/mac/fast/css-generated-content/table-row-with-before-expected.txt:
• platform/mac/fast/css-generated-content/table-with-before-expected.txt:
• platform/mac/fast/css/001-expected.txt:
• platform/mac/fast/css/first-letter-first-line-hover-expected.txt:
• platform/mac/fast/css/first-line-text-decoration-expected.txt:
• platform/mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
• platform/mac/fast/css/focus-ring-detached-expected.txt:
• platform/mac/fast/css/font-smoothing-expected.txt:
• platform/mac/fast/css/hsl-color-expected.txt:
• platform/mac/fast/css/layerZOrderCrash-expected.txt:
• platform/mac/fast/css/line-height-overflow-expected.txt:
• platform/mac/fast/css/nth-child-dynamic-expected.txt:
• platform/mac/fast/css/outline-narrowLine-expected.txt:
• platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
• platform/mac/fast/css/text-rendering-expected.txt:
• platform/mac/fast/css/word-space-extra-expected.txt:
• platform/mac/fast/dom/HTMLElement/bdo-expected.txt:
• platform/mac/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
• platform/mac/fast/dom/HTMLTableElement/colSpan-expected.txt:
• platform/mac/fast/dom/HTMLTableElement/createCaption-expected.txt:
• platform/mac/fast/dom/children-nodes-expected.txt:
• platform/mac/fast/dom/focus-contenteditable-expected.txt:
• platform/mac/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt:
• platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
• platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
• platform/mac/fast/encoding/xmacroman-encoding-test-expected.txt:
• platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt:
• platform/mac/fast/forms/007-expected.txt:
• platform/mac/fast/forms/basic-textareas-expected.txt:
• platform/mac/fast/forms/button-table-styles-expected.txt:
• platform/mac/fast/forms/caret-rtl-expected.txt:
• platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
• platform/mac/fast/forms/input-baseline-expected.txt:
• platform/mac/fast/forms/input-disabled-color-expected.txt:
• platform/mac/fast/forms/input-type-text-min-width-expected.txt:
• platform/mac/fast/forms/negativeLineHeight-expected.txt:
• platform/mac/fast/forms/option-index-expected.txt:
• platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/mac/fast/forms/range/slider-padding-expected.txt:
• platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt:
• platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
• platform/mac/fast/frames/001-expected.txt:
• platform/mac/fast/frames/iframe-with-frameborder-expected.txt:
• platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
• platform/mac/fast/hidpi/image-set-border-image-comparison-expected.txt:
• platform/mac/fast/inline-block/001-expected.txt:
• platform/mac/fast/inline-block/006-expected.txt:
• platform/mac/fast/inline-block/contenteditable-baseline-expected.txt:
• platform/mac/fast/inline-block/tricky-baseline-expected.txt:
• platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
• platform/mac/fast/invalid/010-expected.txt:
• platform/mac/fast/invalid/021-expected.txt:
• platform/mac/fast/layers/overflow-scroll-auto-switch-expected.txt:
• platform/mac/fast/layers/video-layer-expected.txt:
• platform/mac/fast/line-grid/line-grid-contains-value-expected.txt:
• platform/mac/fast/line-grid/line-grid-floating-expected.txt:
• platform/mac/fast/line-grid/line-grid-inside-columns-expected.txt:
• platform/mac/fast/line-grid/line-grid-into-columns-expected.txt:
• platform/mac/fast/line-grid/line-grid-into-floats-expected.txt:
• platform/mac/fast/line-grid/line-grid-positioned-expected.txt:
• platform/mac/fast/multicol/column-break-with-balancing-expected.txt:
• platform/mac/fast/multicol/column-count-with-rules-expected.txt:
• platform/mac/fast/multicol/float-paginate-complex-expected.txt:
• platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt:
• platform/mac/fast/multicol/float-paginate-expected.txt:
• platform/mac/fast/multicol/layers-in-multicol-expected.txt:
• platform/mac/fast/multicol/max-height-columns-block-expected.txt:
• platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
• platform/mac/fast/multicol/positioned-split-expected.txt:
• platform/mac/fast/multicol/table-vertical-align-expected.txt:
• platform/mac/fast/multicol/unsplittable-inline-block-expected.txt:
• platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
• platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.txt:
• platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
• platform/mac/fast/multicol/vertical-lr/float-paginate-expected.txt:
• platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt:
• platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
• platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.txt:
• platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
• platform/mac/fast/multicol/vertical-rl/float-paginate-expected.txt:
• platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt:
• platform/mac/fast/overflow/002-expected.txt:
• platform/mac/fast/overflow/006-expected.txt:
• platform/mac/fast/overflow/line-clamp-expected.txt:
• platform/mac/fast/overflow/overflow-float-stacking-expected.txt:
• platform/mac/fast/overflow/overflow-stacking-expected.txt:
• platform/mac/fast/overflow/position-fixed-transform-clipping-expected.txt:
• platform/mac/fast/overflow/table-overflow-float-expected.txt:
• platform/mac/fast/reflections/reflection-direction-expected.txt:
• platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.txt:
• platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.txt:
• platform/mac/fast/repaint/make-children-non-inline-expected.txt:
• platform/mac/fast/repaint/selection-after-remove-expected.txt:
• platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
• platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.txt:
• platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
• platform/mac/fast/replaced/007-expected.txt:
• platform/mac/fast/replaced/selection-rect-transform-expected.txt:
• platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
• platform/mac/fast/ruby/ruby-inline-table-expected.txt:
• platform/mac/fast/ruby/ruby-length-expected.txt:
• platform/mac/fast/ruby/ruby-run-break-expected.txt:
• platform/mac/fast/ruby/ruby-runs-expected.txt:
• platform/mac/fast/ruby/ruby-simple-expected.txt:
• platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
• platform/mac/fast/table/005-expected.txt:
• platform/mac/fast/table/009-expected.txt:
• platform/mac/fast/table/039-expected.txt:
• platform/mac/fast/table/040-expected.txt:
• platform/mac/fast/table/040-vertical-expected.txt:
• platform/mac/fast/table/cellindex-expected.txt:
• platform/mac/fast/table/percent-heights-expected.txt:
• platform/mac/fast/table/table-and-parts-outline-expected.txt:
• platform/mac/fast/text/basic/012-expected.txt:
• platform/mac/fast/text/basic/014-expected.txt:
• platform/mac/fast/text/basic/generic-family-reset-expected.txt:
• platform/mac/fast/text/complex-synthetic-bold-space-width-expected.txt:
• platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
• platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
• platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
• platform/mac/fast/text/international/bidi-listbox-expected.txt:
• platform/mac/fast/text/international/hebrew-vowels-expected.txt:
• platform/mac/fast/text/international/thai-baht-space-expected.txt:
• platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
• platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
• platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
• platform/mac/fast/transforms/transformed-caret-expected.txt:
• platform/mac/fast/writing-mode/border-styles-vertical-lr-expected.txt:
• platform/mac/fast/writing-mode/border-styles-vertical-rl-expected.txt:
• platform/mac/fast/writing-mode/english-bt-text-expected.txt:
• platform/mac/fast/writing-mode/english-lr-text-expected.txt:
• platform/mac/fast/writing-mode/english-rl-text-expected.txt:
• platform/mac/fast/writing-mode/fieldsets-expected.txt:
• platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:
• platform/mac/fast/xsl/xslt-enc-cyr-expected.txt:
• platform/mac/fast/xsl/xslt-enc-expected.txt:
• platform/mac/fast/xsl/xslt-enc16-expected.txt:
• platform/mac/fast/xsl/xslt-enc16to16-expected.txt:
• platform/mac/fonts/default-expected.txt:
• platform/mac/fonts/fantasy-expected.txt:
• platform/mac/fonts/monospace-expected.txt:
• platform/mac/fonts/sans-serif-expected.txt:
• platform/mac/fonts/serif-expected.txt:
• platform/mac/http/tests/loading/simple-subframe-expected.txt:
• platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt:
• platform/mac/http/tests/misc/favicon-as-image-expected.txt:
• platform/mac/http/tests/misc/frame-access-during-load-expected.txt:
• platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
• platform/mac/http/tests/navigation/postredirect-basic-expected.txt:
• platform/mac/http/tests/navigation/postredirect-goback1-expected.txt:
• platform/mac/media/video-transformed-expected.txt:
• platform/mac/scrollbars/basic-scrollbar-expected.txt:
• platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt:
• platform/mac/svg/as-image/animated-svg-as-image-expected.txt:
• platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.txt:
• platform/mac/svg/custom/getsvgdocument-expected.txt:
• platform/mac/tables/mozilla/bugs/bug106158-1-expected.txt:
• platform/mac/tables/mozilla/bugs/bug10633-expected.txt:
• platform/mac/tables/mozilla/bugs/bug11026-expected.txt:
• platform/mac/tables/mozilla/bugs/bug113235-1-expected.txt:
• platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
• platform/mac/tables/mozilla/bugs/bug1224-expected.txt:
• platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
• platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.txt:
• platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
• platform/mac/tables/mozilla/bugs/bug1430-expected.txt:
• platform/mac/tables/mozilla/bugs/bug149275-1-expected.txt:
• platform/mac/tables/mozilla/bugs/bug16012-expected.txt:
• platform/mac/tables/mozilla/bugs/bug17138-expected.txt:
• platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
• platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
• platform/mac/tables/mozilla/bugs/bug19599-expected.txt:
• platform/mac/tables/mozilla/bugs/bug20579-expected.txt:
• platform/mac/tables/mozilla/bugs/bug20804-expected.txt:
• platform/mac/tables/mozilla/bugs/bug23235-expected.txt:
• platform/mac/tables/mozilla/bugs/bug23299-expected.txt:
• platform/mac/tables/mozilla/bugs/bug25663-expected.txt:
• platform/mac/tables/mozilla/bugs/bug28341-expected.txt:
• platform/mac/tables/mozilla/bugs/bug2962-expected.txt:
• platform/mac/tables/mozilla/bugs/bug30332-1-expected.txt:
• platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
• platform/mac/tables/mozilla/bugs/bug32205-2-expected.txt:
• platform/mac/tables/mozilla/bugs/bug32205-3-expected.txt:
• platform/mac/tables/mozilla/bugs/bug4093-expected.txt:
• platform/mac/tables/mozilla/bugs/bug4284-expected.txt:
• platform/mac/tables/mozilla/bugs/bug43854-1-expected.txt:
• platform/mac/tables/mozilla/bugs/bug43854-2-expected.txt:
• platform/mac/tables/mozilla/bugs/bug4427-expected.txt:
• platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
• platform/mac/tables/mozilla/bugs/bug4849-2-expected.txt:
• platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
• platform/mac/tables/mozilla/bugs/bug55694-expected.txt:
• platform/mac/tables/mozilla/bugs/bug5799-expected.txt:
• platform/mac/tables/mozilla/bugs/bug5838-expected.txt:
• platform/mac/tables/mozilla/bugs/bug60992-expected.txt:
• platform/mac/tables/mozilla/bugs/bug6404-expected.txt:
• platform/mac/tables/mozilla/bugs/bug82946-1-expected.txt:
• platform/mac/tables/mozilla/bugs/bug8858-expected.txt:
• platform/mac/tables/mozilla/bugs/bug8950-expected.txt:
• platform/mac/tables/mozilla/bugs/bug9123-1-expected.txt:
• platform/mac/tables/mozilla/bugs/bug92143-expected.txt:
• platform/mac/tables/mozilla/bugs/bug92868-expected.txt:
• platform/mac/tables/mozilla/bugs/bug963-expected.txt:
• platform/mac/tables/mozilla/core/bloomberg-expected.txt:
• platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
• platform/mac/tables/mozilla/core/col_widths_fix_auto-expected.txt:
• platform/mac/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
• platform/mac/tables/mozilla/marvin/table_row_align_center-expected.txt:
• platform/mac/tables/mozilla/marvin/table_row_align_left-expected.txt:
• platform/mac/tables/mozilla/marvin/table_row_align_right-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_align_center-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_align_left-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_align_right-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_border_0-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_border_1-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_border_2-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_border_3-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_cellpadding-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_cellspacing-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_default-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_td_align_left-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_td_align_right-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_td_colspan-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_td_height-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_td_width-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_th_align_center-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_th_align_left-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_th_align_right-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_th_colspan-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_th_height-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_th_width-expected.txt:
• platform/mac/tables/mozilla/other/nestedTables-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug11331-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug1262-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
• platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.txt:
• platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
• platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.txt:
• platform/mac/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt:
• platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
• platform/mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt:
• platform/mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt:
• platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
• platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
• platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
• platform/mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt:
• platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:

3:46 AM Changeset in webkit [268519] by Diego Pino Garcia

• 1 edit
  1 move
  1 add
  2 deletes in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update baseline of fast/css/word-space-extra.html after r268202.

• platform/glib/fast/css/word-space-extra-expected.png: Renamed from LayoutTests/platform/gtk/fast/css/word-space-extra-expected.png.
• platform/glib/fast/css/word-space-extra-expected.txt: Renamed from LayoutTests/platform/gtk/fast/css/word-space-extra-expected.txt.
• platform/wpe/fast/css/word-space-extra-expected.txt: Removed.

3:44 AM Changeset in webkit [268518] by Lauro Moura

• 5 edits in trunk/Tools

webkitpy: Fix remaining pytest autoinstall imports
​https://bugs.webkit.org/show_bug.cgi?id=217694

Reviewed by Carlos Garcia Campos.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump mini

version due to argument rename below.

• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.init): Change argument name to communicate that the first
arg is the name of the package to be imported.

• Scripts/webkitpy/init.py: Some changes:
• Downgrade attr to a compatible version with the pytest used.
• Fix pytest_timeout import name
• Downgrade pytest to 3.x. Version 4.x deprecated direct invocation of

fixtures, which is still used by W3C webdriver test code.

• Scripts/webkitpy/webdriver_tests/pytest_runner.py:

(run): Avoid using pytest autoload features to ensure it would import
plugins like pytest_timeout, triggering their install.

1:09 AM Changeset in webkit [268517] by Adrian Perez de Castro

• 8 edits in trunk/Source

Non-unified build fixes, mid October 2020, take two
​https://bugs.webkit.org/show_bug.cgi?id=217734

Unreviewed build fix.

Source/WebCore:

No new tests needed.

• Modules/webaudio/AudioWorklet.cpp: Add missing AudioWorkletProcessor.h header.
• Modules/webaudio/AudioWorkletGlobalScope.cpp: Add missing BaseAudioContext.h header.
• Modules/webaudio/AudioWorkletNode.cpp: Add missing AudioParamDescriptor.h header.
• Modules/webaudio/AudioWorkletNode.h: Add missing forward declaration for the

JSC::JSGlobalObject type.

• workers/WorkerRunLoop.cpp: Add missing JavaScriptCore/JSRunLoopTimer.h header, move

inclusion of WorkerRunLoop.h header up to please the style checker.

Source/WebKit:

• UIProcess/WebProcessProxy.cpp: Add missing WebPreferencesKeys.h header.

12:54 AM Changeset in webkit [268516] by svillar@igalia.com

• 9 edits in trunk

[css-flexbox] flex-grow property should be animatable
​https://bugs.webkit.org/show_bug.cgi?id=209872

Reviewed by Antoine Quint.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-flexbox/animation/flex-grow-interpolation-expected.txt: New expected PASS results.
• web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt: Additional results.
• web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt: Ditto.
• web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt: Ditto.
• web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt: Ditto.

Source/WebCore:

Make flew-grow animatable as per spec. This allows us to pass a bunch of flexbox animation subtests.

• animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add the wrapper for flex-grow.

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setFlexGrow): Clamp flex-grow to 0 as negative values are invalid.