Context Navigation

← Previous Period
Next Period →

Timeline

Dec 25, 2020:

9:39 PM Changeset in webkit [271086] by aestes@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r270662): SourceBufferParserWebM leaks CMSampleBufferRefs
https://bugs.webkit.org/show_bug.cgi?id=220144

Reviewed by Anders Carlsson.

platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::SourceBufferParserWebM::VideoTrackData::createSampleBuffer):
(WebCore::SourceBufferParserWebM::AudioTrackData::createSampleBuffer): Move the RetainPtr
holding an adopted CMSampleBufferRef rather than leaking it when calling provideMediaData.

1:46 PM Changeset in webkit [271085] by Alan Bujtas

8 edits in trunk/Source/WebCore

[LFC][Integration] Use the pre-computed geometries for the inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=220135
<rdar://problem/72642850>

Reviewed by Antti Koivisto.

Let's skip the tree traversal and recomputing the box geometries in InlineFormattingContext::layoutInFlowContent.

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::inlineReplacedContentHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedContentWidthAndMargin):

layout/inlineformatting/InlineFormattingContext.h:
layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
(WebCore::LayoutIntegration::LineLayout::updateLineBreakBoxDimensions):
(WebCore::LayoutIntegration::LineLayout::layout):

layout/integration/LayoutIntegrationLineLayout.h:
layout/layouttree/LayoutReplacedBox.h:

(WebCore::Layout::ReplacedBox::contentSizeForIntegration const): Deleted.
(WebCore::Layout::ReplacedBox::setContentSizeForIntegration): Deleted.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutModernLines):

9:53 AM Changeset in webkit [271084] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Fast vertical alignment should work with line-height
https://bugs.webkit.org/show_bug.cgi?id=220131

Reviewed by Antti Koivisto.

Adjust the line box height and the root inline box's logical top position as the layout bounds of the inline-block content stretches the line.

layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::LineBoxBuilder):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

2:35 AM Changeset in webkit [271083] by ysuzuki@apple.com

74 edits
1 copy
5 adds
1 delete in trunk/Source/ThirdParty

Update capstone
https://bugs.webkit.org/show_bug.cgi?id=219941

Reviewed by Michael Catanzaro.

capstone/CMakeLists.txt:
capstone/Source/.gitignore:
capstone/Source/.travis.yml:
capstone/Source/CMakeLists.txt:
capstone/Source/COMPILE.TXT:
capstone/Source/COMPILE_CMAKE.TXT:
capstone/Source/COMPILE_MSVC.TXT:
capstone/Source/CREDITS.TXT:
capstone/Source/ChangeLog-capstone:
capstone/Source/HACK.TXT:
capstone/Source/LEB128.h:

(decodeULEB128):

capstone/Source/MCDisassembler.h:
capstone/Source/MCFixedLenDisassembler.h:
capstone/Source/MCInst.c:

(MCInst_Init):
(MCInst_clear):
(MCInst_insert0):
(MCInst_setOpcode):
(MCInst_setOpcodePub):
(MCInst_getOpcode):
(MCInst_getOpcodePub):
(MCInst_getOperand):
(MCInst_getNumOperands):
(MCInst_addOperand2):
(MCOperand_isValid):
(MCOperand_isReg):
(MCOperand_isImm):
(MCOperand_isFPImm):
(MCOperand_getReg):
(MCOperand_setReg):
(MCOperand_getImm):
(MCOperand_setImm):
(MCOperand_getFPImm):
(MCOperand_setFPImm):
(MCOperand_CreateReg1):
(MCOperand_CreateReg0):
(MCOperand_CreateImm1):
(MCOperand_CreateImm0):
(MCOperand_Init): Deleted.

capstone/Source/MCInst.h:
capstone/Source/MCInstrDesc.c:

(MCOperandInfo_isPredicate):
(MCOperandInfo_isOptionalDef):

capstone/Source/MCInstrDesc.h:
capstone/Source/MCRegisterInfo.c:

(MCRegisterInfo_InitMCRegisterInfo):
(DiffListIterator_init):
(DiffListIterator_getVal):
(DiffListIterator_next):
(DiffListIterator_isValid):
(MCRegisterInfo_getMatchingSuperReg):
(MCRegisterInfo_getSubReg):
(MCRegisterInfo_getRegClass):
(MCRegisterClass_contains):

capstone/Source/MCRegisterInfo.h:
capstone/Source/Makefile:
capstone/Source/MathExtras.h:

(Hi_32):
(Lo_32):
(isUIntN):
(isMask_32):
(isMask_64):
(isShiftedMask_32):
(isShiftedMask_64):
(isPowerOf2_32):
(CountLeadingZeros_32):
(CountLeadingOnes_32):
(CountLeadingZeros_64):
(CountLeadingOnes_64):
(CountTrailingZeros_32):
(CountTrailingOnes_32):
(CountTrailingZeros_64):
(CountTrailingOnes_64):
(CountPopulation_32):
(CountPopulation_64):
(Log2_32):
(Log2_64):
(Log2_32_Ceil):
(Log2_64_Ceil):
(GreatestCommonDivisor64):
(BitsToDouble):
(BitsToFloat):
(DoubleToBits):
(FloatToBits):
(MinAlign):
(NextPowerOf2):
(RoundUpToAlignment):
(OffsetToAlignment):
(abs64):
(SignExtend32):
(SignExtend64):
(countLeadingZeros):

capstone/Source/README.md:
capstone/Source/SPONSORS.TXT: Added.
capstone/Source/SStream.c:

(SStream_Init):
(SStream_concat0):
(SStream_concat):
(printInt64Bang):
(printUInt64Bang):
(printInt64):
(printInt32BangDec):
(printInt32Bang):
(printInt32):
(printUInt32Bang):
(printUInt32):

capstone/Source/SStream.h:
capstone/Source/arch/ARM/ARMAddressingModes.h:

(ARM_AM_getAddrOpcStr):
(ARM_AM_getShiftOpcStr):
(ARM_AM_getShiftOpcEncoding):
(ARM_AM_getAMSubModeStr):
(rotr32):
(rotl32):
(getSORegOpc):
(getSORegOffset):
(ARM_AM_getSORegShOp):
(getSOImmValImm):
(getSOImmValRot):
(getSOImmValRotate):
(getSOImmVal):
(isSOImmTwoPartVal):
(getSOImmTwoPartFirst):
(getSOImmTwoPartSecond):
(getThumbImmValShift):
(isThumbImmShiftedVal):
(getThumbImm16ValShift):
(isThumbImm16ShiftedVal):
(getThumbImmNonShiftedVal):
(getT2SOImmValSplatVal):
(getT2SOImmValRotateVal):
(getT2SOImmVal):
(getT2SOImmValRotate):
(isT2SOImmTwoPartVal):
(getT2SOImmTwoPartFirst):
(getT2SOImmTwoPartSecond):
(ARM_AM_getAM2Opc):
(getAM2Offset):
(getAM2Op):
(getAM2ShiftOpc):
(getAM2IdxMode):
(getAM3Opc):
(getAM3Offset):
(getAM3Op):
(getAM3IdxMode):
(getAM4SubMode):
(getAM4ModeImm):
(ARM_AM_getAM5Opc):
(ARM_AM_getAM5Offset):
(ARM_AM_getAM5Op):
(createNEONModImm):
(getNEONModImmOpCmode):
(getNEONModImmVal):
(ARM_AM_decodeNEONModImm):
(getFPImmFloat):

capstone/Source/arch/ARM/ARMBaseInfo.h:

(ARMCC_getOppositeCondition):
(ARMCC_ARMCondCodeToString):
(ARM_PROC_IFlagsToString):
(ARM_PROC_IModToString):
(ARM_MB_MemBOptToString):
(ARM_ISB_InstSyncBOptToString):
(isARMLowRegister):
(ARMII_AddrModeToString):

capstone/Source/arch/ARM/ARMDisassembler.c:

(ITStatus_push_back):
(ITStatus_instrInITBlock):
(ITStatus_instrLastInITBlock):
(ITStatus_getITCC):
(ITStatus_advanceITState):
(ITStatus_setITState):
(Check):
(ARM_getFeatureBits):
(DecodePredicateOperand):
(ARM_init):
(checkDecodedInstruction):
(_ARM_getInstruction):
(AddThumb1SBit):
(AddThumbPredicate):
(UpdateThumbVFPPredicate):
(_Thumb_getInstruction):
(Thumb_getInstruction):
(ARM_getInstruction):
(DecodeGPRnopcRegisterClass):
(DecodeGPRwithAPSRRegisterClass):
(DecodetGPRRegisterClass):
(DecodetcGPRRegisterClass):
(DecoderGPRRegisterClass):
(DecodeDPRRegisterClass):
(DecodeDPR_8RegisterClass):
(DecodeDPR_VFP2RegisterClass):
(DecodeDPairRegisterClass):
(DecodeCCOutOperand):
(DecodeSORegImmOperand):
(DecodeSORegRegOperand):
(DecodeRegListOperand):
(DecodeSPRRegListOperand):
(DecodeDPRRegListOperand):
(DecodeBitfieldMaskOperand):
(DecodeCopMemInstruction):
(DecodeAddrMode2IdxInstruction):
(DecodeSORegMemOperand):
(DecodeAddrMode3Instruction):
(DecodeRFEInstruction):
(DecodeQADDInstruction):
(DecodeMemMultipleWritebackInstruction):
(DecodeCPSInstruction):
(DecodeT2CPSInstruction):
(DecodeT2MOVTWInstruction):
(DecodeArmMOVTWInstruction):
(DecodeSMLAInstruction):
(DecodeAddrModeImm12Operand):
(DecodeAddrMode5Operand):
(DecodeAddrMode7Operand):
(DecodeT2BInstruction):
(DecodeBranchImmInstruction):
(DecodeAddrMode6Operand):
(DecodeVLDInstruction):
(DecodeVLDST1Instruction):
(DecodeVLDST2Instruction):
(DecodeVLDST3Instruction):
(DecodeVLDST4Instruction):
(DecodeVSTInstruction):
(DecodeVLD1DupInstruction):
(DecodeVLD2DupInstruction):
(DecodeVLD3DupInstruction):
(DecodeVLD4DupInstruction):
(DecodeNEONModImmInstruction):
(DecodeVSHLMaxInstruction):
(DecodeShiftRight8Imm):
(DecodeShiftRight16Imm):
(DecodeShiftRight32Imm):
(DecodeShiftRight64Imm):
(DecodeTBLInstruction):
(DecodeThumbAddSpecialReg):
(DecodeThumbBROperand):
(DecodeT2BROperand):
(DecodeThumbCmpBROperand):
(DecodeThumbAddrModeRR):
(DecodeThumbAddrModeIS):
(DecodeThumbAddrModePC):
(DecodeThumbAddrModeSP):
(DecodeT2AddrModeSOReg):
(DecodeT2LoadShift):
(DecodeT2LoadImm8):
(DecodeT2LoadImm12):
(DecodeT2LoadT):
(DecodeT2LoadLabel):
(DecodeT2Imm8S4):
(DecodeT2AddrModeImm8s4):
(DecodeT2AddrModeImm0_1020s4):
(DecodeT2Imm8):
(DecodeT2AddrModeImm8):
(DecodeT2LdStPre):
(DecodeT2AddrModeImm12):
(DecodeThumbAddSPImm):
(DecodeThumbAddSPReg):
(DecodeThumbCPS):
(DecodePostIdxReg):
(DecodeThumbBLXOffset):
(DecodeCoprocessor):
(DecodeThumbTableBranch):
(DecodeThumb2BCCInstruction):
(DecodeT2SOImm):
(DecodeThumbBCCTargetOperand):
(DecodeThumbBLTargetOperand):
(DecodeMemBarrierOption):
(DecodeInstSyncBarrierOption):
(DecodeMSRMask):
(DecodeBankedReg):
(DecodeDoubleRegLoad):
(DecodeDoubleRegStore):
(DecodeLDRPreImm):
(DecodeLDRPreReg):
(DecodeSTRPreImm):
(DecodeSTRPreReg):
(DecodeVLD1LN):
(DecodeVST1LN):
(DecodeVLD2LN):
(DecodeVST2LN):
(DecodeVLD3LN):
(DecodeVST3LN):
(DecodeVLD4LN):
(DecodeVST4LN):
(DecodeVMOVSRR):
(DecodeVMOVRRS):
(DecodeIT):
(DecodeT2LDRDPreInstruction):
(DecodeT2STRDPreInstruction):
(DecodeT2Adr):
(DecodeT2ShifterImmOperand):
(DecodeSwap):
(DecodeVCVTD):
(DecodeVCVTQ):
(DecodeLDR):
(DecodeMRRC2):

capstone/Source/arch/ARM/ARMGenAsmWriter.inc:
capstone/Source/arch/ARM/ARMGenDisassemblerTables.inc:
capstone/Source/arch/ARM/ARMGenInstrInfo.inc:
capstone/Source/arch/ARM/ARMGenRegisterInfo.inc:
capstone/Source/arch/ARM/ARMInstPrinter.c:

(get_op_access):
(set_mem_access):
(op_addImm):
(ARM_getRegName):
(translateShiftImm):
(printRegImmShift):
(printRegName):
(ARM_printInst):
(printOperand):
(printThumbLdrLabelOperand):
(printSORegRegOperand):
(printSORegImmOperand):
(printAM2PreOrOffsetIndexOp):
(printAddrModeTBB):
(printAddrModeTBH):
(printAddrMode2Operand):
(printAddrMode2OffsetOperand):
(printAM3PreOrOffsetIndexOp):
(printAddrMode3Operand):
(printAddrMode3OffsetOperand):
(printPostIdxImm8Operand):
(printPostIdxRegOperand):
(printPostIdxImm8s4Operand):
(printAddrMode5Operand):
(printAddrMode6Operand):
(printAddrMode7Operand):
(printAddrMode6OffsetOperand):
(printBitfieldInvMaskImmOperand):
(printMemBOption):
(printInstSyncBOption):
(printShiftImmOperand):
(printPKHLSLShiftImm):
(printPKHASRShiftImm):
(printRegisterList):
(printGPRPairOperand):
(printSetendOperand):
(printCPSIMod):
(printCPSIFlag):
(printMSRMaskOperand):
(printBankedRegOperand):
(printPredicateOperand):
(printMandatoryPredicateOperand):
(printSBitModifierOperand):
(printNoHashImmediate):
(printPImmediate):
(printCImmediate):
(printCoprocOptionImm):
(printAdrLabelOperand):
(printThumbS4ImmOperand):
(printThumbSRImm):
(printThumbITMask):
(printThumbAddrModeRROperand):
(printThumbAddrModeImm5SOperand):
(printThumbAddrModeImm5S1Operand):
(printThumbAddrModeImm5S2Operand):
(printThumbAddrModeImm5S4Operand):
(printThumbAddrModeSPOperand):
(printT2SOOperand):
(printAddrModeImm12Operand):
(printT2AddrModeImm8Operand):
(printT2AddrModeImm8s4Operand):
(printT2AddrModeImm0_1020s4Operand):
(printT2AddrModeImm8OffsetOperand):
(printT2AddrModeImm8s4OffsetOperand):
(printT2AddrModeSoRegOperand):
(printFPImmOperand):
(printNEONModImmOperand):
(printImmPlusOneOperand):
(printRotImmOperand):
(printModImmOperand):
(printFBits16):
(printFBits32):
(printVectorIndex):
(printVectorListOne):
(printVectorListTwo):
(printVectorListTwoSpaced):
(printVectorListThree):
(printVectorListFour):
(printVectorListOneAllLanes):
(printVectorListTwoAllLanes):
(printVectorListThreeAllLanes):
(printVectorListFourAllLanes):
(printVectorListTwoSpacedAllLanes):
(printVectorListThreeSpacedAllLanes):
(printVectorListFourSpacedAllLanes):
(printVectorListThreeSpaced):
(printVectorListFourSpaced):
(ARM_addVectorDataType):
(ARM_addVectorDataSize):
(ARM_addReg):
(ARM_addUserMode):
(ARM_addSysReg):

capstone/Source/arch/ARM/ARMMapping.c:

(ARM_reg_name2):
(ARM_insn_name):
(ARM_rel_branch):
(ARM_blx_to_arm_mode):
(ARM_reg_access):

capstone/Source/arch/ARM/ARMMapping.h:
capstone/Source/arch/ARM/ARMMappingInsn.inc:
capstone/Source/arch/ARM/ARMMappingInsnOp.inc:
capstone/Source/arch/ARM/ARMModule.c:

(ARM_global_init):
(ARM_option):
(init): Deleted.
(option): Deleted.
(ARM_enable): Deleted.

capstone/Source/arch/ARM/ARMModule.h: Added.
capstone/Source/arch/Mips/MipsDisassembler.c:

(getFeatureBits):
(Mips_init):
(readInstruction16):
(readInstruction32):
(MipsDisassembler_getInstruction):
(Mips_getInstruction):
(getReg):
(DecodeINSVE_DF_4):
(DecodeAddiGroupBranch_4):
(DecodeDaddiGroupBranch_4):
(DecodeBlezlGroupBranch_4):
(DecodeBgtzlGroupBranch_4):
(DecodeBgtzGroupBranch_4):
(DecodeBlezGroupBranch_4):
(DecodeCPU16RegsRegisterClass):
(DecodeGPR64RegisterClass):
(DecodeGPRMM16RegisterClass):
(DecodeGPRMM16ZeroRegisterClass):
(DecodeGPRMM16MovePRegisterClass):
(DecodeGPR32RegisterClass):
(DecodePtrRegisterClass):
(DecodeDSPRRegisterClass):
(DecodeFGR64RegisterClass):
(DecodeFGR32RegisterClass):
(DecodeCCRRegisterClass):
(DecodeFCCRegisterClass):
(DecodeCCRegisterClass):
(DecodeFGRCCRegisterClass):
(DecodeMem):
(DecodeCacheOp):
(DecodeCacheOpMM):
(DecodeCacheOpR6):
(DecodeSyncI):
(DecodeMSA128Mem):
(DecodeMemMMImm4):
(DecodeMemMMSPImm5Lsl2):
(DecodeMemMMGPImm7Lsl2):
(DecodeMemMMReglistImm4Lsl2):
(DecodeMemMMImm12):
(DecodeMemMMImm16):
(DecodeFMem):
(DecodeFMem2):
(DecodeFMem3):
(DecodeFMemCop2R6):
(DecodeSpecial3LlSc):
(DecodeHWRegsRegisterClass):
(DecodeAFGR64RegisterClass):
(DecodeACC64DSPRegisterClass):
(DecodeHI32DSPRegisterClass):
(DecodeLO32DSPRegisterClass):
(DecodeMSA128BRegisterClass):
(DecodeMSA128HRegisterClass):
(DecodeMSA128WRegisterClass):
(DecodeMSA128DRegisterClass):
(DecodeMSACtrlRegisterClass):
(DecodeCOP2RegisterClass):
(DecodeBranchTarget):
(DecodeJumpTarget):
(DecodeBranchTarget21):
(DecodeBranchTarget26):
(DecodeBranchTarget7MM):
(DecodeBranchTarget10MM):
(DecodeBranchTargetMM):
(DecodeJumpTargetMM):
(DecodeAddiur2Simm7):
(DecodeUImm6Lsl2):
(DecodeLiSimm7):
(DecodeSimm4):
(DecodeSimm16):
(DecodeLSAImm):
(DecodeInsSize):
(DecodeExtSize):
(DecodeSimm19Lsl2):
(DecodeSimm18Lsl3):
(DecodeSimm9SP):
(DecodeANDI16Imm):
(DecodeUImm5lsl2):
(DecodeRegListOperand):
(DecodeRegListOperand16):
(DecodeMovePRegPair):
(DecodeSimm23Lsl2):

capstone/Source/arch/Mips/MipsDisassembler.h:
capstone/Source/arch/Mips/MipsGenAsmWriter.inc:
capstone/Source/arch/Mips/MipsGenDisassemblerTables.inc:
capstone/Source/arch/Mips/MipsGenInstrInfo.inc:
capstone/Source/arch/Mips/MipsGenRegisterInfo.inc:
capstone/Source/arch/Mips/MipsInstPrinter.c:

(set_mem_access):
(isReg):
(MipsFCCToString):
(printRegName):
(Mips_printInst):
(printOperand):
(printUnsignedImm):
(printUnsignedImm8):
(printMemOperand):
(printMemOperandEA):
(printFCCOperand):
(printRegisterPair):
(printAlias1):
(printAlias2):
(printAlias):
(printRegisterList):

capstone/Source/arch/Mips/MipsMapping.c:

(Mips_get_insn_id):
(Mips_group_name):
(Mips_map_insn):
(Mips_map_register):

capstone/Source/arch/Mips/MipsMappingInsn.inc:
capstone/Source/arch/Mips/MipsModule.c:

(updated_mode):
(Mips_global_init):
(Mips_option):
(init): Deleted.
(option): Deleted.
(Mips_enable): Deleted.

capstone/Source/arch/Mips/MipsModule.h: Added.
capstone/Source/capstone.pc.in:
capstone/Source/cmake.sh: Added.
capstone/Source/config.mk:
capstone/Source/cs.c:

(cs_version):
(cs_support):
(cs_errno):
(cs_strerror):
(cs_open):
(cs_close):
(fill_insn):
(skipdata_size):
(cs_option):
(skipdata_opstr):
(cs_disasm):
(cs_disasm_ex):
(cs_free):
(cs_malloc):
(cs_disasm_iter):
(cs_reg_name):
(cs_insn_name):
(cs_group_name):
(cs_insn_group):
(cs_reg_read):
(cs_reg_write):
(cs_op_count):
(cs_op_index):
(cs_regs_access):
(cs_kern_os_calloc): Deleted.

capstone/Source/cs_priv.h:
capstone/Source/functions.mk:
capstone/Source/include/capstone/arm.h:
capstone/Source/include/capstone/arm64.h:
capstone/Source/include/capstone/capstone.h:
capstone/Source/include/capstone/evm.h:
capstone/Source/include/capstone/m680x.h:
capstone/Source/include/capstone/m68k.h:
capstone/Source/include/capstone/mips.h:
capstone/Source/include/capstone/mos65xx.h: Added.
capstone/Source/include/capstone/platform.h:
capstone/Source/include/capstone/ppc.h:
capstone/Source/include/capstone/sparc.h:
capstone/Source/include/capstone/systemz.h:
capstone/Source/include/capstone/tms320c64x.h:
capstone/Source/include/capstone/x86.h:
capstone/Source/include/capstone/xcore.h:
capstone/Source/include/platform.h: Copied from Source/ThirdParty/capstone/Source/include/capstone/platform.h.
capstone/Source/include/windowsce/stdint.h:
capstone/Source/make.sh:
capstone/Source/nmake-x86.bat: Removed.
capstone/Source/nmake.bat:
capstone/Source/pkgconfig.mk:
capstone/Source/utils.c:

(make_id2insn):
(insn_find):
(name2id):
(id2name):
(count_positive):
(count_positive8):
(cs_strdup):
(cs_snprintf):
(arr_exist8):
(arr_exist):

capstone/Source/utils.h:
capstone/capstone-Revision.txt:

2:28 AM Changeset in webkit [271082] by mark.lam@apple.com

3 edits
1 add in trunk

VMInspector::dumpRegisters() should not dump beyond the start of the next frame.
https://bugs.webkit.org/show_bug.cgi?id=220136
rdar://64404201

Reviewed by Yusuke Suzuki.

JSTests:

stress/dumpRegisters-should-stop-before-next-frame.js: Added.

Source/JavaScriptCore:

VMInspector::dumpRegisters() was dumping stack slots up for up to
codeBlock->numCalleeLocals() slots for any given CallFrame. This is incorrect.
codeBlock->numCalleeLocals() indicates the maximum number of stack slots that the
codeBlock may use. However, the executing codeBlock may not necessary use up that
number of slots before calling another function.

In the attached test case, the global program has 98 callee locals. However, it
was only using a very small number of stack slots to call $vm.dumpRegisters().
On an ASAN build, iterating thru 98 stack slots of the global program (to dump
their contents) ended up reading beyond the top of the stack, and this made ASAN
very unhappy. The fix is simply to ensure that VMInspector::dumpRegisters() never
dumps past the start of the next CallFrame.

tools/VMInspector.cpp:

(JSC::VMInspector::dumpRegisters):

Dec 23, 2020:

5:01 PM Changeset in webkit [271081] by Simon Fraser

11 edits in trunk/Source/WebCore

Clean up some code related to scroll pinning
https://bugs.webkit.org/show_bug.cgi?id=220128

Reviewed by Sam Weinig.

ScrollAnimatorMac and ScrollingTreeScrollingNodeDelegateMac share a lot of similar code
related to being "pinned" to an edge for scrolling (i.e. already scrolled to an edge).

There are too many functions implementing similar functionality in slightly different
ways. Reduce this count by one by rewriting isAlreadyPinnedInDirectionOfGesture()
and calling it from isPinnedForScrollDelta().

Rename bool pinnedInDirection() to isPinnedForScrollDelta().

Make use of wheelEvent.isGestureStart().

page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::isPinnedForScrollDeltaOnAxis const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::isPinnedForScrollDelta const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::isAlreadyPinnedInDirectionOfGesture const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::pinnedInDirection const): Deleted.

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::isPinnedForScrollDeltaOnAxis const):
(WebCore::ScrollableArea::isPinnedForScrollDelta const):
(WebCore::ScrollableArea::isPinnedInBothDirections const): Deleted.
(WebCore::ScrollableArea::isPinnedHorizontallyInDirection const): Deleted.
(WebCore::ScrollableArea::isPinnedVerticallyInDirection const): Deleted.

platform/ScrollableArea.h:

(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition const): Deleted.
(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition const): Deleted.
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMinimumPosition const): Deleted.
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMaximumPosition const): Deleted.

platform/cocoa/ScrollController.h:
platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::handleWheelEvent):

platform/ios/ScrollAnimatorIOS.mm:

(WebCore::ScrollAnimatorIOS::determineScrollableAreaForTouchSequence):

platform/mac/ScrollAnimatorMac.h:
platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::isPinnedForScrollDelta const):
(WebCore::ScrollAnimatorMac::allowsVerticalStretching const):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching const):
(WebCore::ScrollAnimatorMac::pinnedInDirection const): Deleted.
(WebCore::newGestureIsStarting): Deleted.
(WebCore::ScrollAnimatorMac::isAlreadyPinnedInDirectionOfGesture const): Deleted.

platform/mock/ScrollAnimatorMock.h:

5:00 PM Changeset in webkit [271080] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] Metal backend renders tdl.js samples as red
https://bugs.webkit.org/show_bug.cgi?id=220129

Patch by Kyle Piddington <Kyle Piddington> on 2020-12-23
Reviewed by Kenneth Russell.

src/libANGLE/renderer/metal/FrameBufferMtl.mm:

(rx::FramebufferMtl::blitWithDraw):

1:57 PM Changeset in webkit [271079] by Said Abou-Hallawa

8 edits in trunk/Source

[GPU Process]: Don't call flushDrawingContext() in the middle of recording drawing commands
https://bugs.webkit.org/show_bug.cgi?id=220126

Reviewed by Simon Fraser.

Source/WebCore:

Avoid calling flushDrawingContext() except when the drawing is finished
and the backend of the ImageBuffer is about to be used.

Rename flushDrawingContextAndCommit() to flushDrawingContextAsync(). The
difference between flushDrawingContext() and flushDrawingContextAsync()
is the former waits for the flush reply message.

html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::prepareForDisplay):

platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::flushDrawingContextAsync):
(WebCore::ImageBuffer::flushDrawingContextAndCommit): Deleted.

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawImageBuffer):
(WebCore::DisplayList::Recorder::didAppendItemOfType): Deleted.

platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::Delegate::willAppendItemOfType):
(WebCore::DisplayList::Recorder::append):
(WebCore::DisplayList::Recorder::Delegate::didAppendItemOfType): Deleted.

Source/WebKit:

There is no need to replay back the DrawImageBuffer immediately after it
was recorded. The worry was the source ImageBuffer may change before
replaying back the DrawImageBuffer into the destination ImageBuffer. But
this should not happen with the shared memory buffer because the order
of drawing among multiple ImageBuffer is preserved.

Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::display):

WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

1:27 PM Changeset in webkit [271078] by Peng Liu

14 edits in trunk/Source

[Media in GPU Process][MSE] Clean up SourceBufferPrivateRemote and implement functions with new IPC messages
https://bugs.webkit.org/show_bug.cgi?id=220122

Reviewed by Eric Carlson.

Source/WebCore:

Currently, SourceBuffer needs to get the highestPresentationTimestamp from SourceBufferPrivate, which
is hard to implement synchronously when SourceBufferPrivate runs in a different process (e.g., GPU process).
This patch makes SourceBufferPrivate push highestPresentationTimestamp to SourceBuffer when its value
is changed.

This patch also changes some functions of SourceBufferPrivate to virtual so that we can override them
in SourceBufferPrivateRemote.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::highestPresentationTimestamp const):
(WebCore::SourceBuffer::sourceBufferPrivateHighestPresentationTimestampChanged):

Modules/mediasource/SourceBuffer.h:
platform/graphics/SourceBufferPrivate.cpp:

(WebCore::SourceBufferPrivate::updateHighestPresentationTimestamp):
(WebCore::SourceBufferPrivate::removeCodedFrames):
(WebCore::SourceBufferPrivate::didReceiveSample):
(WebCore::SourceBufferPrivate::highestPresentationTimestamp const): Deleted.

platform/graphics/SourceBufferPrivate.h:

(WebCore::SourceBufferPrivate::setMode):
(WebCore::SourceBufferPrivate::setGroupStartTimestamp):
(WebCore::SourceBufferPrivate::setGroupStartTimestampToEndTimestamp):
(WebCore::SourceBufferPrivate::setShouldGenerateTimestamps):
(WebCore::SourceBufferPrivate::startChangingType):
(WebCore::SourceBufferPrivate::bufferFull const):
(WebCore::SourceBufferPrivate::hasVideo const):
(WebCore::SourceBufferPrivate::timestampOffset const):

platform/graphics/SourceBufferPrivateClient.h:

Source/WebKit:

Add IPC messages and handlers in RemoteSourceBufferProxy to implement the added functions of SourceBufferPrivateRemote.
Also add an IPC message to forward the HighestPresentationTimestampChanged callback from RemoteSourceBufferProxy
to SourceBufferPrivateRemote.

GPUProcess/media/RemoteSourceBufferProxy.cpp:

(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateHighestPresentationTimestampChanged):
(WebKit::RemoteSourceBufferProxy::setMediaSourceEnded):
(WebKit::RemoteSourceBufferProxy::setMode):
(WebKit::RemoteSourceBufferProxy::startChangingType):
(WebKit::RemoteSourceBufferProxy::removeCodedFrames):
(WebKit::RemoteSourceBufferProxy::setAllTrackBuffersNeedRandomAccess):
(WebKit::RemoteSourceBufferProxy::setGroupStartTimestamp):
(WebKit::RemoteSourceBufferProxy::setGroupStartTimestampToEndTimestamp):
(WebKit::RemoteSourceBufferProxy::setShouldGenerateTimestamps):

GPUProcess/media/RemoteSourceBufferProxy.h:
GPUProcess/media/RemoteSourceBufferProxy.messages.in:
Scripts/webkit/messages.py:
WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::setMediaSourceEnded):
(WebKit::SourceBufferPrivateRemote::setMode):
(WebKit::SourceBufferPrivateRemote::removeCodedFrames):
(WebKit::SourceBufferPrivateRemote::setAllTrackBuffersNeedRandomAccess):
(WebKit::SourceBufferPrivateRemote::setGroupStartTimestamp):
(WebKit::SourceBufferPrivateRemote::setGroupStartTimestampToEndTimestamp):
(WebKit::SourceBufferPrivateRemote::setShouldGenerateTimestamps):
(WebKit::SourceBufferPrivateRemote::startChangingType):
(WebKit::SourceBufferPrivateRemote::sourceBufferPrivateHighestPresentationTimestampChanged):

WebProcess/GPU/media/SourceBufferPrivateRemote.h:
WebProcess/GPU/media/SourceBufferPrivateRemote.messages.in:

1:20 PM Changeset in webkit [271077] by Ryan Haddad

3 edits in trunk/LayoutTests

REGRESSION: [ Mac ] media/video-buffering-allowed.html is flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=217621

Unreviewed test gardening.

platform/mac/TestExpectations:
platform/mac/TestExpectationsRosetta:

Move the flaky expectation from Rosetta -> mac since this isn't
Rosetta specific.

12:55 PM Changeset in webkit [271076] by Peng Liu

5 edits in trunk

[Media in GPU Process][MSE] Media element does not fire "resize" event
https://bugs.webkit.org/show_bug.cgi?id=220119

Reviewed by Eric Carlson.

Source/WebKit:

Implement RemoteMediaPlayerProxy::mediaPlayerSizeChanged() to forward the video
resize callback from MSE media player to web process.

No new tests, covered by existing failing layout test.

GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::mediaPlayerSizeChanged):

GPUProcess/media/RemoteMediaPlayerProxy.h:

LayoutTests:

gpu-process/TestExpectations:

12:06 PM Changeset in webkit [271075] by Fujii Hironori

6 edits in trunk

[WinCairo] Enable WebGL 2
https://bugs.webkit.org/show_bug.cgi?id=192314

Reviewed by Kenneth Russell.

Source/cmake/OptionsWin.cmake: Turned ENABLE_WEBGL2 on.

Source/WebCore:

platform/graphics/texmap/ANGLEContext.cpp:

(WebCore::ANGLEContext::createContext): Added context attributes
for WebGL by copying the code of GraphicsContextGLOpenGLCocoa.mm.

LayoutTests:

platform/wincairo/TestExpectations:

11:18 AM Changeset in webkit [271074] by Kate Cheney

6 edits in trunk/Source/WebCore

Can't login to Skype from Microsoft Outlook account in Safari
https://bugs.webkit.org/show_bug.cgi?id=220106
<rdar://problem/72453487>

Reviewed by Alex Christensen.

This is a temporary quirk to assist a high-traffic website while they
complete the large task of migrating away from logins using
third party cookies. This quirk will be removed when the site is
updated.

No new tests, site-specific quirk.

Create a quirk that will call the Storage Access API on behalf of
Microsoft for skype.com under live.com. This patch also refactors
existing quirks to avoid lots of duplicate code.

dom/DocumentStorageAccess.cpp:

(WebCore::DocumentStorageAccess::requestStorageAccessQuirk):

page/Quirks.cpp:

Condense the code which calls the Storage Access API and handles the
click into one function Quirks::requestStorageAccessAndHandleClick.
Call this function if the domain/element pair matches the check in
Quirks::isStorageAccessQuirkDomainElementPair.

(WebCore::isStorageAccessQuirkDomainElementPair):
(WebCore::Quirks::requestStorageAccessAndHandleClick const):
(WebCore::Quirks::mapToTopDomain):
Moved from NetworkStorageSession and adjusted to check the host to
distinguish login.live.com from outlook.live.com which should be
treated differently.

(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
The BBC case can't be included in the same check as other domains with
quirks because we need to create a pop-up and inject JavaScript based
on the user's response. So we still need to check for the BBC domain
separately.

(WebCore::isMicrosoftLoginElement): Deleted.
(WebCore::isMicrosoftDomain): Deleted.
(WebCore::isPlaystationLoginElement): Deleted.

page/Quirks.h:
platform/network/NetworkStorageSession.cpp:

(WebCore::NetworkStorageSession::storageAccessQuirks):
(WebCore::NetworkStorageSession::mapToTopDomain): Moved.

platform/network/NetworkStorageSession.h:

11:13 AM Changeset in webkit [271073] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

[GTK][CMake] Forward missing header on Darwin
https://bugs.webkit.org/show_bug.cgi?id=220114

Patch by Monson Shao <holymonson@gmail.com> on 2020-12-23
Reviewed by Alex Christensen.

Building jsc with GTK port on Darwin needs spi/darwin/ProcessMemoryFootprint.h

wtf/PlatformGTK.cmake:

10:51 AM Changeset in webkit [271072] by Simon Fraser

4 edits
3 adds in trunk

REGRESSION: Scroll snapping triggers body scroll
https://bugs.webkit.org/show_bug.cgi?id=220056
Source/WebCore:

<rdar://problem/72595482>

Reviewed by Wenson Hsieh.

ScrollController::handleWheelEvent() needs to return true to indicate that it
handled the event when it has been processed for scroll snap. If we don't do this,
the latching code thinks that no node handled the event so the latch times out.

Test: fast/scrolling/latching/scroll-snap-latching.html

platform/cocoa/ScrollController.h:
platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::handleWheelEvent):

LayoutTests:

Reviewed by Wenson Hsieh.

fast/scrolling/latching/scroll-snap-latching-expected.txt: Added.
fast/scrolling/latching/scroll-snap-latching.html: Added.
platform/mac-wk1/fast/scrolling/latching/scroll-snap-latching-expected.txt: Added.

10:51 AM Changeset in webkit [271071] by dino@apple.com

2 edits in trunk/Tools

Simulated Python crash during test runs
https://bugs.webkit.org/show_bug.cgi?id=220108
<rdar://problem/72605338>

Reviewed by Geoffrey Garen.

The ResourceLoadStatistics code can unlink a database during the test
run, which causes a simulated python crash. We already worked around this
by setting the SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS environment variable
on a temporary directory, but it needs to include /private/var/folders as well.
However, I didn't have any luck setting multiple directories, so I
used '/' instead.

Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver):

9:00 AM Changeset in webkit [271070] by Simon Fraser

132 edits in trunk

Standardize on "allows scrolling" terminology instead of asking about scrollbars
https://bugs.webkit.org/show_bug.cgi?id=220111

Reviewed by Wenson Hsieh.

Source/WebCore:

Code variously used "canScrollHorizontally" and "hasEnabledHorizontalScrollbar".
Standardize on "allowsHorizontalScrolling". This returns true both when there
is overflow to scroll, and when style allows it (i.e. not overflow-x: hidden).

This changes the name and dumping for ScrollableAreaParams so lots of test results
change.

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry):

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::operator<<):

page/scrolling/ScrollingCoordinatorTypes.h:

(WebCore::ScrollableAreaParameters::operator== const):

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::eventCanScrollContents const):

page/scrolling/ScrollingTreeScrollingNode.h:
page/scrolling/ScrollingTreeScrollingNodeDelegate.h:

(WebCore::ScrollingTreeScrollingNodeDelegate::allowsHorizontalScrolling const):
(WebCore::ScrollingTreeScrollingNodeDelegate::allowsVerticalScrolling const):
(WebCore::ScrollingTreeScrollingNodeDelegate::hasEnabledHorizontalScrollbar const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegate::hasEnabledVerticalScrollbar const): Deleted.

page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalScrolling const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalScrolling const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::canScrollHorizontally const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::canScrollVertically const): Deleted.

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::allowsHorizontalScrolling const):
(WebCore::ScrollableArea::allowsVerticalScrolling const):

platform/ScrollableArea.h:
platform/cocoa/ScrollController.h:
platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::snapRubberBandTimerFired):

platform/mac/ScrollAnimatorMac.h:
platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::allowsHorizontalScrolling const):
(WebCore::ScrollAnimatorMac::allowsVerticalScrolling const):
(WebCore::ScrollAnimatorMac::canScrollHorizontally const): Deleted.
(WebCore::ScrollAnimatorMac::canScrollVertically const): Deleted.

platform/mock/ScrollAnimatorMock.h:

Source/WebKit:

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ScrollableAreaParameters>::encode):
(IPC::ArgumentCoder<ScrollableAreaParameters>::decode):

LayoutTests:

fast/scrolling/ios/change-scrollability-on-content-resize-expected.txt:
fast/scrolling/ios/change-scrollability-on-content-resize-nested-expected.txt:
fast/scrolling/ios/scrollbar-hiding-expected.txt:
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-expected.txt:
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up-expected.txt:
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-nested-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-overflow-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/positioned-nodes-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/sticky-in-overflow-expected.txt:
platform/ipad/fast/scrolling/ios/change-scrollability-on-content-resize-nested-expected.txt:
platform/ipad/scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-nested-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-overflow-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/positioned-nodes-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/remove-coordinated-frame-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/sticky-in-overflow-expected.txt:
platform/wpe/scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt:
scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt:
scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-non-cb-overflow-expected.txt:
scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow-expected.txt:
scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow2-expected.txt:
scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-dynamic-expected.txt:
scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-expected.txt:
scrollingcoordinator/mac/fixed-backgrounds/fixed-background-on-overflow-expected.txt:
scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers-expected.txt:
scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt:
scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-expected.txt:
scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-nested-expected.txt:
scrollingcoordinator/scrolling-tree/composited-in-absolute-in-overflow-expected.txt:
scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt:
scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt:
scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt:
scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt:
scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt:
scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt:
scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt:
scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt:
scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt:
scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt:
scrollingcoordinator/scrolling-tree/positioned-nodes-expected.txt:
scrollingcoordinator/scrolling-tree/remove-coordinated-frame-expected.txt:
scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt:
scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt:
scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt:
scrollingcoordinator/scrolling-tree/sticky-in-overflow-expected.txt:
scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt:
tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt:
tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt:
tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt:
tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt:
tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:
tiled-drawing/scrolling/fixed/four-bars-expected.txt:
tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt:
tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt:
tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt:
tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt:
tiled-drawing/scrolling/fixed/nested-fixed-expected.txt:
tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt:
tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt:
tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt:
tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt:
tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt:
tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt:

8:52 AM Changeset in webkit [271069] by commit-queue@webkit.org

2 edits in trunk

[CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu
https://bugs.webkit.org/show_bug.cgi?id=220082

Patch by Monson Shao <holymonson@gmail.com> on 2020-12-23
Reviewed by Alex Christensen.

In some distros (NixOS) harfbuzz and harfbuzz-icu may have different include dir.

Source/cmake/FindHarfBuzz.cmake:

Dec 22, 2020:

4:12 PM Changeset in webkit [271068] by dino@apple.com

4 edits in trunk/LayoutTests

Update WebGL methods test to ignore makeXRCompatible
https://bugs.webkit.org/show_bug.cgi?id=220107
<rdar://problem/72603916>

Reviewed by Sam Weinig.

Sync upstream changes from
https://github.com/KhronosGroup/WebGL/pull/3198/
so that our versions of these tests can pass with
WebXR enabled.

webgl/1.0.3/resources/webgl_test_files/conformance/context/methods.html:
webgl/2.0.0/resources/webgl_test_files/conformance/context/methods.html:
webgl/2.0.0/resources/webgl_test_files/conformance2/context/methods-2.html:

3:56 PM Changeset in webkit [271067] by ap@apple.com

3 edits
2 moves in trunk/LayoutTests

Remove non-inclusive language from tests in http/tests/xmlhttprequest
https://bugs.webkit.org/show_bug.cgi?id=220096

Patch by Beth Dakin <Beth Dakin> on 2020-12-22
Reviewed by Alexey Proskuryakov.

http/tests/xmlhttprequest/access-control-basic-allow-list-request-headers.html:
http/tests/xmlhttprequest/access-control-basic-allow-list-response-headers.html:
http/tests/xmlhttprequest/resources/access-control-basic-allowlist-request-headers.cgi: Copied from http/tests/xmlhttprequest/resources/access-control-basic-whitelist-request-headers.cgi.
http/tests/xmlhttprequest/resources/access-control-basic-allowlist-response-headers.cgi: Copied from http/tests/xmlhttprequest/resources/access-control-basic-whitelist-response-headers.cgi.
http/tests/xmlhttprequest/resources/access-control-basic-whitelist-request-headers.cgi: Removed.
http/tests/xmlhttprequest/resources/access-control-basic-whitelist-response-headers.cgi: Removed.

3:45 PM Changeset in webkit [271066] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/ANGLE

warning: enumerated and non-enumerated type in conditional expression in Compiler.cpp
https://bugs.webkit.org/show_bug.cgi?id=220062

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-12-22
Reviewed by Dean Jackson.

Building ANGLE with -Wextra is too aggressive. -Wextra is great for code that we control,
where the burden of squashing warnings is relatively low. But with ANGLE, we have to either
land fixes upstream, or carry them downstream forever. It doesn't make sense to bother with
this for minor build warning fixes when upstream is clearly not using the same warning flags
and/or same compiler that we do.

Since we add -Wextra in our global flags, we have to manually override it here. We can now
also stop explicitly disabling other warnings that are implied by -Wextra.

Finally, note that changes.diff is not modified because this is, confusingly, a downstream
WebKit build file.

CMakeLists.txt:

2:37 PM Changeset in webkit [271065] by dino@apple.com

14 edits in trunk/Source

Use an enum class to identify WebGL versions
https://bugs.webkit.org/show_bug.cgi?id=220099
<rdar://problem/72596828>

Reviewed by Ken Russell.

Source/WebCore:

Rather than doing string comparisons multiple times, against
values that have been deprecated, use an enum class to
identify the version of WebGL that we are creating.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::toWebGLVersion):
(WebCore::HTMLCanvasElement::createContextWebGL):
(WebCore::HTMLCanvasElement::getContextWebGL):

html/HTMLCanvasElement.h:
html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):

html/canvas/WebGLRenderingContextBase.h:
platform/graphics/GraphicsContextGLAttributes.h: New enum class.
platform/graphics/RemoteGraphicsContextGLProxyBase.cpp:

(WebCore::RemoteGraphicsContextGLProxyBase::isGLES2Compliant const):

platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::InitializeEGLDisplay): Add a logging statement as a drive-by.
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):

Source/WebKit:

Encode the WebGL version.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<WebCore::GraphicsContextGLAttributes>::encode):
(IPC::ArgumentCoder<WebCore::GraphicsContextGLAttributes>::decode):

Shared/WebCoreArgumentCoders.h:

2:19 PM Changeset in webkit [271064] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Use reserveInitialCapacity when applicable
https://bugs.webkit.org/show_bug.cgi?id=220100
<rdar://problem/72598083>

Reviewed by Simon Fraser.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout): inlineItems size is a better approximation.
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::m_isConsideredEmpty):

layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):

1:18 PM Changeset in webkit [271063] by Beth Dakin

7 edits
1 copy
2 moves in trunk/LayoutTests

Remove non-inclusive language from tests in http/tests/contentextensions/
https://bugs.webkit.org/show_bug.cgi?id=220094

Reviewed by Alex Christensen.

http/tests/contentextensions/allowlist-expected.txt: Copied from http/tests/contentextensions/whitelist-expected.txt.
http/tests/contentextensions/allowlist.html: Copied from http/tests/contentextensions/whitelist.html.
http/tests/contentextensions/allowlist.html.json: Copied from http/tests/contentextensions/whitelist.html.json.
http/tests/contentextensions/basic-filter.html:
http/tests/contentextensions/basic-filter.html.json:
http/tests/contentextensions/crash-xhr.html.json:
http/tests/contentextensions/filters-with-quantifiers-combined-expected.txt:
http/tests/contentextensions/filters-with-quantifiers-combined.html:
http/tests/contentextensions/filters-with-quantifiers-combined.html.json:
http/tests/contentextensions/whitelist-expected.txt: Removed.
http/tests/contentextensions/whitelist.html: Removed.
http/tests/contentextensions/whitelist.html.json: Removed.

12:40 PM Changeset in webkit [271062] by commit-queue@webkit.org

4 edits in trunk/Source/ThirdParty/ANGLE

[WebGL2] deqp/functional/gles3/texturespecification RGB4444 and RGB565 failures on Mac AMD
https://bugs.webkit.org/show_bug.cgi?id=220093

Patch by Kenneth Russell <kbr@chromium.org> on 2020-12-22
Reviewed by Alex Christensen.

Promote the RGBA4444 and RGB565 texture formats to RGB[A]8 in
order to work around OpenGL driver bugs on macOS with AMD GPUs.

include/platform/FeaturesGL.h:
src/libANGLE/renderer/gl/formatutilsgl.cpp:

(rx::nativegl::GetNativeInternalFormat):

src/libANGLE/renderer/gl/renderergl_utils.cpp:

(rx::nativegl_gl::InitializeFeatures):

12:30 PM Changeset in webkit [271061] by commit-queue@webkit.org

5 edits in trunk

Support aspect-ratio on positioned elements
https://bugs.webkit.org/show_bug.cgi?id=219741

Patch by Rob Buis <rbuis@igalia.com> on 2020-12-22
Reviewed by Simon Fraser.

Source/WebCore:

Support aspect-ratio on positioned elements taking into account
insets in the case where no width/height is specified.

rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthUsing const):
(WebCore::RenderBox::computePositionedLogicalHeightUsing const):
(WebCore::RenderBox::shouldComputeLogicalHeightFromAspectRatio const): We should not compute
the logical height if there is an implied height due to top/bottom.
(WebCore::RenderBox::shouldComputeLogicalWidthFromAspectRatio const):
(WebCore::RenderBox::shouldComputeLogicalWidthFromAspectRatioAndInsets const): Helper method
to determine whether logical width can be computed from inset information in the case where
no width/height are specified.
(WebCore::RenderBox::computeLogicalWidthFromAspectRatio const): compute logical width
from the computed logical height constriaining it by min max.

rendering/RenderBox.h:

LayoutTests:

Enable some tests that pass now.

TestExpectations:

12:00 PM Changeset in webkit [271060] by youenn@apple.com

7 edits
2 adds in trunk

MediaStreamTrack.muted value should not change before the corresponding event is fired
https://bugs.webkit.org/show_bug.cgi?id=220084

Reviewed by Eric Carlson.

Source/WebCore:

Before the patch, the muted value was changed and a task was queued to dispatch the corresponding event.
During a period of time, the muted value was changed while the event was not fired.
To fix this, dispatch a task that will change the value and dispatch the event.
MediaStreamTrack is now storing the muted value instead of relying on its m_private muted value.
The muted value is only used for JS as the rest of the code base expects to get the actual muted value.

Test: fast/mediastream/media-stream-track-muted-event.html

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::mutedForBindings const):
(WebCore::MediaStreamTrack::trackMutedChanged):

Modules/mediastream/MediaStreamTrack.h:
Modules/mediastream/MediaStreamTrack.idl:

LayoutTests:

fast/mediastream/media-stream-track-muted-event-expected.txt: Added.
fast/mediastream/media-stream-track-muted-event.html: Added.
platform/ios/mediastream/audio-muted-in-background-tab.html: Updated to cope with async muted change.
platform/ios/mediastream/video-muted-in-background-tab.html: Dittod

11:45 AM Changeset in webkit [271059] by Kate Cheney

11 edits in trunk/Source

Cannot see 'Add to my stations' button in BBC World service Radio
https://bugs.webkit.org/show_bug.cgi?id=219949
<rdar://problem/60319532>

Reviewed by Alex Christensen.

This is a temporary quirk to assist a high-traffic website while they
complete the large task of migrating away from site compatibility using
third party cookies. This quirk will be removed when the site is
updated.

Source/WebCore:

No new tests, site-specific quirk.

Create a quirk that will call the Storage Access API on behalf of
BBC for radioplayer.co.uk under bbc.co.uk. When the user clicks to open
the radio player pop-up, storage access is requested. If the user grants
permission, then we open the pop-up to static.radioplayer.co.uk to get
first party status, then immediately redirect to the radio player page.

This changes the language of the site-specific quirk code in
NetworkStorageSession now that we are creating quirks for instances
other than login cases.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

page/DOMWindow.cpp:

(WebCore::DOMWindow::open):
Even if WebKit cancels the pop-up click in Element::dispatchMouseEvent,
the popup still appears. So we should check here if the pop-up is trying
to load before storage access has been granted. If so, we should cancel it
and wait for the quirk to re-open the pop-up after prompting the user.
Also adds a null frame check.

page/Quirks.cpp:

(WebCore::isBBCDomain):
(WebCore::isBBCPopOutPlayerElement):
(WebCore::Quirks::BBCRadioPlayerURLString):
(WebCore::Quirks::staticRadioPlayerURLString):
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):

page/Quirks.h:

This is where we check if the pop-up button has been clicked and
prompt for storage access if needed. If the user grants storage
access, we should open a popup to static.radioplayer.co.uk so it
gets marked as first party, then inject script to redirect to the
correct BBC radio player page.

platform/network/NetworkStorageSession.cpp:

(WebCore::NetworkStorageSession::storageAccessQuirks):
(WebCore::NetworkStorageSession::loginDomainMatchesRequestingDomain):
(WebCore::NetworkStorageSession::canRequestStorageAccessForLoginOrCompatibilityPurposesWithoutPriorUserInteraction):
(WebCore::NetworkStorageSession::subDomainInNeedOfStorageAccessForFirstParty):
(WebCore::NetworkStorageSession::canRequestStorageAccessForLoginPurposesWithoutPriorUserInteraction): Deleted.
(WebCore::NetworkStorageSession::loginDomainForFirstParty): Deleted.

platform/network/NetworkStorageSession.h:

Change wording now that quirks are not only being used for login
flows.

Source/WebKit:

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccessInternal):
(WebKit::ResourceLoadStatisticsDatabaseStore::cookieAccess):

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessEphemeral):
Change wording now that quirks are not only being used for login
flows.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):
Mark the quirk-initiated pop-up as user-initiated so it doesn't get
blocked.

11:02 AM Changeset in webkit [271058] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Add fast path for the most common "inline level box is the child of the root inline box" case
https://bugs.webkit.org/show_bug.cgi?id=220089
<rdar://problem/72590141>

Reviewed by Simon Fraser.

layout/inlineformatting/InlineFormattingState.h:

(WebCore::Layout::InlineFormattingState::addLineRun):

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::logicalMarginRectForInlineLevelBox const):

layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::inlineLevelBoxList const):
(WebCore::Layout::LineBox::containsInlineLevelBox const): Deleted.

10:40 AM Changeset in webkit [271057] by Ryan Haddad

14 edits in trunk

Unreviewed, fix the build with recent SDKs.

Source/WebCore:

platform/cocoa/DragImageCocoa.mm:

(WebCore::createDragImageIconForCachedImageFilename):

platform/graphics/mac/IconMac.mm:

(WebCore::Icon::createIconForFileExtension):
(WebCore::Icon::createIconForUTI):

platform/mac/LocalDefaultSystemAppearance.mm:

(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):
(WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance):

platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollerImpDelegate effectiveAppearanceForScrollerImp:]):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint const):

platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paintScrollCorner):

platform/mac/ThemeMac.mm:

(WebCore::paintStepper):
(WebCore::ThemeMac::ensuredView):
(WebCore::ThemeMac::supportsLargeFormControls):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::createAttachmentPlaceholderImage):

Source/WebKit:

UIProcess/PDF/WKPDFHUDView.mm:

(-[WKPDFHUDView _getImageForControlName:]):

UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:

(-[WKScrollerImpDelegate effectiveAppearanceForScrollerImp:]):

Tools:

MiniBrowser/mac/ExtensionManagerWindowController.m:

(-[ExtensionManagerWindowController add:]):

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
(-[WK2BrowserWindowController saveAsPDF:]):
(-[WK2BrowserWindowController saveAsWebArchive:]):

10:28 AM Changeset in webkit [271056] by commit-queue@webkit.org

5 edits in trunk

REGRESSION(r270612) [GStreamer][MSE] Some play/seek related failures
https://bugs.webkit.org/show_bug.cgi?id=219822

Patch by Philippe Normand <pnormand@igalia.com> on 2020-12-22
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Call appendComplete which internally synchronizes the TrackBuffer buffered ranges and calls
m_client->sourceBufferPrivateAppendComplete().

platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::didReceiveAllPendingSamples):
(WebCore::SourceBufferPrivateGStreamer::appendParsingFailed):

LayoutTests:

Unflag tests now-passing and flag tests that were mis-gardened before this regression happened.

platform/glib/TestExpectations:
platform/gtk/TestExpectations:

10:11 AM Changeset in webkit [271055] by Antti Koivisto

10 edits in trunk/Source/WebCore

[LFC][Integration] Invalidate line layout path for children of inlines
https://bugs.webkit.org/show_bug.cgi?id=219639

Reviewed by Zalan Bujtas.

We currently assume you can just invalidate the direct parent.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::blockContainer):
(WebCore::LayoutIntegration::LineLayout::containing):

layout/integration/LayoutIntegrationLineLayout.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::insertedIntoTree):
(WebCore::RenderObject::willBeRemovedFromTree):

Invalidate here.

rendering/RenderText.cpp:

(WebCore::RenderText::setText):

rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::attachToRenderElementInternal):

rendering/updating/RenderTreeBuilderBlock.cpp:

(WebCore::RenderTreeBuilder::Block::attachIgnoringContinuation):
(WebCore::RenderTreeBuilder::Block::detach):

8:48 AM Changeset in webkit [271054] by Simon Fraser

3 edits
2 adds in trunk

Sibling element wheel event regions can be wrong
https://bugs.webkit.org/show_bug.cgi?id=220071
Source/WebCore:

<rdar://problem/72435466>

Reviewed by Daniel Bates.

RenderStyle contains eventListenerRegionTypes() data which derive from registered
wheel event handlers, so style sharing needs to avoid sharing style between elements
with different handlers. For now, just disable style sharing for any elements
which event handlers.

Test: fast/scrolling/mac/wheel-event-listener-region-siblings.html

style/StyleSharingResolver.cpp:

(WebCore::Style::SharingResolver::canShareStyleWithElement const):

LayoutTests:

Reviewed by Daniel Bates.

fast/scrolling/mac/wheel-event-listener-region-siblings-expected.txt: Added.
fast/scrolling/mac/wheel-event-listener-region-siblings.html: Added.

8:09 AM Changeset in webkit [271053] by Simon Fraser

3 edits
2 adds in trunk

Layout overflow is computed incorrectly inside flexbox (breaks sticky positioning)
https://bugs.webkit.org/show_bug.cgi?id=220075
Source/WebCore:

<rdar://problem/70956639>

Reviewed by Zalan Bujtas.

RenderBlock::endAndCommitUpdateScrollInfoAfterLayoutTransaction(), which is only called by grid
and flexbox layout, would unconditionally clear layout overflow on boxes with overflow clipping,
which resulted in incorrect sticky positioning because RenderBoxModelObject::computeStickyPositionConstraints()
consults layout overflow.

It was only through happenstance that overflow:scroll worked correctly, relying on the fact
that updateScrollInfoAfterLayout() would trigger caching of scroll dimensions on RenderLayer.

This clearing was added in r151360 but seems incorrect; layout overflow should be preserved
after layout.

Test: fast/flexbox/preserve-layout-overflow.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::endAndCommitUpdateScrollInfoAfterLayoutTransaction):

LayoutTests:

Reviewed by Zalan Bujtas.

fast/flexbox/preserve-layout-overflow-expected.txt: Added.
fast/flexbox/preserve-layout-overflow.html: Added.

6:33 AM Changeset in webkit [271052] by Alan Bujtas

7 edits in trunk/Source/WebCore

[LFC][Integration] Compute enclosing top and bottom while constructing the inline runs
https://bugs.webkit.org/show_bug.cgi?id=220064
<rdar://problem/72556810>

Reviewed by Antti Koivisto.

Let's pre-compute the enclosing top and bottom coordinates while constructing the line runs.
(This saves a loop on the inline level boxes while constructing the lines at InlineContentBuilder::createDisplayLines)

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

layout/inlineformatting/InlineLineGeometry.h:

(WebCore::Layout::InlineLineGeometry::enclosingTopAndBottom const):
(WebCore::Layout::InlineLineGeometry::InlineLineGeometry):

layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):

layout/integration/LayoutIntegrationLine.h:

(WebCore::LayoutIntegration::Line::Line):
(WebCore::LayoutIntegration::Line::enclosingContentTop const):
(WebCore::LayoutIntegration::Line::enclosingContentBottom const):

layout/integration/LayoutIntegrationPagination.cpp:

(WebCore::LayoutIntegration::makeAdjustedContent):

4:42 AM Changeset in webkit [271051] by commit-queue@webkit.org

11 edits in trunk/LayoutTests/imported/w3c

Add test for logical properties in webkit non-standard '-webkit-writing-mode: horizontal-bt' mode
https://bugs.webkit.org/show_bug.cgi?id=220015

Patch by Ziran Sun <Ziran Sun> on 2020-12-22
Reviewed by Manuel Rego Casasnovas.

web-platform-tests/css/css-logical/logical-box-border-color-expected.txt:
web-platform-tests/css/css-logical/logical-box-border-radius-expected.txt:
web-platform-tests/css/css-logical/logical-box-border-shorthands-expected.txt:
web-platform-tests/css/css-logical/logical-box-border-style-expected.txt:
web-platform-tests/css/css-logical/logical-box-border-width-expected.txt:
web-platform-tests/css/css-logical/logical-box-inset-expected.txt:
web-platform-tests/css/css-logical/logical-box-margin-expected.txt:
web-platform-tests/css/css-logical/logical-box-padding-expected.txt:
web-platform-tests/css/css-logical/logical-box-size-expected.txt:
web-platform-tests/css/css-logical/resources/test-shared.js:

(CSS.supports):

4:22 AM Changeset in webkit [271050] by Lauro Moura

4 edits in trunk/Tools

[Flapak SDK] Allow setting custom SDK repository locations and other small fixes
https://bugs.webkit.org/show_bug.cgi?id=219884

Reviewed by Philippe Normand.

Tools:

Update envvar to match the WEBKIT_FLATPAK prefix
Give precedence to the verbose flag instead of envvar
Enable logging earlier to be used in the parse step
Error out if the user provides an user repo that is not accessible.

flatpak/flatpakutils.py:

(WebkitFlatpak.load_from_args):
(WebkitFlatpak.clean_args):

Tools/buildstream:

Allow inheriting the RSYNC info from envvar for local testing.
Add a 'dry-push-repo' command to be able to perform push-repo dry-runs.

Makefile:

2:11 AM Changeset in webkit [271049] by youenn@apple.com

10 edits in trunk/Source

[iOS] Do extensive search for microphone devices when trying to capture
https://bugs.webkit.org/show_bug.cgi?id=220010
<rdar://problem/72036034>

Reviewed by Eric Carlson.

Source/WebCore:

It is not possible to discover some audio input devices without an active audio
session, so WebKit allocates an auxiliary audio session when it needs to build
a list of audio capture devices. The full list of devices is only needed when
evaluating getUserMedia audio constraints, or for enumerateDevices *after* capture
is active (we return a truncated list before capture is active), so don't activate
the session until we need to validate audio constraints or after the user gives
permission to capture.

Manually tested on device with built-in, BT, and USB audio inputs.

platform/mediastream/RealtimeMediaSourceFactory.h:

(WebCore::AudioCaptureFactory::addExtensiveObserver):
(WebCore::AudioCaptureFactory::removeExtensiveObserver):

platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:
platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:

(WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices):
(WebCore::AVAudioSessionCaptureDeviceManager::enableAllDevicesQuery):
(WebCore::AVAudioSessionCaptureDeviceManager::disableAllDevicesQuery):

platform/mediastream/ios/CoreAudioCaptureSourceIOS.h:
platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:

(WebCore::CoreAudioCaptureSourceFactoryIOS::addExtensiveObserver):
(WebCore::CoreAudioCaptureSourceFactoryIOS::removeExtensiveObserver):
(WebCore::CoreAudioCaptureSourceFactoryIOS::createAudioCaptureSource):
In UIProcess, UserMediaPermissionRequestManagerProxy makes sure to enable the extensive audio device query.
In WebProcess, we also need this when starting the audio capture.
We enable it when there is no observer to handle the WebProcess side.

platform/mediastream/mac/CoreAudioCaptureSource.h:

(WebCore::CoreAudioCaptureSourceFactory::createAudioCaptureSource):

Source/WebKit:

Enable exhaustive audio device query in case getUserMedia is called for audio capture.
In case the manager is destroyed or reset after some time without capturing, make sure to disable
exhaustive audio device query if no other page need it.

UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::invalidatePendingRequests):
(WebKit::UserMediaPermissionRequestManagerProxy::denyRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::resetAccess):
(WebKit::UserMediaPermissionRequestManagerProxy::startProcessingUserMediaPermissionRequest):

UIProcess/UserMediaPermissionRequestManagerProxy.h:

Dec 21, 2020:

9:20 PM Changeset in webkit [271048] by Beth Dakin

8 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=220078
Remove non-inclusive language from WebGL tests

Reviewed by Alex Christensen.

webgl/1.0.3/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html:
webgl/1.0.3/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html:
webgl/2.0.0/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html:
webgl/2.0.0/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html:
webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/element-index-uint.html:
webgl/2.0.0/resources/webgl_test_files/conformance2/vertex_arrays/vertex-array-object.html:
webgl/2.0.0/resources/webgl_test_files/js/tests/no-over-optimizations-on-uniform-array.js:

(setupTests):

7:23 PM Changeset in webkit [271047] by Simon Fraser

2 edits in trunk/Tools

[macOS MiniBrowser] Add menu items to reset all experimental and internal debug features to defaults
https://bugs.webkit.org/show_bug.cgi?id=220060

Reviewed by Wenson Hsieh.

Add menu items at the bottom of the "Experimental" and "Internal Debug" feature submenus
to reset all the features to their default values.

MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController resetAllExperimentalFeatures:]):
(-[SettingsController resetAllInternalDebugFeatures:]):

5:04 PM Changeset in webkit [271046] by Alan Coon

1 copy in tags/Safari-610.4.3

Tag Safari-610.4.3.

4:57 PM Changeset in webkit [271045] by Wenson Hsieh

2 edits in trunk/Source/WebKit

REGRESSION (iOS 14): Bad access crash in ShareableBitmap::makeCGImageCopy() under assignLegacyDataForContextMenuInteraction()
https://bugs.webkit.org/show_bug.cgi?id=219843
<rdar://problem/72537059>

Reviewed by Geoffrey Garen.

Apply a speculative fix for the crash by making the UI process robust in the case where the requested position
information has the isImage flag set, but no native image. Additionally, keep the existing debug assertions by
moving them outside of their current if statements.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView assignLegacyDataForContextMenuInteraction]):
(-[WKContentView continueContextMenuInteraction:]):

4:25 PM Changeset in webkit [271044] by ysuzuki@apple.com

2 edits in trunk/JSTests

[JSC] Update elem.wast.js test
https://bugs.webkit.org/show_bug.cgi?id=220011

Reviewed by Ross Kirsling.

Now all tests pass. Remove FIXME.

wasm/spec-tests/elem.wast.js:

3:50 PM Changeset in webkit [271043] by Beth Dakin

49 edits
11 moves
2 adds
2 deletes in trunk/LayoutTests

Remove non-inclusive language from layout tests
https://bugs.webkit.org/show_bug.cgi?id=220063

Reviewed by Geoffrey Garen.

This patch removes many instances of non-inclusive language from the layout tests.

fast/canvas/webgl/oes-element-index-uint.html:
fast/canvas/webgl/oes-vertex-array-object.html:
fast/encoding/idn-security.html:
fast/images/image-formats-support-expected.txt:
fast/images/image-formats-support.html:
fast/text/arabic-blacklisted-expected.html: Removed.
fast/text/arabic-blacklisted.html: Removed.
fast/text/arabic-blocked-fonts-expected.html: Copied from fast/text/arabic-blacklisted-expected.html.
fast/text/arabic-blocked-fonts.html: Copied from fast/text/arabic-blacklisted.html.
http/tests/appcache/online-whitelist-expected.txt:
http/tests/appcache/online-whitelist.html:
http/tests/appcache/resources/allowlist-wildcard.manifest: Copied from http/tests/appcache/resources/whitelist-wildcard.manifest.
http/tests/appcache/resources/online-allowlist.manifest: Copied from http/tests/appcache/resources/online-whitelist.manifest.
http/tests/appcache/resources/online-allowlist.php: Copied from http/tests/appcache/resources/online-whitelist.php.
http/tests/appcache/resources/online-whitelist.manifest: Removed.
http/tests/appcache/resources/online-whitelist.php: Removed.
http/tests/appcache/resources/whitelist-wildcard.manifest: Removed.
http/tests/appcache/whitelist-wildcard-expected.txt:
http/tests/appcache/whitelist-wildcard.html:
http/tests/misc/char-encoding-bocu-1-blacklisted-expected.txt: Removed.
http/tests/misc/char-encoding-bocu-1-blacklisted.html: Removed.
http/tests/misc/char-encoding-bocu-1-blocklisted-expected.txt: Added.
http/tests/misc/char-encoding-bocu-1-blocklisted.html: Copied from http/tests/misc/char-encoding-bocu-1-blacklisted.html.
http/tests/misc/char-encoding-scsu-blacklisted-expected.txt: Removed.
http/tests/misc/char-encoding-scsu-blacklisted.html: Removed.
http/tests/misc/char-encoding-scsu-blocklisted-expected.txt: Added.
http/tests/misc/char-encoding-scsu-blocklisted.html: Copied from http/tests/misc/char-encoding-scsu-blacklisted.html.
http/tests/security/contentSecurityPolicy/1.1/stylenonce-allowed-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/stylenonce-allowed.html:
http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01-expected.txt:
http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html:
http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02-expected.txt:
http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html:
http/tests/security/cross-frame-access-enumeration-expected.txt:
http/tests/security/cross-frame-access-enumeration.html:
http/tests/security/isolatedWorld/cross-origin-xhr-expected.txt:
http/tests/security/isolatedWorld/cross-origin-xhr.html:
http/tests/security/local-image-from-remote-allow-list-expected.txt:
http/tests/security/local-image-from-remote-allow-list.html:
http/tests/xmlhttprequest/access-control-basic-allow-list-response-headers-expected.txt:
http/tests/xmlhttprequest/access-control-basic-allow-list-response-headers.html:
http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple.html:
http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html:
http/tests/xmlhttprequest/origin-allow-list-all-expected.txt:
http/tests/xmlhttprequest/origin-allow-list-all.html:
http/tests/xmlhttprequest/origin-allow-list-exact-match-expected.txt:
http/tests/xmlhttprequest/origin-allow-list-exact-match.html:
http/tests/xmlhttprequest/origin-allow-list-https-expected.txt:
http/tests/xmlhttprequest/origin-allow-list-https.html:
http/tests/xmlhttprequest/origin-allow-list-ip-addresses-expected.txt:
http/tests/xmlhttprequest/origin-allow-list-ip-addresses-with-subdomains.html:
http/tests/xmlhttprequest/origin-allow-list-ip-addresses.html:
http/tests/xmlhttprequest/origin-allow-list-removal-expected.txt:
http/tests/xmlhttprequest/origin-allow-list-removal.html:
http/tests/xmlhttprequest/origin-allow-list-subdomains-expected.txt:
http/tests/xmlhttprequest/origin-allow-list-subdomains.html:
http/tests/xmlhttprequest/resources/origin-allowlisting-ip-address-test.html: Copied from http/tests/xmlhttprequest/resources/origin-whitelisting-ip-address-test.html.
http/tests/xmlhttprequest/resources/origin-whitelisting-ip-address-test.html: Removed.
http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple.js:

(start):

inspector/timeline/line-column.html:
js/promises-tests/resources/mocha.js:
media/track/captions-webvtt/allowlist.vtt: Copied from media/track/captions-webvtt/whitelist.vtt.
media/track/captions-webvtt/whitelist.vtt: Removed.
media/track/track-css-property-allowlist-expected.txt: Added.
media/track/track-css-property-allowlist.html: Copied from media/track/track-css-property-whitelist.html.
media/track/track-css-property-whitelist-expected.txt: Removed.
media/track/track-css-property-whitelist.html: Removed.
platform/glib/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:
platform/wpe/security/block-test-expected.txt:
security/block-test-expected.txt:
security/block-test.html:

3:05 PM Changeset in webkit [271042] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][Integration] Reserve both the line and the run vector sizes
https://bugs.webkit.org/show_bug.cgi?id=220068
<rdar://problem/72560573>

Reviewed by Simon Fraser.

We actually know how many entries these vectors will have (in case of no-bidi content).

layout/integration/LayoutIntegrationInlineContent.h:
layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):

2:31 PM Changeset in webkit [271041] by Chris Dumez

14 edits in trunk/Source

Simplify CARingBuffer usage with SharedMemory storage
https://bugs.webkit.org/show_bug.cgi?id=220047

Reviewed by Geoff Garen.

Simplify CARingBuffer usage with SharedMemory storage:

There are now 2 storage types:
- ReadOnlySharedRingBufferStorage: Used by the reader
- SharedRingBufferStorage: Used by the writer One type inherits the other. This allows the API to be a bit clearer and we can drop the m_readyOnly flag.
Drop SharedRingBufferStorage::updateReadOnlyStorage() function. Instead, the reader can now construct a new ReadOnlySharedRingBufferStorage directly of the SharedMemory handle and pass it to the CARingBuffer constructor.

Source/WebCore:

platform/audio/cocoa/CARingBuffer.cpp:

(WebCore::CARingBuffer::CARingBuffer):

platform/audio/cocoa/CARingBuffer.h:

Source/WebKit:

GPUProcess/media/RemoteAudioDestinationManager.cpp:

(WebKit::RemoteAudioDestination::audioSamplesStorageChanged):
(WebKit::RemoteAudioDestination::RemoteAudioDestination):

GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:

(WebKit::RemoteAudioMediaStreamTrackRenderer::RemoteAudioMediaStreamTrackRenderer):
(WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged):

GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
GPUProcess/webrtc/RemoteMediaRecorder.cpp:

(WebKit::RemoteMediaRecorder::RemoteMediaRecorder):
(WebKit::RemoteMediaRecorder::audioSamplesStorageChanged):

GPUProcess/webrtc/RemoteMediaRecorder.h:
Shared/Cocoa/SharedRingBufferStorage.cpp:

(WebKit::ReadOnlySharedRingBufferStorage::ReadOnlySharedRingBufferStorage):
(WebKit::ReadOnlySharedRingBufferStorage::data):
(WebKit::ReadOnlySharedRingBufferStorage::sharedFrameBounds const):
(WebKit::ReadOnlySharedRingBufferStorage::getCurrentFrameBounds):
(WebKit::ReadOnlySharedRingBufferStorage::flush):
(WebKit::ReadOnlySharedRingBufferStorage::updateFrameBounds):
(WebKit::SharedRingBufferStorage::setStorage):
(WebKit::SharedRingBufferStorage::allocate):
(WebKit::SharedRingBufferStorage::deallocate):
(WebKit::SharedRingBufferStorage::setCurrentFrameBounds):

Shared/Cocoa/SharedRingBufferStorage.h:

(WebKit::ReadOnlySharedRingBufferStorage::storage const):

UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:

(WebKit::m_ringBuffer):
(WebKit::SpeechRecognitionRemoteRealtimeMediaSource::setStorage):

WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp:

(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::RemoteAudio):
(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::setStorage):

WebProcess/cocoa/RemoteCaptureSampleManager.cpp:

(WebKit::RemoteCaptureSampleManager::RemoteAudio::RemoteAudio):
(WebKit::RemoteCaptureSampleManager::RemoteAudio::setStorage):

1:59 PM Changeset in webkit [271040] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Retain IPC::Connection when using it when making a NetworkDataTask
https://bugs.webkit.org/show_bug.cgi?id=220067

Patch by Alex Christensen <achristensen@webkit.org> on 2020-12-21
Reviewed by Geoffrey Garen.

r265230 helped, but it's still crashing.
Maybe we're getting a non-null pointer to an object that is about to be destroyed on another thread.
There's no reason not to keep it alive here.
Also, don't release assert in isParentProcessAFullWebBrowser if there's no audit token so we don't
just kick this can down the road.

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::sessionWrapperForTask):

1:31 PM Changeset in webkit [271039] by commit-queue@webkit.org

10 edits in trunk

Source/JavaScriptCore:
[JSC] Add minimum parameter to the WASM JS-API for Memory & Table.
https://bugs.webkit.org/show_bug.cgi?id=219600

Patch by Jessica Tallon <jtallon@igalia.com> on 2020-12-21
Reviewed by Yusuke Suzuki.

This patch adds a "minimum" perameter to the constructor of both WebAssembly.Memory and
WebAssembly.Table. This represents the same value as the "initial" perameter. The new
perameter name is outlined here [1]. It is part of the JS type reflection proposal.

[1]: https://github.com/WebAssembly/js-types/blob/master/proposals/js-types/Overview.md#naming-of-size-limits

JSTests/wasm/js-api/table.js:
JSTests/wasm/js-api/test_memory_constructor.js:
Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.cpp:
Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp:

LayoutTests:
[JSC] Fix expectation for WASM JS-type reflection WPTs
https://bugs.webkit.org/show_bug.cgi?id=219600

Patch by Jessica Tallon <jtallon@igalia.com> on 2020-12-21
Reviewed by Yusuke Suzuki.

Changed the expectations for the WASM JS-Type reflections constructor
tests as we now support the minimum parameter.

LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/constructor-types.tentative.any-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor-types.tentative.any-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/constructor-types.tentative.any.worker-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor-types.tentative.any.worker-expected.txt:

12:48 PM Changeset in webkit [271038] by Ryan Haddad

9 edits in trunk/Source

Unreviewed, reverting r270939 and r270952.

Caused layout test timeouts on internal bots

Reverted changesets:

"[Cocoa] WebM format reader doesn't work with a url in a
<source> element"
https://bugs.webkit.org/show_bug.cgi?id=219961
https://trac.webkit.org/changeset/270939

"[Cocoa] WebM format reader doesn't work with a url in a
<source> element"
https://bugs.webkit.org/show_bug.cgi?id=219961
https://trac.webkit.org/changeset/270952

12:46 PM Changeset in webkit [271037] by commit-queue@webkit.org

9 edits in trunk

$(findstring iphone,$(SDKROOT)) fails when SDKROOT is not lowercase
https://bugs.webkit.org/show_bug.cgi?id=219993
rdar://72436093

Patch by Ryan Hostetler <rhost@apple.com> on 2020-12-21
Reviewed by Darin Adler.

Update SDKROOT evaluation to be lowercase and SDK filename only.

Source/Makefile:

Source/ThirdParty:

Makefile:

Source/ThirdParty/libwebrtc:

Makefile:

Tools:

ImageDiff/Makefile:
Makefile:

12:17 PM Changeset in webkit [271036] by Wenson Hsieh

10 edits in trunk/Source

Many websites crash under toDataURL() when enabling GPU process for DOM
https://bugs.webkit.org/show_bug.cgi?id=220051
<rdar://problem/72412509>

Reviewed by Simon Fraser.

Source/WebCore:

See WebKit ChangeLog for more details.

platform/graphics/ImageBufferBackend.h:

Add traits for the PreserveResolution enum flag, so that it can be encoded over IPC.

Source/WebKit:

Three methods of canvas readback (toDataURL, toData, and toBGRAData) currently cause the web content
process to crash when enabling GPU process for DOM rendering. This is because we attempt to call into the
respective methods on the image buffer backend following r270342, which unconditionally fire release assertions.

Instead of using the proxy image buffer backend object in the web process, we need to communicate with the
platform RemoteImageBuffer in the GPU process. To do this, we add some plumbing through
RemoteRenderingBackendProxy and RemoteRenderingBackend, and override the toDataURL, toData, and
toBGRAData methods on RemoteImageBufferProxy in the web process to request data from the remote rendering
backend instead.

GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::getDataURLForImageBuffer):
(WebKit::RemoteRenderingBackend::getDataForImageBuffer):
(WebKit::RemoteRenderingBackend::getBGRADataForImageBuffer):

GPUProcess/graphics/RemoteRenderingBackend.h:
GPUProcess/graphics/RemoteRenderingBackend.messages.in:
Scripts/webkit/messages.py:
WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::getImageData):
(WebKit::RemoteRenderingBackendProxy::getDataURLForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::getDataForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::getBGRADataForImageBuffer):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:

11:56 AM Changeset in webkit [271035] by Russell Epstein

1 copy in tags/Safari-611.1.9.3.1

Tag Safari-611.1.9.3.1.

11:54 AM Changeset in webkit [271034] by keith_miller@apple.com

4 edits in trunk/Source/JavaScriptCore

DFG should make sure replacement watchpoint is fired before folding to PutByOffset
https://bugs.webkit.org/show_bug.cgi?id=220031
<rdar://72045350>

Reviewed by Saam Barati.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::presenceConditionIfConsistent):
(JSC::DFG::ByteCodeParser::checkPresence):
(JSC::DFG::ByteCodeParser::checkPresenceForReplace):
(JSC::DFG::ByteCodeParser::load):
(JSC::DFG::ByteCodeParser::store):
(JSC::DFG::ByteCodeParser::presenceLike): Deleted.
(JSC::DFG::ByteCodeParser::checkPresenceLike): Deleted.

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::tryFoldAsPutByOffset):

runtime/Structure.cpp:

(JSC::Structure::dump const):

11:44 AM Changeset in webkit [271033] by Russell Epstein

8 edits in branches/safari-611.1.9-branch/Source

Versioning.

WebKit-7611.1.9.3.1

11:38 AM Changeset in webkit [271032] by Kate Cheney

2 edits in trunk/Source/WebKit

Missing textInteractionEnabled key in WKPreferences initWithCoder looks like a false value.
https://bugs.webkit.org/show_bug.cgi?id=220061
<rdar://problem/72487342>

Reviewed by Wenson Hsieh.

We should check for the existence of the textInteractionEnabled key
in the NSCoder before updating the default value in WKPreferences,
otherwise a missing key will register as a false value when the default
of textInteractionEnabled should be true.

UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences initWithCoder:]):

11:35 AM Changeset in webkit [271031] by sihui_liu@apple.com

11 edits in trunk/Source/WebKit

Check availability of speech recognition service before requesting permissions
https://bugs.webkit.org/show_bug.cgi?id=220033

Reviewed by Youenn Fablet.

If speech recognition service is not available for target language (maybe the language is not supported, user
turns off dictation in system settings, etc), let's just fail the speech recognition request without prompting.

Manually tested with MiniBrowser.

UIProcess/Cocoa/MediaPermissionUtilities.mm:

(WebKit::requestSpeechRecognitionAccess):
(WebKit::checkSpeechRecognitionServiceAccess):
(WebKit::checkSpeechRecognitionServiceAvailability):

UIProcess/MediaPermissionUtilities.h:
UIProcess/SpeechRecognitionPermissionManager.cpp:

(WebKit::SpeechRecognitionPermissionManager::request):
(WebKit::SpeechRecognitionPermissionManager::startProcessingRequest):

UIProcess/SpeechRecognitionPermissionManager.h:
UIProcess/SpeechRecognitionPermissionRequest.h:

(WebKit::SpeechRecognitionPermissionRequest::create):
(WebKit::SpeechRecognitionPermissionRequest::lang const):
(WebKit::SpeechRecognitionPermissionRequest::SpeechRecognitionPermissionRequest):

UIProcess/SpeechRecognitionServer.cpp:

(WebKit::SpeechRecognitionServer::requestPermissionForRequest):

UIProcess/SpeechRecognitionServer.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestSpeechRecognitionPermission):

UIProcess/WebPageProxy.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createSpeechRecognitionServer):

11:24 AM Changeset in webkit [271030] by mark.lam@apple.com

5 edits in branches/safari-610-branch

Cherry-pick r270981. rdar://problem/72552976

2020-12-17 Mark Lam <mark.lam@apple.com>

Add tagging to JIT probe's return address.
https://bugs.webkit.org/show_bug.cgi?id=220008
rdar://71279530

Reviewed by Keith Miller and Robin Morisset.

assembler/MacroAssemblerARM64.cpp:
assembler/testmasm.cpp: (JSC::testProbeModifiesProgramCounter):
runtime/JSCPtrTag.h:

10:48 AM Changeset in webkit [271029] by Russell Epstein

2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r270998. rdar://problem/72552852

Fix some issues with PDFs as <object>.
https://bugs.webkit.org/show_bug.cgi?id=220024

Reviewed by Tim Horton.

No new tests (Unable to write automated tests)

WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::dataProviderGetBytesAtPositionCallback): (WebKit::PDFPlugin::getResourceBytesAtPosition): Set the correct URL. (WebKit::PDFPlugin::ByteRangeRequest::completeWithAccumulatedData): Try harder to catch mismatches in delivered bytes vs expected bytes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:48 AM Changeset in webkit [271028] by Russell Epstein

2 edits in branches/safari-610-branch/Source/JavaScriptCore

Cherry-pick r270993. rdar://problem/72552973

Build fix after r270988.
https://bugs.webkit.org/show_bug.cgi?id=220021
<rdar://problem/72474809>

Not reviewed.

JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:47 AM Changeset in webkit [271027] by Russell Epstein

4 edits in branches/safari-610-branch/Source/JavaScriptCore

Cherry-pick r270988. rdar://problem/72552973

Fix MacroAssemblerARM64E::validateUntaggedPtr() to account for TBI.
https://bugs.webkit.org/show_bug.cgi?id=220021
<rdar://problem/72474809>

Reviewed by Saam Barati.

assembler/AbstractMacroAssembler.h:
assembler/DisallowMacroScratchRegisterUsage.h:
templatized the DisallowMacroScratchRegisterUsage class so that we can #include it in MacroAssembler implementations.
assembler/MacroAssemblerARM64E.h: (JSC::MacroAssemblerARM64E::validateUntaggedPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:47 AM Changeset in webkit [271026] by Russell Epstein

2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r270580. rdar://problem/72552978

Multicolumn children becoming in-flow elements should be inserted into the multicolumn flow
https://bugs.webkit.org/show_bug.cgi?id=218503

Reviewed by Zalan Bujtas.

Out of flow children of a multicolumn container are not really part of the multicolumn flow. Making them in-flow (i.e. setting "position: static;")
should trigger the code that inserts them into the MultiColumnFlowThread object of the multicolumn container. RenderTreeBuilder was handling this
in-flow <-> out-of-flow changes just for the cases in which the inline status of an element was affecting the parent.

rendering/RenderMultiColumnFlow.cpp: (WebCore::RenderMultiColumnFlow::normalizeTreeAfterStyleChange): Insert renderer in the multicolumn flow thread whenever it becames in flow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:32 AM Changeset in webkit [271025] by Megan Gardner

2 edits in trunk/Source/WebCore

Copy Localizable.strings file into the correct directory
https://bugs.webkit.org/show_bug.cgi?id=220029
rdar://72167601

Reviewed by Alex Christensen.

After the changes in r269865, r269873, r269915, r269932, r269937 the localizable.strings
was not showing up in the right place in the production build to allow it to be correctly
localized. This skips the step of putting it in DerivedSources and just puts the
concatenated file in the final correct directory so we do not have to relay on Xcode build
doing the correct thing for us.

WebCore.xcodeproj/project.pbxproj:

10:14 AM Changeset in webkit [271024] by aboya@igalia.com

14 edits in trunk

[MSE] Fix allSamplesInTrackEnqueued() handling
https://bugs.webkit.org/show_bug.cgi?id=220055

Reviewed by Philippe Normand.

Source/WebCore:

Within the changes introduced by r270612 a spurious call to
allSamplesInTrackEnqueued() was added to provideMediaData().

provideMediaData() is called every time there may be new samples that
need to be enqueued into the playback pipeline.

allSamplesInTrackEnqueued() is supposed to be called when
MediaSource.endOfStream() has been called and all pending samples have
been enqueued, therefore signaling the playback pipeline that no more
samples will be added.

Some decoders need to be notified of this condition in order to move
the last samples in their queue downstream. This is true at least of
the avdec (ffmpeg) decoders that are commonly used in desktop versions
of the GStreamer port.

Calling allSamplesInTrackEnqueued() prematurely will mess with the
playback as the code will not accept any more samples, a serious
problem. This patch fixes it by removing the spurious call and
restoring its original purpose when it was introduced in r230909.

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::streamEndedWithError):
(WebCore::MediaSource::openIfInEndedState):

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::setMediaSourceEnded):
(WebCore::SourceBuffer::trySignalAllSamplesEnqueued): Deleted.

Modules/mediasource/SourceBuffer.h:
platform/graphics/SourceBufferPrivate.cpp:

(WebCore::SourceBufferPrivate::setMediaSourceEnded):
(WebCore::SourceBufferPrivate::trySignalAllSamplesInTrackEnqueued):
(WebCore::SourceBufferPrivate::provideMediaData):

platform/graphics/SourceBufferPrivate.h:

Source/WebKit:

trySignalAllSamplesInTrackEnqueued() does not need to be exposed
outside of SourceBufferPrivate.

GPUProcess/media/RemoteSourceBufferProxy.cpp:

(WebKit::RemoteSourceBufferProxy::trySignalAllSamplesInTrackEnqueued): Deleted.

GPUProcess/media/RemoteSourceBufferProxy.h:
GPUProcess/media/RemoteSourceBufferProxy.messages.in:
WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::trySignalAllSamplesInTrackEnqueued): Deleted.

WebProcess/GPU/media/SourceBufferPrivateRemote.h:

LayoutTests:

Adjusted test expectations.

platform/glib/TestExpectations:

10:11 AM Changeset in webkit [271023] by Ryan Haddad

1 edit
4 adds in trunk/LayoutTests

Unreviewed test gardening, rebaseline tests for Windows.

platform/win/http/tests/xmlhttprequest/methods-async-expected.txt: Added.
platform/win/http/tests/xmlhttprequest/methods-expected.txt: Added.
platform/win/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.

9:54 AM Changeset in webkit [271022] by Fujii Hironori

2 edits in trunk/Tools

[Win][MiniBrowser] Update built-in User-Agent strings (December 2020)
https://bugs.webkit.org/show_bug.cgi?id=220048

Reviewed by Alex Christensen.

MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::setUserAgent):

8:10 AM Changeset in webkit [271021] by Aditya Keerthi

8 edits in trunk

REGRESSION (r262729): Poor contrast for specific color/background combinations on disabled input fields
https://bugs.webkit.org/show_bug.cgi?id=219991
<rdar://problem/70522921>

Reviewed by Sam Weinig.

Source/WebCore:

The text color for disabled input fields is adjusted based on any
specified color and background-color rules.

r262729 modified the adjustment logic to use the contrastRatio
utility function to determine illegibility issues due to contrast,
rather than a differenceSquared computation. In both cases if the
computed value is less than a minimum constrast value, the original
text color is preserved. As a part of the change, the minimum
contrast value was set to 1.1, a value chosen in order to maintain
the appearance of fast/forms/input-disabled-color.html.

However, the constrast value 1.1 results in combination of
"color #acacac" and "background-color: #f2f2f2" producing white
text on a light gray background, which is illegible. Previously,
this color combination did not result in any change to the text color.

In order to fix, increase the minimum color constrast to 1.195,
which accounts for the failing combination. Note that this increase to
the minimum value prevents some existing text color adjustments
from being performed. This is evidenced by the need to rebaseline
fast/forms/input-disabled-color.html after increasing the constrast.
However, the new text colors are subjectively more legible, which
is the reason why we have a minimum color constrast value.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::disabledTextColor const):

LayoutTests:

Updated an existing test to account for the failing color/background
combination and rebaselined expectations to match the new minimum
constrast ratio.

fast/forms/input-disabled-color.html:
platform/ios/fast/forms/input-disabled-color-expected.txt:
platform/mac-catalina/fast/forms/input-disabled-color-expected.txt:
platform/mac-mojave/fast/forms/input-disabled-color-expected.txt:
platform/mac/fast/forms/input-disabled-color-expected.txt:

4:15 AM Changeset in webkit [271020] by aboya@igalia.com

5 edits in trunk/LayoutTests

media-source-webm.html: Handle frame size in HAVE_METADATA
https://bugs.webkit.org/show_bug.cgi?id=220046

Reviewed by Eric Carlson.

The current version of media-source-webm.html assumes that a resize
event happens after the first media segment is appended.

This is not necessarily true. In fact, an initialization segment
should cause a transition to HAVE_METADATA, and that per spec implies
the size of the video is known.

In practice, some implementations don't report this until a media
segment has arrived.

Because of the way the current code is written, an implementation
emitting resize on HAVE_METADATA would timeout the test. This patch
fixes that, accomodating both cases.

media/media-source/media-source-webm.html:
media/media-source/media-source-webm-expected.txt:
platform/glib/TestExpectations:
platform/wpe/TestExpectations:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed