Context Navigation

← Previous Period
Next Period →

Timeline

Feb 15, 2021:

8:29 PM Changeset in webkit [272896] by pvollan@apple.com

4 edits in trunk/Source

[macOS] Close XPC connections before entering sandbox
https://bugs.webkit.org/show_bug.cgi?id=221905
<rdar://problem/70359582>

Reviewed by Brent Fulgham.

Source/WebKit:

XPC connections that are now allowed in the sandbox should be closed before entering the sandbox.

Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::initializeSandboxParameters):

Source/WTF:

Add softlinking macro for libraries in /usr/lib/system/.

wtf/cocoa/SoftLinking.h:

8:21 PM Changeset in webkit [272895] by pvollan@apple.com

7 edits in trunk/Source/WebKit

Remove 'com.apple.powerlog.plxpclogger.xpc' from WebKit sandboxes
https://bugs.webkit.org/show_bug.cgi?id=221840
<rdar://problem/73579040>

Reviewed by Brent Fulgham.

Remove this service from WebKit sandboxes, since it is not required for correctness.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::diagnosticServices):

WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

8:11 PM Changeset in webkit [272894] by wilander@apple.com

8 edits in trunk

PCM: Add high entropy attributionSourceNonce attribute to anchor tags
https://bugs.webkit.org/show_bug.cgi?id=221934
<rdar://73581230>

Reviewed by Jiewen Tan.

In Private Click Measurement (PCM), the source site should have the option to
provide a high entropy nonce with which PCM can asynchronously validate its
subsequent, asynchronous request for a signature of its unlinkable token.

The nonce attribute's name is attributionSourceNonce and it's a
128-bit/16-byte Base64URL encoded string.

The attribute is behind the experimental feature flag
PrivateClickMeasurementFraudPrevention.

Source/WebCore:

New API tests added.

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parsePrivateClickMeasurement const):

html/HTMLAnchorElement.idl:
html/HTMLAttributeNames.in:
loader/PrivateClickMeasurement.h:

(WebCore::PrivateClickMeasurement::EphemeralSourceNonce::EphemeralSourceNonce):
(WebCore::PrivateClickMeasurement::EphemeralSourceNonce::isValid const):
(WebCore::PrivateClickMeasurement::setEphemeralSourceNonce):
(WebCore::PrivateClickMeasurement::ephemeralSourceNonce const):
(WebCore::PrivateClickMeasurement::clearEphemeralSourceNonce):

page/Settings.yaml:

Tools:

TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:

(TestWebKitAPI::TEST):

6:06 PM Changeset in webkit [272893] by Wenson Hsieh

2 edits in trunk/Source/WebCore/PAL

Unreviewed, fix the Apple internal iOS build after r272878

Wrap NSScrollViewSPI.h in a USE(APPKIT) guard, so that we don't attempt to import AppKit headers when
building for iOS using the internal SDK.

pal/spi/mac/NSScrollViewSPI.h:

5:51 PM Changeset in webkit [272892] by msaboff@apple.com

10 edits in trunk/Source

[ARM64] Change break instruction comment to indicate possible security failure
https://bugs.webkit.org/show_bug.cgi?id=221936

Reviewed by Mark Lam.

Source/bmalloc:

Change the ASSERT break comment immediate to the same value the C++ compiler uses.

bmalloc/BAssert.h:

Source/JavaScriptCore:

We change the comment value to indicate a possible security issue by
using the same value the C++ compiler emits.

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::breakpoint):

disassembler/ARM64/A64DOpcode.cpp:

(JSC::ARM64Disassembler::A64OpcodeExceptionGeneration::format):

disassembler/ARM64/A64DOpcode.h:

(JSC::ARM64Disassembler::A64OpcodeExceptionGeneration::immediate16):

offlineasm/arm64.rb:

Source/WTF:

Change the ASSERT break comment immediate to the same value the C++ compiler uses.

wtf/Assertions.cpp:
wtf/Assertions.h:

4:27 PM Changeset in webkit [272891] by Truitt Savell

3 edits in trunk/Source/WebKit

Unreviewed, reverting r272867.

Broke 50+ fast/layoutformattingcontext/ tests on Mac Debug WK2

Reverted changeset:

"Page scrolling by wheel events doesn't work in non-AC mode
pages if Hardware Acceleration Policy is changed dynamically
from "always" to "never""
https://bugs.webkit.org/show_bug.cgi?id=221067
https://commits.webkit.org/r272867

4:18 PM Changeset in webkit [272890] by eric.carlson@apple.com

29 edits in trunk/Source

[macOS] Connect Touch Bar to MediaSession
https://bugs.webkit.org/show_bug.cgi?id=221921
<rdar://problem/74363311>

Reviewed by Jer Noble.

Source/WebCore:

These changes can only be tested manually.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didReceiveRemoteControlCommand): PlatformMediaSession::RemoteCommandArgument
is a struct.

html/MediaElementSession.cpp:

(WebCore::MediaElementSession::didReceiveRemoteControlCommand): Ditto. Track BeginScrubbing
and EndScrubbing so we know when to set the 'fastSeek' flag when sending a SeekTo command.

html/MediaElementSession.h:

platform/NowPlayingManager.h:
platform/audio/PlatformMediaSession.cpp: PlatformMediaSession::RemoteCommandArgument

is a struct.
(WebCore::convertEnumerationToString):

platform/audio/PlatformMediaSession.h:

(WebCore::PlatformMediaSession::RemoteCommandArgument::encode const):
(WebCore::PlatformMediaSession::RemoteCommandArgument::decode):

platform/cocoa/PlaybackSessionModel.h:

(WebCore::PlaybackSessionModel::sendRemoteCommand): Ditto.

platform/cocoa/PlaybackSessionModelMediaElement.h:
platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::sendRemoteCommand): Ditto.

platform/ios/RemoteCommandListenerIOS.mm:

(WebCore::RemoteCommandListenerIOS::RemoteCommandListenerIOS): Ditto.

platform/mac/PlaybackSessionInterfaceMac.h:
platform/mac/PlaybackSessionInterfaceMac.mm:

(WebCore::PlaybackSessionInterfaceMac::willBeginScrubbing): Pull the logic to update
controls manager timing out of beginScrubbing so it can be used from WebPlaybackControlsManager.
(WebCore::PlaybackSessionInterfaceMac::beginScrubbing):

platform/mac/RemoteCommandListenerMac.mm:

(WebCore::RemoteCommandListenerMac::RemoteCommandListenerMac): PlatformMediaSession::RemoteCommandArgument
is a struct.

platform/mac/WebPlaybackControlsManager.h:
platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager seekToTime:toleranceBefore:toleranceAfter:]): Call
sendRemoteCommand.
(-[WebPlaybackControlsManager beginTouchBarScrubbing]): Ditto.
(-[WebPlaybackControlsManager endTouchBarScrubbing]): Ditto.
(-[WebPlaybackControlsManager togglePlayback]): Ditto.
(-[WebPlaybackControlsManager setPlaying:]): Ditto.
(-[WebPlaybackControlsManager togglePictureInPicture]): Ditto.

testing/Internals.cpp:

(WebCore::Internals::postRemoteControlCommand): Ditto.

Source/WebKit:

GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::didReceiveRemoteControlCommand): PlatformMediaSession::RemoteCommandArgument
is a struct.

GPUProcess/GPUConnectionToWebProcess.h:
UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionModelContext::sendRemoteCommand):
(WebKit::PlaybackSessionManagerProxy::sendRemoteCommand):

WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::didReceiveRemoteCommand):

WebProcess/GPU/GPUProcessConnection.h:
WebProcess/GPU/GPUProcessConnection.messages.in:
WebProcess/GPU/media/RemoteRemoteCommandListener.messages.in:
WebProcess/cocoa/PlaybackSessionManager.h:
WebProcess/cocoa/PlaybackSessionManager.messages.in:
WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionManager::sendRemoteCommand):

4:16 PM Changeset in webkit [272889] by timothy@apple.com

8 edits in trunk/Source

Web Inspector: Add a way to wake up debuggables to the remote inspector protocol
https://bugs.webkit.org/show_bug.cgi?id=221871
rdar://70351644

Reviewed by Devin Rousso.

Source/JavaScriptCore:

inspector/remote/RemoteInspector.h:
inspector/remote/RemoteInspectorConstants.h:
inspector/remote/cocoa/RemoteInspectorCocoa.mm:

(Inspector::RemoteInspector::xpcConnectionReceivedMessage): Handle WIRApplicationWakeUpDebuggablesMessage.
(Inspector::RemoteInspector::receivedWakeUpDebuggables): Added. Call the client.

Source/WebKit:

UIProcess/API/Cocoa/_WKAutomationDelegate.h:
UIProcess/Cocoa/AutomationClient.h:
UIProcess/Cocoa/AutomationClient.mm:

(WebKit::AutomationClient::AutomationClient): Check if the delegate responds to new method.
(WebKit::AutomationClient::requestedDebuggablesToWakeUp): Added. Call new process pool delegate method.

4:09 PM Changeset in webkit [272888] by Said Abou-Hallawa

8 edits in trunk/Source

[GPU Process] Ensure that no image decoders run in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=221885
<rdar://problem/74341122>

Reviewed by Simon Fraser.

Source/WebCore:

Release assert no PDF image is created in the GPU Process.

platform/graphics/cg/PDFDocumentImage.h:

Source/WebCore/PAL:

Add CGImageSourceSetAllowableTypes() to the ImageIO SPI header file.

pal/spi/cg/ImageIOSPI.h:

Source/WebKit:

Make GPU Process force ImageIO to disable all image decoding.

GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::initializeGPUProcess):

Source/WTF:

CGImageSourceSetAllowableTypes() is available starting from macOS Big Sur
and iOS 14.0.

wtf/PlatformHave.h:

3:49 PM Changeset in webkit [272887] by Peng Liu

2 edits in trunk/Source/WebKit

[GPUP] Ignore an IPC message if the message receiver has been destroyed
https://bugs.webkit.org/show_bug.cgi?id=221920

Reviewed by Eric Carlson.

No new tests, fixing test crashes due to assertion failures.

WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::dispatchMessage):

3:29 PM Changeset in webkit [272886] by msaboff@apple.com

2 edits in trunk/Source/WTF

REGRESSION r272823): Crash in ARM64e Wasm tests
https://bugs.webkit.org/show_bug.cgi?id=221922

Reviewed by Mark Lam.

Updated to properly compute the size of thread_state_t as well as the offset of
the PC found in thread_state_t.

wtf/threads/Signals.cpp:

(WTF::hashThreadState):

3:08 PM Changeset in webkit [272885] by Alexey Shvayka

31 edits
6 adds
2 deletes in trunk

[JSC] PropertySlot should allow passing custom setters
https://bugs.webkit.org/show_bug.cgi?id=221872

Reviewed by Yusuke Suzuki.

LayoutTests/imported/w3c:

web-platform-tests/WebIDL/ecmascript-binding/attributes-accessors-unique-function-objects-expected.txt: Added.
web-platform-tests/WebIDL/ecmascript-binding/attributes-accessors-unique-function-objects.html: Added.
web-platform-tests/dom/events/Event-isTrusted.any-expected.txt:
web-platform-tests/dom/events/Event-isTrusted.any.worker-expected.txt:
web-platform-tests/html/browsers/history/the-location-interface/document_location-expected.txt:
web-platform-tests/html/browsers/windows/auxiliary-browsing-contexts/opener-setter.window-expected.txt:
web-platform-tests/html/browsers/windows/embedded-opener-expected.txt:

Source/JavaScriptCore:

This patch:

Merges PropertySlot::TypeCustomAccessor into TypeCustom, allowing to pass a setter for CustomAccessor / CustomValue. Raw C++ function pointers are used to avoid creating CustomGetterSetter instances for non-reified static properties.
Reworks JSObject::getOwnPropertyDescriptor() for custom accessors, making it simpler, more robust, and no longer required to reify all static properties.
Hoists GetValueFunc / PutValueFunc declarations to JSC namespace so they can be used in header files.
Moves CustomAccessor's wrapper maps to JSGlobalObject (because VM outlives it) and simplifies their keys to C++ function pointers.
Splits JSCustomGetterSetterFunction into JSCustomGetterFunction / JSCustomSetterFunction since their signatures and Call logic are quite different. This is a nice refactor that also simplifies garbage collection and reduces memory needed for setter wrappers.
Removes PropertyDescriptor::setCustomDescriptor(), making PropertyDescriptor unaware of custom accessors. Also, drops CustomAccessor check from validateAndApplyPropertyDescriptor() that was incorrect (no error should be thrown if accessors are unchanged) yet unreachable because PropertyDescriptor::equalTo() ignores CustomAccessor.

This change fixes a) accessor functions of unforgeable properties [1] to be persistent
(in terms of referential equality) and b) cross-realm accessor functions to be of correct
global object (instead of lexical).

[1]: https://heycam.github.io/webidl/#dfn-unforgeable-on-an-interface

API/JSCallbackObject.h:
JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
runtime/JSCustomGetterFunction.cpp: Added.

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSCustomGetterFunction::JSCustomGetterFunction):
(JSC::JSCustomGetterFunction::create):

runtime/JSCustomGetterFunction.h: Added.
runtime/JSCustomGetterSetterFunction.cpp: Removed.
runtime/JSCustomGetterSetterFunction.h: Removed.
runtime/JSCustomSetterFunction.cpp: Added.

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSCustomSetterFunction::JSCustomSetterFunction):
(JSC::JSCustomSetterFunction::create):

runtime/JSCustomSetterFunction.h: Added.
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::customGetterFunctionMap):
(JSC::JSGlobalObject::customSetterFunctionMap):
(JSC::JSGlobalObject::customGetterFunctionStructure const):
(JSC::JSGlobalObject::customSetterFunctionStructure const):
(JSC::JSGlobalObject::customGetterSetterFunctionStructure const): Deleted.

runtime/JSObject.cpp:

(JSC::getCustomGetterFunction):
(JSC::getCustomSetterFunction):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::validateAndApplyPropertyDescriptor):
(JSC::getCustomGetterSetterFunctionForGetterSetter): Deleted.

runtime/JSObject.h:

(JSC::JSObject::fillCustomGetterPropertySlot):

runtime/Lookup.h:

(JSC::getStaticPropertySlotFromTable):

runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::setAccessorDescriptor):
(JSC::PropertyDescriptor::setCustomDescriptor): Deleted.

runtime/PropertyDescriptor.h:
runtime/PropertySlot.cpp:

(JSC::PropertySlot::customAccessorGetter const): Deleted.

runtime/PropertySlot.h:

(JSC::PropertySlot::isCustom const):
(JSC::PropertySlot::customGetter const):
(JSC::PropertySlot::customSetter const):
(JSC::PropertySlot::setCustom):
(JSC::PropertySlot::setCacheableCustom):
(JSC::PropertySlot::getValue const):
(JSC::PropertySlot::isCustomAccessor const): Deleted.
(JSC::PropertySlot::customGetterSetter const): Deleted.
(JSC::PropertySlot::setCustomGetterSetter): Deleted.

runtime/PutPropertySlot.h:
runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

Source/WebCore:

To prevent cross-origin accessor functions from different realms to have the same wrapper,
return PropertySlot::TypeGetter instead.

Tests: fast/dom/Window/getOwnPropertyDescriptor-other-window.html

js/instance-property-getter-other-instance.html
imported/w3c/web-platform-tests/dom/events/Event-isTrusted.any.js
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/document_location.html

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):

bindings/js/JSLocationCustom.cpp:

(WebCore::getOwnPropertySlotCommon):

LayoutTests:

fast/dom/Window/getOwnPropertyDescriptor-other-window-expected.txt:
fast/dom/Window/getOwnPropertyDescriptor-other-window.html:
js/instance-property-getter-other-instance-expected.txt:
js/instance-property-getter-other-instance.html:

3:03 PM Changeset in webkit [272884] by Wenson Hsieh

8 edits
2 adds in trunk/Source/WebKit

[macOS] Add a ShareableBitmap with decoded image data to WebHitTestResultData
https://bugs.webkit.org/show_bug.cgi?id=221869

Reviewed by Tim Horton.

Add WebHitTestResultData::imageBitmap; we'll use this in future patches to vend decoded image data to system
frameworks for image extraction.

Shared/WebHitTestResultData.cpp:

(WebKit::WebHitTestResultData::WebHitTestResultData):
(WebKit::WebHitTestResultData::encode const):
(WebKit::WebHitTestResultData::decode):

Add imageBitmap and decoding/encoding support using ShareableBitmap::Handle.

Shared/WebHitTestResultData.h:
Sources.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp: Added.

(WebKit::createShareableBitmap):

WebProcess/WebCoreSupport/ShareableBitmapUtilities.h: Added.

Pull logic to decode rendered image data into a bitmap into a separate helper function; use this helper function
in WebHitTestResultData, as well as a couple of existing call sites in WebPage.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestImageExtraction):
(WebKit::WebPage::shareableBitmap const): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::imagePositionInformation):

2:40 PM Changeset in webkit [272883] by Caio Lima

14 edits
1 copy
8 adds in trunk

[ESNext] Implement private accessors
https://bugs.webkit.org/show_bug.cgi?id=194435

Reviewed by Yusuke Suzuki.

JSTests:

stress/private-accesor-duplicate-name-early-errors.js: Added.
stress/private-getter-brand-check.js: Added.
stress/private-getter-inner-class.js: Added.
stress/private-members-get-and-set.js: Added.
stress/private-methods-and-accessors-postfix-node.js: Added.
stress/private-methods-and-accessors-prefix-node.js: Added.
stress/private-names-available-on-direct-eval.js:
stress/private-names-available-on-eval-during-field-initialization.js: Copied from JSTests/stress/private-names-available-on-direct-eval.js.
stress/private-setter-brand-check.js: Added.
stress/private-setter-inner-class.js: Added.
test262/config.yaml:
test262/expectations.yaml:

Source/JavaScriptCore:

This patch is implementing support for instance private getters and
setters following the proposal on https://tc39.es/proposal-private-methods.
Private accessors also use the private brand check mechanism of
private methods, which means that we are using both
op_set_private_brand and op_check_private_brand to perform brand
checks. Accessors are also stored on class lexical scope as a pair of
getter and setter. This is done creating a new JSObject and
storing the getter on get property, and setter on set
property. This is designed in such way that we can always hit IC fast
path on get_by_id_direct to access the property, and also to allow
constant folding of accessors on DFG/FTL, since acessors objects are
going to be constant once created.

For reference, we have the following bytecode for a private getter
access:

`
class C {

get #m() {...}
access() {

return this.#m;

}

}
`

Bytecode for class declaration:

`
...
new_object dst:loc12, inlineCapacity:2 this is the object to store getter and setter pair
new_func_exp dst:loc13, scope:loc4, functionDecl:"get #m() {...}"
put_by_id base:loc13, property:@homeObject, value:loc11, flags:Strict
put_by_id base:loc12, property:@get, value:loc13, flags:IsDirect|Strict
put_to_scope scope:loc4, var:#m, value:loc12 loc4 is the class lexical scope
...

Bytecode for access():

`
...
resolve_scope dst:loc7, scope:loc4, var:"#m", resolveType:GlobalProperty, localScopeDepth:0
get_from_scope dst:loc8, scope:loc7, var:@privateBrand
check_private_brand base:this, brand:loc8
get_from_scope dst:loc8, scope:loc7, var:"#m"
get_by_id_direct dst:loc9, base:loc8, property:@get
mov dst:loc10, src:this
call dst:loc6, callee:loc9, argc:1, argv:16
...

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::instantiateLexicalVariables):
(JSC::BytecodeGenerator::getPrivateTraits):
(JSC::BytecodeGenerator::getAvailablePrivateAccessNames):
(JSC::BytecodeGenerator::isPrivateMethod): Deleted.

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):
(JSC::PropertyListNode::emitPutConstantProperty):
(JSC::BaseDotNode::emitGetPropertyValue):
(JSC::BaseDotNode::emitPutProperty):
(JSC::PostfixNode::emitDot):
(JSC::PrefixNode::emitDot):

parser/Nodes.h:
parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseGetterSetter):

parser/Parser.h:

(JSC::Scope::declarePrivateSetter):
(JSC::Scope::declarePrivateGetter):

parser/VariableEnvironment.cpp:

(JSC::VariableEnvironment::declarePrivateAccessor):
(JSC::VariableEnvironment::declarePrivateSetter):
(JSC::VariableEnvironment::declarePrivateGetter):

parser/VariableEnvironment.h:

(JSC::VariableEnvironmentEntry::isPrivateSetter const):
(JSC::VariableEnvironmentEntry::isPrivateGetter const):
(JSC::VariableEnvironmentEntry::setIsPrivateSetter):
(JSC::VariableEnvironmentEntry::setIsPrivateGetter):
(JSC::PrivateNameEntry::isSetter const):
(JSC::PrivateNameEntry::isGetter const):
(JSC::PrivateNameEntry::isField const):
(JSC::PrivateNameEntry::isPrivateMethodOrAcessor const):
(JSC::VariableEnvironment::declarePrivateSetter):
(JSC::VariableEnvironment::declarePrivateGetter):

runtime/ExceptionHelpers.cpp:

(JSC::createPrivateMethodAccessError):

2:28 PM Changeset in webkit [272882] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit

[WPE][GTK] SleepDisabler does not inhibit sleep with bubblewrap sandbox enabled: need to run xdg-dbus-proxy under bwrap or xdg-desktop-portal does not read our app ID
https://bugs.webkit.org/show_bug.cgi?id=219010

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-02-15
Reviewed by Carlos Garcia Campos.

We need to run xdg-dbus-proxy under bubblewrap so that we can mount /.flatpak-info in its
mount namespace. Why? Because xdg-desktop-portal checks the pid of its D-Bus peer using
Unix credentials, then looks in that process's mount namespace to read its app ID from
/.flatpak-info. If /.flatpak-info doesn't exist, then any portals that depend on the app ID
will break, including the inhibit portal that we need to prevent the system from suspending
during video playback. This normally works because flatpak runs xdg-dbus-proxy under
bubblewrap and mounts /.flatpak-info, but it breaks for WebKit because we don't. Start doing
so.

This method of getting the app ID might seem like a strange contortion, but it's really
required beacuse the sandboxed process cannot be trusted to provide its own app ID, and will
not have write access to its /.flatpak-info so we can rely on that.

UIProcess/Launcher/ProcessLauncher.h:
UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::createFlatpakInfo):
(WebKit::XDGDBusProxyLauncher::launch):
(WebKit::bubblewrapSpawn):

2:22 PM Changeset in webkit [272881] by Aditya Keerthi

10 edits in trunk

[iOS][FCR] Add new look for input type=range with datalist
https://bugs.webkit.org/show_bug.cgi?id=221782
<rdar://problem/74251214>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/ios/form-control-refresh/range/datalist.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::listOptionValueAsDouble):

Added a helper method to validate and sanitize an option element's
value, and return it as a double.

html/HTMLInputElement.h:
rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks):

rendering/RenderTheme.h:

Make paintSliderTicks a virtual method to support a custom implementation
for iOS. Use FloatRect instead of IntRect for subpixel accuracy.

rendering/RenderThemeIOS.h:
rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintSliderTicks):
(WebCore::RenderThemeIOS::paintSliderTrackWithFormControlRefresh):

LayoutTests:

Added a reference mismatch test to verify that range inputs with
different datalist option values do not appear the same.

fast/forms/ios/form-control-refresh/range/datalist-expected-mismatch.html:
fast/forms/ios/form-control-refresh/range/datalist.html:

2:16 PM Changeset in webkit [272880] by Chris Dumez

5 edits in trunk/Source/WebCore

Crash under WorkerThreadableLoader::MainThreadBridge::notifyIsDone()
https://bugs.webkit.org/show_bug.cgi?id=221906
<rdar://74225448>

Reviewed by Alex Christensen.

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::computeIsDone):
r267227 added this function and this was the first case where the DocumentThreadableLoader
would do an async operation and ref itself during the operation. I believe this was the
source of the crash as this could cause DocumentThreadableLoader to outlive its client.
When DocumentThreadableLoader::notifyIsDone() would get called later on, m_client may be
bad. To maintain pre-r267227 behavior, we now capture a WeakPtr to |this| instead of a
Ref<>, so that we don't unnecessarily extend the lifetime of the DocumentThreadableLoader.

loader/DocumentThreadableLoader.h:

(WebCore::DocumentThreadableLoader::clearClient):
Add new clearClient() function to DocumentThreadableLoader so that the client can clear
the raw pointer the DocumentThreadableLoader holds to it before getting destroyed. I wanted
to use WeakPtr but this did not work out due to multithreading.

loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
Before destroying itself, WorkerThreadableLoader::MainThreadBridge now clears the
raw pointer to it that DocumentThreadableLoader holds. This is important since
DocumentThreadableLoader is RefCounted and its lifetime may get extended past
the MainThreadBridge.

loader/WorkerThreadableLoader.h:

Use tighter typing for clarity.

2:03 PM Changeset in webkit [272879] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Fix -Wunused-variable warning
https://bugs.webkit.org/show_bug.cgi?id=221653
<rdar://problem/74280146>

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-02-15
Reviewed by Alex Christensen.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):

1:48 PM Changeset in webkit [272878] by commit-queue@webkit.org

8 edits
4 moves
1 add in trunk/Source/WebCore

Pull Mac-only code out of ScrollController
https://bugs.webkit.org/show_bug.cgi?id=221462
<rdar://problem/74273853>

Patch by Martin Robinson <mrobinson@igalia.com> on 2021-02-15
Reviewed by Simon Fraser.

No new tests. This should not change behavior.

Split out Mac-specific code from ScrollController and prepare it for use on
non-Cocoa platforms. This code must be pulled out primarily because it is
Objective-C++ code and should maintain the .mm extension. The idea here is to
isolate the basic platform-independent scroll snapping code and gradually make
the rest (related to handling wheel events) more-and-more platform-independent.

PlatformMac.cmake: Update source list.
Sources.txt: Ditto.
SourcesCocoa.txt: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
page/scrolling/ScrollingMomentumCalculator.cpp: Guard code with ENABLE(CSS_SCROLL_SNAP).
platform/ScrollController.cpp: Added.

This file contains only the platform-independent scroll snapping code that will be
used to add initial scroll snap support to other ports.

platform/ScrollController.h: Renamed from Source/WebCore/platform/cocoa/ScrollController.h.
platform/ScrollSnapAnimatorState.cpp: Renamed from Source/WebCore/platform/cocoa/ScrollSnapAnimatorState.mm.
platform/ScrollSnapAnimatorState.h: Renamed from Source/WebCore/platform/cocoa/ScrollSnapAnimatorState.h.
platform/graphics/cg/GraphicsContextGLCG.cpp: Fix unified source build issue exposed by this

change.

platform/mac/ScrollController.mm: Renamed from Source/WebCore/platform/cocoa/ScrollController.mm.
platform/mac/VideoFullscreenInterfaceMac.mm: Fix unified source build issue.

1:42 PM Changeset in webkit [272877] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][Integration] Fix fast/text/justify-nbsp.html tests with inlines enabled
https://bugs.webkit.org/show_bug.cgi?id=221908

Reviewed by Antti Koivisto.

Non-breaking-space is not taken into account when counting the number of expansion opportunities. Disable IFC for now.

layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForCharacter):

layout/integration/LayoutIntegrationCoverage.h:

1:40 PM Changeset in webkit [272876] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, silence -Wreturn-type warning
https://bugs.webkit.org/show_bug.cgi?id=221881
<rdar://problem/74358043>

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-02-15

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseRGBParameters):

1:21 PM Changeset in webkit [272875] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit

Unreviewed, reverting r272863.
https://bugs.webkit.org/show_bug.cgi?id=221918

broke process launching

Reverted changeset:

"[WPE][GTK] SleepDisabler does not inhibit sleep with
bubblewrap sandbox enabled: need to run xdg-dbus-proxy under
bwrap or xdg-desktop-portal does not read our app ID"
https://bugs.webkit.org/show_bug.cgi?id=219010
https://trac.webkit.org/changeset/272863

12:42 PM Changeset in webkit [272874] by aakash_jain@apple.com

4 edits in trunk/Tools

[ews] Add python 3 support - part 2
https://bugs.webkit.org/show_bug.cgi?id=221899

Reviewed by Jonathan Bedard.

CISupport/ews-build/steps.py: Map unicode() to str() for python 3, in order to keep code compatible with

both Python 2 and 3.
(ValidateCommiterAndReviewer.load_contributors): Used items instead of iteritems.
(PrintConfiguration.convert_build_to_os_name): Ditto.

CISupport/ews-build/steps_unittest.py:

(BuildStepMixinAdditions.executedSteps): Converted filter to list comprehension.

CISupport/ews-build/factories_unittest.py: Ditto.

12:28 PM Changeset in webkit [272873] by achristensen@apple.com

11 edits in trunk/Source/WebKit

Unexpected ASSERT when touch events are dispatched on the main thread
https://bugs.webkit.org/show_bug.cgi?id=221832

Reviewed by Dean Jackson.

The TouchEvent message is special. It's received on a non-main thread and completed on the main thread, which asserts.
Rather than lose our asserts making sure our message CompletionHandlers are called on the correct thread,
mark this one with a new attribute, MainThreadCallback, which indicates that it is ok for the callback to be called on the main thread
like it was before r272558 in a different form.

Platform/IPC/HandleMessage.h:

(IPC::handleMessageAsync):

Scripts/webkit/messages.py:
Scripts/webkit/model.py:
Scripts/webkit/tests/TestWithImageDataMessages.h:
Scripts/webkit/tests/TestWithLegacyReceiverMessages.h:
Scripts/webkit/tests/TestWithSemaphoreMessages.h:
Scripts/webkit/tests/TestWithSuperclass.messages.in:
Scripts/webkit/tests/TestWithSuperclassMessages.h:
Scripts/webkit/tests/TestWithoutAttributesMessages.h:
WebProcess/WebPage/EventDispatcher.messages.in:

11:58 AM Changeset in webkit [272872] by Jonathan Bedard

2 edits in trunk/Tools

[results.webkit.org] Distinguish hash and revision
https://bugs.webkit.org/show_bug.cgi?id=221861
<rdar://problem/74298457>

Reviewed by Aakash Jain.

Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit.py:

(Commit.from_json): Pass hash and revision via json.
(Commit.init): Convert id to hash or revision.

11:50 AM Changeset in webkit [272871] by Said Abou-Hallawa

2 edits in trunk/Source/WebCore

[GPU Process] (REGRESSION r272776): Incorrect order for decoding the Pattern repeat properties
https://bugs.webkit.org/show_bug.cgi?id=221910

Reviewed by Simon Fraser.

The order of decoding the repeatX and repeatY properties is reversed.

This is already caught by the GPU bots. Some of the wpt canvas tests have
been failing unexpectedly like 2d.pattern.paint.repeatx.basic.html.

platform/graphics/Pattern.h:

(WebCore::Pattern::Parameters::decode):

11:24 AM Changeset in webkit [272870] by weinig@apple.com

13 edits in trunk

Prepare for adding relative color support
https://bugs.webkit.org/show_bug.cgi?id=221881

Reviewed by Darin Adler.

Source/WebCore:

In preparation for adding experimental relative color support a little cleanup
is in order. This change:

Threads a CSSParserContext through the color parsing functions. This will be needed to check if the feature is enabled or not.
Does a small cleanup of CSSParserContext, sorting features and using the initialization list in the constructor.
Refactors some of the color parsing helpers to extract more helpers. These clarify the code better and will be shared by the relative parsers.
Move normalization of components to after parsing to avoid unnecessary work in the case of failure and separate the phases a bit more.
Removes some unnecessary ValueRangeAll parameters that were already the default.
Switch HSLA and HWBA to stop storing their components in a 0-1 normalization and instead use values that match the input, 0-360 for hue, and 0-100 for the the remaining two components. This seems more natural, and will simplify future color function work that expects the values in this form.

css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseColorWorkerSafe):

css/parser/CSSParserContext.cpp:

(WebCore::shouldEnableLegacyOverflowScrollingTouch):
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):

css/parser/CSSParserContext.h:

(WebCore::CSSParserContextHash::hash):

css/parser/CSSPropertyParser.cpp:

(WebCore::consumeShadow):
(WebCore::consumeCaretColor):
(WebCore::consumeOutlineColor):
(WebCore::consumePaintStroke):
(WebCore::consumeBackgroundComponent):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::consumeBorder):

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeOptionalAlpha):
(WebCore::CSSPropertyParserHelpers::consumeHue):
(WebCore::CSSPropertyParserHelpers::normalizeHue):
(WebCore::CSSPropertyParserHelpers::clampRGBComponent):
(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
(WebCore::CSSPropertyParserHelpers::normalizeWhitenessBlackness):
(WebCore::CSSPropertyParserHelpers::parseHWBParameters):
(WebCore::CSSPropertyParserHelpers::parseLabParameters):
(WebCore::CSSPropertyParserHelpers::parseLCHParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForRGBTypes):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForLabParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForXYZParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunction):
(WebCore::CSSPropertyParserHelpers::consumeColorWorkerSafe):
(WebCore::CSSPropertyParserHelpers::consumeColor):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradientStopColor):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradientColorStop):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeLinearGradient):
(WebCore::CSSPropertyParserHelpers::consumeConicGradient):
(WebCore::CSSPropertyParserHelpers::consumeImageOrNone):
(WebCore::CSSPropertyParserHelpers::consumeCrossFade):
(WebCore::CSSPropertyParserHelpers::consumeGeneratedImage):
(WebCore::CSSPropertyParserHelpers::consumeFilterFunction):
(WebCore::CSSPropertyParserHelpers::consumeSingleShadow):
(WebCore::CSSPropertyParserHelpers::consumeImage):
(WebCore::CSSPropertyParserHelpers::parseOptionalAlpha): Deleted.

css/parser/CSSPropertyParserHelpers.h:

(WebCore::CSSPropertyParserHelpers::consumeImage):

editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):

platform/graphics/ColorConversion.cpp:

(WebCore::calculateHSLHue):
(WebCore::SRGBA<float>>::convert):
(WebCore::HSLA<float>>::convert):
(WebCore::HWBA<float>>::convert):

platform/graphics/ColorModels.h:
rendering/RenderTheme.cpp:

(WebCore::RenderTheme::datePlaceholderTextColor const):

Tools:

TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

Update HSLA tests to account for HSLA now using 0-360, 0-100, 0-100 bounds rather than 0-1, 0-1, 0-1.

11:21 AM Changeset in webkit [272869] by Russell Epstein

1 copy in branches/safari-612.1.4-branch

New branch.

11:18 AM Changeset in webkit [272868] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GPU Process] Repopulate the TestExpectations file #3
https://bugs.webkit.org/show_bug.cgi?id=221708

Unreviewed test gardening.

Patch by Rini Patel <rini_patel@apple.com> on 2021-02-15

gpu-process/TestExpectations:

11:12 AM Changeset in webkit [272867] by Fujii Hironori

3 edits in trunk/Source/WebKit

Page scrolling by wheel events doesn't work in non-AC mode pages if Hardware Acceleration Policy is changed dynamically from "always" to "never"
https://bugs.webkit.org/show_bug.cgi?id=221067

Reviewed by Carlos Garcia Campos.

GTK port is still supporting non-AC mode in WebKit2, and it can
enable/disable accelerated compositing dynamically.

r271235 fixed the bug that wheel event scrolling didn't work in
non-AC mode pages by checking if EventDispatcher's
m_scrollingTrees has a scrolling tree for a WebKit::WebPage.
However, if accelerated compositing is disabled dynamically,
m_scrollingTrees keeps to have a scrolling tree for the WebPage.
m_scrollingTrees should remove the item if accelerated compositing
is disabled.

r271235 added a code to check m_scrollingTrees, but it didn't lock
m_scrollingTreesMutex. The code can be removed. Removed it by
moving to above code.

EventDispatcher::wheelEvent was using a local lambda expression.
However the return value wasn't used. It can be a do-while
statement.

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent): Replaced the lambda
expression with a do-while statement. Unified code of the checking
scrolling tree existence.

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):
(WebKit::WebPage::enterAcceleratedCompositingMode):
(WebKit::WebPage::exitAcceleratedCompositingMode):
(WebKit::WebPage::close):

11:10 AM Changeset in webkit [272866] by graouts@webkit.org

8 edits in trunk

Getting the computed style should resolve animations using the last style change event style
https://bugs.webkit.org/show_bug.cgi?id=221882

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark 20 new PASS results.

web-platform-tests/css/css-color/animation/opacity-interpolation-expected.txt:
web-platform-tests/css/css-transforms/animation/rotate-interpolation-expected.txt:
web-platform-tests/css/css-transforms/animation/scale-interpolation-expected.txt:
web-platform-tests/css/css-transforms/animation/transform-interpolation-006-expected.txt:
web-platform-tests/css/css-transforms/animation/translate-interpolation-expected.txt:

Source/WebCore:

We would fail some WTP tests when animating from the "neutral" value to some explicit value,
where "neutral" is the underlying value for the element, because we cloned the current element
style to be the target style when resolving animations under KeyframeEffect::getAnimatedStyle().
However, that current style may already carry the result of animation resolution, so we should
use the "last style change event style" set on the target to not see any unanimated styles.

If it's not set, then we can use the current element style since it means we will not have
resolved styles for this element yet.

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::getAnimatedStyle):

10:48 AM Changeset in webkit [272865] by Russell Epstein

1 edit in branches/safari-612.1.3-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb

Revert "Unreviewed infrastructure test."

This reverts commit r272864.

10:42 AM Changeset in webkit [272864] by Russell Epstein

1 edit in branches/safari-612.1.3-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb

Unreviewed infrastructure test.

10:40 AM Changeset in webkit [272863] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-02-15
Reviewed by Carlos Garcia Campos.

UIProcess/Launcher/ProcessLauncher.h:
UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::createFlatpakInfo):
(WebKit::XDGDBusProxyLauncher::launch):
(WebKit::bubblewrapSpawn):

10:17 AM Changeset in webkit [272862] by commit-queue@webkit.org

9 edits
2 adds
2 deletes in trunk/Source

Unreviewed, reverting r272831.
https://bugs.webkit.org/show_bug.cgi?id=221907

breaking internal build

Reverted changeset:

"[JSC] Enable JITCage on macOS"
https://bugs.webkit.org/show_bug.cgi?id=221805
https://trac.webkit.org/changeset/272831

10:06 AM Changeset in webkit [272861] by Ruben Turcios

8 edits in trunk/Source

Versioning.

WebKit-7612.1.5

10:00 AM Changeset in webkit [272860] by commit-queue@webkit.org

3 edits
1 add
1 delete in trunk/LayoutTests

[LayoutTests] Convert http/tests/svg convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=221859
<rdar://problem/74298062>

Patch by Chris Gambrell <Chris Gambrell> on 2021-02-15
Reviewed by Jonathan Bedard.

http/tests/svg/cached-image-sizing.html:
http/tests/svg/resources/delayCachedLoad.php: Removed.
http/tests/svg/resources/delayCachedLoad.py: Added.
imported/blink/http/tests/svg/svgload-vs-load.svg:

10:00 AM Changeset in webkit [272859] by commit-queue@webkit.org

2 edits
1 add
1 delete in trunk/LayoutTests

[LayoutTests] Convert http/tests/incremental convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=221902
<rdar://problem/74348931>

Patch by Chris Gambrell <Chris Gambrell> on 2021-02-15
Reviewed by Jonathan Bedard.

http/tests/incremental/resources/delayed-css.php: Removed.
http/tests/incremental/resources/delayed-css.py: Added.
http/tests/incremental/stylesheet-body-incremental-rendering.html:

9:35 AM Changeset in webkit [272858] by youenn@apple.com

16 edits in trunk/Source

Move WebRTCPlatformCodecsInGPUProcessEnabled to Page Settings
https://bugs.webkit.org/show_bug.cgi?id=221893

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Always use the remote factory to simplify things. This ensures that factories remain in sync whether callbacks are set or not.
We check anyway whether callbacks are set and use them if needed.
Otherwise, we default to the in-process code path.

Source/webrtc/sdk/WebKit/WebKitDecoder.mm:

(webrtc::createWebKitDecoderFactory):

Source/webrtc/sdk/WebKit/WebKitEncoder.mm:

(webrtc::createWebKitEncoderFactory):

Source/WebCore:

Covered by existing tests.

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebRTCH264SimulcastEnabled):
(WebCore::RuntimeEnabledFeatures::webRTCPlatformCodecsInGPUProcessEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebRTCPlatformCodecsInGPUProcessEnabled): Deleted.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::setWebRTCPlatformCodecsInGPUProcessEnabled): Deleted.

testing/InternalSettings.h:
testing/InternalSettings.idl:

Source/WebKit:

Make LibWebRTCProvider and MediaRecorder provider keep a WebPage reference.
Use it to get WebRTCPlatformCodecsInGPUProcessEnabled setting when needed.
For LibWebRTCProvider, set callback only once before creating the first peer connection.
This makes sure we do not change callbacks while using them in another thread.

WebProcess/GPU/webrtc/MediaRecorderProvider.cpp:

(WebKit::MediaRecorderProvider::createMediaRecorderPrivate):

WebProcess/GPU/webrtc/MediaRecorderProvider.h:

(WebKit::MediaRecorderProvider::MediaRecorderProvider):

WebProcess/Network/webrtc/LibWebRTCProvider.cpp:

(WebKit::LibWebRTCProvider::createPeerConnection):

WebProcess/Network/webrtc/LibWebRTCProvider.h:

(WebKit::LibWebRTCProvider::LibWebRTCProvider):

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):

Source/WTF:

Scripts/Preferences/WebPreferencesExperimental.yaml:

9:26 AM Changeset in webkit [272857] by commit-queue@webkit.org

2 edits in trunk/Tools

Add git commit -v support to commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=221903

Patch by Adam Roben <Adam Roben> on 2021-02-15
Reviewed by Darin Adler.

From the git-commit documentation:

-v, --verbose

Show unified diff between the HEAD commit and what would be
committed at the bottom of the commit message template to help
the user describe the commit by reminding what changes the
commit has. Note that this diff output doesn't have its lines
prefixed with #. This diff will not be a part of the commit
message. See the commit.verbose configuration variable in
git-config(1).

commit-log-editor was getting confused about the diff not being prefixed
with #. Now it looks for the "cut line" that Git puts in the log just
before the diff. It looks like this:

# ------------------------ >8 ------------------------

See https://github.com/git/git/blob/e6362826a0409539642a5738db61827e5978e2e4/wt-status.c#L24-L25

Scripts/commit-log-editor: Keep track of whether the "cut line" has been found. If it has, consider it and everything after it to be part of the log contents but not the existing log message.

9:11 AM Changeset in webkit [272856] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Do not re-measure wrapped content
https://bugs.webkit.org/show_bug.cgi?id=221874

Reviewed by Antti Koivisto.

This patch addresses the performance issue with extremely long content when
the content gets re-measured many time while performing line breaking.

When a certain text content does not fit the line we can

keep it on the current line and let it overflow or
wrap the entire content to the next line or
split it somewhere in the middle.

In case of 2 and 3 this overflowing content turns into the leading content on the subsequent line.
Now due to ligature (#3) and position dependent glyph sizing(#2) we need to remeasure this leading content again.
However with unreasonably long content and relatively small horizontal constraint, this could lead to
repeated, continuous text measuring.
In this patch we turn the overflow width into the leading width so that we measure the long text content only once.
(FIXME: This should be turned into a generic "use the overflow content as-is when turning it into leading content")

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):

layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::placeInlineContent):
(WebCore::Layout::LineBuilder::candidateContentForLine):
(WebCore::Layout::LineBuilder::handleInlineContent):

layout/inlineformatting/InlineLineBuilder.h:

9:09 AM Changeset in webkit [272855] by youenn@apple.com

7 edits
2 adds in trunk/Source/WebKit

Share more code between RemoteRealtimeAudioSource and RemoteRealtimeVideoSource
https://bugs.webkit.org/show_bug.cgi?id=221898

Reviewed by Eric Carlson.

Introduce RemoteRealtimeMediaSourceProxy to share more code between the two classes.
This class implements most of the messaging with capture process.
No change of behavior.

WebProcess/cocoa/RemoteRealtimeAudioSource.cpp:

(WebKit::RemoteRealtimeAudioSource::createRemoteMediaSource):

WebProcess/cocoa/RemoteRealtimeAudioSource.h:

(WebKit::RemoteRealtimeAudioSource::identifier const): Deleted.
(WebKit::RemoteRealtimeAudioSource::connection): Deleted.
(WebKit::RemoteRealtimeAudioSource::applyConstraintsFailed): Deleted.

WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:

(WebKit::RemoteRealtimeMediaSourceProxy::isReady const):

WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:

(WebKit::RemoteRealtimeVideoSource::RemoteRealtimeVideoSource):
(WebKit::RemoteRealtimeVideoSource::createRemoteMediaSource):
(WebKit::RemoteRealtimeVideoSource::~RemoteRealtimeVideoSource):
(WebKit::RemoteRealtimeVideoSource::setShouldApplyRotation):
(WebKit::RemoteRealtimeVideoSource::hasEnded):
(WebKit::RemoteRealtimeVideoSource::generatePresets):
(WebKit::RemoteRealtimeVideoSource::setFrameRateWithPreset):
(WebKit::RemoteRealtimeVideoSource::gpuProcessConnectionDidClose):
(WebKit::RemoteRealtimeVideoSource::whenReady): Deleted.
(WebKit::RemoteRealtimeVideoSource::didFail): Deleted.
(WebKit::RemoteRealtimeVideoSource::setAsReady): Deleted.
(WebKit::RemoteRealtimeVideoSource::connection): Deleted.
(WebKit::RemoteRealtimeVideoSource::startProducingData): Deleted.
(WebKit::RemoteRealtimeVideoSource::stopProducingData): Deleted.

WebProcess/cocoa/RemoteRealtimeVideoSource.h:

(WebKit::RemoteRealtimeVideoSource::identifier const): Deleted.

9:07 AM Changeset in webkit [272854] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[WPE][GTK] BubblewrapLauncher should create flatpak-info keyfile only once
https://bugs.webkit.org/show_bug.cgi?id=221224

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-02-15
Reviewed by Adrian Perez de Castro.

BubblewrapLauncher should create its flatpak-info keyfile only once, because its contents
will never change. Makes more sense to cache this tiny string in memory than to recompute it
every time a subprocess is launched.

When working on this, I noticed a quirk in the documentation of g_key_file_to_data: although
the function has a GError parameter, it is legacy and the function is actually guaranteed to
succeed. So icky though it seems, I've removed the error checking for that, as recommended
by its documentation.

UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::createFlatpakInfo):

9:01 AM Changeset in webkit [272853] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[iOS] Cleanup exit/enterFullScreenHandler and how the global states are set.
https://bugs.webkit.org/show_bug.cgi?id=221886

Patch by Jean-Yves Avenard <Jean-Yves Avenard> on 2021-02-15
Reviewed by Darin Adler.

There is no change in behavior with this commit.

platform/ios/VideoFullscreenInterfaceAVKit.h:
platform/ios/VideoFullscreenInterfaceAVKit.mm:

(VideoFullscreenInterfaceAVKit::doEnterFullscreen):
(VideoFullscreenInterfaceAVKit::doExitFullscreen):
(VideoFullscreenInterfaceAVKit::exitFullscreenHandler):
(VideoFullscreenInterfaceAVKit::enterFullscreenHandler):
Pass new nextActions OptionSet to define the behaviour of the handler; either call doEnterFullScreen or doExitFullScreen, rather than set member booleans that could be incorrectly used by other methods.

8:58 AM Changeset in webkit [272852] by youenn@apple.com

4 edits
3 adds in trunk

Use page setting to expose or not registerRTCRtpScriptTransformer in workers
https://bugs.webkit.org/show_bug.cgi?id=221892

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/wpt/webrtc/no-webrtc-transform.html

bindings/js/WebCoreBuiltinNames.h:
workers/DedicatedWorkerGlobalScope.idl:

LayoutTests:

http/wpt/webrtc/no-webrtc-transform-expected.txt: Added.
http/wpt/webrtc/no-webrtc-transform.html: Added.
http/wpt/webrtc/no-webrtc-transform.js: Added.

8:52 AM Changeset in webkit [272851] by commit-queue@webkit.org

5 edits
4 adds
4 deletes in trunk/LayoutTests

[LayoutTests] Convert http/tests/ssl convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=221862
<rdar://problem/74298527>

Patch by Chris Gambrell <Chris Gambrell> on 2021-02-15
Reviewed by Jonathan Bedard.

http/tests/ssl/referer-301.html:
http/tests/ssl/referer-303.html:
http/tests/ssl/resources/ping-with-unsafe-redirect-frame.html:
http/tests/ssl/resources/redirect-ping-to-http.php: Removed.
http/tests/ssl/resources/redirect-ping-to-http.py: Added.
http/tests/ssl/resources/referer-301-redir.php: Removed.
http/tests/ssl/resources/referer-301-redir.py: Added.
http/tests/ssl/resources/referer-303-redir.php: Removed.
http/tests/ssl/resources/referer-303-redir.py: Added.
http/tests/ssl/verify-ssl-enabled.php: Removed.
http/tests/ssl/verify-ssl-enabled.py: Added.
platform/win/TestExpectations:

8:51 AM Changeset in webkit [272850] by msaboff@apple.com

1 edit
1 delete in trunk

Unreviewed cleanup after r272824.

Restored stepped on Tools/ChangeLog entries.
Eliminated unneeded empty directory.

4:56 AM Changeset in webkit [272849] by Chris Lord

10 edits in trunk/Source/WebCore

CSSFontFace should not need its m_fontSelector data member
https://bugs.webkit.org/show_bug.cgi?id=208351

Reviewed by Myles C. Maxfield.

Remove the last use of m_fontSelector from CSSFontFace. Adding
CachedFontClient::fontRequested allows us to add the FontSelector as a
client while we have access to both the FontSelector and the CachedFont
in CSSFontFace::appendSources.

No new tests because there is no behavior change.

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::appendSources):
(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::opportunisticallyStartFontDataURLLoading):
(WebCore::CSSFontFace::document):
(WebCore::CSSFontFace::pump):
(WebCore::CSSFontFace::font):

css/CSSFontFace.h:
css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::opportunisticallyStartFontDataURLLoading):
(WebCore::CSSFontFaceSource::load):

css/CSSFontFaceSource.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::opportunisticallyStartFontDataURLLoading):
(WebCore::CSSFontSelector::clearDocument):
(WebCore::CSSFontSelector::willBeginLoadingFontSoon):
(WebCore::CSSFontSelector::fontRequested):
(WebCore::CSSFontSelector::loadPendingFonts):

css/CSSFontSelector.h:
loader/cache/CachedFont.cpp:

(WebCore::CachedFont::requestLoad):

loader/cache/CachedFont.h:
loader/cache/CachedFontClient.h:

(WebCore::CachedFontClient::fontRequested):

3:39 AM Changeset in webkit [272848] by Lauro Moura

2 edits in trunk/Source/WTF

REGRESSION(r272842) [GStreamer] Layout tests exiting early due to crashes after GPUProcess for media enabled by default for WTR
https://bugs.webkit.org/show_bug.cgi?id=221883

Reviewed by Philippe Normand.

Scripts/Preferences/WebPreferencesExperimental.yaml: Disable

UseGPUProcessForMediaEnabled when using GStreamer for now.

3:24 AM Changeset in webkit [272847] by Manuel Rego Casasnovas

7 edits
2 adds in trunk/LayoutTests

[selectors] Update WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=221890

Reviewed by Carlos Alberto Lopez Perez.

LayoutTests/imported/w3c:

web-platform-tests/css/selectors/focus-visible-002-expected.txt:
web-platform-tests/css/selectors/focus-visible-002.html:
web-platform-tests/css/selectors/focus-visible-006.html:
web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001-expected.xht: Added.
web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001.html: Added.
web-platform-tests/css/selectors/w3c-import.log:

LayoutTests:

TestExpectations: Add test failure for :dir().

3:05 AM Changeset in webkit [272846] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Improve readability in RenderFlexibleBox::childIntrinsicLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=221877

Patch by Rob Buis <rbuis@igalia.com> on 2021-02-15
Reviewed by Sergio Villar Senin.

Improve readability in RenderFlexibleBox::childIntrinsicLogicalWidth by
using Optional instead of -1, which is a magic value that ends up not
being used.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::childIntrinsicLogicalWidth const):

2:38 AM Changeset in webkit [272845] by commit-queue@webkit.org

3 edits
3 adds in trunk

Crash in RetainPtr<CGImage*>::RetainPtr via ImageBufferCGBackend::toCFData
https://bugs.webkit.org/show_bug.cgi?id=221376

Patch by Frederic Wang <fwang@igalia.com> on 2021-02-15
Reviewed by Said Abou-Hallawa.

Source/WebCore:

Call to copyNativeImage(CopyBackingStore) may return a null pointer if CGBitmapContextCreateImage
does. This patch fixes a crash due to null pointer dereference and adds a similar check for
copyNativeImage(DontCopyBackingStore).

Test: fast/canvas/resize-to-large-canvas-and-convert-to-blog.html

platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::ImageBufferCGBackend::toCFData const):

LayoutTests:

fast/canvas/resize-to-large-canvas-and-convert-to-blog-expected.txt: Added.
fast/canvas/resize-to-large-canvas-and-convert-to-blog-expected.txt: Added.
fast/canvas/resize-to-large-canvas-and-convert-to-blog.html: Added.

2:23 AM Changeset in webkit [272844] by Manuel Rego Casasnovas

2 edits in trunk/Source/WebCore

[selectors] Update :focus-visible status in features.json
https://bugs.webkit.org/show_bug.cgi?id=221889

Reviewed by Sergio Villar Senin.

features.json:

1:04 AM Changeset in webkit [272843] by svillar@igalia.com

4 edits in trunk/Source/WebCore

Don't update form control elements validity status if they are detached from the document.
https://bugs.webkit.org/show_bug.cgi?id=220390

Reviewed by Ryosuke Niwa.

When a radio button input element is removed from a form (either because it's moved or because the form
is deleted) then it's also removed from its current RadioButtonGroup. The latter removal might require the
update of the input validity status. In case of validity status changes, then we have to walk up
the ancestor chain in order to update the style for pseudo classes such as :valid :invalid. That node traversal
should not be done in case of being detached from the main document because our ancestors might have been
deleted before.

Apart from that we're replacing the HashSet of raw pointers to descendants in HTMLFieldSetElement by a WeakHashSet
which is safer.

html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::matchesValidPseudoClass const):
(WebCore::HTMLFieldSetElement::matchesInvalidPseudoClass const):
(WebCore::HTMLFieldSetElement::addInvalidDescendant):
(WebCore::HTMLFieldSetElement::removeInvalidDescendant):

html/HTMLFieldSetElement.h:
html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::updateValidity(): Early return in case of isConnected().

Feb 14, 2021:

6:08 PM Changeset in webkit [272842] by Peng Liu

46 edits in trunk

[GPUP] Move UseGPUProcessForMediaEnabled from WebPreferencesInternal to WebPreferencesExperimental
https://bugs.webkit.org/show_bug.cgi?id=221310

Reviewed by Eric Carlson.

Source/WTF:

Move UseGPUProcessForMediaEnabled from WebPreferencesInternal to WebPreferencesExperimental,
so that the WebKitTestRunner will turn it on by default.

Scripts/Preferences/WebPreferencesExperimental.yaml:
Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(TEST):
Use WKPreferencesSetBoolValueForKeyForTesting() to set the preference for testing.
It works no matter the preference is internal or experimental.

LayoutTests:

Update expectations of the tests which are affected by the "Media In GPUProcess" feature
(WebKitTestRunner will enable the feature by default). Also set "UseGPUProcessForMediaEnabled=false"
for some webrtc tests.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:
platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:
platform/wk2/TestExpectations:
webrtc/captureCanvas-webrtc-software-h264-baseline.html:
webrtc/captureCanvas-webrtc-software-h264-high.html:
webrtc/captureCanvas-webrtc.html:
webrtc/concurrentVideoPlayback2.html:
webrtc/direction-change.html:
webrtc/disable-encryption.html:
webrtc/h264-baseline.html:
webrtc/h264-high.html:
webrtc/multi-audio.html:
webrtc/multi-video.html:
webrtc/peer-connection-track-end.html:
webrtc/peerconnection-page-cache-long.html:
webrtc/peerconnection-page-cache.html:
webrtc/remove-track.html:
webrtc/utf8-sdp.html:
webrtc/video-addTrack.html:
webrtc/video-addTransceiver.html:
webrtc/video-autoplay.html:
webrtc/video-disabled-black.html:
webrtc/video-h264.html:
webrtc/video-interruption.html:
webrtc/video-mediastreamtrack-stats.html:
webrtc/video-mute.html:
webrtc/video-remote-mute.html:
webrtc/video-replace-muted-track.html:
webrtc/video-replace-track-to-null.html:
webrtc/video-replace-track.html:
webrtc/video-rotation-no-cvo.html:
webrtc/video-rotation.html:
webrtc/video-setDirection.html:
webrtc/video-sframe.html:
webrtc/video-stats.html:
webrtc/video-unmute.html:
webrtc/video-with-data-channel.html:
webrtc/video.html:

12:51 PM Changeset in webkit [272841] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[iOS] MobileSafari crashes at WebCore: WebCore::VideoFullscreenInterfaceAVKit::doEnterFullscreen
https://bugs.webkit.org/show_bug.cgi?id=221863
<rdar://73861140>

Patch by Jean-Yves Avenard <Jean-Yves Avenard> on 2021-02-14
Reviewed by Darin Adler.

On iPad, it's possible for AVKit to fail due to racing requests to exit full screen and enter full screen. The enterFullscreenHandler would attempt to immediately re-enter full screen.
For now we bail-out early to avoid the crash. In a follow-up patch we will ensure that the condition to enter fullscreen while there's a pending operation to exit fullscreen can't occur.
No new tests, can't reproduce. Analysis has been entirely theoretical.

platform/ios/VideoFullscreenInterfaceAVKit.mm:

(VideoFullscreenInterfaceAVKit::enterFullscreenHandler):
Exit early if error returned.

11:06 AM Changeset in webkit [272840] by commit-queue@webkit.org

2 edits in trunk/JSTests

JSC stress test stress/copy-data-properties-fast-path.js.default fails on s390x and ppc64le
https://bugs.webkit.org/show_bug.cgi?id=221557
<rdar://problem/74311603>

Unreviewed, unskip this test since it seems Yusuke has already fixed it.

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-02-14

stress/copy-data-properties-fast-path.js:

9:18 AM Changeset in webkit [272839] by Darin Adler

3 edits
2 adds in trunk

Crash calling replaceTrack on a sender that outlives its RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=221870

Reviewed by Youenn Fablet.

Source/WebCore:

Test: fast/mediastream/RTCRtpSender-outlives-RTCPeerConnection.html

Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::replaceTrack): Added a null check for m_connection.
It's already using WeakPtr, so null check is all we need.

LayoutTests:

fast/mediastream/RTCRtpSender-outlives-RTCPeerConnection-expected.txt: Added.
fast/mediastream/RTCRtpSender-outlives-RTCPeerConnection.html: Added.

Feb 13, 2021:

7:04 PM Changeset in webkit [272838] by Alexey Shvayka

5 edits
1 add in trunk

Proxy's GetOwnProperty should complete trap result descriptor before validation
https://bugs.webkit.org/show_bug.cgi?id=221772

Reviewed by Yusuke Suzuki.

JSTests:

stress/proxy-get-own-property.js:
stress/proxy-returning-incomplete-property-descriptor-error.js: Added.

Source/JavaScriptCore:

This patch implements CompletePropertyDescriptor abstract op and utilizes it in
Proxy's GetOwnProperty, right before IsCompatiblePropertyDescriptor check
as per spec [1].

This change tightens trap result validation rules for properties that are
non-configurable on ProxyTarget, aligning JSC with V8 and SpiderMonkey.

It's impossible to prefill trap result descriptor: toPropertyDescriptor() throws
on malformed descriptors, thus it expects the argument to be an empty descriptor
(added an assert).

Property descriptors returned to userland are unaffected as they were implicitly
completed when filling PropertySlot (see PropertyDescriptor::defaultAttributes).

[1]: https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-getownproperty-p (step 14)

runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

runtime/ProxyObject.cpp:

(JSC::completePropertyDescriptor):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):

4:05 PM Changeset in webkit [272837] by weinig@apple.com

5 edits in trunk/Source/WebCore

Reduce requirements for color types to only conversion to their reference color
https://bugs.webkit.org/show_bug.cgi?id=221868

Reviewed by Darin Adler.

We currently require every new color type to define a conversion to/from xyz and then perhaps
some more conversions to reference colors to avoid unnecessary trips through XYZ. For example,
if every conversion from HSL to sRGB went through XYZ it would be very silly and inefficient,
and the fact that we require the boiler plate for HSL -> XYZ, even though it's always going to
convert to SRGB first seems unfortunate. We can do better.

At first I thought we could model color conversion as DAG, with XYZ at the root, and each color
type declaring a "reference color" that would get them closer to XYZ. So, HSL would have a
"reference color" of sRGB, sRGB would have a "reference color" of linearSRGB, and linearSRGB
would have a "reference color" XYZ. Then, as long as there was a defined conversion to/from the
"reference color", we could do a least common ancestor graph search between the two color types
being converted between to find the optimal set of conversions needed.

That almost works, but the relationships between the four color types that make up each RGB type
(bounded-gamma-encoded, bounded-linear-encoded, extended-gamma-encoded, extended-linear-encoded)
make it not quite ideal, since a conversion from something like sRGB to ExtendedSRGB would wind
up going through XYZ (since the "reference color" for sRGB is LinearSRGB and the "reference color"
for ExtendedSRGB is LinearExtendedSRGB, and both either "reference colors" are XYZ).

Ultimately, the depth of the type graph is not all that large (though the ASCII art I made is
quite big, though I did remove A98RGB and Rec2020 as they are same as DisplayP3 here):

┌ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ┼ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ┐

Matrix Conversions ┌───────────┐│┌───────────┐

│ │ XYZ (D50) │││ XYZ (D65) │ │

└─────▲─────┘│└─────▲─────┘

│ │ │ │ │

┌─────────────────────────┬───────────┘ │ └───────────┬───────────────────────────────┐
│ │ │ │ │ │ │
│ │ │ │ │
│ │ │ │ │ │ │
│ ProPhotoRGB───────────────────┐ │ SRGB──────────────────────────┐ DisplayP3─────────────────────┐
│ │ │┌────────┐ ┌────────────────┐│ │ │┌────────┐ ┌────────────────┐│ │┌────────┐ ┌────────────────┐│ │
│ ││ Linear │ │ LinearExtended ││ │ ││ Linear │ │ LinearExtended ││ ││ Linear │ │ LinearExtended ││
│ │ │└────────┘ └────────────────┘│ │ │└────────┘ └────────────────┘│ │└────────┘ └────────────────┘│ │
│ ─│─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─│─ ─│─ ─│─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─│─│─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─│─

┌───────────┐ │┌────────┐ ┌────────────────┐│ │ │┌────────┐ ┌────────────────┐│ │┌────────┐ ┌────────────────┐│
│ Lab │ ││ Gamma │ │ GammaExtended ││ │ ││ Gamma │ │ GammaExtended ││ ││ Gamma │ │ GammaExtended ││
└─────▲─────┘ │└────────┘ └────────────────┘│ │ │└────▲───┘ └────────────────┘│ │└────────┘ └────────────────┘│

│ └─────────────────────────────┘ │ └─────┼───────────────────────┘ └─────────────────────────────┘
│ │ ┌──┴──────────┬─────────────┐
│ │ │ │ │

┌───────────┐ │┌───────────┐ ┌───────────┐┌─────────────┐
│ LCH │ ││ HSL │ │ HWB ││SRGB<uint8_t>│
└───────────┘ │└───────────┘ └───────────┘└─────────────┘

From this, it turns out you can handle all the cases in about 5 steps, with most peeling off a
conversion from the front or back or the path and using recursion to continue on. It ultimately
leaves a final step where only matrix conversions remain, which can potentially be further
optimized in another patch to concatenate the matrices at compile time.

Handle the special case SRGBA<uint8_t> for Input and Output, and recursively call conversion.

Handle all color types that are not IsRGBType<T> or IsXYZA<T> for Input and Output. For all these other color types, we can uncondtionally convert them to their "reference" color, as either they have already been handled by a ColorConversion specialization or this will get us closer to the final conversion, and recursively call conversion.

Handle conversions within a RGBFamily (e.g. all have the same descriptor). This will conclude the conversion.

Handle any gamma conversions for the Input and Output, recursively call conversion

At this point, Input and Output are each either Linear-RGB types (of different familes) or XYZA and therefore all additional conversion can happen via matrix transformation. This will conclude the conversion.

With these steps, we group the color types into 3 distinct groups.

RGB types.

These inherit from the RGBType struct and are defined in terms of their xyzToLinear / linearToXYZ
matrices, their transfer function, whether they are bounded or extended and their white point. New
RGB color types can be added without any new conversion code being required, as long as they specify
those properties.

The XYZ type.

This is the root type, and only varies on its white point. If other white points beside D50 and D65
are ever needed, we will need to extend the ChromaticAdapation specializations to also have conversion
matrices between those.

All other types.

All other types (e.g. Lab, LCHA, HSLA, HWBA (and SRGBA<uint8_t>, kind of, it's a special flower) are
the set currently) have their conversions defined in terms of single reference color and require
explicit specialization of the ColorConversion struct to work.

platform/graphics/ColorConversion.cpp:

(WebCore::Lab<float>>::convert):
(WebCore::WhitePoint::D50>>::convert):
(): Deleted.
(WebCore::WhitePoint::D65>>::convert): Deleted.
(WebCore::toLinear): Deleted.
(WebCore::toGammaEncoded): Deleted.
(WebCore::A98RGB<float>>::convert): Deleted.
(WebCore::LinearA98RGB<float>>::convert): Deleted.
(WebCore::DisplayP3<float>>::convert): Deleted.
(WebCore::LinearDisplayP3<float>>::convert): Deleted.
(WebCore::ExtendedSRGBA<float>>::convert): Deleted.
(WebCore::LinearExtendedSRGBA<float>>::convert): Deleted.
(WebCore::ProPhotoRGB<float>>::convert): Deleted.
(WebCore::LinearProPhotoRGB<float>>::convert): Deleted.
(WebCore::Rec2020<float>>::convert): Deleted.
(WebCore::LinearRec2020<float>>::convert): Deleted.
(WebCore::LinearSRGBA<float>>::convert): Deleted.
(WebCore::xyzToLinear): Deleted.
(WebCore::linearToXYZ): Deleted.
(WebCore::XYZFor<LinearA98RGB<float>>>::convert): Deleted.
(WebCore::XYZFor<LinearDisplayP3<float>>>::convert): Deleted.
(WebCore::XYZFor<LinearExtendedSRGBA<float>>>::convert): Deleted.
(WebCore::XYZFor<LinearProPhotoRGB<float>>>::convert): Deleted.
(WebCore::XYZFor<LinearRec2020<float>>>::convert): Deleted.
(WebCore::XYZFor<LinearSRGBA<float>>>::convert): Deleted.
(WebCore::XYZFor<Lab<float>>>::convert): Deleted.
(WebCore::XYZFor<A98RGB<float>>>::convert): Deleted.
(WebCore::XYZFor<DisplayP3<float>>>::convert): Deleted.
(WebCore::XYZFor<ExtendedSRGBA<float>>>::convert): Deleted.
(WebCore::XYZFor<HSLA<float>>>::convert): Deleted.
(WebCore::XYZFor<HWBA<float>>>::convert): Deleted.
(WebCore::XYZFor<LCHA<float>>>::convert): Deleted.
(WebCore::XYZFor<ProPhotoRGB<float>>>::convert): Deleted.
(WebCore::XYZFor<Rec2020<float>>>::convert): Deleted.
(WebCore::XYZFor<SRGBA<float>>>::convert): Deleted.

platform/graphics/ColorConversion.h:

(WebCore::ColorConversion::convert):
(WebCore::ColorConversion::toLinearEncoded):
(WebCore::ColorConversion::toGammaEncoded):
(WebCore::ColorConversion::toExtended):
(WebCore::ColorConversion::toBounded):
(WebCore::ColorConversion::handleRGBFamilyConversion):
(WebCore::ColorConversion::handleMatrixConversion):

platform/graphics/ColorMatrix.h:

(WebCore::operator==):
(WebCore::operator!=):
(WebCore::applyMatricesToColorComponents):

platform/graphics/ColorTypes.h:

12:35 PM Changeset in webkit [272836] by ap@apple.com

2 edits in trunk/Source/WebKit

Unreviewed build fix.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView pointerInteraction:styleForRegion:]):

11:13 AM Changeset in webkit [272835] by Darin Adler

2 edits in trunk/Source/WebCore

Improve computed style handling in degenerate grid cases, sizes and lengths of zero
https://bugs.webkit.org/show_bug.cgi?id=221856

Reviewed by Anders Carlsson.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForImageSliceSide): Handle "auto", which can come up with sizes of zero.
(WebCore::valueForNinePieceImage): Simplify by not putting Ref<> results into RefPtr<> locals.
(WebCore::valueForGridTrackList): Clamp insertion point to the actual size of the tracks,
since it can be set to an arbitrary larger value.

11:07 AM Changeset in webkit [272834] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC][Integration] Not every inline box contributes to line overflow
https://bugs.webkit.org/show_bug.cgi?id=221867

Reviewed by Antti Koivisto.

Consider the follow content:
<div style="font-size: 20px;">content<span style="font-size: 200px;"><img></span></div>

In quirks mode, the inline box (<span>) does not stretch the line box vertically. What it means in practice is
that the inline box's descent is ignored. While the inline box has a relatively large descent and
in theory it overflows the line (since it is larger than the root inline box's descent)
it should not be taken into account when computing the scrollable overflow.
However adding "padding: 1px" to the <span> will make the inline box stretch the line and now this "1px padding" will
contribute to the scrollable overflow.

layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayNonRootInlineBoxes const):

layout/integration/LayoutIntegrationInlineContentBuilder.h:
layout/integration/LayoutIntegrationLine.h:

(WebCore::LayoutIntegration::NonRootInlineBox::NonRootInlineBox):
(WebCore::LayoutIntegration::NonRootInlineBox::canContributeToLineOverflow const):

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):

10:18 AM Changeset in webkit [272833] by commit-queue@webkit.org

2 edits in trunk/JSTests

JSC stress test stress/copy-data-properties-fast-path.js.default fails on s390x and ppc64le
https://bugs.webkit.org/show_bug.cgi?id=221557

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-02-13
Reviewed by Saam Barati.

Skip the test on these architectures. I don't know what else to do with it.

stress/copy-data-properties-fast-path.js:

2:59 AM Changeset in webkit [272832] by ysuzuki@apple.com

2 edits in trunk/JSTests

Unreviewed, fix stress/copy-data-properties-fast-path.js occasional failure

Wrap it with try-catch since stack-overflow RangeError in JS can happen.

stress/copy-data-properties-fast-path.js:

2:12 AM Changeset in webkit [272831] by ysuzuki@apple.com

9 edits
1 copy
1 add
2 deletes in trunk/Source

[JSC] Enable JITCage on macOS
https://bugs.webkit.org/show_bug.cgi?id=221805
<rdar://problem/74153806>

Reviewed by Mark Lam.

Source/JavaScriptCore:

We enable JITCage too on macOS if it is ARM64E.
We need to add this entitlement only when building it on macOS 120000 or higher version.
Otherwise, we cannot launch the process. This means that we need to dynamically generate entitlements file
because we must not attach this entitlement when building JSC for non 120000 macOS.

This patch follows r248164's way: we must not use CODE_SIGN_ENTITLEMENTS because XCode inserts implicit code-signing
and it breaks our pipeline. We need to disable this XCode's implicit behavior by setting CODE_SIGN_INJECT_BASE_ENTITLEMENTS.

And we also create TestAPI.xcconfig to apply generated entitlements only to testapi and jsc shell.

Configurations/Base.xcconfig:
Configurations/JSC.xcconfig:
Configurations/TestAPI.xcconfig: Copied from Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig.
Configurations/ToolExecutable.xcconfig:
JavaScriptCore.xcodeproj/project.pbxproj:
Scripts/process-entitlements.sh: Added.
allow-jit-macOS.entitlements: Removed.
testapi.entitlements: Removed.

Source/WebKit:

We need to add this entitlement only when building it on macOS 120000 or higher version.
Otherwise, we cannot launch the process. And we attach this entitlement only when building processes
with Apple Internal SDKs.

Scripts/process-entitlements.sh:

Source/WTF:

Enable JIT_CAGE when macOS is 120000 or higher with ARM64E.

wtf/PlatformEnable.h:

Feb 12, 2021:

9:30 PM Changeset in webkit [272830] by mark.lam@apple.com

8 edits in trunk/Source/JavaScriptCore

Rename slotVisitor variables to visitor.
https://bugs.webkit.org/show_bug.cgi?id=221866

Reviewed by Yusuke Suzuki.

In existing code, we sometimes name a SlotVisitor instance slotVisitor and
sometimes just visitor. This patch makes it so that we use visitor consistently
everywhere. This will also reduce the size of the GC verifier patch later.

Also fixed a few typos in comments.

This is a pure refactoring patch. There are no behavior changes.

API/JSMarkingConstraintPrivate.cpp:

(JSContextGroupAddMarkingConstraint):

bytecode/RecordedStatuses.cpp:

(JSC::RecordedStatuses::visitAggregate):
(JSC::RecordedStatuses::markIfCheap):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::blocksInPostOrder):

heap/Heap.cpp:

(JSC::Heap::runBeginPhase):
(JSC::Heap::runFixpointPhase):
(JSC::Heap::runConcurrentPhase):
(JSC::Heap::stopThePeriphery):
(JSC::Heap::resumeThePeriphery):
(JSC::Heap::addCoreConstraints):
(JSC::Heap::performIncrement):

heap/HeapInlines.h:

(JSC::Heap::forEachSlotVisitor):

runtime/JSSegmentedVariableObject.cpp:

(JSC::JSSegmentedVariableObject::visitChildren):

runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::visit):

8:36 PM Changeset in webkit [272829] by jer.noble@apple.com

7 edits
2 adds in trunk

[Mac] Sound does not play on YouTube after switching back to foreground
https://bugs.webkit.org/show_bug.cgi?id=221858
<rdar://70602677>

Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/mac/media/unmute-after-loading.html

Remove a stray, unnecessary reset of a cached muted state which kept mute
state from being changed the first time after loading.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):

testing/Internals.cpp:

(WebCore::Internals::privatePlayerMuted):

testing/Internals.h:
testing/Internals.idl:
testing/Internals.mm:

(WebCore::Internals::privatePlayerMuted):

LayoutTests:

platform/mac/media/unmute-after-loading-expected.txt: Added.
platform/mac/media/unmute-after-loading.html: Added.

6:16 PM Changeset in webkit [272828] by Chris Dumez

42 edits in trunk

Reduce explicit usage of [objC release] in WebKit
https://bugs.webkit.org/show_bug.cgi?id=221780
<rdar://problem/74282389>

Reviewed by Darin Adler.

Apply review feedback from Darin Adler and Sam Weinig after r272789.

Source/WebCore:

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(if):

editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_addLinkForElement):
(HTMLConverter::_processElement):
(HTMLConverter::_addMarkersToList):

platform/ios/WebCoreMotionManager.mm:

(-[WebCoreMotionManager initializeOnMainThread]):

platform/network/ios/NetworkStateNotifierIOS.mm:

Source/WebKit:

UIProcess/Inspector/ios/WKInspectorHighlightView.h:
UIProcess/ios/WKScrollView.mm:
UIProcess/mac/WebColorPickerMac.mm:

(+[WKPopoverColorWell _colorPopoverCreateIfNecessary:]):

WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:

(-[WKAccessibilityWebPageObjectBase setRemoteParent:]):

Source/WebKitLegacy/ios:

WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder _updateTitleForDocumentIfAvailable]):

Source/WebKitLegacy/mac:

DOM/DOMUIKitExtensions.mm:

(-[DOMNode absoluteQuads]):
(-[DOMHTMLAreaElement absoluteQuadsWithOwner:]):

DOM/ExceptionHandlers.mm:

(raiseDOMErrorException):

DefaultDelegates/WebDefaultUIDelegate.mm:

(-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):

History/WebHistory.mm:

(-[WebHistoryPrivate visitedURL:withTitle:]):
(-[WebHistory _visitedURL:withTitle:method:wasFailure:]):

History/WebHistoryItem.mm:

(-[WebHistoryItem initFromDictionaryRepresentation:]):

Misc/WebNSDataExtras.mm:

(-[NSData _webkit_parseRFC822HeaderFields]):

Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):

Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::performRequest):

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::createWindow):
(WebChromeClient::addMessageToConsole):

WebCoreSupport/WebEditorClient.mm:

(attributesForAttributedStringConversion):

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::actionDictionary const):
(WebFrameLoaderClient::createFrame):

WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:]):
(-[WebInspectorWindowController window]):

WebView/WebDataSource.mm:

(-[WebDataSource _documentFragmentWithArchive:]):
(-[WebDataSource _makeRepresentation]):

WebView/WebFrame.mm:
WebView/WebFrameView.mm:
WebView/WebHTMLView.mm:

(-[WebHTMLView _updateMouseoverWithEvent:]):

WebView/WebNavigationData.mm:
WebView/WebPDFRepresentation.mm:

(-[WebPDFRepresentation finishedLoadingWithDataSource:]):

WebView/WebPDFView.mm:

(-[WebPDFView _menuItemsFromPDFKitForEvent:]):

WebView/WebPolicyDelegate.mm:
WebView/WebScriptDebugger.mm:

(WebScriptDebugger::sourceParsed):

WebView/WebView.mm:

(-[WebView _openNewWindowWithRequest:]):

WebView/WebWindowAnimation.h:
WebView/WebWindowAnimation.mm:

(-[WebWindowScaleAnimation setSubAnimation:]):

Tools:

DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::addChromeInputField):

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::addChromeInputField):

5:48 PM Changeset in webkit [272827] by commit-queue@webkit.org

10 edits
5 adds
5 deletes in trunk/LayoutTests

[LayoutTests] Convert http/tests/mime convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=221737

<rdar://problem/74219024>

Patch by Chris Gambrell <Chris Gambrell> on 2021-02-12
Reviewed by Jonathan Bedard.

http/tests/mime/quoted-charset.php: Removed.
http/tests/mime/quoted-charset.py: Added.
http/tests/mime/resources/style-with-charset.php: Removed.
http/tests/mime/resources/style-with-charset.py: Added.
http/tests/mime/resources/style-with-text-css-and-invalid-type.php: Removed.
http/tests/mime/resources/style-with-text-css-and-invalid-type.py: Added.
http/tests/mime/resources/style-with-text-plain.php: Removed.
http/tests/mime/resources/style-with-text-plain.py: Added.
http/tests/mime/resources/uppercase-mime-type.php: Removed.
http/tests/mime/resources/uppercase-mime-type.py: Added.
http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt:
http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension.html:
http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt:
http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain.html:
http/tests/mime/standard-mode-loads-stylesheet-with-charset-and-css-extension.html:
http/tests/mime/standard-mode-loads-stylesheet-with-charset.html:
http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html:
http/tests/mime/uppercase-mime-type-expected.txt:
http/tests/mime/uppercase-mime-type.html:

5:40 PM Changeset in webkit [272826] by jiewen_tan@apple.com

6 edits in trunk

[WebAuthn] Provide SPI to query local credentials
https://bugs.webkit.org/show_bug.cgi?id=221743
<rdar://problem/65849832>

Reviewed by Brent Fulgham.

Source/WebKit:

Covered by API tests.

UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(getAllLocalAuthenticatorCredentialsImpl):
(+[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentials]):
(+[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentialsWithAccessGroup:]):
(+[_WKWebAuthenticationPanel deleteLocalAuthenticatorCredentialWithID:]):

UIProcess/API/Cocoa/_WKWebAuthenticationPanelForTesting.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(TestWebKitAPI::TEST):

5:27 PM Changeset in webkit [272825] by mark.lam@apple.com

4 edits in trunk/Source/JavaScriptCore

Remove some unused methods in MarkedBlock and PreciseAllocation.
https://bugs.webkit.org/show_bug.cgi?id=221864

Reviewed by Yusuke Suzuki.

heap/MarkedBlock.h:

(JSC::MarkedBlock::Handle::visitWeakSet): Deleted.
(JSC::MarkedBlock::Handle::reapWeakSet): Deleted.

heap/PreciseAllocation.cpp:

(JSC::PreciseAllocation::shrink): Deleted.
(JSC::PreciseAllocation::visitWeakSet): Deleted.
(JSC::PreciseAllocation::reapWeakSet): Deleted.

heap/PreciseAllocation.h:

4:32 PM Changeset in webkit [272824] by achristensen@apple.com

3 edits in trunk/LayoutTests

REGRESSION (r272784): [macOS Release] fast/animation/request-animation-frame-throttling-lowPowerMode.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=221843

Reviewed by Chris Dumez.

Something about r272784 subtly changed timing, which caused there to be a little bit of a lag in RAF throttling.
I could reproduce it making the way this test measures frame rate go up to 35, but not 36.
This test is still good, though, because if you remove setLowPowerModeEnabled it spikes up to 60 or 61 frames per second.

fast/animation/request-animation-frame-throttling-lowPowerMode-expected.txt:
fast/animation/request-animation-frame-throttling-lowPowerMode.html:

4:32 PM Changeset in webkit [272823] by msaboff@apple.com

10 edits
1 add in trunk

[ARM64e] Harden Mach exception handling
https://bugs.webkit.org/show_bug.cgi?id=221841

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Split wasm_throw_from_fault_handler_trampoline into two trampolines to eliminate the
need to pass a register argument to signify if we are using FastTLS. With this change
we don't need to modify registers besides the PC when handling exceptions.
Added sanity checks to make sure handlers are being called for the exceptions they
were registered for.

bytecode/BytecodeList.rb:
llint/WebAssembly.asm:
runtime/VMTraps.cpp:
signal: Added.
tools/SigillCrashAnalyzer.cpp:

(JSC::installCrashHandler):

wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):

Source/WTF:

For Darwin ARM64e platforms, we check to make sure that all thread state besides the PC hasn't
been modified by an exception handler.

wtf/threads/Signals.cpp:

(WTF::hashThreadState):

Tools:

Updated test to check that the exception type matches the one we registered for.

TestWebKitAPI/Tests/WTF/Signals.cpp:

(TEST):

4:29 PM Changeset in webkit [272822] by jer.noble@apple.com

8 edits
3 adds in trunk

[Mac] Unable to play WebM/Opus generated from Chrome MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=221808

Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/mac-bigsur/media/media-webm-no-duration.html

In the absense of an explicit decode timestamp, CoreMedia convention is to use
the presentation timestamp instead.

All fields in the CoreAudioOpusHeader must be byte-swapped.

platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::MediaSampleAVFObjC::decodeTime const):

platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm:

(WebCore::cookieFromOpusCodecPrivate):

Source/WebKit:

In the absense of an explicit duration parsed from the InitializationSegment,
rely instead on the maximum presentation timestamp available in any MediaTrackReader
to generate an explicit duration.

Shared/mac/MediaFormatReader/MediaFormatReader.cpp:

(WebKit::MediaFormatReader::finishParsing):
(WebKit::MediaFormatReader::copyProperty):

Shared/mac/MediaFormatReader/MediaTrackReader.cpp:

(WebKit::MediaTrackReader::greatestPresentationTime const):

Shared/mac/MediaFormatReader/MediaTrackReader.h:

LayoutTests:

platform/mac-bigsur/media/media-webm-no-duration-expected.txt: Added.
platform/mac-bigsur/media/media-webm-no-duration.html: Added.

3:52 PM Changeset in webkit [272821] by don.olmstead@sony.com

3 edits in trunk/Tools

[Python-3] Use pathlib to generate file:// urls
https://bugs.webkit.org/show_bug.cgi?id=221850

Reviewed by Jonathan Bedard.

Use pathlib which can generate file:// urls for *nix and Windows. The previous logic
only worked on *nix.

Add the pathlib backport for 2.7.

Scripts/webkitpy/init.py:
Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SVNTestRepository.setup):
(SVNTestRepository._setup_mock_repo):

3:49 PM Changeset in webkit [272820] by don.olmstead@sony.com

2 edits in trunk/Tools

[Python-3] base64.encodestring is deprecated
https://bugs.webkit.org/show_bug.cgi?id=221842

Reviewed by Jonathan Bedard.

In Python 3.9 base64.encodestring was completely removed. Replacing with base64.b64encode
which works in Python 2/3 and is used by the code being tested.

Scripts/webkitpy/w3c/wpt_github_unittest.py:

(WPTGitHubTest.test_auth_token):

3:46 PM Changeset in webkit [272819] by don.olmstead@sony.com

2 edits in trunk/Tools

Run additional webkitpy tests on Windows by default
https://bugs.webkit.org/show_bug.cgi?id=221851

Reviewed by Jonathan Bedard.

The tests in WebKit/Scripts and webkitpy.common.config pass on Windows.

The WebKit/Scripts tests are not run when using Cygwin. Without any port option its
the only way to differentiate WinCairo, which doesn't use Cygwin, and AppleWin, which
does.

Scripts/webkitpy/test/main.py:

3:35 PM Changeset in webkit [272818] by Ryan Haddad

2 edits in trunk/LayoutTests

[ Big Sur ] media/media-source/media-source-webm-init-inside-segment.html is failing
https://bugs.webkit.org/show_bug.cgi?id=220552

Unreviewed test gardening.

platform/mac-wk1/TestExpectations: Skip the test for WK1.

3:29 PM Changeset in webkit [272817] by Ryan Haddad

2 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is timing out on Catalina wk1 debug EWS
https://bugs.webkit.org/show_bug.cgi?id=206503

Unreviewed test gardening.

platform/mac-wk1/TestExpectations: Changed expectation from Mojave to Catalina to suppress failure.

3:06 PM Changeset in webkit [272816] by Ryan Haddad

2 edits in trunk/Source/WebKit

Unreviewed, reverting r272799.

Caused debug WK2 tests to exit early with an assertion failure

Reverted changeset:

"Unexpected ASSERT when touch events are dispatched on the
main thread"
https://bugs.webkit.org/show_bug.cgi?id=221832
https://commits.webkit.org/r272799

3:05 PM Changeset in webkit [272815] by Ryan Haddad

2 edits in trunk/Tools

REGRESSION (r268421): TestWebKitAPI.WebKit.PreferenceChanges* tests are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=221848

Unreviewed test gardening.

TestWebKitAPI.WebKit.GlobalPreferenceChangesUsingDefaultsWrite is also flaky, so disable it for Big Sur.

TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:

3:03 PM Changeset in webkit [272814] by Dewei Zhu

2 edits in trunk/Websites/perf.webkit.org

'sync-commits.py' should be able to limit reporting scope to a specific branch on a Git repository.
https://bugs.webkit.org/show_bug.cgi?id=221799

Reviewed by Ryosuke Niwa.

Fetching git commits with 'git log --all ...' may end up fetching commits from branches created for
pull requests. Add 'branch' variable to allow us to limit to a certain branch.

tools/sync-commits.py: Added 'branch' variable to GitRepository so that we can fetch from a specific branch.

If branch is not specified, it will still use '--all' to list commits.
(load_repository):
(GitRepository.init):
(GitRepository._fetch_all_hashes):

2:29 PM Changeset in webkit [272813] by commit-queue@webkit.org

3 edits in trunk/Websites/perf.webkit.org

perf.webkit.org/tools/js/analysis-results-notifier.js should allow sending of completion emails regardless of test name
https://bugs.webkit.org/show_bug.cgi?id=221712

Patch by Roy Reapor <rreapor@apple.com> on 2021-02-12
Reviewed by Dewei Zhu.

Rule platforms and tests can be undefined, an empty array, or an array of strings. Undefined will match everything.
Empty array will match nothing. Array of strings will match items in the array.

Rule will not match if either tests or platforms is an empty array.

tools/js/analysis-results-notifier.js:

(AnalysisResultsNotifier._validateRules.isUnderfinedOrEmptyArrayOrArrayOfStrings):

platforms and tests can now be undefined or an empty array officially

(AnalysisResultsNotifier._validateRules):

switched to assert.ok(). console.assert() no longer throws since node v10 (https://github.com/facebook/jest/issues/5634)
both rule platforms and tests must pass isUnderfinedOrEmptyArrayOrArrayOfStrings(). previously, rules like {tests: [1, 3], platforms: ['speedometer']} passes validation.

(AnalysisResultsNotifier._applyUpdate):

switched to assert.ok(). console.assert() no longer throws since node v10 (https://github.com/facebook/jest/issues/5634)

(AnalysisResultsNotifier._validateRules.isNonemptyArrayOfStrings): Deleted.

unit-tests/analysis-results-notifier-tests.js:
added a bunch of unittests
specify the exact regex match for assert.throws() and assert.doesNotThrow() argument.

2:13 PM Changeset in webkit [272812] by commit-queue@webkit.org

25 edits
3 adds
3 deletes in trunk/LayoutTests

[LayoutTests] Convert http/tests/storageAccess convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=221720
<rdar://problem/74207513>

Patch by Chris Gambrell <Chris Gambrell> on 2021-02-12
Reviewed by Jonathan Bedard.

http/tests/storageAccess/aggregate-sorted-data-with-storage-access.html:
http/tests/storageAccess/deny-due-to-no-interaction-under-general-third-party-cookie-blocking-ephemeral.html:
http/tests/storageAccess/deny-due-to-no-interaction-under-general-third-party-cookie-blocking.html:
http/tests/storageAccess/deny-storage-access-under-opener-ephemeral.html:
http/tests/storageAccess/deny-storage-access-under-opener-if-auto-dismiss-ephemeral.html:
http/tests/storageAccess/deny-storage-access-under-opener-if-auto-dismiss.html:
http/tests/storageAccess/deny-storage-access-under-opener.html:
http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture-ephemeral.html:
http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture.html:
http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking.html:
http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral.html:
http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies.html:
http/tests/storageAccess/has-storage-access-under-general-third-party-cookie-blocking-with-cookie-ephemeral.html:
http/tests/storageAccess/has-storage-access-under-general-third-party-cookie-blocking-with-cookie.html:
http/tests/storageAccess/request-and-grant-access-cross-origin-non-sandboxed-iframe-ephemeral.html:
http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-and-access-from-right-frame.html:
http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-but-access-from-wrong-frame.html:
http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe.html:
http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html:
http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html:
http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html:
http/tests/storageAccess/request-and-grant-access-with-per-page-scope-access-from-another-frame.html:
http/tests/storageAccess/resources/echo-incoming-cookies-as-json.php: Removed.
http/tests/storageAccess/resources/echo-incoming-cookies-as-json.py: Added.
http/tests/storageAccess/resources/get-cookies.php: Removed.
http/tests/storageAccess/resources/get-cookies.py: Added.
http/tests/storageAccess/resources/has-storage-access-iframe.html:
http/tests/storageAccess/resources/request-storage-access-iframe.html:
http/tests/storageAccess/resources/set-cookie.php: Removed.
http/tests/storageAccess/resources/set-cookie.py: Added.

2:07 PM Changeset in webkit [272811] by stephan.szabo@sony.com

2 edits in trunk/Source/WebCore

[PlayStation][Debug] Build fix after r272772
https://bugs.webkit.org/show_bug.cgi?id=221836

Unreviewed Build Fix

platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

2:01 PM Changeset in webkit [272810] by youenn@apple.com

2 edits in trunk/Source/WebKit

Enable video capture in GPUProcess by default on MacOS
https://bugs.webkit.org/show_bug.cgi?id=221750

Reviewed by Eric Carlson.

Manually tested.

Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCaptureVideoInGPUProcessEnabled):

1:53 PM Changeset in webkit [272809] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Multiline inline boxes have incorrect content box height/width values
https://bugs.webkit.org/show_bug.cgi?id=221827

Reviewed by Antti Koivisto.

Exclude padding and borders when computing the content box size for a multiline inline box.
(This is similar to r272724 but with inline boxes spanning multiple lines.)

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

1:52 PM Changeset in webkit [272808] by jer.noble@apple.com

2 edits in trunk/Source/WebKit

[Mac] Update Opus setting after a preference change.
https://bugs.webkit.org/show_bug.cgi?id=221807

Reviewed by Eric Carlson.

Make the opusDecoderEnabled() setting dynamic by applying changes
to that setting after a preference update.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

1:49 PM Changeset in webkit [272807] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Fix Windows build again after r272772
https://bugs.webkit.org/show_bug.cgi?id=221765

Unreviewed.

No new tests because there is no behavior change.

platform/graphics/win/FontCGWin.cpp:

(WebCore::FontCascade::drawGlyphs):

1:35 PM Changeset in webkit [272806] by youenn@apple.com

11 edits in trunk/Source/WebKit

Remote video capture samples should be processed in a background thread
https://bugs.webkit.org/show_bug.cgi?id=221201
<rdar://problem/73826816>

Reviewed by Eric Carlson.

Make RemoteRealtimeVideoSource register to RemoteCaptureSampleManager to get video samples from a background thread.
Make RemoteCaptureSampleManager able to handle incoming video samples in background thread like for audio.
Make UserMediaCaptureManagerProxy use RemoteCaptureSampleManager instead of UserMediaCaptureManager message.
Covered by existing tests.

UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
WebProcess/cocoa/RemoteCaptureSampleManager.cpp:

(WebKit::RemoteCaptureSampleManager::addSource):
(WebKit::RemoteCaptureSampleManager::removeSource):
(WebKit::RemoteCaptureSampleManager::audioStorageChanged):
(WebKit::RemoteCaptureSampleManager::audioSamplesAvailable):
(WebKit::RemoteCaptureSampleManager::videoSampleAvailable):
(WebKit::RemoteCaptureSampleManager::RemoteVideo::RemoteVideo):
(WebKit::RemoteCaptureSampleManager::RemoteVideo::videoSampleAvailable):

WebProcess/cocoa/RemoteCaptureSampleManager.h:
WebProcess/cocoa/RemoteCaptureSampleManager.messages.in:
WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:

(WebKit::RemoteRealtimeVideoSource::create):
(WebKit::RemoteRealtimeVideoSource::videoSampleAvailable):
(WebKit::RemoteRealtimeVideoSource::remoteVideoSampleAvailable): Deleted.

WebProcess/cocoa/RemoteRealtimeVideoSource.h:
WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::remoteVideoSampleAvailable): Deleted.

WebProcess/cocoa/UserMediaCaptureManager.h:
WebProcess/cocoa/UserMediaCaptureManager.messages.in:

1:31 PM Changeset in webkit [272805] by mmaxfield@apple.com

75 edits in trunk/Source/WebCore

enum LengthType -> enum class LengthType
https://bugs.webkit.org/show_bug.cgi?id=221834

Reviewed by Sam Weinig and Simon Fraser.

iPhoneOS14.2.sdk/usr/include/MacTypes.h:193 has:

typedef SInt32 Fixed;

but we have:

enum LengthType {

... Fixed ...

}

This leads to: error: reference to 'Fixed' is ambiguous

Unfortunately, this error occurs in
/System/Library/Frameworks/CoreText.framework/Headers/SFNTLayoutTypes.h,
which means we can't modify the error site to qualify the name. Therefore,
the best solution is to turn enum LengthType into enum class LengthType.
This is in accordance with WebKit's style guide.

No new tests because there is no behavior change.

animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

css/BasicShapeFunctions.cpp:

(WebCore::convertToLengthSize):
(WebCore::convertToCenterCoordinate):

css/CSSBasicShapes.cpp:

(WebCore::buildSerializablePositionOffset):

css/CSSCalculationValue.cpp:

(WebCore::CSSCalcPrimitiveValueNode::createCalcExpression const):
(WebCore::createCSS):

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::computeLength const):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength const):

css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapNinePieceImageSlice):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):

css/LengthFunctions.cpp:

(WebCore::valueForLength):
(WebCore::floatValueForLength):

css/LengthFunctions.h:

(WebCore::minimumValueForLength):

css/TransformFunctions.cpp:

(WebCore::convertToFloatLength):
(WebCore::transformsForValue):
(WebCore::translateForValue):

display/css/DisplayFillLayerImageGeometry.cpp:

(WebCore::Display::calculateImageIntrinsicDimensions):

dom/Document.cpp:

(WebCore::Document::updateLayoutIfDimensionsOutOfDate):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::createInnerTextStyle):

html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::adjustMinWidth const):

html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::adjustMinWidth const):

html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::resolveCustomStyle):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::buildLayoutTree):
(WebCore::Layout::TreeBuilder::createLayoutBox):

page/FrameView.cpp:

(WebCore::FrameView::performFixedWidthAutoSize):

page/IntersectionObserver.cpp:

(WebCore::parseRootMargin):
(WebCore::IntersectionObserver::rootMargin const):

platform/Length.cpp:

(WebCore::parseLength):
(WebCore::Length::Length):
(WebCore::convertTo100PercentMinusLength):
(WebCore::blend):
(WebCore::operator<<):

platform/Length.h:

(WebCore::Length::Length):
(WebCore::Length::operator=):
(WebCore::Length::setValue):
(WebCore::Length::isAuto const):
(WebCore::Length::isFixed const):
(WebCore::Length::isMaxContent const):
(WebCore::Length::isMinContent const):
(WebCore::Length::isPercent const):
(WebCore::Length::isRelative const):
(WebCore::Length::isUndefined const):
(WebCore::Length::isCalculated const):
(WebCore::Length::isLegacyIntrinsic const):
(WebCore::Length::isIntrinsic const):
(WebCore::Length::isFillAvailable const):
(WebCore::Length::isFitContent const):
(WebCore::Length::isMinIntrinsic const):

platform/LengthBox.h:

(WebCore::LengthBox::LengthBox):

platform/Theme.cpp:

(WebCore::Theme::minimumControlSize const):

platform/graphics/Image.cpp:

(WebCore::Image::computeIntrinsicDimensions):

platform/graphics/transforms/PerspectiveTransformOperation.cpp:

(WebCore::PerspectiveTransformOperation::blend):

platform/graphics/transforms/TranslateTransformOperation.cpp:

(WebCore::TranslateTransformOperation::blend):

platform/graphics/transforms/TranslateTransformOperation.h:
platform/mac/ThemeMac.mm:

(WebCore::sizeFromNSControlSize):
(WebCore::ThemeMac::minimumControlSize const):

rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):

rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::calculateGridTrackSize const):

rendering/RenderBlockFlow.cpp:

(WebCore::isNonBlocksOrNonFixedHeightListItems):
(WebCore::getBPMWidth):

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalWidthInFragmentByMinMax const):
(WebCore::RenderBox::constrainLogicalHeightByMinMax const):
(WebCore::RenderBox::adjustBorderBoxLogicalWidthForBoxSizing const):
(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing const):
(WebCore::RenderBox::computeLogicalWidthInFragment const):
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing const):
(WebCore::RenderBox::sizesLogicalWidthToFitContent const):
(WebCore::RenderBox::computeInlineDirectionMargins const):
(WebCore::RenderBox::computeLogicalHeight const):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing const):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth const):
(WebCore::RenderBox::computePositionedLogicalWidthUsing const):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeightUsing const):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced const):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced const):
(WebCore::RenderBox::percentageLogicalHeightIsResolvable const):

rendering/RenderButton.cpp:

(WebCore::RenderButton::updateAnonymousChildStyle const):

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

rendering/RenderElement.cpp:

(WebCore::includeNonFixedHeight):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution):

rendering/RenderFullScreen.cpp:

(WebCore::createFullScreenStyle):

rendering/RenderImage.cpp:

(WebCore::RenderImage::layoutShadowContent):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

rendering/RenderLayerBacking.cpp:

(WebCore::hasNonZeroTransformOrigin):

rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::updateMargins):

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::adjustInnerStyle):

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalWidthFromColumns const):

rendering/RenderTableSection.cpp:

(WebCore::updateLogicalHeightForCell):

rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::layoutExcludedChildren):

rendering/RenderTextControlSingleLine.cpp:

(WebCore::resetOverriddenHeight):
(WebCore::RenderTextControlSingleLine::layout):

rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::adjustApplePayButtonStyle const):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::setSizeFromFont const):
(WebCore::RenderThemeMac::adjustListButtonStyle const):
(WebCore::RenderThemeMac::adjustMenuListStyle const):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle const):
(WebCore::RenderThemeMac::adjustSearchFieldStyle const):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle const):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationPartStyle const):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationPartStyle const):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle const):
(WebCore::RenderThemeMac::adjustSliderThumbSize const):

rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeCenterCoordinate::updateComputedLength):

rendering/style/BasicShapes.h:

(WebCore::BasicShapeRadius::BasicShapeRadius):

rendering/style/BorderData.h:

(WebCore::BorderData::BorderData):

rendering/style/FillLayer.h:

(WebCore::FillLayer::initialFillXPosition):
(WebCore::FillLayer::initialFillYPosition):

rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::GridTrackSize):

rendering/style/NinePieceImage.h:
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setPageScaleTransform):
(WebCore::RenderStyle::setWordSpacing):

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::resetMargin):
(WebCore::RenderStyle::initialShapeMargin):
(WebCore::RenderStyle::initialBorderRadius):
(WebCore::RenderStyle::initialObjectPosition):
(WebCore::RenderStyle::initialWordSpacing):
(WebCore::RenderStyle::initialMaxSize):
(WebCore::RenderStyle::initialMargin):
(WebCore::RenderStyle::initialPadding):
(WebCore::RenderStyle::initialTextIndent):
(WebCore::RenderStyle::initialZeroLength):
(WebCore::RenderStyle::initialOneLength):
(WebCore::RenderStyle::initialLineHeight):
(WebCore::RenderStyle::initialFlexBasis):
(WebCore::RenderStyle::initialMarqueeIncrement):
(WebCore::RenderStyle::initialTransformOriginX):
(WebCore::RenderStyle::initialTransformOriginY):
(WebCore::RenderStyle::initialPerspectiveOriginX):
(WebCore::RenderStyle::initialPerspectiveOriginY):
(WebCore::RenderStyle::initialSpecifiedLineHeight):
(WebCore::RenderStyle::initialScrollMargin):
(WebCore::RenderStyle::initialScrollPadding):
(WebCore::RenderStyle::initialGridAutoColumns):
(WebCore::RenderStyle::initialGridAutoRows):
(WebCore::RenderStyle::setBorderRadius):

rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):

rendering/style/StyleRareNonInheritedData.h:
rendering/style/StyleReflection.h:

(WebCore::StyleReflection::StyleReflection):

rendering/style/StyleSurroundData.cpp:

(WebCore::StyleSurroundData::StyleSurroundData):

rendering/updating/RenderTreeBuilderFullScreen.cpp:

(WebCore::RenderTreeBuilder::FullScreen::createPlaceholder):

style/StyleAdjuster.cpp:

(WebCore::Style::addIntrinsicMargins):
(WebCore::Style::Adjuster::adjust const):
(WebCore::Style::Adjuster::adjustForTextAutosizing):

style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertLength):
(WebCore::Style::BuilderConverter::convertLengthOrAuto):
(WebCore::Style::BuilderConverter::convertLengthSizing):
(WebCore::Style::BuilderConverter::convertLengthMaxSizing):
(WebCore::Style::BuilderConverter::convertToRadiusLength):
(WebCore::Style::BuilderConverter::convertRadius):
(WebCore::Style::BuilderConverter::convertTo100PercentMinusLength):
(WebCore::Style::BuilderConverter::convertPositionComponent):
(WebCore::Style::BuilderConverter::createGridTrackBreadth):
(WebCore::Style::BuilderConverter::convertWordSpacing):
(WebCore::Style::BuilderConverter::convertLineHeight):

style/StyleBuilderCustom.h:

(WebCore::Style::ApplyPropertyBorderImageModifier::applyInitialValue):

style/StyleBuilderState.cpp:

(WebCore::Style::BuilderState::createFilterOperations):

style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

style/StyleResolveForFontRaw.cpp:

(WebCore::Style::resolveForFontRaw):

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::intrinsicWidth const):
(WebCore::SVGSVGElement::intrinsicHeight const):

1:26 PM Changeset in webkit [272804] by Aditya Keerthi

3 edits in trunk/Source/WebKit

[tvOS] Fix build failure in WKFormSelectPicker
https://bugs.webkit.org/show_bug.cgi?id=221839
<rdar://problem/74287348>

Reviewed by Wenson Hsieh.

UITableViewStyleInsetGrouped is not available on tvOS. Rather than
have two separate codepaths, we can just use UITableViewStyleGrouped
with sectionContentInsetFollowsLayoutMargins set to YES.

Platform/spi/ios/UIKitSPI.h:
UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKSelectPickerTableViewController initWithView:]):

1:22 PM Changeset in webkit [272803] by don.olmstead@sony.com

2 edits in trunk/Tools

webkitpy.xcode only relevant for darwin platforms
https://bugs.webkit.org/show_bug.cgi?id=221837

Reviewed by Jonathan Bedard.

The tests in webkitpy.xcode are Darwin specific and should only run on that platform.

This issue was discovered when running the tests with Python 3 on Windows which failed
a number of tests in the suite. These tests may run successfully on *nix platforms but
aren't actually relevant.

Scripts/webkitpy/test/main.py:

1:10 PM Changeset in webkit [272802] by youenn@apple.com

5 edits in trunk/Source/WebKit

Test landed flaky: [iOS] TestWebKitAPI.WebKit2.CrashGPUProcessWhileCapturing
https://bugs.webkit.org/show_bug.cgi?id=221331
<rdar://problem/73935129>

Reviewed by Eric Carlson.

Now that RemoteRealtimeVideoSource is a RealtimeVideoCaptureSource, we can register RemoteRealtimeVideoSource
to its factory so that it will be muted if another RemoteRealtimeVideoSource is created.
This is now possible as clones of the track will get the same underlying RemoteRealtimeVideoSource.
We can thus only recreate the active source when GPU process crashes.
Covered by test no longer flaky.

WebProcess/cocoa/RemoteRealtimeAudioSource.cpp:

(WebKit::RemoteRealtimeAudioSource::gpuProcessConnectionDidClose):

WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:

(WebKit::RemoteRealtimeVideoSource::gpuProcessConnectionDidClose):

WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::VideoFactory::setActiveSource): Deleted.

WebProcess/cocoa/UserMediaCaptureManager.h:

1:01 PM Changeset in webkit [272801] by Antti Koivisto

3 edits in trunk/LayoutTests

[LFC][Integration] Make accessibility/aria-modal-in-aria-hidden.html more robust
https://bugs.webkit.org/show_bug.cgi?id=221812

Reviewed by Zalan Bujtas.

It is very dependent on exact interactions between the internal testing API and the DOM.
It also seems to be partially testing a wrong thing (probably as workaround for above).

accessibility/aria-modal-in-aria-hidden-expected.txt:
accessibility/aria-modal-in-aria-hidden.html:

Do rendering update between every mutation and check, not just the last one.
Fix the middle test to use isIgnored too.
(isValid() is not even a function, it is a property, so this relied on getting null to pass)

12:38 PM Changeset in webkit [272800] by Jonathan Bedard

5 edits in trunk/Tools

[webkit-patch] Post both revision and identifier to bugzilla
https://bugs.webkit.org/show_bug.cgi?id=221829
<rdar://problem/74282619>

Reviewed by Aakash Jain.

Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/comments.py:

(bug_comment_from_svn_revision): Include subversion revision.

Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:

(CloseBugForLandDiffTest.test_empty_state):

12:25 PM Changeset in webkit [272799] by dino@apple.com

2 edits in trunk/Source/WebKit

Unexpected ASSERT when touch events are dispatched on the main thread
https://bugs.webkit.org/show_bug.cgi?id=221832
<rdar://problem/74283856>

Reviewed by Sam Weinig.

The change in r272558 causes an ASSERT when running on iOS debug
builds. The touch event CompletionHandlers are created on the EventDispatcher
thread, but serviced on the main thread. We now need to state that this
is ok as we create the CompletionHandler.

This is covered by tests, but the EWS bots don't run iOS tests in
debug mode, and the internal bots hadn't caught up yet!

Platform/IPC/HandleMessage.h:

(IPC::handleMessageAsync): Pass a CompletionHandlerCallThread into the constructor.

11:43 AM Changeset in webkit [272798] by Truitt Savell

2 edits in trunk/LayoutTests

REGRESSION (r272241) [MacOS wk1] imported/w3c/web-platform-tests/css/css-flexbox/overflow-auto-006.html is flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=221347

Unreviewed test gardening.

Patch by Amir Mark Jr <Amir Mark Jr.> on 2021-02-12

platform/mac-wk1/TestExpectations:

11:25 AM Changeset in webkit [272797] by mark.lam@apple.com

11 edits
1 add in trunk/Source

Move RootMarkReason out of SlotVisitor.
https://bugs.webkit.org/show_bug.cgi?id=221831

Reviewed by Tadeu Zagallo.

Source/JavaScriptCore:

This will lessen the amount of diff needed for the GC verifier later.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/Heap.cpp:

(JSC::Heap::addCoreConstraints):

heap/HeapAnalyzer.h:
heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::analyzeEdge):
(JSC::rootTypeToString):

heap/HeapSnapshotBuilder.h:
heap/RootMarkReason.h: Added.
heap/SlotVisitor.h:

(JSC::SetRootMarkReasonScope::SetRootMarkReasonScope):

inspector/JSInjectedScriptHost.cpp:

Source/WebCore:

bindings/js/DOMGCOutputConstraint.cpp:

(WebCore::DOMGCOutputConstraint::executeImpl):

11:15 AM Changeset in webkit [272796] by Brent Fulgham

2 edits in trunk/Source/WebKit

[macOS] Limit mech-register to required services
https://bugs.webkit.org/show_bug.cgi?id=221768
<rdar://problem/70350150>

Reviewed by Per Arne Vollan.

Limit mach-register to the two cases identified by telemetry.

WebProcess/com.apple.WebProcess.sb.in:

11:10 AM Changeset in webkit [272795] by svillar@igalia.com

8 edits
7 adds
2 deletes in trunk/LayoutTests

[css-flexbox] Another WPT test import
https://bugs.webkit.org/show_bug.cgi?id=221813

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

web-platform-tests/css/css-flexbox/flexbox-min-width-auto-005-expected.html: Added.
web-platform-tests/css/css-flexbox/flexbox-min-width-auto-005.html: Added.
web-platform-tests/css/css-flexbox/flexbox-min-width-auto-006-expected.html: Added.
web-platform-tests/css/css-flexbox/flexbox-min-width-auto-006.html: Added.
web-platform-tests/css/css-flexbox/percentage-descendant-of-anonymous-flex-item-expected.html: Added.
web-platform-tests/css/css-flexbox/percentage-descendant-of-anonymous-flex-item.html: Added.
web-platform-tests/css/css-flexbox/radiobutton-min-size-expected.txt: Updated expectations.
web-platform-tests/css/css-flexbox/radiobutton-min-size.html: Updated.
web-platform-tests/css/css-flexbox/support/40x20-green.png: Added.
web-platform-tests/css/css-flexbox/support/w3c-import.log:
web-platform-tests/css/css-flexbox/w3c-import.log:

LayoutTests:

Imported the most recent changes in flexbox WPT tests. This implies deleting a local test that
was upstreamed to WPT, so it does not make sense to have a duplicate.

TestExpectations: Removed a test that is currently passing. Adding a new expected failure.
css3/flexbox/percentage-descendants-of-skipped-flex-item-expected.html: Removed.
css3/flexbox/percentage-descendants-of-skipped-flex-item.html: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/css/css-flexbox/radiobutton-min-size-expected.txt:

Updated expectations.

11:08 AM Changeset in webkit [272794] by commit-queue@webkit.org

3 edits
2 adds in trunk

Crash in WebCore::RenderThemeMac::paintSearchFieldResultsDecorationPart() from large scale
https://bugs.webkit.org/show_bug.cgi?id=221635

Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2021-02-12
Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/editing/style/large-scale-crash.html

paintSearchFieldResultsDecorationPart(), unlike other functions like
paintSearchField(), paintSearchFieldCancelButton(), etc. has been
calling [NSButton:drawWithFrame:inView] directly. When a very large
scale has been applied however, this can lead to an assertion below us.
First draw the cell to an ImageBuffer using
paintCellAndSetFocusedElementNeedsRepaintIfNecessary(), as other
functions are already doing (as of 213352).
Thanks to Aditya Keerthi for pointing out this difference
and help with the fix.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldResultsDecorationPart):

LayoutTests:

Add a test with a very large value of scale that tests that
we do not trigger the assertion here.
Thanks to Ryosuke Niwa for help in cleaning up the test
and making it more reliable.

fast/rendering/searchfield-scale-crash-expected.txt: Added.
fast/rendering/searchfield-scale-crash.html: Added.

11:05 AM Changeset in webkit [272793] by Jonathan Bedard

3 edits in trunk/Tools

[webkit-patch] Use identifiers when posting to bugzilla (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=221724
<rdar://problem/74209525>

Rubber-stamped by Aakash Jain.

Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/svn.py:

(Svn): Keep track of the set of mock remotes.

Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py:

(Svn._cache_path): Change the cache path if we detect the current host is being mocked.

11:03 AM Changeset in webkit [272792] by aakash_jain@apple.com

1 edit
1 delete in trunk/Tools

Delete old build.webkit.org templates
https://bugs.webkit.org/show_bug.cgi?id=221692

Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/templates: Removed.

10:59 AM Changeset in webkit [272791] by aakash_jain@apple.com

3 edits in trunk/Tools

[build.webkit.org] Avoid hosting results on S3
https://bugs.webkit.org/show_bug.cgi?id=221822

Reviewed by Jonathan Bedard.

Reverts r271801, r272220 and r272399.

CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
CISupport/build-webkit-org/steps.py:

(ExtractTestResults.init):
(ExtractTestResults.resultDirectoryURL):

10:50 AM Changeset in webkit [272790] by stephan.szabo@sony.com

3 edits in trunk/Source/WebCore

[WinCairo][Debug] Build fix after r272772
https://bugs.webkit.org/show_bug.cgi?id=221814

Unreviewed build fix.

platform/graphics/cairo/FontCairo.cpp:
platform/graphics/cairo/GraphicsContextImplCairo.cpp:

10:40 AM Changeset in webkit [272789] by Chris Dumez

92 edits in trunk

Reduce explicit usage of [objC release] in WebKit
https://bugs.webkit.org/show_bug.cgi?id=221780

Reviewed by Alex Christensen.

Reduce explicit usage of [objC release] in WebKit by using smart pointers.

Source/WebCore:

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::postUserInfoForChanges):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):

bridge/testbindings.mm:

(main):

editing/cocoa/HTMLConverter.mm:

(HTMLConverter::HTMLConverter):
(HTMLConverter::computedAttributesForElement):
(HTMLConverter::_addMarkersToList):
(fileWrapperForURL):

history/mac/HistoryItemMac.mm:

(WebCore::HistoryItem::setViewState):

page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::exposedUnfilledArea const):

platform/ios/WebCoreMotionManager.h:
platform/ios/WebCoreMotionManager.mm:

(-[WebCoreMotionManager dealloc]):
(-[WebCoreMotionManager initializeOnMainThread]):
(-[WebCoreMotionManager checkClientStatus]):
(-[WebCoreMotionManager update]):

platform/ios/wak/WAKView.mm:

(-[WAKView dealloc]):
(-[WAKView _subviewReferences]):
(-[WAKView addSubview:]):
(-[WAKView removeFromSuperview]):

platform/ios/wak/WAKViewInternal.h:
platform/mac/PasteboardMac.mm:

(WebCore::writeFileWrapperAsRTFDAttachment):

platform/mac/PlatformSpeechSynthesizerMac.mm:

(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

platform/network/ios/NetworkStateNotifierIOS.mm:

(-[WebNetworkStateObserver initWithBlock:]):
(-[WebNetworkStateObserver dealloc]):

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::makeDelegate):

platform/text/mac/TextBoundaries.mm:

(WebCore::findWordBoundary):
(WebCore::findNextWordFromIndex):

Source/WebKit:

Shared/Cocoa/WKObject.mm:

(-[WKObject dealloc]):
(initializeTargetIfNeeded):
(-[WKObject forwardingTargetForSelector:]):
(-[WKObject forwardInvocation:]):

Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:

(-[UIView _web_setSubviews:]):

UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm:

(-[WKCustomProtocolLoader initWithLegacyCustomProtocolManagerProxy:customProtocolID:request:]):
(-[WKCustomProtocolLoader dealloc]):
(WebKit::LegacyCustomProtocolManagerClient::startLoading):

UIProcess/Inspector/ios/WKInspectorHighlightView.h:
UIProcess/Inspector/ios/WKInspectorHighlightView.mm:

(-[WKInspectorHighlightView initWithFrame:]):
(-[WKInspectorHighlightView dealloc]):
(-[WKInspectorHighlightView _removeAllLayers]):
(-[WKInspectorHighlightView _createLayers:]):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _selectPositionAtPoint:stayingWithinFocusedElement:completionHandler:]):
(-[WKContentView selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView moveSelectionAtBoundary:inDirection:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:withBoundary:completionHandler:]):

UIProcess/ios/WKScrollView.mm:

(-[WKScrollView _updateDelegate]):
(-[WKScrollView dealloc]):

UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectPopover initWithView:hasGroups:]):

UIProcess/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel dealloc]):
(-[WKTextInputPanel init]):

UIProcess/mac/WebColorPickerMac.mm:

(+[WKPopoverColorWell _colorPopoverCreateIfNecessary:]):

WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.h:
WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:

(-[WKAccessibilityWebPageObjectBase setRemoteParent:]):

WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

(-[WKAccessibilityWebPageObject dealloc]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):

Source/WebKitLegacy/ios:

WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::runOpenPanel):

WebView/WebPDFViewIOS.mm:

(-[WebPDFView dealloc]):
(-[WebPDFView setDataSource:]):
(-[WebPDFView _checkPDFTitle]):
(-[WebPDFView title]):

WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder _updateTitleForDocumentIfAvailable]):

Source/WebKitLegacy/mac:

DOM/DOMUIKitExtensions.mm:

(-[DOMNode absoluteQuads]):
(-[DOMHTMLAreaElement absoluteQuadsWithOwner:]):

DOM/ExceptionHandlers.mm:

(raiseDOMErrorException):

DefaultDelegates/WebDefaultUIDelegate.mm:

(-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):

History/WebHistory.mm:

(-[WebHistoryPrivate init]):
(-[WebHistoryPrivate dealloc]):
(-[WebHistoryPrivate removeItemFromDateCaches:]):
(-[WebHistoryPrivate addItemToDateCaches:]):
(-[WebHistoryPrivate visitedURL:withTitle:]):
(-[WebHistoryPrivate addItem:discardDuplicate:]):
(-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
(-[WebHistoryPrivate removeAllItems]):
(-[WebHistoryPrivate orderedLastVisitedDays]):
(-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
(-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
(-[WebHistory loadFromURL:error:]):
(-[WebHistory _visitedURL:withTitle:method:wasFailure:]):

History/WebHistoryItem.mm:

(-[WebHistoryItem initFromDictionaryRepresentation:]):

Misc/WebDownload.mm:

(-[WebDownloadInternal dealloc]):
(-[WebDownloadInternal setRealDelegate:]):
(-[WebDownloadInternal downloadDidBegin:]):
(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
(-[WebDownloadInternal download:didReceiveResponse:]):
(-[WebDownloadInternal download:didReceiveDataOfLength:]):
(-[WebDownloadInternal download:decideDestinationWithSuggestedFilename:]):
(-[WebDownloadInternal download:didCreateDestination:]):
(-[WebDownloadInternal downloadDidFinish:]):
(-[WebDownloadInternal download:didFailWithError:]):

Misc/WebNSDataExtras.mm:

(-[NSData _webkit_parseRFC822HeaderFields]):

Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
(-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):

Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::performRequest):

Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::didReceiveData):

Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView pluginView:receivedData:]):
(-[WebNetscapePluginView loadPluginRequest:]):
(-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

Plugins/WebPluginController.mm:

(-[WebPluginController pluginView:receivedResponse:]):

Plugins/WebPluginDatabase.mm:

(-[WebPluginDatabase refresh]):
(-[WebPluginDatabase _removePlugin:]):
(-[WebPluginDatabase _scanForNewPlugins]):

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::createWindow):
(WebChromeClient::addMessageToConsole):
(WebChromeClient::mouseDidMoveOverElement):
(WebChromeClient::exceededDatabaseQuota):
(WebChromeClient::reachedApplicationCacheOriginQuota):
(WebChromeClient::runOpenPanel):
(WebChromeClient::exitFullScreenForElement):

WebCoreSupport/WebEditorClient.mm:

(attributesForAttributedStringConversion):

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::forceLayoutForNonHTML):
(WebFrameLoaderClient::dispatchCreatePage):
(WebFrameLoaderClient::committedLoad):
(WebFrameLoaderClient::prepareForDataSourceReplacement):
(WebFrameLoaderClient::createDocumentLoader):
(WebFrameLoaderClient::savePlatformDataToCachedFrame):
(WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebFrameLoaderClient::actionDictionary const):
(WebFrameLoaderClient::createFrame):
(pluginView):
(WebFrameLoaderClient::createPlugin):

WebCoreSupport/WebGeolocationClient.mm:

(WebGeolocationClient::requestPermission):
(-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):

WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController init]):
(-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:]):
(-[WebInspectorWindowController dealloc]):
(-[WebInspectorWindowController frontendWebView]):
(-[WebInspectorWindowController window]):
(-[WebInspectorWindowController showWindow:]):
(-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):

WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::requestPermission):
(WebNotificationClient::checkPermission):

WebView/WebArchive.mm:

(-[WebArchivePrivate dealloc]):
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive mainResource]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):

WebView/WebDataSource.mm:

(-[WebDataSource _documentFragmentWithArchive:]):
(-[WebDataSource _makeRepresentation]):

WebView/WebFrame.mm:

(-[WebFramePrivate dealloc]):
(-[WebFramePrivate setWebFrameView:]):
(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
(+[WebFrame _createMainFrameWithPage:frameName:frameView:]):
(+[WebFrame _createMainFrameWithSimpleHTMLDocumentWithPage:frameView:style:]):
(-[WebFrame getDictationResultRanges:andMetadatas:]):
(-[WebFrame frameView]):

WebView/WebFrameInternal.h:
WebView/WebFrameView.mm:

(-[WebFrameViewPrivate dealloc]):
(-[WebFrameView _scrollView]):
(-[WebFrameView _install]):
(-[WebFrameView initWithFrame:]):
(-[WebFrameView _setCustomScrollViewClass:]):

WebView/WebFullScreenController.mm:

(-[WebFullScreenController init]):

WebView/WebHTMLView.mm:

(-[WebHTMLView _updateMouseoverWithEvent:]):

WebView/WebNavigationData.mm:

(-[WebNavigationDataPrivate dealloc]):
(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
(-[WebNavigationData url]):
(-[WebNavigationData title]):
(-[WebNavigationData originalRequest]):
(-[WebNavigationData response]):
(-[WebNavigationData clientRedirectSource]):

WebView/WebPDFDocumentExtras.mm:

(allScriptsInPDFDocument):

WebView/WebPDFRepresentation.mm:

(-[WebPDFRepresentation finishedLoadingWithDataSource:]):

WebView/WebPDFView.mm:

(-[WebPDFView menuForEvent:]):
(-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]):
(-[WebPDFView attributedString]):
(-[WebPDFView selectionImageForcingBlackText:]):
(-[WebPDFView _menuItemsFromPDFKitForEvent:]):
(-[WebPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]):

WebView/WebPolicyDelegate.mm:

(-[WebPolicyDecisionListenerPrivate initWithTarget:action:]):
(-[WebPolicyDecisionListenerPrivate dealloc]):
(-[WebPolicyDecisionListener _usePolicy:]):
(-[WebPolicyDecisionListener _invalidate]):

WebView/WebPreferences.mm:

(+[WebPreferences _setIBCreatorID:]):

WebView/WebScriptDebugger.mm:

(WebScriptDebugger::sourceParsed):

WebView/WebTextCompletionController.mm:

(-[WebTextCompletionController _buildUI]):

WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController init]):

WebView/WebView.mm:

(-[WebView _registerDraggedTypes]):
(-[WebView _commonInitializationWithFrameName:groupName:]):
(+[WebView _supportedFileExtensions]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _downloadURL:]):
(-[WebView _openNewWindowWithRequest:]):
(-[WebView _didStartProvisionalLoadForFrame:]):
(-[WebView caretChanged]):
(-[WebView setBackgroundColor:]):
(+[WebView setMIMETypesShownAsHTML:]):
(-[WebView setPreferences:]):
(-[WebView setPreferencesIdentifier:]):
(-[WebView setCurrentNodeHighlight:]):
(-[WebView stopLoadingAndClear]):
(-[WebView _openFrameInNewWindowFromMenu:]):
(-[WebView _searchWithGoogleFromMenu:]):

WebView/WebWindowAnimation.mm:

(-[WebWindowScaleAnimation setSubAnimation:]):

Tools:

DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):

DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
(destroyWebViewAndOffscreenWindow):
(dumpFrameAsPDF):
(dumpBackForwardListForWebView):

DumpRenderTree/mac/DumpRenderTreePasteboard.mm:

(+[DumpRenderTreePasteboard _pasteboardWithName:]):

DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController mouseDown:withModifiers:]):
(-[EventSendingController mouseUp:withModifiers:]):
(-[EventSendingController mouseMoveToX:Y:]):
(-[EventSendingController keyDown:withModifiers:withLocation:]):
(-[EventSendingController sentTouchEventOfType:]):
(-[EventSendingController touchEnd]):
(-[EventSendingController touchCancel]):

DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::clearBackForwardList):
(TestRunner::keepWebHistory):
(TestRunner::setDatabaseQuota):
(TestRunner::setMockDeviceOrientation):
(TestRunner::setMockGeolocationPosition):
(-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
(-[APITestDelegateIPhone dealloc]):
(-[APITestDelegateIPhone run]):
(-[APITestDelegateIPhone _cleanUp]):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(-[SynchronousLoader dealloc]):
(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
(+[SynchronousLoader makeRequest:withUsername:password:]):
(TestRunner::addChromeInputField):

DumpRenderTree/mac/UIDelegate.h:
DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
(-[UIDelegate timerFired]):
(-[UIDelegate dealloc]):

WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):

WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator interpolatedEvents:]):

WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::PlatformWebView):

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::addChromeInputField):

WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:

(-[WebKitTestRunnerDraggingInfo dealloc]):
(-[WebKitTestRunnerDraggingInfo draggedImage]):
(-[WebKitTestRunnerDraggingInfo draggingPasteboard]):
(-[WebKitTestRunnerDraggingInfo draggingSource]):

WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:

(+[WebKitTestRunnerPasteboard _pasteboardWithName:]):
(-[LocalPasteboard _addTypesWithoutUpdatingChangeCount:owner:]):

10:37 AM Changeset in webkit [272788] by Ryan Haddad

2 edits in trunk/LayoutTests

[ macOS wk2 ] webgpu/whlsl/do-while-loop-break.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215606

Unreviewed test gardening.

Patch by Robert Jenner <Robert Jenner> on 2021-02-12

platform/mac-wk2/TestExpectations: Switch expectation from Failure to ImageOnlyFailure.

10:36 AM Changeset in webkit [272787] by aakash_jain@apple.com

1 edit
1 delete in trunk/Tools

[build.webkit.org] Delete unused Makefile
https://bugs.webkit.org/show_bug.cgi?id=221721

Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/Makefile: Removed.

10:20 AM Changeset in webkit [272786] by commit-queue@webkit.org

18 edits
4 adds
1 delete in trunk

GPU process WebGL context toDataURL does not work for non-premultiplied contexts
https://bugs.webkit.org/show_bug.cgi?id=221748

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-02-12
Reviewed by Myles C. Maxfield.

Source/WebKit:

Implement GraphicsContextGL::paintRenderingResultsToImageData(). This
is used for Image.toDataURL() call, and returns something for
WebGL canvases that have non-premultiplied alpha.

No new tests, tested by currently failing WebGL conformance and ad hoc tests like
premultiplyalpha-test.html.
This does not make any failing test pass, as the tests test also premultiplied
case, which needs other currently unimplemented code.

GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:

(paintRenderingResultsToImageData):
Generated GPU process side implementation.

GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::getImageData):

GPUProcess/graphics/RemoteRenderingBackend.h:
GPUProcess/graphics/RemoteRenderingBackend.messages.in:

Change ImageDataReference to RefPtr<ImageData>.

Platform/IPC/ImageDataReference.h: Removed.

This implementation is redundant. The messages could accept just
RefPtr<WebCore::ImageData>, which is exactly "reference to
Image Data", i.e. ImageDataReference.

RefPtr<WebCore::ImageData> encoder and decoder already exist.

Scripts/webkit/messages.py:
Scripts/webkit/messages_unittest.py:
Scripts/webkit/tests/Makefile:
Scripts/webkit/tests/MessageArgumentDescriptions.cpp:

(IPC::jsValueForArguments):
(IPC::messageArgumentDescriptions):

Scripts/webkit/tests/MessageNames.cpp:

(IPC::description):
(IPC::receiverName):
(IPC::isValidMessageName):

Scripts/webkit/tests/MessageNames.h:
Scripts/webkit/tests/TestWithImageData.messages.in: Added.
Scripts/webkit/tests/TestWithImageDataMessageReceiver.cpp: Added.

(WebKit::TestWithImageData::didReceiveMessage):
(WebKit::TestWithImageData::didReceiveSyncMessage):

Scripts/webkit/tests/TestWithImageDataMessages.h: Added.

(Messages::TestWithImageData::messageReceiverName):
(Messages::TestWithImageData::SendImageData::name):
(Messages::TestWithImageData::SendImageData::SendImageData):
(Messages::TestWithImageData::SendImageData::arguments const):
(Messages::TestWithImageData::ReceiveImageData::name):
(Messages::TestWithImageData::ReceiveImageData::arguments const):

Scripts/webkit/tests/TestWithImageDataMessagesReplies.h: Added.

Test using RefPtr<WebCore::ImageData> in messages.in.

WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:

(WebKit::RemoteGraphicsContextGLProxy::paintRenderingResultsToImageData):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::getImageData):
Generated Web process side implementation.

Tools:

Add support for generating IPC implementation for functions with RefPtr<>.

Scripts/generate-gpup-webgl:

10:06 AM Changeset in webkit [272785] by aakash_jain@apple.com

3 edits in trunk/Tools

[build.webkit.org] commit identifier should show main instead of trunk
https://bugs.webkit.org/show_bug.cgi?id=221798

Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/steps.py:

(ShowIdentifier.init): Increased timeout to 10 minutes (since first run might take a while).
(ShowIdentifier.evaluateCommand):

CISupport/build-webkit-org/steps_unittest.py: Updated unit-tests.

9:50 AM Changeset in webkit [272784] by achristensen@apple.com

28 edits in trunk/Source/WebKit

Stop using GenericCallback from WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=221653

Reviewed by Chris Dumez.

There are still two uses in the DrawingAreaProxy implementations, but those are quite tangled and deserve their own patch.

UIProcess/API/APIAttachment.cpp:

(API::Attachment::updateAttributes):

UIProcess/API/APIAttachment.h:
UIProcess/API/C/WKPage.cpp:

(CompletionHandler<void):
(WKPageRenderTreeExternalRepresentation):
(WKPageGetSourceForFrame):
(WKPageGetContentsAsString):
(WKPageGetBytecodeProfile):
(WKPageGetSamplingProfilerOutput):
(WTF::Function<void): Deleted.

UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::Attachment::updateFromSerializedRepresentation):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _insertAttachmentWithFileWrapper:contentType:completion:]):
(-[WKWebView _getContentsAsStringWithCompletionHandler:]):
(-[WKWebView _getContentsOfAllFramesAsStringWithCompletionHandler:]):

UIProcess/API/Cocoa/_WKAttachment.mm:

(-[_WKAttachment setFileWrapper:contentType:completion:]):

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::startSpeaking):

UIProcess/GenericCallback.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getBytecodeProfile):
(WebKit::WebPageProxy::getSamplingProfilerOutput):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::installActivityStateChangeCompletionHandler):
(WebKit::WebPageProxy::insertAttachment):
(WebKit::WebPageProxy::updateAttachmentAttributes):
(WebKit::WebPageProxy::didInsertAttachmentWithIdentifier):
(WebKit::WebPageProxy::clearLoadDependentCallbacks): Deleted.
(WebKit::WebPageProxy::voidCallback): Deleted.
(WebKit::WebPageProxy::stringCallback): Deleted.
(WebKit::WebPageProxy::invalidateStringCallback): Deleted.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _shareForWebView:]):
(-[WKContentView _defineForWebView:]):
(-[WKContentView accessibilityRetrieveSpeakSelectionContent]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applyAutocorrection):

UIProcess/mac/WKTextFinderClient.mm:

(-[WKTextFinderClient getSelectedText:]):

WebProcess/Notifications/NotificationPermissionRequestManager.h:
WebProcess/WebCoreSupport/WebNotificationClient.h:
WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::activityStateDidChange):

WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::activityStateDidChange):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::setActivityState):
(WebKit::WebPage::getContentsAsString):
(WebKit::WebPage::getRenderTreeExternalRepresentation):
(WebKit::WebPage::getSelectionOrContentsAsString):
(WebKit::WebPage::getSourceForFrame):
(WebKit::WebPage::getBytecodeProfile):
(WebKit::WebPage::getSamplingProfilerOutput):
(WebKit::WebPage::insertAttachment):
(WebKit::WebPage::updateAttachmentAttributes):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applyAutocorrection):

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::handleActivityStateChangeCallbacks):
(WebKit::TiledCoreAnimationDrawingArea::activityStateDidChange):

9:32 AM Changeset in webkit [272783] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Fix Windows build after r272772
https://bugs.webkit.org/show_bug.cgi?id=221765

Unreviewed.

No new tests because there is no behavior change.

platform/graphics/Font.cpp:

9:17 AM Changeset in webkit [272782] by Jonathan Bedard

6 edits in trunk/Tools

[webkit-patch] Use identifiers when posting to bugzilla
https://bugs.webkit.org/show_bug.cgi?id=221724
<rdar://problem/74209525>

Rubber-stamped by Aakash Jain.

Scripts/webkitpy/common/config/urls.py:

(view_identifier_url): Return commits.webkit.org identifier link.

Scripts/webkitpy/tool/commands/download_unittest.py:

(DownloadCommandsTest.mock_svn_remote): Return a mock context for a remote Svn instance.

Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/comments.py:

(bug_comment_from_svn_revision): Query remote Subversion server to construct identifier link.

Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:

(CloseBugForLandDiffTest.test_empty_state): Mock context for a remote Svn instance.

Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:

4:05 AM Changeset in webkit [272781] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC] Update the block box/container list
https://bugs.webkit.org/show_bug.cgi?id=221800
<rdar://problem/74178203>

Reviewed by Antti Koivisto.

Add DisplayType::FlowRoot to isBlockContainer/isBlockLevelBox and DisplayType::Grid to isBlockLevelBox.

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isBlockLevelBox const):
(WebCore::Layout::Box::isBlockContainer const):

3:51 AM Changeset in webkit [272780] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] LineLayout::enclosingBorderBoxRectFor reports content box size
https://bugs.webkit.org/show_bug.cgi?id=221778

Reviewed by Antti Koivisto.

Before 272724, inline boxes included their paddings and borders in the content box geometry.
Now we can just simply return the border box rect.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::enclosingBorderBoxRectFor const):

3:29 AM Changeset in webkit [272779] by svillar@igalia.com

3 edits
2 adds in trunk

Crash in InsertTextCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=213514

Reviewed by Ryosuke Niwa.

Source/WebCore:

The InsertTextCommand might delete the current selection before inserting the text. In that case and when
the selection was ending inside an empty row of a table the code was calling CompositeEditCommand::removeNode()
directly to delete the empty row. That method however does not properly update the m_endingPosition of
the CompositeEditCommand leaving the current selection in an inconsistent state. Replaced that call by
removeNodeUpdatingStates() which ends up calling removeNode() but only after updating the selection state.

Test: editing/deleting/insert-in-orphaned-selection-crash.html

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows): Replaced
CompositeEditCommand::removeNode() by removeNodeUpdatingStates().

LayoutTests:

editing/deleting/insert-in-orphaned-selection-crash-expected.txt: Added.
editing/deleting/insert-in-orphaned-selection-crash.html: Added.

2:54 AM Changeset in webkit [272778] by youenn@apple.com

18 edits in trunk

Make RemoteRealtimeVideoSource a RealtimeVideoCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=221747

Reviewed by Eric Carlson.

Source/WebCore:

Introduce isVideoSource to be able to get presets data from RealtimeVideoSource.
Expose presets in RealtimeVideoSource for GPUProcess to send it to WebProcess.
Remove no longer used m_defaultSize member.
Update RealtimeVideoSource to set some of its members when its capture source is ready,
including settings, size, frame rate and name.
Covered by existing tests.

platform/mediastream/RealtimeMediaSource.h:
platform/mediastream/RealtimeVideoCaptureSource.cpp:

(WebCore::RealtimeVideoCaptureSource::prepareToProduceData):
(WebCore::RealtimeVideoCaptureSource::presetsData):

platform/mediastream/RealtimeVideoCaptureSource.h:
platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::whenReady):

platform/mediastream/RealtimeVideoSource.h:

Source/WebKit:

All capture video sources are now deriving from RealtimeVideoCaptureSource.
This allows to expose a RealtimeVideoSource that can handle changes of resolution and frame rate in software as needed.
This also allows to better align audio and video sources on iOS: there will only be one running source at any given time.
Covered by existing tests.

Scripts/webkit/messages.py:
UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::capabilities):
(WebKit::UserMediaCaptureManagerProxy::generatePresets):

UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
WebProcess/cocoa/RemoteRealtimeAudioSource.cpp:

(WebKit::RemoteRealtimeAudioSource::createRemoteMediaSource):
(WebKit::RemoteRealtimeAudioSource::setAsReady):

WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:

WebProcess/cocoa/RemoteRealtimeVideoSource.h:
WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::VideoFactory::createVideoCaptureSource):
(WebKit::UserMediaCaptureManager::DisplayFactory::createDisplayCaptureSource):

LayoutTests:

fast/mediastream/resources/getDisplayMedia-utils.js:

(async waitForHeight):
(async waitForWidth):
Updated to fail instead of timing out.

fast/mediastream/resources/getUserMedia-helper.js:

Removing no longer needed code that made it impossible to run the tests in browser.

1:38 AM Changeset in webkit [272777] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Nullopt crash in DOMSelection::getRangeAt
https://bugs.webkit.org/show_bug.cgi?id=221786

Reviewed by Darin Adler.

No new tests since we don't have any way to reproduce this crash.

page/DOMSelection.cpp:

(WebCore::DOMSelection::getRangeAt): Added a nullopt check with an assertion.

1:10 AM Changeset in webkit [272776] by Said Abou-Hallawa

26 edits in trunk

Source/WebCore:
Make Pattern hold a NativeImage instead of an Image
https://bugs.webkit.org/show_bug.cgi?id=221637

Reviewed by Simon Fraser.

This will make caching the Pattern data in the GPUP straightforward since
all we need is to cache the NativeImage and encode the pattern data.

html/canvas/CanvasPattern.cpp:

(WebCore::CanvasPattern::create):
(WebCore::CanvasPattern::CanvasPattern):

html/canvas/CanvasPattern.h:
html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::createPattern):

inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildArrayForCanvasPattern):
Extract a NativeImage of an Image. The platform Patterns deal with
NativeImages only.

platform/graphics/Image.h:

Remove ImageHandle.

platform/graphics/Pattern.cpp:

(WebCore::Pattern::create):
(WebCore::Pattern::Pattern):
(WebCore::Pattern::setPatternSpaceTransform):

platform/graphics/Pattern.h:

(WebCore::Pattern::Parameters::encode const):
(WebCore::Pattern::Parameters::decode):
(WebCore::Pattern::encode const): Deleted.
(WebCore::Pattern::decode): Deleted.
Make the new struct 'Parameters' holds all the members other than the
NativeImage. This struct + RenderingResourceIdentifer of the NativeImage
will be recorded for the strokePattern and the fillPattern.

platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::FillSource::FillSource):

platform/graphics/cairo/PatternCairo.cpp:

(WebCore::Pattern::createPlatformPattern const):

platform/graphics/cg/PatternCG.cpp:

(WebCore::Pattern::createPlatformPattern const):
The platform Pattern deals only with NativeImages.

platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::shouldDumpForFlags):
SetState::state() is renamed to SetStateItem::stateChange() since it
returns GraphicsContextStateChange.

platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::apply):
SetState::apply() has to be a special case.

platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::SetState::SetState):
(WebCore::DisplayList::SetState::apply):
(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::SetState::apply const): Deleted.
Add a new constructor for SetState to be used by the decoder. All the
members of GraphicsContextStateChange will be copied but strokePattern
and fillPattern will be created only when their NativeImages are resolved
in the SetState::apply().

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::SetState::stateChange const):
(WebCore::DisplayList::SetState::strokePatternParameters const):
(WebCore::DisplayList::SetState::fillPatternParameters const):
(WebCore::DisplayList::SetState::strokePatternImageIdentifier const):
(WebCore::DisplayList::SetState::fillPatternImageIdentifier const):
(WebCore::DisplayList::SetState::encode const):
(WebCore::DisplayList::SetState::decode):
(WebCore::DisplayList::SetState::state const): Deleted.
Specialize the encode and the decoding of strokePattern and fillPattern
by using the Pattern::Parameters and the RenderingResourceIdentifer of
the NativeImage.

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::cacheNativeImage):
(WebCore::DisplayList::Recorder::appendStateChangeItem):
(WebCore::DisplayList::Recorder::drawNativeImage):
(WebCore::DisplayList::Recorder::drawPattern):

platform/graphics/displaylists/DisplayListRecorder.h:

Cache the NativeImages of strokePattern and fillPattern.

platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::applySetStateItem):
(WebCore::DisplayList::Replayer::applyItem):
Resolve the NativeImages of strokePattern and fillPattern from the cached
NativeImages.

platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

rendering/RenderLayerBacking.cpp:

(WebCore::patternForDescription):

rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
Patterns should be created with NativeImages.

Source/WebKit:
Make Pattern hold a NativeImage instead of an Image
https://bugs.webkit.org/show_bug.cgi?id=221637

Reviewed by Simon Fraser.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ImageHandle>::encode): Deleted.
(IPC::ArgumentCoder<ImageHandle>::decode): Deleted.

Shared/WebCoreArgumentCoders.h:

Delete the encoding and decoding of Image since it is not used anymore

LayoutTests:
[GPU Process] Implement SetState DisplayList item
https://bugs.webkit.org/show_bug.cgi?id=219468

Reviewed by Simon Fraser.

gpu-process/TestExpectations:

Unmark tests that are no longer crash.

12:42 AM Changeset in webkit [272775] by Adrian Perez de Castro

1 copy in releases/WPE WebKit/webkit-2.30.5

WPE WebKit 2.30.5

12:42 AM Changeset in webkit [272774] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.30.5 release

Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

wpe/NEWS: Add release notes for 2.30.5.

12:32 AM Changeset in webkit [272773] by Antti Koivisto

7 edits in trunk/Source/WebKit

Increase network layout resource load priority for prioritized loads
https://bugs.webkit.org/show_bug.cgi?id=221751

Reviewed by Geoffrey Garen.

Currently visibility based prioritization only affects resource load scheduler.
We should increase the priority passed to the network layer and so the server too.

NetworkProcess/NetworkDataTask.h:

(WebKit::NetworkDataTask::setPriority):

NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::reprioritizeRequest):

NetworkProcess/NetworkLoad.h:
NetworkProcess/NetworkLoadScheduler.cpp:

(WebKit::NetworkLoadScheduler::HostContext::shouldDelayLowPriority const):
(WebKit::NetworkLoadScheduler::HostContext::schedule):
(WebKit::NetworkLoadScheduler::HostContext::unschedule):
(WebKit::NetworkLoadScheduler::HostContext::prioritize):

NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::setPriority):

Feb 11, 2021:

10:53 PM Changeset in webkit [272772] by mmaxfield@apple.com

24 edits in trunk/Source/WebCore

drawGlyphs() should take a Glyph* and an Advance* instead of a GlyphBuffer
https://bugs.webkit.org/show_bug.cgi?id=221765

Reviewed by Simon Fraser.

Making it take a GlyphBuffer is misleading because it only uses the glyph array and the advance array
from inside the GlyphBuffer. A GlyphBuffer also holds a bunch of extra data like glyph origins and an
initial advance. GlyphBuffers internally have a flatten() function which incorporate the origins into
the advances, and this flatten() function needs to have been called before calling drawGlyphs(). Our
code ASSERT()s this, and after the assertion, we shouldn't need the entire GlyphBuffer any more.

No new tests because there is no behavior change.

platform/graphics/Font.cpp:
platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::drawGlyphBuffer const):

platform/graphics/FontCascade.h:
platform/graphics/GlyphBufferMembers.h:
platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawGlyphs):

platform/graphics/GraphicsContext.h:
platform/graphics/GraphicsContextImpl.h:
platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawGlyphs):

platform/graphics/cairo/FontCairo.cpp:

(WebCore::FontCascade::drawGlyphs):

platform/graphics/cairo/GraphicsContextImplCairo.h:
platform/graphics/coretext/FontCascadeCoreText.cpp:

(WebCore::FontCascade::drawGlyphs):

platform/graphics/displaylists/DisplayListDrawGlyphsRecorder.h:
platform/graphics/displaylists/DisplayListDrawGlyphsRecorderCoreText.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

platform/graphics/displaylists/DisplayListDrawGlyphsRecorderHarfBuzz.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

platform/graphics/displaylists/DisplayListDrawGlyphsRecorderWin.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawGlyphs::apply const):
(WebCore::DisplayList::DrawGlyphs::generateGlyphBuffer const): Deleted.

platform/graphics/displaylists/DisplayListItems.h:
platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawGlyphs):

platform/graphics/displaylists/DisplayListRecorder.h:
platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::drawGlyphs):

platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
rendering/mathml/MathOperator.cpp:

(WebCore::MathOperator::paintGlyph):
(WebCore::MathOperator::paint):

rendering/mathml/RenderMathMLToken.cpp:

(WebCore::RenderMathMLToken::paint):

9:43 PM Changeset in webkit [272771] by Manuel Rego Casasnovas

4 edits in trunk

[WPE] event.ctrlKey and other are false in keydown event
https://bugs.webkit.org/show_bug.cgi?id=221760

Reviewed by Adrian Perez de Castro.

Source/WebKit:

This is the same issue that was fixed for WebKitGTK in r272489.

Test: fast/events/keyboardevent-modifier.html

Shared/libwpe/WebEventFactory.cpp:

(WebKit::modifiersForEventModifiers):
(WebKit::modifiersForKeyboardEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):

LayoutTests:

platform/wpe/TestExpectations: The test passes now.

9:12 PM Changeset in webkit [272770] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][Integration] The root box's display type should stay Display::Block
https://bugs.webkit.org/show_bug.cgi?id=221801

Reviewed by Antti Koivisto.

layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::updateStyle):

7:24 PM Changeset in webkit [272769] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix after r272758; include missing change to RuntimeEnabledFeatures.

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setOpusDecoderEnabled):
(WebCore::RuntimeEnabledFeatures::opusDecoderEnabled const):

6:56 PM Changeset in webkit [272768] by Nikita Vasilyev

6 edits in trunk/Source

Web Inspector: "Show Extended Gridlines" option for grid overlay does not work
https://bugs.webkit.org/show_bug.cgi?id=221775

Reviewed by Devin Rousso.

Replace all mentions of "Gridlines" with "GridLines" (camelcase).

Source/JavaScriptCore:

inspector/protocol/DOM.json:

Source/WebCore:

inspector/InspectorOverlay.h:
inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::showGridOverlay):

inspector/agents/InspectorDOMAgent.h:

6:19 PM Changeset in webkit [272767] by commit-queue@webkit.org

6 edits in trunk

REGRESSION(r272293) WebGL 1.0.2 test expectations say HTTPS
https://bugs.webkit.org/show_bug.cgi?id=221774
<rdar://problem/74149867>

Patch by Alex Christensen <achristensen@webkit.org> on 2021-02-11
Reviewed by Geoff Garen.

Source/WebCore:

www.opengl.org is in the list of hosts that support HTTPS, which affected our test expectations.
Since we need a domain to test with anyways for bug 221591, we may as well use this one.

contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::makeSecureIfNecessary):

LayoutTests:

http/tests/contentextensions/make-https-expected.txt:
http/tests/webgl/1.0.2/origin-clean-conformance-expected.txt:
http/tests/webgl/1.0.2/readPixelsBadArgs-expected.txt:

6:14 PM Changeset in webkit [272766] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

CodeBlock::propagateTransitions() should also handle OpSetPrivateBrand's LLInt IC.
https://bugs.webkit.org/show_bug.cgi?id=221787

Reviewed by Yusuke Suzuki.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::propagateTransitions):

6:08 PM Changeset in webkit [272765] by achristensen@apple.com

2 edits in trunk/Tools

Make WebKitLegacy.CrossPartitionFileSchemeAccess stop timing out on EWS bots
https://bugs.webkit.org/show_bug.cgi?id=206956

TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm:

This test times out sometimes, but only on bots. Let's kick the can down the road.

6:03 PM Changeset in webkit [272764] by achristensen@apple.com

18 edits
4 deletes in trunk

Unreviewed, reverting r272603.

Broke test, has room for improvement

Reverted changeset:

"Synthesize range responses if needed in WebCoreNSURLSession"
https://bugs.webkit.org/show_bug.cgi?id=221072
https://trac.webkit.org/changeset/272603

5:56 PM Changeset in webkit [272763] by don.olmstead@sony.com

2 edits in trunk/Tools

[Python-3] Update pylint version
https://bugs.webkit.org/show_bug.cgi?id=221785

Reviewed by Jonathan Bedard.

Update pylint on Python 3 to version 2.6.0 which supports >=3.5.

Update pylint on Python 2.7 to the last 0.x version, 0.28.0. The logilab packages are
specific to this version only so they are moved into the block.

Scripts/webkitpy/init.py:

5:24 PM Changeset in webkit [272762] by Jonathan Bedard

4 edits
1 add in trunk

Tools:
[run-webkit-tests] Update PHP module configuration
https://bugs.webkit.org/show_bug.cgi?id=221776
<rdar://problem/74248860>

Reviewed by Alexey Proskuryakov.

Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd.init): Optionally exclude PHP init directory.

Scripts/webkitpy/port/base.py:

(Port._darwin_php_version): Add -x version.

LayoutTests:

[run-webkit-tests] Update PHP module configuration

https://bugs.webkit.org/show_bug.cgi?id=221776
<rdar://problem/74248860>

Reviewed by Alexey Proskuryakov.

http/conf/apache2.4-x-httpd.conf: Added.

5:18 PM Changeset in webkit [272761] by Lauro Moura

5 edits in trunk/Tools

[WPE] Fix WPEQt tests after r272707
https://bugs.webkit.org/show_bug.cgi?id=220681

Reviewed by Carlos Garcia Campos.

Setting the title became async, so we must wait for it to be
processed.

Same patch as r271578, reapplying after original change was reapplied
in r272707.

TestWebKitAPI/Tests/WPEQt/TestLoad.cpp:

(TestLoad::main):

TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp:

(TestLoadHtml::main):

TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp:

(TestLoadRequest::main):

TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:

(TestRunJavaScript::main):

4:48 PM Changeset in webkit [272760] by Chris Dumez

10 edits in trunk/Source

Review usage of adoptNS()
https://bugs.webkit.org/show_bug.cgi?id=221779

Reviewed by Alex Christensen.

Review usage of adoptNS():

Make sure we call adoptNS() as soon as we allocate the object instead of doing it later on, as this is less error-prone
Fix cases where we called adoptNS() but really should have retained instead of adopting

Source/WebCore:

platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:

(WebCore::PlatformCAFilters::filterValueForOperation):

platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::addAnimationForKey):

platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:

(WebCore::AudioSampleBufferCompressor::gradualDecoderRefreshCount):

platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):

platform/text/cocoa/LocaleCocoa.mm:

(WebCore::createDateTimeFormatter):

testing/Internals.mm:

(WebCore::Internals::encodedPreferenceValue):

Source/WebKit:

UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::makeNode):

UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::makeNode):

4:39 PM Changeset in webkit [272759] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][Integration] Add scrollable overflow support
https://bugs.webkit.org/show_bug.cgi?id=221777

Reviewed by Simon Fraser.

Normally inline level boxes stretch the line box with their margin box. However inline boxes
behave differently. They stretch the line box with their layout bounds (->glyph sizes)
and they contribute to scrollable overflow with their border boxes (note that vertical margin is ignored on inline boxes).
e.g <div><span style="padding: 100px">text</span></div>
the line will not be stretched to include the 200px vertical padding, but instead the padding is added to the scrollable overflow area.
(see fast/inline/inline-content-with-padding-left-right.html)

layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):

4:08 PM Changeset in webkit [272758] by jer.noble@apple.com

13 edits in trunk/Source

[Mac] Add Experimental Opus Codec support
https://bugs.webkit.org/show_bug.cgi?id=221745

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Copy libopus headers into the libwebrtc header directory.

libwebrtc.xcodeproj/project.pbxproj:

Source/WebCore:

Add support for the Opus Codec in a WebM container by parsing the Opus private
codec data into a CoreAudio-specific magic cookie, and using that cookie to
initialize an AudioFormatDescription necessary to instantiate the CoreAudio
Opus decoder.

This magic cookie requires information both from the private codec data, but
also requires information parsed directly from the stream itself; update the
createOpusAudioFormatDescription() to take frame data as well as cookie data.

platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::opusDecoderEnabled):
(WebCore::PlatformMediaSessionManager::setOpusDecoderEnabled):

platform/audio/PlatformMediaSessionManager.h:
platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::SourceBufferParserWebM::AudioTrackData::consumeFrameData):

platform/graphics/cocoa/WebMAudioUtilitiesCocoa.h:
platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm:

(WebCore::createAudioFormatDescriptionForFormat):
(WebCore::opusConfigToFrameDuration):
(WebCore::opusConfigToBandwidth):
(WebCore::cookieFromOpusCodecPrivate):
(WebCore::isOpusDecoderAvailable):
(WebCore::createOpusAudioFormatDescription):
(WebCore::createVorbisAudioFormatDescription):

Source/WebKit:

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

Add a new experimental feature setting, disabled by default, controlling whether to
enable parsing of Opus tracks from WebM files.

Scripts/Preferences/WebPreferencesExperimental.yaml:
wtf/PlatformEnableCocoa.h:

3:57 PM Changeset in webkit [272757] by Ruben Turcios

1 copy in tags/Safari-612.1.3.1

Tag Safari-612.1.3.1.

3:43 PM Changeset in webkit [272756] by Ruben Turcios

8 edits in branches/safari-612.1.3-branch/Source

Versioning.

WebKit-7612.1.3.1

3:30 PM Changeset in webkit [272755] by Said Abou-Hallawa

10 edits in trunk

Unreviewed, reverting r270578.
https://bugs.webkit.org/show_bug.cgi?id=221110

Caused incorrect image layout inside a flexbox container.

LayoutTests/imported/w3c:

web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-013-expected.txt:
web-platform-tests/css/css-flexbox/image-as-flexitem-size-003-expected.txt:
web-platform-tests/css/css-flexbox/image-as-flexitem-size-003v-expected.txt:
web-platform-tests/css/css-flexbox/image-as-flexitem-size-004-expected.txt:
web-platform-tests/css/css-flexbox/image-as-flexitem-size-004v-expected.txt:

Source/WebCore:

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainSizeFromAspectRatioUsing const):
(WebCore::RenderFlexibleBox::childCrossSizeIsDefinite const):

LayoutTests:

TestExpectations:

2:57 PM Changeset in webkit [272754] by ddkilzer@apple.com

3 edits in trunk/Source/WebKit

Remove unused WebKit::LocalStorageDatabaseTracker::deleteAllDatabases()
<https://webkit.org/b/221734>
<rdar://problem/74215959>

Reviewed by Alexey Proskuryakov.

NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::deleteAllDatabases): Delete.

NetworkProcess/WebStorage/LocalStorageDatabaseTracker.h:

(WebKit::LocalStorageDatabaseTracker::deleteAllDatabases): Delete.

Remove this method since it's not used anywhere. This fixes a missing symbol linker error for WebCore::SQLiteFileSystem::deleteEmptyDatabaseDirectory() when building WebKit.framework with dead code stripping turned off since that method was not exported from WebCore.framework.

2:25 PM Changeset in webkit [272753] by Aditya Keerthi

5 edits
2 adds in trunk

[iOS][FCR] Add new picker for <select multiple> elements
https://bugs.webkit.org/show_bug.cgi?id=221636
<rdar://problem/72399337>

Reviewed by Wenson Hsieh.

Source/WebKit:

Test: fast/forms/ios/form-control-refresh/select/select-multiple-picker.html

UIProcess/ios/forms/WKFormSelectControl.mm:

(-[WKFormSelectControl initWithView:]):

UIProcess/ios/forms/WKFormSelectPicker.h:
UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKSelectPickerTableViewController initWithView:]):

The new picker is a table view with style UITableStyleInsetGrouped.

(-[WKSelectPickerTableViewController viewWillAppear:]):

Enable/disable the next/previous accessory buttons accordingly.

(-[WKSelectPickerTableViewController numberOfRowsInGroup:]):
(-[WKSelectPickerTableViewController numberOfSectionsInTableView:]):

There will always be at least one section, to display the empty message.
Adding groups will add more sections to the table view.

(-[WKSelectPickerTableViewController tableView:numberOfRowsInSection:]):
(-[WKSelectPickerTableViewController tableView:heightForHeaderInSection:]):

The header for the first section is an inset matching table view inset.

(-[WKSelectPickerTableViewController tableView:heightForFooterInSection:]):

An empty first section should not have a footer if there are more sections
after it. This can occur when the first option belongs to a group.

(-[WKSelectPickerTableViewController tableView:titleForHeaderInSection:]):
(-[WKSelectPickerTableViewController tableView:viewForFooterInSection:]):

Return nil so that the footer height is obeyed.

(-[WKSelectPickerTableViewController tableView:viewForHeaderInSection:]):

The header view displays the group name along with a button to collapse
the section.

(-[WKSelectPickerTableViewController collapseSection:]):

Collapsing sections is implemented by removing the corresponding rows
from the data source. The button is animated by changing its transform.

(-[WKSelectPickerTableViewController findItemIndexAt:]):
(-[WKSelectPickerTableViewController optionItemAtIndexPath:]):
(-[WKSelectPickerTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectPickerTableViewController tableView:didSelectRowAtIndexPath:]):
(-[WKSelectPickerTableViewController next:]):
(-[WKSelectPickerTableViewController previous:]):
(-[WKSelectPickerTableViewController close:]):
(-[WKSelectMultiplePicker initWithView:]):
(-[WKSelectMultiplePicker configurePresentation]):

Display the picker as a half-sheet (that can be dragged up into a
fullscreen view) on iPhones, and as a popover on iPads.

(-[WKSelectMultiplePicker controlView]):
(-[WKSelectMultiplePicker controlBeginEditing]):
(-[WKSelectMultiplePicker controlEndEditing]):
(-[WKSelectMultiplePicker presentationControllerDidDismiss:]):
(-[WKSelectMultiplePicker _indexPathForRow:]):
(-[WKSelectMultiplePicker selectRow:inComponent:extendingSelection:]):

Added testing hook to support layout testing.

LayoutTests:

Added a test which selects options using the new multi-select picker.
Grouped, ungrouped, and disabled options are all tested.

fast/forms/ios/form-control-refresh/select/select-multiple-picker-expected.txt: Added.
fast/forms/ios/form-control-refresh/select/select-multiple-picker.html: Added.

2:24 PM Changeset in webkit [272752] by commit-queue@webkit.org

4 edits in trunk/Source/WTF

Reduce string copies when converting from NSString/CFStringRef to WTF::String
https://bugs.webkit.org/show_bug.cgi?id=221766

Patch by Alex Christensen <achristensen@webkit.org> on 2021-02-11
Reviewed by Geoff Garen.

This reduces the string copies from two to one which should speed up many things.
The cost is that for non-Latin1-encodable strings of length less than 1024, we now do an allocation
and a reallocation, whereas before we were doing just one allocation. I think even in this case, though,
the cost of a reallocation should be comparable to the cost of doing a double string copy,
and the benefit of reducing a string copy everywhere is compelling.

I also reduced duplicate code by combining the CF and NS implementations.

wtf/text/WTFString.h:
wtf/text/cf/StringCF.cpp:

(WTF::String::String):

wtf/text/cocoa/StringCocoa.mm:

(WTF::String::String): Deleted.

2:22 PM Changeset in webkit [272751] by Jonathan Bedard

7 edits in trunk/Tools

[webkitpy] Use commits.webkit.org instead of trac
https://bugs.webkit.org/show_bug.cgi?id=221764
<rdar://problem/74242815>

Reviewed by Aakash Jain.

Scripts/webkitpy/common/config/urls.py:

(view_revision_url):

Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:

(CloseBugForLandDiffTest.test_empty_state):

Scripts/webkitpy/tool/steps/commit_unittest.py:

(CommitTest._test_check_test_expectations):

Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:

(UpdateChangeLogsForRevertTest):

2:05 PM Changeset in webkit [272750] by Chris Dumez

5 edits in trunk

[GPUP] <audio> won't load when URL ends with .php causing some tests to time out
https://bugs.webkit.org/show_bug.cgi?id=221695

Reviewed by Eric Carlson.

Source/WebCore:

No new tests, covered by unskipped layout tests.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerEngineUpdated):
(WebCore::HTMLMediaElement::mediaPlayerDidInitializeMediaEngine):
We were calling HTMLMediaElement::audioSourceProvider() in mediaPlayerEngineUpdated() which
happens right after we've constructed the MediaPlayerPrivate but before we've called
load() on the MediaPlayerPrivate. The issue was that calling audioSourceProvider() would
initialize the AudioSourceProvider and end up sending the RemoteMediaPlayerProxy::CreateAudioSourceProvider
IPC to the GPUProcess. RemoteMediaPlayerProxy::createAudioSourceProvider() would return early
because m_player->audioSourceProvider() returns null. The reason m_player->audioSourceProvider()
returns null is because it's MediaPlayerPrivate is still a NullMediaPlayerPrivate, because
MediaPlayer::load() has not been called in the GPUProcess yet. For this reason, I moved the
audioSourceProvider() initialization from mediaPlayerEngineUpdated() to
mediaPlayerDidInitializeMediaEngine(). mediaPlayerDidInitializeMediaEngine() happens right
after we've called MediaPlayerPrivate::load() which will end up calling MediaPlayer::load()
in the GPUProcess.

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::loadWithNextMediaEngine):
Pass an empty ContentType to MediaPlayerPrivate::load() when we did not have a content type
but guessed one based on the extension. This ends up getting passed to the MediaPlayer
in the GPUProcess and it is important it knows it does not have a content type so that
it can guess one from the extension and try the next media engine if it cannot find one.

LayoutTests:

Unskip tests that are no longer timing out.

gpu-process/TestExpectations:

1:57 PM Changeset in webkit [272749] by Aditya Keerthi

9 edits
4 adds in trunk

[iOS] Some checkboxes and radio buttons are clipped on top
https://bugs.webkit.org/show_bug.cgi?id=221736
<rdar://problem/73956812>

Reviewed by Simon Fraser.

Source/WebCore:

The clipping occurs due to integral rounding of the paint rect in
both RenderBox::paintBoxDecorations, as well as using the integral
rect in RenderTheme::paint. To fix, use FloatRect and the device
pixel snapped rect when painting these elements.

Tests: fast/forms/ios/form-control-refresh/checkbox/subpixel-clipping.html

fast/forms/ios/form-control-refresh/radio/subpixel-clipping.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):

Moved into RenderTheme to avoid duplication.

rendering/RenderElement.cpp:

(WebCore::RenderElement::paintOutline):

Moved into RenderTheme to avoid duplication.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

Use the device pixel snapped rect when painting checkboxes and radio
buttons.

rendering/RenderTheme.h:

(WebCore::RenderTheme::adjustedPaintRect):

On most platforms, no adjustment is performed.

(WebCore::RenderTheme::paintCheckbox):
(WebCore::RenderTheme::paintRadio):

rendering/RenderThemeIOS.h:
rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::adjustedPaintRect):

On iOS, radio buttons and checkboxes always have a square painting
rect. Updated to use FloatRect, rather than IntRect, to avoid
clipping.

(WebCore::RenderThemeIOS::paintCheckbox):
(WebCore::RenderThemeIOS::paintRadio):

rendering/RenderThemeWin.h:

LayoutTests:

Added reference mismatch tests to verify that the clipping no longer
occurs. The tests work by drawing an overlay smaller than the actual
size of the checkbox/radio input. If the input is clipped, only the
overlay will be visible, matching the "-expected-mismatch.html".
However, if the input is drawn correctly, the overlay will not cover
the entire input, and a mismatch will occur.

fast/forms/ios/form-control-refresh/checkbox/subpixel-clipping-expected-mismatch.html: Added.
fast/forms/ios/form-control-refresh/checkbox/subpixel-clipping.html: Added.
fast/forms/ios/form-control-refresh/radio/subpixel-clipping-expected-mismatch.html: Added.
fast/forms/ios/form-control-refresh/radio/subpixel-clipping.html: Added.

1:49 PM Changeset in webkit [272748] by jer.noble@apple.com

38 edits
6 copies
1 add in trunk/Source

[Cocoa][GPUP] Move RemoteCommandListener into the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=221732

Reviewed by Eric Carlson.

Source/WebCore:

Refactor RemoteCommandListener to allow its methods to work over XPC:

Rather than having a synchronous client method to query whether seeking is supported, require clients to set seekability explicitly.
Change the RemoteCommandArgument from a union to an Optional<double>.
Allow clients to query the MediaPlaybackTarget through the session rather than wait for a notification that the playback target changed.

Additionally, add a mini-factory functionality to RemoteCommandListener to allow
clients to specify a different subclass to be created at runtime.

Modules/webaudio/AudioContext.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didReceiveRemoteControlCommand):

html/HTMLMediaElement.h:
html/MediaElementSession.cpp:

(WebCore::MediaElementSession::didReceiveRemoteControlCommand):

html/MediaElementSession.h:
platform/NowPlayingManager.cpp:

(WebCore::NowPlayingManager::didReceiveRemoteControlCommand):
(WebCore::NowPlayingManager::setNowPlayingInfo):
(WebCore::NowPlayingManager::supportsSeeking const): Deleted.

platform/NowPlayingManager.h:
platform/RemoteCommandListener.cpp:

(WebCore::remoteCommandListenerCreationFunction):
(WebCore::RemoteCommandListener::setCreationFunction):
(WebCore::RemoteCommandListener::resetCreationFunction):
(WebCore::RemoteCommandListener::create):
(WebCore::RemoteCommandListener::RemoteCommandListener):
(WebCore::RemoteCommandListener::setSupportsSeeking):

platform/RemoteCommandListener.h:

(WebCore::RemoteCommandListener::RemoteCommandListener): Deleted.
(WebCore::RemoteCommandListener::updateSupportedCommands): Deleted.
(WebCore::RemoteCommandListener::client const): Deleted.

platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::didReceiveRemoteControlCommand):

platform/audio/PlatformMediaSession.h:
platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::processDidReceiveRemoteControlCommand):

platform/audio/PlatformMediaSessionManager.h:
platform/audio/cocoa/MediaSessionManagerCocoa.h:
platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::scheduleSessionStatusUpdate):

platform/audio/ios/MediaSessionHelperIOS.h:
platform/audio/ios/MediaSessionHelperIOS.mm:

(MediaSessionHelperiOS::activeVideoRouteDidChange):

platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::sessionWillBeginPlayback):

platform/ios/RemoteCommandListenerIOS.h:
platform/ios/RemoteCommandListenerIOS.mm:

(WebCore::RemoteCommandListenerIOS::create):
(WebCore::RemoteCommandListenerIOS::RemoteCommandListenerIOS):
(WebCore::RemoteCommandListenerIOS::updateSupportedCommands):
(WebCore::RemoteCommandListener::create): Deleted.

platform/mac/RemoteCommandListenerMac.h:
platform/mac/RemoteCommandListenerMac.mm:

(WebCore::RemoteCommandListenerMac::create):
(WebCore::RemoteCommandListenerMac::updateSupportedCommands):
(WebCore::RemoteCommandListenerMac::RemoteCommandListenerMac):
(WebCore::RemoteCommandListener::create): Deleted.

testing/Internals.cpp:

(WebCore::Internals::postRemoteControlCommand):

Source/WebKit:

Add a new Remote/Proxy class pair to facilitate RemoteCommandListener being
created in the GPU Process.

DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::createRemoteCommandListener):
(WebKit::GPUConnectionToWebProcess::releaseRemoteCommandListener):

GPUProcess/GPUConnectionToWebProcess.h:
GPUProcess/GPUConnectionToWebProcess.messages.in:
GPUProcess/media/RemoteRemoteCommandListenerProxy.cpp:

(WebKit::RemoteRemoteCommandListenerProxy::RemoteRemoteCommandListenerProxy):
(WebKit::RemoteRemoteCommandListenerProxy::didReceiveRemoteControlCommand):
(WebKit::RemoteRemoteCommandListenerProxy::updateSupportedCommands):

GPUProcess/media/RemoteRemoteCommandListenerProxy.h:
GPUProcess/media/RemoteRemoteCommandListenerProxy.messages.in:
Scripts/webkit/messages.py:
Sources.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::didReceiveRemoteCommand):

WebProcess/GPU/media/RemoteRemoteCommandListener.cpp: Added.

(WebKit::RemoteRemoteCommandListener::create):
(WebKit::RemoteRemoteCommandListener::RemoteRemoteCommandListener):
(WebKit::RemoteRemoteCommandListener::~RemoteRemoteCommandListener):
(WebKit::RemoteRemoteCommandListener::gpuProcessConnectionDidClose):
(WebKit::RemoteRemoteCommandListener::didReceiveRemoteControlCommand):

WebProcess/GPU/media/RemoteRemoteCommandListener.h:
WebProcess/GPU/media/RemoteRemoteCommandListener.messages.in:
WebProcess/GPU/media/RemoteRemoteCommandListenerIdentifier.h:
WebProcess/GPU/media/ios/RemoteMediaSessionHelper.cpp:

(WebKit::RemoteMediaSessionHelper::activeVideoRouteDidChange):

WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setUseGPUProcessForMedia):

1:38 PM Changeset in webkit [272747] by Alexey Shvayka

3 edits
3 adds
1 delete in trunk

SetIntegrityLevel should call DefineOwnProperty with partial descriptor
https://bugs.webkit.org/show_bug.cgi?id=221497

Reviewed by Yusuke Suzuki.

JSTests:

stress/arguments-define-property-throws-out-of-memory.js: Added.
stress/freeze-invokes-out-of-memory.js: Removed.
stress/object-freeze-with-arguments-no-oom-error.js: Added.
stress/object-freeze-with-proxy-defineProperty.js: Added.

Source/JavaScriptCore:

This patch prevents GetOwnProperty result descriptor from being reused for
DefineOwnProperty. Instead, partial descriptor with only Configurable
and (conditionally) Writable fields is passed, which is observable by
ProxyObject's "defineProperty" trap (and possibly any other opaque object).

Also, replaces isDataDescriptor() check with negated isAccessorDescriptor()
as per spec [1], which is equivalent in this case yet is false dichotomy
for partial descriptors.

Aligns JSC with V8 and SpiderMonkey.

[1]: https://tc39.es/ecma262/#sec-setintegritylevel (step 7.b.ii)

runtime/ObjectConstructor.cpp:

(JSC::setIntegrityLevel):

1:34 PM Changeset in webkit [272746] by Darin Adler

2 edits in trunk/Source/WebCore

Use a template to simplify repetitive code in ColorSpaceCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=221770

Reviewed by Sam Weinig.

platform/graphics/cg/ColorSpaceCG.cpp:

(WebCore::namedColorSpace): Added.
(WebCore::sRGBColorSpaceRef): Use namedColorSpace. Also took out long-obsolete
workaround for a bug in pre-2013 versions of Core Graphics on Windows.
(WebCore::adobeRGB1998ColorSpaceRef): Ditto.
(WebCore::displayP3ColorSpaceRef): Ditto.
(WebCore::extendedSRGBColorSpaceRef): Ditto.
(WebCore::ITUR_2020ColorSpaceRef): Ditto.
(WebCore::linearSRGBColorSpaceRef): Ditto.
(WebCore::ROMMRGBColorSpaceRef): Ditto.
(WebCore::xyzColorSpaceRef): Ditto.

1:33 PM Changeset in webkit [272745] by Chris Dumez

4 edits in trunk/LayoutTests

[ MacOS Debug wk2] imported/w3c/web-platform-tests/worklets/animation-worklet-service-worker-interception.https.html is a flakey text failure
https://bugs.webkit.org/show_bug.cgi?id=221731
<rdar://problem/74213595>

Unreviewed, skip animation & layout worklets tests since we do not support those and it is
causing those tests to be flaky.

LayoutTests/imported/w3c:

web-platform-tests/worklets/animation-worklet-service-worker-interception.https-expected.txt:

LayoutTests:

TestExpectations:

1:30 PM Changeset in webkit [272744] by Darin Adler

2 edits in trunk/Source/WebKit

[Cocoa] IPC decoder is using decoded size to allocate memory for an array
https://bugs.webkit.org/show_bug.cgi?id=221773

Reviewed by Geoffrey Garen.

Shared/Cocoa/ArgumentCodersCocoa.mm:

(IPC::decodeArrayInternal): As with other similar structures, such a Vector and
CFArray, don't use the size to preallocate space when decoding an NSArray. The
decoded size is potentially incorrect, which we will discover indirectly when
decoding the array elements; we can't safely use the size to make a choice about
allocating memory beforehand.

11:59 AM Changeset in webkit [272743] by aakash_jain@apple.com

4 edits in trunk/Tools

build.webkit.org should display commit identifier in builds
https://bugs.webkit.org/show_bug.cgi?id=221730

Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/steps.py:

(ExtractTestResults.finished):
(ShowIdentifier): build-step to show commit identifier.
(ShowIdentifier.init):
(ShowIdentifier.start):
(ShowIdentifier.evaluateCommand):
(ShowIdentifier.getLastBuildStepByName):
(ShowIdentifier.url_for_identifier):
(ShowIdentifier.getResultSummary): Display custom failure message.
(ShowIdentifier.hideStepIf): Hide this step if successful.

CISupport/build-webkit-org/steps_unittest.py:

(BuildStepMixinAdditions.executedSteps): filter wasn't working as expected with python 3, replaced
with list comprehension.
(TestShowIdentifier): Added unit-tests.
(TestShowIdentifier.test_success):
(TestShowIdentifier.test_failure):

CISupport/build-webkit-org/factories.py: Added ShowIdentifier build step.

11:33 AM Changeset in webkit [272742] by commit-queue@webkit.org

2 edits in trunk/Websites/webkit.org

scroll-snap demo should use new spec
https://bugs.webkit.org/show_bug.cgi?id=184046

Patch by Martin Robinson <mrobinson@igalia.com> on 2021-02-11
Reviewed by Wenson Hsieh.

Update the scroll-snap demo to reflect the modern specification. This
demo isn't currently linked from the site, but if it's every linked again
it will now reflect the current specification.

This maintains the old CSS so that the demo continues to work with
old versions of Safari.

demos/scroll-snap/index.html: Update the descriptions in the demo to reflect

the newest version of the specification.

11:23 AM Changeset in webkit [272741] by Brent Fulgham

2 edits in trunk/Source/WebKit

[macOS] Add telemetry for a likely-unused call to ipc-posix-shm-read-data
https://bugs.webkit.org/show_bug.cgi?id=221733
<rdar://problem/74214692>

Reviewed by Per Arne Vollan.

Add telemetry to confirm this is unsed.

WebProcess/com.apple.WebProcess.sb.in:

11:17 AM Changeset in webkit [272740] by Aditya Keerthi

3 edits
2 adds in trunk

[iOS][FCR] Range inputs have an incorrect RTL appearance
https://bugs.webkit.org/show_bug.cgi?id=221758
<rdar://problem/74236993>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/forms/ios/form-control-refresh/range/rtl-appearance.html

rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintSliderTrackWithFormControlRefresh):

In a right-to-left appearance, the track should begin filling from
the right.

LayoutTests:

Added a reference mismatch test to verify that a range input with
dir="rtl" has a distinct appearance from a standard range input.

fast/forms/ios/form-control-refresh/range/rtl-appearance-expected-mismatch.html: Added.
fast/forms/ios/form-control-refresh/range/rtl-appearance.html: Added.

11:12 AM Changeset in webkit [272739] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Grid section in Layout panel gets out of sync with grid overlay after reopening Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=221728
<rdar://problem/74212444>

Patch by Razvan Caliman <Razvan Caliman> on 2021-02-11
Reviewed by BJ Burg.

Hide all shown grid overlays when the WebInspector is closed.

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMAgent::highlightNodeList):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

10:50 AM Changeset in webkit [272738] by aakash_jain@apple.com

3 edits in trunk/Tools

JSC EWSes should be triggered by change in any jsc file
https://bugs.webkit.org/show_bug.cgi?id=221756

Reviewed by Jonathan Bedard.

CISupport/ews-build/steps.py:

(CheckPatchRelevance): Used generic jsc regex.

CISupport/ews-build/steps_unittest.py: Made the unit-tests more generic by using for loop to check multiple filenames.

10:33 AM Changeset in webkit [272737] by commit-queue@webkit.org

6 edits in trunk/Source/WebInspectorUI

Web Inspector: Add settings UI for CSS Grid overlay
https://bugs.webkit.org/show_bug.cgi?id=221556
<rdar://problem/74100005>

Patch by Razvan Caliman <Razvan Caliman> on 2021-02-11
Reviewed by Devin Rousso.

Add UI to toggle configuration options for the CSS Grid overlay.
When an option's value changes, all shown overlays are refreshed.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Base/Setting.js:
UserInterface/Controllers/OverlayManager.js:

(WI.OverlayManager):
(WI.OverlayManager.prototype.showGridOverlay):
(WI.OverlayManager.prototype._handleGridSettingChanged):

UserInterface/Views/CSSGridSection.css:

(.css-grid-section .node-link,):
(.css-grid-section :is(.heading, .title)):

UserInterface/Views/CSSGridSection.js:

(WI.CSSGridSection.prototype.initialLayout):

9:43 AM Changeset in webkit [272736] by weinig@apple.com

7 edits in trunk/Source

Returning sRGB from CG color space functions on failure is too error prone
https://bugs.webkit.org/show_bug.cgi?id=221676

Reviewed by Darin Adler.

Source/WebCore:

platform/graphics/cg/ColorCG.cpp:

(WebCore::leakCGColor):
Switch to checking for nullptr rather than sRGB and be explicit about where we can
and cannot use conversion to ExtendedSRGB, rather than the old behavior where we
would secretly use sRGB on platforms without ExtendedSRGB and expect CG to clamp for
us.

platform/graphics/cg/ColorSpaceCG.cpp:

(WebCore::sRGBColorSpaceRef):
(WebCore::adobeRGB1998ColorSpaceRef):
(WebCore::displayP3ColorSpaceRef):
(WebCore::extendedSRGBColorSpaceRef):
(WebCore::ITUR_2020ColorSpaceRef):
(WebCore::labColorSpaceRef):
(WebCore::linearSRGBColorSpaceRef):
(WebCore::ROMMRGBColorSpaceRef):
(WebCore::xyzColorSpaceRef):

platform/graphics/cg/ColorSpaceCG.h:

(WebCore::cachedNullableCGColorSpace):
(WebCore::cachedCGColorSpace):
Rename cachedCGColorSpace to cachedNullableCGColorSpace to indicate that it can
now return nullptr for unsupported color spaces. Add explicit guards around color
space accessors to ensure they are only called on platforms where they are known
to be supported.

platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::createCGGradient):
Be explicit about which color space is being used for the gradien when extended colors are present.
This is the same behavior as before, but previously it would happen silently beneath extendedSRGBColorSpaceRef()
which is a suprising result.

Source/WTF:

wtf/PlatformHave.h:

Add specific macros for color spaces supported by Core Graphics.

9:30 AM Changeset in webkit [272735] by youenn@apple.com

5 edits in trunk

[MacOS] Enable Audio Capture in GPUProcess by default
https://bugs.webkit.org/show_bug.cgi?id=221400

Reviewed by Eric Carlson.

Source/WebKit:

Covered by existing API tests, in particular TestWebKitAPI.WebKit.OnDeviceChangeCrash.

WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

We need to synchronously fill the granted requests, otherwise there is a risk that
the granted requests will be cleared (on page close for instance) and then later filled
for the page that was gone.

Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCaptureAudioInGPUProcessEnabled):

Tools:

TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:

(-[GetUserMediaRepromptTestView haveStream:]):
Increase timeout since capture might require spinning GPUProcess.

9:26 AM Changeset in webkit [272734] by commit-queue@webkit.org

19 edits
1 add in trunk

Complete XRSession::requestAnimationFrame implementation
https://bugs.webkit.org/show_bug.cgi?id=220979

Patch by Sergio Villar Senin <svillar@igalia.com> and Imanol Fernandez <imanol> on 2021-02-11
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Enable XRSession RAF tests.

web-platform-tests/webxr/xrSession_requestAnimationFrame_timestamp.https-expected.txt: Added.

Source/WebCore:

Implement the render loop for immersive and inline XR sessions.
Implement WebXR render state updates.
Create the FrameData struct used to query frame specific data from XR devices.
Use window RAF for inline XR sessions.
Implement WebFakeXRDevice testing rendering loop using a timer.
Implement OpenXR session states and session tracking.
Improve OpenXR event handling.

Tested by the WebXR platform tests.

Modules/webxr/WebXRFrame.cpp: Add m_active, m_time and m_session members

(WebCore::WebXRFrame::create):
(WebCore::WebXRFrame::WebXRFrame):

Modules/webxr/WebXRFrame.h:

(WebCore::WebXRFrame::setTime):
(WebCore::WebXRFrame::setActive):
(WebCore::WebXRFrame::isActive const):

Modules/webxr/WebXRRenderState.h: Add m_compositionDisabled member and output canvas setter

(WebCore::WebXRRenderState::setOutputCanvas):
(WebCore::WebXRRenderState::compositionDisabled const):
(WebCore::WebXRRenderState::setCompositionDisabled):

Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::create):
(WebCore::WebXRSession::WebXRSession):
(WebCore::WebXRSession::initialize): required to creat the XRFrame with makeRef(this)
(WebCore::WebXRSession::requestReferenceSpace): implement reference space creation
(WebCore::WebXRSession::requestAnimationFrame): implement render loop for immersive and inline sessions
(WebCore::WebXRSession::applyPendingRenderState): implement WebXR render state updates
(WebCore::WebXRSession::frameShouldBeRendered const): add check based on the spec
(WebCore::WebXRSession::requestFrame): implement helper function to dispatch a frame request to XR devices
(WebCore::WebXRSession::onFrame): process the XR frame and call the RAF callbacks

Modules/webxr/WebXRSession.h:

Modules/webxr/WebXRSystem.cpp: Implement render loop using window raf loop.

(WebCore::WebXRSystem::WebXRSystem):
(WebCore::WebXRSystem::DummyInlineDevice::DummyInlineDevice): Add ScriptExecutionContext
(WebCore::WebXRSystem::DummyInlineDevice::requestFrame): Adapt to the new interface

Modules/webxr/WebXRSystem.h:
Modules/webxr/WebXRWebGLLayer.cpp:

(WebCore::WebXRWebGLLayer::canvas const): Implement canvas getter

Modules/webxr/WebXRWebGLLayer.h:

(WebCore::WebXRWebGLLayer::compositionDisabled const): add
(WebCore::WebXRWebGLLayer::setCompositionDisabled): add

platform/xr/PlatformXR.h: Add FrameData struct

platform/xr/openxr/PlatformXROpenXR.cpp: Implement render loop using OpenXR API

(PlatformXR::OpenXRDevice::resetSession):
(PlatformXR::OpenXRDevice::shutDownTrackingAndRendering):
(PlatformXR::OpenXRDevice::pollEvents): Implement event loop to query m_sessionState
(PlatformXR::sessionIsActive): add
(PlatformXR::sessionIsRunning): add
(PlatformXR::OpenXRDevice::beginSession):
(PlatformXR::xrViewToViewData): helper function to convert data from OpenXR
(PlatformXR::OpenXRDevice::requestFrame): start OpenXR frame, query pose and view data
(PlatformXR::OpenXRDevice::waitUntilStopping): properly wait for OpenXR event before ending the session.

platform/xr/openxr/PlatformXROpenXR.h:

testing/WebFakeXRDevice.cpp: Implement render loop using a timer

(WebCore::SimulatedXRDevice::SimulatedXRDevice):
(WebCore::SimulatedXRDevice::~SimulatedXRDevice):
(WebCore::SimulatedXRDevice::shutDownTrackingAndRendering):
(WebCore::SimulatedXRDevice::stopTimer):
(WebCore::SimulatedXRDevice::frameTimerFired):
(WebCore::SimulatedXRDevice::requestFrame):

testing/WebFakeXRDevice.h:

LayoutTests:

platform/wpe/TestExpectations:

9:09 AM Changeset in webkit [272733] by Lauro Moura

2 edits in trunk/Tools

[Flatpak SDK] Fix env forwarding for older flatpak versions
https://bugs.webkit.org/show_bug.cgi?id=221757

Rubber-stamped by Philippe Normand.

Older flatpak versions (pre 1.10) might not have been patched for the
envvar CVE that triggered the new behavior and would still be
receiving the environment through envvars instead of the --args file
descriptor.

flatpak/webkit-bwrap:

8:58 AM Changeset in webkit [272732] by don.olmstead@sony.com

7 edits in trunk

[CMake] WEBKIT_EXECUTABLE can incorrectly link framework
https://bugs.webkit.org/show_bug.cgi?id=221703

Reviewed by Michael Catanzaro.

After r272484 which added an additional test for TestJavaScriptCore the PlayStation build
began failing with an unresolved symbol in bmalloc. On PlayStation both WTF and bmalloc
are linked into JavaScriptCore. That library was building successfully which implied that
WTF was being erroniously linked into TestJavaScriptCore.

Inside _WEBKIT_EXECUTABLE_LINK_FRAMEWORK there was an invalid conditional which was causing
WTF to be linked. Fixed the logic to ensure that if the requested framework is linked into
another framework that is being linked then it is not added to the linker.

Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

GTK compiles JavaScriptCore as a SHARED library but the symbols from WTF are not being
properly exposed from it. Workaround this by linking WTF directly until GTK turns on
hidden visibility and properly exports symbols.

shell/PlatformGTK.cmake:

Tools:

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/PlatformGTK.cmake:

8:36 AM Changeset in webkit [272731] by weinig@apple.com

19 edits in trunk/Source

Rework RGB color types to be more declarative to reduce code duplication and make progress toward better automatic conversion
https://bugs.webkit.org/show_bug.cgi?id=221677

Reviewed by Darin Adler.

Source/WebCore:

The "RGB" family of colors (those inheriting from RGBType) all share a common structure
can be generalized to simplify their conversions and centralize their definitions.

To do this, each RGB color type now defines a "Descriptor" type (e.g. SRGBDescriptor for
SRGBA) which includes:

What transfer function it uses (e.g. SRGBTransferFunction)
What whitePoint it is defined for (e.g. WhitePoint::D65)
What matrices it uses to convert from linear to xyz and from xyz to linear.

Then using type aliases, the color type is defined using the descriptor and one of the four
base types: BoundedGammaEncoded, BoundedLinearEncoded, ExtendedGammaEncoded, and ExtendedLinearEncoded.
So, for the SRGBA family of color types, they are defined as:

template<typename T> using SRGBA = BoundedGammaEncoded<T, SRGBADescriptor<T>>;
template<typename T> using LinearSRGBA = BoundedLinearEncoded<T, SRGBADescriptor<T>>;
template<typename T> using ExtendedSRGBA = ExtendedGammaEncoded<T, SRGBADescriptor<T>>;
template<typename T> using LinearExtendedSRGBA = ExtendedLinearEncoded<T, SRGBADescriptor<T>>;

By using type aliases like this, we gain the ability to easily set up relationships between
the types. For instance, the BoundedGammaEncoded type has the following members:

using LinearCounterpart = BoundedLinearEncoded<T, D>;
using ExtendedCounterpart = ExtendedGammaEncoded<T, D>;

Where D is the "Descriptor" it was made with. This allows helper functions such as the conversion
functions to automatically know what counterpart to use without having to write specialized versions
for each pair. This will aid in unifying conversion functions further.

This change also removes the XYZReference member of the color types, replacing it with the
WhitePoint, which can be used to construct the XYZReference as is done by the new XYZFor<> alias.
This will allow for straigthforward comparisons when we stop always converting through XYZA.

As a result of moving the matrices to the color type descriptors, we can now simplify all the
linear to xyz and xyz to linear conversions to use generic functions (called linearToXYZ and
xyzToLinear not suprisingly) and since the descriptors also include the transfer function we
can further simplify the gamma conversion functions to no longer explicitly passing the transfer
function.

Two consequenes of using complex type aliases for the color types, rather than direct structs, is
that we can no longer easily forward declare the color types, so ColorTypes.h is included in a few
more places now, and the deduction guides we had been using don't work, so we must explicitly specify
the type in a few places. We should be able to reduce the amount included in most places by splitting
up the color types into their own headers, and only including the needed color type, only SRGBA in
practice.

This also adds back a missing clamp to the conversion from SRGBA<float> to SRGBA<uint8_t> that I didn't
intend to remove in a previous patch, but I am not actual sure is necessary. While I work that out,
better to add it back.

css/parser/CSSParser.h:
css/parser/CSSParserFastPaths.h:
platform/graphics/Color.cpp:

(WebCore::Color::lightened const):
(WebCore::Color::darkened const):

platform/graphics/ColorComponents.h:

(WebCore::mapColorComponents):

platform/graphics/ColorConversion.cpp:

(WebCore::toLinear):
(WebCore::toGammaEncoded):
(WebCore::A98RGB<float>>::convert):
(WebCore::LinearA98RGB<float>>::convert):
(WebCore::DisplayP3<float>>::convert):
(WebCore::LinearDisplayP3<float>>::convert):
(WebCore::ExtendedSRGBA<float>>::convert):
(WebCore::LinearExtendedSRGBA<float>>::convert):
(WebCore::ProPhotoRGB<float>>::convert):
(WebCore::LinearProPhotoRGB<float>>::convert):
(WebCore::Rec2020<float>>::convert):
(WebCore::LinearRec2020<float>>::convert):
(WebCore::SRGBA<float>>::convert):
(WebCore::LinearSRGBA<float>>::convert):
(WebCore::xyzToLinear):
(WebCore::linearToXYZ):
(WebCore::XYZFor<LinearA98RGB<float>>>::convert):
(WebCore::XYZFor<LinearDisplayP3<float>>>::convert):
(WebCore::XYZFor<LinearExtendedSRGBA<float>>>::convert):
(WebCore::XYZFor<LinearProPhotoRGB<float>>>::convert):
(WebCore::XYZFor<LinearRec2020<float>>>::convert):
(WebCore::XYZFor<LinearSRGBA<float>>>::convert):
(WebCore::Lab<float>>::convert):
(WebCore::XYZFor<Lab<float>>>::convert):
(WebCore::XYZFor<A98RGB<float>>>::convert):
(WebCore::XYZFor<DisplayP3<float>>>::convert):
(WebCore::XYZFor<ExtendedSRGBA<float>>>::convert):
(WebCore::HSLA<float>>::convert):
(WebCore::XYZFor<HSLA<float>>>::convert):
(WebCore::HWBA<float>>::convert):
(WebCore::XYZFor<HWBA<float>>>::convert):
(WebCore::LCHA<float>>::convert):
(WebCore::XYZFor<LCHA<float>>>::convert):
(WebCore::XYZFor<ProPhotoRGB<float>>>::convert):
(WebCore::XYZFor<Rec2020<float>>>::convert):
(WebCore::XYZFor<SRGBA<float>>>::convert):
(WebCore::LinearA98RGB<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::LinearDisplayP3<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::LinearExtendedSRGBA<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::LinearProPhotoRGB<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::LinearRec2020<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::LinearSRGBA<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::Lab<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::A98RGB<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::DisplayP3<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::ExtendedSRGBA<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::HSLA<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::HWBA<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::LCHA<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::ProPhotoRGB<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::Rec2020<float>::ReferenceXYZ>::convert): Deleted.
(WebCore::SRGBA<float>::ReferenceXYZ>::convert): Deleted.

platform/graphics/ColorConversion.h:

(WebCore::ColorConversion::convert):

platform/graphics/ColorTypes.h:

(WebCore::asColorComponents):

platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::blendPixel):
(WebCore::ImageBackingStore::pixelValue const):

platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::makeSimpleColorFromARGBCFArray):

platform/graphics/cg/ColorCG.cpp:

(WebCore::roundAndClampToSRGBALossy):

platform/graphics/filters/FilterOperation.h:
platform/graphics/mac/ColorMac.mm:

(WebCore::makeSimpleColorFromNSColor):

platform/ios/ColorIOS.mm:

(WebCore::colorFromUIColor):

Source/WebKit:

UIProcess/API/wpe/WebKitColor.cpp:

(webkitColorToWebCoreColor):
Update to specify SRGBA<float>, which is now required due to lack of deduction guides through
type aliases.

8:28 AM Changeset in webkit [272730] by Chris Dumez

2 edits in trunk/Source/WebCore

Audio is sometimes distorted when using createMediaElementSource
https://bugs.webkit.org/show_bug.cgi?id=221553

Reviewed by Eric Carlson.

AudioSourceProviderAVFObjC::provideInput() was calculating the number of
frames available in the RingBuffer like so:
endFrame - (m_readCount + writeAheadCount)

The issue is that when writeAheadCount is greater than 0, (m_readCount + writeAheadCount)
can become greater than endFrame, causing us to end up with a super large number of
available frames. This can lead us to render garbage because we may be reading more
frames than available the RingBuffer.

I have also made a change in the case where rendering has already started were we ignore
writeAheadCount and render whatever we have in the RingBuffer. After we've started rendering,
deciding not to render because of writeAheadCount, even though there are available frames
in the RingBuffer, is really hurtful to user experience. This was reproducible on
https://www.waveplayer.info/createmediaelementsource-test/ where we would start rendering
for a bit, then output silence and then pick up rendering again (this time for good).

platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::provideInput):

8:22 AM Changeset in webkit [272729] by Russell Epstein

1 copy in tags/Safari-612.1.3

Tag Safari-612.1.3.

8:09 AM Changeset in webkit [272728] by Simon Fraser

2 edits in trunk/Source/WebKit

Crash when UI-side compositing is enabled on macOS
https://bugs.webkit.org/show_bug.cgi?id=221740

Reviewed by Tim Horton.

When UI-side compositing is enabled on macOS, WebProcess::updatePageScreenProperties()
crashes because allOf(m_pageMap.values(), ...) return a null WebPage. We're inside
WebProcess::createWebPage() here, so haven't set the HashMap value yet.

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::updatePageScreenProperties):

8:06 AM Changeset in webkit [272727] by Chris Lord

6 edits in trunk/Source/WebCore

Remove FontSelector dependence in CSSFontFace when creating a new FontFace wrapper
https://bugs.webkit.org/show_bug.cgi?id=221753

Reviewed by Myles C. Maxfield.

Add a parameter to the CSSFontFace-based FontFace constructor to allow
specifying the ScriptExecutionContext and therefore allow removal of
another dependence on m_fontSelector in CSSFontFace.

No new tests because there is no behavior change.

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::wrapper):

css/CSSFontFace.h:
css/FontFace.cpp:

(WebCore::FontFace::create):
(WebCore::FontFace::FontFace):

css/FontFace.h:
css/FontFaceSet.cpp:

(WebCore::FontFaceSet::Iterator::next):
(WebCore::FontFaceSet::load):

7:25 AM Changeset in webkit [272726] by Manuel Rego Casasnovas

4 edits
1 copy
1 add in trunk/LayoutTests

Add more Selenium key codes for test_driver.send_keys()
https://bugs.webkit.org/show_bug.cgi?id=221674

Reviewed by Carlos Garcia Campos.

LayoutTests/imported/w3c:

Add more Selenium key codes (https://seleniumhq.github.io/selenium/docs/api/py/webdriver/selenium.webdriver.common.keys.html).
Not all of them are added, only the ones that are supported in eventSender.keyDown().

web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt: Updated expectations

as this test was using the code for ENTER.

web-platform-tests/resources/testdriver-vendor.js:

LayoutTests:

platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt.

6:56 AM Changeset in webkit [272725] by Alan Bujtas

6 edits in trunk/Source/WebCore

[LFC][IFC] Introduce dedicated logical rect getter for each inline level box type
https://bugs.webkit.org/show_bug.cgi?id=221725

Reviewed by Antti Koivisto.

This helps when different type of rects (margin vs. border) are returned for different type of boxes.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::logicalRectForTextRun const):
(WebCore::Layout::LineBox::logicalRectForLineBreakBox const):
(WebCore::Layout::LineBox::logicalRectForInlineLevelBox const):
(WebCore::Layout::LineBox::logicalMarginRectForAtomicInlineLevelBox const):
(WebCore::Layout::LineBox::logicalRectForInlineBox const):
(WebCore::Layout::LineBox::logicalMarginRectForInlineLevelBox const): Deleted.

layout/inlineformatting/InlineLineBox.h:
layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayNonRootInlineBoxes const):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::showInlineTreeAndRuns):

6:46 AM Changeset in webkit [272724] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Inline boxes have incorrect content box height/width values
https://bugs.webkit.org/show_bug.cgi?id=221739

Reviewed by Antti Koivisto.

Do not include horizontal and vertical padding and borders when computing the content box size.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::logicalRectForInlineBox const):

6:44 AM Changeset in webkit [272723] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Add syscall to allow list in WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=221705
<rdar://problem/74162777>

Reviewed by Brent Fulgham.

Add required syscall to allow list in WebContent sandbox on macOS.

WebProcess/com.apple.WebProcess.sb.in:

6:40 AM Changeset in webkit [272722] by youenn@apple.com

2 edits in trunk/LayoutTests

Remove GPUProcess flag in MediaRecorder tests
https://bugs.webkit.org/show_bug.cgi?id=221401

Reviewed by Eric Carlson.

We will remove http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html once rdar://problem/74043225 is fixed.

http/wpt/mediarecorder/pause-recording.html:

Increase timer to cope with added latency introduced by IPC messaging.

6:18 AM Changeset in webkit [272721] by svillar@igalia.com

12 edits in trunk/Source

Non unified build fixes for mid February 2021
https://bugs.webkit.org/show_bug.cgi?id=221749

Reviewed by Youenn Fablet.

Source/WebCore:

CMakeLists.txt:
Modules/mediastream/SFrameUtils.cpp:
Modules/mediastream/STUNMessageParsing.h:
bindings/js/WebCoreBuiltinNames.h:
dom/EventTargetFactory.in:
inspector/InspectorFrontendAPIDispatcher.cpp:

(WebCore::InspectorFrontendAPIDispatcher::evaluateOrQueueExpression):

workers/DedicatedWorkerGlobalScope.cpp:
workers/Worker.cpp:

Source/WebKit:

GPUProcess/graphics/RemoteRenderingBackend.cpp:
GPUProcess/media/RemoteCDMInstanceProxy.cpp:

5:42 AM Changeset in webkit [272720] by svillar@igalia.com

2 edits in trunk/LayoutTests

Unreviewed test gardening.

platform/ios/TestExpectations: Replaced Failure by ImageOnlyFailure for a couple of tests I imported yesterday.

3:08 AM Changeset in webkit [272719] by youenn@apple.com

7 edits
1 copy
2 moves
1 add in trunk/Source/WebKit

Split RemoteRealtimeMediaSource in two audio-specific and video-specific classes
https://bugs.webkit.org/show_bug.cgi?id=221608

Reviewed by Eric Carlson.

Split RemoteRealtimeMediaSource in RemoteRealtimeAudioSource and RemoteRealtimeVideoSource.
This will allow RemoteRealtimeVideoSource to become a RealtimeVideoCaptureSource in a follow-up
to properly handle fan-out to multiple clones with various frame rates and resolutions.
This also allows removing differences of behaviors between audio and video classes.

No change of behavior.

SourcesCocoa.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/cocoa/RemoteCaptureSampleManager.cpp:

(WebKit::RemoteCaptureSampleManager::addSource):
(WebKit::RemoteCaptureSampleManager::didUpdateSourceConnection):
(WebKit::RemoteCaptureSampleManager::RemoteAudio::RemoteAudio):

WebProcess/cocoa/RemoteCaptureSampleManager.h:
WebProcess/cocoa/RemoteRealtimeAudioSource.cpp: Added.

(WebKit::RemoteRealtimeAudioSource::create):
(WebKit::RemoteRealtimeAudioSource::RemoteRealtimeAudioSource):
(WebKit::RemoteRealtimeAudioSource::createRemoteMediaSource):
(WebKit::RemoteRealtimeAudioSource::~RemoteRealtimeAudioSource):
(WebKit::RemoteRealtimeAudioSource::whenReady):
(WebKit::RemoteRealtimeAudioSource::didFail):
(WebKit::RemoteRealtimeAudioSource::setAsReady):
(WebKit::RemoteRealtimeAudioSource::setCapabilities):
(WebKit::RemoteRealtimeAudioSource::setSettings):
(WebKit::RemoteRealtimeAudioSource::remoteAudioSamplesAvailable):
(WebKit::RemoteRealtimeAudioSource::connection):
(WebKit::RemoteRealtimeAudioSource::startProducingData):
(WebKit::RemoteRealtimeAudioSource::stopProducingData):
(WebKit::RemoteRealtimeAudioSource::capabilities):
(WebKit::RemoteRealtimeAudioSource::applyConstraints):
(WebKit::RemoteRealtimeAudioSource::applyConstraintsSucceeded):
(WebKit::RemoteRealtimeAudioSource::applyConstraintsFailed):
(WebKit::RemoteRealtimeAudioSource::hasEnded):
(WebKit::RemoteRealtimeAudioSource::captureStopped):
(WebKit::RemoteRealtimeAudioSource::captureFailed):
(WebKit::RemoteRealtimeAudioSource::gpuProcessConnectionDidClose):

WebProcess/cocoa/RemoteRealtimeAudioSource.h: Copied from Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.h.

(WebKit::RemoteRealtimeAudioSource::identifier const):

WebProcess/cocoa/RemoteRealtimeVideoSource.cpp: Renamed from Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp.

(WebKit::RemoteRealtimeVideoSource::create):
(WebKit::RemoteRealtimeVideoSource::RemoteRealtimeVideoSource):
(WebKit::RemoteRealtimeVideoSource::createRemoteMediaSource):
(WebKit::RemoteRealtimeVideoSource::~RemoteRealtimeVideoSource):
(WebKit::RemoteRealtimeVideoSource::whenReady):
(WebKit::RemoteRealtimeVideoSource::didFail):
(WebKit::RemoteRealtimeVideoSource::setAsReady):
(WebKit::RemoteRealtimeVideoSource::clone):
(WebKit::RemoteRealtimeVideoSource::setCapabilities):
(WebKit::RemoteRealtimeVideoSource::setSettings):
(WebKit::RemoteRealtimeVideoSource::remoteVideoSampleAvailable):
(WebKit::RemoteRealtimeVideoSource::connection):
(WebKit::RemoteRealtimeVideoSource::startProducingData):
(WebKit::RemoteRealtimeVideoSource::stopProducingData):
(WebKit::RemoteRealtimeVideoSource::setShouldApplyRotation):
(WebKit::RemoteRealtimeVideoSource::capabilities):
(WebKit::RemoteRealtimeVideoSource::applyConstraints):
(WebKit::RemoteRealtimeVideoSource::applyConstraintsSucceeded):
(WebKit::RemoteRealtimeVideoSource::applyConstraintsFailed):
(WebKit::RemoteRealtimeVideoSource::hasEnded):
(WebKit::RemoteRealtimeVideoSource::captureStopped):
(WebKit::RemoteRealtimeVideoSource::captureFailed):
(WebKit::RemoteRealtimeVideoSource::stopBeingObserved):
(WebKit::RemoteRealtimeVideoSource::requestToEnd):
(WebKit::RemoteRealtimeVideoSource::gpuProcessConnectionDidClose):

WebProcess/cocoa/RemoteRealtimeVideoSource.h: Renamed from Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.h.
WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::addAudioSource):
(WebKit::UserMediaCaptureManager::removeAudioSource):
(WebKit::UserMediaCaptureManager::addVideoSource):
(WebKit::UserMediaCaptureManager::removeVideoSource):
(WebKit::UserMediaCaptureManager::sourceStopped):
(WebKit::UserMediaCaptureManager::sourceEnded):
(WebKit::UserMediaCaptureManager::captureFailed):
(WebKit::UserMediaCaptureManager::sourceMutedChanged):
(WebKit::UserMediaCaptureManager::sourceSettingsChanged):
(WebKit::UserMediaCaptureManager::remoteVideoSampleAvailable):
(WebKit::UserMediaCaptureManager::applyConstraintsSucceeded):
(WebKit::UserMediaCaptureManager::applyConstraintsFailed):
(WebKit::UserMediaCaptureManager::AudioFactory::createAudioCaptureSource):
(WebKit::UserMediaCaptureManager::VideoFactory::createVideoCaptureSource):
(WebKit::UserMediaCaptureManager::DisplayFactory::createDisplayCaptureSource):

WebProcess/cocoa/UserMediaCaptureManager.h:

(WebKit::UserMediaCaptureManager::remoteCaptureSampleManager):

2:55 AM Changeset in webkit [272718] by commit-queue@webkit.org

4 edits in trunk

Handle min-width/min-height:auto for aspect-ratio
https://bugs.webkit.org/show_bug.cgi?id=220582

Patch by Rob Buis <rbuis@igalia.com> on 2021-02-11
Reviewed by Antti Koivisto.

Source/WebCore:

Implement automatic minimum size [1] handling for aspect-ratio
as specified here [2].

[1] https://drafts.csswg.org/css-sizing-3/#automatic-minimum-size
[2] https://drafts.csswg.org/css-sizing-4/#aspect-ratio-minimum

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalWidthInFragmentByMinMax const):
(WebCore::RenderBox::constrainLogicalHeightByMinMax const):
(WebCore::RenderBox::computePositionedLogicalWidthUsing const):
(WebCore::RenderBox::computePositionedLogicalHeight const):
(WebCore::RenderBox::computePositionedLogicalHeightUsing const):

LayoutTests:

Enable tests that pass now.

TestExpectations:

2:30 AM Changeset in webkit [272717] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.30.5

WebKitGTK 2.30.5

2:29 AM Changeset in webkit [272716] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.30.5 release

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.30.5.

2:06 AM Changeset in webkit [272715] by mmaxfield@apple.com

6 edits
4 adds in trunk

Remove another use of FontSelector from within CSSFontFace
https://bugs.webkit.org/show_bug.cgi?id=221071

Reviewed by Darin Adler.

Source/WebCore:

Instead of CSSFontFace directly knowing about CSSFontSelector, we can just make CSSFontSelector
inherit from CSSFontFace::Client.

Also, clean up the callback methods a little bit.

Tests: fast/text/font-loading-multiple-documents.html

fast/text/font-loading-multiple-sets.html

css/CSSFontFace.cpp:

(WebCore::iterateClients):
(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::fontLoadEventOccurred):
(WebCore::CSSFontFace::updateStyleIfNeeded):

css/CSSFontFace.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::fontLoaded):
(WebCore::CSSFontSelector::fontStyleUpdateNeeded):

css/CSSFontSelector.h:

LayoutTests:

fast/text/font-loading-multiple-documents-expected.html: Added.
fast/text/font-loading-multiple-documents.html: Added.
fast/text/font-loading-multiple-sets-expected.txt: Added.
fast/text/font-loading-multiple-sets.html: Added.

1:31 AM Changeset in webkit [272714] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r272646 - [GStreamer] Make m_client WeakPtr in AudioSourceProviderGStreamer
https://bugs.webkit.org/show_bug.cgi?id=217952

Reviewed by Carlos Garcia Campos.

platform/audio/AudioSourceProviderClient.h: Turned into

CanMakeWeakPtr.

platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:

(WebCore::AudioSourceProviderGStreamer::setClient): Adapt to use
WeakPtr.

platform/audio/gstreamer/AudioSourceProviderGStreamer.h: Turned

m_client into WeakPtr.

1:31 AM Changeset in webkit [272713] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r270184 - [GStreamer] AudioSourceProvider can potentially invoke an already-freed client
https://bugs.webkit.org/show_bug.cgi?id=217952

Reviewed by Xabier Rodriguez-Calvar.

platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:

(WebCore::AudioSourceProviderGStreamer::deinterleavePadsConfigured): Check the provider has
a client before setting up the audio format.

1:29 AM Changeset in webkit [272712] by Lauro Moura

3 edits in trunk/Tools

[Flatpak SDK] Support multiple builds running at the same time
https://bugs.webkit.org/show_bug.cgi?id=221711

Reviewed by Philippe Normand.

Instead of writing the environment to a file, read the --setenv
arguments from the --args file descriptor passed to webkit-bwrap like
bwrap itself would do.

flatpak/flatpakutils.py: Do not write the env file anymore

(WebkitFlatpak.run_in_sandbox):

flatpak/webkit-bwrap: Read the environment from the args file

descriptor.

12:44 AM Changeset in webkit [272711] by commit-queue@webkit.org

7 edits
2 adds in trunk

the nested grid container which has replaced item with 'max-height' has wrong width(0px).
https://bugs.webkit.org/show_bug.cgi?id=219194

Patch by Ziran Sun <Ziran Sun> on 2021-02-11
Reviewed by Javier Fernandez.
LayoutTests/imported/w3c:

The test is imported from WPT.

web-platform-tests/css/css-grid/grid-items/grid-auto-margin-and-replaced-item-001-expected.html: Added.
web-platform-tests/css/css-grid/grid-items/grid-auto-margin-and-replaced-item-001.html: Added.
web-platform-tests/css/css-sizing/percentage-height-in-flexbox-expected.txt: Added.

Source/WebCore:

Width of a nested grid container with margin:auto returns 0 when their item has "max-height".
This causes the grid item's position wrong due to the wrongly comuputed auto-margin value.
This change is to check whether the preferred logical width is dirty when the grid area changes.

It's a reland of r272338, which got reverted because it broken
imported/w3c/web-platform-tests/css/css-sizing/percentage-height-in-flexbox.html on ios. This change
actually fixes the test failure in the flexbox test. Hence, updating test expectation file of
the flexbox test seems working.

This is an import of Chromium change at
https://chromium-review.googlesource.com/c/chromium/src/+/2503910
This change also imported needsPreferredWidthsRecalculation() from Chromium to RenderReplaced to
address the test case specified here.

Test: imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-auto-margin-and-replaced-item-001.html

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::needsPreferredWidthsRecalculation const):

rendering/RenderReplaced.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed