Timeline
Apr 25, 2021:
- 10:51 PM Changeset in webkit [276581] by
-
- 2 edits in trunk/Tools
Add an option to not enable all experimental features in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=225041
Reviewed by Wenson Hsieh.
Added --no-enable-all-experimental-features to DumpRenderTree as we did
for WebKitTestRunner in r276559.
- DumpRenderTree/mac/DumpRenderTree.mm:
(setWebPreferencesForTestOptions):
(initializeGlobalsFromCommandLineOptions):
- 10:24 PM Changeset in webkit [276580] by
-
- 4 edits in trunk/LayoutTests
Unreviewesd EWS fixes.
Skip http/tests/security/referrer-policy-header-multipart.html on WebKit1
after r276526 split it out of http/tests/security/referrer-policy-header.html
- platform/mac-wk1/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 7:05 PM Changeset in webkit [276579] by
-
- 2 edits in trunk/LayoutTests
[WinCairo] Unreviewed test gardening
- platform/wincairo/TestExpectations:
- 6:03 PM Changeset in webkit [276578] by
-
- 6 edits2 adds in trunk
Fix a crash caused by AVIF decoding failure
https://bugs.webkit.org/show_bug.cgi?id=223843
<rdar://problem/76205084>
Reviewed by Philippe Normand.
Source/WebCore:
A crash happens when the image count is accessed in AVIFImageDecoder::tryDecodeSize.
This is because an instance of AVIFImageReader is destroyed by setFailed()
in AVIFImageReader::parseHeader. Deciding a failure was hasty because
parsing can fail when necessary data is not received yet. To fix this,
we call setFailed in AVIFImageReader::parseHeader only when all data is received.
Test: http/tests/images/avif-partial-load-crash.html
- platform/image-decoders/avif/AVIFImageDecoder.cpp:
(WebCore::AVIFImageDecoder::tryDecodeSize):
- platform/image-decoders/avif/AVIFImageReader.cpp:
(WebCore::AVIFImageReader::parseHeader):
(WebCore::AVIFImageReader::repetitionCount const):
- platform/image-decoders/avif/AVIFImageReader.h:
LayoutTests:
Check if partial load of avif images crashes.
- TestExpectations: Skip the test for non-gtk platforms.
- http/tests/images/avif-partial-load-crash-expected.txt: Added.
- http/tests/images/avif-partial-load-crash.html: Added.
- 3:59 PM Changeset in webkit [276577] by
-
- 6 edits in trunk
Fix handling of overflow of /= and *= operators with double over Checked<uint64_t> and other 64-bit types.
https://bugs.webkit.org/show_bug.cgi?id=224835
Reviewed by Chris Dumez.
Source/WebCore:
- platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm:
(WebCore::GPUBindGroupAllocator::reallocate): Use integer math instead of floating point math to increase
the size by 25% each time through the loop, staying within the capabilities of our checked integer class.
Source/WTF:
- wtf/CheckedArithmetic.h: Since it is quite difficult to write correct implementations of the
operations where we multiply or divide a checked integer by a floating point number, deleted
those functions, which were barely used. Also corrected return types of various member functions,
which were unconventional "const Type", replacing them with the conventional "Type" for functions
that return a distinct value, "Type&" for assignment operators, and bool for relational operators.
Tools:
- TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
Removed tests of the "/=" operator with floating point arguments, no longer supported.
- 3:53 PM Changeset in webkit [276576] by
-
- 5 edits in trunk/Source/WebCore
Remove templated operator<<(TextStream&, T*) that interferes with raw pointer formatting.
https://bugs.webkit.org/show_bug.cgi?id=224962
Reviewed by Darin Adler.
We can end up calling into this one (which unhelpfully casts its
argument to intptr_t) instead of theconst void*one in
TextStream.h.
Removing this means we can drop static_cast<const void*>(...) in
various places in debugging output code.
- rendering/RenderLayer.cpp:
(WebCore::outputPaintOrderTreeRecursive):
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeStandardPrefix):
- rendering/svg/SVGRenderTreeAsText.h:
- 3:06 PM Changeset in webkit [276575] by
-
- 24 edits1 delete in trunk/Source/WebCore
Make more IndexedDB objects iso-heap'ed
https://bugs.webkit.org/show_bug.cgi?id=225029
Reviewed by Darin Adler.
Deployed IsoHeap on more IndexedDB objects.
- Modules/indexeddb/IDBFactory.cpp:
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBGetAllResult.cpp:
- Modules/indexeddb/IDBGetAllResult.h:
- Modules/indexeddb/IDBGetResult.cpp:
- Modules/indexeddb/IDBGetResult.h:
- Modules/indexeddb/IDBIndex.cpp:
- Modules/indexeddb/IDBIndex.h:
- Modules/indexeddb/IDBKey.cpp:
- Modules/indexeddb/IDBKey.h:
- Modules/indexeddb/IDBObjectStore.cpp:
- Modules/indexeddb/IDBObjectStore.h:
- Modules/indexeddb/IDBRecordIdentifier.h: Removed since it's not used anywhere.
- Modules/indexeddb/IDBRequest.cpp:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
- Modules/indexeddb/client/IDBConnectionProxy.h:
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/TransactionOperation.cpp:
- Modules/indexeddb/client/TransactionOperation.h:
- Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
- Modules/indexeddb/shared/IDBDatabaseInfo.h:
- WebCore.xcodeproj/project.pbxproj:
- 2:45 PM Changeset in webkit [276574] by
-
- 9 edits1 delete in trunk/Source
Add
ALWAYS_LOG_WITH_STREAMmacro for easier development/debugging
https://bugs.webkit.org/show_bug.cgi?id=224959
Reviewed by Darin Adler.
It's often very helpful to use existing
operator<<defined on objects, but annoying to
have to copypaste the boilerplate code that creates aWTF::TextStreamand uses it in a
WTFLogAlwaysor wait for a debug build to enable existingLOG_WITH_STREAM.
Source/WebCore:
- platform/Logging.h:
Move contents of
pal/LogMacros.htowtf/Assertions.h.
Source/WebCore/PAL:
- pal/LogMacros.h: Removed.
- PAL.xcodeproj/project.pbxproj:
- pal/CMakeLists.txt:
Move contents of
pal/LogMacros.htowtf/Assertions.h.
Source/WebKit:
- Platform/Logging.h:
Move contents of
pal/LogMacros.htowtf/Assertions.h.
Source/WTF:
- wtf/Assertions.h:
(LOG_WITH_STREAM): Moved from
Source/WebCore/pal/LogMacros.h.
(ALWAYS_LOG_WITH_STREAM): Added.
AddALWAYS_LOG_WITH_STREAMso that one change existingLOGwhen debugging with minimal
friction. As an example, many times I've wished I could've just changed
`
LOG_WITH_STREAM(Channel, stream << node);
`
to something like
`
ALWAYS_LOG_WITH_STREAM(stream << node);
`
and avoid having to modify the surrounding code too much.
- 2:09 PM Changeset in webkit [276573] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Audit: REGRESSION(?): creating a new test in Edit mode causes the Results folder to appear
https://bugs.webkit.org/show_bug.cgi?id=224994
Reviewed by Darin Adler.
- UserInterface/Views/AuditNavigationSidebarPanel.js:
(WI.AuditNavigationSidebarPanel.prototype._addTest):
- 2:00 PM Changeset in webkit [276572] by
-
- 8 edits1 add in trunk
[css-flexbox] Table layout disregards overriding width
https://bugs.webkit.org/show_bug.cgi?id=224934
Patch by Felipe Erias <Felipe Erias> on 2021-04-25
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update expectations.
- web-platform-tests/css/css-flexbox/table-with-percent-intrinsic-width-expected.txt: This test now passes.
Source/WebCore:
If a table's parent has set an overriding width on it, that value will get preference over the one from
the table's "width" property. This fixes several tests where the width assigned by the flexbox algorithm
did not match the width of the table after layout.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::applyPreferredLogicalWidthQuirks const): Give precedence to the element's
overriding width if it has been set.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth): Give precedence to the element's overriding width if it
has been set, instead of discarding it if it is smaller than the style width.
(WebCore::RenderTable::computePreferredLogicalWidths): Take the overriding width into account when
computing the preferred min/max values for the element.
LayoutTests:
- TestExpectations: Remove three WPT tests that now pass.
- platform/glib/TestExpectations: Remove one WPT test that now passes.
- platform/gtk/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt: Added.
- 1:38 PM Changeset in webkit [276571] by
-
- 5 edits in trunk/Source/WebKit
[GPUP] REGRESSION: Selecting play/pause on Spotify.com causes page to reload
https://bugs.webkit.org/show_bug.cgi?id=225023
<rdar://76985997>
Reviewed by Darin Adler.
A zero ObjectIdentifier is apparently invalid, which causes a debug ASSERT on the sending
side and a SIGKILL on the receiving side. Replace the zero ObjectIdentifier message when
clearing a LegacyCDMSession with an Optional<ObjectIdentifier>, and send an explicit
WTF::nullopt when clearing.
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerCachedKeyForKeyId const):
(WebKit::RemoteMediaPlayerProxy::setLegacyCDMSession):
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::setCDMSession):
- 1:32 PM Changeset in webkit [276570] by
-
- 5 edits in trunk/Source/WebKit
[GPUP][iOS] Silent video playback can interrupt system audio
https://bugs.webkit.org/show_bug.cgi?id=225031
<rdar://76652073>
Reviewed by Eric Carlson.
When the WebContent process asks the GPU Process to set the AVAudioSession audio session
category, the GPU Process as an optimization returns early if the session category being
requested is the same as has already been set. However, the default value of the category
is "None" (which translates to AVAudioSessionCategoryAmbient), and setting the category
to "None" becomes a no-op due to this default. As such, the GPUP never sets the underlying
AVAudioSession's category away from the default, which is AVAudioSessionCategorySoloAmbient,
and thus will interrupt other audio during playback.
Additionally, there's a subtle logic error where the audio session category is not changed
when a given WebContent process (and it's RemoteAudioSession & Proxy) goes away.
The fix for both of these issues is to re-calculate the correct audio session category
when a RemoteAudioSessionProxy is added or removed from RemoteAudioSessionProxyManager.
Since "None" is the default value for a RemoteAudioSessionProxy, the mere act of adding
a new RemoteAudioSessionProxy (which is created when a WebContent process is created)
will cause the audio session category to be set to AVAudioSessionCategoryAmbient.
- GPUProcess/media/RemoteAudioSessionProxy.cpp:
(WebKit::RemoteAudioSessionProxy::setCategory):
- GPUProcess/media/RemoteAudioSessionProxy.h:
- GPUProcess/media/RemoteAudioSessionProxyManager.cpp:
(WebKit::RemoteAudioSessionProxyManager::addProxy):
(WebKit::RemoteAudioSessionProxyManager::removeProxy):
(WebKit::RemoteAudioSessionProxyManager::updateCategory):
(WebKit::RemoteAudioSessionProxyManager::setCategoryForProcess): Deleted.
- GPUProcess/media/RemoteAudioSessionProxyManager.h:
- 12:17 PM Changeset in webkit [276569] by
-
- 7 edits in trunk/Source/ThirdParty/ANGLE
[Metal ANGLE] support primitive restart behavior with simple data types
https://bugs.webkit.org/show_bug.cgi?id=225011
Primitive restart behavior for simple data types is not defined in Metal. Add a pre-draw pass to
create a set of restart indices, rather than re-write the index buffer. This pass avoids
storing more copies of the index buffer: instead, we cache the location of restart indices, and
use them to build draw lists.
Patch by Kyle Piddington <Kyle Piddington> on 2021-04-25
Reviewed by Dean Jackson.
- src/libANGLE/renderer/metal/BufferMtl.h:
- src/libANGLE/renderer/metal/BufferMtl.mm:
(rx::IndexConversionBufferMtl::IndexConversionBufferMtl):
(rx::BufferMtl::markConversionBuffersDirty):
(rx::calculateRestartRanges):
(rx::BufferMtl::getRestartIndices):
- src/libANGLE/renderer/metal/ContextMtl.h:
- src/libANGLE/renderer/metal/ContextMtl.mm:
(rx::ContextMtl::drawLineLoopElements):
(rx::ContextMtl::drawElementsImpl):
(rx::ContextMtl::drawElementsSimpleTypesPrimitiveRestart): Deleted.
- src/libANGLE/renderer/metal/VertexArrayMtl.h:
- src/libANGLE/renderer/metal/VertexArrayMtl.mm:
(rx::VertexArrayMtl::getIndexBuffer):
(rx::VertexArrayMtl::getDrawIndices):
(rx::VertexArrayMtl::convertIndexBuffer):
(rx::VertexArrayMtl::streamIndexBufferFromClient):
- 12:16 PM Changeset in webkit [276568] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
[Metal ANGLE] Temporarily remove AST validation even for debug builds
https://bugs.webkit.org/show_bug.cgi?id=224991
rdar://76299178
Patch by John Cunningham <johncunningham@apple.com> on 2021-04-25
Reviewed by Kenneth Russell.
- src/libANGLE/renderer/metal/ShaderMtl.mm:
(rx::ShaderMtl::compileImplMtl):
- 12:06 PM Changeset in webkit [276567] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
[Metal ANGLE] Select proper IOSurface backing format for WebGL environment
https://bugs.webkit.org/show_bug.cgi?id=224948
<rdar://76284889>
Depending on the architecture, WebCore expects different
IOSurface texture targets for the main buffer. When running catalyst on
Arm64 devices, Metal-ANGLE needs to select the TEXTURE_2D texture target for our
IOSurface/Pbuffer bind point, rather than TEXTURE_RECTANGLE.
Reviewed by Dean Jackson.
Patch by Kyle Piddington <Kyle Piddington> on 2021-04-25
- src/libANGLE/renderer/metal/DisplayMtl.h:
- src/libANGLE/renderer/metal/DisplayMtl.mm:
(rx::needsEAGLOnMac):
(rx::DisplayMtl::EGLDrawingBufferTextureTarget):
(rx::DisplayMtl::generateConfigs):
- 11:35 AM Changeset in webkit [276566] by
-
- 2 edits in trunk/Source/WebKit
[WebXR] Should be enabled when WEBXR_INTERNALS is true
https://bugs.webkit.org/show_bug.cgi?id=225026
<rdar://problem/77111380>
Reviewed by Sam Weinig.
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultWebXREnabled): Return true when HAVE(WEBXR_INTERNALS).
- 10:43 AM Changeset in webkit [276565] by
-
- 2 edits in trunk/Source/WebCore
css-contain category missing from CSSProperties.json
https://bugs.webkit.org/show_bug.cgi?id=224990
Patch by Tyler Wilcock <Tyler Wilcock> on 2021-04-25
Reviewed by Darin Adler.
- css/CSSProperties.json:
Add missing css-contain category to avoid style lint errors. Example
error:
ERROR: Source/WebCore/css/CSSProperties.json:0: property "contain" has category "css-contain" which is not in the set of categories. [json/syntax] [5]
- 10:39 AM Changeset in webkit [276564] by
-
- 2 edits in trunk/Tools
jsonchecker.py validate_string uses Python 2 basestring type instead of Python 2/3 str type
https://bugs.webkit.org/show_bug.cgi?id=224978
Patch by Tyler Wilcock <Tyler Wilcock> on 2021-04-25
Reviewed by Darin Adler.
validate_string uses the Python 2 basestring type instead of the Python 2/3
str type. This causes the check to exit early the first time it validates
a string with this error:
name 'basestring' is not defined
This resulted in jsonchecker not checking the file beyond the first
string validation.
I believe this caused jsonchecker to miss a bug in one of my previous
patches in which I put the "settings-flag" property in the wrong
place:
https://bugs.webkit.org/show_bug.cgi?id=224718#c20
- Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONCSSPropertiesChecker.validate_string):
validate_string with Python 2 / 3 str type instead of Python 2
basestring.
Apr 24, 2021:
- 10:59 PM Changeset in webkit [276563] by
-
- 4 edits in trunk/Source/WebCore
Deploy Ref/RefPtr in DeleteSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=225028
Reviewed by Wenson Hsieh.
Deployed smart pointers in DeleteSelectionCommand.
Also deployed ScriptDisallowedScope around the code which accesses the render tree.
No new tests since there should be no observable behavioral differences.
- editing/DeleteSelectionCommand.cpp:
(WebCore::isTableRowEmpty):
(WebCore::isSpecialHTMLElement): Moved from Editing.cpp.
(WebCore::firstInSpecialElement): Ditto.
(WebCore::lastInSpecialElement): Ditto.
(WebCore::positionBeforeContainingSpecialElement): Ditto. Now returns a pair instead of returning
Position and "returning" the special element via an out argument.
(WebCore::positionAfterContainingSpecialElement): Ditto.
(WebCore::DeleteSelectionCommand::initializeStartEnd):
(WebCore::DeleteSelectionCommand::initializePositionData):
(WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
(WebCore::firstEditablePositionInNode):
(WebCore::DeleteSelectionCommand::insertBlockPlaceholderForTableCellIfNeeded):
(WebCore::DeleteSelectionCommand::removeNode):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
(WebCore::DeleteSelectionCommand::mergeParagraphs):
(WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows):
(WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
(WebCore::DeleteSelectionCommand::doApply):
- editing/Editing.cpp:
(WebCore::isRenderedTable): Return false when the node is not a HTMLElement for consistency.
(WebCore::isSpecialHTMLElement): Moved to DeleteSelectionCommand.cpp.
(WebCore::firstInSpecialElement): Ditto.
(WebCore::lastInSpecialElement): Ditto.
(WebCore::positionBeforeContainingSpecialElement): Ditto.
(WebCore::positionAfterContainingSpecialElement): Ditto.
- editing/Editing.h:
- 7:12 PM Changeset in webkit [276562] by
-
- 15 edits5 adds in trunk
Changing the source of a model element with clipping applied does not update the model
https://bugs.webkit.org/show_bug.cgi?id=224917
Reviewed by Simon Fraser.
Source/WebCore:
Tests: model-element/model-element-contents-layer-updates-with-clipping.html
model-element/model-element-contents-layer-updates.html
Previously, a <model> with a contents clipping layer (e.g. border-radius)
would not reparent its contents layer in the right place when setContentsToModel
was called again (because the source changed), leaving the old model
contents layer in place.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateSublayerList):
Ensure that updateSublayerList always parents contentsLayer in one of its two homes:
under contentsClippingLayer, if it exists; otherwise, directly under the primary layer.
(WebCore::GraphicsLayerCA::setContentsToModel):
Drive-by fix a bug revealed by the tests for this patch: when swapping out the
contents layer in setContentsToModel, we also need to mark ContentsRectsChanged,
or the new contents layer will not get its bounds set during the subsequent flush.
(WebCore::GraphicsLayerCA::setContentsToPlatformLayer):
Remove special-case code that was added to fix this bug just for setContentsToPlatformLayer;
this case is now correctly handled for all contents layers by updateSublayerList.
(WebCore::GraphicsLayerCA::dumpInnerLayer const):
- platform/graphics/GraphicsLayerClient.h:
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::dumpAdditionalProperties):
- platform/graphics/ca/PlatformCALayer.h:
- testing/Internals.cpp:
(WebCore::toPlatformLayerTreeFlags):
- testing/Internals.h:
- testing/Internals.idl:
Add a bit to platformLayerTreeAsText() that makes PlatformCALayerRemoteModelHosting
dump the size of the model that it is hosting, which is used in the test for this bug.
Remove the IncludeOpacity bit since we can just always log opacity if it's not the default.
Source/WebKit:
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteModelHosting.h:
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteModelHosting.mm:
(WebKit::PlatformCALayerRemoteModelHosting::dumpAdditionalProperties):
Add a bit to platformLayerTreeAsText() that makes PlatformCALayerRemoteModelHosting
dump the size of the model that it is hosting, which is used in the test for this bug.
LayoutTests:
- model-element/model-element-contents-layer-updates-expected.txt: Added.
- model-element/model-element-contents-layer-updates-with-clipping-expected.txt: Added.
- model-element/model-element-contents-layer-updates-with-clipping.html: Added.
- model-element/model-element-contents-layer-updates.html: Added.
- model-element/resources/cube.usdz: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac/TestExpectations:
Add tests that ensure that adding a <model> with one source, then changing
it to another, correctly updates the content layer. Test this both
with and without clipping (the without-clipping case passed before this change,
with-clipping failed).
These tests only work on Cocoa ports with UI-side compositing enabled
because they depend on the PlatformCALayer subclass holding on to the model
data (and logging its size) in order to distinguish between the two models.
- 5:50 PM Changeset in webkit [276561] by
-
- 2 edits in trunk/Tools
Rename slave to worker in webkitpy - part 2
https://bugs.webkit.org/show_bug.cgi?id=224988
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/common/system/crashlogs_unittest.py:
- 5:47 PM Changeset in webkit [276560] by
-
- 1 copy in tags/Safari-611.2.5
Tag Safari-611.2.5.
- 5:39 PM Changeset in webkit [276559] by
-
- 8 edits in trunk/Tools
Add an option to not enable all experimental features in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=224958
Reviewed by Tim Horton.
Added --no-enable-all-experimental-features to run-webkit-tests and WebKitTestRunner.
It causes a crash in DumpRenderTree for now. We should rectify this in the future
when we align the behaviors of WebKitTestRunner and DumpRenderTree.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args): Added --no-enable-all-experimental-features.
- Scripts/webkitpy/port/driver.py:
(Driver.cmd_line): Pass along the option to WebKitTestRunner.
- WebKitTestRunner/Options.cpp:
(WTR::handleOptionNoEnableAllExperimentalFeatures): Added.
(WTR::OptionsHandler::OptionsHandler): Added --no-enable-all-experimental-features.
- WebKitTestRunner/Options.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::resetPreferencesToConsistentValues):
- WebKitTestRunner/TestController.h:
- 3:31 PM Changeset in webkit [276558] by
-
- 4 edits2 adds in trunk
Crash in BreakBlockquoteCommand::doApply()
https://bugs.webkit.org/show_bug.cgi?id=224941
Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2021-04-24
Reviewed by Ryosuke Niwa.
Source/WebCore:
Despite assertions to the contrary, it is possible for there not to be any node
to move into the new blockquote in BreakBlockquoteCommand::doApply() as a result
of layout updates, so remove the assertions and handle this case.
Test: editing/pasteboard/paste-as-quotation-then-paste-crash.html
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
LayoutTests:
Add test for this crash, running only on Release for now.
Thanks to Tuomas Karkkainen for its basic structure.
- TestExpectations:
- editing/pasteboard/paste-as-quotation-then-paste-crash-expected.txt: Added.
- editing/pasteboard/paste-as-quotation-then-paste-crash.html: Added.
- 2:29 PM Changeset in webkit [276557] by
-
- 8 edits in branches/safari-611-branch/Source
Versioning.
WebKit-7611.2.5
- 2:21 PM Changeset in webkit [276556] by
-
- 8 edits in branches/safari-611-branch/Source/WebKit
Reland r275846 with Unreviewed crash fix. rdar://77106929
Corrects crash due to bad merge.
- 2:14 PM Changeset in webkit [276555] by
-
- 8 edits in branches/safari-611-branch/Source/WebKit
Revert "Re-land Cherry-pick r275846. rdar://problem/76727548"
This reverts commit r276398.
- 12:36 PM Changeset in webkit [276554] by
-
- 11 edits in trunk
Improve parsing and computed style of the rotate CSS property
https://bugs.webkit.org/show_bug.cgi?id=225019
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Mark 2 WPT progressions and add some new parsing WPT tests for rotate.
- web-platform-tests/css/css-transforms/animation/rotate-composition-expected.txt: We don't support additive interpolation,
the FAIL result is most likely a test that passed without proper support for the feature which now fails due to lack of
support for this feature.
- web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt:
- web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
There were a few issues with how we parsed the rotate CSS property and how we dealt with it
when resolving the computed style.
When parsing, we required individual vector coordinates to be 1 when others were 0 for a vector
to be considered parallel with the x, y or z axis. We now support any positive value. Then, as
we create the TransformOperation from the CSSValue, we must set the type to ROTATE_3D instead
of ROTATE_Z if the z axis was specified through the CSS value. Indeed, ROTATE_Z is equivalent
to ROTATE and without setting this type to ROTATE_3D, TransformOperation::is3DOperation() would
return false.
This is important because when figuring out the computed style, we should only return an angle
without a rotation vector if TransformOperation::is3DOperation() is false. For the case where
the operation was specified in 3D, we now use the same rule used when parsing to determine
whether the rotation vector is parallel with the x, y or z axis to use the matching keywords.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedRotate):
- css/TransformFunctions.cpp:
(WebCore::rotateForValue):
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeRotate):
- 12:35 PM Changeset in webkit [276553] by
-
- 6 edits in trunk
Support interpolation of the background-repeat shorthand
https://bugs.webkit.org/show_bug.cgi?id=225016
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Mark 10 WPT progressions.
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 12:33 PM Changeset in webkit [276552] by
-
- 7 edits in trunk
Fix interpolation of the clip CSS property
https://bugs.webkit.org/show_bug.cgi?id=225017
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Mark 13 WPT progressions.
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt:
Source/WebCore:
While we interpolated the clip value correctly, we wouldn't set the RenderStyle bit that
indicates that there is a non-auto value in the first place. With a new dedicated wrapper,
we can ensure we set the bit correctly as we blend, and that we use discrete interpolation
if both the from and to values aren't auto.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 12:32 PM Changeset in webkit [276551] by
-
- 5 edits in trunk
Computed style for the translate CSS property should use px for the z value
https://bugs.webkit.org/show_bug.cgi?id=225018
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Mark a single WPT progression.
- web-platform-tests/css/css-transforms/animation/translate-composition-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedTranslate):
- 9:02 AM Changeset in webkit [276550] by
-
- 16 edits in trunk
Refactor ValueRange from enum to enum class
https://bugs.webkit.org/show_bug.cgi?id=224981
Patch by Tyler Wilcock <Tyler Wilcock> on 2021-04-24
Reviewed by Sam Weinig.
Source/WebCore:
Refactor ValueRange from:
enum ValueRange {
ValueRangeAll,
ValueRangeNonNegative
}
to:
enum ValueRange : uint8_t {
All,
NonNegative
}
making it smaller (one byte versus four) and harder to misuse (no
auto-coercion to number types).
- animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::create):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- css/CSSCalculationValue.h:
(WebCore::CSSCalcValue::createCalculationValue const):
(WebCore::CSSCalcValue::setPermittedValueRange):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- css/MediaQueryExpression.cpp:
(WebCore::consumeFirstValue):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeTransformOrigin):
(WebCore::consumeLetterSpacing):
(WebCore::consumeWordSpacing):
(WebCore::consumeTabSize):
(WebCore::consumeTextSizeAdjust):
(WebCore::consumeFontSize):
(WebCore::consumeLineHeight):
(WebCore::consumeSize):
(WebCore::consumeTextIndent):
(WebCore::consumeScrollPadding):
(WebCore::consumeMaxWidthOrHeight):
(WebCore::consumeWidthOrHeight):
(WebCore::consumeMarginOrOffset):
(WebCore::consumeClipComponent):
(WebCore::consumeLineClamp):
(WebCore::consumeHyphenateLimit):
(WebCore::consumeColumnWidth):
(WebCore::consumeGapLength):
(WebCore::consumeZoom):
(WebCore::consumeAnimationIterationCount):
(WebCore::consumeAnimationValue):
(WebCore::consumeLineWidth):
(WebCore::consumeTranslate3d):
(WebCore::consumeNumbers):
(WebCore::consumePerspective):
(WebCore::consumeTransformValue):
(WebCore::consumeTranslate):
(WebCore::consumeScale):
(WebCore::consumeRotate):
(WebCore::consumePositionLonghand):
(WebCore::consumeFlexBasis):
(WebCore::consumeKerning):
(WebCore::consumeStrokeDasharray):
(WebCore::consumeBaselineShift):
(WebCore::consumeRxOrRy):
(WebCore::consumeBorderRadiusCorner):
(WebCore::consumeTextUnderlineOffset):
(WebCore::consumeTextDecorationThickness):
(WebCore::consumeVerticalAlign):
(WebCore::consumeShapeRadius):
(WebCore::consumeBasicShapePolygon):
(WebCore::consumeRadii):
(WebCore::consumeBasicShapeInset):
(WebCore::consumeBorderImageSlice):
(WebCore::consumeBorderImageOutset):
(WebCore::consumeBorderImageWidth):
(WebCore::consumeReflect):
(WebCore::consumeBackgroundSize):
(WebCore::consumeFitContent):
(WebCore::consumeGridBreadth):
(WebCore::consumeInitialLetter):
(WebCore::consumeWebkitMarqueeIncrement):
(WebCore::consumeWebkitMarqueeRepetition):
(WebCore::consumeWebkitMarqueeSpeed):
(WebCore::consumeAspectRatio):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::consumeBorderSpacing):
(WebCore::CSSPropertyParser::consumeFlex):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeNumberOrPercentDividedBy100Raw):
(WebCore::CSSPropertyParserHelpers::CalcParser::CalcParser):
(WebCore::CSSPropertyParserHelpers::consumeNumberRaw):
(WebCore::CSSPropertyParserHelpers::consumeFontWeightNumberRaw):
(WebCore::CSSPropertyParserHelpers::consumeLengthRaw):
(WebCore::CSSPropertyParserHelpers::consumePercentRaw):
(WebCore::CSSPropertyParserHelpers::consumeAngleRaw):
(WebCore::CSSPropertyParserHelpers::consumeAngleWorkerSafe):
(WebCore::CSSPropertyParserHelpers::consumeTime):
(WebCore::CSSPropertyParserHelpers::consumePositionComponent):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradientPoint):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeFilterFunction):
(WebCore::CSSPropertyParserHelpers::consumeSingleShadow):
(WebCore::CSSPropertyParserHelpers::consumeFontSizeRaw):
(WebCore::CSSPropertyParserHelpers::consumeLineHeightRaw):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- css/parser/CSSPropertyParserHelpers.h:
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- css/parser/CSSPropertyParserWorkerSafe.cpp:
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontStretch):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontStretchRange):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- page/IntersectionObserver.cpp:
(WebCore::parseRootMargin):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- platform/CalculationValue.h:
(WebCore::CalculationValue::CalculationValue):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- platform/Length.cpp:
(WebCore::convertTo100PercentMinusLength):
(WebCore::blendMixedTypes):
(WebCore::blend):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- platform/Length.h:
Refactor enum ValueRange to enum class ValueRange.
- style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTo100PercentMinusLength):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
Tools:
ValueRange has been refactored from enum to enum class : uint8_t to
make it smaller and harder to misuse.
- TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
(TestWebKitAPI::createTestValue):
Refactor ValueRangeAll and ValueRangeNonNegative to ValueRange::All
and ValueRange::NonNegative.
- 6:42 AM Changeset in webkit [276549] by
-
- 3 edits2 adds in trunk
[RenderTreeBuilder] Subtree moving should clear the floats on all the descendants
https://bugs.webkit.org/show_bug.cgi?id=224996
<rdar://76837320>
Reviewed by Antti Koivisto.
Source/WebCore:
While moving a subtree, we invalidate the floating object list so that we don't end up with incorrectly placed floats (they'll get regenerated during the subsequent layout).
A float can be "assigned" to more than one RenderBlockFlow (e.g intruding floats). It's very common that a set of descendant RenderBlockFlow
renderers "see" the same set of floats (each RenderBlockFlow has its own list of floating objects).
Now the invalidation is based on ancestor-to-descendant direction starting with finding the outer most containing block for a particular float (see outermostBlockContainingFloatingObject)
The invalidation logic also expects no gaps in the ancestor chain e.g.
RenderBlockFlow (A) -> float X
RenderBlockFlow (B) -> float X
RenderBlockFlow (C) -> float X
if float X is assigned to both A and C, then it must be assigned to B as well.
RenderBlockFlow::removeFloatingObjects() simply removes the float from the renderer. It does not invalidate the ancestor/descendant chain.
e.g. calling B.removeFloatingObjects() would just remove float X from RenderBlockFlow (B)
RenderBlockFlow (A) -> float X
RenderBlockFlow (B)
RenderBlockFlow (C) -> float X
and any subsequent invalidation attempt would fail to clear up A or C (depending on whether it is initiated on A or C).
Test: fast/multicol/floating-boxes-moved-under-multi-column.html
- rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::moveChildren):
LayoutTests:
- fast/multicol/floating-boxes-moved-under-multi-column-expected.txt: Added.
- fast/multicol/floating-boxes-moved-under-multi-column.html: Added.
- 6:10 AM Changeset in webkit [276548] by
-
- 2 edits in trunk/Source/WebCore
[LFC] Ignore content height and width when 'contain: size' is present
https://bugs.webkit.org/show_bug.cgi?id=225013
Reviewed by Antti Koivisto.
Enable size containment for "shrink to fit width" and for "height: auto" formatting context roots.
https://www.w3.org/TR/css-contain-2/#size-containment.
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
- 12:41 AM Changeset in webkit [276547] by
-
- 4 edits2 adds in trunk
Move selectedOptions cache invalidation timing
https://bugs.webkit.org/show_bug.cgi?id=224894
Patch by Rob Buis <rbuis@igalia.com> on 2021-04-24
Reviewed by Ryosuke Niwa.
Source/WebCore:
Move selectedOptions cache invalidation timing out
of setSelectedState, having it in setSelectedState
can cause selectedOptions cache invalidation while
determining the cache.
Test: fast/dom/HTMLSelectElement/selected-options-item-crash.html
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setSelectedState):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
LayoutTests:
Add test for this.
- fast/dom/HTMLSelectElement/selected-options-item-crash-expected.txt: Added.
- fast/dom/HTMLSelectElement/selected-options-item-crash.html: Added.
Apr 23, 2021:
- 11:11 PM Changeset in webkit [276546] by
-
- 2 edits in trunk/Source/WebCore
Crash in IndentOutdentCommand::outdentParagraph attempting to move a paragraph
https://bugs.webkit.org/show_bug.cgi?id=224909
Patch by Ian Gilbert <iang@apple.com> on 2021-04-23
Reviewed by Ryosuke Niwa.
Added check inside IndentOutdentCommand::outdentParagraph to ensure that inserting a
HTMLBRElement was successful before attempting to move a paragraph to that node.
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph):
- 5:47 PM Changeset in webkit [276545] by
-
- 2 edits in trunk/Source/WebKit
PCM: debug mode should send the second report on a 10 second delay after the first
https://bugs.webkit.org/show_bug.cgi?id=225010
<rdar://problem/77092303>
Reviewed by John Wilander.
Fix a bug in PCM debug mode where we don't set the timer for 10_s
after sending the first report for an attribution.
No new tests, this is debug mode only. Non-debug mode behavior is
covered by existing tests, and I tested debug mode manually.
- NetworkProcess/PrivateClickMeasurementManager.cpp:
(WebKit::PrivateClickMeasurementManager::firePendingAttributionRequests):
If the attribution has been sent to only one endpoint, indicated by
a non-null laterTimeToSend value, we should set the timer to be 10
seconds if debug mode is enabled.
Also, change the interval time from 1 minute to 10 seconds, because
there was no good reason that it was 1 minute and we should be
consistent. Also 1 minute is a long time to wait during a test.
- 5:40 PM Changeset in webkit [276544] by
-
- 1 copy in tags/Safari-611.2.4
Tag Safari-611.2.4.
- 5:36 PM Changeset in webkit [276543] by
-
- 1 copy in tags/Safari-611.1.21.2.6
Tag Safari-611.1.21.2.6.
- 5:26 PM Changeset in webkit [276542] by
-
- 2 edits in branches/safari-611.1.21.2-branch/Source/JavaScriptCore
Cherry-pick r276527. rdar://problem/77092686
[YARR Interpreter] Improper backtrack of parentheses with non-zero based greedy quantifiers
https://bugs.webkit.org/show_bug.cgi?id=224983
Reviewed by Mark Lam.
When we backtrack a parentheses with a greedy non zero based quantifier,
we don't properly restore for the case where we hadn't reached the minimum count.
We now save the input position on entry and restore it when we backtrack for
this case. We also properly release the allocated ParenthesesDisjunctionContext's.
- yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:26 PM Changeset in webkit [276541] by
-
- 8 edits in branches/safari-611.1.21.2-branch/Source
Versioning.
WebKit-7611.1.21.2.6
- 5:25 PM Changeset in webkit [276540] by
-
- 1 edit2 deletes in trunk/Tools
Delete unused buildbot.css and default.css
https://bugs.webkit.org/show_bug.cgi?id=224997
Reviewed by Alexey Proskuryakov.
- CISupport/build-webkit-org/public_html/buildbot.css: Removed.
- CISupport/build-webkit-org/public_html/default.css: Removed.
- 5:22 PM Changeset in webkit [276539] by
-
- 1 copy in tags/Safari-611.1.21.161.6
Tag Safari-611.1.21.161.6.
- 5:21 PM Changeset in webkit [276538] by
-
- 2 edits in branches/safari-611.1.21.161-branch/Source/JavaScriptCore
Cherry-pick r276527. rdar://problem/77092673
[YARR Interpreter] Improper backtrack of parentheses with non-zero based greedy quantifiers
https://bugs.webkit.org/show_bug.cgi?id=224983
Reviewed by Mark Lam.
When we backtrack a parentheses with a greedy non zero based quantifier,
we don't properly restore for the case where we hadn't reached the minimum count.
We now save the input position on entry and restore it when we backtrack for
this case. We also properly release the allocated ParenthesesDisjunctionContext's.
- yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:21 PM Changeset in webkit [276537] by
-
- 2 edits in branches/safari-611.1.21.161-branch/Source/JavaScriptCore
Cherry-pick r276524. rdar://problem/77092702
Fix B3 strength reduction for shl.
https://bugs.webkit.org/show_bug.cgi?id=224913
rdar://76978874
Reviewed by Michael Saboff.
If the operation can potentially either underflow or overflow, then the result
can be any value.
- b3/B3ReduceStrength.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:18 PM Changeset in webkit [276536] by
-
- 1 edit2 copies1 add1 delete in trunk/Websites/bugs.webkit.org
Bugzilla needs to linkify identifiers (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=224312
<rdar://problem/75845629>
Reviewed by Dewei Zhu.
- extensions/Commits: Moved from Trac.
- extensions/Commits/Config.pm: Changed Plugin name.
- extensions/Commits/Extension.pm: Ditto.
(_replace_revision): Use commit.webkit.org instead of trac.
- extensions/Trac: Moved to Commits.
- 5:18 PM Changeset in webkit [276535] by
-
- 8 edits in branches/safari-611.1.21.161-branch/Source
Versioning.
WebKit-7611.1.21.161.6
- 5:16 PM Changeset in webkit [276534] by
-
- 1 copy in tags/Safari-611.1.21.0.14
Tag Safari-611.1.21.0.14.
- 5:13 PM Changeset in webkit [276533] by
-
- 2 edits in branches/safari-611.1.21.0-branch/Source/JavaScriptCore
Cherry-pick r276527. rdar://problem/77092655
[YARR Interpreter] Improper backtrack of parentheses with non-zero based greedy quantifiers
https://bugs.webkit.org/show_bug.cgi?id=224983
Reviewed by Mark Lam.
When we backtrack a parentheses with a greedy non zero based quantifier,
we don't properly restore for the case where we hadn't reached the minimum count.
We now save the input position on entry and restore it when we backtrack for
this case. We also properly release the allocated ParenthesesDisjunctionContext's.
- yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:13 PM Changeset in webkit [276532] by
-
- 2 edits in branches/safari-611.1.21.0-branch/Source/JavaScriptCore
Cherry-pick r276524. rdar://problem/77092695
Fix B3 strength reduction for shl.
https://bugs.webkit.org/show_bug.cgi?id=224913
rdar://76978874
Reviewed by Michael Saboff.
If the operation can potentially either underflow or overflow, then the result
can be any value.
- b3/B3ReduceStrength.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:08 PM Changeset in webkit [276531] by
-
- 8 edits in branches/safari-611.1.21.0-branch/Source
Versioning.
WebKit-7611.1.21.0.14
- 4:45 PM Changeset in webkit [276530] by
-
- 2 edits in trunk/Source/WebCore
Crash in constructCustomElementSynchronously
https://bugs.webkit.org/show_bug.cgi?id=224992
<rdar://66988026>
Reviewed by Tadeu Zagallo.
Exit early when the global object is nullptr although this shouldn't happen.
No new tests since we have no reproductions.
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::tryToConstructCustomElement): Added a null check.
- 4:38 PM Changeset in webkit [276529] by
-
- 2 edits in branches/safari-611-branch/Source/JavaScriptCore
Cherry-pick r276527. rdar://problem/77091667
[YARR Interpreter] Improper backtrack of parentheses with non-zero based greedy quantifiers
https://bugs.webkit.org/show_bug.cgi?id=224983
Reviewed by Mark Lam.
When we backtrack a parentheses with a greedy non zero based quantifier,
we don't properly restore for the case where we hadn't reached the minimum count.
We now save the input position on entry and restore it when we backtrack for
this case. We also properly release the allocated ParenthesesDisjunctionContext's.
- yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:21 PM Changeset in webkit [276528] by
-
- 3 edits in trunk/Source/WebCore
Add additional guards around USE_ANGLE
https://bugs.webkit.org/show_bug.cgi?id=225001
Reviewed by Fujii Hironori.
When USE(ANGLE) initializeOpenGLShims isn't used or available.
When USE(ANGLE) the ANGLE shader compiler isn't needed.
- platform/graphics/GLContext.cpp:
(WebCore::initializeOpenGLShimsIfNeeded):
- platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:
- 4:06 PM Changeset in webkit [276527] by
-
- 2 edits in trunk/Source/JavaScriptCore
[YARR Interpreter] Improper backtrack of parentheses with non-zero based greedy quantifiers
https://bugs.webkit.org/show_bug.cgi?id=224983
Reviewed by Mark Lam.
When we backtrack a parentheses with a greedy non zero based quantifier,
we don't properly restore for the case where we hadn't reached the minimum count.
We now save the input position on entry and restore it when we backtrack for
this case. We also properly release the allocated ParenthesesDisjunctionContext's.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchParentheses):
(JSC::Yarr::Interpreter::backtrackParentheses):
- 4:01 PM Changeset in webkit [276526] by
-
- 5 edits1 copy2 adds in trunk/LayoutTests
http/tests/security/referrer-policy-header.html is slow
https://bugs.webkit.org/show_bug.cgi?id=224998
Reviewed by Geoffrey Garen.
The test is a flaky timeout on the bots because it is slow. On my machine, it takes 17 seconds to run
it with a debug build. To speed things up, I am now running the subtests in parallel instead of
sequentially. I also split the test in 2 (regular response vs multipart response). Each tests now takes
about ~5 seconds to run on my machine.
- http/tests/security/referrer-policy-header-expected.txt:
- http/tests/security/referrer-policy-header-multipart-expected.txt: Added.
- http/tests/security/referrer-policy-header-multipart.html: Added.
- http/tests/security/referrer-policy-header-test.js: Copied from LayoutTests/http/tests/security/referrer-policy-header.html.
(printResults):
(onmessage):
(runTests):
- http/tests/security/referrer-policy-header.html:
- http/tests/security/resources/postReferrer.py:
- http/tests/security/resources/serve-referrer-policy-and-test.py:
- 3:46 PM Changeset in webkit [276525] by
-
- 2 edits in branches/safari-611-branch/Source/JavaScriptCore
Cherry-pick r276524. rdar://problem/77089783
Fix B3 strength reduction for shl.
https://bugs.webkit.org/show_bug.cgi?id=224913
rdar://76978874
Reviewed by Michael Saboff.
If the operation can potentially either underflow or overflow, then the result
can be any value.
- b3/B3ReduceStrength.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:14 PM Changeset in webkit [276524] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix B3 strength reduction for shl.
https://bugs.webkit.org/show_bug.cgi?id=224913
rdar://76978874
Reviewed by Michael Saboff.
If the operation can potentially either underflow or overflow, then the result
can be any value.
- b3/B3ReduceStrength.cpp:
- 3:06 PM Changeset in webkit [276523] by
-
- 8 edits in trunk/Source/WebKit
Unreviewed, reverting r275562.
https://bugs.webkit.org/show_bug.cgi?id=225002
Causes issues in iOS contextmenu animations and interactions
with other popovers
Reverted changeset:
"[iOS] contextmenu hints can be clipped by the WKWebView"
https://bugs.webkit.org/show_bug.cgi?id=224204
https://trac.webkit.org/changeset/275562
- 3:04 PM Changeset in webkit [276522] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r273154): fast/forms/ios/repeatedly-focus-offscreen-select.html is consistently failing
https://bugs.webkit.org/show_bug.cgi?id=224985
<rdar://problem/77042177>
Reviewed by Wenson Hsieh.
The test is failing after r273154, which made <select> elements present
a UIMenu rather than a popover. The old logic ensured popovers were not
presented when the <select> element was offscreen (see r265117 for more
information on why that behavior was necessary), but the new
presentation omitted that logic.
To achieve the correct behavior, and fix the failing test, <select>
menus should not be presented when the element is offscreen.
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPicker controlBeginEditing]):
- 3:00 PM Changeset in webkit [276521] by
-
- 7 edits in trunk
Not computing image aspect ratios from width and height attributes for lazy loaded images
https://bugs.webkit.org/show_bug.cgi?id=224197
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
The test cases for error images and images without src in img-aspect-ratio.html are passed. This patch
doesn't change the behavior of the original aspect ratio case, so it's failed like before.
- web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio-expected.txt:
Source/WebCore:
This patch supports error images and lazy loaded images (without src attribute) to compute
implicit aspect ratios from width and height attributes. Refactor the code a bit. Added
intrinsicAspectRatioFromWidthHeight() to compute aspect ratio from width and height attributes when
the object is allowed to which is decided by canMapWidthHeightToAspectRatio().
Remove!downcast<RenderImage>(*this).cachedImage()constraint, so that images without src attributes
is allowed. As to error images, compute the aspect ratio when the image shouldDisplayBrokenImageIcon().
- rendering/RenderImage.cpp:
(WebCore::RenderImage::canMapWidthHeightToAspectRatio const): To indicate that the object is allowed
to compute aspect ratio from width and height attributes.
(WebCore::RenderImage::computeIntrinsicRatioInformation const): When shouldDisplayBrokenImageIcon(),
try to compute the aspect ratio from attributes width and height.
- rendering/RenderImage.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::intrinsicAspectRatioFromWidthHeight const): Compute the aspect ratio from attributes width and height.
(WebCore::RenderReplaced::computeIntrinsicRatioInformation const):
- rendering/RenderReplaced.h:
(WebCore::RenderReplaced::canMapWidthHeightToAspectRatio const): Ditto.
- 2:53 PM Changeset in webkit [276520] by
-
- 3 edits in trunk/LayoutTests
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/css-module-worker-test.html is a flakey crash and failure
https://bugs.webkit.org/show_bug.cgi?id=222750
Unreviewed test gardening.
Move expectation to a more general location, this isn't limited to macOS.
- TestExpectations:
- platform/mac/TestExpectations:
- 2:38 PM Changeset in webkit [276519] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, reverting r276451.
https://bugs.webkit.org/show_bug.cgi?id=224999
Broke perf testing
Reverted changeset:
"[iOS] Update sandbox message filter syntax"
https://bugs.webkit.org/show_bug.cgi?id=223384
https://trac.webkit.org/changeset/276451
- 2:32 PM Changeset in webkit [276518] by
-
- 1 edit in branches/safari-611-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
Unreviewed build fix. rdar://problem/76963040
WebKit2/UIProcess/AuxiliaryProcessProxy.cpp:163:10: error: use of undeclared identifier 'isMainRunLoop'
- 2:29 PM Changeset in webkit [276517] by
-
- 13 edits in branches/safari-611-branch/Source
Cherry-pick r276324. rdar://problem/77086404
FullGCActivityCallback should use the percentage of pages uncompressed in RAM to determine deferral.
https://bugs.webkit.org/show_bug.cgi?id=224817
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Right now we try to determine if too many pages are paged out by
dereferencing them and bailing out of the GC if we go over a
deadline. While this works if the only goal is to avoid causing
extensive thrashing on spinny disks (HDD), it doesn't prevent
thrashing when access to disk is fast (e.g. SSD). This is because
on fast disks the proportional time to load the memory from disk
is much lower. Additionally, on SSDs in particular we don't want
to load the pages into RAM then bail as that will force a
different page onto disk, increasing wear.
This patch switches to asking the OS if each MarkedBlock is paged
out. Then if we are over a threshold we wait until we would have
GC'd anyway. This patch uses the (maxVMGrowthFactor - 1) as the
percentage of "slow" pages (paged out or compressed) needed to
defer the GC. The idea behind that threshold is that if we add
that many pages then the same number of pages would be forced
out of RAM for us to do a GC anyway (in the limit).
- heap/BlockDirectory.cpp: (JSC::BlockDirectory::updatePercentageOfPagedOutPages): (JSC::BlockDirectory::isPagedOut): Deleted.
- heap/BlockDirectory.h:
- heap/FullGCActivityCallback.cpp: (JSC::FullGCActivityCallback::doCollection):
- heap/Heap.cpp: (JSC::Heap::isPagedOut):
- heap/Heap.h:
- heap/MarkedSpace.cpp: (JSC::MarkedSpace::isPagedOut):
- heap/MarkedSpace.h:
- runtime/OptionsList.h:
Source/WebKit:
Add mincore to the acceptable syscall list.
- WebProcess/com.apple.WebProcess.sb.in:
Source/WTF:
Add a noexcept flavor of FunctionTraits. On Linux mincore (and probably other syscalls) are marked noexcept so the existing overloads don't work.
- wtf/FunctionTraits.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:01 PM Changeset in webkit [276516] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC][Win] callOperationNoExceptionCheck() also needs to support operations that return SlowPathReturnType
https://bugs.webkit.org/show_bug.cgi?id=224964
Reviewed by Yusuke Suzuki.
r229989 (Bug 183655) added the x64 Windows support only for
callOperation(), but for callOperationNoExceptionCheck().
callOperationNoExceptionCheck() also needs the x64 Windows
support.
This change is a preparation for Bug 224920 that is going to use
callOperationNoExceptionCheck instead of callOperation.
- jit/JIT.h:
(callOperation): Rewrote by using 'if constexpr' instead of SFINAE.
(callOperationNoExceptionCheck): Added a new implementation for
x64 Windows based on callOperation.
- 1:11 PM Changeset in webkit [276515] by
-
- 3 edits in trunk/Source/WebKit
[iOS] GPU Process sandbox lacks IOMobileFramebufferUserClient method filter
https://bugs.webkit.org/show_bug.cgi?id=224956
<rdar://problem/68227590>
Reviewed by Per Arne Vollan.
This patch updates the GPU process sandbox to match the method filter used in the WebContent process
so that we will retain consistent protections when activating the GPU Process. These are the same rules
governing access to this resource when the GPU process is disabled, so should not create a change in behavior.
We also remove unneeded telemetry to reduce messaging burden and avoid performance issues.
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 12:53 PM Changeset in webkit [276514] by
-
- 2 edits in trunk/Source/WebKit
Web Inspector: [Cocoa] WKInspectorResourceURLSchemeHandler needs to serialize cleanup actions
https://bugs.webkit.org/show_bug.cgi?id=224986
<rdar://76768454>
Reviewed by Devin Rousso.
- UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.mm:
(-[WKInspectorResourceURLSchemeHandler webView:startURLSchemeTask:]):
Do cleanup on the main queue so that it can be serialized with reads.
(-[WKInspectorResourceURLSchemeHandler webView:stopURLSchemeTask:]):
Ensure that all removals from the map are processed before doing a lookup.
- 12:51 PM Changeset in webkit [276513] by
-
- 6 edits in trunk/Source/WebCore
Remove virtual function calls in GraphicsLayer destructors
https://bugs.webkit.org/show_bug.cgi?id=180232
Reviewed by Adrian Perez de Castro.
I notice that ~CoordinatedGraphicsLayer makes a virtual function call to
GraphicsLayer::willBeDestroyed, which makes a virtual function call to
CoordinatedGraphicsLayer::removeFromParent. I think that the functions are being called as
intended, because ~CoordinatedGraphicsLayer has not yet been fully destroyed. However, I'm
reminded of Effective C++ item #9: Never call virtual functions during construction or
destruction ("because such calls will never go to a more derived class than that of the
currently executing constructor or destructor"). This code is almost certain to break if
anyone tries in the future to subclass any of the existing subclasses of GraphicsLayer, so
let's refactor it a bit. This doesn't fix anything, but my hope is that it will make the
code a bit harder to break, and not the opposite.
The main risk here is that some reordering of operations is necessary. The derived class
portion of removeFromParent must now be executed before willBeDestroyed. It can't happen
after, because parent would already be unset by that point. It's hard to be certain that
this won't break anything, but I think it should be fine.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::willBeDestroyed):
(WebCore::GraphicsLayer::removeFromParentInternal):
(WebCore::GraphicsLayer::removeFromParent):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::~GraphicsLayerCA):
(WebCore::GraphicsLayerCA::willBeDestroyed): Deleted.
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
- 12:34 PM Changeset in webkit [276512] by
-
- 4 edits2 adds in trunk/Tools
Add a conftest.py to run existing webkitpy tests in pytest
https://bugs.webkit.org/show_bug.cgi?id=224687
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.serial_test_run_in_parallel): Deal with the fact that pytest
running the tests might be not be the same version as the autoinstalled version,
and not API compatible.
- Scripts/webkitpy/conftest.py: Added.
(pytest_configure): Define the markers the plugins in conftest use
(pytest_addoption): Add --run-integration to allow them to be disabled by default.
(pytest_pycollect_makeitem): Rename serial/integration tests so pytest finds them.
(pytest_collection_modifyitems): Mark tests as skipped when needed per the above.
- Scripts/webkitpy/pytest.ini: Added.
- Scripts/webkitpy/test/main_unittest.py:
(TestStubs): Stop these from being picked up by pytest as tests.
- Scripts/webkitpy/test/markers.py: Fix this so pytest is technically optional,
even though it is always present because of the autoinstalled copy.
- 12:21 PM Changeset in webkit [276511] by
-
- 1 edit in branches/safari-611-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
Unreviewed build fix.
WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:127:17: error: use of undeclared identifier 'defaultProcess'
- 12:06 PM Changeset in webkit [276510] by
-
- 10 edits in trunk/Source
Remove decoder memory allocations based on untrusted data (sizes) in the stream; related changes
https://bugs.webkit.org/show_bug.cgi?id=224984
Reviewed by Sam Weinig.
Source/WebCore:
- platform/network/cf/CertificateInfoCFNet.cpp:
(WTF::Persistence::decodeCFData): Removed unneeded check for zero size. Removed code that
locally allocates a vector before bufferIsLargeEnoughToContain is called. Instead use
bufferPointerForDirectRead, which makes does the buffer size check, and pass the pointer
directly to CFDataCreate.
Source/WebKit:
- Platform/IPC/ArgumentCoders.h: Remove the calls to
HashMap::reserveInitialCapacity and HashSet::reserveInitialCapacity, based
on number read in from the decoder. This means there will be more wasted
memory in these HashMap and HashSet objects, so we have to test to make
sure this does not create a performance problem. But without this check,
we are trying to allocate memory based on an unstrusted size.
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<RefPtr<ApplePayError>>::encode): Removed the coder
for a Vector of these RefPtr, replaced it with a coder for an individual one,
allowing the Vector ArgumentCoder template to handle vector size and construction.
One benefit is that this adds in a shrinkToFit and prevents us from making any
separate mistake about pre-sizing the Vector here since we use shared code.
(IPC::ArgumentCoder<RefPtr<ApplePayError>>::decode): Ditto.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<RefPtr<SecurityOrigin>>::encode): Ditto.
(IPC::ArgumentCoder<RefPtr<SecurityOrigin>>::decode): Ditto.
(IPC::ArgumentCoder<WebCore::CDMInstanceSession::KeyStatusVector>::encode):
(IPC::ArgumentCoder<WebCore::CDMInstanceSession::KeyStatusVector>::decode):
Removed unnecessary specialization for the KeyStatusVector. There is already
an ArgumentCoder for Vector, for std::pair, for Ref<SharedBuffer>, and for
enumerations like CDMKeyStatus, so there's no need to have a specialized
coder for this. This function that we are removing had a call to
reserveInitialCapacity, but the Vector ArgumentCoder template does not.
- Shared/WebCoreArgumentCoders.h: Replaced the
ArgumentCoder<Vector<RefPtr<WebCore::ApplePayError>>> specialization with
ArgumentCoder<RefPtr<WebCore::ApplePayError>>. Removed the
ArgumentCoder<WebCore::CDMInstanceSession::KeyStatusVector> specialization.
Source/WTF:
- wtf/persistence/PersistentDecoder.cpp:
(WTF::Persistence::Decoder::bufferPointerForDirectRead): Added.
(WTF::Persistence::Decoder::decodeFixedLengthData): Refactor to use bufferPointerForDirectRead.
- wtf/persistence/PersistentDecoder.h: Added bufferPointerForDirectRead function for use in the
rare cases where we want to read directly out of the decoder buffer, rather than writing to a
passed-in pointer. Also did a small refactoring of bufferIsLargeEnoughToContain to use &&
rather than an if statement.
- 11:57 AM Changeset in webkit [276509] by
-
- 2 edits in trunk/Source/WebKit
Set proper network logging level for full web browsers
https://bugs.webkit.org/show_bug.cgi?id=224982
<rdar://problem/76903650>
Reviewed by Brent Fulgham.
Full web browsers have different low-level network logging requirements
for ephemeral sessions.
No new tests. There's no automated way to test if network level logs
show up. I tested that logging is correct for web browser and non web
browser apps manually.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
- 11:54 AM Changeset in webkit [276508] by
-
- 2 edits in trunk/LayoutTests
[macOS] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/css-module-worker-test.html is a flakey crash and failure
https://bugs.webkit.org/show_bug.cgi?id=222750
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 11:15 AM Changeset in webkit [276507] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
Unreviewed, reverting r276190.
broke a test internally.
Reverted changeset:
"Metal-ANGLE: Shared memory texture tests failing in iOS
Simulator"
https://bugs.webkit.org/show_bug.cgi?id=222685
https://commits.webkit.org/r276190
- 10:44 AM Changeset in webkit [276506] by
-
- 4 edits in trunk/Source
Disable GPUProcess on shipping iOS
https://bugs.webkit.org/show_bug.cgi?id=224897
Reviewed by Eric Carlson.
Source/WebKit:
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
(WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
(WebKit::defaultUseGPUProcessForMediaEnabled):
(WebKit::defaultUseGPUProcessForWebGLEnabled):
(WebKit::defaultCaptureAudioInGPUProcessEnabled):
(WebKit::defaultCaptureVideoInGPUProcessEnabled):
(WebKit::defaultWebRTCCodecsInGPUProcess):
Source/WTF:
- wtf/PlatformEnableCocoa.h:
- 10:31 AM Changeset in webkit [276505] by
-
- 2 edits in trunk/Tools
Make report-non-inclusive-language ignore .db files
https://bugs.webkit.org/show_bug.cgi?id=224979
Reviewed by Darin Adler.
- Scripts/report-non-inclusive-language:
- 10:21 AM Changeset in webkit [276504] by
-
- 7 edits in trunk
Fix KVO for camera/microphone capture state WKWebView API
https://bugs.webkit.org/show_bug.cgi?id=224922
<rdar://problem/77008199>
Reviewed by Eric Carlson.
Source/WebKit:
Add missing willChange observer call and migrate keys to API keys.
Covered by API test.
- UIProcess/Cocoa/PageClientImplCocoa.h:
- UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::microphoneCaptureWillChange):
(WebKit::PageClientImplCocoa::cameraCaptureWillChange):
(WebKit::PageClientImplCocoa::microphoneCaptureChanged):
(WebKit::PageClientImplCocoa::cameraCaptureChanged):
- UIProcess/PageClient.h:
(WebKit::PageClient::microphoneCaptureWillChange):
(WebKit::PageClient::cameraCaptureWillChange):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateReportedMediaCaptureState):
Tools:
Add tests for capture state API.
- TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
(-[MediaCaptureObserver observeValueForKeyPath:ofObject:change:context:]):
(TestWebKitAPI::waitUntilCameraState):
(TestWebKitAPI::waitUntilMicrophoneState):
(TestWebKitAPI::TEST):
- 10:04 AM Changeset in webkit [276503] by
-
- 1 edit in branches/safari-611-branch/Source/WebCore/layout/inlineformatting/InlineContentBreaker.cpp
Apply patch. rdar://problem/76963029
- 10:00 AM WebKitGTK/2.32.x edited by
- (diff)
- 9:55 AM Changeset in webkit [276502] by
-
- 25 edits in trunk/Source
Improve our constructDeletedValue() template specializations
https://bugs.webkit.org/show_bug.cgi?id=224889
Reviewed by Darin Adler.
Source/WebCore:
Improve our constructDeletedValue() template specializations and make them more consistent:
- Use placement-new instead of object assignment since we don't want/need to destroy the existing object (since it is uninitialized).
- Do as little initialization as possible for performance reasons.
- Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::deletedValue): Deleted.
- Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyDataHashTraits::constructDeletedValue):
(WebCore::IDBKeyDataHashTraits::isDeletedValue):
(WebCore::IDBKeyData::isDeletedValue const): Deleted.
- Modules/indexeddb/shared/IDBResourceIdentifier.cpp:
(WebCore::IDBResourceIdentifier::deletedValue): Deleted.
(WebCore::IDBResourceIdentifier::isHashTableDeletedValue const): Deleted.
- Modules/indexeddb/shared/IDBResourceIdentifier.h:
(WebCore::IDBResourceIdentifierHashTraits::constructDeletedValue):
(WebCore::IDBResourceIdentifierHashTraits::isDeletedValue):
- dom/MessagePortIdentifier.h:
(WTF::HashTraits<WebCore::MessagePortIdentifier>::constructDeletedValue):
(WTF::HashTraits<WebCore::MessagePortIdentifier>::isDeletedValue):
- history/BackForwardItemIdentifier.h:
(WTF::HashTraits<WebCore::BackForwardItemIdentifier>::constructDeletedValue):
(WTF::HashTraits<WebCore::BackForwardItemIdentifier>::isDeletedValue):
- layout/LayoutUnits.h:
(WTF::HashTraits<WebCore::Layout::SlotPosition>::constructDeletedValue):
(WTF::HashTraits<WebCore::Layout::SlotPosition>::isDeletedValue):
- loader/PrivateClickMeasurement.h:
(WebCore::PrivateClickMeasurement::AttributionDestinationSite::matches const):
(WTF::HashTraits<WebCore::PrivateClickMeasurement::SourceSite>::constructDeletedValue):
(WTF::HashTraits<WebCore::PrivateClickMeasurement::SourceSite>::isDeletedValue):
(WTF::HashTraits<WebCore::PrivateClickMeasurement::AttributionDestinationSite>::constructDeletedValue):
(WTF::HashTraits<WebCore::PrivateClickMeasurement::AttributionDestinationSite>::isDeletedValue):
(WebCore::PrivateClickMeasurement::SourceSite::isHashTableDeletedValue const): Deleted.
(WebCore::PrivateClickMeasurement::SourceSite::deletedValue): Deleted.
(WebCore::PrivateClickMeasurement::SourceSite::constructDeletedValue): Deleted.
(WebCore::PrivateClickMeasurement::SourceSite::deleteValue): Deleted.
(WebCore::PrivateClickMeasurement::SourceSite::isDeletedValue const): Deleted.
(WebCore::PrivateClickMeasurement::AttributionDestinationSite::isHashTableDeletedValue const): Deleted.
(WebCore::PrivateClickMeasurement::AttributionDestinationSite::deletedValue): Deleted.
(WebCore::PrivateClickMeasurement::AttributionDestinationSite::constructDeletedValue): Deleted.
(WebCore::PrivateClickMeasurement::AttributionDestinationSite::deleteValue): Deleted.
(WebCore::PrivateClickMeasurement::AttributionDestinationSite::isDeletedValue const): Deleted.
- page/ClientOrigin.h:
(WTF::HashTraits<WebCore::ClientOrigin>::constructDeletedValue):
- page/GlobalWindowIdentifier.h:
(WTF::HashTraits<WebCore::GlobalWindowIdentifier>::constructDeletedValue):
(WTF::HashTraits<WebCore::GlobalWindowIdentifier>::isDeletedValue):
- platform/Cookie.h:
(WTF::HashTraits<WebCore::Cookie>::constructDeletedValue):
(WebCore::Cookie::Cookie): Deleted.
- platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKeyHashTraits::constructDeletedValue):
- platform/graphics/FontCache.h:
(WebCore::FontCascadeCacheKeyHashTraits::constructDeletedValue):
- platform/graphics/IntPointHash.h:
(WTF::HashTraits<WebCore::IntPoint>::constructDeletedValue):
(WTF::HashTraits<WebCore::IntPoint>::isDeletedValue):
- rendering/CSSValueKey.h:
(WTF::HashTraits<WebCore::CSSValueKey>::constructDeletedValue):
- workers/service/ServiceWorkerClientIdentifier.h:
(WTF::HashTraits<WebCore::ServiceWorkerClientIdentifier>::constructDeletedValue):
(WTF::HashTraits<WebCore::ServiceWorkerClientIdentifier>::isDeletedValue):
Source/WebCore/PAL:
- pal/SessionID.h:
(WTF::HashTraits<PAL::SessionID>::constructDeletedValue):
Source/WebKit:
Improve our constructDeletedValue() template specializations and make them more consistent:
- Use placement-new instead of object assignment since we don't want/need to destroy the existing object (since it is uninitialized).
- Do as little initialization as possible for performance reasons.
- NetworkProcess/cache/NetworkCache.h:
(WTF::HashTraits<WebKit::NetworkCache::GlobalFrameID>::constructDeletedValue):
(WTF::HashTraits<WebKit::NetworkCache::GlobalFrameID>::isDeletedValue):
- Platform/IPC/StringReference.h:
(WTF::HashTraits<IPC::StringReference>::constructDeletedValue):
- Shared/CallbackID.h:
(WTF::HashTraits<WebKit::CallbackID>::constructDeletedValue):
(WTF::HashTraits<WebKit::CallbackID>::isDeletedValue):
Source/WebKitLegacy/mac:
Improve our constructDeletedValue() template specializations and make them more consistent:
- Use placement-new instead of object assignment since we don't want/need to destroy the existing object (since it is uninitialized).
- Do as little initialization as possible for performance reasons.
- History/BinaryPropertyList.cpp:
(IntegerArray::integers const):
(IntegerArray::size const):
(IntegerArrayHashTraits::constructDeletedValue):
(IntegerArrayHashTraits::isDeletedValue):
(IntegerArray::markDeleted): Deleted.
(IntegerArray::isDeletedValue const): Deleted.
(IntegerArray::deletedValueSize): Deleted.
- 9:53 AM Changeset in webkit [276501] by
-
- 2 edits in branches/safari-611-branch/Source/WebKit
Cherry-pick r276482. rdar://problem/77074513
[Mac] CMBaseClass object pointers can become unaligned on x86
https://bugs.webkit.org/show_bug.cgi?id=224950
<rdar://77020922>
Reviewed by Eric Carlson.
CMBaseClass has a 4-byte version member before its 8-byte pointers on x86. Deal with this
the same way we do with other pointer-bearing, static, CM-type objects: enforce a 4-byte
packing, and prepend the struct with another 4-byte object in order to force the pointers
into 8-byte alignment.
- Shared/mac/MediaFormatReader/CoreMediaWrapped.h: (WebKit::CoreMediaWrapped<Wrapped>::vTable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:31 AM Changeset in webkit [276500] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer][EME] cbcs fixes
https://bugs.webkit.org/show_bug.cgi?id=224976
Reviewed by Philippe Normand.
In cbcs you can get from qtdemux buffers without an iv_size
because it had constant_iv_size. We need to check that.
When decryption bails out because of the buffer being unencrypted,
we should TRACE so.
cbcs buffers could not include the subsample_count, we consider 0
as default.
- platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(transformInPlace):
- 9:15 AM WebKitGTK/2.32.x edited by
- (diff)
- 9:14 AM WebKitGTK/2.32.x edited by
- (diff)
- 9:12 AM WebKitGTK/2.32.x edited by
- (diff)
- 8:40 AM Changeset in webkit [276499] by
-
- 2 edits in trunk/Source/WebCore
Improve HashTableDeletedValue of ServiceWorkerRegistrationKey
https://bugs.webkit.org/show_bug.cgi?id=224975
Patch by Michael Catanzaro <Michael Catanzaro> on 2021-04-23
Reviewed by Chris Dumez.
We construct only the SecurityOriginData, no need to construct a full
ServiceWorkerRegistrationKey or URL. No behavior changes.
- workers/service/ServiceWorkerRegistrationKey.h:
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::constructDeletedValue):
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::isDeletedValue):
(WebCore::ServiceWorkerRegistrationKey::isHashTableDeletedValue const): Deleted.
(WebCore::ServiceWorkerRegistrationKey::ServiceWorkerRegistrationKey): Deleted.
- 8:16 AM Changeset in webkit [276498] by
-
- 8 edits in trunk/LayoutTests/imported/w3c
Import the update to "mapping attribute width and height to aspect ratio" tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=224911
Reviewed by Rob Buis.
Import the update to "mapping attribute width and height to aspect ratio" tests from WPT commit 0ae0bb7cab. Split up the test cases, to make sure
each image has its own test case and won't affect testing other images.
- web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/canvas-aspect-ratio-expected.txt:
- web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio-expected.txt:
- web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio.html:
- web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/picture-aspect-ratio-expected.txt:
- web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/picture-aspect-ratio.html:
- web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/resources/aspect-ratio.js:
(test_computed_style_aspect_ratio):
- web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio-expected.txt:
- 7:32 AM Changeset in webkit [276497] by
-
- 5 edits in trunk/Source
Handle rotation correctly in WebRTC GPUProcess rendering pipeline
https://bugs.webkit.org/show_bug.cgi?id=224927
<rdar://76915991>
Reviewed by Eric Carlson.
Source/WebCore:
Add a routine to update the affine transformn of the root layer.
Manually tested.
- platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h:
- platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::LocalSampleBufferDisplayLayer::updateRootLayerAffineTransform):
Source/WebKit:
Instead of updating the inner layer, update the root layer.
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::updateAffineTransform):
- 7:07 AM Changeset in webkit [276496] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, reverting r276486.
https://bugs.webkit.org/show_bug.cgi?id=224973
broke windows build
Reverted changeset:
"[JSC][Win] callOperationNoExceptionCheck() also needs to
support operations that return SlowPathReturnType"
https://bugs.webkit.org/show_bug.cgi?id=224964
https://trac.webkit.org/changeset/276486
- 6:29 AM Changeset in webkit [276495] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, GStreamer follow-up after r276493
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Remove spurious adoptGRef call, as
this is not transfer-full.
- 6:17 AM Changeset in webkit [276494] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening
- platform/gtk/TestExpectations: Remove test expectation for
imported/w3c/web-platform-tests/mediacapture-fromelement/capture.html which is tracked in
the main TestExpectations already.
- 2:46 AM Changeset in webkit [276493] by
-
- 7 edits in trunk/Source/WebCore
[Media] Allow access to MediaElement id from MediaPlayerPrivate
https://bugs.webkit.org/show_bug.cgi?id=224818
Patch by Philippe Normand <pnormand@igalia.com> on 2021-04-23
Reviewed by Xabier Rodriguez-Calvar.
A new method is added in the MediaPlayer allowing to query the client media element for its
identifier. That could be useful for accurate naming of the internal player/pipeline in the
MediaPlayerPrivate. If no specific id was set on the media element then the id is empty
string and the MediaPlayerPrivate needs to handle that by forging a unique id.
This also lead me to simplify pipeline-related code in the GStreamer player. The player can
handle only one pipeline in its entire life-time so the code handling pipeline "re-loading"
was actually never hit.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::elementId const):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerElementId const):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::loadFull): Deleted.
(WebCore::MediaPlayerPrivateGStreamer::setPipeline): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 2:43 AM Changeset in webkit [276492] by
-
- 2 edits in trunk/Source/WebCore
Do not set synchronous scrolling for layers without relevant scrolling scopes
https://bugs.webkit.org/show_bug.cgi?id=221383
Reviewed by Simon Fraser.
Fixed backgrounds could force the layer compositor to set synchronous scrolling because they're slow
to repaint. However that cannot be done if the layer's boxScrollingScope hasn't been previously updated
in RenderLayer::updateLayerPosition.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateSynchronousScrollingNodes): Do not call
setSynchronousScrollingReasons() if there is no scrollingScope.
- 2:23 AM Changeset in webkit [276491] by
-
- 12 edits4 adds in trunk
[LibWebRTC][WPE][GTK] Enable vp9 and NO_MAIN_THREAD_WRAPPING
https://bugs.webkit.org/show_bug.cgi?id=222795
Patch by Philippe Normand <pnormand@igalia.com> on 2021-04-23
Reviewed by Xabier Rodriguez-Calvar.
Source/ThirdParty/libwebrtc:
- CMakeLists.txt: Enable NO_MAIN_THREAD_WRAPPING as in the XCode build and harmonize options
between Apple and non-Apple ports.
- Source/webrtc/common_video/h265/h265_pps_parser.h:
Source/WebCore:
Add VP9 encoding and decoding support in the WPE/GTK LibWebRTC backend. The underlying
encoding support is based on LibWebRTC's internal VP9 support. The GStreamer VPx encoders
lack simulcast and high profile support, so can't really be used anyway. The
GStreamerVP8Encoder was removed for this reason as well.
- platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:
(WebCore::VP9Decoder::VP9Decoder):
(WebCore::VP9Decoder::Create):
(WebCore::GStreamerVideoDecoderFactory::CreateVideoDecoder):
(WebCore::GStreamerVideoDecoderFactory::GStreamerVideoDecoderFactory):
(WebCore::GStreamerVideoDecoderFactory::GetSupportedFormats const):
- platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.h:
- platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp:
- platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::makeElement):
(WebCore::GStreamerVideoEncoder::createEncoder):
(WebCore::GStreamerVideoEncoder::SetRestrictionCaps):
(WebCore::GStreamerVideoEncoderFactory::CreateVideoEncoder):
(WebCore::GStreamerVideoEncoderFactory::GStreamerVideoEncoderFactory):
(WebCore::GStreamerVideoEncoderFactory::GetSupportedFormats const):
- platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.h:
- platform/mediastream/libwebrtc/LibWebRTCProviderGStreamer.cpp:
(WebCore::LibWebRTCProviderGStreamer::createDecoderFactory):
(WebCore::LibWebRTCProviderGStreamer::createEncoderFactory):
LayoutTests:
Update GLIB baselines for webrtc tests.
- platform/glib/TestExpectations:
- platform/glib/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences-expected.txt: Added.
- 12:16 AM Changeset in webkit [276490] by
-
- 15 edits in trunk/Source/WebKit
[GTK] Implement PageClient::makeViewBlank()
https://bugs.webkit.org/show_bug.cgi?id=224236
Reviewed by Chris Dumez.
Make most of the changes in r275485 cross platform and implement PageClient::makeViewBlank() for the GTK port.
- UIProcess/API/glib/WebKitUIClient.cpp:
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::makeViewBlank):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSnapshot):
(webkitWebViewBaseDraw):
(webkitWebViewBaseMakeBlank):
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didUpdateRenderingAfterCommittingLoad):
(WebKit::WebPageProxy::stopMakingViewBlankDueToLackOfRenderingUpdate):
(WebKit::WebPageProxy::makeViewBlankIfUnpaintedSinceLastLoadCommit):
(WebKit::WebPageProxy::didCommitLoadForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::didUpdateRenderingAfterCommittingLoad): Deleted.
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
- WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState):
(WebKit::DrawingAreaCoordinatedGraphics::display):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didUpdateRendering):
(WebKit::WebPage::didCommitLoad):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::didUpdateRendering): Deleted.
Apr 22, 2021:
- 10:42 PM Changeset in webkit [276489] by
-
- 2 edits1 add in trunk/LayoutTests
[GTK] Unreviewed test gardening. Update baseline after r276448.
- platform/glib/TestExpectations:
- platform/gtk/fast/forms/datalist/input-list-expected.txt: Added.
- 10:25 PM Changeset in webkit [276488] by
-
- 18 edits2 adds in trunk
[css-counter-styles] Parse @counter-style descriptors
https://bugs.webkit.org/show_bug.cgi?id=224718
Patch by Tyler Wilcock <Tyler Wilcock> on 2021-04-22
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Parsing for all @counter-style descriptors is implemented with this
patch, so mark more tests passing.
You'll notice that some @counter-style descriptors implemented in this
patch did not gain any passing tests (e.g.pad,negative). In all
of these cases, the expected results contain a <string> value, and we
fail only because we incorrectly don't serialize these <string> values
with quotes. I have manually confirmed in all cases that these values
are properly parsed, so it's just the serialization that's incorrect.
These <string> values serialize without quotes because WebKit's representation
of custom identifiers is not a separate type, but instead overloaded onto the
CSS_STRING type. This means that during serialization time, WebKit must guess
whether it is actually serializing a string (and include quotes if so), or if
it's serializing a custom ident (leaving off quotes if so).
Relevant code snippet:
Relevant changelog snippet from David Hyatt, 2016-12-07:
We also overload CSS_STRING primitive value type and have it act as both a string
and a custom identifier. This is lame, since the parser should have made two different
types of objects instead, but since our parser doesn't do that yet, I added a serializeAsStringOrCustomIdent
that preserves our old behavior of "quote the string only if needed." In this case what
that really meant was "Try to guess that we were originally a custom ident and leave off
quotes if so." This function will go away once we properly create CSSStringValues and
CSSCustomIdentValues instead of turning the latter into strings.
- web-platform-tests/css/css-counter-styles/counter-style-fallback-expected.txt:
- web-platform-tests/css/css-counter-styles/counter-style-prefix-suffix-syntax-expected.txt:
- web-platform-tests/css/css-counter-styles/counter-style-range-syntax-expected.txt:
- web-platform-tests/css/css-counter-styles/counter-style-speak-as-syntax-expected.txt:
- web-platform-tests/css/css-counter-styles/counter-style-system-syntax-expected.txt:
Source/WebCore:
Implement parsing and CSSCounterStyleRule IDL interface for @counter-style descriptors.
See spec for full details on all descriptors:
https://drafts.csswg.org/css-counter-styles-3/#the-counter-style-rule
Test: webexposed/counter-style-image-symbols-not-exposed.html and WPTs
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
Returnnullptrfor new @counter-style descriptor properties.
- css/CSSCounterStyleRule.cpp:
(WebCore::toCounterStyleSystemEnum):
(WebCore::symbolsValidForSystem):
(WebCore::StyleRuleCounterStyle::newValueInvalidOrEqual const):
(WebCore::CSSCounterStyleRule::cssText const):
(WebCore::CSSCounterStyleRule::setName):
(WebCore::CSSCounterStyleRule::setterInternal):
(WebCore::CSSCounterStyleRule::setSystem):
(WebCore::CSSCounterStyleRule::setNegative):
(WebCore::CSSCounterStyleRule::setPrefix):
(WebCore::CSSCounterStyleRule::setSuffix):
(WebCore::CSSCounterStyleRule::setRange):
(WebCore::CSSCounterStyleRule::setPad):
(WebCore::CSSCounterStyleRule::setFallback):
(WebCore::CSSCounterStyleRule::setSymbols):
(WebCore::CSSCounterStyleRule::setAdditiveSymbols):
(WebCore::CSSCounterStyleRule::setSpeakAs):
Implement setters and tangential functionality required by setters.
- css/CSSCounterStyleRule.h:
Replace FIXME with actual descriptor getter and setter
implementations.
- css/CSSProperties.json:
Add @counter-style descriptor properties.
- css/CSSValueKeywords.in:
Add new values required for
systemandspeak-as
@counter-style descriptor properties.
- css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
Ensure new @counter-style descriptors are disabled at runtime based
on CSSParserContext state.
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeCounterStyleSystem):
(WebCore::consumeCounterStyleSymbol):
(WebCore::consumeCounterStyleNegative):
(WebCore::consumeCounterStyleRangeBound):
(WebCore::consumeCounterStyleRange):
(WebCore::consumeCounterStylePad):
(WebCore::consumeCounterStyleSymbols):
(WebCore::consumeCounterStyleAdditiveSymbols):
(WebCore::consumeCounterStyleSpeakAs):
(WebCore::CSSPropertyParser::parseCounterStyleDescriptor):
Parse @counter-style descriptors.
Tools:
- DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):
Fix typo (missing 's'). CSSCounterStyleAtRulesEnabled, not
CSSCounterStyleAtRuleEnabled.
LayoutTests:
Add test ensuring <image> @counter-style symbol values cannot be
parsed when thecounterStyleAtRuleImageSymbolsEnabledfeature flag
is disabled.
---
This test is skipped on Windows because I haven't been able to get the
required feature flags (CSSCounterStyleAtRulesEnabled and
CSSCounterStyleAtRuleImageSymbolsEnabled) to work properly for that
port.
The code hidden behind these flags is all in the CSS parser, which is not
unique to Windows, so I think we can be confident that if the test passes
on all other platforms, that the behavior is correct on Windows too.
One attempt at implementing the necessary Windows-specific flag functionality is here:
https://bugs.webkit.org/attachment.cgi?id=426371&action=edit
Which failed to compile[1] with this error:
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Tools\DumpRenderTree\win\DumpRenderTree.cpp(834,51): error C2039: 'setCSSCounterStyleAtRulesEnabled': is not a member of 'IWebPreferencesPrivate7' [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Tools\DumpRenderTree\win\DumpRenderTree.cpp(835,62): error C2039: 'setCSSCounterStyleAtRuleImageSymbolsEnabled': is not a member of 'IWebPreferencesPrivate7' [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
Those methods are present in
IWebPreferencesPrivate7.idl, and implemented similarly to other
flags in other places (e.g. win/WebPreferences.{h, cpp}, win/WebPreferenceKeysPrivate.h).
I can't reproduce this compilation error on my Windows machine.
I then tried removing the lines that caused the above compilation failure.
Those setters are called in DumpRenderTree::enableExperimentalFeatures, so in
lieu of enabling these flags there I could enable the flag I need via test header.
That patch is: https://bugs.webkit.org/attachment.cgi?id=426509&action=edit
This results in successful compilation, but causes lots (all?) of the
layout tests to fail[2] with a stacktrace that looks like:
- 10:20 PM Changeset in webkit [276487] by
-
- 2 edits in trunk/WebDriverTests
[GTK][WebDriver] Garden keypress failures
Unreviewed test gardening.
- TestExpectations.json:
- 10:16 PM Changeset in webkit [276486] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC][Win] callOperationNoExceptionCheck() also needs to support operations that return SlowPathReturnType
https://bugs.webkit.org/show_bug.cgi?id=224964
Reviewed by Yusuke Suzuki.
r229989 (Bug 183655) added the x64 Windows support only for
callOperation(), but for callOperationNoExceptionCheck().
callOperationNoExceptionCheck() also needs the x64 Windows
support.
This change is a preparation for Bug 224920 that is going to use
callOperationNoExceptionCheck instead of callOperation.
- jit/JIT.h:
(callOperation): Rewrote by using 'if constexpr' instead of SFINAE.
(callOperationNoExceptionCheck): Added a new implementation for
x64 Windows based on callOperation.
- 10:06 PM Changeset in webkit [276485] by
-
- 2 edits in trunk/Source/WTF
[WTF] Undefined behavior warning in StringBuilder::allocateBuffer
https://bugs.webkit.org/show_bug.cgi?id=224942
Reviewed by Chris Dumez.
- wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::allocateBuffer): Add check before calling memcpy
- 8:56 PM Changeset in webkit [276484] by
-
- 3 edits2 adds in trunk
Sometimes appHighlights are not painted when created.
https://bugs.webkit.org/show_bug.cgi?id=224904
Reviewed by Antti Koivisto.
Source/WebCore:
In order for highlights to be painted correctly, we need to not use the new line layout code,
so we need to opt out when we are repainting due to a highlight being added or removed.
Test: http/wpt/css/css-highlight-api/highlight-text-dynamic.html
- Modules/highlight/Highlight.cpp:
(WebCore::repaintRange):
LayoutTests:
- http/wpt/css/css-highlight-api/highlight-text-dynamic-expected-mismatch.html: Added.
- http/wpt/css/css-highlight-api/highlight-text-dynamic.html: Added.
- 8:26 PM Changeset in webkit [276483] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening. Update test expectations.
- platform/gtk/TestExpectations:
- 8:23 PM Changeset in webkit [276482] by
-
- 2 edits in trunk/Source/WebKit
[Mac] CMBaseClass object pointers can become unaligned on x86
https://bugs.webkit.org/show_bug.cgi?id=224950
<rdar://77020922>
Reviewed by Eric Carlson.
CMBaseClass has a 4-byte version member before its 8-byte pointers on x86. Deal with this
the same way we do with other pointer-bearing, static, CM-type objects: enforce a 4-byte
packing, and prepend the struct with another 4-byte object in order to force the pointers
into 8-byte alignment.
- Shared/mac/MediaFormatReader/CoreMediaWrapped.h:
(WebKit::CoreMediaWrapped<Wrapped>::vTable):
- 7:52 PM Changeset in webkit [276481] by
-
- 7 edits20 adds in trunk/LayoutTests
[GTK] Unreviewed test gardening. Update baselines after r276448.
r276448 turned on editable <input type=date> and <input type=time>,
many tests baselines need to be updated or emitted as result differ
from general baseline.
- platform/gtk/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/baseline-alignment-and-overflow.tentative-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/date-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-seconds-leading-zeroes-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-valueasdate-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-valueasdate-stepping-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-valueasnumber-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-valueasnumber-stepping-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/month-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-2-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/week-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt: Added.
- 7:33 PM Changeset in webkit [276480] by
-
- 2 edits in trunk/Source/WebKit
Followup to r276397
https://bugs.webkit.org/show_bug.cgi?id=224883
Reviewed by Darin Adler.
Use a range-based for loop when mapping FloatQuads in
sendTapHighlightForNodeIfNecessary.
No change in behavior.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
- 6:29 PM Changeset in webkit [276479] by
-
- 2 edits in trunk/LayoutTests
[ BigSur wk2 arm64 ] webrtc/captureCanvas-webrtc.html
https://bugs.webkit.org/show_bug.cgi?id=224963
Uneviewed test gardneing.
- platform/mac-wk2/TestExpectations: Updated test expectations to Pass Timeout for BigSur arm64 only while test is reviewed.
- 5:56 PM Changeset in webkit [276478] by
-
- 3 edits2 adds in trunk
Fix color gamut in WebRTC when using VPx software decoder.
https://bugs.webkit.org/show_bug.cgi?id=220972
<rdar://problem/73616455>
Reviewed by Youenn Fablet.
Source/WebCore:
By default, and how libwebrtc is configuring its encoders and decoder, video range levels are used
(16-235). Video range was assumed to use full range instead (0-255), causing blacks to look grey and
whites to appear washed-out.
It is theoretically possible, when using VP9 that full-range level are used. While the information
related to video levels is available at the VP9 codec level; only the color space information is
being made available in libwebrtc's public image data structure, color range isn't.
For now we can assume the default is sufficient, and a follow-up change will be submitted to libwebrtc
later on.
In memory of Dr. Alex. May he rest in peace.
Test: webrtc/video-vp8-videorange.html
- platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
(WebCore::RealtimeIncomingVideoSourceCocoa::pixelBufferPool):
LayoutTests:
- webrtc/video-vp8-videorange-expected.txt: Added.
- webrtc/video-vp8-videorange.html: Added.
- 5:42 PM Changeset in webkit [276477] by
-
- 4 edits in trunk/Source/WebKit
[iOS] Remove useless 'network-outbound' rule from non-networking file rule
https://bugs.webkit.org/show_bug.cgi?id=224940
<rdar://problem/66583476>
Reviewed by Per Arne Vollan.
No new tests. No effect on behavior.
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb:
- 5:09 PM Changeset in webkit [276476] by
-
- 14 edits in trunk
[Cocoa] re-enable test case WKInspectorDelegate.InspectorConfiguration
https://bugs.webkit.org/show_bug.cgi?id=224577
<rdar://70505272>
Reviewed by Devin Rousso.
Source/WebInspectorUI:
Adjust the CSP directive list in the <meta> tag to allow for customization
by WebKit ports.
- UserInterface/Main.html:
- Remove
default-src 'self'so as not to block custom scheme loads. - Remove
connect-src * ws:so as not to block custom scheme loads. - Add
object-src 'none'as we have no reason to allow <object>, <embed>, or <applet>.
Source/WebKit:
For the purposes of testing, we want to be able to issue a fetch() that will
hit a custom URL scheme handler registered with _WKInspectorConfiguration.
This is not allowed by the existing <meta> tag CSP directive list because 'connect-src *'
does not allow connecting to arbitrary schemes, just arbitrary domains.
To fix this, relax the 'connect-src' directive in Main.html and apply
a dynamically-computed CSP directive using the 'Content-Security-Policy' HTTP
response header. This is only sent for main resources (Main.html and Test.html)
using the newly added inspector-resource: URL scheme handler.
The dynamically computed directive explicitly allows 'self' and any other registered
custom URL scheme handlers. WebKit ports which have not migrated away from file:///
will only apply the weaker 'connect-src' directive from the <meta> tag after this change.
Progresses an existing API test: WKInspectorDelegate.InspectorConfiguration.
- UIProcess/API/Cocoa/_WKInspectorDelegate.h:
- UIProcess/API/APIInspectorClient.h:
(API::InspectorClient::frontendLoaded):
- UIProcess/API/Cocoa/_WKInspectorPrivateForTesting.h:
- UIProcess/API/Cocoa/_WKInspector.mm:
- UIProcess/API/Cocoa/_WKInspectorTesting.mm:
(JavaScriptSnippetToFetchURL):
(-[_WKInspector _fetchURLForTesting:]):
- UIProcess/Inspector/WebInspectorUIProxy.cpp:
(WebKit::WebInspectorUIProxy::frontendLoaded): Notify the _WKInspectorDelegate
adapter that the frontend has finished loading.
- UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.h:
- UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.mm:
(-[WKInspectorResourceURLSchemeHandler allowedURLSchemesForCSP]):
(-[WKInspectorResourceURLSchemeHandler setAllowedURLSchemesForCSP:]):
(-[WKInspectorResourceURLSchemeHandler webView:startURLSchemeTask:]):
Added. Keep track of allowed custom schemes and allowed main resources.
Apply the CSP directive for main resource requests only.
- UIProcess/Inspector/mac/WKInspectorViewController.mm:
(-[WKInspectorViewController webViewConfiguration]):
Set the allowed URL schemes property so the URL scheme handler can include
the schemes in the dynamically computed 'connect-src' directive.
Tools:
Trigger a fetch of a resource that uses a custom URL scheme handler in
order to test that custom scheme handlers registered in an _WKInspectorConfiguration
are getting used as expected.
Add an -inspectorFrontendLoaded: delegate method to -WKInspectorDelegate.
This is mainly used to prevent tests from progressing with a half-loaded inspector.
To make it possible to do this fetch(), there are some CSP related changes
that were made for Main.html so that fetching from a registered custom scheme is allowed.
Drive-by, per post-commit comments, add a better fix for the memory leak reported in
https://bugs.webkit.org/show_bug.cgi?id=223899. Thanks Joe!
- TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm:
(resetGlobalState):
(-[InspectorDelegate inspectorFrontendLoaded:]):
(TEST):
(-[UIDelegate _webView:didAttachLocalInspector:]):
(-[UIDelegate _webView:willCloseLocalInspector:]):
(-[UIDelegate _webViewDidEnableInspectorBrowserDomain:]):
(-[UIDelegate _webViewDidDisableInspectorBrowserDomain:]):
- 4:04 PM Changeset in webkit [276475] by
-
- 2 edits in trunk/Tools
Unreviewed. Gardening TestSSL flakiness
- TestWebKitAPI/glib/TestExpectations.json:
- 4:04 PM Changeset in webkit [276474] by
-
- 1 copy in tags/Safari-612.1.11.5
Tag Safari-612.1.11.5.
- 3:33 PM Changeset in webkit [276473] by
-
- 9 edits in trunk
Add trace points for WKWebView snapshotting
https://bugs.webkit.org/show_bug.cgi?id=224943
Reviewed by Tim Horton.
Source/WebKit:
Add new trace points to make snapshotting-related issues easier to diagnose. In the UI
process we start/end a trace scope when requested to snapshot, and before calling the
client's completion handler.
Trace CARenderServer snapshots which happen in the UI process, and in the web process, trace
the start and end of the snapshot painting.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):
- UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView requestSnapshot]):
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::paintSnapshotAtSize):
Source/WTF:
New snapshot values.
- wtf/SystemTracing.h:
Tools:
New snapshot descriptions.
- Tracing/SystemTracePoints.plist:
- 3:31 PM Changeset in webkit [276472] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed. Guard doesPageNeedTCCD in platform COCOA after r274213
https://bugs.webkit.org/show_bug.cgi?id=224951
Silence -Wunused-function in non-cocoa platforms.
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
- 3:31 PM Changeset in webkit [276471] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] Null pointer dereference in ResourceLoader::didReceiveAuthenticationChallenge
https://bugs.webkit.org/show_bug.cgi?id=224838
Patch by Michael Catanzaro <Michael Catanzaro> on 2021-04-22
Reviewed by Adrian Perez de Castro.
Add a RELEASE_ASSERT_NOT_REACHED() to avoid this warning.
- platform/network/soup/AuthenticationChallenge.h:
- 3:24 PM Changeset in webkit [276470] by
-
- 5 edits in trunk/Source/JavaScriptCore
Unreviewed, reverting r276456.
https://bugs.webkit.org/show_bug.cgi?id=224952
Windows specific crash
Reverted changeset:
"[JSC} Remove exception checks from non-throwing function
calls in Baseline JIT"
https://bugs.webkit.org/show_bug.cgi?id=224920
https://trac.webkit.org/changeset/276456
- 3:23 PM Changeset in webkit [276469] by
-
- 4 edits in trunk/Source
[SOUP] Show more connection information in the inspector
https://bugs.webkit.org/show_bug.cgi?id=224873
Source/WebCore:
Handle SOUP_HTTP_2_0.
Reviewed by Adrian Perez de Castro.
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::ResourceResponse):
Source/WebKit:
Show the h2 protocol as well as the connection identifier
in the inspector.
Reviewed by Adrian Perez de Castro.
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::gotHeadersCallback):
(WebKit::soupHTTPVersionToString):
(WebKit::NetworkDataTaskSoup::didGetHeaders):
- 3:16 PM Changeset in webkit [276468] by
-
- 2 edits in trunk/Source/WebKitLegacy/win
Disable prefixed WebAudio on WebKitLegacy-Windows
https://bugs.webkit.org/show_bug.cgi?id=224944
Reviewed by Eric Carlson.
Disable prefixed WebAudio on WebKitLegacy-Windows. It is already disabled everywhere else.
- WebView.cpp:
(WebView::notifyPreferencesChanged):
- 3:12 PM Changeset in webkit [276467] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (Metal ANGLE): webgl/2.0.0/conformance/glsl/misc/shader-uniform-packing-restrictions.html is constantly timing out.
https://bugs.webkit.org/show_bug.cgi?id=224257
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating test that's timing out constantly to slow to see if it improves.
- 3:09 PM Changeset in webkit [276466] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
[CMake][ANGLE] Silence -Wreturn-type for gcc and clang
https://bugs.webkit.org/show_bug.cgi?id=224949
Reviewed by Don Olmstead.
Avoid "control reaches end of non-void function" in
sh::TIntermRebuild::traverseChildren(...)
- CMakeLists.txt:
- 3:07 PM Changeset in webkit [276465] by
-
- 10 edits in trunk
Add discrete animation support for border-image-repeat
https://bugs.webkit.org/show_bug.cgi?id=224923
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Mark 10 WPT progressions.
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/NinePieceImage.cpp:
(WebCore::operator<<):
- rendering/style/NinePieceImage.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setBorderImageHorizontalRule):
(WebCore::RenderStyle::setBorderImageVerticalRule):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::borderImageHorizontalRule const):
(WebCore::RenderStyle::borderImageVerticalRule const):
- 3:02 PM Changeset in webkit [276464] by
-
- 3 edits2 adds in trunk
[RenderTreeBuilder] Multi-column spanners are not part of the enclosing multi-column renderer's subtree
https://bugs.webkit.org/show_bug.cgi?id=224914
<rdar://76846946>
Reviewed by Simon Fraser.
Source/WebCore:
This patch handles the case when the newly inserted renderer is a column spanner and checking enclosingFragmentedFlow()
on the spanner's new parent returns the incorrect enclosing multi-column renderer.
This can result in having the spanner in multiple multi-column flows.
(Note that the spanners are directly attached to the RenderBlockFlow that establishes the multi-column context, while non-spanner
renderers are part of the RenderMultiColumnFlow subtree. e.g
RenderBlockFlow <- spanner's parent.
RenderMultiColumnFlow
Non-spanner renderer
spanner renderer
calling enclosingFragmentedFlow() on a spanner's parent (RenderBlockFlow) returns the parent multi-column flow -and
not the one it establishes. e.g.
RenderMultiColumnFlow <- parent multi-column flow -in case of nested columns.
RenderBlockFlow <- spanner's parent.
RenderMultiColumnFlow
Non-spanner renderer
spanner renderer
)
Test: fast/multicol/spanner-inserted-to-multiple-multicolumns.html
- rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::childFlowStateChangesAndAffectsParentBlock):
LayoutTests:
- fast/multicol/spanner-inserted-to-multiple-multicolumns-expected.txt: Added.
- fast/multicol/spanner-inserted-to-multiple-multicolumns.html: Added.
- 2:56 PM Changeset in webkit [276463] by
-
- 2 edits in trunk/Source/WebCore
[WebXR] Optional button test is incorrect
https://bugs.webkit.org/show_bug.cgi?id=224945
Reviewed by Tim Horton.
Fix a conditional test that was always true.
- testing/WebFakeXRInputController.cpp:
(WebCore::WebFakeXRInputController::getButtonOrPlaceholder const):
(A != B A != C) -> (A != B && A != C) - 2:50 PM Changeset in webkit [276462] by
-
- 2 edits in trunk/Source/WebCore
[WebXR] Closure is capturing this unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=224946
Reviewed by Tim Horton.
Remove the "this" capture.
- Modules/webxr/WebXRInputSourceArray.cpp:
(WebCore::WebXRInputSourceArray::handleRemovedInputSources):
- 2:19 PM Changeset in webkit [276461] by
-
- 2 edits in trunk/Source/WebKit
NowPlayingInfoForGPUManager::clearNowPlayingInfoPrivate() sometimes launches the GPUProcess on page close
https://bugs.webkit.org/show_bug.cgi?id=224939
Reviewed by Simon Fraser.
Make sure NowPlayingInfoForGPUManager::clearNowPlayingInfoPrivate() never launches the GPUProcess. The GPU
process already takes care of clearing now playing info on exit.
- WebProcess/GPU/media/WebMediaStrategy.cpp:
(WebKit::WebMediaStrategy::createNowPlayingManager const):
- 1:52 PM Changeset in webkit [276460] by
-
- 5 edits in trunk/Source/WebKit
Call RemoteMediaEngineConfigurationFactory::registerFactory() in WebProcess::setUseGPUProcessForMedia()
https://bugs.webkit.org/show_bug.cgi?id=224937
Reviewed by Eric Carlson.
Call RemoteMediaEngineConfigurationFactory::registerFactory() in WebProcess::setUseGPUProcessForMedia(),
like we used to do, instead of doing it in the GPUProcessConnection constructor. It is safer to
register the factory before we have a GPUProcessConnection and we wouldn't want things to behave
differently depending on whether or not the GPUProcess is already launched. I made sure that this does
not eagerly launch the GPUProcess.
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::GPUProcessConnection):
(WebKit::GPUProcessConnection::mediaEngineConfigurationFactory): Deleted.
- WebProcess/GPU/GPUProcessConnection.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setUseGPUProcessForMedia):
(WebKit::WebProcess::mediaEngineConfigurationFactory):
- WebProcess/WebProcess.h:
- 1:36 PM Changeset in webkit [276459] by
-
- 2 edits in trunk/Source/WebKit
Fix ENABLE macro around NetworkProcessConnection::connectToRTCDataChannelRemoteSource declaration
https://bugs.webkit.org/show_bug.cgi?id=224938
Patch by Alex Christensen <achristensen@webkit.org> on 2021-04-22
Reviewed by Chris Dumez.
This matches the macro around the definition.
- WebProcess/Network/NetworkProcessConnection.h:
- 1:25 PM Changeset in webkit [276458] by
-
- 4 edits2 deletes in trunk
Unreviewed, reverting r271644.
https://bugs.webkit.org/show_bug.cgi?id=224908
Caused regression
<http://webkit.org/b/221962|webkit.org/b/221962>
Reverted changeset:
"[css-multicol] OOM with 1px height columns"
https://bugs.webkit.org/show_bug.cgi?id=220490
https://trac.webkit.org/changeset/271644
- 1:22 PM Changeset in webkit [276457] by
-
- 2 edits in trunk/Tools
Add "Tim Nguyen" to contributors.json.
https://bugs.webkit.org/show_bug.cgi?id=224936
Patch by Tim Nguyen <ntim@apple.com> on 2021-04-22
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/common/config/contributors.json:
- 1:17 PM Changeset in webkit [276456] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC} Remove exception checks from non-throwing function calls in Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=224920
Reviewed by Tadeu Zagallo.
These functions are not taking JSGlobalObject and will not throw an error.
Use callOperationNoExceptionCheck instead to avoid emitting unnecessary exception checks.
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emit_op_profile_type):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_profile_type):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
- 1:01 PM Changeset in webkit [276455] by
-
- 2 edits in trunk/Tools
[Win][WTR] eventSender.leapForward doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=224918
Reviewed by Don Olmstead.
fast/events/click-count.html was failing because
eventSender.leapForward didn't work as expected.
Use Sleep() API to implement it as well as DRT does.
- WebKitTestRunner/win/EventSenderProxyWin.cpp:
(WTR::EventSenderProxy::dispatchMessage):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::leapForward):
- 12:48 PM Changeset in webkit [276454] by
-
- 4 edits in trunk
v2: REGRESSION(r266890): [Cocoa] Fix API::InspectorClient leak
https://bugs.webkit.org/show_bug.cgi?id=223899
<rdar://problem/75249282>
Reviewed by Devin Rousso.
Address post-review feedback.
Source/WebKit:
- UIProcess/API/Cocoa/_WKInspectorTesting.mm:
(-[_WKInspector _openURLExternallyForTesting:useFrontendAPI:]):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm:
(TEST):
- 12:32 PM Changeset in webkit [276453] by
-
- 2 edits in trunk/Source/WebKit
Add some new messages.in files to the Mac CMake build
- PlatformMac.cmake:
- 12:21 PM Changeset in webkit [276452] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, reverting r276393.
This expectation is needed so that the test will pass on bots
Reverted changeset:
"Mass removing prior test expectations that don't need to be
set anymore"
https://bugs.webkit.org/show_bug.cgi?id=224898
https://commits.webkit.org/r276393
- 12:19 PM Changeset in webkit [276451] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Update sandbox message filter syntax
https://bugs.webkit.org/show_bug.cgi?id=223384
<rdar://problem/75531614>
Reviewed by Brent Fulgham.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 11:44 AM Changeset in webkit [276450] by
-
- 61 edits2 adds in trunk
Implement FontFace in Workers for OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=224178
<rdar://problem/76529024>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
FontFace is now available for Workers, rebaseline related tests.
- web-platform-tests/css/css-font-loading/fontfaceset-load-css-wide-keywords-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.align.center.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.align.end.ltr.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.align.end.rtl.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.align.left.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.align.right.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.align.start.ltr.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.align.start.rtl.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.alphabetic.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.bottom.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.hanging.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.ideographic.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.middle.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.top.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.fill.maxWidth.bound.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.fill.maxWidth.fontface.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.fontface.notinpage.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.fontface.repeat.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.fontface.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.space.basic.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.space.collapse.end.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.space.collapse.nonspace.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.space.collapse.other.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.space.collapse.space.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.draw.space.collapse.start.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.measure.actualBoundingBox.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.measure.advances.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.measure.baselines.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.measure.emHeights.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.measure.fontBoundingBox.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.measure.width.basic.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.measure.width.empty.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.measure.width.space.worker-expected.txt:
Source/WebCore:
To comply with spec and complete the OffscreenCanvas implementation,
FontFace needs to be made available on WorkerGlobalScope. This patch
makes it available and fixes crashes using it due to accessing
main-thread only singletons.
No new tests, rebaselined existing tests.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj: Add new files WorkerFontLoadRequest.cpp, WorkerFontLoadRequest.h
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontCacheFallingBackToSingleton):
(WebCore::CSSFontFace::font):
- css/CSSFontFace.h: Use the ScriptExecutionContext's FontCache if possible when loading fonts.
- css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
(WebCore::CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts):
Use the correct CSSValuePool and FontCache in
ensureLocalFontFacesForFamilyRegistered. Also clarify a vaguely-named
variable.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::CSSFontFaceSource):
Use FontLoadRequest::isPending instead of making assumptions about the
request state on construction.
- css/FontFace.cpp:
(WebCore::FontFace::create):
(WebCore::FontFace::display const):
- css/FontFace.h:
- css/FontFace.idl: Construct with a ScriptExecutionContext instead of a Document and make available for Workers.
- css/FontFaceSet.idl: Expose to Workers.
- loader/FontLoadRequest.h:
(WebCore::FontLoadRequest::isWorkerFontLoadRequest const):
Add isPending function and new type WorkerFontLoadRequest.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::createCustomFontData):
Use convertWOFFToSfntIfNecessary().
- loader/cache/CachedFontLoadRequest.h: Implement FontLoadRequest::isPending.
- platform/graphics/Font.cpp:
(WebCore::Font::create):
(WebCore::Font::Font):
(WebCore::Font::systemFallbackFontForCharacter const):
- platform/graphics/Font.h: Add an optional FontCache parameter for use with vertical font data retrieval and add a FontCache parameter to systemFallbackFontForCharacter instead of using the singleton.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::fontForPlatformData):
Pass FontCache parameter when creating fonts.
- platform/graphics/FontCache.h:
(WebCore::FontCache::fontCacheFallingBackToSingleton):
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::update const):
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::FontCascade::fontForCombiningCharacterSequence const):
Rename fontCacheFallbackToSingleton -> fontCacheFallingBackToSingleton
- platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::realizeFallbackRangesAt):
(WebCore::FontCascadeFonts::glyphDataForSystemFallback):
Use familyNamesData instead of familyNames and pass the FontCache
parameter when calling glyphDataForSystemFallback to make this safe
to use in a Worker.
- platform/graphics/FontTaggedSettings.h: Add missing wtf/Hasher.h include.
- platform/graphics/WOFFFileFormat.cpp:
(WebCore::convertWOFFToSfntIfNecessary):
- platform/graphics/WOFFFileFormat.h: Add utility function to convert WOFF fonts on non-Cocoa platforms.
- workers/WorkerFontLoadRequest.cpp: Added.
(WebCore::WorkerFontLoadRequest::WorkerFontLoadRequest):
(WebCore::WorkerFontLoadRequest::load):
(WebCore::WorkerFontLoadRequest::ensureCustomFontData):
(WebCore::WorkerFontLoadRequest::createFont):
(WebCore::WorkerFontLoadRequest::setClient):
(WebCore::WorkerFontLoadRequest::didReceiveResponse):
(WebCore::WorkerFontLoadRequest::didReceiveData):
(WebCore::WorkerFontLoadRequest::didFinishLoading):
(WebCore::WorkerFontLoadRequest::didFail):
- workers/WorkerFontLoadRequest.h: Added. Implement FontLoadRequest for Workers.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::fonts):
(WebCore::WorkerGlobalScope::fontLoadRequest):
(WebCore::WorkerGlobalScope::beginLoadingFontSoon):
- workers/WorkerGlobalScope.h: Implement ScriptExecutionContext font-loading related functions.
- workers/WorkerGlobalScope.idl: Include FontFaceSource.
- 11:41 AM Changeset in webkit [276449] by
-
- 5 edits1 add in trunk
[JSC] Baseline should have fast path for switch_imm
https://bugs.webkit.org/show_bug.cgi?id=224521
Reviewed by Tadeu Zagallo.
JSTests:
- stress/switch-imm-baseline.js: Added.
(shouldBe):
(test):
Source/JavaScriptCore:
This patch implements op_switch_imm fast path in Baseline.
We have this fast path in LLInt, DFG, and FTL. So only Baseline lacks this.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_switch_imm):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_switch_imm):
- 11:09 AM Changeset in webkit [276448] by
-
- 13 edits7 adds in trunk
[GTK] Turn on editable <input type=date> and <input type=time> fields
https://bugs.webkit.org/show_bug.cgi?id=224921
Reviewed by Carlos Garcia Campos.
.:
Turn on editable date and time inputs for GTK
- Source/cmake/OptionsGTK.cmake: Add new source file to the list.
Source/WebCore:
Turn on editable date and time inputs for GTK.
No new tests. This is covered by enabling existing <input type=date>
and <input type=time> tests.
- Headers.cmake: Add headers to the list.
- loader/EmptyClients.cpp: Add missing header include.
Source/WebKit:
Turn on editable date and time inputs for GTK.
- SourcesGTK.txt: Add source file.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createDateTimePicker): Added.
- UIProcess/API/gtk/PageClientImpl.h: Added method declaration.
- UIProcess/gtk/WebDateTimePickerGtk.cpp: Added. Stub for date/time picker which
doesn't have any user interface. This will allow clients to use the editable shadow
DOM date/time input editable fields.
(WebKit::WebDateTimePickerGtk::create):
(WebKit::WebDateTimePickerGtk::~WebDateTimePickerGtk):
(WebKit::WebDateTimePickerGtk::WebDateTimePickerGtk):
(WebKit::WebDateTimePickerGtk::endPicker):
(WebKit::WebDateTimePickerGtk::showDateTimePicker):
- UIProcess/gtk/WebDateTimePickerGtk.h: Added.
Source/WTF:
Turn on editable date and time inputs for GTK.
- Scripts/Preferences/WebPreferencesInternal.yaml: Set editable date/time inputs
on by default for GTK as well.
LayoutTests:
Turn on editable date and time inputs for GTK.
- platform/gtk/TestExpectations: Enable new forms test for WebKitGTK.
- platform/gtk/fast/forms/date/date-input-rendering-basic-expected.txt: Added.
- platform/gtk/fast/forms/date/date-pseudo-elements-expected.txt: Added.
- platform/gtk/fast/forms/time/time-input-rendering-basic-expected.txt: Added.
- 11:05 AM Changeset in webkit [276447] by
-
- 5 edits in trunk/Source
Fix the tvOS build after r276325
https://bugs.webkit.org/show_bug.cgi?id=224929
<rdar://problem/77003408>
Reviewed by Wenson Hsieh.
Source/WebKit:
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/forms/WKDateTimeInputControl.mm:
[UIColor systemBackgroundColor] is SPI on tvOS.
(-[WKDateTimePickerViewController viewDidLoad]):
UIBlurEffectStyleSystemMaterial is not available on tvOS. Instead, use
a UIView with a system background color as the background view.
Source/WTF:
Fix the tvOS build after r276325
- wtf/PlatformHave.h:
- 11:00 AM Changeset in webkit [276446] by
-
- 2 edits in trunk/Source/WebKit
v2: Web Inspector: exempt API::SharedJSContext from remote inspection and automatic inspection
https://bugs.webkit.org/show_bug.cgi?id=224841
<rdar://69386559>
Reviewed by Devin Rousso.
Use the RemoteInspector C SPI to temporarily turn off "allow remote inspection by default".
- UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:
(API::SharedJSContext::ensureContext):
- 10:12 AM Changeset in webkit [276445] by
-
- 4 edits in trunk
[css-grid] WPT Tests css/css-grid/grid-items/grid-item-percentage-sizes-*.html fail
https://bugs.webkit.org/show_bug.cgi?id=209650
Patch by Ziran Sun <Ziran Sun> on 2021-04-22
Reviewed by Sergio Villar Senin.
Source/WebCore:
We need to check child's writing mode in order to pick the correct dimension to resolve
percentage height against. Overriding containing block size should also be chosen in favour
of special code for orthogonal writing mode.
This change is an import of Chromium CL at
https://chromium-review.googlesource.com/c/chromium/src/+/1348055.
Three tests that failed are now passing.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight const):
LayoutTests:
- TestExpectations: grid-item-percentage-sizes-00{1-3}.html are passing and unskipped now.
- 9:52 AM Changeset in webkit [276444] by
-
- 1 copy in tags/Safari-611.1.21.161.5
Tag Safari-611.1.21.161.5.
- 9:44 AM Changeset in webkit [276443] by
-
- 8 edits in branches/safari-611.1.21.161-branch/Source
Versioning.
WebKit-7611.1.21.161.5
- 9:43 AM Changeset in webkit [276442] by
-
- 3 edits in trunk/Tools
Ensure all non-local AutoInstalled libraries specify version
https://bugs.webkit.org/show_bug.cgi?id=224872
Reviewed by Jonathan Bedard.
Currently on Python 3 running test-webkitpy fails due to us attempting to
install flask 2.0.0rc1, recently released. We shouldn't, however, be installing
the latest possible version of flask, but rather specifying one. We do actually
attempt to specify one in webkitflaskpy, but we pass the Version object to the
wrong place.
Now actually specifying the versions, we need to change some of them to the
latest version which supports Python 2 to be able to install them to run
test-webkitpy-python2.
To ensure we don't repeat this, this makes AutoInstall.register raise if you try
to register a non-local package without specifying a version.
Additionally, require AutoInstall.register's package argument be a Package by
passing moving the lookup to AutoInstall.install and requiring it to be
successful.
Finally, while I'm touching this, make registering 'autoinstalled' an outright
failure, and make installing a local package fail if it cannot be found.
- Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(AutoInstall.register):
(AutoInstall.install):
- Scripts/libraries/webkitflaskpy/webkitflaskpy/init.py:
- 9:38 AM Changeset in webkit [276441] by
-
- 5 edits1 add in trunk
[iOS] The Look Up text service popover should avoid covering selected text
https://bugs.webkit.org/show_bug.cgi?id=224915
rdar://75891746
Reviewed by Megan Gardner.
Source/WebKit:
Adjust the presentation rect when showing the Look Up text service popup using the callout bar on iOS so that
we use the entire bounds of the selection. Currently, we only use the first selection rect (top to bottom) as
the presentation rect, which may cause the popup to obscure selected text.
This seems to have been derived from iOS legacy web view behavior that dating back to rdar://7475904; while the
exact reasoning for this is effectively lost to time, it's likely due to how there used to only be a single
block selection rect in non-editable content in iOS 5 anyways, so taking only the first selection rect would not
be incorrect. However, we now use character granularity selection everywhere in WebKit2, so this logic is no
longer sensible.
Test: TextServicesTests.LookUpPresentationRect
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _lookupForWebView:]):
(-[WKContentView _translateForWebView:]):
Make a similar adjustment here, since this presentation rect is intended to match that of the Look Up popover.
Tools:
Add a new API test to exercise the change.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/ios/TextServicesTests.mm: Added.
(TestWebKitAPI::handleLookup):
(TestWebKitAPI::TEST):
- TestWebKitAPI/ios/UIKitSPI.h: Add SPI declarations for UIWKTextInteractionAssistant.
- 9:35 AM Changeset in webkit [276440] by
-
- 6 edits in branches/safari-612.1.11-branch/Source
Cherry-pick r275899. rdar://problem/76986496
Revert r275172
https://bugs.webkit.org/show_bug.cgi?id=224499
<rdar://76396241>
Patch by Alex Christensen <achristensen@webkit.org> on 2021-04-13
Reviewed by Tim Horton.
Source/WebKit:
It turns out that terminate_with_reason uses a different syscall than xpc_connection_kill in its implementation,
and the former is not allowed by Messages's sandbox yet. Revert for Messages until they add it.
- Platform/IPC/cocoa/ConnectionCocoa.mm: (IPC::ConnectionTerminationWatchdog::watchdogTimerFired): (IPC::Connection::kill):
- Platform/spi/Cocoa/ReasonSPI.h:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::platformInvalidate): (WebKit::terminateWithReason):
Source/WTF:
- wtf/spi/darwin/XPCSPI.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:34 AM Changeset in webkit [276439] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Re-block access to SYS_setattrlist
https://bugs.webkit.org/show_bug.cgi?id=224892
<rdar://problem/74828532>
Reviewed by Per Arne Vollan.
No new tests. No change in behavior.
- WebProcess/com.apple.WebProcess.sb.in:
- 9:12 AM Changeset in webkit [276438] by
-
- 3 edits in trunk/Tools
Services EWS should run for webkitscmpy and webkitcorepy changes
https://bugs.webkit.org/show_bug.cgi?id=223941
Reviewed by Jonathan Bedard.
- CISupport/ews-build/steps.py:
(CheckPatchRelevance):
- CISupport/ews-build/steps_unittest.py: Added unit-test.
- 9:04 AM Changeset in webkit [276437] by
-
- 5 edits in trunk/Source/WebKit
Call RemoteCDMFactory::registerFactory() in WebProcess::setUseGPUProcessForMedia()
https://bugs.webkit.org/show_bug.cgi?id=224907
Reviewed by Eric Carlson.
Call RemoteCDMFactory::registerFactory() in WebProcess::setUseGPUProcessForMedia() like we
did before r275887, instead of doing it in the GPUProcessConnection constructor. This is
safer as it makes sure the CDMFactory gets registered even if the GPUProcess has not launched
yet. This is also more consistent with what we do for LegacyCDM since Bug 224905.
The MediaKeys API still seems functional after r275887 (unlike the LegacyCDM one) so it does
not seem it caused obvious breakage. That said, it is still safer to restore pre-r275887
behavior. There is also no drawback to restoring the previous behavior since I made sure the
GPUProcess does not get launched eagerly.
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::GPUProcessConnection):
(WebKit::GPUProcessConnection::dispatchMessage):
- WebProcess/GPU/GPUProcessConnection.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setUseGPUProcessForMedia):
(WebKit::WebProcess::cdmFactory):
- WebProcess/WebProcess.h:
- 8:17 AM Changeset in webkit [276436] by
-
- 4 edits1 move1 delete in trunk/Tools
Add an xfail marker for webkitpy's tests; get SCM passing
https://bugs.webkit.org/show_bug.cgi?id=224886
Reviewed by Jonathan Bedard.
Also:
Delete the old, unused skip_if decorator.
Fix our runner to detect unexpected-success and report them as failures.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitSVNTest.test_rebase_in_progress):
(GitTestWithMock.test_create_patch):
- Scripts/webkitpy/test/markers.py:
(xfail):
(xfail.decorator):
- Scripts/webkitpy/test/runner.py:
(Runner.handle):
(_Worker.handle):
(TestResult):
(TestResult.init):
(TestResult.addSuccess):
- Scripts/webkitpy/test/runner_unittest.py:
(FakeTestCase):
(FakeTestCase.init):
(FakeTestCase.id):
(FakeModuleSuite.run):
- Scripts/webkitpy/test/skip.py: Removed.
- Scripts/webkitpy/test/skip_unittest.py: Removed.
- 7:48 AM Changeset in webkit [276435] by
-
- 2 edits in trunk/Tools
server_process_unittest.py's MockFile should all be bytes
https://bugs.webkit.org/show_bug.cgi?id=224877
Reviewed by Jonathan Bedard.
This fixes the test when run under pytest on Python 3.
- Scripts/webkitpy/port/server_process_unittest.py:
(MockFile.read):
- 7:09 AM Changeset in webkit [276434] by
-
- 6 edits in trunk/Tools
Fix potential flakiness when running webkitpy tests
https://bugs.webkit.org/show_bug.cgi?id=224887
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.serial_test_run_in_parallel): Increase the delay to ensure it's
much greater than the VM spawn time, as the current time is a bit marginal when
the system is under load and we're using the spawn multiprocessing start method
- Scripts/webkitpy/test/main.py:
(Tester.run): Allow argv to be passed through for testing
- Scripts/webkitpy/test/main_unittest.py:
(TesterTest.test_no_tests_found): Explicitly pass argv to avoid using sys.argv
- Scripts/webkitpy/w3c/test_parser_unittest.py:
(TestParserTest.test_analyze_pixel_test_all_true): Reset options after test
(TestParserTest.test_analyze_pixel_test_all_false): Reset options after test
- Scripts/webkitpy/xcode/simulated_device_unittest.py:
(SimulatedDeviceTest.reset_simulated_device_manager): _device_identifier_to_name
is a dict, and should remain one
- 7:06 AM Changeset in webkit [276433] by
-
- 33 edits4 copies11 adds in trunk
Implement WebXR Input Sources
https://bugs.webkit.org/show_bug.cgi?id=223257
Reviewed by Youenn Fablet.
.:
Enable WPE Gamepad when WebXR is enabled.
- Source/cmake/OptionsWPE.cmake:
LayoutTests/imported/w3c:
Update WebXR Input Source test expectations.
- web-platform-tests/webxr/events_input_source_recreation.https-expected.txt: Added.
- web-platform-tests/webxr/events_input_sources_change.https-expected.txt: Added.
- web-platform-tests/webxr/events_session_select.https-expected.txt: Added.
- web-platform-tests/webxr/events_session_select_subframe.https-expected.txt: Added.
- web-platform-tests/webxr/events_session_squeeze.https-expected.txt: Added.
- web-platform-tests/webxr/getInputPose_handedness.https-expected.txt: Added.
- web-platform-tests/webxr/xrInputSource_add_remove.https-expected.txt: Added.
- web-platform-tests/webxr/xrInputSource_emulatedPosition.https-expected.txt: Added.
- web-platform-tests/webxr/xrInputSource_profiles.https-expected.txt: Added.
- web-platform-tests/webxr/xrInputSource_sameObject.https-expected.txt: Added.
- web-platform-tests/webxr/xrReferenceSpace_originOffset.https-expected.txt: Added.
Source/WebCore:
This patch implements the platform data definition and the DOM bits required to support WebXR Input Sources, the input mechanism used in WebXR.
Example XR input sources include, but are not limited to, handheld controllers, optically tracked hands, and gaze-based input methods.
More info about the API in:
- https://immersive-web.github.io/webxr/#input
- https://immersive-web.github.io/webxr-gamepads-module/#webxr-device-api-integration
Tested by WebXR WPT.
- Modules/gamepad/Gamepad.h: Add setConnected method.
- Modules/webxr/WebXRGamepad.cpp: Bridge between WebXRInputSource and Gamepad
(WebCore::WebXRGamepad::WebXRGamepad):
- Modules/webxr/WebXRGamepad.h:
- Modules/webxr/WebXRInputSpace.cpp: Instance of WebXRSpace used for WebXRInputSource spaces.
(WebCore::WebXRInputSpace::create):
(WebCore::WebXRInputSpace::WebXRInputSpace):
(WebCore::WebXRInputSpace::nativeOrigin const):
- Modules/webxr/WebXRInputSpace.h:
- Modules/webxr/WebXRFrame.cpp:
(WebCore::WebXRFrame::populatePose): set emulatedPosition based on the spaces.
- Modules/webxr/WebXRInputSource.cpp: Complete WebXRInputSource implementation.
(WebCore::WebXRInputSpace::create):
(WebCore::WebXRInputSpace::WebXRInputSpace):
(WebCore::WebXRInputSpace::nativeOrigin const):
(WebCore::WebXRInputSource::create):
(WebCore::WebXRInputSource::WebXRInputSource):
(WebCore::WebXRInputSource::update):
(WebCore::WebXRInputSource::requiresInputSourceChange):
(WebCore::WebXRInputSource::disconnect):
(WebCore::WebXRInputSource::pollEvents):
(WebCore::WebXRInputSource::createEvent):
- Modules/webxr/WebXRInputSource.h:
(WebCore::WebXRInputSource::handle const):
(WebCore::WebXRInputSource::handedness const):
(WebCore::WebXRInputSource::targetRayMode const):
(WebCore::WebXRInputSource::targetRaySpace const):
(WebCore::WebXRInputSource::gripSpace const):
(WebCore::WebXRInputSource::profiles const):
(WebCore::WebXRInputSource::gamepad const):
- Modules/webxr/WebXRInputSource.idl: Add gamepad attribute.
- Modules/webxr/WebXRInputSourceArray.cpp: Implement input source updates and event dispatching.
(WebCore::WebXRInputSourceArray::create):
(WebCore::WebXRInputSourceArray::WebXRInputSourceArray):
(WebCore::WebXRInputSourceArray::length const):
(WebCore::WebXRInputSourceArray::item const):
(WebCore::WebXRInputSourceArray::clear):
(WebCore::WebXRInputSourceArray::update):
(WebCore::WebXRInputSourceArray::handleRemovedInputSources):
(WebCore::WebXRInputSourceArray::handleAddedOrUpdatedInputSources):
- Modules/webxr/WebXRInputSourceArray.h:
- Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::WebXRSession): Set tracking delegate before initializing tracking and rendering.
(WebCore::WebXRSession::isPositionEmulated const): Add helper method.
(WebCore::WebXRSession::shutdown): Clear WebXRInputSourceArray instance.
(WebCore::WebXRSession::sessionDidInitializeInputSources): Dispatch initial InputSource discovery event.
(WebCore::WebXRSession::onFrame): Update WebXRInputSourceArray instance.
- Modules/webxr/WebXRSession.h:
- Modules/webxr/WebXRSpace.cpp: Add virtual class isPositionEmulated to be used in WebXRFrame.
(WebCore::WebXRSpace::isPositionEmulated const):
- Modules/webxr/WebXRSpace.h:
- Modules/webxr/WebXRSystem.cpp:
(WebCore::WebXRSystem::requestSession): update FIXME comment.
- Modules/webxr/XRHandedness.h: Reuse PlatformXR enum.
- Modules/webxr/XRInputSourceEvent.cpp:
(WebCore::XRInputSourceEvent::XRInputSourceEvent):
(WebCore::XRInputSourceEvent::setFrameActive):
- Modules/webxr/XRInputSourceEvent.h:
- Modules/webxr/XRInputSourcesChangeEvent.h:
- Modules/webxr/XRTargetRayMode.h: Reuse PlatformXR enum.
- platform/gamepad/GamepadConstants.cpp:
(WebCore::xrStandardGamepadMappingString): Add xr-standard gamepad mapping name.
- platform/gamepad/GamepadConstants.h:
- platform/xr/PlatformXR.h: Add Input Source frame data.
- testing/WebFakeXRDevice.cpp: Implement required changes to run and pass WebXR Input Source tests.
(WebCore::SimulatedXRDevice::initializeTrackingAndRendering):
(WebCore::SimulatedXRDevice::frameTimerFired):
(WebCore::WebFakeXRDevice::simulateResetPose):
(WebCore::WebFakeXRDevice::simulateInputSourceConnection):
- testing/WebFakeXRDevice.h:
- testing/WebFakeXRInputController.cpp:
(WebCore::WebFakeXRInputController::create):
(WebCore::WebFakeXRInputController::WebFakeXRInputController):
(WebCore::WebFakeXRInputController::setGripOrigin):
(WebCore::WebFakeXRInputController::setPointerOrigin):
(WebCore::WebFakeXRInputController::disconnect):
(WebCore::WebFakeXRInputController::reconnect):
(WebCore::WebFakeXRInputController::setSupportedButtons):
(WebCore::WebFakeXRInputController::updateButtonState):
(WebCore::WebFakeXRInputController::getFrameData):
(WebCore::WebFakeXRInputController::getButtonOrPlaceholder const):
- testing/WebFakeXRInputController.h:
LayoutTests:
Update WebXR Input Source test expectations.
- platform/wpe/TestExpectations:
- 5:18 AM Changeset in webkit [276432] by
-
- 9 edits in trunk
[SOUP] Add support for preconnect
https://bugs.webkit.org/show_bug.cgi?id=177934
Reviewed by Sergio Villar Senin.
.:
Enable server preconnect support when building with libsoup3.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
Source/WebKit:
Use new libsoup API to implement preconnect support.
- NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::create):
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup):
(WebKit::NetworkDataTaskSoup::createRequest):
(WebKit::NetworkDataTaskSoup::resume):
(WebKit::NetworkDataTaskSoup::preconnectCallback):
- NetworkProcess/soup/NetworkDataTaskSoup.h:
LayoutTests:
Remove expectations for tests that are now passing.
- platform/glib/TestExpectations:
- 5:14 AM Changeset in webkit [276431] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
Unreviewed, WPE build fix after r276390
Fix namespacing issues in nullptr_t invocations.
- src/compiler/translator/tree_util/IntermRebuild.cpp:
(sh::TIntermRebuild::BaseResult::BaseResult):
(sh::PreResult::PreResult):
(sh::PostResult::PostResult):
- src/compiler/translator/tree_util/IntermRebuild.h:
- 4:52 AM Changeset in webkit [276430] by
-
- 2 edits in trunk/Source/WebKit
[GTK] Build error: Couldn't find include 'Soup-2.4.gir'
https://bugs.webkit.org/show_bug.cgi?id=224926
Reviewed by Philippe Normand.
Use the right soup API version when generating the introspection.
- PlatformGTK.cmake:
- 4:47 AM Changeset in webkit [276429] by
-
- 10 edits in trunk
[GTK][WPE] Bump libsoup3 version to 2.99.4
https://bugs.webkit.org/show_bug.cgi?id=224925
Reviewed by Philippe Normand.
.:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
Source/WebCore:
Update to use the new API.
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::ResourceResponse):
- platform/network/soup/SoupVersioning.h:
(soup_message_get_tls_peer_certificate):
(soup_message_get_tls_peer_certificate_errors):
(soup_message_get_tls_certificate): Deleted.
(soup_message_get_tls_certificate_errors): Deleted.
Tools/buildstream:
- elements/sdk/libsoup3.bst:
LayoutTests:
Remove expectations for tests that should be passing now.
- platform/glib/TestExpectations:
- 1:29 AM Changeset in webkit [276428] by
-
- 9 edits1 add in trunk
[iOS] Web processes recreated after crashing are not created with the right contentSizeCategory
https://bugs.webkit.org/show_bug.cgi?id=224916
Reviewed by Tim Horton.
Source/WebCore:
The constructor of WKWebView sets the contentSizeCategory for the first page.
But if the web process crashes, the new one won't have it set.
This patch simply adds the contentSizeCategory to the WebProcessCreationParameters.
Tests: TextStyleFontSize.Startup
TextStyleFontSize.AfterCrash
- rendering/RenderThemeCocoa.h:
Source/WebKit:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/ios/TextStyleFontSize.mm: Added.
(-[TextStyleFontSizeWebView _contentSizeCategory]):
(TEST):
- 1:27 AM Changeset in webkit [276427] by
-
- 18 edits2 adds in trunk
[JSC] DFG / FTL should inline switch_string
https://bugs.webkit.org/show_bug.cgi?id=224578
Reviewed by Mark Lam.
JSTests:
- microbenchmarks/switch-inlining.js: Added.
(inner):
(outer):
- stress/switch-inlining-nested.js: Added.
(shouldBe):
(inner):
(outer):
Source/JavaScriptCore:
Because of r275840 change, we no longer copy StringJumpTable when compiling DFG / FTL code.
Instead we are using a pointer to UnlinkedStringTable stored in UnlinkedCodeBlock.
This allows DFG / FTL to inline CodeBlock which includes op_switch_string. We were previously not able
to do that because we cannot copy StringImpl in DFG / FTL concurrent compiler thread.
- We handle StringJumpTable / UnlinkedStringJumpTable in the same way as SimpleJumpTable / UnlinkedSimpleJumpTable.
- We put m_ctiDefault of StringJumpTable in the last element of m_ctiOffsets vector of StringJumpTable to make sizeof(StringJumpTable) small.
- We use m_indexInTable instead of m_branchOffset in FTL switch generation to make switch table dense.
The microbenchmark shows 30% improvement because of unlocking inlining feature.
ToT Patched
switch-inlining 27.1238+-0.2708 20.2630+-0.1477 definitely 1.3386x faster
<geometric> 27.1238+-0.2708 20.2630+-0.1477 definitely 1.3386x faster
- bytecode/JumpTable.h:
(JSC::StringJumpTable::ensureCTITable):
(JSC::StringJumpTable::ctiForValue const):
(JSC::StringJumpTable::ctiDefault const):
(JSC::StringJumpTable::isEmpty const):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedStringJumpTable::indexForValue const):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchStringOnString):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::switchStringSlow):
- ftl/FTLOperations.cpp:
(JSC::FTL::JSC_DEFINE_JIT_OPERATION):
- ftl/FTLOperations.h:
- jit/JIT.cpp:
(JSC::JIT::link):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_switch_string):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_switch_string):
- jit/JITOperations.cpp:
(JSC::JSC_DEFINE_JIT_OPERATION):
- 1:25 AM WebKitGTK/2.32.x edited by
- (diff)
- 12:50 AM Changeset in webkit [276426] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r275790) [GTK][WPE] Scrolling rendering fails after the second page
https://bugs.webkit.org/show_bug.cgi?id=224824
Patch by Alejandro G. Castro <alex@igalia.com> on 2021-04-22
Reviewed by Simon Fraser.
We are making the implementation more similar to the Apple
scrolling coordinator. Now we reimplement willStartRenderingUpdate
to be able to synchronize the state there. That way we can avoid
the timer and just schedule a rendering update when we want to
commit the tree state.
Test: Fixes the timeout of the overflow-scrollable-after-back.html,
added in the regression.
- page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp:
(WebCore::ScrollingCoordinatorNicosia::ScrollingCoordinatorNicosia):
(WebCore::ScrollingCoordinatorNicosia::pageDestroyed):
(WebCore::ScrollingCoordinatorNicosia::commitTreeStateIfNeeded):
(WebCore::ScrollingCoordinatorNicosia::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinatorNicosia::willStartRenderingUpdate):
(WebCore::ScrollingCoordinatorNicosia::commitTreeState): Deleted.
- page/scrolling/nicosia/ScrollingCoordinatorNicosia.h:
- 12:40 AM Changeset in webkit [276425] by
-
- 2 edits in trunk/Source/WebCore
GraphicsContextGLOpenGLCocoa should check that ANGLE is loaded in WK1 releaseCurrentContext
https://bugs.webkit.org/show_bug.cgi?id=224532
<rdar://problem/76632149>
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-04-22
Reviewed by Kenneth Russell.
Avoid crashing in case WK1 is used but ANGLE library is not present.
There are some cases where ANGLE could be omitted for size savings.
- platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::releaseCurrentContext):
Apr 21, 2021:
- 11:03 PM Changeset in webkit [276424] by
-
- 16 edits in branches/safari-612.1.11-branch
Cherry-pick r276347. rdar://problem/76986456
Support scrolling to a selected AppHighlight
https://bugs.webkit.org/show_bug.cgi?id=224773
Reviewed by Tim Horton.
Source/WebCore:
Test: AppHighlights::AppHighlightCreateAndRestoreAndScroll
- Modules/highlight/AppHighlightStorage.cpp: (WebCore::AppHighlightStorage::restoreAndScrollToAppHighlight): (WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll): (WebCore::AppHighlightStorage::restoreUnrestoredAppHighlights): (WebCore::AppHighlightStorage::restoreAppHighlight): Deleted.
- Modules/highlight/AppHighlightStorage.h:
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp: (WebCore::TemporarySelectionChange::setSelection):
- page/Page.cpp: (WebCore::Page::doAfterUpdateRendering):
Source/WebKit:
- UIProcess/API/Cocoa/WKWebView.mm: (restoreHighlight): (-[WKWebView _restoreAppHighlights:]): (-[WKWebView _restoreAndScrollToAppHighlight:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::restoreAppHighlightsAndScrollToIndex): (WebKit::WebPageProxy::restoreAppHighlights): Deleted.
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::restoreAppHighlightsAndScrollToIndex): (WebKit::WebPage::restoreAppHighlights): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm: (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:31 PM Changeset in webkit [276423] by
-
- 8 edits in branches/safari-612.1.11-branch/Source
Versioning.
WebKit-7612.1.11.5
- 10:12 PM Changeset in webkit [276422] by
-
- 4 edits49 adds in trunk/LayoutTests
Import css/css-will-change tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=224870
Patch by Tim Nguyen <ntim@apple.com> on 2021-04-21
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- web-platform-tests/css/css-will-change/META.yml: Added.
- web-platform-tests/css/css-will-change/inheritance-expected.txt: Added.
- web-platform-tests/css/css-will-change/inheritance.html: Added.
- web-platform-tests/css/css-will-change/parsing/w3c-import.log: Added.
- web-platform-tests/css/css-will-change/parsing/will-change-computed-expected.txt: Added.
- web-platform-tests/css/css-will-change/parsing/will-change-computed.html: Added.
- web-platform-tests/css/css-will-change/parsing/will-change-invalid-expected.txt: Added.
- web-platform-tests/css/css-will-change/parsing/will-change-invalid.html: Added.
- web-platform-tests/css/css-will-change/parsing/will-change-valid-expected.txt: Added.
- web-platform-tests/css/css-will-change/parsing/will-change-valid.html: Added.
- web-platform-tests/css/css-will-change/w3c-import.log: Added.
- web-platform-tests/css/css-will-change/will-change-abspos-cb-001-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-abspos-cb-001.html: Added.
- web-platform-tests/css/css-will-change/will-change-abspos-cb-002-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-abspos-cb-002.html: Added.
- web-platform-tests/css/css-will-change/will-change-abspos-cb-003-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-abspos-cb-003.html: Added.
- web-platform-tests/css/css-will-change/will-change-abspos-cb-dynamic-001-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-abspos-cb-dynamic-001.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-001-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-001.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-002-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-002.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-003-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-003.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-004-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-004.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-005-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-005.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-006-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-fixedpos-cb-006.html: Added.
- web-platform-tests/css/css-will-change/will-change-inherit-dynamic-expected.txt: Added.
- web-platform-tests/css/css-will-change/will-change-inherit-dynamic.html: Added.
- web-platform-tests/css/css-will-change/will-change-stacking-context-001-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-stacking-context-001.html: Added.
- web-platform-tests/css/css-will-change/will-change-stacking-context-002-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-stacking-context-002.html: Added.
- web-platform-tests/css/css-will-change/will-change-stacking-context-003-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-stacking-context-003.html: Added.
- web-platform-tests/css/css-will-change/will-change-transform-add-content-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-transform-add-content.html: Added.
- web-platform-tests/css/css-will-change/will-change-transform-image-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-transform-image.html: Added.
- web-platform-tests/css/css-will-change/will-change-transform-zero-size-child-overflow-visible-expected.html: Added.
- web-platform-tests/css/css-will-change/will-change-transform-zero-size-child-overflow-visible.html: Added.
- web-platform-tests/css/css-will-change/will-change-will-change-1-expected.xht: Added.
- web-platform-tests/css/css-will-change/will-change-will-change-1.html: Added.
LayoutTests:
- 9:51 PM Changeset in webkit [276421] by
-
- 6 edits in trunk/Source
[Win] GetDoubleClickTime() returns 0 in the non-interactive window station on Windows 10 version 2004
https://bugs.webkit.org/show_bug.cgi?id=224793
Reviewed by Don Olmstead.
Source/WebCore:
Some editing and events tests using double click were failing on
Windows 10 version 2004 and 20H2. DumpRenderTree.exe creates a
non-interactive window station if it is running as admin. However,
GetDoubleClickTime() returns 0 in the window station on the latest
Windows 10.
- platform/win/GDIUtilities.h:
(WebCore::getDoubleClickTime): Added.
Source/WebKit:
- Shared/win/WebEventFactory.cpp:
(WebKit::clickCount): Use WebCore::getDoubleClickTime instead of
GetDoubleClickTime API.
Source/WebKitLegacy/win:
- WebView.cpp:
(WebView::handleMouseEvent): Use WebCore::getDoubleClickTime
instead of GetDoubleClickTime API. Change coding style for
check-webkit-style.
- 9:27 PM Changeset in webkit [276420] by
-
- 3 edits in trunk/LayoutTests
[WinCairo] Unreviewed test gardening
- platform/wincairo-wk1/TestExpectations:
- platform/wincairo/TestExpectations:
- 8:41 PM Changeset in webkit [276419] by
-
- 3 edits2 adds in trunk
Ignore column spanner property for the inner part of a text control.
https://bugs.webkit.org/show_bug.cgi?id=224757
<rdar://problem/76844224>
Reviewed by Antti Koivisto.
Source/WebCore:
Let's not try to span columns with the _inner_ part of a text control. Such subtrees should be opaque to multi-column layout.
(we already do this for <legend>)
Test: fast/multicol/spanner-inside-text-control.html
- rendering/updating/RenderTreeBuilderMultiColumn.cpp:
(WebCore::isValidColumnSpanner):
LayoutTests:
- fast/multicol/spanner-inside-text-control-expected.txt: Added.
- fast/multicol/spanner-inside-text-control.html: Added.
- 8:28 PM Changeset in webkit [276418] by
-
- 17 edits2 deletes in trunk
Unreviewed, reverting r276380 and r276386.
https://bugs.webkit.org/show_bug.cgi?id=224912
Caused WPT css/css-counter-styles/cssom test crashes on macOS
WK1 with ASan
Reverted changesets:
"[css-counter-styles] Parse @counter-style descriptors"
https://bugs.webkit.org/show_bug.cgi?id=224718
https://trac.webkit.org/changeset/276380
"CSSComputedStyleDeclaration.cpp should use C++ style
comments"
https://bugs.webkit.org/show_bug.cgi?id=224875
https://trac.webkit.org/changeset/276386
- 8:20 PM Changeset in webkit [276417] by
-
- 2 edits in trunk/LayoutTests
Mass removing prior test expectations that don't need to be set anymore
https://bugs.webkit.org/show_bug.cgi?id=224898
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Removing test expectation, as it is no longer needed.
- 7:27 PM Changeset in webkit [276416] by
-
- 2 edits in trunk/LayoutTests
[ iOS, EWS ] scrollingcoordinator/ios/fixed-inside-sticky-no-stacking-context-2.html is a constant Image Failure
https://bugs.webkit.org/show_bug.cgi?id=224910
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations: Updating expectation to Failure to speed up EWS while test is reviewed.
- 7:12 PM Changeset in webkit [276415] by
-
- 3 edits1 move1 add11 deletes in trunk/LayoutTests
[GLIB][GTK][WPE] Unreviewed test gardening. Remove redundant baselines.
- platform/glib/TestExpectations:
- platform/glib/fast/canvas/webgl/webgl-compressed-texture-astc-expected.txt: Removed.
- platform/glib/http/tests/loading/oauth-expected.txt: Renamed from LayoutTests/platform/gtk/http/tests/loading/oauth-expected.txt.
- platform/glib/imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/css/css-values/minmax-length-computed-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/css/css-values/minmax-length-percent-computed-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/css/css-values/minmax-length-computed-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/css/css-values/minmax-length-percent-computed-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Removed.
- platform/wpe/TestExpectations:
- platform/wpe/http/tests/loading/oauth-expected.txt: Removed.
- platform/wpe/http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/css/css-values/minmax-length-computed-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/css/css-values/minmax-length-percent-computed-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https-expected.txt: Removed.
- 6:28 PM Changeset in webkit [276414] by
-
- 26 edits1 delete in trunk
[GPUP] Refactor SourceBuffer::enqueuedSamplesForTrackID() for testing purposes
https://bugs.webkit.org/show_bug.cgi?id=224891
Reviewed by Eric Carlson.
Source/WebCore:
This patch is a preparation to run
MockMediaPlayerMediaSourcein the GPU Process.
SourceBuffer::enqueuedSamplesForTrackID()is a synchronous function used for testing
purposes. It works fine when "Media in GPU process" is disabled. However, when
"Media in GPU process" is enabled, we have to use a synchronous IPC message to
implement it. This patch changes it to be a function with a completion handler
parameter, so that we can implement it with an asynchronous IPC message when
we runMockMediaPlayerMediaSourcein the GPU process.
There is no behavior change when "Media in GPU Process" is disabled.
Covered by existing tests.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::enqueuedSamplesForTrackID):
- Modules/mediasource/SourceBuffer.h:
- platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::enqueuedSamplesForTrackID):
- platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::enqueuedSamplesForTrackID): Deleted.
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockSourceBufferPrivate::enqueuedSamplesForTrackID):
- platform/mock/mediasource/MockSourceBufferPrivate.h:
- testing/Internals.cpp:
(WebCore::Internals::enqueuedSamplesForTrackID):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::enqueuedSamplesForTrackID):
- GPUProcess/media/RemoteSourceBufferProxy.h:
- GPUProcess/media/RemoteSourceBufferProxy.messages.in:
- WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
(WebKit::SourceBufferPrivateRemote::bufferedSamplesForTrackId):
(WebKit::SourceBufferPrivateRemote::enqueuedSamplesForTrackID):
- WebProcess/GPU/media/SourceBufferPrivateRemote.h:
LayoutTests:
Update following tests to use the asynchronous
enqueuedSamplesForTrackID().
- media/media-source/media-source-append-acb-no-frame-lost.html:
- media/media-source/media-source-append-acb-tolerance.html:
- media/media-source/media-source-append-presentation-durations.html:
- media/media-source/media-source-dropped-iframe.html:
- media/media-source/media-source-erase-after-last-append.html:
- media/media-source/media-source-first-append-not-starting-at-zero.html:
- media/media-source/media-source-remove-b-frame.html:
- media/media-source/media-source-seek-back.html:
- media/media-source/media-source-timestampoffset-rounding-error.html:
We don't need this platform-specific test expectation now.
- platform/mac/media/media-source/media-source-append-before-last-range-no-quota-exceeded-expected.txt: Removed.
- 6:15 PM Changeset in webkit [276413] by
-
- 2 edits in trunk/Source/WebKit
PCM: Remove PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable overrides in testing
https://bugs.webkit.org/show_bug.cgi?id=224885
<rdar://problem/76973184>
Reviewed by Brent Fulgham.
We had a temporary override to PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable
in WebKit::PrivateClickMeasurementManager::getTokenPublicKey() and
WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken().
This patch removes those overrides since the network load hang has been resolved.
No new tests. Existing tests cover this code.
- NetworkProcess/PrivateClickMeasurementManager.cpp:
(WebKit::PrivateClickMeasurementManager::getTokenPublicKey):
(WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken):
- 6:04 PM Changeset in webkit [276412] by
-
- 3 edits in trunk/LayoutTests
Mass removal of prior test expectations that do not need to be set anymore.
https://bugs.webkit.org/show_bug.cgi?id=224901
Unreviewed test gardening.
Two more tests removed from test expectations.
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 5:59 PM Changeset in webkit [276411] by
-
- 8 edits in trunk
Regression(r275887) open.spotify.com says Safari is not supported
https://bugs.webkit.org/show_bug.cgi?id=224905
<rdar://76982108>
Reviewed by Eric Carlson.
Source/WebKit:
Move legacyCDMFactory() getter from GPUProcessConnection to WebProcess so that
we can query it without having to launch the GPUProcess. This means we can
call legacyCDMFactory().registerFactory() inside of WebProcess::setUseGPUProcessForMedia()
(like before r275887) instead of doing it in the GPUProcessConnection constructor.
As a result, calls to WebKitMediaKeys.isTypeSupported() return accurate results
even if the GPUProcess is not launched yet. Calling WebKitMediaKeys.isTypeSupported() ends
up launching the GPU Process, as is expected.
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::GPUProcessConnection):
(WebKit::GPUProcessConnection::legacyCDMFactory): Deleted.
- WebProcess/GPU/GPUProcessConnection.h:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::setCDM):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setUseGPUProcessForMedia):
(WebKit::WebProcess::legacyCDMFactory):
- WebProcess/WebProcess.h:
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
(TEST):
- 5:53 PM Changeset in webkit [276410] by
-
- 2 edits in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Update test expectations after r276393.
- platform/glib/TestExpectations:
- 5:50 PM Changeset in webkit [276409] by
-
- 2 edits in trunk/Source/WebCore
Crash under RegistrationDatabase::openSQLiteDatabase()
https://bugs.webkit.org/show_bug.cgi?id=224895
<rdar://64574013>
Reviewed by Geoffrey Garen.
This was a thread-safety issue. The static string in recordsTableSchema() was being used
from several threads without synchronization. The reason is that there can be several
RegistrationDatabase that co-exist (one per SWServer, meaning one per sessionID) and each
RegistrationDatabase was using its own WorkQueue.
To address the issue, all RegistrationDatabase objects now share the same WorkQueue.
- workers/service/server/RegistrationDatabase.cpp:
(WebCore::registrationDatabaseWorkQueue):
(WebCore::RegistrationDatabase::RegistrationDatabase):
- 5:13 PM Changeset in webkit [276408] by
-
- 1 copy in tags/Safari-612.1.11.4
Tag Safari-612.1.11.4.
- 4:54 PM Changeset in webkit [276407] by
-
- 8 edits in branches/safari-612.1.11-branch/Source
Versioning.
WebKit-7612.1.11.4
- 4:50 PM Changeset in webkit [276406] by
-
- 2 edits in trunk/Tools
[build.webkit.org] Disable unused parameters in force build dialog box
https://bugs.webkit.org/show_bug.cgi?id=224544
Unreviewed minor infrastructure fix.
- CISupport/build-webkit-org/loadConfig.py:
- 4:39 PM Changeset in webkit [276405] by
-
- 8 edits in branches/safari-611-branch/Source/WebKit
Cherry-pick r275805. rdar://problem/76963040
Crash under WebProcessProxy::shouldSendPendingMessage()
https://bugs.webkit.org/show_bug.cgi?id=224377
<rdar://75329251>
Reviewed by David Kilzer.
We are crashing with a null-dereference of pendingMessage.encoder inside WebProcessProxy::shouldSendPendingMessage().
However, pendingMessage.encoder is a UniqueRef<> and thus cannot be null. Also, we know that the WebProcessProxy
is alive because WebProcessProxy::didFinishLaunching() has a protector.
One thing that I believe could theoretically happen and would not be safe though is AuxiliaryProcessProxy::sendMessage()
being called on a non-main thread. Sending IPC off the main thread is safe in general and something we commonly do with
an IPC::Connection. To make this safe, IPC::Connection uses a Lock to protect its vector of messages. However, sending
IPC via an AuxiliaryProcessProxy is currently not thread safe as it relies on the process state (which gets updated on
the main thread) and access to the m_pendingMessages is not synchronized.
As a speculative fix, I have added logic in AuxiliaryProcessProxy::sendMessage() to dispatch to the main thread if
we're not already on it. I have also used WTF::DestructionThread::MainRunLoop to make sure all AuxiliaryProcessProxy
objects get destroyed on the main thread.
In a follow-up, I am planning to add a release assertion in AuxiliaryProcessProxy::sendMessage() to make sure we're
on a main thread. We'll then be able to drop the "dispatching the main thread" logic. For now though, I think we
should start with the "dispatch to main thread" logic, so that we have a patch that we can cherry-pick to a branch.
- UIProcess/AuxiliaryProcessProxy.cpp: (WebKit::AuxiliaryProcessProxy::sendMessage): (WebKit::AuxiliaryProcessProxy::didFinishLaunching): (WebKit::AuxiliaryProcessProxy::replyToPendingMessages):
- UIProcess/AuxiliaryProcessProxy.h:
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp: (WebKit::WebAuthnProcessProxy::singleton):
- UIProcess/WebProcessProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:39 PM Changeset in webkit [276404] by
-
- 7 edits in branches/safari-611-branch/Source/WebCore
Cherry-pick r276010. rdar://problem/76962988
Integrator's note, used bit 27 instead of 26 to avoid conflict.
REGRESSION(r272900): Nullptr crash in ComposedTreeIterator::traverseNextInShadowTree() via ShadowRoot::hostChildElementDidChange
https://bugs.webkit.org/show_bug.cgi?id=222720
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2021-04-15
Reviewed by Ryosuke Niwa.
This patch reverts r274064 to apply a different fix. Instead of null-checking the nodes returned by
SlotAssignment::assignedNodesForSlot(), assigned nodes are removed from the list when they are about to be
removed from the parent. That ensures we never return nullptr nodes nor nodes with a nullptr parent from the
assigned nodes vector.
- dom/ComposedTreeIterator.cpp: (WebCore::ComposedTreeIterator::traverseNextInShadowTree): (WebCore::ComposedTreeIterator::advanceInSlot):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::removeBetween):
- dom/Node.h: (WebCore::Node::hasShadowRootContainingSlots const): (WebCore::Node::setHasShadowRootContainingSlots):
- dom/ShadowRoot.h:
- dom/SlotAssignment.cpp: (WebCore::SlotAssignment::addSlotElementByName): (WebCore::SlotAssignment::removeSlotElementByName): (WebCore::SlotAssignment::willRemoveAssignedNode):
- dom/SlotAssignment.h: (WebCore::ShadowRoot::willRemoveAssignedNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:39 PM Changeset in webkit [276403] by
-
- 2 edits in branches/safari-611-branch/Source/WebCore
Cherry-pick r276206. rdar://problem/76962916
Perform port blocking earlier in the load
https://bugs.webkit.org/show_bug.cgi?id=224525
<rdar://problem/75440591>
Unreviewed follow-up (suggested by David Kilzer)
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::willSendRequest): Restore an m_frame nullptr check.,
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:39 PM Changeset in webkit [276402] by
-
- 29 edits4 copies2 adds in branches/safari-611-branch
Cherry-pick r276193. rdar://problem/76962916
Perform port blocking earlier in the load
https://bugs.webkit.org/show_bug.cgi?id=224525
<rdar://problem/75440591>
Reviewed by Darin Adler.
Source/WebCore:
WebKit blocks loads to URLs with any of the prohibited ports defined in
the engine. This blocking happens late in the load process, allowing
connections to be made (and observed). Instead, we should stop the load
early, at the same time we perform other checks.
Test: http/tests/security/form-blocked-port.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): Add a check for prohibited ports, and block (with relevant logging) if a load to a denied port is attempted.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::willSendRequest): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest): Ditto. (WebCore::FrameLoader::reportBlockedLoadFailed): Ditto.
- loader/FrameLoader.h:
- loader/PingLoader.cpp: (WebCore::PingLoader::loadImage): Ditto.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::init): Ditto.
- loader/SubframeLoader.cpp: (WebCore::FrameLoader::SubframeLoader::pluginIsLoadable): Ditto. (WebCore::FrameLoader::SubframeLoader::loadSubframe): Ditto.
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): Ditto. (WebCore::CachedResourceLoader::canRequestAfterRedirection const): Ditto.
Tools:
Update URLScheme test to use a non-prohibited port for the test. Tests of
failed fetches are already handled in WPT and other tests, so using a valid
port here should continue to be a valid test.
- TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: (-[FrameSchemeHandler webView:startURLSchemeTask:]): Use allowed port or the test instead of 123.
LayoutTests:
WebKit blocks loads to URLs with any of the prohibited ports defined in
the engine. This blocking happens late in the load process, allowing
connections to be made (and observed). Instead, we should stop the load
early, at the same time we perform other checks.
Note: The fact that we now block loads earlier means that we do not fire
'willSendRequestForFrame' for blocked ports, so WebKitTestRunner no longer
outputs a message to stdout. Those errors are reported in the JS console,
but since some test paths are specified to always output JS console messages
to stderrr (for example the WPT tests), we have to revise out test expectations
for a few cases.
- fast/loader/cancel-load-during-port-block-timer.html: Revised expectation to reflect new console error message.
- http/tests/cache/cancel-during-failure-crash-expected.txt: Ditto.
- http/tests/preload/download_resources_from_invalid_headers-expected.txt: Update to reflect a preflight is not executed for a blocked port.
- http/tests/preload/resources/nph-invalid_resources_from_header.pl: Update to reflect that we do not preload from restricted ports.
- http/tests/security/blocked-on-redirect-expected.txt: Revised expectation to match revised error message.
- http/tests/security/form-blocked-port.html: Added.
- http/tests/security/form-blocked-port-expected.txt: Added.
- http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt: Revised expectation for revised error message.
- http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt: Ditto.
- http/tests/xmlhttprequest/redirect-cross-origin-expected.txt: Ditto.
- http/tests/xmlhttprequest/simple-cross-origin-denied-events.html: Instead of using a port WebKit blocks (7), use one that is not blocked but is unlikely to be active (as originally intended). This retains the expected test behavior since we now block loads to restricted ports earlier in the load process.
- http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html: Ditto.
- http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt: Update test output to reflect that we are attempting to load from port 8 instead of port 7.
- http/wpt/beacon/beacon-async-error-logging-expected.txt: Ditto.
- http/wpt/beacon/beacon-async-error-logging.html: Update to reflect a preflight is not executed for a blocked port.
- imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.any-expected.txt: Since we block before executing the load, TestRunner no longer outputs an error message to stdout. Instead, they appear in stderr (since all 'wpt' tests are marked to dump console.log output to stderr).
- imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.any.worker-expected.txt: Ditto.
- platform/mac-wk1/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt: Revise to reflect change in console logging (the functional test results are identical).
- platform/mac-wk1/http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt: Ditto.
- platform/win/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt: Ditto.
- platform/win/http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt: Ditto.
- platform/wk2/http/tests/security/blocked-on-redirect-expected.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:39 PM Changeset in webkit [276401] by
-
- 9 edits in branches/safari-611-branch
Cherry-pick r275487. rdar://problem/76962948
REGRESSION(r267763) NetworkProcess never terminates
https://bugs.webkit.org/show_bug.cgi?id=224191
<rdar://problem/76124590>
Patch by Alex Christensen <achristensen@webkit.org> on 2021-04-05
Reviewed by Chris Dumez.
Source/WebKit:
Before r267763, when a WebProcessPool was deallocated, the NetworkProcess it owned was terminated.
Since then, once you start using a NetworkProcess, it will be kept until your app closes or it crashes.
To reclaim these resources in a way similar to how we did before, we now terminate the network process in two situations:
- If all WebsiteDataStores associated with it are deallocated. This happens if you have never used the default WKWebsiteDataStore.
- If all WebProcessPools are deallocated. This can still happen if you do use the default WKWebsiteDataStore, which is never deallocated.
Covered by API tests.
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (+[WKWebsiteDataStore _defaultNetworkProcessExists]):
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::defaultNetworkProcessExists): (WebKit::NetworkProcessProxy::removeSession):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::~WebProcessPool):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: (TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:39 PM Changeset in webkit [276400] by
-
- 2 edits in branches/safari-611-branch/Source/WebKit
Cherry-pick r274504. rdar://problem/76962959
The WebContent process crashes when launching Safari
https://bugs.webkit.org/show_bug.cgi?id=223264
<rdar://75482851>
Reviewed by Brent Fulgham.
The WebContent process crashes when launching Safari on older OSes, because of unavailable sandbox features.
- WebProcess/com.apple.WebProcess.sb.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@274504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:39 PM Changeset in webkit [276399] by
-
- 13 edits in branches/safari-611-branch/Source/bmalloc
Cherry-pick r276266. rdar://problem/76962930
[bmalloc] Enable Adaptive Scavenger for Mac
https://bugs.webkit.org/show_bug.cgi?id=224706
Reviewed by Filip Pizlo.
Enabled the adaptive scavenger code paths for macOS.
The original reason that the partial scavenging paths were kept for macOS was due
to regression on power tests. To alleviate the power regression, this patch splits
out the adaptive scavenger parameters with macOS specific values.
The parameters are:
The multiplier used to compute the next scavenging wait time based on the
time needed for the prior scavenging.
Minimum wait time between scavenging.
Maximum wait time between scavenging.
The values in the current code are:
Wait time Multiplier: 150
Minimum wait time: 100ms
Maximum wait time: 10,000ms (10 seconds)
The proposed values for macOS, determined using empirical testing.
Wait time Multiplier: 300
Minimum wait time: 750ms
Maximum wait time: 20,000ms (20 seconds)
When tested on various mac variants, this change:
- Provides a 3-5% reduction in memory use on RAMification.
- It is neutral on JetStream2.
- It is neutral to a slight regression on Speedometer2, but there is some variability in those results.
Since macOS was the only platform still using the partial scavenging code path,
the partial scavenging code paths were deleted.
- bmalloc/BPlatform.h:
- bmalloc/Heap.cpp: (bmalloc::Heap::scavenge): (bmalloc::Heap::allocateSmallChunk): (bmalloc::Heap::allocateSmallPage): (bmalloc::Heap::allocateLarge): (bmalloc::Heap::scavengeToHighWatermark): Deleted.
- bmalloc/Heap.h:
- bmalloc/IsoDirectory.h:
- bmalloc/IsoDirectoryInlines.h: (bmalloc::passedNumPages>::takeFirstEligible): (bmalloc::passedNumPages>::scavenge): (bmalloc::passedNumPages>::scavengeToHighWatermark): Deleted.
- bmalloc/IsoHeapImpl.h:
- bmalloc/IsoHeapImplInlines.h: (bmalloc::IsoHeapImpl<Config>::scavengeToHighWatermark): Deleted.
- bmalloc/LargeMap.cpp: (bmalloc::LargeMap::add):
- bmalloc/LargeRange.h: (bmalloc::LargeRange::LargeRange): (bmalloc::LargeRange::setUsedSinceLastScavenge): (bmalloc::merge): (): Deleted.
- bmalloc/Scavenger.cpp: (bmalloc::Scavenger::Scavenger): (bmalloc::Scavenger::scavenge): (bmalloc::Scavenger::threadRunLoop): (bmalloc::Scavenger::timeSinceLastPartialScavenge): Deleted. (bmalloc::Scavenger::partialScavenge): Deleted.
- bmalloc/Scavenger.h:
- bmalloc/SmallPage.h: (bmalloc::SmallPage::setUsedSinceLastScavenge):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:39 PM Changeset in webkit [276398] by
-
- 3 edits2 adds in branches/safari-611-branch
Cherry-pick r274064. rdar://problem/76962988
REGRESSION(r272900): Nullptr crash in ComposedTreeIterator::traverseNextInShadowTree() via ShadowRoot::hostChildElementDidChange
https://bugs.webkit.org/show_bug.cgi?id=222720
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2021-03-08
Reviewed by Ryosuke Niwa.
Source/WebCore:
The list of assigned nodes contains weak pointers, we should check the node hasn't been destroyed.
Test: fast/html/details-set-inner-text-crash.html
- dom/ComposedTreeIterator.cpp: (WebCore::ComposedTreeIterator::traverseNextInShadowTree):
LayoutTests:
- fast/html/details-set-inner-text-crash-expected.txt: Added.
- fast/html/details-set-inner-text-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@274064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:06 PM Changeset in webkit [276397] by
-
- 7 edits in trunk/Source
Introduce helper methods to map FloatQuads to and from content and root view coordinates
https://bugs.webkit.org/show_bug.cgi?id=224883
Reviewed by Tim Horton.
Source/WebCore:
Add new helper methods to transform FloatQuads from content coordinates to root view coordinates, and vice
versa; use these methods in several places throughout WebKit to avoid code duplication.
No change in behavior.
- inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didPaint):
(WebCore::InspectorTimelineAgent::localToPageQuad): Deleted.
- inspector/agents/InspectorTimelineAgent.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::rootViewToContents const):
(WebCore::ScrollView::contentsToRootView const):
- platform/ScrollView.h:
Source/WebKit:
Use the new helper methods.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::convertContentToRootView):
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
Note that we previously rounded absolute quads to the nearest integer when mapping through root view
coordinates. From <https://bugs.webkit.org/show_bug.cgi?id=128277#c2>, this seemed unintentional to begin with,
and we should be able to use theFloatPointconversion methods instead.
- 4:01 PM Changeset in webkit [276396] by
-
- 4 edits in trunk/LayoutTests
Mass removal of prior test expectations that do not need to be set anymore.
https://bugs.webkit.org/show_bug.cgi?id=224901
Unreviewed test gardening.
- platform/ios-device/TestExpectations:
- platform/ios-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 3:59 PM Changeset in webkit [276395] by
-
- 4 edits in trunk/Source
[iOS] Fix internal builds after r276325
https://bugs.webkit.org/show_bug.cgi?id=224896
Reviewed by Tim Horton.
Source/WebKit:
- UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePickerViewController datePickerInsets]):
(-[WKDateTimePicker _contextMenuInteraction:styleForMenuWithConfiguration:]):
Source/WTF:
- wtf/PlatformHave.h:
- 3:48 PM Changeset in webkit [276394] by
-
- 3 edits2 adds in trunk
Crash in StyledMarkupAccumulator::traverseNodesForSerialization()
https://bugs.webkit.org/show_bug.cgi?id=224836
Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2021-04-21
Reviewed by Ryosuke Niwa.
Source/WebCore:
In traverseNodesForSerialization(), make sure we check if the current node
is a descendant of the pastEnd node even if we not entering the current node.
Test: editing/execCommand/selectAll-copy-crash.html
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):
LayoutTests:
Add a test for the crash fixed here. Thanks to Tuomas Karkkainen for its first version.
- editing/execCommand/selectAll-copy-crash-expected.txt: Added.
- editing/execCommand/selectAll-copy-crash.html: Added.
- 3:07 PM Changeset in webkit [276393] by
-
- 2 edits in trunk/LayoutTests
Mass removing prior test expectations that don't need to be set anymore
https://bugs.webkit.org/show_bug.cgi?id=224898
Unreviewed test gardening.
Missed one test to removed expectations for.
- 3:00 PM Changeset in webkit [276392] by
-
- 2 edits in trunk/Source/WebKit
[iOS][FCR] Update font for group headers in the <select multiple> picker
https://bugs.webkit.org/show_bug.cgi?id=224823
<rdar://problem/76785841>
Reviewed by Wenson Hsieh.
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPickerTableViewController tableView:heightForHeaderInSection:]):
The new font's size can varying depending on the user's Dynamic Type
setting. Consequently, the height of the header must now be computed
dynamically.
(-[WKSelectPickerTableViewController tableView:viewForHeaderInSection:]):
(-[WKSelectPickerTableViewController groupHeaderFont]):
Use a font with text style UIFontTextStyleTitle3 and a semibold weight,
matching other system grouped headers. The font is not saved as an
instance variable so that an up-to-date lineHeight can be obtained in
"tableView:heightForHeightInSection:".
- 2:52 PM Changeset in webkit [276391] by
-
- 4 edits in trunk/LayoutTests
Mass removing prior test expectations that don't need to be set anymore
https://bugs.webkit.org/show_bug.cgi?id=224898
Unreviewed test gardening.
Remove test expectations that no longer needed to be set.
- TestExpectations:
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 2:13 PM Changeset in webkit [276390] by
-
- 6 edits in trunk
[Python 3] Update gni-to-cmake.py
https://bugs.webkit.org/show_bug.cgi?id=224880
Reviewed by Kenneth Russell.
Source/ThirdParty/ANGLE:
Update gni-to-cmake.py to run on Python 3. Added ArgumentParser support to be able to run
the script on Windows since the script assumed it would be called through a UNIX style
shell.
Ran the .gni files through the converter to verify output. It appears that the
Compiler.cmake file wasn't generated in the last update to ANGLE so it has many changes.
- Compiler.cmake:
- D3D.cmake:
- gni-to-cmake.py:
Tools:
Update script to use the
--prependargument.
- Scripts/update-angle:
- 1:53 PM Changeset in webkit [276389] by
-
- 7 edits in trunk
GPUProcess launches unnecessarily when loading the amazon front page
https://bugs.webkit.org/show_bug.cgi?id=224843
Reviewed by Eric Carlson.
Source/WebCore:
Amazon.com was going media-related feature detection like so:
`
!!h.createElement("audio").canPlayType
!!h.createElement("video").canPlayType
`
Constructing an HTMLAudioElement / HTMLVideoElement would initialize a MediaSession
object, which would launch the GPUProcess. Running such code should really not require
launching the GPUProcess though.
To address this, I made the MediaSession initialization lazy. Instead of doing it when
constructing an HTMLMediaElement, we now do it as soon as we actually need a MediaSession
in the mediaSession() getter. This will at the very least happen in prepareForLoad() after
setting the 'src' attribute. However, in cases where the HTMLMediaElement is not used for
anyway meaningful (e.g no 'src' attribute is ever set), then we avoid launching the
GPUProcess.
I have verified on an iPad that visiting the amazon.com front page and searching for
something no longer launches the GPUProcess after this change. This changes also seems to
be a ~3.6% PLUM progression on iPhone and potentially higher on iPad.
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::create):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::initializeMediaSession):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::prepareForDocumentSuspension):
(WebCore::HTMLMediaElement::resumeFromDocumentSuspension):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::didFinishInsertingNode):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::mediaLoadingFailed):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::seekWithTolerance):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack):
(WebCore::HTMLMediaElement::sourceWasAdded):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::addBehaviorRestrictionsOnEndIfNecessary):
(WebCore::HTMLMediaElement::seekToPlaybackPositionEndedTimerFired):
(WebCore::HTMLMediaElement::mediaEngineWasUpdated):
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
(WebCore::HTMLMediaElement::pausedForUserInteraction const):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::checkForAudioAndVideo):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
(WebCore::HTMLMediaElement::stop):
(WebCore::HTMLMediaElement::suspend):
(WebCore::HTMLMediaElement::resume):
(WebCore::HTMLMediaElement::visibilityStateChanged):
(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker):
(WebCore::HTMLMediaElement::wirelessRoutesAvailableDidChange):
(WebCore::HTMLMediaElement::setIsPlayingToWirelessTarget):
(WebCore::HTMLMediaElement::addEventListener):
(WebCore::HTMLMediaElement::removeEventListener):
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent):
(WebCore::HTMLMediaElement::remoteHasAvailabilityCallbacksChanged):
(WebCore::HTMLMediaElement::exitFullscreen):
(WebCore::HTMLMediaElement::shouldForceControlsDisplay const):
(WebCore::HTMLMediaElement::configureMediaControls):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::mediaPlayerIsFullscreenPermitted const):
(WebCore::HTMLMediaElement::removeBehaviorRestrictionsAfterFirstUserGesture):
(WebCore::HTMLMediaElement::updateRateChangeRestrictions):
(WebCore::HTMLMediaElement::maximumSourceBufferSize const):
(WebCore::HTMLMediaElement::updateMediaState):
(WebCore::HTMLMediaElement::mediaState const):
(WebCore::HTMLMediaElement::purgeBufferedDataIfPossible):
(WebCore::HTMLMediaElement::allowsMediaDocumentInlinePlaybackChanged):
(WebCore::HTMLMediaElement::isVisibleInViewportChanged):
(WebCore::HTMLMediaElement::updateShouldAutoplay):
(WebCore::HTMLMediaElement::updateShouldPlay):
(WebCore::HTMLMediaElement::playbackControlsManagerBehaviorRestrictionsTimerFired):
(WebCore::HTMLMediaElement::setInActiveDocument):
(WebCore::HTMLMediaElement::mediaSession const):
- html/HTMLMediaElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::create):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
(TEST):
- 1:11 PM Changeset in webkit [276388] by
-
- 16 edits2 adds in trunk
[iOS] Text selection in image overlays should not be limited to rectilinear quads
https://bugs.webkit.org/show_bug.cgi?id=224837
<rdar://76829981>
Reviewed by Tim Horton.
Source/WebCore:
Refactor the iOS-specific
WebCore::SelectionGeometrysuch that it is backed by aFloatQuadinstead of an
IntRect, and additionally support a flag to indicate that the selection geometry should render as individual
quads, instead of allowing adjacent rects to be coalesced based on each rects' enclosing bounds.
See comments below for more information.
Test: fast/images/image-extraction/ios/selection-rects-in-image-overlay.html
- html/HTMLElement.cpp:
(WebCore::HTMLElement::selectionRenderingBehavior):
- html/HTMLElement.h:
- platform/ios/SelectionGeometry.cpp:
(WebCore::SelectionGeometry::SelectionGeometry):
Change these constructors to take
FloatQuadinstead of an enclosing bounding box of a quad. Refer to call
sites below.
(WebCore::SelectionGeometry::setLogicalLeft):
(WebCore::SelectionGeometry::setLogicalWidth):
(WebCore::SelectionGeometry::setLogicalTop):
(WebCore::SelectionGeometry::setLogicalHeight):
Adjust these four setters so that they automatically inflate the selection quad to the quad's enclosing bounds
before changing any of the dimensions of the rect. Note that in practice, these methods are only used by code
that attempts to coalesce adjacent selection geometries, in which case we shouldn't be rendering non-rectilinear
quads anyways.
(WebCore::SelectionGeometry::rect const):
This method now computes the enclosing bounding rect of the selection quad. Since this can be called many times
for a single selection geometry, we cache the enclosing bounds inm_cachedEnclosingRectto avoid repeated
bounding box computation.
(WebCore::SelectionGeometry::setQuad):
Set the selection quad, and invalidate the enclosing bounding rect.
(WebCore::SelectionGeometry::setRect):
Since we're already setting the quad from an
IntRect, we can go ahead and set the cached enclosing rect at the
same time to avoid computing it again in the future.
(WebCore::operator<<):
- platform/ios/SelectionGeometry.h:
Add a few new members to
SelectionGeometry. Instead of maintaining anIntRect, store aFloatRectin
m_quad. Additionally, add a new enum describing how theSelectionGeometryshould behave. This enum only has
two values:CoalesceBoundingRects, indicating that adjacent selection geometries should be coalesced based on
the enclosing bounding rects of their quads, andUseIndividualQuads, indicating that each quad should be
rendered individually.
(WebCore::SelectionGeometry::quad const):
(WebCore::SelectionGeometry::logicalLeft const):
(WebCore::SelectionGeometry::logicalWidth const):
(WebCore::SelectionGeometry::logicalTop const):
(WebCore::SelectionGeometry::logicalHeight const):
(WebCore::SelectionGeometry::behavior const):
(WebCore::SelectionGeometry::setBehavior):
(WebCore::SelectionGeometry::rect const): Deleted.
(WebCore::SelectionGeometry::setRect): Deleted.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::collectSelectionGeometries):
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::collectSelectionGeometries):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::collectSelectionGeometries):
(WebCore::adjustLineHeightOfSelectionGeometries):
When collecting selection geometry from renderers, avoid coalescing selection geometry when the
SelectionGeometryhasSelectionRenderingBehavior::UseIndividualQuads.
(WebCore::coalesceSelectionGeometries):
(WebCore::RenderObject::collectSelectionGeometriesInternal):
- rendering/RenderText.cpp:
(WebCore::RenderText::collectSelectionGeometries):
Source/WebKit:
See WebCore ChangeLog for more details.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<SelectionGeometry>::encode):
(IPC::ArgumentCoder<SelectionGeometry>::decode):
Encode the
SelectionGeometryby serializing aFloatQuadinstead of an enclosing rect.
- UIProcess/ios/WKContentViewInteraction.mm:
(WebKit::operator==):
(-[WKContentView selectedTextRange]):
(-[WKContentView markedTextRange]):
- UIProcess/ios/WKTextSelectionRect.h:
- UIProcess/ios/WKTextSelectionRect.mm:
(-[WKTextSelectionRectCustomHandleInfo initWithFloatQuad:]):
(-[WKTextSelectionRectCustomHandleInfo bottomLeft]):
(-[WKTextSelectionRectCustomHandleInfo topLeft]):
(-[WKTextSelectionRectCustomHandleInfo bottomRight]):
(-[WKTextSelectionRectCustomHandleInfo topRight]):
(-[WKTextSelectionRect initWithCGRect:]):
(-[WKTextSelectionRect initWithSelectionGeometry:scaleFactor:]):
(-[WKTextSelectionRect _path]):
(-[WKTextSelectionRect _customHandleInfo]):
Implement SPI methods on
UITextSelectionRectto render text selection UI using quads instead of rects.
(-[WKTextSelectionRect initWithSelectionGeometry:]): Deleted.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::convertContentToRootView):
LayoutTests:
Add a new layout test to exercise the new selection rendering behavior.
- fast/images/image-extraction/ios/selection-rects-in-image-overlay-expected.txt: Added.
- fast/images/image-extraction/ios/selection-rects-in-image-overlay.html: Added.
- 1:06 PM Changeset in webkit [276387] by
-
- 2 edits in trunk/Tools
Always pass --no-abbrev-commit to git-log/show
https://bugs.webkit.org/show_bug.cgi?id=224879
Reviewed by Jonathan Bedard.
Currently some of the SCM tests fail with git's log.abbrevCommit; we should
avoid any risk of the tests failing or functionality being broken by always
asking for the unabbreviated commit.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.local_commits):
(Git.exists):
(Git._changes_files_for_commit):
(Git.revisions_changing_file):
(Git._most_recent_log_matching):
(Git._most_recent_log_for_revision):
(Git.git_commit_from_svn_revision):
(Git.contents_at_revision):
(Git.show_head):
(Git.committer_email_for_revision):
- 12:45 PM Changeset in webkit [276386] by
-
- 2 edits in trunk/Source/WebCore
CSSComputedStyleDeclaration.cpp should use C++ style comments
https://bugs.webkit.org/show_bug.cgi?id=224875
Patch by Tyler Wilcock <Tyler Wilcock> on 2021-04-21
Reviewed by Darin Adler.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
Use instead of /* */ for comments, as this is suggested WebKit
coding style.
- 12:44 PM Changeset in webkit [276385] by
-
- 2 edits in trunk/Source/WebCore
[iOS][FCR] Adjust border radius for large buttons and <select>
https://bugs.webkit.org/show_bug.cgi?id=224825
<rdar://problem/76912116>
Reviewed by Wenson Hsieh.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustRoundBorderRadius):
Larger UIKit buttons do not have a pill-shaped appearance. Match their
appearance for buttons and <select> elements that are natively styled
(ones that do not set "-webkit-appearance: none").
- 12:42 PM Changeset in webkit [276384] by
-
- 41 edits in trunk/Source
Non-unified build fixes, mid April 2021 edition
https://bugs.webkit.org/show_bug.cgi?id=222652
<rdar://problem/75262285>
Unreviewed non-unified build fixes.
Source/JavaScriptCore:
- bytecode/JumpTable.cpp: Remove inclusion of wtf/text/StringHash.h
- bytecode/JumpTable.h: Add missing inclusions of wtf/FixedVector.h and
wtf/text/StringHash.h
- bytecode/SpeculatedType.cpp: Add missing includes JSCJSValueInlines.h and
JSCellInlines.h
- bytecompiler/BytecodeGenerator.cpp: Move template method to header, remove now uneeded
LinkTimeConstant.h include.
- bytecompiler/BytecodeGenerator.h: Add include for LinkTimeConstant.h
(JSC::BytecodeGenerator::emitDirectSetPrototypeOf): Template method moved here from
BytecodeGenerator.cpp to avoid compile errors due to usage of missing template body
definition.
- dfg/DFGDesiredGlobalProperties.cpp: Add missing DFGDesiredWatchpoints.h include.
- ftl/FTLAbstractHeap.cpp: Add missing JSCJSValueInlines.h include.
- runtime/JSCustomGetterFunction.cpp: Add missing IdentifierInlines.h include.
- runtime/JSCustomSetterFunction.cpp: Ditto.
- runtime/SetPrototype.cpp: Add missing HashMapImplInlines.h include.
- runtime/VMTraps.cpp: Add missing VMEntryScope.h include.
- runtime/WeakSetConstructor.cpp: Add missing WeakMapImplInlines.h include.
- runtime/WeakSetPrototype.cpp: Add missing includes for HashMapImplInlines.h and
WeakMapImplInlines.h
- wasm/js/JSWebAssemblyTable.cpp: Add missing ObjectConstructor.h include.
Source/WebCore:
No new tests needed.
- bindings/js/JSWebXRRigidTransformCustom.cpp: Add missing JSDOMConvertBufferSource.h
include.
- bindings/js/JSWebXRSpaceCustom.cpp: Add missing JSWebXRReferenceSpace.h include.
- bindings/js/JSWebXRViewCustom.cpp: Add missing JSDOMConvertBufferSource.h include.
- bindings/js/WorkerModuleScriptLoader.cpp: Add missing ServiceWorkerGlobalScope.h
include.
- css/CSSFontFaceSrcValue.cpp: Add missing CachedFontLoadRequest.h include.
- css/parser/CSSPropertyParserWorkerSafe.cpp: Add missing includes for
CSSFontFaceSrcValue.h, CSSFontFeatureValue.h, CSSUnicodeRangeValue.h, Document.h, and
StyleSheetContents.h; remove (now unneeded) CSSPropertyParserHelpers.h include.
(WebCore::CSSPropertyParserWorkerSafe::parseFont): Sprinkle usage of functions with
missing WebCore:: namespace prefixes.
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcLocal): Ditto.
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontStyleRange): Ditto.
- css/parser/CSSPropertyParserWorkerSafe.h: Add missing CSSPropertyParserHelpers.h
include.
- dom/DocumentFontLoader.cpp: Add missing includes CSSFontSelector.h,
CachedResourceLoader.h, Frame.h, and FrameLoader.h
- editing/AppendNodeCommand.cpp: Add missing CompositeEditCommand.h include.
- editing/DeleteFromTextNodeCommand.cpp: Ditto.
- editing/InsertIntoTextNodeCommand.cpp: Ditto.
- editing/InsertNodeBeforeCommand.cpp: Ditto.
- editing/MergeIdenticalElementsCommand.h: Ditto, and remove unneeded EditCommand.h
include.
- editing/RemoveNodeCommand.cpp: Add missing CompositeEditCommand.h include.
- editing/SetNodeAttributeCommand.cpp: Ditto.
- editing/SetSelectionCommand.cpp: Ditto.
- editing/SplitElementCommand.cpp: Ditto.
- editing/SplitTextNodeCommand.cpp: Ditto.
- loader/cache/CachedFontLoadRequest.h: Add missing FontSelectionAlgorithm.h include.
- platform/graphics/FontTaggedSettings.h: Add missing wtf/Hasher.h include.
- platform/text/BidiContext.cpp: Add missing <mutex> and wtf/NeverDestroyed.h includes.
- workers/WorkerGlobalScopeProxy.h: Forward-declare WebCore::ScriptBuffer.
Source/WebKit:
- WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp: Add missing
NetworkProcessConnection.h include.
(WebKit::RTCDataChannelRemoteManager::connectToRemoteSource): Sprinkle missing WebCore::
namespace prefixes.
(WebKit::RTCDataChannelRemoteManager::postTaskToHandler): Ditto.
(WebKit::RTCDataChannelRemoteManager::sourceFromIdentifier): Ditto.
- WebProcess/WebPage/WebURLSchemeTaskProxy.cpp: Add missing WebProcess.h include.
- 12:41 PM Changeset in webkit [276383] by
-
- 2 edits in trunk/Source/WebCore
[iOS][FCR] Update datalist dropdown indicator
https://bugs.webkit.org/show_bug.cgi?id=224844
<rdar://problem/76785950>
Reviewed by Wenson Hsieh.
- css/html.css:
(input::-webkit-list-button):
Updated to use a "small" sized SF symbol.
- 12:08 PM Changeset in webkit [276382] by
-
- 10 edits in trunk
Enable CSS Scroll Snap by default
https://bugs.webkit.org/show_bug.cgi?id=224867
Patch by Martin Robinson <mrobinson@igalia.com> on 2021-04-21
Reviewed by Don Olmstead.
.:
- Source/cmake/OptionsFTW.cmake: Remove redundant line enabling scroll snap.
- Source/cmake/OptionsGTK.cmake: Ditto.
- Source/cmake/OptionsMac.cmake: Ditto.
- Source/cmake/OptionsWPE.cmake: Ditto.
- Source/cmake/OptionsWin.cmake: Explicitly disable scroll snap for AppleWin port
until it can be approved by maintainers.
- Source/cmake/WebKitFeatures.cmake: Enable scroll snap by default.
Source/WTF:
- wtf/PlatformEnable.h: Move the preprocessor enabling of scroll snap here.
- wtf/PlatformEnableCocoa.h: Move it from here.
- 12:07 PM Changeset in webkit [276381] by
-
- 2 edits in trunk/Source/WebKit
Fix build break after r276363
https://bugs.webkit.org/show_bug.cgi?id=224881
Unreviewed, build fix.
Fix build break after r276363
WebGL GPUP crashes when preparing for display due to off-thread WeakPtr access (IOSURFACE_SET_OWNERSHIP_IDENTITY)
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-04-21
- GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
- 12:07 PM Changeset in webkit [276380] by
-
- 17 edits2 adds in trunk
[css-counter-styles] Parse @counter-style descriptors
https://bugs.webkit.org/show_bug.cgi?id=224718
Patch by Tyler Wilcock <Tyler Wilcock> on 2021-04-21
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Parsing for all @counter-style descriptors is implemented with this
patch, so mark more tests passing.
You'll notice that some @counter-style descriptors implemented in this
patch did not gain any passing tests (e.g.pad,negative). In all
of these cases, the expected results contain a <string> value, and we
fail only because we incorrectly don't serialize these <string> values
with quotes. I have manually confirmed in all cases that these values
are properly parsed, so it's just the serialization that's incorrect.
These <string> values serialize without quotes because WebKit's representation
of custom identifiers is not a separate type, but instead overloaded onto the
CSS_STRING type. This means that during serialization time, WebKit must guess
whether it is actually serializing a string (and include quotes if so), or if
it's serializing a custom ident (leaving off quotes if so).
Relevant code snippet:
Relevant changelog snippet from David Hyatt, 2016-12-07:
We also overload CSS_STRING primitive value type and have it act as both a string
and a custom identifier. This is lame, since the parser should have made two different
types of objects instead, but since our parser doesn't do that yet, I added a serializeAsStringOrCustomIdent
that preserves our old behavior of "quote the string only if needed." In this case what
that really meant was "Try to guess that we were originally a custom ident and leave off
quotes if so." This function will go away once we properly create CSSStringValues and
CSSCustomIdentValues instead of turning the latter into strings.
- web-platform-tests/css/css-counter-styles/counter-style-fallback-expected.txt:
- web-platform-tests/css/css-counter-styles/counter-style-prefix-suffix-syntax-expected.txt:
- web-platform-tests/css/css-counter-styles/counter-style-range-syntax-expected.txt:
- web-platform-tests/css/css-counter-styles/counter-style-speak-as-syntax-expected.txt:
- web-platform-tests/css/css-counter-styles/counter-style-system-syntax-expected.txt:
Source/WebCore:
Implement parsing and CSSCounterStyleRule IDL interface for @counter-style descriptors.
See spec for full details on all descriptors:
https://drafts.csswg.org/css-counter-styles-3/#the-counter-style-rule
Test: webexposed/counter-style-image-symbols-not-exposed.html and WPTs
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
Returnnullptrfor new @counter-style descriptor properties.
- css/CSSCounterStyleRule.cpp:
(WebCore::toCounterStyleSystemEnum):
(WebCore::symbolsValidForSystem):
(WebCore::StyleRuleCounterStyle::newValueInvalidOrEqual const):
(WebCore::CSSCounterStyleRule::cssText const):
(WebCore::CSSCounterStyleRule::setName):
(WebCore::CSSCounterStyleRule::setterInternal):
(WebCore::CSSCounterStyleRule::setSystem):
(WebCore::CSSCounterStyleRule::setNegative):
(WebCore::CSSCounterStyleRule::setPrefix):
(WebCore::CSSCounterStyleRule::setSuffix):
(WebCore::CSSCounterStyleRule::setRange):
(WebCore::CSSCounterStyleRule::setPad):
(WebCore::CSSCounterStyleRule::setFallback):
(WebCore::CSSCounterStyleRule::setSymbols):
(WebCore::CSSCounterStyleRule::setAdditiveSymbols):
(WebCore::CSSCounterStyleRule::setSpeakAs):
Implement setters and tangential functionality required by setters.
- css/CSSCounterStyleRule.h:
Replace FIXME with actual descriptor getter and setter
implementations.
- css/CSSProperties.json:
Add @counter-style descriptor properties.
- css/CSSValueKeywords.in:
Add new values required for
systemandspeak-as
@counter-style descriptor properties.
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeCounterStyleSystem):
(WebCore::consumeCounterStyleSymbol):
(WebCore::consumeCounterStyleNegative):
(WebCore::consumeCounterStyleRangeBound):
(WebCore::consumeCounterStyleRange):
(WebCore::consumeCounterStylePad):
(WebCore::consumeCounterStyleSymbols):
(WebCore::consumeCounterStyleAdditiveSymbols):
(WebCore::consumeCounterStyleSpeakAs):
(WebCore::CSSPropertyParser::parseCounterStyleDescriptor):
Parse @counter-style descriptors.
Tools:
- DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):
Fix typo (missing 's'). CSSCounterStyleAtRulesEnabled, not
CSSCounterStyleAtRuleEnabled.
LayoutTests:
Add test ensuring <image> @counter-style symbol values cannot be
parsed when thecounterStyleAtRuleImageSymbolsEnabledfeature flag
is disabled.
---
This test is skipped on Windows because I haven't been able to get the
required feature flags (CSSCounterStyleAtRulesEnabled and
CSSCounterStyleAtRuleImageSymbolsEnabled) to work properly for that
port.
The code hidden behind these flags is all in the CSS parser, which is not
unique to Windows, so I think we can be confident that if the test passes
on all other platforms, that the behavior is correct on Windows too.
One attempt at implementing the necessary Windows-specific flag functionality is here:
https://bugs.webkit.org/attachment.cgi?id=426371&action=edit
Which failed to compile[1] with this error:
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Tools\DumpRenderTree\win\DumpRenderTree.cpp(834,51): error C2039: 'setCSSCounterStyleAtRulesEnabled': is not a member of 'IWebPreferencesPrivate7' [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Tools\DumpRenderTree\win\DumpRenderTree.cpp(835,62): error C2039: 'setCSSCounterStyleAtRuleImageSymbolsEnabled': is not a member of 'IWebPreferencesPrivate7' [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
Those methods are present in
IWebPreferencesPrivate7.idl, and implemented similarly to other
flags in other places (e.g. win/WebPreferences.{h, cpp}, win/WebPreferenceKeysPrivate.h).
I can't reproduce this compilation error on my Windows machine.
I then tried removing the lines that caused the above compilation failure.
Those setters are called in DumpRenderTree::enableExperimentalFeatures, so in
lieu of enabling these flags there I could enable the flag I need via test header.
That patch is: https://bugs.webkit.org/attachment.cgi?id=426509&action=edit
This results in successful compilation, but causes lots (all?) of the
layout tests to fail[2] with a stacktrace that looks like:
00 00000065
738fdf00 00007ffc3e9e3113 WebKit!WebPreferences::speechRecognitionEnabled(int * enabled = 0x00007ffc`3eae0f50)+0x29 [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebKitLegacy\win\WebPreferences.cpp @ 2617]
01 00000065738fdf30 00007ffc3e9e3cc0 DumpRenderTreeLib!resetWebPreferencesToConsistentValues(struct IWebPreferences * preferences = 0x00000205`e2f204b0)+0x63 [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Tools\DumpRenderTree\win\DumpRenderTree.cpp @ 847]
02 00000065738fdfa0 00007ffc3e9e4171 DumpRenderTreeLib!resetWebViewToConsistentStateBeforeTesting(class WTR::TestOptions * options = 0x00000065`738fea60)+0x2e0 [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Tools\DumpRenderTree\win\DumpRenderTree.cpp @ 1054]
03 00000065738fe050 00007ffc3e9e67d3 DumpRenderTreeLib!runTest(class std::basic_string<char,std::char_traits<char>,std::allocator<char> > * inputLine = <Value unavailable error>)+0x2f1 [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Tools\DumpRenderTree\win\DumpRenderTree.cpp @ 1239]
04 00000065738feca0 00007ff789952f30 DumpRenderTreeLib!main(int argc = <Value unavailable error>, char argv = <Value unavailable error>)+0x5d3 [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Tools\DumpRenderTree\win\DumpRenderTree.cpp @ 1676]
05 00000065738ff5b0 00007ff789953884 DumpRenderTree!main(int argc = 0n2, char argv = 0x00000205`e2e74b80)+0x880 [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Tools\win\DLLLauncher\DLLLauncherMain.cpp @ 232]
I haven't done much digging into why this happens, and cannot reproduce it on my Windows machine.
[1]: https://ews-build.webkit.org/#/builders/10/builds/86747
[2]: https://ews-build.webkit.org/#/builders/10/builds/86897
- platform/win/TestExpectations: Skip newly added test on Windows.
- webexposed/counter-style-image-symbols-not-exposed-expected.txt: Added.
- webexposed/counter-style-image-symbols-not-exposed.html: Added.
- 11:47 AM Changeset in webkit [276379] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: context().isInitialized() ./Modules/webaudio/OfflineAudioDestinationNode.cpp(142)
https://bugs.webkit.org/show_bug.cgi?id=224876
<rdar://76896256>
Reviewed by Eric Carlson.
Source/WebCore:
In OfflineAudioDestinationNode::uninitialize(), we were synchronizing with the
render thread to make sure that OfflineAudioDestinationNode::offlineRender() was
done running before proceeding with uninitialization. However, when an audio
worklet is used, m_renderThread is null and no synchronization with the AudioWorklet
thread would happen. This patch adds the missing synchronization with the AudioWorklet
thread when present.
Test: webaudio/OfflineAudioContext/offlineaudiocontext-uninitialized-crash.html
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::uninitialize):
LayoutTests:
Add layout test coverage.
- webaudio/OfflineAudioContext/offlineaudiocontext-uninitialized-crash-expected.txt: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-uninitialized-crash.html: Added.
- 11:34 AM Changeset in webkit [276378] by
-
- 1 copy in tags/Safari-612.1.11.3
Tag Safari-612.1.11.3.
- 11:23 AM Changeset in webkit [276377] by
-
- 5 edits2 adds in trunk
will-change: transform should affect nested position:fixed
https://bugs.webkit.org/show_bug.cgi?id=167600
Reviewed by Alan Bujtas.
"will-change transform" should make an element a container for position:fixed,
just as a transform does.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-position/position-absolute-dynamic-containing-block-expected.txt:
Source/WebCore:
Test: fast/css/will-change/will-change-transform-contains-fixed.html
- rendering/RenderElement.h:
(WebCore::RenderElement::canContainFixedPositionObjects):
LayoutTests:
- fast/css/will-change/will-change-transform-contains-fixed-expected.html: Added.
- fast/css/will-change/will-change-transform-contains-fixed.html: Added.
- 11:15 AM Changeset in webkit [276376] by
-
- 7 edits in trunk
Add discrete animation support for several background CSS properties
https://bugs.webkit.org/show_bug.cgi?id=224871
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Mark 30 WPT progressions.
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
We now support animation of background-attachment, background-clip, background-origin
and background-repeat.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setBackgroundAttachment):
(WebCore::RenderStyle::setBackgroundClip):
(WebCore::RenderStyle::setBackgroundOrigin):
(WebCore::RenderStyle::setBackgroundRepeatX):
(WebCore::RenderStyle::setBackgroundRepeatY):
- 11:06 AM Changeset in webkit [276375] by
-
- 8 edits in branches/safari-612.1.11-branch/Source
Versioning.
WebKit-7612.1.11.3
- 10:58 AM Changeset in webkit [276374] by
-
- 3 edits in trunk/Tools
Handle os.getenv returning None
https://bugs.webkit.org/show_bug.cgi?id=224869
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository.has_authorization_for_realm): This entirely replaces reading
$HOME with a call to os.path.expanduser. Notably, the stdlib function both
handles cases on Unix-like OSes when $HOME is undefined and on Windows (where
$HOME is undefined by default) correctly constructs the path.
- Scripts/webkitpy/common/system/executive.py:
(Executive.kill_all): Handle $USER being undefined by just attempting to kill
all processes regardless of owner.
- 10:57 AM Changeset in webkit [276373] by
-
- 2 edits in trunk/Source/WebCore
Enable mid-layout render tree dump with floating boxes
https://bugs.webkit.org/show_bug.cgi?id=224878
Reviewed by Simon Fraser.
Floating box geometry dump requires the box to be placed first (see assert(isPlaced()) in FloatingObject::frameRect()).
- rendering/FloatingObjects.cpp:
(WebCore::operator<<):
- 10:43 AM Changeset in webkit [276372] by
-
- 8 edits in trunk
DOMException should be Serializable
https://bugs.webkit.org/show_bug.cgi?id=224865
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
DOMException is now serializable, rebaseline related tests.
- web-platform-tests/html/infrastructure/safe-passing-of-structured-data/structured-cloning-error-stack-optional.sub.window-expected.txt:
- web-platform-tests/html/infrastructure/safe-passing-of-structured-data/structuredclone_0-expected.txt:
Source/WebCore:
Implement serialization of DOMException objects.
No new tests, rebaselined existing tests.
- bindings/js/SerializedScriptValue.cpp:
LayoutTests:
- storage/indexeddb/resources/structured-clone.js: Cloning DOMException is valid.
- storage/indexeddb/resources/structured-clone-expected.txt:
- 10:10 AM Changeset in webkit [276371] by
-
- 1 copy in tags/Safari-612.1.11.2
Tag Safari-612.1.11.2.
- 10:08 AM Changeset in webkit [276370] by
-
- 3 edits2 adds in trunk
RenderGeometryMap should know about individual transform properties
https://bugs.webkit.org/show_bug.cgi?id=224856
Patch by Rob Buis <rbuis@igalia.com> on 2021-04-21
Reviewed by Simon Fraser.
Source/WebCore:
RenderGeometryMap should know about individual transform properties.
Test: fast/transforms/textarea-individual-transform-properties-crash.html
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer const):
(WebCore::canMapBetweenRenderersViaLayers):
LayoutTests:
Add test for this.
- fast/transforms/textarea-individual-transform-properties-crash-expected.txt: Added.
- fast/transforms/textarea-individual-transform-properties-crash.html: Added.
- 9:37 AM Changeset in webkit [276369] by
-
- 2 edits in trunk/Source/WebKit
Followup change to bug 224779 based on post-land review comment.
https://bugs.webkit.org/show_bug.cgi?id=224779
<rdar://problem/76738879>
Reviewed by Chris Dumez.
Remove unnecessary document check.
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::preconnectTo):
- 9:36 AM Changeset in webkit [276368] by
-
- 10 edits in trunk
[CMake] Add OpenGLES2 targets
https://bugs.webkit.org/show_bug.cgi?id=224786
Reviewed by Adrian Perez de Castro.
.:
Modernize the FindOpenGLES2.cmake module. Add an OpenGL::GLES target. Also add an
OpenGLES2_API_VERSION value so HAVE_OPENGL_ES_3 can be determined.
For WPE add a find_package for OpenGL ES so the target is present.
For GTK set HAVE_OPENGL_ES_3 if OpenGLES2_API_VERSION supports it.
- Source/cmake/FindOpenGLES2.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
Source/ThirdParty/ANGLE:
Add an ALIAS target mapping ANGLE's GLESv2 target to OpenGL::GLES if the target is not
already present. This is the case for Windows which uses ANGLE as its sole OpenGL ES
implementation.
- CMakeLists.txt:
Source/WebCore:
Use the OpenGL::GLES target.
- CMakeLists.txt:
Source/WebKit:
Use the OpenGL::GLES target.
- CMakeLists.txt:
- 9:20 AM Changeset in webkit [276367] by
-
- 11 edits in trunk/Source
[GPUP] Refactor the implementation of MediaSource::buffered()
https://bugs.webkit.org/show_bug.cgi?id=224848
Reviewed by Eric Carlson.
Source/WebCore:
This patch is a preparation to run
MockMediaPlayerMediaSourcein the GPU Process.
In the current implementation,
MediaSource::m_bufferedis updated by the caller
ofMediaSource::buffered(). As a result, when an object from the GPU process
wants to get the value ofm_buffered, it may need to use a synchronous IPC
message (from the GPU process to a WebContent process), which is bad.
Therefore, there is anASSERT_NOT_REACHED()inRemoteMediaSourceProxy::buffered().
However,MockMediaPlayerMediaSourceneeds to use it for testing purposes.
This patch adds a function
sourceBufferDidChangeBufferedDirty()to
MediaSource, so thatSourceBuffercan notify theMediaSourceobject to
refresh itsm_bufferedand notifyMediaSourcePrivateregarding the new value.
When "Media in GPU process" is enabled,MediaSourcePrivateRemotewill forward
the new value to the GPU process, so that we can avoid the synchronous IPC
message from the GPU process to the WebContent process, and meet the requirement
ofMockMediaPlayerMediaSource.
There is no behavior change when "Media in GPU Process" is disabled.
Covered by existing tests.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::buffered const):
(WebCore::MediaSource::sourceBufferDidChangeBufferedDirty):
(WebCore::MediaSource::regenerateActiveSourceBuffers):
(WebCore::MediaSource::updateBufferedIfNeeded):
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateBufferedDirtyChanged):
- platform/graphics/MediaSourcePrivate.h:
(WebCore::MediaSourcePrivate::bufferedChanged):
Source/WebKit:
Add an IPC message
BufferedChangedto forward the buffered ranges of
MediaSourcefrom a WebContent process to the GPU process.
- GPUProcess/media/RemoteMediaSourceProxy.cpp:
(WebKit::RemoteMediaSourceProxy::buffered const):
(WebKit::RemoteMediaSourceProxy::bufferedChanged):
- GPUProcess/media/RemoteMediaSourceProxy.h:
- GPUProcess/media/RemoteMediaSourceProxy.messages.in:
- WebProcess/GPU/media/MediaSourcePrivateRemote.cpp:
(WebKit::MediaSourcePrivateRemote::bufferedChanged):
- WebProcess/GPU/media/MediaSourcePrivateRemote.h:
- 9:09 AM Changeset in webkit [276366] by
-
- 3 edits2 adds in trunk
[iOS][FCR] <select> decorations should match the text color
https://bugs.webkit.org/show_bug.cgi?id=224831
<rdar://problem/76918959>
Reviewed by Darin Adler.
Source/WebCore:
Currently, <select> decorations always have a system blue color, even
if a different text color is specified. To improve stylability, the
color of the decoration should match the color of the text.
Test: fast/forms/ios/form-control-refresh/select/decoration-color.html
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintMenuListButtonDecorationsWithFormControlRefresh):
Use the color property of the style when painting the decoration.
LayoutTests:
An empty <select> element contains nothing apart from the decoration
(chevron). Added a test to verify that specifying a different text
color changes the color of the decoration.
- fast/forms/ios/form-control-refresh/select/decoration-color-expected-mismatch.html: Added.
- fast/forms/ios/form-control-refresh/select/decoration-color.html: Added.
- 8:46 AM Changeset in webkit [276365] by
-
- 3 edits in trunk/JSTests
[JSC] Unskip some tests for ARMv7 and MIPS
https://bugs.webkit.org/show_bug.cgi?id=224813
Unreviewed test gardening.
- stress/has-own-property-name-cache-symbols-and-strings.js:
- stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js:
- 8:44 AM Changeset in webkit [276364] by
-
- 5 edits in trunk/Source/WebKit
Fix the watchOS build after r276325
https://bugs.webkit.org/show_bug.cgi?id=224868
<rdar://problem/76938541>
Reviewed by Wenson Hsieh.
r276325 broke the watchOS build by using UIBlurEffectStyleSystemMaterial
in WKDateTimeInputControl.mm.
However, while we have been compiling WKDateTimeInputControl for
watchOS, the class is unused. This is due to the fact that watchOS has
a separate date/time picker implementation. Rather than conditionally
compiling the UIBlurEffectStyleSystemMaterial logic (which would
involve writing additional logic to make sure WKDateTimeInputControl
still compiles on watchOS), we can simply stop building
WKDateTimeInputControl on watchOS.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dateTimeInputControl:]):
(-[WKContentView timePickerValueHour:]):
(-[WKContentView timePickerValueMinute:]):
- UIProcess/ios/forms/WKDateTimeInputControl.h:
- UIProcess/ios/forms/WKDateTimeInputControl.mm:
- 8:41 AM Changeset in webkit [276363] by
-
- 2 edits in trunk/Source/WebKit
WebGL GPUP crashes when preparing for display due to off-thread WeakPtr access (IOSURFACE_SET_OWNERSHIP_IDENTITY)
https://bugs.webkit.org/show_bug.cgi?id=224864
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-04-21
Reviewed by Chris Dumez.
Do not navigate WeakPtr in RemoteGraphicsContextGL thread.
Instead, cache the ownership identity tag during constructor
in main thread.
No new tests, caught with existing tests when the define
is enabled.
- GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
(WebKit::RemoteGraphicsContextGLCocoa::RemoteGraphicsContextGLCocoa):
(WebKit::RemoteGraphicsContextGLCocoa::prepareForDisplay):
- 8:25 AM Changeset in webkit [276362] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
WebRTC should be compiled with thread-safe statics
https://bugs.webkit.org/show_bug.cgi?id=224863
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-04-21
Reviewed by Youenn Fablet.
Compile libwebrtc with normal thread-safe c++ local statics.
No known threading failures. Based on ad-hoc risk vs benefit
evaluation of today and after future merges, it appears
better to err in the side of caution.
- Configurations/Base.xcconfig:
- 8:01 AM Changeset in webkit [276361] by
-
- 2 edits in trunk/Source/WebCore
URL::URL(HashTableDeletedValueType) triggers -Wuninitialized warnings with GCC 11
https://bugs.webkit.org/show_bug.cgi?id=224755
Patch by Michael Catanzaro <Michael Catanzaro> on 2021-04-21
Reviewed by Chris Dumez
My first thought here was to just always fully-initialize the URL object when used as a
HashTableDeletedValue, but Alex is concerned it might have a performance impact. Instead,
Chris suggested we could use the SecurityOriginData rather than URL to track whether we are
a HashTableDeletedValue. This seems good because it avoids any size increase in
ServiceWorkerRegistrationKey. Additionally, let's follow Darin's advice to construct the
ServiceWorkerRegistrationKey using placement new rather than via assignment to the
uninitialized storage.
There should be no behavior change. (Although we were copying uninitialized data before, it
was never read. Hopefully.)
- workers/service/ServiceWorkerRegistrationKey.h:
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::constructDeletedValue):
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::isDeletedValue):
- 8:00 AM Changeset in webkit [276360] by
-
- 8 edits in trunk
Enhance scrolling-related trace points
https://bugs.webkit.org/show_bug.cgi?id=224852
Reviewed by Tim Horton.
Source/WebCore:
Add a new trace point when the "display did refresh" ping gets to ThreadedScrollingTree on
the EventDispatcher thread, and add some metadata to the existing displayDidRefresh trace
scope.
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread):
(WebCore::ThreadedScrollingTree::displayDidRefresh):
Source/WebKit:
Add a new trace point in EventDispatcher::displayWasRefreshed() so we can tell when the
WebProcess receives displayDidRefresh IPC (this can sometimes be delayed by other work that
might share the same dispatch thread).
We repurpose the existing DisplayRefreshDispatchingToMainThread which is the WK1 equivalent.
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::displayWasRefreshed):
Source/WTF:
One new trace point, and some argument descriptors.
- wtf/SystemTracing.h:
Tools:
Update trace point descriptions.
- Tracing/SystemTracePoints.plist:
- 7:15 AM Changeset in webkit [276359] by
-
- 2 edits in trunk/Source/WebCore
AudioMediaStreamTrackRendererUnit should not have its data zeroed if one track has not enough data
https://bugs.webkit.org/show_bug.cgi?id=224673
Reviewed by Eric Carlson.
AudioMediaStreamTrackRendererUnit may get data from multiple tracks.
If one track has not enough data, AudioSampleDataSource will zero the buffer while it should leave it unchanged.
If all tracks do not have enough data, AudioMediaStreamTrackRendererUnit will have silent output as the first track will actually zero the buffer.
Manually tested.
- platform/audio/cocoa/AudioSampleDataSource.mm:
(WebCore::AudioSampleDataSource::pullSamplesInternal):
- 6:36 AM Changeset in webkit [276358] by
-
- 4 edits in trunk/Source/WebCore
[LFC] Take "contain: size" into account when computing the preferred logical width
https://bugs.webkit.org/show_bug.cgi?id=224850
Reviewed by Antti Koivisto.
The intrinsic sizes of the size containment box are determined as if the element had no content,
following the same logic as when sizing as if empty.
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraints):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingRoot):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::computedIntrinsicWidthConstraints):
- 6:36 AM Changeset in webkit [276357] by
-
- 6 edits2 adds in trunk
REGRESSION(r256107): Text moves around when selecting at https://www.tokyo-sports.co.jp/entame/news/2834187/
https://bugs.webkit.org/show_bug.cgi?id=224839
<rdar://74958484>
Reviewed by Darin Adler.
Source/WebCore:
Pass in locale information when constructing the text iterator for the content (locale affects soft wrap opportunities).
Test: fast/text/line-break-with-locale.html
- layout/inlineformatting/InlineTextItem.cpp:
(WebCore::Layout::InlineTextItem::createAndAppendTextItems):
- layout/inlineformatting/text/TextUtil.cpp: In addition to locale, add missing line breaking mode.
(WebCore::Layout::TextUtil::lineBreakIteratorMode):
- layout/inlineformatting/text/TextUtil.h:
LayoutTests:
- fast/text/line-break-with-locale-expected.html: Added.
- fast/text/line-break-with-locale.html: Added.
- 6:34 AM Changeset in webkit [276356] by
-
- 6 edits in trunk
[css-grid] last-baseline shouldn't affect baseline alignment
https://bugs.webkit.org/show_bug.cgi?id=224538
Patch by Ziran Sun <Ziran Sun> on 2021-04-21
Reviewed by Darin Adler and Javier Fernandez.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-grid/alignment/grid-baseline-004-expected.txt:
Source/WebCore:
According to discussions at https://github.com/w3c/csswg-drafts/issues/5293,
"align-self: last baseline" should not interfere with baseline alignment in
first row. This change is to make sure this is checked while deciding
whether an item participates in baseline alignment.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::isBaselineAlignmentForChild const):
- 2:57 AM Changeset in webkit [276355] by
-
- 5 edits in trunk/Tools
[WPE] Allow defining custom repo and branch for Cog checkout
https://bugs.webkit.org/show_bug.cgi?id=224739
Reviewed by Philippe Normand.
Use cmake args "-DWPE_COG_REPO=<repo>" and "-DWPE_COG_TAG=<tag>" to
build different cog versions without having to edit the cmake files.
There might be the need to wipe the checked-out dir from time to time,
as only CMake 3.18 introduced different checkout strategies. Previous
cmakes try to rebase the previously checked out branch which might
lead to conflicts.
This commit also allows selecting between Cog and MiniBrowser with the
WPE_BROWSER envvar.
- PlatformWPE.cmake:
- Scripts/webkitpy/port/wpe.py:
(WPEPort.cog_path):
(WPEPort):
(WPEPort.browser_name):
(WPEPort.run_minibrowser):
- Scripts/webkitpy/port/wpe_unittest.py:
(WPEPortTest.test_default_upload_configuration):
(WPEPortTest):
(WPEPortTest.test_browser_name_default):
(WPEPortTest.test_browser_name_with_cog_built):
(WPEPortTest.test_browser_name_override_minibrowser_with_cog_built):
(WPEPortTest.test_browser_name_override_cog_without_cog_built):
(WPEPortTest.test_browser_name_override_unknown):
- Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py:
(WebDriverWPE.browser_name): Make it cog-aware.
(WebDriverWPE.browser_path): Ditto.
- 2:38 AM Changeset in webkit [276354] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, WPE Cog build fix after r276316
- wpe/wpe-webkit-uninstalled.pc.in: Adjust paths once again.
- 2:04 AM Changeset in webkit [276353] by
-
- 8 edits2 adds in trunk
Add basic (non-momentum) wheel event handling for scroll snap
https://bugs.webkit.org/show_bug.cgi?id=222594
Reviewed by Darin Adler.
Source/WebCore:
Test: css3/scroll-snap/scroll-snap-wheel-event.html
Enable scroll snapping for basic wheel events on GTK+ and WPE. The Mac port
has special wheel handling due to momentum scrolling. Other scroll-snap-enabled
ports can just use a basic version.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll): Accept a bitmask of options now. This
will allow using this method when handling wheel events that do not animate.
(WebCore::ScrollAnimator::handleWheelEvent): Trigger ::scroll with
scroll snapping enabled and pass the appropriate option to disable animations.
(WebCore::ScrollAnimator::processWheelEventForScrollSnap): Deleted.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::ScrollAnimator::processWheelEventForScrollSnap): Made
this a method that can be overridden by subclasses.
- platform/mac/ScrollAnimatorMac.h: Added processWheelEventForScrollSnap.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scroll): Pay attention to the NeverAnimate bitmask now.
(WebCore::ScrollAnimatorMac::processWheelEventForScrollSnap): Added.
LayoutTests:
- css3/scroll-snap/scroll-snap-wheel-event-expected.txt: Added.
- css3/scroll-snap/scroll-snap-wheel-event.html: Added.
- platform/ios-wk2/TestExpectations: Skip new test because it uses mouse event simulation.
Move existing classification to better section as well.
- platform/mac-wk1/fast/scrolling/latching/scroll-snap-latching-expected.txt: Rebased this previous failing test.
- 1:44 AM Changeset in webkit [276352] by
-
- 2 edits in trunk/Source/WebCore
Use BlobURL::getOriginURL in more places
https://bugs.webkit.org/show_bug.cgi?id=224857
Reviewed by Alex Christensen.
Covered by existing tests.
- loader/PolicyChecker.cpp:
(WebCore::FrameLoader::PolicyChecker::extendBlobURLLifetimeIfNecessary const):
- 1:13 AM WebKitGTK/2.32.x edited by
- (diff)
- 12:38 AM Changeset in webkit [276351] by
-
- 13 edits in trunk
Long-pressing a data detectors link causes the link to be followed
https://bugs.webkit.org/show_bug.cgi?id=224847
<rdar://problem/72889738>
Reviewed by Wenson Hsieh.
Source/WebCore:
New API tests: iOSMouseSupport.{EndedTouchesTriggerClick,CancelledTouchesDoNotTriggerClick}
- page/EventHandler.h:
Source/WebKit:
On iOS, it is possible for a gesture to be externally cancelled (in this case,
when a data detectors context menu is presented by long pressing a link).
This is reported to WKMouseGestureRecognizer as "touches cancelled".
Currently, WKMouseGestureRecognizer just runs with that as a normal
"mouse button release" event, which then causes the link that you're long
pressing to also be followed.
- Shared/NativeWebMouseEvent.h:
- Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::encode const):
(WebKit::WebMouseEvent::decode):
- Shared/WebMouseEvent.h:
(WebKit::WebMouseEvent::gestureCancelled const):
- Shared/ios/NativeWebMouseEventIOS.mm:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
- UIProcess/ios/WKMouseGestureRecognizer.mm:
(-[WKMouseGestureRecognizer createMouseEventWithType:wasCancelled:]):
(-[WKMouseGestureRecognizer touchesBegan:withEvent:]):
(-[WKMouseGestureRecognizer touchesMoved:withEvent:]):
(-[WKMouseGestureRecognizer touchesEnded:withEvent:]):
(-[WKMouseGestureRecognizer touchesCancelled:withEvent:]):
(-[WKMouseGestureRecognizer _hoverEntered:withEvent:]):
(-[WKMouseGestureRecognizer _hoverMoved:withEvent:]):
(-[WKMouseGestureRecognizer _hoverExited:withEvent:]):
(-[WKMouseGestureRecognizer createMouseEventWithType:]): Deleted.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::handleMouseEvent):
Add a bit to WebKit::WebMouseEvent indicating that the gesture it is a part of
was cancelled. This will only be set on the mouse release event dispatched from
touchesCancelled from WKMouseGestureRecognizer, and will cause WebCore to
avoid dispatching the click event, as you would on macOS if you e.g.
moved the mouse too far from its origin during the press.
Plumb the bit all the way from WKMouseGestureRecognizer, through the
NativeWebMouseEvent constructor, to WebMouseEvent, and then check it
and call invalidateClick() immediately before handing WebCore the
mouse release event, to avoid the click event.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:
(TEST):
Add tests ensuring that we get a click event for completed touches, and not for cancelled touches.
- 12:33 AM Changeset in webkit [276350] by
-
- 2 edits2 adds in trunk/LayoutTests/imported/w3c
[selectors] Import one more :focus-visible WPT test
https://bugs.webkit.org/show_bug.cgi?id=224827
Reviewed by Rob Buis.
- web-platform-tests/css/selectors/focus-visible-020-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-020.html: Added.
- web-platform-tests/css/selectors/w3c-import.log:
- 12:33 AM Changeset in webkit [276349] by
-
- 7 edits in trunk/Source
[ BigSur wk2 ARM64 ] http/wpt/webrtc/change-encoded-transform.html is a flakey crash
https://bugs.webkit.org/show_bug.cgi?id=224696
<rdar://problem/76780020>
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
On stream recreation, the new delegate may have to process a transformed frame before receiving one from the encoder.
Check for encoder_queue to not be null in that case.
- Source/webrtc/modules/rtp_rtcp/source/rtp_sender_video_frame_transformer_delegate.cc:
Source/WebCore:
Sometimes the video sender delegate will be recreated on the fly.
In that case, it might receive a frame from the old delegate before processing an existing frame.
This makes the encoder queue being null.
To prevent this we update backends to only register once.
Covered by tests no longer crashing.
- Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.cpp:
(WebCore::LibWebRTCRtpReceiverTransformBackend::setTransformableFrameCallback):
- Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.h:
- Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.cpp:
(WebCore::LibWebRTCRtpSenderTransformBackend::setTransformableFrameCallback):
- Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.h:
- 12:21 AM Changeset in webkit [276348] by
-
- 6 edits in trunk/Source
[macOS] Avoid triggering image extraction for animated images
https://bugs.webkit.org/show_bug.cgi?id=224851
Reviewed by Megan Gardner.
Source/WebCore:
Avoid adding the "Reveal Image" context menu item for animated images. Testing is currently blocked on
webkit.org/b/224641.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
Source/WebKit:
Avoid making image extraction requests for animated images by adding an optional
AllowsAnimatedImages
argument tocreateShareableBitmap, and passing inAllowsAnimatedImages::Noin the case where we're creating
a shareable bitmap for image extraction.
- WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
(WebKit::createShareableBitmap):
- WebProcess/WebCoreSupport/ShareableBitmapUtilities.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::requestImageExtraction):
- 12:18 AM Changeset in webkit [276347] by
-
- 16 edits in trunk
Support scrolling to a selected AppHighlight
https://bugs.webkit.org/show_bug.cgi?id=224773
Reviewed by Tim Horton.
Source/WebCore:
Test: AppHighlights::AppHighlightCreateAndRestoreAndScroll
- Modules/highlight/AppHighlightStorage.cpp:
(WebCore::AppHighlightStorage::restoreAndScrollToAppHighlight):
(WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll):
(WebCore::AppHighlightStorage::restoreUnrestoredAppHighlights):
(WebCore::AppHighlightStorage::restoreAppHighlight): Deleted.
- Modules/highlight/AppHighlightStorage.h:
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp:
(WebCore::TemporarySelectionChange::setSelection):
- page/Page.cpp:
(WebCore::Page::doAfterUpdateRendering):
Source/WebKit:
- UIProcess/API/Cocoa/WKWebView.mm:
(restoreHighlight):
(-[WKWebView _restoreAppHighlights:]):
(-[WKWebView _restoreAndScrollToAppHighlight:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::restoreAppHighlightsAndScrollToIndex):
(WebKit::WebPageProxy::restoreAppHighlights): Deleted.
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreAppHighlightsAndScrollToIndex):
(WebKit::WebPage::restoreAppHighlights): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm:
(TestWebKitAPI::TEST):
