Timeline
Apr 24, 2022:
- 11:54 PM Changeset in webkit [293316] by
-
- 4 edits in trunk
[RISCV64] Enable Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=239708
Reviewed by Yusuke Suzuki.
.:
Turn on the CMake defaults for ENABLE(JIT) and ENABLE(FTL_JIT) options
for RISCV64. These are enabled together to avoid having to worry about
a 64-bit platform that would want to allow compiling with Baseline JIT
enabled and FTL JIT disabled at the same time. But because FTL JIT
support for RISCV64 isn't complete yet, it's still disabled at runtime.
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- runtime/Options.cpp:
(JSC::Options::recomputeDependentOptions):
Disable FTL JIT at runtime under CPU(RISCV64) since the support is still
incomplete. This is necessary due to Baseline JIT and FTL JIT still
being enabled at build-time on this platform for pure convenience.
- 11:41 PM Changeset in webkit [293315] by
-
- 2 edits in trunk/Source/JavaScriptCore
[GCC] Unreviewed, build fix for Ubuntu LTS/Debian after r293265
- wasm/WasmTypeDefinition.h:
(JSC::Wasm::FunctionSignature::operator!= const):
- 11:36 PM Changeset in webkit [293314] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Wasm] Remove confusing isFuncref and isExternref
https://bugs.webkit.org/show_bug.cgi?id=239699
Reviewed by Yusuke Suzuki.
There are two functions with the same name Wasm::Type::isFuncref and
Wasm::isFuncref but with different behaviour, and so,
this brings confusion into the codebase.
The first function checks that .kind == funcref and the second one checks
for the same but with respect to typed function references proposal.
The second one should be used when we want to check that type is funcref,
so the first one is not needed and actually not used, so this patch removes it.
The same situation is for isExternref.
- wasm/generateWasmOpsHeader.py:
(typeMacroizer):
(typeMacroizerFiltered):
- 11:29 PM Changeset in webkit [293313] by
-
- 2 edits in trunk/Source/JavaScriptCore
[RISCV64] Implement MacroAssemblerRISCV64 fencing methods
https://bugs.webkit.org/show_bug.cgi?id=239706
Reviewed by Yusuke Suzuki.
Provide MacroAssemblerRISCV64 implementations for the tree fencing
methods, using thefenceinstruction but with different corresponding
combinations of the predecessor and successor operation sets.
- assembler/MacroAssemblerRISCV64.h:
(JSC::MacroAssemblerRISCV64::memoryFence):
(JSC::MacroAssemblerRISCV64::storeFence):
(JSC::MacroAssemblerRISCV64::loadFence):
- 11:26 PM Changeset in webkit [293312] by
-
- 5 edits in trunk/JSTests
Skip microbenchmarks/memcpy-wasm.js and friends on non-FTL (i.e. non-WASM) platforms
https://bugs.webkit.org/show_bug.cgi?id=239705
Reviewed by Yusuke Suzuki.
Mark microbenchmarks/memcpy-wasm.js and related tests as skipped on
non-FTL platforms since WASM tests are not run there, resulting in
failures when they're executed.
- microbenchmarks/memcpy-wasm-large.js:
- microbenchmarks/memcpy-wasm-medium.js:
- microbenchmarks/memcpy-wasm-small.js:
- microbenchmarks/memcpy-wasm.js:
- 11:02 PM Changeset in webkit [293311] by
-
- 13 edits1 add in trunk
TextTrackLoader should use SameOrigin mode by default
https://bugs.webkit.org/show_bug.cgi?id=239381
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/cloneNode-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-data-url-expected.txt:
- web-platform-tests/service-workers/service-worker/webvtt-cross-origin.https-expected.txt:
Source/WebCore:
Covered by updated test.
- loader/TextTrackLoader.cpp:
LayoutTests:
- http/tests/security/contentSecurityPolicy/resources/track.vtt.py: Added.
- http/tests/security/contentSecurityPolicy/track-redirect-allowed.html:
- http/tests/security/contentSecurityPolicy/track-redirect-allowed2.html:
- http/tests/security/contentSecurityPolicy/track-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/track-redirect-blocked.html:
- http/tests/security/text-track-crossorigin-expected.txt:
- http/tests/security/text-track-crossorigin.html:
- 10:56 PM Changeset in webkit [293310] by
-
- 4 edits in trunk/Source/WebKit
Make NetworkResourceLoader.m_parameters non const
https://bugs.webkit.org/show_bug.cgi?id=239603
Reviewed by Anders Carlsson.
Now that NetworkResourceLoader can be transitioned through WebProcesses,
several NetworkResourceLoaderParameters might need to be changed over time.
For that reason, it no longer makes sense to have m_parameters const.
Covered by existing tests.
- NetworkProcess/NetworkLoadParameters.h:
- NetworkProcess/NetworkResourceLoadParameters.h:
- NetworkProcess/NetworkResourceLoader.h:
- 9:45 PM Changeset in webkit [293309] by
-
- 43 edits in trunk/Source
Use equalLettersIgnoringASCIICase() and SortedArrayMap in more places
https://bugs.webkit.org/show_bug.cgi?id=239714
Reviewed by Darin Adler.
Use equalLettersIgnoringASCIICase() and SortedArrayMap in more places, for performance.
- Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::preconnectTo):
- Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse):
- Source/WTF/wtf/unix/LanguageUnix.cpp:
(WTF::platformLanguage):
- Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::validatedPaymentNetwork const):
- Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::FetchBodyConsumer::packageFormData):
- Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
- Source/WebCore/css/parser/CSSAtRuleID.cpp:
(WebCore::cssAtRuleID):
- Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::consumeStringOrURI):
(WebCore::CSSParserImpl::consumeImportRule):
(WebCore::CSSParserImpl::consumeDeclaration):
(WebCore::CSSParserImpl::consumeKeyframeKeyList):
- Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeAnimationName):
- Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumePseudo):
(WebCore::CSSSelectorParser::consumeAttributeFlags):
(WebCore::consumeANPlusB):
- Source/WebCore/css/parser/CSSSupportsParser.cpp:
(WebCore::CSSSupportsParser::consumeCondition):
- Source/WebCore/css/parser/CSSTokenizer.cpp:
(WebCore::CSSTokenizer::consumeIdentLikeToken):
- Source/WebCore/css/parser/MediaQueryParser.cpp:
(WebCore::MediaQueryParser::readMediaNot):
(WebCore::isRestrictorOrLogicalOperator):
(WebCore::MediaQueryParser::readMediaType):
(WebCore::MediaQueryParser::readAnd):
- Source/WebCore/css/parser/SizesCalcParser.cpp:
(WebCore::SizesCalcParser::calcToReversePolishNotation):
- Source/WebCore/css/typedom/transform/CSSPerspective.cpp:
(WebCore::checkLength):
- Source/WebCore/editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::requiresExtendedContext):
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::DataDetection::isDataDetectorElement):
- Source/WebCore/html/Autofill.cpp:
(WebCore::AutofillData::createFromHTMLFormControlElement):
- Source/WebCore/html/EnterKeyHint.cpp:
(WebCore::enterKeyHintForAttributeValue):
- Source/WebCore/html/EnterKeyHint.h:
- Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::relList):
- Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::parseFormRelAttributes):
(WebCore::HTMLFormElement::relList):
- Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::parseCrossoriginState):
- Source/WebCore/html/InputType.cpp:
(WebCore::InputType::applyStep):
- Source/WebCore/html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::isSupported):
- Source/WebCore/html/parser/HTMLParserIdioms.cpp:
(WebCore::parseCORSSettingsAttribute):
- Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::loadApplicationManifest):
- Source/WebCore/loader/LinkLoader.cpp:
(WebCore::LinkLoader::preconnectIfNeeded):
- Source/WebCore/loader/ServerTiming.cpp:
(WebCore::ServerTiming::setParameter):
- Source/WebCore/page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::screenshot):
- Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::isGoogleMaps const):
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
(WebCore::Quirks::needsDeferKeyDownAndKeyPressTimersUntilNextEditingCommand const):
- Source/WebCore/page/SecurityOriginData.cpp:
(WebCore::SecurityOriginData::databaseIdentifier const):
- Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::schemeIsInHttpFamily):
(WebCore::ContentSecurityPolicySourceList::isValidSourceForExtensionMode):
- Source/WebCore/platform/graphics/FontGenericFamilies.cpp:
(WebCore::computeUserPrefersSimplified):
- Source/WebCore/platform/graphics/MIMETypeCache.cpp:
(WebCore::MIMETypeCache::shouldOverrideExtendedType):
- Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsType):
- Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::willUseWebMFormatReaderForType):
(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
- Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::isContentTypeSupported):
- Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::platformInit):
- Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:
(webKitDMABufVideoSinkIsEnabled):
- Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::isThunderRanked):
- Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::createDecodingConfiguration):
(WebCore::LibWebRTCProvider::createEncodingConfiguration):
- Source/WebCore/platform/network/curl/CookieUtil.cpp:
(WebCore::CookieUtil::parseCookieAttributes):
- Source/WebCore/platform/network/curl/CurlMultipartHandle.cpp:
(WebCore::CurlMultipartHandle::extractBoundary):
- Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::iconForAttachment):
- Source/WebCore/svg/SVGAElement.cpp:
(WebCore::SVGAElement::relList):
- Source/WebCore/testing/MockCDMFactory.cpp:
(WebCore::MockCDMFactory::supportsKeySystem):
(WebCore::MockCDMInstance::setServerCertificate):
Canonical link: https://commits.webkit.org/249932@main
- 8:54 PM Changeset in webkit [293308] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, non-unified build fixes after r293285
- html/track/TextTrack.cpp:
- 2:16 PM Changeset in webkit [293307] by
-
- 2 edits in trunk/Source/WebKit
Use utf-8 for text mode files in generate-automation-atom.py
https://bugs.webkit.org/show_bug.cgi?id=239542
Patch by Daniel Kolesa <Daniel Kolesa> on 2022-04-24
Reviewed by Adrian Perez de Castro.
At least with older versions of python (3.6), this will otherwise
be ascii, which will break input files that contain non-ascii
characters, e.g. Source/WebKit/UIProcess/Automation/atoms/FindNodes.js
- Scripts/generate-automation-atom.py:
(main):
- 1:28 PM Changeset in webkit [293306] by
-
- 2 edits in trunk/Source/WebCore
[Win][WinCairo] Unreviewed build fix
https://bugs.webkit.org/show_bug.cgi?id=239692
<rdar://problem/92222456>
- Headers.cmake: Added necessary headers of WebCore/layout.
- 11:00 AM Changeset in webkit [293305] by
-
- 1 copy in tags/WebKit-7613.2.7.1.1
Tag WebKit-7613.2.7.1.1.
- 10:58 AM Changeset in webkit [293304] by
-
- 1 copy in tags/WebKit-7613.2.7.0.1
Tag WebKit-7613.2.7.0.1.
- 8:21 AM Changeset in webkit [293303] by
-
- 7 edits in trunk/Source/WebCore
Fix a typo (r293297)
https://bugs.webkit.org/show_bug.cgi?id=239704
Unreviewed.
- layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntergration): Deleted.
- layout/formattingContexts/flex/FlexFormattingContext.h:
- layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntergration): Deleted.
- layout/formattingContexts/inline/InlineFormattingContext.h:
- layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::layout):
- layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):
Apr 23, 2022:
- 10:49 PM Changeset in webkit [293302] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r293301.
- bindings/js/JSDOMConvertStrings.h:
(WebCore::Converter<IDLAtomStringAdaptor<IDLByteString>>::convert):
- 9:48 PM Changeset in webkit [293301] by
-
- 12 edits in trunk/Source
[IDL] Add support for [AtomString] with USVString & ByteString types
https://bugs.webkit.org/show_bug.cgi?id=239695
Reviewed by Cameron McCormack.
Add support for [AtomString] with USVString and ByteString types in our WebIDL
bindings. This is needed to mark the AtomString(const String&) constructor
explicit.
- Source/WTF/wtf/text/AtomString.cpp:
(WTF::replaceUnpairedSurrogatesWithReplacementCharacterInternal):
(WTF::replaceUnpairedSurrogatesWithReplacementCharacter):
- Source/WTF/wtf/text/AtomString.h:
- Source/WTF/wtf/text/WTFString.cpp:
(WTF::replaceUnpairedSurrogatesWithReplacementCharacter): Deleted.
- Source/WTF/wtf/text/WTFString.h:
- Source/WebCore/Modules/fetch/FetchResponse.h:
- Source/WebCore/Modules/fetch/FetchResponse.idl:
- Source/WebCore/bindings/js/JSDOMConvertStrings.cpp:
(WebCore::throwIfInvalidByteString):
(WebCore::identifierToByteString):
(WebCore::valueToByteString):
(WebCore::valueToByteAtomString):
(WebCore::valueToUSVAtomString):
(WebCore::stringToByteString): Deleted.
- Source/WebCore/bindings/js/JSDOMConvertStrings.h:
(WebCore::Converter<IDLAtomStringAdaptor<T>>::convert):
(WebCore::Converter<IDLAtomStringAdaptor<IDLUSVString>>::convert):
(WebCore::Converter<IDLAtomStringAdaptor<IDLByteString>>::convert):
(WebCore::JSConverter<IDLAtomStringAdaptor<T>>::convert):
(WebCore::JSConverter<IDLAtomStringAdaptor<IDLUSVString>>::convert):
(WebCore::JSConverter<IDLAtomStringAdaptor<IDLByteString>>::convert):
- Source/WebCore/html/HTMLAnchorElement.idl:
- Source/WebCore/html/HTMLAreaElement.idl:
- Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::httpStatusText const):
(WebCore::ResourceResponseBase::setHTTPStatusText):
- Source/WebCore/platform/network/ResourceResponseBase.h:
Canonical link: https://commits.webkit.org/249926@main
- 8:54 PM Changeset in webkit [293300] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed build fix.
- Headers.cmake:
- 8:45 PM Changeset in webkit [293299] by
-
- 28 edits1 delete in trunk/Source
Remove the
PreferInlineTextSelectionInImagesinternal feature flag
https://bugs.webkit.org/show_bug.cgi?id=234849
Reviewed by Sam Weinig.
Source/WebCore:
See WebKit/ChangeLog for more details.
- en.lproj/Localizable.strings:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
- page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):
- platform/ContextMenuItem.cpp:
(WebCore::isValidContextMenuAction):
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.h:
- platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::contextMenuItemTagQuickLookImage): Deleted.
(WebCore::contextMenuItemTagQuickLookImageForTextSelection): Deleted.
(WebCore::contextMenuItemTagQuickLookImageForVisualSearch): Deleted.
Source/WebKit:
This patch reverts r279164, which introduced an internal feature to avoid Live Text analysis when hovering over
images, and instead added a new context menu item to reveal selectable text in the image by launching the
QuickLook panel in Live Text mode.
This alternate Live Text experience was originally devised as a way to mitigate the power and performance impact
of passively triggering Live Text analysis when hovering over images on pre-M1 devices, but this mitigation was
ultimately deemed unnecessary in macOS 12.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- UIProcess/Cocoa/QuickLookPreviewActivity.h: Removed.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::computeHasVisualSearchResults):
(WebKit::WebViewImpl::computeHasImageAnalysisResults): Deleted.
- UIProcess/PageClient.h:
(WebKit::PageClient::computeHasVisualSearchResults):
(WebKit::PageClient::computeHasImageAnalysisResults): Deleted.
- UIProcess/WebContextMenuProxy.h:
(WebKit::WebContextMenuProxy::quickLookPreviewActivity const): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::computeHasVisualSearchResults):
(WebKit::WebPageProxy::computeHasImageAnalysisResults): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::computeHasVisualSearchResults):
(WebKit::PageClientImpl::computeHasImageAnalysisResults): Deleted.
- UIProcess/mac/WKQuickLookPreviewController.h:
- UIProcess/mac/WKQuickLookPreviewController.mm:
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):
(WebKit::WebContextMenuProxyMac::insertOrUpdateQuickLookImageItem): Deleted.
(WebKit::WebContextMenuProxyMac::updateQuickLookContextMenuItemTitle): Deleted.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::handleContextMenuLookUpImage):
(WebKit::WebPageProxy::handleContextMenuQuickLookImage): Deleted.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKitLegacy/mac:
See WebKit/ChangeLog for more details.
- WebView/WebHTMLView.mm:
(toTag):
Source/WTF:
See WebKit/ChangeLog for more details.
- Scripts/Preferences/WebPreferencesInternal.yaml:
- 7:27 PM Changeset in webkit [293298] by
-
- 11 edits in trunk/Source/WebCore
Code cleanup in preparation for optimizing use of AccessibilityObject::elementsFromAttribute.
https://bugs.webkit.org/show_bug.cgi?id=239664
<rdar://problem/92180286>
Reviewed by Chris Fleizach.
No new functionality.
AccessibilityObject::elementsFromAttribute now returns a vector as
opposed to taking an out parameter. This makes the code more concise
and possibly more efficient.
Removed this method from the AXCoreObject interface, since this method
should not be exposed to an AT client. The Inspector is an exception
that accesses AccessibilityObjects directly and not through the
AXCoreObject interface.
All these changes are entirely code cleanup and modernization, no change
in functionality.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::ariaLabeledByText const):
(WebCore::AccessibilityNodeObject::textUnderElement const):
(WebCore::AccessibilityNodeObject::descriptionForElements const):
(WebCore::AccessibilityNodeObject::ariaDescribedByAttribute const):
(WebCore::AccessibilityNodeObject::ariaLabeledByAttribute const):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements const): Renamed.
(WebCore::AccessibilityNodeObject::ariaLabeledByElements const): Deleted.
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaElementsFromAttribute const):
(WebCore::AccessibilityObject::elementsFromAttribute const):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isTabItemSelected const):
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::elementsFromAttribute const): Deleted.
- accessibility/isolatedtree/AXIsolatedObject.h:
- inspector/InspectorAuditAccessibilityObject.cpp:
(WebCore::accessiblityObjectForNode):
(WebCore::InspectorAuditAccessibilityObject::getControlledNodes):
(WebCore::InspectorAuditAccessibilityObject::getFlowedNodes):
(WebCore::InspectorAuditAccessibilityObject::getMouseEventNode):
(WebCore::InspectorAuditAccessibilityObject::getOwnedNodes):
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
- 4:03 PM Changeset in webkit [293297] by
-
- 8 edits in trunk/Source/WebCore
[FFC][Integration] Add integration API to FlexFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=239692
Reviewed by Antti Koivisto.
The integration codepath needs dedicated (and temporary)APIs on the formatting contexts.
(This is exactly how inline layout has been integrated.)
- layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntergration):
(WebCore::Layout::FlexFormattingContext::computedIntrinsicWidthConstraintsForIntegration):
- layout/formattingContexts/flex/FlexFormattingContext.h:
- layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntergration):
(WebCore::Layout::InlineFormattingContext::lineLayoutForIntergration): Deleted.
- layout/formattingContexts/inline/InlineFormattingContext.h:
- layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::FlexLayout):
(WebCore::LayoutIntegration::FlexLayout::computeIntrinsicWidthConstraints):
(WebCore::LayoutIntegration::FlexLayout::layout):
- layout/integration/flex/LayoutIntegrationFlexLayout.h:
(WebCore::LayoutIntegration::FlexLayout::rootLayoutBox const):
(WebCore::LayoutIntegration::FlexLayout::rootLayoutBox):
- layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):
- 3:26 PM Changeset in webkit [293296] by
-
- 30 edits3 copies1 add in trunk
Add WKNotification and WKWebsiteDataStore SPI for handling click/close of persistent notifications
https://bugs.webkit.org/show_bug.cgi
Reviewed by Chris Dumez.
Source/WebCore:
Covered by existing tests with WKTR changes.
In Cocoa, expose the dictionary representation of a notification as an NSDictionary,
as it is meant to be used as an NSUserNotification userInfo value.
- Modules/notifications/NotificationData.h:
- Modules/notifications/NotificationDataCocoa.mm: Added.
(WebCore::NotificationData::fromDictionary):
(WebCore::NotificationData::dictionaryRepresentation const):
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::processNotificationEvent):
- workers/service/server/SWServer.h:
Source/WebKit:
For notifications that are persistent, add WKWebsiteDataStore SPI to handle click/close operations,
as the WKNotificationManager's runtime record of such notifications might be gone.
WebKitTestRunner exercises this new SPI in existing tests.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processNotificationEvent):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- SourcesCocoa.txt:
- UIProcess/API/C/WKNotification.cpp:
(WKNotificationGetIsPersistent):
- UIProcess/API/C/WKNotification.h:
- UIProcess/API/C/mac/WKNotificationPrivateMac.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h.
- UIProcess/API/C/mac/WKNotificationPrivateMac.mm: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h.
(WKNotificationCopyDictionaryRepresentation):
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _processPersistentNotificationClick:completionHandler:]):
(-[WKWebsiteDataStore _processPersistentNotificationClose:completionHandler:]):
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/API/Cocoa/_WKDownload.mm:
- UIProcess/API/Cocoa/_WKDownloadInternal.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::processNotificationEvent):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Notifications/WebNotification.cpp:
- UIProcess/Notifications/WebNotification.h:
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::dispatchDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
- WebKit.xcodeproj/project.pbxproj:
Tools:
Teach WKTR to use the new SPI by keeping a set of notifications that are persistent.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/WebNotificationProvider.cpp:
(WTR::WebNotificationProvider::showWebNotification):
(WTR::WebNotificationProvider::closeWebNotification):
(WTR::WebNotificationProvider::reset):
- WebKitTestRunner/WebNotificationProvider.h:
- WebKitTestRunner/cocoa/WebNotificationProviderCocoa.mm:
(WTR::WebNotificationProvider::simulateWebNotificationClickForServiceWorkerNotifications):
- 2:47 PM Changeset in webkit [293295] by
-
- 2 edits in trunk/Source/WebCore
Fix build error caused by LTO + Unified Sources
https://bugs.webkit.org/show_bug.cgi?id=239679
Reviewed by Alex Christensen.
This hopefully fixes the following build error:
Undefined symbols for architecture x86_64:
"JSC::GenericTypedArrayView<JSC::Uint8ClampedAdaptor>::tryCreateUninitialized(unsigned long)", referenced from:
WebCore::FEGaussianBlurSoftwareApplier::apply(WebCore::Filter const&, WTF::Vector<WTF::Ref<WebCore::FilterImage, WTF::RawPtrTraits<WebCore::FilterImage> >, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::FilterImage&) const in lto.o
ld: symbol(s) not found for architecture x86_64
- platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:
- 2:13 PM Changeset in webkit [293294] by
-
- 3 edits in trunk/Tools
[buildbot] Increase the EWS compile timeout to account for delayed output from clang/XCBuild
https://bugs.webkit.org/show_bug.cgi?id=239455
Reviewed by Ryan Haddad.
Same as https://commits.webkit.org/249737@main, needed to work around
delayed output bugs in Xcode/XCBuild.
- Tools/CISupport/ews-build/steps.py:
(CompileWebKit.init):
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249919@main
- 1:25 PM Changeset in webkit [293293] by
-
- 8 edits in trunk/Source/WebCore
[FFC][Integration] Construct and update the layout tree for the flex items
https://bugs.webkit.org/show_bug.cgi?id=239684
Reviewed by Antti Koivisto.
This patch implements the usual flow of preparing a subtree for integration layout.
- Take the direct children of a RenderFlexibleBox (flex items) and construct Layout::ContainerBox objects.
- Run layout on the direct children (RenderBlocks) first and update the associated Layout::ContainerBoxes' geometries.
- Call LayoutIntegration::FlexLayout::layout (not yet implemented) to run flex layout on the flex items.
- layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTreeForFlexContent):
- layout/integration/LayoutIntegrationBoxTree.h:
- layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::FlexLayout):
(WebCore::LayoutIntegration::FlexLayout::updateFlexItemDimensions):
- layout/integration/flex/LayoutIntegrationFlexLayout.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):
- rendering/RenderFlexibleBox.h:
- 10:36 AM Changeset in webkit [293292] by
-
- 123 edits in trunk/Source
Start preparing the code base for making the AtomString(const String&) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=239658
Reviewed by Darin Adler.
Start preparing the code base for making the AtomString(const String&) constructor explicit.
This helps us find cases where we atomize unnecessarily or not early enough, thus causing
unnecessary String allocations.
- Source/JavaScriptCore/runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeToAtomString const):
- Source/WebKit/WebProcess/Plugins/Plugin.h:
- Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
- Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- Source/WebKitLegacy/mac/DOM/DOMCustomXPathNSResolver.h:
- Source/WebKitLegacy/mac/DOM/DOMCustomXPathNSResolver.mm:
(DOMCustomXPathNSResolver::lookupNamespaceURI):
- Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
- Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(parameterValue):
(WebFrameLoaderClient::createPlugin):
- Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
- Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h:
- Source/WTF/wtf/persistence/PersistentCoders.cpp:
(WTF::Persistence::Coder<AtomString>::decode):
- Source/WTF/wtf/text/StringBuilder.h:
(WTF::StringBuilder::toAtomString const):
- Source/WTF/wtf/text/StringConcatenate.h:
(WTF::tryMakeAtomStringFromAdapters):
- Source/WTF/wtf/text/StringView.cpp:
(WTF::convertASCIILowercaseAtom):
- Source/WebCore/Modules/gamepad/GamepadEvent.idl:
- Source/WebCore/Modules/mediasession/MediaMetadata.cpp:
(WebCore::ArtworkImageLoader::requestImageResource):
- Source/WebCore/Modules/plugins/PluginReplacement.h:
(WebCore::ReplacementPlugin::create const):
- Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::create):
(WebCore::YouTubePluginReplacement::YouTubePluginReplacement):
(WebCore::YouTubePluginReplacement::youTubeURL):
(WebCore::YouTubePluginReplacement::youTubeURLFromAbsoluteURL):
- Source/WebCore/Modules/plugins/YouTubePluginReplacement.h:
- Source/WebCore/Modules/websockets/CloseEvent.idl:
- Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleLiveRegionCreated):
- Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsLiveRegion const):
(WebCore::AccessibilityObject::tagName const):
- Source/WebCore/accessibility/AccessibilityObject.h:
- Source/WebCore/accessibility/AccessibilityObjectInterface.h:
- Source/WebCore/accessibility/AccessibilityRole.idl:
- Source/WebCore/accessibility/AriaAttributes.idl:
- Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
- Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
- Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::IDLAttributeNameToAnimationPropertyName):
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::updateBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes):
- Source/WebCore/animation/KeyframeEffect.h:
- Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::commitStyles):
- Source/WebCore/bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::setAttributeChangedCallback):
- Source/WebCore/bindings/js/JSCustomElementInterface.h:
- Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp:
(WebCore::JSCustomElementRegistry::define):
- Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp:
(WebCore::constructJSExtendableMessageEvent):
- Source/WebCore/css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
(WebCore::CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts):
- Source/WebCore/dom/Attr.cpp:
(WebCore::Attr::setNodeValue):
- Source/WebCore/dom/ClipboardEvent.idl:
- Source/WebCore/dom/CompositionEvent.idl:
- Source/WebCore/dom/CustomElementRegistry.idl:
- Source/WebCore/dom/CustomEvent.idl:
- Source/WebCore/dom/Document+HTML.idl:
- Source/WebCore/dom/DragEvent.idl:
- Source/WebCore/dom/Element.idl:
- Source/WebCore/dom/ErrorEvent.idl:
- Source/WebCore/domjit/DOMJITIDLConvert.h:
(WebCore::DOMJIT::DirectConverter<IDLAtomStringAdaptor<IDLDOMString>>::directConvert):
(WebCore::DOMJIT::DirectConverter<IDLRequiresExistingAtomStringAdaptor<IDLDOMString>>::directConvert):
- Source/WebCore/editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::createElementForImageOverlay):
- Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::createFragmentForImageAttachment):
- Source/WebCore/html/HTMLAnchorElement.h:
- Source/WebCore/html/HTMLAnchorElement.idl:
- Source/WebCore/html/HTMLAreaElement.idl:
- Source/WebCore/html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parametersForPlugin):
(WebCore::HTMLEmbedElement::updateWidget):
- Source/WebCore/html/HTMLEmbedElement.h:
- Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::mapDataParamToSrc):
(WebCore::HTMLObjectElement::parametersForPlugin):
(WebCore::HTMLObjectElement::updateWidget):
- Source/WebCore/html/HTMLObjectElement.h:
- Source/WebCore/html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::name const):
(WebCore::HTMLParamElement::value const):
- Source/WebCore/html/HTMLParamElement.h:
- Source/WebCore/html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::requestObject):
- Source/WebCore/html/HTMLPlugInElement.h:
- Source/WebCore/html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::requestObject):
- Source/WebCore/html/HTMLPlugInImageElement.h:
- Source/WebCore/html/track/TextTrack.h:
(WebCore::TextTrack::inBandMetadataTrackDispatchType const):
- Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::createPlugin):
- Source/WebCore/loader/EmptyFrameLoaderClient.h:
- Source/WebCore/loader/FrameLoaderClient.h:
- Source/WebCore/loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::requestPlugin):
(WebCore::FrameLoader::SubframeLoader::requestObject):
(WebCore::FrameLoader::SubframeLoader::loadPlugin):
- Source/WebCore/loader/SubframeLoader.h:
- Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::language const):
- Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::CDMPrivateFairPlayStreaming::supportsConfiguration const):
- Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.h:
- Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::rendererWasAutomaticallyFlushed):
- Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::settings):
(WebCore::AVVideoCaptureSource::capabilities):
- Source/WebCore/platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::decode):
- Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::stripLeadingAndTrailingDoubleQuote):
(WebCore::ResourceResponse::platformLazyInit):
- Source/WebCore/platform/text/PlatformLocale.h:
(WebCore::Locale::createDefault):
- Source/WebCore/plugins/DOMMimeTypeArray.idl:
- Source/WebCore/plugins/DOMPlugin.idl:
- Source/WebCore/plugins/DOMPluginArray.idl:
- Source/WebCore/rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::paintApplePayButton):
- Source/WebCore/style/PropertyCascade.h:
(WebCore::Style::PropertyCascade::hasCustomProperty const):
(WebCore::Style::PropertyCascade::customProperty const):
- Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertFontPalette):
(WebCore::Style::BuilderConverter::convertContainerName):
- Source/WebCore/svg/SVGFEBlendElement.h:
- Source/WebCore/svg/SVGFEColorMatrixElement.h:
- Source/WebCore/svg/SVGFEComponentTransferElement.h:
- Source/WebCore/svg/SVGFECompositeElement.h:
- Source/WebCore/svg/SVGFEConvolveMatrixElement.h:
- Source/WebCore/svg/SVGFEDiffuseLightingElement.h:
- Source/WebCore/svg/SVGFEDisplacementMapElement.h:
- Source/WebCore/svg/SVGFEDropShadowElement.h:
- Source/WebCore/svg/SVGFEGaussianBlurElement.h:
- Source/WebCore/svg/SVGFEMorphologyElement.h:
- Source/WebCore/svg/SVGFEOffsetElement.h:
- Source/WebCore/svg/SVGFESpecularLightingElement.h:
- Source/WebCore/svg/SVGFETileElement.h:
- Source/WebCore/svg/SVGScriptElement.h:
- Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::buildFilterExpression):
- Source/WebCore/xml/CustomXPathNSResolver.cpp:
(WebCore::CustomXPathNSResolver::lookupNamespaceURI):
- Source/WebCore/xml/CustomXPathNSResolver.h:
- Source/WebCore/xml/CustomXPathNSResolver.idl:
- Source/WebCore/xml/NativeXPathNSResolver.cpp:
(WebCore::NativeXPathNSResolver::lookupNamespaceURI):
- Source/WebCore/xml/NativeXPathNSResolver.h:
- Source/WebCore/xml/XPathGrammar.cpp:
- Source/WebCore/xml/XPathNSResolver.h:
- Source/WebCore/xml/XPathNSResolver.idl:
- Source/WebCore/xml/XPathParser.cpp:
(WebCore::XPath::Parser::expandQualifiedName):
- Source/WebCore/xml/XPathParser.h:
- Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::handleNamespaceAttributes):
(WebCore::handleElementAttributes):
Canonical link: https://commits.webkit.org/249917@main
- 9:30 AM Changeset in webkit [293291] by
-
- 15 edits in trunk
AX ITM: Table row objects should return a non-null unignored parent even when a table object is not found in its ancestry.
https://bugs.webkit.org/show_bug.cgi?id=239606
<rdar://problem/92094205>
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/aria-expanded-supported-roles.html.
In addition, fixed test accessibility/mac/heading-clickpoint.html.
AccessibilityARIAGridRow::parentObjectUnignored was returning nullptr
if there was no table ancestor. This caused problems in isolated tree
mode where only the root object should have a null parent. With this
patch this method will return the table ancestor if one exists, its
parent in the AX tree otherwise.
Changed all classes in the AXObject hierarchy to return an AXObject for
the parentObjectUnignored method instead of an AXCoreObject.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedObjectForPage):
Removed unnecessary downcast.
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::parentObjectUnignored const):
(WebCore::AccessibilityARIAGridRow::parentTable const):
Rewrote this method using Accessibility::findAncestor.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::parentObjectUnignored const):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectUnignored const):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::parentObjectUnignored const):
- accessibility/AccessibilityTableCell.h:
LayoutTests:
- accessibility/aria-expanded-supported-roles.html:
- accessibility/mac/heading-clickpoint-expected.txt:
- accessibility/mac/heading-clickpoint.html:
- platform/mac/accessibility/aria-expanded-supported-roles-expected.txt:
- 8:09 AM Changeset in webkit [293290] by
-
- 4 edits in trunk/Source/WebCore
fix a few ObjC memory management issues after r291361
https://bugs.webkit.org/show_bug.cgi?id=239686
<rdar://problem/91008058>
Reviewed by Eric Carlson.
- platform/ios/PlaybackSessionInterfaceAVKit.mm:
(WebCore::mediaSelectionOptions):
- platform/ios/WebAVPlayerController.h:
- platform/ios/WebAVPlayerController.mm:
(-[WebAVMediaSelectionOption localizedDisplayName]): Added.
(-[WebAVMediaSelectionOption dealloc]): Deleted.
- 1:10 AM Changeset in webkit [293289] by
-
- 5 edits1 delete in trunk
[ATSPI] WTR: add implementation for AccessibilityUIElement::domIdentifier
https://bugs.webkit.org/show_bug.cgi?id=239598
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2022-04-23
Reviewed by Andres Gonzalez.
Tools:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::domIdentifier const): Deleted.
- WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::domIdentifier const):
- WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
(WTR::AccessibilityUIElement::domIdentifier const):
LayoutTests:
- platform/glib/accessibility/table-add-remove-row-expected.txt: Removed.
Apr 22, 2022:
- 11:44 PM Changeset in webkit [293288] by
-
- 8 edits4 adds in trunk
The layout is not updated when style.contain is changed from "size"/"inline-size" to empty string
https://bugs.webkit.org/show_bug.cgi?id=239489
Reviewed by Rob Buis.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/contain-inline-size-removed-expected.html: Added.
- web-platform-tests/css/css-contain/contain-inline-size-removed.html: Added.
- web-platform-tests/css/css-contain/contain-size-removed-expected.html: Added.
- web-platform-tests/css/css-contain/contain-size-removed.html: Added.
- web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-004-expected.txt:
- web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-005-expected.txt:
Source/WebCore:
Unlike "layout", "paint" and "style" containment, being a "size" and "inline-size" containment or not affects the layout size of the element.
So it should require layout when a normal element becomes a "size"/"inline-size" containment, vice versa.
Tests: imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-removed.html
imported/w3c/web-platform-tests/css/css-contain/contain-size-removed.html
- rendering/style/RenderStyle.cpp:
(WebCore::rareNonInheritedDataChangeRequiresLayout):
(WebCore::RenderStyle::effectiveContainment const): Deleted. Moved to StyleRareNonInheritedData.
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::effectiveContainment const):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::effectiveContainment const):
- rendering/style/StyleRareNonInheritedData.h:
- 11:27 PM Changeset in webkit [293287] by
-
- 3 edits2 adds in trunk
Should never be reached failure in WebCore::RenderElement::visibleInViewportStateChanged
https://bugs.webkit.org/show_bug.cgi?id=191824
Patch by Rob Buis <rbuis@igalia.com> on 2022-04-22
Reviewed by Eric Carlson.
Source/WebCore:
Provide an empty visibleInViewportStateChanged implementation
for RenderMedia to prevent hitting the ASSERT.
Test: media/audio-viewport-state-change-crash.html
- rendering/RenderMedia.h:
LayoutTests:
- media/audio-viewport-state-change-crash-expected.txt: Added.
- media/audio-viewport-state-change-crash.html: Added.
- 9:40 PM Changeset in webkit [293286] by
-
- 2 edits in trunk/Source/WebCore
Crash under AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate()
https://bugs.webkit.org/show_bug.cgi?id=239683
<rdar://92198272>
Reviewed by Alan Bujtas.
Crash data suggest that m_page can be null in
AsyncScrollingCoordinator::scheduleRenderingUpdate(), which does seem possible because
scheduleRenderingUpdate() is a dispatch from the scrolling thread, and
ScrollingCoordinator::pageDestroyed() may have run before it runs.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):
- 9:21 PM Changeset in webkit [293285] by
-
- 88 edits2 copies in trunk
Move global AtomStrings to a common header to promote reuse
https://bugs.webkit.org/show_bug.cgi?id=239585
Reviewed by Geoff Garen and Darin Adler.
Source/WebCore:
- Headers.cmake:
- Modules/async-clipboard/Clipboard.cpp:
(WebCore::Clipboard::getType):
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::contentHint const):
(WebCore::MediaStreamTrack::setContentHint):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- animation/AnimationEffect.cpp:
(WebCore::AnimationEffect::getTiming const):
(WebCore::AnimationEffect::updateTiming):
- animation/EffectTiming.h:
- contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::isValidCSSSelector):
- css/CSSStyleSheet.h:
- css/FontFace.cpp:
(WebCore::FontFace::display const):
- css/MediaFeatureNames.cpp:
(WebCore::MediaFeatureNames::init):
- dom/DataTransfer.cpp:
(WebCore::normalizeType):
(WebCore::DataTransfer::setDataFromItemList):
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::dropEffect const):
- dom/Document.cpp:
(WebCore::Document::designMode const):
- dom/InlineStyleSheetOwner.cpp:
(WebCore::isValidCSSContentType):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
- dom/mac/ImageControlsMac.cpp:
- editing/FontShadow.cpp:
(WebCore::serializationForCSS):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
- editing/cocoa/DataDetection.mm:
- editing/cocoa/HTMLConverter.mm:
(HTMLConverterCaches::propertyValueForNode):
(HTMLConverter::computedAttributesForElement):
(HTMLConverter::_enterElement):
(HTMLConverter::_processElement):
- editing/markup.cpp:
(WebCore::createFragmentForTransformToFragment):
- html/Autocapitalize.cpp:
(WebCore::stringForAutocapitalizeType):
- html/Autofill.cpp:
(WebCore::AutofillData::createFromHTMLFormControlElement):
- html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::saveFormControlState const):
(WebCore::BaseCheckableInputType::restoreFormControlState):
(WebCore::BaseCheckableInputType::fallbackValue const):
- html/EnterKeyHint.cpp:
(WebCore::attributeValueForEnterKeyHint):
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::createForLegacyFactoryFunction):
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::formControlType const):
- html/HTMLElement.cpp:
(WebCore::toValidDirValue):
(WebCore::HTMLElement::contentEditable const):
(WebCore::HTMLElement::setContentEditable):
(WebCore::HTMLElement::setAutocorrect):
(WebCore::plaintextOnlyName): Deleted.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::autocomplete const):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::loadingForBindings const):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::decoding const):
(WebCore::HTMLImageElement::loadingForBindings const):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::preload const):
- html/HTMLTextFormControlElement.cpp:
(WebCore::directionString):
- html/InputMode.cpp:
(WebCore::InputModeNames::none):
(WebCore::InputModeNames::text):
(WebCore::InputModeNames::tel):
(WebCore::InputModeNames::url):
(WebCore::InputModeNames::email):
(WebCore::InputModeNames::search):
- html/InputTypeNames.cpp:
(WebCore::InputTypeNames::email):
(WebCore::InputTypeNames::reset):
(WebCore::InputTypeNames::search):
(WebCore::InputTypeNames::submit):
(WebCore::InputTypeNames::telephone):
(WebCore::InputTypeNames::text):
(WebCore::InputTypeNames::url):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::updateInnerTextElementEditabilityImpl):
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::isValidKind const):
(WebCore::AudioTrack::updateKindFromPrivate):
(WebCore::AudioTrack::alternativeKeyword): Deleted.
(WebCore::AudioTrack::mainKeyword): Deleted.
(WebCore::AudioTrack::commentaryKeyword): Deleted.
- html/track/AudioTrack.h:
- html/track/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::isValidKindKeyword):
(WebCore::TextTrack::kindKeyword const):
(WebCore::TextTrack::subtitlesKeyword): Deleted.
(WebCore::captionsKeyword): Deleted.
- html/track/TextTrack.h:
- html/track/VTTCue.cpp:
(WebCore::VTTCue::positionAlign const):
(WebCore::VTTCue::setPositionAlign):
(WebCore::VTTCue::toJSON const):
(WebCore::autoKeyword): Deleted.
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::isValidKind const):
(WebCore::VideoTrack::updateKindFromPrivate):
(WebCore::VideoTrack::alternativeKeyword): Deleted.
(WebCore::VideoTrack::captionsKeyword): Deleted.
(WebCore::VideoTrack::mainKeyword): Deleted.
(WebCore::VideoTrack::subtitlesKeyword): Deleted.
(WebCore::VideoTrack::commentaryKeyword): Deleted.
- html/track/VideoTrack.h:
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::WebVTTParser):
- inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::createInspectorStyleSheetForDocument):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::Attributes::parseEncodingType):
- loader/NavigationScheduler.cpp:
- loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::textFromUTF8):
- loader/archive/mhtml/MHTMLParser.cpp:
(WebCore::MHTMLParser::addResourceToArchive):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
- mathml/MathMLPresentationElement.cpp:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::addAudioTrackKindDisplayNameIfNeeded):
- page/EventSource.cpp:
(WebCore::EventSource::EventSource):
- page/Page.cpp:
(WebCore::Page::userStyleSheet const):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):
- page/PrintContext.cpp:
(WebCore::PrintContext::pageProperty):
- page/ProcessWarming.cpp:
(WebCore::ProcessWarming::initializeNames):
- platform/CommonAtomStrings.cpp: Added.
(WebCore::initializeCommonAtomStrings):
- platform/CommonAtomStrings.h: Added.
(WebCore::alternativeAtom):
(WebCore::autoAtom):
(WebCore::captionsAtom):
(WebCore::commentaryAtom):
(WebCore::cssContentTypeAtom):
(WebCore::eagerAtom):
(WebCore::emailAtom):
(WebCore::falseAtom):
(WebCore::lazyAtom):
(WebCore::mainAtom):
(WebCore::noneAtom):
(WebCore::offAtom):
(WebCore::onAtom):
(WebCore::plaintextOnlyAtom):
(WebCore::resetAtom):
(WebCore::searchAtom):
(WebCore::submitAtom):
(WebCore::subtitlesAtom):
(WebCore::telAtom):
(WebCore::textAtom):
(WebCore::textPlainContentTypeAtom):
(WebCore::trueAtom):
(WebCore::urlAtom):
- platform/Pasteboard.cpp:
(WebCore::Pasteboard::isSafeTypeForDOMToReadAndWrite):
- platform/StaticPasteboard.cpp:
(WebCore::StaticPasteboard::writePlainText):
- platform/animation/Animation.cpp:
(WebCore::Animation::initialName const):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load):
(WebCore::textPlain): Deleted.
- platform/ios/wak/WebCoreThread.mm:
(StartWebThread):
- platform/network/HTTPParsers.cpp:
- platform/network/ios/WebCoreURLResponseIOS.h:
(WebCore::shouldUseQuickLookForMIMEType):
- style/Styleable.cpp:
(WebCore::Styleable::animationListContainsNewlyValidAnimation const):
(WebCore::Styleable::updateCSSAnimations const):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::rotateMode const):
- svg/SVGAnimationElement.cpp:
(WebCore::sumAtom):
(WebCore::SVGAnimationElement::isAdditive const):
(WebCore::SVGAnimationElement::isAccumulated const):
- svg/SVGFEConvolveMatrixElement.cpp:
- svg/SVGFEConvolveMatrixElement.h:
(WebCore::SVGPropertyTraits<EdgeModeType>::toString):
(WebCore::SVGPropertyTraits<EdgeModeType>::fromString):
- svg/SVGMarkerTypes.h:
(WebCore::SVGPropertyTraits<SVGMarkerOrientType>::fromString):
(WebCore::SVGPropertyTraits<SVGMarkerOrientType>::toString):
(WebCore::SVGPropertyTraits<SVGMarkerOrientType>::autoString): Deleted.
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::type const):
- svg/SVGTextPathElement.h:
(WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::toString):
(WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::fromString):
- svg/animation/SVGSMILElement.cpp:
(WebCore::indefiniteAtom):
(WebCore::SVGSMILElement::parseClockValue):
(WebCore::SVGSMILElement::repeatCount const):
- svg/properties/SVGPropertyTraits.h:
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::m_notificationClient):
- xml/XPathValue.cpp:
Source/WebKit:
- GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::initializeGPUProcess):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
- Shared/Cocoa/WebKit2InitializeCocoa.mm:
(WebKit::runInitializationCode):
- Shared/WebKit2Initialize.cpp:
(WebKit::InitializeWebKit2):
- UIProcess/API/APIContentRuleListStore.cpp:
(API::ContentRuleListStore::compileContentRuleList):
Source/WebKitLegacy/win:
- WebKitGraphics.cpp:
(makeFont):
Source/WTF:
- wtf/text/AtomString.cpp:
(WTF::AtomString::init):
- wtf/text/AtomString.h:
(WTF::xmlnsAtom):
(WTF::trueAtom): Deleted.
(WTF::falseAtom): Deleted.
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::makeBackend):
- 8:28 PM Changeset in webkit [293284] by
-
- 1 edit in branches/safari-613.2.7.1-branch/Source/WebCore/page/Page.cpp
Unreviewed build fix. rdar://80544133
./page/Page.cpp:389:9: error: incomplete type 'WebCore::FontCache' named in nested name specifier
- 8:27 PM Changeset in webkit [293283] by
-
- 1 edit in branches/safari-613.2.7.0-branch/Source/WebCore/page/Page.cpp
Unreviewed build fix. rdar://80544133
./page/Page.cpp:389:9: error: incomplete type 'WebCore::FontCache' named in nested name specifier
- 7:58 PM Changeset in webkit [293282] by
-
- 2 edits in branches/safari-613.2.7.1-branch/Source
Apply patch. rdar://problem/90968687
- 7:54 PM Changeset in webkit [293281] by
-
- 18 edits in branches/safari-613.2.7.1-branch
Revert "Apply patch. rdar://problem/88904160"
This reverts commit r293269.
- 7:42 PM Changeset in webkit [293280] by
-
- 9 edits2 copies in branches/safari-614.1.10-branch/Source
Cherry-pick r293106. rdar://problem/91740931
[WebGPU] WebKit and WebKitLegacy shouldn't need to know about WebGPU.framework
https://bugs.webkit.org/show_bug.cgi?id=239528
<rdar://problem/91740931>
Unreviewed build fix.
Source/WebCore/PAL:
WebKit and WebKitLegacy create a WebGPU implementation from pal/graphics/WebGPU/Impl. This implementation
knows about WebGPU.framework. However, the create() function doesn't need to know about WebGPU.framework,
and its header doesn't need to include <WebGPU/WebGPU.h>. Only the .cpp files need to know about
<WebGPU/WebGPU.h>, and those .cpp files are invisible from WebKit and WebKitLegacy's points of view. So,
this patch splits the PAL header into:
- A header which includes a creation function, but doesn't know about WebGPU.framework, and
- A header which knows about WebGPU.framework, but doesn't hold the creation function used by WebKit or
WebKitLegacy.
This fixes one of Apple's internal builds.
- PAL.xcodeproj/project.pbxproj:
- pal/graphics/WebGPU/Impl/WebGPUCreateImpl.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp. (PAL::WebGPU::create):
- pal/graphics/WebGPU/Impl/WebGPUCreateImpl.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.h.
- pal/graphics/WebGPU/Impl/WebGPUImpl.cpp: (PAL::WebGPU::GPUImpl::create): Deleted.
- pal/graphics/WebGPU/Impl/WebGPUImpl.h:
Source/WebKit:
- GPUProcess/graphics/WebGPU/RemoteGPU.cpp: (WebKit::RemoteGPU::workQueueInitialize):
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::createGPUForWebGPU const):
Source/WebKitLegacy/mac:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createGPUForWebGPU const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:23 PM Changeset in webkit [293279] by
-
- 6 edits in trunk/Source
Unreviewed, non-unified build fixes after r293203
Source/JavaScriptCore:
- jit/ScratchRegisterAllocator.h:
Source/WebCore:
- page/PageConfiguration.h:
Source/WTF:
- wtf/RobinHoodHashTable.h:
- 7:15 PM Changeset in webkit [293278] by
-
- 4 edits in trunk/Source/WebCore
Reduce sizeof(CSSNumericType)
https://bugs.webkit.org/show_bug.cgi?id=239680
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-22
Reviewed by Yusuke Suzuki.
- bindings/IDLTypes.h:
(WebCore::IDLType::nullValue):
(WebCore::IDLType::isNullType):
(WebCore::IDLType::extractValueFromNullable):
- css/typedom/numeric/CSSMathProduct.cpp:
(WebCore::multiplyTypes):
- css/typedom/numeric/CSSNumericType.h:
(WebCore::CSSNumericType::valueForType):
(WebCore::CSSNumericType::valueForType const):
- 7:05 PM Changeset in webkit [293277] by
-
- 1 edit in branches/safari-613.2.7.1-branch/Source/WebCore/page/SecurityOrigin.h
Unreviewed build fix. rdar://90511155
WebCore/page/SecurityOrigin.h:309:13: note: candidate function not viable: requires 2 arguments, but 4 were provided inline void add(Hasher& hasher, const SecurityOrigin& origin)
- 7:02 PM Changeset in webkit [293276] by
-
- 1 edit in branches/safari-613.2.7.0-branch/Source/WebCore/page/SecurityOrigin.h
Unreviewed build fix. rdar://90511155
WebCore/page/SecurityOrigin.h:309:13: note: candidate function not viable: requires 2 arguments, but 4 were provided inline void add(Hasher& hasher, const SecurityOrigin& origin)
- 5:44 PM Changeset in webkit [293275] by
-
- 18 edits in branches/safari-613.2.7.0-branch
Revert "Apply patch. rdar://problem/88904160"
This reverts commit r293258.
- 5:44 PM Changeset in webkit [293274] by
-
- 5 edits in branches/safari-613.2.7.0-branch/Source/WebKit
Revert "Apply patch. rdar://problem/88904160"
This reverts commit r293259.
- 5:37 PM Changeset in webkit [293273] by
-
- 5 edits in branches/safari-613.2.7.1-branch/Source/WebKit
Revert "Apply patch. rdar://problem/88904160"
This reverts commit r293270.
- 5:37 PM Changeset in webkit [293272] by
-
- 2 edits in branches/safari-613.2.7.1-branch/Source
Revert "Apply patch. rdar://problem/90968687"
This reverts commit r293271.
- 5:06 PM Changeset in webkit [293271] by
-
- 2 edits in branches/safari-613.2.7.1-branch/Source
Apply patch. rdar://problem/90968687
- 5:04 PM Changeset in webkit [293270] by
-
- 5 edits in branches/safari-613.2.7.1-branch/Source/WebKit
Apply patch. rdar://problem/88904160
- 5:04 PM Changeset in webkit [293269] by
-
- 18 edits in branches/safari-613.2.7.1-branch
Apply patch. rdar://problem/88904160
- 4:59 PM Changeset in webkit [293268] by
-
- 10 edits in branches/safari-613.2.7.1-branch
Cherry-pick r292274. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
- page/Page.h:
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
Tools:
Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):
LayoutTests:
- TestExpectations:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:59 PM Changeset in webkit [293267] by
-
- 8 edits2 adds in branches/safari-613.2.7.1-branch
Cherry-pick r292072. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_attachmentElementClient):
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
LayoutTests:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:39 PM Changeset in webkit [293266] by
-
- 37 edits5 copies24 adds in trunk
Revert "[WebAuthn] Clean up WebAuthenticationModern and WebAuthnProcess"
This reverts commit 6ced3b519689536e6e4d36b9e46e78be9e6f4706.
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/249907@main
- 4:21 PM Changeset in webkit [293265] by
-
- 4 edits in trunk/Source/JavaScriptCore
[Refactoring] Reduce number of const and reinterpret casts
https://bugs.webkit.org/show_bug.cgi?id=239648
Reviewed by Yusuke Suzuki.
The statement
"reinterpret_cast<TypeDefinition*>(const_cast<char*>(functionType.m_payload)
- sizeof(TypeDefinition))"
is dangerous and it produces warning on some platfroms.
There is way to avoid it and this patch is doint that.
- wasm/WasmSlowPaths.cpp:
(JSC::LLInt::doWasmCallIndirect):
(JSC::LLInt::doWasmCallRef):
- wasm/WasmTypeDefinition.h:
(JSC::Wasm::FunctionSignature::operator== const):
- wasm/WasmTypeDefinitionInlines.h:
- 4:19 PM Changeset in webkit [293264] by
-
- 9 edits in trunk
Web Inspector: Regression(r287684) Resources from the memory cache show empty content in Network, Sources, and Search tabs
https://bugs.webkit.org/show_bug.cgi?id=239667
Reviewed by Devin Rousso.
Source/WebCore:
Updated tests:
- http/tests/inspector/network/resource-response-source-disk-cache.html
- http/tests/inspector/network/resource-response-source-memory-cache.html
r287684 introduced a subtle bug when calling InspectorInstrumentation::didReceiveData. We rely
on there being a difference between real, but empty, data buffer and not having a data buffer,
but after r287684 an empty SharedBuffer would be passed in the later case. Instead, we should
continue to pass nullptr if there is no buffer so that InspectorNetworkAgent::didReceiveData
can distiguish between the two.
The bug is the result of having a non-nullptr
datainInspectorNetworkAgent::didReceiveData,
which causes us to callmaybeAddResourceData, which means by the time
InspectorNetworkAgent::getResponseBodyis called, the ResourceData for the request will have
an empty, not non-existant,content(), which means we will return the empty content instead,
since we believe the response had actual content.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveDataImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didReceiveData):
- loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
LayoutTests:
Add test steps to ensure that the resource has content, and that the base64Encoded value matches our
expectations. While only the memory cache was affected by this regression, add the test steps to both
the memory and disk caches to defend this functionality.
- http/tests/inspector/network/resource-response-source-memory-cache-expected.txt:
- http/tests/inspector/network/resource-response-source-memory-cache.html:
- http/tests/inspector/network/resource-response-source-disk-cache-expected.txt:
- http/tests/inspector/network/resource-response-source-disk-cache.html:
- 4:06 PM Changeset in webkit [293263] by
-
- 10 edits in branches/safari-613.2.7.0-branch
Cherry-pick r292274. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
- page/Page.h:
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
Tools:
Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):
LayoutTests:
- TestExpectations:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:06 PM Changeset in webkit [293262] by
-
- 8 edits2 adds in branches/safari-613.2.7.0-branch
Cherry-pick r292072. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_attachmentElementClient):
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
LayoutTests:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:02 PM Changeset in webkit [293261] by
-
- 20 edits4 adds in branches/safari-613.2.7.1-branch
Cherry-pick r291589. rdar://problem/90511155
LayoutTests/imported/w3c:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
Import web-platform-tests test coverage.
- web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt: Added.
- web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html: Added.
- web-platform-tests/webmessaging/broadcastchannel/w3c-import.log:
Source/WebCore:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.
To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.
When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.
Test: imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- dom/BroadcastChannel.cpp: (WebCore::shouldPartitionOrigin): (WebCore::BroadcastChannel::MainThreadBridge::registerChannel): (WebCore::BroadcastChannel::MainThreadBridge::unregisterChannel): (WebCore::BroadcastChannel::MainThreadBridge::postMessage):
- dom/BroadcastChannelRegistry.h:
- loader/EmptyClients.cpp:
- page/PartitionedSecurityOrigin.h: Added. (WebCore::PartitionedSecurityOrigin::PartitionedSecurityOrigin): (WebCore::PartitionedSecurityOrigin::isHashTableDeletedValue const): (WebCore::PartitionedSecurityOrigin::isHashTableEmptyValue const): (WebCore::operator==): (WTF::add): (WTF::PartitionedSecurityOriginHash::hash): (WTF::PartitionedSecurityOriginHash::equal): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::emptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::constructEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::isEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::peek): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::take):
Source/WebKit:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.
To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.
When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.
- WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp: (WebKit::toClientOrigin): (WebKit::WebBroadcastChannelRegistry::registerChannel): (WebKit::WebBroadcastChannelRegistry::unregisterChannel): (WebKit::WebBroadcastChannelRegistry::postMessage): (WebKit::WebBroadcastChannelRegistry::postMessageLocally): (WebKit::WebBroadcastChannelRegistry::postMessageToRemote): (WebKit::WebBroadcastChannelRegistry::networkProcessCrashed):
- WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.h:
Source/WebKitLegacy:
Dust off Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=238121
Reviewed by Yusuke Suzuki.
- PlatformMac.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:52 PM Changeset in webkit [293260] by
-
- 7 edits2 adds in trunk
Focusing scroll container before scrolling breaks smooth scrolling
https://bugs.webkit.org/show_bug.cgi?id=239605
Reviewed by Wenson Hsieh.
Source/WebCore:
If script calls focus() and then scrollTo({ behavior: smooth }) in the same runloop, the
scrollToFocusedElementInternal() that happens on a zero-delay timer in FrameView will stop
the animated scroll.
Fix by having programmatic scrolls on Element and DOMWindow cancel any pending focus-related
scroll.
Test: fast/scrolling/programmatic-smooth-scroll-after-focus.html
- dom/Element.cpp:
(WebCore::Element::scrollTo):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollTo const):
- page/FrameView.cpp:
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::cancelScheduledScrollToFocusedElement):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::setWasScrolledByUser):
- page/FrameView.h:
LayoutTests:
- fast/scrolling/programmatic-smooth-scroll-after-focus-expected.txt: Added.
- fast/scrolling/programmatic-smooth-scroll-after-focus.html: Added.
- platform/win/TestExpectations:
- 3:45 PM Changeset in webkit [293259] by
-
- 5 edits in branches/safari-613.2.7.0-branch/Source/WebKit
Apply patch. rdar://problem/88904160
- 3:45 PM Changeset in webkit [293258] by
-
- 18 edits in branches/safari-613.2.7.0-branch
Apply patch. rdar://problem/88904160
- 3:05 PM Changeset in webkit [293257] by
-
- 4 edits2 adds in branches/safari-613.2.7.0-branch
Cherry-pick r291724. rdar://problem/91975589
Expose the AX tree of PDFs loaded via iframes on the Mac
https://bugs.webkit.org/show_bug.cgi?id=238168
Reviewed by Chris Fleizach.
Source/WebKit:
Given this markup:
<iframe src="/path/to/paystub.pdf">
An accessibility tree is built for paystub.pdf, but we don't expose it
to AX clients, making the PDF entirely inaccessible.
This happens because we were setting the AX parent to be the webpage
for full-frame PDF plugins (which an iframe with this markup is).
This behavior is correct only for main-frame (i.e. not iframe)
full-frame plugins, so this patch adds an extra condition to that logic.
Test: accessibility/mac/iframe-pdf.html
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::PDFPlugin):
LayoutTests:
- accessibility/mac/iframe-pdf-expected.txt: Added.
- accessibility/mac/iframe-pdf.html: Added.
- platform/mac-wk1/TestExpectations: Skip new test as it always times out in WK1 (similar to accessibility/mac/basic-embed-pdf-accessibility.html)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:56 PM Changeset in webkit [293256] by
-
- 2 edits in branches/safari-613.2.7.0-branch/Source
Apply patch. rdar://problem/90968687
- 2:53 PM Changeset in webkit [293255] by
-
- 20 edits3 adds in branches/safari-613.2.7.0-branch
Cherry-pick r291589. rdar://problem/90511155
LayoutTests/imported/w3c:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
Import web-platform-tests test coverage.
- web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt: Added.
- web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html: Added.
- web-platform-tests/webmessaging/broadcastchannel/w3c-import.log:
Source/WebCore:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.
To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.
When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.
Test: imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- dom/BroadcastChannel.cpp: (WebCore::shouldPartitionOrigin): (WebCore::BroadcastChannel::MainThreadBridge::registerChannel): (WebCore::BroadcastChannel::MainThreadBridge::unregisterChannel): (WebCore::BroadcastChannel::MainThreadBridge::postMessage):
- dom/BroadcastChannelRegistry.h:
- loader/EmptyClients.cpp:
- page/PartitionedSecurityOrigin.h: Added. (WebCore::PartitionedSecurityOrigin::PartitionedSecurityOrigin): (WebCore::PartitionedSecurityOrigin::isHashTableDeletedValue const): (WebCore::PartitionedSecurityOrigin::isHashTableEmptyValue const): (WebCore::operator==): (WTF::add): (WTF::PartitionedSecurityOriginHash::hash): (WTF::PartitionedSecurityOriginHash::equal): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::emptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::constructEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::isEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::peek): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::take):
Source/WebKit:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.
To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.
When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.
- WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp: (WebKit::toClientOrigin): (WebKit::WebBroadcastChannelRegistry::registerChannel): (WebKit::WebBroadcastChannelRegistry::unregisterChannel): (WebKit::WebBroadcastChannelRegistry::postMessage): (WebKit::WebBroadcastChannelRegistry::postMessageLocally): (WebKit::WebBroadcastChannelRegistry::postMessageToRemote): (WebKit::WebBroadcastChannelRegistry::networkProcessCrashed):
- WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.h:
Source/WebKitLegacy:
Dust off Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=238121
Reviewed by Yusuke Suzuki.
- PlatformMac.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:24 PM Changeset in webkit [293254] by
-
- 2 edits1 copy in trunk/LayoutTests
REBASLINE: [ Monterey ] fast/text/khmer-lao-font.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=238917
Unreviewed test gardening.
- platform/mac-bigsur/fast/text/khmer-lao-font-expected.txt: Copied from LayoutTests/platform/mac/fast/text/khmer-lao-font-expected.txt.
- platform/mac/fast/text/khmer-lao-font-expected.txt:
Canonical link: https://commits.webkit.org/249903@main
- 2:08 PM Changeset in webkit [293253] by
-
- 2 edits in trunk
Add my github account name
https://bugs.webkit.org/show_bug.cgi?id=239671
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-22
Reviewed by Chris Dumez.
- metadata/contributors.json:
- 1:58 PM Changeset in webkit [293252] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC]Throw consistent exceptions for memory.init and memory.copy
https://bugs.webkit.org/show_bug.cgi?id=239592
Patch by Geza Lore <Geza Lore> on 2022-04-22
Reviewed by Yusuke Suzuki.
For a trapping Wasm memory.init and memory.copy instruction, the LLInt
used to throw OutOfBoundsMemoryAccess, but BBQ/OMG used to throw
OutOfBoundsTableAccess.
Changed BBQ/OMG to throw OutOfBoundsMemoryAccess as well.
- wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::addMemoryCopy):
(JSC::Wasm::AirIRGenerator::addMemoryInit):
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addMemoryInit):
(JSC::Wasm::B3IRGenerator::addMemoryCopy):
- 1:48 PM Changeset in webkit [293251] by
-
- 5 edits3 adds in trunk/Source/WebCore
[LFC][Integration] Add blank LayoutIntegration::FlexLayout
https://bugs.webkit.org/show_bug.cgi?id=239663
Reviewed by Antti Koivisto.
This is in preparation for adding flex formatting context integration.
- CMakeLists.txt:
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- layout/integration/flex/LayoutIntegrationFlexLayout.cpp: Added.
(WebCore::LayoutIntegration::FlexLayout::FlexLayout):
(WebCore::LayoutIntegration::FlexLayout::updateFormattingRootGeometryAndInvalidate):
(WebCore::LayoutIntegration::FlexLayout::updateFlexItemDimensions):
(WebCore::LayoutIntegration::FlexLayout::updateStyle):
(WebCore::LayoutIntegration::FlexLayout::computeIntrinsicWidthConstraints):
(WebCore::LayoutIntegration::FlexLayout::layout):
(WebCore::LayoutIntegration::FlexLayout::paint):
(WebCore::LayoutIntegration::FlexLayout::hitTest):
(WebCore::LayoutIntegration::FlexLayout::collectOverflow):
(WebCore::LayoutIntegration::FlexLayout::contentLogicalHeight const):
- layout/integration/flex/LayoutIntegrationFlexLayout.h: Added.
- 1:43 PM Changeset in webkit [293250] by
-
- 2 edits in branches/safari-613.2.7.1-branch/Source/WebCore
Cherry-pick r292878. rdar://problem/90248865
ScriptDisallowedScope::isEventAllowedInMainThread assert failure when activating AudioSession
https://bugs.webkit.org/show_bug.cgi?id=239343
Reviewed by Eric Carlson.
As part of HTMLMediaElement::clearMediaPlayer we call PlatformMediaSession::canProduceAudioChanged
which can result in activating the AudioSession when the page is capturing audio.
This sends a synchronous IPC message to the GPU process. As part of IPC::Connection::waitForSyncReply,
we also end up dispatching enqueued messages, including a WebPage_EndPrinting message that
fires an event listener on the main thread.
This patch will instead queue the PlatformMediaSession::canProduceAudioChanged as a task to avoid
firing the event listener on the main thread, which results in assertion failure.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::clearMediaPlayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:43 PM Changeset in webkit [293249] by
-
- 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore
Cherry-pick r292878. rdar://problem/90248865
ScriptDisallowedScope::isEventAllowedInMainThread assert failure when activating AudioSession
https://bugs.webkit.org/show_bug.cgi?id=239343
Reviewed by Eric Carlson.
As part of HTMLMediaElement::clearMediaPlayer we call PlatformMediaSession::canProduceAudioChanged
which can result in activating the AudioSession when the page is capturing audio.
This sends a synchronous IPC message to the GPU process. As part of IPC::Connection::waitForSyncReply,
we also end up dispatching enqueued messages, including a WebPage_EndPrinting message that
fires an event listener on the main thread.
This patch will instead queue the PlatformMediaSession::canProduceAudioChanged as a task to avoid
firing the event listener on the main thread, which results in assertion failure.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::clearMediaPlayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:39 PM Changeset in webkit [293248] by
-
- 6 edits in branches/safari-613.2.7.1-branch
Apply patch. rdar://problem/91446317
- 1:39 PM Changeset in webkit [293247] by
-
- 6 edits in branches/safari-613.2.7.1-branch
Revert "Cherry-pick r291606. rdar://problem/91446317"
This reverts commit r293072.
- 1:39 PM Changeset in webkit [293246] by
-
- 1 edit in branches/safari-613.2.7.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
Revert "Unreviewed build fix. rdar://91446317"
This reverts commit r293144.
- 1:35 PM Changeset in webkit [293245] by
-
- 6 edits in branches/safari-613.2.7.0-branch
Apply patch. rdar://problem/91446317
- 1:35 PM Changeset in webkit [293244] by
-
- 6 edits in branches/safari-613.2.7.0-branch
Revert "Cherry-pick r291606. rdar://problem/91446317"
This reverts commit r293072.
- 1:35 PM Changeset in webkit [293243] by
-
- 1 edit in branches/safari-613.2.7.0-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
Revert "Unreviewed build fix. rdar://91446317"
This reverts commit r293144.
- 1:18 PM Changeset in webkit [293242] by
-
- 2 edits in trunk
Unreviewed, add Geoff's github username to contributors.json so he can review patches
- metadata/contributors.json:
- 1:14 PM Changeset in webkit [293241] by
-
- 10 edits in branches/safari-613.2.7.1-branch
Apply patch. rdar://problem/91288849
- 1:14 PM Changeset in webkit [293240] by
-
- 10 edits in branches/safari-613.2.7.0-branch
Apply patch. rdar://problem/91288849
- 1:08 PM Changeset in webkit [293239] by
-
- 2 edits in branches/safari-613.2.7.1-branch
Apply patch. rdar://problem/91590827
- 1:08 PM Changeset in webkit [293238] by
-
- 2 edits in branches/safari-613.2.7.0-branch
Apply patch. rdar://problem/91590827
- 12:58 PM Changeset in webkit [293237] by
-
- 5 edits in trunk/Source
Modernize Text::replaceWholeText() https://bugs.webkit.org/show_bug.cgi?id=239637
Reviewed by Ryosuke Niwa.
Modernize Text::replaceWholeText():
- Drop unnecessary return value.
- Ref the Text node at call sites instead of using an internal protectedThis variable.
- Use node instead of n for variable name.
- Use modern template deduction for Ref / RefPtr.
- Source/WebKitLegacy/mac/DOM/DOMText.mm:
(-[DOMText replaceWholeText:]):
- Source/WebCore/dom/Text.cpp:
(WebCore::Text::replaceWholeText):
- Source/WebCore/dom/Text.h:
- Source/WebCore/html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::updateVisibleValue):
Canonical link: https://commits.webkit.org/249898@main
- 12:02 PM Changeset in webkit [293236] by
-
- 4 edits2 adds in branches/safari-613.2.7.1-branch
Cherry-pick r291724. rdar://problem/91975589
Expose the AX tree of PDFs loaded via iframes on the Mac
https://bugs.webkit.org/show_bug.cgi?id=238168
Reviewed by Chris Fleizach.
Source/WebKit:
Given this markup:
<iframe src="/path/to/paystub.pdf">
An accessibility tree is built for paystub.pdf, but we don't expose it
to AX clients, making the PDF entirely inaccessible.
This happens because we were setting the AX parent to be the webpage
for full-frame PDF plugins (which an iframe with this markup is).
This behavior is correct only for main-frame (i.e. not iframe)
full-frame plugins, so this patch adds an extra condition to that logic.
Test: accessibility/mac/iframe-pdf.html
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::PDFPlugin):
LayoutTests:
- accessibility/mac/iframe-pdf-expected.txt: Added.
- accessibility/mac/iframe-pdf.html: Added.
- platform/mac-wk1/TestExpectations: Skip new test as it always times out in WK1 (similar to accessibility/mac/basic-embed-pdf-accessibility.html)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:46 AM Changeset in webkit [293235] by
-
- 9 edits in branches/safari-613.2.7.1-branch/Source
Versioning.
WebKit-7613.2.7.1.1
- 11:46 AM Changeset in webkit [293234] by
-
- 9 edits in branches/safari-613.2.7.0-branch/Source
Versioning.
WebKit-7613.2.7.0.1
- 11:25 AM Changeset in webkit [293233] by
-
- 7 edits in trunk/Source
[LFC][Integration] Add FlexFormattingContextIntegrationEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=239654
Reviewed by Antti Koivisto.
Source/WebCore:
This is in preparation for supporting flex formatting context through integration.
- layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForFlexLayout):
- layout/integration/LayoutIntegrationCoverage.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):
- rendering/RenderFlexibleBox.h:
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml:
- 11:02 AM Changeset in webkit [293232] by
-
- 5 edits in trunk/Source/WebCore
Store StyleScope during CSSStyleSheet Creation
https://bugs.webkit.org/show_bug.cgi?id=239659
Reviewed by Antti Koivisto.
To ensure that we can always access the style scope, we shall ensure we store the style scope
at CSSStyleSheet creation time. It was possible before that a style sheet could become disconnected
and then a rule would later be mutated. This resulted in the unfortunate side effect of being unable to find
the style scope.
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::styleScope):
- css/CSSStyleSheet.h:
- style/StyleScope.cpp:
(WebCore::Style::Scope::collectResolverScopes):
- style/StyleScope.h:
- 10:46 AM Changeset in webkit [293231] by
-
- 12 edits in trunk
[iOS] Add find interaction API to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=239612
rdar://88442918
Reviewed by Alex Christensen.
Source/WebKit:
Promote the
_findInteractionand_findInteractionEnabledSPI to
findInteractionandfindInteractionEnabledAPI.
In order to make this change, new UIKit objects and protocols must be
adopted. Existing (deprecated) protocol conformance is kept around to
avoid breaking internal clients.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView findInteractionEnabled]):
(-[WKWebView setFindInteractionEnabled:]):
(-[WKWebView findInteraction]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Declare conformance to three protocols: _UITextSearching, UITextSearching, UIFindInteractionDelegate.
_UITextSearching: Conformance is kept around to avoid breaking internal clients.
UITextSearching: Conformance is declared for clients to migrate off of _UITextSearching.
UIFindInteractionDelegate: Conformance is necessary to begin a UIFindSession.
- UIProcess/API/ios/WKWebViewIOS.h:
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _didCommitLoadForMainFrame]):
The "searchable object" does not need to be reset anymore, as UIKit
will do that in-[WKWebView findInteraction:sessionForView:]the next
time a find session begins.
(-[WKWebView _searchableObject]):
(-[WKWebView _setFindInteractionEnabled:]):
(-[WKWebView _findInteraction]):
It is safe to cast between the SPI and API version of this object. UIKit
has guaranteed compatibility.
(-[WKWebView offsetFromPosition:toPosition:inDocument:]):
(-[WKWebView compareFoundRange:toRange:inDocument:]):
(-[WKWebView performTextSearchWithQueryString:usingOptions:resultAggregator:]):
(-[WKWebView replaceFoundTextInRange:inDocument:withText:]):
(-[WKWebView decorateFoundTextRange:inDocument:usingStyle:]):
(-[WKWebView scrollRangeToVisible:inDocument:]):
(-[WKWebView findInteraction:sessionForView:]):
(-[WKWebView findInteraction:didBeginFindSession:]):
Custom content views do not need to be aware that a find session has
begun, as they do not draw an overlay.
(-[WKWebView findInteraction:didEndFindSession:]):
Custom content views do not need to be aware that a find session has
begun, as they do not draw an overlay.
- UIProcess/ios/WKContentViewInteraction.h:
Declare the old _UITextSearching methods explicitly, as we need to
maintain support for internal clients.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView performTextSearchWithQueryString:usingOptions:resultAggregator:]):
(-[WKContentView replaceFoundTextInRange:inDocument:withText:]):
(-[WKContentView decorateFoundTextRange:inDocument:usingStyle:]):
(-[WKContentView scrollRangeToVisible:inDocument:]):
(-[WKContentView offsetFromPosition:toPosition:inDocument:]):
(-[WKContentView compareFoundRange:toRange:inDocument:]):
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView compareFoundRange:toRange:inDocument:]):
(-[WKPDFView performTextSearchWithQueryString:usingOptions:resultAggregator:]):
(-[WKPDFView decorateFoundTextRange:inDocument:usingStyle:]):
Tools:
Augment an existing API test to use the new API, in addition to the
existing SPI.
The find-and-replace test is updated to account for the fact that a
find interaction no longer exposes a searchableObject. Instead, use
test-only SPI on WKWebView to perform the replace.
- TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
(TEST):
- 10:28 AM Changeset in webkit [293230] by
-
- 9 edits in trunk
[iOS]
-selectWordForReplacementshould select dictation alternatives that span multiple words
https://bugs.webkit.org/show_bug.cgi?id=239622
rdar://91416535
Reviewed by Aditya Keerthi.
Source/WebKit:
Currently,
-selectWordForReplacement(which is invoked by UIKit when the tapping on spelling corrections and
dictation alternatives to reveal the callout bar with text suggestions) handles multi-word dictation ranges by
only selecting one of the words (i.e., whichever word is closest to the tapped location). This makes it
impossible to handle dictation ranges that span multiple words, since only part of the range is replaced with
the chosen alternative.
To address this, instead of using the existing
extendSelectionmethod (which is still exercised when tapping
the "Select" action in the callout bar with a caret selection), we addextendSelectionForReplacement, which
extends the selection to include any dictation alternative range that encompasses the selection (and otherwise
falls back to selecting the current word).
Test: SelectionTests.SelectWordForReplacementWithDictationAlternative
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView selectWordForReplacement]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::extendSelectionForReplacement):
Add a new IPC message,
WebPage::ExtendSelectionForReplacement, and use it to implement `-[WKContentView
selectWordForReplacement]`.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::extendSelectionForReplacement):
Add logic to select the enclosing dictation alternative marker range (if it exists), or the current word at the
start of the selection if there is no enclosing marker range. Note that we first grab a Vector of all the marker
ranges instead of creating them as we iterate through the list ofRenderedDocumentMarker*, since creating
visible position ranges from each marker range triggers layout, and eachRenderedDocumentMarker*is not
ref-counted, so it's possible that a reentrant call to update the document marker controller during layout could
destroy the nextRenderedDocumentMarker*during iteration.
(WebKit::WebPage::extendSelection):
(WebKit::WebPage::setSelectedRangeDispatchingSyntheticMouseEventsIfNeeded):
Pull out logic for dispatching synthetic mouse events when selecting text into a separate helper method, which
is now called from bothextendSelectionandextendSelectionForReplacement.
Tools:
Add an API test to exercise the change.
- TestWebKitAPI/Tests/ios/SelectionByWord.mm:
(TEST):
- 9:44 AM Changeset in webkit [293229] by
-
- 9 edits in branches/safari-614.1.10-branch/Source
Versioning.
WebKit-7614.1.10.6
- 9:36 AM Changeset in webkit [293228] by
-
- 3 edits in trunk/Source/WebCore/PAL
Adjust SPI headers to fix build with non-internal SDK
https://bugs.webkit.org/show_bug.cgi?id=239626
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-22
Reviewed by Chris Dumez.
- pal/spi/cocoa/PassKitSPI.h:
- pal/spi/mac/ScreenCaptureKitSPI.h:
- 9:33 AM Changeset in webkit [293227] by
-
- 1 copy in branches/safari-613.2.7.3-branch
New branch.
- 9:33 AM Changeset in webkit [293226] by
-
- 1 copy in branches/safari-613.2.7.2-branch
New branch.
- 9:33 AM Changeset in webkit [293225] by
-
- 1 copy in branches/safari-613.2.7.1-branch
New branch.
- 9:33 AM Changeset in webkit [293224] by
-
- 1 copy in branches/safari-613.2.7.0-branch
New branch.
- 9:11 AM Changeset in webkit [293223] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 arm64 ] imported/w3c/web-platform-tests/infrastructure/reftest-wait.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=230488
Unreviewed test gardening.
Updated text expectations in include Monterey wk2 arm64
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249892@main
- 8:57 AM Changeset in webkit [293222] by
-
- 4 edits in trunk/Source/WebCore
[LFC][Integration] BoxTree should be able to build non-inline content tree
https://bugs.webkit.org/show_bug.cgi?id=239653
Reviewed by Antti Koivisto.
This is in preparation for supporting non-IFC content (e.g. flex).
- layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::rootBoxFirstLineStyle):
(WebCore::LayoutIntegration::BoxTree::BoxTree):
(WebCore::LayoutIntegration::BoxTree::buildTreeForInlineContent):
(WebCore::LayoutIntegration::BoxTree::layoutBoxForRenderer):
(WebCore::LayoutIntegration::BoxTree::rendererForLayoutBox):
(WebCore::LayoutIntegration::BoxTree::buildTree): Deleted.
- layout/integration/LayoutIntegrationBoxTree.h:
(WebCore::LayoutIntegration::BoxTree::rootRenderer const):
(WebCore::LayoutIntegration::BoxTree::rootRenderer):
(WebCore::LayoutIntegration::BoxTree::flow const): Deleted.
(WebCore::LayoutIntegration::BoxTree::flow): Deleted.
- layout/integration/inline/LayoutIntegrationLineLayout.h:
(WebCore::LayoutIntegration::LineLayout::flow const):
(WebCore::LayoutIntegration::LineLayout::flow):
- 8:13 AM Changeset in webkit [293221] by
-
- 2 edits in trunk/LayoutTests
[ macOS Release arm64 ] imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html is a flakey text failure
https://bugs.webkit.org/show_bug.cgi?id=223472
Unreviewed test gardening.
Updated test expectation [ Release arm64 ]
- LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/249890@main
- 7:03 AM Changeset in webkit [293220] by
-
- 7 edits in trunk/Source
Apply purifyNaN in more places.
https://bugs.webkit.org/show_bug.cgi?id=239619
<rdar://problem/91924480>
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- wasm/js/JSWebAssemblyHelpers.h:
(JSC::toJSValue):
Source/WebCore:
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::toJS):
- bindings/js/JSDOMConvertWebGL.cpp:
(WebCore::convertToJSValue):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readTerminal):
- bridge/objc/objc_utility.mm:
(JSC::Bindings::convertObjcValueToValue):
- 6:29 AM Changeset in webkit [293219] by
-
- 9 edits in trunk
Fix for accessibility/aria-grid-with-aria-owns-rows.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=239498
<rdar://problem/91961398>
Reviewed by Chris Fleizach and Tyler Wilcock.
Source/WebCore:
Test: accessibility/aria-grid-with-aria-owns-rows.html.
When creating AXIsolatedObjects, we were passing the object ID of the
parent to the constructor in a parent to child traversal, and storing
that parent ID in the object. This assumed that all AX objects have a
parent-child reflexive relationship, i.e., if A is a child of B, B is
the parent of A. But that is not true in several cases in the
accessibility hierarchy.
One example where the parent-child relationship is not reflexive is for table cells, where a cell can be the child of an object with role column, but its parent is an object with role row.
Another case is when aria-owns is used.
This patch fixes the problem by letting the live object determine its
own parent, instead of having the traversal algorithm pass the parent ID
to the AXIsolatedObject constructor.
A previous attempt to fix this problem was made in
https://bugs.webkit.org/show_bug.cgi?id=236156.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::AXIsolatedObject):
(WebCore::AXIsolatedObject::create):
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::initializeAttributeData): Renamed.
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::create):
(WebCore::AXIsolatedTree::generateSubtree):
(WebCore::AXIsolatedTree::nodeChangeForObject):
(WebCore::AXIsolatedTree::queueRemovalsAndUnresolvedChanges):
(WebCore::AXIsolatedTree::collectNodeChangesForSubtree):
(WebCore::AXIsolatedTree::updateNode):
(WebCore::AXIsolatedTree::updateChildren):
(WebCore::AXIsolatedTree::parentIDForObject): Deleted.
- accessibility/isolatedtree/AXIsolatedTree.h:
- accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::initializePlatformProperties):
LayoutTests:
- accessibility/aria-grid-with-aria-owns-rows-expected.txt:
- accessibility/aria-grid-with-aria-owns-rows.html:
- 6:27 AM Changeset in webkit [293218] by
-
- 5 edits2 adds in trunk
Book content is clipped at page boundary when displaying list with bullet points
https://bugs.webkit.org/show_bug.cgi?id=239638
<rdar://89257768>
Reviewed by Antti Koivisto.
Source/WebCore:
Table cell content needs special handling when does not fit the page.
When a table cell's first line does not fit the page, instead of the normal, "let's add a flow level pagination strut"
we have to handle it as a line level strut (not sure why it is implemted this way but this is the expected behavior).
-also implment LineBoxIteratorModernPath::isFirstAfterPageBreak.
Test: fast/multicol/pagination/table-cell-one-line-pagination.html
- layout/integration/inline/InlineIteratorLineBoxModernPath.h:
(WebCore::InlineIterator::LineBoxIteratorModernPath::isFirstAfterPageBreak const):
- layout/integration/inline/LayoutIntegrationLine.h:
(WebCore::LayoutIntegration::Line::Line):
(WebCore::LayoutIntegration::Line::isFirstAfterPageBreak const):
- layout/integration/inline/LayoutIntegrationPagination.cpp:
(WebCore::LayoutIntegration::setPageBreakForLine): According to RenderBlockFlow::adjustLinePositionForPagination, we
have to call setPageBreak, even when the first line does not fit.
(WebCore::LayoutIntegration::makeAdjustedContent):
(WebCore::LayoutIntegration::adjustLinePositionsForPagination):
LayoutTests:
- fast/multicol/pagination/table-cell-one-line-pagination-expected.html: Added.
- fast/multicol/pagination/table-cell-one-line-pagination.html: Added.
- 5:02 AM Changeset in webkit [293217] by
-
- 4 edits in trunk/Source/WebCore
Bail out from text decoration computation if none is requested
https://bugs.webkit.org/show_bug.cgi?id=239641
Reviewed by Tim Nguyen.
- rendering/TextDecorationPainter.cpp:
(WebCore::collectStylesForRenderer):
Also avoid resolving colors unnecessarily.
(WebCore::TextDecorationPainter::stylesForRenderer):
- rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
- rendering/style/RenderStyleConstants.h:
Remove unused 'None' value.
- 4:40 AM Changeset in webkit [293216] by
-
- 5 edits in trunk/Source/WebCore
[MSE] Improve SourceBuffer memory cost reporting
https://bugs.webkit.org/show_bug.cgi?id=238948
Reviewed by Xabier Rodriguez-Calvar.
Properly implementing the memoryCost() API in SourceBuffer would improve memory
awareness when garbage collecting.
This patch extends the SourceBuffer interface with the ReportExtraMemoryCost
attribute, implements memoryCost() method for the interface and fixes
calculations for removed buffers. It distinguishes the amount of memory
increases reported (extraMemoryCostDelta, what was reported until now, can
only grow) from the total amount of memory reported (can grow and shrink).
This patch is co-authored by Andrzej Surdej (https://github.com/asurdej-comcast)
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/827
- Modules/mediasource/SourceBuffer.cpp: Implement memoryCost() interface and hold the absolute memory consumed as m_extraMemoryCost, keeping the original m_reportedExtraMemoryCost behaviour.
- Modules/mediasource/SourceBuffer.h: Added memoryCost() and m_extraMemoryCost.
- Modules/mediasource/SourceBuffer.idl: Require the ReportExtraMemoryCost feature.
- platform/graphics/SourceBufferPrivate.cpp: Also report the memory change to SourceBuffer when evicting frames (memory reduction).
- 4:08 AM Changeset in webkit [293215] by
-
- 2 edits in trunk/Source/WebKit
[GLib] Make WebKitSettings XSS auditor functions no-op
https://bugs.webkit.org/show_bug.cgi?id=239651
Reviewed by Adrian Perez de Castro.
With the XSS auditor feature being deprecated and removed, and the
preference entries removed in r293199, the GLib API for this feature
has to be adjusted as well. In both getter and setter, a warning is
printed out when invoked.
- UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_get_enable_xss_auditor):
(webkit_settings_set_enable_xss_auditor):
- 12:25 AM Changeset in webkit [293214] by
-
- 1 copy in releases/WPE WebKit/webkit-2.36.1
WPE WebKit 2.36.1
- 12:22 AM Changeset in webkit [293213] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.36.1 release
.:
- Source/cmake/OptionsWPE.cmake: Bump version numbers.
Source/WebKit:
- wpe/NEWS: Add release notes for 2.36.1.
- 12:02 AM Changeset in webkit [293212] by
-
- 5 edits in trunk
AX: The isolated tree is not updated after role changes in AccessibilityRenderObject::updateRoleAfterChildrenCreation()
https://bugs.webkit.org/show_bug.cgi?id=239549
Reviewed by Chris Fleizach and Andres Gonzalez.
Source/WebCore:
In AccessibilityRenderObject::updateRoleAfterChildrenCreation(), if the objects role changes,
we need to inform the cache via AXObjectCache::handleRoleChange which in turn will
update the isolated tree.
Fixes accessibility/mac/invalid-menu-role-does-not-send-notification.html in isolated tree mode.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation):
LayoutTests:
- accessibility/mac/invalid-menu-role-does-not-send-notification-expected.txt:
- accessibility/mac/invalid-menu-role-does-not-send-notification.html:
Update test to use async-await to actually wait for changes to happen,
which is required to make the test pass in isolated tree mode.
Apr 21, 2022:
- 11:08 PM Changeset in webkit [293211] by
-
- 21 edits1 add in trunk
Use GCGLSpanTuple to pass buffer parameters to multidraw calls.
https://bugs.webkit.org/show_bug.cgi?id=239154
Patch by John Cunningham <johncunningham@apple.com> on 2022-04-21
Reviewed by Kimmo Kinnunen.
Source/WebCore:
- html/canvas/WebGLMultiDraw.cpp:
(WebCore::WebGLMultiDraw::multiDrawArraysWEBGL):
(WebCore::WebGLMultiDraw::multiDrawArraysInstancedWEBGL):
(WebCore::WebGLMultiDraw::multiDrawElementsWEBGL):
(WebCore::WebGLMultiDraw::multiDrawElementsInstancedWEBGL):
(WebCore::makeSpanWithOffset): Deleted.
- platform/graphics/GraphicsContextGL.h:
- platform/graphics/GraphicsTypesGL.h:
- platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::multiDrawArraysANGLE):
(WebCore::GraphicsContextGLANGLE::multiDrawArraysInstancedANGLE):
(WebCore::GraphicsContextGLANGLE::multiDrawElementsANGLE):
(WebCore::GraphicsContextGLANGLE::multiDrawElementsInstancedANGLE):
- platform/graphics/angle/GraphicsContextGLANGLE.h:
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
Source/WebKit:
- GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::WebCore::vectorCopyCast):
(WebKit::RemoteGraphicsContextGL::multiDrawArraysANGLE):
(WebKit::RemoteGraphicsContextGL::multiDrawArraysInstancedANGLE):
(WebKit::RemoteGraphicsContextGL::multiDrawElementsANGLE):
(WebKit::RemoteGraphicsContextGL::multiDrawElementsInstancedANGLE):
- GPUProcess/graphics/RemoteGraphicsContextGL.h:
- GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
- GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:
(getInternalformativ):
(multiDrawArraysANGLE): Deleted.
(multiDrawArraysInstancedANGLE): Deleted.
(multiDrawElementsANGLE): Deleted.
(multiDrawElementsInstancedANGLE): Deleted.
- Platform/IPC/ArgumentCoders.h:
- Platform/IPC/ArrayReferenceTuple.h: Added.
- Scripts/webkit/messages.py:
(class_template_headers):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::multiDrawArraysANGLE):
(WebKit::RemoteGraphicsContextGLProxy::multiDrawArraysInstancedANGLE):
(WebKit::RemoteGraphicsContextGLProxy::multiDrawElementsANGLE):
(WebKit::RemoteGraphicsContextGLProxy::multiDrawElementsInstancedANGLE):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
(WebKit::RemoteGraphicsContextGLProxy::multiDrawArraysANGLE): Deleted.
(WebKit::RemoteGraphicsContextGLProxy::multiDrawArraysInstancedANGLE): Deleted.
(WebKit::RemoteGraphicsContextGLProxy::multiDrawElementsANGLE): Deleted.
(WebKit::RemoteGraphicsContextGLProxy::multiDrawElementsInstancedANGLE): Deleted.
Tools:
- Scripts/generate-gpup-webgl:
- 10:41 PM Changeset in webkit [293210] by
-
- 27 edits2 adds in trunk
[JSC] PropertyTable should have compact mode
https://bugs.webkit.org/show_bug.cgi?id=239451
Reviewed by Saam Barati.
This patch introduces "compact" version of PropertyTable. PropertyTable needs to hold two kind of integers: index and property offset.
But for most of objects, both are pretty small and they can fit in uint8_t. If we can use uint8_t for both, we can significantly reduce
size of allocated memory for PropertyTable (only 40% of memory is required!). This is good for memory, but also good for performance.
Now each CompactPropertyTableEntry is 8bytes while original PropertyMapEntry was 16bytes, so CompactPropertyTableEntry can fit in CPU cache well.
Also, not allocating large amount of memory can reduce memory allocation / deallocation cost. One of costly destruction of GC-managed objects is
PropertyTable (and CodeBlock), and we can reduce that cost by not allocating much memory.
The approach is following.
- For index vector, we use uint8_t if index can fit within uint8_t.
- For proprety offset, we use uint8_t and CompactPropertyTableEntry if it is suitable.
- Once the table gets non-compact, we keep it non-compact since we could have deleted index which has larger than uint8_t. We could improve this strategy when deleted indexes are cleared, but for now, we are taking simple approach.
- We store isCompactFlag 1 bit in the pointer to the table.
- We encapsulate functions modifying property table entry in PropertyTable itself, so we do not leak internal compact / non-compact mode to the user of PropertyTable. We remove begin() / end() iterators and instead use forEachproperty, which can implement iteration for each mode more efficiently.
We have a further opportunity to improve this further: we can deploy 75% load factor only for compact table. Then we can increase threshold of
compact table further and keep more and more tables compact mode. Plus, for small sized tables, small backing memory is better in terms of
CPU cache hit (and that's measured in WTF::HashTable, and that's why WTF::Hashtable deploys 75% load factor only for small tables). This is left
for the subsequent change.
This change is neutral in JetStream2, 0.3% improvement in Speedometer2 with 80% confidence, and 0.41% improvement in RAMification with 95% confidence.
- JSTests/stress/change-attribute-structure-transition.js:
(shouldBe.JSON.stringify.sd):
- Source/JavaScriptCore/bytecode/ObjectAllocationProfileInlines.h:
(JSC::ObjectAllocationProfileBase<Derived>::initializeProfile):
- Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
- Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
- Source/JavaScriptCore/ftl/FTLOperations.cpp:
(JSC::FTL::JSC_DEFINE_JIT_OPERATION):
- Source/JavaScriptCore/runtime/ClonedArguments.h:
- Source/JavaScriptCore/runtime/IteratorOperations.cpp:
(JSC::createIteratorResultObjectStructure):
- Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- Source/JavaScriptCore/runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
- Source/JavaScriptCore/runtime/JSObject.cpp:
(JSC::JSObject::analyzeHeap):
- Source/JavaScriptCore/runtime/JSObject.h:
- Source/JavaScriptCore/runtime/ObjectConstructor.h:
(JSC::constructEmptyObject):
(JSC::createDataPropertyDescriptorObjectStructure):
(JSC::createAccessorPropertyDescriptorObjectStructure):
- Source/JavaScriptCore/runtime/ObjectConstructorInlines.h:
(JSC::objectAssignFast):
- Source/JavaScriptCore/runtime/PropertyOffset.h:
- Source/JavaScriptCore/runtime/PropertySlot.h:
- Source/JavaScriptCore/runtime/PropertyTable.cpp:
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::finishCreation):
(JSC::PropertyTable::visitChildrenImpl):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::seal):
(JSC::PropertyTable::freeze):
(JSC::PropertyTable::isSealed const):
(JSC::PropertyTable::isFrozen const):
(JSC::PropertyTable::renumberPropertyOffsets):
- Source/JavaScriptCore/runtime/PropertyTable.h:
(JSC::isPowerOf2):
(JSC::nextPowerOf2):
(JSC::PropertyTable::findImpl):
(JSC::PropertyTable::find):
(JSC::PropertyTable::get):
(JSC::PropertyTable::add):
(JSC::PropertyTable::remove):
(JSC::PropertyTable::take):
(JSC::PropertyTable::updateAttributeIfExists):
(JSC::PropertyTable::sizeInMemory):
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):
(JSC::PropertyTable::skipDeletedEntries):
(JSC::PropertyTable::dataSize):
(JSC::PropertyTable::canInsert):
(JSC::PropertyTable::forEachProperty const):
(JSC::PropertyTable::forEachPropertyMutable):
(JSC::PropertyTable::begin): Deleted.
(JSC::PropertyTable::end): Deleted.
(JSC::PropertyTable::begin const): Deleted.
(JSC::PropertyTable::end const): Deleted.
(JSC::PropertyTable::table): Deleted.
(JSC::PropertyTable::table const): Deleted.
- Source/JavaScriptCore/runtime/RegExpMatchesArray.h:
- Source/JavaScriptCore/runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyTable):
(JSC::Structure::nonPropertyTransitionSlow):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::PropertyTableStatisticsExitLogger::~PropertyTableStatisticsExitLogger):
(JSC::Structure::getConcurrently):
(JSC::Structure::getPropertiesConcurrently):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::toStructureShape):
(JSC::Structure::dump const):
- Source/JavaScriptCore/runtime/Structure.h:
(JSC::CompactPropertyTableEntry::CompactPropertyTableEntry):
(JSC::CompactPropertyTableEntry::key const):
(JSC::CompactPropertyTableEntry::setKey):
(JSC::CompactPropertyTableEntry::offset const):
(JSC::CompactPropertyTableEntry::setOffset):
(JSC::CompactPropertyTableEntry::attributes const):
(JSC::CompactPropertyTableEntry::setAttributes):
(JSC::PropertyTableEntry::PropertyTableEntry):
(JSC::PropertyTableEntry::key const):
(JSC::PropertyTableEntry::setKey):
(JSC::PropertyTableEntry::offset const):
(JSC::PropertyTableEntry::setOffset):
(JSC::PropertyTableEntry::attributes const):
(JSC::PropertyTableEntry::setAttributes):
(JSC::PropertyMapEntry::PropertyMapEntry): Deleted.
- Source/JavaScriptCore/runtime/StructureInlines.h:
(JSC::Structure::get):
(JSC::Structure::forEachPropertyConcurrently):
(JSC::Structure::forEachProperty):
(JSC::Structure::add):
(JSC::Structure::remove):
(JSC::Structure::attributeChange):
Canonical link: https://commits.webkit.org/249881@main
- 10:35 PM Changeset in webkit [293209] by
-
- 4 edits4 adds in trunk
contain: layouton the html element should change position:fixed behavior
https://bugs.webkit.org/show_bug.cgi?id=238560
Patch by Rob Buis <rbuis@igalia.com> on 2022-04-21
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/contain-layout-021-expected.html: Added.
- web-platform-tests/css/css-contain/contain-layout-021.html: Added.
- web-platform-tests/css/css-contain/reference/contain-layout-021-ref.html: Added.
Source/WebCore:
The mapLocalToContainer/mapAbsoluteToLocalPoint methods need to not only consider boxes
having transforms but need to include all checks in canContainFixedPositionObjects to
determine if the box acts as a fixed position containing block.
Tests: imported/w3c/web-platform-tests/css/css-contain/contain-layout-021.html
imported/w3c/web-platform-tests/css/css-contain/reference/contain-layout-021-ref.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer const):
(WebCore::RenderBox::mapAbsoluteToLocalPoint const):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::mapLocalToContainer const):
- 10:21 PM Changeset in webkit [293208] by
-
- 5 edits2 adds in trunk
No-op, instead of throwing, on dataTransfer.items.remove()
https://bugs.webkit.org/show_bug.cgi?id=239618
Reviewed by Wenson Hsieh.
LayoutTests/imported/w3c:
Import test coverage from upstream WPT.
- web-platform-tests/html/editing/dnd/datastore/datatransferitemlist-remove-expected.txt: Added.
- web-platform-tests/html/editing/dnd/datastore/datatransferitemlist-remove.html: Added.
Source/WebCore:
Calling dataTransfer.items.remove() with an out-of-range index should be a no-op instead of
throwing as per the latest HTML specification:
We were the only browser behaving this way so this was a compatibility risk.
Test: imported/w3c/web-platform-tests/html/editing/dnd/datastore/datatransferitemlist-remove.html
- dom/DataTransferItemList.cpp:
(WebCore::DataTransferItemList::remove):
- 8:56 PM Changeset in webkit [293207] by
-
- 2 edits in trunk/Tools
[PGO] Fix perl warnings cause by PGO for real this time.
https://bugs.webkit.org/show_bug.cgi?id=239633
Reviewed by Yusuke Suzuki.
Add a missing 'defined' check before reading the PGO environment variable.
- Tools/Scripts/check-for-weak-vtables-and-externals:
Canonical link: https://commits.webkit.org/249878@main
- 8:27 PM Changeset in webkit [293206] by
-
- 9 edits in trunk/LayoutTests
AX ITM: Fix for multiple flaky tests in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=239583
<rdar://problem/92064483>
Reviewed by Chris Fleizach.
Rewrote these flaky tests so that now pass in isolated tree mode:
- Use expect() instead of shouldBe*() and log the output at the end of
the test.
- Avoid setting focus to an element just to get the accessible element.
- accessibility/legend-children-are-visible-expected.txt:
- accessibility/legend-children-are-visible.html:
- accessibility/mac/aria-label-overrides-visible-text-expected.txt:
- accessibility/mac/aria-label-overrides-visible-text.html:
- accessibility/mac/aria-popup-buttons-on-native-elements-expected.txt:
- accessibility/mac/aria-popup-buttons-on-native-elements.html:
- accessibility/mac/link-with-title-expected.txt:
- accessibility/mac/link-with-title.html:
- 7:48 PM Changeset in webkit [293205] by
-
- 4 edits in trunk/Source/WebKitLegacy/win
Unreviewed build fix after r293199.
https://bugs.webkit.org/show_bug.cgi?id=239628
Remove unused references to XSS Auditor.
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::isXSSAuditorEnabled):
(WebPreferences::setXSSAuditorEnabled):
- WebView.cpp:
(WebView::notifyPreferencesChanged):
- 6:21 PM Changeset in webkit [293204] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 arm64 ] media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239634
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249875@main
- 5:51 PM Changeset in webkit [293203] by
-
- 12 edits2 deletes in trunk/Source/JavaScriptCore
[JSC] Remove TempRegisterSet
https://bugs.webkit.org/show_bug.cgi?id=239578
Reviewed by Mark Lam.
We can always use RegisterSet. TempRegisterSet can save several bytes, but we have no code using TempRegisterSet in
heap-allocated classes. So, this does not make sense anymore. Instead of TempRegisterSet, we will consistently use
RegisterSet to pass register info and ScratchRegisterAllocator to manage allocation of temp / scratch registers.
We also remove the copyCalleeSavesToEntryFrameCalleeSavesBuffer function which takes no scratch register. It was
using TempRegisterSet to allocate a scratch register, but the caller of this function was making assumptions on how
TempRegisterSet will allocate that scratch. This is very fragile and dangerous. We should explicitly pass a scratch
register instead in that case.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::copyLLIntBaselineCalleeSavesFromFrameOrRegisterToEntryFrameCalleeSavesBuffer):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::copyLLIntBaselineCalleeSavesFromFrameOrRegisterToEntryFrameCalleeSavesBuffer): Deleted.
- jit/RegisterSet.h:
- jit/ScratchRegisterAllocator.cpp:
(JSC::ScratchRegisterAllocator::lock):
(JSC::ScratchRegisterAllocator::allocateScratch):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
- jit/ScratchRegisterAllocator.h:
- jit/TempRegisterSet.cpp: Removed.
- jit/TempRegisterSet.h: Removed.
- jit/ThunkGenerators.cpp:
(JSC::handleExceptionGenerator):
(JSC::handleExceptionWithCallFrameRollbackGenerator):
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::nativeForGenerator):
(JSC::boundFunctionCallGenerator):
(JSC::remoteFunctionCallGenerator):
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):
- 5:17 PM Changeset in webkit [293202] by
-
- 24 edits in trunk
[WTF] Add string concatenate adapter for UUID
https://bugs.webkit.org/show_bug.cgi?id=239590
Reviewed by Chris Dumez and Darin Adler.
This patch adds string concatenate adapter for UUID.
UUID's stringifier consists of multiple string concatenate adapters.
This patch adds WTF::handleWithAdapters so that we can define adapters
once, and we can semi-automatically define length() and writeTo method for UUID.
And we use UUID + makeString instead of createVersion4UUIDString. This is more
efficient since we do not need to allocate string twice.
- Source/WTF/wtf/UUID.cpp:
(WTF::UUID::generateWeakRandomUUIDVersion4):
(WTF::createVersion4UUIDString):
(WTF::generateWeakRandomUUIDVersion4): Deleted.
(WTF::UUID::toString const): Deleted.
(WTF::createVersion4UUIDStringWeak): Deleted.
- Source/WTF/wtf/UUID.h:
(WTF::UUID::createVersion4Weak):
(WTF::UUID::isHashTableDeletedValue const):
(WTF::UUID::data const):
(WTF::StringTypeAdapter<UUID>::StringTypeAdapter):
(WTF::StringTypeAdapter<UUID>::length const):
(WTF::StringTypeAdapter<UUID>::is8Bit const):
(WTF::StringTypeAdapter<UUID>::writeTo const):
- Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::updateBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes):
- Tools/TestWebKitAPI/Tests/WTF/UUID.cpp:
(TEST):
Canonical link: https://commits.webkit.org/249873@main
- 5:09 PM Changeset in webkit [293201] by
-
- 1 copy in tags/WebKit-7613.2.7
Tag WebKit-7613.2.7.
- 5:09 PM Changeset in webkit [293200] by
-
- 1 delete in tags/WebKit-7613.2.7
Delete tag.
- 5:05 PM Changeset in webkit [293199] by
-
- 4 edits in trunk/Source
Remove XSS Auditor: Part 4 (Settings)
https://bugs.webkit.org/show_bug.cgi?id=239628
Reviewed by Alex Christensen.
This change is a follow-up to Bug 230661 that removes the unused
Source/WebKitLegacy/mac:
WebKitXSSAuditorEnabledPreferenceKey.
- WebView/WebPreferenceKeysPrivate.h:
Source/WTF:
WebPreferences.yaml content.
- Scripts/Preferences/WebPreferences.yaml:
- 5:02 PM Changeset in webkit [293198] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r292095. rdar://problem/90240658
Ensure m_layerRulesBeforeImportRules is properly copied during StyleSheetContents instantiation
https://bugs.webkit.org/show_bug.cgi?id=238537
Reviewed by Antti Koivisto.
During the instantiation of the StyleSheetContents the m_layerRulesBeforeImportRules was not being
properly copied.
- css/StyleSheetContents.cpp: (WebCore::StyleSheetContents::StyleSheetContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:01 PM Changeset in webkit [293197] by
-
- 4 edits in trunk/Source/WebCore
Simplify FrameSelection::textWasReplaced() and callers
https://bugs.webkit.org/show_bug.cgi?id=239620
Reviewed by Geoffrey Garen.
- dom/CharacterData.cpp:
(WebCore::CharacterData::setData):
- Cache document().frame()
- Call textWasReplaced() with *this instead of this
- Use modern template deduction for Ref<>.
(WebCore::CharacterData::setDataAndUpdate):
- Use WTFMove() for m_data to avoid ref-counting churn. We're about to overwrite m_data anyway.
- Use
else iffor the ProcessingInstruction branch instead ofifto avoid this check in the common case where |this| is a Text node. A Text node cannot be a ProcessingInstruction node. - Cache document().frame()
- Call textWasReplaced() with *this instead of this
- editing/FrameSelection.cpp:
(WebCore::updatePositionAfterAdoptingTextReplacement):
- Pass node by reference now that the caller now has a reference instead of a pointer
- Drop !position.anchorNode() check. It is not necessary as the position.anchorNode() != &node check would already be true if the anchorNode were null.
(WebCore::FrameSelection::textWasReplaced):
- Drop outdated comment about a fragment check since there is no such check anymore
- Pass node by reference instead of pointer as all call sites have a non-null pointer
- Drop null check for node that is no longer necessary
- editing/FrameSelection.h:
- 4:55 PM Changeset in webkit [293196] by
-
- 1 copy in tags/WebKit-7613.2.7
Tag WebKit-7613.2.7.
- 4:27 PM Changeset in webkit [293195] by
-
- 85 edits in trunk/Source
Adopt RobinHoodHashMap / RobinHoodHashSet more broadly in WebCore
https://bugs.webkit.org/show_bug.cgi?id=239576
Reviewed by Yusuke Suzuki.
Source/WebCore:
Adopt RobinHoodHashMap / RobinHoodHashSet more broadly in WebCore to avoid wasting memory in hash tables.
RobinHoodHashMap / RobinHoodHashSet have more restrictions on what key types they work with and may result
in slightly lower performance but they have a much higher load factor that the regular HashMap / HashSet,
thus reducing memory usage. This patch adopts RobinHoodHashMap / RobinHoodHashSet on non performance
sensitive maps / sets in WebCore that have compatible keys (String / AtomString / URL because they cache
their hash).
This is perf-neutral on all our benchmarks according to A/B testing.
- Modules/encryptedmedia/InitDataRegistry.h:
- Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h:
- Modules/indexeddb/server/SQLiteIDBTransaction.h:
- Modules/mediasource/MediaSourceRegistry.h:
- Modules/mediastream/MediaDevices.h:
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
- Modules/web-locks/WebLockRegistry.cpp:
- Modules/webaudio/AudioWorkletGlobalScope.h:
- Modules/webaudio/AudioWorkletNode.h:
- Modules/webaudio/AudioWorkletProcessor.cpp:
(WebCore::constructFrozenKeyValueObject):
(WebCore::copyDataFromParameterMapToJSObject):
(WebCore::AudioWorkletProcessor::buildJSArguments):
(WebCore::AudioWorkletProcessor::process):
- Modules/webaudio/AudioWorkletProcessor.h:
- Modules/webaudio/BaseAudioContext.h:
(WebCore::BaseAudioContext::parameterDescriptorMap const):
- Modules/webdatabase/Database.cpp:
(WebCore::WTF_REQUIRES_LOCK):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::recordDeletingDatabase):
- Modules/webdatabase/DatabaseTracker.h:
- bindings/js/JSCustomElementInterface.h:
- bindings/js/ScriptModuleLoader.h:
- dom/CustomElementRegistry.h:
(WebCore::CustomElementRegistry::promiseMap):
- dom/ExtensionStyleSheets.h:
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::observe):
- dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::resetObservation):
- dom/MutationObserverRegistration.h:
- dom/Node.cpp:
(WebCore::Node::registerMutationObserver):
- dom/Node.h:
- dom/WindowEventLoop.cpp:
- editing/Editor.h:
- inspector/InspectorAuditResourcesObject.h:
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::clear):
- inspector/NetworkResourcesData.h:
- inspector/agents/InspectorAnimationAgent.h:
- inspector/agents/InspectorCanvasAgent.h:
- inspector/agents/InspectorDOMDebuggerAgent.h:
- inspector/agents/InspectorDatabaseAgent.h:
- inspector/agents/InspectorNetworkAgent.h:
- inspector/agents/InspectorPageAgent.h:
- inspector/agents/InspectorWorkerAgent.h:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setActiveContentRuleListActionPatterns):
- loader/DocumentLoader.h:
- loader/cache/CachedResourceLoader.h:
- page/Page.h:
- page/PageConfiguration.h:
- page/csp/ContentSecurityPolicyMediaListDirective.h:
- page/csp/ContentSecurityPolicySourceList.h:
- platform/LegacySchemeRegistry.cpp:
(WebCore::WTF_REQUIRES_LOCK):
- platform/StaticPasteboard.h:
- platform/graphics/SourceBufferPrivate.h:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::updateTracksOfKind):
- platform/graphics/cg/UTIRegistry.cpp:
(WebCore::additionalSupportedImageTypes):
- platform/graphics/cg/UTIRegistry.h:
- platform/graphics/cocoa/FontCacheCoreText.cpp:
- platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::genericFamily):
- platform/graphics/cocoa/SystemFontDatabaseCoreText.h:
- platform/mac/ThreadCheck.mm:
(WebCoreReportThreadViolation):
- platform/mediastream/MediaStreamPrivate.h:
- platform/network/BlobRegistryImpl.h:
- platform/network/CredentialStorage.h:
- platform/network/NetworkStorageSession.h:
- rendering/ReferencedSVGResources.h:
- svg/SVGDocumentExtensions.h:
- workers/Worker.h:
- workers/WorkerGlobalScope.h:
- workers/service/ServiceWorkerContextData.h:
(WebCore::ServiceWorkerContextData::decode):
- workers/service/server/RegistrationDatabase.cpp:
(WebCore::stripScriptSources):
(WebCore::populateScriptSourcesFromDisk):
(WebCore::RegistrationDatabase::doPushChanges):
(WebCore::RegistrationDatabase::importRecords):
- workers/service/server/RegistrationStore.cpp:
(WebCore::RegistrationStore::didSaveWorkerScriptsToDisk):
- workers/service/server/RegistrationStore.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::didSaveWorkerScriptsToDisk):
(WebCore::SWServer::updateWorker):
(WebCore::SWServer::installContextData):
- workers/service/server/SWServer.h:
- workers/service/server/SWServerToContextConnection.h:
- workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::SWServerWorker):
(WebCore::SWServerWorker::didSaveScriptsToDisk):
- workers/service/server/SWServerWorker.h:
Source/WebKit:
Adopt RobinHoodHashMap / RobinHoodHashSet more broadly in WebKit to avoid wasting memory in hash tables.
RobinHoodHashMap / RobinHoodHashSet have more restrictions on what key types they work with and may result
in slightly lower performance but they have a much higher load factor that the regular HashMap / HashSet,
thus reducing memory usage. This patch adopts RobinHoodHashMap / RobinHoodHashSet on non performance
sensitive maps / sets in WebCore that have compatible keys (String / AtomString / URL because they cache
their hash).
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::didSaveScriptsToDisk):
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::allowedNetworkHosts const):
(API::PageConfiguration::setAllowedNetworkHosts):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _setLoadsFromNetwork:]):
(-[WKWebViewConfiguration _setAllowedNetworkHosts:]):
Source/WTF:
Allow using RobinHoodHashMap / RobinHoodHashSet with URL keys since a URL wraps a String
and uses its internal String's cached hash as hash.
- wtf/URLHash.h:
- 4:11 PM Changeset in webkit [293194] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 arm64 ] fast/scrolling/mac/adjust-scroll-snap-during-gesture.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239627
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249869@main
- 3:56 PM Changeset in webkit [293193] by
-
- 2 edits in trunk/LayoutTests
[ iOS 15.4 ] imported/w3c/web-platform-tests/css/css-color/opacity-overlapping-letters.html is failing
https://bugs.webkit.org/show_bug.cgi?id=239625
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/249868@main
- 3:31 PM Changeset in webkit [293192] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 arm64 ] REGRESSION (r242313): Layout Test scrollingcoordinator/mac/multiple-fixed.html is a flaky time out and image diff
https://bugs.webkit.org/show_bug.cgi?id=195635
Unreviewed test gardening.
Adding new test expectation.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249867@main
- 3:07 PM Changeset in webkit [293191] by
-
- 2 edits in trunk/Source/WebKit
Build is broken on shipping macOS due to TBA annotations replacement in API headers
https://bugs.webkit.org/show_bug.cgi?id=239623
Unreviewed, bump versions in WebKit.xcconfig too to disable TBA annotation replacement on shipping OS
so that we don't get warnings about API not yet being available.
- Configurations/WebKit.xcconfig:
- 3:07 PM Changeset in webkit [293190] by
-
- 1 copy in tags/WebKit-7614.1.10.5
Tag WebKit-7614.1.10.5.
- 2:46 PM Changeset in webkit [293189] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Elements: Layout: hovering over a node should highlight it in the page
https://bugs.webkit.org/show_bug.cgi?id=239621
Reviewed by Patrick Angle.
- UserInterface/Views/NodeOverlayListSection.js:
(WI.NodeOverlayListSection.prototype.layout):
Use the existingWI.linkifyNodeReferenceto create the UI for theWI.DOMNode.
- UserInterface/Base/DOMUtilities.js:
(WI.linkifyNodeReferenceElement):
Don't style the UI as a link if clicking it doesn't do anything.
- 2:03 PM Changeset in webkit [293188] by
-
- 4 edits in trunk
<body> with overflow:hidden CSS is scrollable on iOS standalone web app
https://bugs.webkit.org/show_bug.cgi?id=220908
<rdar://73574797>
Reviewed by Devin Rousso.
Source/WebKit:
overflow:hiddenfailed to make the primary scroll view unscrollable in a home screen web
app because of logic in _updateScrollViewForTransaction: that was intended to ensure that if
the current unobscured rect is equal to the max unobscured rect (i.e. testing for collapsed
UI in MobileSafari), the user could scroll to expand the UI.
This failed in Web.app because there is no collapsible UI there, i.e.
minUnobscuredSize == maxUnobscuredSize. So test for that scenario.
Tested by new API tests.
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _updateScrollViewForTransaction:]):
Tools:
New API tests for various configurations of insets and size overrides.
- TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
(TestWebKitAPI::TEST):
- 1:57 PM Changeset in webkit [293187] by
-
- 10 edits in trunk/Tools
[git-webkit] Allow caller to specify remote for PR
https://bugs.webkit.org/show_bug.cgi?id=239452
<rdar://problem/91897384>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
(Git.init): Allow caller to define remotes.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.parser): Add '--remote' option.
(PullRequest.main): Allow options to specify the remote we're making a PR against.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py:
(Revert.add_comment_to_reverted_commit_bug_tracker): Derive remote from argument.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.PRGenerator.find): Support finding PRs if label doesn't contain username.
(GitHub.PRGenerator.create): Error 422 is a validation error, usually caused by another PR pointing to the same branch.
(GitHub.PRGenerator.update): Extract error message for more actionable errors.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/clean_unittest.py:
(TestClean.test_clean_pr): Add fork remote.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py:
Canonical link: https://commits.webkit.org/249863@main
- 1:51 PM Changeset in webkit [293186] by
-
- 2 edits in trunk/Source/WebCore
Only AXIsolatedTree::update{Children,Node} once when processing notifications in AXObjectCache::updateIsolatedTree
https://bugs.webkit.org/show_bug.cgi?id=239499
Reviewed by Andres Gonzalez.
Currently, we do try to prevent performing duplicate updates, but we do so only
if we have an exact match for a previous notification for any given object.
However, multiple notifications trigger AXIsolatedTree::updateNode and children,
so we'll still duplicate work if we get multiple notifications in the same group.
For example, before this patch, if the same object got both an AXValueChanged and
AXTextChanged notification, we'd call AXIsolatedTree::updateNode twice.
With this patch, we instead keep track of whether or not we've
performed a node or children update for each object to prevent
duplicate work.
No new tests because there is no behavior change.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateIsolatedTree):
(WebCore::appendIfNotContainsMatching): Deleted.
- 1:48 PM Changeset in webkit [293185] by
-
- 9 edits in branches/safari-614.1.10-branch/Source
Versioning.
WebKit-7614.1.10.5
- 1:40 PM Changeset in webkit [293184] by
-
- 1 copy in tags/WebKit-7614.1.10.4
Tag WebKit-7614.1.10.4.
- 1:33 PM Changeset in webkit [293183] by
-
- 2 edits in trunk/LayoutTests
Implement ElementInternals
https://bugs.webkit.org/show_bug.cgi?id=197960
Unreviewed test gardening.
- LayoutTests/platform/ipad/TestExpectations:
Canonical link: https://commits.webkit.org/249861@main
- 1:11 PM Changeset in webkit [293182] by
-
- 1 edit in branches/safari-613-branch/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
Unreviewed build fix. rdar://91584856
WebPageProxyIOS.mm:572:31: error: use of undeclared identifier 'createVersion4UUIDString'; did you mean 'createVersion4UUIDStringWeak'?
- 1:11 PM Changeset in webkit [293181] by
-
- 1 edit in branches/safari-613-branch/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Unreviewed build fix. rdar://72058321
DerivedSources/WebKit/WebPageMessageReceiver.cpp:4038:99: error: indirection requires pointer operand ('UniqueRef<IPC::Encoder>' invalid)
return IPC::handleMessage<Messages::WebPage::PerformActionOnElement>(connection, decoder, *replyEncoder, this, &WebPage::performActionOnElement);
- 1:11 PM Changeset in webkit [293180] by
-
- 8 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r291371. rdar://problem/72058321
- 1:11 PM Changeset in webkit [293179] by
-
- 8 edits in branches/safari-613-branch/Source/WebKit
Revert r291371. rdar://problem/72058321
This reverts r293069.
- 10:51 AM Changeset in webkit [293178] by
-
- 23 edits in trunk/Source/WebInspectorUI
Web Inspector: add reference page links for the Timelines Tab
https://bugs.webkit.org/show_bug.cgi?id=239580
Reviewed by Patrick Angle.
- UserInterface/Views/TimelineView.js:
(WI.TimelineView.prototype.initialLayout): Added.
- UserInterface/Views/TimelineView.css:
(.timeline-view > .reference-page-link-container): Added.
Add a reference page link to the bottom-right of each timeline view.
- UserInterface/Views/CPUTimelineView.js:
(WI.CPUTimelineView.prototype.initialLayout):
- UserInterface/Views/HeapAllocationsTimelineView.js:
- UserInterface/Views/LayoutTimelineView.js:
- UserInterface/Views/MediaTimelineView.js:
- UserInterface/Views/MemoryTimelineView.js:
- UserInterface/Views/NetworkTimelineView.js:
- UserInterface/Views/OverviewTimelineView.js:
- UserInterface/Views/RenderingFrameTimelineView.js:
- UserInterface/Views/ScriptDetailsTimelineView.js:
- UserInterface/Views/ScriptProfileTimelineView.js:
Add
WI.*.ReferencePage = WI.ReferencePage.*relationships for each timeline view.
- UserInterface/Base/ReferencePage.js:
(WI.ReferencePage): Added.
(WI.ReferencePage.prototype.get page): Added.
(WI.ReferencePage.prototype.get topic): Added.
(WI.ReferencePage.prototype.createLinkElement): Added.
- UserInterface/Base/Main.js:
(WI.createReferencePageLink): Moved to
WI.ReferencePage.prototype.createLinkElement.
Create aWI.ReferencePageclass that knows how to generate a<a>.
- UserInterface/Views/AuditNavigationSidebarPanel.js:
(WI.AuditNavigationSidebarPanel.prototype.showDefaultContentView):
- UserInterface/Views/AuditTestCaseContentView.js:
(WI.AuditTestCaseContentView.prototype.showRunningPlaceholder):
- UserInterface/Views/AuditTestContentView.js:
(WI.AuditTestContentView.prototype.showStoppingPlaceholder):
(WI.AuditTestContentView.prototype.showNoResultPlaceholder):
(WI.AuditTestContentView.prototype.showNoResultDataPlaceholder):
(WI.AuditTestContentView.prototype.showFilteredPlaceholder):
- UserInterface/Views/AuditTestGroupContentView.js:
(WI.AuditTestGroupContentView.prototype.showRunningPlaceholder):
- UserInterface/Views/BreakpointPopover.js:
(WI.BreakpointPopover.prototype.show):
- UserInterface/Views/CreateAuditPopover.js:
(WI.CreateAuditPopover.prototype.show):
- UserInterface/Views/Layers3DContentView.js:
(WI.Layers3DContentView.prototype.initialLayout):
- UserInterface/Views/LocalResourceOverridePopover.js:
(WI.LocalResourceOverridePopover.prototype.show):
ReplaceWI.createReferencePageLinkwithWI.ReferencePage.*.createLinkElement
- 10:43 AM Changeset in webkit [293177] by
-
- 2 edits in trunk/Source/WebCore
[GBM] Debug build broken
https://bugs.webkit.org/show_bug.cgi?id=239609
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-21
Reviewed by Adrian Perez de Castro.
- platform/graphics/gbm/GraphicsContextGLGBM.cpp: Include Logging.h enabling use of logging facilities.
Canonical link: https://commits.webkit.org/249859@main
- 10:32 AM Changeset in webkit [293176] by
-
- 9 edits2 adds in trunk/Source/JavaScriptCore
Unreviewed, reverting r293146.
https://bugs.webkit.org/show_bug.cgi?id=239613
Broke JSC tests. Looks like EWS was blocked by label
<https://bugs.webkit.org/show_bug.cgi?id=239411>
Reverted changeset:
"[JSC] Remove TempRegisterSet"
https://bugs.webkit.org/show_bug.cgi?id=239578
https://commits.webkit.org/r293146
- 10:16 AM Changeset in webkit [293175] by
-
- 6 edits2 adds in trunk
[git-webkit] Add revert command (237663)
https://bugs.webkit.org/show_bug.cgi?id=237663
rdar://90039948
Reviewed by Jonathan Bedard.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: Break the pull request creation into serval differnt funtions so that other action can reuse it easily.
(PullRequest):
(PullRequest.check_pull_request_args):
(PullRequest.pull_request_branch_point):
(PullRequest.create_pull_request):
(PullRequest.main):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py: Added.
(Revert):
(Revert.parser):
(Revert.revert_commit):
(Revert.main):
Canonical link: https://commits.webkit.org/249857@main
- 10:10 AM Changeset in webkit [293174] by
-
- 3 edits in trunk/Tools
[Merge-Queue] Don't close bugs associated with test gardening
https://bugs.webkit.org/show_bug.cgi?id=239604
<rdar://problem/92093456>
Reviewed by Ryan Haddad.
- Tools/CISupport/ews-build/steps.py:
(CloseBug.doStepIf): Skip step if we're a test gardening change.
(UpdatePullRequest):
(UpdatePullRequest.is_test_gardening): Check for "Unreviewed test gardening" in the commit message.
(UpdatePullRequest.evaluateCommand):
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249856@main
- 9:55 AM Changeset in webkit [293173] by
-
- 9 edits in trunk
A suspended remote shared worker should resume when a new SharedWorker is added
https://bugs.webkit.org/show_bug.cgi?id=239325
Reviewed by Chris Dumez.
Source/WebKit:
Check whether resuming/suspending remote shared worker in case of added/removed SharedWorker object.
Make sure to suspend the remote shared worker at launch time if needed.
Covered by updated test.
- NetworkProcess/SharedWorker/WebSharedWorker.cpp:
- NetworkProcess/SharedWorker/WebSharedWorker.h:
- NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
LayoutTests:
- http/tests/navigation/page-cache-shared-worker-expected.txt:
- http/tests/navigation/page-cache-shared-worker.html:
- http/tests/navigation/resources/page-cache-helper-for-sharedworker.html:
- http/tests/navigation/resources/shared-worker-script.js:
- 9:28 AM Changeset in webkit [293172] by
-
- 4 edits in trunk/Tools
[commits.webkit.org] Disable CORS
https://bugs.webkit.org/show_bug.cgi?id=239607
Reviewed by Aakash Jain.
- Tools/Scripts/libraries/reporelaypy/reporelaypy/init.py: Bump version.
- Tools/Scripts/libraries/reporelaypy/reporelaypy/webserver.py: Disable CORS.
- Tools/Scripts/libraries/reporelaypy/setup.py: Bump version.
Canonical link: https://commits.webkit.org/249853@main
- 9:28 AM Changeset in webkit [293171] by
-
- 2 edits in trunk/LayoutTests
[ macOS Release ] webanimations/css-transition-retargeting-during-ready-promise.html is a flaky failure
Updating test expectations to include Monterey Release
https://bugs.webkit.org/show_bug.cgi?id=215335
Unreviewed test gardening.
- LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/249853@main
- 9:21 AM Changeset in webkit [293170] by
-
- 7 edits2 adds in trunk
AVSampleBufferRenderSynchronizer timeline sometimes goes backwards when playback begins
https://bugs.webkit.org/show_bug.cgi?id=239471
rdar://91117803
Reviewed by Jer Noble.
Source/WebCore:
Test: media/media-source/media-source-current-time.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Log current time and requested
playback rate.
(WebCore::HTMLMediaElement::setPausedInternal): Log.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
If time has gone backward, clamp to the most recent seek time.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal): INFO_LOG -> ALWAYS_LOG
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pauseInternal): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentMediaTime const): Use clampTimeToLastSeekTime.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::clampTimeToLastSeekTime const): New,
clamp time value to the most recent seek time.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setCurrentTimeDidChangeCallback):
Use clampTimeToLastSeekTime.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance): INFO_LOG -> ALWAYS_LOG
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal): INFO_LOG -> ALWAYS_LOG
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer): INFO_LOG -> ALWAYS_LOG
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableVideoFrame): INFO_LOG -> ALWAYS_LOG
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged): INFO_LOG -> ALWAYS_LOG
Source/WebKit:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::currentTimeChanged): Log when time jumps backwards.
LayoutTests:
- media/media-source/media-source-current-time-expected.txt: Added.
- media/media-source/media-source-current-time.html: Added.
- 8:21 AM Changeset in webkit [293169] by
-
- 5 edits in trunk/Source/WebCore
[LFC][Integration] Add direct style accessor to inline iterator
https://bugs.webkit.org/show_bug.cgi?id=239593
Reviewed by Alan Bujtas.
The current implementation fetches the line and the renderer and is pretty expensive.
- layout/integration/inline/InlineIteratorBox.cpp:
(WebCore::InlineIterator::Box::style const): Deleted.
- layout/integration/inline/InlineIteratorBox.h:
(WebCore::InlineIterator::Box::style const):
- layout/integration/inline/InlineIteratorBoxLegacyPath.h:
(WebCore::InlineIterator::BoxLegacyPath::style const):
- layout/integration/inline/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::style const):
- 7:46 AM Changeset in webkit [293168] by
-
- 3 edits in trunk/Tools
[Merge-Queue] Allow "Rubber-stamped" as review message
https://bugs.webkit.org/show_bug.cgi?id=239601
<rdar://problem/92091819>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/steps.py:
(ValidateCommitMessage.evaluateCommand): Allow "Rubber-stamped by."
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249850@main
- 6:20 AM Changeset in webkit [293167] by
-
- 10 edits2 copies in trunk/Tools
[build.webkit.org] Support identifiers on dashboard
https://bugs.webkit.org/show_bug.cgi?id=239473
<rdar://problem/76852365>
Reviewed by Aakash Jain.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.layoutTestResultsDirectoryURLForIteration): Remove leading r.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.get buildURL): Request identifier.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: OpenSource should be considered a git checkout.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Initialization.js: Add Commit interface.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Main.js: Kick off periodic commits.webkit.org refresh.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/QueueView.js:
(QueueView.prototype._appendPendingRevisionCount): Use commit.webkit.org interface instead of trac.
(QueueView.prototype._formatRevisionForDisplay): Don't truncate identifiers.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/tests/index.html: Import Commits.js.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/tests/resources/MockCommits.js:
(MockCommits): Add mock commits.webkit.org interface.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/tests/resources/tests.js:
(setup): Add commits.webkit.org interface.
(this.view._latestProductiveIteration):
- Tools/CISupport/build-webkit-org/public_html/dashboard/index.html:
Canonical link: https://commits.webkit.org/249849@main
- 5:14 AM Changeset in webkit [293166] by
-
- 1 copy in releases/WebKitGTK/webkit-2.36.1
WebKitGTK 2.36.1
- 5:13 AM Changeset in webkit [293165] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.1 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.36.1.
- 4:41 AM Changeset in webkit [293164] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Tools
Merge r293163 - [GTK][WPE] Make make-dist script python3 only
https://bugs.webkit.org/show_bug.cgi?id=239596
Reviewed by Adrian Perez de Castro.
It fails with python2 since r291934.
- Scripts/make-dist:
- 4:40 AM Changeset in webkit [293163] by
-
- 2 edits in trunk/Tools
[GTK][WPE] Make make-dist script python3 only
https://bugs.webkit.org/show_bug.cgi?id=239596
Reviewed by Adrian Perez de Castro.
It fails with python2 since r291934.
- Scripts/make-dist:
- 3:53 AM Changeset in webkit [293162] by
-
- 2 edits1 add in trunk/LayoutTests
[iOS] Rebaseline fast/attachment/attachment-disabled-rendering.html expectations
https://bugs.webkit.org/show_bug.cgi?id=238960
Unreviewed test gardening.
The page dimensions are slightly different, but the <attachment> has 0 size as expected.
- platform/ios-wk2/TestExpectations:
- platform/ios/fast/attachment/attachment-disabled-rendering-expected.txt: Added.
- 3:37 AM Changeset in webkit [293161] by
-
- 2 edits in trunk/Source/WebCore
Small cleanups to StyleBuilderCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=239595
Reviewed by Antti Koivisto.
- Make use of DECLARE_PROPERTY_CUSTOM_HANDLERS more often
- Make code style for the containIntrinsic*Size methods consistent with
applyInitialContainIntrinsicBlockSize (use auto and better variable name)
- A bit of extra sorting
- style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueContainIntrinsicBlockSize):
(WebCore::Style::BuilderCustom::applyInitialContainIntrinsicInlineSize):
(WebCore::Style::BuilderCustom::applyValueContainIntrinsicInlineSize):
- 2:51 AM Changeset in webkit [293160] by
-
- 3 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r292901 - [GTK] AddressSanitizer: heap-buffer-overflow in WebCore::Length::ref()
https://bugs.webkit.org/show_bug.cgi?id=237389
Reviewed by Žan Doberšek.
- platform/graphics/nicosia/NicosiaAnimation.cpp:
(Nicosia::createThreadsafeKeyFrames): Convert Length members of transform functions to
the fixed variety before they are moved to separate threads.
(Nicosia::Animation::Animation): Use the new helper.
- platform/graphics/transforms/TranslateTransformOperation.h: Added setters.
- 2:51 AM Changeset in webkit [293159] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebKit
Merge r292628 - [WPE][2.36] Build with a11y disabled fails
https://bugs.webkit.org/show_bug.cgi?id=239004
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-08
Reviewed by Michael Catanzaro.
Add accessibility build guards.
- UIProcess/Launcher/glib/XDGDBusProxy.cpp:
(WebKit::XDGDBusProxy::XDGDBusProxy):
(WebKit::XDGDBusProxy::launch const):
- 2:51 AM WebKitGTK/2.36.x edited by
- (diff)
- 2:51 AM Changeset in webkit [293158] by
-
- 11 edits in releases/WebKitGTK/webkit-2.36/Source
Merge r292211 - REGRESSION(r290360): [GLX] Crash on process exit
https://bugs.webkit.org/show_bug.cgi?id=238494
Reviewed by Michael Catanzaro.
Source/WebCore:
When creating a PlatformDisplay from a shared GdkDisplay, we need to keep a reference to the display and connect
to closed signal to release our display dependent resources. Closed signal is emitted right before the native
display is actually closed by GDK. We also need to make sure that the sharing GL context is released before the
PlatformDisplay is destroyed. This is always happening for EGL because the sharing GL context is cleared before
terminating the EGL display in the atexit handler, but that's not the case of GLX. Since X11 only allows one
PlatformDisplay, which is always the shared one, we can just install an atexit handler in the constructor to
clear the sharing context before the destructor is called.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::createPlatformDisplay):
(WebCore::PlatformDisplay::PlatformDisplay):
(WebCore::PlatformDisplay::sharedDisplayDidClose):
(WebCore::PlatformDisplay::~PlatformDisplay):
(WebCore::PlatformDisplay::clearSharingGLContext):
(WebCore::PlatformDisplay::terminateEGLDisplay):
- platform/graphics/PlatformDisplay.h:
- platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:
(WebCore::PlatformDisplayLibWPE::PlatformDisplayLibWPE):
- platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::create):
(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::sharedDisplayDidClose):
- platform/graphics/wayland/PlatformDisplayWayland.h:
- platform/graphics/win/PlatformDisplayWin.h:
- platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::create):
(WebCore::clearSharingGLContextAtExit):
(WebCore::PlatformDisplayX11::PlatformDisplayX11):
(WebCore::PlatformDisplayX11::~PlatformDisplayX11):
(WebCore::PlatformDisplayX11::sharedDisplayDidClose):
- platform/graphics/x11/PlatformDisplayX11.h:
Source/WebKit:
- WebProcess/gtk/WaylandCompositorDisplay.cpp:
(WebKit::WaylandCompositorDisplay::WaylandCompositorDisplay):
- 2:51 AM Changeset in webkit [293157] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/gtk/po
Merge r292212 - Croatian translation for WebKitGTK
https://bugs.webkit.org/show_bug.cgi?id=238611
Patch by gogo <trebelnik2@gmail.com> on 2022-04-01
Rubber-stamped by Carlos Garcia Campos.
- hr.po: Added.
- 2:51 AM Changeset in webkit [293156] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebKit
Merge r292099 - [GTK][WPE] Exit cleanly if Connection to UIProcess severed. Regression (r214307)
https://bugs.webkit.org/show_bug.cgi?id=235224
This patch reverts the WPE and GTK specific code removed in '[WK2] Make
establishing a connection between the WebProcess and the Network process more
robust' (r12345):
GTK+ and WPE ports don't exit on send sync message failure. In those particular
cases, the network process can be terminated by the UI process while the
Web process is still initializing, so we always want to exit instead of crashing. This can
happen when the WebView is created and then destroyed quickly.
See https://bugs.webkit.org/show_bug.cgi?id=183348.
Reviewed by Carlos Garcia Campos.
- WebProcess/WebProcess.cpp:
(WebKit::getNetworkProcessConnection):
(WebKit::WebProcess::getGPUProcessConnection):
(WebKit::getWebAuthnProcessConnection):
- 2:51 AM Changeset in webkit [293155] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r292684 - Include locale.h for LC_MESSAGES definition.
https://bugs.webkit.org/show_bug.cgi?id=239030
Patch by Khem Raj <raj.khem@gmail.com> on 2022-04-09
Reviewed by Michael Catanzaro.
- accessibility/atspi/AccessibilityRootAtspi.cpp:
- 2:51 AM Changeset in webkit [293154] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36/Source/JavaScriptCore
Merge r291815 - [JSC] JSRemoteFunction thunk should materialize code-pointer
https://bugs.webkit.org/show_bug.cgi?id=238313
Reviewed by Mark Lam.
When invoking a JSRemoteFunction, we must first wrap the arguments passed to it.
The wrapping operation may trigger a GC, and GC can jettison JIT code. As a result,
even though we know that the target JSFunction has JIT code that we want to execute,
the JIT code may be jettisoned (while wrapping the arguments for it) before we get
to the call. This resulted in occasional crashes on the JSTests/stress/shadow-realm-evaluate.js test.
This patch fixes this by doing a null check on the JIT code just before calling it,
and if null (i.e. the JIT code has been jettisoned), re-materializing the JIT code
first before making the call.
- jit/JITOperations.cpp:
(JSC::JSC_DEFINE_JIT_OPERATION):
- jit/JITOperations.h:
- jit/ThunkGenerators.cpp:
(JSC::remoteFunctionCallGenerator):
- 2:51 AM Changeset in webkit [293153] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36
Merge r291785 - [JSC] Fix remoteFunctionCallGenerator on MIPS
https://bugs.webkit.org/show_bug.cgi?id=238274
Patch by Geza Lore <Geza Lore> on 2022-03-23
Reviewed by Yusuke Suzuki.
JSTests:
- stress/shadow-realm-evaluate.js:
Source/JavaScriptCore:
Eliminate register conflict (nonArgGPR0 == regT4, which is used in
valueRegs)
- jit/ThunkGenerators.cpp:
(JSC::remoteFunctionCallGenerator):
- 2:51 AM Changeset in webkit [293152] by
-
- 13 edits in releases/WebKitGTK/webkit-2.36/Source/JavaScriptCore
Merge r290788 - Add a DeferTraps scope
https://bugs.webkit.org/show_bug.cgi?id=237306
<rdar://83494949>
Reviewed by Mark Lam.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::noticeIncomingCall):
- bytecode/CodeBlock.h:
- bytecode/RepatchInlines.h:
(JSC::linkFor):
(JSC::virtualForWithFunction):
- dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeModuleProgram):
- interpreter/InterpreterInlines.h:
(JSC::Interpreter::execute):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
- runtime/ExceptionScope.h:
- runtime/ScriptExecutable.cpp:
(JSC::ScriptExecutable::installCode):
- runtime/VMTraps.cpp:
(JSC::VMTraps::handleTraps):
(JSC::VMTraps::takeTopPriorityTrap):
- runtime/VMTraps.h:
(JSC::VMTraps::needHandling const):
(JSC::VMTraps::maybeNeedHandling const):
(JSC::VMTraps::hasTrapBit):
(JSC::VMTraps::setTrapBit):
- runtime/VMTrapsInlines.h:
(JSC::DeferTraps::DeferTraps):
(JSC::DeferTraps::~DeferTraps):
- 2:51 AM Changeset in webkit [293151] by
-
- 5 edits4 adds in releases/WebKitGTK/webkit-2.36
Merge r291813 - Safari can't play video completely at bilibili.com
https://bugs.webkit.org/show_bug.cgi?id=236440
rdar://88761053
Reviewed by Jer Noble.
Source/WebCore:
Video frames were incorrectly evicted during a call to appendBuffer
as the Source Buffer incorrectly assumed a discontinuity was present.
When appending data to a source buffer, the MSE specs describe a method
to detect discontinuities in the Coded Frame Processing algorithm
(https://www.w3.org/TR/media-source/#sourcebuffer-coded-frame-processing)
step 6:
"
- If last decode timestamp for track buffer is set and decode timestamp is less than last decode timestamp:
OR
- If last decode timestamp for track buffer is set and the difference between decode timestamp and last decode timestamp is greater than 2 times last frame duration.
"
The issue being what defines the last frame duration.
Is it the frame last seen in the coded frame processing loop or the frame
whose presentation timestamp is just before the one we are currently
processing.
H264 and HEVC have a concept of b-frames: that is a frame that depends
on a future frame to be decoded.
Those frames are found in the container and can be identified by their
presentation timestamp higher than the frame following in decode order.
Those present a challenge as the frame prior the current one in
presentation order, may actually only be found several frames back in
decode order.
Bug 181891 attempted to fix a similar issue, and used the longest
"decode duration" as a workaround to detect discontinuity in the content.
It mentioned adopting the same technique as in Mozilla's MSE
implementation, but Mozilla also skip discontinuity detection within a
media segment (https://www.w3.org/TR/media-source/#media-segment which for
fMP4 is a single moof box) an approach that can't be achieved with
CoreMedia's AVStreamDataParser.
As mentioned in bug 181891, CoreMedia ignore the decode timestamps' delta
and juggles with the sample's duration so that there's no discontinuity
in the demuxed samples' presentation time, causing false positive in the
gap detection algorithm.
Bilibili uses HEVC content, and uses an encoding that generate lots
of b-frames, with a very wide sliding window (seen up to 12 frames).
By using the longest frame duration found in either presentation or
decode duration as threshold to identify a discontinuity, we can
properly parse the content and not incorrectly evict appended frames.
(As a side note, the use of HEVC with B-Frames is peculiar as not all
hardware support it.)
It is difficult to identify here if the issue is within the bilibili's
content or CoreMedia's output, though the responsibility more than
likely lies with bilibili.
Test: media/media-source/media-mp4-hevc-bframes.html
- platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::TrackBuffer::TrackBuffer):
(WebCore::SourceBufferPrivate::resetTrackBuffers):
(WebCore::SourceBufferPrivate::didReceiveSample):
- platform/graphics/SourceBufferPrivate.h:
LayoutTests:
- media/media-source/content/test-bframes-hevc-manifest.json: Added.
- media/media-source/content/test-bframes-hevc.mp4: Added.
- media/media-source/media-mp4-hevc-bframes-expected.txt: Added.
- media/media-source/media-mp4-hevc-bframes.html: Added.
- 2:50 AM Changeset in webkit [293150] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebKit
Merge r291621 - Ensure that proxies are invalidated before destroying them.
https://bugs.webkit.org/show_bug.cgi?id=237187
Reviewed by Carlos Garcia Campos.
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::updateSceneState):
- 2:35 AM Changeset in webkit [293149] by
-
- 3 edits in trunk/Source/WebCore
[GTK][WPE] Update libwebrtc API usage for video encoder factory
https://bugs.webkit.org/show_bug.cgi?id=239558
Reviewed by Philippe Normand.
Update GstreamerVideoEncoderFactory with current libwebrtc API.
No new tests required.
- platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder): Chain main constructor rather to
copy its initializations.
Update InitEncode method signature.
Remove deprecated attributes of EncoderInfo.
Fix code-style.
(WebCore::GStreamerH264Encoder::GStreamerH264Encoder): Remove unused class attribute and fix
a memleak.
- platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.h: Remove deprecated
method.
- 2:28 AM Changeset in webkit [293148] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r292863): std::remove_cvref_t not defined in GCC9<
https://bugs.webkit.org/show_bug.cgi?id=239482
Reviewed by Žan Doberšek.
std::remove_cvref_t is only available since GCC9 onwards:
- wtf/StdLibExtras.h: add remove_cvref_t to std namespace if not defined.
- 1:39 AM Changeset in webkit [293147] by
-
- 2 edits in trunk/Source/WebCore
Skip release assert during container query resolution
https://bugs.webkit.org/show_bug.cgi?id=239537
Patch by Rob Buis <rbuis@igalia.com> on 2022-04-21
Reviewed by Antti Koivisto.
Skip release assert during container query resolution
since resolveStyle will be a no-op as the container
query resolution was started in resolveStyle, so calling
resolveStyle the second time will bail right away.
- dom/Document.cpp:
(WebCore::Document::updateStyleIfNeeded):
Apr 20, 2022:
- 10:28 PM Changeset in webkit [293146] by
-
- 9 edits2 deletes in trunk/Source/JavaScriptCore
[JSC] Remove TempRegisterSet
https://bugs.webkit.org/show_bug.cgi?id=239578
Reviewed by Mark Lam.
We can always use RegisterSet. TempRegisterSet can save several bytes, but we have no code using TempRegisterSet in
heap-allocated class, so this does not make sense anymore. Instead of TempRegisterSet, we should consistently use
ScratchRegisterAllocator.
- Source/JavaScriptCore/CMakeLists.txt:
- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
- Source/JavaScriptCore/Sources.txt:
- Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::copyLLIntBaselineCalleeSavesFromFrameOrRegisterToEntryFrameCalleeSavesBuffer):
- Source/JavaScriptCore/jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::copyCalleeSavesToEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyLLIntBaselineCalleeSavesFromFrameOrRegisterToEntryFrameCalleeSavesBuffer): Deleted.
- Source/JavaScriptCore/jit/RegisterSet.h:
- Source/JavaScriptCore/jit/ScratchRegisterAllocator.cpp:
(JSC::ScratchRegisterAllocator::lock):
(JSC::ScratchRegisterAllocator::allocateScratch):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
- Source/JavaScriptCore/jit/ScratchRegisterAllocator.h:
- Source/JavaScriptCore/jit/TempRegisterSet.cpp: Removed.
- Source/JavaScriptCore/jit/TempRegisterSet.h: Removed.
Canonical link: https://commits.webkit.org/249842@main
- 9:51 PM Changeset in webkit [293145] by
-
- 1 edit in branches/safari-613-branch/Source/WebKit/DerivedSources-output.xcfilelist
Remove merge conflict marker.
- 9:51 PM Changeset in webkit [293144] by
-
- 1 edit in branches/safari-613-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
Unreviewed build fix. rdar://91446317
Source/WebKit/UIProcess/WebPageProxy.cpp:3499:17: error: no matching constructor for initialization of 'WTF::URL'
- 9:08 PM Changeset in webkit [293143] by
-
- 2 edits in trunk/Tools
Generate well-formed JSON for compile_commands.json
https://bugs.webkit.org/show_bug.cgi?id=239584
Reviewed by Mark Lam.
Currently, compile_commands.json always has one trailing comma in the main array. While clangd does not care this,
it is ill-formed JSON, and some other tools consuming compile_commands.json can fail.
This patch makes it so that generated compile_commands.json has well-formed JSON.
- Tools/Scripts/generate-compile-commands:
Canonical link: https://commits.webkit.org/249841@main
- 8:56 PM Changeset in webkit [293142] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, fix the iOS 15.4 build after r293117
Remove an unnecessary header include.
- Platform/spi/ios/UIKitSPI.h:
- 8:32 PM Changeset in webkit [293141] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix GPRInfo inconsistency in unlinked DFG bringup
https://bugs.webkit.org/show_bug.cgi?id=239573
Reviewed by Mark Lam.
Previously, we forgot changing GPRInfo::toIndex of x64 so that we got assertion in ScratchRegisterAllocator.
This patch fixes it and test this consistency in testmasm.
It allows unlinked DFG style register usage in x64, so we reenabled it again.
- Source/JavaScriptCore/assembler/testmasm.cpp:
(JSC::testGPRInfoConsistency):
- Source/JavaScriptCore/dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- Source/JavaScriptCore/jit/GPRInfo.h:
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toArgumentRegister):
(JSC::GPRInfo::toIndex):
Canonical link: https://commits.webkit.org/249839@main
- 7:48 PM Changeset in webkit [293140] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] platform/ios/ios/fast/text/opticalFont.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=239570
<rdar://problem/92056238>
Unreviewed test gardening.
Rebase.
- platform/ios/platform/ios/ios/fast/text/opticalFont-expected.txt:
- 7:43 PM Changeset in webkit [293139] by
-
- 19 edits3 deletes in branches/safari-613-branch
Revert r291589. rdar://problem/90511155
This reverts r293071.
- 7:08 PM Changeset in webkit [293138] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed follow-up to r293123 to address review feedback from Sam & Darin
- css/SelectorFilter.cpp:
(WebCore::localNameIsKnownToBeLowercase):
(WebCore::SelectorFilter::collectElementIdentifierHashes):
- 6:51 PM Changeset in webkit [293137] by
-
- 16 edits2 adds in trunk
Avoid falling back to snapshots for transparent images when triggering batch text recognition
https://bugs.webkit.org/show_bug.cgi?id=239555
rdar://91622151
Reviewed by Aditya Keerthi.
Source/WebCore:
For normal Live Text, our existing heuristics fall back to analyzing a snapshot rather than the image data
itself for transparent image elements (e.g. on Twitter). However, when installing block-style image overlay
content usingImageAnalysisQueue, it doesn't make sense to use this compatibility hack, since this flavor of
image overlay content is directly visible to the user, and would still show up underneath fully transparent
image elements, as long as we're able to analyze the other (non-fully-transparent) image element underneath.
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXImage.cpp:
- page/ChromeClient.h:
Plumb the new
TextRecognitionOptionsstruct through this client method.
(WebCore::ChromeClient::requestTextRecognition):
- page/EventHandler.cpp:
(WebCore::EventHandler::textRecognitionHoverTimerFired):
- page/ImageAnalysisQueue.cpp:
(WebCore::ImageAnalysisQueue::resumeProcessing):
Use the presence of an identifier as a cue to determine whether or not we should opt into the snapshotting
fallback behavior, for the time being. I also considered just keying this behavior off of theidentifierin
WebPage::requestTextRecognition, but chose this approach because it seems fragile to couple those two
behaviors.
- platform/TextRecognitionOptions.h: Added.
- testing/Internals.cpp:
Source/WebKit:
Refactor
requestTextRecognition()to take inTextRecognitionOptions.
See WebCore/ChangeLog for more details.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::requestTextRecognition):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::requestTextRecognition):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::requestTextRecognition):
Tools:
Add an API test to exercise the bug, by triggering batch image analysis on an image with
opacity: 0;that
fades in on a timer.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::CGImagePixelReader::CGImagePixelReader):
(TestWebKitAPI::CGImagePixelReader::isTransparentBlack const):
(TestWebKitAPI::CGImagePixelReader::at const):
(TestWebKitAPI::CGImagePixelReader::width const):
(TestWebKitAPI::CGImagePixelReader::height const):
Add a simple helper class to read pixel values at a given location in a given CGImage; this helper class works
by first rendering the given image into a plain SRGB bitmap context, which we then use to read back pixel data
in RGBA format.
(TestWebKitAPI::processRequestWithError):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/fade-in-image.html: Added.
- 6:30 PM Changeset in webkit [293136] by
-
- 2 edits in trunk
Unreviewed, add github accounts of Apple JSC reviewers
- metadata/contributors.json:
- 6:24 PM Changeset in webkit [293135] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/rendering/RenderGrid.cpp
Revert "Unreviewed build fix. rdar://88512506"
This reverts r293134.
- 5:47 PM Changeset in webkit [293134] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/rendering/RenderGrid.cpp
Unreviewed build fix. rdar://88512506
Correction to r293125.
- 5:45 PM Changeset in webkit [293133] by
-
- 13 edits2 deletes in branches/safari-613-branch
Revert r292274. rdar://problem/80544133
This reverts r293080.
- 5:30 PM Changeset in webkit [293132] by
-
- 2 edits in trunk/Tools
[LayoutTests][Win] Tests can fail if long paths are not enabled in registry.
https://bugs.webkit.org/show_bug.cgi?id=188092
Reviewed by Basuke Suzuki.
Python 3.6 supports long file paths on Windows by default so long as LongPathsEnabled is set in
HKLM\System\CurrentControlSet\Control\FileSystem. This patch adds that key to webkitpy's registry editing.
- Scripts/webkitpy/port/win.py:
(WinPort):
(WinPort.set_long_paths_enabled): Added.
(WinPort.restore_long_paths_enabled): Added.
(WinPort.setup_test_run):
(WinPort.clean_up_test_run):
Canonical link: https://commits.webkit.org/249834@main
- 5:25 PM Changeset in webkit [293131] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_block_downloads.tentative.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239577
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249833@main
- 4:17 PM Changeset in webkit [293130] by
-
- 2 edits in trunk/LayoutTests
[ macOS Release wk2 ] webanimations/frame-rate/animation-frame-rate-alignment-started-with-one-frame-separation.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239574
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249832@main
- 4:02 PM Changeset in webkit [293129] by
-
- 13 edits in trunk/Source
Move true / false AtomStrings to a central location and reuse them
https://bugs.webkit.org/show_bug.cgi?id=239530
Reviewed by Sam Weinig.
Source/WebCore:
- dom/mac/ImageControlsMac.cpp:
(WebCore::ImageControlsMac::createImageControls):
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::detectContentInRange):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::contentEditable const):
(WebCore::HTMLElement::setContentEditable):
(WebCore::trueName): Deleted.
(WebCore::falseName): Deleted.
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::updateInnerTextElementEditabilityImpl):
- mathml/MathMLPresentationElement.cpp:
(WebCore::MathMLPresentationElement::cachedBooleanAttribute):
- platform/network/HTTPParsers.cpp:
(WebCore::parseStructuredFieldValue):
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::parseAttribute):
- svg/properties/SVGPropertyTraits.h:
(WebCore::SVGPropertyTraits<bool>::toString):
- xml/XPathValue.cpp:
(WebCore::XPath::Value::toString const):
Source/WTF:
- wtf/text/AtomString.cpp:
(WTF::AtomString::init):
- wtf/text/AtomString.h:
(WTF::trueAtom):
(WTF::falseAtom):
- 3:47 PM Changeset in webkit [293128] by
-
- 2 edits in trunk/LayoutTests
[ Monterey Release wk2 ] imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-in-main-window-self-navigate-inherits.sub.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239568
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249830@main
- 3:32 PM Changeset in webkit [293127] by
-
- 2 edits in trunk/Source/WebKit
Add release assert logging in RemoteRenderingBackendProxy::prepareBuffersForDisplay()
https://bugs.webkit.org/show_bug.cgi?id=239563
Reviewed by Wenson Hsieh.
Use RELEASE_ASSERT_WITH_MESSAGE() to make it more clear which of the two release
assertions is being hit.
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::prepareBuffersForDisplay):
- 3:29 PM Changeset in webkit [293126] by
-
- 6 edits2 moves2 adds in trunk
REGRESSION (r281913): Map toolbar flickers when dragging the map on https://gis.ee/
https://bugs.webkit.org/show_bug.cgi?id=238589
<rdar://90483049>
Reviewed by Alan Bujtas.
Source/WebCore:
If a layer has negative z-order descendants, and one of those descendants becomes
composited, then that layer also has to composite, because its foreground needs to render in
front of those descendants. But this is tricky, because the compositing toggle is
out-of-order; we only know that the layer has to get composited after processing
descendants.
In particular, this created a problem with the overlap map, which tracks sets of rectangles
in "compositing scopes" via LayerOverlapMap. The delayed compositing toggle of the layer
with negative z-order descendants meant that any layers processed up to that point had their
bounds added in the wrong overlap scope. This resulted in subsequent bad overlap testing,
and a failure to make later layers composited.
The previous fix in this area (r281913) was incorrect. Revert it, and do a better fix, which
is to speculatively push an overlap map entry for the layer with negative z-order
descendants, if necessary. If this layer ends up not getting composited, we unwind the
speculative push, which will merge that scope with its parent scope.
In addition give OverlapMapContainer (an "overlap scope") a RenderLayer& which we can use
for logging, and to assert on correct behavior; it is not otherwise used in release builds.
Tests: compositing/layer-creation/overlap-with-negative-z-layers.html
compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs.html
- rendering/LayerOverlapMap.cpp:
(WebCore::OverlapMapContainer::OverlapMapContainer):
(WebCore::OverlapMapContainer::scopeLayer const):
(WebCore::OverlapMapContainer::dump const):
(WebCore::LayerOverlapMap::LayerOverlapMap):
(WebCore::LayerOverlapMap::add):
(WebCore::LayerOverlapMap::pushCompositingContainer):
(WebCore::LayerOverlapMap::popCompositingContainer):
- rendering/LayerOverlapMap.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):
(WebCore::RenderLayerCompositor::updateOverlapMap const):
LayoutTests:
Move subtree-div-overlaps-multiple-negative-z-divs.html into the layer-creation directory.
Add a new test.
- compositing/layer-creation/overlap-with-negative-z-layers-expected.html: Added.
- compositing/layer-creation/overlap-with-negative-z-layers.html: Added.
- compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs-expected.html: Renamed from LayoutTests/compositing/subtree-div-overlaps-multiple-negative-z-divs-expected.html.
- compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs.html: Renamed from LayoutTests/compositing/subtree-div-overlaps-multiple-negative-z-divs.html.
- fast/harness/render-tree-as-text-options-expected.txt: Test progressed; update results.
- 3:27 PM Changeset in webkit [293125] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/rendering/RenderGrid.cpp
Unreviewed build fix. rdar://88512506
./rendering/RenderGrid.cpp:477:94: error: too few arguments to function call, expected 2, have 1
- 3:21 PM Changeset in webkit [293124] by
-
- 2 edits in trunk/Source/WebCore
Simplify type checking / casting in JSEventListener::handleEvent()
https://bugs.webkit.org/show_bug.cgi?id=239559
Reviewed by Sam Weinig.
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- 3:11 PM Changeset in webkit [293123] by
-
- 2 edits in trunk/Source/WebCore
Avoid call to convertToASCIILowercase() in SelectorFilter::collectElementIdentifierHashes() in the common case
https://bugs.webkit.org/show_bug.cgi?id=239545
Reviewed by Sam Weinig.
The call to convertToASCIILowercase() in SelectorFilter::collectElementIdentifierHashes() shows in Speedometer profiles
even though input tags are already lowercase, simply because the function needs to iterate over the string to determine
that it is all lowercase. In the common case though, we can leverage the fact that all known HTML element tags are
lowercase to avoid the call to convertToASCIILowercase(). This is because HTMLElement::localName() returns one of the
tags defined in HTMLNames.h (for known HTML elements), all of which are lowercase.
- css/SelectorFilter.cpp:
(WebCore::SelectorFilter::collectElementIdentifierHashes):
- 3:09 PM Changeset in webkit [293122] by
-
- 2 edits in trunk/Source/WebCore
Add missing WTFMove() in MIMETypeRegistryThreadGlobalData()
https://bugs.webkit.org/show_bug.cgi?id=239565
Reviewed by Sam Weinig.
- platform/MIMETypeRegistry.h:
(WebCore::MIMETypeRegistryThreadGlobalData::MIMETypeRegistryThreadGlobalData):
- 2:47 PM Changeset in webkit [293121] by
-
- 8 edits2 deletes in branches/safari-613-branch
Revert r290201. rdar://problem/88672183
This reverts r293067.
- 2:47 PM Changeset in webkit [293120] by
-
- 3 edits2 deletes in branches/safari-613-branch
Revert r291281. rdar://problem/90245637
This reverts r293068.
- 2:47 PM Changeset in webkit [293119] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp
Revert "Unreviewed build fix. rdar://problem/88672183"
This reverts r293107.
- 2:46 PM Changeset in webkit [293118] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] media/audio-session-category-at-most-recent-playback.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239566
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249824@main
- 2:42 PM Changeset in webkit [293117] by
-
- 12 edits in trunk
Address recent deprecation warnings on iOS.
https://bugs.webkit.org/show_bug.cgi?id=239560
Reviewed by Wenson Hsieh.
Source/WebKit:
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]):
(-[WKActionSheetAssistant contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]): Deleted.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setUpInteraction]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView pasteForWebView:]):
(-[WKContentView _handleDOMPasteRequestWithResult:]):
(-[WKContentView _requestDOMPasteAccessForCategory:elementRect:originIdentifier:completionHandler:]):
(-[WKContentView contextMenuInteraction:configuration:previewForHighlightingItemWithIdentifier:]):
(-[WKContentView contextMenuInteraction:configuration:dismissalPreviewForItemWithIdentifier:]):
(-[WKContentView contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]): Deleted.
(-[WKContentView contextMenuInteraction:previewForDismissingMenuWithConfiguration:]): Deleted.
- UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(-[WKDataListSuggestionsDropdown contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]):
(-[WKDataListSuggestionsDropdown contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]): Deleted.
- UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]):
(-[WKDateTimePicker contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]): Deleted.
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]):
(-[WKFileUploadPanel contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]): Deleted.
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPicker contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]):
(-[WKSelectPicker contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]): Deleted.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
(TEST):
- WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView initWithFrame:configuration:]):
(-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
(-[TestRunnerWKWebView resetCustomMenuAction]):
(-[TestRunnerWKWebView canPerformAction:withSender:]):
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformInitialize):
(WTR::TestController::platformDestroy):
- 2:41 PM Changeset in webkit [293116] by
-
- 2 edits in trunk/Tools/CISupport
Update archs for watchOS build queues
https://bugs.webkit.org/show_bug.cgi?id=239553
Reviewed by Aakash Jain.
Remove the deprecated i386 arch from watchOS simulator builders and switch
EWS + trunk bots to arm64 to expand build coverage for this architecture.
- Tools/CISupport/build-webkit-org/config.json:
- Tools/CISupport/ews-build/config.json:
Canonical link: https://commits.webkit.org/249822@main
- 2:37 PM Changeset in webkit [293115] by
-
- 2 edits in trunk/LayoutTests
Some layout tests are failing on EWS but not post commit testing due to a OS difference
https://bugs.webkit.org/show_bug.cgi?id=239564
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/249821@main
- 2:25 PM Changeset in webkit [293114] by
-
- 433 edits in trunk
[IFC][Integration] Do not call WebPreferences::simpleLineLayoutEnabled in canUseForLineLayoutWithReason
https://bugs.webkit.org/show_bug.cgi?id=239540
Reviewed by Antti Koivisto.
Source/WebCore:
- Use RuntimeEnabledFeatures::sharedFeatures() instead of Page::Settings.
- Remove simpleLineLayoutEnabled setting.
- Rename LayoutFormattingContextIntegrationEnabled -> InlineFormattingContextIntegrationEnabled (in preparation for adding more of these FCs).
- display/DisplayView.cpp:
(WebCore::Display::View::prepareForDisplay):
- layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::formattingStateForFormattingContext const):
(WebCore::Layout::LayoutState::formattingStateForInlineFormattingContext const):
(WebCore::Layout::LayoutState::ensureInlineFormattingState):
(WebCore::Layout::LayoutState::setViewportSize):
(WebCore::Layout::LayoutState::viewportSize const):
(WebCore::Layout::LayoutState::setIsIntegratedRootBoxFirstChild):
(WebCore::Layout::LayoutState::shouldIgnoreTrailingLetterSpacing const):
(WebCore::Layout::LayoutState::shouldNotSynthesizeInlineBlockBaseline const):
- layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::close):
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
- layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
- layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::isEnabled):
(WebCore::LayoutIntegration::LineLayout::releaseCaches):
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setInlineFormattingContextIntegrationEnabled):
(WebCore::RuntimeEnabledFeatures::inlineFormattingContextIntegrationEnabled const):
(WebCore::RuntimeEnabledFeatures::setLayoutFormattingContextIntegrationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled const): Deleted.
- rendering/TextPainter.cpp:
(WebCore::TextPainter::clearGlyphDisplayLists):
Source/WebKit:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSimpleLineLayoutEnabled): Deleted.
(WKPreferencesGetSimpleLineLayoutEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _simpleLineLayoutEnabled]): Deleted.
(-[WKPreferences _setSimpleLineLayoutEnabled:]): Deleted.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm:
(-[WebPreferences simpleLineLayoutEnabled]): Deleted.
(-[WebPreferences setSimpleLineLayoutEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml:
LayoutTests:
- TestExpectations:
- editing/document-marker-null-check.html:
- editing/text-iterator/count-mark-lineboxes.html:
- fast/block/float/simple-line-layout-float-shrink-line-expected.html:
- fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout-expected.html:
- fast/block/margin-collapse/empty-clear-blocks-complex.html:
- fast/css/word-spacing-with-normal-layout.html:
- fast/css3-text/css3-text-decoration/simple-line-layout-text-decoration-expected.html:
- fast/css3-text/css3-text-justify/text-justify-last-line-simple-line-layout-expected.html:
- fast/dom/Document/CaretRangeFromPoint/simple-line-layout-hittest-with-caret-range-from-point-expected.html:
- fast/dom/Range/simple-line-layout-getclientrects-expected.html:
- fast/forms/basic-textareas-quirks-simple-lines-expected.html:
- fast/forms/basic-textareas-quirks.html:
- fast/forms/basic-textareas-simple-lines-expected.html:
- fast/forms/basic-textareas.html:
- fast/forms/linebox-overflow-in-textarea-padding-simple-lines-expected.html:
- fast/forms/linebox-overflow-in-textarea-padding.html:
- fast/forms/negativeLineHeight-simple-lines-expected.html:
- fast/forms/negativeLineHeight.html:
- fast/forms/textAreaLineHeight-simple-lines-expected.html:
- fast/forms/textAreaLineHeight.html:
- fast/inline/hidpi-legacy-integral-rounding-on-hard-line-break-expected.html:
- fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes-expected.html:
- fast/inline/simple-line-layout-16bit-content-expected.html:
- fast/layoutformattingcontext/absolute-positioned-box-with-inline-sibling-expected.html:
- fast/layoutformattingcontext/absolute-positioned-box-with-inline-sibling.html:
- fast/layoutformattingcontext/absolute-positioned-simple-table-expected.html:
- fast/layoutformattingcontext/absolute-positioned-simple-table.html:
- fast/layoutformattingcontext/absolute-positioned-simple-table2-expected.html:
- fast/layoutformattingcontext/absolute-positioned-simple-table2.html:
- fast/layoutformattingcontext/absolute-positioned-simple-table3-expected.html:
- fast/layoutformattingcontext/absolute-positioned-simple-table3.html:
- fast/layoutformattingcontext/anonymous-inline-container-simple-expected.html:
- fast/layoutformattingcontext/anonymous-inline-container-simple.html:
- fast/layoutformattingcontext/block-only/abs-pos-with-border-padding-and-float-child-expected.html:
- fast/layoutformattingcontext/block-only/abs-pos-with-border-padding-and-float-child.html:
- fast/layoutformattingcontext/block-only/absolute-auto-with-sibling-margin-bottom.html:
- fast/layoutformattingcontext/block-only/absolute-height-stretch.html:
- fast/layoutformattingcontext/block-only/absolute-left-auto.html:
- fast/layoutformattingcontext/block-only/absolute-left-right-top-bottom-auto.html:
- fast/layoutformattingcontext/block-only/absolute-nested.html:
- fast/layoutformattingcontext/block-only/absolute-nested2.html:
- fast/layoutformattingcontext/block-only/absolute-position-left-right-margin.html:
- fast/layoutformattingcontext/block-only/absolute-position-min-max-height.html:
- fast/layoutformattingcontext/block-only/absolute-position-min-max-width.html:
- fast/layoutformattingcontext/block-only/absolute-position-when-containing-block-is-not-in-the-formatting-context.html:
- fast/layoutformattingcontext/block-only/absolute-position-when-containing-block-is-not-in-the-formatting-context2.html:
- fast/layoutformattingcontext/block-only/absolute-position-with-margin-auto-simple-expected.html:
- fast/layoutformattingcontext/block-only/absolute-position-with-margin-auto-simple.html:
- fast/layoutformattingcontext/block-only/absolute-position-with-margin-auto-simple2-expected.html:
- fast/layoutformattingcontext/block-only/absolute-position-with-margin-auto-simple2.html:
- fast/layoutformattingcontext/block-only/absolute-positioned-min-max-percentage-with-parent-padding-expected.html:
- fast/layoutformattingcontext/block-only/absolute-positioned-min-max-percentage-with-parent-padding.html:
- fast/layoutformattingcontext/block-only/absolute-simple.html:
- fast/layoutformattingcontext/block-only/absolute-width-shrink-to-fit.html:
- fast/layoutformattingcontext/block-only/absolute-width-stretch.html:
- fast/layoutformattingcontext/block-only/absolute-with-static-block-position-nested.html:
- fast/layoutformattingcontext/block-only/almost-intruding-left-float-simple.html:
- fast/layoutformattingcontext/block-only/block-replaced-with-vertical-margins-expected.html:
- fast/layoutformattingcontext/block-only/block-replaced-with-vertical-margins.html:
- fast/layoutformattingcontext/block-only/block-root-top-should-start-from-float-top-expected.html:
- fast/layoutformattingcontext/block-only/block-root-top-should-start-from-float-top.html:
- fast/layoutformattingcontext/block-only/body-height-with-auto-html-height-quirk.html:
- fast/layoutformattingcontext/block-only/body-height-with-auto-html-height-quirk2.html:
- fast/layoutformattingcontext/block-only/body-height-with-non-auto-html-height-quirk.html:
- fast/layoutformattingcontext/block-only/body-height-with-non-auto-html-height-quirk2.html:
- fast/layoutformattingcontext/block-only/border-simple.html:
- fast/layoutformattingcontext/block-only/box-sizing-inflow-out-of-flow-simple.html:
- fast/layoutformattingcontext/block-only/child-containing-block-margin-collapse-when-float-avoiders-expected.html:
- fast/layoutformattingcontext/block-only/child-containing-block-margin-collapse-when-float-avoiders.html:
- fast/layoutformattingcontext/block-only/collapsed-margin-with-min-height.html:
- fast/layoutformattingcontext/block-only/collapsed-through-siblings.html:
- fast/layoutformattingcontext/block-only/collapsed-through-with-parent.html:
- fast/layoutformattingcontext/block-only/fixed-nested.html:
- fast/layoutformattingcontext/block-only/float-and-siblings-with-margins.html:
- fast/layoutformattingcontext/block-only/float-avoider-multiple-roots.html:
- fast/layoutformattingcontext/block-only/float-avoider-simple-left.html:
- fast/layoutformattingcontext/block-only/float-avoider-simple-right.html:
- fast/layoutformattingcontext/block-only/float-avoider-with-margins.html:
- fast/layoutformattingcontext/block-only/float-clear-with-auto-width-expected.html:
- fast/layoutformattingcontext/block-only/float-clear-with-auto-width.html:
- fast/layoutformattingcontext/block-only/float-left-when-container-has-padding-margin.html:
- fast/layoutformattingcontext/block-only/float-min-max-height.html:
- fast/layoutformattingcontext/block-only/float-min-max-width.html:
- fast/layoutformattingcontext/block-only/floating-and-next-previous-inflow-with-margin-with-no-border.html:
- fast/layoutformattingcontext/block-only/floating-and-next-previous-inflow-with-margin.html:
- fast/layoutformattingcontext/block-only/floating-box-clear-both-simple.html:
- fast/layoutformattingcontext/block-only/floating-box-clear-right-simple.html:
- fast/layoutformattingcontext/block-only/floating-box-left-and-right-multiple-with-top-offset.html:
- fast/layoutformattingcontext/block-only/floating-box-left-and-right-multiple.html:
- fast/layoutformattingcontext/block-only/floating-box-right-simple.html:
- fast/layoutformattingcontext/block-only/floating-box-with-clear-siblings.html:
- fast/layoutformattingcontext/block-only/floating-box-with-clear-simple.html:
- fast/layoutformattingcontext/block-only/floating-box-with-new-formatting-context.html:
- fast/layoutformattingcontext/block-only/floating-box-with-relative-positioned-sibling.html:
- fast/layoutformattingcontext/block-only/floating-left-and-right-with-clearance.html:
- fast/layoutformattingcontext/block-only/floating-left-right-simple.html:
- fast/layoutformattingcontext/block-only/floating-left-right-with-all-margins.html:
- fast/layoutformattingcontext/block-only/floating-lefts-and-rights-simple.html:
- fast/layoutformattingcontext/block-only/floating-multiple-lefts-in-body.html:
- fast/layoutformattingcontext/block-only/floating-multiple-lefts-multiple-lines.html:
- fast/layoutformattingcontext/block-only/floating-multiple-lefts.html:
- fast/layoutformattingcontext/block-only/floating-with-new-block-formatting-context.html:
- fast/layoutformattingcontext/block-only/floats-and-block-formatting-roots-expected.html:
- fast/layoutformattingcontext/block-only/floats-and-block-formatting-roots.html:
- fast/layoutformattingcontext/block-only/inflow-min-max-height.html:
- fast/layoutformattingcontext/block-only/inflow-min-max-width.html:
- fast/layoutformattingcontext/block-only/margin-collapse-bottom-bottom.html:
- fast/layoutformattingcontext/block-only/margin-collapse-bottom-nested.html:
- fast/layoutformattingcontext/block-only/margin-collapse-first-last-are-floating.html:
- fast/layoutformattingcontext/block-only/margin-collapse-simple.html:
- fast/layoutformattingcontext/block-only/margin-collapse-top-nested.html:
- fast/layoutformattingcontext/block-only/margin-collapse-when-child-has-padding-border.html:
- fast/layoutformattingcontext/block-only/margin-collapse-with-block-formatting-context.html:
- fast/layoutformattingcontext/block-only/margin-collapse-with-block-formatting-context2.html:
- fast/layoutformattingcontext/block-only/margin-collapse-with-clearance.html:
- fast/layoutformattingcontext/block-only/margin-left-right-sizing-out-of-flow.html:
- fast/layoutformattingcontext/block-only/margin-left-right-sizing.html:
- fast/layoutformattingcontext/block-only/margin-propagation-simple-content-height.html:
- fast/layoutformattingcontext/block-only/margin-sibling-collapse-propagated.html:
- fast/layoutformattingcontext/block-only/margin-simple.html:
- fast/layoutformattingcontext/block-only/min-max-and-preferred-width-simple-expected.html:
- fast/layoutformattingcontext/block-only/min-max-and-preferred-width-simple.html:
- fast/layoutformattingcontext/block-only/min-max-height-percentage.html:
- fast/layoutformattingcontext/block-only/negative-margin-simple.html:
- fast/layoutformattingcontext/block-only/non-auto-top-bottom-height-with-auto-margins.html:
- fast/layoutformattingcontext/block-only/non-auto-top-bottom-height-with-margins.html:
- fast/layoutformattingcontext/block-only/non-auto-top-bottom-left-right-widht-height-out-of-flow.html:
- fast/layoutformattingcontext/block-only/out-of-flow-is-never-float-box-expected.html:
- fast/layoutformattingcontext/block-only/out-of-flow-is-never-float-box.html:
- fast/layoutformattingcontext/block-only/out-of-flow-with-containing-block-border-padding.html:
- fast/layoutformattingcontext/block-only/padding-nested.html:
- fast/layoutformattingcontext/block-only/padding-simple.html:
- fast/layoutformattingcontext/block-only/relative-auto-with-parent-offset.html:
- fast/layoutformattingcontext/block-only/relative-auto.html:
- fast/layoutformattingcontext/block-only/relative-bottom.html:
- fast/layoutformattingcontext/block-only/relative-position-when-containing-block-is-not-in-the-formatting-context.html:
- fast/layoutformattingcontext/block-only/relative-right.html:
- fast/layoutformattingcontext/block-only/relative-siblings.html:
- fast/layoutformattingcontext/block-only/relative-simple.html:
- fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple-expected.html:
- fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html:
- fast/layoutformattingcontext/block-only/replaced-intrinsic-width-simple-expected.html:
- fast/layoutformattingcontext/block-only/replaced-intrinsic-width-simple.html:
- fast/layoutformattingcontext/br-and-wbr-simple-expected.html:
- fast/layoutformattingcontext/br-and-wbr-simple.html:
- fast/layoutformattingcontext/br-in-inline-content-simple-expected.html:
- fast/layoutformattingcontext/br-in-inline-content-simple.html:
- fast/layoutformattingcontext/center-alignment-with-block-content-simple-expected.html:
- fast/layoutformattingcontext/center-alignment-with-block-content-simple.html:
- fast/layoutformattingcontext/display/stacking-item-bounds-expected.html:
- fast/layoutformattingcontext/display/stacking-item-bounds.html:
- fast/layoutformattingcontext/empty-block-level-box-with-clearance-expected.html:
- fast/layoutformattingcontext/empty-block-level-box-with-clearance.html:
- fast/layoutformattingcontext/empty-table-box-expected.html:
- fast/layoutformattingcontext/empty-table-box.html:
- fast/layoutformattingcontext/empty-table-with-specified-height-quirk-simple-expected.html:
- fast/layoutformattingcontext/empty-table-with-specified-height-quirk-simple.html:
- fast/layoutformattingcontext/empty-table-with-specified-height-standards-simple-expected.html:
- fast/layoutformattingcontext/empty-table-with-specified-height-standards-simple.html:
- fast/layoutformattingcontext/fit-content-width-simple-expected.html:
- fast/layoutformattingcontext/fit-content-width-simple.html:
- fast/layoutformattingcontext/flex-box-simple.html:
- fast/layoutformattingcontext/float-and-br-inline-content-only-expected.html:
- fast/layoutformattingcontext/float-and-br-inline-content-only.html:
- fast/layoutformattingcontext/float-avoider-available-horizontal-space-expected.html:
- fast/layoutformattingcontext/float-avoider-available-horizontal-space.html:
- fast/layoutformattingcontext/float-avoider-available-horizontal-space2-expected.html:
- fast/layoutformattingcontext/float-avoider-available-horizontal-space2.html:
- fast/layoutformattingcontext/float-avoider-available-horizontal-space3-expected.html:
- fast/layoutformattingcontext/float-avoider-available-horizontal-space3.html:
- fast/layoutformattingcontext/float-avoider-with-inline-content-expected.html:
- fast/layoutformattingcontext/float-avoider-with-inline-content.html:
- fast/layoutformattingcontext/float-avoiding-br-last-line-expected.html:
- fast/layoutformattingcontext/float-avoiding-br-last-line.html:
- fast/layoutformattingcontext/float-avoiding-br-simple-expected.html:
- fast/layoutformattingcontext/float-avoiding-br-simple.html:
- fast/layoutformattingcontext/float-in-inline-context-simple-expected.html:
- fast/layoutformattingcontext/float-in-inline-context-simple.html:
- fast/layoutformattingcontext/float-inside-table-cell-simple-expected.html:
- fast/layoutformattingcontext/float-inside-table-cell-simple.html:
- fast/layoutformattingcontext/float-with-clear-simple-expected.html:
- fast/layoutformattingcontext/float-with-clear-simple.html:
- fast/layoutformattingcontext/floats-shrinking-line-simple-expected.html:
- fast/layoutformattingcontext/floats-shrinking-line-simple.html:
- fast/layoutformattingcontext/flow-integration-basic-paint.html:
- fast/layoutformattingcontext/flow-integration-basic.html:
- fast/layoutformattingcontext/height-percentage-quirk-to-icb-expected.html:
- fast/layoutformattingcontext/height-percentage-quirk-to-icb.html:
- fast/layoutformattingcontext/height-precentage-with-anonymous-wrapper-expected.html:
- fast/layoutformattingcontext/height-precentage-with-anonymous-wrapper.html:
- fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing-expected.html:
- fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing.html:
- fast/layoutformattingcontext/html-is-absolute-positioned-expected.html:
- fast/layoutformattingcontext/html-is-absolute-positioned.html:
- fast/layoutformattingcontext/inlin-box-content-fits-but-the-box-does-not-expected.html:
- fast/layoutformattingcontext/inlin-box-content-fits-but-the-box-does-not.html:
- fast/layoutformattingcontext/inline-box-overlaps-multiple-lines-expected.html:
- fast/layoutformattingcontext/inline-box-overlaps-multiple-lines.html:
- fast/layoutformattingcontext/inline-float-simple-expected.html:
- fast/layoutformattingcontext/inline-float-simple.html:
- fast/layoutformattingcontext/inline-max-width-height-simple-expected.html:
- fast/layoutformattingcontext/inline-max-width-height-simple.html:
- fast/layoutformattingcontext/inline-text-outside-of-inline-container-simple-expected.html:
- fast/layoutformattingcontext/inline-text-outside-of-inline-container-simple.html:
- fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple-expected.html:
- fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple.html:
- fast/layoutformattingcontext/intrusive-floats-takes-entire-horizontal-space-expected.html:
- fast/layoutformattingcontext/intrusive-floats-takes-entire-horizontal-space.html:
- fast/layoutformattingcontext/line-heigt-when-text-is-inside-inline-container-expected.html:
- fast/layoutformattingcontext/line-heigt-when-text-is-inside-inline-container.html:
- fast/layoutformattingcontext/max-content-and-box-sizing-simple-expected.html:
- fast/layoutformattingcontext/max-content-and-box-sizing-simple.html:
- fast/layoutformattingcontext/min-max-content-width-simple-expected.html:
- fast/layoutformattingcontext/min-max-content-width-simple.html:
- fast/layoutformattingcontext/min-max-content-width-simple2-expected.html:
- fast/layoutformattingcontext/min-max-content-width-simple2.html:
- fast/layoutformattingcontext/min-max-content-width-with-floats-simple-expected.html:
- fast/layoutformattingcontext/min-max-content-width-with-floats-simple.html:
- fast/layoutformattingcontext/min-max-content-width-with-nested-floats-simple-expected.html:
- fast/layoutformattingcontext/min-max-content-width-with-nested-floats-simple.html:
- fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html:
- fast/layoutformattingcontext/out-of-flow-positioned-line-breaks.html:
- fast/layoutformattingcontext/out-of-flow-with-non-fixed-height-simple-expected.html:
- fast/layoutformattingcontext/out-of-flow-with-non-fixed-height-simple.html:
- fast/layoutformattingcontext/overflow-at-inline-box-boundary-simple-expected.html:
- fast/layoutformattingcontext/overflow-at-inline-box-boundary-simple.html:
- fast/layoutformattingcontext/quirk-margin-not-collapse-when-floating-expected.html:
- fast/layoutformattingcontext/quirk-margin-not-collapse-when-floating.html:
- fast/layoutformattingcontext/replaced-and-trailing-trimmable-content-expected.html:
- fast/layoutformattingcontext/replaced-and-trailing-trimmable-content.html:
- fast/layoutformattingcontext/replaced-box-with-margin-on-baseline-expected.html:
- fast/layoutformattingcontext/replaced-box-with-margin-on-baseline.html:
- fast/layoutformattingcontext/run-expansion-extends-line-content-width-expected.html:
- fast/layoutformattingcontext/run-expansion-extends-line-content-width.html:
- fast/layoutformattingcontext/simple-absolute-positioned-inline-element-expected.html:
- fast/layoutformattingcontext/simple-absolute-positioned-inline-element.html:
- fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height-expected.html:
- fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html:
- fast/layoutformattingcontext/simple-inline-block-expected.html:
- fast/layoutformattingcontext/simple-inline-block.html:
- fast/layoutformattingcontext/simple-table-with-empty-td.html:
- fast/layoutformattingcontext/subframe-with-display-none-html-expected.html:
- fast/layoutformattingcontext/subframe-with-display-none-html.html:
- fast/layoutformattingcontext/table-basic-row-baseline-align.html:
- fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html:
- fast/layoutformattingcontext/table-basic-row-vertical-align-baseline.html:
- fast/layoutformattingcontext/table-cell-baseline-offset-simple-expected.html:
- fast/layoutformattingcontext/table-cell-baseline-offset-simple.html:
- fast/layoutformattingcontext/table-cell-baseline-offset-simple2-expected.html:
- fast/layoutformattingcontext/table-cell-baseline-offset-simple2.html:
- fast/layoutformattingcontext/table-cell-height-middle-align-simple-expected.html:
- fast/layoutformattingcontext/table-cell-height-middle-align-simple.html:
- fast/layoutformattingcontext/table-cell-vertical-alignment-simple-expected.html:
- fast/layoutformattingcontext/table-cell-vertical-alignment-simple.html:
- fast/layoutformattingcontext/table-colspan-simple-expected.html:
- fast/layoutformattingcontext/table-colspan-simple.html:
- fast/layoutformattingcontext/table-fixed-row-height-simple-expected.html:
- fast/layoutformattingcontext/table-fixed-row-height-simple.html:
- fast/layoutformattingcontext/table-fixed-width-colspans.html:
- fast/layoutformattingcontext/table-fixed-width-variations-simple-expected.html:
- fast/layoutformattingcontext/table-fixed-width-variations-simple.html:
- fast/layoutformattingcontext/table-fixed-width-with-max-distribution.html:
- fast/layoutformattingcontext/table-flex-width-border-collapse.html:
- fast/layoutformattingcontext/table-flex-width-colspans.html:
- fast/layoutformattingcontext/table-min-max-flex-distribution-simple-expected.html:
- fast/layoutformattingcontext/table-min-max-flex-distribution-simple.html:
- fast/layoutformattingcontext/table-min-max-width-empty-content-simple-expected.html:
- fast/layoutformattingcontext/table-min-max-width-empty-content-simple.html:
- fast/layoutformattingcontext/table-min-max-width-simple-expected.html:
- fast/layoutformattingcontext/table-min-max-width-simple.html:
- fast/layoutformattingcontext/table-missing-cells-simple-expected.html:
- fast/layoutformattingcontext/table-missing-cells-simple.html:
- fast/layoutformattingcontext/table-quirk-vertical-margin-simple-expected.html:
- fast/layoutformattingcontext/table-quirk-vertical-margin-simple.html:
- fast/layoutformattingcontext/table-simple-border-collapse-expected.html:
- fast/layoutformattingcontext/table-simple-border-collapse-with-padding-expected.html:
- fast/layoutformattingcontext/table-simple-border-collapse-with-padding.html:
- fast/layoutformattingcontext/table-simple-border-collapse.html:
- fast/layoutformattingcontext/table-simple-border-collapse2-expected.html:
- fast/layoutformattingcontext/table-simple-border-collapse2.html:
- fast/layoutformattingcontext/table-simple-border-collapse3-expected.html:
- fast/layoutformattingcontext/table-simple-border-collapse3.html:
- fast/layoutformattingcontext/table-simple-collapsed-row-border-expected.html:
- fast/layoutformattingcontext/table-simple-collapsed-row-border.html:
- fast/layoutformattingcontext/table-simple-collapsed-row-border2-expected.html:
- fast/layoutformattingcontext/table-simple-collapsed-row-border2.html:
- fast/layoutformattingcontext/table-simple-collapsed-tbody-border-expected.html:
- fast/layoutformattingcontext/table-simple-collapsed-tbody-border.html:
- fast/layoutformattingcontext/table-simple-fixed-width-with-wide-content-expected.html:
- fast/layoutformattingcontext/table-simple-fixed-width-with-wide-content.html:
- fast/layoutformattingcontext/table-simple-multiple-sections-expected.html:
- fast/layoutformattingcontext/table-simple-multiple-sections-with-border-spacing-and-collapse-expected.html:
- fast/layoutformattingcontext/table-simple-multiple-sections-with-border-spacing-and-collapse.html:
- fast/layoutformattingcontext/table-simple-multiple-sections.html:
- fast/layoutformattingcontext/table-simple-row-border-expected.html:
- fast/layoutformattingcontext/table-simple-row-border.html:
- fast/layoutformattingcontext/table-simple-rowspan-with-spacing-expected.html:
- fast/layoutformattingcontext/table-simple-rowspan-with-spacing.html:
- fast/layoutformattingcontext/table-simple-tall-cell-content-with-fixed-height-expected.html:
- fast/layoutformattingcontext/table-simple-tall-cell-content-with-fixed-height.html:
- fast/layoutformattingcontext/table-simple-thead-border-ignore-expected.html:
- fast/layoutformattingcontext/table-simple-thead-border-ignore.html:
- fast/layoutformattingcontext/table-simple-with-border.html:
- fast/layoutformattingcontext/table-simple-with-fixed-widht-and-inline-content.html:
- fast/layoutformattingcontext/table-simple-with-padding.html:
- fast/layoutformattingcontext/table-space-distribution-mixed-width-type-simple-expected.html:
- fast/layoutformattingcontext/table-space-distribution-mixed-width-type-simple.html:
- fast/layoutformattingcontext/table-space-distribution-simple-expected.html:
- fast/layoutformattingcontext/table-space-distribution-simple-mismatching.html:
- fast/layoutformattingcontext/table-space-distribution-simple.html:
- fast/layoutformattingcontext/table-space-distribution-simple2-expected.html:
- fast/layoutformattingcontext/table-space-distribution-simple2.html:
- fast/layoutformattingcontext/table-space-mixed-width-type-simple3-expected.html:
- fast/layoutformattingcontext/table-space-mixed-width-type-simple3.html:
- fast/layoutformattingcontext/table-space-shinking-mixed-width-type-simple-expected.html:
- fast/layoutformattingcontext/table-space-shinking-mixed-width-type-simple.html:
- fast/layoutformattingcontext/table-space-shinking-mixed-width-type-simple2-expected.html:
- fast/layoutformattingcontext/table-space-shinking-mixed-width-type-simple2.html:
- fast/layoutformattingcontext/table-space-width-100-percent-quirk-expected.html:
- fast/layoutformattingcontext/table-space-width-100-percent-quirk.html:
- fast/layoutformattingcontext/table-with-column-spanner-first-row.html:
- fast/layoutformattingcontext/table-with-margin-content-simple-expected.html:
- fast/layoutformattingcontext/table-with-margin-content-simple.html:
- fast/layoutformattingcontext/table-with-margin-simple-expected.html:
- fast/layoutformattingcontext/table-with-margin-simple.html:
- fast/layoutformattingcontext/table-with-padding-and-border-simple-expected.html:
- fast/layoutformattingcontext/table-with-padding-and-border-simple.html:
- fast/layoutformattingcontext/table-with-percent-columns-and-spacing-expected.html:
- fast/layoutformattingcontext/table-with-percent-columns-and-spacing.html:
- fast/layoutformattingcontext/table-with-percent-columns-only-no-content-expected.html:
- fast/layoutformattingcontext/table-with-percent-columns-only-no-content.html:
- fast/layoutformattingcontext/table-with-percent-columns-simple-expected.html:
- fast/layoutformattingcontext/table-with-percent-columns-simple.html:
- fast/layoutformattingcontext/table-with-percent-height-descendant.html:
- fast/layoutformattingcontext/vertical-align-bottom-nested-expected.html:
- fast/layoutformattingcontext/vertical-align-bottom-nested.html:
- fast/layoutformattingcontext/vertical-align-middle-nested-expected.html:
- fast/layoutformattingcontext/vertical-align-middle-nested.html:
- fast/layoutformattingcontext/vertical-align-middle-simple-expected.html:
- fast/layoutformattingcontext/vertical-align-middle-simple.html:
- fast/layoutformattingcontext/vertical-align-top-nested-expected.html:
- fast/layoutformattingcontext/vertical-align-top-nested.html:
- fast/layoutformattingcontext/wbr-simple-expected.html:
- fast/layoutformattingcontext/wbr-simple.html:
- fast/multicol/orphans-ignored-expected.html:
- fast/multicol/orphans-ignored.html:
- fast/repaint/implicitly-positioned-block-repaint-complex-line-layout.html:
- fast/replaced/width100percent-textarea.html:
- fast/text/embed-at-end-of-pre-wrap-line-simple-lines-expected.html:
- fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html:
- fast/text/embed-at-end-of-pre-wrap-line.html:
- fast/text/font-with-no-space-glyph-expected.html:
- fast/text/font-with-no-space-glyph.html:
- fast/text/line-runs-rounding-simple-lines-expected.html:
- fast/text/mark-matches-rendering-simple-lines-expected.html:
- fast/text/multiple-renderers-with-hypen-on-boundary-expected.html:
- fast/text/negative-letter-spacing-visual-overflow-expected.html:
- fast/text/newline-width-expected.html:
- fast/text/newline-width.html:
- fast/text/no-wrap-in-pre-with-word-wrap-expected.html:
- fast/text/no-wrap-in-pre-with-word-wrap.html:
- fast/text/overflow-wrap-break-word-004.html:
- fast/text/overflow-wrap-break-word-005.html:
- fast/text/overflow-wrap-break-word-007.html:
- fast/text/simple-line-hyphens-with-text-align-expected.html:
- fast/text/simple-line-hyphens-with-word-letter-spacing-expected.html:
- fast/text/simple-line-layout-and-multiline-inlineboxtree-expected.html:
- fast/text/simple-line-layout-and-multiline-inlineboxtree.html:
- fast/text/simple-line-layout-dynamic-letter-word-spacing-expected.html:
- fast/text/simple-line-layout-fallback-space-glyph-expected.html:
- fast/text/simple-line-layout-glyph-overflows-line-expected.html:
- fast/text/simple-line-layout-hyphen-limit-after-expected.html:
- fast/text/simple-line-layout-hyphen-limit-before-expected.html:
- fast/text/simple-line-layout-hyphen-limit-lines-expected.html:
- fast/text/simple-line-layout-hyphen-limit-lines2-expected.html:
- fast/text/simple-line-layout-hyphenation-limit-lines-accross-words-expected.html:
- fast/text/simple-line-layout-leading-whitespace-with-soft-hard-linebreak-expected.html:
- fast/text/simple-line-layout-leading-whitespace-with-soft-hard-linebreak.html:
- fast/text/simple-line-layout-line-box-contain-glyphs-expected.html:
- fast/text/simple-line-layout-line-box-contain-glyphs.html:
- fast/text/simple-line-layout-multiple-renderers-non-breaking-space-expected.html:
- fast/text/simple-line-layout-multiple-renderers-with-float-expected.html:
- fast/text/simple-line-layout-selection-with-overflow-expected.html:
- fast/text/simple-line-layout-text-position-with-stroke-expected.html:
- fast/text/simple-line-layout-with-justified-punctuation-expected.html:
- fast/text/simple-line-layout-wrapping-multiple-renderers-hang-expected.html:
- fast/text/simple-line-letterspacing-expected.html:
- fast/text/simple-line-text-indent-expected.html:
- fast/text/simple-line-text-measuring-with-trailing-space-expected.html:
- fast/text/simple-line-with-br-expected.html:
- fast/text/simple-line-with-multiple-renderers-expected.html:
- fast/text/simple-line-wordspacing-expected.html:
- fast/text/simple-lines-float-compare-expected.html:
- fast/text/simple-lines-float-expected.html:
- fast/text/simple-lines-float.html:
- fast/text/simple-lines-intruding-wide-float-expected.html:
- fast/text/simple-lines-range-low-line-height-expected.html:
- fast/text/simple-lines-text-transform-expected.html:
- fast/text/simple-lines-text-transform.html:
- fast/text/whitespace/pre-wrap-008.html:
- fast/text/whitespace/pre-wrap-015.html:
- fast/text/whitespace/pre-wrap-016.html:
- fast/text/whitespace/pre-wrap-line-test-simple-lines-expected.html:
- fast/text/whitespace/pre-wrap-line-test.html:
- fast/text/whitespace/pre-wrap-long-word-simple-lines-expected.html:
- fast/text/whitespace/pre-wrap-long-word-simple-lines.html:
- fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines-expected.html:
- fast/text/whitespace/pre-wrap-spaces-after-newline.html:
- fast/text/whitespace/simple-line-layout-tab-position-expected.html:
- fast/text/word-break-break-all-010.html:
- fast/text/word-break-break-all-011.html:
- printing/simple-lines-break-expected.html:
- 2:10 PM Changeset in webkit [293113] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] imported/blink/fast/text/international-iteration-simple-text.html is a flaky failure
Adding test expectation for newly affected macOS wk2
https://bugs.webkit.org/show_bug.cgi?id=179853
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249819@main
- 1:56 PM Changeset in webkit [293112] by
-
- 5 edits in trunk/LayoutTests
[WebGPU] Unskip api/validation/createTexture.html 🎉
https://bugs.webkit.org/show_bug.cgi?id=239447
Reviewed by Kimmo Kinnunen.
It passes now!!!!
- http/tests/webgpu/webgpu/api/validation/createTexture-expected.txt:
- platform/ios-device-wk1/TestExpectations:
- platform/ios-simulator-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 1:18 PM Changeset in webkit [293111] by
-
- 5 edits in trunk
Unreviewed, reverting r292508.
https://bugs.webkit.org/show_bug.cgi?id=239561
Links to test results are partly broken in layout-tests-
results/results.html
Reverted changeset:
"Fix expected, actual links for variant-based imported wpt
tests"
https://bugs.webkit.org/show_bug.cgi?id=238832
https://commits.webkit.org/r292508
- 12:38 PM Changeset in webkit [293110] by
-
- 7 edits in trunk/Source/WebCore
Avoid repeated calls to eventNames() in a few more places
https://bugs.webkit.org/show_bug.cgi?id=239548
Reviewed by Yusuke Suzuki.
Avoid repeated calls to eventNames() in a few more places given that it accesses threadGlobalData().
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):
- dom/SimulatedClick.cpp:
(WebCore::simulateClick):
- dom/ios/PointerEventIOS.cpp:
(WebCore::buttonsForType):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::eventListenersDidChange):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
- page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::cancelPointer):
- 12:30 PM Changeset in webkit [293109] by
-
- 4 edits2 adds in trunk/Tools
[PGO] run-benchmark should allow pgo profiles to be collected during a benchmark run
https://bugs.webkit.org/show_bug.cgi?id=239313
Add a --profile-output-directory to run-benchmark.
Add helper scripts pgo-profile-merge and pgo-profile-summarize to simplify handling profile output.
Add a script called build-and-collect-pgo-profiles that automates everything.
Reviewed by Dewei Zhu.
- Tools/Scripts/pgo-profile-merge: Added.
- Tools/Scripts/pgo-profile-summarize: Added.
- Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.init):
- Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(config_argument_parser):
(parse_args):
(run_benchmark_plan):
- Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner.init):
(WebServerBenchmarkRunner._get_result):
(WebServerBenchmarkRunner._run_one_test): Deleted.
Canonical link: https://commits.webkit.org/249815@main
- 11:36 AM Changeset in webkit [293108] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] fast/scrolling/overflow-scroll-past-max.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239554
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249814@main
- 10:53 AM Changeset in webkit [293107] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp
Unreviewed build fix. rdar://problem/88672183
./animation/KeyframeEffect.cpp:644:9: error: use of undeclared identifier 'computedKeyframeList'; did you mean 'computedKeyframes'?
- 10:43 AM Changeset in webkit [293106] by
-
- 9 edits2 copies in trunk/Source
[WebGPU] WebKit and WebKitLegacy shouldn't need to know about WebGPU.framework
https://bugs.webkit.org/show_bug.cgi?id=239528
<rdar://problem/91740931>
Unreviewed build fix.
Source/WebCore/PAL:
WebKit and WebKitLegacy create a WebGPU implementation from pal/graphics/WebGPU/Impl. This implementation
knows about WebGPU.framework. However, the create() function doesn't need to know about WebGPU.framework,
and its header doesn't need to include <WebGPU/WebGPU.h>. Only the .cpp files need to know about
<WebGPU/WebGPU.h>, and those .cpp files are invisible from WebKit and WebKitLegacy's points of view. So,
this patch splits the PAL header into:
- A header which includes a creation function, but doesn't know about WebGPU.framework, and
- A header which knows about WebGPU.framework, but doesn't hold the creation function used by WebKit or
WebKitLegacy.
This fixes one of Apple's internal builds.
- PAL.xcodeproj/project.pbxproj:
- pal/graphics/WebGPU/Impl/WebGPUCreateImpl.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp.
(PAL::WebGPU::create):
- pal/graphics/WebGPU/Impl/WebGPUCreateImpl.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.h.
- pal/graphics/WebGPU/Impl/WebGPUImpl.cpp:
(PAL::WebGPU::GPUImpl::create): Deleted.
- pal/graphics/WebGPU/Impl/WebGPUImpl.h:
Source/WebKit:
- GPUProcess/graphics/WebGPU/RemoteGPU.cpp:
(WebKit::RemoteGPU::workQueueInitialize):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createGPUForWebGPU const):
Source/WebKitLegacy/mac:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createGPUForWebGPU const):
- 10:33 AM Changeset in webkit [293105] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239546
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249812@main
- 10:24 AM Changeset in webkit [293104] by
-
- 12 edits in branches/safari-613-branch/Source
Cherry-pick r289100. rdar://problem/79950080
Teach VideoFullscreenInterface to keep track of its corresponding MediaPlayer's MediaPlayerIdentifier
https://bugs.webkit.org/show_bug.cgi?id=236090
Reviewed by Eric Carlson.
Source/WebCore:
Add plumbing for an optional MediaPlayerIdentifier through the video fullscreen model. This identifier is
invalidated uponloadstart, and updated once we observeloadedmetadata, which ensures that if the media
engine (and media player) changes out from underneath the video fullscreen model, we still keep the new player
ID up to date.
See WebKit/ChangeLog for more details.
- platform/cocoa/VideoFullscreenModel.h: (WebCore::VideoFullscreenModelClient::setPlayerIdentifier):
- platform/cocoa/VideoFullscreenModelVideoElement.h:
- platform/cocoa/VideoFullscreenModelVideoElement.mm: (WebCore::VideoFullscreenModelVideoElement::updateForEventName): (WebCore::VideoFullscreenModelVideoElement::observedEventNames):
Additionally listen for
loadstartEventandloadedmetadataEvent(see above).
(WebCore::VideoFullscreenModelVideoElement::setPlayerIdentifier):
- platform/ios/VideoFullscreenInterfaceAVKit.h:
- platform/mac/VideoFullscreenInterfaceMac.h: (WebCore::VideoFullscreenInterfaceMac::playerIdentifier const):
Source/WebKit:
Add an IPC message between VideoFullscreenManager and VideoFullscreenManagerProxy to update the media player ID
corresponding to a given PlaybackSessionContextIdentifier. This is sent if the underlying media player changes
(and subsequently firesloadstartandloadedmetadataevents), and also sent upon entering fullscreen video.
In a future patch, this mechanism will be used to teach VideoFullscreenManagerProxy to grab an image bitmap from
the GPU process for a given PlaybackSessionContextIdentifier.
- UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
- UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in:
- UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: (WebKit::VideoFullscreenManagerProxy::setPlayerIdentifier):
- WebProcess/cocoa/VideoFullscreenManager.h:
- WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenInterfaceContext::setPlayerIdentifier): (WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement): (WebKit::VideoFullscreenManager::setPlayerIdentifier):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:24 AM Changeset in webkit [293103] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore/Modules/fetch
Unreviewed build fix. rdar://problem/91446363
Source/WebCore/Modules/fetch/FormDataConsumer.h:56:18: error: 'auto' not allowed in function prototype
- 10:09 AM Changeset in webkit [293102] by
-
- 10 edits in branches/safari-614.1.10-branch
Cherry-pick r293043. rdar://problem/91910145
Various WebKit tools need to be told about the system content path
https://bugs.webkit.org/show_bug.cgi?id=239516
Reviewed by Ryan Haddad.
Source/JavaScriptCore:
Added the INSTALL_PATH_PREFIX to the INSTALL_PATH for TestAPI and the JSC tools.
This will contain the system content path prefix when enabled.
- Configurations/TestAPI.xcconfig:
- Configurations/ToolExecutable.xcconfig:
Tools:
Added the INSTALL_PATH_PREFIX to the INSTALL_PATH for the webkit test tools.
This will contain the system content path prefix when enabled.
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
- DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
- DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:08 AM Changeset in webkit [293101] by
-
- 110 edits29 adds in trunk
[WebGPU] Update WebGPU CTS to revision 549d7c2f1637321a9247f0a3ab022f919e5ca5da
https://bugs.webkit.org/show_bug.cgi?id=239444
Reviewed by Kimmo Kinnunen.
Tools:
- Scripts/import-webgpu-cts:
LayoutTests:
This includes a fix for api/validation/createTexture.
- http/tests/webgpu/common/framework/fixture.js:
(export.Fixture.prototype.eventualExpectOK):
(export.Fixture):
- http/tests/webgpu/common/internal/version.js:
- http/tests/webgpu/cts.https.html:
- http/tests/webgpu/webgpu/api/operation/adapter/requestDevice_limits.spec.js:
(g.test.string_appeared_here.desc.Test.that.specifying.limits.that.aren.requestDevice.to.reject.fn.async t):
(string_appeared_here.fn.async t):
(kLimits.beginSubcases.expandWithParams.p.switch.case):
(kLimits.beginSubcases.expandWithParams.p.switch):
(fn.async t):
(fn.async t.switch.case):
(65535.fn.async t): Deleted.
- http/tests/webgpu/webgpu/api/operation/command_buffer/copyTextureToTexture.spec.js:
(F.prototype.GetRenderPipelineForT2TCopyWithDepthTests):
- http/tests/webgpu/webgpu/api/operation/command_buffer/image_copy.spec.js:
(0.and.is.isnstring_appeared_heret.power.of.2.values.also.including.ImageCopyTest.prototype.async checkStencilTextureContent):
(0.and.is.isnstring_appeared_heret.power.of.2.values.also.including.ImageCopyTest.prototype.DoCopyTextureToBufferWithDepthAspectTest):
(0.and.is.isnstring_appeared_heret.power.of.2.values.also.including.ImageCopyTest):
- http/tests/webgpu/webgpu/api/operation/command_buffer/programmable/programmable_state_test.js:
(export.ProgrammableStateTest.prototype.createBindingStatePipeline):
- http/tests/webgpu/webgpu/api/operation/command_buffer/render/state_tracking.spec.js:
(VertexAndIndexStateTrackingTest.prototype.GetRenderPipelineForTest):
(VertexAndIndexStateTrackingTest):
(The.test.verifies.both.of.these.two.draw.calls.work.correctly.fn.async t):
- http/tests/webgpu/webgpu/api/operation/compute/basic.spec.js:
(g.test.string_appeared_here.fn.async t):
(kMaxComputeWorkgroupSize.p.largeDimension.fn.async t):
- http/tests/webgpu/webgpu/api/operation/memory_sync/buffer/buffer_sync_test.js:
(export.checkOpsValidForContext):
(export.BufferSyncTest.prototype.async createIntermediateBuffersAndTexturesForWriteOp):
(export.BufferSyncTest.prototype.async createBuffersForReadOp):
(export.BufferSyncTest.prototype.async createBufferWithValue):
(export.BufferSyncTest.prototype.async createBufferWithValues):
(export.BufferSyncTest.prototype.async createTextureWithValue):
(export.BufferSyncTest.prototype.createStorageWriteComputePipeline):
(export.BufferSyncTest.prototype.createTrivialRenderPipeline):
(export.BufferSyncTest.prototype.createStorageWriteRenderPipeline):
(export.BufferSyncTest.prototype.beginSimpleRenderPass):
(export.BufferSyncTest.prototype.encodeWriteAsStorageBufferInRenderPass):
(export.BufferSyncTest.prototype.encodeWriteAsStorageBufferInComputePass):
(export.BufferSyncTest.prototype.encodeWriteByB2BCopy):
(export.BufferSyncTest.prototype.encodeWriteByT2BCopy):
(export.BufferSyncTest.prototype.writeByWriteBuffer):
(export.BufferSyncTest.prototype.encodeWriteOp):
(export.BufferSyncTest.prototype.createStorageReadComputePipeline):
(export.BufferSyncTest.prototype.createBindGroupSrcDstBuffer):
(export.BufferSyncTest.prototype.createVertexReadRenderPipeline):
(export.BufferSyncTest.prototype.createUniformReadRenderPipeline):
(export.BufferSyncTest.prototype.createStorageReadRenderPipeline):
(export.BufferSyncTest.prototype.encodeReadAsStorageBufferInComputePass):
(export.BufferSyncTest.prototype.encodeReadAsIndirectBufferInComputePass):
(export.BufferSyncTest.prototype.encodeReadAsVertexBufferInRenderPass):
(export.BufferSyncTest.prototype.encodeReadAsIndexBufferInRenderPass):
(export.BufferSyncTest.prototype.encodeReadAsIndirectBufferInRenderPass):
(export.BufferSyncTest.prototype.encodeReadAsIndexedIndirectBufferInRenderPass):
(export.BufferSyncTest.prototype.encodeReadAsUniformBufferInRenderPass):
(export.BufferSyncTest.prototype.encodeReadAsStorageBufferInRenderPass):
(export.BufferSyncTest.prototype.encodeReadByB2BCopy):
(export.BufferSyncTest.prototype.encodeReadByB2TCopy):
(export.BufferSyncTest.prototype.encodeReadOp):
(export.BufferSyncTest.prototype.async encodeWriteByB2BCopy): Deleted.
(export.BufferSyncTest.prototype.async encodeWriteByT2BCopy): Deleted.
(export.BufferSyncTest.prototype.async encodeWriteOp): Deleted.
(export.BufferSyncTest.prototype.async createCommandBufferWithWriteOp): Deleted.
(export.BufferSyncTest.prototype.async submitWriteOp): Deleted.
- http/tests/webgpu/webgpu/api/operation/memory_sync/buffer/multiple_buffers.html: Added.
- http/tests/webgpu/webgpu/api/operation/memory_sync/buffer/multiple_buffers.spec.js: Added.
- http/tests/webgpu/webgpu/api/operation/memory_sync/buffer/single_buffer-expected.txt: Added.
- http/tests/webgpu/webgpu/api/operation/memory_sync/buffer/single_buffer.html: Added.
- http/tests/webgpu/webgpu/api/operation/memory_sync/buffer/single_buffer.spec.js: Added.
(p.kBoundaryInfo.p.boundary.contexts.expandWithParams):
(fn.async t):
(true.fn.async t):
(g.test.string_appeared_here.desc.Test.write.after.write.operations.in.the.same.render.bundle.The.first.write.will.write.1.into.a.storage.buffer.The.second.write.will.write.2.into.the.same.buffer.in.the.same.pass.Expected.data.in.buffer.is.either.1.or.2.fn.async t):
(g.test.string_appeared_here.desc.Test.write.after.write.operations.in.the.same.compute.pass.The.first.write.will.write.1.into.a.storage.buffer.The.second.write.will.write.2.into.the.same.buffer.in.the.same.pass.Expected.data.in.buffer.is.2.fn.async t):
- http/tests/webgpu/webgpu/api/operation/memory_sync/operation_context_helper.js: Added.
(combineContexts):
(export.OperationContextHelper):
(export.OperationContextHelper.prototype.ensureSubmit):
(export.OperationContextHelper.prototype.popContext):
(export.OperationContextHelper.prototype.makeDummyAttachment):
(export.OperationContextHelper.prototype.ensureContext):
(export.OperationContextHelper.prototype.flushRenderBundles):
(export.OperationContextHelper.prototype.flushCommandBuffers):
(export.OperationContextHelper.prototype.ensureBoundary):
- http/tests/webgpu/webgpu/api/operation/memory_sync/texture/same_subresource.spec.js:
(TextureSyncTestHelper):
(TextureSyncTestHelper.prototype.performWriteOp):
(TextureSyncTestHelper.prototype.ensureSubmit): Deleted.
(TextureSyncTestHelper.prototype.popContext): Deleted.
(TextureSyncTestHelper.prototype.makeDummyAttachment): Deleted.
(TextureSyncTestHelper.prototype.ensureContext): Deleted.
(TextureSyncTestHelper.prototype.flushRenderBundles): Deleted.
(TextureSyncTestHelper.prototype.flushCommandBuffers): Deleted.
(TextureSyncTestHelper.prototype.ensureBoundary): Deleted.
- http/tests/webgpu/webgpu/api/operation/memory_sync/texture/texture_sync_test.js:
(combineContexts): Deleted.
- http/tests/webgpu/webgpu/api/operation/render_pass/resolve.spec.js:
- http/tests/webgpu/webgpu/api/operation/render_pass/storeOp.spec.js:
(kArrayLayers.fn.t.else):
- http/tests/webgpu/webgpu/api/operation/rendering/basic.spec.js:
- http/tests/webgpu/webgpu/api/operation/rendering/blending.spec.js:
- http/tests/webgpu/webgpu/api/operation/rendering/depth.spec.js:
- http/tests/webgpu/webgpu/api/operation/rendering/depth_clip_clamp.spec.js:
(fn.async t):
- http/tests/webgpu/webgpu/api/operation/rendering/draw.spec.js:
(9.undefined.fn.async t):
- http/tests/webgpu/webgpu/api/operation/resource_init/buffer.spec.js:
- http/tests/webgpu/webgpu/api/operation/resource_init/check_texture/by_copy.js:
(export.const.checkContentsByBufferCopy):
(export.const.checkContentsByTextureCopy):
- http/tests/webgpu/webgpu/api/operation/resource_init/check_texture/by_ds_test.js:
(const.checkContents):
- http/tests/webgpu/webgpu/api/operation/resource_init/check_texture/by_sampling.js:
(export.const.checkContentsBySampling):
- http/tests/webgpu/webgpu/api/operation/resource_init/texture_zero.spec.js:
(export.TextureZeroInitTest.prototype.initializeWithStoreOp):
(export.TextureZeroInitTest.prototype.discardTexture):
(export.TextureZeroInitTest):
- http/tests/webgpu/webgpu/api/operation/sampling/anisotropy.spec.js:
(SamplerAnisotropicFilteringSlantedPlaneTest.prototype.async init):
- http/tests/webgpu/webgpu/api/operation/texture_view/format_reinterpretation-expected.txt: Added.
- http/tests/webgpu/webgpu/api/operation/texture_view/format_reinterpretation.html: Added.
- http/tests/webgpu/webgpu/api/operation/texture_view/format_reinterpretation.spec.js: Added.
(makeInputTexelView):
(viewFormat.fn.async t):
(4.fn.async t):
- http/tests/webgpu/webgpu/api/operation/texture_view/read.spec.js:
- http/tests/webgpu/webgpu/api/operation/texture_view/write.spec.js:
- http/tests/webgpu/webgpu/api/operation/vertex_state/correctness.spec.js:
(prototype.makeTestWGSL):
- http/tests/webgpu/webgpu/api/validation/attachment_compatibility.spec.js:
(F.prototype.createColorAttachment):
(F.prototype.createRenderPipeline):
(F):
(string_appeared_here.filter.p.p.format.depthStencilInfo.stencil):
(fn.async t):
- http/tests/webgpu/webgpu/api/validation/buffer/create.spec.js:
- http/tests/webgpu/webgpu/api/validation/createBindGroup.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/createBindGroupLayout.spec.js:
(prototype.async g): Deleted.
- http/tests/webgpu/webgpu/api/validation/createComputePipeline.spec.js:
(making.sure.that.the.test.working):
- http/tests/webgpu/webgpu/api/validation/createRenderPipeline.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/createTexture.spec.js:
(format.unless):
(2.fn.async t):
(fn.async t):
(format.fn.async t):
(kTextureFormats.fn.async t):
- http/tests/webgpu/webgpu/api/validation/createView.spec.js:
(true.fn.async t):
(kTextureFormats.fn.async t): Deleted.
- http/tests/webgpu/webgpu/api/validation/encoding/beginRenderPass.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/buffer_texture_copies.spec.js:
(string_appeared_here.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/clearBuffer.spec.js:
(kResourceStates.fn.async t):
(false.fn.async t):
(g.test.string_appeared_here.desc.Test.that.clearing.an.error.buffer.fails.fn.async t): Deleted.
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/compute_pass.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyBufferToBuffer.spec.js:
(F.prototype.TestCopyBufferToBuffer):
(F):
(kResourceStates.fn.async t):
(fn.async t):
(kBufferUsages.fn.async t):
(g.test.string_appeared_here.fn.async t): Deleted.
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyTextureToTexture.spec.js:
(fn.async t):
(kTextureFormats.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/indirect_draw.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setIndexBuffer.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setPipeline.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setVertexBuffer.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/state_tracking.spec.js:
(F.prototype.createRenderPipeline):
- http/tests/webgpu/webgpu/api/validation/encoding/cmds/setBindGroup.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/programmable/pipeline_bind_group_compat.spec.js:
(F.prototype.createComputePipelineWithLayout):
- http/tests/webgpu/webgpu/api/validation/encoding/queries/general.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/queries/resolveQuerySet.spec.js:
(g.test.string_appeared_here.desc.Tests.that.resolve.query.set must.be.with.valid.query.set and):
(g.test.string_appeared_here.desc.Tests.that.resolve.query.set must):
(kResourceStates.fn.async t):
- http/tests/webgpu/webgpu/api/validation/encoding/render_bundle.spec.js:
(fn.async t):
- http/tests/webgpu/webgpu/api/validation/image_copy/buffer_related.spec.js:
(kResourceStates.fn.async t):
(false.fn.async t):
(fn.async t):
(bytesPerRow.undefined.copyHeightInBlocks.1.bytesPerRow.undefined.bytesPerRow.kTextureFormatInfo.format.bytesPerBlock.fn.async t):
- http/tests/webgpu/webgpu/api/validation/image_copy/image_copy.js:
(export.ImageCopyTest.prototype.testBuffer):
(export.ImageCopyTest):
- http/tests/webgpu/webgpu/api/validation/image_copy/layout_related.spec.js:
(fn.async t):
(unless.p.p.dimension.string_appeared_here.p.copyHeightInBlocks.1.p.copyDepth.1.fn.async t): Deleted.
- http/tests/webgpu/webgpu/api/validation/image_copy/texture_related.spec.js:
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/queue/copyToTexture/CopyExternalImageToTexture.spec.js:
- http/tests/webgpu/webgpu/api/validation/queue/submit.spec.js:
(fn.async t):
- http/tests/webgpu/webgpu/api/validation/queue/writeBuffer.spec.js:
(kResourceStates.fn.async t):
(g.test.string_appeared_here.desc.Tests.that.the.data.ranges.given.to.GPUQueue.writeBuffer.are.properly.validated.Tests.calling.writeBuffer.with.both.TypedArrays.and.ArrayBuffers.and.checks.that.the.data.offset.and.size.is.interpreted.correctly.both.When.passing.a.TypedArray.the.data.offset.and.size.is.given.in.elements.When.passing.an.ArrayBuffer.the.data.offset.and.size.is.given.in.bytes.Also.verifies.that.the.specified.data.range.Describes.a.valid.range.of.the.destination.buffer.and.source.buffer.Fits.fully.within.the.destination.buffer.Has.a.byte.size.is.a.multiple.of.4.fn.async t.runTest):
(g.test.string_appeared_here.desc.Tests.that.the.data.ranges.given.to.GPUQueue.writeBuffer.are.properly.validated.Tests.calling.writeBuffer.with.both.TypedArrays.and.ArrayBuffers.and.checks.that.the.data.offset.and.size.is.interpreted.correctly.both.When.passing.a.TypedArray.the.data.offset.and.size.is.given.in.elements.When.passing.an.ArrayBuffer.the.data.offset.and.size.is.given.in.bytes.Also.verifies.that.the.specified.data.range.Describes.a.valid.range.of.the.destination.buffer.and.source.buffer.Fits.fully.within.the.destination.buffer.Has.a.byte.size.is.a.multiple.of.4.fn.async t):
(false.fn.async t):
- http/tests/webgpu/webgpu/api/validation/render_pass_descriptor.spec.js:
(true.fn.async t):
- http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_pass_encoder.spec.js:
(unless.p.kTextureFormatInfo.p.format.depth.kTextureFormatInfo.p.format.stencil.p.aspect0.string_appeared_here.p.type0.string_appeared_here.p.aspect1.string_appeared_here.p.type1.string_appeared_here.unless.p.p.binding1InBundle.p.type1.string_appeared_here.unless.p.p.compute.p.binding0InBundle.p.binding1InBundle.p.type1.string_appeared_here.fn.async t):
- http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_render_common.spec.js:
(F.prototype.createBindGroupForTest):
(F.prototype.isRangeNotOverlapped):
(F):
(false.unless.t.t.inSamePass.t.level0.t.level1.fn.async t):
(false.fn.async t):
(false.unless.t.t.inSamePass.t.baseLevel0.t.baseLevel1.fn.async t): Deleted.
- http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_render_misc.spec.js:
(F.prototype.createBindGroupLayoutForTest):
(F.prototype.createBindGroupForTest):
(F):
(false.fn.async t):
(usage0.string_appeared_here.usage0.string_appeared_here.usage1.string_appeared_here.usage1.string_appeared_here.fn.async t):
(or.different.subresources.of.the.same.texture.texture.usages.in.copies.and.in.render.pass.consecutively.set bind): Deleted.
- http/tests/webgpu/webgpu/api/validation/state/device_lost/destroy-expected.txt: Added.
- http/tests/webgpu/webgpu/api/validation/state/device_lost/destroy.html: Added.
- http/tests/webgpu/webgpu/api/validation/state/device_lost/destroy.spec.js: Added.
(DeviceDestroyTests.prototype.async executeAfterDestroy):
(DeviceDestroyTests.prototype.async executeCommandsAfterDestroy):
(DeviceDestroyTests):
(false.filter):
(false.fn.async t):
(fn.async t):
(g.test.string_appeared_here.desc.Tests.creating.bind.group.on.destroyed.device.Tests.valid.combinations.of.Various.binded.resource.types.Various.valid.binding.entries.Maximum.set of):
(g.test.string_appeared_here.desc.Tests.creating.bind.group.layouts.on.destroyed.device.Tests.valid.combinations.of.Various.valid.binding.entries.Maximum.set of):
- http/tests/webgpu/webgpu/api/validation/validation_test.js:
(export.ValidationTest.prototype.getNoOpShaderCode):
(export.ValidationTest.prototype.createNoOpRenderPipeline):
(export.ValidationTest.prototype.createNoOpComputePipeline):
- http/tests/webgpu/webgpu/api/validation/vertex_state.spec.js:
- http/tests/webgpu/webgpu/capability_info.js:
(export.resolvePerAspectFormat):
(export.viewCompatible):
- http/tests/webgpu/webgpu/constants.js:
- http/tests/webgpu/webgpu/gpu_test.js:
(export.GPUTest.prototype.expectSingleColor):
(export.GPUTest.prototype.readSinglePixelFrom2DTexture):
(export.GPUTest.prototype.async expectDeviceLost):
(export.GPUTest.prototype.makeTextureWithContents):
(export.GPUTest.prototype.createEncoder):
(export.GPUTest):
(export.GPUTest.prototype.async makeBufferWithContents): Deleted.
- http/tests/webgpu/webgpu/listing.js:
- http/tests/webgpu/webgpu/shader/execution/evaluation_order-expected.txt: Added.
- http/tests/webgpu/webgpu/shader/execution/evaluation_order.html: Added.
- http/tests/webgpu/webgpu/shader/execution/evaluation_order.spec.js: Added.
(run):
- http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_arithmetic.spec.js:
(calculateResults):
(makeCaseImpl):
(4.fn.async t):
(fullNumericRange): Deleted.
- http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_logical-expected.txt: Added.
- http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_logical.html: Added.
- http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_logical.spec.js: Added.
(makeCase):
(4.fn.async t):
- http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/atan.spec.js:
(4.fn.async t):
- http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/atan2.spec.js:
(4.fn.async t):
- http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/clamp.spec.js:
(calculateMinMaxClamp):
(calculateMedianClamp):
(generateIntegerTestCases):
(generateFloatTestCases):
(4.fn.async t):
(generateTestCases): Deleted.
- http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/inversesqrt.spec.js:
(4.fn.async t):
- http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/ldexp.spec.js:
(4.fn.async t):
- http/tests/webgpu/webgpu/shader/execution/expression/expression.js:
- http/tests/webgpu/webgpu/shader/execution/expression/unary/f32_arithmetic.spec.js:
(4.fn.async t):
- http/tests/webgpu/webgpu/shader/execution/memory_model/memory_model_setup.js:
- http/tests/webgpu/webgpu/shader/execution/robust_access.spec.js:
(runShaderTest):
- http/tests/webgpu/webgpu/shader/execution/robust_access_vertex.spec.js:
(F.prototype.generateVertexShaderCode):
- http/tests/webgpu/webgpu/shader/execution/sampling/gradients_in_varying_loop.spec.js:
(DerivativesTest.prototype.async init):
- http/tests/webgpu/webgpu/shader/execution/shader_io/compute_builtins.spec.js:
- http/tests/webgpu/webgpu/shader/execution/shader_io/shared_structs.spec.js:
(and.the.layout.attributes.should.be.ignored.when.used.as.an.entry.point.IO.parameter.fn.async t):
(and.uses.it.as.both.the.output.of.a.vertex.shader.and.the.input.to.a.fragment.shader.fn.async t):
(and.uses.those.structures.as.parameter.and.return.types.entry.point.functions.and.regular.functions.fn.async t):
- http/tests/webgpu/webgpu/shader/execution/zero_init.spec.js:
- http/tests/webgpu/webgpu/shader/types.js:
- http/tests/webgpu/webgpu/shader/validation/shader_io/builtins.spec.js:
- http/tests/webgpu/webgpu/shader/validation/shader_io/generic.spec.js:
- http/tests/webgpu/webgpu/shader/validation/shader_io/invariant.spec.js:
(false.beginSubcases.fn.t.const.code.struct.VertexOut.location):
- http/tests/webgpu/webgpu/shader/validation/shader_io/locations.spec.js:
- http/tests/webgpu/webgpu/shader/validation/shader_io/util.js:
(export.generateShader):
- http/tests/webgpu/webgpu/shader/validation/tokens-expected.txt: Added.
- http/tests/webgpu/webgpu/shader/validation/tokens.html: Added.
- http/tests/webgpu/webgpu/shader/validation/tokens.spec.js: Added.
(string_appeared_here.beginSubcases.fn.t.else):
- http/tests/webgpu/webgpu/shader/validation/variable_and_const.spec.js:
(fn.t.prototype.else):
- http/tests/webgpu/webgpu/util/check_contents.js:
- http/tests/webgpu/webgpu/util/color_space_conversion.js:
(XYZ_to_lin_sRGB):
(lin_P3_to_XYZ):
(XYZ_to_lin_P3):
(export.makeInPlaceColorConversion):
- http/tests/webgpu/webgpu/util/command_buffer_maker.js:
(export.CommandBufferMaker):
- http/tests/webgpu/webgpu/util/conversion.js:
(export.floatAsNormalizedInteger):
(export.float32ToFloatBits):
(export.numberToFloatBits):
- http/tests/webgpu/webgpu/util/copy_to_texture.js:
(export.CopyToTextureUtils.prototype.getExpectedPixels):
(export.CopyToTextureUtils.prototype.doTestAndCheckResult):
(export.CopyToTextureUtils):
(isFp16Format): Deleted.
(isFp32Format): Deleted.
(isUnormFormat): Deleted.
(export.CopyToTextureUtils.prototype.formatForExpectedPixels): Deleted.
(export.CopyToTextureUtils.prototype.getSourceImageBitmapPixels): Deleted.
(export.CopyToTextureUtils.prototype.checkCopyExternalImageResult): Deleted.
(export.CopyToTextureUtils.prototype.async checkBufferWithRowPitch): Deleted.
- http/tests/webgpu/webgpu/util/create_elements.js:
(export.canCopyFromCanvasContext):
(export.createCanvas):
- http/tests/webgpu/webgpu/util/device_pool.js:
(export.DevicePool.prototype.async reserve):
(export.DevicePool.prototype.async release):
(export.DevicePool):
(canonicalizeDescriptor):
(DeviceHolder.prototype.expectDeviceLost):
- http/tests/webgpu/webgpu/util/math.js:
- http/tests/webgpu/webgpu/util/texture.js: Added.
(export.makeTextureWithContents):
- http/tests/webgpu/webgpu/util/texture/layout.js:
(export.getTextureCopyLayout):
- http/tests/webgpu/webgpu/util/texture/texel_data.js:
(export.makeClampToRange):
(unpackComponentsBits):
(makeNormalizedInfo):
(makeIntegerInfo):
(makeFloatInfo):
(packComponents): Deleted.
(export.const.kTexelRepresentationInfo.rgba32float.makeFloatInfo): Deleted.
(export.getSingleDataType): Deleted.
(export.getComponentReadbackTraits): Deleted.
- http/tests/webgpu/webgpu/util/texture/texel_view.js: Added.
(export.TexelView.prototype.fromTextureDataByReference):
(export.TexelView.fromTexelsAsBytes):
(export.TexelView.prototype.fromTexelsAsColors):
(export.TexelView.prototype.writeTextureData):
(export.TexelView):
- http/tests/webgpu/webgpu/util/texture/texture_ok-expected.txt: Added.
- http/tests/webgpu/webgpu/util/texture/texture_ok.html: Added.
- http/tests/webgpu/webgpu/util/texture/texture_ok.js: Added.
(makeTexelViewComparer):
(makeTexelViewComparer.):
- http/tests/webgpu/webgpu/util/texture/texture_ok.spec.js: Added.
(fn.async t):
- http/tests/webgpu/webgpu/web_platform/canvas/readbackFromWebGPUCanvas.spec.js:
(allCanvasTypes.fn.async t): Deleted.
- http/tests/webgpu/webgpu/web_platform/copyToTexture/ImageBitmap.spec.js:
(makeTestColorsTexelView):
(F.prototype.generatePixel): Deleted.
(F.prototype.getImagePixels): Deleted.
(F): Deleted.
(fn.async t): Deleted.
- http/tests/webgpu/webgpu/web_platform/copyToTexture/canvas.spec.js:
(F.prototype.init2DCanvasContentWithColorSpace):
(F.prototype.init2DCanvasContent):
(F.prototype.initGLCanvasContent):
(F.prototype.getInitGPUCanvasData):
(F.prototype.initGPUCanvasContent):
(F.prototype.calculateSourceContentOnCPU):
(F):
(fn.async t):
(F.prototype.getTestImageURLByColorSpace): Deleted.
- platform/ios-device-wk1/TestExpectations:
- platform/ios-simulator-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 9:35 AM Changeset in webkit [293100] by
-
- 4 edits in trunk/Source/WebCore
[css-cascade] Optimize code for deferred properties
https://bugs.webkit.org/show_bug.cgi?id=238260
Reviewed by Darin Adler.
CSS declarations for deferred properties were just appended to a vector,
which could grow huge. Then StyleBuilder would apply them one by one,
doing useless work if a property appeared multiple times.
The point of deferred properties is that they should be applied in
relative order. But if a property appears multiple times, we should only
care about the last occurrence.
So this patch removes the vector and instead stores the Property in the
same array as non-deferred properties. To track the indices, it uses an
array instead of a HashMap.
When applying the properties, the property IDs are placed in a vector,
which is then sorted according to the corresponding indices. This can
have some overhead, but the size of the vector will be limited by the
number of deferred properties. Currently there are only 8 of these (in
bug 236199 I plan to add 96 more, but 104 is still not that big).
No new tests since there should be no change in behavior.
- style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::buildCascade):
Call sortDeferredPropertyIDs().
(WebCore::Style::initializeCSSValue):
Move a low-level idiom into its own function.
(WebCore::Style::PropertyCascade::set):
Use the new initializeCSSValue().
(WebCore::Style::PropertyCascade::setDeferred):
Use the new data structures for deferred properties.
(WebCore::Style::PropertyCascade::sortDeferredPropertyIDs):
New private method to sort the deferred property IDs according to their
index.
- style/PropertyCascade.h:
(WebCore::Style::PropertyCascade::deferredPropertyIndex const):
New private method to get the index of the deferred property.
(WebCore::Style::PropertyCascade::setDeferredPropertyIndex):
New private method to set the index of a deferred property.
(WebCore::Style::PropertyCascade::hasDeferredProperty const):
Use the new data structures for deferred properties.
(WebCore::Style::PropertyCascade::deferredProperty const):
Use the new data structures for deferred properties.
(WebCore::Style::PropertyCascade::deferredPropertyIDs const):
New method to get the deferred property IDs sorted by their index.
(WebCore::Style::PropertyCascade::deferredProperties const): Deleted.
- style/StyleBuilder.cpp:
(WebCore::Style::Builder::applyDeferredProperties):
Use the new data structures for deferred properties.
- 9:17 AM Changeset in webkit [293099] by
-
- 2 edits in trunk/Tools
[ Monterey Release arm64 ] TestWebKitAPI.ContentRuleList.ResourceTypes is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239523
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-20
Reviewed by Chris Dumez.
If the request count isn't the expected value, wait until it is.
- TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
(TEST):
- 9:10 AM Changeset in webkit [293098] by
-
- 8 edits1 move1 add1 delete in trunk/Source/WebGPU
[WebGPU] Expand hardware capabilities to include features (beyond just limits)
https://bugs.webkit.org/show_bug.cgi?id=239443
Reviewed by Kimmo Kinnunen.
Only MTLGPUFamilyApple devices support depth/stencil textures in the managed/shared address space.
So, we have to expand the hardware capabilities infrastructure to be able to hold this kind
of information (so the texture creation function can consult with this state to know what storage
mode to use for the created texture). This patch replaces the stored WGPULimits struct with a new
struct, HardwareCapabilities, which holds a WGPULimits iniside it.
While I was here, I also included a Vector<WGPUFeature> inside the HardwareCapabilities struct,
and hooked it up to the various places which need to be guarded by the presence of features.
This is needed for compressed textures to work (among other things). Because there are only
a handful of possible features, I elected to use a sorted Vector instead of using the big HashSet
hammer.
- WebGPU.xcodeproj/project.pbxproj:
- WebGPU/Adapter.h:
(WebGPU::Adapter::create):
- WebGPU/Adapter.mm:
(WebGPU::Adapter::Adapter):
(WebGPU::Adapter::enumerateFeatures):
(WebGPU::Adapter::getLimits):
(WebGPU::Adapter::hasFeature):
(WebGPU::Adapter::requestDevice):
- WebGPU/Device.h:
(WebGPU::Device::limits const):
(WebGPU::Device::features const):
(WebGPU::Device::baseCapabilities const):
- WebGPU/Device.mm:
(WebGPU::Device::create):
(WebGPU::Device::Device):
(WebGPU::Device::enumerateFeatures):
(WebGPU::Device::getLimits):
(WebGPU::Device::hasFeature):
- WebGPU/HardwareCapabilities.h: Renamed from Source/WebGPU/WebGPU/HardwareLimits.h.
- WebGPU/HardwareCapabilities.mm: Added.
(WebGPU::baseCapabilities):
(WebGPU::baseFeatures):
(WebGPU::apple3):
(WebGPU::apple4):
(WebGPU::apple5):
(WebGPU::apple6):
(WebGPU::apple7):
(WebGPU::mac2):
(WebGPU::mergeMaximum):
(WebGPU::mergeAlignment):
(WebGPU::mergeLimits):
(WebGPU::mergeFeatures):
(WebGPU::mergeBaseCapabilities):
(WebGPU::rawHardwareCapabilities):
(WebGPU::anyLimitIsBetterThan):
(WebGPU::includesUnsupportedFeatures):
(WebGPU::checkLimits):
(WebGPU::hardwareCapabilities):
(WebGPU::isValid):
- WebGPU/HardwareLimits.mm: Removed.
- WebGPU/Instance.mm:
(WebGPU::Instance::requestAdapter):
- WebGPU/Texture.mm:
(WebGPU::featureRequirementForFormat):
(WebGPU::Device::validateCreateTexture):
(WebGPU::storageMode):
(WebGPU::Device::createTexture):
- 9:03 AM Changeset in webkit [293097] by
-
- 2 edits in branches/safari-614.1.10-branch/Source/WebGPU
Cherry-pick r292760. rdar://problem/91351306
[WebGPU] Fix the tvOS build (again)
https://bugs.webkit.org/show_bug.cgi?id=239106
<rdar://problem/91351306>
Unreviewed.
Turns out PLATFORM(APPLETV) and PLATFORM(TVOS) are different things.
- WebGPU/Texture.mm: (WebGPU::Device::createTexture): (WebGPU::Texture::createView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:56 AM Changeset in webkit [293096] by
-
- 2 edits in trunk/Source/WebCore/PAL
[WebGPU] Fix texture conversion format typo
https://bugs.webkit.org/show_bug.cgi?id=239446
Reviewed by Kimmo Kinnunen.
I mixed up "plus" and "unorm".
- pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp:
(PAL::WebGPU::ConvertToBackingContext::convertToBacking):
- 8:32 AM Changeset in webkit [293095] by
-
- 2 edits in trunk/Source/WebGPU
[WebGPU] RGB9E5Ufloat textures are not renderable
https://bugs.webkit.org/show_bug.cgi?id=239445
Reviewed by Kimmo Kinnunen.
I misread the table in the spec. This format isn't listed in
https://gpuweb.github.io/gpuweb/#plain-color-formats but is instead
listed in https://gpuweb.github.io/gpuweb/#packed-formats.
- WebGPU/Texture.mm:
(WebGPU::isRenderableFormat):
- 8:04 AM Changeset in webkit [293094] by
-
- 4 edits in trunk/Source/WebCore
Some AutoscrollController cleanup
https://bugs.webkit.org/show_bug.cgi?id=239512
Reviewed by Alan Bujtas.
Have AutoscrollController store a WeakPtr to the render object. Address an apparent
null de-ref in AutoscrollController::stopAutoscrollTimer() where the Frame can null.
Refactor updateDragAndDrop() with a lambda so that all the code paths that exit early
clearly call stopAutoscrollTimer() which nulls out the renderer.
- page/AutoscrollController.cpp:
(WebCore::AutoscrollController::autoscrollRenderer const):
(WebCore::AutoscrollController::startAutoscrollForSelection):
(WebCore::AutoscrollController::stopAutoscrollTimer):
(WebCore::AutoscrollController::updateAutoscrollRenderer):
(WebCore::AutoscrollController::updateDragAndDrop):
(WebCore::AutoscrollController::startPanScrolling):
- page/AutoscrollController.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::startPanScrolling):
- 6:51 AM Changeset in webkit [293093] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, RISC-V build fix.
- assembler/MacroAssemblerRISCV64.h:
(JSC::MacroAssemblerRISCV64::store64):
Add the store64(TrustedImmPtr, Address) overload required after 249798@main.
It constructs a 32-bit or 64-bit TrustedImm value, based on the detected
pointer size, and relays it to the appropriate store64() method.
- 6:36 AM Changeset in webkit [293092] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Accommodate the RISCV64 C calling convention
https://bugs.webkit.org/show_bug.cgi?id=236367
<rdar://problem/89026012>
Reviewed by Yusuke Suzuki.
The 64-bit RISC-V (RV64) calling convention requires 32-bit arguments
to be sign-extended to fill out the whole 64-bit register, fitting
nicely with different instructions in this ISA that operate on 32-bit
values, and differring from other 64-bit ISAs that provide partial-sized
registers (which are aliased to the whole register).
JSC JIT is tailored to the other ISAs, often taking shortcuts to pack
non-sign-extended values into registers that are then accessed for those
32-bit values through the partial-sized aliases. This can trip up RISC-V
execution when constructing calls that pass 32-bit values to native code
using the C calling convention.
To avoid this, arguments setup done through the CCallHelpers class is
enhanced to, after packing up arguments either into argument registers
or onto the stack, another pass of the argument types for the desired
operation is done, detecting whether the argument was supposed to be
packed into an GPR or an FPR destination. On RV64, when packed into a
GPR argument register that matches a 32-bit argument in the operation,
the additional sign extension is performed on that argument register.
GPR and FPR distinction for a given argument's register type is based
on whether or not the double type is used as the argument's type. All
non-double-typed arguments are passed as GPRs. Additional compile-time
validation is provided to ensure that's the case for every operation
that's having its arguments set up. This is relied upon when traversing
the operation's arguments and indexing every GPR argument along the way.
This approach only accommodates the RV64 calling convention for the
Baseline JIT level. For higher levels, similar but probably different
solutions will have to be crafted.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::finalizeGPRArguments):
(JSC::CCallHelpers::gprArgsCount):
(JSC::CCallHelpers::fprArgsCount):
(JSC::CCallHelpers::setupArgumentsImpl):
(JSC::CCallHelpers::setupArgumentsEntryImpl):
- 5:56 AM Changeset in webkit [293091] by
-
- 3 edits3 adds in trunk
[GStreamer] REGRESSION(r285586): we never end the playback of some videos
https://bugs.webkit.org/show_bug.cgi?id=239387
Patch by Yacine Bandou <yacine.bandou@softathome.com> on 2022-04-20
Reviewed by Philippe Normand.
Source/WebCore:
If the sinks have the EOS flag, we shouldn't ignore the EOS message.
Without this commit we never end the playback of some videos,
because we ignore the EOS message, like this one:
https://www.tv5mondeplus.com/bumpers/tv5_bumper.mp4
Test: media/video-inaccurate-duration-ended.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
LayoutTests:
- media/content/test-inaccurate-duration.mp4: Added.
- media/video-inaccurate-duration-ended-expected.txt: Added.
- media/video-inaccurate-duration-ended.html: Added.
- 4:51 AM Changeset in webkit [293090] by
-
- 30 edits in trunk
Parsing of contain-intrinsic-size and adding a runtime flag for it
https://bugs.webkit.org/show_bug.cgi?id=238181
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/css-sizing/contain-intrinsic-size/animation/contain-intrinsic-size-interpolation-expected.txt:
- web-platform-tests/css/css-sizing/contain-intrinsic-size/parsing/contain-intrinsic-size-computed-expected.txt:
- web-platform-tests/css/css-sizing/contain-intrinsic-size/parsing/contain-intrinsic-size-valid-expected.txt:
- web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
Source/WebCore:
Parsing of contain-intrinsic-size according to [1]. In order to parse the shorthand properly,
the latest draft has been updated to "none | <length> | auto <length>". ContainIntrinsicSizeType
in RenderStyle, indicates the type of value. containIntrinsicWidth/Height indicates the length
value for Length and AutoAndLength type.
Thanks to Rob Buis for helping with this patch.
[1] https://www.w3.org/TR/css-sizing-4/#intrinsic-size-override
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForContainIntrinsicSize):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- css/CSSProperties.json:
- css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const):
(WebCore::StyleProperties::asTextInternal const):
- css/parser/CSSParserContext.cpp:
(WebCore::operator==):
(WebCore::add):
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
- css/parser/CSSParserContext.h:
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeContainIntrinsicSize):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::consumeContainIntrinsicSizeShorthand):
(WebCore::CSSPropertyParser::parseShorthand):
- css/parser/CSSPropertyParser.h:
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::containIntrinsicWidthType const):
(WebCore::RenderStyle::containIntrinsicHeightType const):
(WebCore::RenderStyle::containIntrinsicWidth const):
(WebCore::RenderStyle::containIntrinsicHeight const):
(WebCore::RenderStyle::setContainIntrinsicWidthType):
(WebCore::RenderStyle::setContainIntrinsicHeightType):
(WebCore::RenderStyle::setContainIntrinsicWidth):
(WebCore::RenderStyle::setContainIntrinsicHeight):
(WebCore::RenderStyle::initialContainIntrinsicWidthType):
(WebCore::RenderStyle::initialContainIntrinsicHeightType):
(WebCore::RenderStyle::initialContainIntrinsicWidth):
(WebCore::RenderStyle::initialContainIntrinsicHeight):
- rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
- rendering/style/StyleRareNonInheritedData.h:
- style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInitialContainIntrinsicWidth):
(WebCore::Style::BuilderCustom::applyInheritContainIntrinsicWidth):
(WebCore::Style::BuilderCustom::applyValueContainIntrinsicWidth):
(WebCore::Style::BuilderCustom::applyInitialContainIntrinsicHeight):
(WebCore::Style::BuilderCustom::applyInheritContainIntrinsicHeight):
(WebCore::Style::BuilderCustom::applyValueContainIntrinsicHeight):
(WebCore::Style::BuilderCustom::applyInitialContainIntrinsicBlockSize):
(WebCore::Style::BuilderCustom::applyInheritContainIntrinsicBlockSize):
(WebCore::Style::BuilderCustom::applyValueContainIntrinsicBlockSize):
(WebCore::Style::BuilderCustom::applyInitialContainIntrinsicInlineSize):
(WebCore::Style::BuilderCustom::applyInheritContainIntrinsicInlineSize):
(WebCore::Style::BuilderCustom::applyValueContainIntrinsicInlineSize):
Source/WTF:
- Scripts/Preferences/WebPreferencesExperimental.yaml:
LayoutTests:
- platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- 3:43 AM Changeset in webkit [293089] by
-
- 26 edits in trunk
Unprefix -webkit-user-select CSS property
https://bugs.webkit.org/show_bug.cgi?id=208677
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
WPT progressions.
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/css-ui/inheritance-expected.txt:
- web-platform-tests/css/css-ui/parsing/user-select-computed-expected.txt:
- web-platform-tests/css/css-ui/parsing/user-select-valid-expected.txt:
- web-platform-tests/inert/inert-computed-style-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- css/CSSProperties.json:
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- css/html.css:
(#if defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY):
(input::-webkit-inner-spin-button):
(input::-webkit-strong-password-auto-fill-button):
(input::-webkit-credentials-auto-fill-button):
(input::-webkit-contacts-auto-fill-button):
(input::-webkit-credit-card-auto-fill-button):
(input::-webkit-caps-lock-indicator):
(#if defined(ENABLE_DATALIST_ELEMENT) && ENABLE_DATALIST_ELEMENT):
(textarea):
(input:-webkit-autofill-strong-password):
- css/mediaControls.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(video::-webkit-media-text-track-container):
- css/plugIns.css:
(embed::-webkit-snapshotted-plugin-content > .snapshot-overlay > .snapshot-label,):
- dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::updateSubtree):
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::collectPresentationalHintsForAttribute):
LayoutTests:
- editing/selection/user-select-js-property-expected.txt:
- editing/selection/user-select-js-property.html:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/resources/property-names.js:
- platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 2:09 AM Changeset in webkit [293088] by
-
- 2 edits in trunk/LayoutTests
[Debug] Skip editing/inserting/insert-list-user-select-none-crash.html
Unreviewed test gardening.
This started crashing after r293028, but it's not a direct cause of that bug. You can also
reproduce before r293028 by replacinguser-select: none;in the test withuser-select: text.
- 12:54 AM Changeset in webkit [293087] by
-
- 14 edits in trunk/Source/JavaScriptCore
Unify calls and checks for CellTag
https://bugs.webkit.org/show_bug.cgi?id=238025
Reviewed by Yusuke Suzuki.
This patch moves all the places where cell tags are written and checked
when branching: this will be needed when implementing the concurrency on
32 bits archs, so we can focus on changing storeCell, branchIfNotCell and
branchIfCell to implement the mutex locks/unlocks.
It also reduces the code size in JetStream2 by ~1% on average on 32
bits platforms.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::store8):
(JSC::MacroAssemblerARMv7::storePair32):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::storePair32):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectStrictEquality):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::jitAssertIsCell):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::storeCell):
(JSC::AssemblyHelpers::storeTrustedValue):
(JSC::AssemblyHelpers::branchIfNotCell):
(JSC::AssemblyHelpers::branchIfCell):
- jit/CallFrameShuffler32_64.cpp:
(JSC::CallFrameShuffler::emitStore):
- jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::emitLoadJSCell):
- 12:43 AM Changeset in webkit [293086] by
-
- 17 edits in trunk/Source
Unreviewed, non-unified build fixes after r293052
Source/WebCore:
- css/typedom/numeric/CSSMathMin.cpp:
- css/typedom/numeric/CSSMathNegate.cpp:
- css/typedom/numeric/CSSMathProduct.cpp:
- css/typedom/numeric/CSSMathSum.cpp:
- css/typedom/transform/CSSSkew.cpp:
- dom/CustomElementRegistry.cpp:
- html/InputTypeNames.cpp:
- inspector/agents/InspectorCSSAgent.cpp:
- page/FocusController.cpp:
- style/AttributeChangeInvalidation.cpp:
- style/ClassChangeInvalidation.cpp:
- style/ElementRuleCollector.cpp:
- style/IdChangeInvalidation.cpp:
- style/StyleSharingResolver.cpp:
Source/WebKit:
- WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::handleEvent):
- 12:24 AM Changeset in webkit [293085] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r293044): Extraneous border around AutoFill buttons in
activeandhoverstates
https://bugs.webkit.org/show_bug.cgi?id=239531
Unreviewed fix.
Used "Convert to Outlines" tool in Sketch for outlines, then cleaned up SVGs, instead of stroke atttributes.
- css/html.css:
(input::-webkit-credentials-auto-fill-button:hover):
(input::-webkit-credentials-auto-fill-button:active):
