(courtesy of Martin Robinson, who introduced the notion of Garderner in WebKit world of fame)

1. Keep the tree green: the gardener on a given day will diagnose all bot redness and try to form a hypothesis for each failure. In my experience there are several types of failures:
  a. The GTK+ port is lacking some feature or has a bug: In this case the gardener will figure out exactly what the problem is, open a bug with as much information as possible including test diffs and links to relevant bugs. The gardener will CC any people involved in WebKitGTK+ who would might know how to fix the problem.
  b. A test is exposing a general WebKit bug that only GTK+ triggers (often the case with JavaScriptCore and inspector tests): In this case the gardener will leave a comment on the original bug with the test diff or stack trace (for something like an assertion failure) and offer to gather more information for the original patch author (even resorting to debugging directly on the bots if it cannot be reproduced locally).
  c. A test is missing expectations or needs new expectations: The gardener will generate new expectations after verifying that the tests seem to work when run manually or by looking at the expected results.
  d. A DRT feature is missing: The gardener will open a bug. The idea is that we will completely avoid skipped tests with no information about the failure.

2. If the tree isn't red, the gardener should be able to choose how to spend the day:
  a. Generating results for tests that do not have results (soon this will include pixel results as well).
  b. Diagnosing and opening bugs for failures that do not have open bugs (there's a huge list). This also includes unskipping tests that are passing.
  c. Implementing missing DRT features. There are a ton of these and we need to kill them. Using DRTSupportGtk we can do it without making API decisions.

3. At the end of the day the gardener should keep a very simple log for tomorrow's gardener, so he/she can follow up with any pending investigations. This will also help us keep track of newly skipped tests. See the [#Gardeninglog Gardening log] entry at the bottom of this wiki page.

Check also chrome gardening instructions: http://dev.chromium.org/developers/how-tos/webkit-gardening

== Gardening schedule ==

||= Day      =||= Gardener =||
|| Tue 09 Sep ||  clopez ||
|| Wed 10 Sep ||  ||
|| Thu 11 Sep ||  ||
|| Fri 12 Sep ||  ||
|| Sat 13 Sep ||  ||
|| Sun 14 Sep ||  ||
|| Mon 15 Sep ||  ||
|| Tue 16 Sep ||  ||
|| Wed 17 Sep ||  ||
|| Thu 18 Sep ||  ||
|| Fri 19 Sep ||  ||
|| Sat 20 Sep ||  ||
|| Sun 21 Sep ||  ||
|| Mon 22 Sep ||  ||
|| Tue 23 Sep ||  ||
|| Wed 24 Sep ||  ||
|| Thu 25 Sep ||  ||
|| Fri 26 Sep ||  ||
|| Sat 27 Sep ||  ||
|| Sun 28 Sep ||  ||
|| Mon 29 Sep ||  ||
|| Tue 30 Sep ||  ||
|| Wed 01 Oct ||  ||
|| Thu 02 Oct ||  ||
|| Fri 03 Oct ||  ||
|| Sat 04 Oct ||  ||
|| Sun 05 Oct ||  ||
|| Mon 06 Oct ||  ||
|| Tue 07 Oct ||  ||
|| Wed 08 Oct ||  ||
|| Thu 09 Oct ||  ||


== Gardening log ==

* Please put new log entries at the top.

{{{#!td style="background: #eef"
Done:
  * Gardening: https://trac.webkit.org/r173319
-- !clopez@igalia.com - Wed Sep 6 2014
}}}

{{{#!td style="background: #eef"
Done:
  * Build-fix: https://trac.webkit.org/r173257
-- !clopez@igalia.com - Thu Sep 4 2014
}}}

{{{#!td style="background: #eef"
Done:
  * Build-fix: https://trac.webkit.org/r172971
  * Gardening: https://trac.webkit.org/r172981
-- !clopez@igalia.com - Tue Aug 26 2014
}}}

{{{#!td style="background: #eef"
Done:
  * Gardening: https://trac.webkit.org/r172750
-- !clopez@igalia.com - Thu Aug 19 2014
}}}


{{{#!td style="background: #eef"
Done:

* Rebaselined fast/ruby/ruby-base-merge-block-children-crash-2.html after r172517.
* Rebaselined inspector-protocol/dom/getAccessibilityPropertiesForNode.html after r172136.
* Rebaselined scrollbars/scrollbar-selectors.html after r172220.
* Updated expectations with new identified failures and flakiness (check committed changes)
* Committed the following changes:
  * https://trac.webkit.org/r172585
Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Thu Aug 14 2014

}}}

{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/135583
  * http://webkit.org/b/135584
  * http://webkit.org/b/135585
* Committed the following changes:
  * https://trac.webkit.org/r172017
Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Mon Aug 04 2014

}}}


{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/135529
  * http://webkit.org/b/135530
  * http://webkit.org/b/135531
  * http://webkit.org/b/135532
  * http://webkit.org/b/135533
  * http://webkit.org/b/135534
* Rebaselined the tests affected by r171567, r171609 and r171341.
* Committed the following changes:
  * https://trac.webkit.org/r171963
Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Sat Aug 02 2014

}}}


{{{#!td


{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/135050
  * http://webkit.org/b/135051
  * http://webkit.org/b/135052
  * http://webkit.org/b/135053
  * http://webkit.org/b/135086
  * http://webkit.org/b/135087
  * http://webkit.org/b/135088
  * http://webkit.org/b/135089
  * http://webkit.org/b/135090
  * http://webkit.org/b/135091
  * http://webkit.org/b/135092
  * http://webkit.org/b/135093
  * http://webkit.org/b/135094
  * http://webkit.org/b/135095
* Updated the bugs
  * http://webkit.org/b/129050
* Committed the following changes:
  * https://trac.webkit.org/r171263
Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Sat Jul 19 2014

}}}


{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/134976
  * http://webkit.org/b/134979
  * http://webkit.org/b/134981
  * http://webkit.org/b/134982
  * http://webkit.org/b/134994
  * http://webkit.org/b/134995
  * http://webkit.org/b/134996
  * http://webkit.org/b/134998
  * http://webkit.org/b/135003
  * http://webkit.org/b/135004
* Updated the bugs
  * http://webkit.org/b/81604
  * http://webkit.org/b/132248
* Committed the following changes:
  * http://webkit.org/b/135005
Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Wed Jul 16 2014

}}}

{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/134756
  * http://webkit.org/b/134758
  * http://webkit.org/b/134760
  * http://webkit.org/b/134761
* Updated the bugs
  * http://webkit.org/b/122571
  * http://webkit.org/b/134576
* Committed the following changes:
  * http://webkit.org/b/134762
Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Wed Jul 09 2014

}}}


{{{#!td style="background: #eef"
Done:

* Updated the bugs:
  * http://webkit.org/b/124770
* Committed the following changes:
  * http://webkit.org/b/134665

Pending:

* Check the remaining failures.

-- !ltilve@igalia.com - Mon Jul 07 2014

}}}


{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/134579
  * http://webkit.org/b/134577
  * http://webkit.org/b/134576
  * http://webkit.org/b/134575
  * http://webkit.org/b/134574
  * http://webkit.org/b/134573
  * http://webkit.org/b/134559
  * http://webkit.org/b/134550
* Updated the bug
  * http://webkit.org/b/103383
  * http://webkit.org/b/105280
* Committed the following changes:
  * http://webkit.org/b/134583
Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Wed Jul 02 2014

}}}


{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/134399
* Rebaselined the tests affected by r170207, r170249, r170304, r170418 and r170433.
* Committed the following changes:
  * http://webkit.org/b/134400
Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Fri Jun 27 2014

}}}

{{{#!td style="background: #eef"
Done:

* Opened the following bugs for flaky and failing tests:
  * http://webkit.org/b/133864
  * http://webkit.org/b/133865
  * http://webkit.org/b/133866
  * http://webkit.org/b/133867
  * http://webkit.org/b/133868
  * http://webkit.org/b/133869
* Committed the following changes:
  * http://webkit.org/b/133870

Pending:

* Check the remaining failures.

-- !eocanha@igalia.com - Fri Jun 13 2014

}}}

{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/133806
  * http://webkit.org/b/133797 
  * http://webkit.org/b/133807
  * http://webkit.org/b/133808
  * http://webkit.org/b/133803
* Rebaselined fast/forms/placeholder-position.html
* Updated the highdpi list for bug http://webkit.org/b/131347
* Committed the following changes:
  * http://webkit.org/b/133811

Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Thu Jun 12 2014

}}}

{{{#!td style="background: #eef"
Done:

* Committed the following changes:
  * http://webkit.org/b/133733

Pending:

* Check the remaining failures.

-- !ltilve@igalia.com - Wed Jun 11 2014

}}}

{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/133514
  * http://webkit.org/b/133516
  * http://webkit.org/b/133517
  * http://webkit.org/b/133519
* Updated the highdpi list for bug http://webkit.org/b/131347
* Committed the following changes:
  * http://webkit.org/b/133520

Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Wed Jun 04 2014

}}}

{{{#!td style="background: #eef"
Done:

* Checked Layout test failures on r169097
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/267
* Opened the following bugs:
  * http://webkit.org/b/133151
  * http://webkit.org/b/133148
  * http://webkit.org/b/133147
  * http://webkit.org/b/133146
* Committed the following changes:
  * http://webkit.org/b/133152
  * http://webkit.org/b/133113

-- !ltilve@igalia.com - Thu May 21 2014
}}}

{{{#!td style="background: #eef"
Done:

* Opened the following bugs for flaky tests:
  * http://webkit.org/b/132995
  * http://webkit.org/b/132996
  * http://webkit.org/b/132997
  * http://webkit.org/b/132998
  * http://webkit.org/b/132999
  * http://webkit.org/b/133000
  * http://webkit.org/b/133001
* Updated TestExpectations:
  * http://webkit.org/b/133003

Pending:

* Check the remaining failures.

-- !eocanha@igalia.com - Fri May 16 2014

}}}

{{{#!td style="background: #eef"
Done:

* Rebaselined the tests affected by r168641, r168543, r168350 and r168674.
* Opened the following bugs:
  * http://webkit.org/b/132909
  * http://webkit.org/b/132910
  * http://webkit.org/b/132914
  * http://webkit.org/b/132919
  * http://webkit.org/b/132921
  * http://webkit.org/b/132923
* Updated the highdpi list for bug http://webkit.org/b/131347
* Commented on bug: http://webkit.org/b/132886 
* Committed the following changes:
  * http://webkit.org/b/132925

Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Thu May 15 2014

}}}

{{{#!td style="background: #eef"
Done:

* Checked Layout test failures on r168676
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/108
* Updated the following bugs:
  * http://webkit.org/b/132232
* Committed the following changes:
  * http://webkit.org/b/132858
  * http://webkit.org/b/132873

-- !ltilve@igalia.com - Thu May 13 2014
}}}

{{{#!td style="background: #eef"
Done:
* Checked Layout test failures on r168358
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/47158
* Updated the following bugs:
  * http://webkit.org/b/132328
  * http://webkit.org/b/132255
* Opened the following bugs:
  * http://webkit.org/b/132329
* Committed the following changes:
  * http://webkit.org/b/132614
  * http://webkit.org/b/132644

-- !ltilve@igalia.com - Thu May 7 2014
}}}

{{{#!td style="background: #eef"

Done:

* r168118 Broke the GTK build.
  * Tracked here: http://webkit.org/b/132447

-- !clopez@igalia.com - Thu May 01 2014

}}}

{{{#!td style="background: #eef"
Done:

* Rebaselined all the (128) tests affected by the new multi-column mode enabled on r168046.
* Opened the following bugs:
  * http://webkit.org/b/132425
* Updated the following bugs:
  * http://webkit.org/b/132275
  * http://webkit.org/b/77631
  * http://webkit.org/b/128061
* Committed the following changes:
  * http://webkit.org/b/132426

Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Thu May 01 2014

}}}

{{{#!td style="background: #eef"
Done:
* Checked Layout test failures on r167923
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46925
* Opened the following bugs:
  * http://webkit.org/b/132329
  * http://webkit.org/b/132361  

-- !ltilve@igalia.com - Thu Apr 29 2014
}}}

{{{#!td style="background: #eef"
Done:
* Done:
  * Flagged tons of tests and created tons of bugs in three entries:
    * https://trac.webkit.org/changeset/167881
    * https://trac.webkit.org/changeset/167882
    * https://trac.webkit.org/changeset/167886
    * https://trac.webkit.org/changeset/167888
  
-- !calvaris@igalia.com - Thu Apr 28 2014
}}}

{{{#!td style="background: #eef"
Done:

* Opened the following bugs (flaky tests):
  * http://webkit.org/b/132181
  * http://webkit.org/b/132182
  * http://webkit.org/b/132183
  * http://webkit.org/b/132184
  * http://webkit.org/b/132185
* Updated the following test expectations for the previous bugs:
  * http://webkit.org/b/132187

Pending:

* Check the remaining failures.

-- !eocanha@igalia.com - Fri Apr 25

}}}

{{{#!td style="background: #eef"
Done:
* Changed on the release bot (http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release) the following:
  * Removed the environment variable XVFB_SCREEN_DEPTH=8
  * Removed deprecated environment variable WEBKIT_TESTFONTS
  * Did an upgrade of the system (Debian testing)
* Opened the following bugs:
  * http://webkit.org/b/132126
    * The removal of the environment variable XVFB_SCREEN_DEPTH=8 caused new failures on a dozen of tests. \\
      I reported here all of them and updated the text expectations accordingly.
  * http://webkit.org/b/132128
  * http://webkit.org/b/132134
* Updated the following bugs:
  * http://webkit.org/b/131223
* Committed the following changes:
  * http://webkit.org/b/132129

Notes:
* If you notice that a test started failing on r167754 it could be because \\
  of the removal of the XVFB_SCREEN_DEPTH=8 variable. Let me know that \\
  or update http://webkit.org/b/132126

-- !clopez@igalia.com - Thu Apr 24 2014
}}}

{{{#!td style="background: #eef"
Done:

* Checked Layout test failures on r167649
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46703
* Opened the following bugs:
  * http://webkit.org/b/132119
  * http://webkit.org/b/132135
* Committed the following changes:
  * http://webkit.org/b/132138

Pending:

* Check the remaining failures.

-- !elima@igalia.com - Thu Apr 24 2014

}}}

{{{#!td style="background: #eef"
Done:

* Checked Layout test failures on r167649
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46703
* Opened the following bugs:
  * http://webkit.org/b/132046
  * http://webkit.org/b/132054
  * http://webkit.org/b/132056
* Committed the following changes:
  * http://webkit.org/b/132058
  * http://webkit.org/b/132051

Pending:

* Check the remaining failures.

-- !ltilve@igalia.com - Mon Apr 22 2014

}}}

{{{#!td style="background: #eef"
Done:

* Checked Layout test failures on r167589
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46673
* Opened the following bugs:
  * http://webkit.org/b/131934
* Updated the following bugs:
  * http://webkit.org/b/129330
  * http://webkit.org/b/117689
* Committed the following changes:
  * http://webkit.org/b/131937

Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Mon Apr 21 2014

}}}

{{{#!td style="background: #eef"
Done:

* Checked API tests failures on r167424
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46563
* Updated the following bugs:
  * http://webkit.org/b/131619 (Closed after checking that test is now passing)
  * http://webkit.org/b/118420 (Checked that test is now passing)
  * http://webkit.org/b/119840 (Checked that test is now passing)
* Opened the following bugs:
  * http://webkit.org/b/131793
  * http://webkit.org/b/131794
* Committed the following changes:
  * http://webkit.org/b/131795

-- !elima@igalia.com - Thu Apr 17 2014

}}}

{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/131737
  * http://webkit.org/b/131743

Pending:

* Check the remaining failures.

-- !aperez@igalia.com - Wed Apr 16 2014

}}}

{{{#!td style="background: #eef"
Done:

* Checked API tests failures on r167347
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46527
* Opened the following bugs:
  * http://webkit.org/b/131731
* Updated the following bugs:
  * http://webkit.org/b/85037
  * http://webkit.org/b/117689
  * http://webkit.org/b/120305
  * http://webkit.org/b/120306
  * http://webkit.org/b/121970
  * http://webkit.org/b/122571
  * http://webkit.org/b/125068
* Committed the following changes:
  * http://webkit.org/b/131736

Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Wed Apr 16 2014

}}}

{{{#!td style="background: #eef"
Done:

* Checked failures on r167304
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46496
* Committed the following changes:
  * http://webkit.org/b/131686

Pending:

* Check the remaining failures.

-- !ltilve@igalia.com - Tue Apr 15 2014

}}}


{{{#!td style="background: #eef"
Done:

* Checked failures on r167246
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46454
* Opened the following bugs:
  * http://webkit.org/b/131616 (this is a general bug to fix test-related scripts)
  * http://webkit.org/b/131619
  * http://webkit.org/b/131620
* Committed the following changes:
  * http://webkit.org/b/131624

Pending:

* Check the remaining failures.

-- !elima@igalia.com - Fri Apr 14 2014

}}}


{{{#!td style="background: #eef"
Done:

* Checked failures on r167125
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46384
* Opened the following bugs:
  * http://webkit.org/b/131540
  * http://webkit.org/b/131546
  * http://webkit.org/b/131545
* Updated the following bugs:
  * http://webkit.org/b/95428
  * http://webkit.org/b/130971  
* Committed the following changes:
  * http://webkit.org/b/131549

Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Fri Apr 11 2014

}}}

{{{#!td style="background: #eef"
Done:

* Opened the following bugs:
  * http://webkit.org/b/131533
  * http://webkit.org/b/131534
  * http://webkit.org/b/131535
* Updated the following test expectations:
  * http://webkit.org/b/131537

Pending:

* Check the remaining failures.

-- !eocanha@igalia.com - Fri Apr 11 2014

}}}

{{{#!td style="background: #eef"
Done:

* Checked both text-only and image-only failures on r167072
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46344
* Opened the following bugs:
  * http://webkit.org/b/131496
  * http://webkit.org/b/131498
  * http://webkit.org/b/131501
* Updated the following test expectations:
  * http://webkit.org/b/131504

Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Thu Apr 10 2014

}}}

{{{#!td style="background: #eef"
Done:

* Checked the status of `garden-o-matic`:
  * Works fine for WebKitGTK+ port when using a Git clone.
  * Usage instructions in the [[Rebaseline]] page.

!aperez@igalia.com - Wed 9 Apr 2014
}}}

{{{#!td style="background: #eef"
Done:

* Started checking the reported Unexpected text-only failures on r166926
  * http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/46239/
* Opened the following bugs:
  * http://webkit.org/b/131380
  * http://webkit.org/b/131377
* Updated test expectations accordingly and rebaselined one test:
  * http://webkit.org/b/131382

Pending:

* Check the remaining failures.

-- !clopez@igalia.com - Tue Apr 8 2014
}}}

}}}