07/04/15: Today

14:51 Changeset [186286] by drousso@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Wrong cursor position in styles panel when deleting a line break

Reviewed by Timothy Hatcher.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleBeforeChange): If the change is a deletion at the beginning of a line,
remove all markers on that line to ensure that there is no blank space on the previous line after deleting.

14:49 Changeset [186285] by drousso@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Pressing tab on a newline in the console should insert a tab character

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ConsolePrompt.js:

(WebInspector.ConsolePrompt.prototype._handleTabKey): Tabs can now be inserted at the beginning of newlines and before the first
non-space character on any other line.

14:48 Changeset [186284] by drousso@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Pressing enter on a newline in the styles sidebar inserts a semicolon

Reviewed by Timothy Hatcher.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleEnterKey): Now returns if the line is empty.

14:46 Changeset [186283] by drousso@apple.com
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Console should indicate if you have unseen messages in console due to filters

Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController.prototype.updatePreviousMessageRepeatCount): Now returns true/false depending on if
the message count was actually updated.

  • UserInterface/Views/LogContentView.css:

(.log-scope-bar > li.unread): Applies the unread-border-pulse keyframe animation.
(.log-scope-bar > li.unread.errors): The pulsing border is colored red.
(.log-scope-bar > li.unread.warnings): The pulsing border is colored yellow(ish).
(.log-scope-bar > li.unread.logs): The pulsing border is colored grey.
(@keyframes unread-border-pulse): Changes the color of the border from transparent to whatever is specificed.

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._pulseScopeBarItemBorder): Adds the class "unread" to the scope bar item whose panel
the newest message belongs to, but only if that panel or the All panel is not visible.
(WebInspector.LogContentView.prototype._scopeBarSelectionDidChange): Clears the "unread" class on the selected scope bar item.

  • UserInterface/Views/ScopeBar.js:

(WebInspector.ScopeBar.prototype.get items): Returns a list of all the items in the scope bar.

  • UserInterface/Views/ScopeBarItem.js:

(WebInspector.ScopeBarItem): Added another parameter to allow for a custom class name.

14:44 Changeset [186282] by drousso@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Pseudo Styles Ordering and Media Queries

Reviewed by Timothy Hatcher.

  • UserInterface/Views/RulesStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)):
Fix filter label styling with pseudo selectors.

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh): Pseudo-selector rules will now order directly after the last style that
matches the pseudo-selector without the pseudo-element. If no rules match, place the pseudo-selector rules above the first
inherited or UserAgent rule (whichever comes first).

14:41 Changeset [186281] by drousso@apple.com
  • 3 edits
    6 adds in trunk/Source/WebInspectorUI

REGRESSION(r184000): Web Inspector: Multiline CSS in Styles Sidebar is marked as invalid

Reviewed by Timothy Hatcher.

First changes made by Tobias Reiss <tobi+webkit@basecode.de>

  • Tools/PrettyPrinting/css-rule-tests/add-whitespace-between-values-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/add-whitespace-between-values.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/add-whitespace-between-rules-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/add-whitespace-between-rules.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-newline-between-values-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-newline-between-values.css: Added.
  • Tools/PrettyPrinting/index.html:

Add regression tests.

  • UserInterface/Views/CodeMirrorFormatters.js:

Remove newlines before values that belong in one line and add whitespace between values.

14:31 Changeset [186280] by cdumez@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed Windows build fix after r186279.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:


  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:


12:42 Changeset [186279] by cdumez@apple.com
  • 199 edits in trunk

Drop RefPtr::clear() method

Reviewed by Brady Eidson.


Drop RefPtr::clear() method in favor of "= nullptr;" pattern.


Drop RefPtr::clear() method in favor of "= nullptr;" pattern.


Drop RefPtr::clear() method in favor of "= nullptr;" pattern.


Drop RefPtr::clear() method in favor of "= nullptr;" pattern.


Drop RefPtr::clear() method in favor of "= nullptr;" pattern.


Drop RefPtr::clear() method in favor of "= nullptr;" pattern.


Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
Also made the "= nullptr;" pattern as efficient as clear()
by providing a operator=(nullptr_t) overload. Local micro-
benchmarking showed that "= nullptr;" used to be ~1.7% slower
than clear().


Drop RefPtr::clear() method in favor of "= nullptr;" pattern.

07:45 Changeset [186278] by nvasilyev@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: The arrow that appears for Web Inspector Layout & Rendering records overlaps the category switcher

Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineDataGrid.css:

(.data-grid.timeline > .navigation-bar-container):

07/03/15: Yesterday

21:13 Changeset [186277] by mitz@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Just give up on -Wunreachable-code in JavaScriptCore.

  • Configurations/Base.xcconfig:
  • llint/LowLevelInterpreter.cpp:


21:11 Changeset [186276] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed the iOS 8 build.

  • editing/cocoa/HTMLConverter.mm:
20:56 Changeset [186275] by cdumez@apple.com
  • 10 edits
    2 adds in trunk

REGRESSION (r178097): HTMLSelectElement.add(option, undefined) prepends option to the list of options; should append to the end of the list of options

Reviewed by Ryosuke Niwa.


HTMLSelectElement.add(X, undefined) is supposed to be equivalent to
HTMLSelectElement.add(X) which should *append* X. The same is true
for HTMLOptionsCollection.add(X, undefined).

However, due to a bug in our bindings generator for overloaded
operations, the actual behavior was not the expected one. The
second overload would be chosen: add(X, index) and undefined would
be converted as 0-index, which would *prepend* X.

This patch fixes the bindings generator so that undefined is allowed
for optional parameters of an overload operation, when doing the
overload resolution.


  • fast/dom/HTMLSelectElement/add.html
  • fast/dom/HTMLSelectElement/options-collection-add.html
  • http/tests/websocket/tests/hybi/undefined-protocol.html
  • bindings/scripts/CodeGeneratorJS.pm:

Allow undefined value for optional parameters when doing the overload

  • bindings/scripts/test/JS/JSTestObj.cpp:


  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:


  • bindings/scripts/test/TestObj.idl:

Add bindings tests coverage and rebaseline.


  • fast/dom/HTMLSelectElement/add-expected.txt:
  • fast/dom/HTMLSelectElement/add.html:
  • fast/dom/HTMLSelectElement/options-collection-add-expected.txt:
  • fast/dom/HTMLSelectElement/options-collection-add.html:

Update tests so that calling add(X, undefined) is expected to append X,
not prepend it.

  • http/tests/websocket/tests/hybi/undefined-protocol-expected.txt: Added.
  • http/tests/websocket/tests/hybi/undefined-protocol.html: Added.

Add test coverage for "new WebSocket(url, undefined)" as WebSocket is
using constructor overloads with optional parameters. Previously, calling
new WebSocket(url, undefined) was equivalent to calling
new WebSocket(url, "undefined") even though it is supposed to be
equivalent to calling new WebSocket(url).

20:12 Changeset [186274] by mitz@apple.com
  • 2 edits in trunk/Tools

Fixed the iOS build.

  • DumpRenderTree/mac/EventSendingController.mm:

(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):

19:55 Changeset [186273] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixed the LLINT CLoop build.

  • llint/LowLevelInterpreter.cpp:


19:54 Changeset [186272] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed the Mavericks build after r186236.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::url): Removed the export macro from this inline function.

18:41 Changeset [186271] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the iOS build.

  • bridge/objc/objc_class.mm:


18:24 Changeset [186270] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the iOS build.

  • editing/cocoa/HTMLConverter.mm:
17:35 Changeset [186269] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the iOS build.

  • page/FrameView.cpp:


14:58 Changeset [186268] by mitz@apple.com
  • 45 edits
    1 move in trunk

[Xcode] Update some build settings as recommended by Xcode 7

Reviewed by Sam Weinig.


  • Configurations/Base.xcconfig: Enabled CLANG_WARN_UNREACHABLE_CODE, GCC_NO_COMMON_BLOCKS,


  • bmalloc.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.


  • Configurations/Base.xcconfig: Enabled CLANG_WARN_UNREACHABLE_CODE and


  • dfg/DFGGraph.h: Tweaked the definition of DFG_CRASH to suppress unreachable code warnings.


  • ANGLE.xcodeproj/project.pbxproj: Enabled CLANG_WARN_BOOL_CONVERSION,


  • Configurations/Base.xcconfig: Updated LastUpgradeCheck.


  • Configurations/Base.xcconfig: Enabled CLANG_WARN_UNREACHABLE_CODE,


  • WebCore.xcodeproj/project.pbxproj: Updated LastUpgradeCheck. Disabled -Wunreachable-code

for two bison-generated source files. Updated for rename of WebScriptObject.h.

  • bindings/objc/WebScriptObject.mm:

(-[WebUndefined dealloc]): Removed unreachable code and suppressed warning about not calling

  • bridge/objc/WebScriptObject.h: Renamed to WebScriptObjectProtocol.h to enabled inlcuding

the other WebScriptObject.h.

  • bridge/objc/WebScriptObjectProtocol.h: Renamed from WebScriptObject.h.
  • bridge/objc/objc_class.mm: Updated for rename and included WebScriptObject.h because we

use selectors declared in that file.

  • bridge/objc/objc_instance.mm: Ditto.

(ObjCRuntimeMethod::create): Resolved ambiguity between JSC::JSValue and the Objective-C
JSValue class.
(ObjCRuntimeMethod::createStructure): Ditto.
(ObjcInstance::invokeMethod): Ditto.
(ObjcInstance::invokeObjcMethod): Ditto.
(ObjcInstance::invokeDefaultMethod): Ditto.
(ObjcInstance::setValueOfUndefinedField): Ditto.
(ObjcInstance::getValueOfUndefinedField): Ditto.
(ObjcInstance::defaultValue): Ditto.
(ObjcInstance::stringValue): Ditto.
(ObjcInstance::numberValue): Ditto.
(ObjcInstance::booleanValue): Ditto.
(ObjcInstance::valueOf): Ditto,

  • bridge/objc/objc_runtime.h: Moved definition of isFallbackMethod() from here to the


  • bridge/objc/objc_runtime.mm: Updated for rename and included WebScriptObject.h because we

use selectors declared in that file.
(JSC::Bindings::ObjcMethod::isFallbackMethod): Moved definition from the header to here.

  • bridge/objc/objc_utility.mm: Updated for rename.
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addScrollbarPseudoClassType): Removed unreachable code.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

Added declarations to the WebCoreMovieObserver interface.
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks): Suppressed
-Wundeclared-selector around invocation of a selector that is not declared anywhere.


  • Configurations/Base.xcconfig: Enabled CLANG_WARN_UNREACHABLE_CODE and


  • WebInspectorUI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.


  • WebKit.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.


  • Configurations/Base.xcconfig: Enabled CLANG_WARN_UNREACHABLE_CODE,



  • Configurations/Base.xcconfig: Enabled CLANG_WARN_UNREACHABLE_CODE and


  • WebKit2.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.


  • Configurations/Base.xcconfig: Enabled CLANG_WARN_UNREACHABLE_CODE and


  • WTF.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.


  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
  • DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,


  • DumpRenderTree/mac/EventSendingController.mm:

(+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:,
which was removed in r19101.

  • DumpRenderTree/mac/TextInputController.m:

(-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector
around used of a selector not that is not declared anywhere.

  • MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS.
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
  • TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,


  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
14:55 Changeset [186267] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Memory leak for a protected Element having pending events in ImageLoader.

Patch by Kyounga Ra <kyounga@alticast.com> on 2015-07-03
Reviewed by Brady Eidson.

If ImageLoader is destroyed before an active derefElementTimer is fired, protected element's refCount never be zero..

  • loader/ImageLoader.cpp:


  • loader/ImageLoader.h:
14:55 Changeset [186266] by cdumez@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skip http/tests/xmlhttprequest/cross-origin-cookie-storage.html on Windows.

Windows' DumpRenderTree does not implement testRunner.setAlwaysAcceptCookies().

  • platform/win/TestExpectations:
14:15 WebKitGTK/2.8.x edited by mario@webkit.org
13:54 Changeset [186265] by dbates@webkit.org
  • 19 edits
    2 adds in trunk

REGRESSION (r178097): JavaScript TypeError after clicking on compose button in Yahoo Mail

Reviewed by Chris Dumez.


Fixes an issue where extra arguments passed to a Web IDL overloaded function, whose implementation
is generated by the bindings generator script, are not ignored as per the note in section "Interface object Call? method"
of the Web IDL spec, <http://www.w3.org/TR/2012/CR-WebIDL-20120419/> (19 April 2012).

Currently for an overloaded function the JavaScript bindings generator script emits code to
throw a TypeError when it cannot find a candidate function that takes the same number of
arguments as passed by a caller. Prior to the change made in bug #139179 (r178097), the
bindings code for HTMLSelectElement.add() was written by hand and ignored extra arguments
that were passed to it. Following this change, the bindings code for HTMLSelectElement.add()
is generated by the bindings generator script. Therefore, we throw a TypeError when Yahoo Mail
calls HTMLSelectElement.add() with extra arguments because the code emitted by the bindings
generator script does not ignore them.

  • bindings/scripts/CodeGeneratorJS.pm:

(LengthOfLongestFunctionParameterList): Added. Computes the length of longest overload parameter list.
(GenerateOverloadedFunction): Emit code that ignores more arguments than LengthOfLongestFunctionParameterList().
(GenerateOverloadedConstructorDefinition): Ditto.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod12): Added; expected result for an overloaded
function that takes a variadic number of Blob elements.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod): Update expected result. The added
if-conditional expression for the IDL declaration overloadedMethod(Blob... blobArgs) is empty
because we do not support overloading of functions with variadic arguments.

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors5): Added; expected
result for an overloaded constructors that takes a variadic number of long arguments.
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors): Update expected
result. The added if-conditional expression for the IDL declaration Constructor(long... longArgs) is empty
because we do not support overloading of constructors with variadic arguments.

  • bindings/scripts/test/TestObj.idl: Added declaration overloadedMethod(Blob...). Also fixed

typo in license block text.

  • bindings/scripts/test/TestOverloadedConstructors.idl: Added declaration Constructor(long... longArgs).

Also fixed typo in license block text.


Add new sub-tests to LayoutTests/fast/dom/HTMLSelectElement/{add, options-collection-add}.html,
simplify existing test code, share common code, and update expected results.

Additionally, update results for tests in LayoutTests/fast/canvas now that we ignore extra
arguments passed to a Web IDL overloaded function whose implementation is generated by the
bindings generator script.

  • fast/canvas/canvas-overloads-drawImage-expected.txt:
  • fast/canvas/canvas-overloads-setFillColor-expected.txt:
  • fast/canvas/canvas-overloads-setShadow-expected.txt:
  • fast/canvas/canvas-overloads-setStrokeColor-expected.txt:
  • fast/canvas/script-tests/canvas-overloads-drawImage.js:
  • fast/canvas/script-tests/canvas-overloads-setFillColor.js:
  • fast/canvas/script-tests/canvas-overloads-setShadow.js:
  • fast/canvas/script-tests/canvas-overloads-setStrokeColor.js:
  • fast/dom/HTMLSelectElement/add-expected.txt:
  • fast/dom/HTMLSelectElement/add.html:
  • fast/dom/HTMLSelectElement/options-collection-add-expected.txt:
  • fast/dom/HTMLSelectElement/options-collection-add.html:
  • fast/dom/HTMLSelectElement/resources/html-select-and-options-collection-utilities.js: Added.


13:50 Changeset [186264] by cdumez@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed, tentative fix for flaky layout test introduced in r186256.

  • platform/mac/accessibility/selection-notification-focus-change-expected.txt:
  • platform/mac/accessibility/selection-notification-focus-change.html:
13:39 Changeset [186263] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash on xLarge memory allocation using bmalloc on 32bit systems

Reviewed by Gustavo Noronha Silva.

Disable the gcc's -ftree-sra optimization (automatically enabled
with -O1 and higher levels) for WebCore and 32bit Intel architectures,
as that causes the crash in bmalloc when allocating large amounts of
memory from the texture mapper's tiled backing store implementation.

  • CMakeLists.txt: Pass -fno-free-sra to gcc on 32bit Intel architectures.
11:45 Changeset [186262] by peavo@outlook.com
  • 4 edits in trunk/Source/ThirdParty/ANGLE

[WinCairo][WebGL] Enable HLSL.

Reviewed by Alex Christensen.

High Level Shader Language needs to be enabled for WebGL to work on Windows.

  • ANGLE.vcxproj/translatorCommon.props:
  • ANGLE.vcxproj/translator_hlsl.vcxproj:
  • ANGLE.vcxproj/translator_hlsl.vcxproj.filters:
11:41 Changeset [186261] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the !ENABLE(VIDEO) build after r186054

Reviewed by Eric Carlson.

  • platform/MemoryPressureHandler.cpp:


10:38 Changeset [186260] by utatane.tea@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Relax builtin JS restriction about try-catch

Reviewed by Sam Weinig.

When retrieving the captured variables from the full activated scope,
it swapped the given vector with the stored declared variables vector.
This is because retrieving the captured variables are executed in the
last sequence of the parser, so declared variables are no longer used.
However, in builtins functions case, after retrieving the captured
variables, we check the variables by using declared variables vector.
So at that time, the declared variables vector becomes empty and it
raises assertion failures when the builtins function contains the full
activated scope. try-catch's catch scope requires the upper scope full
activated, so JS code in the builtins cannot use the try-catch.

This patch relaxes this restriction. When retrieving the captured
variables from the scope, just copy to the given vector.

  • parser/Parser.h:


08:14 Changeset [186259] by mrobinson@webkit.org
  • 3 edits in trunk

[GTK] Forcefully disable gtk-doc and gobject-introspection when crossbuilding

Patch by Emanuele Aina <emanuele.aina@collabora.com> on 2015-07-03
Reviewed by Martin Robinson.

  • Source/PlatformGTK.cmake: override the cached variables to

forcefully disable gtk-doc and gobject-introspection when

  • Source/cmake/OptionsGTK.cmake: avoid running gtk-doc to check the

documentation syntax when cross-building.

01:45 Changeset [186258] by carlosgc@webkit.org
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r186025): [SOUP] NetworkCache gets blocked in traverse since r186025

Reviewed by Sergio Villar Senin.

In r186025 the readSync method used when traversing the cache
files was removed in favor of using parallel async reads to speed
up the traverse. The approach used doesn't work for soup, because
the IO operations are async, but run their callbacks in the
current thread. The network cache now runs up to 5 async reads in
the io work queue thread, and waits for them to finish, and those
asycn reads never finish for the soup backend because the thread
is blocked waiting for them. We need to use a different thread to
run those reads.

  • NetworkProcess/cache/NetworkCacheIOChannel.h: Add

readSyncInThread private method.

  • NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:

(WebKit::NetworkCache::IOChannel::read): When not called in the
main thread, call readSyncInThread() instead.
(WebKit::NetworkCache::IOChannel::readSyncInThread): Run the read
operation synchronously in a different thread, since the current
thread might be blocked waiting for us.

00:28 Changeset [186257] by youenn.fablet@crf.canon.fr
  • 8 edits in trunk/Source/WebCore

[Streams API] Remove ReadableStream and Reader cancel() custom binding

Reviewed by Darin Adler.

Removed stream and reader cancel custom binding.
Updated binding generator to correctly handle promise-based APIs with optional parameters.

No behavior changes.

  • Modules/streams/ReadableStream.idl: Removed custom
  • Modules/streams/ReadableStreamReader.idl: Ditto.
  • bindings/js/JSReadableStreamCustom.cpp:

(WebCore::JSReadableStream::cancel): Deleted.

  • bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::JSReadableStreamReader::cancel): Deleted.

  • bindings/scripts/CodeGeneratorJS.pm: Handling of promise parameter in case of optional arguments.

(GenerateReturnParameters): Utility function to generate return parameters (exception and promise).

  • bindings/scripts/test/JS/JSTestObj.cpp:


  • bindings/scripts/test/TestObj.idl:


20:34 Changeset [186256] by commit-queue@webkit.org
  • 16 edits
    2 adds in trunk

AX: Selection change as a result of focusing an element should include that
information in the intent

Patch by Doug Russell <d_russell@apple.com> on 2015-07-02
Reviewed by Chris Fleizach.

Added focusChange flag to AXTextStateChangeIntent.
Added intent support to selection logic called by Element::updateFocusAppearance().
Added NSAccessibilityTextSelectionChangedFocus to mac notifications.


Test: platform/mac/accessibility/selection-notification-focus-change.html

  • accessibility/AXObjectCache.cpp:


  • accessibility/AXTextStateChangeIntent.h:
  • accessibility/AccessibilityRenderObject.cpp:


  • accessibility/mac/AXObjectCacheMac.mm:


  • dom/Element.cpp:


  • dom/Element.h:


  • editing/FrameSelection.cpp:


  • editing/FrameSelection.h:
  • html/HTMLInputElement.cpp:


  • html/HTMLTextAreaElement.cpp:


  • html/HTMLTextFormControlElement.cpp:


  • html/HTMLTextFormControlElement.h:
  • page/EventHandler.cpp:


  • page/FocusController.cpp:



  • platform/mac/accessibility/selection-notification-focus-change-expected.txt: Added.
  • platform/mac/accessibility/selection-notification-focus-change.html: Added.
20:08 Changeset [186255] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] test_ewk2_application_cache_manager has been failed since r185527

Patch by Przemek Piorkowski <piorkowskiprzemyslaw@gmail.com> on 2015-07-02
Reviewed by Gyuyoung Kim.

In order to handle properly WebApplicationCacheManagerProxy implementation which use

WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.

  • Source/cmake/OptionsEfl.cmake: set ENABLE_PUBLIC_SUFFIX_LIST to ON for EFL.


WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.

  • PlatformEfl.cmake: PublicSuffixSoup.cpp added to source files.


WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.

  • UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:

(TEST_F): enable ewk_application_cache_manager as it is passing now.

19:40 Changeset [186254] by cdumez@apple.com
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r186251.

caused crashes in webaudio tests (Requested by cdumez on

Reverted changeset:

"Ensure media playback is stopped during page close"

Patch by Commit Queue <commit-queue@webkit.org> on 2015-07-02

19:35 Changeset [186253] by cdumez@apple.com
  • 9 edits in trunk/Source/WebKit2

Unreviewed, rolling out r186247 and r186250.

Broke the build on Mavericks bots (Requested by cdumez on

Reverted changesets:

"Provide API to clear the HSTS cache"

"Unreviewed build fix for non-COCOA ports after r186247."

Patch by Commit Queue <commit-queue@webkit.org> on 2015-07-02

18:48 Changeset [186252] by fpizlo@apple.com
  • 10 edits
    2 adds in trunk/Source/JavaScriptCore

DFG and FTL should have an OSR exit fuzzer

Reviewed by Benjamin Poulain.

Adds a basic OSR exit fuzzer to JSC. This isn't hooked into any test harnesses yet, but I
spot-checked it on v8-earley-boyer.js and so far found no bugs. I'd like to figure out how
to harness this after I land it.

Since it's turned off by default, it should have no effect on behavior.


  • dfg/DFGOSRExitFuzz.h: Added.
  • dfg/DFGSpeculativeJIT.cpp:


  • dfg/DFGSpeculativeJIT.h:
  • ftl/FTLLowerDFGToLLVM.cpp:


  • jsc.cpp:


  • runtime/Options.h:
  • runtime/TestRunnerUtils.h:
18:44 Changeset [186251] by bfulgham@apple.com
  • 7 edits in trunk/Source/WebCore

Ensure media playback is stopped during page close

Reviewed by Zalan Bujtas.

Add new method to Page class to stop all media playback. It just uses the process
MediaSessionManager singleton to inform all hosted in a particular document to stop.

  • Modules/webaudio/AudioContext.h:

(WebCore::WebAudio::hostingDocument): Added.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::hostingDocument): Added.

  • dom/Document.cpp:

(WebCore::Document::commonTeardown): Call the new PlatformMediaSessionManager::stopAllMediaPlaybackForDocument
method on document cleanup.

  • platform/audio/PlatformMediaSession.h:

Made PlatformMediaSessionManager a friend so it can access the protected 'client' accessor.
Updated PlatformMediaSessionClient to require clients to have a "hostingDocument" member.

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::stopAllMediaPlaybackForDocument): Added. Only pauses
playback on elements that match the provided document.

  • platform/audio/PlatformMediaSessionManager.h:
18:43 Changeset [186250] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix for non-COCOA ports after r186247.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deleteWebsiteData): Add PLATFORM(COCOA) guard.

18:27 Changeset [186249] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Tapping a video in Safari causes the video to flash gray for a quick moment

Reviewed by Brent Fulgham.

On iOS, video elements should not show the tap highlight.

  • css/html.css:


17:53 Changeset [186248] by dbates@webkit.org
  • 4 edits
    2 adds in trunk

[iOS] Add WebKitSystemInterface for iOS 8.4

Rubber-stamped by Zalan Bujtas.


  • Scripts/copy-webkitlibraries-to-product-directory:


  • WebKitSystemInterfaceIOS.h:
  • libWebKitSystemInterfaceIOSDevice8.4.a: Added.
  • libWebKitSystemInterfaceIOSSimulator8.4.a: Added.
17:08 Changeset [186247] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Provide API to clear the HSTS cache

Reviewed by Tim Horton.

  • NetworkProcess/NetworkProcess.cpp:


  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:


  • Shared/WebsiteData/WebsiteDataTypes.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:


  • UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:


  • UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:


16:53 Changeset [186246] by saambarati1@gmail.com
  • 16 edits
    4 moves
    2 adds
    2 deletes in trunk

Rename "Deconstruction" to "Destructuring" throughout JSC

Reviewed by Mark Lam.


It is good to use the same naming conventions as the ES6
spec because it is the de facto way of speaking about these
language features. This also has the benefit of improving JSC's
hackability because it improves code readability for newcomers
to JSC or newcomers to this part of the code base.

  • bytecompiler/BytecodeGenerator.cpp:


  • bytecompiler/BytecodeGenerator.h:


  • bytecompiler/NodesCodegen.cpp:

(JSC::DeconstructingAssignmentNode::emitBytecode): Deleted.
(JSC::DeconstructionPatternNode::~DeconstructionPatternNode): Deleted.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createDeconstructingAssignment): Deleted.

  • parser/NodeConstructors.h:

(JSC::DeconstructionPatternNode::DeconstructionPatternNode): Deleted.
(JSC::DeconstructingAssignmentNode::DeconstructingAssignmentNode): Deleted.

  • parser/Nodes.cpp:


  • parser/Nodes.h:

(JSC::ExpressionNode::isDeconstructionNode): Deleted.
(JSC::DeconstructionPatternNode::isBindingNode): Deleted.
(JSC::DeconstructionPatternNode::emitDirectBinding): Deleted.
(JSC::DeconstructingAssignmentNode::bindings): Deleted.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::tryParseDeconstructionPatternExpression): Deleted.
(JSC::Parser<LexerType>::parseDeconstructionPattern): Deleted.
(JSC::Parser<LexerType>::parseDefaultValueForDeconstructionPattern): Deleted.

  • parser/Parser.h:


  • parser/SyntaxChecker.h:


  • tests/stress/reserved-word-with-escape.js:
  • tests/stress/rest-elements.js:


  • js/deconstructing-parameters-should-be-locals-expected.txt: Removed.
  • js/deconstructing-parameters-should-be-locals.html: Removed.
  • js/destructuring-assignment-expected.txt:
  • js/destructuring-parameters-should-be-locals-expected.txt: Copied from LayoutTests/js/deconstructing-parameters-should-be-locals-expected.txt.
  • js/destructuring-parameters-should-be-locals.html: Copied from LayoutTests/js/deconstructing-parameters-should-be-locals.html.
  • js/regress/deconstructing-parameters-overridden-by-function-expected.txt: Removed.
  • js/regress/deconstructing-parameters-overridden-by-function.html: Removed.
  • js/regress/destructuring-parameters-overridden-by-function-expected.txt: Copied from LayoutTests/js/regress/deconstructing-parameters-overridden-by-function-expected.txt.
  • js/regress/destructuring-parameters-overridden-by-function.html: Copied from LayoutTests/js/regress/deconstructing-parameters-overridden-by-function.html.
  • js/regress/script-tests/deconstructing-parameters-overridden-by-function.js: Removed.
  • js/regress/script-tests/destructuring-parameters-overridden-by-function.js: Copied from LayoutTests/js/regress/script-tests/deconstructing-parameters-overridden-by-function.js.
  • js/script-tests/deconstructing-parameters-should-be-locals.js: Removed.
  • js/script-tests/destructuring-assignment.js:

(testDeconstructArgs): Deleted.
(testDeconstructArgLength): Deleted.

  • js/script-tests/destructuring-parameters-should-be-locals.js: Copied from LayoutTests/js/script-tests/deconstructing-parameters-should-be-locals.js.

(description.value.string_appeared_here.readDeconstructedParameter): Deleted.
(overwriteDeconstructedParameter): Deleted.
(readCapturedDeconstructedParameter): Deleted.
(overwriteCapturedDeconstructedParameter): Deleted.

16:40 Changeset [186245] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/ios

iOS WebKitLegacy should match WebKit2's viewport behavior

Reviewed by Brent Fulgham.

  • WebCoreSupport/WebChromeClientIOS.mm:


16:34 Changeset [186244] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

WebKit should use 80% white background for PiP indicator

Reviewed by Brent Fulgham.

The designers wanted 80% white, not 80% black (r186104).
I've also reverted the AirPlay background back to black.

  • Modules/mediacontrols/mediaControlsiOS.css:


16:32 Changeset [186243] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebKit2

Gardening: fix broken 32-bit build..

Not reviewed.

  • UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:


16:31 Changeset [186242] by ggaren@apple.com
  • 3 edits in trunk/Source/bmalloc

bmalloc: Shrink the super chunk size

Reviewed by Andreas Kling.

We have lots of reports of crashing due to failed VM allocation on iOS.
(This VM limit on iOS is usually 1GB-2GB, and has been as low as 256MB.)

Shrink the super chunk size in case fragmentation is the reason for
VM allocation failure.

This has the downside that >= 2MB allocations will now be super slow,
but they are also super rare (as in never on most websites), so this
is probably an OK tradeoff.

  • bmalloc/Sizes.h:
15:57 Changeset [186241] by bfulgham@apple.com
  • 2 edits in trunk/Source/WebKit2

Correct *another* typo in r186238.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Fix parameter name scrolView -> scrollView.
15:44 Changeset [186240] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix the build.

Rubber-stamped by Brady Eidson.

  • WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Http, not HTTP, for settings generator reasons.

15:32 Changeset [186239] by bfulgham@apple.com
  • 2 edits in trunk/Source/WebKit2

Correct typo in r186238.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]):

15:31 Changeset [186238] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Clear current AirPlay source before setting another

Reviewed by Brent Fulgham.

  • Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::clientStateDidChange): Don't make a client begin playing

to the target just because it has paused.

(WebCore::WebMediaSessionManager::configurePlaybackTargetClients): Always select a client that

requrested the picker, and never consider paused clients when choosing a client to begin
playing to the targer. Call setShouldPlayToPlaybackTarget(true) after all of the other
clients have been told to stop playing to the target.

15:17 Changeset [186237] by bfulgham@apple.com
  • 3 edits in trunk/Source/WebKit2

Provide delegate SPI for clients to notify WebKit about content inset changes

Reviewed by Darin Adler.

Provide a new SPI for WebKit client applications to use to inform WebKit of planned
adjustments to the edge insets of the view.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Add new optional delegate method.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]): If the new delegate
method exists, use the specified content insets, rather than the current state of the view.

15:10 Changeset [186236] by bdakin@apple.com
  • 8 edits in trunk/Source

Allow the UIDelegate to customize an image preview
-and corresponding-

Reviewed by Tim Horton.


Add WEBCORE_EXPORT to use this in WK2.

  • loader/cache/CachedResource.h:



Add imageURL to InteractionInformationAtPosition.

  • Shared/InteractionInformationAtPosition.cpp:


  • Shared/InteractionInformationAtPosition.h:

Two new delegate methods.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:

Call the delegate methods at the appropriate time.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView previewViewControllerForPosition:inSourceView:]):
(-[WKContentView commitPreviewViewController:]):

Include the imageURL in InteractionInformationAtPosition.

  • WebProcess/WebPage/ios/WebPageIOS.mm:


14:39 Changeset [186235] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Instead of requiring ToT UIKIt, check that UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP is defined to 1

Reviewed by Beth Dakin.

  • Shared/ios/NativeWebTouchEventIOS.mm:


13:47 Changeset [186234] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove change I accidentally committed in r186232

  • UIProcess/WebsiteData/WebsiteDataStore.h:
13:39 Changeset [186233] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix EWS build after r186182.

  • WebProcess/WebPage/WebPage.h:

Don't export a function defined in a header, or it will generate a weak external symbol.

13:19 Changeset [186232] by beidson@apple.com
  • 17 edits in trunk

Add preference to disable all http-equiv.
<rdar://problem/9091261> and https://bugs.webkit.org/show_bug.cgi?id=146553

Reviewed by Sam Weinig.

No new tests (Covered by existing test)

  • dom/Document.cpp:


  • page/Settings.in:


  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setMetaRefreshEnabled:]): Still expose this SPI, but have it affect

the "httpEquivEnabled" setting.

(-[WebPreferences metaRefreshEnabled]): Ditto.
(-[WebPreferences setHTTPEquivEnabled:]):
(-[WebPreferences httpEquivEnabled]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _preferencesChanged:]):


  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMetaRefreshEnabled): Still expose this SPI, but have it affect

the "httpEquivEnabled" setting.

(WKPreferencesGetMetaRefreshEnabled): Ditto

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:


  • WebProcess/WebPage/WebPage.cpp:



  • loader/meta-refresh-disabled.html:
12:27 Changeset [186231] by youenn.fablet@crf.canon.fr
  • 8 edits in trunk/Source/WebCore

[Streams API] Remove ReadableStreamController.enqueue() custom binding

Reviewed by Darin Adler.

Made enqueue not custom. Updated error to use Default=Undefined in IDL.

No change in behavior.

  • Modules/streams/ReadableStreamController.h:

(WebCore::ReadableStreamController::error): Removed unneeded variation of error.
(WebCore::ReadableStreamController::enqueue): Calling ReadableJSStream enqueue method.

  • Modules/streams/ReadableStreamController.idl: Updated error with Default=Undefined and made enqueue not custom.
  • bindings/js/JSDOMBinding.cpp:

(WebCore::createDOMException): Adding support for RangeError exceptions.

  • bindings/js/JSReadableStreamControllerCustom.cpp:

(WebCore::constructJSReadableStreamController): Deleted.

  • bindings/js/ReadableJSStream.cpp:

(WebCore::ReadableJSStream::error): Updated to pass error value as parameter.
(WebCore::ReadableJSStream::enqueue): Added exception throwing through ExceptionCode.
(WebCore::ReadableJSStream::retrieveChunkSize): Ditto.

  • bindings/js/ReadableJSStream.h:
  • dom/ExceptionCode.h: Adding RangeError.
11:44 Changeset [186230] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for Win EWS bot.

Not reviewed.

  • tools/JSDollarVMPrototype.cpp:


11:38 Changeset [186229] by mark.lam@apple.com
  • 6 edits
    1 add in trunk/Source/WebKit2

WKWebView evaluateJavaScript:completionHandler: should reuse its JSContext instance.

Reviewed by Anders Carlsson.

The core issue here is that we need to be able to deserialized an
API::SerializedScriptValue instance into an ObjC object graph. We'll solve this
by introducing a API::SerializedScriptValue::deserialize() functions that does
the job. The deserialize() function will will use a SharedJSContext to provide
the needed JSContext for doing this work.

Also updated ScriptMessageHandlerDelegate::didPostMessage() to use this new
deserialize() function.

  • Shared/API/APISerializedScriptValue.h:


  • Changed to return a WebCore::SerializedScriptValue*. This makes it friendlier to use in the 2 places that need it.
  • UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm: Added.


  • UIProcess/API/Cocoa/WKUserContentController.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView evaluateJavaScript:completionHandler:]):

  • UIProcess/API/gtk/WebKitWebView.cpp:


  • Removed a now unnecessary cast.
  • WebKit2.xcodeproj/project.pbxproj:
11:33 Changeset [186228] by beidson@apple.com
  • 3 edits
    3 adds in trunk

[Content Extensions] Block synchronous XMLHTTPRequest.
<rdar://problem/21573006> and https://bugs.webkit.org/show_bug.cgi?id=146271

Reviewed by Alex Christensen.


Test: http/tests/contentextensions/sync-xhr-blocked.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously): If content blocked, set up an error, clear

the response, and clear the response data.


  • http/tests/contentextensions/sync-xhr-blocked-expected.txt: Added.
  • http/tests/contentextensions/sync-xhr-blocked.html: Added.
  • http/tests/contentextensions/sync-xhr-blocked.html.json: Added.
10:31 Changeset [186227] by drousso@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Show suggest popover on Tab press even if it wasn't showing before

Reviewed by Timothy Hatcher.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey): Pressing tab will try to autocomplete before trying
to add an ending colon/semicolon or highlight the next section of text.

09:04 Changeset [186226] by mitz@apple.com
  • 4 edits in trunk/Source

<rdar://problem/21429613> [iOS] Stop making symlinks from PrivateFrameworks to Frameworks

Reviewed by Sam Weinig.


  • JavaScriptCore.xcodeproj/project.pbxproj: Removed the build phase that makes the symlink.


  • WebKit2.xcodeproj/project.pbxproj: Removed the build phase that makes the directory of


07:56 WebKitGTK/Gardening/Howto edited by clopez@igalia.com
07:52 WebKitGTK/2.8.x edited by clopez@igalia.com
07:45 WebKitGTK/2.8.x edited by clopez@igalia.com
06:00 Changeset [186225] by carlosgc@webkit.org
  • 5 edits in trunk

[GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18

Reviewed by Sergio Villar Senin.


This is because we don't provide any quota, and 0 is used by
default, so there's never enough quota and openDatabase fails. We
should expose this in the API, but for now, we could use a default
quota of 5MB like WTR does.

  • UIProcess/API/gtk/WebKitUIClient.cpp: Override

exceededDatabaseQuota and return always the default quota.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::exceededDatabaseQuota): Return the quota based on the
expected usage and current database usabe like mac does.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Add
custom UI client to implement exceededDatabaseQuota.


Enable the WebSQL directory test that was disabled because of this bug.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:


05:13 Changeset [186224] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Unreviewed, rolling out r185704.

Didn't fix the problem (Requested by anttik on #webkit).

Reverted changeset:

"~4% Membuster regression after WebKit r185452"

00:36 Changeset [186223] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit

iOS WebKitLegacy should match WebKit2's viewport behavior

Reviewed by Dan Bernstein.

A number of changes have been made to WebKit2's viewport behavior
to make it possible to scale "responsive" sites that misbehave (lay out
in a non-responsive way).

  • History/WebHistoryItem.mm:
  • History/WebHistoryItemPrivate.h:

Add the plumbing required to implement these new behaviors in WebKit1.

  • WebKit.iOS.exp:
00:27 Changeset [186222] by achristensen@apple.com
  • 4 edits in trunk/LayoutTests

Skip new web timing test on platforms without web timing.

  • platform/ios-sim-deprecated/Skipped:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
00:08 Changeset [186221] by carlosgc@webkit.org
  • 4 edits in trunk/Source/WebKit2

[GTK] Accelerated Compositing stops working after a web process crash

Reviewed by Martin Robinson.

The problem is that we don't send the window ID again to the new
web process.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didRelaunchProcess): Call

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDidRelaunchWebProcess): Set the window ID to
the new drawing area.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:


23:59 Changeset [186220] by achristensen@apple.com
  • 8 edits in trunk/Source

Re-enable WebGL on WinCairo

Reviewed by Csaba Osztrogonác.

  • ANGLE.vcxproj/DirectX32.props:
  • ANGLE.vcxproj/DirectX64.props:
  • ANGLE.vcxproj/libGLESv2Common.props:

Update DirectX directories to use the Windows SDK instead of the June 2010 DirectX SDK.

Re-enable WebGL on WinCairo.

Reviewed by Csaba Osztrogonác.

  • WebKit.vcxproj/WebKit.sln:

Build the ANGLE projects on WinCairo again.

Re-enable WebGL on WinCairo

Reviewed by Csaba Osztrogonác.

  • wtf/FeatureDefines.h:

Enable WebGL on WinCairo again.

23:41 Changeset [186219] by achristensen@apple.com
  • 3 edits in trunk/LayoutTests

Fix test from r186208 and r186216.

  • http/tests/misc/webtiming-resolution-expected.txt:
  • http/tests/misc/webtiming-resolution.html:

Properly and explicitly test if the time delta is close to a multiple of the expected resolution.

21:46 Changeset [186218] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Web Inspector: Aggregate profile call information on the backend to drastically reduce profile sizes

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-01
Reviewed by Timothy Hatcher.


  • inspector/protocol/Timeline.json:

Change a CPUProfile from sending a required "calls" param to sending a required
"callInfo" param which includes aggregated information about the calls.


  • inspector/TimelineRecordFactory.cpp:

Replace the array of Call objects with a single aggregated call info object.


Since we still support legacy backends, the frontend documents where
it is handling legacy backends with compatibility comments.

  • UserInterface/Models/ProfileNode.js:

(WebInspector.ProfileNode.prototype.get callInfo):
Handle a ProfileNode created with callInfo or calls. They are mutually exclusive.

  • UserInterface/Models/ScriptTimelineRecord.js:

If the profile has per-call information, construct ProfileNodeCall objects, otherwise
just construct the ProfileNode with the aggregate callInfo value.

  • UserInterface/Views/ScriptTimelineDataGridNode.js:

(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
When we have aggregate call information we cannot easily partition a script,
so we instead treat the entire script as one large atomic unit in the timeline.
If the timeline range has any portion of the script, show the entire script.
Users used to be able to select a portion of a script and view the relevant
functions called in just that sliver, but this doesn't appear to be a well
known feature or commonly used. In fact, given the small ranges of time it
could be confusing for users.

  • UserInterface/Views/TimelineRecordingContentView.js:

Treat as a discrete unit.

21:30 Changeset [186217] by drousso@apple.com
  • 4 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: When autocompleting, pressing tab twice shouldn't insert a tab character

Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype.updateCompletions): Resolves the promise as having completions.
(WebInspector.CodeMirrorCompletionController.prototype.hideCompletions): Resolves the promise as not having completions.
(WebInspector.CodeMirrorCompletionController.prototype.completeAtCurrentPositionIfNeeded): Returns a WrappedPromise that allows
callers of this function to determine if the autocomplete had any values or was instead not shown.

  • UserInterface/Main.html: Added WrappedPromise class.
  • UserInterface/Models/WrappedPromise.js: Added WrappedPromise object to expose resolve and reject functions.
  • UserInterface/Views/ConsolePrompt.js:

(WebInspector.ConsolePrompt.prototype._handleTabKey): Attempts to find completions for current text. If there are none, beep.

21:01 Changeset [186216] by cdumez@apple.com
  • 3 edits in trunk/LayoutTests

Reduce resolution of performance.now

Reviewed by Simon Fraser.

Make layout test introduced in r186208.

  • http/tests/misc/webtiming-resolution-expected.txt:
  • http/tests/misc/webtiming-resolution.html:
18:30 Changeset [186215] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG::freezeFragile should register the frozen value's structure

Reviewed by Mark Lam and Geoffrey Garen.

This fixes weird concurrency bugs where the constant folding phase tries to convert
something to a constant but then crashes because the constant's structure wasn't
registered. The AI was registering the structure of any value it saw, but constant folding
wasn't - and that's fine so long as there ain't no concurrency.

The best fix is to just make it impossible to introduce a constant into the IR without
registering its structure. That's what this change does. This is not only a great
concurrency fix - it also makes the compiler somewhat easier to hack on because it's one
less case of structure registering that you have to remember about.

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::setOSREntryValue): No need to register.
(JSC::DFG::AbstractValue::set): We still call register, but just to get the watchpoint state.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::freezeFragile): Register the structure.

  • dfg/DFGStructureRegistrationPhase.cpp:

(JSC::DFG::StructureRegistrationPhase::run): Assert that these are all registered.

17:51 Changeset [186214] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Web Inspector: [Mac] InspectorFrontendHost.beep() doesn't play a sound, sandbox warnings

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-01
Reviewed by Timothy Hatcher.

  • WebProcess/com.apple.WebProcess.sb.in:

Get NSBeep working without any sandbox warnings.

17:48 Changeset [186213] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.17-branch/Source


17:47 Changeset [186212] by drousso@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Make the first click on a rule section create a newline for easy property addition

Reviewed by Timothy Hatcher.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleEnterKey): Inserts a semicolon if the line is missing one.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleMouseDown): If the user clicks on a property with the editor being
unfocused, the name/value containing the cursor will be highlighted. If instead the user clicks at the end of a line, the
cursor's position is saved for mouseUp.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleMouseUp): If the mouseDown cursor position was saved and is equal
to the current cursor's position (the user did not drag), add a newline after the current line and place the cursor on that line.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey.highlightNextNameOrValue): Deleted.

17:40 Changeset [186211] by cdumez@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline js/dom/global-constructors-attributes.html after r186198.

  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
17:36 Changeset [186210] by bfulgham@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] REGRESSION (r185124) CACFLayer handling broken

Reviewed by Tim Horton.

At some point in the past, the set of LayerChange flags
overflowed the default MSVC enum type of 'int'. This caused
Windows rendering code to not receive various update notifications.

Zalan's change moved the DebugIndicatorsChanged flag into that
overflow set, which made it obvious that something was wrong.

The fix is to tell the compiler to use a compatible base type
for the enum.

  • platform/graphics/ca/GraphicsLayerCA.h: Prevent overflow.
17:32 Changeset [186209] by bshafiei@apple.com
  • 5 edits in branches/safari-600.8-branch/Source


17:29 Changeset [186208] by achristensen@apple.com
  • 3 edits
    2 adds in trunk

Reduce resolution of performance.now.

Reviewed by Simon Fraser.


Test: http/tests/misc/webtiming-resolution.html

  • page/Performance.cpp:

Floor the time returned by performance.now to the nearest 5 microseconds.


  • http/tests/misc/webtiming-resolution-expected.txt: Added.
  • http/tests/misc/webtiming-resolution.html: Added.
17:07 Changeset [186207] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Ignore Visual Studio warning in SegmentedVector

Patch by Alex Christensen <achristensen@webkit.org> on 2015-07-01
Reviewed by Andreas Kling.

  • wtf/SegmentedVector.h:

Use pragmas to ignore the 0 element array warning.

17:05 Changeset [186206] by bfulgham@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Build fix

Patch by Eric Carlson <eric.carlson@apple.com> on 2015-07-01
Reviewed by Brent Fulgham.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVVideoLayer enterPIPModeRedirectingVideoToLayer:]): Renamed from enterOptimizedFullScreenModeRedirectingVideoToLayer.
(-[WebAVVideoLayer leavePIPMode]): Renamed from leaveOptimizedFullScreenMode.
(-[WebAVVideoLayer enterOptimizedFullScreenModeRedirectingVideoToLayer:]): Deleted.
(-[WebAVVideoLayer leaveOptimizedFullScreenMode]): Deleted.

17:02 Changeset [186205] by mmaxfield@apple.com
  • 5 edits
    3 adds in trunk

[iOS] Support bold and thin italicized system fonts

Reviewed by Darin Adler.


Add the italicized attribute to font descriptors.

Test: fast/text/weighted-italicized-system-font.html

  • platform/graphics/ios/FontCacheIOS.mm:


  • platform/graphics/mac/FontCacheMac.mm:


  • platform/spi/cocoa/CoreTextSPI.h:


  • fast/text/weighted-italicized-system-font-expected.html: Added.
  • fast/text/weighted-italicized-system-font.html: Added.
17:00 Changeset [186204] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove code to recompute rounded window corners

Reviewed by Simon Fraser.

This code is no longer needed since we're always layer-backed now.

  • UIProcess/API/mac/WKView.mm:

(-[WKView displayIfNeeded]): Deleted.
(-[WKView _cacheWindowBottomCornerRect]): Deleted.

  • UIProcess/API/mac/WKViewInternal.h:
16:36 Changeset [186203] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

bmalloc: realloc of an XLarge range can unmap adjacent VM ranges

Reviewed by Anders Carlsson.

This bug causes a crash when running fast/css/large-list-of-rules-crash.html
with the fix applied for https://bugs.webkit.org/show_bug.cgi?id=146519.

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::reallocate): Start at object + newSize since starting
at object + oldSize means deleting the adjacent VM range.

16:28 Changeset [186202] by mmirman@apple.com
  • 13 edits
    5 deletes in trunk

Unreviewed, rolling out r185889

Patch breaks chromeexperiments.com

Reverted changeset:



  • runtime/JSBoundSlotBaseFunction.cpp: Removed.
  • runtime/JSBoundSlotBaseFunction.h: Removed.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Deleted.
(JSC::JSGlobalObject::visitChildren): Deleted.

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::boundSlotBaseFunctionStructure): Deleted.

  • runtime/JSObject.cpp:

(JSC::getBoundSlotBaseFunctionForGetterSetter): Deleted.

  • runtime/VM.cpp:

(JSC::VM::VM): Deleted.

  • runtime/VM.h:


  • inspector-protocol/runtime/getProperties-expected.txt:
  • js/dom/native-bindings-descriptors-expected.txt: Removed.
  • js/dom/native-bindings-descriptors.html: Removed.
  • js/dom/script-tests/native-bindings-descriptors.js: Removed.
16:26 Changeset [186201] by achristensen@apple.com
  • 17 edits
    1 delete in trunk/Source

Fix ANGLE Windows build after r186169.

Reviewed by Brent Fulgham.


  • ANGLE.vcxproj/libEGL.vcxproj:
  • ANGLE.vcxproj/libEGL.vcxproj.filters:
  • ANGLE.vcxproj/libGLESv2.vcxproj:
  • ANGLE.vcxproj/libGLESv2.vcxproj.filters:
  • ANGLE.vcxproj/libGLESv2Common.props:
  • ANGLE.vcxproj/translator_common.vcxproj:
  • ANGLE.vcxproj/translator_common.vcxproj.filters:
  • ANGLE.vcxproj/translator_glsl.vcxproj:
  • ANGLE.vcxproj/translator_glsl.vcxproj.filters:
  • ANGLE.vcxproj/translator_hlsl.vcxproj:
  • ANGLE.vcxproj/translator_hlsl.vcxproj.filters:

Update Windows build to build new files.


  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Don't compile OpenGLShims.cpp or Extensions3DOpenGL.cpp on Windows
because Windows uses OpenGLES through ANGLE, not OpenGL.

  • platform/graphics/ANGLEWebKitBridge.h:

Use OpenGLESShims.h on Windows instead of OpenGLShims.h.

  • platform/graphics/OpenGLESShims.h:

Added needed definitions from OpenGL to compile successfully.

  • platform/graphics/win/GL/glext.h: Removed.
16:17 Changeset [186200] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Web page doesn't update its loading state when web process becomes suspended if there are pending network requests (XHR).

When web page is loading, we hold a background activity token in NavigationState and we release the token when the page done
loading. A web page can start loading subresources (like XHR) after the page is loaded, and WebPageProxy will update its
_networkRequestsInProgress state which will notify the client there is network actvity on-going. Since we don't hold
the background activity token after page is loaded, the WebContent process could become suspended without notifying the client
and the client will lose track of the loading state.

The first thought was to hold another background activity when _networkRequestsInProgress flag is set in NavigationState.
However, this could result in side-effect that a WebContent process can stay active for too long if there is a long lasting
XHR resquest.

This patch fix this by notifying the client that network activity is stopped when WebContent process is going to be suspended.
We also cache the networkRequestsInProgress state for suspended process, so that when it becomes foreground, we can tell
the client the correct state of network activity.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-07-01
Reviewed by Dan Bernstein.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Initialize m_hasNetworkRequestsOnSuspended.
(WebKit::WebPageProxy::processWillBecomeSuspended): If there is pending requests on suspend, cache the network activity state

and notify the client.

(WebKit::WebPageProxy::processWillBecomeForground): Restore the network activity state when the process becomes foreground.

  • UIProcess/WebPageProxy.h: Add a data member m_hasNetworkRequestsOnSuspended to cache the network activity state on process


  • UIProcess/WebProcessProxy.cpp:


16:09 Changeset [186199] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Turn off mediastreamaudiosourcenode.html test

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Simon Fraser.

  • platform/mac/TestExpectations:
15:38 Changeset [186198] by dino@apple.com
  • 24 edits in trunk/Source

Disable the experimental WebGL2 implementation

Reviewed by Myles Maxfield.


Add (and disable) an ENABLE_WEBGL2 flag.

  • Configurations/FeatureDefines.xcconfig:


Add (and disable) an ENABLE_WEBGL2 flag. Also protect
anything that is specific to WebGL2.

Covered by running the WebGL 1.0.2 conformance suite
and our LayoutTests.

  • Configurations/FeatureDefines.xcconfig:
  • bindings/js/JSCanvasRenderingContextCustom.cpp:


  • bindings/js/JSWebGL2RenderingContextCustom.cpp:
  • bindings/js/JSWebGLRenderingContextBaseCustom.cpp:


  • html/HTMLCanvasElement.cpp:


  • html/canvas/WebGL2RenderingContext.cpp:
  • html/canvas/WebGL2RenderingContext.h:
  • html/canvas/WebGL2RenderingContext.idl:
  • html/canvas/WebGLFramebuffer.cpp:


  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContextBase.cpp:


  • html/canvas/WebGLVertexArrayObject.cpp:
  • html/canvas/WebGLVertexArrayObject.h:
  • html/canvas/WebGLVertexArrayObject.idl:


Add (and disable) an ENABLE_WEBGL2 flag.

  • Configurations/FeatureDefines.xcconfig:


Add (and disable) an ENABLE_WEBGL2 flag.

  • Configurations/FeatureDefines.xcconfig:


Add (and disable) an ENABLE_WEBGL2 flag.

  • wtf/FeatureDefines.h:
15:22 Changeset [186197] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Fix missing space.

  • platform/mac/TestExpectations:
14:54 Changeset [186196] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Never try to pass URLs to LaunchServices when they're the same domain as the current URL.
<rdar://problem/20731429> and https://bugs.webkit.org/show_bug.cgi?id=146521

Reviewed by Alex Christensen.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::tryAppLink): Compare the proposed URL to the current URL to see if they’re in the same domain.

14:52 Changeset [186195] by cdumez@apple.com
  • 7 edits
    2 adds in trunk

Regression(183998): Disqus comments take a very long time to load

Reviewed by Simon Fraser.


Stop throttling requestAnimationFrame() in iframes that are not visible
due to them being zero-sized or display:none. Those are usually utility
iframes and throttling them is risky.

Se still throttle requestAnimationFrame() in iframes that would be
visible in theory but are currently not noticeable because they are
outside the viewport.


  • fast/animation/request-animation-frame-throttle-subframe.html
  • fast/animation/request-animation-frame-throttle-subframe-display-none.html
  • fast/animation/request-animation-frame-throttle-subframe-zero-size.html
  • page/FrameView.cpp:



  • fast/animation/request-animation-frame-throttle-subframe-display-none-expected.txt:
  • fast/animation/request-animation-frame-throttle-subframe-display-none.html:

Update layout test as we changed behavior here. We no longer throttle display:none

  • fast/animation/request-animation-frame-throttle-subframe-zero-size-expected.txt: Added.
  • fast/animation/request-animation-frame-throttle-subframe-zero-size.html: Added.

Add layout test to check that we don't throttle RaF in iframes that are zero-sized.

  • fast/animation/resources/requestAnimationFrame-frame-2.html:
  • fast/animation/resources/requestAnimationFrame-frame.html:

Update use of requestAnimationFrame() to be more representative of real world usage.

14:34 Changeset [186194] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

WKWebView snapshots have the wrong scale after rotation

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
"Coordinate" -> "Coordinates".

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
Defer any snapshotting that happens during a resize until after
the resize completes. This will ensure that (in the case of an IOSurface
snapshot) the tiles are up to date, and (in the case of a software snapshot)
that our understanding of the scale and scroll offset of the WKContentView
are up to date, so that we can correctly convert from view to content coordinates
in the UI process.

(-[WKWebView _endAnimatedResize]):
Perform the deferred snapshotting after the resize completes.

14:21 Changeset [186193] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix the iOS build.

  • WebCoreSupport/WebUserMediaClient.mm:

(-[WebUserMediaPolicyListener denyOnlyThisRequest]): Remove ASSERT_NOT_REACHED,
because it caused the compiler to warn about noreturn.

13:53 Changeset [186192] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Mark compositing/masks/compositing-clip-path-origin.html as being image-flakey.

  • platform/mac/TestExpectations:
13:31 Changeset [186191] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION (r179168): Characters overlap after resizing the font on the copy-pasted Japanese text

Reviewed by Darin Adler.


The bug was caused by WebKit serializing the used line-height size (e.g. 18px) in the copied content
instead of string "normal" and removeStyleFromRulesAndContext failing to strip it down when text with
a font that influences the line height got pasted. This is because the used value of line-height
property of the context and the pasted content doesn't match when the context doesn't use the same font.

Fixed the bug by not considering line-height as a list of editing properties we try to preserve. This is
fine because we don't provide editing operations to directly manipulate line-height.

Test: editing/pasteboard/cjk-line-height.html

  • editing/EditingStyle.cpp:

(WebCore::editingProperties): Removed CSSPropertyLineHeight.


Added a regression test. Also reverted the bad rebaseline in r179168:

  • editing/pasteboard/cjk-line-height-expected.txt: Added.
  • editing/pasteboard/cjk-line-height.html: Added.
  • editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt:
13:07 Changeset [186190] by bshafiei@apple.com
  • 1 copy in branches/safari-600.8-branch

New Branch.

13:07 Changeset [186189] by bshafiei@apple.com
  • 1 copy in branches/safari-600.1.4.17-branch

New Branch.

12:34 Changeset [186188] by bshafiei@apple.com
  • 5 edits
    1 copy
    1 delete in tags/Safari-601.1.38/Source/WebKit2

Roll out r185936. rdar://problem/21637235

12:33 Changeset [186187] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.38/Source

Roll out r185939. rdar://problem/21637235

12:32 Changeset [186186] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.38/Source/WebCore

Roll out r185951. rdar://problem/21637235

12:29 Changeset [186185] by bfulgham@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION (r184296): View keeps scrolling upward

Reviewed by Darin Adler.

Avoid improperly triggering the ScrollController wheel event handling
logic when the wheel event deltaX/deltaY are zero. On certain sites,
this caused a programmatic JavaScript scroll to be triggered unexpectedly,
scrolling the page back to some initial state.

This bug was introduced while trying to make sure scrollbars were notified
when the wheel event had come to an end. Revise that change so that we still
follow the right code path for non-stretchable regions. However, make sure
that for zero-delta wheel events we make sure to properly handle the wheel
event phase.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::shouldForwardWheelEventsToParent): New helper function
to reduce the complexity of the logic in handleWheelEvent.
(WebCore::ScrollAnimatorMac::handleWheelEvent): When wheel events should be forwarded
to the parent scroll view, if the event was handled or has no change in position
trigger the 'handleWheelEventPhase' logic so that scrollbars are hidden, etc.

12:11 Changeset [186184] by bdakin@apple.com
  • 2 edits in trunk/Source/WebKit2

This is a quick follow-on to http://trac.webkit.org/changeset/186132

Rubber-stamped by Darin Adler.

Make this a one-liner.

  • WebProcess/WebPage/ios/WebPageIOS.mm:


12:08 Changeset [186183] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Hide the inline controls when going into PiP

Reviewed by Eric Carlson.

When the presentation mode is PiP, toggle a class
on the container element so that we can completely
hide the control toolbar. The placard should still
remain visible.

  • Modules/mediacontrols/mediaControlsiOS.css:

(video::-webkit-media-controls-panel-container.picture-in-picture): Add
a rule that hides the toolbar when PiP is active.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handlePresentationModeChange): Toggle a
class. Also fix a bug I noticed where exiting from PiP was
not auto-hiding the controls until the user tapped.

11:44 Changeset [186182] by commit-queue@webkit.org
  • 30 edits in trunk

Enable MEDIA_STREAM flag

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

  • Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag

Enable MEDIA_STREAM flag

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

  • Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag
  • Modules/mediastream/MediaStreamTrack.h:
  • WebCore.xcodeproj/project.pbxproj: Changed project headers to

private headers

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/AVAudioCaptureSource.mm:
  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::refreshCaptureDeviceList): Deleted.

  • platform/mediastream/mac/AVMediaCaptureSource.mm:


Enable MEDIA_STREAM flag

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

  • Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag
  • WebCoreSupport/WebUserMediaClient.h: Changed signatures
  • WebCoreSupport/WebUserMediaClient.mm: Changed signatures

(-[WebUserMediaPolicyListener denyOnlyThisRequest]):
(-[WebUserMediaPolicyListener shouldClearCache]):

Enable MEDIA_STREAM flag

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

  • Configurations/FeatureDefines.xcconfig: Add MEDIA_STREAM flag
  • WebKit2.xcodeproj/project.pbxproj: Changed some project to private

declarations of headers

  • WebProcess/WebCoreSupport/WebUserMediaClient.cpp:
  • WebProcess/WebPage/WebPage.h:


Enabled MEDIA_STREAM flag

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

  • TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:

Enable MEDIA_STREAM flag

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

Added attributes to tests

  • platform/mac/js/dom/global-constructors-attributes-expected.txt:


10:35 Changeset [186181] by bfulgham@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r185016): Intermittent crash in WebCore::TextTrackList::remove

Reviewed by Eric Carlson.

The m_textTracks member is frequently null checked during other operations, but
was not checked during track removal. This needs to be corrected.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removeTextTrack): Check that m_textTracks is
not null before using it during track removal.

10:22 Changeset [186180] by antti@apple.com
  • 7 edits
    2 adds in trunk

PNG mask images are loaded with Accept:image/svg+xml


Reviewed by Simon Fraser.

For some strange reason MaskImageOperation code loads all mask images, including non-SVG ones
using CachedSVGDocument. Resulting bad accept header may cause server to reject the request.

This is far from ideal but as a quick fix we can override the accept header for mask images to
allow any image type.

Test: http/tests/misc/mask-image-accept.html

  • loader/cache/CachedResourceLoader.cpp:


  • loader/cache/CachedResourceRequest.h:


  • loader/cache/CachedSVGDocumentReference.cpp:


  • loader/cache/CachedSVGDocumentReference.h:


  • platform/graphics/MaskImageOperation.cpp:



Reviewed by Simon Fraser.

  • http/tests/misc/mask-image-accept-expected.html: Added.
  • http/tests/misc/mask-image-accept.html: Added.
10:13 Changeset [186179] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (185319): Reproducible crash in WebHistoryItem launching FluidApp.
<rdar://problem/21598293> and https://bugs.webkit.org/show_bug.cgi?id=146494

Reviewed by Darin Adler.

  • History/WebHistoryItem.mm:

(-[WebHistoryItem initFromDictionaryRepresentation:]): Don’t reference members of a Vector

that don’t exist.

09:53 Changeset [186178] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Check shouldOpenExternalURLs instead of isProcessingUserGesture before passing URL to LaunchServices.
<rdar://problem/20577859> and https://bugs.webkit.org/show_bug.cgi?id=146513

Reviewed by Darin Adler.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::tryAppLink): The expected value of isProcessingUserGesture is lost over redirects.

shouldOpenExternalURLs actually fits this role perfectly.

08:54 Changeset [186177] by jer.noble@apple.com
  • 4 edits
    11 adds in trunk

[MSE] Failures on W3C media-source tests regarding MIME types

Reviewed by Eric Carlson.


Tests: http/tests/media/media-source/SourceBuffer-abort-readyState.html


Multiple failures in the W3C media-source test suite due to two failures in isTypeSupported MIME type handling:

  • MIME types without codec strings were being rejected.
  • MIME types with codec strings which are rejected by the system are being reported as supported.

For the first, stop rejecting MIME types with non-existent codec strings. For MIME types which do have non-empty
codec strings, treat a "Maybe" response as unsupported.

  • Modules/mediasource/MediaSource.cpp:



Import four new tests from the w3c test suite <https://github.com/w3c/web-platform-tests.git>.

  • http/tests/media/media-source/SourceBuffer-abort-readyState.html: Added.
  • http/tests/media/media-source/SourceBuffer-abort-removed.html: Added.
  • http/tests/media/media-source/SourceBuffer-abort-updating.html: Added.
  • http/tests/media/media-source/SourceBuffer-abort.html: Added.
  • http/tests/media/white.mp4: Added.
  • http/tests/media/white.webm: Added.
  • platform/mac/TestExpectations:
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-expected.txt: Added.
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-readyState-expected.txt: Added.
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-removed-expected.txt: Added.
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-updating-expected.txt: Added.
  • platform/mac/http/tests/media/media-source/mediasource-is-type-supported-expected.txt: Added.
08:44 Changeset [186176] by mcatanzaro@igalia.com
  • 2 edits in trunk/Source/WebKit2

[GTK] [Wayland] Build broken with ENABLE_WAYLAND_TARGET=ON

Unreviewed, fix build with ENABLE_WAYLAND_TARGET=ON after r185949.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:


07:51 Changeset [186175] by mrobinson@webkit.org
  • 5 edits
    2 copies in trunk

[GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936

Reviewed by Carlos Garcia Campos.


Instead of setting spell checking languages unconditionally when building int
developer mode, add some C API that allows setting them in WebKitTestRunner.

  • PlatformGTK.cmake: Add the new C API file to the source list.
  • UIProcess/API/C/gtk/WKTextCheckerGtk.cpp:

(WKTextCheckerSetSpellCheckingLanguages): Added this function which allows settings
the spell checking languages from the C API.

  • UIProcess/API/C/gtk/WKTextCheckerGtk.h: Added.
  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::enchantTextChecker): Remove the hack which sets the spell checking languages automatically
for development builds.


  • WebKitTestRunner/gtk/main.cpp:

(main): Use the new WKTextChecker API to set the spell checking languages
when the process is starting up.

01:55 Changeset [186174] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Mac] Numerous CGColor leaks in swipe gestures

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-01
Reviewed by Tim Horton.

  • UIProcess/mac/ViewGestureControllerMac.mm:


01:51 Changeset [186173] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Mac] Confusing RetainPtr use in TiledCoreAnimationDrawingArea

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-01
Reviewed by Tim Horton.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

Simplify adoption into a new RetainPtr.


23:26 Changeset [186172] by achristensen@apple.com
  • 4 edits in trunk/Source

[Win] Unreviewed build fix after r186169.


  • WebKit.vcxproj/WebKit.sln:

Temporarily don't build ANGLE projects on Windows.


  • wtf/FeatureDefines.h:

Temporarily disable WebGL on WinCairo. It was already temporarily disabled on AppleWin.

23:23 Changeset [186171] by bshafiei@apple.com
  • 5 edits in trunk/Source


23:18 Changeset [186170] by bshafiei@apple.com
  • 6 edits in tags/Safari-601.1.38/Source/WebKit2

Roll out r186148. rdar://problem/20655729

23:17 Changeset [186169] by achristensen@apple.com
  • 160 edits
    541 adds
    85 deletes in trunk/Source

Update ANGLE to b11e2483742db884bd0af41f78f528240577356b.

Reviewed by Dean Jackson.


Huge list of source changes omitted.


  • CMakeLists.txt:
  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::getValidationResultValue): Deleted.

  • platform/graphics/ANGLEWebKitBridge.h:


  • platform/graphics/GraphicsContext3D.h:


  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

Update WebCore to reflect changes in ANGLE.

23:15 Changeset [186168] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.38

New tag.

23:08 Changeset [186167] by gyuyoung.kim@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Unreviewed gardening.

Some tests are flaky or timeout after bumping Ubuntu version from 14.04 to 15.04.
Mark the tests to flaky or timeout.

  • platform/efl/TestExpectations:
  • platform/efl/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
22:59 Changeset [186166] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skip this test for now. We can unskip it when this feature is enabled.

  • js/script-tests/intl.js:
21:30 Changeset [186165] by zalan@apple.com
  • 5 edits
    2 adds in trunk

Frame flattening: Hit-testing an iframe could end up destroying the associated inline tree context.

Reviewed by Simon Fraser.

This patch ensures that the render tree associated with the document on which
the hit-test is initiated does not get laid out, unless it was directly mutated prior to the hittest.

Hit-test requirements:

  1. A clean the render tree before hit-testing gets propagated to the renderers.

Document::updateLayout() ensures it by calling both updateStyleIfNeeded() and layout() not only on the current tree, but also
on the ancestors if needed.

  1. No render tree mutation while hit-testing the renderers.

When an iframe is being hit-tested, this hit-test could bubble down to the child frame's render view.
In order to ensure #1, we call Document::updateLayout() on the current (subframe) document.
If updateStyleIfNeeded() mutates the render tree, we mark it dirty for layout(). However frame flattening also
marks the parent renderer (RenderIFrame) dirty.
While calling layout() to clean the current render tree, we end up laying out the parent tree too.
Laying out the parent tree could end up destroying the inline tree context from where the
hittest just bubbled down. (InlineFlowBox -> RenderWidget -> RenderView).

This patch protects the render tree from such unintentional inline tree mutation during hittesting.
After the initial layout we set a layout disallow flag on the frame view to defer subsequent layouts.
This patch only changes behavior when frame flattening is enabled, but in future we may always want to enable this.


Test: fast/frames/flattening/hittest-iframe-while-style-changes-crash.html

  • page/FrameView.cpp:

(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded): Deleted. -> Assertion in no longer valid.

  • page/FrameView.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::hitTest): Protect the render tree from subsequent layouts.


  • fast/frames/flattening/hittest-iframe-while-style-changes-crash-expected.txt: Added.
  • fast/frames/flattening/hittest-iframe-while-style-changes-crash.html: Added.
19:39 Changeset [186164] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix CoordinatedGraphics.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:


19:07 Changeset [186163] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: add " = $0" hint after selected element in main DOMTreeOutline

Patch by Devin Rousso <drousso@apple.com> on 2015-06-30
Reviewed by Timothy Hatcher.

  • UserInterface/Views/DOMTreeOutline.css: Adds a semi-opaque " = $0" to the selected element in the DOM tree.

(.dom-tree-outline li.selected > span::after):
(.dom-tree-outline:focus li.selected > span::after):

19:03 Changeset [186162] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebKit2

More Gtk/EFL fixing.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:


  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:


19:01 Changeset [186161] by commit-queue@webkit.org
  • 25 edits
    5 adds in trunk

Implement ECMAScript Internationalization API

Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2015-06-30
Reviewed by Benjamin Poulain.


Begin implementing the Intl apis behind ENABLE_INTL flag.
Create the base Intl namespace object.

  • Source/cmake/WebKitFeatures.cmake: add ENABLE_INTL flag


  • CMakeLists.txt: add IntlObject.cpp
  • Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: add IntlObject
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: add IntlObject
  • JavaScriptCore.xcodeproj/project.pbxproj: add IntlObject
  • runtime/CommonIdentifiers.h: add "Intl" name
  • runtime/IntlObject.cpp: Added.


  • runtime/IntlObject.h: Added.
  • runtime/JSGlobalObject.cpp: Add global Intl



Test: js/intl.html

  • Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag


  • Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag


  • Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag


  • wtf/FeatureDefines.h: add ENABLE_INTL flag


  • Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag


  • win/tools/vsprops/FeatureDefines.props: add ENABLE_INTL flag
  • win/tools/vsprops/FeatureDefinesCairo.props: add ENABLE_INTL flag


  • TestExpectations: Skip intl until enabled
  • js/intl-expected.txt: Added.
  • js/intl.html: Added.
  • js/script-tests/intl.js: Added.


18:51 Changeset [186160] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

scroll-snap-points do not work very well with mechanical scroll wheel events

Patch by Wenson Hsieh <whsieh@berkeley.edu> on 2015-06-30
Reviewed by Brent Fulgham.


Stateless scroll events generated by scrolling with a mechanical mouse wheel now trigger scroll
snapping after a fixed delay.

Test: platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html

  • platform/cocoa/ScrollController.h: Added member to track stateless scrolling.
  • platform/cocoa/ScrollController.mm: Added constant for delay for stateless scroll snapping.

(WebCore::ScrollController::processWheelEventForScrollSnapOnAxis): Triggers timer upon stateless scroll events.
(WebCore::ScrollController::horizontalScrollSnapTimerFired): Timer now handles stateless scrolling updates.
(WebCore::ScrollController::verticalScrollSnapTimerFired): See above.
(WebCore::ScrollController::beginScrollSnapAnimation): Handles stateless scroll snapping.


  • platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html: Added.
18:46 Changeset [186159] by simon.fraser@apple.com
  • 5 edits in trunk/Source

Fix Mac and Windows builds.


  • WebCoreSupport/AcceleratedCompositingContext.cpp:


  • WebView.cpp:



  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:


18:33 Changeset [186158] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.


18:30 Changeset [186157] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.

New tag.

18:15 Changeset [186156] by simon.fraser@apple.com
  • 6 edits in trunk/Source/WebCore

Try to fix Gtk and EFL builds.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:


  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:


  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:


  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
18:08 Changeset [186155] by simon.fraser@apple.com
  • 10 edits in trunk/Source

[iOS] Missing tiles inside position:fixed on scrolling

Reviewed by Tim Horton.

Layer flushing adjusts the coverage rect for tiled layers, but does so at times
when position:fixed layers are moved around by the scrolling tree. The computed
coverage rect then doesn't reflect the layer's on-screen position, causing missing

Fix by pushing the notion of being in a "stable state" onto FrameView, and passing
that state into the layer flush. When not in a stable state, flushing doesn't change
the visible and coverage rects for layers that are viewport-constrained.


  • page/FrameView.cpp:


  • page/FrameView.h: Remove some velocity-related data members that were unused.
  • platform/graphics/GraphicsLayer.h:


  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects): If this is a viewport-constrained
layer, and the viewport is not stable, don't touch the rects.

  • platform/graphics/ca/GraphicsLayerCA.h:


  • rendering/RenderLayerCompositor.cpp:



  • WebProcess/WebPage/ios/WebPageIOS.mm:


  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:


18:01 Changeset [186154] by simon.fraser@apple.com
  • 5 edits in trunk/Source/WebCore

Rename GraphicsLayer's allowsBackingStoreDetachment to isViewportConstrained

Reviewed by Tim Horton.

What GraphicsLayer really needs to know is whether some other thread/process
is moving its platform layers around behind its back, and this is is better
expressed as "isViewportConstrained" rather than "allowsBackingStoreDetachment".

The sense of the flag is flipped, and boolean logic adjusted accordingly.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setAllowsBackingStoreDetachment): Deleted.
(WebCore::GraphicsLayer::allowsBackingStoreDetachment): Deleted.

  • platform/graphics/ca/GraphicsLayerCA.cpp:


  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.cpp:


17:46 Changeset [186153] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL] Implement ewk_favicon_database_clear() API.

Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-30
Reviewed by Gyuyoung Kim.

We need to provide way to clear favicon data.

  • UIProcess/API/efl/ewk_favicon_database.cpp:


  • UIProcess/API/efl/ewk_favicon_database.h:
  • UIProcess/API/efl/ewk_favicon_database_private.h:
  • UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:


17:39 Changeset [186152] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Ignore viewport rect changes during zoom bouncing.

Reviewed by Benjamin Poulain.

When the user has pinch-zoomed past the maximum zoom scale and lets go of the screen,
we animate a bounce back to the maximum scale.

Suppress viewport rect updates during this bounce animation since we don't need them
anyway. This fixes an issue where we'd sometimes get a weird rect during the animation
and if could send that to the web process, causing it to generate tiles for a part of
the page that's not actually exposed.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateVisibleContentRects]):

17:36 Changeset [186151] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS.

Patch by Keith Miller <keith_miller@apple.com> on 2015-06-30
Reviewed by Filip Pizlo.

We were not checking if errors occurred in WTF::cryptographicallyRandomValuesFromOS.
We now buffer the data until enough bits of entropy exist to fill the buffer
rather than crash. Additionally, added two crash functions so we can distinguish
between the two reasons why we crashed in traces.

  • wtf/OSRandomSource.cpp:


17:17 Changeset [186150] by cdumez@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, rebaseline editing/style/unbold-in-bold.html on WK2.

  • platform/mac-wk2/editing/style/unbold-in-bold-expected.txt: Added.
17:16 Changeset [186149] by cdumez@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, revert bad wk2 baseline done in r186106.

  • platform/mac-wk2/editing/style: Removed.
17:08 Changeset [186148] by enrica@apple.com
  • 6 edits in trunk/Source/WebKit2

<rdar://problem/20655729> WebKit should heuristically exclude scrolling touch events from the user gesture category

Reviewed by Benjamin Poulain.

  • Platform/spi/ios/UIKitSPI.h:
  • Shared/WebEvent.h:


  • Shared/WebEventConversion.cpp:


  • Shared/ios/NativeWebTouchEventIOS.mm:


  • Shared/ios/WebTouchEventIOS.cpp:

Pipe isPotentialTap through.

16:33 Changeset [186147] by bshafiei@apple.com
  • 5 edits
    1 copy
    1 delete in tags/Safari-601.

Roll out r185936. rdar://problem/21597179

16:30 Changeset [186146] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.

Roll out r185939. rdar://problem/21597179

16:27 Changeset [186145] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.

Roll out r185951. rdar://problem/21597179

16:15 Changeset [186144] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.


16:10 Changeset [186143] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.

New tag.

15:58 Changeset [186142] by fpizlo@apple.com
  • 3 edits in trunk/PerformanceTests

Update the JetStream documentation to reflect the recent changes

Reviewed by Geoffrey Garen.

  • JetStream/create.rb: Bump the version.
  • JetStream/in-depth-TEMPLATE.html: Add cdjs documentation. Remove cordic documentation. Change documentation for splay and mandreel.
15:58 Changeset [186141] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: ProfileNode cleanup

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-30
Reviewed by Timothy Hatcher.

  • UserInterface/Models/ProfileNode.js:

Use Array.prototype.every instead of reduce.
Correct the name of a function to be what callers expect!

15:51 Changeset [186140] by clopez@igalia.com
  • 3 edits in trunk/Source/WebKit2

[GTK] [EFL] Unreviewed build fix after r186118.

Add if PLATFORM(COCOA) back.

  • WebProcess/WebProcess.cpp:


  • WebProcess/WebProcess.h:
15:21 Changeset [186139] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

CABackdropFilter should set windowServerAware to false

Reviewed by Simon Fraser.

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::PlatformCALayerCocoa): Set windowServerAware
to false on Mac (it's not available on iOS).

15:20 Changeset [186138] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: iOS 8: Profile Nodes not showing in JavaScript Timeline

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-30
Reviewed by Brian Burg.

  • UserInterface/Models/ScriptTimelineRecord.js:

For legacy backends, convert the startTime to the proper timestamp type.

15:19 Changeset [186137] by cdumez@apple.com
  • 3 edits in trunk/Source/WebCore

Rolling out r175171

Unreviewed, rolling out <http://trac.webkit.org/changeset/175171>. It
wasn't a huge win and Brady says it caused crash at

  • platform/network/cf/ResourceRequest.h:
  • platform/network/cocoa/ResourceRequestCocoa.mm:


15:19 Changeset [186136] by basile_clement@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Allow object allocation sinking through GetScope, GetExecutable and SkipScope nodes

Reviewed by Filip Pizlo.

  • dfg/DFGNode.h:


  • dfg/DFGObjectAllocationSinkingPhase.cpp:


  • dfg/DFGPromoteHeapAccess.h:


15:16 Changeset [186135] by cdumez@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, revert bad WK1 rebaseline done in r186106.

  • platform/mac/editing/style/unbold-in-bold-expected.txt:
15:00 Changeset [186134] by simon.fraser@apple.com
  • 4 edits in trunk/Source

Crash under _layoutForNodeHighlight: when inspecting espn.com

Reviewed by Joseph Pecoraro.

When inspecting espn.com, MobileSafari sometimes crashes, because
highlight.quads is empty. I was not able to quickly determine why.

Fix by bailing in this case.

  • WebInspector/WebNodeHighlightView.mm:

(-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):


When inspecting espn.com, MobileSafari sometimes crashes, because
highlight.quads is empty. I was not able to quickly determine why.

Fix by bailing in this case.

  • UIProcess/WKInspectorHighlightView.mm:

(-[WKInspectorHighlightView _layoutForNodeHighlight:]):

14:45 Changeset [186133] by mattbaker@apple.com
  • 24 edits
    1 add in trunk/Source

Web Inspector: Reduce rendering frames "Other" time by instrumenting compositing

Reviewed by Brian Burg.


  • inspector/protocol/Timeline.json:

New timeline record type for compositing events.


Added Inspector instrumentation for measuring CoreAnimation compositing time. We mark the start of a composite
event when the LayerFlushScheduler triggers a scheduled layer flush. InspectorController now exports a function
for marking the end of the composite event, which should be called during the CA transaction post-commit phase
(based on platform support). Lacking platform support, the event is considered complete after CoreAnimation
runloop observers have run.

  • inspector/InspectorController.cpp:


  • inspector/InspectorController.h:

New export for instrumentation in WebKit2.

  • inspector/InspectorInstrumentation.cpp:


  • inspector/InspectorInstrumentation.h:

Plumbing for new instrumentation.

  • inspector/InspectorTimelineAgent.cpp:


  • inspector/InspectorTimelineAgent.h:

New Composite event type and instrumentation.

  • page/FrameView.cpp:

Hook for start of compositing.

  • platform/spi/cocoa/QuartzCoreSPI.h:

New header include and interface declaration.


  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Controllers/TimelineManager.js:

Added handling for new Composite record type. Paint records with a parent Composite record
are flagged to simplify processing after the event hierarchy is unpacked.

  • UserInterface/Images/TimelineRecordComposite.svg: Added.

New composite record icon.

  • UserInterface/Models/LayoutTimelineRecord.js:

(WebInspector.LayoutTimelineRecord.prototype.get duringComposite): Added
Composite record support.

  • UserInterface/Models/RenderingFrameTimelineRecord.js:

(WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.get validRecordForTaskType):
Add compositing time when bucketing runloop tasks, ignoring Paint events that are
contained within a Composite event.

  • UserInterface/Views/LayoutTimelineOverviewGraph.js:

Add Composite records to paint timeline row.

  • UserInterface/Views/RenderingFrameTimelineView.js:

Small unrelated fix.

  • UserInterface/Views/TimelineIcons.css:

(.composite-record .icon):

  • UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar.timeline-record-type-layout.layout-timeline-record-composite > .segment):

  • UserInterface/Views/TimelineRecordTreeElement.js:

New styles and tree element icon.


  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:


  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

Added CA transaction post-commit handlers to instrument end of composite.

14:40 Changeset [186132] by bdakin@apple.com
  • 4 edits in trunk/Source

The bounds on InteractionInformationAtPosition should be more precise
-and corresponding-

Reviewed by Enrica Casucci and Simon Fraser.


Export absoluteContentQuad().

  • rendering/RenderBox.h:


For links, get the TextQuads from the Range, and for images, look at the
absoluteContentQuad(). All other items can continue to use absoluteBoundingBox.

  • WebProcess/WebPage/ios/WebPageIOS.mm:


14:37 Changeset [186131] by jond@apple.com
  • 2 edits in trunk/Tools

Added myself, Jonathan Davis, as a committer.

14:01 Changeset [186130] by jond@apple.com
  • 2 edits in trunk/Websites/webkit.org

Added WebKit feature status page to navigation.

13:31 Changeset [186129] by zalan@apple.com
  • 2 edits in trunk/Source/WebCore

Addressing post-review comments in r185756.

  • html/RubyTextElement.cpp:


13:03 Changeset [186128] by zalan@apple.com
  • 2 edits in trunk/Source/WebCore

Addressing post-review comments in r185916

  • platform/LayoutUnit.h:


12:53 Changeset [186127] by mrajca@apple.com
  • 2 edits in trunk/Source/WebCore

MediaSession: Use setSessionInternal to set the default media session in HTMLMediaElement's constructor

Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:


12:48 Changeset [186126] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Disable Spintracer when getting the list of plug-ins

Reviewed by Tim Horton.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:


12:12 Changeset [186125] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Java Plugin cannot launch JavaUpdater.app after renaming

Reviewed by Tim Horton.

Check for both "JavaUpdater.app" and "Java Updater.app".

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:


11:26 Changeset [186124] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit/mac

Remove the WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS ifdefs now that this is always true

Reviewed by Dan Bernstein.

  • Misc/WebDownload.h:
  • WebView/WebFrameLoadDelegate.h:
  • WebView/WebPolicyDelegate.h:
  • WebView/WebResourceLoadDelegate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.h:
  • postprocess-headers.sh:
11:10 Changeset [186123] by mrajca@apple.com
  • 5 edits in trunk/Source/WebCore

Media Session: implement algorithm for updating a media element's session (6.1)

Reviewed by Darin Adler.

In addition to storing a pointer to the new media session, we now:

  • pause the media element if it is 'active' in the current media session
  • remove the media element from the current media session
  • release the current media session if there are no more active media elements
  • set the default media session if the new media session is null
  • update the 'kind' attribute to match the kind of the new media session
  • Modules/mediasession/MediaSession.cpp:


  • Modules/mediasession/MediaSession.h:
  • html/HTMLMediaElement.cpp:


  • html/HTMLMediaElement.h:
11:08 Changeset [186122] by cdumez@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Avoid taking a useless / blank navigation snapshot when navigating after restoring sessionState

Reviewed by Darin Adler.

We currently take a useless / blank navigation snapshot when navigating
after restoring the back / forward list from a sessionState object.
This is because we get a current HistoryItem from the sessionState
which we have never really navigated to. We then take a navigation
snapshot for the current HistoryItem when navigating away as we usually
do. However, in this case, the HistoryItem was imported and there is
nothing to snapshot.

Taking this snapshot is not only wasteful, it can also potentially
overwrite the snapshot that was set by the client using
WKWebView._saveBackForwardSnapshotForItem() SPI.

To address the problem, this patch suppresses navigation snapshotting
after restoring the back / forward list from a session state and until
the next load is committed.

  • UIProcess/WebPageProxy.cpp:


  • UIProcess/WebPageProxy.h:
10:32 Changeset [186121] by bfulgham@apple.com
  • 2 edits in trunk/Source/WebKit/win

[Win] webViewAddMessageToConsole always gets 1 for isError

Reviewed by Zalan Bujtas.

  • WebCoreSupport/WebChromeClient.cpp:

(messageIsError): Added.
(WebChromeClient::addMessageToConsole): Only pass true for
isError if the message is an error message.

10:20 Changeset [186120] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: iOS 8: Uncaught Exception expanding Object Prototype

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-30
Reviewed by Timothy Hatcher.

  • UserInterface/Views/ObjectTreePropertyTreeElement.js:


  • UserInterface/Views/ObjectTreeView.js:

We are supposed to receive value properties for proto properties
so that we can immediately start showing information about the property.
When that is not the case, which appeared to only be on legacy
backends for the top level prototype, just ignore it.

10:16 Changeset [186119] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Misc. Timeline cleanup

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-30
Reviewed by Timothy Hatcher.

  • UserInterface/Models/Timeline.js:

Nobody listens for this event. Just remove it.

  • UserInterface/Models/TimelineRecording.js:

Avoiding doing multiple lookups.

  • UserInterface/Views/TimelineDataGridNode.js:
  • UserInterface/Views/TimelineRecordingContentView.js:


  • UserInterface/Views/TimelineView.js:

Eliminate some unnecessary deletes.

10:12 Changeset [186118] by andersca@apple.com
  • 13 edits in trunk/Source

Get rid of unused WKSI functions

Reviewed by Tim Horton.


  • platform/graphics/cg/PathCG.cpp:

Just call CGPathAddRoundedRect directly.

  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:


  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Deleted.


  • UIProcess/API/Cocoa/WKWebView.mm:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Deleted.

  • WebProcess/WebProcess.cpp:


  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:


09:39 Changeset [186117] by bfulgham@apple.com
  • 2 edits in trunk/Tools

Unreviewed build fix.

  • Scripts/update-webkit-dependency: Try to build even if we cannot connect

to developer.apple.com to get update libraries.

09:31 Changeset [186116] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.


09:27 Changeset [186115] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.

New tag.

04:26 Changeset [186114] by peavo@outlook.com
  • 3 edits in trunk/Source/WebKit/win

[WinCairo] Compile error, WebEditorClient::didApplyStyle() should not have any parameters.

Reviewed by Csaba Osztrogonác.

  • WebCoreSupport/WebEditorClient.cpp:


  • WebCoreSupport/WebEditorClient.h:
02:53 Changeset [186113] by calvaris@igalia.com
  • 4 edits in trunk

[Streams API] Finish pulling must always be done asynchronously as it is the expected promise behavior (according to the spec)

Reviewed by Darin Adler.


Current tests cover the case already.

  • Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::pull): Call finishPull() in a postTask to delay it and simulate the promise


  • streams/reference-implementation/readable-stream-expected.txt: Updated expectation to PASS
02:27 Changeset [186112] by calvaris@igalia.com
  • 5 edits in trunk

[Streams API] Synced bad strategy test with reference implementation

Reviewed by Darin Adler.


Current tests cover the case.

  • bindings/js/ReadableJSStream.cpp:

(WebCore::ReadableJSStream::retrieveChunkSize): Check for negative size then running the JavaScript function.


  • streams/reference-implementation/bad-strategies-expected.txt:
  • streams/reference-implementation/bad-strategies.html: There are three tests that are merged into one and a

fourth check is added. Updated expectations accordingly.

00:50 Changeset [186111] by youenn.fablet@crf.canon.fr
  • 6 edits in trunk/Source/WebCore

[Streams API] Remove ReadableStream.getReader() custom binding

Reviewed by Darin Adler.

Covered by existing tests.

  • Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::getReader): Updated to take an exception.

  • Modules/streams/ReadableStream.h:
  • Modules/streams/ReadableStream.idl: Updated to remove custom binding.
  • bindings/js/JSReadableStreamCustom.cpp:

(WebCore::JSReadableStream::getReader): Deleted.

  • bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::constructJSReadableStreamReader): Updated to pass an exception to getReader.

00:17 Changeset [186110] by philn@webkit.org
  • 2 edits in trunk

[CMake] Error when gst-plugins-base is missing is too confusing

Reviewed by Carlos Garcia Campos.

  • Source/cmake/OptionsGTK.cmake: Error out if the required

GStreamer libraries are not found on the host.

Note: See TracTimeline for information about the timeline view.