Timeline


and

01/23/17: Today

12:29 Changeset [211050] by timothy@hatcher.name
  • 2 edits in trunk/Source/ThirdParty

gtest fails to link on Linux due to missing -lpthread
https://bugs.webkit.org/show_bug.cgi?id=167313

  • gtest/CMakeLists.txt: Remove find_package(Threads) that was added in my last commit.

This is assumed to already happen in the platform cmake options file.

12:21 Changeset [211049] by antti@apple.com
  • 5 edits in trunk/Source/WebKit2

Use priorities in speculative revalidation
https://bugs.webkit.org/show_bug.cgi?id=167314

Reviewed by Chris Dumez.

We currently do all speculative cache operations with 'Medium' priority
and network operations with 'Low'. We should use the actual request priorities instead.

  • NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::constructRevalidationRequest):

Use priority when constructing validation request.

(WebKit::NetworkCache::SpeculativeLoadManager::retrieveEntryFromStorage):

Use priority when retrieving from cache.

(WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):

  • NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h:
  • NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:

(WebKit::NetworkCache::SubresourceInfo::encode):
(WebKit::NetworkCache::SubresourceInfo::decode):

Save and restore the priority.

  • NetworkProcess/cache/NetworkCacheSubresourcesEntry.h:

(WebKit::NetworkCache::SubresourceInfo::SubresourceInfo):
(WebKit::NetworkCache::SubresourceInfo::priority):

12:15 Changeset [211048] by jbedard@apple.com
  • 2 edits in trunk/Tools

svn-create-patch should emit properties when files are moved or copied
https://bugs.webkit.org/show_bug.cgi?id=167264

Reviewed by Daniel Bates.

  • Scripts/svn-create-patch:

(manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.

11:32 Changeset [211047] by commit-queue@webkit.org
  • 4 edits in trunk

[WebRTC] Filter libwebrtc link flags
https://bugs.webkit.org/show_bug.cgi?id=167287

Patch by Youenn Fablet <youenn@apple.com> on 2017-01-23
Reviewed by Alex Christensen.

Source/ThirdParty/libwebrtc:

  • CMakeLists.txt:

Tools:

  • Scripts/webkitpy/libwebrtc/generate_cmake.py:

(CMakeGenerator._compute_link_flags):
(CMakeGenerator._compute_link_flags.keep_flag):
(CMakeGenerator._generate_compile_target_options):

11:32 Changeset [211046] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk

[WebRTC] Make VP8 optional in libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=167257

Patch by Youenn Fablet <youennf@gmail.com> on 2017-01-23
Reviewed by Darin Adler.

Source/ThirdParty/libwebrtc:

Reusing strategy used to have VP9 optional for VP8 codec.

  • CMakeLists.txt: Updated tocompile and link vp8_noop.cc
  • Source/webrtc/media/engine/webrtcvideoengine2.cc:
  • Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:
  • Source/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:
  • Source/webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc: Added.
  • Source/webrtc/video/video_encoder.cc:

Tools:

  • Scripts/webkitpy/libwebrtc/generate_cmake.py:

(CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.

11:23 Changeset [211045] by jer.noble@apple.com
  • 22 edits
    2 moves in trunk

Source/WebCore:
REGRESSION (r208149): Video details does not apear and missing scrubber in Control Center
https://bugs.webkit.org/show_bug.cgi?id=167233

Reviewed by Alex Christensen.

Test: In TestWebKitAPI, NowPlayingControlsTests.NowPlayingControlsIOS

In r208149, we introduced a new media type, Video, and renamed the old type to
VideoAudio (to be able to distinguish between video-with-audio and silent-video).
But we missed one place where that type needs to be renamed.

For testing purposes, overload methods from PlatformMediaSessionManager which WebKit2 uses
to report the current now playing session and it's information.

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::nowPlayingEligibleSession):
(WebCore::MediaSessionManageriOS::updateNowPlayingInfo):

Source/WebKit2:
Video details does not apear and missing scrubber in Control Center
https://bugs.webkit.org/show_bug.cgi?id=167233

Reviewed by Alex Christensen.

Make requestActiveNowPlayingSessionInfo() and handleActiveNowPlayingSessionInfoResponse()
work in PLATFORM(IOS).

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _requestActiveNowPlayingSessionInfo]):
(-[WKWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestActiveNowPlayingSessionInfo):
(WebKit::WebPageProxy::handleActiveNowPlayingSessionInfoResponse):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::handleActiveNowPlayingSessionInfoResponse):

  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::requestActiveNowPlayingSessionInfo):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::requestActiveNowPlayingSessionInfo): Deleted.

Tools:
Video details does not apear and missing scrubber in Control Center
https://bugs.webkit.org/show_bug.cgi?id=167233

Reviewed by Alex Christensen.

Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
NowPlayingControlTests for iOS.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:

(-[NowPlayingTestWebView setWindowVisible:]):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
  • TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
  • TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
  • TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.

(SOFT_LINK_CLASS):
(-[TestMessageHandler addMessage:withHandler:]):
(-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
(simulated_forceClickAssociatedEventsMask):
(-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
(-[TestWKWebViewHostWindow isKeyWindow]):
(-[TestWKWebViewHostWindow makeKeyWindow]):
(-[TestWKWebViewHostWindow resignKeyWindow]):
(-[TestWKWebView initWithFrame:]):
(-[TestWKWebView initWithFrame:configuration:]):
(-[TestWKWebView _setUpTestWindow:]):
(-[TestWKWebView performAfterReceivingMessage:action:]):
(-[TestWKWebView loadTestPageNamed:]):
(-[TestWKWebView synchronouslyLoadTestPageNamed:]):
(-[TestWKWebView stringByEvaluatingJavaScript:]):
(-[TestWKWebView waitForMessage:]):
(-[TestWKWebView performAfterLoading:]):
(-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
(-[TestWKWebView typeCharacter:]):

10:45 Changeset [211044] by timothy@hatcher.name
  • 2 edits in trunk/Source/ThirdParty

gtest fails to link on Linux due to missing -lpthread
https://bugs.webkit.org/show_bug.cgi?id=167313

Reviewed by Alex Christensen.

  • gtest/CMakeLists.txt: Add call to find_package(Threads) before testing CMAKE_USE_PTHREADS_INIT.

Without the find_package call, CMAKE_USE_PTHREADS_INIT was always false for me. Also explicitly
define GTEST_HAS_PTHREAD to 0 when CMAKE_USE_PTHREADS_INIT is false to prevent gtest-port.h from
setting GTEST_HAS_PTHREAD based on the platform.

10:45 Changeset [211043] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

IntlObject uses JSArray::tryCreateUninitialized in an unsafe way
https://bugs.webkit.org/show_bug.cgi?id=167288

Reviewed by Filip Pizlo.

Refactored the following "create" methods into a "tryCreate" method and a
"create" wrapper: JSArray::create(), Butterfly::create() and
createArrayButterfly().

Changed IntlObject.cpp to use JSArray::tryCreate() as it is simpler to use
by not requiring the caller to be GC savey. The performance benefits of
tryCreateUninitialized() are not needed by the IntlObject c++ code.

Did not add a new test as the bug caused LayoutTests/js/intl.html to fail
reliably with the JSC option values scribbleFreeCells=true,
collectContinuously=true and JSC_useGenerationalGC=false.

  • runtime/Butterfly.h:
  • runtime/ButterflyInlines.h:

(JSC::Butterfly::tryCreate): Added.
(JSC::Butterfly::create):

  • runtime/IntlObject.cpp:

(JSC::canonicalizeLocaleList):
(JSC::lookupSupportedLocales):
(JSC::intlObjectFuncGetCanonicalLocales):

  • runtime/JSArray.h:

(JSC::createContiguousArrayButterfly): Deleted.
(JSC::tryCreateArrayButterfly): Added.
(JSC::createArrayButterfly):
(JSC::JSArray::tryCreate): Added.
(JSC::JSArray::create):

10:39 Changeset [211042] by cdumez@apple.com
  • 12 edits in trunk/Source

REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
https://bugs.webkit.org/show_bug.cgi?id=167308
<rdar://problem/30144964>

Unreviewed, do a partial revert of r211033 to fix assertion.

Source/WebCore:

No new tests, already covered by:
fullscreen/exit-full-screen-iframe.html

  • dom/Document.cpp:

(WebCore::Document::webkitExitFullscreen):

  • page/ChromeClient.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::exitFullScreenForElement):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::exitFullScreenForElement):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exitFullScreenForElement):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
10:30 Changeset [211041] by megan_gardner@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r210941): LayoutTest scrollingcoordinator/ios/sync-layer-positions-after-scroll.html failing
https://bugs.webkit.org/show_bug.cgi?id=167262

Unreviewed test gardening.

Fix to interpolation code caused a different result.

  • scrollingcoordinator/ios/sync-layer-positions-after-scroll-expected.txt:
10:20 Changeset [211040] by gns@gnome.org
  • 2 edits in trunk/Source/WebCore

[GTK] asserting on unknown locale for hyphenation is wrong
https://bugs.webkit.org/show_bug.cgi?id=167312

Reviewed by Carlos Garcia Campos.

The fact that we hit the assert on a test called 'hyphenation-unknown-locale' is already
a strong indication we should not have it. In addition to that, Carlos Lopez pointed out
a similar assert was removed from the Mac codepaths when the test was introduced.

  • platform/text/hyphen/HyphenationLibHyphen.cpp:

(WebCore::lastHyphenLocation): early return when a locale that is not available is provided
for hyphenation, instead of asserting.

09:40 Changeset [211039] by cdumez@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix the iOS build after r211033.

  • dom/Node.cpp:

(WebCore::Node::defaultEventHandler):

03:28 Changeset [211038] by gns@gnome.org
  • 2 edits in trunk/Source/WebKit2

urlParserEnabled parameter is only encoded for COCOA ports
https://bugs.webkit.org/show_bug.cgi?id=167238

Reviewed by Alex Christensen.

This leads to URLParser being enabled on the UI process, since it is
the default, but disabled on the WebProcess, which is the default for
WebProcessCreationParameters, casuing asserts like on tests such as these
due to differences in parsing:

  • fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html
  • fast/loader/window-open-to-invalid-url-calls-policy-delegate.html
  • http/tests/inspector/network/copy-as-curl.html
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): encode urlParserEnabled
(WebKit::WebProcessCreationParameters::decode): decode urlParserEnabled

02:41 Changeset [211037] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

JavaScriptCore has a weak external symbol in it
https://bugs.webkit.org/show_bug.cgi?id=167282

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-01-23
Reviewed by Yusuke Suzuki.

  • debugger/Debugger.cpp:

(JSC::Debugger::ProfilingClient::~ProfilingClient):

  • debugger/Debugger.h:

Avoid possible weak external symbol.

01:54 Changeset [211036] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Remove allowWindowOpenWithoutUserGesture setting
https://bugs.webkit.org/show_bug.cgi?id=167301

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-01-23
Reviewed by Darin Adler.

Source/WebCore:

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::allowPopUp):

  • page/Settings.in:

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Use the equivalent existing setting.

01/22/17: Yesterday

23:28 Changeset [211035] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebCore

Database file not removed for origins after deleting all databases
https://bugs.webkit.org/show_bug.cgi?id=167281

Reviewed by Darin Adler.

When DatabaseTracker::deleteDatabasesModifiedSince() is called with a min time, all databases for every origin
are deleted. For each origin if all databases are removed DatabaseTracker::deleteOrigin() is called to remove
also the origin database file. However, DatabaseTracker::deleteOrigin() returns early if the origin doesn't have
databases and in this particular case it never has databases, because we have just removed them.

This will be covered by GTK+ unit tests.

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteDatabasesModifiedSince): Instead of removing the databases while iterating
them, add the ones to be removed to a vector. If after the iteration all databases should be removed call
DatabaseTracker::deleteOrigin() to ensure both the databases and the database file are removed for the origin,
otherwhise call DatabaseTracker::deleteDatabase() for every database to delete.

23:25 Changeset [211034] by mcatanzaro@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] Update Safari version in user agent
https://bugs.webkit.org/show_bug.cgi?id=167290

Reviewed by Carlos Garcia Campos.

Update Safari version from 10 to 11.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::buildUserAgentString):

22:24 Changeset [211033] by darin@apple.com
  • 135 edits in trunk/Source

Remove PassRefPtr from "page" directory of WebCore, also deploy references
https://bugs.webkit.org/show_bug.cgi?id=167224

Reviewed by Chris Dumez.

Source/WebCore:

  • Modules/fetch/DOMWindowFetch.cpp:

(WebCore::DOMWindowFetch::fetch): Use DOMWindow::document instead of
scriptExecutionContext.

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::databaseExceededQuota): Pass a reference.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
Pass a reference.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot): Pass a reference.

  • dom/Document.cpp:

(WebCore::Document::childrenChanged): Pass a reference. Also made the
didReceiveDocType code unconditional instead of iOS-only.
(WebCore::Document::platformSuspendOrStopActiveDOMObjects): Ditto.
(WebCore::Document::updateViewportArguments): Ditto.
(WebCore::Document::setFocusedElement): Ditto.
(WebCore::Document::createDOMWindow): Ditto.
(WebCore::Document::takeDOMWindowFrom): Ditto.
(WebCore::Document::requestFullScreenForElement): Ditto.
(WebCore::Document::webkitExitFullscreen): Ditto.

  • dom/Element.cpp:

(WebCore::Element::focus): Ditto.
(WebCore::Element::blur): Ditto.
(WebCore::Element::dispatchFocusEvent): Ditto.
(WebCore::Element::dispatchBlurEvent): Ditto.

  • dom/Node.cpp:

(WebCore::Node::defaultEventHandler): Ditto.

  • editing/EditorCommand.cpp:

(WebCore::executePrint): Ditto.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setFocusedElementIfNeeded): Ditto.

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Ditto.
(WebCore::CachedFrame::CachedFrame): Ditto.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::handleDOMActivateEvent): Ditto.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isKeyboardFocusable): Pass a reference,
and also rewrote to use && for clarity.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::supportsFullscreen): Pass a reference.

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::defaultEventHandler): Ditto.
(WebCore::SpinButtonElement::releaseCapture): Ditto.

  • html/shadow/mac/ImageControlsButtonElementMac.cpp:

(WebCore::ImageControlsButtonElementMac::defaultEventHandler): Ditto.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::showContextMenu): Ditto.
(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent): Ditto.

  • loader/EmptyClients.cpp:

(WebCore::EmptyChromeClient::createPopupMenu): Updated to take reference.
(WebCore::EmptyChromeClient::createSearchPopupMenu): Ditto.
(WebCore::EmptyChromeClient::createColorChooser): Ditto.

  • loader/EmptyClients.h: Ditto.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm): Pass a reference.
(WebCore::FrameLoader::commitProvisionalLoad): Ditto.
(WebCore::FrameLoader::closeAndRemoveChild): Take a reference.
(WebCore::FrameLoader::detachFromParent): Pass a reference.
(WebCore::FrameLoader::dispatchBeforeUnloadEvent): Ditto.
(WebCore::createWindow): Ditto.

  • loader/FrameLoader.h: Updated for the above.
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy): Pass a reference.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota): Ditto.

  • loader/appcache/ApplicationCacheGroup.h: Return a reference from origin.
  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::calculateQuotaForOrigin): Take a reference.
(WebCore::ApplicationCacheStorage::calculateRemainingSizeForOriginExcludingCache):
Ditto.
(WebCore::ApplicationCacheStorage::store): Pass a reference.
(WebCore::ApplicationCacheStorage::checkOriginQuota): Updated since origin
now returns areference.

  • loader/appcache/ApplicationCacheStorage.h: Updated for the above.
  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData): Pass a reference.

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isKeyboardFocusable): Ditto.

  • page/Chrome.cpp:

(WebCore::Chrome::Chrome): Moved initialization of data members to the
class definition.
(WebCore::Chrome::contentsSizeChanged): Take a reference.
(WebCore::Chrome::createWindow): Ditto.
(WebCore::Chrome::runBeforeUnloadConfirmPanel): Ditto.
(WebCore::Chrome::runJavaScriptAlert): Ditto.
(WebCore::Chrome::runJavaScriptConfirm): Ditto.
(WebCore::Chrome::runJavaScriptPrompt): Ditto.
(WebCore::Chrome::setStatusbarText): Ditto.
(WebCore::Chrome::print): Ditto.
(WebCore::Chrome::createColorChooser): Ditto.
(WebCore::Chrome::createPopupMenu): Ditto.
(WebCore::Chrome::createSearchPopupMenu): Ditto.
(WebCore::Chrome::didReceiveDocType): Ditto. Also made unconditional, but
empty for non-iOS platforms.
(WebCore::Chrome::registerPopupOpeningObserver): Take a reference.
(WebCore::Chrome::unregisterPopupOpeningObserver): Ditto.

  • page/Chrome.h: Updated for the above.
  • page/ChromeClient.h: Take references. Also updated some arguments from

Node to Element.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::handleContextMenuEvent): Take a reference.
(WebCore::ContextMenuController::showContextMenu): Ditto.
(WebCore::ContextMenuController::maybeCreateContextMenu): Ditto. Also use
make_unique instead of unique_ptr plus new.
(WebCore::openNewWindow): Ditto.
(WebCore::insertUnicodeCharacter): Ditto.
(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
(WebCore::ContextMenuController::showContextMenuAt): Ditto.
(WebCore::ContextMenuController::showImageControlsMenu): Ditto.

  • page/ContextMenuController.h: Updated for the above.
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::fired): Pass a reference.

  • page/DOMWindow.cpp:

(WebCore::PostMessageTimer::PostMessageTimer): Take Ref&& instead of
PassRefPtr.
(WebCore::DOMWindow::adjustWindowRect): Use a reference.

(WebCore::DOMWindow::allowPopUp): Ditto. Also rewrite to use
instead

of successive if statements.
(WebCore::DOMWindow::canShowModalDialog): Ditto.
(WebCore::DOMWindow::DOMWindow): Ditto.
(WebCore::DOMWindow::didSecureTransitionTo): Ditto.
(WebCore::DOMWindow::registerProperty): Ditto.
(WebCore::DOMWindow::unregisterProperty): Ditto.
(WebCore::DOMWindow::postMessageTimerFired): Merge with the function
immediately followed, called only from here.
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck): Deleted.
(WebCore::DOMWindow::print): Pass a reference.
(WebCore::DOMWindow::alert): Ditto.
(WebCore::DOMWindow::confirm): Ditto.
(WebCore::DOMWindow::prompt): Ditto.
(WebCore::DOMWindow::setStatus): Ditto.
(WebCore::DOMWindow::setDefaultStatus): Ditto.
(WebCore::DOMWindow::moveBy): Ditto.
(WebCore::DOMWindow::moveTo): Ditto.
(WebCore::DOMWindow::resizeBy): Ditto.
(WebCore::DOMWindow::resizeTo): Ditto.
(WebCore::DOMWindow::clearTimeout): Ditto.
(WebCore::DOMWindow::incrementScrollEventListenersCount): Ditto.
(WebCore::DOMWindow::decrementScrollEventListenersCount): Ditto.
(WebCore::DOMWindow::showModalDialog): Ditto.

  • page/DOMWindow.h: Updated for the above. ALso made functions private

and final.

  • page/DOMWindowProperty.cpp:

(WebCore::DOMWindowProperty::DOMWindowProperty): Pass a reference.
(WebCore::DOMWindowProperty::~DOMWindowProperty): Ditto.
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInCachedFrame): Ditto.
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInFrame): Ditto.

  • page/DebugPageOverlays.cpp:

(WebCore::RegionOverlay::create): Return RefPtr instead of PassRefPtr.
(WebCore::RegionOverlay::~RegionOverlay): Pass a reference.
(WebCore::DebugPageOverlays::showRegionOverlay): Ditto.
(WebCore::DebugPageOverlays::hideRegionOverlay): Ditto.

  • page/DragController.cpp:

(WebCore::DragController::dragExited): Pass a reference.
(WebCore::DragController::performDragOperation): Ditto.
(WebCore::DragController::concludeEditDrag): Ditto.
(WebCore::DragController::tryDHTMLDrag): Ditto.

  • page/EventHandler.cpp: Replaced OptionalCursor with std::optional<Cursor>.

(WebCore::EventHandler::updateCursor): Refactor into two functions so we
can share more code with selectCursor.
(WebCore::EventHandler::selectCursor): Updated to use std::optional.
(WebCore::EventHandler::handleMouseMoveEvent): Use the new updateCursor.
(WebCore::EventHandler::startPanScrolling): Use a reference.
(WebCore::EventHandler::updateDragAndDrop): Ditto.
(WebCore::EventHandler::cancelDragAndDrop): Ditto.
(WebCore::EventHandler::performDragAndDrop): Ditto.
(WebCore::EventHandler::setCapturingMouseEventsElement): Take a raw pointer
instead of a PassRefPtr.
(WebCore::EventHandler::dispatchMouseEvent): Use a reference.
(WebCore::EventHandler::updateDragStateAfterEditDragIfNeeded): Ditto.
(WebCore::EventHandler::isKeyboardOptionTab): Ditto.
(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult): Ditto.
(WebCore::EventHandler::tabsToLinks): Ditto.

  • page/EventHandler.h: Updated for the above.
  • page/FocusController.cpp:

(WebCore::FocusController::setFocusedFrame): Take pointer instead
of PassRefPtr.
(WebCore::FocusController::setFocusedElement): Take reference instead of
PassRefPtr.

  • page/FocusController.h: Updated for the above changes.
  • page/FrameTree.cpp:

(WebCore::FrameTree::transferChild): Deleted. Unused function.
(WebCore::FrameTree::appendChild): Merged with the following function
since it's now only used here. Take reference instead of PassRefPtr.
(WebCore::FrameTree::actuallyAppendChild): Deleted.
(WebCore::FrameTree::removeChild): Take reference instead of pointer.
Use move instead of trickier swap.

  • page/FrameTree.h: Updated for the above.
  • page/FrameView.cpp:

(WebCore::FrameView::setContentsSize): Use a reference.

  • page/MainFrame.cpp:

(WebCore::MainFrame::dropChildren): Ditto.

  • page/Page.cpp:

(WebCore::Page::scrollingCoordinator): Ditto.

  • page/PageOverlay.cpp:

(WebCore::PageOverlay::fadeAnimationTimerFired): Ditto.

  • page/PageOverlayController.cpp:

(WebCore::PageOverlayController::installPageOverlay): Take reference
instead of PassRefPtr.
(WebCore::PageOverlayController::uninstallPageOverlay): Take reference
intead of pointer.

  • page/PageOverlayController.h: Updated for the above.
  • page/PageSerializer.cpp:

(WebCore::PageSerializer::PageSerializer): Moved most initialization to the
class definition.
(WebCore::PageSerializer::serialize): Use reference.
(WebCore::PageSerializer::serializeFrame): Use initializer list instead of
constructor for resource.
(WebCore::PageSerializer::serializeCSSStyleSheet): Ditto.
(WebCore::PageSerializer::addImageToResources): Ditto.

  • page/PageSerializer.h: Removed constructors from PageSerializer::Resource

struct since structures don't really need them. Updated for the above.
Changed SerializerMarkupAccumulator into a nested class.

  • page/PerformanceEntry.h:

(WebCore::PerformanceEntry::startTimeCompareLessThan): Use const RefPtr&
instead of PassRefPtr to compare RefPtr in place.

  • page/PerformanceUserTiming.cpp:

(WebCore::insertPerformanceEntry): Take Ref&& instead of PassRefPtr.

  • page/ResourceUsageOverlay.cpp:

(WebCore::ResourceUsageOverlay::~ResourceUsageOverlay): Use refrence.
(WebCore::ResourceUsageOverlay::initialize): Ditto.

  • page/animation/AnimationBase.h: Removed unneeded include.
  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::clear): Use reference.
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): Ditto.
(WebCore::AnimationControllerPrivate::addEventToDispatch): Use the
append function instead of a hand-written alternative.
(WebCore::AnimationControllerPrivate::addElementChangeToDispatch):
Take a reference rather than a Ref&& since no caller is passing ownership.

  • page/animation/AnimationControllerPrivate.h: Updated for the above.
  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc): Return RefPtr instead of PassRefPtr.
(WebCore::blendFilter): Ditto.
(WebCore::crossfadeBlend): Ditto.

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions): Updated to use
animationForProperty, which returns a raw pointer.
(WebCore::CompositeAnimation::animationForProperty): Renamed from
getAnimationForProperty and changed to return raw pointer instead
of PassRefPtr.

  • page/animation/CompositeAnimation.h: Updated for the above.
  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::onAnimationEnd): Use animationForProperty.
(WebCore::ImplicitAnimation::sendTransitionEvent): Pass reference.

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::sendAnimationEvent): Ditto.

  • page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::tabsToAllFormControls): Take reference.
(WebCore::EventHandler::createDraggingDataTransfer): Return Ref.

  • page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::tabsToAllFormControls): Ditto.
(WebCore::EventHandler::createDraggingDataTransfer): Ditto.

  • page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::tabsToAllFormControls): Ditto.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::createDraggingDataTransfer): Ditto.
(WebCore::EventHandler::tabsToAllFormControls): Ditto.
(WebCore::EventHandler::platformPrepareForWheelEvents): Ditto.

  • page/mac/ServicesOverlayController.h: Take Ref&& for ranges instead

of PassRefPtr. Use references.

  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::createForSelection): Ditto.
(WebCore::ServicesOverlayController::Highlight::createForTelephoneNumber): Ditto.
(WebCore::ServicesOverlayController::Highlight::Highlight): Ditto.
(WebCore::ServicesOverlayController::buildPotentialHighlightsIfNeeded): Ditto.
(WebCore::ServicesOverlayController::buildPhoneNumberHighlights): Ditto.
(WebCore::ServicesOverlayController::buildSelectionHighlight): Ditto.
(WebCore::ServicesOverlayController::highlightsAreEquivalent): Ditto.
(WebCore::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight): Ditto.
(WebCore::ServicesOverlayController::handleClick): Ditto.

  • page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]):
Take a reference instead of PassRefPtr.
(WebCore::TextIndicatorWindow::setTextIndicator): Updated for the above.

  • page/scrolling/AsyncScrollingCoordinator.h: Use Ref&& and RefPtr intead

of PsasRefPtr.

  • page/scrolling/ScrollLatchingState.cpp:

(WebCore::ScrollLatchingState::ScrollLatchingState): Initialize data members
in class definition.
(WebCore::ScrollLatchingState::setWheelEventElement): Use raw pointer instead
of PassRefPtr.
(WebCore::ScrollLatchingState::setPreviousWheelScrolledElement): Use raw
pointer instead of RefPtr&&.
(WebCore::ScrollLatchingState::setScrollableContainer): Use raw pointer instead
of PassRefPtr.

  • page/scrolling/ScrollLatchingState.h: Updated for the above.
  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::cloneAndReset): Use Ref instead of PassRefPtr.
(WebCore::ScrollingStateNode::appendChild): Use Ref&& instead of PassRefPtr.

  • page/scrolling/ScrollingStateNode.h: Updated for the above.
  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::createNode): Use Ref instead of PassRefPtr.
(WebCore::ScrollingStateTree::attachNode): Updated for the abve.
(WebCore::ScrollingStateTree::commit): Ditto.

  • page/scrolling/ScrollingStateTree.h: Ditto.
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode): Use reference.

  • page/scrolling/ScrollingTree.h: Return Ref instead of PassRefPtr.
  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::appendChild): Take Ref&& instead of PassRefPtr.
(WebCore::ScrollingTreeNode::removeChild): Take reference instead of pointer.

  • page/scrolling/ScrollingTreeNode.h: Updated for the above.
  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::ThreadedScrollingTree): Take reference
instead of pointer.

  • page/scrolling/ThreadedScrollingTree.h: Updated for the above.
  • page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::ScrollingCoordinatorIOS): Pass reference.

  • page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::create): Take a reference.
(WebCore::ScrollingTreeIOS::ScrollingTreeIOS): Ditto.
(WebCore::ScrollingTreeIOS::createScrollingTreeNode): Return Ref instead of
PassRefPtr.

  • page/scrolling/ios/ScrollingTreeIOS.h: Updated for the above.
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac): Use reference.

  • page/scrolling/mac/ScrollingTreeMac.cpp:

(ScrollingTreeMac::create): Take a reference.
(ScrollingTreeMac::ScrollingTreeMac): Ditto.
(ScrollingTreeMac::createScrollingTreeNode): Return a Ref instead of a
PassRefPtr.

  • page/scrolling/mac/ScrollingTreeMac.h: Updated for the above.
  • page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::tabsToAllFormControls): Take reference.
(WebCore::EventHandler::createDraggingDataTransfer): Return Ref.

  • platform/Cursor.h: Rearranged the header a bit. Got rid of the explicit

copy constructor, assignment operator, and destructor. Using the ones
that the compiler automatically generates will work for all platforms and
we then also get move constructor and move assignment operator.

  • platform/efl/CursorEfl.cpp:

(WebCore::Cursor::Cursor): Deleted.
(WebCore::Cursor::~Cursor): Deleted.
(WebCore::Cursor::operator=): Deleted.

  • platform/gtk/CursorGtk.cpp:

(WebCore::Cursor::Cursor): Deleted.
(WebCore::Cursor::operator=): Deleted.
(WebCore::Cursor::~Cursor): Deleted.

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::Cursor): Deleted.
(WebCore::Cursor::operator=): Deleted.
(WebCore::Cursor::~Cursor): Deleted.

  • platform/win/CursorWin.cpp:

(WebCore::SharedCursor::SharedCursor): Moved this here from the header
since it is only used within this file.
(WebCore::SharedCursor::create): Ditto.
(WebCore::Cursor::Cursor): Deleted.
(WebCore::Cursor::operator=): Deleted.
(WebCore::Cursor::~Cursor): Deleted.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
Pass reference.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking): Get to FrameView
through the render tree itself, rather than through the frame.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateLayerForHeader): Use reference.
(WebCore::RenderLayerCompositor::updateLayerForFooter): Ditto.
(WebCore::RenderLayerCompositor::attachRootLayer): Ditto.
(WebCore::RenderLayerCompositor::detachRootLayer): Ditto.

  • rendering/RenderMenuList.cpp:

(RenderMenuList::showPopup): Ditto.

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::addSearchResult): Ditto.
(WebCore::RenderSearchField::showPopup): Ditto.
(WebCore::RenderSearchField::valueChanged): Ditto.

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::isKeyboardFocusable): Ditto.

  • testing/MockPageOverlayClient.cpp:

(WebCore::MockPageOverlayClient::installOverlay): Ditto.
(WebCore::MockPageOverlayClient::uninstallAllOverlays): Ditto.

Source/WebKit/ios:

  • WebCoreSupport/WebChromeClientIOS.h: Update for changes to ChromeClient.
  • WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::runJavaScriptAlert): Ditto.
(WebChromeClientIOS::runJavaScriptConfirm): Ditto.
(WebChromeClientIOS::runJavaScriptPrompt): Ditto.
(WebChromeClientIOS::setNeedsScrollNotifications): Ditto.
(WebChromeClientIOS::observedContentChange): Ditto.
(WebChromeClientIOS::clearContentChangeObservers): Ditto.
(WebChromeClientIOS::notifyRevealedSelectionByScrollingFrame): Ditto.
(WebChromeClientIOS::elementDidFocus): Ditto.
(WebChromeClientIOS::elementDidBlur): Ditto.
(WebChromeClientIOS::createPopupMenu): Ditto.
(WebChromeClientIOS::createSearchPopupMenu): Ditto.
(WebChromeClientIOS::attachRootGraphicsLayer): Ditto.

Source/WebKit/mac:

  • WebCoreSupport/WebApplicationCacheQuotaManager.mm:

(-[WebApplicationCacheQuotaManager quota]): Pass reference.

  • WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedElementChanged): Ditto.
(WebChromeClient::createWindow): Ditto.
(WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
(WebChromeClient::runJavaScriptAlert): Ditto.
(WebChromeClient::runJavaScriptConfirm): Ditto.
(WebChromeClient::runJavaScriptPrompt): Ditto.
(WebChromeClient::contentsSizeChanged): Ditto.
(WebChromeClient::unavailablePluginButtonClicked): Ditto.
(WebChromeClient::print): Ditto.
(WebChromeClient::exceededDatabaseQuota): Ditto.
(WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
(WebChromeClient::createColorChooser): Ditto.
(WebChromeClient::elementDidFocus): Ditto.
(WebChromeClient::elementDidBlur): Ditto.
(WebChromeClient::createPopupMenu): Ditto.
(WebChromeClient::createSearchPopupMenu): Ditto.
(WebChromeClient::attachRootGraphicsLayer): Ditto.
(WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
(WebChromeClient::supportsFullScreenForElement): Ditto.
(WebChromeClient::enterFullScreenForElement): Ditto.
(WebChromeClient::exitFullScreenForElement): Ditto.

  • WebView/WebFrame.mm:

(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
Updated for change to the appendChild function.

Source/WebKit/win:

  • Plugins/PluginView.cpp:

(WebCore::PluginView::status): Pass reference.
(WebCore::PluginView::focusPluginElement): Ditto.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::createWindow): Updated for change to ChromeClient.
(WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
(WebChromeClient::runJavaScriptAlert): Ditto.
(WebChromeClient::runJavaScriptConfirm): Ditto.
(WebChromeClient::runJavaScriptPrompt): Ditto.
(WebChromeClient::contentsSizeChanged): Ditto.
(WebChromeClient::unavailablePluginButtonClicked): Ditto.
(WebChromeClient::print): Ditto.
(WebChromeClient::exceededDatabaseQuota): Ditto.
(WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
(WebChromeClient::attachRootGraphicsLayer): Ditto.
(WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
(WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.
(WebChromeClient::createPopupMenu): Ditto.
(WebChromeClient::createSearchPopupMenu): Ditto.
(WebChromeClient::supportsFullScreenForElement): Ditto.
(WebChromeClient::enterFullScreenForElement): Ditto.
(WebChromeClient::exitFullScreenForElement): Ditto.
(WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.

  • WebCoreSupport/WebChromeClient.h: Ditto.

Source/WebKit2:

  • UIProcess/Scrolling/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::createScrollingTreeNode): Return a Ref
instead of PassRefPtr.

  • UIProcess/Scrolling/RemoteScrollingTree.h: Updated for the above.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageInstallPageOverlay): Pass a reference.
(WKBundlePageUninstallPageOverlay): Ditto.
(WKBundlePageInstallPageOverlayWithAnimation): Ditto.
(WKBundlePageUninstallPageOverlayWithAnimation): Ditto.

  • WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:

(WebKit::PDFPlugin::jsPDFDocPrint): Ditto.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::focusPluginElement): Ditto.
(WebKit::PluginView::setStatusbarText): Ditto.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::elementDidFocus): Updated for changes to ChromeClient.
(WebKit::WebChromeClient::elementDidBlur): Ditto.
(WebKit::WebChromeClient::makeFirstResponder): Ditto.
(WebKit::WebChromeClient::createWindow): Ditto.
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
(WebKit::WebChromeClient::runJavaScriptAlert): Ditto.
(WebKit::WebChromeClient::runJavaScriptConfirm): Ditto.
(WebKit::WebChromeClient::runJavaScriptPrompt): Ditto.
(WebKit::WebChromeClient::contentsSizeChanged): Ditto.
(WebKit::WebChromeClient::unavailablePluginButtonClicked): Ditto.
(WebKit::WebChromeClient::print): Ditto.
(WebKit::WebChromeClient::exceededDatabaseQuota): Ditto.
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
(WebKit::WebChromeClient::createColorChooser): Ditto.
(WebKit::WebChromeClient::createPopupMenu): Ditto.
(WebKit::WebChromeClient::createSearchPopupMenu): Ditto.
(WebKit::WebChromeClient::attachRootGraphicsLayer): Ditto.
(WebKit::WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
(WebKit::WebChromeClient::createScrollingCoordinator): Ditto.
(WebKit::WebChromeClient::supportsFullScreenForElement): Ditto.
(WebKit::WebChromeClient::enterFullScreenForElement): Ditto.
(WebKit::WebChromeClient::exitFullScreenForElement): Ditto.
(WebKit::WebChromeClient::didAddHeaderLayer): Ditto.
(WebKit::WebChromeClient::didAddFooterLayer): Ditto.
(WebKit::WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.

  • WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.
  • WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::elementDidRefocus): Ditto.
(WebKit::WebChromeClient::didReceiveMobileDocType): Ditto.
(WebKit::WebChromeClient::observedContentChange): Ditto.
(WebKit::WebChromeClient::clearContentChangeObservers): Ditto.
(WebKit::WebChromeClient::notifyRevealedSelectionByScrollingFrame): Ditto.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchCreatePage): Pass reference.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::~WebInspectorClient): Ditto.
(WebKit::WebInspectorClient::hideHighlight): Ditto.
(WebKit::WebInspectorClient::showPaintRect): Ditto.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll): Ditto.
(WebKit::FindController::hideFindUI): Ditto.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createWithCoreMainFrame): Return Ref instead of
PassRefPtr.
(WebKit::WebFrame::createSubframe): Ditto.
(WebKit::WebFrame::create): Ditto.

  • WebProcess/WebPage/WebFrame.h: Updated for the above.
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::openInNewTab): Pass reference.

  • WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::FindController::updateFindIndicator): Use reference.
(WebKit::FindController::hideFindIndicator): Ditto.

22:21 Changeset [211032] by joepeck@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline WebKit1 results after r211006.

Unreviewed test gardening.

  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
21:13 Changeset [211031] by bshafiei@apple.com
  • 5 edits in tags/Safari-604.1.4.2/Source

Versioning.

21:09 Changeset [211030] by bshafiei@apple.com
  • 1 copy in tags/Safari-604.1.4.2

New tag.

19:52 Changeset [211029] by mmaxfield@apple.com
  • 7 edits in trunk/Source/WebCore

[Cocoa] Unify FontPlatformData's hashing and equality operators
https://bugs.webkit.org/show_bug.cgi?id=167061

Reviewed by Darin Adler.

On iOS, we were using CFEqual() and CFHash(), while on macOS
we were using pointer hashing and pointer equality. Instead,
we should be consistent about these operators.

Right now, FontPlatformData holds two internal CTFontRefs, and
switching to these higher-level CFEqual() and CFHash()
functions is required for eliminating one of these two
internal font objects.

No new tests because there is no behavior change.

  • platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::hash): Deleted.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::platformIsEqual):
(WebCore::cascadeToLastResortAttributesDictionary):

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::hash):

  • platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::hash):

  • platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::hash):

  • platform/graphics/win/FontPlatformDataDirect2D.cpp:

(WebCore::FontPlatformData::hash):

10:51 Changeset [211028] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

[WebGL] Do not allow GPU muxing on some old Mac hardware
https://bugs.webkit.org/show_bug.cgi?id=167259
<rdar://problem/30060378>

Reviewed by Simon Fraser and Darin Adler.

Some old Macbook Pro models should never use the
integrated GPU for WebGL, because they are unstable
when swapping between that and the discrete GPU.

Unfortunately this hardware configuration isn't in our
testing infrastructure, so it was confirmed manually.
Meanwhile, our existing tests make sure this patch
doesn't break anything elsewhere.

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::attachToAppleGraphicsControl): Helper function
to get a mach port that talks to Apple's Graphics Control
system.
(WebCore::hasMuxCapability): Decides whether a system
can do live GPU switching, based on whether or not it
has a muxable GPU, and if that GPU is not the old hardware
we know is problematic.
(WebCore::hasMuxableGPU): Helper to return the static hasMuxCapability value.
(WebCore::setPixelFormat): Only request the integrated card when the
GPU is muxable.

09:24 Changeset [211027] by mmaxfield@apple.com
  • 29 edits
    6 copies
    20 adds
    1 delete in trunk

Introducing the Platform Abstraction Layer (PAL)
https://bugs.webkit.org/show_bug.cgi?id=143358

Reviewed by Alex Christensen.

.:

  • CMakeLists.txt:
  • Source/CMakeLists.txt:
  • Source/cmake/WebKitFS.cmake:

Source/WebCore:

In order to enforce layering and promote testability, WebCore/platform files
should be compiled in their own project. This new project can enforce layering
and can be tested with unit tests in addition to layout tests.

The name of this new project is the Platform Abstraction Layer, or "PAL."
This comprises of a new directory in WebCore which will be the destination
for files migrated from WebCore/platform. This new folder, and its associated
project, will maintain layering invariants. These invariants are enforced at
build-time by setting the #include path for PAL to not include the rest of
WebCore (which is the same layering enforcement mechanism for WTF). Files will
be migrated into this new target/directory piece-by-piece, and the migration
of a file will be performed as soon as it can be migrated without violating
layering.

Within WebCore, files should include PAL files using the convention
#include <pal/foo.h>. Symbols within PAL are placed within a new top-level
namespace, "PAL," and therefore when used should be referred to as PAL::Foo.

The first set of files to move into the new platform is the crypto/ subdirectory
because it is both simple but also includes platform-dependent files.

No new tests because there is no behavior change.

  • CMakeLists.txt:
  • Configurations/WebCore.xcconfig: Add PAL to the include path
  • PAL/Configurations/Base.xcconfig: Added.
  • PAL/Configurations/DebugRelease.xcconfig: Added.
  • PAL/Configurations/PAL.xcconfig: Added. Sets up some PAL-specific

variables.

  • PAL/Configurations/FeatureDefines.xcconfig: Added.
  • PAL/Configurations/Version.xcconfig: Added.
  • PAL/PAL.xcodeproj/project.pbxproj: Added. New project file.
  • PAL/config.h: Added. Simplified from WebCore/config.h.
  • PAL/pal/CMakeLists.txt: Added.
  • PAL/pal/PlatformEfl.cmake: Added.
  • PAL/pal/PlatformGTK.cmake: Added.
  • PAL/pal/PlatformMac.cmake: Added.
  • PAL/pal/PlatformWin.cmake: Added.
  • PAL/pal/crypto/CryptoDigest.h: Renamed from Source/WebCore/platform/crypto/CryptoDigest.h.
  • PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp: Renamed from Source/WebCore/platform/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp.
  • PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp: Renamed from Source/WebCore/platform/crypto/gcrypt/CryptoDigestGCrypt.cpp.
  • PAL/pal/crypto/gnutls/CryptoDigestGnuTLS.cpp: Renamed from Source/WebCore/platform/crypto/gnutls/CryptoDigestGnuTLS.cpp.
  • PAL/pal/crypto/win/CryptoDigestWin.cpp: Renamed from Source/WebCore/platform/crypto/win/CryptoDigestWin.cpp.
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • PlatformWin.cmake:
  • WebCore.xcodeproj/project.pbxproj: Create a project link so WebCore

knows that it needs to build PAL as a dependency.

  • crypto/algorithms/CryptoAlgorithmSHA1.cpp:

(WebCore::CryptoAlgorithmSHA1::digest): Update #include and namespace.

  • crypto/algorithms/CryptoAlgorithmSHA224.cpp:

(WebCore::CryptoAlgorithmSHA224::digest): Ditto.

  • crypto/algorithms/CryptoAlgorithmSHA256.cpp:

(WebCore::CryptoAlgorithmSHA256::digest): Ditto.

  • crypto/algorithms/CryptoAlgorithmSHA384.cpp:

(WebCore::CryptoAlgorithmSHA384::digest): Ditto.

  • crypto/algorithms/CryptoAlgorithmSHA512.cpp:

(WebCore::CryptoAlgorithmSHA512::digest): Ditto.

  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::cryptoDigestAlgorithm): Ditto.
(WebCore::signRSASSA_PKCS1_v1_5): Ditto.
(WebCore::verifyRSASSA_PKCS1_v1_5): Ditto.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::computeContentSecurityPolicySHA256Hash): Ditto.

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::toCryptoDigestAlgorithm): Ditto.
(WebCore::ContentSecurityPolicy::findHashOfContentInPolicies): Ditto.

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::HostTLSCertificateSet::computeCertificateHash): Ditto.

00:29 Changeset [211026] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GStreamer] Clear out m_appsinkCaps in AppendPipeline::appsinkCapsChanged() before using outPtr()
https://bugs.webkit.org/show_bug.cgi?id=167165

Reviewed by Carlos Garcia Campos.

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::appsinkCapsChanged): Replace the gst_caps_replace() call
with a simple comparison and, in case the current appsink caps differ from the caps
on the sink's pad, move the reference to the latter into the m_appsinkCaps member
variable. This removes the use of GRefPtr<>::outPtr() which asserted in debug
configurations in the case of m_appsinkCaps not being null.

01/21/17:

22:44 Changeset [211025] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r210959): LayoutTest fast/mediastream/MediaStream-video-element-video-tracks-disabled.html is failing
https://bugs.webkit.org/show_bug.cgi?id=167260

Unreviewed test gardening.

Since this test checks against a black frame as its expected output, we need to use the legacy
media controls so that there is no start button.

Patch by Antoine Quint <graouts@apple.com> on 2017-01-21

  • fast/mediastream/MediaStream-video-element-video-tracks-disabled.html:
  • platform/mac-wk2/TestExpectations:
21:48 Changeset [211024] by cdumez@apple.com
  • 9 edits
    9 adds in trunk

JavaScript for-of does not work on a lot of collection types (e.g. HTMLCollection)
https://bugs.webkit.org/show_bug.cgi?id=167091

Reviewed by Darin Adler.

Source/JavaScriptCore:

Update Array methods to throw a TypeError when (this === null
this === undefined)

instead of when (this == null). This is because (this == null) returns true for types
that masquerades as undefined (such as document.all) and this prevented use of the
Array API on such types. The specification only stays to use ToObject(), which throws
when the input is undefined or null.

The corresponding specification is at:

  • builtins/ArrayPrototype.js:

(values):
(keys):
(entries):
(reduce):
(reduceRight):
(every):
(forEach):
(filter):
(map):
(some):
(fill):
(find):
(findIndex):
(includes):
(sort):
(concatSlowPath):
(copyWithin):

Source/WebCore:

As per the Web IDL specification [1], https://heycam.github.io/webidl/#es-iterator
an interface should get an iterator if it has:

  • an indexed property getter and an integer-typed attribute named "length".

We now comply with this part of the Web IDL specification. This adds an iterator
to the following interfaces:

  • AudioTrackList, ClientRectList, CSSRuleList, CSSStyleDeclaration, CSSValueList, MimeTypeArray, WebKitNamedFlowCollection, Plugin, PluginArray, DOMStringList, FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement, HTMLOptionsCollection, HTMLSelectElement, MediaList, NamedNodeMap, SourceBufferList, StyleSheetList, TextTrackCueList, TextTrackList, TouchList, VideoTrackList, VTTRegionList.

As a result, it is now possible to use for ... of for those types.

Tests: fast/dom/FileList-iterator.html

fast/dom/collection-iterators.html
fast/dom/document-all-undefined.html
fast/events/touch/ios/touchlist-iterator.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GetAttributeWithName):
(InterfaceNeedsIterator):
(GenerateImplementation):
(addIterableProperties):

LayoutTests:

  • fast/dom/FileList-iterator-expected.txt: Added.
  • fast/dom/FileList-iterator.html: Added.
  • fast/dom/collection-iterators-expected.txt: Added.
  • fast/dom/collection-iterators.html: Added.
  • fast/events/touch/ios/touchlist-iterator-expected.txt: Added.
  • fast/events/touch/ios/touchlist-iterator.html: Added.

Add layout test coverage for all types that gained an iterator.

  • fast/dom/document-all-undefined-expected.txt: Added.
  • fast/dom/document-all-undefined.html: Added.

Add layout test to cover the fact that HTMLAllCollection masquerades as
undefined, as per:

  • inspector/model/remote-object-get-properties-expected.txt:

Rebaseline now that there is an extra Symbol.iterator property.

  • platform/wk2/TestExpectations:

Skip that requires beginDragWithFiles() as this is unimplemented in
WebKitTestRunner.

21:19 Changeset [211023] by cdumez@apple.com
  • 11 edits in trunk

innerText should replace existing text node
https://bugs.webkit.org/show_bug.cgi?id=167116

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing test now that one more check is passing.

  • web-platform-tests/innerText/setter-expected.txt:

Source/WebCore:

Update setInnerText() to use ContainerNode::replaceAllChildren()
instead of replaceChildrenWithText(). replaceAllChildren() is
implemented as per specification:

As a result, we now correctly remove existing children before
inserting the new one.

No new tests, updated existing one.

  • editing/markup.cpp:

(WebCore::replaceChildrenWithText): Deleted.

  • editing/markup.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):

LayoutTests:

  • accessibility/mac/aria-liveregions-changedtext.html:

The text is using innerText and changed behavior now that we stopped
reusing the existing Text child. Code in RenderObject::willBeDestroyed()
is supposed to call AXObjectCache::childrenChanged(parent()) to fire
the AXLiveRegionChanged notification. However, it did not because the
parent renderer did not have an associated AccessibilityObject.

  • fast/dom/HTMLElement/set-inner-outer-optimization.html:

Update existing test which expected the non spec-compliant Text child
optimization.

  • fast/repaint/vertical-text-repaint-expected.txt:
  • fast/repaint/vertical-text-repaint.html:

Update / rebaseline test. We now repaint each 80x80 rectangle instead of
only repainting the text rects because we remove the Text node then add
a new one instead of only updating the existing Text node's test. The
output looks exactly the same otherwise.

18:29 Changeset [211022] by cdumez@apple.com
  • 5 edits in trunk

AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification coalescing
https://bugs.webkit.org/show_bug.cgi?id=167286
<rdar://problem/30133211>

Reviewed by Ryosuke Niwa.

Source/WebCore:

AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification
coalescing. This patch fixes the issue.

No new tests, updated existing test.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textChanged):

LayoutTests:

Update test to use a longer timer delay. When using this longer delay, we were getting 4
AXLiveRegionChanged notifications instead of the expected 2 because
AccessibilityRenderObject::textChanged() was bypassing AXLiveRegionChanged notification
coalescing.

  • accessibility/mac/aria-multiple-liveregions-notification-expected.txt:
  • accessibility/mac/aria-multiple-liveregions-notification.html:
18:16 Changeset [211021] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove -[WebFrame sendOrientationChangeEvent:] which is unused
https://bugs.webkit.org/show_bug.cgi?id=167276

Reviewed by Alex Christensen.

It was usurped by -deviceOrientationChanged in 2014.

  • WebView/WebFrame.mm:

(-[WebFrame sendOrientationChangeEvent:]): Deleted.

  • WebView/WebFramePrivate.h:
17:52 Changeset [211020] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=167271

Reviewed by Alex Christensen.

-_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),

  • WebView/WebView.mm:

(-[WebView _contentsSizeRespectingOverflow]): Deleted.

  • WebView/WebViewPrivate.h:
17:52 Changeset [211019] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebKit/ios

Remove the unused -[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]
https://bugs.webkit.org/show_bug.cgi?id=167273

Reviewed by Alex Christensen.

This function was added for an experiment, but is no longer used, so remove it.

  • WebCoreSupport/WebFixedPositionContent.h:
  • WebCoreSupport/WebFixedPositionContent.mm:

(anchorEdgeFlagsForAnchorEdge): Deleted.
(-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]): Deleted.

14:22 Changeset [211018] by utatane.tea@gmail.com
  • 9 edits in trunk/Source/JavaScriptCore

[JSC] export JSC::importModule API for WebCore dynamic import
https://bugs.webkit.org/show_bug.cgi?id=167099

Reviewed by Darin Adler.

We newly expose JSC::importModule API. This can be used later
from WebCore to implement WebCore side dynamic import.
And JSC shell also uses this API.

And this patch also cleans up module loader a bit:
Dropping requestInstantiateAll.

  • builtins/BuiltinNames.h:
  • builtins/ModuleLoaderPrototype.js:

(requestLink):
(requestImportModule):
(requestInstantiateAll): Deleted.
(importModule): Deleted.

  • jsc.cpp:

(GlobalObject::moduleLoaderImportModule):

  • runtime/Completion.cpp:

(JSC::importModule):

  • runtime/Completion.h:
  • runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::requestImportModule):

  • runtime/JSModuleLoader.h:
  • runtime/ModuleLoaderPrototype.cpp:
14:10 Changeset [211017] by utatane.tea@gmail.com
  • 4 edits
    3 adds in trunk

dynamic import is ambiguous with import declaration at module code
https://bugs.webkit.org/show_bug.cgi?id=167098

Reviewed by Darin Adler.

JSTests:

  • modules/import-call.js: Added.

(from.string_appeared_here.import.string_appeared_here.then):

  • modules/import-call/main.js: Added.
  • stress/import-syntax.js:

(async):

Source/JavaScriptCore:

This patch fixes two syntax issues related to dynamic import.

  1. Fix member expression parsing with dynamic import results

We should not return import expression immediately after parsing
it in parseMemberExpression. This prohibits us to parse the following
code,

import("...").then(function () {
});

  1. dynamic import with import declaration under the module context

Before this patch, we always attempt to parse IMPORT as import declaration
under the module context. It means that import call in the top level
expression statement fails to be parsed since the parser attempts to parse
it as import declaration.

import("...") module top level statement.

In this patch, we check the condition [lookahead != (] before starting
parsing import declaration. This allows us to put import call in the module
top level statement.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseModuleSourceElements):
(JSC::Parser<LexerType>::parseMemberExpression):

12:46 Changeset [211016] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r210959): LayoutTest inspector/css/pseudo-element-matches.html timing out
https://bugs.webkit.org/show_bug.cgi?id=167246

Unreviewed test gardening.

This test expects elements with legacy media controls pseudo classes so we turn off
modern media controls for it and stop expecting a timeout.

Patch by Antoine Quint <graouts@apple.com> on 2017-01-21

  • inspector/css/pseudo-element-matches.html:
  • platform/mac/TestExpectations:
02:21 Changeset [211015] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Bring back gtk-doc error messages after r209981.

Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
impossible to know what's wrong.

  • gtk/gtkdoc.py:

(GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.

01:22 Changeset [211014] by carlosgc@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r211012.

It caused a lot of crashes in the network process

Reverted changeset:

"[SOUP] Custom protocols don't work in private browsing mode"
https://bugs.webkit.org/show_bug.cgi?id=167236
http://trac.webkit.org/changeset/211012

01/20/17:

23:52 Changeset [211013] by commit-queue@webkit.org
  • 20 edits in trunk/Source

Remove never changing IndexedDB RuntimeEnabledFeature
https://bugs.webkit.org/show_bug.cgi?id=167278

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-01-20
Reviewed by Darin Adler.

Source/WebCore:

This RuntimeEnabledFeature flag is always true and there are
no existing ways to change it. So lets just remove it.

  • Modules/indexeddb/DOMWindowIndexedDatabase.idl:
  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBCursorWithValue.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBOpenDBRequest.idl:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/indexeddb/IDBVersionChangeEvent.idl:
  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setIndexedDBEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::indexedDBEnabled): Deleted.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

  • WebProcess/WebProcess.cpp:

(WebKit::m_resourceLoadStatisticsStorage):

23:40 Changeset [211012] by carlosgc@webkit.org
  • 5 edits in trunk/Source

[SOUP] Custom protocols don't work in private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=167236

Reviewed by Sergio Villar Senin.

Source/WebCore:

Add static method to set the global custom protocols request type and setup method to add the feature to the session.

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setCustomProtocolRequestType):
(WebCore::SoupNetworkSession::setupCustomProtocols):

  • platform/network/soup/SoupNetworkSession.h:

Source/WebKit2:

We only register them in the default session.

  • NetworkProcess/CustomProtocols/soup/CustomProtocolManagerSoup.cpp:

(WebKit::CustomProtocolManager::registerProtocolClass): Set the WEBKIT_TYPE_SOUP_REQUEST_GENERIC as type for
custom protocols, and setup custom protocols in all existing sessions.
(WebKit::CustomProtocolManager::registerScheme): Use g_type_class_peek instead of g_type_class_ref since we know
the class was already created in registerProtocolClass().

22:36 Changeset [211011] by cdumez@apple.com
  • 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline html/dom/interfaces.html.

  • web-platform-tests/html/dom/interfaces-expected.txt:
20:51 Changeset [211010] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Search Tab should display search results immediately when closing and reopening Inspector
https://bugs.webkit.org/show_bug.cgi?id=167073

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-01-20
Reviewed by Timothy Hatcher.

  • UserInterface/Views/SearchSidebarPanel.js:

(WebInspector.SearchSidebarPanel.prototype.focusSearchField):
Add parameter that will trigger a search with the current input value when true.

  • UserInterface/Views/SearchTabContentView.js:

(WebInspector.SearchTabContentView):
(WebInspector.SearchTabContentView.prototype.focusSearchField):
(WebInspector.SearchTabContentView.prototype.initialLayout):

18:36 Changeset [211009] by commit-queue@webkit.org
  • 4 edits in trunk

[WebRTC] Update build system to make G711 optional in libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=167256

Patch by Youenn Fablet <youennf@gmail.com> on 2017-01-20
Reviewed by Alex Christensen.

Source/ThirdParty/libwebrtc:

  • CMakeLists.txt: Updating to add compilation of generic pcm encoder functions.

Tools:

  • Scripts/webkitpy/libwebrtc/generate_cmake.py:

(CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.

18:31 Changeset [211008] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

Record whether a media element was prevented from playing without user interaction
https://bugs.webkit.org/show_bug.cgi?id=167214

Patch by Matt Rajca <mrajca@apple.com> on 2017-01-20
Reviewed by Eric Carlson.

This state will be used to notify clients when a user explicitly starts playback
of a media element that was prevented from autoplaying.

Tests will be added after a WebKit callback API is added.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/SuccessOr.h: Added.

(WebCore::SuccessOr::SuccessOr):
(WebCore::SuccessOr::operator bool):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canTransitionFromAutoplayToPlay):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::playInternal):

  • html/HTMLMediaElement.h:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):

  • html/MediaElementSession.h:
18:24 Changeset [211007] by beidson@apple.com
  • 27 edits
    2 adds in trunk

Require a button press on a gamepad for them to be exposed to the DOM.
<rdar://problem/28620919> and https://bugs.webkit.org/show_bug.cgi?id=167272

Reviewed by Alex Christensen.

Source/WebCore:

Test: gamepad/gamepad-visibility-1.html

  • Modules/gamepad/GamepadManager.cpp:

(WebCore::GamepadManager::platformGamepadInputActivity):

  • Modules/gamepad/GamepadManager.h:
  • platform/gamepad/GamepadProvider.cpp:

(WebCore::GamepadProvider::dispatchPlatformGamepadInputActivity):

  • platform/gamepad/GamepadProvider.h:

(WebCore::GamepadProvider::~GamepadProvider): Deleted.
(WebCore::GamepadProvider::isMockGamepadProvider): Deleted.

  • platform/gamepad/GamepadProviderClient.h:
  • platform/gamepad/cocoa/GameControllerGamepad.h:
  • platform/gamepad/cocoa/GameControllerGamepad.mm:

(WebCore::GameControllerGamepad::setupAsExtendedGamepad):
(WebCore::GameControllerGamepad::setupAsGamepad):

  • platform/gamepad/cocoa/GameControllerGamepadProvider.h:
  • platform/gamepad/cocoa/GameControllerGamepadProvider.mm:

(WebCore::GameControllerGamepadProvider::gamepadHadInput):
(WebCore::GameControllerGamepadProvider::inputNotificationTimerFired):

  • platform/gamepad/mac/HIDGamepad.cpp:

(WebCore::HIDGamepad::valueChanged):

  • platform/gamepad/mac/HIDGamepad.h:
  • platform/gamepad/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::valuesChanged):
(WebCore::HIDGamepadProvider::inputNotificationTimerFired):

  • platform/gamepad/mac/HIDGamepadProvider.h:
  • testing/MockGamepadProvider.cpp:

(WebCore::MockGamepadProvider::setMockGamepadButtonValue):
(WebCore::MockGamepadProvider::gamepadInputActivity):

  • testing/MockGamepadProvider.h:

Source/WebKit2:

  • UIProcess/Gamepad/UIGamepadProvider.cpp:

(WebKit::UIGamepadProvider::gamepadSyncTimerFired):
(WebKit::UIGamepadProvider::platformGamepadInputActivity):

  • UIProcess/Gamepad/UIGamepadProvider.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::gamepadActivity):

  • UIProcess/WebPageProxy.h:
  • WebProcess/Gamepad/WebGamepadProvider.cpp:

(WebKit::WebGamepadProvider::gamepadActivity):

  • WebProcess/Gamepad/WebGamepadProvider.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::gamepadActivity):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

LayoutTests:

  • gamepad/gamepad-visibility-1-expected.txt: Added.
  • gamepad/gamepad-visibility-1.html: Added.
18:23 Changeset [211006] by joepeck@webkit.org
  • 75 edits
    1 delete in trunk

Cleanup RuntimeEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=167228

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/resource-timing/resource_cached-expected.txt:
  • web-platform-tests/resource-timing/resource_connection_reuse-expected.txt:
  • web-platform-tests/resource-timing/resource_dynamic_insertion-expected.txt:

The previous internals API didn't appear to be working. Making it work
improved these results.

Source/WebCore:

RuntimeEnabledFeatures::reset() is bad for tests. It was getting called
after the TestRunners had set up all the Settings and RuntimeEnabledFeatures
they expected, so it was clearing the "consistent state" set by TestRunners.

Cleanup within RuntimeEnabledFeatures:

  • Initialize all members.
  • Remove unused features.
  • Remove reset() no longer used.
  • Document features that do not change (potentially removable).
  • Document features that are not used but have APIs (use or remove later).
  • Drop webkit prefix for these internal only apis.
  • Move things around a bit to make it more readable.
  • Enable the Fetch API by default (WebKit levels all were enabling it).

Cleanup within Internals:

  • Move all RuntimeEnabledFeature toggling to InternalSettings
  • Save and restore these RuntimeEnabledFeatures in InternalSettings
  • Modules/mediastream/MediaStreamEvent.idl:
  • Modules/mediastream/NavigatorMediaDevices.idl:
  • Modules/mediastream/NavigatorUserMedia.idl:
  • Modules/mediastream/RTCDTMFToneChangeEvent.idl:
  • Modules/mediastream/RTCIceCandidate.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCRtpReceiver.idl:
  • Modules/mediastream/RTCRtpSender.idl:
  • Modules/mediastream/RTCRtpTransceiver.idl:
  • Modules/mediastream/RTCSessionDescription.idl:
  • Modules/mediastream/RTCTrackEvent.idl:

Canonical usage is to start with a capital letter.

  • dom/EventNames.in:

No port has API/SPI to disable this feature at runtime and the default is
to have the feature enabled, so this is no different from the runtime flag.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
These features were always enabled and not toggleable. So drop the runtime
feature check.

  • page/csp/ContentSecurityPolicy.h:
  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled): Deleted.
Nobody calls this method. Drop it.

  • page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::reset):
(WebCore::RuntimeEnabledFeatures::javaScriptI18NAPIEnabled): Deleted.

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLinkPreloadEnabled):
(WebCore::RuntimeEnabledFeatures::linkPreloadEnabled):
(WebCore::RuntimeEnabledFeatures::setResourceTimingEnabled):
(WebCore::RuntimeEnabledFeatures::resourceTimingEnabled):
(WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::shadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::setInputEventsEnabled):
(WebCore::RuntimeEnabledFeatures::inputEventsEnabled):
(WebCore::RuntimeEnabledFeatures::setInteractiveFormValidationEnabled):
(WebCore::RuntimeEnabledFeatures::interactiveFormValidationEnabled):
(WebCore::RuntimeEnabledFeatures::setCustomElementsEnabled):
(WebCore::RuntimeEnabledFeatures::customElementsEnabled):
(WebCore::RuntimeEnabledFeatures::setModernMediaControlsEnabled):
(WebCore::RuntimeEnabledFeatures::modernMediaControlsEnabled):
(WebCore::RuntimeEnabledFeatures::setIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::localStorageEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::sessionStorageEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebkitNotificationsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitNotificationsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::touchEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setTouchEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setDeviceMotionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::deviceMotionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::deviceMotionEventEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::ondevicemotionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setJavaScriptI18NAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitMediaStreamEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled): Deleted.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
(WebCore::InternalSettings::setResourceTimingEnabled):
(WebCore::InternalSettings::setLinkPreloadEnabled):
(WebCore::InternalSettings::setCSSGridLayoutEnabled):
(WebCore::InternalSettings::setWebGL2Enabled):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:
  • testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::setLinkPreloadSupport): Deleted.
(WebCore::Internals::setCSSGridLayoutEnabled): Deleted.
(WebCore::Internals::webGL2Enabled): Deleted.
(WebCore::Internals::setWebGL2Enabled): Deleted.
(WebCore::Internals::setResourceTimingSupport): Deleted.

  • testing/Internals.h:
  • testing/Internals.idl:

Move toggling of RuntimeEnabledFeatures to InternalSettings and
properly remember to save and restore them in Internals.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

  • WebProcess/WebProcess.cpp:

(WebKit::m_resourceLoadStatisticsStorage):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):
(setWebPreferencesForTestOptions):
(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):
More closely match WebKitTestRunner initialization of preferences
for experimental features.

LayoutTests:

Update tests that toggle runtime enabled features to use
consistently named internals.settings.setFooEnabled setters.

  • css3/flexbox/flexbox-lines-must-be-stretched-by-default.html:
  • css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html:
  • fast/canvas/webgl/bufferData-offset-length.html:
  • fast/canvas/webgl/copyBufferSubData.html:
  • fast/canvas/webgl/getBufferSubData-webgl1.html:
  • fast/canvas/webgl/webgl2-buffer-targets.html:
  • fast/canvas/webgl/webgl2-buffers.html:
  • fast/canvas/webgl/webgl2-context-creation.html:
  • fast/canvas/webgl/webgl2-runtime-flag.html:
  • fast/canvas/webgl/webgl2-texStorage.html:
  • fast/canvas/webgl/webgl2-texture-upload-enums.html:
  • fast/css-grid-layout/grid-disable.html:
  • fast/css/ensure-flexbox-compatibility-with-initial-values.html:
  • fast/dom/Window/window-properties-performance-resource-timing.html:
  • http/tests/fetch/redirectmode-and-preload.html:
  • http/tests/misc/resource-timing-resolution.html:
  • http/tests/performance/performance-resource-timing-cached-entries.html:
  • http/tests/performance/performance-resource-timing-entries-iterable.html:
  • http/tests/performance/performance-resource-timing-entries.html:
  • http/tests/performance/performance-resource-timing-initiator-css.html:
  • http/tests/performance/performance-resource-timing-initiator-no-override.html:
  • http/tests/performance/performance-resource-timing-xhr-single-entry.html:
  • http/tests/preload/delaying_onload_link_preload_after_discovery.html:
  • http/tests/preload/delaying_onload_link_preload_after_discovery_image.html:
  • http/tests/preload/download_resources.html:
  • http/tests/preload/download_resources_from_header_iframe.html:
  • http/tests/preload/download_resources_from_invalid_headers.html:
  • http/tests/preload/dynamic_adding_preload.html:
  • http/tests/preload/dynamic_remove_preload_href.html:
  • http/tests/preload/not_delaying_window_onload_before_discovery.html:
  • http/tests/preload/onerror_event.html:
  • http/tests/preload/onload_event.html:
  • http/tests/preload/resources/download_resources_from_header.php:
  • http/tests/preload/resources/invalid_resources_from_header.php:
  • http/tests/preload/single_download_preload_runner.html:
  • http/tests/security/cached-cross-origin-preloading-css-stylesheet.html:
  • resources/testharnessreport.js:
17:46 Changeset [211005] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603-branch/Source

Versioning.

17:21 Changeset [211004] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

[WebRTC] Update libwertc AudioRtpSender::SetAudioSend
https://bugs.webkit.org/show_bug.cgi?id=167243

Patch by Youenn Fablet <youennf@gmail.com> on 2017-01-20
Reviewed by Alex Christensen.

Introducing WEBRTC_WEBKIT_BUILD macro to match existing WEBRTC_CHROMIUM_BUILD.
WEBRTC_WEBKIT_BUILD is defined by current WebKit libwebrtc build system.

  • Source/webrtc/api/rtpsender.cc:
17:08 Changeset [211003] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.1.21

New tag.

17:05 Changeset [211002] by megan_gardner@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r210941): LayoutTest scrollingcoordinator/ios/sync-layer-positions-after-scroll.html failing
https://bugs.webkit.org/show_bug.cgi?id=167262

Updating Tests to comply with change in bug 167171.
Change is correct, but causes the results for this test to be different.

Unreviewed test gardening.

  • scrollingcoordinator/ios/sync-layer-positions-after-scroll-expected.txt:
16:44 Changeset [211001] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Add debugging code to compare URLParser with URL::parse
https://bugs.webkit.org/show_bug.cgi?id=167267

Reviewed by Brady Eidson.

  • platform/URLParser.cpp:

(WebCore::URLParser::URLParser):
(WebCore::URLParser::parse):

16:35 Changeset [211000] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Marking media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167266

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
16:30 Changeset [210999] by jmarcell@apple.com
  • 5 edits in tags/Safari-604.1.4.1/Source

Versioning.

16:28 Changeset [210998] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Marking inspector/network/client-blocked-load.html as a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=167265

Unreviewed test gardening.

  • platform/mac/TestExpectations:
16:21 Changeset [210997] by ryanhaddad@apple.com
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r210778.

This change caused multiple LayoutTests to crash.

Reverted changeset:

"[Cocoa] Unify FontPlatformData's hashing and equality
operators"
https://bugs.webkit.org/show_bug.cgi?id=167061
http://trac.webkit.org/changeset/210778

16:17 Changeset [210996] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.4.1

New tag.

16:08 Changeset [210995] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Marking media/modern-media-controls/pip-support/pip-support-enabled.html as crashing on macOS WK1.
https://bugs.webkit.org/show_bug.cgi?id=164336

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
16:00 Changeset [210994] by ryanhaddad@apple.com
  • 3 edits in trunk/LayoutTests

More media test gardening.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
15:33 Changeset [210993] by achristensen@apple.com
  • 6 edits in trunk

Build Fix for Windows DumpRenderTree after r210976
https://bugs.webkit.org/show_bug.cgi?id=167115

Source/WebKit/win:

  • WebPreferences.h:

Remove extra space.

  • IWebPreferencesPrivate.idl:

Add new interface functions.

  • WebView.cpp:

We use new functions that are only in IWebPreferencesPrivate4,
so instantiate that COM object instead of version 3.

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

15:23 Changeset [210992] by commit-queue@webkit.org
  • 27 edits in trunk

Remove outdated ENABLE(CSP_NEXT) build flag
https://bugs.webkit.org/show_bug.cgi?id=167252

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-01-20
Reviewed by Brent Fulgham.

.:

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • dom/Document.idl:
  • page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::reset):

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled): Deleted.

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled): Deleted.

  • page/csp/ContentSecurityPolicy.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • fast/dom/event-handler-attributes.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html:
14:54 Changeset [210991] by joepeck@webkit.org
  • 7 edits in trunk

Build Fix for Windows DumpRenderTree after r210976

Source/WebKit/win:

  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setWebAnimationsEnabled):
(WebPreferences::webAnimationsEnabled):

  • WebPreferences.h:
  • WebView.cpp:

Add toggle APIs for WebAnimations.

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

14:53 Changeset [210990] by ryanhaddad@apple.com
  • 3 edits in trunk/LayoutTests

Cleaning up TestExpectations for inspector/css/pseudo-element-matches.html.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
14:48 Changeset [210989] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Marking media/modern-media-controls/audio/audio-controls-metrics.html as failing on iOS.
https://bugs.webkit.org/show_bug.cgi?id=167258

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
14:40 Changeset [210988] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Build fix after r210783. Didn't mean to require custom elements API.

  • public/v3/main.js:

(main):

14:30 Changeset [210987] by commit-queue@webkit.org
  • 16 edits in trunk/Source/ThirdParty/libwebrtc

[WebRTC] libwebrtc headers are incompatible with WebKit compilation flags
https://bugs.webkit.org/show_bug.cgi?id=167242

Patch by Youenn Fablet <youenn@apple.com> on 2017-01-20
Reviewed by Alex Christensen.

WebKit is enforcing -Wunused-parameter and -Wunused-variable which conflict with some included libwertc headers.
Removed unused parameter names for inlined functions.

  • Source/webrtc/api/jsep.h:

(webrtc::SessionDescriptionInterface::RemoveCandidates):

  • Source/webrtc/api/mediastreaminterface.h:

(webrtc::AudioSourceInterface::SetVolume):
(webrtc::AudioSourceInterface::RegisterAudioObserver):
(webrtc::AudioSourceInterface::UnregisterAudioObserver):
(webrtc::AudioSourceInterface::AddSink):
(webrtc::AudioSourceInterface::RemoveSink):
(webrtc::AudioTrackInterface::GetSignalLevel):

  • Source/webrtc/api/peerconnectionfactory.h:
  • Source/webrtc/api/peerconnectioninterface.h:

(webrtc::MetricsObserverInterface::IncrementEnumCounter):
(webrtc::PeerConnectionInterface::AddTrack):
(webrtc::PeerConnectionInterface::RemoveTrack):
(webrtc::PeerConnectionInterface::CreateSender):
(webrtc::PeerConnectionInterface::GetStats):
(webrtc::PeerConnectionInterface::CreateOffer):
(webrtc::PeerConnectionInterface::CreateAnswer):
(webrtc::PeerConnectionInterface::UpdateIce):
(webrtc::PeerConnectionInterface::SetConfiguration):
(webrtc::PeerConnectionInterface::RemoveIceCandidates):
(webrtc::PeerConnectionInterface::StartRtcEventLog):
(webrtc::PeerConnectionObserver::OnAddStream):
(webrtc::PeerConnectionObserver::OnRemoveStream):
(webrtc::PeerConnectionObserver::OnDataChannel):
(webrtc::PeerConnectionObserver::OnIceCandidatesRemoved):
(webrtc::PeerConnectionObserver::OnIceConnectionReceivingChange):

  • Source/webrtc/api/rtpsender.cc:
  • Source/webrtc/base/messagehandler.h:

(rtc::FunctorMessageHandler::OnMessage):

  • Source/webrtc/base/sanitizer.h:

(rtc_AsanPoison):
(rtc_AsanUnpoison):
(rtc_MsanMarkUninitialized):
(rtc_MsanCheckInitialized):

  • Source/webrtc/base/stream.h:

(rtc::StreamInterface::ConsumeReadData):
(rtc::StreamInterface::ConsumeWriteBuffer):

  • Source/webrtc/media/base/mediachannel.h:

(cricket::DataMediaChannel::GetStats):
(cricket::DataMediaChannel::OnNetworkRouteChanged):

  • Source/webrtc/media/engine/webrtcvideodecoderfactory.h:

(cricket::WebRtcVideoDecoderFactory::CreateVideoDecoderWithParams):

  • Source/webrtc/media/engine/webrtcvideoencoderfactory.h:

(cricket::WebRtcVideoEncoderFactory::VideoCodec::VideoCodec):
(cricket::WebRtcVideoEncoderFactory::EncoderTypeHasInternalSource):

  • Source/webrtc/media/engine/webrtcvideoengine2.cc:
  • Source/webrtc/modules/include/module.h:

(webrtc::Module::ProcessThreadAttached):

  • Source/webrtc/modules/video_coding/codecs/vp9/vp9_noop.cc:
  • Source/webrtc/p2p/base/port.h:

(cricket::Port::HandleIncomingPacket):
(cricket::Port::HandleConnectionDestroyed):
(cricket::Connection::set_receiving_timeout):

  • Source/webrtc/p2p/base/stun.h:

(cricket::StunAttribute::SetOwner):

  • Source/webrtc/p2p/base/stunrequest.h:

(cricket::StunRequest::Prepare):
(cricket::StunRequest::OnResponse):
(cricket::StunRequest::OnErrorResponse):

  • Source/webrtc/p2p/base/transport.h:

(cricket::Transport::SetLocalCertificate):
(cricket::Transport::GetLocalCertificate):
(cricket::Transport::GetSslRole):
(cricket::Transport::SetSslMaxProtocolVersion):

  • Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc:
  • Source/webrtc/typedefs.h:
14:19 Changeset [210986] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Marking media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167254

Unreviewed test gardening.

  • platform/mac/TestExpectations:
14:12 Changeset [210985] by zalan@apple.com
  • 6 edits in trunk

Simple line layout: Add support for non-breaking space character.
https://bugs.webkit.org/show_bug.cgi?id=167250
<rdar://problem/30119638>

Reviewed by Antti Koivisto.
Source/WebCore:

Do not bail out on noBreakSpace character.
The line breaking logic already takes noBreakSpace characters into account.
(except the peculiar "-webkit-nbsp-mode: space" mode)

Covered by existing test cases.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseForStyle):
(WebCore::SimpleLineLayout::printReason):

LayoutTests:

These are output progressions (they do not reflect changes in functionality).

  • fast/block/float/br-with-clear-2-expected.txt:
  • platform/mac/css1/text_properties/text_transform-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4427-expected.txt:
14:07 Changeset [210984] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Marking macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=167253

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
14:07 Changeset [210983] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Marking inspector/css/pseudo-element-matches.html as a timeout on macOS.
https://bugs.webkit.org/show_bug.cgi?id=167246

Unreviewed test gardening.

  • platform/mac/TestExpectations:
14:04 Changeset [210982] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Make sync-commits.py robust against missing Subversion authors and missing parent Git commits
https://bugs.webkit.org/show_bug.cgi?id=167231

Reviewed by Antti Koivisto.

Fixed a bug that a subversion commit that's missing author name (anonymous commit) results in an out of bound
exception, and a bug that syncing a git repository starts failing once there was a merge commit which pulled
in a commit data earlier than that of the last reported commit.

For the latter fix, added --max-ancestor-fetch-count to specify the number of maximum commits to look back.

  • tools/sync-commits.py:

(main): Added --max-ancestor-fetch-count.
(Repository.fetch_commits_and_submit): If submit_commits fails with FailedToFindParentCommit, fetch the parent
commit's information until we've resolved them all.
(Repository.fetch_next_commit): Renamed from fetch_commit.
(SVNRepository.fetch_next_commit): Renamed from fetch_commit. Don't try to get the author name if it's missing
due to an anonymous commit. It's important to never include the "author" field in the JSON submitted to
a dashboard since it rejects when "author" field is not an array (e.g. null).
(GitRepository.fetch_next_commit): Renamed from fetch_commit.
(GitRepository.fetch_commit): Added. Fetches the commit information for a given git hash. Used to retrieve
missing parent commits.
(GitRepository._revision_from_tokens): Extracted from fetch_commit.

  • tools/util.py:

(submit_commits): Optionally takes status_to_accept to avoid throwing in the case of FailedToFindParentCommit
and returns the response JSON.

14:02 Changeset [210981] by rniwa@webkit.org
  • 3 edits
    1 add in trunk/Websites/perf.webkit.org

REGRESSION(r198234): /api/commits/%revision% always fails
https://bugs.webkit.org/show_bug.cgi?id=167235

Reviewed by Antti Koivisto.

The bug was caused by a typo in CommitLogFetcher::fetch_revision, which was calling commit_for_revision on
$this->db instead of $this. This had been monkey-patched in the internal dashboard so it was working there.

Also fixed a bug that /latest wasn't doing what it claimed to do, and a bug that /oldest /latest,
and /last-reported would return a commit with all values set to null instead of an empty list.

Finally, added server API tests for /api/commits.

  • public/api/commits.php:

(main): Add a comment for APIs that only exist for v2 UI.

  • public/include/commit-log-fetcher.php:

(CommitLogFetcher::fetch_latest): Fixed the bug that this function was returning the oldest commit, not the
the latest commit as desired.
(CommitLogFetcher::fetch_revision): Fixed the bug that this function would always encounter an exception
because commit_for_revision is defined on $this, not $this->db.
(CommitLogFetcher::format_single_commit): Return an empty list instead of an array with a single commit with
all values set to null.

  • server-tests/api-commits.js: Added. Added tests for the JSON API at /api/commits.

(.assertCommitIsSameAsOneSubmitted): Added. A helper function to compare a commit returned by /api/commits
to one sent to /api/report-commits.

13:50 Changeset [210980] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix Mac CMake build.

  • CMakeLists.txt:
  • PlatformMac.cmake:
13:35 Changeset [210979] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Marking media/modern-media-controls/placard-support/placard-support-airplay.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=164298

Unreviewed test gardening.

  • platform/mac/TestExpectations:
13:35 Changeset [210978] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Marking media/modern-media-controls/tracks-panel/tracks-panel-hide-click-outside.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=165290

Unreviewed test gardening.

  • platform/mac/TestExpectations:
13:25 Changeset [210977] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

[WebRTC] Update libwertc AudioRtpSender::SetAudioSend
https://bugs.webkit.org/show_bug.cgi?id=167243

Patch by Youenn Fablet <youennf@gmail.com> on 2017-01-20
Reviewed by Alex Christensen.

Introducing WEBRTC_WEBKIT_BUILD macro to match existing WEBRTC_CHROMIUM_BUILD.
WEBRTC_WEBKIT_BUILD is defined by current WebKit libwebrtc build system.

  • Source/webrtc/api/rtpsender.cc:
13:04 Changeset [210976] by commit-queue@webkit.org
  • 19 edits in trunk

Web Animations should be off by default and enabled as an experimental feature
https://bugs.webkit.org/show_bug.cgi?id=167115
<rdar://problem/30048963>

Patch by Antoine Quint <graouts@apple.com> on 2017-01-20
Reviewed by Joseph Pecoraro.

Source/WebCore:

Conditionalize the existing parts of the Web Animations API so that they may be
toggled at runtime.

  • animation/Animatable.idl:
  • animation/AnimationEffect.idl:
  • animation/AnimationTimeline.idl:
  • animation/DocumentAnimation.idl:
  • animation/DocumentTimeline.idl:
  • animation/KeyframeEffect.idl:
  • animation/WebAnimation.idl:
  • page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::reset):

  • page/RuntimeEnabledFeatures.h:

Source/WebKit2:

Promote, or relegate depending on how you see things, the Web Animations preference
to an experimental feature.

  • Shared/WebPreferencesDefinitions.h:

Tools:

Turn Web Animations on in DRT.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

Websites/webkit.org:

Add a test for Web Animations feature detection.

  • experimental-features.html:

LayoutTests:

No need for an explicit preference anymore.

  • webanimations/script-tests/Document.js:
12:44 Changeset [210975] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Skipping pointer-lock tests on macOS WK2.
https://bugs.webkit.org/show_bug.cgi?id=167246

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:41 Changeset [210974] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

[WebRTC] libwebrtc H.264 codec is using VTB only for IOS
https://bugs.webkit.org/show_bug.cgi?id=167245

Patch by Youenn Fablet <youennf@gmail.com> on 2017-01-20
Reviewed by Alex Christensen.

  • Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc: Removing WEBRTC_IOS flag.
10:43 Changeset [210973] by commit-queue@webkit.org
  • 4 edits
    11 adds in trunk

[WebRTC] Add libwebrtc build infrastructure
https://bugs.webkit.org/show_bug.cgi?id=167207

Patch by Youenn Fablet <youenn@apple.com> on 2017-01-20
Reviewed by Alex Christensen.

.:

  • WebKit.xcworkspace/contents.xcworkspacedata:

Source/ThirdParty:

Checking-in files used for building libwebrtc.
The principle is the following:

  • Select a revision of libwebrtc
  • Ask libwebrtc build system to generate the project.json (something like gn gen --ide json ...)
  • Copy project.json here and the libwebrtc selected revision in a libwebrtc/libwebrtc folder.
  • Call Tools/Scripts/generate-libwebrtc-cmake which will update CMakeLists.txt
  • Build libwebrtc with CMake
  • libwebrtc/CMakeLists.txt: Added (Generated by Tools/Scripts/generate-libwebrtc-cmake using project.json as input).
  • libwebrtc/Makefile: Added.
  • libwebrtc/WebKit/project.json: Added (Generated by libwebrtc build system).
  • libwebrtc/WebKit/rtc_sdk_framework_objc_info_plist.plist: Added.
  • libwebrtc/libwebrtc.xcodeproj/project.pbxproj: Added.

Tools:

Adding a script doing the libwebrtc project json to CMake file conversion.

  • Scripts/generate-libwebrtc-cmake: Added.
  • Scripts/webkitpy/libwebrtc/init.py: Added.
  • Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
10:21 Changeset [210972] by cdumez@apple.com
  • 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, unskip innerText/ folder in ImportExpectations

This is needed so that the tests in this folder gets re-sync'ed
from upstream next time.

  • resources/ImportExpectations:
10:10 Changeset [210971] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

We should flash a safepoint before each DFG/FTL phase
https://bugs.webkit.org/show_bug.cgi?id=167234

Reviewed by Filip Pizlo.

The recent GC changes caused us to regress Kraken because of a
longstanding issue that happened to be hit with higher frequency because
of a change in timing between when a particular GC was happening and
when a particular FTL compilation was happening. The regression is caused
by the GC was waiting for a large function to make it through the DFG portion
of an FTL compilation. This was taking 20ms-30ms and started happened during a
particular test with much higher frequency.

This means that anytime the GC waits for this compilation, the test ran at least
~20ms slower because the GC waits for the compiler threads the mutator is stopped.

It's good that we have such an easily reproducible case of this performance
issue because it will effect many real JS programs, especially ones with
large functions that get hot.

The most straight forward solution to fix this is to flash a safepoint before
each phase, allowing the GC to suspend the compiler if needed. In my testing,
this progresses Kraken in the browser, and doesn't regress anything else. This
solution also makes the most sense. I did some analysis on the compilation time
of this function that took ~20-30ms to pass through the DFG phases, and
the phase times were mostly evenly distributed. Some took longer than others,
but no phase was longer than 3ms. Most were in the 0.25ms to 1.5ms range.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGSafepoint.cpp:

(JSC::DFG::Safepoint::begin):

  • runtime/Options.h:
10:09 Changeset [210970] by matthew_hanson@apple.com
  • 3 edits
    4 adds in branches/safari-603-branch

Merge r210951. rdar://problem/29562247

10:09 Changeset [210969] by matthew_hanson@apple.com
  • 29 edits in branches/safari-603-branch

Merge r210949. rdar://problem/30108531

10:09 Changeset [210968] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r210947. rdar://problem/30108809

10:09 Changeset [210967] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Merge r210945. rdar://problem/28745101

09:59 Changeset [210966] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Mini Browser: Show tooltip for Experimental Features
https://bugs.webkit.org/show_bug.cgi?id=167225

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-01-20
Reviewed by Alex Christensen.

  • MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
Include the full details string as a tooltip.

09:50 Changeset [210965] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] Test output results should not be written twice.
https://bugs.webkit.org/show_bug.cgi?id=167197

Reviewed by Brent Fulgham.

Prevent test output from being written twice by returning early from
the dump() function, if it already has been called.
This patch also adds a missing newline to a test output line.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dump):

08:56 Changeset [210964] by matthew_hanson@apple.com
  • 19 edits
    2 copies
    2 adds in branches/safari-603-branch/Source

Merge r210936. rdar://problem/30058349

08:25 Changeset [210963] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebCore

Merge r210473. rdar://problem/29204422

08:25 Changeset [210962] by matthew_hanson@apple.com
  • 7 edits in branches/safari-603-branch/Source/WebKit2

Merge r210913. rdar://problem/30086738

08:25 Changeset [210961] by matthew_hanson@apple.com
  • 10 edits
    5 adds in branches/safari-603-branch

Merge r210939. rdar://problem/29885052

08:25 Changeset [210960] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r210935. rdar://problem/30101860

04:17 Changeset [210959] by graouts@webkit.org
  • 220 edits
    4 copies
    10 adds in trunk

[Modern Media Controls] Turn modern media controls on by default
https://bugs.webkit.org/show_bug.cgi?id=165668

Reviewed by Dean Jackson.

Source/WebCore:

Tests: media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html

media/modern-media-controls/pip-support/ipad/pip-support-enabled.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html

Fix an error which may be triggered prior to Sierra where we would assume the presentation
mode API was avaiable when it might not be, which caused a few tests to fail.

We also ensure that we always inject the UA styles for legacy media controls as otherwise
toggling from modern media controls to legacy media controls would not inject those styles.
To facilitate this we add a dedicated method for modern media controls styles in RenderTheme
that is only used in the case of modern media controls when the shadow root asks for the styles
to inject in the shadow root.

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::shadowRootCSSText):

  • Modules/modern-media-controls/media/pip-support.js:

(PiPSupport.prototype.syncControl):
(PiPSupport):

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::modernMediaControlsStyleSheet):

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::mediaControlsStyleSheet):
(WebCore::RenderThemeIOS::modernMediaControlsStyleSheet):

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsStyleSheet):
(WebCore::RenderThemeMac::modernMediaControlsStyleSheet):

Source/WebKit/mac:

Enabled modern media controls by default in WK1.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

Source/WebKit2:

Use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED as the default value for modern media controls, which is true.

  • Shared/WebPreferencesDefinitions.h:

Tools:

Enabled modern media controls by default in test runners.

  • DumpRenderTree/TestOptions.h:
  • WebKitTestRunner/TestOptions.h:

LayoutTests:

Turn modern media controls off for a majority of pre-existing tests that made assumptions on the implementation
of media controls.

For tests designed for modern media controls, we don't need to opt out since modern media controls are now on
by default, and we turn them back on since they were skipped. But we make these tests more resilient by:

  1. adding iPad-specific tests
  2. adding platform-agnostic ways to press an element, using either eventSender or uiController
  3. checking that elements that are sized asynchronously are indeed sized before making assumptions to that effect
  4. ensuring that we don't have additional scheduler.frameDidFire callbacks after we no longer need them
  • TestExpectations:
  • accessibility/mac/video-tag-hit-test.html:
  • accessibility/mac/video-volume-slider-accessibility.html:
  • accessibility/media-element.html:
  • accessibility/media-emits-object-replacement.html:
  • compositing/video/poster-expected.html:
  • compositing/video/poster.html:
  • fast/hidpi/video-controls-in-hidpi.html:
  • fast/layers/video-layer.html:
  • fullscreen/video-controls-drag.html:
  • fullscreen/video-controls-override.html:
  • fullscreen/video-controls-rtl.html:
  • fullscreen/video-controls-timeline.html:
  • http/tests/media/hls/video-controls-live-stream.html:
  • http/tests/media/hls/video-duration-accessibility.html:
  • http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html:
  • http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html:
  • http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html:
  • http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html:
  • media/accessibility-closed-captions-has-aria-owns.html:
  • media/adopt-node-crash.html:
  • media/airplay-autoplay.html:
  • media/audio-as-video-fullscreen.html:
  • media/audio-controls-do-not-fade-out.html:
  • media/audio-controls-rendering.html:
  • media/audio-controls-timeline-in-media-document.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-repaint.html:
  • media/click-placeholder-not-pausing.html:
  • media/click-volume-bar-not-pausing.html:
  • media/controls-after-reload.html:
  • media/controls-drag-timebar.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-strict.html:
  • media/controls-styling.html:
  • media/controls-without-preload.html:
  • media/controls/airplay-controls.html:
  • media/controls/airplay-picker.html:
  • media/controls/basic.html:
  • media/controls/elementOrder.html:
  • media/controls/forced-tracks-only.html:
  • media/controls/fullscreen-button-inline-layout.html:
  • media/controls/inline-elements-dropoff-order.html:
  • media/controls/picture-in-picture.html:
  • media/controls/pip-placeholder-without-video-controls.html:
  • media/controls/showControlsButton.html:
  • media/controls/statusDisplay.html:
  • media/controls/statusDisplayBad.html:
  • media/controls/track-menu.html:
  • media/mac/controls-panel-not-clipped-out-expected.html:
  • media/mac/controls-panel-not-clipped-out.html:
  • media/media-captions-no-controls.html:
  • media/media-controller-drag-crash.html:
  • media/media-controls-accessibility.html:
  • media/media-controls-cancel-events.html:
  • media/media-controls-clone.html:
  • media/media-controls-drag-timeline-set-controls-property.html:
  • media/media-controls-timeline-updates-after-playing.html:
  • media/media-controls-timeline-updates-when-hovered.html:
  • media/media-controls-timeline-updates.html:
  • media/media-document-audio-controls-visible.html:
  • media/media-document-audio-repaint.html:
  • media/media-fullscreen-return-to-inline.html:
  • media/modern-media-controls/airplay-button/airplay-button-on.html:
  • media/modern-media-controls/airplay-button/airplay-button.html:
  • media/modern-media-controls/airplay-placard/airplay-placard-text-section.html:
  • media/modern-media-controls/audio/audio-controls-buttons-expected.txt:
  • media/modern-media-controls/audio/audio-controls-buttons.html:
  • media/modern-media-controls/audio/audio-controls-metrics.html:
  • media/modern-media-controls/button/button.html:
  • media/modern-media-controls/buttons-container/buttons-container-buttons-property.html:
  • media/modern-media-controls/forward-button/forward-button.html:
  • media/modern-media-controls/fullscreen-button/fullscreen-button.html:
  • media/modern-media-controls/fullscreen-support/fullscreen-support-click.html:
  • media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap-expected.txt: Added.
  • media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html: Added.
  • media/modern-media-controls/icon-button/icon-button-active-state.html:
  • media/modern-media-controls/icon-button/icon-button-on.html:
  • media/modern-media-controls/icon-button/icon-button.html:
  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html:
  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-controls-bar-styles.html:
  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-layout.html:
  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-time-control-styles.html:
  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-dropping-controls.html:
  • media/modern-media-controls/layout-node/addChild.html:
  • media/modern-media-controls/layout-node/children.html:
  • media/modern-media-controls/layout-node/height.html:
  • media/modern-media-controls/layout-node/insertAfter.html:
  • media/modern-media-controls/layout-node/insertBefore.html:
  • media/modern-media-controls/layout-node/node-made-dirty-during-layout.html:
  • media/modern-media-controls/layout-node/remove.html:
  • media/modern-media-controls/layout-node/removeChild.html:
  • media/modern-media-controls/layout-node/subclassing.html:
  • media/modern-media-controls/layout-node/visible.html:
  • media/modern-media-controls/layout-node/width.html:
  • media/modern-media-controls/layout-node/x.html:
  • media/modern-media-controls/layout-node/y.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-right-container-margin.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-styles.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-controls-bar-styles.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-layout.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-status-label.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-time-control-styles.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-volume-styles.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-dropping-controls.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide.html:
  • media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html:
  • media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html:
  • media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html:
  • media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html:
  • media/modern-media-controls/media-controller/media-controller-resize.html:
  • media/modern-media-controls/media-controller/media-controller-scale-factor.html:
  • media/modern-media-controls/media-controller/media-controller-single-container.html:
  • media/modern-media-controls/mute-button/mute-button.html:
  • media/modern-media-controls/pip-button/pip-button.html:
  • media/modern-media-controls/pip-placard/pip-placard-text-section.html:
  • media/modern-media-controls/pip-support/ipad/pip-support-enabled-expected.txt: Added.
  • media/modern-media-controls/pip-support/ipad/pip-support-enabled.html: Copied from LayoutTests/media/modern-media-controls/pip-support/pip-support-enabled.html.
  • media/modern-media-controls/pip-support/ipad/pip-support-tap-expected.txt: Added.
  • media/modern-media-controls/pip-support/ipad/pip-support-tap.html: Copied from LayoutTests/media/modern-media-controls/pip-support/pip-support-click.html.
  • media/modern-media-controls/pip-support/pip-support-click.html:
  • media/modern-media-controls/pip-support/pip-support-enabled.html:
  • media/modern-media-controls/placard-support/ipad/placard-support-pip-expected.txt: Copied from LayoutTests/media/modern-media-controls/placard-support/placard-support-airplay-expected.txt.
  • media/modern-media-controls/placard-support/ipad/placard-support-pip.html: Added.
  • media/modern-media-controls/placard-support/placard-support-airplay-expected.txt:
  • media/modern-media-controls/play-pause-button/play-pause-button.html:
  • media/modern-media-controls/playback-support/playback-support-button-click-expected.txt:
  • media/modern-media-controls/playback-support/playback-support-button-click.html:
  • media/modern-media-controls/resources/media-controls-utils.js:

(pressOnElement):
(finishMediaControlsTest):

  • media/modern-media-controls/rewind-button/rewind-button.html:
  • media/modern-media-controls/scheduler/not-reentrant.html:
  • media/modern-media-controls/scheduler/single-callback-when-registered-multiple-times.html:
  • media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt: Copied from LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-drag-expected.txt.
  • media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html: Added.
  • media/modern-media-controls/scrubber-support/scrubber-support-click.html:
  • media/modern-media-controls/scrubber-support/scrubber-support-drag-expected.txt:
  • media/modern-media-controls/scrubber-support/scrubber-support-drag.html:
  • media/modern-media-controls/seek-backward-support/seek-backward-support.html:
  • media/modern-media-controls/seek-forward-support/seek-forward-support.html:
  • media/modern-media-controls/skip-back-button/skip-back-button.html:
  • media/modern-media-controls/slider/slider-fill.html:
  • media/modern-media-controls/slider/slider-styles.html:
  • media/modern-media-controls/start-support/start-support-click-to-start-expected.txt:
  • media/modern-media-controls/start-support/start-support-click-to-start.html:
  • media/modern-media-controls/status-label/status-label-font.html:
  • media/modern-media-controls/status-label/status-label-text-selection.html:
  • media/modern-media-controls/status-label/status-label.html:
  • media/modern-media-controls/time-label/time-label.html:
  • media/modern-media-controls/tracks-button/tracks-button.html:
  • media/modern-media-controls/tracks-panel/tracks-panel-right-x.html:
  • media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html:
  • media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
  • media/modern-media-controls/tracks-support/tracks-support-show-and-populate-panel.html:
  • media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt:
  • media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html:
  • media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html:
  • media/modern-media-controls/volume-slider/volume-slider-value.html:
  • media/modern-media-controls/volume-support/volume-support-click.html:
  • media/modern-media-controls/volume-support/volume-support-drag.html:
  • media/nodesFromRect-shadowContent.html:
  • media/progress-events-generated-correctly.html:
  • media/require-user-gesture-to-load-video.html:
  • media/tab-focus-inside-media-elements.html:
  • media/track/track-cue-rendering-horizontal.html:
  • media/track/track-cue-rendering-vertical.html:
  • media/track/track-cues-cuechange.html:
  • media/track/track-cues-enter-exit.html:
  • media/track/track-in-band-duplicate-tracks-when-source-changes.html:
  • media/track/track-manual-mode.html:
  • media/video-controls-audiotracks-trackmenu.html:
  • media/video-controls-captions-trackmenu-localized.html:
  • media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html:
  • media/video-controls-captions-trackmenu-sorted.html:
  • media/video-controls-captions-trackmenu.html:
  • media/video-controls-drop-and-restore-timeline.html:
  • media/video-controls-in-media-document.html:
  • media/video-controls-no-display-with-text-track.html:
  • media/video-controls-rendering.html:
  • media/video-controls-show-on-kb-or-ax-event.html:
  • media/video-controls-toggling.html:
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-visible-exiting-fullscreen.html:
  • media/video-controls-zoomed.html:
  • media/video-display-toggle.html:
  • media/video-empty-source.html:
  • media/video-fullscreeen-only-controls.html:
  • media/video-fullscreeen-only-playback.html:
  • media/video-initially-hidden-volume-slider-up.html:
  • media/video-no-audio.html:
  • media/video-play-audio-require-user-gesture.html:
  • media/video-play-require-user-gesture.html:
  • media/video-trackmenu-selection.html:
  • media/video-volume-slider-drag.html:
  • media/video-volume-slider.html:
  • media/video-zoom-controls.html:
  • media/volume-bar-empty-when-muted.html:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html:
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
03:43 Changeset [210958] by gskachkov@gmail.com
  • 8 edits in trunk

Super property access in base class constructor doesn't work
https://bugs.webkit.org/show_bug.cgi?id=166665

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Allow to use super inside of the constructor for classes
without parent class.
Parser checks if super used within the constructor and
add this information to function metedata, and later it is used
during byte code generation.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionInfo):

  • parser/Parser.h:

(JSC::Scope::usesEval):
(JSC::Scope::fillParametersForSourceProviderCache):
(JSC::Scope::restoreFromSourceProviderCache):
(JSC::Parser::adjustSuperBindingForBaseConstructor):

  • parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::SourceProviderCacheItem):

LayoutTests:

  • js/class-syntax-super-expected.txt:
  • js/script-tests/class-syntax-super.js:
01:28 Changeset [210957] by cdumez@apple.com
  • 4 edits in trunk/LayoutTests/imported/w3c

Re-sync innerText web-platform-tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=167229

Reviewed by Alex Christensen.

Re-sync innerText web-platform-tests from upstream 1a36aa52.

  • web-platform-tests/innerText/setter-expected.txt:
  • web-platform-tests/innerText/setter-tests.js:
  • web-platform-tests/innerText/setter.html:
00:11 Changeset [210956] by carlosgc@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-2.15.3

WebKitGTK+ 2.15.3

00:09 Changeset [210955] by carlosgc@webkit.org
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.15.3 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.15.3.

01/19/17:

22:55 Changeset [210954] by carlosgc@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Threaded Compositor] Initialize the threaded compositor with the current size
https://bugs.webkit.org/show_bug.cgi?id=167196

Reviewed by Žan Doberšek.

We are always creating the threaded compositor with an empty size and then a sizeDidChange always happen when
the backing store state changes. This is always happening because the threaded compositor is created before the
first backing store state, but if we wanted to create it later, for example to enter/leave AC mode on demand,
the threaded compositor will not have the viewport size unless the window is resized, or sizeDidChange is called
manually when entering AC mode. Creating the threaded compositor is sync and changing the size too, so it's
better to do both things at the same time using the same sync operation.

  • Shared/CoordinatedGraphics/SimpleViewportController.cpp:

(WebKit::SimpleViewportController::SimpleViewportController): Pass an initial size to the constructor.

  • Shared/CoordinatedGraphics/SimpleViewportController.h:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::create): Add viewportSize and scaleFactor construction parameters,
(WebKit::ThreadedCompositor::ThreadedCompositor): Ditto. Also mark as needs resize if the given size is not empty.

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
  • WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost): Initialize the threaded compositor
with an initial viewport size and scale factor.

22:42 Changeset [210953] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

measurement-sets API can incorrectly order points with OS version without commit time
https://bugs.webkit.org/show_bug.cgi?id=167227

Reviewed by Chris Dumez.

Ignore revision_order for the purpose of ordering data points in /api/measurement-sets.

These orderings are used in some UI (e.g A/B testing) to order OS build numbers which do not have a timestamp
associated with each "revision".

The baseline measurements made in our internal dashboard were using these ordering numbers before ordering
results with build time. Because those data points don't have an associated Webkit revisions, all data points
were ordered first by macOS's revision_order, then build time. Because v3 UI completely ignores revision_order
for the purpose of plotting data points, this resulted in some data points being plotted in a wrong order
with some lines going backwards in time.

This patch addresses this discrepancy by stop ordering data points with revision_order in the JSON API.

  • public/api/measurement-set.php:

(MeasurementSetFetcher::execute_query): Fixed the bug.

  • server-tests/api-measurement-set-tests.js: Added a test.
21:11 Changeset [210952] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Build fix after r210626. We need to clear Triggerable's static map in each iteration.

  • tools/sync-buildbot.js:

(syncLoop):

19:56 Changeset [210951] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION(r206156): Animated images are repeated one extra iteration than the value which is saved in the image file
https://bugs.webkit.org/show_bug.cgi?id=167174

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-01-19
Reviewed by Simon Fraser.

Source/WebCore:

Before r206156, BitmapImage::repetitionCount() used to return zero for
the case loopCount = 1, -1 for loopCount = Infinity and loopCount for
all other cases. Having repetitionCount() return zero for loopCount = 1
makes the condition if (++m_repetitionsComplete > repetitionCount())
break the animation loop after one iteration. But it was wrong for all
loopCount > 1. It was causing an extra iteration to be played for the
animated image. After r206156, BitmapImage::repetitionCount() returns
loopCount for all cases loopCount != Infinity. Keeping the same condition
causes the extra iteration to be played even for loopCount = 1.

Test: fast/images/animated-image-loop-count.html

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::internalStartAnimation):

LayoutTests:

  • fast/images/animated-image-loop-count-expected.html: Added.
  • fast/images/animated-image-loop-count.html: Added.
  • fast/images/resources/animated-red-green-blue-repeat-1.gif: Added.
  • fast/images/resources/animated-red-green-blue-repeat-2.gif: Added.

Ensure the animated image stops animating after loopCount iterations.

19:49 Changeset [210950] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Include SubtleCrypto test on experimental-features test page
https://bugs.webkit.org/show_bug.cgi?id=167226

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-01-19
Reviewed by Yusuke Suzuki.

  • experimental-features.html:

Add a test for SubtleCrypto and make the test resilient against exceptions.

19:23 Changeset [210949] by cdumez@apple.com
  • 29 edits in trunk

iterable<> should be enabled on WK1
https://bugs.webkit.org/show_bug.cgi?id=167221
<rdar://problem/30108531>

Reviewed by Youenn Fablet.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:

Source/WebCore:

  • Modules/fetch/FetchHeaders.idl:
  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::finishCreation):

  • bindings/scripts/test/TestNode.idl:
  • bindings/scripts/test/TestObj.idl:
  • css/FontFaceSet.idl:
  • dom/NodeList.idl:

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences setCustomElementsEnabled:]):
(-[WebPreferences DOMIteratorEnabled]): Deleted.
(-[WebPreferences setDOMIteratorEnabled:]): Deleted.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::setDOMIteratorEnabled): Deleted.
(WebPreferences::domIteratorEnabled): Deleted.

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setDOMIteratorEnabled): Deleted.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
18:52 Changeset [210948] by zalan@apple.com
  • 3 edits
    2 adds in trunk

Simple line layout: Extend coverage for justified content.
https://bugs.webkit.org/show_bug.cgi?id=167219
<rdar://problem/30108391>

Reviewed by Antti Koivisto.

Source/WebCore:

Add support for general punctuation characters (0x2010, 0x2027) and latin characters including Extended-B.

Test: fast/text/simple-line-layout-with-justified-punctuation.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseForFontAndText):

LayoutTests:

  • fast/text/simple-line-layout-with-justified-punctuation-expected.html: Added.
  • fast/text/simple-line-layout-with-justified-punctuation.html: Added.
18:38 Changeset [210947] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Structure::pin() needs to be called while holding a lock
https://bugs.webkit.org/show_bug.cgi?id=167220

Reviewed by Saam Barati.

Imagine this race: the mutator calls pin() and the collector calls visitChildren(),
on the same Structure at the same time. In trunk pin() does not require a lock to be
held and it doesn't grab any locks. Meanwhile visitChildren() grabs the lock, checks
if the structure is pinned, and if not, it removes it by overwriting with zero. Now
imagine how this plays out when pin() runs. Since pin() grabs no locks, it is
irrelevant that visitChildren() grabs any locks. So, visitChildren() might check if
the table is pinned before pin() pins it, and then clear the table after it was
already pinned.

The problem here is that pin() should be holding a lock. We could either make pin()
grab that lock by itself, or what this patch does is makes the caller grab the lock.
This is great because it means that sometimes we don't have to introduce any new
locking.

This fixes a materializePropertyTable() checkOffsetConsistency() crash that happens
very rarely, but I was able to get it to reproduce with run-webkit-tests and
aggressive GC settings.

  • runtime/ConcurrentJSLock.h:
  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyTable):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::pinForCaching):
(JSC::Structure::add):

  • runtime/Structure.h:
  • runtime/StructureInlines.h:

(JSC::Structure::checkOffsetConsistency):
(JSC::Structure::add):
(JSC::Structure::addPropertyWithoutTransition):

17:35 Changeset [210946] by achristensen@apple.com
  • 10 edits in trunk

Construct URLSearchParams from array or object
https://bugs.webkit.org/show_bug.cgi?id=166973

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/url/urlsearchparams-constructor-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

  • html/URLSearchParams.cpp:

(WebCore::URLSearchParams::URLSearchParams):
(WebCore::URLSearchParams::create):
(WebCore::URLSearchParams::get):
(WebCore::URLSearchParams::has):
(WebCore::URLSearchParams::sort):
(WebCore::URLSearchParams::set):
(WebCore::URLSearchParams::getAll):
(WebCore::URLSearchParams::remove):
(WebCore::URLSearchParams::Iterator::next):

  • html/URLSearchParams.h:

(WebCore::URLSearchParams::create):
(WebCore::URLSearchParams::pairs):
(WebCore::URLSearchParams::operator const Vector<std::pair<String, String>>&): Deleted.

  • html/URLSearchParams.idl:
  • platform/URLParser.cpp:

(WebCore::URLParser::serialize):

  • platform/URLParser.h:

Source/WebKit2:

  • NetworkProcess/capture/NetworkCaptureManager.cpp:

(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):
Change std::pair's first/second to WTF::KeyValuePair's key/value.

17:09 Changeset [210945] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

CRASH at WebCore::TrackListBase::remove
https://bugs.webkit.org/show_bug.cgi?id=167217

Reviewed by Brent Fulgham.

Source/WebCore:

Test: media/media-source/media-source-error-crash.html

In very specific conditions, a HTMLMediaElement backed by a MediaSource can try to remove
the same track from its track list twice. If there are two SourceBuffers attached to a
HTMLMediaElement, and one has not yet been initialized, when the second fails to parse an
appended buffer after receiving an initialization segment, the HTMLMediaElement will remove
all its tracks in mediaLoadingFailed(), then MediaSource object itself will attempt remove
the same track in removeSourceBuffer().

Solving this the safest way possible: bail early from TrackListBase if asked to remove a
track which the list does not contain.

  • html/track/TrackListBase.cpp:

(TrackListBase::remove):

LayoutTests:

  • media/media-source/media-source-error-crash-expected.txt: Added.
  • media/media-source/media-source-error-crash.html: Added.
16:56 Changeset [210944] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Ensure status server logs go to log file
https://bugs.webkit.org/show_bug.cgi?id=167210

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer.next_work_item): Change log level from debug to info in
order to facilitate deubgging issues.
(StatusServer.update_work_items): Same.

16:23 Changeset [210943] by aestes@apple.com
  • 6 edits
    1 copy
    1 add in trunk/Source

Source/WebCore:
[iOS] Move the PDF password view into its own class for reuse
https://bugs.webkit.org/show_bug.cgi?id=167192

Reviewed by Tim Horton.

  • English.lproj/Localizable.strings: Updated the failure alert strings to not be specific to PDFs.

Source/WebKit2:
[iOS] Move the PDF password view into its own class for possible reuse
https://bugs.webkit.org/show_bug.cgi?id=167192

Reviewed by Tim Horton.

  • UIProcess/ios/WKPDFView.h: Stopped conforming to UIDocumentPasswordViewDelegate.
  • UIProcess/ios/WKPDFView.mm: Changed _passwordView to a WKPasswordView.

(-[WKPDFView _passwordViewFrame]): Returns the frame to set on _passwordView.
(-[WKPDFView _updatePasswordEntryField]): Removed.
(-[WKPDFView _showPasswordEntryField]): Created a WKPasswordView, set a lambda on its
userDidEnterPassword property to do the work previously done in -_tryToUnlockWithPassword:,
and showed the password view.
(-[WKPDFView _keyboardDidShow:]): Moved to WKPasswordView.
(-[WKPDFView _hidePasswordEntryField]): Deleted. The userDidEnterPassword lambda now calls
-[WKPasswordView hide] when the document is unlocked.
(-[WKPDFView userDidEnterPassword:forPasswordView:]): Moved to WKPasswordView.
(-[WKPDFView didBeginEditingPassword:inView:]): Ditto.
(-[WKPDFView didEndEditingPassword:inView:]): Ditto.
(-[WKPDFView _didFailToUnlock]): Ditto.
(-[WKPDFView _tryToUnlockWithPassword:]): Moved into _passwordView's userDidEnterPassword lambda.

  • UIProcess/ios/WKPasswordView.h: Added.
  • UIProcess/ios/WKPasswordView.mm: Added.

(-[WKPasswordView initWithFrame:documentName:]): Created a UIDocumentPasswordView with
documentName, set self as its passwordDelegate, and added it as a subview.
(-[WKPasswordView layoutSubviews]): Updated _scrollView's contentSize if we are displaying
the view.
(-[WKPasswordView displayInContentView:]): Saved the scroll view's previous minimum/maximum
zoom scale and color, set new values for minimum/maximum zoom scale and color, and added
self as a subview of contentView.
(-[WKPasswordView hide]): Restored the saved minimum/maximum zoom scale and color on the
scroll view and removed self from its superview.
(-[WKPasswordView displayPasswordFailureAlert]): Displayed the alert previously shown by
-[WKPDFView _didFailToUnlock].
(-[WKPasswordView _keyboardDidShow:]): Moved from WKPDFView.
(-[WKPasswordView userDidEnterPassword:forPasswordView:]): Retained self and called the
_userDidEnterPassword block with the password.
(-[WKPasswordView didBeginEditingPassword:inView:]): Moved from WKPDFView.
(-[WKPasswordView didEndEditingPassword:inView:]): Ditto.

  • WebKit2.xcodeproj/project.pbxproj:
15:43 Changeset [210942] by achristensen@apple.com
  • 11208 adds in trunk/Source/ThirdParty/libwebrtc

Source/ThirdParty/libwebrtc:
[WebRTC] Upload libwebrtc code base
https://bugs.webkit.org/show_bug.cgi?id=167205

Patch by Youenn Fablet <youenn@apple.com> on 2017-01-19
Reviewed by Alex Christensen and Jon Lee.

Add initial libwebrtc source from branch 56. Here's how to get what we committed:
git clone https://chromium.googlesource.com/external/webrtc.git && cd webrtc && git checkout 7bf536976366443ea59153ff3d22da0ec32badc1

Source/ThirdParty/libwebrtc/Source/third_party/opus/src:

15:30 Changeset [210941] by megan_gardner@apple.com
  • 3 edits
    6 adds in trunk

Additional selection tests and interpolation fix
https://bugs.webkit.org/show_bug.cgi?id=167171

Reviewed by Simon Fraser.

Tools:

We weren't adding the final event when interpolating event streams.

  • WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator interpolatedEvents:]):

LayoutTests:

Selections tests for dragging left and right.
Factored out common functions used across tests.

  • fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text-expected.txt: Added.
  • fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html: Added.
  • fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text-expected.txt: Added.
  • fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html: Added.
  • fast/events/touch/ios/resources: Added.
  • fast/events/touch/ios/resources/basic-gestures.js: Added.

(pressAtPoint):
(dragFromPointToPoint):

15:09 Changeset [210940] by jmarcell@apple.com
  • 5 edits in trunk/Source

Versioning.

15:04 Changeset [210939] by cdumez@apple.com
  • 10 edits
    5 adds in trunk

Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
https://bugs.webkit.org/show_bug.cgi?id=167215
<rdar://problem/29885052>

Reviewed by Andreas Kling.

Source/WebCore:

Make sure HTML validation bubble gets dismissed when its associated
element's frame gets detached and that we do not crash.

Tests: fast/forms/validation-message-detached-iframe.html

fast/forms/validation-message-detached-iframe2.html

  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction):

  • page/ValidationMessageClient.h:

Source/WebKit/mac:

Make sure HTML validation bubble gets dismissed when its associated
element's frame gets detached and that we do not crash.

  • WebCoreSupport/WebValidationMessageClient.h:
  • WebCoreSupport/WebValidationMessageClient.mm:

(WebValidationMessageClient::documentDetached):

Source/WebKit2:

Make sure HTML validation bubble gets dismissed when its associated
element's frame gets detached and that we do not crash.

  • WebProcess/WebCoreSupport/WebValidationMessageClient.cpp:

(WebKit::WebValidationMessageClient::documentDetached):

  • WebProcess/WebCoreSupport/WebValidationMessageClient.h:

LayoutTests:

Add layout test coverage.

  • fast/forms/resources/form-validation-iframe.html: Added.
  • fast/forms/validation-message-detached-iframe-expected.txt: Added.
  • fast/forms/validation-message-detached-iframe.html: Added.
  • fast/forms/validation-message-detached-iframe2-expected.txt: Added.
  • fast/forms/validation-message-detached-iframe2.html: Added.
14:58 Changeset [210938] by rniwa@webkit.org
  • 6 edits
    1 add in trunk/Websites/perf.webkit.org

Add a mechanism to dispatch and listen to an action
https://bugs.webkit.org/show_bug.cgi?id=167191

Reviewed by Antti Koivisto.

Added the notion of an action to components. Like DOM events, it can be dispatched or listen to.

Also added ComponentBase.prototype.part which finds a sub-component inside a component's shadow tree,
and made ComponentBase.prototype.content take an id to find an element that matches it.

  • browser-tests/close-button-tests.js: Added. Tests for CloseButton.
  • browser-tests/component-base-tests.js: Added tests for ComponentBase's part(~), content(id), dispatchEvent.
  • browser-tests/index.html:
  • public/v3/components/base.js:

(ComponentBase): Added this._actionCallbacks, which is a map of an action name to a callback to be invoked.
(ComponentBase.prototype.content): Return an element of the given id if one is specified.
(ComponentBase.prototype.part): Find a component whose element has the matching id.
(ComponentBase.prototype.dispatchAction): Added.
(ComponentBase.prototype.listenToAction): Added.
(ComponentBase.prototype._ensureShadowTree): Call didConstructShadowTree.
(ComponentBase.prototype.didConstructShadowTree): Added.
(ComponentBase.prototype._recursivelyReplaceUnknownElementsByComponents): Copy attributes when instantiating
an element for a component when the browser doesn't support custom elements API.
(ComponentBase.createLink):
(ComponentBase.prototype.createEventHandler): Added.
(ComponentBase.createEventHandler): Renamed from createActionHandler.

  • public/v3/components/button-base.js:

(ButtonBase.prototype.didConstructShadowTree): Added. Dispatch "activate" action when the button is clicked.
(ButtonBase.prototype.setCallback): Deleted.
(ButtonBase.htmlTemplate): Use id instead of class so that this.content() can find it.
(ButtonBase.cssTemplate): Updated style rules.

  • public/v3/pages/chart-pane.js:

(ChartPane):
(ChartPane.prototype.didConstructShadowTree): Added. Listen to "activate" action on the close button.
(ChartPane.prototype.render): Fixed a bug that we were never calling enqueueToRender on the close button.
(ChartPane.htmlTemplate): Add the id on the close button.

13:35 Changeset [210937] by ryanhaddad@apple.com
  • 2 edits in trunk/LayoutTests

Skipping three crashing pointer lock tests.
https://bugs.webkit.org/show_bug.cgi?id=166765

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
13:33 Changeset [210936] by cdumez@apple.com
  • 19 edits
    2 copies
    2 adds in trunk/Source

Implement per activity state CPU usage reporting using diagnostic logging
https://bugs.webkit.org/show_bug.cgi?id=167163
<rdar://problem/30058349>

Reviewed by Andreas Kling.

Implement per activity state CPU usage reporting using diagnostic logging.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • page/ActivityState.h:
  • page/ChromeClient.h:
  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::nonVisibleStateKey):
(WebCore::DiagnosticLoggingKeys::visibleNonActiveStateKey):
(WebCore::DiagnosticLoggingKeys::visibleAndActiveStateKey):
(WebCore::DiagnosticLoggingKeys::foregroundCPUUsageToDiagnosticLogginKey):
(WebCore::DiagnosticLoggingKeys::backgroundCPUUsageToDiagnosticLogginKey):

  • page/DiagnosticLoggingKeys.h:
  • page/Page.cpp:

(WebCore::isUtilityPageChromeClient):
(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::didStartProvisionalLoad):
(WebCore::Page::didFinishLoad):
(WebCore::Page::isUtilityPage):
(WebCore::Page::setActivityState):
(WebCore::Page::setIsVisibleInternal):

  • page/Page.h:

(WebCore::Page::activityState):
(WebCore::Page::isUtilityPage):

  • page/PerformanceMonitor.cpp: Added.

(WebCore::activityStateForCPUSampling):
(WebCore::PerformanceMonitor::PerformanceMonitor):
(WebCore::PerformanceMonitor::didStartProvisionalLoad):
(WebCore::PerformanceMonitor::didFinishLoad):
(WebCore::PerformanceMonitor::activityStateChanged):
(WebCore::PerformanceMonitor::measurePostLoadCPUUsage):
(WebCore::PerformanceMonitor::measurePostBackgroundingCPUUsage):
(WebCore::PerformanceMonitor::measurePerActivityStateCPUUsage):
(WebCore::stringForCPUSamplingActivityState):
(WebCore::PerformanceMonitor::measureCPUUsageInActivityState):

  • page/PerformanceMonitor.h: Copied from Source/WebCore/page/ActivityState.h.
  • page/Settings.cpp:
  • page/Settings.h:

(WebCore::Settings::isPostLoadCPUUsageMeasurementEnabled):
(WebCore::Settings::isPostBackgroundingCPUUsageMeasurementEnabled):
(WebCore::Settings::isPerActivityStateCPUUsageMeasurementEnabled):

Source/WebKit2:

  • Platform/Logging.h:
  • UIProcess/PerActivityStateCPUUsageSampler.cpp: Added.

(WebKit::PerActivityStateCPUUsageSampler::PerActivityStateCPUUsageSampler):
(WebKit::PerActivityStateCPUUsageSampler::~PerActivityStateCPUUsageSampler):
(WebKit::PerActivityStateCPUUsageSampler::reportWebContentCPUTime):
(WebKit::loggingKeyForActivityState):
(WebKit::loggingKeyForCPUUsage):
(WebKit::PerActivityStateCPUUsageSampler::loggingTimerFired):
(WebKit::PerActivityStateCPUUsageSampler::pageForLogging):

  • UIProcess/PerActivityStateCPUUsageSampler.h: Copied from Source/WebCore/page/ActivityState.h.
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::reportWebContentCPUTime):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessPool.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::reportProcessCPUTime):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
12:53 Changeset [210935] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

The mutator needs to fire a barrier after memmoving stuff around in an object that the GC scans
https://bugs.webkit.org/show_bug.cgi?id=167208

Reviewed by Saam Barati.

It used to be that if you moved a value from one place to another in the same object
then there is no need for a barrier because the generational GC would have no need to
know that some old object still continues to refer to the same other old object.

But the concurrent GC might scan that object as the mutator moves pointers around in
it. If the ordering is right, this could mean that the collector never sees some of
those pointers. This can be fixed by adding a barrier.

This fixes the most obvious cases I found. There may be more and I'll continue to
audit. Most of the other memmove users seem to already use some kind of synchronization
to prevent this. For example, this can also be fixed by just holding the cell lock
around the memmove since we're dealing with indexing storage and the GC reads that
under the cell lock.

  • runtime/JSArray.cpp:

(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):

12:21 Changeset [210934] by timothy@hatcher.name
  • 2 edits in trunk/Websites/webkit.org

Add Tesla to the domain associations on the team page
https://bugs.webkit.org/show_bug.cgi?id=167202

Reviewed by Brian Burg.

  • wp-content/themes/webkit/team.php:
11:25 Changeset [210933] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

Rubber-stamped by Anders Carlsson.

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toPKPaymentAuthorizationStatus): Suppressed deprecation warnings.

11:24 Changeset [210932] by mmaxfield@apple.com
  • 10 edits in trunk

[Cocoa] Variation fonts are erroneously disabled on iOS
https://bugs.webkit.org/show_bug.cgi?id=167172

Reviewed by Simon Fraser.

OpenSource builders don't seem to understand sdk=embedded*.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
11:16 Changeset [210931] by timothy@hatcher.name
  • 2 edits in trunk/Websites/bugs.webkit.org

Bugzilla email autocomplete does not work on third email field of advanced search page
https://bugs.webkit.org/show_bug.cgi?id=167204

Reviewed by Alexey Proskuryakov.

  • committers-autocomplete.js: Added email3 to SINGLE_EMAIL_INPUTS list.
10:31 Changeset [210930] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab's "Clear Network Items" button should have keyboard shortcuts
https://bugs.webkit.org/show_bug.cgi?id=166943

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-01-19
Reviewed by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector._clear):
Move clear keyboard shortcut to main object and call _handleClearShortcut on the visible
content view if able.

  • UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController):
(WebInspector.JavaScriptLogViewController.prototype.requestClearMessages):
(WebInspector.JavaScriptLogViewController.prototype._handleClearShortcut): Deleted.

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype.handleClearShortcut):
Move logic for requesting to clear messages from the LogManager to a better named function.

  • UserInterface/Views/NetworkGridContentView.js:

(WebInspector.NetworkGridContentView):
(WebInspector.NetworkGridContentView.prototype.handleClearShortcut):

10:20 Changeset [210929] by andersca@apple.com
  • 2 edits
    1 add in trunk/Source/WebKit2

Install WebKit.apinotes with the public headers of WebKit framework
https://bugs.webkit.org/show_bug.cgi?id=167182
rdar://problem/29008989

Reviewed by Sam Weinig.

  • Shared/API/Cocoa/WebKit.apinotes: Added.
  • WebKit2.xcodeproj/project.pbxproj:
09:59 Changeset [210928] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Dashboard's log/error/warning help tag says "click to show the Console" even when clicking does nothing
https://bugs.webkit.org/show_bug.cgi?id=167102

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-01-19
Reviewed by Brian Burg.

  • UserInterface/Base/Main.js:

(WebInspector.showConsoleTab):
Don't revert to the All scopes if the requested scope is already selected.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/DefaultDashboardView.js:

(WebInspector.DefaultDashboardView):
(WebInspector.DefaultDashboardView.prototype._appendElementForNamedItem):
(WebInspector.DefaultDashboardView.prototype._setItemEnabled):
Only apply a title to the element when it is enabled.

09:52 Changeset [210927] by bburg@apple.com
  • 6 edits
    1 move
    4 adds in trunk/Source/WebKit2

Web Inspector: move Mac-specific automation commands to a separate implementation file
https://bugs.webkit.org/show_bug.cgi?id=163297
<rdar://problem/28718990>

Reviewed by Timothy Hatcher.

Not all Automation commands are available on all platforms. Start splitting out
command declarations and implementations based on the target platform.

  • DerivedSources.make:

Set an appropriate --platform so the correct backend interface is generated.

  • UIProcess/Automation/Automation.json:

Guard commands that should not be available on iOS:

  • resizeWindowOfBrowsingContext
  • moveWindowOfBrowsingContext
  • inspectBrowsingContext
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::platformSimulateKeySequence): Deleted.

  • Move shared convenience macros to header file.
  • Move out Cocoa-only or Mac-only command implementations.
  • UIProcess/Automation/WebAutomationSession.h:

Rearrange some declarations and switch from USE(APPKIT) to PLATFORM(MAC).

  • UIProcess/Automation/WebAutomationSessionMacros.h: Added.
  • UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm: Added.

(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):
Moved from WebAutomationSessionCocoa.mm. Add iOS-specific header includes.

  • UIProcess/Automation/mac/WebAutomationSessionMac.mm: Renamed from Source/WebKit2/UIProcess/Cocoa/WebAutomationSessionCocoa.mm.

(WebKit::WebAutomationSession::resizeWindowOfBrowsingContext):
(WebKit::WebAutomationSession::moveWindowOfBrowsingContext):
(WebKit::WebAutomationSession::inspectBrowsingContext):
Move macOS platform command implementations to here. If other desktop ports want
to use these commands, we can move them somewhere else later.

(WebKit::WebAutomationSession::sendSynthesizedEventsToPage):
(WebKit::WebAutomationSession::markEventAsSynthesizedForAutomation):
(WebKit::WebAutomationSession::wasEventSynthesizedForAutomation):
Move out AppKit-specific event simulation code to here.

(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
(WebKit::WebAutomationSession::platformSimulateKeyStroke):
(WebKit::WebAutomationSession::platformSimulateKeySequence):
Move out Mac platformFoo implementations to here.

  • WebKit2.xcodeproj/project.pbxproj:
  • Added UIProcess/Automation/{mac,cocoa} groups.
  • Add new platform-specific implementation files.
09:28 Changeset [210926] by ryanhaddad@apple.com
  • 2 edits in trunk/Source/WebCore

Rebaseline bindings tests after r210918.

Unreviewed test gardening.

  • bindings/scripts/test/JS/JSTestObj.cpp:
09:10 Changeset [210925] by gskachkov@gmail.com
  • 5 edits in trunk

"this" missing after await in async arrow function
https://bugs.webkit.org/show_bug.cgi?id=166919

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch fixed issue in async arrow function. Issue appears because in arrow
function _this_ is loaded from arrow function virtual scope.
Async arrow function can be suspended and when resuming should be used _this_ from
virtual scope, to allow this we load _this_ from virtual scope before store it to
generator.generatorThis property

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

JSTests:

  • stress/async-arrow-functions-lexical-binding-in-class.js:

(ChildClass.prototype.asyncThisPropWithAwaitBody):
(ChildClass.prototype.asyncThisPropInEvalWithAwaitBody):
(ChildClass.prototype.asyncThisValueBodyWithAwait):
(ChildClass.prototype.asyncThisValueInEvalWithAwaitBody):
(ChildClass):
(ChildClass3):
(ChildClass3.prototype.classValue):
(ChildClass3.prototype.get classProperty):

  • stress/async-arrow-functions-lexical-new.target-binding.js:

(C2WithAwait):

08:56 Changeset [210924] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.4

New tag.

07:56 Changeset [210923] by akling@apple.com
  • 28 edits in trunk/Source

ScriptExecutionContext::topOrigin() should return a reference.
<https://webkit.org/b/167190>

Reviewed by Sam Weinig.

Source/WebCore:

There is always a topOrigin() SecurityOrigin, so make it return a reference
and remove some unnecessary null-checks exposed by this change.

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::canCallApplePaySessionAPIs):

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::getSupportedConfiguration):
(WebCore::CDM::getConsentStatus):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

  • Modules/mediastream/MediaDevicesEnumerationRequest.cpp:

(WebCore::MediaDevicesEnumerationRequest::topLevelDocumentOrigin):

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::topLevelDocumentOrigin):
(WebCore::canCallGetUserMedia):

  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResource):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
(WebCore::ApplicationCacheGroup::update):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setDomainForCachePartition):

  • page/SecurityOrigin.h:

(WebCore::SecurityOrigin::canAccessDatabase):
(WebCore::SecurityOrigin::canAccessSessionStorage):
(WebCore::SecurityOrigin::canAccessPluginStorage):
(WebCore::SecurityOrigin::canAccessApplicationCache):

  • storage/StorageNamespaceProvider.cpp:

(WebCore::StorageNamespaceProvider::localStorageArea):

  • testing/Internals.cpp:

(WebCore::Internals::isLoadingFromMemoryCache):

  • workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):

  • workers/DedicatedWorkerGlobalScope.h:
  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):

  • workers/DedicatedWorkerThread.h:
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

  • workers/WorkerGlobalScope.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):

  • workers/WorkerThread.h:

Source/WebKit/mac:

  • Misc/WebCache.mm:

(+[WebCache addImageToCache:forURL:forFrame:]):
(+[WebCache removeImageFromCacheForURL:forFrame:]):

03:50 Changeset [210922] by carlosgc@webkit.org
  • 3 edits
    3 adds in trunk/Tools

Unreviewed. Fix GTK+ unit tests failing since r210531.

Avoid using paths to files that don't actually exist.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:

(testWebKitConsoleMessageNetworkError):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(testContextMenuDefaultMenu):

  • TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
  • TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
  • TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
01:03 Changeset [210921] by carlosgc@webkit.org
  • 30 edits
    1 copy
    3 adds in trunk

[GTK] Provide API to set proxy settings
https://bugs.webkit.org/show_bug.cgi?id=128674

Reviewed by Michael Catanzaro.

Source/WebCore:

Add SoupNetworkProxySettings struct to store proxy settings.

  • platform/network/soup/SoupNetworkProxySettings.h: Added.

(WebCore::SoupNetworkProxySettings::SoupNetworkProxySettings):
(WebCore::SoupNetworkProxySettings::operator=):
(WebCore::SoupNetworkProxySettings::isEmpty):

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession): Setup the proxy if user provided proxy settings.
(WebCore::SoupNetworkSession::setupProxy): Set the proxy-resolver property of the SoupSession according to the
global SoupNetworkProxySettings.
(WebCore::SoupNetworkSession::setProxySettingsFromEnvironment): Update the global SoupNetworkProxySettings with
values from environment.
(WebCore::SoupNetworkSession::setProxySettings): Set the global SoupNetworkProxySettings.

  • platform/network/soup/SoupNetworkSession.h:

Source/WebKit2:

Add new method webkit_web_context_set_network_proxy_settings() that allows to set proxy settings in a
WebKitWebContext. It receives an enum WebKitNetworkProxyMode with modes Default, NoProxy and Custom, and an
optional WebKitNetworkProxySettings that is used when mode is Custom. WebKitNetworkProxySettings is a simple
boxed type that user can create to set proxy settins with a similar API to GSimpleProxyResolver.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in: Add SetNetworkProxySettings message.
  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode): Encode proxy settings.
(WebKit::NetworkProcessCreationParameters::decode): Decode proxy settings.

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/efl/NetworkProcessMainEfl.cpp: Use SoupNetworkSession::setProxySettingsFromEnvironment().
  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Set proxy settings if provided by the user.
(WebKit::NetworkProcess::setNetworkProxySettings): Set global proxy settings and setup the proxy for all
existing contexts.

  • PlatformGTK.cmake: Add new files to compilation.
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Encode proxy settings.
(WebKit::WebProcessCreationParameters::decode): Decode proxy settings.

  • Shared/WebProcessCreationParameters.h:
  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<SoupNetworkProxySettings>::encode): Add encoder implementation for SoupNetworkProxySettings.
(IPC::ArgumentCoder<SoupNetworkProxySettings>::decode): add decoder implementation for SoupNetworkProxySettings.

  • UIProcess/API/gtk/WebKitNetworkProxySettings.cpp: Added.

(_WebKitNetworkProxySettings::_WebKitNetworkProxySettings):
(webkitNetworkProxySettingsGetNetworkProxySettings):
(webkit_network_proxy_settings_new): Create a new WebKitNetworkProxySettings with optional default proxy uri and
ignore hosts list.
(webkit_network_proxy_settings_copy):
(webkit_network_proxy_settings_free):
(webkit_network_proxy_settings_add_proxy): Add a proxy uri for a given uri scheme.

  • UIProcess/API/gtk/WebKitNetworkProxySettings.h: Added.
  • UIProcess/API/gtk/WebKitNetworkProxySettingsPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_network_proxy_settings): Set proxy settings.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols to the documentation.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for WebKitNetworkProxySettings.
  • UIProcess/API/gtk/webkit2.h: Include WebKitNetworkProxySettings.h.
  • UIProcess/WebProcessPool.h: Add m_networkProxySettings and a setter for soup.
  • UIProcess/efl/WebProcessPoolEfl.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess): Set m_networkProxySettings to parameters.

  • UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess): Ditto.

  • UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess): Ditto.
(WebKit::WebProcessPool::setNetworkProxySettings): Update m_networkProxySettings and notify all processes.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add SetNetworkProxySettings message.
  • WebProcess/efl/WebProcessMainEfl.cpp: Use SoupNetworkSession::setProxySettingsFromEnvironment().
  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformSetCacheModel): Remove comment that is no longer true.
(WebKit::WebProcess::platformInitializeWebProcess): Set proxy settings if provided by the user.
(WebKit::WebProcess::setNetworkProxySettings): Set global proxy settings and setup the proxy for all
existing contexts.

Tools:

Add tests for new proxy settings API.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(serverCallback):
(ProxyTest::ProxyTest):
(ProxyTest::~ProxyTest):
(ProxyTest::loadURIAndGetMainResourceData):
(ProxyTest::proxyServerPortAsString):
(testWebContextProxySettings):
(beforeAll):

00:59 Changeset [210920] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Do not update the backing store state unnecessarily when page visibility changes
https://bugs.webkit.org/show_bug.cgi?id=167195

Reviewed by Sergio Villar Senin.

I've noticed that we are receiving UpdateBackingStoreState messages in the web process even when size and scale
factor didn't change. That's quite unfortunate because we do a lot of work unnecessarily and we tell the
threaded compositor that the size changed. This is not only a problem because it's not true, but also because
changing the size is a sync operation in the threaded compositor, so we block the compositing thread for
nothing. This is happening because the WebPageProxy notifies the drawing area that the backing store is
discardable when the page is not visible, and that always produces a new backing store state. In accelerating
compositing mode we don't even have a backing store to discard, so we should check we have something to discard
and also make sure we only generate a new backing store state if we really discarded the backing store.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
(WebKit::DrawingAreaProxyImpl::discardBackingStore):

00:40 Changeset [210919] by utatane.tea@gmail.com
  • 3 edits in trunk/Source/JavaScriptCore

[B3] B3 strength reduction could encounter Value without owner in PureCSE
https://bugs.webkit.org/show_bug.cgi?id=167161

Reviewed by Filip Pizlo.

PureCSE relies on the fact that all the stored Values have owner member.
This assumption is broken when you execute specializeSelect in B3ReduceStrength phase.
It clears owner of Values which are in between Select and Check to clone them to then/else
blocks. If these cleared Values are already stored in PureCSE map, this map poses a Value
with nullptr owner in PureCSE.

This patch changes PureCSE to ignore stored Values tha have nullptr owner. This even means
that a client of PureCSE could deliberately null the owner if they wanted to signal the
Value should be ignored.

While PureCSE ignores chance for optimization if Value's owner is nullptr, in the current
strength reduction algorithm, this does not hurt optimization because CSE will be eventually
applied since the strength reduction phase want to reach fixed point. But even without
this iterations, our result itself is valid since PureCSE is allowed to be conservative.

  • b3/B3PureCSE.cpp:

(JSC::B3::PureCSE::findMatch):
(JSC::B3::PureCSE::process):

  • b3/testb3.cpp:

(JSC::B3::testCheckSelectAndCSE):
(JSC::B3::run):

00:21 Changeset [210918] by achristensen@apple.com
  • 11 edits in trunk

[WebIDL] Records should preserve javascript object order
https://bugs.webkit.org/show_bug.cgi?id=167189

Patch by Sam Weinig <sam@webkit.org> on 2017-01-18
Reviewed by Alex Christensen.

Source/WebCore:

Instead of modeling IDL records as HashMaps, use a Vector
of KeyValuePairs, to all preserving the iteration order.

  • Modules/webdatabase/SQLResultSetRowList.cpp:

(WebCore::SQLResultSetRowList::item):

  • Modules/webdatabase/SQLResultSetRowList.h:

Return a Vector rather than a HashMap.

  • bindings/IDLTypes.h:

Change underlying type to be a Vector<KeyValuePair<K, V>>.

  • bindings/js/JSDOMConvert.h:

Update conversion for new implementation type. For conversion
to JSValue, allow any type that can has an iterator of keyValuePairs.

  • testing/TypeConversions.h:

(WebCore::TypeConversions::testLongRecord):
(WebCore::TypeConversions::setTestLongRecord):
(WebCore::TypeConversions::testNodeRecord):
(WebCore::TypeConversions::setTestNodeRecord):
(WebCore::TypeConversions::testSequenceRecord):
(WebCore::TypeConversions::setTestSequenceRecord):

  • testing/TypeConversions.idl:

Update test IDL to use functions, since the spec mandates that
records can't be used with attributes.

LayoutTests:

  • js/dom/webidl-type-mapping-expected.txt:
  • js/dom/webidl-type-mapping.html:

Update test to reflect changes to TypeConversions.idl

00:08 Changeset [210917] by timothy@apple.com
  • 2 edits in trunk/Tools

Add back my old email address so old commits will still match it.

Patch by Timothy Hatcher <timothy@hatcher.name> on 2017-01-19

  • Scripts/webkitpy/common/config/contributors.json:
00:04 Changeset [210916] by timothy@apple.com
  • 4 edits in trunk/Tools

Remove my old email address from contributors.json and watchlist.

Patch by Timothy Hatcher <timothy@hatcher.name> on 2017-01-19

  • Scripts/validate-committer-lists:

(CommitterListFromGit): Change the mapping to the correct email.

  • Scripts/webkitpy/common/config/contributors.json:
  • Scripts/webkitpy/common/config/watchlist:
Note: See TracTimeline for information about the timeline view.