Timeline



Oct 31, 2020: Today

12:06 PM Changeset in webkit [269228] by Simon Fraser
  • 19 edits in trunk/Source

Clean up BoxSide and BorderEdge code
https://bugs.webkit.org/show_bug.cgi?id=218197

Reviewed by Sam Weinig.

Source/WebCore:

Change border-drawing functions in RenderBoxModelObject which took BorderEdge[] to
use RectEdges<BorderEdge>. In addition, make BoxSide an enum class, and remove the redundant
PhysicalBoxSide. Also make BorderEdgeFlags an OptionSet<>.

I renamed PhysicalBoxSide to BoxSide because "physical" is a loaded term (it could mean
either locally top/right/bottom/left, or refer to absolute "physical coordinates").
This allowed BoxSide to be used in RectEdges, therefore making RectEdges<BorderEdge>
the right way to represent the set of edges for a box.

An equivalent set of bit flags, BoxSideFlag, allows use in an OptionSet<>.

Use more enumeration of sides in the border painting code.

  • page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::rootMargin const):

  • platform/RectEdges.h:

(WebCore::RectEdges::at):
(WebCore::RectEdges::top):
(WebCore::RectEdges::right):
(WebCore::RectEdges::bottom):
(WebCore::RectEdges::left):
(WebCore::RectEdges::at const):
(WebCore::RectEdges::top const):
(WebCore::RectEdges::right const):
(WebCore::RectEdges::bottom const):
(WebCore::RectEdges::left const):
(WebCore::RectEdges::setAt):
(WebCore::RectEdges::setTop):
(WebCore::RectEdges::setRight):
(WebCore::RectEdges::setBottom):
(WebCore::RectEdges::setLeft):

  • platform/text/WritingMode.h:

(WebCore::isHorizontalPhysicalSide):
(WebCore::mirrorPhysicalSide):
(WebCore::rotatePhysicalSide):
(WebCore::mapLogicalSideToPhysicalSide):

  • rendering/BorderEdge.cpp:

(WebCore::borderEdges):
(WebCore::BorderEdge::getBorderEdgeInfo): Deleted.

  • rendering/BorderEdge.h:

(WebCore::edgeFlagForSide):
(WebCore::includesEdge):
(WebCore::includesAdjacentEdges):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::borderWillArcInnerEdge):
(WebCore::borderStyleHasUnmatchedColorsAtCorner):
(WebCore::colorsMatchAtCorner):
(WebCore::colorNeedsAntiAliasAtCorner):
(WebCore::willBeOverdrawn):
(WebCore::joinRequiresMitre):
(WebCore::calculateAdjustedInnerBorder):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::calculateSideRect):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::RenderBoxModelObject::borderObscuresBackgroundEdge const):
(WebCore::RenderBoxModelObject::borderObscuresBackground const):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::drawLineForBoxSide const):
(WebCore::RenderElement::paintOutline):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::paintColumnRules):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::calculateBorderStyleColor):

  • rendering/RenderObjectEnums.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintCollapsedBorders):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::offsetTopForRowGroupBorder):
(WebCore::RenderTableSection::paintRowGroupBorderIfRequired):
(WebCore::physicalBorderForDirection):

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):

  • rendering/style/NinePieceImage.h:

(WebCore::imagePieceHorizontalSide):
(WebCore::imagePieceVerticalSide):

Source/WebKit:

  • UIProcess/ios/WKKeyboardScrollingAnimator.mm:

(boxSide):

9:11 AM Changeset in webkit [269227] by Chris Dumez
  • 21 edits
    7 adds in trunk

Promises returned by our DOM API have the caller's global instead of the callee's
https://bugs.webkit.org/show_bug.cgi?id=218363

Reviewed by Darin Adler and Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/range/sw.https.window.js:

Re-import latest version of the test from upstream. Without those upstream changes, there would be a testharness error
when running this test.

  • web-platform-tests/html/cross-origin-embedder-policy/coep-on-response-from-service-worker.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/controller-with-no-fetch-event-handler.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/fetch-event-redirect.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/fetch-request-resources.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/fetch-response-taint.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/redirected-response.https-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/promise-methods-after-discard-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/startrendering-after-discard-expected.txt:

Rebaseline WPT tests that are now passing.

Source/WebCore:

Promises returned by our DOM APIs were using the caller's global instead of the
callee's global. This behavior was inconsistent with Chrome and Firefox, and was
causing failures in web-platform-tests. Because the global of the promise was
wrong, the global of the values passed when settling the promise (e.g. the global
of the exception used to reject a promise) was also wrong. This patch fixes this.

After fixing the global of DOM promises, some tests started failing because they
expect the promises coming from subframes to still get settled *after* their
iframe has been removed from the document. Such promises get settled properly
in Firefox and Chrome. They also used to settle properly in WebKit because we
were incorrectly using the caller's global. The issue was that after an iframe
gets detached, Document::stopActiveDOMObjects() would get called, which would
stop the EventLoopTaskGroup associated with the document and clear all pending
tasks from this group in the event loop. To address this, when a
Document::stopActiveDOMObjects(), we now mark the Document's EventLoopTaskGroup
as "ready to stop" instead of stopping it. Only once ALL groups in the EventLoop
are ready to stop, do we actually stop all those groups. This is important
because each document has its own group but all documents of similar origins
share the same EventLoop.

Tests: fast/js-promise-from-detached-iframe.html

http/tests/eventloop/promise-from-cross-origin-detached-iframe.html
webaudio/promise-global-object.html

  • bindings/js/JSDOMPromiseDeferred.h:

(WebCore::DeferredPromise::shouldIgnoreRequestToFulfill const):
(WebCore::callPromiseFunction):

  • dom/Document.cpp:

(WebCore::Document::stopActiveDOMObjects):
(WebCore::Document::eventLoop):

  • dom/EventLoop.cpp:

(WebCore::EventLoop::registerGroup):
(WebCore::EventLoop::unregisterGroup):
(WebCore::EventLoop::stopAssociatedGroupsIfNecessary):

  • dom/EventLoop.h:

(WebCore::EventLoopTaskGroup::EventLoopTaskGroup):
(WebCore::EventLoopTaskGroup::~EventLoopTaskGroup):
(WebCore::EventLoopTaskGroup::isReadyToStop const):
(WebCore::EventLoopTaskGroup::markAsReadyToStop):
(WebCore::EventLoopTaskGroup::stopAndDiscardAllTasks):

  • workers/WorkerOrWorkletGlobalScope.cpp:

(WebCore::WorkerOrWorkletGlobalScope::prepareForDestruction):

LayoutTests:

  • fast/js-promise-from-detached-iframe-expected.txt: Added.
  • fast/js-promise-from-detached-iframe.html: Added.

Add layout test to verify that JS promises from iframes properly get settled after the
the iframe gets removed from the doucment. I have verified that this test passes in
both Firefox and Chrome.

  • http/tests/eventloop/promise-from-cross-origin-detached-iframe-expected.txt: Added.
  • http/tests/eventloop/promise-from-cross-origin-detached-iframe.html: Added.
  • http/tests/eventloop/resources/promise-from-cross-origin-detached-iframe-subframe.html: Added.

Similar test as above but in a cross-origin iframe. Ryosuke recommended adding this test
since event loops only shared between documents of similar origins. I have verified that this
test passes in both Firefox and Chrome.

  • platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:

Rebaseline existing test that has slightly different output.

  • requestidlecallback/requestidlecallback-document-gc-expected.txt:
  • requestidlecallback/requestidlecallback-document-gc.html:

Tweak test to check that enough documents are gc's at regular intervals, instead of expecting
them to be collected in a 0-timer.

  • webaudio/promise-global-object-expected.txt: Added.
  • webaudio/promise-global-object.html: Added.

Add test to verify that the global object of the promise is correct when the promise comes
from calling a DOM API in an subframe. Previously, we would incorrectly use the caller's
global instead of the callee's global. I have verified that this test passes in both Firefox
and Chrome.

9:08 AM Changeset in webkit [269226] by weinig@apple.com
  • 22 edits
    4 deletes in trunk

Remove all remaining testRunner.overridePreference calls
https://bugs.webkit.org/show_bug.cgi?id=218373

Reviewed by Simon Fraser.

Tools:

Remove implementations of testRunner.overridePreference. Adds testRunner.setShouldInvertColors,
which is a windows only preference. When we generate preferences for Windows, we can convert
this to use test header commands instead.

Also add default for MinimumFontSize so it can be used as test header commands for DumpRenderTree.

  • DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):

  • DumpRenderTree/TestRunner.cpp:

(setShouldInvertColors):
(TestRunner::staticFunctions):
(overridePreferenceCallback): Deleted.

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::overridePreference): Deleted.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setShouldInvertColors):
(TestRunner::overridePreference): Deleted.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::toBool): Deleted.
(WTR::TestRunner::overridePreference): Deleted.

LayoutTests:

Removes remaining uses of testRunner.overridePreference and addresses some
recent feedback by removing some unnecessary "window." uses.

Also removed test cross-origin-local-storage-wk1.html as it is redundant with
other tests such as cross-origin-local-storage.html which uses internals instead.

  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html:
  • fast/parser/noscript-with-javascript-disabled.html:
  • fast/text/international/locale-sensitive-fonts.html:
  • fast/text/zero-font-size.html:
  • http/tests/download/default-encoding.html:
  • http/tests/misc/favicon-loads-with-images-disabled.html:
  • http/tests/security/cross-origin-local-storage-wk1-expected.txt: Removed.
  • http/tests/security/cross-origin-local-storage-wk1.html: Removed.
  • http/tests/security/resources/load-local-storage.html:
  • http/tests/xsl/xslt-transform-with-javascript-disabled.html:
  • platform/ios-wk1/TestExpectations:
  • platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Removed.
  • platform/mac/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Removed.
  • platform/win/TestExpectations:
  • platform/win/inverted-colors/non-composited.html:
  • platform/wk2/TestExpectations:
  • svg/as-image/svg-image-with-data-uri-images-disabled.html:
8:21 AM EarlyWarningSystem edited by aakash_jain@apple.com
(diff)
7:29 AM Changeset in webkit [269225] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][IFC] Split inline level box alignment process into multiple phases
https://bugs.webkit.org/show_bug.cgi?id=218397

Reviewed by Antti Koivisto.

Inline level box alignment inside the line box is described at https://www.w3.org/TR/css-inline-3/#line-layout.
The alignment process involves 3 distinct steps:

  1. Computing the line box's logical height. This step solely uses the layout bounds geometry of the inline level boxes.
  2. Finding the root inline box vertical position. This step is somewhat similar to the final, alignment phase but instead of

the logical top, here we compute the baseline offsets. It helps to figure out the root inline box's baseline positing inside the line box.

  1. Aligning the inline level boxes by computing their logical top position.

These 3 steps are implemented by the following 3 functions:

  1. computeLineBoxLogicalHeight()
  2. computeRootInlineBoxVerticalPosition()
  3. alignInlineLevelBoxes()

While some of the code in these functions may look redundant, they work with different type of geometries (layout bounds vs. normal ascent/descent/logical height).

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::setVerticalGeometryForInlineBox const):
(WebCore::Layout::LineBoxBuilder::alignInlineLevelBoxesVerticallyAndComputeLineBoxHeight):

  • layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::logicalRectForTextRun const):
(WebCore::Layout::LineBox::logicalRectForInlineLevelBox const):

  • layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineLevelBox::style const):
(WebCore::Layout::LineBox::InlineLevelBox::fontMetrics const): Deleted.

5:53 AM Changeset in webkit [269224] by Alan Bujtas
  • 5 edits in trunk/LayoutTests

Remove unneeded whitespace between content and <br>
https://bugs.webkit.org/show_bug.cgi?id=218151
<rdar://problem/70662471>

Reviewed by Antti Koivisto.

Missed these files in r268958.

  • editing/inserting/paragraph-separator-in-table-1.html:
  • platform/mac/editing/inserting/paragraph-separator-in-table-1-expected.txt:
5:19 AM Changeset in webkit [269223] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][Integration] Generate RootInlineBox::lineTop/lineBottom matching geometries
https://bugs.webkit.org/show_bug.cgi?id=218412

Reviewed by Antti Koivisto.

Line::enclosingRect's y() and maxY() match RootInlineBox::lineTop() and lineBottom() vertical coordinates.
It is required by the line iterator as some clients are apparently interested in the overflown area.

  • layout/integration/LayoutIntegrationLine.h:

(WebCore::LayoutIntegration::Line::Line):
(WebCore::LayoutIntegration::Line::enclosingRect const):

  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):

  • layout/integration/LayoutIntegrationPagination.cpp:

(WebCore::LayoutIntegration::makeAdjustedContent):

5:18 AM Changeset in webkit [269222] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

[LFC][IFC] Rename ContainerStart/End to InlineBoxStart/End
https://bugs.webkit.org/show_bug.cgi?id=218410

Reviewed by Antti Koivisto.

ContainerStart/End inline items are triggered by inline boxes.

"An inline box is one that is both inline-level and whose contents participate in its containing inline formatting context."

  • layout/inlineformatting/InlineContentBreaker.cpp:

(WebCore::Layout::isTextContent):
(WebCore::Layout::isVisuallyEmptyWhitespaceContent):
(WebCore::Layout::isNonContentRunsOnly):
(WebCore::Layout::InlineContentBreaker::processOverflowingTextContent const):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::collectHangingTrailingWhitespaceContent):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

  • layout/inlineformatting/InlineItem.h:

(WebCore::Layout::InlineItem::isInlineBoxStart const):
(WebCore::Layout::InlineItem::isInlineBoxEnd const):
(WebCore::Layout::InlineItem::isContainerStart const): Deleted.
(WebCore::Layout::InlineItem::isContainerEnd const): Deleted.

  • layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::visuallyCollapsePreWrapOverflowContent):
(WebCore::Layout::Line::append):
(WebCore::Layout::Line::appendInlineBoxStart):
(WebCore::Layout::Line::appendInlineBoxEnd):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::isRunVisuallyNonEmpty const):
(WebCore::Layout::Line::TrimmableTrailingContent::remove):
(WebCore::Layout::Line::appendInlineContainerStart): Deleted.
(WebCore::Layout::Line::appendInlineContainerEnd): Deleted.

  • layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Run::isInlineBoxStart const):
(WebCore::Layout::Line::Run::isInlineBoxEnd const):
(WebCore::Layout::Line::Run::isContainerStart const): Deleted.
(WebCore::Layout::Line::Run::isContainerEnd const): Deleted.

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
(WebCore::Layout::LineBuilder::inlineItemWidth const):
(WebCore::Layout::LineBuilder::nextContentForLine):
(WebCore::Layout::LineBuilder::nextWrapOpportunity const):

Oct 30, 2020: Yesterday

11:52 PM Changeset in webkit [269221] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Usage of allWorkletGlobalScopesSet() in WorkletGlobalScope is not thread-safe
https://bugs.webkit.org/show_bug.cgi?id=218408

Reviewed by Geoff Garen.

The WorkletGlobalScope constructor / destructor were adding / removing themselves
in allWorkletGlobalScopesSet(), without locking. This used to be safe when we
only had paint worklets, because those are main-thread only. However,
AudioWorketGlobalScopes get constructed / destroyed on background thread so this
is no longer safe.

Since this is only used by Internals for layout tests to figure out how many
worklet instances are alive, I replaced the map with an std::atomic<unsigned>.

No new tests, found when running existing tests with GuardMalloc.

  • testing/Internals.cpp:

(WebCore::Internals::isAnyWorkletGlobalScopeAlive const):

  • worklets/WorkletGlobalScope.cpp:

(WebCore::WorkletGlobalScope::WorkletGlobalScope):
(WebCore::WorkletGlobalScope::~WorkletGlobalScope):
(WebCore::WorkletGlobalScope::numberOfWorkletGlobalScopes):

  • worklets/WorkletGlobalScope.h:
8:34 PM Changeset in webkit [269220] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore/PAL

Fix internal watchOS and tvOS builds after r269211
https://bugs.webkit.org/show_bug.cgi?id=217506

Unreviewed build fix.

  • pal/spi/cg/CoreGraphicsSPI.h:
8:21 PM Changeset in webkit [269219] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WTF

REGRESSION (r267689): Rise of the Tomb Raider gets stuck while launching
https://bugs.webkit.org/show_bug.cgi?id=218411
<rdar://problem/70622557>

Reviewed by Zalan Bujtas.

  • Scripts/Preferences/WebPreferences.yaml:

Sam accidentally changed the default of RequiresUserGestureForMediaPlayback
in r267689; previously it was @YES only in PLATFORM(IOS_FAMILY), he made
it true globally.

Go back to the old, and intended, behavior.

7:00 PM Changeset in webkit [269218] by Karl Rackler
  • 2 edits in trunk/LayoutTests

REGRESSION (r269070): [ Big Sur ] editing/input/reveal-caret-of-multiline-input.html is a constant failure
rdar://70819245
Re-baseline for Big Sur.

Unreviewed test gardening.

  • platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:
6:34 PM Changeset in webkit [269217] by Karl Rackler
  • 2 edits in trunk/LayoutTests

REGRESSION (r268178): [iOS] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217741
Remove test expectation after revert of r268178.

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
6:21 PM Changeset in webkit [269216] by Karl Rackler
  • 2 edits in trunk/LayoutTests

REGRESSION (iOS 14): [ iOS wk2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure (217419)
https://bugs.webkit.org/show_bug.cgi?id=217419
Re-baseline

Unreviewed test gardening.

  • platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
5:54 PM Changeset in webkit [269215] by Karl Rackler
  • 2 edits in trunk/LayoutTests

REGRESSION (r268958): [ Big Sur ] fast/forms/basic-inputs.html is a constant failure
rdar://70904424
Re-baseline after r268958
Unreviewed test gardening.

  • platform/mac/fast/forms/basic-inputs-expected.txt:
5:29 PM Changeset in webkit [269214] by Chris Dumez
  • 192 edits
    3 moves
    10 adds
    3 deletes in trunk/LayoutTests

Resync web-platform-tests/interfaces tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=218394

Reviewed by Sam Weinig.

Resync web-platform-tests/interfaces tests from upstream 5dbb0a3fa631ef73da06.

  • web-platform-tests/audio-output/idlharness.https.window-expected.txt:
  • web-platform-tests/encoding/idlharness.any-expected.txt:
  • web-platform-tests/encoding/idlharness.any.js:
  • web-platform-tests/encoding/idlharness.any.worker-expected.txt:
  • web-platform-tests/html/dom/idlharness.https.html:
  • web-platform-tests/html/dom/idlharness.worker.js:
  • web-platform-tests/payment-request/idlharness.https.window-expected.txt:
  • web-platform-tests/resize-observer/idlharness.window-expected.txt:
  • web-platform-tests/streams/idlharness.any-expected.txt:
  • web-platform-tests/streams/idlharness.any.worker-expected.txt:
  • web-platform-tests/web-animations/idlharness.window-expected.txt:
  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/idlharness.https.window.js:

Rebaseline some WPT tests whose output has changed. Some of the tests had
to be resync'd from upstream to keep running.

  • web-platform-tests/interfaces/*: Updated.
5:15 PM Changeset in webkit [269213] by Russell Epstein
  • 3 edits in branches/safari-611.1.4-branch/Source/WebKit

Cherry-pick r269202. rdar://problem/70901517

Correct sandbox violations in GPU Process
https://bugs.webkit.org/show_bug.cgi?id=218356
<rdar://problem/70574999>

Reviewed by Eric Carlson.

The new GPU Process sandbox is missing 'sysctl.name2oid' from the allow list, even though
we allow it everywhere else. We need this for proper function.

  • GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:15 PM Changeset in webkit [269212] by Russell Epstein
  • 2 edits in branches/safari-611.1.4-branch/Source/WebCore

Cherry-pick r269188. rdar://problem/70901497

REGRESSION (r269146): ASSERTION FAILED: didNeedLayout
logicalHeight() == oldHeight in WebCore::RenderBlockFlow::ensureLineBoxes

https://bugs.webkit.org/show_bug.cgi?id=218350
<rdar://problem/70822708>

Reviewed by Zalan Bujtas.

Dropping of ensureLineBoxes call revealed a bug in text control style updates.

RenderTextControlSingleLine mutates style of the innerTextElement() renderer by altering the height property.
On style update this mutation is lost which causes ensureLineBoxes for innerTextElement() to miscompute block height
if RenderTextControlSingleLine layout has not happened before.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):

Don't zero the dimension properties of the innerTextElement() unnecessarily. Instead see of the underlying style has
actually changed and set the style only in that case. That will then trigger layout as needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:01 PM Changeset in webkit [269211] by mmaxfield@apple.com
  • 13 edits
    4 adds in trunk/Source/WebCore

[Cocoa] [GPU Process] Perform image decoding of color fonts in the Web Process
https://bugs.webkit.org/show_bug.cgi?id=217506

Reviewed by Simon Fraser.

Source/WebCore:

Core Text itself doesn't know how to draw things; it has to rely on Core Graphics to do that.
However, Core Graphics only understands the simplest of text drawing concepts; it doesn't understand
things like color fonts or emoji. Core Text sits between the application and Core Graphics, and is
responsible for splitting up an arbitrary draw command into individual simple pieces which Core
Graphics can understand. For example, when you ask Core Text to draw a string which is of the form
"outlines emoji outlines", Core Text will end up telling Core Graphics to draw the first outlines, then
draw the emoji image (using Core Graphics's normal image drawing routines), then draw the remaining
outlines.

This is exactly the same kind of filtering we want to do for the GPU Process. We want to be able to
separate out the glyphs which are rendered using outlines from the emoji glyphs which are rendered
using images. We want to handle the image glyphs ourself in WebKit using our own image drawing display
list facilities, which will cause images to be decoded in the Web Process, thereby increasing the
security of the GPU Process.

So, this patch implements a custom CGContext, backed by a function table that is populated in WebKit.
We pass this custom CGContext into Core Text, which does its normal splitting up of outlines / images,
and calls glyph / image drawing functions on our CGContext. Because these functions are implemented by
WebKit, this effectively makes WebKit able to intercept the drawing calls, and implement them ourself
by appending items to the current display list. So, when Core Text tells our CGContext to draw an emoji,
our callback runs and we "just" append a DrawImage display list item.

I use scare-quotes around "just" because it is a bit more complicated than that. Core Text internally
can change the fill/stroke color (for COLR glyphs), the text matrix (it should be updated between
adjacent runs), the CTM, and the shadow state (because Core Text sometimes will implement shadows itself
by just drawing the text two times). So, in our CGContext callback, we have to look at the state of
the CGContext, figure out if anything changed (because we're not notified when changes happen), and
if things did change, append additional display list items to make a parallel change happen at draw
time.

Tests added in https://trac.webkit.org/r269177

  • Headers.cmake:
  • PlatformAppleWin.cmake:
  • PlatformWinCairo.cmake:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/FreeType.cmake:
  • platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::ImageBufferCGBackend::setupContext):

  • platform/graphics/coretext/FontCascadeCoreText.cpp:

(WebCore::fillVectorWithHorizontalGlyphPositions):

  • platform/graphics/displaylists/DisplayListDrawGlyphsRecorder.h: Added.
  • platform/graphics/displaylists/DisplayListDrawGlyphsRecorderCoreText.cpp: Added.

(WebCore::DisplayList::beginLayer): VTable callback for creating a transparency layer.
(WebCore::DisplayList::endLayer): Ditto for ending a transparency layer.
(WebCore::DisplayList::drawGlyphs): VTable callback for drawing outline glyphs.
(WebCore::DisplayList::drawImage): VTable callback for drawing an image.
(WebCore::DisplayList::DrawGlyphsRecorder::createInternalContext): Set up the custom CGContext
infrastructure. Hook up the VTable callbacks.
(WebCore::DisplayList::DrawGlyphsRecorder::DrawGlyphsRecorder):
(WebCore::DisplayList::DrawGlyphsRecorder::populateInternalState): We need to save the GraphicsContext
state at the beginning of the entry point, so we can restore anything that changed when we're done.
(WebCore::DisplayList::DrawGlyphsRecorder::populateInternalContext): Because Core Text internally
interrogates the CGContext to see if it needs to do things like draw shadows itself, we need to make
sure that the recorder's state is mirrored in our custom CGContext. This applies all the relevant
state to our CGContext so it's ready when Core Text asks for it.
(WebCore::DisplayList::DrawGlyphsRecorder::prepareInternalContext): Call the above two functions.
(WebCore::DisplayList::DrawGlyphsRecorder::concludeInternalContext): Called once when we're done.
This function cleans up, by possibly appending additional display list items to restore the state
back to what it was when we started.
(WebCore::DisplayList::DrawGlyphsRecorder::updateFillColor): Detect a changed fill color, and if it has
changed, append a display list item to make a parallel change at drawing time.
(WebCore::DisplayList::DrawGlyphsRecorder::updateStrokeColor): Ditto for the stroke color.
(WebCore::DisplayList::DrawGlyphsRecorder::updateCTM): Ditto for the CTM.
(WebCore::DisplayList::shadowIsCleared):
(WebCore::DisplayList::DrawGlyphsRecorder::updateShadow): Ditto for the shadow state.
(WebCore::DisplayList::DrawGlyphsRecorder::recordBeginLayer): Hook this up to beginTransparencyLayer().
(WebCore::DisplayList::DrawGlyphsRecorder::recordEndLayer): Hook this up to endTransparencyLayer().
(WebCore::DisplayList::computeAdvancesFromPositions): CGContext gives us positions, but our display list
infrastructure requires advances. Simply subtract to convert between them.
(WebCore::DisplayList::DrawGlyphsRecorder::recordDrawGlyphs): The callback that appends a DrawGlyphs
display list item. Note it has to call the various update() functions to detect changes in the CGContext
state.
(WebCore::DisplayList::DrawGlyphsRecorder::recordDrawImage): Ditto for a DrawImage display list item.
(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs): The main entry point. Simply set up, do the work,
then clean up.

  • platform/graphics/displaylists/DisplayListDrawGlyphsRecorderHarfBuzz.cpp: Added. Dummy implementation

to make the other ports continue to compile.
(WebCore::DisplayList::DrawGlyphsRecorder::DrawGlyphsRecorder):
(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::Recorder):
(WebCore::DisplayList::Recorder::drawGlyphs): Call m_drawGlyphsRecorder.drawGlyphs() instead of just
appending a DrawGlyphs command.
(WebCore::DisplayList::Recorder::concatCTM): Tiny optimization.
(WebCore::DisplayList::Recorder::clipToDrawingCommands): The current clipToDrawingCommands's context
CTM didn't match the parallel one used during playback. In order to make the CTMs match are recording
and playback time, we have to make sure they start off the same.

  • platform/graphics/displaylists/DisplayListRecorder.h: DisplayList::Recorder owns a DrawGlyphsRecorder,

whose lifetime equals that of the DisplayList::Recorder. Rather than destroying / recreating the
DrawGlyphsRecorder, the DrawGlyphsRecorder class is smart enough to clean up after itself so it can be
reused multiple times.

Source/WebCore/PAL:

Add some new entry points, and do some various cleanup.

  • pal/spi/cg/CoreGraphicsSPI.h:
4:56 PM Changeset in webkit [269210] by Brian Burg
  • 31 edits
    2 adds
    2 deletes in trunk

Web Inspector: move InspectorFrontendAPIDispatcher to WebCore, clean up uses
https://bugs.webkit.org/show_bug.cgi?id=217835
<rdar://problem/70384407>

Reviewed by Devin Rousso.

Source/WebCore:

Expose the dispatcher as part of the InspectorFrontendClient API so that other code
can use the dispatcher regardless of whether it's a WebInspectorUI or RemoteWebInspectorUI.

Add an InspectorFrontendAPIDispatcher instance and getter to InspectorFrontendClientLocal.

Adopt the JSONValue-based InspectorFrontendAPIDispatcher::dispatch() method
in InspectorFrontendClientLocal. Remove the redundant parallel queuing implementation.
Remove redundant public methods that are available on InspectorFrontendAPIDispatcher.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:

Moved files.

  • inspector/InspectorFrontendAPIDispatcher.cpp: Renamed from Source/WebKit/WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.cpp.

(WebCore::InspectorFrontendAPIDispatcher::InspectorFrontendAPIDispatcher):
(WebCore::InspectorFrontendAPIDispatcher::reset):
(WebCore::InspectorFrontendAPIDispatcher::frontendLoaded):
(WebCore::InspectorFrontendAPIDispatcher::suspend):
(WebCore::InspectorFrontendAPIDispatcher::unsuspend):
(WebCore::InspectorFrontendAPIDispatcher::dispatchCommand):
(WebCore::InspectorFrontendAPIDispatcher::dispatchMessageAsync):
(WebCore::InspectorFrontendAPIDispatcher::evaluateOrQueueExpression):
(WebCore::InspectorFrontendAPIDispatcher::evaluateQueuedExpressions):
(WebCore::InspectorFrontendAPIDispatcher::evaluateExpression):
(WebCore::InspectorFrontendAPIDispatcher::evaluateExpressionForTesting):
Add new dispatch() method. Remove other dispatch methods that can be expressed
using the new JSON::Value-based method. If it's not possible to evaluate JS
immediately, schedule a one-shot task to try again on a different event loop turn.

  • inspector/InspectorFrontendAPIDispatcher.h: Renamed from Source/WebKit/WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.h.

Add new dispatch() method which takes a vector of JSON::Value objects and
serializes them into command arguments for the frontend.

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::pagePaused):
(WebCore::InspectorFrontendClientLocal::pageUnpaused):
(WebCore::InspectorFrontendClientLocal::setDockingUnavailable):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::startProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::showConsole):
(WebCore::InspectorFrontendClientLocal::showResources):
(WebCore::InspectorFrontendClientLocal::showMainResourceForFrame):
Use InspectorFrontendAPIDispatcher to dispatch commands to the frontend.

(WebCore::InspectorFrontendClientLocal::dispatch): Deleted.
(WebCore::InspectorFrontendClientLocal::dispatchMessage): Deleted.
(WebCore::InspectorFrontendClientLocal::dispatchMessageAsync): Deleted.
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad): Deleted.
These are redundant with InspectorFrontendAPIDispatcher.

  • testing/Internals.cpp:

(WebCore::InspectorStubFrontend::sendMessageToFrontend): Use frontend dispatcher directly.

Source/WebKit:

Adopt the JSONValue-based InspectorFrontendAPIDispatcher::dispatch() method
in WebInspectorUI and RemoteInspectorUI methods that dispatch to the frontend.

  • Sources.txt:
  • WebKit.xcodeproj/project.pbxproj: Move files.
  • WebProcess/Inspector/RemoteWebInspectorUI.h:
  • WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::RemoteWebInspectorUI):
(WebKit::RemoteWebInspectorUI::initialize):
(WebKit::RemoteWebInspectorUI::updateFindString):
(WebKit::RemoteWebInspectorUI::didSave):
(WebKit::RemoteWebInspectorUI::didAppend):
(WebKit::RemoteWebInspectorUI::frontendLoaded):
(WebKit::RemoteWebInspectorUI::sendMessageToFrontend):
(WebKit::RemoteWebInspectorUI::pagePaused):
(WebKit::RemoteWebInspectorUI::pageUnpaused):
(WebKit::RemoteWebInspectorUI::setDiagnosticLoggingAvailable):

  • WebProcess/Inspector/WebInspectorUI.h:
  • WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::WebInspectorUI):
(WebKit::WebInspectorUI::setDockSide):
(WebKit::WebInspectorUI::setDockingUnavailable):
(WebKit::WebInspectorUI::setIsVisible):
(WebKit::WebInspectorUI::updateFindString):
(WebKit::WebInspectorUI::setDiagnosticLoggingAvailable):
(WebKit::WebInspectorUI::showConsole):
(WebKit::WebInspectorUI::showResources):
(WebKit::WebInspectorUI::showMainResourceForFrame):
(WebKit::WebInspectorUI::startPageProfiling):
(WebKit::WebInspectorUI::stopPageProfiling):
(WebKit::WebInspectorUI::startElementSelection):
(WebKit::WebInspectorUI::stopElementSelection):
(WebKit::WebInspectorUI::didSave):
(WebKit::WebInspectorUI::didAppend):
(WebKit::WebInspectorUI::sendMessageToFrontend):
(WebKit::WebInspectorUI::evaluateInFrontendForTesting):
(WebKit::WebInspectorUI::pagePaused):
(WebKit::WebInspectorUI::pageUnpaused):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

Add missing header includes (related to unified sources changes from r269168).

Source/WebKitLegacy/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::sendMessageToFrontend):

LayoutTests:

  • inspector/dom/dom-remove-events.html:
  • inspector/dom/remove-multiple-nodes.html:

The order of events received has changed slightly due to the new auto-suspend behavior
in InspectorFrontendAPIDispatcher. Remove event handlers when the test is complete to
ensure that events which arrive after the test has finished do not stomp on the expected results.

  • inspector/debugger/call-frame-function-name.html:
  • inspector/debugger/call-frame-this-host.html:
  • inspector/debugger/hit-breakpoint-from-console.html:
  • inspector/debugger/setBreakpoint-autoContinue.html:
  • inspector/debugger/setBreakpoint-column.html:
  • inspector/debugger/setBreakpoint-condition.html:
  • inspector/debugger/setBreakpoint.html:
  • inspector/debugger/setBreakpointByUrl-sourceURL.html:

Some tests seem to call ProtocolTest.completeTest() from the handler of Debugger.paused, when
the debugger is still paused. This causes timeouts after this refactoring, since not resuming means that
we'll get stuck in the debugger's nested run loop and never return.

4:52 PM Changeset in webkit [269209] by rniwa@webkit.org
  • 1 edit
    11 adds in trunk

Add Introduction to WebKit
https://bugs.webkit.org/show_bug.cgi?id=217017

Rubber-stamped by Simon Fraser.

Added the basic introductory documentation for WebKit.

  • Introduction.md: Added.
  • resources/js-wrapper.png: Added.
  • resources/webkit2-process-architecture.png: Added.
  • resources/xcode-add-file.png: Added.
  • resources/xcode-build-settings-for-run.png: Added.
  • resources/xcode-export-header.png: Added.
  • resources/xcode-scheme-dumprendertree.png: Added.
  • resources/xcode-scheme-layout-test.png: Added.
  • resources/xcode-workspace-build-location.png: Added.
  • resources/xcode-workspace-settings.png: Added.
3:59 PM Changeset in webkit [269208] by Chris Fleizach
  • 7 edits
    1 add in trunk/Source

AX: Incorrect list of voices being displayed on iOS
https://bugs.webkit.org/show_bug.cgi?id=218293

Reviewed by Per Arne Vollan.

Source/WebCore:

Limit the voices that we display in WebSpeech to only built-in system voices. This was the intention of the "compact"
decision, but some mobile assets have compact voices, which are not available WebContent.

  • platform/ios/PlatformSpeechSynthesizerIOS.mm:

(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/PlatformMac.cmake:
  • pal/spi/cocoa/AXSpeechManagerSPI.h: Added.

Source/WTF:

  • wtf/PlatformHave.h:
3:26 PM Changeset in webkit [269207] by Russell Epstein
  • 1 copy in tags/Safari-610.3.6

Tag Safari-610.3.6.

1:34 PM Changeset in webkit [269206] by Keith Rollin
  • 2 edits in trunk/Source/WebCore

Further lessen reliance on VPATH in WebCore/DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=218378
<rdar://problem/70730895>

Reviewed by Darin Adler.

Bug 217696 updated WebCore/DerivedSources.make to rely less on VPATH
and make more use of explicit partial or full paths. The solution
there, however, did not go far enough, and led to failures when
building WebKit for Safari Tech Preview and using old SDKs that
contains files that have since been "upstreamed" into WebKit. Address
this problem by taking further control of how DerivedSources.make
finds needed files instead of using the VPATH mechanism.

No new tests -- this is a build fix.

  • DerivedSources.make:
1:32 PM Changeset in webkit [269205] by Jonathan Bedard
  • 5 edits in trunk/Tools

[webkitpy] Use allowlist and blocklist
https://bugs.webkit.org/show_bug.cgi?id=217985
<rdar://problem/70499499>

Reviewed by Aakash Jain.

  • Scripts/webkitpy/pylintrc:
  • Scripts/webkitpy/style/checkers/cpp.py:

(check_namespace_indentation):

  • Scripts/webkitpy/w3c/common.py:

(is_basename_skipped):

  • flatpak/flatpakutils.py:

(WebkitFlatpak.setup_gstbuild):

1:27 PM Changeset in webkit [269204] by Fujii Hironori
  • 4 edits
    2 adds in trunk

[TextureMapper] Replica layers don't blend correctly because computeOverlapRegions doesn't take TextureMapperPaintOptions::transform into account
https://bugs.webkit.org/show_bug.cgi?id=218307

Reviewed by Don Olmstead.

Source/WebCore:

Blending in replica layers didn't work as expected because
computeOverlapRegions didn't take the transform of
TextureMapperPaintOptions into account. Rendering replica layers
are achieved by using the transform.

TextureMapperLayer::paintWithIntermediateSurface also should take
the transform. commitSurface no longer needs to transform by it.

Test: compositing/reflections/opacity-in-reflection.html

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):

  • platform/graphics/texmap/TextureMapperLayer.h:

LayoutTests:

  • compositing/reflections/opacity-in-reflection-expected.html: Added.
  • compositing/reflections/opacity-in-reflection.html: Added.
1:09 PM Changeset in webkit [269203] by Chris Dumez
  • 5 edits in trunk

BaseAudioContext.decodeAudioData() should throw an InvalidStateError when document is not fully active
https://bugs.webkit.org/show_bug.cgi?id=218400

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-detached-execution-context-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/offlineaudiocontext-detached-execution-context-expected.txt:

Source/WebCore:

BaseAudioContext.decodeAudioData() should throw an InvalidStateError when document is not fully active:

We were previously throwing a NotAllowedError instead.

No new tests, rebaselined existing tests.

  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::decodeAudioData):

11:06 AM Changeset in webkit [269202] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit

Correct sandbox violations in GPU Process
https://bugs.webkit.org/show_bug.cgi?id=218356
<rdar://problem/70574999>

Reviewed by Eric Carlson.

The new GPU Process sandbox is missing 'sysctl.name2oid' from the allow list, even though
we allow it everywhere else. We need this for proper function.

  • GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
11:06 AM Changeset in webkit [269201] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Extra closing parenthesis added after var in styles panel
https://bugs.webkit.org/show_bug.cgi?id=218295
<rdar://problem/70771314>

Reviewed by Devin Rousso.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._addVariableTokens):
Remove contents.push(token) which was adding ). The closing parenthesis that was already
included in rawTokens above.
Drive-by: rawTokens.slice() should never include i as the 2nd argument. i is an index of an item
in the tokens - a different array.

10:42 AM Changeset in webkit [269200] by Alan Coon
  • 11 edits in branches/safari-611.1.4-branch

Cherry-pick r269173. rdar://problem/70831161

[Cocoa] Remove soft linking of NetworkExtension.framework
https://bugs.webkit.org/show_bug.cgi?id=218314
<rdar://problem/70785239>

Reviewed by Andy Estes.

Source/WebCore:

WebCore should link NetworkExtension.framework normally, to avoid the
runtime cost associated with soft linking.

  • Configurations/WebCore.xcconfig:

On macOS, weak link the framework since NetworkExtension.framework is
not available on the Base System.

  • platform/cocoa/NetworkExtensionContentFilter.h:

Added the isRequired static method to avoid soft linking
NetworkExtension.framework in WebKit.

  • platform/cocoa/NetworkExtensionContentFilter.mm:

Only compile this file in the ENABLE(CONTENT_FILTERING) build, as its
functionality is unavailable on tvOS.

(WebCore::NetworkExtensionContentFilter::enabled):
(WebCore::NetworkExtensionContentFilter::initialize):
(WebCore::NetworkExtensionContentFilter::unblockHandler const):
(WebCore::NetworkExtensionContentFilter::isRequired):

Source/WebKit:

  • UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::addPlatformLoadParameters):

Replaced the soft linked method call with a new method exported from
WebCore.

  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::platformDidReceiveLoadParameters):

Tools:

Updated a test to reflect that NetworkExtension.framework is no longer
loaded at runtime. This test was failing on Catalina after r269109,
as the Contacts framework was loading NetworkExtension.

  • TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.h:
  • TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm: (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:]): (TEST):
  • TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm: (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:42 AM Changeset in webkit [269199] by Alan Coon
  • 5 edits
    1 delete in branches/safari-611.1.4-branch

Cherry-pick r269160. rdar://problem/70831130

Unreviewed, reverting r268192.

PLT regression - rdar://problem/70141350

Reverted changeset:

"Adjust heuristic for checking whether view reaches visually
non-empty state"
https://bugs.webkit.org/show_bug.cgi?id=217400
https://trac.webkit.org/changeset/268192

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:42 AM Changeset in webkit [269198] by Alan Coon
  • 4 edits
    2 adds in branches/safari-611.1.4-branch

Cherry-pick r269136. rdar://problem/70831153

REGRESSION(r267329): Crash in VisibleSelection::toNormalizedRange()
https://bugs.webkit.org/show_bug.cgi?id=218276

Reviewed by Wenson Hsieh.

Source/WebCore:

The crash was a symptom of the issue that m_extent or m_base could be null but not the other
when canonicalizing a non-null Position with VisiblePosition will make it null.

Fixed the bug by making sure base and extent's nullness match.

Test: editing/selection/delete-selection-with-disconnected-extent.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents):

LayoutTests:

Added a regression test and rebaselined the test now that we got the pre-r267329 behavior back.

  • editing/execCommand/insert-list-nested-with-orphaned-expected.txt: Reverted the rebaseline in r267329.
  • editing/selection/delete-selection-with-disconnected-extent-expected.txt: Added.
  • editing/selection/delete-selection-with-disconnected-extent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:42 AM Changeset in webkit [269197] by Alan Coon
  • 2 edits in branches/safari-611.1.4-branch/Source/WebCore

Cherry-pick r269110. rdar://problem/70831200

[LFC][IFC] horizontalAlignmentOffset should check for empty run list
https://bugs.webkit.org/show_bug.cgi?id=218285
<rdar://problem/70730722>

Reviewed by Antti Koivisto.

LineBoxBuilder functions check for empty run list except this static helper.

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp: (WebCore::Layout::horizontalAlignmentOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:42 AM Changeset in webkit [269196] by Alan Coon
  • 6 edits in branches/safari-611.1.4-branch/Source

Cherry-pick r269082. rdar://problem/70831193

Adopt the UIPointerInteraction API
https://bugs.webkit.org/show_bug.cgi?id=218266
<rdar://problem/70732850>

Reviewed by Wenson Hsieh.

Source/WebKit:

No new tests, just moving from deprecated SPI to API.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setUpInteraction]): (-[WKContentView cleanUpInteraction]): (-[WKContentView setUpPointerInteraction]): (-[WKContentView _pointerInteraction:regionForRequest:defaultRegion:completion:]): (-[WKContentView pointerRegionForPositionInformation:point:]): (-[WKContentView pointerInteraction:styleForRegion:]): (-[WKContentView setUpCursorInteraction]): Deleted. (-[WKContentView _cursorInteraction:regionForLocation:defaultRegion:completion:]): Deleted. (-[WKContentView cursorRegionForPositionInformation:point:]): Deleted. (-[WKContentView cursorInteraction:styleForRegion:modifiers:]): Deleted.

Source/WTF:

  • wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:42 AM Changeset in webkit [269195] by Alan Coon
  • 3 edits in branches/safari-611.1.4-branch/Source/WebCore

Cherry-pick r269078. rdar://problem/70831181

Remove leftover DiagnosticLoggingKey after r268458
https://bugs.webkit.org/show_bug.cgi?id=218263
<rdar://problem/70738034>

Reviewed by Darin Adler.

Remove the leftover DiagnosticKey for ResourceLoadStatistics telemetry now that the
actual data is no longer generated.

  • page/DiagnosticLoggingKeys.cpp: (WebCore::DiagnosticLoggingKeys::resourceLoadStatisticsTelemetryKey): Deleted.
  • page/DiagnosticLoggingKeys.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:42 AM Changeset in webkit [269194] by Alan Coon
  • 2 edits in branches/safari-611.1.4-branch/Source/WebInspectorUI

Cherry-pick r269071. rdar://problem/70831166

Web Inspector: REGRESSION(r266669): Uncaught Exception: TypeError: node.nodeType is not a function. (In 'node.nodeType()', 'node.nodeType' is undefined)
https://bugs.webkit.org/show_bug.cgi?id=218254

Reviewed by Joseph Pecoraro.

r266669 changed WI.DOMBreakpoint to use WI.DOMNode instead of DOM.NodeId, meaning that
WI.DOMTreeContentView.prototype._updateBreakpointStatus now expects a WI.DOMNode.

  • UserInterface/Views/DOMTreeContentView.js: (WI.DOMTreeContentView.prototype._domTreeElementAdded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:42 AM Changeset in webkit [269193] by Alan Coon
  • 8 edits in branches/safari-611.1.4-branch

Cherry-pick r268904. rdar://problem/70831149

Null check platformStrategies when making blob read stream for an NSURLRequest
https://bugs.webkit.org/show_bug.cgi?id=218112
<rdar://problem/70507102>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-10-22
Reviewed by Wenson Hsieh.

Source/WebCore:

r266187 made it possible to create a DataTransfer without a user event, which allows you to make a FileList,
which allows you to submit a multipart form without a user event that calls decidePolicyForNavigationAction
with a request that has a form data body that would make a blob upload stream. This causes us to use
platformStrategies in the UI process, which dereferences null. Since the blob only really exists in the network
process, just return a nil HTTPBody in such an exotic case instead of crashing.

Covered by an API test that would hit this crash. Web platform tests were insufficient because WebKitTestRunner does not
access WKNavigationAction.request, but Safari does.

  • platform/PlatformStrategies.cpp: (WebCore::hasPlatformStrategies):
  • platform/PlatformStrategies.h:
  • platform/network/FormData.cpp: (WebCore::FormData::containsBlobElement const): (WebCore::FormData::resolveBlobReferences):
  • platform/network/FormData.h:
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::createHTTPBodyCFReadStream):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: (TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:42 AM Changeset in webkit [269192] by Alan Coon
  • 7 edits
    1 add in branches/safari-611.1.4-branch

Cherry-pick r268878. rdar://problem/70831133

UIClient isn't notified when page muted state changes
https://bugs.webkit.org/show_bug.cgi?id=218085
<rdar://problem/70462420>

Reviewed by Youenn Fablet.

Source/WebKit:

API test: WKWebView.MediaMuted

  • UIProcess/API/C/WKPage.cpp: (WKPageGetMediaState): reportedMediaCaptureState -> reportedMediaState.
  • UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _mediaCaptureState]): Ditto.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateReportedMediaCaptureState): Only record current capture state in m_reportedMediaCaptureState. m_delayStopCapturingReporting isn't necessary, remove it.
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::reportedMediaState const): Renamed from reportedMediaCaptureState to reflect what it returns. (WebKit::WebPageProxy::mediaStateFlags const): Deleted. (WebKit::WebPageProxy::reportedMediaCaptureState const): Deleted.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
  • TestWebKitAPI/Tests/WebKitCocoa/MediaMutedState.mm: Added. (-[AudioStateObserver initWithWebView:]): (-[AudioStateObserver observeValueForKeyPath:ofObject:change:context:]): (-[AudioStateTestView setMuted:]): (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:42 AM Changeset in webkit [269191] by Alan Coon
  • 11 edits
    1 copy
    1 add in branches/safari-611.1.4-branch/Source

Cherry-pick r268386. rdar://problem/70831174

Cocoa: Make WebGLLayer not dependent on GraphicsContextGLOpenGL
https://bugs.webkit.org/show_bug.cgi?id=217212
<rdar://problem/69876022>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-10-13
Reviewed by Dean Jackson.

Source/WebCore:

WebGLLayer was needlessly using GraphicsContextGLOpenGL.
This is problematic because WebGLLayer should work with
upcoming remote GraphicsContextGL implementation.

The prepare callgraph was:

GCGLOpenGL -> WebGLLayer -> GCGLOpenGL

Refactor it to be:

GCGLOpenGL -> WebGLLayer

Move the back buffer ownership to the GraphicsContextGLOpenGL.
Make the front buffer ownership explicit in WebGLLayer.
Move the EGL bindings ownerships of all buffers to
GraphicsContextGLOpenGL.

Make the WebGLLayer not use EGL or OpenGL, it does not
need and cannot use it as not all of its clients use OpenGL
(i.e. the above mentioned remote use-case).

Improves the memory usage by not allocating front buffers
unless needed. In case the canvas does not present, will
not allocate front buffers at all.

Improves error handling of the allocations and EGL bindings.

No new tests, a refactor.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLOpenGL::reshapeFBOs): (WebCore::GraphicsContextGLOpenGL::prepareTexture): (WebCore::GraphicsContextGLOpenGL::prepareTextureImpl):
  • platform/graphics/angle/GraphicsContextGLANGLEUtilities.h: Added. (WebCore::ScopedRestoreTextureBinding::ScopedRestoreTextureBinding): (WebCore::ScopedRestoreTextureBinding::~ScopedRestoreTextureBinding):
  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL): (WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL): (WebCore::GraphicsContextGLOpenGL::makeContextCurrent): (WebCore::GraphicsContextGLOpenGL::reshapeDisplayBufferBacking): (WebCore::GraphicsContextGLOpenGL::bindDisplayBufferBacking): (WebCore::GraphicsContextGLOpenGL::prepareForDisplay): (WebCore::GraphicsContextGLOpenGL::didDisplay):
  • platform/graphics/cocoa/WebGLLayer.h:
  • platform/graphics/cocoa/WebGLLayer.mm: (-[WebGLLayer initWithClient:devicePixelRatio:]): (-[WebGLLayer copyImageSnapshotWithColorSpace:]): (-[WebGLLayer recycleBuffer]): (-[WebGLLayer prepareForDisplayWithContents:]): (-[WebGLLayer display]): (-[WebGLLayer detachClient]):
  • platform/graphics/cocoa/WebGLLayerClient.h: Copied from Source/WebCore/platform/graphics/cocoa/WebGLLayer.h. (WebCore::WebGLLayerClient::~WebGLLayerClient):
  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:
  • platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp: (WebCore::GraphicsContextGLOpenGL::reshapeFBOs):

Source/WebKit:

Removed unneeded inclusions of GraphicsContextGLOpenGL.h. The
file is now using non-public headers.

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/mac/WebPageMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:02 AM Changeset in webkit [269190] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Increase camera failing timer to 30 seconds
https://bugs.webkit.org/show_bug.cgi?id=218389

Reviewed by Eric Carlson.

From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.

  • platform/mediastream/mac/AVVideoCaptureSource.h:
9:52 AM Changeset in webkit [269189] by Jonathan Bedard
  • 2 edits in trunk

Github mirror ReadMe need to update
https://bugs.webkit.org/show_bug.cgi?id=218120
<rdar://problem/70861595>

Reviewed by Aakash Jain.

  • ReadMe.md:
9:04 AM Changeset in webkit [269188] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore
REGRESSION (r269146): ASSERTION FAILED: didNeedLayout
logicalHeight() == oldHeight in WebCore::RenderBlockFlow::ensureLineBoxes

https://bugs.webkit.org/show_bug.cgi?id=218350
<rdar://problem/70822708>

Reviewed by Zalan Bujtas.

Dropping of ensureLineBoxes call revealed a bug in text control style updates.

RenderTextControlSingleLine mutates style of the innerTextElement() renderer by altering the height property.
On style update this mutation is lost which causes ensureLineBoxes for innerTextElement() to miscompute block height
if RenderTextControlSingleLine layout has not happened before.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::styleDidChange):

Don't zero the dimension properties of the innerTextElement() unnecessarily. Instead see of the underlying style has
actually changed and set the style only in that case. That will then trigger layout as needed.

8:34 AM Changeset in webkit [269187] by commit-queue@webkit.org
  • 10 edits
    65 copies
    129 moves
    26 adds
    3 deletes in trunk/LayoutTests

Resync web-platform-tests/css/css-sizing/aspect-ratio from upstream
https://bugs.webkit.org/show_bug.cgi?id=218377

Patch by Rob Buis <rbuis@igalia.com> on 2020-10-30
Reviewed by Frédéric Wang.

Resync web-platform-tests/css/css-sizing/aspect-ratio from upstream f8941337b6.

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-001-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-002-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-002.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-002.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-003-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-003.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-003.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-004-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-004.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-004.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-005-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-005.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-005.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-005.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-006-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-006.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-006.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-006.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-007-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-007.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-007.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-007.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-008-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-008.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-008.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-008.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-009-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/auto-margins-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-009.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-006.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-010-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-010.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-011-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-002.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-011.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-003.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-012-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-003.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-012.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-009.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-013-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-004.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-013.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-015.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-014-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-005.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/abspos-014.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/auto-margins-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-006.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/auto-margins-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/auto-margins-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-007.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-002-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-008.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-002.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-003-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-009.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-003.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-004-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-010.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-004.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-005-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-013.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-005.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-005.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-006-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-014.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-006.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-006.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-007-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-015.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-007.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-007.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-008-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-016.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-008.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-008.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-009-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-017.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-009.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-009.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-010-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-018.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-010.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-010.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-011-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-011.tentative-expected.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-011.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-011.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-012-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-012.tentative-expected.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-012.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-012.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-013-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-019.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-013.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-013.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-014-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-020.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-014.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-014.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-015-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-015.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-015.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-016-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-002.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-016.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-016.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-017-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-003.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-017.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-017.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-018-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-004.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-018.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-018.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-019-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-005.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-019.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-019.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-020-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-006.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-020.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-020.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-021-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-007.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-021.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-022-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-008.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-022.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-023-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-009.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-023.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-024-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-010.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-024.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-025-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-025.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-026-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-002.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-026.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-020.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-027-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-003.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-027.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-020.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-028-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-004.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-028.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-with-margin-collapsing-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-005.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-with-margin-collapsing-001.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-with-margin-collapsing-002-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-006.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-with-margin-collapsing-002.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-007.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-001.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-002-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-008.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-002.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-003-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-003.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-003.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-004-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-002.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-004.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-005-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-003.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-005.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-005.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-006-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-004.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-006.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-006.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-007-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-007.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-007.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-008-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-002.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-008.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-008.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-009-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-003.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-009.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-009.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-010-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-004.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-010.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-010.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-011-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-005.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-011.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-012-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-006.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-012.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-013-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-007.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-013.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-009.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-014-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-008.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-014.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-009.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-015-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-009.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-015.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-016-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-010.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-016.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-003.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-017-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-011.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-017.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-005.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-018-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-012.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-018.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-003.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-019-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-019.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-020-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-020.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-021-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-021.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-022-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-022.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-023-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-023.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-024-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-024.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-001-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-002-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-002.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-003-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-003.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-004-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-004.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-005-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-005.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-005.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-006-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-006.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-006.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-007-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-007.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-007.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-008-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-008.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-008.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-computed.html:
  • web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-invalid.html:
  • web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-valid.html:
  • web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-001-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-002-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-002.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-003-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-003.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-004-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-004.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-001.tentative-expected.txt: Removed.
  • web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-002.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-002.tentative-expected.txt: Removed.
  • web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-003.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-003.tentative-expected.txt: Removed.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-001-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-001.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-002-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-002.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-003-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-003.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-004-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-004.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-005-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-005.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-005.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-006-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-006.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-006.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-007-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-007.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-007.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-008-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-008.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-008.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-009-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-009.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-009.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-010-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-010.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-010.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-011-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-011.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-011.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-012-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-012.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-012.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-013-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-013.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-014-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-014.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-015-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-015.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-011.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-016-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-016.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-017-expected.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-017.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-018-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-018.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-001.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-019-expected.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-019.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-020-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-020.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-006.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-021-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-021.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-006.tentative.html.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-022-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-022.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-023-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-023.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-024-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-024.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-025-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-025.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-026-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-026.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-027-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.tentative-expected.xht.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-027.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/small-aspect-ratio-crash.html: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/w3c-import.log:
8:32 AM Changeset in webkit [269186] by Chris Dumez
  • 39 edits
    2 copies
    2 adds
    1 delete in trunk/LayoutTests

Resync web-platform-tests/resources tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=218351

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Resync web-platform-tests/resources tests from upstream 5dbb0a3fa631ef73da0.

  • web-platform-tests/resources/*: Updated.
  • web-platform-tests/console/idlharness.any-expected.txt:
  • web-platform-tests/console/idlharness.any.worker-expected.txt:
  • web-platform-tests/content-security-policy/frame-src/frame-src-same-document-meta.sub.html:
  • web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-long-crash-expected.txt:
  • web-platform-tests/css/css-text/text-indent/text-indent-long-line-crash-expected.txt:
  • web-platform-tests/css/cssom/idlharness-expected.txt:
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/anchor-fragment-form-submit-withpath.html:
  • web-platform-tests/html/cross-origin-embedder-policy/reporting-navigation.https.html:
  • web-platform-tests/html/cross-origin-embedder-policy/require-corp-about-blank.https-expected.txt:
  • web-platform-tests/html/cross-origin-embedder-policy/require-corp-about-srcdoc.https-expected.txt:
  • web-platform-tests/html/cross-origin-embedder-policy/require-corp.https-expected.txt:
  • web-platform-tests/wasm/jsapi/idlharness.any-expected.txt:
  • web-platform-tests/web-share/share-url-invalid.https.html:
  • web-platform-tests/webrtc/RTCPeerConnection-getStats.https.html:
  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html:
  • web-platform-tests/webrtc/RTCPeerConnection-track-stats.https-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-track-stats.https.html:
  • web-platform-tests/webrtc/legacy/RTCPeerConnection-addStream.https.html:
  • Rebaseline a few tests that have different output.
  • I resync'd from upstream a few tests that would have stopped running properly after the resources/ folder resync.

LayoutTests:

Rebaseline test that has different output.

  • platform/mac-wk2/imported/w3c/web-platform-tests/web-share/share-url-invalid.https-expected.txt:
7:02 AM Changeset in webkit [269185] by Karl Rackler
  • 2 edits
    1 delete in trunk/LayoutTests

REGRESSION (r269070): [ Big Sur ] editing/input/reveal-caret-of-multiline-input.html is a constant failure
rdar://70819245
Re-baseline for Mojave after r269174.

Unreviewed test gardening.

  • platform/mac-bigsur/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
  • platform/mac-mojave/editing/input/reveal-caret-of-multiline-input-expected.txt:
6:59 AM Changeset in webkit [269184] by Simon Fraser
  • 42 edits in trunk/Source

Convert ScrollingTreeNode change flags to an OptionSet<>
https://bugs.webkit.org/show_bug.cgi?id=218374

Reviewed by Antti Koivisto.

Address the FIXME in ScrollingStateNode.h and use an OptionSet<> for the
ScrollingState tree change flags. This required moving them all into
the same enum class in ScrollingStateNode.

Source/WebCore:

  • page/scrolling/ScrollingStateFixedNode.cpp:

(WebCore::ScrollingStateFixedNode::setPropertyChangesAfterReattach):
(WebCore::ScrollingStateFixedNode::updateConstraints):
(WebCore::ScrollingStateFixedNode::setPropertyChangedBitsAfterReattach): Deleted.

  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
(WebCore::ScrollingStateFrameScrollingNode::setPropertyChangesAfterReattach):
(WebCore::ScrollingStateFrameScrollingNode::setFrameScaleFactor):
(WebCore::ScrollingStateFrameScrollingNode::setEventTrackingRegions):
(WebCore::ScrollingStateFrameScrollingNode::setScrollBehaviorForFixedElements):
(WebCore::ScrollingStateFrameScrollingNode::setLayoutViewport):
(WebCore::ScrollingStateFrameScrollingNode::setMinLayoutViewportOrigin):
(WebCore::ScrollingStateFrameScrollingNode::setMaxLayoutViewportOrigin):
(WebCore::ScrollingStateFrameScrollingNode::setOverrideVisualViewportSize):
(WebCore::ScrollingStateFrameScrollingNode::setHeaderHeight):
(WebCore::ScrollingStateFrameScrollingNode::setFooterHeight):
(WebCore::ScrollingStateFrameScrollingNode::setTopContentInset):
(WebCore::ScrollingStateFrameScrollingNode::setRootContentsLayer):
(WebCore::ScrollingStateFrameScrollingNode::setCounterScrollingLayer):
(WebCore::ScrollingStateFrameScrollingNode::setInsetClipLayer):
(WebCore::ScrollingStateFrameScrollingNode::setContentShadowLayer):
(WebCore::ScrollingStateFrameScrollingNode::setHeaderLayer):
(WebCore::ScrollingStateFrameScrollingNode::setFooterLayer):
(WebCore::ScrollingStateFrameScrollingNode::setVisualViewportIsSmallerThanLayoutViewport):
(WebCore::ScrollingStateFrameScrollingNode::setFixedElementsLayoutRelativeToFrame):
(WebCore::ScrollingStateFrameScrollingNode::setAsyncFrameOrOverflowScrollingEnabled):
(WebCore::ScrollingStateFrameScrollingNode::setPropertyChangedBitsAfterReattach): Deleted.

  • page/scrolling/ScrollingStateFrameScrollingNode.h:
  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::ScrollingStateNode):
(WebCore::ScrollingStateNode::setPropertyChanged):
(WebCore::ScrollingStateNode::setPropertyChangesAfterReattach):
(WebCore::ScrollingStateNode::appendChild):
(WebCore::ScrollingStateNode::insertChild):
(WebCore::ScrollingStateNode::removeChildAtIndex):
(WebCore::ScrollingStateNode::setLayer):
(WebCore::ScrollingStateNode::setPropertyChangedBitsAfterReattach): Deleted.

  • page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::hasChangedProperties const):
(WebCore::ScrollingStateNode::hasChangedProperty const):
(WebCore::ScrollingStateNode::resetChangedProperties):
(WebCore::ScrollingStateNode::changedProperties const):
(WebCore::ScrollingStateNode::setChangedProperties):
(WebCore::ScrollingStateNode::setPropertyChangedInternal):
(WebCore::ScrollingStateNode::setPropertyChangedBit): Deleted.

  • page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp:

(WebCore::ScrollingStateOverflowScrollProxyNode::setPropertyChangesAfterReattach):
(WebCore::ScrollingStateOverflowScrollProxyNode::setOverflowScrollingNode):
(WebCore::ScrollingStateOverflowScrollProxyNode::setPropertyChangedBitsAfterReattach): Deleted.

  • page/scrolling/ScrollingStateOverflowScrollProxyNode.h:
  • page/scrolling/ScrollingStatePositionedNode.cpp:

(WebCore::ScrollingStatePositionedNode::setPropertyChangesAfterReattach):
(WebCore::ScrollingStatePositionedNode::setRelatedOverflowScrollingNodes):
(WebCore::ScrollingStatePositionedNode::updateConstraints):
(WebCore::ScrollingStatePositionedNode::setPropertyChangedBitsAfterReattach): Deleted.

  • page/scrolling/ScrollingStatePositionedNode.h:
  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setPropertyChangesAfterReattach):
(WebCore::ScrollingStateScrollingNode::setScrollableAreaSize):
(WebCore::ScrollingStateScrollingNode::setTotalContentsSize):
(WebCore::ScrollingStateScrollingNode::setReachableContentsSize):
(WebCore::ScrollingStateScrollingNode::setScrollPosition):
(WebCore::ScrollingStateScrollingNode::setScrollOrigin):
(WebCore::ScrollingStateScrollingNode::setHorizontalSnapOffsets):
(WebCore::ScrollingStateScrollingNode::setVerticalSnapOffsets):
(WebCore::ScrollingStateScrollingNode::setHorizontalSnapOffsetRanges):
(WebCore::ScrollingStateScrollingNode::setVerticalSnapOffsetRanges):
(WebCore::ScrollingStateScrollingNode::setCurrentHorizontalSnapPointIndex):
(WebCore::ScrollingStateScrollingNode::setCurrentVerticalSnapPointIndex):
(WebCore::ScrollingStateScrollingNode::setScrollableAreaParameters):
(WebCore::ScrollingStateScrollingNode::setSynchronousScrollingReasons):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollData):
(WebCore::ScrollingStateScrollingNode::setIsMonitoringWheelEvents):
(WebCore::ScrollingStateScrollingNode::setScrollContainerLayer):
(WebCore::ScrollingStateScrollingNode::setScrolledContentsLayer):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollbarLayer):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollbarLayer):
(WebCore::ScrollingStateScrollingNode::setPropertyChangedBitsAfterReattach): Deleted.

  • page/scrolling/ScrollingStateScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.cpp:

(WebCore::ScrollingStateStickyNode::setPropertyChangesAfterReattach):
(WebCore::ScrollingStateStickyNode::updateConstraints):
(WebCore::ScrollingStateStickyNode::setPropertyChangedBitsAfterReattach): Deleted.

  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::nodeWasReattachedRecursive):

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitTreeState):

  • page/scrolling/ScrollingTreeFrameScrollingNode.cpp:

(WebCore::ScrollingTreeFrameScrollingNode::commitStateBeforeChildren):

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren):
(WebCore::ScrollingTreeScrollingNode::commitStateAfterChildren):

  • page/scrolling/cocoa/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::commitStateBeforeChildren):

  • page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.mm:

(WebCore::ScrollingTreeOverflowScrollProxyNode::commitStateBeforeChildren):

  • page/scrolling/cocoa/ScrollingTreePositionedNode.mm:

(WebCore::ScrollingTreePositionedNode::commitStateBeforeChildren):

  • page/scrolling/cocoa/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::commitStateBeforeChildren):

  • page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:

(WebCore::ScrollingStateScrollingNode::setScrollerImpsFromScrollbars):

  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateAfterChildren):

  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:

(WebCore::ScrollingTreeOverflowScrollingNodeMac::commitStateAfterChildren):

  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::updateFromStateNode):

  • page/scrolling/nicosia/ScrollingTreeFixedNode.cpp:

(WebCore::ScrollingTreeFixedNode::commitStateBeforeChildren):

  • page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateAfterChildren):

  • page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.cpp:

(WebCore::ScrollingTreeOverflowScrollProxyNode::commitStateBeforeChildren):

  • page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::commitStateAfterChildren):

  • page/scrolling/nicosia/ScrollingTreePositionedNode.cpp:

(WebCore::ScrollingTreePositionedNode::commitStateBeforeChildren):

  • page/scrolling/nicosia/ScrollingTreeStickyNode.cpp:

(WebCore::ScrollingTreeStickyNode::commitStateBeforeChildren):

Source/WebKit:

  • Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateNode>::encode):
(ArgumentCoder<ScrollingStateNode>::decode):
(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateFrameScrollingNode>::encode):
(ArgumentCoder<ScrollingStateOverflowScrollProxyNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):
(ArgumentCoder<ScrollingStateFrameScrollingNode>::decode):
(ArgumentCoder<ScrollingStateOverflowScrollProxyNode>::decode):
(ArgumentCoder<ScrollingStateFixedNode>::encode):
(ArgumentCoder<ScrollingStateFixedNode>::decode):
(ArgumentCoder<ScrollingStateStickyNode>::encode):
(ArgumentCoder<ScrollingStateStickyNode>::decode):
(ArgumentCoder<ScrollingStatePositionedNode>::encode):
(ArgumentCoder<ScrollingStatePositionedNode>::decode):
(WebKit::dump):

  • UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

  • UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

  • UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm:

(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::commitStateBeforeChildren):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::commitStateAfterChildren):

  • UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateBeforeChildren):

  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateBeforeChildren):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateAfterChildren):

  • UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp:

(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::commitStateBeforeChildren):

  • UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.cpp:

(WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::commitStateBeforeChildren):

5:32 AM Changeset in webkit [269183] by Lauro Moura
  • 2 edits in trunk/Tools

webkitpy: Sync package versions with WPT suite
https://bugs.webkit.org/show_bug.cgi?id=217826
<rdar://problem/70619091>

Reviewed by Carlos Garcia Campos.

Sync most packages. funcsics is already imported with a newer version
in webkitcorepy.

  • Scripts/webkitpy/init.py:
5:28 AM Changeset in webkit [269182] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Re-add Martin Robinson as a committer
https://bugs.webkit.org/show_bug.cgi?id=218376

Patch by Martin Robinson <mrobinson@igalia.com> on 2020-10-30
Reviewed by Žan Doberšek.

  • Scripts/webkitpy/common/config/contributors.json: Updated with new status.
3:27 AM Changeset in webkit [269181] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build error with release build with -DLOG_DISABLED=0
https://bugs.webkit.org/show_bug.cgi?id=218338

Add the proper ifdefs to solve it.

Patch by Alejandro G. Castro <alex@igalia.com> on 2020-10-30
Reviewed by Adrian Perez de Castro.

  • display/DisplayTreeBuilder.cpp:

(WebCore::Display::TreeBuilder::build const):

3:27 AM Changeset in webkit [269180] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening

Remove tests marked as flaky for bug #198830 that have been consistently passing in the last
4000 GTK Release builds.

  • platform/gtk/TestExpectations:
1:40 AM Changeset in webkit [269179] by magomez@igalia.com
  • 4 edits in trunk/Source/WebCore

[GTK] Direct composited images may not be rendered after a window resize
https://bugs.webkit.org/show_bug.cgi?id=218292

Reviewed by Carlos Garcia Campos.

Ensure that valid buffers passed for ImageBackings are not destroyed until the
CoordinatedGraphicsScene consumes them.

  • platform/graphics/nicosia/texmap/NicosiaImageBackingTextureMapperImpl.cpp:

(Nicosia::ImageBackingTextureMapperImpl::flushUpdate):

  • platform/graphics/nicosia/texmap/NicosiaImageBackingTextureMapperImpl.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):

Oct 29, 2020:

8:26 PM Changeset in webkit [269178] by clopez@igalia.com
  • 3 edits in trunk/LayoutTests

[GTK][WPE] Gardening of new failures after r269177 and mark more flaky tests.

Unreviewed gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
7:27 PM Changeset in webkit [269177] by mmaxfield@apple.com
  • 3 edits
    94 adds in trunk/LayoutTests

[GPU Process] Add tests for sbix and COLR fonts in canvas
https://bugs.webkit.org/show_bug.cgi?id=218346

Reviewed by Simon Fraser.

Test all the relevant combinations of:
{CTM, no CTM} x
{line dash, no line dash} x
{color style, gradient style} x
{shadow, no shadow} x
{fill, stroke} x
{sbix, COLR}.

We actually care about the combinations because we have some codepaths (e.g. emulated shadows)
that only are triggered when 2 or more of the above are active.

Image orientation only works in http tests, so the sbix font is used in http/tests/.
See https://bugs.webkit.org/show_bug.cgi?id=217808 for more information.

  • fast/text/canvas-color-fonts/COLR-expected.html: Added.
  • fast/text/canvas-color-fonts/COLR.html: Added.
  • fast/text/canvas-color-fonts/ctm-COLR-expected.html: Added.
  • fast/text/canvas-color-fonts/ctm-COLR.html: Added.
  • fast/text/canvas-color-fonts/fill-color-COLR-expected.html: Added.
  • fast/text/canvas-color-fonts/fill-color-COLR.html: Added.
  • fast/text/canvas-color-fonts/fill-color-shadow-COLR-expected.html: Added.
  • fast/text/canvas-color-fonts/fill-color-shadow-COLR.html: Added.
  • fast/text/canvas-color-fonts/fill-color-shadow-ctm-COLR-expected.html: Added.
  • fast/text/canvas-color-fonts/fill-color-shadow-ctm-COLR.html: Added.
  • fast/text/canvas-color-fonts/fill-gradient-COLR-2-expected-mismatch.html: Added.
  • fast/text/canvas-color-fonts/fill-gradient-COLR-2.html: Added.
  • fast/text/canvas-color-fonts/fill-gradient-COLR-expected.html: Added.
  • fast/text/canvas-color-fonts/fill-gradient-COLR.html: Added.
  • fast/text/canvas-color-fonts/linedash-COLR-expected-mismatch.html: Added.
  • fast/text/canvas-color-fonts/linedash-COLR.html: Added.
  • fast/text/canvas-color-fonts/linedash-outlines-expected-mismatch.html: Added.
  • fast/text/canvas-color-fonts/linedash-outlines.html: Added.
  • fast/text/canvas-color-fonts/resources/Ahem-COLR.ttf: Added.
  • fast/text/canvas-color-fonts/stroke-color-COLR-expected.html: Added.
  • fast/text/canvas-color-fonts/stroke-color-COLR.html: Added.
  • fast/text/canvas-color-fonts/stroke-color-shadow-COLR-expected.html: Added.
  • fast/text/canvas-color-fonts/stroke-color-shadow-COLR.html: Added.
  • fast/text/canvas-color-fonts/stroke-color-shadow-ctm-COLR-expected.html: Added.
  • fast/text/canvas-color-fonts/stroke-color-shadow-ctm-COLR.html: Added.
  • fast/text/canvas-color-fonts/stroke-gradient-COLR-2-expected-mismatch.html: Added.
  • fast/text/canvas-color-fonts/stroke-gradient-COLR-2.html: Added.
  • fast/text/canvas-color-fonts/stroke-gradient-COLR-3-expected-mismatch.html: Added.
  • fast/text/canvas-color-fonts/stroke-gradient-COLR-3.html: Added.
  • fast/text/canvas-color-fonts/stroke-gradient-COLR-4-expected-mismatch.html: Added.
  • fast/text/canvas-color-fonts/stroke-gradient-COLR-4.html: Added.
  • fast/text/canvas-color-fonts/stroke-gradient-COLR-5-expected-mismatch.html: Added.
  • fast/text/canvas-color-fonts/stroke-gradient-COLR-5.html: Added.
  • fast/text/canvas-color-fonts/stroke-gradient-COLR-expected.html: Added.
  • fast/text/canvas-color-fonts/stroke-gradient-COLR.html: Added.
  • http/tests/canvas/color-fonts/ctm-sbix-2-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/ctm-sbix-2.html: Added.
  • http/tests/canvas/color-fonts/ctm-sbix-3-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/ctm-sbix-3.html: Added.
  • http/tests/canvas/color-fonts/ctm-sbix-4-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/ctm-sbix-4.html: Added.
  • http/tests/canvas/color-fonts/ctm-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/ctm-sbix.html: Added.
  • http/tests/canvas/color-fonts/fill-color-sbix-2-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/fill-color-sbix-2.html: Added.
  • http/tests/canvas/color-fonts/fill-color-sbix-3-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/fill-color-sbix-3.html: Added.
  • http/tests/canvas/color-fonts/fill-color-sbix-4-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/fill-color-sbix-4.html: Added.
  • http/tests/canvas/color-fonts/fill-color-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/fill-color-sbix.html: Added.
  • http/tests/canvas/color-fonts/fill-color-shadow-ctm-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/fill-color-shadow-ctm-sbix.html: Added.
  • http/tests/canvas/color-fonts/fill-color-shadow-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/fill-color-shadow-sbix.html: Added.
  • http/tests/canvas/color-fonts/fill-gradient-sbix-2-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/fill-gradient-sbix-2.html: Added.
  • http/tests/canvas/color-fonts/fill-gradient-sbix-3-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/fill-gradient-sbix-3.html: Added.
  • http/tests/canvas/color-fonts/fill-gradient-sbix-4-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/fill-gradient-sbix-4.html: Added.
  • http/tests/canvas/color-fonts/fill-gradient-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/fill-gradient-sbix.html: Added.
  • http/tests/canvas/color-fonts/linedash-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/linedash-sbix.html: Added.
  • http/tests/canvas/color-fonts/resources/Ahem-sbix.ttf: Added.
  • http/tests/canvas/color-fonts/resources/image1.jpg: Added.
  • http/tests/canvas/color-fonts/resources/image2.jpg: Added.
  • http/tests/canvas/color-fonts/stroke-color-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/stroke-color-sbix.html: Added.
  • http/tests/canvas/color-fonts/stroke-color-shadow-ctm-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/stroke-color-shadow-ctm-sbix.html: Added.
  • http/tests/canvas/color-fonts/stroke-color-shadow-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/stroke-color-shadow-sbix.html: Added.
  • http/tests/canvas/color-fonts/stroke-gradient-sbix-2-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html: Added.
  • http/tests/canvas/color-fonts/stroke-gradient-sbix-3-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html: Added.
  • http/tests/canvas/color-fonts/stroke-gradient-sbix-4-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html: Added.
  • http/tests/canvas/color-fonts/stroke-gradient-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/stroke-gradient-sbix.html: Added.
  • http/tests/canvas/color-fonts/text-sbix-2-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/text-sbix-2.html: Added.
  • http/tests/canvas/color-fonts/text-sbix-3-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/text-sbix-3.html: Added.
  • http/tests/canvas/color-fonts/text-sbix-4-expected-mismatch.html: Added.
  • http/tests/canvas/color-fonts/text-sbix-4.html: Added.
  • http/tests/canvas/color-fonts/text-sbix-expected.html: Added.
  • http/tests/canvas/color-fonts/text-sbix.html: Added.
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
6:17 PM Changeset in webkit [269176] by weinig@apple.com
  • 33 edits
    4 deletes in trunk

Remove all remaining boolean overridePreference calls
https://bugs.webkit.org/show_bug.cgi?id=218355

Reviewed by Darin Adler.
Tools:

Add a few more defaults for DumpRenderTree to allow them to be
used as test header commands.

  • DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):

LayoutTests:

Remove unnecessary testRunner.overridePreference calls (for features on
by default) and replace others with test header commands or internals.settings
as appropriate.

  • fast/canvas/webgl/resources/js-test-pre.js:
  • fast/dom/timer-throttling-hidden-page-non-nested.html:
  • fast/dom/timer-throttling-hidden-page.html:
  • fast/events/resources/tabindex-focus-blur-all.js:
  • fast/harness/override-preferences-2-expected.txt: Removed.
  • fast/harness/override-preferences-2.html: Removed.
  • fast/harness/override-preferences-expected.txt: Removed.
  • fast/harness/override-preferences.html: Removed.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html:
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html:
  • fast/mediacapturefromelement/resources/webgl-test.js:
  • fast/parser/noscript-with-javascript-disabled.html:
  • fast/parser/noscript-with-javascript-enabled.html:
  • http/tests/cache/display-image-unset-allows-cached-image-load.html:
  • http/tests/misc/favicon-loads-with-icon-loading-override.html:
  • http/tests/misc/favicon-loads-with-images-disabled.html:
  • http/tests/xsl/xslt-transform-with-javascript-disabled.html:
  • media/remove-video-best-media-element-in-main-frame-crash.html:
  • platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate.html:
  • platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html:
  • platform/mac-wk2/plugins/destroy-during-async-npp-new.html:
  • platform/mac-wk2/plugins/script-object-access-fails-during-slow-initialization.html:
  • platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-multiple.html:
  • platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization.html:
  • svg/as-image/svg-image-with-data-uri-images-disabled.html:
  • webaudio/resources/audio-testing.js:
  • webgl/1.0.3/resources/webgl_test_files/conformance/more/unit.js:
  • webgl/1.0.3/resources/webgl_test_files/resources/js-test-pre.js:
  • webgl/2.0.0/resources/webgl_test_files/conformance/more/unit.js:
  • webgl/2.0.0/resources/webgl_test_files/js/js-test-pre.js:
  • webgl/resources/js-test-pre.js:
  • webgl/resources/webgl_test_files/js/js-test-pre.js:
5:55 PM Changeset in webkit [269175] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'value.truncate')
https://bugs.webkit.org/show_bug.cgi?id=218061
<rdar://problem/70551334>

Patch by Federico Bucchi <Federico Bucchi> on 2020-10-29
Reviewed by Devin Rousso.

  • UserInterface/Views/DOMStorageContentView.js:

(WI.DOMStorageContentView.prototype.itemUpdated):

3:58 PM Changeset in webkit [269174] by Karl Rackler
  • 2 edits
    2 copies
    2 adds in trunk/LayoutTests

REGRESSION (r269070): [ Big Sur ] editing/input/reveal-caret-of-multiline-input.html is a constant failure
rdar://70819245
Re-baseline for Big Sur.

Unreviewed test gardening.

  • platform/mac-bigsur/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/mac-catalina/editing/Input/reveal-caret-of-multiline-input-expected.txt: Copied from LayoutTests/platform/mac-bigsur/editing/input/reveal-caret-of-multiline-input-expected.txt.
  • platform/mac-mojave/editing/input/reveal-caret-of-multiline-input-expected.txt: Copied from LayoutTests/platform/mac-bigsur/editing/input/reveal-caret-of-multiline-input-expected.txt.
3:26 PM Changeset in webkit [269173] by Aditya Keerthi
  • 11 edits in trunk

[Cocoa] Remove soft linking of NetworkExtension.framework
https://bugs.webkit.org/show_bug.cgi?id=218314
<rdar://problem/70785239>

Reviewed by Andy Estes.

Source/WebCore:

WebCore should link NetworkExtension.framework normally, to avoid the
runtime cost associated with soft linking.

  • Configurations/WebCore.xcconfig:

On macOS, weak link the framework since NetworkExtension.framework is
not available on the Base System.

  • platform/cocoa/NetworkExtensionContentFilter.h:

Added the isRequired static method to avoid soft linking
NetworkExtension.framework in WebKit.

  • platform/cocoa/NetworkExtensionContentFilter.mm:

Only compile this file in the ENABLE(CONTENT_FILTERING) build, as its
functionality is unavailable on tvOS.

(WebCore::NetworkExtensionContentFilter::enabled):
(WebCore::NetworkExtensionContentFilter::initialize):
(WebCore::NetworkExtensionContentFilter::unblockHandler const):
(WebCore::NetworkExtensionContentFilter::isRequired):

Source/WebKit:

  • UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::addPlatformLoadParameters):

Replaced the soft linked method call with a new method exported from
WebCore.

  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::platformDidReceiveLoadParameters):

Tools:

Updated a test to reflect that NetworkExtension.framework is no longer
loaded at runtime. This test was failing on Catalina after r269109,
as the Contacts framework was loading NetworkExtension.

  • TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.h:
  • TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:

(-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:]):
(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm:

(-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):

3:01 PM Changeset in webkit [269172] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[GLIB] Gardening scroll failure

Unreviewed test gardening.

  • platform/glib/TestExpectations:
2:38 PM Changeset in webkit [269171] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

JavaScriptCore should support multiple build variants
<https://webkit.org/b/218347>
<rdar://problem/70786057>

Patch by Jérôme Decoodt <jdecoodt@apple.com> on 2020-10-29
Reviewed by Keith Miller.

Update JavaScriptCore to handle BUILD_VARIANTS properly by
passing the value to build phase scripts and handling all
variants set during the build. For engineering builds,
BUILD_VARIANTS=normal.

  • CMakeLists.txt:
  • Update to pass equivalent ${BUILD_VARIANTS} for non-Apple platforms to asm.rb and generate_offset_extractor.rb.

(LLInt Offsets | Generate Derived Sources):
(Offline Assembler | Offline Assemble):

  • Update build phase script to pass "${BUILD_VARIANTS}" as an argument to scripts.
  • offlineasm/asm.rb:
  • Parse BUILD_VARIANTS argument to pass to offsetsAndConfigurationIndexForVariants().
  • offlineasm/generate_offset_extractor.rb:
  • Parse BUILD_VARIANTS argument to pass to configurationIndicesForVariants().
  • offlineasm/offsets.rb:

(offsetsAndConfigurationIndex):

  • Update argument list in comment block.

(offsetsAndConfigurationIndexForVariants): Add.

  • Invoke offsetsAndConfigurationIndex() for each build variant.

(configurationIndices):

  • Update argument list in comment block.

(configurationIndicesForVariants): Add.

  • Invoke configurationIndices() for each build variant.
2:35 PM Changeset in webkit [269170] by Chris Dumez
  • 7 edits in trunk

Source/WebCore:
Regression(PSON): Back/forward navigation may hang
https://bugs.webkit.org/show_bug.cgi?id=216611
<rdar://problem/68992714>

Reviewed by Geoffrey Garen.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadItem):
Add assertion that would have hit when reproducing the bug. A crash in debug is better than
hanging.

Source/WebKit:
Regression(PSON): Back/forward navigation may hang
https://bugs.webkit.org/show_bug.cgi?id=216611
<rdar://problem/68992714>

Reviewed by Geoffrey Garen.

The scenario was as follows:

  1. Load A in Process P1
  2. Load A#foo in Process P1 (fragment navigation)
  3. Load B in Process P2
  4. history.go(-2) to load A again in P1
  5. history.go(2) to load B again in P2
  6. history.back() to go back to A#foo in P1

-> Hang

We doing the process swap at step 3, we would suspend the page containing A#foo
in P1 when doing the new load in P2. When process swapping again at step 4,
we would go back to process P1 (because it is same origin) but we did not have
any suspended WebPage for A so we would create a new WebPage (with a new
WebPageIdentifier). The reason we do this is to allow the suspended WebPage
for A#foo to remain in process, as we may want it for another back/forward
navigation later.

The issue was that when constructing the new WebPage in P1 for A at step 4,
we would restore all history items from the WebPageProxy's BackForwardList
and overwrite any existing HistoryItems with the same IDs in the WebProcess.
This meant that WebKit layer would construct new HistoryItems for
HistoryItems that already existing and are used by the Suspended WebPage
containing A#foo.

Later on, at step 6, when trying to go back A#foo in P1, we would ask
the Suspended WebPage in P1 to load a given HistoryItem. This HistoryItem
is supposed to be present in the Page's back/forward list and is supposed
to have an associated back/forward cache entry. However, it was not the
case here because we ended up with a new HistoryItem instance that was
restored from the UIProcess earlier.

To address the issue, The WebPage constructor no longer overwrites
existing HistoryItems. Note that before prior to r231048, the WebPage
constructor was NOT overwriting existing HistoryItems so this restores
previous behavior. Presumably, we started overwriting to stop hitting
the assertion in WebBackForwardListProxy::addItemFromUIProcess() that
checked that we either wanted to overwrite or that there was no
existing HistoryItem with the given ID. This is no longer an issue
since I replaced this assertion with an if-check and an early return.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::addItemFromUIProcess):

  • WebProcess/WebPage/WebPage.cpp:

Tools:
Regression(PSON): Back/forward navigation may hang
https://bugs.webkit.org/show_bug.cgi?id=216611
<rdar://problem/68992714>

Reviewed by Geoffrey Garen.

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2:22 PM Changeset in webkit [269169] by Karl Rackler
  • 2 edits in trunk/LayoutTests

Unreviewed, reverting r269167.

This reverts commit 269167 because it was in the incorrect
location.

Reverted changeset:

"REGRESSION (r269070): [ Big Sur ] editing/input/reveal-caret-
of-multiline-input.html is a constant failure"
https://trac.webkit.org/changeset/269167

2:10 PM Changeset in webkit [269168] by jiewen_tan@apple.com
  • 50 edits in trunk

[WebAuthn] Make WebContent process talk to the WebAuthn process for WebAuthn requests
https://bugs.webkit.org/show_bug.cgi?id=218070
<rdar://problem/70384404>

Reviewed by Brent Fulgham.

Source/WebCore:

Covered by existing tests.

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebAuthenticationModernEnabled):
(WebCore::RuntimeEnabledFeatures::webAuthenticationModernEnabled const):
Adds bindings in WebCore.

Source/WebKit:

Once modern web authentication is enabled, let WebContent process talk to the WebAuthn process
for WebAuthn requests.

  • Scripts/process-entitlements.sh:

Adds necessary entitlements for the WebAuthn process.

  • UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::handleRequest):
Adds a way to distinguish if itself is in the UI Process or in the WebAuthn process.

  • WebAuthnProcess/WebAuthnConnectionToWebProcess.cpp:

(WebKit::WebAuthnConnectionToWebProcess::makeCredential):
(WebKit::WebAuthnConnectionToWebProcess::getAssertion):
(WebKit::WebAuthnConnectionToWebProcess::handleRequest):
(WebKit::WebAuthnConnectionToWebProcess::isUserVerifyingPlatformAuthenticatorAvailable):
(WebKit::WebAuthnConnectionToWebProcess::setMockWebAuthenticationConfiguration):

  • WebAuthnProcess/WebAuthnConnectionToWebProcess.h:
  • WebAuthnProcess/WebAuthnConnectionToWebProcess.messages.in:

Adds receivers for messages coming from the web content processes.

  • WebAuthnProcess/WebAuthnProcess.cpp:

(WebKit::WebAuthnProcess::WebAuthnProcess):
(WebKit::WebAuthnProcess::setMockWebAuthenticationConfiguration):

  • WebAuthnProcess/WebAuthnProcess.h:

(WebKit::WebAuthnProcess::authenticatorManager):
Handles the authenticator managers.

  • WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:

Relaxes sandbox for necessary hardware accesses.

  • WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:

(WebKit::WebAuthenticatorCoordinator::makeCredential):
(WebKit::WebAuthenticatorCoordinator::getAssertion):
(WebKit::WebAuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setMockWebAuthenticationConfiguration):
Sends messages to the WebAuthn process accordingly.

Source/WTF:

  • Scripts/Preferences/WebPreferencesExperimental.yaml:

Adds bindings in WebCore.

LayoutTests:

Modifies tests that can run on the new WebAuthn process run on it. Some tests will require
mock UI interactions which is not currently supported for the new WebAuthn process. Therefore,
they still run on the UI process.

  • http/wpt/webauthn/ctap-hid-failure.https.html:
  • http/wpt/webauthn/ctap-hid-success.https.html:
  • http/wpt/webauthn/ctap-nfc-failure.https.html:
  • http/wpt/webauthn/idl.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-hid.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-local.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-u2f.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure.https.html:
  • http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
  • http/wpt/webauthn/public-key-credential-create-success-local.https.html:
  • http/wpt/webauthn/public-key-credential-create-success-nfc.https.html:
  • http/wpt/webauthn/public-key-credential-create-success-u2f.https.html:
  • http/wpt/webauthn/public-key-credential-create-with-invalid-parameters.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-local-silent.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-local.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-nfc.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-u2f-silent.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-u2f.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-local.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-nfc.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-u2f.https.html:
  • http/wpt/webauthn/public-key-credential-get-with-invalid-parameters.https.html:
  • http/wpt/webauthn/public-key-credential-ip-address.html:
  • http/wpt/webauthn/public-key-credential-is-user-verifying-platform-authenticator-available.html:
  • http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html:
  • http/wpt/webauthn/public-key-credential-unfocused-document.https.html:
2:07 PM Changeset in webkit [269167] by Karl Rackler
  • 2 edits in trunk/LayoutTests

REGRESSION (r269070): [ Big Sur ] editing/input/reveal-caret-of-multiline-input.html is a constant failure
rdar://70819245
Re-baseline for Big Sur.

Unreviewed test gardening.

  • platform/mac-bigsur/editing/input/reveal-caret-of-multiline-input-expected.txt:
2:00 PM Changeset in webkit [269166] by commit-queue@webkit.org
  • 81 edits in trunk/Source/WebInspectorUI

Web Inspector: update styles to use CSS properties with neutral directionality
https://bugs.webkit.org/show_bug.cgi?id=217447
<rdar://problem/70064975>

Patch by Federico Bucchi <Federico Bucchi> on 2020-10-29
Reviewed by Devin Rousso.

  • UserInterface/Debug/UncaughtExceptionReporter.css:

(.uncaught-exception-sheet):
(.uncaught-exception-sheet h1 > img):
(.uncaught-exception-sheet h2 > img):
(.uncaught-exception-sheet dd):
(.uncaught-exception-sheet ul):

  • UserInterface/Views/AuditNavigationSidebarPanel.css:

(.content-view.tab.audit .content-view .reference-page-link-container):
(body[dir=ltr] .content-view.tab.audit .content-view .reference-page-link-container): Deleted.
(body[dir=rtl] .content-view.tab.audit .content-view .reference-page-link-container): Deleted.

  • UserInterface/Views/AuditTestCaseContentView.css:

(.content-view.audit-test-case > header):
(.content-view.audit-test-case > header h1 > img):
(.content-view.audit-test-case > header > .metadata > .source):
(.content-view.audit-test-case > header > .metadata > .duration):

  • UserInterface/Views/AuditTestContentView.css:

(.content-view.audit-test > header):

  • UserInterface/Views/AuditTestGroupContentView.css:

(.content-view.audit-test-group > header):
(.content-view.audit-test-group > header > nav > .scope-bar > li:last-child):
(.content-view.audit-test-group > header > nav > .scope-bar > li > img):
(.content-view.audit-test-group > header > .percentage-pass):

  • UserInterface/Views/BezierEditor.css:

(.bezier-editor > .bezier-preview-timing):

  • UserInterface/Views/BlackboxSettingsView.css:

(.settings-view.blackbox > table > tbody td.remove-blackbox > .remove-blackbox-button):

  • UserInterface/Views/BoxModelDetailsSectionRow.css:

(.details-section .row.box-model .box.border > .label):

  • UserInterface/Views/BoxShadowEditor.css:

(.box-shadow-editor > table > tr > td):
(.box-shadow-editor > table > tr.offset-x > td > svg):

  • UserInterface/Views/BreakpointActionView.css:

(:matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)):
(.breakpoint-action-block-body > .description):

  • UserInterface/Views/BreakpointPopover.css:

(.popover .edit-breakpoint-popover-content input:is(#edit-breakpoint-popover-ignore-count, #edit-breakpoint-popover-auto-continue)):
(.popover .edit-breakpoint-popover-content > .reference-page-link-container):
(body[dir=ltr] .popover .edit-breakpoint-popover-content > .reference-page-link-container): Deleted.
(body[dir=rtl] .popover .edit-breakpoint-popover-content > .reference-page-link-container): Deleted.

  • UserInterface/Views/ButtonNavigationItem.css:

(.navigation-bar .item.button.image-and-text > span):

  • UserInterface/Views/CPUTimelineOverviewGraph.css:

(.timeline-overview-graph.cpu > .legend):
(body[dir=ltr] .timeline-overview-graph.cpu > .legend): Deleted.
(body[dir=rtl] .timeline-overview-graph.cpu > .legend): Deleted.

  • UserInterface/Views/CPUTimelineView.css:

(.timeline-view.cpu > .content .subtitle > .info):
(.timeline-view.cpu > .content > .details > .timeline-ruler):
(.timeline-view.cpu > .content > .overview > .divider):
(.timeline-view.cpu > .content > .overview .legend):
(.timeline-view.cpu > .content > .overview .legend .swatch):
(.timeline-view.cpu > .content > .overview > .chart > .container.stats > table .filter.active + .filter.active):
(body[dir=ltr] .timeline-view.cpu > .content > .details > .timeline-ruler): Deleted.
(body[dir=rtl] .timeline-view.cpu > .content > .details > .timeline-ruler): Deleted.
(body[dir=ltr] .timeline-view.cpu > .content > .overview > .divider): Deleted.
(body[dir=rtl] .timeline-view.cpu > .content > .overview > .divider): Deleted.

  • UserInterface/Views/CPUUsageCombinedView.css:

(.cpu-usage-combined-view > .details):
(.cpu-usage-combined-view > .details > .legend-container > .row > .swatch):
(body[dir=ltr] .cpu-usage-combined-view > .details): Deleted.
(body[dir=rtl] .cpu-usage-combined-view > .details): Deleted.

  • UserInterface/Views/CPUUsageView.css:

(.cpu-usage-view > .details):
(body[dir=ltr] .cpu-usage-view > .details): Deleted.
(body[dir=rtl] .cpu-usage-view > .details): Deleted.

  • UserInterface/Views/CallFrameTreeElement.css:

(.tree-outline .item.call-frame .status):
(body[dir=rtl] .tree-outline .item.call-frame .status):
(.tree-outline:not(.single-thread) > .children > .item.call-frame.async-boundary):
(.tree-outline .item.call-frame.async-boundary .icon):
(.tree-outline .item.call-frame.async-boundary::after):
(.tree-outline .item.call-frame.async-boundary::before):
(body[dir=ltr] .tree-outline .item.call-frame .status): Deleted.

  • UserInterface/Views/CallFrameView.css:

(.call-frame .icon):

  • UserInterface/Views/CanvasDetailsSidebarPanel.css:

(.sidebar > .panel.details.canvas .details-section.canvas-extensions .content > ul):

  • UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview > .content-view.canvas > footer > .view-related-items > img + img):
(.content-view.canvas-overview > .content-view.canvas > footer .memory-cost):

  • UserInterface/Views/CheckboxNavigationItem.css:

(.navigation-bar .item.checkbox label):

  • UserInterface/Views/ColorPicker.css:

(.color-picker .slider):
(.color-picker > .color-inputs > div + div):

  • UserInterface/Views/ComputedStyleSection.css:

(.computed-style-section .computed-property-item .disclosure-button):

  • UserInterface/Views/ConsoleMessageView.css:

(.console-message.expandable .console-top-level-message::before):

  • UserInterface/Views/CookiePopover.css:

(.popover .cookie-popover-content > table > tr > td):

  • UserInterface/Views/CreateAuditPopover.css:

(.popover .create-audit-content > .editor-wrapper > .reference-page-link):

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.css:

(.sidebar > .panel.dom-node-details .details-section.dom-node-associated-data > .content .row):

  • UserInterface/Views/DOMTreeContentView.css:

(.content-view.dom-tree .tree-outline.dom):
(.content-view.dom-tree.show-gutter .tree-outline.dom):
(.content-view.dom-tree .tree-outline.dom li .status-image):
(body[dir=rtl] .content-view.dom-tree .tree-outline.dom li .status-image):
(body[dir=ltr] .content-view.dom-tree .tree-outline.dom li .status-image): Deleted.

  • UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom ol):
(.tree-outline.dom li:matches(.hovered, .selected) + ol.children.expanded):

  • UserInterface/Views/DataGrid.css:

(.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
(.data-grid td .icon):
(.data-grid td .go-to-arrow):
(body[dir=ltr] .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after): Deleted.
(body[dir=rtl] .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after): Deleted.

  • UserInterface/Views/DetailsSection.css:

(.details-section > .header):
(.details-section > .header > label > input[type="checkbox"]):
(.details-section > .header .go-to-arrow):
(.details-section > .content > .group > .row.simple > .label):
(.details-section > .content > .group > .row.simple > .value):
(.details-section > .content > .group > .row.simple > .value .go-to-arrow):

  • UserInterface/Views/ErrorObjectView.css:

(.error-object > .formatted-error::before):
(.error-object .content):

  • UserInterface/Views/FilterBar.css:

(.filter-bar > input[type="search"]):
(:matches(.filter-bar, .search-bar) > input[type="search"]::-webkit-search-results-button):
(:matches(.filter-bar, .search-bar) > .navigation-bar + input[type="search"]):
(:matches(.filter-bar, .search-bar) > input[type="search"]:focus):
(:matches(.filter-bar, .search-bar) > input[type="search"] + :empty):
(:matches(.filter-bar, .search-bar) > input[type="search"] + .navigation-bar > .item.scope-bar:last-child):

  • UserInterface/Views/FindBanner.css:

(.find-banner > :first-child):
(.find-banner > :last-child):
(.find-banner > input[type="search"]):
(.find-banner > button.segmented):
(.find-banner > button.segmented.previous-result):
(.find-banner > button.segmented.next-result):
(body[dir=ltr] .find-banner > button.segmented.next-result):
(body[dir=rtl] .find-banner > button.segmented.next-result):
(.find-banner > button.segmented.next-result > .glyph):
(.find-banner.console-find-banner > input[type="search"]::-webkit-textfield-decoration-container):
(body[dir=ltr] .find-banner > button.segmented.previous-result): Deleted.
(body[dir=rtl] .find-banner > button.segmented.previous-result): Deleted.

  • UserInterface/Views/FlexibleSpaceNavigationItem.css:

(.navigation-bar .item.flexible-space.align-start > .item):
(.navigation-bar .item.flexible-space.align-end > .item):

  • UserInterface/Views/FontResourceContentView.css:

(.content-view.resource.font .preview > .line > .metric):

  • UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
(.panel.exclusive-presentation.details.css-style > .content > .rules):

  • UserInterface/Views/GraphicsOverviewContentView.css:

(.content-view.graphics-overview > section > .header):

  • UserInterface/Views/HierarchicalPathComponent.css:

(.hierarchical-path-component > :matches(.icon, .selector-arrows)):
(.hierarchical-path-component > select):
(.hierarchical-path-component > .separator):
(.hierarchical-path-component.text-only):
(body[dir=ltr] .hierarchical-path-component > select): Deleted.
(body[dir=rtl] .hierarchical-path-component > select): Deleted.
(body[dir=ltr] .hierarchical-path-component.text-only > select): Deleted.
(body[dir=rtl] .hierarchical-path-component.text-only > select): Deleted.

  • UserInterface/Views/LayerTreeDetailsSidebarPanel.css:

(.layer-tree-popover ul):

  • UserInterface/Views/Layers3DContentView.css:

(.content-view.layers-3d .layer-info ul):

  • UserInterface/Views/LocalResourceOverridePopover.css:

(.popover .local-resource-override-popover-content label.is-case-sensitive):
(.popover .local-resource-override-popover-content .editor.status-text):

  • UserInterface/Views/LogContentView.css:

(.content-view.log > .hidden-messages-banner > button):
(.content-view.log > .hidden-messages-banner > .dismiss):
(.console-group-title::before):
(body[dir=rtl] .console-group-title::before):
(body[dir=ltr] .content-view.log > .hidden-messages-banner > .dismiss): Deleted.
(body[dir=rtl] .content-view.log > .hidden-messages-banner > .dismiss): Deleted.
(body[dir=ltr] .console-group-title::before): Deleted.

  • UserInterface/Views/Main.css:

(.go-to-link:not(.dont-float)):
(@media (-webkit-device-pixel-ratio: 1) .reference-page-link):
(.device-settings-content .container > * + *):
(.device-settings-content label > input):
(.device-settings-content > .reference-page-link-container):
(body[dir=ltr] .device-settings-content > .reference-page-link-container): Deleted.
(body[dir=rtl] .device-settings-content > .reference-page-link-container): Deleted.

  • UserInterface/Views/MemoryCategoryView.css:

(.memory-category-view > .details):
(body[dir=ltr] .memory-category-view > .details): Deleted.
(body[dir=rtl] .memory-category-view > .details): Deleted.

  • UserInterface/Views/MemoryTimelineOverviewGraph.css:

(.timeline-overview-graph.memory > .legend):
(.timeline-overview-graph.memory .memory-pressure-event):
(body[dir=ltr] .timeline-overview-graph.memory > .legend): Deleted.
(body[dir=rtl] .timeline-overview-graph.memory > .legend): Deleted.
(body[dir=ltr] .timeline-overview-graph.memory .memory-pressure-event): Deleted.
(body[dir=rtl] .timeline-overview-graph.memory .memory-pressure-event): Deleted.

  • UserInterface/Views/MemoryTimelineView.css:

(.timeline-view.memory > .content > .details > .timeline-ruler):
(.timeline-view.memory > .content > .overview > .divider):
(.timeline-view.memory .legend):
(.timeline-view.memory .legend .swatch):
(body[dir=ltr] .timeline-view.memory > .content > .details > .timeline-ruler): Deleted.
(body[dir=rtl] .timeline-view.memory > .content > .details > .timeline-ruler): Deleted.
(body[dir=ltr] .timeline-view.memory > .content > .overview > .divider): Deleted.
(body[dir=rtl] .timeline-view.memory > .content > .overview > .divider): Deleted.

  • UserInterface/Views/NetworkTableContentView.css:

(.content-view.tab.network > .content-browser > .navigation-bar .hierarchical-path .icon):
(.content-view.network .network-table > .table .icon):
(.network-table > .table.grouped .data-container .cell:not(.parent).name):
(.network-table > .table.grouped .data-container .cell.child.name):
(.network-table > .table .cell.domain > .lock):
(.network-table > .table .cell.name > .status):
(.network-table > .table :not(.header) .cell.waterfall):
(.network-table > .statistics > .statistic > .text):
(body[dir=ltr] .network-table > .table :not(.header) .cell.waterfall): Deleted.
(body[dir=rtl] .network-table > .table :not(.header) .cell.waterfall): Deleted.

  • UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:

(.object-tree-array-index .index-value .object-tree .tree-outline.object):
(.object-tree-array-index .index-value .formatted-node .tree-outline.dom):

  • UserInterface/Views/ObjectTreePropertyTreeElement.css:

(.item.object-tree-property.prototype-property + ol):

  • UserInterface/Views/ObjectTreeView.css:

(.tree-outline.object ol):
(.tree-outline.object li > button[disabled] + .indeterminate-progress-spinner):

  • UserInterface/Views/OpenResourceDialog.css:

(.open-resource-dialog > .field):
(.open-resource-dialog > .field::before):
(.open-resource-dialog > .field > input):
(.open-resource-dialog > .field > img):
(.open-resource-dialog > .tree-outline .item):
(body[dir=ltr] .open-resource-dialog > .field::before): Deleted.
(body[dir=rtl] .open-resource-dialog > .field::before): Deleted.
(body[dir=ltr] .open-resource-dialog > .field > img): Deleted.
(body[dir=rtl] .open-resource-dialog > .field > img): Deleted.

  • UserInterface/Views/QuickConsole.css:

(.quick-console > .navigation-bar .active-execution-context):
(.quick-console > .navigation-bar .active-execution-context > .selector-arrows):
(.quick-console > .navigation-bar .active-execution-context:not(.automatic)):

  • UserInterface/Views/RecordingActionTreeElement.css:

(.item.recording-action:not(.initial-state)::before):
(.tree-outline:not(.hide-disclosure-buttons) .item.recording-action:not(.initial-state, .parent) > .icon):

  • UserInterface/Views/RecordingStateDetailsSidebarPanel.css:

(.sidebar > .panel.details.recording-state > .content .details-section > .header .source):

  • UserInterface/Views/ResourceDetailsSection.css:

(.resource-details > section > .details):
(.resource-details > section > .details > p):
(.resource-details > section > .details > .pair):
(.resource-details > section > .details > .pair > .key):
(body[dir=ltr] .resource-details > section > .details): Deleted.
(body[dir=rtl] .resource-details > section > .details): Deleted.

  • UserInterface/Views/ResourceSecurityContentView.css:

(.resource-security .details > .show-certificate > .key > .error):

  • UserInterface/Views/ResourceSizesContentView.css:

(.resource-sizes > .content > section.network .warning):

  • UserInterface/Views/ResourceTimingBreakdownView.css:

(.resource-timing-breakdown > table > tr > td.time):

  • UserInterface/Views/ScopeBar.css:

(.scope-bar > li.multiple > select):
(.scope-bar > li.multiple > .arrows):
(body[dir=ltr] .scope-bar > li.multiple > select): Deleted.
(body[dir=rtl] .scope-bar > li.multiple > select): Deleted.

  • UserInterface/Views/SearchSidebarPanel.css:

(.sidebar > .panel.navigation.search > .search-bar > .search-settings):

  • UserInterface/Views/SettingsTabContentView.css:

(.content-view.tab.settings > .settings-view > .container button):
(.content-view.tab.settings > .settings-view > .container > .title):
(.content-view.tab.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
(.content-view.tab.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
(.content-view.tab.settings > .settings-view > .container.reference > a):

  • UserInterface/Views/ShaderProgramContentView.css:

(.content-view.shader-program > .shader.compute,):
(body[dir=ltr] .content-view.shader-program > .shader.vertex:not(.shares-vertex-fragment-shader),):
(body[dir=ltr] .content-view.shader-program > .shader.fragment,):

  • UserInterface/Views/SingleSidebar.css:

(.single-sidebar.trailing > .resizer):
(.single-sidebar.leading > .resizer):
(body[dir=ltr] .single-sidebar.trailing > .resizer,): Deleted.
(body[dir=ltr] .single-sidebar.leading > .resizer,): Deleted.

  • UserInterface/Views/SourcesNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.sources > .content .tree-outline.single-thread):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .property .select-variable-property):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration .selector > .icon):
(.spreadsheet-css-declaration .selector > .icon + *):
(.spreadsheet-css-declaration .selector.style-attribute > span):

  • UserInterface/Views/SpringEditor.css:

(.spring-editor > .spring-timing):
(.spring-editor > .spring-timing::before):
(.spring-editor > .spring-timing::after):
(body[dir=ltr] .spring-editor > .spring-timing::before,): Deleted.
(body[dir=ltr] .spring-editor > .spring-timing::after,): Deleted.

  • UserInterface/Views/TabBar.css:

(.tab-bar > .navigation-bar > .item.group > .item:nth-child(1 of :not(.hidden))):
(.tab-bar > .navigation-bar > .item.group > .item:nth-last-child(1 of :not(.hidden))):
(body:not(.docked) .tab-bar > .tabs > .item:nth-child(n + 3 of :not(.hidden)),):
(body:not(.docked) .tab-bar > .tabs:not(.hide-border-end) > .item:nth-last-child(1 of :not(.hidden))):
(body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover,):
(body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:last-child:not(.selected, .disabled):hover):
(.tab-bar > .tabs > .item > .name):
(body[dir=ltr]:not(.docked) .tab-bar > .tabs > .item:nth-child(n + 3 of :not(.hidden)),): Deleted.
(body[dir=ltr]:not(.docked) .tab-bar > .tabs:not(.hide-border-end) > .item:nth-last-child(1 of :not(.hidden)),): Deleted.
(body[dir=ltr]:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover,): Deleted.
(body[dir=ltr]:not(.docked) .tab-bar > .tabs:not(.animating) > .item:last-child:not(.selected, .disabled):hover,): Deleted.

  • UserInterface/Views/Table.css:

(.table > .header > :matches(.sort-ascending, .sort-descending)):
(.table > .header > :matches(.sort-ascending, .sort-descending)::after):
(.table > .header .cell:not(:first-child)::before):
(body[dir=ltr] .table > .header > :matches(.sort-ascending, .sort-descending)::after): Deleted.
(body[dir=rtl] .table > .header > :matches(.sort-ascending, .sort-descending)::after): Deleted.
(body[dir=ltr] .table > .header .cell:not(:first-child)::before): Deleted.
(body[dir=rtl] .table > .header .cell:not(:first-child)::before): Deleted.

  • UserInterface/Views/ThreadTreeElement.css:

(.tree-outline > .item.thread + ol > .item.truncated-call-frames):
(.tree-outline > .item.thread + ol > .item.truncated-call-frames .icon):

  • UserInterface/Views/TimelineOverview.css:

(.timeline-overview > :matches(.navigation-bar.timelines, .tree-outline.timelines)):
(.timeline-overview:not(.frames) > :matches(.scroll-container, .timeline-ruler, .graphs-container)):
(.timeline-overview > .scroll-container > .scroll-width-sizer):
(body[dir=ltr] .timeline-overview > :matches(.navigation-bar.timelines, .tree-outline.timelines)): Deleted.
(body[dir=rtl] .timeline-overview > :matches(.navigation-bar.timelines, .tree-outline.timelines)): Deleted.
(body[dir=ltr] .timeline-overview:not(.frames) > :matches(.scroll-container, .timeline-ruler, .graphs-container)): Deleted.
(body[dir=rtl] .timeline-overview:not(.frames) > :matches(.scroll-container, .timeline-ruler, .graphs-container)): Deleted.
(body[dir=ltr] .timeline-overview > .scroll-container > .scroll-width-sizer): Deleted.
(body[dir=rtl] .timeline-overview > .scroll-container > .scroll-width-sizer): Deleted.

  • UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar > img):
(.timeline-record-bar > .segment):
(body[dir=ltr] .timeline-record-bar > .segment:last-of-type):
(body[dir=ltr] .timeline-record-bar > .segment): Deleted.
(body[dir=rtl] .timeline-record-bar > .segment): Deleted.

  • UserInterface/Views/TimelineRecordingContentView.css:

(.content-view.timeline-recording > .content-browser .recording-progress > .status > .indeterminate-progress-spinner):

  • UserInterface/Views/TimelineRuler.css:

(.timeline-ruler > .header > .divider > .label):
(.timeline-ruler > .markers > .marker):
(.timeline-ruler > .markers > .marker::before):
(.timeline-ruler > .markers > .marker::after):
(.timeline-ruler > .shaded-area.left):
(.timeline-ruler > .shaded-area.right):
(body[dir=ltr] .timeline-ruler > .header > .divider > .label): Deleted.
(body[dir=rtl] .timeline-ruler > .header > .divider > .label): Deleted.
(body[dir=ltr] .timeline-ruler > .markers > .marker): Deleted.
(body[dir=rtl] .timeline-ruler > .markers > .marker): Deleted.
(body[dir=ltr] .timeline-ruler > .markers > .marker::before): Deleted.
(body[dir=rtl] .timeline-ruler > .markers > .marker::before): Deleted.
(body[dir=ltr] .timeline-ruler > .markers > .marker::after): Deleted.
(body[dir=rtl] .timeline-ruler > .markers > .marker::after): Deleted.
(body[dir=ltr] .timeline-ruler > .shaded-area.left,): Deleted.
(body[dir=ltr] .timeline-ruler > .shaded-area.right,): Deleted.

  • UserInterface/Views/TreeOutline.css:

(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
(.tree-outline .item .icon):
(.tree-outline .item .status):

  • UserInterface/Views/TreeOutline.js:

(WI.TreeOutline._generateStyleRulesIfNeeded):

  • UserInterface/Views/TypeTreeElement.css:

(.item.type-tree-element.prototype):
(.item.type-tree-element.prototype + ol):

  • UserInterface/Views/TypeTreeView.css:

(.tree-outline.type):
(.tree-outline.type ol):
(.tree-outline.type li .empty-message):

  • UserInterface/Views/WebSocketContentView.css:

(.web-socket.content-view > .data-grid .data-column > div):
(.web-socket.content-view .icon):
(body[dir=ltr] .web-socket.content-view .icon): Deleted.
(body[dir=rtl] .web-socket.content-view .icon): Deleted.

1:51 PM Changeset in webkit [269165] by Lauro Moura
  • 4 edits in trunk/LayoutTests

[GLIB] Gardening some failures

Unreviewed test gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Rebaseline
1:23 PM Changeset in webkit [269164] by Chris Dumez
  • 16 edits
    1 move
    23 adds
    47 deletes in trunk/LayoutTests

Resync web-platform-tests/payment-request tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=218308

Reviewed by Geoff Garen.

LayoutTests/imported/w3c:

Resync web-platform-tests/payment-request tests from upstream 326f137f2c3d23c.

It drops a lot of manual tests too, now that our test importer is smart enough not to
import them.

  • resources/resource-files.json:
  • web-platform-tests/payment-request/*: Updated.

LayoutTests:

Skip a few new tests that are failing.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
1:23 PM Changeset in webkit [269163] by pvollan@apple.com
  • 3 edits in trunk/Source/WebKit

[macOS] Add required entitlement for message filtering
https://bugs.webkit.org/show_bug.cgi?id=218342
<rdar://problem/70810567>

Reviewed by Brent Fulgham.

The entitlement 'com.apple.private.security.message-filter' needs to be set to YES. This patch also
adds telemetry for mach-bootstrap filtering.

  • Scripts/process-entitlements.sh:
  • WebProcess/com.apple.WebProcess.sb.in:
1:20 PM Changeset in webkit [269162] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Don't look in the keychain for a preferred client certificate in the network process
https://bugs.webkit.org/show_bug.cgi?id=218322
<rdar://problem/64931374>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-10-29
Reviewed by Geoffrey Garen.

Often, based on a race condition of preconnecting to a server we have just been told to load and
the use of Safari's BackgroundLoad class when navigating to a page we have not received any data from yet,
and with an installed client certificate and an identity preference in the keychain, the user will be asked
if com.apple.WebKit.Networking can access a private key in the keychain instead of if Safari can access a
private key in the keychain. If the user types in the password and clicks "Always Allow" this does not make
it always allowed, but it would have if Safari had asked instead of com.apple.WebKit.Networking.
This is because Safari is responding to WKNavigationDelegate's didReceiveAuthenticationChallenge with
NSURLSessionAuthChallengeUseCredential and nil, which would cause CFNetwork to search in the keychain as the network
process for the preferred client certificate. What we want Safari's network process to do is not search in the keychain
for this preconnect request's challenge but wait until the actual request, at which time Safari will use its proper logic
to find the correct client certificate and AuthenticationManager::initializeConnection will create a SecKeyProxy
to do the signing in the UI process. Third party applications will not be affected because the SecKeyProxy path is the
only one that works for applications lacking Safari's entitlements. I used the steps in the radar to verify that this
is fixed. Unfortunately, it is not practical to make a unit test that installs a system client certificate and an
identity preference because doing so would require the entry of the login keychain password while running the unit test.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::configurationForSessionID):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

12:24 PM Changeset in webkit [269161] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebCore

Make WebCore::ContainerNode::ChildChangeType enum class
https://bugs.webkit.org/show_bug.cgi?id=218298
Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-10-29
Reviewed by Darin Adler.

And this patch moved to ChildChangeType to under ChildChange.
This patch also move ChildChangeSource to under ChildChange and specify a base type.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):
(WebCore::CharacterData::notifyParentAfterChange):

  • dom/CharacterData.h:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeAllChildrenWithScriptAssertion):
(WebCore::ContainerNode::removeNodeWithScriptAssertion):
(WebCore::executeNodeInsertionWithScriptAssertion):
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::replaceAllChildrenWithNewText):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChildWithoutPreInsertionValidityCheck):
(WebCore::ContainerNode::parserAppendChild):
(WebCore::affectsElements):
(WebCore::ContainerNode::childrenChanged):
(WebCore::ContainerNode::replaceChildren):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::ChildChange::isInsertion const):

  • dom/Element.cpp:

(WebCore::Element::childrenChanged):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::childrenChanged):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):

  • html/HTMLElement.h:
  • html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::childrenChanged):

  • svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::childrenChanged):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::childrenChanged):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::childrenChanged):

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::childrenChanged):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):

  • svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::childrenChanged):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::childrenChanged):

  • svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::childrenChanged):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::childrenChanged):

12:15 PM Changeset in webkit [269160] by sihui_liu@apple.com
  • 5 edits
    1 delete in trunk

Unreviewed, reverting r268192.

PLT regression - rdar://problem/70141350

Reverted changeset:

"Adjust heuristic for checking whether view reaches visually
non-empty state"
https://bugs.webkit.org/show_bug.cgi?id=217400
https://trac.webkit.org/changeset/268192

11:35 AM Changeset in webkit [269159] by Said Abou-Hallawa
  • 6 edits
    2 adds in trunk

REGRESSION(269065): [GPU Process]: Order of drawing has to be preserved when drawing a canvas to another canvas
https://bugs.webkit.org/show_bug.cgi?id=218324

Reviewed by Simon Fraser.

Source/WebCore:

Allow DisplayList::Recorder::Delegate to take an action after appending
a DisplayList::Item to its DisplayList::DisplayList.

Test: fast/canvas/canvas-draw-canvas-on-canvas-flushing-order.html

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::didAppendItem):
(WebCore::DisplayList::Recorder::appendItemAndUpdateExtent):
(WebCore::DisplayList::Recorder::appendItem):

  • platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::Delegate::didAppendItem):

Source/WebKit:

When drawing an ImageBuffer to another ImageBuffer, the DrawingContext of
the source and the destination ImageBuffers have to be flushed immediately.
Otherwise an older version or a newer version of the source ImageBuffer
might be drawn to the destination ImageBuffer.

  • WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

LayoutTests:

  • fast/canvas/canvas-draw-canvas-on-canvas-flushing-order-expected.html: Added.
  • fast/canvas/canvas-draw-canvas-on-canvas-flushing-order.html: Added.
11:32 AM Changeset in webkit [269158] by Russell Epstein
  • 11 edits in branches/safari-610-branch/Source

Cherry-pick r269118. rdar://problem/70795320

macCatalyst WebGL on Apple Silicon devices is using a software renderer
https://bugs.webkit.org/show_bug.cgi?id=218303
<rdar://problem/70587571>

Reviewed by Geoffrey Garen.

Source/ThirdParty/ANGLE:

  • src/gpu_info_util/SystemInfo.h:
  • src/gpu_info_util/SystemInfo_apple.mm: (angle::GetSystemInfo): We can just use the macOS version of GetSystemInfo in macCatalyst.
  • src/gpu_info_util/SystemInfo_macos.mm: (angle::GetSystemInfo_mac):
  • src/libANGLE/Display.cpp:
  • src/libANGLE/formatutils.cpp: (gl::BuildInternalFormatInfoMap):
  • src/libANGLE/renderer/gl/renderergl_utils.cpp: (rx::nativegl_gl::GenerateCaps): It turns out we must use EAGL in macCatalyst on Apple Silicon in all cases, not just in-process in iOS apps (the problem is not just about coexistence of the two GLs, but actually about our ability to load the accelerated renderer /at all/ in macCatalyst processes).

I left the runtime switching in place, because there is a future in which
we /can/ use CGL in non-iOS-app processes, but that future is not now.

Source/WebCore:

  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: (WebCore::needsEAGLOnMac): (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL): (WebCore::GraphicsContextGLOpenGL::IOSurfaceTextureTarget): (WebCore::GraphicsContextGLOpenGL::IOSurfaceTextureTargetQuery): (WebCore::GraphicsContextGLOpenGL::EGLIOSurfaceTextureTarget): (WebCore::isiOSAppOnMac): Deleted. See ANGLE ChangeLog.

Source/WebKit:

  • UIProcess/mac/HighPerformanceGPUManager.mm: (WebKit::HighPerformanceGPUManager::addProcessRequiringHighPerformance): (WebKit::HighPerformanceGPUManager::removeProcessRequiringHighPerformance): (WebKit::HighPerformanceGPUManager::updateState): (WebKit::isiOSAppOnMac): Deleted. HighPerformanceGPUManager is PLATFORM(MAC)-only, which is not true for MACCATALYST, so delete this dead code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:18 AM Changeset in webkit [269157] by weinig@apple.com
  • 7 edits in trunk

[Testing] Remove requirement of adding new SPI for each preference that needs testing (WebKitLegacy Windows)
https://bugs.webkit.org/show_bug.cgi?id=218291

Reviewed by Brent Fulgham.

Source/WebKitLegacy/win:

Expose a set of setters for DumpRenderTree to use when setting preferences
by string, matching WebKitLegacy for cocoa platforms and modern WebKit.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferences.cpp:

(WebPreferences::setBoolPreferenceForTesting):
(WebPreferences::setUInt32PreferenceForTesting):
(WebPreferences::setDoublePreferenceForTesting):
(WebPreferences::setStringPreferenceForTesting):

  • WebPreferences.h:

Tools:

Adopt set*PreferenceForTesting functions to match DumpRenderTree for cocoa platforms, and
make it so that only TestOptions.cpp needs to be touched to add support for new preference
in tests.

Also adds some helpers to convert between string types and use RetainPtr in a few more places.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(toUTF8):
(toBSTR):
(resetWebPreferencesToConsistentValues):
(boolWebPreferenceFeatureValue):
(setWebPreferencesForTestOptions):
(runTest):

11:10 AM Changeset in webkit [269156] by youenn@apple.com
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Add some logging to SequenceCheckerImpl::IsCurrent
https://bugs.webkit.org/show_bug.cgi?id=218328

Reviewed by Eric Carlson.

  • Source/webrtc/rtc_base/synchronization/sequence_checker.cc:

This might help debugging https://bugs.webkit.org/show_bug.cgi?id=218063.

10:53 AM Changeset in webkit [269155] by Noam Rosenthal
  • 3 edits
    4 adds in trunk

REGRESSION(r268249): image-orientation:none is broken for local (file://) urls
https://bugs.webkit.org/show_bug.cgi?id=217808
<rdar://problem/70603407>

Reviewed by Myles C. Maxfield.

Source/WebCore:

Use isCORSSameOrigin() instead of isOriginClean(), it's a more accureate method
for this purpose.
Allow image-orientation: none overriding when the image is local or a data-url.

Test: fast/images/image-orientation-none-local.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::allowsOrientationOverride const):

LayoutTests:

Added a tests that ensure image-orientation: none is supported in file and data URLs.

  • fast/images/image-orientation-none-local-expected.txt: Added.
  • fast/images/image-orientation-none-local.html: Added.
  • fast/images/image-orientation-none-data-url-expected.txt: Added.
  • fast/images/image-orientation-none-data-url.html: Added.
10:47 AM Changeset in webkit [269154] by Ryan Haddad
  • 3 edits in trunk/Source/WebKit

Unreviewed, reverting r269109.

Introduced dependency cycle

Reverted changeset:

"[Cocoa] Remove soft linking of Contacts.framework"
https://bugs.webkit.org/show_bug.cgi?id=218289
https://trac.webkit.org/changeset/269109

10:21 AM Changeset in webkit [269153] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

[LFC][Integration] Rename text run localStart/EndOffset to start/end
https://bugs.webkit.org/show_bug.cgi?id=218344

Reviewed by Zalan Bujtas.

There is no danger of confusion and these are called just start/end elsewhere.

  • dom/Position.cpp:

(WebCore::Position::upstream const):
(WebCore::Position::downstream const):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextRun):

  • editing/VisibleUnits.cpp:

(WebCore::startPositionForLine):
(WebCore::endPositionForLine):

  • layout/integration/LayoutIntegrationRunIterator.h:

(WebCore::LayoutIntegration::PathTextRun::start const):
(WebCore::LayoutIntegration::PathTextRun::end const):
(WebCore::LayoutIntegration::PathTextRun::localStartOffset const): Deleted.
(WebCore::LayoutIntegration::PathTextRun::localEndOffset const): Deleted.

  • layout/integration/LayoutIntegrationRunIteratorLegacyPath.h:

(WebCore::LayoutIntegration::RunIteratorLegacyPath::start const):
(WebCore::LayoutIntegration::RunIteratorLegacyPath::end const):
(WebCore::LayoutIntegration::RunIteratorLegacyPath::localStartOffset const): Deleted.
(WebCore::LayoutIntegration::RunIteratorLegacyPath::localEndOffset const): Deleted.

  • layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::minimumCaretOffset const):
(WebCore::LayoutIntegration::RunIteratorModernPath::maximumCaretOffset const):
(WebCore::LayoutIntegration::RunIteratorModernPath::start const):
(WebCore::LayoutIntegration::RunIteratorModernPath::end const):
(WebCore::LayoutIntegration::RunIteratorModernPath::localStartOffset const): Deleted.
(WebCore::LayoutIntegration::RunIteratorModernPath::localEndOffset const): Deleted.

  • rendering/RenderBlockFlow.cpp:

(WebCore::positionForRun):

  • rendering/RenderText.cpp:

(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::caretMinOffset const):
(WebCore::RenderText::caretMaxOffset const):
(WebCore::RenderText::countRenderedCharacterOffsetsUntil const):
(WebCore::containsOffset):

10:10 AM Changeset in webkit [269152] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[macOS] Add telemetry for IOKit use
https://bugs.webkit.org/show_bug.cgi?id=218343
<rdar://problem/70811875>

Reviewed by Geoffrey Garen.

Add telemetry with backtrace for IOKIt use in the WebContent process.

  • WebProcess/com.apple.WebProcess.sb.in:
9:53 AM Changeset in webkit [269151] by Chris Lord
  • 3 edits in trunk/Source/WebKit

[WPE] Add axis-locking to kinetic scrolling
https://bugs.webkit.org/show_bug.cgi?id=209729

Reviewed by Adrian Perez de Castro.

Add axis-locking to scroll gestures on WPE, and new WPE-specific
settings to control the process.

  • UIProcess/API/wpe/ScrollGestureController.cpp:

(WebKit::ScrollGestureController::handleEvent):

  • UIProcess/API/wpe/ScrollGestureController.h:
9:20 AM Changeset in webkit [269150] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

Improve LibWebRTCSocketClient logging
https://bugs.webkit.org/show_bug.cgi?id=218336

Reviewed by Eric Carlson.

Output webrtc socket identifier in case of error.
Fix the case of LibWebRTCSocketClient::sendTo that can log too much.

No observable change of behavior.

  • NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:

(WebKit::LibWebRTCSocketClient::sendTo):
(WebKit::LibWebRTCSocketClient::close):
(WebKit::LibWebRTCSocketClient::setOption):

8:51 AM Changeset in webkit [269149] by Antti Koivisto
  • 12 edits in trunk/Source/WebCore

[LFC][Integration] Rename top/bottomWithLeading to lineBoxTop/Bottom
https://bugs.webkit.org/show_bug.cgi?id=218340

Reviewed by Zalan Bujtas.

These match the spec concept of line box.
For clarity rename the legacy fields and functions in RootInlineBox too.

  • layout/integration/LayoutIntegrationLineIterator.h:

(WebCore::LayoutIntegration::PathLine::lineBoxTop const):
(WebCore::LayoutIntegration::PathLine::lineBoxBottom const):
(WebCore::LayoutIntegration::PathLine::topWithLeading const): Deleted.
(WebCore::LayoutIntegration::PathLine::bottomWithLeading const): Deleted.

  • layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:

(WebCore::LayoutIntegration::LineIteratorLegacyPath::lineBoxTop const):
(WebCore::LayoutIntegration::LineIteratorLegacyPath::lineBoxBottom const):
(WebCore::LayoutIntegration::LineIteratorLegacyPath::topWithLeading const): Deleted.
(WebCore::LayoutIntegration::LineIteratorLegacyPath::bottomWithLeading const): Deleted.

  • layout/integration/LayoutIntegrationLineIteratorModernPath.h:

(WebCore::LayoutIntegration::LineIteratorModernPath::lineBoxTop const):
(WebCore::LayoutIntegration::LineIteratorModernPath::lineBoxBottom const):
(WebCore::LayoutIntegration::LineIteratorModernPath::topWithLeading const): Deleted.
(WebCore::LayoutIntegration::LineIteratorModernPath::bottomWithLeading const): Deleted.

  • rendering/ComplexLineLayout.cpp:

(WebCore::ComplexLineLayout::layoutRunsAndFloatsInRange):
(WebCore::ComplexLineLayout::linkToEndLineIfNeeded):
(WebCore::ComplexLineLayout::checkFloatInCleanLine):
(WebCore::ComplexLineLayout::determineStartPosition):
(WebCore::ComplexLineLayout::determineEndPosition):
(WebCore::ComplexLineLayout::checkPaginationAndFloatsAtEndLine):
(WebCore::ComplexLineLayout::lineWidthForPaginatedLineChanged const):
(WebCore::ComplexLineLayout::matchedEndLine):
(WebCore::ComplexLineLayout::updateFragmentForLine const):

  • rendering/RenderBlockFlow.cpp:

(WebCore::calculateMinimumPageHeight):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::markLinesDirtyInBlockRange):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox):

  • rendering/RenderLayoutState.cpp:

(WebCore::RenderLayoutState::computeLineGridPaginationOrigin):

  • rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::collectSelectionRects):

  • rendering/RenderText.cpp:

(WebCore::RenderText::collectSelectionRects):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::adjustPosition):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSnapAdjustment const):
(WebCore::RootInlineBox::outputLineBox const):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::lineBoxTop const):
(WebCore::RootInlineBox::lineBoxBottom const):
(WebCore::RootInlineBox::setLineTopBottomPositions):
(WebCore::RootInlineBox::lineTopWithLeading const): Deleted.
(WebCore::RootInlineBox::lineBottomWithLeading const): Deleted.

8:16 AM Changeset in webkit [269148] by Karl Rackler
  • 3 edits in trunk/LayoutTests

REGRESSION: [ Mojave+ ] inspector/dom-debugger/attribute-modified-style.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=218341

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
7:29 AM Changeset in webkit [269147] by youenn@apple.com
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Disable VP9 VTB hardware decoding
https://bugs.webkit.org/show_bug.cgi?id=218326

Reviewed by Alex Christensen.

VP9 hardware decoder does not work properly yet as used in WebRTC pipeline.
Disable hardware support for now and use software based VP9 through VTB.

  • Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:

(-[RTCVideoDecoderVTBVP9 resetDecompressionSession]):

7:21 AM Changeset in webkit [269146] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

[LFC][Integration] RenderBlockFlow::positionForPointWithInlineChildren should use iterator
https://bugs.webkit.org/show_bug.cgi?id=218283

Reviewed by Zalan Bujtas.

Reduce InlineBox access and eliminate one ensureLineBoxes() call.

  • layout/integration/LayoutIntegrationLineIterator.h:

(WebCore::LayoutIntegration::PathLine::topWithLeading const):
(WebCore::LayoutIntegration::PathLine::bottomWithLeading const):
(WebCore::LayoutIntegration::PathLine::legacyRootInlineBox const):

  • layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:

(WebCore::LayoutIntegration::LineIteratorLegacyPath::topWithLeading const):
(WebCore::LayoutIntegration::LineIteratorLegacyPath::bottomWithLeading const):
(WebCore::LayoutIntegration::LineIteratorLegacyPath::legacyRootInlineBox const):

  • layout/integration/LayoutIntegrationLineIteratorModernPath.h:

(WebCore::LayoutIntegration::LineIteratorModernPath::topWithLeading const):
(WebCore::LayoutIntegration::LineIteratorModernPath::bottomWithLeading const):
(WebCore::LayoutIntegration::LineIteratorModernPath::legacyRootInlineBox const):

  • layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::legacyInlineBox const):

  • rendering/RenderBlockFlow.cpp:

(WebCore::positionForRun):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::positionForBox const): Deleted.

  • rendering/RenderBlockFlow.h:
6:17 AM Changeset in webkit [269145] by Alan Bujtas
  • 7 edits in trunk/Source/WebCore

[LFC][Integration] Implement outputLineTreeAndMark for IFC
https://bugs.webkit.org/show_bug.cgi?id=218310

Reviewed by Antti Koivisto.

Add a legacy like inline tree output. This helps when comparing legacy and modern line tree geometries.

"<div>before<img>after<div>" generates the following output:

DIV RenderBlock at (x, y) size width x height renderer->(address) node->(address)

line at (x, y) size (width x height) baseline (y)

Inline level boxes:

Root inline box at (x, y) size (width x height) baseline (y) ascent (ascent/layout bounds ascent) descent (descent/layout bounds descent)
Atomic inline level box at (x, y) size (width x height) baseline (y) ascent (ascent/layout bounds ascent) descent (descent/layout bounds descent)

Runs:

text run at (x, y) size (width x height) run(start, end)
box run at (x, y) size (width x height)
text run at (x, y) size (width x height) run(start, end)

  • layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineLevelBox::LayoutBounds::height const):
(WebCore::Layout::LineBox::InlineLevelBox::layoutBounds const):
(WebCore::Layout::LineBox::InlineLevelBox::isRootInlineBox const):

  • layout/integration/LayoutIntegrationCoverage.cpp:
  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::outputLineTree const):

  • layout/integration/LayoutIntegrationLineLayout.h:
  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::showInlineTreeAndRuns):
(WebCore::Layout::outputLayoutTree):
(WebCore::Layout::outputInlineRuns): Deleted.

  • layout/layouttree/LayoutTreeBuilder.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::outputLineTreeAndMark const):

4:37 AM Changeset in webkit [269144] by commit-queue@webkit.org
  • 18 edits in trunk

Make scroll-margin independent of scroll snapping and have it apply when scrolling to anchors
https://bugs.webkit.org/show_bug.cgi?id=218076

Patch by Martin Robinson <mrobinson@igalia.com> on 2020-10-29
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin-expected.txt: Updated expectation to note new pass.

Source/WebCore:

  • dom/Element.cpp:

(WebCore::Element::scrollIntoView): Use absoluteAnchorRectWithScrollMargin, taking into
account scroll-margin.
(WebCore::Element::scrollIntoViewIfNeeded): Ditto.
(WebCore::Element::scrollIntoViewIfNotVisible): Ditto.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor): Ditto.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::absoluteAnchorRectWithScrollMargin const): Added this override
which properly converts the scroll-margin to LayoutUnits and applies it to absoluteAnchorRect.

  • rendering/RenderBox.h: Added method declaration.
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::absoluteAnchorRectWithScrollMargin const): Added implementation
that simply calls absoluteAnchorRect.

  • rendering/RenderElement.h: Added declaration of new virtual

absoluteAnchorRectWithScrollMargin.

  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleDidChange): Get the scroll-margin directly from the
style instead of the now-removed ScrollSnapArea.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::scrollMargin const): Move scroll-margin and scroll-snap-align to
m_rareNonInheritedData and get rid of intermediate ScrollSnapArea. These two properties
are no independent.
(WebCore::RenderStyle::scrollMarginTop const): Ditto.
(WebCore::RenderStyle::scrollMarginBottom const): Ditto.
(WebCore::RenderStyle::scrollMarginLeft const): Ditto.
(WebCore::RenderStyle::scrollMarginRight const): Ditto.
(WebCore::RenderStyle::setScrollMarginTop): Ditto.
(WebCore::RenderStyle::setScrollMarginBottom): Ditto.
(WebCore::RenderStyle::setScrollMarginLeft): Ditto.
(WebCore::RenderStyle::setScrollMarginRight): Ditto.
(WebCore::RenderStyle::scrollSnapAlign const): Ditto.
(WebCore::RenderStyle::setScrollSnapAlign): Ditto.
(WebCore::RenderStyle::hasSnapPosition const): Ditto.
(WebCore::RenderStyle::scrollSnapArea const): Deleted.

  • rendering/style/RenderStyle.h: Add accessors for scroll-margin and moved hasSnapPosition

from ScrollSnapArea.

  • rendering/style/StyleRareNonInheritedData.cpp: Removed intermediate ScrollSnapArea data

structure and moved members here.
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Ditto.
(WebCore::StyleRareNonInheritedData::operator== const): Ditto.

  • rendering/style/StyleRareNonInheritedData.h: Ditto.
  • rendering/style/StyleScrollSnapPoints.cpp: Ditto.

(WebCore::StyleScrollSnapArea::copy const): Deleted.
(WebCore::StyleScrollSnapArea::StyleScrollSnapArea): Deleted.

  • rendering/style/StyleScrollSnapPoints.h: Removed ScrollSnapArea.

(WebCore::StyleScrollSnapArea::create): Deleted.
(WebCore::StyleScrollSnapArea::hasSnapPosition const): Deleted.

LayoutTests:

  • TestExpectations: Updated expectations for newly passing tests and marked some tests

as flaky.

4:23 AM Changeset in webkit [269143] by Chris Lord
  • 8 edits
    1 delete in trunk/Source

[GTK] Smooth scrolling should not apply to continuous scrolling with sync scrolling
https://bugs.webkit.org/show_bug.cgi?id=218133

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Respect PlatformWheelEvent.hasPreciseScrollingDeltas in the base
ScrollAnimator class, and make sure the flag is set correctly for
GdkEvent.

  • SourcesGTK.txt:
  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollWithoutAnimation):
(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollAnimator.h:
  • platform/gtk/GtkVersioning.h:

(gdk_event_get_source_device):

  • platform/gtk/PlatformWheelEventGtk.cpp: Removed.

Source/WebKit:

Set hasPreciseScrollDeltas appropriately on scroll events created from GdkEvent.

  • Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

2:19 AM Changeset in webkit [269142] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.30.2

WebKitGTK 2.30.2

1:15 AM Changeset in webkit [269141] by cathiechen
  • 8 edits
    1 copy
    4 adds in trunk

Source/WebCore:
IntersectionObserverCallback leaks
https://bugs.webkit.org/show_bug.cgi?id=218225

Reviewed by Ryosuke Niwa.

Unless the page is unloaded, JSIntersectionObserverCallback and objects inside it can not be garbage collected properly.
To fix this, make IntersectionObserverCallback as a weak callback. To keep it alive, in JSIntersectionObserver::visitAdditionalChildren
add the callback to visitor.

Test: intersection-observer/intersection-observer-callback-leak.html

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSIntersectionObserverCustom.cpp: Copied from Source/WebCore/page/IntersectionObserverCallback.idl.

(WebCore::JSIntersectionObserver::visitAdditionalChildren):

  • page/IntersectionObserver.h:

(WebCore::IntersectionObserver::callbackConcurrently):

  • page/IntersectionObserver.idl:
  • page/IntersectionObserverCallback.h:

(WebCore::IntersectionObserverCallback::hasCallback const):

  • page/IntersectionObserverCallback.idl:

LayoutTests:
IntersectionObserverCallback leak
https://bugs.webkit.org/show_bug.cgi?id=218225

Reviewed by Ryosuke Niwa.

In intersection-observer-callback-after-gc.html, the callbacks with observed targets deleted should stay alive as long as observers are alive.
In intersection-observer-callback-leak.html, use internals.numberOfLiveNodes to check that the objects inside JSIntersectionObserverCallback
can be garbage collected.

  • intersection-observer/intersection-observer-callback-after-gc-expected.txt: Added.
  • intersection-observer/intersection-observer-callback-after-gc.html: Added.
  • intersection-observer/intersection-observer-callback-leak-expected.txt: Added.
  • intersection-observer/intersection-observer-callback-leak.html: Added.

Oct 28, 2020:

11:31 PM Changeset in webkit [269140] by Russell Epstein
  • 4 edits in branches/safari-610-branch

Cherry-pick r269094. rdar://problem/70795299

Use _CFURLConnectionSetFrameworkStubs for SecItemShim instead of DYLD_INTERPOSE on Apple Silicon Macs
https://bugs.webkit.org/show_bug.cgi?id=218269
<rdar://problem/70491533>

Reviewed by Darin Adler.

Source/WebKit:

r171066 introduced the use of _CFURLConnectionSetFrameworkStubs on iOS for CFNetwork to be able
to get and set credentials as the UI process. This is also needed on Apple Silicon Macs.
We should eventually replace it with an even cleaner per-NSURLSession solution, but this is a step
in the right direction, and I verified manually that it fixes the radar.

Covered by an API test that used to fail on Apple Silicon Macs.

  • Shared/mac/SecItemShim.cpp: (WebKit::initializeSecItemShim):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: (TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:31 PM Changeset in webkit [269139] by Russell Epstein
  • 14 edits
    4 adds in branches/safari-610-branch

Cherry-pick r268952. rdar://problem/70795327

[BigSur] Appending a new WebM init segment between Cluster elements throws an error
https://bugs.webkit.org/show_bug.cgi?id=218149
<rdar://problem/70416537>

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Add an "OnElementEnd()" callback to libwebm.

  • Source/third_party/libwebm/webm_parser/include/webm/callback.h:
  • Source/third_party/libwebm/webm_parser/src/callback.cc:
  • Source/third_party/libwebm/webm_parser/src/master_parser.cc:
  • Source/third_party/libwebm/webm_parser/src/webm_parser.cc:

Source/WebCore:

Test: media/media-source/media-source-webm-init-inside-segment.html

The WebM Byte Stream Format specification states that an "initialization segment" consists
of both a leading Ebml element and Segment element, and a "media segment" consists of a
single Cluster element. However, while both Ebml and Segment elements are top-level, Cluster
elements are contained within a Segment. This means if a client pushes a new "initialization
segment" after parsing some-but-not-all Clusters within a Segment, the new Ebml and Segment
elements will be parsed as children of the preceeding Segment, and the subsquent Segment
will overflow its "parent's" size.

In order to support appending a new "initialization segment" while still in the middle of
parsing the previous Segment element, first improve our state tracking in order to determine
what the current parent element is. Then, when we detect that an Ebml element is parsed
while still inside a Segment, abort with a simulated error, which when caught, will indicate
that the parser needs to be reset, and the reader "rewound" to the Ebml's position.

To allow the reader to rewind, we must not throw away appended data as we iterate over them.
Instead, we will only discard read samples once each parsing pass is fully complete. This
allows us to "rewind" across appended segment boundaries, if necessary.

Because all WTF::Deque iterators are invalidated whenever any element is removed, and
because we do not need random-access to the elements in the deque, replace the Deque with a
StdList to store the incoming data.

  • platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm: (WebCore::SourceBufferParserAVFObjC::setLogger):
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
  • platform/graphics/cocoa/SourceBufferParser.h:
  • platform/graphics/cocoa/SourceBufferParserWebM.cpp: (WTF::LogArgument<webm::Id>::toString): (WTF::LogArgument<WebCore::SourceBufferParserWebM::State>::toString): (WebCore::logChannel): (WebCore::logClassName): (WebCore::SourceBufferParserWebM::appendData): (WebCore::SourceBufferParserWebM::resetParserState): (WebCore::SourceBufferParserWebM::invalidate): (WebCore::SourceBufferParserWebM::setLogger): (WebCore::SourceBufferParserWebM::OnElementBegin): (WebCore::SourceBufferParserWebM::OnElementEnd): (WebCore::SourceBufferParserWebM::OnEbml): (WebCore::SourceBufferParserWebM::OnSegmentBegin): (WebCore::SourceBufferParserWebM::OnInfo): (WebCore::SourceBufferParserWebM::OnTrackEntry):
  • platform/graphics/cocoa/SourceBufferParserWebM.h:

LayoutTests:

  • media/media-source/content/test-vp9-long-manifest.json: Added.
  • media/media-source/content/test-vp9-long.webm: Added.
  • media/media-source/media-source-webm-init-inside-segment-expected.txt: Added.
  • media/media-source/media-source-webm-init-inside-segment.html: Added.
  • platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:13 PM Changeset in webkit [269138] by Russell Epstein
  • 4 edits in branches/safari-610-branch

Cherry-pick r268791. rdar://problem/70795323

[iOS] Disable audio capture in the background for non Safari applications
https://bugs.webkit.org/show_bug.cgi?id=217948
<rdar://problem/70241557>

Reviewed by Eric Carlson.

Source/WebCore:

We do not have good OS support when capturing audio in a WebProcess for a backgrounded application.
Until we have proper support, it seems best to mute audio capture when being backgrounded.
Manually tested.

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm: (WebCore::RealtimeMediaSourceCenter::shouldInterruptAudioOnPageVisibilityChange):

LayoutTests:

  • platform/ios/mediastream/video-muted-in-background-tab.html: By default, audio capture will be muted in WTR if page goes to background. Update the test to explicitly request for audio capture to continue while in background.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:26 PM Changeset in webkit [269137] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Null dereference in CompositeEditCommand::cloneParagraphUnderNewElement() due to not checking for top of DOM tree
https://bugs.webkit.org/show_bug.cgi?id=218132

Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2020-10-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

When iterating through parent nodes, cloneParagraphUnderNewElement()
has to be careful to check for the top of the DOM tree (where
parentNode() returns nullptr) and stop iterating.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

LayoutTests:

Add a test to verify that we don't iterate outside the DOM tree while cloning a paragraph.
Thanks to Ryosuke Niwa for helping minimize the test and make it more stable.

  • editing/deleting/move-paragraph-crash-expected.txt: Added.
  • editing/deleting/move-paragraph-crash.html: Added.
8:53 PM Changeset in webkit [269136] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION(r267329): Crash in VisibleSelection::toNormalizedRange()
https://bugs.webkit.org/show_bug.cgi?id=218276

Reviewed by Wenson Hsieh.

Source/WebCore:

The crash was a symptom of the issue that m_extent or m_base could be null but not the other
when canonicalizing a non-null Position with VisiblePosition will make it null.

Fixed the bug by making sure base and extent's nullness match.

Test: editing/selection/delete-selection-with-disconnected-extent.html

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents):

LayoutTests:

Added a regression test and rebaselined the test now that we got the pre-r267329 behavior back.

  • editing/execCommand/insert-list-nested-with-orphaned-expected.txt: Reverted the rebaseline in r267329.
  • editing/selection/delete-selection-with-disconnected-extent-expected.txt: Added.
  • editing/selection/delete-selection-with-disconnected-extent.html: Added.
7:58 PM Changeset in webkit [269135] by clopez@igalia.com
  • 11 edits
    1 copy
    1 move
    1 delete in trunk/LayoutTests

[GTK][WPE] Rebaseline of tests and gardening of failures.

Rebaselines some tests and mark some tests as failing after recent changes.

Unreviewed gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
  • platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/gtk/fast/css/word-space-extra-expected.txt: Copied from LayoutTests/platform/glib/fast/css/word-space-extra-expected.txt.
  • platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/gtk/fast/html/tab-order-expected.txt: Removed.
  • platform/gtk/fast/text/basic/generic-family-reset-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/wpe/fast/css/word-space-extra-expected.txt: Renamed from LayoutTests/platform/glib/fast/css/word-space-extra-expected.txt.
  • platform/wpe/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/wpe/fast/text/basic/generic-family-reset-expected.txt:
7:40 PM Changeset in webkit [269134] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Web Audio broken on iOS 14 after switching app
https://bugs.webkit.org/show_bug.cgi?id=217606
<rdar://problem/70231769>

Reviewed by Eric Carlson.

When we call AudioOutputUnitStart(), AVFoundation checks if we are allowed to play by
making sure that our application is foreground. In order to do that, AVFoundation
needs the PID of our hosting application. We provide this PID whenever the following
function is called:
MediaSessionManageriOS::providePresentingApplicationPIDIfNecessary()

The issue was that we were not calling providePresentingApplicationPIDIfNecessary()
before starting WebAudio playback. As a result, AVFoundation was relying on the
visibility of the WebContent process itself. This was causing a race because
RunningBoard gets notified that the WebContent process is visible a little later
than for the UIProcess. When the UIProcess would become foreground, we would send
the SetApplicationState IPC to the WebProcess, which would update the page's
visibility and cause us to stop the media session interruption. This would cause
us to call AudioOutputUnitStart(), which would fail because AVFoundation would
ask RunningBoard if the WebContent process is foreground. At this point,
RunningBoard would not necessarily know yet that the WebContent process is
visible. However, RunningBoard reliably knows the UIProcess is visible at this
point.

We now call this function inside MediaSessionManageriOS::sessionWillBeginPlayback()
since this gets called by WebAudio code before starting the playback.

  • platform/audio/cocoa/AudioOutputUnitAdaptor.cpp:

(WebCore::AudioOutputUnitAdaptor::start):
Add some error logging when the call to AudioOutputUnitStart() fails to facilitate
debugging such issues in the future.

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::sessionWillBeginPlayback):

5:51 PM Changeset in webkit [269133] by Chris Dumez
  • 5 edits
    2 moves
    6 adds
    2 deletes in trunk/LayoutTests

Resync web-platform-tests/webaudio tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=218313

Reviewed by Alex Christensen.

Resync web-platform-tests/webaudio tests from upstream 5fe9553936ab4d7ba2b4.

  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-detached-execution-context-expected.txt: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-detached-execution-context.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-detached-execution-context.tentative.html.
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-detached-execution-context.tentative-expected.txt: Removed.
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/promise-methods-after-discard-expected.txt: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/promise-methods-after-discard.html: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/w3c-import.log:
  • web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html:
  • web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/offlineaudiocontext-detached-execution-context-expected.txt: Added.
  • web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/offlineaudiocontext-detached-execution-context.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/offlineaudiocontext-detached-execution-context.tentative.html.
  • web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/offlineaudiocontext-detached-execution-context.tentative-expected.txt: Removed.
  • web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/startrendering-after-discard-expected.txt: Added.
  • web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/startrendering-after-discard.html: Added.
  • web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/w3c-import.log:
5:10 PM Changeset in webkit [269132] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[build.webkit.org] loadConfig unittest fail depending on locally installed version of buildbot
https://bugs.webkit.org/show_bug.cgi?id=218234

Reviewed by Jonathan Bedard.

  • CISupport/build-webkit-org/loadConfig_unittest.py:
5:10 PM Changeset in webkit [269131] by Russell Epstein
  • 1 copy in tags/Safari-610.2.11.51.7

Tag Safari-610.2.11.51.7.

5:02 PM Changeset in webkit [269130] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[build.webkit.org] Use -q and -o while unzipping layout-test-results.zip
https://bugs.webkit.org/show_bug.cgi?id=218230

Reviewed by Jonathan Bedard.

  • CISupport/build-webkit-org/steps.py:

(ExtractTestResults.start):

5:00 PM Changeset in webkit [269129] by wilander@apple.com
  • 6 edits
    3 adds in trunk

PCM: Accept ad click data when the link opens a new window
https://bugs.webkit.org/show_bug.cgi?id=214176
<rdar://problem/65358005>

Reviewed by Brent Fulgham.

A link with the attribute target="_blank" takes another code path for
navigation which involves the creation of a new window and webpage. That
code path needs to transfer ad click attribution data to the new webpage
Source/WebKit:

where it can be picked up in WebPageProxy::didCommitLoadForFrame().
The ad click attribution data sits in the NavigationAction which is not
available in the completion handler WebPageProxy::createNewPage().
The client, which differs between TestRunner and e.g. Safari, consumes
the NavigationAction. I don't want to risk a regression in e.g. Safari
while still passing the test because TestRunner hasn't regressed.

Test: http/tests/adClickAttribution/attribution-conversion-through-image-redirect-in-new-window.html

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

Now also checks for pending ad click attribution data in its new
member variable m_newPageNavigationAdClickAttribution.

(WebKit::WebPageProxy::createNewPage):

Now forwards optional ad click attribution data to the completion
handler where it can be stored on the newly created webpage in the
new member variable m_newPageNavigationAdClickAttribution.

  • UIProcess/WebPageProxy.h:

Added m_newPageNavigationAdClickAttribution.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

Added missing navigationAction.adClickAttribution() copy.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):

Added missing navigationAction.adClickAttribution() copy.

LayoutTests:

where it can be picked up.

  • http/tests/adClickAttribution/attribution-conversion-through-image-redirect-in-new-window-expected.txt: Added.
  • http/tests/adClickAttribution/attribution-conversion-through-image-redirect-in-new-window.html: Added.
  • http/tests/adClickAttribution/resources/convertAndPostMessageBack.html: Added.
4:51 PM Changeset in webkit [269128] by basuke.suzuki@sony.com
  • 7 edits in trunk/Source

[WinCairo][PlayStation] Add handling for accept failure case
https://bugs.webkit.org/show_bug.cgi?id=217353

Reviewed by Alex Christensen.

Source/JavaScriptCore:

It is rare to happen, but listening socket can be invalid state (i.e. cable disconnection, interface error),
and accept() will be called because of the poll's false report. In that situation, it is required to rebuild
the listening socket from the scratch. The failure of accept is the good place to capture this situation.

This patch moves listening duty into Listener internal calss and it is possible to make the invalid state
while maintained by SocketEndpoint. Also in case of failure continues, the retry will be gradually increasing
the intervals.

  • inspector/remote/socket/RemoteInspectorServer.h:
  • inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:

(Inspector::RemoteInspectorSocketEndpoint::listenInet):
(Inspector::RemoteInspectorSocketEndpoint::pollingTimeout):
(Inspector::RemoteInspectorSocketEndpoint::workerThread):
(Inspector::RemoteInspectorSocketEndpoint::createClient):
(Inspector::RemoteInspectorSocketEndpoint::disconnect):
(Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled):

  • inspector/remote/socket/RemoteInspectorSocketEndpoint.h:

Source/WebDriver:

Following the interface change.

  • HTTPServer.h:
  • socket/HTTPServerSocket.cpp:

(WebDriver::HTTPServer::didStatusChanged):

2:34 PM Changeset in webkit [269127] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network: background color of rows from previous session is wrong
https://bugs.webkit.org/show_bug.cgi?id=218058
<rdar://problem/70550459>

Patch by Federico Bucchi <Federico Bucchi> on 2020-10-28
Reviewed by Devin Rousso.

  • UserInterface/Views/NetworkTableContentView.css:

(.network-table > .table li:not(.filler, .selected) .cell:not(.name, .current-session),):
(.network-table > .table li:not(.filler, .selected) .cell:not(.current-session)): Deleted.

2:30 PM Changeset in webkit [269126] by Truitt Savell
  • 2 edits in trunk/LayoutTests

Rebase for fast/forms/input-appearance-spinbutton.html on Catalina after changes in r269036
https://bugs.webkit.org/show_bug.cgi?id=218151

Unreviewed test gardening.

  • platform/mac-catalina/fast/forms/input-appearance-spinbutton-expected.txt:
2:27 PM Changeset in webkit [269125] by Truitt Savell
  • 2 edits in trunk/LayoutTests

Unreviewed, reverting r269122.

Checked in Change markers

Reverted changeset:

"Rebase for fast/forms/input-appearance-spinbutton.html on
Catalina after changes in r269036"
https://bugs.webkit.org/show_bug.cgi?id=218151
https://trac.webkit.org/changeset/269122

2:16 PM Changeset in webkit [269124] by Conrad Shultz
  • 5 edits in trunk/Source/WebCore

Remove diagnostic logging for plug-ins
https://bugs.webkit.org/show_bug.cgi?id=218304

Reviewed by Tim Horton.

There's no longer a need to pipe diagnostic logging up to clients.

  • history/BackForwardCache.cpp:

(WebCore::canCacheFrame):

  • loader/SubframeLoader.cpp:

(WebCore::logPluginRequest):
Remove a now-unused parameter.
(WebCore::FrameLoader::SubframeLoader::requestObject):
(WebCore::FrameLoader::SubframeLoader::createJavaAppletWidget):

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::pluginLoadedKey): Deleted.
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey): Deleted.
(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey): Deleted.
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey): Deleted.
(WebCore::DiagnosticLoggingKeys::hasPluginsKey): Deleted.

  • page/DiagnosticLoggingKeys.h:
2:09 PM Changeset in webkit [269123] by Said Abou-Hallawa
  • 2 edits in trunk/Source/WebKit

[GPU Process] Eagerly flush the PutImageData item to the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=218116

Reviewed by Simon Fraser.

Flush the DrawingContext of the RemoteImageBufferProxy once the PutImageData
item is recorded. So no expensive operation is going to block the painting.

  • WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
2:04 PM Changeset in webkit [269122] by Truitt Savell
  • 2 edits in trunk/LayoutTests

Rebase for fast/forms/input-appearance-spinbutton.html on Catalina after changes in r269036
https://bugs.webkit.org/show_bug.cgi?id=218151

Unreviewed test gardening.

  • platform/mac-catalina/fast/forms/input-appearance-spinbutton-expected.txt:
1:42 PM Changeset in webkit [269121] by jer.noble@apple.com
  • 6 edits
    2 adds in trunk

[MSE] Handle trackId changing across Initialization Segments
https://bugs.webkit.org/show_bug.cgi?id=218294
<rdar://problem/70771306>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-trackid-change.html

When appending an initialization segment after the receivedFirstInitializationSegment flag is
true, and when the number of video or audio tracks is 1, the trackId is allowed to change across
initialiaztion segments. When this occurs, move the TrackBuffer inside the trackBufferMap to
refer to the new trackId, so that when MediaSamples are parsed, they're put into the correct
TrackBuffer.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):

  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::setPrivate):

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::setPrivate):

  • html/track/VideoTrack.cpp:

(WebCore::VideoTrack::setPrivate):

LayoutTests:

  • media/media-source/media-source-trackid-change-expected.txt: Added.
  • media/media-source/media-source-trackid-change.html: Added.
1:39 PM Changeset in webkit [269120] by aakash_jain@apple.com
  • 13 edits
    1 move in trunk/Tools

Rename build.webkit.org-config directory to build-webkit-org
https://bugs.webkit.org/show_bug.cgi?id=218302

Reviewed by Jonathan Bedard.

  • CISupport/build-webkit-org: Copied from Tools/CISupport/build.webkit.org-config.
  • CISupport/build-webkit-org/htdigestparser_unittest.py:
  • CISupport/build-webkit-org/public_html/TestFailures/scripts/builders_unittests.js:
  • CISupport/build-webkit-org/steps.py:
  • CISupport/build-webkit-org/steps_unittest.py:
  • CISupport/build-webkit-org/wkbuild.py:
  • CISupport/build-webkit-org/wkbuild_unittest.py:
  • CISupport/build.webkit.org-config: Removed.
  • CISupport/ews-build/steps.py:
  • CISupport/ews-build/steps_unittest.py:
  • Scripts/run-dashboard-tests:
  • Scripts/webkitpy/layout_tests/views/buildbot_results.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
1:28 PM Changeset in webkit [269119] by Russell Epstein
  • 1 edit in branches/safari-610-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaMutedState.mm

Unreviewed debug build fix, rdar://problem/70733353

Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaMutedState.mm:32:9: fatal error: WebKit/WKMediaPlaybackState.h file not found.

1:26 PM Changeset in webkit [269118] by timothy_horton@apple.com
  • 11 edits in trunk/Source

macCatalyst WebGL on Apple Silicon devices is using a software renderer
https://bugs.webkit.org/show_bug.cgi?id=218303
<rdar://problem/70587571>

Reviewed by Geoffrey Garen.

Source/ThirdParty/ANGLE:

  • src/gpu_info_util/SystemInfo.h:
  • src/gpu_info_util/SystemInfo_apple.mm:

(angle::GetSystemInfo):
We can just use the macOS version of GetSystemInfo in macCatalyst.

  • src/gpu_info_util/SystemInfo_macos.mm:

(angle::GetSystemInfo_mac):

  • src/libANGLE/Display.cpp:
  • src/libANGLE/formatutils.cpp:

(gl::BuildInternalFormatInfoMap):

  • src/libANGLE/renderer/gl/renderergl_utils.cpp:

(rx::nativegl_gl::GenerateCaps):
It turns out we must use EAGL in macCatalyst on Apple Silicon in all cases,
not just in-process in iOS apps (the problem is not just about coexistence
of the two GLs, but actually about our ability to load the accelerated
renderer /at all/ in macCatalyst processes).

I left the runtime switching in place, because there is a future in which
we /can/ use CGL in non-iOS-app processes, but that future is not now.

Source/WebCore:

  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::needsEAGLOnMac):
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::IOSurfaceTextureTarget):
(WebCore::GraphicsContextGLOpenGL::IOSurfaceTextureTargetQuery):
(WebCore::GraphicsContextGLOpenGL::EGLIOSurfaceTextureTarget):
(WebCore::isiOSAppOnMac): Deleted.
See ANGLE ChangeLog.

Source/WebKit:

  • UIProcess/mac/HighPerformanceGPUManager.mm:

(WebKit::HighPerformanceGPUManager::addProcessRequiringHighPerformance):
(WebKit::HighPerformanceGPUManager::removeProcessRequiringHighPerformance):
(WebKit::HighPerformanceGPUManager::updateState):
(WebKit::isiOSAppOnMac): Deleted.
HighPerformanceGPUManager is PLATFORM(MAC)-only, which is not true
for MACCATALYST, so delete this dead code.

1:06 PM Changeset in webkit [269117] by Jonathan Bedard
  • 10 edits in trunk/Tools

[webkitscmpy] Support finding commit by tag
https://bugs.webkit.org/show_bug.cgi?id=218212
<rdar://problem/70700121>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git.commit): Find a commit referred to by a provided tag.

  • Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:

(Scm.find): Find a commit by tag, if applicable.
(Scm.commit):

  • Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:

(Svn.info): Pull information by tag, support non-standard branches.
(Svn._cache_revisions): Support non-standard branches.
(Svn._branch_for): Return the non-standard branch name for tags.
(Svn.commit): Find a commit referred to by a provided tag.

  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:

(Git): Support tags.

  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py:

(Svn.init): Support tags.
(Svn.tags): Tags are simply specialized branches, return the names of those tags
based on the commit mapping.

  • Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:
  • Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

(TestGit):
(TestGit.test_tag):

  • Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:

(TestSvn):
(TestSvn.test_tag):

1:01 PM Changeset in webkit [269116] by Fujii Hironori
  • 3 edits in trunk/Source/WebCore

TextureMapperLayer::paintWithIntermediateSurface: Reduce BitmapTextures by unifying replicaSurface and mainSurface
https://bugs.webkit.org/show_bug.cgi?id=217943

Reviewed by Don Olmstead.

TextureMapperLayer::paintWithIntermediateSurface was using two
BitmapTextures for the main layer and replica layer. But, a single
BitmapTexture suffices. Create a BitmapTexture and render both
layers onto it.

No new tests, no behavior changes.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintIntoSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):

  • platform/graphics/texmap/TextureMapperLayer.h:
12:25 PM Changeset in webkit [269115] by sbarati@apple.com
  • 24 edits
    1 add in trunk

Better cache our serialization of the outer TDZ environment when creating FunctionExecutables during bytecode generation
https://bugs.webkit.org/show_bug.cgi?id=199866
<rdar://problem/53333108>

Reviewed by Tadeu Zagallo.

JSTests:

  • microbenchmarks/let-const-tdz-environment-parsing-and-hash-consing-speed.js: Added.

Source/JavaScriptCore:

This patch removes performance pathologies regarding programs with
many variables under TDZ (let/const). We had an algorithm for caching
the results of gathering all variables under TDZ, but that algorithm
wasn't nearly aggressive enough in its caching. This lead us to worst
case quadratic runtime, which could happens in practice for large functions.

There are a few fixes here:

  • Instead of flattening the entire TDZ stack, and caching that result,

we now cache each stack entry individually. So as you push/pop to the
TDZ environment stack, we no longer invalidate everything. Instead, we
will just need to cache the newly pushed entry. We also no longer invalidate
the cache for lifting a TDZ check. The compromise here is we may emit
more runtime TDZ checks for closure variables. This is better than N2
bytecode compile time perf, since a well predicted branch for a TDZ
check is essentially free.

  • We no longer transform the CompactTDZEnvironment (formerly CompactVariableEnvironment)

from a Vector into a HashSet each time we generate code for an inner function. Instead,
CompactTDZEnvironment can be in two modes: compact and inflated. It starts life off in
compact mode (a vector), and will turn into an inflated mode if it's ever needed. Once
inflated, it'll stay this way until it's destructed. This improves our algorithm from being
O(EnvSize * NumFunctions) to O(EnvSize) at the cost of using more space in a HashTable versus a
Vector. In the future, we could consider just binary searching through this Vector, and never using
a hash table.

  • bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

  • bytecode/UnlinkedFunctionExecutable.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::popLexicalScopeInternal):
(JSC::BytecodeGenerator::needsTDZCheck):
(JSC::BytecodeGenerator::liftTDZCheckIfPossible):
(JSC::BytecodeGenerator::pushTDZVariables):
(JSC::BytecodeGenerator::getVariablesUnderTDZ):
(JSC::BytecodeGenerator::preserveTDZStack):
(JSC::BytecodeGenerator::restoreTDZStack):
(JSC::BytecodeGenerator::emitNewInstanceFieldInitializerFunction):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::makeFunction):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluateWithScopeExtension):

  • interpreter/Interpreter.cpp:

(JSC::eval):

  • parser/Parser.h:

(JSC::Parser<LexerType>::parse):
(JSC::parse):

  • parser/VariableEnvironment.cpp:

(JSC::CompactTDZEnvironment::sortCompact):
(JSC::CompactTDZEnvironment::CompactTDZEnvironment):
(JSC::CompactTDZEnvironment::operator== const):
(JSC::CompactTDZEnvironment::toTDZEnvironmentSlow const):
(JSC::CompactTDZEnvironmentMap::get):
(JSC::CompactTDZEnvironmentMap::Handle::~Handle):
(JSC::CompactTDZEnvironmentMap::Handle::Handle):
(JSC::CompactVariableEnvironment::CompactVariableEnvironment): Deleted.
(JSC::CompactVariableEnvironment::operator== const): Deleted.
(JSC::CompactVariableEnvironment::toVariableEnvironment const): Deleted.
(JSC::CompactVariableMap::get): Deleted.
(JSC::CompactVariableMap::Handle::~Handle): Deleted.
(JSC::CompactVariableMap::Handle::Handle): Deleted.

  • parser/VariableEnvironment.h:

(JSC::CompactTDZEnvironment::toTDZEnvironment const):
(JSC::CompactTDZEnvironmentKey::CompactTDZEnvironmentKey):
(JSC::CompactTDZEnvironmentKey::hash):
(JSC::CompactTDZEnvironmentKey::equal):
(JSC::CompactTDZEnvironmentKey::makeDeletedValue):
(JSC::CompactTDZEnvironmentKey::isHashTableDeletedValue const):
(JSC::CompactTDZEnvironmentKey::environment):
(WTF::HashTraits<JSC::CompactTDZEnvironmentKey>::emptyValue):
(WTF::HashTraits<JSC::CompactTDZEnvironmentKey>::isEmptyValue):
(WTF::HashTraits<JSC::CompactTDZEnvironmentKey>::constructDeletedValue):
(WTF::HashTraits<JSC::CompactTDZEnvironmentKey>::isDeletedValue):
(JSC::CompactTDZEnvironmentMap::Handle::environment const):
(JSC::CompactVariableEnvironment::hash const): Deleted.
(JSC::CompactVariableMapKey::CompactVariableMapKey): Deleted.
(JSC::CompactVariableMapKey::hash): Deleted.
(JSC::CompactVariableMapKey::equal): Deleted.
(JSC::CompactVariableMapKey::makeDeletedValue): Deleted.
(JSC::CompactVariableMapKey::isHashTableDeletedValue const): Deleted.
(JSC::CompactVariableMapKey::isHashTableEmptyValue const): Deleted.
(JSC::CompactVariableMapKey::environment): Deleted.
(WTF::HashTraits<JSC::CompactVariableMapKey>::emptyValue): Deleted.
(WTF::HashTraits<JSC::CompactVariableMapKey>::isEmptyValue): Deleted.
(WTF::HashTraits<JSC::CompactVariableMapKey>::constructDeletedValue): Deleted.
(WTF::HashTraits<JSC::CompactVariableMapKey>::isDeletedValue): Deleted.
(JSC::CompactVariableMap::Handle::Handle): Deleted.
(JSC::CompactVariableMap::Handle::operator=): Deleted.
(JSC::CompactVariableMap::Handle::operator bool const): Deleted.
(JSC::CompactVariableMap::Handle::environment const): Deleted.
(JSC::CompactVariableMap::Handle::swap): Deleted.

  • runtime/CachedTypes.cpp:

(JSC::Decoder::handleForTDZEnvironment const):
(JSC::Decoder::setHandleForTDZEnvironment):
(JSC::CachedCompactTDZEnvironment::encode):
(JSC::CachedCompactTDZEnvironment::decode const):
(JSC::CachedCompactTDZEnvironmentMapHandle::encode):
(JSC::CachedCompactTDZEnvironmentMapHandle::decode const):
(JSC::CachedFunctionExecutableRareData::decode const):
(JSC::Decoder::handleForEnvironment const): Deleted.
(JSC::Decoder::setHandleForEnvironment): Deleted.
(JSC::CachedCompactVariableEnvironment::encode): Deleted.
(JSC::CachedCompactVariableEnvironment::decode const): Deleted.
(JSC::CachedCompactVariableMapHandle::encode): Deleted.
(JSC::CachedCompactVariableMapHandle::decode const): Deleted.

  • runtime/CachedTypes.h:
  • runtime/CodeCache.cpp:

(JSC::generateUnlinkedCodeBlockImpl):
(JSC::generateUnlinkedCodeBlock):
(JSC::generateUnlinkedCodeBlockForDirectEval):
(JSC::recursivelyGenerateUnlinkedCodeBlockForProgram):
(JSC::recursivelyGenerateUnlinkedCodeBlockForModuleProgram):
(JSC::CodeCache::getUnlinkedGlobalCodeBlock):

  • runtime/CodeCache.h:
  • runtime/Completion.cpp:

(JSC::generateProgramBytecode):
(JSC::generateModuleBytecode):

  • runtime/DirectEvalExecutable.cpp:

(JSC::DirectEvalExecutable::create):

  • runtime/DirectEvalExecutable.h:
  • runtime/JSScope.cpp:

(JSC::JSScope::collectClosureVariablesUnderTDZ):

  • runtime/JSScope.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WTF:

  • wtf/RefPtr.h:

(WTF::swap): Deleted.
This function is no longer necessary, and causes ADL (https://en.cppreference.com/w/cpp/language/adl)
compile errors when not using DumbPtrTraits and calling sort on a vector of that type.

12:08 PM Changeset in webkit [269114] by Jonathan Bedard
  • 18 edits
    2 copies
    2 moves
    4 adds in trunk/Tools

[webkitflaskpy] Create shared library for WebKit's flask tooling
https://bugs.webkit.org/show_bug.cgi?id=218257
<rdar://problem/70736269>

Rubber-stamped by Aakash Jain.

  • Scripts/libraries/resultsdbpy/resultsdbpy/init.py:

(_maybe_add_webkit_python_library_paths): Add webkitcorepy and webkitflaskpy.
(_maybe_add_webkitcorepy_path): Renamed _maybe_add_webkit_python_library_paths.

  • Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/util.py: Moved to webkitflaskpy/util.py.
  • Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Moved to webkitflaskpy/util_unittest.py.
  • Scripts/libraries/webkitflaskpy: Added.
  • Scripts/libraries/webkitflaskpy/MANIFEST.in: Added.
  • Scripts/libraries/webkitflaskpy/README.md: Added.
  • Scripts/libraries/webkitflaskpy/setup.py: Added.
  • Scripts/libraries/webkitflaskpy/webkitflaskpy: Added.
  • Scripts/libraries/webkitflaskpy/webkitflaskpy/init.py: Added.
  • Scripts/libraries/webkitflaskpy/webkitflaskpy/util.py: Moved from resultsdpy/flask_support/util.py.
  • Scripts/libraries/webkitflaskpy/webkitflaskpy/util_unittest.py: Moved from resultsdpy/flask_support/util_unittest.py.
  • Scripts/webkitpy/test/main.py:

(main): Add

11:59 AM Changeset in webkit [269113] by Russell Epstein
  • 4 edits in branches/safari-610.2.11.51-branch

Cherry-pick r269094. rdar://problem/70769706

Use _CFURLConnectionSetFrameworkStubs for SecItemShim instead of DYLD_INTERPOSE on Apple Silicon Macs
https://bugs.webkit.org/show_bug.cgi?id=218269
<rdar://problem/70491533>

Reviewed by Darin Adler.

Source/WebKit:

r171066 introduced the use of _CFURLConnectionSetFrameworkStubs on iOS for CFNetwork to be able
to get and set credentials as the UI process. This is also needed on Apple Silicon Macs.
We should eventually replace it with an even cleaner per-NSURLSession solution, but this is a step
in the right direction, and I verified manually that it fixes the radar.

Covered by an API test that used to fail on Apple Silicon Macs.

  • Shared/mac/SecItemShim.cpp: (WebKit::initializeSecItemShim):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: (TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:46 AM Changeset in webkit [269112] by Russell Epstein
  • 8 edits in branches/safari-610.2.11.51-branch/Source

Versioning.

WebKit-7610.2.11.51.7

11:33 AM Changeset in webkit [269111] by weinig@apple.com
  • 75 edits in trunk

Reduce Preference Override Methods: TabsToLinks/SpatialNavigation
https://bugs.webkit.org/show_bug.cgi?id=218288

Reviewed by Tim Horton.

Source/WebKit:

Removes WKPreferencesGet/SetTabToLinksEnabled preference as it duplicates functionality of
WKPreferencesGet/SetTabsToLinks. The former was added for https://bugs.webkit.org/show_bug.cgi?id=95329
but was redundant even at the time. We can now use test header commands for all of its
use cases.

Also removes testing only bundle SPI for enabling spatial navigation which also can be
set via test headers instead.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTabToLinksEnabled): Deleted.
(WKPreferencesGetTabToLinksEnabled): Deleted.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetSpatialNavigationEnabled): Deleted.

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setSpatialNavigationEnabled): Deleted.

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::setTabToLinksEnabled): Deleted.
(WebKit::WebPage::tabToLinksEnabled const): Deleted.

Source/WTF:

  • Scripts/Preferences/WebPreferences.yaml:

Unify TabToLinksEnabled and TabsToLinks. TabToLinksEnabled was added for https://bugs.webkit.org/show_bug.cgi?id=95329
and has never actually been needed.

Tools:

Replace uses of testRunner.overridePreference("WebKitTabToLinksPreferenceKey", ...) and
testRunner.setSpatialNavigationEnabled(...) with test header commands, helping to reduce
the number of different ways we have to override preferences in LayoutTests.

  • DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):
(setSpatialNavigationEnabledCallback): Deleted.

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setSpatialNavigationEnabled): Deleted.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):
(setWebPreferencesForTestOptions):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setSpatialNavigationEnabled): Deleted.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

Replace uses of testRunner.overridePreference("WebKitTabToLinksPreferenceKey", ...) and
testRunner.setSpatialNavigationEnabled(...) with test header commands, helping to reduce
the number of different ways we have to override preferences in LayoutTests.

  • accessibility/mac/caret-browsing-tab-selection.html:
  • accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html:
  • accessibility/mac/selection-element-tabbing-to-link.html:
  • accessibility/mac/selection-notification-focus-change.html:
  • accessibility/mac/tab-focus-post-notification.html:
  • fast/events/tab-focus-anchor.html:
  • fast/events/tab-focus-link-in-canvas.html:
  • fast/spatial-navigation/snav-1st-stop.html:
  • fast/spatial-navigation/snav-clipped-overflowed-content.html:
  • fast/spatial-navigation/snav-container-only-white-space.html:
  • fast/spatial-navigation/snav-container-white-space.html:
  • fast/spatial-navigation/snav-display-contents-crash.html:
  • fast/spatial-navigation/snav-div-overflow-scrol-hidden.html:
  • fast/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html:
  • fast/spatial-navigation/snav-fully-aligned-horizontally.html:
  • fast/spatial-navigation/snav-fully-aligned-vertically.html:
  • fast/spatial-navigation/snav-hidden-focusable-element.html:
  • fast/spatial-navigation/snav-hidden-iframe-zero-size.html:
  • fast/spatial-navigation/snav-hidden-iframe.html:
  • fast/spatial-navigation/snav-iframe-flattening-simple.html:
  • fast/spatial-navigation/snav-iframe-nested.html:
  • fast/spatial-navigation/snav-iframe-no-focusable-content.html:
  • fast/spatial-navigation/snav-iframe-no-scrollable-content.html:
  • fast/spatial-navigation/snav-iframe-recursive-offset-parent.html:
  • fast/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:
  • fast/spatial-navigation/snav-imagemap-area-not-focusable.html:
  • fast/spatial-navigation/snav-imagemap-area-without-image.html:
  • fast/spatial-navigation/snav-imagemap-overlapped-areas.html:
  • fast/spatial-navigation/snav-imagemap-simple.html:
  • fast/spatial-navigation/snav-input.html:
  • fast/spatial-navigation/snav-media-elements.html:
  • fast/spatial-navigation/snav-multiple-select-focusring.html:
  • fast/spatial-navigation/snav-multiple-select-optgroup.html:
  • fast/spatial-navigation/snav-multiple-select.html:
  • fast/spatial-navigation/snav-offscreen-content.html:
  • fast/spatial-navigation/snav-only-clipped-overflow-content.html:
  • fast/spatial-navigation/snav-radio-group.html:
  • fast/spatial-navigation/snav-radio.html:
  • fast/spatial-navigation/snav-search-optimization.html:
  • fast/spatial-navigation/snav-simple-content-overflow.html:
  • fast/spatial-navigation/snav-single-select-list.html:
  • fast/spatial-navigation/snav-single-select.html:
  • fast/spatial-navigation/snav-table-traversal.html:
  • fast/spatial-navigation/snav-textarea.html:
  • fast/spatial-navigation/snav-tiny-table-traversal.html:
  • fast/spatial-navigation/snav-two-elements-one-line.html:
  • fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
  • fast/spatial-navigation/snav-z-index.html:
  • fast/spatial-navigation/snav-zero-margin-content.html:
  • media/media-controls-accessibility.html:
  • media/tab-focus-inside-media-elements.html:
11:17 AM Changeset in webkit [269110] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] horizontalAlignmentOffset should check for empty run list
https://bugs.webkit.org/show_bug.cgi?id=218285
<rdar://problem/70730722>

Reviewed by Antti Koivisto.

LineBoxBuilder functions check for empty run list except this static helper.

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::horizontalAlignmentOffset):

10:41 AM Changeset in webkit [269109] by Aditya Keerthi
  • 3 edits in trunk/Source/WebKit

[Cocoa] Remove soft linking of Contacts.framework
https://bugs.webkit.org/show_bug.cgi?id=218289

Reviewed by Geoff Garen.

Since Contacts.framework does not depend on WebKit and soft linking is
discouraged, WebKit should link Contacts.framework normally.

Soft linking requires running the linker at runtime, leading to an
unwanted performance cost. By normally linking (on iOS) and weak linking
(on macOS), the linkage is declared at build time, which enables running
the linker at build/update/install time and avoiding the runtime cost.

  • Configurations/WebKit.xcconfig:

On macOS, weak link the framework since Contacts.framework is not
available on the Base System.

  • Platform/cocoa/PaymentAuthorizationPresenter.mm:

(WebKit::toNSError):

10:40 AM Changeset in webkit [269108] by Chris Dumez
  • 12 edits in trunk

AudioBuffer channels should be neuterable / detachable
https://bugs.webkit.org/show_bug.cgi?id=218286

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing. This test is also passing in Firefox. It is crashing in Blink.

  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/transferred-buffer-output-expected.txt:

Source/WebCore:

AudioBuffer channels should be neuterable / detachable:

When the one of the channels' buffers gets detached/neutered, the array returned by
getChannelData(0) is neutered and thus has zero length. Internally though, if
channelData() gets called and ANY of the channels' buffers are detached, we return
a new empty array, as per the specification. This makes sure we end up with silence
on all channels when any of the channels gets detached, which is consistent with the
specification and Firefox (Blink seems to crash).

To make the AudioBuffer API less error-prone when used natively, I updated length()
and duration() to return 0 whenever any of the channels is detached. This is safer
since channelData() returns 0-length arrays in this case. The Web API keeps returning
the original values though so they rely on new originalLength() / originalDuration()
getters.

No new tests, rebaselined / updated existing tests.

  • Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::create):
(WebCore::AudioBuffer::AudioBuffer):
(WebCore::AudioBuffer::invalidate):
(WebCore::AudioBuffer::channelData):
(WebCore::AudioBuffer::zero):
(WebCore::AudioBuffer::hasDetachedChannelBuffer const):

  • Modules/webaudio/AudioBuffer.h:

(WebCore::AudioBuffer::originalLength const):
(WebCore::AudioBuffer::originalDuration const):
(WebCore::AudioBuffer::length const):
(WebCore::AudioBuffer::duration const):

  • Modules/webaudio/AudioBuffer.idl:
  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer):

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::initialize):

LayoutTests:

  • webaudio/audiobuffer-neuter-expected.txt:
  • webaudio/audiobuffer-neuter.html:

Extend layout test coverage. I have verified that this new version of the test is fully passing in
Gecko. In Blink, the initial checks all pass but it then crashes during rendering.

  • webaudio/resources/audio-testing.js:

(createConstantBuffer):
Improve createConstantBuffer() so that it can construct buffers with multiple channels.

10:32 AM Changeset in webkit [269107] by rmorisset@apple.com
  • 3 edits
    1 add in trunk

DFGIntegerRangeOptimization is wrong for Upsilon (as 'shadow' nodes are not in SSA form)
https://bugs.webkit.org/show_bug.cgi?id=218073

Reviewed by Saam Barati.

JSTests:

The only testcase I managed to get for this bug loops forever when not crashing.
So I use a 1s timeout through --watchdog=1000.

  • stress/bounds-checking-in-cold-loop.js: Added.

(true.vm.ftlTrue):

Source/JavaScriptCore:

In DFGIntegerRangeOptimization, when visiting an Upsilon node, we call setEquivalence, that calls setRelationship.
But despite its name, this function does not overwrite a pre-existing relationship, it simply replaces it by an over-approximation of the intersection of the old and new relationship (see the filter method).
Since the old relationship is always (by definition) an over-approximation of this intersection, it will often do nothing at all if it cannot find a closer approximation.
This is a problem specifically for Upsilon nodes, because several of them can store to the same "shadow node" corresponding to a given Phi, so they are the only case where there can already be a completely different relationship for the same nodes (coming from a different Upsilon).

The fix is very simple thanks to a suggestion by Phil: we just remove all relationships referring to the shadow node just before executing an Upsilon.
This is correct since the upsilon effectively kills that shadow node, before making it live again with a different value, and we already aggressively prune the relationshipMaps by liveness.

  • dfg/DFGIntegerRangeOptimizationPhase.cpp:
9:17 AM Changeset in webkit [269106] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews] Ensure that uat instance doesn't send emails
https://bugs.webkit.org/show_bug.cgi?id=218227

Reviewed by Jonathan Bedard.

  • CISupport/ews-build/send_email.py:
8:57 AM Changeset in webkit [269105] by weinig@apple.com
  • 13 edits
    1 add in trunk

[Testing] Remove requirement of adding new SPI for each preference that needs testing
https://bugs.webkit.org/show_bug.cgi?id=218267

Reviewed by Simon Fraser.

Source/WebKitLegacy/mac:

Expose a set of setters to for DumpRenderTree to use when setting preferences
by string.

  • WebView/WebPreferences.mm:

(-[WebPreferences _setBoolPreferenceForTestingWithValue:forKey:]):
(-[WebPreferences _setUInt32PreferenceForTestingWithValue:forKey:]):
(-[WebPreferences _setDoublePreferenceForTestingWithValue:forKey:]):
(-[WebPreferences _setStringPreferenceForTestingWithValue:forKey:]):

  • WebView/WebPreferencesPrivate.h:

Tools:

Removes the requirement for WebKitLegacy (macOS), which has already been lifted for
modern WebKit, that testing new preferences requires new WebPreferences SPI. Instead,
new testing specific SPI ([WebPreferences _set*PreferenceForTestingWithValue:forKey:])
are used to allow string based setting.

To make this work with the shared WebPreferences*.yaml names, a helper is generated to
map from the shared name to the WebKitLegacy specific name.

This still doesn't quite take us all the way to supporting any WebPreferences*.yaml name
in test headers, as is supported in WebKitTestRunner, as we still need a viable mechanism
to fully reset WebPreferences between tests. Right now, each preference must be set on
each test run, requiring the complete set of preferences to be known up front.

  • DumpRenderTree/CMakeLists.txt:
  • DumpRenderTree/DerivedSources-input.xcfilelist:
  • DumpRenderTree/DerivedSources-output.xcfilelist:
  • DumpRenderTree/DerivedSources.make:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/Scripts/PreferencesTemplates/TestOptionsGeneratedWebKitLegacyKeyMapping.cpp.erb: Added.
  • DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::supportedBoolWebPreferenceFeatures):

  • DumpRenderTree/TestOptions.h:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::overridePreference):

8:28 AM Changeset in webkit [269104] by Philippe Normand
  • 4 edits
    9 adds
    6 deletes in trunk

[GStreamer] Multi-channel (>2) support for the AudioFileReader
https://bugs.webkit.org/show_bug.cgi?id=215255

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The audio file reader used to handle up to stereo audio layouts. It can now handle up to 5.1
surround layouts. This patch also modernizes the coding style of this module in various
parts.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::initializeDebugCategory):
(WebCore::AudioFileReader::handleSample):
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::decodeAudioForBusCreation):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

LayoutTests:

  • platform/glib/TestExpectations: audiobuffersource-multi-channels.html is now passing.
  • platform/glib/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
  • platform/glib/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Added.
  • platform/glib/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
  • platform/glib/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Added.
  • platform/glib/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
  • platform/gtk/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Removed.
  • platform/gtk/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Removed.
  • platform/gtk/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Removed.
  • platform/gtk/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Removed.
  • platform/gtk/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Removed.
  • platform/gtk/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Removed.
8:24 AM Changeset in webkit [269103] by calvaris@igalia.com
  • 6 edits in trunk/Source/WebCore

[GStreamer][EME][Thunder] Do not sanitize CENC init data
https://bugs.webkit.org/show_bug.cgi?id=218182

Reviewed by Philippe Normand.

In certain cases, like smoothstreaming with PlayReady, the init
datas we are getting are correct but are not in PSSH box format
they would be "sanitized away". In this patch you can enable
sanitization customization depending on the CDM you're using.

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::sanitizeInitData):

  • platform/encryptedmedia/CDMPrivate.cpp:

(WebCore::CDMPrivate::sanitizeInitData const):

  • platform/encryptedmedia/CDMPrivate.h:
  • platform/graphics/gstreamer/eme/CDMThunder.cpp:

(WebCore::CDMPrivateThunder::sanitizeInitData const):

  • platform/graphics/gstreamer/eme/CDMThunder.h:
6:14 AM Changeset in webkit [269102] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Add support for case when nested vertical alignment affects the root inlinebox vertical position
https://bugs.webkit.org/show_bug.cgi?id=218271

Reviewed by Antti Koivisto.

Let's start tracking the nested vertical alignment offsets from the root's baseline.
It enables us to find out how much offset the root inlinebox's baseline is required inside the line box.
e.g.
<div style="font-size: 50px;">

root inlinebox text content
<span style="font-size: 10px; vertical-align: text-bottom">and some nested text with an image

<img src="broken.jpg" style="vertical-align: baseline; height: 100px; width: 100px;">

</span>

</div>
In this case, the nested inline box (<span>) has 'text-bottom' vertical alignment which may stretch the line box and
may push the root inlinebox downwards so as the nested <img> (aligned with the <span>'s baseline).

We simply compute the absolute offset value for each inline level boxes as we walk the "tree" and hold on to the maximum value.

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::alignInlineLevelBoxesVerticallyAndComputeLineBoxHeight):

6:13 AM Changeset in webkit [269101] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GStreamer] Mock video source doesn't set framerate on its caps
https://bugs.webkit.org/show_bug.cgi?id=218248

Patch by Philippe Normand <pnormand@igalia.com> on 2020-10-28
Reviewed by Xabier Rodriguez-Calvar.

Set framerate on the sample caps and reduce code duplication.

  • platform/graphics/gstreamer/MediaSampleGStreamer.cpp:

(WebCore::MediaSampleGStreamer::createImageSample):

  • platform/graphics/gstreamer/MediaSampleGStreamer.h:
  • platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:

(WebCore::MockRealtimeVideoSourceGStreamer::updateSampleBuffer):

6:13 AM Changeset in webkit [269100] by commit-queue@webkit.org
  • 4 edits
    2 adds
    3 deletes in trunk/Tools

[Flatpak SDK] Update Mesa and GTK4 dependencies
https://bugs.webkit.org/show_bug.cgi?id=218281

Patch by Philippe Normand <pnormand@igalia.com> on 2020-10-28
Reviewed by Carlos Alberto Lopez Perez.

  • buildstream/elements/flatpak/sdk.bst: Switch to app-debug-link as in the upstream FDO SDK.
  • buildstream/elements/freedesktop-sdk.bst: Bump junction ref.
  • buildstream/elements/sdk/mesa.bst: Update to 20.1.10 and add patch not present in stable release yet.
  • buildstream/patches/fdo-0001-pango-Bump-to-1.47.patch: Added.
  • buildstream/patches/mesa/0001-mesa-rename-_mesa_free_errors_data.patch: Removed.
  • buildstream/patches/mesa/0002-mesa-add-bool-param-to-_mesa_free_context_data.patch: Removed.
  • buildstream/patches/mesa/0003-mesa-st-release-debug_output-after-destroying-the-co.patch: Removed.
  • buildstream/patches/mesa/0004-mesa-clear-texture-s-views-when-texture-is-remove.patch: Added.
5:47 AM Changeset in webkit [269099] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] Using audio files for the <img> tag triggers warnings
https://bugs.webkit.org/show_bug.cgi?id=218245

Reviewed by Xabier Rodriguez-Calvar.

Plug non-video pads to a fake sink in order to maintain a valid pipeline. Later we should
switch to decodebin3 and rely on the stream selection facilities.

  • platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::InnerDecoder::connectDecoderPad):
(WebCore::ImageDecoderGStreamer::InnerDecoder::preparePipeline):

4:41 AM Changeset in webkit [269098] by calvaris@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed, reverting r269043.

Original patch was revert, should revert expectations as well

Reverted changeset:

"Unreviewed, GStreamer gardening"
https://trac.webkit.org/changeset/269043

4:40 AM Changeset in webkit [269097] by calvaris@igalia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, reverting r269033.

269043

Reverted changeset:

"[EME][GStreamer] Decode base64 init data if needed"
https://bugs.webkit.org/show_bug.cgi?id=218175
https://trac.webkit.org/changeset/269033

2:31 AM Changeset in webkit [269096] by Adrian Perez de Castro
  • 6 edits in trunk

[GTK4] Build broken with GTK 3.99.3
https://bugs.webkit.org/show_bug.cgi?id=218270

Reviewed by Carlos Garcia Campos.

Source/WebKit:

No new tests needed.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(toplevelWindowStateChanged): Replace GDK_SURFACE_STATE_MINIMIZED with GDK_TOPLEVEL_STATE_MINIMIZED.

  • UIProcess/API/gtk/WebKitWebViewGtk.cpp:

(surfaceStateChangedCallback): Ditto, and GDK_SURFACE_STATE_MAXIMIZED with GDK_TOPLEVEL_STATE_MAXIMIZED.

  • UIProcess/Gamepad/gtk/UIGamepadProviderGtk.cpp:

(WebKit::getWebPageProxy): Write an implementation which works for GTK4.
(WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput): Accomodate for windows
being a bit less special in GTK4 and use gtk_widget_has_focus() directly.

Tools:

  • buildstream/elements/sdk/gtk.bst: Bump GTK4 version to 3.99.4

Oct 27, 2020:

9:35 PM Changeset in webkit [269095] by Alan Bujtas
  • 7 edits in trunk/LayoutTests

Remove unneeded whitespace between content and <br>
https://bugs.webkit.org/show_bug.cgi?id=218151
<rdar://problem/70662471>

Reviewed by Antti Koivisto.

Missed these files in r268958.

  • accessibility/mac/text-marker-sentence-nav.html:
  • fast/dom/HTMLTextAreaElement/reset-textarea.html:
  • fast/text/basic/generic-family-reset.html:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac/fast/text/basic/generic-family-reset-expected.txt:
8:03 PM Changeset in webkit [269094] by achristensen@apple.com
  • 4 edits in trunk

Use _CFURLConnectionSetFrameworkStubs for SecItemShim instead of DYLD_INTERPOSE on Apple Silicon Macs
https://bugs.webkit.org/show_bug.cgi?id=218269
<rdar://problem/70491533>

Reviewed by Darin Adler.

Source/WebKit:

r171066 introduced the use of _CFURLConnectionSetFrameworkStubs on iOS for CFNetwork to be able
to get and set credentials as the UI process. This is also needed on Apple Silicon Macs.
We should eventually replace it with an even cleaner per-NSURLSession solution, but this is a step
in the right direction, and I verified manually that it fixes the radar.

Covered by an API test that used to fail on Apple Silicon Macs.

  • Shared/mac/SecItemShim.cpp:

(WebKit::initializeSecItemShim):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:

(TEST):

7:25 PM Changeset in webkit [269093] by Keith Rollin
  • 2 edits in trunk/Source/WebKitLegacy

Unexpected txt file: .../WebKitLegacy.framework/.../Sources.txt
https://bugs.webkit.org/show_bug.cgi?id=218268
<rdar://problem/70742539>

Reviewed by Tim Horton.

Sources.txt and SourcesCocoa.txt were added to the WebKitLegacy
project in https://trac.webkit.org/changeset/247401 as targets of the
WebKitLegacy target. This caused them to be treated as resources and
so were copied to the framework's Resources directory on a build.
These files don't need to be included in the build, and so are removed
from that target.

  • WebKitLegacy.xcodeproj/project.pbxproj:
7:09 PM Changeset in webkit [269092] by wenson_hsieh@apple.com
  • 11 edits in trunk

[Concurrent display lists] Add alternate versions of existing display list items that only contain inline data
https://bugs.webkit.org/show_bug.cgi?id=218259

Reviewed by Tim Horton.

Source/WebCore:

In preparation for supporting concurrent generation and consumption of display list items in the GPU process,
add new variants of some existing display list items that contain only "inline data" (i.e. no pointers).

No change in behavior; see below for more details.

  • platform/graphics/Path.cpp:

(WebCore::Path::isEmpty const):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::Path):

  • platform/graphics/Path.h:

Add a helper method to convert InlinePathData to Path.

(WebCore::Path::inlineData const):
(WebCore::Path::encode const):
(WebCore::Path::hasInlineData const):

Rename hasAnyInlineData to just hasInlineData, and make it public.

(WebCore::Path::releasePlatformPathIfPossible const): Deleted.

Additionally, remove releasePlatformPathIfPossible() altogether. This method was used to ensure that
StrokePath and FillPath wouldn't keep their Path's platform CGPathRefs around after applying the item in
the GPU process, which leads to accumulating a pool of unused CGPathRefs after playing back a display list
that contains many Path objects. However, since StrokeInlinePath and FillInlinePath now exist, the Path
object we create when applying those items is always going to be temporary, which allows us to avoid this
problem.

(WebCore::Path::hasAnyInlineData const): Deleted.

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::platformPath const):
(WebCore::Path::isNull const):

  • platform/graphics/displaylists/DisplayList.h:
  • platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::Item::sizeInBytes):
(WebCore::DisplayList::SetInlineFillGradient::SetInlineFillGradient):
(WebCore::DisplayList::SetInlineFillGradient::gradient const):
(WebCore::DisplayList::SetInlineFillGradient::create):
(WebCore::DisplayList::SetInlineFillGradient::apply const):
(WebCore::DisplayList::SetInlineFillGradient::isInline):

Introduce a new SetInlineFillGradient item to represent setting the fill gradient to a gradient with at most 4
color stops, with only inline colors. This inline data is pulled out of the Gradient upon construction, and
later used to reconstruct a Gradient during playback.

(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::SetInlineFillColor::create):
(WebCore::DisplayList::SetInlineFillColor::apply const):

Change SetFillColor to SetInlineFillColor, and make it pass around an SRGB<uint8_t> instead of a Color,
since the latter could contain a pointer to an extended color.

(WebCore::DisplayList::SetInlineStrokeColor::create):
(WebCore::DisplayList::SetInlineStrokeColor::apply const):

Similar to the above, but when setting the stroke color to an inline (non-extended) color.

(WebCore::DisplayList::SetStrokeThickness::create):
(WebCore::DisplayList::SetStrokeThickness::apply const):
(WebCore::DisplayList::FillInlinePath::FillInlinePath):
(WebCore::DisplayList::FillInlinePath::apply const):
(WebCore::DisplayList::FillPath::apply const):
(WebCore::DisplayList::StrokePath::apply const):
(WebCore::DisplayList::StrokeInlinePath::localBounds const):
(WebCore::DisplayList::StrokeInlinePath::apply const):
(WebCore::DisplayList::StrokeInlinePath::StrokeInlinePath):

Add StrokeInlinePath and FillInlinePath, which contain InlinePathData instead of Path objects and only
construct path() objects when needed (i.e. when applying to a GraphicsContext).

(WebCore::DisplayList::SetFillColor::create): Deleted.
(WebCore::DisplayList::SetFillColor::apply const): Deleted.
(WebCore::DisplayList::SetStrokeState::create): Deleted.
(WebCore::DisplayList::SetStrokeState::apply const): Deleted.

  • platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::SetInlineFillGradient::create):
(WebCore::DisplayList::SetInlineFillGradient::encode const):
(WebCore::DisplayList::SetInlineFillGradient::decode):
(WebCore::DisplayList::SetInlineFillColor::color const):
(WebCore::DisplayList::SetInlineFillColor::SetInlineFillColor):
(WebCore::DisplayList::SetInlineFillColor::encode const):
(WebCore::DisplayList::SetInlineFillColor::decode):
(WebCore::DisplayList::SetInlineStrokeColor::color const):
(WebCore::DisplayList::SetInlineStrokeColor::SetInlineStrokeColor):
(WebCore::DisplayList::SetInlineStrokeColor::encode const):
(WebCore::DisplayList::SetInlineStrokeColor::decode):
(WebCore::DisplayList::SetStrokeThickness::thickness const):
(WebCore::DisplayList::SetStrokeThickness::SetStrokeThickness):
(WebCore::DisplayList::SetStrokeThickness::encode const):
(WebCore::DisplayList::SetStrokeThickness::decode):

Pull stroke thickness out into its own display list item.

(WebCore::DisplayList::FillInlinePath::create):
(WebCore::DisplayList::FillInlinePath::path const):
(WebCore::DisplayList::FillInlinePath::encode const):
(WebCore::DisplayList::FillInlinePath::decode):
(WebCore::DisplayList::StrokeInlinePath::create):
(WebCore::DisplayList::StrokeInlinePath::path const):
(WebCore::DisplayList::StrokeInlinePath::encode const):
(WebCore::DisplayList::StrokeInlinePath::decode):
(WebCore::DisplayList::Item::encode const):
(WebCore::DisplayList::Item::decode):
(WebCore::DisplayList::SetFillColor::color const): Deleted.
(WebCore::DisplayList::SetFillColor::SetFillColor): Deleted.
(WebCore::DisplayList::SetFillColor::encode const): Deleted.
(WebCore::DisplayList::SetFillColor::decode): Deleted.
(WebCore::DisplayList::SetStrokeState::color const): Deleted.
(WebCore::DisplayList::SetStrokeState::hasColor const): Deleted.
(WebCore::DisplayList::SetStrokeState::thickness const): Deleted.
(WebCore::DisplayList::SetStrokeState::hasThickness const): Deleted.
(WebCore::DisplayList::SetStrokeState::SetStrokeState): Deleted.
(WebCore::DisplayList::SetStrokeState::encode const): Deleted.
(WebCore::DisplayList::SetStrokeState::decode): Deleted.

Split SetStrokeState out into separate items tracking thickness and stroke color.

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::containsOnlyInlineStateChanges):

Refactor this code so that it emits multiple display list items if multiple inline states change. Previously,
this was only done for simultaneous stroke color and stroke thickness changes (via the SetStrokeState item);
this was done to avoid creating more display list items than needed. However, once all inline display list items
are constructed directly in shared memory, there will be (almost) zero overhead for splitting this into
separate items.

(WebCore::DisplayList::Recorder::appendStateChangeItem):
(WebCore::DisplayList::Recorder::willAppendItem):
(WebCore::DisplayList::Recorder::fillPath):
(WebCore::DisplayList::Recorder::strokePath):
(WebCore::DisplayList::containsOnlyStrokeColorOrThicknessChange): Deleted.
(WebCore::DisplayList::containsOnlyFillColorChange): Deleted.
(WebCore::DisplayList::createStateChangeItem): Deleted.

Additionally refactor this method so that it is now a private method that appends to m_displayList, instead of
returning a display list item to be appended. This will become important in a future patch, which will replace
the existing append method with a templated version that takes the display list item type as a template
argument.

  • platform/graphics/displaylists/DisplayListRecorder.h:

LayoutTests:

Rebaseline an existing test.

  • displaylists/canvas-display-list-expected.txt:
6:49 PM Changeset in webkit [269091] by Russell Epstein
  • 5 edits in branches/safari-610-branch/Source

Apply patch. rdar://problem/70733375

6:42 PM Changeset in webkit [269090] by Russell Epstein
  • 2 edits in branches/safari-610-branch/Source/WTF

Cherry-pick r269019. rdar://problem/70733412

Add extra validation to MetaAllocator::findAndRemoveFreeSpace
https://bugs.webkit.org/show_bug.cgi?id=217792
<rdar://problem/69433015>

Reviewed Saam Barati.

  • wtf/MetaAllocator.cpp: (WTF::MetaAllocator::findAndRemoveFreeSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:42 PM Changeset in webkit [269089] by Russell Epstein
  • 2 edits in branches/safari-610-branch/Source/WTF

Cherry-pick r269017. rdar://problem/70733371

Assert that WTF::HashTable does not visit the same bucket twice
https://bugs.webkit.org/show_bug.cgi?id=217691
<rdar://problem/69887843>

Reviewed by Saam Barati.

  • wtf/HashTable.h: (WTF::KeyTraits>::inlineLookup): (WTF::KeyTraits>::lookupForWriting): (WTF::KeyTraits>::fullLookupForWriting): (WTF::KeyTraits>::addUniqueForInitialization): (WTF::KeyTraits>::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:42 PM Changeset in webkit [269088] by Russell Epstein
  • 2 edits in branches/safari-610-branch/Source/JavaScriptCore

Cherry-pick r269016. rdar://problem/70733329

Validate addresses returned by LinkBuffer::locationOf
https://bugs.webkit.org/show_bug.cgi?id=217786
<rdar://problem/69887913>

Reviewed by Saam Barati.

  • assembler/LinkBuffer.h: (JSC::LinkBuffer::locationOf): (JSC::LinkBuffer::locationOfNearCall): (JSC::LinkBuffer::getLinkerAddress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:42 PM Changeset in webkit [269087] by Russell Epstein
  • 7 edits
    1 add in branches/safari-610-branch

Cherry-pick r268878. rdar://problem/70733353

UIClient isn't notified when page muted state changes
https://bugs.webkit.org/show_bug.cgi?id=218085
<rdar://problem/70462420>

Reviewed by Youenn Fablet.

Source/WebKit:

API test: WKWebView.MediaMuted

  • UIProcess/API/C/WKPage.cpp: (WKPageGetMediaState): reportedMediaCaptureState -> reportedMediaState.
  • UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _mediaCaptureState]): Ditto.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateReportedMediaCaptureState): Only record current capture state in m_reportedMediaCaptureState. m_delayStopCapturingReporting isn't necessary, remove it.
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::reportedMediaState const): Renamed from reportedMediaCaptureState to reflect what it returns. (WebKit::WebPageProxy::mediaStateFlags const): Deleted. (WebKit::WebPageProxy::reportedMediaCaptureState const): Deleted.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
  • TestWebKitAPI/Tests/WebKitCocoa/MediaMutedState.mm: Added. (-[AudioStateObserver initWithWebView:]): (-[AudioStateObserver observeValueForKeyPath:ofObject:change:context:]): (-[AudioStateTestView setMuted:]): (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:42 PM Changeset in webkit [269086] by Russell Epstein
  • 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r268537. rdar://problem/70733338

Crash in -[WKDateTimePicker setDateTimePickerToInitialValue]
https://bugs.webkit.org/show_bug.cgi?id=217763
<rdar://problem/68635008>

Reviewed by Wenson Hsieh.

Crash occurs due to the use of an autoreleased NSString in
setDateTimePickerToInitialValue. To fix, make the variable
a RetainPtr.

  • UIProcess/ios/forms/WKDateTimeInputControl.mm: (-[WKDateTimePicker setDateTimePickerToInitialValue]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:42 PM Changeset in webkit [269085] by Russell Epstein
  • 2 edits in branches/safari-610-branch/Source/WTF

Cherry-pick r268135. rdar://problem/70733407

Add maximum depth check to RedBlackTree
https://bugs.webkit.org/show_bug.cgi?id=217249
<rdar://problem/69432957>

Reviewed by Saam Barati.

We limit all tree traversals to 128 levels deep. That's a very conservative upper bound that
would work for a tree that used all of the available address space.

  • wtf/RedBlackTree.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:36 PM Changeset in webkit [269084] by Said Abou-Hallawa
  • 21 edits in trunk/Source

Make RenderingMode a bool enum and remove ShouldAccelerate
https://bugs.webkit.org/show_bug.cgi?id=218264

Reviewed by Tim Horton.

Source/WebCore:

Convert RenderingMode back to be a bool enum. ShouldAccelerate will be
removed so no conversion from RenderingMode to ShouldAccelerate and vice
versa is needed anymore. Only one instance of ImageBuffer::create() will
be handling creating the remote and display list ImageBuffers.

-- Remove unused createImageBuffer() method in HostWindow and ChromeClient.
-- Remove unused argument 'ShouldUseDisplayList' from createImageBuffer()

of HostWindow, ChromeClient and WebChromeClient.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer const):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::createBufferForPainting const):

  • html/HTMLVideoElement.h:
  • html/ImageBitmap.cpp:

(WebCore::ImageBitmap::createPromise):

  • html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::createPattern):

  • page/Chrome.cpp:

(WebCore::Chrome::createImageBuffer const):

  • page/Chrome.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::createImageBuffer const):

  • platform/HostWindow.h:
  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::create):

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/RenderingMode.h:

Source/WebKit:

When creating a remote ImageBuffer in WebKit, all we need to know is whether
the backend is accelerated or not. RemoteImageBufferProxy has to be backed
by a DisplayList. RemoteImageBuffer has to own the real backend. Two enum
values for RenderingMode is sufficient for creating the remote ImageBuffer.

  • GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::createImageBuffer):

  • GPUProcess/graphics/RemoteRenderingBackend.h:
  • Shared/WebCoreArgumentCoders.h:
  • WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::createImageBuffer):

  • WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createImageBuffer const):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
6:00 PM Changeset in webkit [269083] by Dewei Zhu
  • 14 edits
    2 adds in trunk/Websites/perf.webkit.org

Refactor 'platforms' table to contain group information.
https://bugs.webkit.org/show_bug.cgi?id=193132

Reviewed by Ryosuke Niwa.

Group 'platforms' so that bisecting can use commit sets from other platforms which are in the same platform group.
This will help to enhance the bisecting capability to higher granularity.
Added admin page to manage platform groups.
Updated platform admin page to allow update platform group.
SQL query to update existing database:

BEGIN;
CREATE TABLE platform_groups (

platformgroup_id serial PRIMARY KEY,
platformgroup_name varchar(64) NOT NULL,
CONSTRAINT platform_group_name_must_be_unique UNIQUE (platformgroup_name));

ALTER TABLE platforms ADD COLUMN platform_group integer REFERENCES platform_groups DEFAULT NULL;
END;

  • init-database.sql: Added 'platform_group' column to 'platforms' table.

Added 'platform_groups' table.

  • migrate-database.sql: Updated migration script accordingly.
  • public/admin/platform-groups.php: Added a page to manage platform groups.
  • public/admin/platforms.php: Added support to update platform group in admin page.
  • public/include/admin-header.php: Added link to page that maneges platform groups.
  • public/include/manifest-generator.php: Added 'platformGroup' in manifest.
  • public/v3/index.html: Included 'platform-groups.js'.
  • public/v3/models/analysis-task.js:

(AnalysisTask.prototype.async.commitSetsFromTestGroupsAndMeasurementSet):
Included measurement commit sets from other platforms in the same platform group.
(AnalysisTask.prototype._commitSetForOtherPlatformsInSameGroup):
Helper function to find measurment commit set for other platforms in same platform group.

  • public/v3/models/manifest.js: Added step to build 'PlatformGroup' instances.
  • public/v3/models/platform-group.js: Added 'PlatformGroup' to represent entries in 'platform_groups' table.

(PlatformGroup):
(PlatformGroup.prototype.addPlatform):
(PlatformGroup.prototype.platforms):

  • public/v3/models/platform.js: Added itself to 'PlatformGroup' in constructor if it belongs

to a group.
(Platform.prototype.group): Return the platform group of current platform.

  • public/v3/models/time-series.js: Added helper function to show view between a given time range.

(TimeSeries.prototype.viewBetweenTime):

  • server-tests/api-manifest-tests.js: Updated unit test to also test platform group initialization.
  • tools/js/database.js: Added prefix for 'platform_groups'.
  • tools/js/v3-models.js: Added import for platform group.
5:10 PM Changeset in webkit [269082] by timothy_horton@apple.com
  • 6 edits in trunk/Source

Adopt the UIPointerInteraction API
https://bugs.webkit.org/show_bug.cgi?id=218266
<rdar://problem/70732850>

Reviewed by Wenson Hsieh.

Source/WebKit:

No new tests, just moving from deprecated SPI to API.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView setUpPointerInteraction]):
(-[WKContentView _pointerInteraction:regionForRequest:defaultRegion:completion:]):
(-[WKContentView pointerRegionForPositionInformation:point:]):
(-[WKContentView pointerInteraction:styleForRegion:]):
(-[WKContentView setUpCursorInteraction]): Deleted.
(-[WKContentView _cursorInteraction:regionForLocation:defaultRegion:completion:]): Deleted.
(-[WKContentView cursorRegionForPositionInformation:point:]): Deleted.
(-[WKContentView cursorInteraction:styleForRegion:modifiers:]): Deleted.

Source/WTF:

  • wtf/PlatformHave.h:
5:06 PM Changeset in webkit [269081] by Chris Dumez
  • 8 edits
    1 add in trunk

AudioBuffer.getChannelData(x) should keep returning the same JS wrapper for a given channel
https://bugs.webkit.org/show_bug.cgi?id=218265

Reviewed by Geoff Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now fully passing. I have verified that this test passes in Chrome and Firefox
as well.

  • web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-getChannelData-expected.txt:

Source/WebCore:

AudioBuffer.getChannelData(x) should keep returning the same JS wrapper for a given channel.
This is the behavior of Chrome & Firefox and is covered by Web-Platform-Tests.

No new tests, rebaselined existing test.

  • Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::AudioBuffer):
(WebCore::AudioBuffer::releaseMemory):
(WebCore::AudioBuffer::getChannelData):
(WebCore::AudioBuffer::visitChannelWrappers):

  • Modules/webaudio/AudioBuffer.h:
  • Modules/webaudio/AudioBuffer.idl:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
4:50 PM Changeset in webkit [269080] by weinig@apple.com
  • 2 edits in trunk/Tools

DumpRenderTree spams stderr with CFNetwork warnings about null diskcache path
https://bugs.webkit.org/show_bug.cgi?id=218241

Reviewed by Darin Adler.

Remove attempt at using a memory only shared URL cache, as subsequent calls
to [WebPreferences setCacheModel:] cause a disk cache to be used anyway. All
this really seems to do is cause CFNetwork to log to stderr. It's unlikely
this optimization is worthwhile anyway these days, as avoiding touching the
filesystem is less necessary.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(prepareConsistentTestingEnvironment):

4:23 PM Changeset in webkit [269079] by clopez@igalia.com
  • 26 edits in trunk/LayoutTests

[GTK][WPE] Rebaseline tests after r269044 and r269036
https://bugs.webkit.org/show_bug.cgi?id=218151

Unreviewed gardening.

  • platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/gtk/fast/forms/option-index-expected.txt:
  • platform/gtk/fast/text/basic/generic-family-reset-expected.txt:
  • platform/gtk/fast/xsl/xslt-enc-cyr-expected.txt:
  • platform/gtk/fast/xsl/xslt-enc-expected.txt:
  • platform/gtk/fast/xsl/xslt-enc16-expected.txt:
  • platform/gtk/fast/xsl/xslt-enc16to16-expected.txt:
  • platform/gtk/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/gtk/http/tests/navigation/postredirect-goback1-expected.txt:
  • platform/gtk/inspector/timeline/line-column-expected.txt:
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/wpe/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/wpe/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/wpe/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/wpe/fast/text/basic/generic-family-reset-expected.txt:
  • platform/wpe/fast/xsl/xslt-enc-cyr-expected.txt:
  • platform/wpe/fast/xsl/xslt-enc-expected.txt:
  • platform/wpe/fast/xsl/xslt-enc16-expected.txt:
  • platform/wpe/fast/xsl/xslt-enc16to16-expected.txt:
  • platform/wpe/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/wpe/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/wpe/http/tests/navigation/postredirect-goback1-expected.txt:
  • platform/wpe/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
  • platform/wpe/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt:
  • platform/wpe/svg/wicd/test-rightsizing-b-expected.txt:
3:22 PM Changeset in webkit [269078] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

Remove leftover DiagnosticLoggingKey after r268458
https://bugs.webkit.org/show_bug.cgi?id=218263
<rdar://problem/70738034>

Reviewed by Darin Adler.

Remove the leftover DiagnosticKey for ResourceLoadStatistics telemetry now that the
actual data is no longer generated.

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::resourceLoadStatisticsTelemetryKey): Deleted.

  • page/DiagnosticLoggingKeys.h:
3:21 PM Changeset in webkit [269077] by jer.noble@apple.com
  • 5 edits
    2 adds in trunk

[Mac] Audio and Video element creation up to 300x slower than other browsers
https://bugs.webkit.org/show_bug.cgi?id=218206
<rdar://problem/62451019>

Reviewed by Eric Carlson.

PerformanceTests:

  • Media/AudioElementCreation.html: Added.
  • Media/VideoElementCreation.html: Added.

Source/WebCore:

Tests: PerformanceTests/Media/AudioElementCreation.html

PerformanceTests/Media/VideoElementCreation.html

Currently, a large percent of the element creation code occurrs as a result of adding its
session to PlatformMediaSessionManager, which forces iterating over all extant sessions and
then to set various properties of the audio hardware in response. This patch addresses the
bulk of those expensive calls, but more performance optimizations are available to further
reduce media element creation costs.

When an <audio> element is created, we set the preferred audio output buffer size to a large
value for performance reasons. However, there's no need to repeatedly call into CoreAudio if
the buffer size is already set to that same high value. Store the result of setting the
preferred buffer size, and also add a property change listener to detect other callers
modifying that same value, so that all set operations with identical sizes become no-ops,
and all queries just return cached values.

When any media element is created, the entire list of extant sessions is iterated and
properties on each are queried. Rather than do these inside the same run-loop, use a
TaskQueue to enqueue a task to query the list of created elements during the next run-loop.

Between these two optimization, the runtime cost of creating 1000 audio elements is reduced
(on this engineer's machine) from 2s to 40ms.

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::beginInterruption):
(WebCore::PlatformMediaSessionManager::addSession):
(WebCore::PlatformMediaSessionManager::removeSession):
(WebCore::PlatformMediaSessionManager::sessionStateChanged):
(WebCore::PlatformMediaSessionManager::forEachDocumentSession):
(WebCore::PlatformMediaSessionManager::forEachSession):
(WebCore::PlatformMediaSessionManager::anyOfSessions const):

  • platform/audio/PlatformMediaSessionManager.h:
  • platform/audio/mac/AudioSessionMac.mm:

(WebCore::AudioSessionPrivate::addSampleRateObserverIfNeeded):
(WebCore::AudioSessionPrivate::handleSampleRateChange):
(WebCore::AudioSessionPrivate::addBufferSizeObserverIfNeeded):
(WebCore::AudioSessionPrivate::handleBufferSizeChange):
(WebCore::AudioSession::sampleRate const):
(WebCore::AudioSession::bufferSize const):
(WebCore::AudioSession::preferredBufferSize const):
(WebCore::AudioSession::setPreferredBufferSize):

2:54 PM Changeset in webkit [269076] by Keith Rollin
  • 2 edits in trunk

Fix "usage" message when invoking ar -V
https://bugs.webkit.org/show_bug.cgi?id=218255
<rdar://problem/70735674>

Reviewed by Fujii Hironori.

The Mac/BSD version of ar does not support the -V flag. This flag is
used unconditionally in OptionsCommon.cmake when trying to determine
if the installed ar supports the thinning of archives, leading to a
"usage" message being emitted on macOS.

Avoid this message by capturing the error-output. Examine the output
to see if it's a "usage" message. If so, then treat the ar as one
that does not support thinning. Any other error-output is printed as a
warning. If there is no error-output, continue processing as normal.

  • Source/cmake/OptionsCommon.cmake:
2:49 PM Changeset in webkit [269075] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: truncate data URLs in the Resources sidebar and Headers panel
https://bugs.webkit.org/show_bug.cgi?id=218262

Reviewed by Darin Adler.

  • UserInterface/Base/Main.js:

(WI.createResourceLink):

  • UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WI.ResourceDetailsSidebarPanel.prototype._refreshURL):

  • UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._refreshSummarySection):

2:48 PM Changeset in webkit [269074] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Search: don't steal focus from the search field when shown
https://bugs.webkit.org/show_bug.cgi?id=218260

Reviewed by Brian Burg.

  • UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype.focusSearchField):
(WI.SearchSidebarPanel.prototype.performSearch.createTreeElementForMatchObject):

2:46 PM Changeset in webkit [269073] by Chris Dumez
  • 21 edits in trunk

[GPUProcess] Use async IPC for RemoteAudioDestinationManager's StartAudioDestination / StopAudioDestination
https://bugs.webkit.org/show_bug.cgi?id=218251

Reviewed by Geoffrey Garen.

Source/WebCore:

DefaultAudioDestinationNode::resume() / suspend() were already asynchronous operations. However, they expected
AudioDestination::start() / stop() to finish synchronously and would simply call their completion handler
asynchronously. Instead, we now make AudioDestination::start() / stop() asynchronous as well. This allows us
to use asynchronous IPC for RemoteAudioDestinationManager's StartAudioDestination / StopAudioDestination.

As a result of this change, I had to make AudioDestinationNode::startRendering() asynchronous as well since
it uses AudioDestination::start() internally.

As an improvement, the completion handler to AudioDestinationNode's startRendering() / resume() / suspend()
is now provided with an exception in cases where they fail. This allows the call sites to properly deal
with such errors instead of assuming things were successsful.

No new tests, no Web-facing beahvior change.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::suspendRendering):
(WebCore::AudioContext::resumeRendering):
(WebCore::AudioContext::startRendering):
(WebCore::AudioContext::mayResumePlayback):
(WebCore::AudioContext::suspendPlayback):

  • Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::resume):
(WebCore::AudioDestinationNode::suspend):
(WebCore::AudioDestinationNode::close):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::startRendering):
(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):

  • Modules/webaudio/DefaultAudioDestinationNode.h:
  • Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::startOfflineRendering):
(WebCore::OfflineAudioContext::resumeOfflineRendering):

  • Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::startRendering):

  • Modules/webaudio/OfflineAudioDestinationNode.h:
  • platform/audio/AudioDestination.h:

(WebCore::AudioDestination::start):
(WebCore::AudioDestination::stop):

  • platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestinationCocoa::start):
(WebCore::AudioDestinationCocoa::stop):

  • platform/audio/cocoa/AudioDestinationCocoa.h:
  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::start):
(WebCore::AudioDestinationGStreamer::stop):

  • platform/audio/gstreamer/AudioDestinationGStreamer.h:
  • platform/mock/MockAudioDestinationCocoa.cpp:

(WebCore::MockAudioDestinationCocoa::start):
(WebCore::MockAudioDestinationCocoa::stop):

  • platform/mock/MockAudioDestinationCocoa.h:

Source/WebKit:

Use async IPC for RemoteAudioDestinationManager's StartAudioDestination / StopAudioDestination.

  • GPUProcess/media/RemoteAudioDestinationManager.messages.in:
  • WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:

(WebKit::RemoteAudioDestinationProxy::start):
(WebKit::RemoteAudioDestinationProxy::stop):

  • WebProcess/GPU/media/RemoteAudioDestinationProxy.h:

LayoutTests:

  • webaudio/audiocontext-state.html:

Update existing test which incorrectly expected the AudioContext's state to become "running" synchronously
after connecting a source node. The state switches to "running" asynchronously now. It is up to the user
agent if and when the audio context starts autoplaying so this should be an acceptable behavior change.

2:40 PM Changeset in webkit [269072] by Fujii Hironori
  • 8 edits in trunk

[TextureMapper][GTK] Test compositing/clipping/border-radius-stacking-context-clip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=214868

Reviewed by Carlos Garcia Campos.

Source/WebCore:

If a replica layer has m_state.pos, m_layerTransforms.combined
should be translated by them.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeTransformsRecursive):

  • platform/graphics/texmap/TextureMapperLayer.h:

LayoutTests:

  • platform/gtk/TestExpectations: Unmarked compositing/clipping/border-radius-stacking-context-clip.html.
  • platform/gtk/compositing/reflections/nested-reflection-transformed-expected.png: Updated.
  • platform/gtk/compositing/reflections/nested-reflection-transformed2-expected.png: Updated.
  • platform/gtk/compositing/reflections/reflection-positioning2-expected.png: Updated.
2:38 PM Changeset in webkit [269071] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r266669): Uncaught Exception: TypeError: node.nodeType is not a function. (In 'node.nodeType()', 'node.nodeType' is undefined)
https://bugs.webkit.org/show_bug.cgi?id=218254

Reviewed by Joseph Pecoraro.

r266669 changed WI.DOMBreakpoint to use WI.DOMNode instead of DOM.NodeId, meaning that
WI.DOMTreeContentView.prototype._updateBreakpointStatus now expects a WI.DOMNode.

  • UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype._domTreeElementAdded):

2:04 PM Changeset in webkit [269070] by commit-queue@webkit.org
  • 10 edits
    2 moves
    2 adds in trunk

Overflow scrollIntoView wrong with borders
https://bugs.webkit.org/show_bug.cgi?id=152660

Patch by Martin Robinson <mrobinson@igalia.com> on 2020-10-27
Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/overflow/scrollIntoView-nested-in-area-with-border.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible): Offset the exposure rect by the border
so that it is relative to the content rectangle.

LayoutTests:

Added a new test for this fix and renamed a similar test to follow a
standard naming convention. This will make the two tests easier to find.

  • fast/overflow/scrollIntoView-nested-in-area-with-border-expected.html: Added.
  • fast/overflow/scrollIntoView-nested-in-area-with-border.html: Added.
  • fast/overflow/scrollIntoView-overflow-hidden-expected.html: Renamed from LayoutTests/fast/overflow/overflow-hidden-scroll-into-view-expected.html.
  • fast/overflow/scrollIntoView-overflow-hidden.html: Renamed from LayoutTests/fast/overflow/overflow-hidden-scroll-into-view.html.
  • fast/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt: Updated expectation.
  • platform/ios/TestExpectations: Updated test name in expectations.
  • platform/mac-wk2/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Updated expectation.
  • platform/mac-wk2/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Ditto.
  • platform/mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Ditto.
  • platform/mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Ditto.
  • platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Ditto.
1:59 PM Changeset in webkit [269069] by Lauro Moura
  • 2 edits in trunk/Source/WebCore

Unreviewed. Followup for r269058: Update bindings reference files

  • bindings/scripts/test/JS/JSTestDOMJIT.cpp:
1:54 PM Changeset in webkit [269068] by Brian Burg
  • 25 edits
    4 copies
    1 add in trunk

[Cocoa] Introduce _WKInspectorConfiguration for customizing local and remote Web Inspectors
https://bugs.webkit.org/show_bug.cgi?id=217896
<rdar://problem/70355910>

Reviewed by Devin Rousso.

Source/WebKit:

Introduce _WKInspectorConfiguration for customizing the behavior of Web Inspector instances.
The initial customization is to allow for custom WKURLSchemeHandlers to be used by Web Inspector's
WebView to load resources from client-controlled locations. This can be used to implement loading
of extension resources using a custom scheme such as web-extension://.

Scheme handlers need to be registered at WebView creation time via WKWebViewConfiguration. In
order to configure a inspector page summoned from within WebKit (i.e., Inspect Element context menu item),
we need to add a method to the UI delegate to get a configuration when the page is being created.

This configuration object is used in two different SPI (local and remote cases):

  • As part of WKUIDelegatePrivate, to retrieve a _WKInspectorConfiguration given a _WKInspector.
  • As an argument to the _WKRemoteWebInspectorViewController initializer. It's used later as needed.

New API test: WKInspectorDelegate.InspectorConfiguration.

  • SourcesCocoa.txt:
  • WebKit.xcodeproj/project.pbxproj:

Add new files.

  • UIProcess/API/APIInspectorConfiguration.h: Added.
  • UIProcess/API/APIInspectorConfiguration.cpp: Added.
  • UIProcess/API/Cocoa/_WKInspectorConfiguration.h: Added.
  • UIProcess/API/Cocoa/_WKInspectorConfigurationInternal.h: Added.
  • UIProcess/API/Cocoa/_WKInspectorConfiguration.mm: Added.

(-[_WKInspectorConfiguration init]):
(-[_WKInspectorConfiguration dealloc]):
(-[_WKInspectorConfiguration _apiObject]):
(-[_WKInspectorConfiguration setURLSchemeHandler:forURLScheme:]):
(-[_WKInspectorConfiguration applyToWebViewConfiguration:]):
(-[_WKInspectorConfiguration copyWithZone:]):
Create _WKInspectorConfiguration and add a method to register WKURLSchemeHandlers.

  • Shared/API/APIObject.h:
  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
Add new API object types. Add missing InspectorExtension.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/APIUIClient.h:

(API::UIClient::configurationForLocalInspector):

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::configurationForLocalInspector):
Add new client/delegate method to fetch an inspector configuration as needed.

  • UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
  • UIProcess/API/Cocoa/_WKRemoteWebInspectorViewControllerPrivate.h:
  • UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(-[_WKRemoteWebInspectorViewController initWithConfiguration:]): Renamed from -init.
(-[_WKRemoteWebInspectorViewController init]): Deleted.
(-[_WKRemoteWebInspectorViewController loadForDebuggableType:backendCommandsURL:]):
(-[_WKRemoteWebInspectorViewController configurationForDebuggable:]):
(-[_WKRemoteWebInspectorViewController _setDiagnosticLoggingDelegate:]):
Store a _WKInspectorConfiguration and provide it when asked by RemoteWebInspectorProxy.

  • UIProcess/Inspector/RemoteWebInspectorProxy.h:
  • UIProcess/Inspector/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::load):
Store m_debuggableInfo before creating the page and window. It's used from inside
platformCreateFrontendPageAndWindow to pass as an argument to the delegate method.

  • UIProcess/Inspector/mac/RemoteWebInspectorProxyMac.mm:

(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):

  • UIProcess/Inspector/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateFrontendPage):
Obtain a configuration and use it to initialize the WKInspectorViewController.

  • UIProcess/Inspector/mac/WKInspectorViewController.h:
  • UIProcess/Inspector/mac/WKInspectorViewController.mm:

(-[WKInspectorViewController initWithConfiguration:inspectedPage:]):
(-[WKInspectorViewController webView]):
(-[WKInspectorViewController webViewConfiguration]): Renamed from -configuration.
(-[WKInspectorViewController initWithInspectedPage:]): Deleted.
(-[WKInspectorViewController configuration]): Deleted.
Apply the URL scheme handlers registered in the _WKInspectorConfiguration to the
WKWebViewConfiguration.

  • UIProcess/Inspector/glib/RemoteInspectorClient.cpp:
  • UIProcess/Inspector/socket/RemoteInspectorClient.cpp:

Stub out RemoteWebInspectorProxyClient::configurationForRemoteInspector().

  • UIProcess/API/Cocoa/_WKUserStyleSheet.h:
  • UIProcess/API/Cocoa/_WKUserStyleSheet.mm:

Fix build problems caused by repartitioning of unified sources.

Tools:

Add an API test for _WKInspectorConfiguration. Disabled for now, will
be turned back on when more web extensions API has landed.

  • TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm:

(-[SimpleURLSchemeHandler webView:startURLSchemeTask:]):
(-[SimpleURLSchemeHandler webView:stopURLSchemeTask:]):
(-[UIDelegate _webView:configurationForLocalInspector:]):
(-[UIDelegate _webView:didAttachLocalInspector:]):
(TEST):

1:22 PM Changeset in webkit [269067] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r265515): fast/events/touch/ios/touch-events-with-modifiers.html is a frequent failure
https://bugs.webkit.org/show_bug.cgi?id=218249
<rdar://problem/67079948>

Reviewed by Wenson Hsieh.

  • fast/events/touch/ios/resources/finish-test-after-scrolling-with-touch-event-handlers.html:

Don't notifyDone until both the scroll event happen and the event stream is done being dispatched.
Otherwise, we can move on and then send part of our event stream to the next page.

12:53 PM Changeset in webkit [269066] by Fujii Hironori
  • 4 edits in trunk/Source/WebKitLegacy/win

[WinCairo][WK1] Implement WebView::layerTreeAsString
https://bugs.webkit.org/show_bug.cgi?id=218217

Reviewed by Don Olmstead.

The menu item "Show Layer Tree" didn't work in WinCairo WebKit1
MiniBrowser.

  • WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::layerTreeAsString const): Added.

  • WebCoreSupport/AcceleratedCompositingContext.h:
  • WebView.cpp:

(WebView::layerTreeAsString): Added code for USE(TEXTURE_MAPPER_GL).

12:53 PM Changeset in webkit [269065] by commit-queue@webkit.org
  • 20 edits in trunk/Source

[GPU Process]: Implement DisplayList::DrawImageBuffer item
https://bugs.webkit.org/show_bug.cgi?id=217566

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-10-27
Reviewed by Simon Fraser.

Source/WebCore:

Add the DrawImageBuffer DisplayList item. It will be used only for GPU
rendering. The renderingResourceIdentifier of the source ImageBuffer
will be recorded. For details on how drawing an ImageBuffer to another
ImageBuffer works see the WebKit ChangeLog.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::drawConsumingImageBuffer):

  • platform/graphics/GraphicsContextImpl.h:
  • platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawImageBuffer):

  • platform/graphics/cairo/GraphicsContextImplCairo.h:
  • platform/graphics/displaylists/DisplayList.h:
  • platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::Item::sizeInBytes):
(WebCore::DisplayList::DrawImageBuffer::DrawImageBuffer):
(WebCore::DisplayList::DrawImageBuffer::apply const):
(WebCore::DisplayList::operator<<):

  • platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawImageBuffer::create):
(WebCore::DisplayList::DrawImageBuffer::renderingResourceIdentifier const):
(WebCore::DisplayList::DrawImageBuffer::source const):
(WebCore::DisplayList::DrawImageBuffer::destinationRect const):
(WebCore::DisplayList::DrawImageBuffer::options const):
(WebCore::DisplayList::DrawImageBuffer::encode const):
(WebCore::DisplayList::DrawImageBuffer::decode):
(WebCore::DisplayList::Item::encode const):
(WebCore::DisplayList::Item::decode):

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawImageBuffer):

  • platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::Delegate::lockRemoteImageBuffer):

  • platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::drawImageBuffer):

  • platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:

Source/WebKit:

The sequence in the Web Process is the following:

-- GraphicsContext::drawImageBuffer() uses DisplayList::Recorder to check

whether it is appropriate to create a DrawImageBuffer item or not.

-- DisplayList::Recorder::drawImageBuffer() uses the delegate to see if

the ImageBuffer is remote or not and whether it can be locked till
replaying back the DisplayList in the GPU side.

-- RemoteImageBufferProxy inherits DisplayList::Recorder::Delegate. So

its lockRemoteImageBuffer() is called.

-- If the ImageBuffer can be locked, a DrawImageBufferItem is created with

the ImageBuffer::renderingResourceIdentifier().

The sequence in the GPU Process is the following:

-- When replaying back the DisplayList, DisplayList::Replayer will call

its delegate to check if it wants to apply the DrawImageBuffer.

-- Because RemoteImageBuffer inherits DisplayList::Replayer::Delegate,

RemoteImageBuffer::apply() will be called.

-- RemoteImageBuffer will call RemoteRenderingBackend::applyResourceItem()

which will check whether the item's renderingResourceIdentifier is one
of the ImageBuffers in its RemoteResourceCache or not.

-- If there is a cached ImageBuffer, RemoteRenderingBackend::applyResourceItem()

will draw it in the GraphicsContext.

  • GPUProcess/graphics/RemoteImageBuffer.h:

(WebKit::RemoteImageBuffer::apply): Deleted.

  • GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::applyResourceItem):
(WebKit::RemoteRenderingBackend::applyMediaItem):

  • GPUProcess/graphics/RemoteRenderingBackend.h:
  • GPUProcess/graphics/RemoteResourceCache.cpp:

(WebKit::RemoteResourceCache::cachedImageBuffer):

  • WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
  • WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:

(WebKit::RemoteResourceCacheProxy::releaseImageBuffer):
(WebKit::RemoteResourceCacheProxy::lockRemoteImageBufferForRemoteClient):
(WebKit::RemoteResourceCacheProxy::lockRemoteResourceForRemoteClient):
(WebKit::RemoteResourceCacheProxy::releaseRemoteResource):
(WebKit::RemoteResourceCacheProxy::unlockRemoteResourcesForRemoteClient):

  • WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:
12:40 PM Changeset in webkit [269064] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

showRenderTree should output line vertical geometry.
https://bugs.webkit.org/show_bug.cgi?id=218252

Reviewed by Antti Koivisto.

In addition to the root inlinebox geometry, we should also print the line vertical geometry as they
could be very different in certain cases.

<div style="line-height: 100px;">

text
<img src="broken" style="width: 50px; height: 50px;">

</div>

would produce something these:

Line: (top: 5 bottom: 59) with leading (top: 0 bottom: 100)
RootInlineBox at (0,41) size 51.76x18 (0x137faef70) renderer->(0x137faec00)

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::outputLineBox const):

  • rendering/RootInlineBox.h:
12:33 PM Changeset in webkit [269063] by Keith Rollin
  • 2 edits in trunk/Tools

Update generate_xcfilelists to accommodate paths with symlinks
https://bugs.webkit.org/show_bug.cgi?id=218223
<rdar://problem/70709808>

Reviewed by Timothy Hatcher.

There are cases where file system paths are compared against each
other, and where the comparisons are failing because one or the other
(or both) make use of symlinks, causing paths that refer to the same
location to fail to compare correctly. Address this by resolving path
components that are symlinks.

  • Scripts/webkitpy/generate_xcfilelists_lib/generators.py:

(BaseGenerator):
(BaseGenerator._unexpand):
(BaseGenerator._unexpand._expand_if_abs):
(BaseGenerator._unexpand._variations):
(BaseGenerator._unexpand._variations._gen):
(BaseGenerator._unexpand._try_unexpand):
(BaseGenerator._unexpand._do_unexpand):

12:17 PM WebKitGTK/2.30.x edited by Adrian Perez de Castro
(diff)
12:17 PM Changeset in webkit [269062] by Adrian Perez de Castro
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.30

Merge r269055 - [GStreamer] Bad handling of audio files in the ImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=218239

Patch by Philippe Normand <pnormand@igalia.com> on 2020-10-27
Reviewed by Adrian Perez de Castro.

Source/WebCore:

The final main thread notification needs to be blocking otherwise the decoder might get
disposed of too early.

Test: fast/images/animated-image-mp3-crash.html

  • platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::pushEncodedData):

LayoutTests:

  • fast/images/animated-image-mp3-crash-expected.txt: Added.
  • fast/images/animated-image-mp3-crash.html: Added.
12:07 PM Changeset in webkit [269061] by Russell Epstein
  • 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.3.6

12:00 PM Changeset in webkit [269060] by Russell Epstein
  • 1 copy in tags/Safari-610.3.5

Tag Safari-610.3.5.

11:51 AM Changeset in webkit [269059] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Accessory bar next/previous buttons do not work on inputs in shadow roots
https://bugs.webkit.org/show_bug.cgi?id=203292

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-10-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/shadow-dom/ios/accessory-bar-work-on-input-with-tabindex-in-shadow-tree.html

  • page/FocusController.cpp:

(WebCore::FocusController::nextFocusableElement):
(WebCore::FocusController::previousFocusableElement):

LayoutTests:

Introduced testcases only need to run with iOS family.

  • fast/shadow-dom/ios/accessory-bar-work-on-input-with-tabindex-in-shadow-tree-expected.txt: Added.
  • fast/shadow-dom/ios/accessory-bar-work-on-input-with-tabindex-in-shadow-tree.html: Added.
  • TestExpectations:
  • platform/ios/TestExpectations: Avoid to run introduced tests because we don't have to run them and tests are crashed on these platforms.
  • resources/ui-helper.js:

(window.UIHelper.moveToNextByKeyboardAccessoryBar):
(window.UIHelper.moveToPrevByKeyboardAccessoryBar):
(window.UIHelper):

11:46 AM Changeset in webkit [269058] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Follow-up for: REGRESSION(r267727): Warning spam from JSC_DECLARE_CUSTOM_GETTER
https://bugs.webkit.org/show_bug.cgi?id=217585
<rdar://problem/70376946>

Unreviewed follow-up to r268587. I missed one spot that needs to use
JSC_DECLARE_JIT_OPERATION_WITHOUT_WTF_INTERNAL. This is causing warnings in various
generated bindings files.

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-10-27

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

11:38 AM WebKitGTK/2.30.x edited by Adrian Perez de Castro
(diff)
11:25 AM Changeset in webkit [269057] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] Don't disable MSE build support on Debian and Ubuntu LTS bots
https://bugs.webkit.org/show_bug.cgi?id=218247

Reviewed by Philippe Normand.

The version of gstreamer on this bots (Ubuntu-18.04 and Debian 10)
is now newer enough (1.14) to enable MSE support.

  • CISupport/build.webkit.org-config/config.json:
10:59 AM Changeset in webkit [269056] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Add support for vertical-align: -webkit-baseline-middle
https://bugs.webkit.org/show_bug.cgi?id=218243

Reviewed by Antti Koivisto.

"-webkit-baseline-middle: The center of the element is aligned with the baseline of the text."
https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariCSSRef/Articles/StandardCSSProperties.html
This patch makes LayoutTests/dom/html/level2/html/ cases not assert.

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::alignInlineLevelBoxesVerticallyAndComputeLineBoxHeight):

10:58 AM Changeset in webkit [269055] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[GStreamer] Bad handling of audio files in the ImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=218239

Patch by Philippe Normand <pnormand@igalia.com> on 2020-10-27
Reviewed by Adrian Perez de Castro.

Source/WebCore:

The final main thread notification needs to be blocking otherwise the decoder might get
disposed of too early.

Test: fast/images/animated-image-mp3-crash.html

  • platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::pushEncodedData):

LayoutTests:

  • fast/images/animated-image-mp3-crash-expected.txt: Added.
  • fast/images/animated-image-mp3-crash.html: Added.
10:54 AM Changeset in webkit [269054] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

-Wparentheses warning in OptionsList.h
https://bugs.webkit.org/show_bug.cgi?id=218242

Unreviewed, fix warning by adding extra parentheses.

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-10-27

  • runtime/OptionsList.h:
10:43 AM Changeset in webkit [269053] by clopez@igalia.com
  • 2 edits in trunk/Source/WebCore

Fix build for non-unified builds after r269041.
https://bugs.webkit.org/show_bug.cgi?id=218233

Unreviewed build fix.

Add missing include that can cause a build breakage for non-unified
builds or for unified builds depending on how the included files
are listed-

  • rendering/RenderBlockFlow.cpp:
10:38 AM Changeset in webkit [269052] by aakash_jain@apple.com
  • 16 edits
    1 copy
    1 add in trunk/Tools

Rename BuildSlaveSupport to CISupport
https://bugs.webkit.org/show_bug.cgi?id=218026

Reviewed by Jonathan Bedard.

  • CISupport: Copied from Tools/BuildSlaveSupport.
  • CISupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • CISupport/build.webkit.org-config/steps.py:
  • CISupport/build.webkit.org-config/wkbuild.py:
  • CISupport/build.webkit.org-config/wkbuild_unittest.py:
  • CISupport/ews-app/ews/views/statusbubble.py:
  • CISupport/ews-build/steps.py:
  • CISupport/ews-build/steps_unittest.py:
  • BuildSlaveSupport: Replaced.
  • EWSTools/Start-Queue.ps1:
  • Scripts/bisect-builds:
  • Scripts/run-dashboard-tests:
  • Scripts/webkitpy/common/config/watchlist:
  • Scripts/webkitpy/layout_tests/views/buildbot_results.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • .gitattributes:
10:35 AM Changeset in webkit [269051] by commit-queue@webkit.org
  • 5 edits in trunk

[ iOS wk2 ] webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=209139

Patch by Kenneth Russell <kbr@chromium.org> on 2020-10-27
Reviewed by Dean Jackson.

Source/WebCore:

On ANGLE backend, use wipeAlphaChannelFromPixels on iOS family,
similarly to macOS, when reading back from alpha:false WebGL
contexts. On both backends, apply this only for UNSIGNED_BYTE
readbacks.

Covered by existing WebGL conformance tests.

  • platform/graphics/angle/ExtensionsGLANGLE.cpp:

(WebCore::ExtensionsGLANGLE::readnPixelsRobustANGLE):

  • platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::readPixels):

LayoutTests:

Remove iOS suppression for
webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html.

  • platform/ios-wk2/TestExpectations:
10:32 AM Changeset in webkit [269050] by Noam Rosenthal
  • 4 edits
    2 adds in trunk

compositing/iframes/layout-on-compositing-change.html can assert under ContentfulPaintChecker
https://bugs.webkit.org/show_bug.cgi?id=218204
<rdar://problem/70694218>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/paint-timing/resources/subframe-painting.html:
  • web-platform-tests/paint-timing/fcp-only/fcp-ignore-from-subframe.html:
  • web-platform-tests/paint-timing/fcp-only/fcp-ignore-from-subframe-expected.txt:

Added a new test to assert that painting inside iframes is not automatically considered by the parent.
Upstreamed: https://github.com/web-platform-tests/wpt/pull/26303

Source/WebCore:

Paints from child iframes should not be considered when checking for first-contentful-paint.
The previous w3c test allegedly checking for it was actualy testing something else.

Tests: LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-ignore-from-subframe.html.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

Avoid iframe painting if we're in contentfulness detection fake-paint.

10:30 AM Changeset in webkit [269049] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Use NSURLSessionAuthChallengeRejectProtectionSpace if WKNavigationDelegate didReceiveAuthenticationChallenge is not implemented
https://bugs.webkit.org/show_bug.cgi?id=218008

Patch by Alex Christensen <achristensen@webkit.org> on 2020-10-27
Reviewed by Darin Adler.

This is documented in WKNavigationDelegate.h, and the behavior is basically identical.
The difference is if there is a challenge with multiple protection spaces and a delegate that implements didReceiveAuthenticationChallenge
is attached between the delegate callbacks, it will receive the second callback. This is unlikely and next to impossible to test, but
out of principle we should behave like we have documented that we do.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::didReceiveAuthenticationChallenge):

10:25 AM Changeset in webkit [269048] by weinig@apple.com
  • 5 edits in trunk

Rename WKPreferencesSet*ValueForKey SPI to WKPreferencesSet*ValueForKeyForTesting
https://bugs.webkit.org/show_bug.cgi?id=218240

Reviewed by Darin Adler.

Source/WebKit:

Addresses feedback from initial naming to make it clear what they are used
for and for consistency with WebKitLegacy.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetBoolValueForKeyForTesting):
(WKPreferencesSetDoubleValueForKeyForTesting):
(WKPreferencesSetUInt32ValueForKeyForTesting):
(WKPreferencesSetStringValueForKeyForTesting):
(WKPreferencesSetBoolValueForKey): Deleted.
(WKPreferencesSetDoubleValueForKey): Deleted.
(WKPreferencesSetUInt32ValueForKey): Deleted.
(WKPreferencesSetStringValueForKey): Deleted.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
Update for renamed function names.

10:09 AM Changeset in webkit [269047] by Chris Dumez
  • 3 edits
    4 adds in trunk

Calling AudioContext.suspend() / resume() while already suspended / running should resolve the promise right away
https://bugs.webkit.org/show_bug.cgi?id=218236

Reviewed by Sam Weinig.

Source/WebCore:

Calling AudioContext.suspend() / resume() while already suspended / running should resolve the promise right
away. This is the behavior in the specification [1][2] and matches Blink / Gecko.

[1] https://www.w3.org/TR/webaudio/#dom-audiocontext-suspend
[2] https://www.w3.org/TR/webaudio/#dom-audiocontext-resume

Tests: webaudio/resume-context-while-running.html

webaudio/suspend-context-while-suspended.html

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::suspendRendering):
(WebCore::AudioContext::resumeRendering):

LayoutTests:

Add layout test coverage.

  • webaudio/resume-context-while-running-expected.txt: Added.
  • webaudio/resume-context-while-running.html: Added.
  • webaudio/suspend-context-while-suspended-expected.txt: Added.
  • webaudio/suspend-context-while-suspended.html: Added.
10:08 AM Changeset in webkit [269046] by Chris Lord
  • 4 edits in trunk

[GLIB] imported/w3c/web-platform-tests/html/canvas/offscreen/line-styles/2d.line.width.transformed.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=217986

Reviewed by Simon Fraser.

Fix race condition caused by use of OffscreenCanvas::scriptExecutionContext() on main thread.
Instead of passing a reference to the OffscreenCanvas object when dealing with the placeholder
canvas on the main thread, encapsulate the necessary data in a separate, ThreadSafeRefCounted
object and pass that instead, negating the need to call back to the Worker thread to release
the reference.

Covered by existing tests.

  • html/OffscreenCanvas.cpp:

(WebCore::OffscreenCanvas::create):
(WebCore::OffscreenCanvas::OffscreenCanvas):
(WebCore::OffscreenCanvas::detach):
(WebCore::OffscreenCanvas::setPlaceholderCanvas):
(WebCore::OffscreenCanvas::pushBufferToPlaceholder):
(WebCore::OffscreenCanvas::commitToPlaceholderCanvas):

  • html/OffscreenCanvas.h:
9:58 AM Changeset in webkit [269045] by Brian Burg
  • 6 edits in trunk

Web Inspector: add ENABLE(INSPECTOR_EXTENSIONS) to feature defines
https://bugs.webkit.org/show_bug.cgi?id=218237
<rdar://problem/69968787>

Reviewed by Antti Koivisto.

.:

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Add ENABLE(INSPECTOR_EXTENSIONS), which is only on for the Cocoa macOS port.

Source/WTF:

  • wtf/PlatformEnable.h:
  • wtf/PlatformEnableCocoa.h:

Add ENABLE(INSPECTOR_EXTENSIONS), which is only on for the Cocoa macOS port.

9:51 AM Changeset in webkit [269044] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Web Inspector: console command line API should be exposed to breakpoint conditions/actions
https://bugs.webkit.org/show_bug.cgi?id=218141

Unreviewed test gardening.

  • inspector/timeline/line-column-expected.txt: Rebaseline the test after r269023.
9:15 AM Changeset in webkit [269043] by calvaris@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed, GStreamer gardening

  • platform/glib/TestExpectations: Marked

media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html
as [ Timeout ].

8:57 AM Changeset in webkit [269042] by clopez@igalia.com
  • 3 edits in trunk/Tools

[GTK] Move step for generating the JSC bundle back to the release build bot
https://bugs.webkit.org/show_bug.cgi?id=218207

Reviewed by Adrian Perez de Castro.

On r266208 I moved the step to generate the JSC bundle from the default
GTK release build bot to the new bots for Ubuntu-20.04 packaging.

But it seems the ICU version of Ubuntu-20.04 (66) is not new enough for
testing some Intl features like Intl.ListFormat as JS Intl feature behaviors
are derived from ICU versions.

Move back this step to the GTK release build bot that runs with flatpak,
so it bundles the version of ICU from the FreeDesktop SDK (67 currently)

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
8:57 AM Changeset in webkit [269041] by Antti Koivisto
  • 13 edits in trunk/Source/WebCore

[LFC][Integration] Use iterator for next/previousLinePosition
https://bugs.webkit.org/show_bug.cgi?id=218233

Reviewed by Zalan Bujtas.

Add the required capabilities to the line iterator and also use them in a few other places.

  • editing/VisibleUnits.cpp:

(WebCore::absoluteLineDirectionPointToLocalPointInBlock):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

  • layout/integration/LayoutIntegrationInlineContent.cpp:

(WebCore::LayoutIntegration::InlineContent::containingBlock const):

  • layout/integration/LayoutIntegrationInlineContent.h:
  • layout/integration/LayoutIntegrationLineIterator.cpp:

(WebCore::LayoutIntegration::firstLineFor):
(WebCore::LayoutIntegration::lastLineFor):
(WebCore::LayoutIntegration::LineIterator::closestRunForPoint):
(WebCore::LayoutIntegration::LineIterator::closestRunForLogicalLeftPosition):
(WebCore::LayoutIntegration::PathLine::blockDirectionPointInLine const):

  • layout/integration/LayoutIntegrationLineIterator.h:

(WebCore::LayoutIntegration::LineIterator::LineIterator):
(WebCore::LayoutIntegration::PathLine::y const):
(WebCore::LayoutIntegration::PathLine::logicalHeight const):
(WebCore::LayoutIntegration::PathLine::isHorizontal const):
(WebCore::LayoutIntegration::PathLine::containingBlock const):

  • layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:

(WebCore::LayoutIntegration::LineIteratorLegacyPath::y const):
(WebCore::LayoutIntegration::LineIteratorLegacyPath::logicalHeight const):
(WebCore::LayoutIntegration::LineIteratorLegacyPath::isHorizontal const):
(WebCore::LayoutIntegration::LineIteratorLegacyPath::containingBlock const):

  • layout/integration/LayoutIntegrationLineIteratorModernPath.h:

(WebCore::LayoutIntegration::LineIteratorModernPath::y const):
(WebCore::LayoutIntegration::LineIteratorModernPath::logicalHeight const):
(WebCore::LayoutIntegration::LineIteratorModernPath::isHorizontal const):
(WebCore::LayoutIntegration::LineIteratorModernPath::containingBlock const):

  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::firstLine const):
(WebCore::LayoutIntegration::LineLayout::lastLine const):

  • layout/integration/LayoutIntegrationLineLayout.h:

(WebCore::LayoutIntegration::LineLayout::flow const):
(WebCore::LayoutIntegration::LineLayout::flow):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::findClosestTextAtAbsolutePoint):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):

  • rendering/RootInlineBox.cpp:

(WebCore::isEditableLeaf): Deleted.
(WebCore::RootInlineBox::closestLeafChildForPoint): Deleted.
(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition): Deleted.

This functionality moves to the line iterator.

  • rendering/RootInlineBox.h:
8:34 AM Changeset in webkit [269040] by magomez@igalia.com
  • 2 edits in trunk/Source/WebCore

[WPE] REGRESSION(r268992) Redefinition of min() inside TextureMapperShaderProgram for GLES > 3.0
https://bugs.webkit.org/show_bug.cgi?id=218231

Reviewed by Sergio Villar Senin.

Remove the definition of the min() function and replace its usage with an if. This works for
every GLSL version.

  • platform/graphics/texmap/TextureMapperShaderProgram.cpp:

(WebCore::TextureMapperShaderProgram::create):
(WebCore::STRINGIFY): Deleted.

8:26 AM Changeset in webkit [269039] by Chris Dumez
  • 3 edits
    2 adds in trunk

AudioContext.suspend() should not reject promise when audio session is interrupted
https://bugs.webkit.org/show_bug.cgi?id=218235

Reviewed by Darin Adler.

Source/WebCore:

AudioContext.suspend() should not reject promise when audio session is interrupted. Being
"interrupted" is an internal WebKit concept and rejecting the promise here is confusing
to Web developers.

We now no longer throw when AudioContext.suspend() is called while interrupted. Instead,
we set the 'wasSuspendedByJavascript' flag and register a state change listener to resolve
the promise when the state changes to "suspended".

When the interruption ends, AudioContext::mayResumePlayback() gets called with
shouldResume=false, causing us to update the state from "interrupted" to "suspended",
which resolves the suspend promise.

Test: webaudio/suspend-context-while-interrupted.html

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::suspendRendering):

LayoutTests:

Add layout test coverage.

  • webaudio/suspend-context-while-interrupted-expected.txt: Added.
  • webaudio/suspend-context-while-interrupted.html: Added.
6:56 AM Changeset in webkit [269038] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Assert in BoxTree::layoutBoxForRenderer() under RenderLayer::updateScrollCornerStyle()
https://bugs.webkit.org/show_bug.cgi?id=218205
<rdar://problem/70694256>

Reviewed by Zalan Bujtas.

  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::containing):

Similar to RenderReplica, RenderScrollbarPart is a fake renderer that is not in the tree even
though it has the parent pointer set.

6:28 AM Changeset in webkit [269037] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

RenderStyle::resetPadding sets incorrect computed value (auto)
https://bugs.webkit.org/show_bug.cgi?id=218211

Reviewed by Antti Koivisto.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::resetPadding):

6:27 AM Changeset in webkit [269036] by Alan Bujtas
  • 32 edits in trunk/LayoutTests

Remove unneeded whitespace between content and <br>
https://bugs.webkit.org/show_bug.cgi?id=218151
<rdar://problem/70662471>

Reviewed by Antti Koivisto.

Missed these files in r268958.

  • fast/dom/HTMLTextAreaElement/reset-textarea.html:
  • fast/forms/input-appearance-spinbutton.html:
  • fast/forms/option-index.html:
  • fast/text/basic/generic-family-reset.html:
  • fast/xsl/resources/xslt-enc-cyr.xsl:
  • fast/xsl/resources/xslt-enc.xsl:
  • fast/xsl/resources/xslt-enc16.xsl:
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/success200.html:
  • platform/mac-catalina/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac/fast/forms/option-index-expected.txt:
  • platform/mac/fast/text/basic/generic-family-reset-expected.txt:
  • platform/mac/fast/xsl/xslt-enc-cyr-expected.txt:
  • platform/mac/fast/xsl/xslt-enc-expected.txt:
  • platform/mac/fast/xsl/xslt-enc16-expected.txt:
  • platform/mac/fast/xsl/xslt-enc16to16-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/mac/http/tests/navigation/postredirect-goback1-expected.txt:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
  • svg/wicd/test-rightsizing-b.xhtml:
6:26 AM Changeset in webkit [269035] by Carlos Garcia Campos
  • 6 edits in trunk

WebDriver: sequence of char key press is not supported
https://bugs.webkit.org/show_bug.cgi?id=217951

Reviewed by Brian Burg.

Source/WebKit:

We are assuming there can be only one char key pressed at a time. Use a HashSet to store the currently pressed
char keys and the handle them the same way we do with virtual keys.

Fixes: imported/w3c/webdriver/tests/perform_actions/key_events.py::test_sequence_of_keydown_printable_keys_sends_events

  • UIProcess/Automation/SimulatedInputDispatcher.cpp:

(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):

  • UIProcess/Automation/SimulatedInputDispatcher.h:
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::performInteractionSequence):

WebDriverTests:

Remove expectations for test that is now passing.

6:01 AM Changeset in webkit [269034] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] Device monitor issue in AudioDestination
https://bugs.webkit.org/show_bug.cgi?id=217959

Patch by Philippe Normand <pnormand@igalia.com> on 2020-10-27
Reviewed by Xabier Rodriguez-Calvar.

Remove workaround for false-positive GstDeviceMonitor critical warnings. The GStreamer patch
fixing this issue was backported to the Flatpak SDK in bug #218021.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::maximumNumberOfOutputChannels):

6:00 AM Changeset in webkit [269033] by calvaris@igalia.com
  • 2 edits in trunk/Source/WebCore

[EME][GStreamer] Decode base64 init data if needed
https://bugs.webkit.org/show_bug.cgi?id=218175

Reviewed by Philippe Normand.

There are certain strings with certain key systems that deliver
initialization data encoded as base64 so we need to decode it
first.

  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:

(WebCore::InitData::InitData):
(WebCore::InitData::decodeBase64IfNeeded):

5:30 AM Changeset in webkit [269032] by svillar@igalia.com
  • 5 edits in trunk/Source/WebCore

[WebXR] Move OpenXR calls off the main thread
https://bugs.webkit.org/show_bug.cgi?id=217752

Reviewed by Youenn Fablet.

The OpenXR API is synchronous. Many of the calls involve dealing with external hardware devices
meaning that they have to potential to block the main thread. They should be moved to a different
thread in order to avoid that.

The PlatformXR::Instance creates a WorkQueue which is going to be used by the OpenXR devices to
issue OpenXR calls and also serialize them to ensure that they are executed sequentially. The
OpenXRDevice's are created in the main thread anyway because we need to get weak pointers from
them in the main thread.

  • Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::ensureImmersiveXRDeviceIsSelected): Use a scoped exit to call callback. Also
the Vector of immersive devices is now a pointer which might be null, meaning no available devices.

  • platform/xr/PlatformXR.h: Added a "using" for the Vector of devices.
  • platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::Instance::Impl::queue const): New getter returning the WorkQueue.
(PlatformXR::Instance::Impl::enumerateApiLayerProperties const): Added an ASSERT.
(PlatformXR::Instance::Impl::checkInstanceExtensionProperties const): Ditto.
(PlatformXR::Instance::Impl::Impl): Create the OpenXR WorkQueue and dispatch a task to perform the
OpenXR system initialization in the queue.
(PlatformXR::Instance::Impl::~Impl): Delete the instance in the WorkQueue
(PlatformXR::Instance::enumerateImmersiveXRDevices): Moved the code to a task in the WorkQueue.
(PlatformXR::OpenXRDevice::OpenXRDevice): Ditto. Also added a completion handler to notify the caller
about the end of the device initialization process.
(PlatformXR::OpenXRDevice::collectSupportedSessionModes): Added an ASSERT.
(PlatformXR::OpenXRDevice::collectConfigurationViews): Ditto.

  • platform/xr/openxr/PlatformXROpenXR.h: Added WorkQueue attribute and parameter to device constructor.
4:40 AM Changeset in webkit [269031] by calvaris@igalia.com
  • 3 edits in trunk/Source/WebCore

[EME][GStreamer] Fix logging in utilities
https://bugs.webkit.org/show_bug.cgi?id=218174

Reviewed by Philippe Normand.

There is some logging in GStreamerEMEUtilities.h that was not
using debugging categories properly. It does now.

  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:

(WebCore::InitData::InitData):

  • platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
4:24 AM Changeset in webkit [269030] by calvaris@igalia.com
  • 2 edits in trunk/Source/WebCore

[EME][GStreamer][Thunder] Make response parsing message more robust
https://bugs.webkit.org/show_bug.cgi?id=218172

Reviewed by Philippe Normand.

ParsedResponseMessage checks now for empty buffers and we assert
on that in the code. We also add some other checks that could
trigger crashes if failed.

No new tests needed, just a rework.

  • platform/graphics/gstreamer/eme/CDMThunder.cpp:

(WebCore::ParsedResponseMessage::ParsedResponseMessage):
(WebCore::ParsedResponseMessage::isValid const):
(WebCore::ParsedResponseMessage::operator bool const):
(WebCore::ParsedResponseMessage::operator! const):
(WebCore::CDMInstanceSessionThunder::challengeGeneratedCallback):
(WebCore::CDMInstanceSessionThunder::updateLicense):
(WebCore::CDMInstanceSessionThunder::loadSession):
(WebCore::CDMInstanceSessionThunder::removeSessionData):

3:33 AM Changeset in webkit [269029] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK GStreamer gardening

  • platform/gtk/TestExpectations: Remove flaky expectations for a few tests consistently passing.
3:12 AM Changeset in webkit [269028] by Caio Lima
  • 2 edits in trunk/PerformanceTests

Make WebAssembly tests on JetStream 2 be feature detactable
https://bugs.webkit.org/show_bug.cgi?id=218198

Reviewed by Saam Barati.

This patch is disabling JetStream 2's WASM tests when it's not
possible to find WebAssembly constructor on global object. This allows
us to run JetStream 2 on devices without WASM support, like 32-bits
ports of WebKit.

  • JetStream2/JetStreamDriver.js:
2:03 AM Changeset in webkit [269027] by commit-queue@webkit.org
  • 24 edits in trunk/Source

Make WebCore::FocusDirection to enum class
https://bugs.webkit.org/show_bug.cgi?id=218162

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-10-27
Reviewed by Darin Adler.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::adjustFocusedNodeOnNodeRemoval):
(WebCore::Document::focusNavigationStartingNode const):

  • dom/Document.h:
  • dom/Element.h:
  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::handleFocusEvent):

  • page/EventHandler.cpp:

(WebCore::focusDirectionForKey):
(WebCore::handleKeyboardSelectionMovement):
(WebCore::EventHandler::accessibilityPreventsEventPropagation):
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::defaultTabEventHandler):

  • page/FocusController.cpp:

(WebCore::dispatchEventsOnWindowAndFocusedElement):
(WebCore::FocusController::advanceFocus):
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findFocusableElementWithinScope):
(WebCore::FocusController::findFocusableElementOrScopeOwner):
(WebCore::FocusController::findElementWithExactTabIndex):
(WebCore::FocusController::nextFocusableElementOrScopeOwner):
(WebCore::FocusController::previousFocusableElementOrScopeOwner):

  • page/FocusController.h:
  • page/FocusDirection.h:
  • page/SpatialNavigation.cpp:

(WebCore::isHorizontalMove):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::canScrollInDirection):
(WebCore::entryAndExitPointsForDirection):
(WebCore::isValidCandidate):
(WebCore::distanceDataForNode):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):

  • page/SpatialNavigation.h:

Source/WebKit:

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::takeFocus):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::takeFocus):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::takeFocus):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::handleKeyEventByRelinquishingFocusToChrome):
(WebKit::WebPage::setInitialFocus):

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::takeFocus):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView becomeFirstResponder]):

Source/WebKitLegacy/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::canTakeFocus):
(WebChromeClient::takeFocus):

  • WebView.cpp:

(WebView::setInitialFocus):

1:21 AM Changeset in webkit [269026] by Dewei Zhu
  • 4 edits in trunk/Websites/perf.webkit.org

Fix and update performance dashboard tests
https://bugs.webkit.org/show_bug.cgi?id=218222

Reviewed by Ryosuke Niwa.

  • public/api/upload-root.php: Add a null check against empty array

when accessing invalid key which will show warning since php 7.4.
Per https://wiki.php.net/rfc/notice-for-non-valid-array-container.

  • server-tests/tools-sync-buildbot-integration-tests.js:

Fixed a unit test that assumes build request IDs under one test group is
one after another. This assumption is wrong when 'StartServers' under
'mpm_prefork_module' is set more than one in apache config.
Fixed antoher incorrect unit test.

  • unit-tests/analysis-results-notifier-tests.js:

Fixed unit tests which incorrectly used 'assert.throws' per
https://nodejs.org/docs/latest-v7.x/api/assert.html#assert_assert_throws_block_error_message.

1:01 AM Changeset in webkit [269025] by commit-queue@webkit.org
  • 8 edits
    2 adds
    1 delete in trunk

REGRESSION (r268386): Flashes of inverted color when zooming the map on windy.com
https://bugs.webkit.org/show_bug.cgi?id=218177
<rdar://problem/70676037>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-10-27
Reviewed by Dean Jackson.

Source/WebCore:

Refactoring r268386 changed the behavior so that a new WebGL drawing
buffer would be created when CA would be using the oldest IOSurface
display buffer of the WebGL layer. Before r268386 the WebGL would just
draw on top of the IOSurface even if CA was using it.

This change made the existing bug of using uninitialized IOSurfaces
visible, since IOSurfaces seem to be initialized with red. The existing
bug was probably in r262366.

The fix in this commit fixes the case where WebGL context is drawn to
but the CA does not display the contents. Draw would cause preparation
of the drawing buffer for display, along with the contract that drawing
buffer might be uninitialized. However, the clear of the drawing buffer
was marked needed only during display.

Case that failed at the time of writing was the case where after draw,
the element would be removed by setting display:none. This would return
red contents, e.g. uninitialized IOSurface contents. Before r268386 this
would first return red until 3 buffers had passed and then it would
start recycling old display buffer contents.

The naming is not fixed in this commit due to just fixing the
regression. Other ports contain code that makes renaming or
restructuring the callbacks more confusing for the other ports.

Test: fast/canvas/webgl/webgl-clear-composited-notshowing.html

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::prepareForDisplay):

  • platform/graphics/cocoa/WebGLLayer.h:
  • platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer initWithDevicePixelRatio:contentsOpaque:]):
(-[WebGLLayer display]):
(-[WebGLLayer detachClient]):

  • platform/graphics/cocoa/WebGLLayerClient.h: Removed.
  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:

LayoutTests:

Test case for WebGL which is drawn to a canvas that is not visible. This should still
adhere to preserveDrawingBuffer == false contract of clearing the drawing buffer
correctly.

Case that failed at the time of writing was the case where after draw, the element
would be removed by setting display:none.

  • fast/canvas/webgl/webgl-clear-composited-notshowing-expected.txt: Added.
  • fast/canvas/webgl/webgl-clear-composited-notshowing.html: Added.
12:28 AM Changeset in webkit [269024] by Fujii Hironori
  • 25 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

  • platform/wincairo/fast/box-shadow/inset-box-shadow-radius-expected.txt:
  • platform/wincairo/fast/box-shadow/inset-box-shadows-expected.txt:
  • platform/wincairo/fast/clip/overflow-border-radius-combinations-expected.txt:
  • platform/wincairo/fast/clip/overflow-border-radius-composited-expected.txt:
  • platform/wincairo/fast/clip/overflow-border-radius-transformed-expected.txt:
  • platform/wincairo/fast/css/first-line-text-decoration-expected.txt:
  • platform/wincairo/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
  • platform/wincairo/fast/css/focus-ring-detached-expected.txt:
  • platform/wincairo/fast/css/layerZOrderCrash-expected.txt:
  • platform/wincairo/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/wincairo/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/wincairo/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/wincairo/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/wincairo/fast/dom/focus-contenteditable-expected.txt:
  • platform/wincairo/fast/inline-block/006-expected.txt:
  • platform/wincairo/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/wincairo/fast/text/basic/012-expected.txt:
  • platform/wincairo/fast/text/capitalize-boundaries-expected.txt:
  • platform/wincairo/fast/text/indic-expected.txt:
  • platform/wincairo/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/wincairo/fonts/monospace-expected.txt:
  • platform/wincairo/fonts/sans-serif-expected.txt:
  • platform/wincairo/fonts/serif-expected.txt:
  • platform/wincairo/http/tests/local/file-url-sent-as-referer-expected.txt:
Note: See TracTimeline for information about the timeline view.