Timeline


and

01/28/15: Today

21:23 Changeset [179335] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Poor performance on IE's Chalkboard benchmark.
https://bugs.webkit.org/show_bug.cgi?id=140753.

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-01-28
Reviewed by Zalan Bujtas.

PerformanceTests:

  • SVG/UnderTheSeeBenchmark.html: Added
  • SVG/WorldcupBenchmark.html: Added.
  • SVG/resources/RenderAnimator.css: Added.
  • SVG/resources/RenderAnimator.js: Added.

These are benchmarks for the SVG rendering. Mainly we want to measure how fast
the SVG rendering will be when only a small part of it is drawn.

Source/WebCore:

Test: PerformanceTests/SVG/UnderTheSeeBenchmark.html

PerformanceTests/SVG/WorldcupBenchmark.html

The SVG rendering code was not skipping the SVG elements which are outside the
clipping rectangle. We were drawing all the SVG elements even if some of them
are completely outside the clipping rectangle. The fix is to pass the correct
dirty rectangle to the ScrollView which then gets propagated to the SVG renderers.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):
SVGImage::draw() needs to pass the intersection of 'srcRect' and context->clipBounds(),
to ScrollView::paint(). This will ensure RenderSVGShape::paint() gets the correct
clipping rectangle. If there is no intersection between the boundingBox of the
RenderSVGShape and the clipping rectangle, the RenderSVGShape will not be drawn.

20:45 Changeset [179334] by matthew_hanson@apple.com
  • 3 edits
    4 adds in branches/safari-600.5-branch

Merge r179027. rdar://problem/19585744

20:45 Changeset [179333] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/LayoutTests

Merge r178953. rdar://problem/19617631

20:30 Changeset [179332] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch/LayoutTests

Merge r178795. rdar://problem/19617631

20:29 Changeset [179331] by matthew_hanson@apple.com
  • 11 edits
    3 adds in branches/safari-600.5-branch

Merge r178768. rdar://problem/19617631

20:29 Changeset [179330] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r178571. rdar://problem/19585723

20:29 Changeset [179329] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/JavaScriptCore

Merge r178365. rdar://problem/19617809

19:05 Changeset [179328] by timothy_horton@apple.com
  • 13 edits
    4 adds in trunk/Source/WebKit2

Add API::{FrameInfo, NavigationAction, NavigationResponse} types
https://bugs.webkit.org/show_bug.cgi?id=140982

Reviewed by Sam Weinig.

Make C++ API objects for WK{FrameInfo, NavigationAction, NavigationResponse}
to wrap around, as a step towards moving Modern API logic down into WebPageProxy.

  • Shared/API/APIObject.h:
  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • UIProcess/API/APIFrameInfo.cpp: Added.
  • UIProcess/API/APIFrameInfo.h: Added.
  • UIProcess/API/APINavigationAction.h: Added.
  • UIProcess/API/APINavigationResponse.h: Added.

Add API::FrameInfo, API::NavigationAction, and API::NavigationResponse.

  • UIProcess/API/Cocoa/WKFrameInfo.mm:
  • UIProcess/API/Cocoa/WKFrameInfoInternal.h:

Make WKFrameInfo a WKObject, wrapping a API::FrameInfo.

  • UIProcess/API/Cocoa/WKNavigationAction.mm:
  • UIProcess/API/Cocoa/WKNavigationActionInternal.h:

Make WKNavigationAction a WKObject, wrapping a API::NavigationAction.

  • UIProcess/API/Cocoa/WKNavigationResponse.mm:
  • UIProcess/API/Cocoa/WKNavigationResponseInternal.h:

Make WKNavigationResponse a WKObject, wrapping a API::NavigationResponse.

  • UIProcess/API/Cocoa/WKUserContentController.mm:

Adopt API::FrameInfo.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
Adopt API::FrameInfo, and reorganize the code slightly.
Adopt API::NavigationAction.

(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):
Adopt API::FrameInfo.
Adopt API::NavigationResponse.

(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
Adopt API::FrameInfo.

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPage):
(WebKit::UIDelegate::UIClient::runJavaScriptAlert):
(WebKit::UIDelegate::UIClient::runJavaScriptConfirm):
(WebKit::UIDelegate::UIClient::runJavaScriptPrompt):
Adopt API::FrameInfo.

  • WebKit2.xcodeproj/project.pbxproj:
18:52 Changeset [179327] by antti@apple.com
  • 2 edits in trunk/Source/WebKit2

http/tests/xmlhttprequest/workers/methods.html sometimes times out with disk cache enabled
https://bugs.webkit.org/show_bug.cgi?id=140976

Reviewed by Chris Dumez.

The previous fix sometimes invoked the completion handler twice. Explicitly track if we
have called it or not.

  • NetworkProcess/cache/NetworkCacheStorageCocoa.mm:

(WebKit::NetworkCacheStorage::dispatchRetrieveOperation):

Also move the error case to the done branch. According to the documentation 'done' is always set on error.

18:32 Changeset [179326] by timothy_horton@apple.com
  • 28 edits
    5 adds in trunk

Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
https://bugs.webkit.org/show_bug.cgi?id=140673

Reviewed by Sam Weinig.

  • Platform/IPC/ArgumentCoders.cpp:

(IPC::ArgumentCoder<uuid_t>::encode):
(IPC::ArgumentCoder<uuid_t>::decode):

  • Platform/IPC/ArgumentCoders.h:

Add a uuid_t (simple) argument coder.
Fix a mis-named header-guard #ifdef.

  • Platform/IPC/Connection.cpp:

(IPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(IPC::Connection::dispatchSyncMessage):
Sync message replies inherit the message UUID from the incoming sync message.

(IPC::Connection::sendMessage):
(IPC::Connection::waitForMessage):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
Record outgoing messages. Because sendSyncMessage calls sendMessage,
we have to explicitly avoid recording the message twice.

(IPC::Connection::dispatchMessage):
Record the incoming message.

(IPC::Connection::remoteProcessID):
Add remoteProcessID(), which tries to determine the pid of the remote process.

  • Platform/IPC/Connection.h:

(IPC::Connection::xpcConnection):
This can be const.

(IPC::Connection::isValid):
Make this public.

  • Platform/IPC/MessageDecoder.cpp:

(IPC::MessageDecoder::MessageDecoder):

  • Platform/IPC/MessageDecoder.h:

(IPC::MessageDecoder::setMessageProcessingToken):
(IPC::MessageDecoder::UUID):
Decode and store the message UUID.
Store a MessageProcessingToken for the lifetime of the MessageDecoder;
this ensures that all time spent processing the incoming message will be
counted against that message.

  • Platform/IPC/MessageEncoder.cpp:

(IPC::MessageEncoder::MessageEncoder):
By default, create a new UUID for the message. Alternatively, allow clients
to pass the message UUID in (used for sync message replies).
Store the messageReceiverName and messageName.

(IPC::MessageEncoder::encodeHeader):
Factor encodeHeader() out of the constructors so most of their code can be shared.

(IPC::MessageEncoder::isSyncMessage):
(IPC::MessageEncoder::shouldDispatchMessageWhenWaitingForSyncReply):
Add getters for these flags.

  • Platform/IPC/MessageEncoder.h:

(IPC::MessageEncoder::messageReceiverName):
(IPC::MessageEncoder::messageName):
(IPC::MessageEncoder::destinationID):
(IPC::MessageEncoder::UUID):

  • Platform/IPC/MessageRecorder.h: Added.
  • Platform/IPC/MessageRecorder.cpp: Added.

(MessageRecorder::MessageRecorder):
Add a class that interfaces with a custom DTrace provider to log incoming and outgoing messages.

(MessageRecorder::shared):
(MessageRecorder::isEnabled):
Determine if either of the message probes are enabled. If not, we'll avoid most of the
work associated with MessageRecorder.

(MessageRecorder::recordOutgoingMessage):
(MessageRecorder::recordIncomingMessage):
Build a WebKitMessageRecord and MessageProcessingToken from the Message(De|En)coder.
Once the MessageProcessingToken is deallocated, the probe will be invoked with the WebKitMessageRecord.

(MessageRecorder::MessageProcessingToken::MessageProcessingToken):
(MessageRecorder::MessageProcessingToken::~MessageProcessingToken):
Keep track of when the token is created and destroyed; these are considered the beginning
and ending "processing" times of the message (and as such the token should be kept alive for
exactly as long as the message is being processed).

  • Platform/IPC/MessageRecorderProbes.d: Added.

Add a DTrace provider source file with two probes, message_sent and message_received.
The struct must match the struct in MessageRecorder.h.

  • Platform/IPC/ProcessType.h: Added.

Add an enum of process types.

  • WebKit2.xcodeproj/project.pbxproj:
  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/DatabaseToWebProcessConnection.h:
  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkProcess.h:
  • WebProcess/Databases/WebToDatabaseProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Plugins/PluginProcessConnection.h:
  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebInspectorUI.h:
  • WebProcess/WebProcess.h:
  • UIProcess/Databases/DatabaseProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/WebProcessProxy.h:
  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.h:

Annotate Connection::Clients with process types.

  • Scripts/dtrace/trace-webkit2-messages.d: Added.

Add a DTrace script that outputs a small blob of JSON per message.

18:32 Changeset [179325] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Windows return -1 when calling vsnprintf with arguments that exceed target buffer size
https://bugs.webkit.org/show_bug.cgi?id=140917

Patch by Namhoon Kim <namkim@ea.com> on 2015-01-28
Reviewed by Brent Fulgham.

Fix return value of vsnprintf when windows API return -1 to denote
requested buffer exceeded. Replace return value by calling vscprintf.

  • wtf/StringExtras.h:

(snprintf): Fix return value by calling vscprintf when buffer exceeded.
(wtf_vsnprintf): Ditto.

18:15 Changeset [179324] by bfulgham@apple.com
  • 4 edits in trunk/Source/WebCore

Scroll snap points do not work in the vertical direction
https://bugs.webkit.org/show_bug.cgi?id=141001
<rdar://problem/19632089>

Reviewed by Beth Dakin.

New scroll snap tests are being prepared separately. A manual test case is attached to the issue.

  • page/EventHandler.cpp:

(WebCore::handleWheelEventInAppropriateEnclosingBoxForSingleAxis): We want to consider momentum end phase
when dealing with Scroll Snap Points.

  • platform/mac/AxisScrollSnapAnimator.mm:

(WebCore::AxisScrollSnapAnimator::handleWheelEvent): We do NOT want to bail out early here. In fact, it's strange
that this code was like this at all, since it meant a large number of cases were not being used. We also want to
trigger the scroll snap animation (when applicable) upon an inertia scroll end.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::gestureShouldBeginSnap): Added.
(WebCore::ScrollAnimatorMac::allowsVerticalStretching): If we have automatic elasticity, and we have active scroll
snap points, we want to let the scroll snap animator deal with the gesture.
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching): Ditto.

18:05 Changeset [179323] by benjamin@webkit.org
  • 6 edits
    16 adds in trunk

Start fixing the handling of Element's attributes when they contain non-ASCII characters
https://bugs.webkit.org/show_bug.cgi?id=141016

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

Attribute handling does not work properly when the attribute name contains non-ASCII character.

The HTML parser tokenize those names as ASCII lowercase. Some of the code is CSS and Element use
unicode lowercase for the names. This breaks all the APIs as soon as a name contains a character
that is non-ASCII and uppercase since some APIs change it, other don't.

This patch is a first step toward fixing this mess, it only address the simple cases.
The HTML spec says the names should be compared ASCII case-insensitive, to I spread that behavior
to places that were using unicode.

Tests: fast/css/attribute-ascii-case-insensitive-html.html

fast/css/attribute-ascii-case-insensitive-xhtml-expected.xhtml
fast/css/attribute-ascii-case-insensitive-xhtml.xhtml
fast/css/attribute-ascii-case-insensitive-xml-in-html.html
fast/dom/Element/attribute-ascii-case-insensitive-1.html
fast/dom/Element/attribute-ascii-case-insensitive-2.html
fast/selectors/attribute-ascii-case-insensitive-style-update.html
fast/selectors/element-matches-attribute-ascii-case-insensitive-html.html
fast/selectors/querySelector-attribute-ascii-case-insensitive-html.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::setAttribute):

  • dom/Element.cpp:

(WebCore::Element::synchronizeAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::hasAttribute):

  • dom/ElementData.cpp:

(WebCore::ElementData::findAttributeIndexByNameSlowCase):

  • dom/ElementData.h:

(WebCore::ElementData::findAttributeIndexByName):

LayoutTests:

Start some basic testing.

Some tests are failing due to the more complicated case being handled incorrectly, this will
be fixed in follow ups.

  • fast/css/attribute-ascii-case-insensitive-html-expected.html: Added.
  • fast/css/attribute-ascii-case-insensitive-html.html: Added.
  • fast/css/attribute-ascii-case-insensitive-xhtml-expected.xhtml: Added.
  • fast/css/attribute-ascii-case-insensitive-xhtml.xhtml: Added.
  • fast/css/attribute-ascii-case-insensitive-xml-in-html-expected.html: Added.
  • fast/css/attribute-ascii-case-insensitive-xml-in-html.html: Added.
  • fast/dom/Element/attribute-ascii-case-insensitive-1-expected.txt: Added.
  • fast/dom/Element/attribute-ascii-case-insensitive-1.html: Added.
  • fast/dom/Element/attribute-ascii-case-insensitive-2-expected.txt: Added.
  • fast/dom/Element/attribute-ascii-case-insensitive-2.html: Added.
  • fast/selectors/attribute-ascii-case-insensitive-style-update-expected.txt: Added.
  • fast/selectors/attribute-ascii-case-insensitive-style-update.html: Added.
  • fast/selectors/element-matches-attribute-ascii-case-insensitive-html-expected.txt: Added.
  • fast/selectors/element-matches-attribute-ascii-case-insensitive-html.html: Added.
  • fast/selectors/querySelector-attribute-ascii-case-insensitive-html-expected.txt: Added.
  • fast/selectors/querySelector-attribute-ascii-case-insensitive-html.html: Added.
18:01 Changeset [179322] by joepeck@webkit.org
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Change Main Frame Status Buttons when debugging Augmented JSContext
https://bugs.webkit.org/show_bug.cgi?id=141006

Reviewed by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:

New "Restart" string.

  • UserInterface/Base/Main.js:

(WebInspector.canArchiveMainFrame):

  • UserInterface/Views/FrameTreeElement.js:

(WebInspector.FrameTreeElement.prototype.updateStatusForMainFrame):
(WebInspector.FrameTreeElement.prototype._updateDownloadButton):
Update the tooltip when in a non-Web debuggable, and only show
the Download button when in a Web debuggable.

  • UserInterface/Views/TreeElementStatusButton.js:

(WebInspector.TreeElementStatusButton.prototype.set hidden):
Oops! The implementation was backwards. Simplify with classList.toggle.

17:49 Changeset [179321] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Web Inspector: Crash closing inspected page with frequent activity
https://bugs.webkit.org/show_bug.cgi?id=140973

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-01-28
Reviewed by Timothy Hatcher.

  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::disconnectFromPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
Be sure to close the WebInspector connection through the page
when the page is closing so that the WebKit::WebInspector is
relinquishes itself as the InspectorFrontendChannel.

17:09 Changeset [179320] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Avoid manually handling quickLookWithEvent: if the immediate action gesture recognizer will do Lookup for us
https://bugs.webkit.org/show_bug.cgi?id=141018
<rdar://problem/19619999>

Reviewed by Beth Dakin.

  • UIProcess/API/mac/WKView.mm:

(-[WKView quickLookWithEvent:]):
If we have an immediate action gesture recognizer, just call super and
avoid WebKit's special quickLookWithEvent: implementation.

16:58 Changeset [179319] by ggaren@apple.com
  • 8 edits in trunk

Removed fastMallocForbid / fastMallocAllow
https://bugs.webkit.org/show_bug.cgi?id=141012

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Copy non-current thread stacks before scanning them instead of scanning
them in-place.

This operation is uncommon (i.e., never in the web content process),
and even in a stress test with 4 threads it only copies about 27kB,
so I think the performance cost is OK.

Scanning in-place requires a complex dance where we constrain our GC
data structures not to use malloc, free, or any other interesting functions
that might acquire locks. We've gotten this wrong many times in the past,
and I just got it wrong again yesterday. Since this code path is rarely
tested, I want it to just make sense, and not depend on or constrain the
details of the rest of the GC heap's design.

  • heap/MachineStackMarker.cpp:

(JSC::otherThreadStack): Factored out a helper function for dealing with
unaligned and/or backwards pointers.

(JSC::MachineThreads::tryCopyOtherThreadStack): This is now the only
constrained function, and it only calls memcpy and low-level thread APIs.

(JSC::MachineThreads::tryCopyOtherThreadStacks): The design here is that
you do one pass over all the threads to compute their combined size,
and then a second pass to do all the copying. In theory, the threads may
grow in between passes, in which case you'll continue until the threads
stop growing. In practice, you never continue.

(JSC::growBuffer): Helper function for growing.

(JSC::MachineThreads::gatherConservativeRoots):
(JSC::MachineThreads::gatherFromOtherThread): Deleted.

  • heap/MachineStackMarker.h: Updated for interface changes.

Source/WTF:

Removed the forbid / allow API because it is no longer used.

  • wtf/FastMalloc.cpp:

(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::tryFastRealloc):
(WTF::fastRealloc):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
(WTF::isForbidden): Deleted.
(WTF::fastMallocForbid): Deleted.
(WTF::fastMallocAllow): Deleted.
(WTF::initializeIsForbiddenKey): Deleted.

  • wtf/FastMalloc.h:

Tools:

Fixed a test bug I noticed while testing.

  • DumpRenderTree/JavaScriptThreading.cpp:

(stopJavaScriptThreads): Lock the javaScriptThreads lock before
accessing javaScriptThreads -- otherwise, you'll ASSERT.

16:50 Changeset [179318] by bshafiei@apple.com
  • 6 edits in branches/safari-600.5-branch/Source

Merged r179230. rdar://problem/19621509

16:43 Changeset [179317] by bshafiei@apple.com
  • 5 edits in branches/safari-600.4-branch/Source

Versioning.

16:40 Changeset [179316] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove remaining PLATFORM(WIN) code blocks from WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=140972

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-01-28
Reviewed by Darin Adler.

  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):

16:39 Changeset [179315] by bfulgham@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

[Win] Actually delete the file!

  • platform/win/fast/events/ondrop-text-htmlt-expected.txt: Removed.
16:38 Changeset [179314] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.4.4

New tag.

16:37 Changeset [179313] by bfulgham@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening. Get rid of misspelled expected file.

Get rid of the 'ondrop-text-htmlt-expected.txt' file, and commit a new baseline
from the test system.

  • platform/win/fast/events/ondrop-text-htmlt-expected.txt: Removed.
  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
16:30 Changeset [179312] by dburkart@apple.com
  • 2 edits in trunk/Tools

asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
https://bugs.webkit.org/show_bug.cgi?id=141015

Reviewed by Alexey Proskuryakov.

15:56 Changeset [179311] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix the build.

  • Scripts/copy-webkitlibraries-to-product-directory:
15:46 Changeset [179310] by weinig@apple.com
  • 1 edit
    1 delete in trunk/WebKitLibraries

Remove libWebKitSystemInterfaceMountainLion.a

Reviewed by Mark Rowe.

  • libWebKitSystemInterfaceMountainLion.a: Removed.
15:36 Changeset [179309] by zalan@apple.com
  • 2 edits in trunk/Source/WebCore

Simple line layout: Drop uncommitted/committed terms from LineState.
https://bugs.webkit.org/show_bug.cgi?id=141005

Reviewed by Antti Koivisto.

Fragments form segments and segments turn into runs on the lines.
We add fragments only when they fit so they should not be in 'uncommitted' state at all.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::LineState::createRun):
(WebCore::SimpleLineLayout::LineState::addFragment):
(WebCore::SimpleLineLayout::LineState::addWhitespace):
(WebCore::SimpleLineLayout::LineState::hasWhitespaceOnly):
(WebCore::SimpleLineLayout::LineState::width):
(WebCore::SimpleLineLayout::LineState::firstCharacterFits):
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::firstFragment):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
(WebCore::SimpleLineLayout::createTextRuns): Unnecessary assert.
(WebCore::SimpleLineLayout::LineState::commitAndCreateRun): Deleted.
(WebCore::SimpleLineLayout::LineState::addUncommitted): Deleted.
(WebCore::SimpleLineLayout::LineState::addUncommittedWhitespace): Deleted.

15:20 Changeset [179308] by cdumez@apple.com
  • 3 edits
    2 adds in trunk

Regression(r177494): Bad cast to WebKitCSSResourceValue in StyleBuilderConverter::convertMaskImageOperations()
https://bugs.webkit.org/show_bug.cgi?id=140991
<rdar://problem/19625305>

Reviewed by Antti Koivisto.

Source/WebCore:

convertMaskImageOperations() was assuming that the CSSValueList's values
were always WebKitCSSResourceValue values. However, they can be
CSSInitialValues as well so we should check before casting.

Test: css3/masking/mask-image-initial-value-crash.html

  • css/StyleBuilderConverter.h:

(WebCore::maskImageValueFromIterator):
(WebCore::StyleBuilderConverter::convertMaskImageOperations):

LayoutTests:

Add layout test to cover the case where a CSSValue is incorrectly casted to
a WebKitCSSResourceValue in StyleBuilderConverter::convertMaskImageOperations(),
thus hitting an assertion in downcast<>() on debug builds.

  • css3/masking/mask-image-initial-value-crash-expected.txt: Added.
  • css3/masking/mask-image-initial-value-crash.html: Added.
14:52 Changeset [179307] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r178363. rdar://problem/19617795

14:52 Changeset [179306] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/JavaScriptCore

Merge r178311. rdar://problem/19617780

14:52 Changeset [179305] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-600.5-branch

Merge r178231. rdar://problem/19617801

14:52 Changeset [179304] by matthew_hanson@apple.com
  • 4 edits
    5 adds in branches/safari-600.5-branch

Merge r177927. rdar://problem/19585726

14:52 Changeset [179303] by matthew_hanson@apple.com
  • 4 edits
    4 adds in branches/safari-600.5-branch

Merge r177165. rdar://problem/19617570

14:51 Changeset [179302] by lforschler@apple.com
  • 3 edits
    4 copies in branches/safari-600.1.4.15-branch

Merged r179027. rdar://problem/19432904

14:47 Changeset [179301] by lforschler@apple.com
  • 10 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r178980. rdar://problem/19431679

14:37 Changeset [179300] by lforschler@apple.com
  • 2 edits in trunk/Tools

Increase the FileUpload block size in an attempt to improve network performance.

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(UploadBuiltProduct.init):

14:35 Changeset [179299] by lforschler@apple.com
  • 4 edits
    4 copies in branches/safari-600.1.4.15-branch

Merged r178380. rdar://problem/19432909

14:26 Changeset [179298] by matthew_hanson@apple.com
  • 6 edits
    6 adds in branches/safari-600.5-branch

Merge r177135. rdar://problem/19451316

14:26 Changeset [179297] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r177089. rdar://problem/19617712

14:26 Changeset [179296] by matthew_hanson@apple.com
  • 5 edits
    8 adds in branches/safari-600.5-branch

Merge r177050. rdar://problem/19452133

14:25 Changeset [179295] by lforschler@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source/JavaScriptCore

Merged r178364. rdar://problem/19564749

14:22 Changeset [179294] by bdakin@apple.com
  • 16 edits in trunk/Source

Remove Mountain Lion code from WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=141010

Reviewed by Sam Weinig.

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:

(toNSEventPhase):

  • WebView/WebHTMLView.mm:

(isQuickLookEvent):

Source/WebKit2:

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
  • Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::initializeSandbox):

  • Shared/mac/WebEventFactory.mm:

(WebKit::phaseForEvent):

  • UIProcess/API/mac/WKView.mm:

(-[WKView quickLookWithEvent:]):
(-[WKView updateLayer]):
(-[WKView createFullScreenWindow]):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didFinishLaunching):

  • UIProcess/Network/mac/NetworkProcessProxyMac.mm:

(WebKit::shouldUseXPC):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didFinishLaunching):

  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::isViewVisible):

  • WebKit2Prefix.h:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebProcess/com.apple.WebProcess.sb.in:
14:20 Changeset [179293] by cdumez@apple.com
  • 6 edits in trunk/Source

Remove dead code from MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=140964

Reviewed by Andreas Kling.

Remove dead code from MemoryCache, make more things private and
clean up a little bit.

  • WebCore.exp.in:
  • inspector/InspectorResourceAgent.cpp:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::MemoryCache):
(WebCore::MemoryCache::revalidationSucceeded):
(WebCore::MemoryCache::removeImageFromCache):
(WebCore::MemoryCache::pruneLiveResources):
(WebCore::MemoryCache::pruneDeadResources):
(WebCore::MemoryCache::pruneDeadResourcesToSize):
(WebCore::MemoryCache::remove):
(WebCore::MemoryCache::removeRequestFromSessionCaches):
(WebCore::MemoryCache::setDisabled):
(WebCore::MemoryCache::resourceForURL): Deleted.
(WebCore::MemoryCache::pruneLiveResourcesToPercentage): Deleted.
(WebCore::MemoryCache::pruneDeadResourcesToPercentage): Deleted.
(WebCore::MemoryCache::evict): Deleted.
(WebCore::MemoryCache::removeUrlFromCache): Deleted.
(WebCore::MemoryCache::removeRequestFromCache): Deleted.
(WebCore::MemoryCache::pruneToPercentage): Deleted.

  • loader/cache/MemoryCache.h:

(WebCore::MemoryCache::LRUList::LRUList): Deleted.
(WebCore::MemoryCache::remove): Deleted.
(WebCore::MemoryCache::setPruneEnabled): Deleted.
(WebCore::MemoryCache::minDeadCapacity): Deleted.
(WebCore::MemoryCache::maxDeadCapacity): Deleted.
(WebCore::MemoryCache::capacity): Deleted.
(WebCore::MemoryCache::liveSize): Deleted.
(WebCore::MemoryCache::deadSize): Deleted.

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseCriticalMemory):

14:04 Changeset [179292] by lforschler@apple.com
  • 6 edits in branches/safari-600.1.4.15-branch/Source

Merged r178175. rdar://problem/19433008

13:58 Changeset [179291] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r176475. rdar://problem/19451346

13:58 Changeset [179290] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r175251. rdar://problem/19451346

13:57 Changeset [179289] by lforschler@apple.com
  • 5 edits
    5 copies in branches/safari-600.1.4.15-branch

Merged r178038. rdar://problem/19450100

13:53 Changeset [179288] by lforschler@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177850. rdar://problem/19445865

13:49 Changeset [179287] by lforschler@apple.com
  • 11 edits in branches/safari-600.1.4.15-branch/Source

Merged r177738. rdar://problem/19445865

13:45 Changeset [179286] by burg@cs.washington.edu
  • 23 edits
    2 deletes in trunk/Source

Web Inspector: remove CSS.setPropertyText, CSS.toggleProperty and related dead code
https://bugs.webkit.org/show_bug.cgi?id=140961

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/protocol/CSS.json: Remove unused protocol methods.

Source/WebCore:

No new tests, no behavior changed.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::setPropertyText): Deleted.
(WebCore::InspectorCSSAgent::toggleProperty): Deleted.

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::InspectorStyle):
(WebCore::InspectorStyle::populateAllProperties):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::inspectorStyleForId):
(WebCore::InspectorStyle::setPropertyText): Deleted.
(WebCore::InspectorStyle::toggleProperty): Deleted.
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Deleted.
(WebCore::InspectorStyleSheet::setPropertyText): Deleted.
(WebCore::InspectorStyleSheet::toggleProperty): Deleted.
(WebCore::InspectorStyleSheet::rememberInspectorStyle): Deleted.
(WebCore::InspectorStyleSheet::forgetInspectorStyle): Deleted.
(WebCore::InspectorStyleSheet::revalidateStyle): Deleted.

  • inspector/InspectorStyleSheet.h:
  • inspector/InspectorStyleTextEditor.cpp: Removed.
  • inspector/InspectorStyleTextEditor.h: Removed.

Source/WebInspectorUI:

Setters for CSSProperty (except override) are not used, so delete them. These setters
and their callees in DOMNodeStyles were the only clients of the removed protocol commands.

  • UserInterface/Models/CSSProperty.js:

(WebInspector.CSSProperty.prototype.update):
(WebInspector.CSSProperty.prototype.get name):
(WebInspector.CSSProperty.prototype.get value):
(WebInspector.CSSProperty.prototype.get priority):
(WebInspector.CSSProperty.prototype.hasOtherVendorNameOrKeyword):
(WebInspector.CSSProperty.prototype.set text): Deleted.
(WebInspector.CSSProperty.prototype.set name): Deleted.
(WebInspector.CSSProperty.prototype.set value): Deleted.
(WebInspector.CSSProperty.prototype.set important): Deleted.
(WebInspector.CSSProperty.prototype.set priority): Deleted.
(WebInspector.CSSProperty.prototype.set enabled): Deleted.
(WebInspector.CSSProperty.prototype.add): Deleted.
(WebInspector.CSSProperty.prototype.remove): Deleted.
(WebInspector.CSSProperty.prototype._updatePropertySoon.performUpdate): Deleted.
(WebInspector.CSSProperty.prototype._updatePropertySoon): Deleted.
(WebInspector.CSSProperty.prototype._cancelPendingUpdate): Deleted.

  • UserInterface/Models/CSSStyleDeclaration.js:

(WebInspector.CSSStyleDeclaration.prototype.addProperty): Deleted.
(WebInspector.CSSStyleDeclaration.prototype.removeProperty): Deleted.

  • UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype.addEmptyRule):
(WebInspector.DOMNodeStyles.prototype.addRule): Deleted.
(WebInspector.DOMNodeStyles.prototype.changeProperty): Deleted.
(WebInspector.DOMNodeStyles.prototype.changePropertyText): Deleted.
(WebInspector.DOMNodeStyles.prototype.changePropertyEnabledState): Deleted.
(WebInspector.DOMNodeStyles.prototype.addProperty): Deleted.
(WebInspector.DOMNodeStyles.prototype.removeProperty): Deleted.
(WebInspector.DOMNodeStyles.prototype._handlePropertyChange): Deleted.

  • UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype._newRuleClicked):

  • Versions/Inspector-iOS-6.0.json:
  • Versions/Inspector-iOS-7.0.json:
  • Versions/Inspector-iOS-8.0.json:
13:39 Changeset [179285] by lforschler@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177681. rdar://problem/19445913

13:37 Changeset [179284] by zalan@apple.com
  • 8 edits
    2 copies in trunk/Source/WebCore

Simple line layout: Move FlowContents iterator interface to FlowContentsIterator.
https://bugs.webkit.org/show_bug.cgi?id=140944

Reviewed by Antti Koivisto.

This patch cleans up FlowContents's interface by moving the iterator functionality
to this new FlowContentsIterator class.

No change in functionality.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::LineState::addUncommitted):
(WebCore::SimpleLineLayout::LineState::addUncommittedWhitespace):
(WebCore::SimpleLineLayout::preWrap):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::firstFragment):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary):
(WebCore::SimpleLineLayout::createTextRuns):

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::Style::Style): Deleted.
(WebCore::SimpleLineLayout::FlowContents::nextTextFragment): Deleted.
(WebCore::SimpleLineLayout::nextBreakablePosition): Deleted.
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition): Deleted.
(WebCore::SimpleLineLayout::findNextNonWhitespace): Deleted.
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition): Deleted.
(WebCore::SimpleLineLayout::FlowContents::textWidth): Deleted.
(WebCore::SimpleLineLayout::FlowContents::runWidth): Deleted.

  • rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::Iterator::Iterator):
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator*):
(WebCore::SimpleLineLayout::FlowContents::begin):
(WebCore::SimpleLineLayout::FlowContents::end):
(WebCore::SimpleLineLayout::FlowContents::length):
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator++):
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator==):
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator!=):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPosition):
(WebCore::SimpleLineLayout::FlowContents::TextFragment::TextFragment): Deleted.
(WebCore::SimpleLineLayout::FlowContents::TextFragment::isEmpty): Deleted.
(WebCore::SimpleLineLayout::FlowContents::hasOneSegment): Deleted.
(WebCore::SimpleLineLayout::FlowContents::style): Deleted.
(WebCore::SimpleLineLayout::FlowContents::characterAt): Deleted.
(WebCore::SimpleLineLayout::FlowContents::isLineBreak): Deleted.
(WebCore::SimpleLineLayout::FlowContents::isEnd): Deleted.

  • rendering/SimpleLineLayoutFlowContentsIterator.cpp: Copied from Source/WebCore/rendering/SimpleLineLayoutFlowContents.cpp.

(WebCore::SimpleLineLayout::FlowContentsIterator::Style::Style):
(WebCore::SimpleLineLayout::FlowContentsIterator::FlowContentsIterator):
(WebCore::SimpleLineLayout::FlowContentsIterator::nextTextFragment):
(WebCore::SimpleLineLayout::FlowContentsIterator::textWidth):
(WebCore::SimpleLineLayout::nextBreakablePosition):
(WebCore::SimpleLineLayout::FlowContentsIterator::findNextBreakablePosition):
(WebCore::SimpleLineLayout::findNextNonWhitespace):
(WebCore::SimpleLineLayout::FlowContentsIterator::findNextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContentsIterator::runWidth):

  • rendering/SimpleLineLayoutFlowContentsIterator.h: Copied from Source/WebCore/rendering/SimpleLineLayoutFlowContents.h.

(WebCore::SimpleLineLayout::FlowContentsIterator::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::FlowContentsIterator::TextFragment::isEmpty):
(WebCore::SimpleLineLayout::FlowContentsIterator::style):
(WebCore::SimpleLineLayout::FlowContentsIterator::segmentForPosition):
(WebCore::SimpleLineLayout::FlowContentsIterator::characterAt):
(WebCore::SimpleLineLayout::FlowContentsIterator::isLineBreak):
(WebCore::SimpleLineLayout::FlowContentsIterator::isEnd):

13:27 Changeset [179283] by bdakin@apple.com
  • 18 edits in trunk/Source/WebCore

Remove Mountain Lion code from WebCore
https://bugs.webkit.org/show_bug.cgi?id=141007

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • page/AlternativeTextClient.h:
  • page/mac/SettingsMac.mm:

(WebCore::Settings::initializeDefaultFontFamilies):

  • platform/cocoa/SystemVersion.mm:

(WebCore::callGestalt): Deleted.
(WebCore::createSystemMarketingVersion): Deleted.

  • platform/graphics/Font.cpp:

(WebCore::Font::applyTransforms):

  • platform/graphics/WidthIterator.h:

(WebCore::WidthIterator::supportsTypesettingFeatures):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeLoaded):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::supportsAcceleratedFilterAnimations):

  • platform/graphics/ca/PlatformCAFilters.h:
  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::platformInit):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::phaseForEvent):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::createStreams):

  • platform/network/cocoa/CredentialCocoa.mm:

(WebCore::toCredentialPersistence):

  • platform/spi/cocoa/CoreTextSPI.h:
13:24 Changeset [179282] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Web Inspector: Crash when closing inspected page
https://bugs.webkit.org/show_bug.cgi?id=140968

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-01-28
Reviewed by Timothy Hatcher.

Handle cases where the corePage could be null. With the Inspector Process
in its own process, messages may come to the WebContentProcess after
the WebCore::Page has itself been destroyed.

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::show):
(WebKit::WebInspector::close):
(WebKit::WebInspector::openInNewTab):
(WebKit::WebInspector::evaluateScriptForTest):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::canAttachWindow):
(WebKit::WebInspector::sendMessageToBackend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):

13:16 Changeset [179281] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebKit2

Convert WebPreferences and VisitedLinkProvider to be bridged API::Objects
https://bugs.webkit.org/show_bug.cgi?id=141002

Patch by Sam Weinig <sam@webkit.org> on 2015-01-28
Reviewed by Tim Horton.

  • Shared/API/APIObject.h:

Add VisitedLinkProvider type.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
Allocate WebPreferences and VisitedLinkProvider as their Objective-C counterpart.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]):
Switch to constructInWrapper.

(-[WKPreferences dealloc]):
Call the WebPreferences destructor.

(-[WKPreferences _apiObject]):
Add implementation of the WKObject protocol.

  • UIProcess/API/Cocoa/WKPreferencesInternal.h:

Convert to using ObjectStorage.

  • UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm:

(-[_WKVisitedLinkProvider init]):
Switch to constructInWrapper.

(-[_WKVisitedLinkProvider dealloc]):
Call the VisitedLinkProvider destructor.

(-[_WKVisitedLinkProvider _apiObject]):
Add implementation of the WKObject protocol.

  • UIProcess/API/Cocoa/_WKVisitedLinkProviderInternal.h:

Convert to using ObjectStorage.

  • UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::create):

  • UIProcess/VisitedLinkProvider.h:

Switch create() to return a Ref.

  • UIProcess/WebPreferences.h:

Make the constructor public for use by constructInWrapper.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createWebPage):

  • UIProcess/WebProcessPool.h:

Store the VisitedLinkProvider in a Ref.

13:01 Changeset [179280] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error in media player implementation.
https://bugs.webkit.org/show_bug.cgi?id=141004

Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-28
Reviewed by Brent Fulgham.

MediaPlayer::cachedResourceLoader() returns a pointer to the resource loader, not a reference.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::setSize):
(WebCore::MediaPlayerPrivateMediaFoundation::createVideoWindow):

12:48 Changeset [179279] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Prevent implicit animation when setting fullscreen background to clear.
https://bugs.webkit.org/show_bug.cgi?id=140888

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-01-28
Reviewed by Eric Carlson.

This patch decreases flicker when exiting fullscreen by preventing
an implicit animation when changing the background to clear.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::exitFullscreenInternal):

12:41 Changeset [179278] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[WinCairo] Message loop is flooded with timer messages when animating in accelerated compositing mode.
https://bugs.webkit.org/show_bug.cgi?id=140985

Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-28
Reviewed by Brent Fulgham.

The animation timer has zero timeout, which makes it hard for other messages to slip through.

  • WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::scheduleLayerFlush):

12:35 Changeset [179277] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

[WinCairo] Enable CSS_SELECTORS_LEVEL4.
https://bugs.webkit.org/show_bug.cgi?id=141003

Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-28
Reviewed by Brent Fulgham.

  • win/tools/vsprops/FeatureDefinesCairo.props:
12:33 Changeset [179276] by bfulgham@apple.com
  • 4 edits
    1 copy
    1 add in trunk/LayoutTests

[Win] More gardening to get the bot green.

  • css3/scroll-snap/resources: Added.
  • platform/win/TestExpectations:
  • platform/win/fast/events/ondrop-text-html-expected.txt: Copied from platform/win/fast/events/ondrop-text-htmlt-expected.txt.
  • platform/win/fast/events/ondrop-text-htmlt-expected.txt: Removed.
  • platform/win/fast/html/marquee-scrollamount-expected.txt: Added.
  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/win/fast/text/fallback-traits-fixup-expected.txt:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
12:21 Changeset [179275] by bfulgham@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening. Reskip some region tests.

  • platform/win/TestExpectations:
10:55 Changeset [179274] by lforschler@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177680. rdar://problem/19445865

10:50 Changeset [179273] by lforschler@apple.com
  • 6 edits in branches/safari-600.1.4.15-branch/Source

Merged r177666. rdar://problem/19445905

10:48 Changeset [179272] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit2

Merge r179195. rdar://problem/19572685

10:44 Changeset [179271] by matthew_hanson@apple.com
  • 6 edits in branches/safari-600.5-branch/Source

Merge r179129. rdar://problem/19489518

10:29 Changeset [179270] by bshafiei@apple.com
  • 5 edits in tags/Safari-600.5.3.2/Source

Versioning.

10:28 Changeset [179269] by dburkart@apple.com
  • 37 edits in trunk

Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=136765

Reviewed by Alexey Proskuryakov.

10:28 Changeset [179268] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.3.2

New tag.

10:24 Changeset [179267] by cdumez@apple.com
  • 5 edits in trunk/Source/WebCore

Use an enum class for createFontFamilyValue()'s fromSystemFontID argument
https://bugs.webkit.org/show_bug.cgi?id=140981

Reviewed by Darin Adler.

Use an enum class for createFontFamilyValue()'s fromSystemFontID argument
instead of a simple enum, as suggested by Sam. This is a bit nicer.

Also, use a boolean type for CSSFontFamily.fromSystemFontID instead of
the enum type to facilitate handling. Using a enum (class) for
CSSFontFamily's fromSystemFontID member is not useful as it is always
accessed by name.

  • css/CSSFontFamily.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSystemFont):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

  • css/CSSValuePool.h:
10:20 Changeset [179266] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit2

Merge r179087. rdar://problem/19571057

10:17 Changeset [179265] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r179086. rdar://problem/19566089

10:14 Changeset [179264] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit2

Merge r179023. rdar://problem/19573674

10:09 Changeset [179263] by cdumez@apple.com
  • 11 edits in trunk/Source

Fix typo in markPagesForVistedLinkStyleRecalc()
https://bugs.webkit.org/show_bug.cgi?id=140977

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.exp.in:
  • history/CachedPage.h:

(WebCore::CachedPage::markForVisitedLinkStyleRecalc):
(WebCore::CachedPage::markForVistedLinkStyleRecalc): Deleted.

  • history/PageCache.cpp:

(WebCore::PageCache::markPagesForVisitedLinkStyleRecalc):
(WebCore::PageCache::markPagesForVistedLinkStyleRecalc): Deleted.

  • history/PageCache.h:

Source/WebKit/mac:

  • WebCoreSupport/WebVisitedLinkStore.mm:

(WebVisitedLinkStore::removeAllVisitedLinks):
(WebVisitedLinkStore::removeVisitedLink):
(WebVisitedLinkStore::addVisitedLinkHash):

Source/WebKit/win:

  • WebCoreSupport/WebVisitedLinkStore.cpp:

(WebVisitedLinkStore::removeAllVisitedLinks):
(WebVisitedLinkStore::addVisitedLinkHash):

Source/WebKit2:

  • WebProcess/WebPage/VisitedLinkTableController.cpp:

(WebKit::VisitedLinkTableController::setVisitedLinkTable):
(WebKit::VisitedLinkTableController::visitedLinkStateChanged):
(WebKit::VisitedLinkTableController::allVisitedLinkStateChanged):
(WebKit::VisitedLinkTableController::removeAllVisitedLinks):

10:02 Changeset [179262] by cdumez@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Remove duplicate friend class statement after r179255.

  • history/PageCache.h:
10:00 Changeset [179261] by matthew_hanson@apple.com
  • 10 edits in branches/safari-600.5-branch/Source

Merge r179014. rdar://problem/19573674

09:59 Changeset [179260] by darin@apple.com
  • 19 edits in trunk/Source/WebCore

Make SVGElement::instancesForElement point to elements in the shadow tree, not SVGElementInstance objects
https://bugs.webkit.org/show_bug.cgi?id=140984

Reviewed by Anders Carlsson.

Refactoring of code that is pretty well covered by existing tests, so
not adding new tests.

Inspired by work Rob Buis did in Blink:

http://src.chromium.org/viewvc/blink?view=revision&revision=173275

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear): Removed code to zero m_lastInstanceUnderMouse.
(WebCore::instanceAssociatedWithShadowTreeElement): Deleted.
(WebCore::EventHandler::updateMouseEventTargetNode): Removed code that used
m_lastInstanceUnderMouse to track events on an object after recloning.
This behavior doesn't seem to be needed to pass any existing tests, and Rob
removed it from Blink, so I'll take it out and we can bring if back, based
on the original element rather than on the SVGElementInstance, if we find we
need to restore the behavior in the future.

  • page/EventHandler.h: Removed m_lastInstanceUnderMouse.
  • svg/SVGAnimateElementBase.cpp:

(WebCore::SVGAnimateElementBase::determineAnimatedPropertyType):
Changed this function to take a reference and to call the updated version
of the targetElement.animatedPropertyTypesForAttribute function.
(WebCore::SVGAnimateElementBase::calculateAnimatedValue): Updated to pass
a reference rather than a pointer.
(WebCore::SVGAnimateElementBase::resetAnimatedType): Updated to pass
references rather than pointers.
(WebCore::applyCSSPropertyToTarget): Updated to take a reference.
(WebCore::removeCSSPropertyFromTarget): Ditto.
(WebCore::applyCSSPropertyToTargetAndInstances): Ditto. Also use a modern
for loop, and iterate over shadow tree instances, not over SVGElementInstance.
(WebCore::removeCSSPropertyFromTargetAndInstances): Ditto.
(WebCore::notifyTargetAboutAnimValChange): Ditto.
(WebCore::notifyTargetAndInstancesAboutAnimValChange): Ditto.
(WebCore::SVGAnimateElementBase::clearAnimatedType): More of the same.
(WebCore::SVGAnimateElementBase::applyResultsToTarget): Ditto.
(WebCore::SVGAnimateElementBase::resetAnimatedPropertyType): Ditto.

  • svg/SVGAnimateElementBase.h: Changed determineAnimatedPropertyType to take

a reference rahter than a pointer.

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::applyResultsToTarget): Updated to use the
new instances instead of SVGElementInstance. Also added code to skip work if
the transform is not changing, and use the assignment operator instead of
breaking one matrix down and calling setMatrix on the other.

  • svg/SVGAnimatedTypeAnimator.cpp:

(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
Changed to take a reference rather than a pointer, and rewrote to streamline,
using modern for loops and using the new instances set.

  • svg/SVGAnimatedTypeAnimator.h: Removed the constructors from the

SVGElementAnimatedProperties struct since we can build them just fine without
them. Changed findAnimatedPropertiesForAttributeName to take a reference.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation): Pass a
reference rather than a pointer. Also streamlined the code a bit and removed
a comment that tried to say exactly what the code was doing, but was outdated.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement): Disconnect all instances from this element
and also disconnect the corresponding element from this element if it itself
is an instance. This guarantees we have no dangling pointers.
(WebCore::SVGElement::mapInstanceToElement): Deleted.
(WebCore::SVGElement::removeInstanceMapping): Deleted.
(WebCore::SVGElement::instances): Renamed from instancesForElement and changed
to be a set of SVG element instances in the shadow tree, rather than
SVGElementInstance objects.
(WebCore::SVGElement::correspondingElement): Tweaked assertion a little and use
nullptr instead of 0.
(WebCore::SVGElement::correspondingUseElement): Added. Finds the use element
that owns the shadow tree this element is in by following the host element
pointer from the shadow root.
(WebCore::SVGElement::setCorrespondingElement): Added code to insert or remove
this element from the instances set of the corresponding element.
(WebCore::SVGElement::animatedPropertyTypesForAttribute): Renamed from
animatedPropertyTypeForAttribute and switched to use a return value instead of
an out argument.
(WebCore::SVGElement::addEventListener): Updated to use instances rather than
the old instancesForElement.
(WebCore::SVGElement::removeEventListener): Ditto.
(WebCore::SVGElement::synchronizeAllAnimatedSVGAttribute): Pass a reference.
(WebCore::SVGElement::synchronizeAnimatedSVGAttribute): Ditto.
(WebCore::SVGElement::isPresentationAttributeWithSVGDOM): Updated to use the
new function from AttributeToPropertyMap.

  • svg/SVGElement.h: Changed animatedPropertyTypesForAttribute name to be plural

since it returns a vector of types, and made it use a return value instead of
an out argument. Added the correspondingUseElement function, and removed the
mapInstanceToElement and removeInstanceMapping functions.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::SVGElementInstance): Removed now-unneeded call to
mapInstanceToElement. This is now handled entirely by the SVGElement itself.
(WebCore::SVGElementInstance::detach): Removed now-unneeded call to
removeInstanceMapping. This is now handled entirely by the SVGElement itself.
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Rewrote to be
based on the instances set; logic is different now because we remove each
element from that set as we go.

  • svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::SVGElementRareData): Removed initialization of
pointers since we can do that where they are defined instead.
(WebCore::SVGElementRareData::instances): Renamed from elementInstances and
changed the type.
(WebCore::SVGElementRareData::destroyAnimatedSMILStyleProperties): Deleted.
Unneeded since it was already called just before deleting the rare data.

  • svg/SVGTests.cpp:

(WebCore::SVGTests::SVGTests): Took advantage of using namespace.
(WebCore::createSVGTestPropertyInfo): Added. Helper for function below.
(WebCore::createSVGTextAttributeToPropertyMap): Ditto.
(WebCore::SVGTests::attributeToPropertyMap): Changed to use the create function
above. No longer allocates objects on the heap.
(WebCore::SVGTests::hasExtension): Reworked #if code to make the MathML part
independent rather than repeating the return statement.
(WebCore::SVGTests::synchronizeAttribute): Added. Helper for functions below.
(WebCore::SVGTests::synchronizeRequiredFeatures): Call synchronizeAttribute.
(WebCore::SVGTests::synchronizeRequiredExtensions): Ditto.
(WebCore::SVGTests::synchronizeSystemLanguage): Ditto.

  • svg/SVGTests.h: Removed unneeded forward declarations. Mark the many functions

that do not depend on object state as static so the call sites don't wastefully
pass a this pointer. Removed the unneeded requiredFeaturesPropertyInfo,
requiredExtensionsPropertyInfo, and systemLanguagePropertyInfo functions.
Added synchronizeAttribute helper function.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::invalidateDependentShadowTrees): Updated to use the
new instances set and a modern for loop.

  • svg/properties/SVGAnimatedPropertyMacros.h: Pass reference to addProperty and

made a few other small refinements.

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties): Fixed problems mentioned
in FIXME where we did too much hashing and vector resizing.
(WebCore::SVGAttributeToPropertyMap::addProperty): Streamlined to use a single
hash table lookup.
(WebCore::SVGAttributeToPropertyMap::properties): Renamed from
animatedPropertiesForAttribute and changed to return a vector rather than using
an out argument. Also had to change some since the vectors are in the hash table
now rather than allocated on the heap.
(WebCore::SVGAttributeToPropertyMap::types): Renamed from
animatedPropertyTypeForAttribute and made changes just like the ones above.
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties): Use modern for
loops, take a reference rather than a pointer, and use the function pointer
directly instead of calling through a helper with various assertions.
(WebCore::SVGAttributeToPropertyMap::synchronizeProperty): Ditto.

  • svg/properties/SVGAttributeToPropertyMap.h: Updated to match the changes

above. Also changed the map to contain vectors instead of pointers to vectors.

09:54 Changeset [179259] by matthew_hanson@apple.com
  • 4 edits in branches/safari-600.5-branch/Source

Merge r179013. rdar://problem/19571601

09:50 Changeset [179258] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r173698): Leaks of selector lists in CSS parsing
https://bugs.webkit.org/show_bug.cgi?id=140993

Reviewed by Anders Carlsson.

  • css/CSSGrammar.y.in: Fixed logic in rules that were not moving a parser-

owned pointer into a unique_ptr in all code paths. The magic value
invalidSelectorVector makes this really messy. We might want to find a
different seolution in the future.

09:49 Changeset [179257] by matthew_hanson@apple.com
  • 6 edits in branches/safari-600.5-branch/Source

Merge r178938. rdar://problem/19558472

09:43 Changeset [179256] by matthew_hanson@apple.com
  • 4 edits in branches/safari-600.5-branch/Source

Merge r178858. rdar://problem/19540806

09:22 Changeset [179255] by bfulgham@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r179247.

  • history/PageCache.h: Need to declare NeverDestroyed specialization as

a friend.

09:08 Changeset [179254] by antti@apple.com
  • 2 edits in trunk/Source/WebKit2

http/tests/xmlhttprequest/workers/methods.html sometimes times out with disk cache enabled
https://bugs.webkit.org/show_bug.cgi?id=140976

Reviewed by Chris Dumez.

Running

run-webkit-tests --release -2 http/tests/xmlhttprequest/workers/methods.html --iterations=100

would usually time out an iteration.

  • NetworkProcess/cache/NetworkCacheStorageCocoa.mm:

(WebKit::NetworkCacheStorage::dispatchRetrieveOperation):

Using dispatch_io_read with an empty file calls the handler block immediately with done boolean set
without it being an error. We failed to call the completion handler and any synchronous xhr would hang.
We may see an empty cache file if we are just in process of writing it.

Fix by handling this case specifically.

09:02 Changeset [179253] by jdiggs@igalia.com
  • 15 edits
    3 adds in trunk

AX: [ATK] Implement support for new AtkRole types for MathML
https://bugs.webkit.org/show_bug.cgi?id=140916

Reviewed by Chris Fleizach.

Source/WebCore:

Expose mfrac as ATK_ROLE_MATH_FRACTION, and both mroot and msqrt as
ATK_ROLE_MATH_ROOT. In the case of script elements, expose the container
(msub, msup, msubsup, and mmultiscripts) using the generic text block role
ATK_ROLE_SECTION. Then expose the actual script child elements using role
ATK_ROLE_SUBSCRIPT/ATK_ROLE_SUPERSCRIPT. In the case of mmultiscripts,
expose whether it is a prescript or postscript via AtkObject attribute.

Test: accessibility/math-multiscript-attributes.html
Also added additional test cases to accessibility/roles-exposed.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isMathScriptObject): Added.
(WebCore::AccessibilityObject::isMathMultiscriptObject): Added.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isMathScriptObject): Added.
(WebCore::AccessibilityRenderObject::isMathMultiscriptObject): Added.

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Expose whether a multiscript object is a prescript or postscript.
(atkRole): Map WebCore Accessibility objects to the new ATK roles.

Tools:

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
  • gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4

LayoutTests:

  • accessibility/math-multiscript-attributes.html: Added.
  • accessibility/roles-exposed.html: New test cases added.
  • platform/efl/accessibility/roles-exposed-expected.txt: Updated for new test cases.
  • platform/gtk/accessibility/math-multiscript-attributes-expected.txt: Added.
  • platform/gtk/accessibility/roles-exposed-expected.txt: Updated for new test cases.
  • platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for new test cases.
  • platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Updated for new test cases.
  • platform/mac/accessibility/math-multiscript-attributes-expected.txt: Added.
  • platform/mac/accessibility/roles-exposed-expected.txt: Updated for new test cases.
08:46 Changeset [179252] by bfulgham@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION: Re-skip media tests. (Unreviewed)
https://bugs.webkit.org/show_bug.cgi?id=140995

  • platform/win/TestExpectations: Re-skip the tests.
08:30 Changeset [179251] by clopez@igalia.com
  • 2 edits in trunk

[CMake] Minimum python version should be 2.7.
https://bugs.webkit.org/show_bug.cgi?id=140997

Reviewed by Csaba Osztrogonác.

  • CMakeLists.txt:
06:48 Changeset [179250] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

[GTK] Stop removing color marks from unit tests output
https://bugs.webkit.org/show_bug.cgi?id=140996

Reviewed by Philippe Normand.

Since r178236 google tests use a custom simplified output without
any colors, so we don't need to handle the case of non ttys to
remove the color marks.

  • Scripts/run-gtk-tests:

(TestRunner.init):
(TestRunner._run_test_command.parse_line):

06:47 Changeset [179249] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Add missing file to WebInspector compilation for GTK+.

  • PlatformGTK.cmake: Add UserInterface/External/ESLint/eslint.js
05:44 Changeset [179248] by carlosgc@webkit.org
  • 3 edits in trunk/Tools

[GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
https://bugs.webkit.org/show_bug.cgi?id=131731

Reviewed by Žan Doberšek.

A web page loaded offscreen is in prerender state not hidden.

  • Scripts/run-gtk-tests:

(TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewPageVisibility):

01:33 Changeset [179247] by cdumez@apple.com
  • 29 edits in trunk/Source

Rename pageCache() to PageCache::shared() and return a reference
https://bugs.webkit.org/show_bug.cgi?id=140983

Reviewed by Andreas Kling.

Rename pageCache() to PageCache::shared() as this is a singleton class
and have it return a reference instead of a pointer.

Source/WebCore:

  • history/BackForwardList.cpp:

(WebCore::BackForwardList::addItem):
(WebCore::BackForwardList::setCapacity):
(WebCore::BackForwardList::clearAllPageCaches):
(WebCore::BackForwardList::close):

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::setURL):

  • history/PageCache.cpp:

(WebCore::PageCache::shared):
(WebCore::PageCache::get):
(WebCore::pageCache): Deleted.

  • history/PageCache.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::invalidateCurrentItemCachedPage):
(WebCore::HistoryController::updateForReload):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):
(WebCore::Page::setPagination):
(WebCore::Page::setVisitedLinkStore):

  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferencesChanged):

  • page/Settings.cpp:

(WebCore::Settings::setUsesPageCache):

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseCriticalMemory):

Source/WebKit/mac:

  • History/WebBackForwardList.mm:

(-[WebBackForwardList pageCacheSize]):

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics cachedPageCount]):
(+[WebCoreStatistics cachedFrameCount]):

  • WebCoreSupport/WebVisitedLinkStore.mm:

(WebVisitedLinkStore::removeAllVisitedLinks):
(WebVisitedLinkStore::removeVisitedLink):
(WebVisitedLinkStore::addVisitedLinkHash):

  • WebView/WebView.mm:

(+[WebView _setCacheModel:]):

Source/WebKit/win:

  • WebCoreStatistics.cpp:

(WebCoreStatistics::cachedPageCount):
(WebCoreStatistics::cachedFrameCount):

  • WebCoreSupport/WebVisitedLinkStore.cpp:

(WebVisitedLinkStore::removeAllVisitedLinks):
(WebVisitedLinkStore::addVisitedLinkHash):

  • WebView.cpp:

(WebView::setCacheModel):

Source/WebKit2:

  • WebProcess/WebPage/VisitedLinkTableController.cpp:

(WebKit::VisitedLinkTableController::setVisitedLinkTable):
(WebKit::VisitedLinkTableController::visitedLinkStateChanged):
(WebKit::VisitedLinkTableController::allVisitedLinkStateChanged):
(WebKit::VisitedLinkTableController::removeAllVisitedLinks):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem):
(WebKit::WebBackForwardListProxy::close):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::releasePageCache):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformSetCacheModel):

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformSetCacheModel):

01:22 Changeset [179246] by darin@apple.com
  • 3 edits in trunk/Source/WebCore

Fix MediaPlayerEngine leaks
https://bugs.webkit.org/show_bug.cgi?id=140992

Reviewed by Jer Noble.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::mutableInstalledMediaEnginesVector): Added.
(WebCore::buildMediaEnginesVector): Added.
(WebCore::installedMediaEngines): Changed this to be a vector of factories
instead of a vector of heap-allocated factories. The old code would leak
all the factories when this was called with the ResetEngines option.
(WebCore::addMediaEngine): Updated for above change.
(WebCore::bestMediaEngineForSupportParameters): Ditto.
(WebCore::nextMediaEngine): Ditto.
(WebCore::MediaPlayer::nextBestMediaEngine): Ditto.
(WebCore::MediaPlayer::loadWithNextMediaEngine): Ditto.
(WebCore::MediaPlayer::supportsType): Ditto.
(WebCore::MediaPlayer::getSupportedTypes): Ditto.
(WebCore::MediaPlayer::getSitesInMediaCache): Ditto.
(WebCore::MediaPlayer::clearMediaCache): Ditto.
(WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
(WebCore::MediaPlayer::supportsKeySystem): Ditto.
(WebCore::MediaPlayer::resetMediaEngines): Ditto.

  • platform/graphics/MediaPlayer.h: Ditto.
00:44 Changeset [179245] by darin@apple.com
  • 2 edits in trunk/Source/WTF

Fix small leak in Collator
https://bugs.webkit.org/show_bug.cgi?id=140990

Reviewed by Andreas Kling.

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::Collator): Use fastStrDup instead of strdup.
(WTF::Collator::~Collator): Use fastFree on the collator locale that we
are abandoning. The old code instead just called free on a null pointer.

00:09 Changeset [179244] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Rename descendentxxx to descendantxxxx in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=140979

Patch by Jeongmin Kim <jm86.kim@lge.com> on 2015-01-28
Reviewed by Martin Robinson.

Rename descendentxxx to descendantxxxx in RenderLayerBacking
for matching other variables and function names.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateChildClippingStrategy):
(WebCore::RenderLayerBacking::paintsChildren):
(WebCore::descendantLayerPaintsIntoAncestor):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::descendentLayerPaintsIntoAncestor): Deleted.
(WebCore::RenderLayerBacking::isPaintDestinationForDescendentLayers): Deleted.

01/27/15: Yesterday

23:41 Changeset [179243] by bshafiei@apple.com
  • 6 edits in branches/safari-600.4-branch/Source

Merged r179230. rdar://problem/19621509

21:53 Changeset [179242] by cdumez@apple.com
  • 61 edits in trunk/Source

Use a Ref<CachedResourceLoader> in Document instead of a RefPtr
https://bugs.webkit.org/show_bug.cgi?id=140971

Reviewed by Andreas Kling.

Source/WebCore:

Use a Ref<CachedResourceLoader> in Document instead of a RefPtr as it
can never be null. Also have Document::cachedResourceLoader() return a
reference instead of a pointer. This gets rid of a lot of unnecessary
null-checks.

Source/WebKit/win:

Use more references instead of pointers.

  • WebDataSource.cpp:

(WebDataSource::subresourceForURL):

21:48 Changeset [179241] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ExitSiteData saying m_takesSlowPath shouldn't mean early returning takesSlowPath() since for the non-LLInt case we later set m_couldTakeSlowPath, which is more precise
https://bugs.webkit.org/show_bug.cgi?id=140980

Reviewed by Oliver Hunt.

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFor):

21:29 Changeset [179240] by ap@apple.com
  • 1 edit
    2 copies in trunk/Tools

Partially revert r178802.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
21:11 Changeset [179239] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

21:09 Changeset [179238] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.16

New tag.

18:37 Changeset [179237] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (OS X 10.10.2): media/track/track-in-band-style.html frequently times out
https://bugs.webkit.org/show_bug.cgi?id=140974

  • platform/mac/TestExpectations: Added an expectation.
18:29 Changeset [179236] by ap@apple.com
  • 17 edits in trunk/Source

More build fixes for newer clang.

Rubber-stamped by Anders Carlsson.

Source/WebCore:

  • loader/icon/IconDatabase.h: Added missing override keywords.

Source/WebKit/mac:

Marked a deprecated accessibility method as such.

  • WebView/WebFrame.mm:

(-[WebFrame accessibilityRoot]):

Source/WebKit2:

Added missing override keywords, marked some deprecated accessibility methods as such.

  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:

(WebKit::PluginProcessMainDelegate::doPreInitializationWork): Deleted.
(WebKit::PluginProcessMainDelegate::getExtraInitializationData): Deleted.
(WebKit::PluginProcessMainDelegate::doPostRunWork): Deleted.

  • PluginProcess/WebProcessConnection.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/PageClientImpl.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(PageOverlayClientImpl::actionContextForResultAtPoint): Deleted.
(PageOverlayClientImpl::dataDetectorsDidPresentUI): Deleted.
(PageOverlayClientImpl::dataDetectorsDidChangeUI): Deleted.
(PageOverlayClientImpl::dataDetectorsDidHideUI): Deleted.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(WebKit::NetscapePlugin::isBeingAsynchronouslyInitialized): Deleted.

  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PluginProcessConnection.h:
  • WebProcess/Plugins/PluginProxy.h:

(WebKit::PluginProxy::isBeingAsynchronouslyInitialized): Deleted.

  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
17:54 Changeset [179235] by ap@apple.com
  • 2 edits in trunk/Tools

build.webkit.org/dashboard asserts on some commits
https://bugs.webkit.org/show_bug.cgi?id=140926

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:

(Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.

17:26 Changeset [179234] by bfulgham@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Re-enable Sputnik.

  • platform/win/TestExpectations:
  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
17:16 Changeset [179233] by roger_fong@apple.com
  • 10 edits in trunk

WebGL2: Disable various extensions on WebGL2 context that have been promoted to core.
https://bugs.webkit.org/show_bug.cgi?id=140907.
<rdar://problem/19545857>

Reviewed by Brent Fulgham.

Source/WebCore:

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

  • html/canvas/WebGL2RenderingContext.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::getSupportedExtensions): Deleted.

  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGLRenderingContextBase.idl:

Remove some extra extension enums that shouldn't have been declared on the context idl.

LayoutTests:

  • fast/canvas/webgl/constants.html:
17:11 Changeset [179232] by ap@apple.com
  • 3 edits in trunk/Tools

Make flakiness dashboard OS list actually match test_expectations.py
https://bugs.webkit.org/show_bug.cgi?id=140969

Reviewed by Ryosuke Niwa.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:
17:08 Changeset [179231] by bfulgham@apple.com
  • 3 edits
    1 add in trunk/LayoutTests

[Win] More Windows rebaselines.

  • platform/win/fast/events/ondrop-text-htmlt-expected.txt: Added.
  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/win/fast/text/fallback-traits-fixup-expected.txt:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
17:06 Changeset [179230] by bdakin@apple.com
  • 6 edits in trunk/Source

Immediate action gesture recognizer still doesn't work well with IB
https://bugs.webkit.org/show_bug.cgi?id=140967
-and corresponding-
rdar://problem/19621509

Reviewed by Tim Horton.

We should add (or remove) the gesture recognizer in viewDidMoveToWindow because
initWithFrame it too early and IB might mess with it.
Source/WebKit/mac:

  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController immediateActionRecognizer]):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView viewDidMoveToWindow]):

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView initWithFrame:processPool:configuration:webView:]):

16:48 Changeset [179229] by cdumez@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unnecessary m_cachedPage null-checks in PageCache
https://bugs.webkit.org/show_bug.cgi?id=140965

Reviewed by Andreas Kling.

Remove unnecessary m_cachedPage null-checks in PageCache. We initialize
m_cachedPage when inserting the HistoryItem in the page cache and clear
it when removing it from the page cache. Therefore, it is guaranteed
that HistoryItems currently in the page cache have m_cachedPage
initialized and there is no need to null-check it.

  • history/PageCache.cpp:

(WebCore::PageCache::frameCount):
(WebCore::PageCache::markPagesForVistedLinkStyleRecalc):
(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore::PageCache::markPagesForDeviceScaleChanged):
(WebCore::PageCache::markPagesForCaptionPreferencesChanged):

16:13 Changeset [179228] by ap@apple.com
  • 3 edits in trunk/Source/WebCore

Some NSAccessibility methods we use are deprecated on 10.10
https://bugs.webkit.org/show_bug.cgi?id=140966

Reviewed by Anders Carlsson.

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::overrideAttachmentParent):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper role]):
(-[WebAccessibilityObjectWrapper roleDescription]):
Silence the warnings for now.

16:02 Changeset [179227] by cdumez@apple.com
  • 5 edits in trunk/Source/WebCore

Rename isExpandedShorthand() to isShorthandCSSProperty() for clarity
https://bugs.webkit.org/show_bug.cgi?id=140954

Reviewed by Andreas Kling.

Rename isExpandedShorthand() to isShorthandCSSProperty() for clarity as
all CSS shorthand properties are now expanded during parsing (even
'font').

  • css/StylePropertyShorthand.cpp:

(WebCore::isShorthandCSSProperty):
(WebCore::isExpandedShorthand): Deleted.

  • css/StylePropertyShorthand.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • css/makeprop.pl:
15:43 Changeset [179226] by matthew_hanson@apple.com
  • 6 edits in branches/safari-600.4-branch/Source

Merge r179129. rdar://problem/19489518

15:38 Changeset [179225] by bfulgham@apple.com
  • 2 edits in trunk/Tools

[Win] WinLauncher crashes on eleventh site visited
https://bugs.webkit.org/show_bug.cgi?id=140960

Reviewed by Anders Carlsson.

  • WinLauncher/WinLauncher.cpp:

(WinLauncher::showLastVisitedSites): Don't access off the end of
the history array.

15:34 Changeset [179224] by lforschler@apple.com
  • 6 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177647. rdar://problem/19445865

14:56 Changeset [179223] by fpizlo@apple.com
  • 5 edits
    2 moves in trunk/Source/JavaScriptCore

Move DFGBinarySwitch out of the DFG so that all of the JITs can use it
https://bugs.webkit.org/show_bug.cgi?id=140959

Rubber stamped by Geoffrey Garen.

I want to use this for polymorphic stubs for https://bugs.webkit.org/show_bug.cgi?id=140660.
This code no longer has DFG dependencies so this is a very clean move.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGBinarySwitch.cpp: Removed.
  • dfg/DFGBinarySwitch.h: Removed.
  • dfg/DFGSpeculativeJIT.cpp:
  • jit/BinarySwitch.cpp: Copied from Source/JavaScriptCore/dfg/DFGBinarySwitch.cpp.
  • jit/BinarySwitch.h: Copied from Source/JavaScriptCore/dfg/DFGBinarySwitch.h.
14:49 Changeset [179222] by lforschler@apple.com
  • 8 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r177612. rdar://problem/19445900

14:41 Changeset [179221] by ggaren@apple.com
  • 3 edits in trunk/Source/WTF

Removed WTF_MALLOC_VALIDATION
https://bugs.webkit.org/show_bug.cgi?id=140958

Reviewed by Anders Carlsson.

I don't think anyone has been using this, and the #ifdefs were driving
me crazy.

We have other options for validation -- like MallocGuardEdges,
MallocCheckHeapEach, MallocScribble, and GuardMalloc.

  • wtf/FastMalloc.cpp:

(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::tryFastRealloc):
(WTF::fastRealloc):
(WTF::fastMallocSize):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
(WTF::Internal::fastMallocMatchFailed): Deleted.

  • wtf/FastMalloc.h:

(WTF::Internal::fastMallocValidationHeader): Deleted.
(WTF::Internal::fastMallocValidationSuffix): Deleted.
(WTF::Internal::fastMallocMatchValidationType): Deleted.
(WTF::Internal::setFastMallocMatchValidationType): Deleted.
(WTF::fastMallocMatchValidateMalloc): Deleted.
(WTF::fastMallocMatchValidateFree): Deleted.
(WTF::fastMallocValidate): Deleted.

14:37 Changeset [179220] by eric.carlson@apple.com
  • 7 edits
    1 copy
    3 adds in trunk

Simplify http/tests/media/video-play-stall.html
https://bugs.webkit.org/show_bug.cgi?id=140630

Reviewed by Brent Fulgham.

Source/WebCore:

Test: http/tests/media/video-play-waiting.html

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::play): Add more logging.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): MediaPlayerAVPlayerItemStatusPlaybackBufferEmpty

always maps to HaveCurrentData.

(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Don't log FunctionType,

doing so it needlessly verbose.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Log KVO property

values and notification state.

LayoutTests:

  • http/tests/media/video-play-stall-expected.txt:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-play-waiting-expected.txt: Added.
  • http/tests/media/video-play-waiting.html: Added.
  • media/content/long-test.mp4: Added. New media file with 30 second duration.
  • media/content/long-test.ogv: Ditto.
  • platform/mac/TestExpectations: Remove video-play-stall.html from the skip list. Mark

video-play-waiting.html as flakey as it sometimes times out.

14:31 Changeset [179219] by lforschler@apple.com
  • 4 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177591. rdar://problem/19445895

14:29 Changeset [179218] by ap@apple.com
  • 3 edits in trunk/Tools

[Mac] Disable building Java applets by default
https://bugs.webkit.org/show_bug.cgi?id=140957
rdar://problem/19619529

Reviewed by Anders Carlsson.

It was actually already disabled unconditionally, by accident.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
  • Scripts/webkitpy/port/mac.py:

(MacPort._check_port_build):
(MacPort._build_java_test_support):

14:22 Changeset [179217] by lforschler@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177581. rdar://problem/19445888

14:07 Changeset [179216] by dbates@webkit.org
  • 3 edits in trunk/Tools

[iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
https://bugs.webkit.org/show_bug.cgi?id=140949

Reviewed by Alexey Proskuryakov.

Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
builders so that run-webkit-tests can lint the appropriate TestExpectation
files.

  • Scripts/webkitpy/port/builders.py:
  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.init): Move logic to query for the Mac build directory from here...
(IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
will fail because IOSSimulatorPort.init() ultimately calls Tools/Scripts/webkit-build-directory
to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.

14:05 Changeset [179215] by lforschler@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r177531. rdar://problem/19445868

14:02 Changeset [179214] by ap@apple.com
  • 4 edits in trunk/Tools

Update bots on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=140956

Reviewed by Ryosuke Niwa.

  • TestResultServer/static-dashboards/builders.jsonp:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:
13:59 Changeset [179213] by lforschler@apple.com
  • 8 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r177526. <rdar://problem/19445868>

13:37 Changeset [179212] by lforschler@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177504. rdar://problem/19445872

13:34 Changeset [179211] by commit-queue@webkit.org
  • 41 edits
    1 copy
    4 adds in trunk/Source

Unreviewed, rolling out r179192.
https://bugs.webkit.org/show_bug.cgi?id=140953

Caused numerous layout test failures (Requested by mattbaker_
on #webkit).

Reverted changeset:

"Use FastMalloc (bmalloc) instead of BlockAllocator for GC
pages"
https://bugs.webkit.org/show_bug.cgi?id=140900
http://trac.webkit.org/changeset/179192

13:27 Changeset [179210] by lforschler@apple.com
  • 8 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177499. rdar://problem/19445880

13:19 Changeset [179209] by lforschler@apple.com
  • 22 edits
    3 copies
    3 deletes in branches/safari-600.1.4.15-branch/Source

Merged r177455. rdar://problem/19445868

13:10 Changeset [179208] by bfulgham@apple.com
  • 8 edits
    11 adds
    1 delete in trunk/LayoutTests

[Win] Another round of bug filing and expectation updates.

  • platform/win/TestExpectations:
  • platform/win/fast/selectors: Added.
  • platform/win/fast/selectors/064-expected.txt: Added.
  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/win/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/win/fast/text/drawBidiText-expected.txt: Added.
  • platform/win/fast/text/fallback-traits-fixup-expected.txt:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/win/fast/text/international/hindi-spacing-expected.txt: Added.
  • platform/win/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Removed property svn:executable.
  • platform/win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
  • platform/win/fast/text/unicode-variation-selector-expected.txt:
  • platform/win/fast/text/whitespace: Added.
  • platform/win/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt: Added.
  • platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/win/fast/writing-mode/fieldsets-expected.txt: Added.
  • platform/win/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
  • platform/win/printing/iframe-print-expected.txt: Added.
  • platform/win/transforms/2d/zoom-menulist-expected.txt: Added.
13:00 Changeset [179207] by bshafiei@apple.com
  • 5 edits in tags/Safari-600.5.3.1/Source

Versioning.

12:55 Changeset [179206] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.3.1

New tag.

12:50 Changeset [179205] by benjamin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Import the layout test style-sharing-type-and-readonly.html from blink
https://bugs.webkit.org/show_bug.cgi?id=125280

Reviewed by Sergio Villar Senin.

I fixed the bug a while ago but having one more test seems valuable.
This test is from blink: https://codereview.chromium.org/27033011
by Elliott Sprehn.

  • fast/css/style-sharing-type-and-readonly-expected.txt: Added.
  • fast/css/style-sharing-type-and-readonly.html: Added.
12:46 Changeset [179204] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Modernize some constructors of the CSS JIT
https://bugs.webkit.org/show_bug.cgi?id=140903

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-27
Reviewed by Darin Adler.

Two constructors were still using the old style.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment): Deleted.
(WebCore::SelectorCompiler::TagNamePattern::TagNamePattern): Deleted.

12:45 Changeset [179203] by benjamin@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

Import some extra tests for r179132
https://bugs.webkit.org/show_bug.cgi?id=140930

Reviewed by Sam Weinig.

Add some tests that were done from previous attempts at fixing
the bug.

  • fast/dom/SelectorAPI/tag-case-insensitive-expected.txt: Added.
  • fast/dom/SelectorAPI/tag-case-insensitive.html: Added.
  • fast/dom/SelectorAPI/tag-case-sensitive-expected.txt: Added.
  • fast/dom/SelectorAPI/tag-case-sensitive.xhtml: Added.
  • svg/css/case-sensitive-tags-expected.txt: Added.
  • svg/css/case-sensitive-tags.html: Added.
  • svg/dom/tag-case-sensitive-svg-in-html-expected.txt: Added.
  • svg/dom/tag-case-sensitive-svg-in-html.html: Added.

Those tests were created by Alexandru Chiculita for
https://bugs.webkit.org/show_bug.cgi?id=83438

The patch was rejected at the time due to the perf impact.
That has been solved since then by the CSS JIT.

  • svg/css/foreignObject-case-styling-expected.html: Added.
  • svg/css/foreignObject-case-styling.html: Added.

This test is from Boris Zbarsky when he reported
https://bugs.webkit.org/show_bug.cgi?id=79444.

12:25 Changeset [179202] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r178591): 20% regression in Octane box2d
https://bugs.webkit.org/show_bug.cgi?id=140948

Reviewed by Geoffrey Garen.

Added check that we have a lexical environment to the arguments is captured check.
It doesn't make sense to resolve "arguments" when it really isn't captured.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::willResolveToArgumentsRegister):

12:16 Changeset [179201] by bfulgham@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix.

Lack of include guards in WebVTTElement.h caused a build failure once we started including
this header file from more than one implementation file.

  • html/track/WebVTTElement.h:
11:52 Changeset [179200] by dbates@webkit.org
  • 6 edits in trunk/LayoutTests

[iOS] Update test results and test expectations

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/css3/blending/blend-mode-simple-composited-expected.txt:
  • platform/ios-simulator/css3/blending/blend-mode-simple-expected.txt:
11:44 Changeset [179199] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
https://bugs.webkit.org/show_bug.cgi?id=140942

Reviewed by Alexey Proskuryakov.

The directory LayoutTests/platform/wk2 contains test expectations and test results that
are applicable to all WebKit2 ports. We should make use of this information when
running layout tests using iOS WebKit2.

Additionally, make use of the convenience function Port._wk2_port_name() for the name
of the WebKit2 port instead of directly using string concatenation.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.default_baseline_search_path):

11:41 Changeset [179198] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.4-branch/Source/WebKit2

Merge r179195. rdar://problem/19572685

11:39 Changeset [179197] by dino@apple.com
  • 12 edits in trunk

CSSKeyframesRule::findRule() and deleteRule() should delete the last matching rule, not the first
https://bugs.webkit.org/show_bug.cgi?id=139732

Patch by Sylvain Galineau <galineau@adobe.com> on 2015-01-26
Reviewed by Dean Jackson and Darin Adler.

Source/WebCore:

No new tests because existing tests have been updated to verify this behavior.

  • css/CSSKeyframeRule.h:

(WebCore::StyleKeyframe::getKeys): Deleted.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::keyframeStylesForAnimation): use StyleKeyframe::keys().

  • css/CSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::parseKeyString): Deleted. Moved to CSSParser.
(WebCore::StyleKeyframe::keyText): Build keyframe selector from Vector<double> representation.

  • css/CSSKeyframeRule.h:

(WebCore::StyleKeyframe::setKeyText): parse keyframe selector into Vector<double>.
(WebCore::StyleKeyframe::keys): Added. Returns vector representation of selector keys.
(WebCore::StyleKeyframe::getKeys): Deleted. Now keys().

  • css/CSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::findKeyframeIndex): Return last matching rule.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseKeyframeSelector): Added. Moved from StyleKeyframe.

  • css/CSSParser.h:

(WebCore::CSSParser::parseKeyframeSelector): Added. Moved from StyleKeyframe.

LayoutTests:

Update existing keyframes OM tests to check for findRule/deleteRule matching order i.e. find/delete last specified rule.

  • animations/keyframes-rule-expected.txt:
  • animations/keyframes-rule.html:
  • animations/unprefixed-keyframes-rule-expected.txt:
  • animations/unprefixed-keyframes-rule.html:
11:16 Changeset [179196] by cdumez@apple.com
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, rebaseline fast/css/css2-system-fonts.html on iOS.

Rebaseline fast/css/css2-system-fonts.html on iOS after r179168.

  • platform/ios-sim-deprecated/fast/css/css2-system-fonts-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/css2-system-fonts-expected.txt:
  • platform/ios-simulator/fast/css/css2-system-fonts-expected.txt: Removed.
11:12 Changeset [179195] by bdakin@apple.com
  • 2 edits in trunk/Source/WebKit2

Invoking an immediate action on link often dismisses selection
https://bugs.webkit.org/show_bug.cgi?id=140911
-and corresponding-
rdar://problem/19572685

Reviewed by Tim Horton.

Calling _page->setMaintainsInactiveSelection(false) in complete is often
too soon. Instead, call it in dismissContentRelativeChildWindows. This is more
similar to the timing for the TextIndicator.

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController dismissContentRelativeChildWindows]):
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WKImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):

11:08 Changeset [179194] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.

  • tools/sync-with-buildbot.py:

(find_request_updates):

10:44 Changeset [179193] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.

Rubber-stamped by Anders Carlsson.

  • WebView/WebView.h: Added forward declarations of the protocols.
10:29 Changeset [179192] by ggaren@apple.com
  • 41 edits
    5 deletes in trunk/Source

Use FastMalloc (bmalloc) instead of BlockAllocator for GC pages
https://bugs.webkit.org/show_bug.cgi?id=140900

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Removes some more custom allocation code.

Looks like a speedup. (See results attached to bugzilla.)

Will hopefully reduce memory use by improving sharing between the GC and
malloc heaps.

  • heap/BlockAllocator.cpp: Removed.
  • heap/BlockAllocator.h: Removed. No need for a custom allocator anymore.
  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::CodeBlockSet):

  • heap/CodeBlockSet.h: Feed the compiler.
  • heap/CopiedBlock.h:

(JSC::CopiedBlock::createNoZeroFill):
(JSC::CopiedBlock::create):
(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::isOversize):
(JSC::CopiedBlock::payloadEnd):
(JSC::CopiedBlock::capacity):

  • heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes): Each copied block now tracks its
own size, since we can't rely on Region to tell us our size anymore.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::~CopiedSpace):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocateOversize):

  • heap/CopiedSpaceInlines.h:

(JSC::CopiedSpace::recycleEvacuatedBlock):
(JSC::CopiedSpace::recycleBorrowedBlock):
(JSC::CopiedSpace::allocateBlockForCopyingPhase):
(JSC::CopiedSpace::allocateBlock):
(JSC::CopiedSpace::startedCopying): Deallocate blocks directly, rather
than pushing them onto the block allocator's free list; the block
allocator doesn't exist anymore.

  • heap/CopyWorkList.h:

(JSC::CopyWorkListSegment::create):
(JSC::CopyWorkListSegment::CopyWorkListSegment):
(JSC::CopyWorkList::~CopyWorkList):
(JSC::CopyWorkList::append):
(JSC::CopyWorkList::CopyWorkList): Deleted.

  • heap/GCSegmentedArray.h:

(JSC::GCArraySegment::GCArraySegment):

  • heap/GCSegmentedArrayInlines.h:

(JSC::GCSegmentedArray<T>::GCSegmentedArray):
(JSC::GCSegmentedArray<T>::~GCSegmentedArray):
(JSC::GCSegmentedArray<T>::clear):
(JSC::GCSegmentedArray<T>::expand):
(JSC::GCSegmentedArray<T>::refill):
(JSC::GCArraySegment<T>::create):

  • heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::GCThreadSharedData):

  • heap/GCThreadSharedData.h: Feed the compiler.
  • heap/HandleBlock.h:
  • heap/HandleBlockInlines.h:

(JSC::HandleBlock::create):
(JSC::HandleBlock::HandleBlock):
(JSC::HandleBlock::payloadEnd):

  • heap/HandleSet.cpp:

(JSC::HandleSet::~HandleSet):
(JSC::HandleSet::grow): Same as above.

  • heap/Heap.cpp:

(JSC::Heap::Heap):

  • heap/Heap.h: Removed the block allocator since it is unused now.
  • heap/HeapBlock.h:

(JSC::HeapBlock::destroy):
(JSC::HeapBlock::HeapBlock):
(JSC::HeapBlock::region): Deleted. Removed the Region pointer from each
HeapBlock since a HeapBlock is just a normal allocation now.

  • heap/HeapInlines.h:

(JSC::Heap::blockAllocator): Deleted.

  • heap/HeapTimer.cpp:
  • heap/MarkStack.cpp:

(JSC::MarkStackArray::MarkStackArray):

  • heap/MarkStack.h: Feed the compiler.
  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateBlock): No need to use a custom code path
based on size, since we use a general purpose allocator now.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::create):
(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::capacity): Track block size explicitly, like CopiedBlock.

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::freeBlock):

  • heap/MarkedSpace.h:
  • heap/Region.h: Removed.
  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::SlotVisitor): Removed reference to block allocator.

  • heap/SuperRegion.cpp: Removed.
  • heap/SuperRegion.h: Removed.
  • heap/WeakBlock.cpp:

(JSC::WeakBlock::create):
(JSC::WeakBlock::WeakBlock):

  • heap/WeakBlock.h:
  • heap/WeakSet.cpp:

(JSC::WeakSet::~WeakSet):
(JSC::WeakSet::addAllocator):
(JSC::WeakSet::removeAllocator): Removed reference to block allocator.

Source/WebCore:

  • platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::install): Be sure to release other
memory after GC and not before, since GC might contribute to free
malloc pages now.

Source/WTF:

New interface for aligned allocation: fastAlignedMalloc / fastAlignedFree.
We require a special function call on free because Windows.

  • wtf/FastMalloc.cpp:

(WTF::fastAlignedMalloc):
(WTF::fastAlignedFree): Do it.

(WTF::do_memalign): Un-ifdef this, since we use it now.

  • wtf/FastMalloc.h: Make our new function names visible like the rest

of fastMalloc.

10:24 Changeset [179191] by ap@apple.com
  • 3 edits in trunk/LayoutTests

<rdar://problem/16801814> Media controls do not appear in 2 DRT tests

This doesn't appear to happen any more, although the tests are still flaky due to
flaky font metrics.

  • platform/mac/TestExpectations:
  • platform/mac/media/controls-without-preload-expected.txt:
10:22 Changeset [179190] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Win] Disable FTL stress tests
https://bugs.webkit.org/show_bug.cgi?id=140932

Reviewed by Brent Fulgham.

  • Scripts/run-javascriptcore-tests:
10:15 Changeset [179189] by cdumez@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed. Rebaseline several editing tests on Mac after r179168.

  • platform/mac/editing/attributed-string/font-size-expected.txt:
  • platform/mac/editing/attributed-string/vertical-align-expected.txt:
09:28 Changeset [179188] by bfulgham@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Unskip tests now that r179170 is in place.

  • platform/win/TestExpectations:
09:13 Changeset [179187] by ossy@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[ARM] Typo fix after r176083
https://bugs.webkit.org/show_bug.cgi?id=140937

Reviewed by Anders Carlsson.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::ldrh):

09:05 Changeset [179186] by bfulgham@apple.com
  • 3 edits
    1 add in trunk/LayoutTests

[Win] Adjust some expectations based on test bot display metrics.

  • platform/win/TestExpectations:
  • platform/win/fast/dom/adopt-node-crash-2-expected.txt:
  • platform/win/fast/ondrop-text-html-expected.txt: Added.
09:01 Changeset [179185] by zalan@apple.com
  • 4 edits in trunk/Source/WebCore

Simple line layout: Make FlowContents an iterator class.
https://bugs.webkit.org/show_bug.cgi?id=140909

Reviewed by Antti Koivisto.

This patch transfers content position handling from createLineRuns()/LineState to
FlowContents. FlowContents becomes a real iterator class.
It tightens content and position information so that we can start supporting
no textual content such as <br>.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::LineState::commitAndCreateRun): Remove redundant committedLogicalRight.
(WebCore::SimpleLineLayout::LineState::addUncommitted): Now that we don't have current
positon in LineState, we need to be able to figure out where we start the uncommitted content.
This is mainly relevant after collapsed whitespace, when we start a new uncommitted segment.
It was previously achieved through LineState::jumpTo().
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::firstFragment): Return the first fragment for this line.
(WebCore::SimpleLineLayout::createLineRuns): Renaming and removing position handling.
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns): Renaming.
(WebCore::SimpleLineLayout::createTextRuns):
(WebCore::SimpleLineLayout::LineState::jumpTo): Deleted.
(WebCore::SimpleLineLayout::initializeNewLine): Deleted. : Move overflow fragment functionality
to firstFragment().

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::nextTextFragment):

  • rendering/SimpleLineLayoutFlowContents.h:
09:00 Changeset [179184] by dbates@webkit.org
  • 6 edits in trunk/Websites/webkit.org

Update Xcode requirement and add instructions to build, run, and debug WebKit for iOS Simulator

Reviewed by David Kilzer.

  • building/build.html: Added instructions to build WebKit for iOS Simulator.
  • building/debug.html: Added some instructions to debug the UIProcess and WebProcess

in the iOS Simulator using command line tools. We should look to add Xcode instructions
and simplify these steps once we teach debug-safari about the iOS Simulator.

  • building/run.html: Added remark to run Safari in the iOS Simulator.
  • building/tools.html: Require Xcode 6.1.1 (for the iOS 8.1 SDK) to build for iOS Simulator.
  • css/main.css: Define the .ios-instructions class with the same style as other .*-instructions classes.
08:17 Changeset [179183] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit/mac

Make it easy to test enabling formal delegate protocols
https://bugs.webkit.org/show_bug.cgi?id=140892

Reviewed by Dan Bernstein.

Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.

  • Misc/WebDownload.h:
  • WebView/WebFrameLoadDelegate.h:
  • WebView/WebPolicyDelegate.h:
  • WebView/WebResourceLoadDelegate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.h:
08:10 Changeset [179182] by carlosgc@webkit.org
  • 6 edits in trunk/Source/WebKit2

REGRESSION(r166975): [GTK] Page overlays are not drawn anymore after r166975
https://bugs.webkit.org/show_bug.cgi?id=131433

Reviewed by Žan Doberšek.

Implement page overlays for the GTK+ port.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

Override pure virtual setViewOverlayRootLayer().

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display): Remove FIXME and use modern
for loop.
(WebKit::DrawingAreaImpl::attachViewOverlayGraphicsLayer): Remove
ifdefs and use LayerTreeHost::setViewOverlayRootLayer().

  • WebProcess/WebPage/LayerTreeHost.h: Add pure virtual setViewOverlayRootLayer().
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::LayerTreeHostGtk): Initialize m_viewOverlayRootLayer.
(WebKit::LayerTreeHostGtk::initialize): Remove FIXME.
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplay):
Remove unused old page overlays code.
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplayInRect): Ditto.
(WebKit::LayerTreeHostGtk::sizeDidChange): Ditto.
(WebKit::LayerTreeHostGtk::paintContents): Remove FIXME.
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges): Flush
compositing state on m_pageOverlayLayers if present.
(WebKit::LayerTreeHostGtk::setViewOverlayRootLayer): Set m_pageOverlayLayers.
(WebKit::LayerTreeHostGtk::createPageOverlayLayer): Deleted.
(WebKit::LayerTreeHostGtk::destroyPageOverlayLayer): Deleted.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h: Remove unused old

page overlays code.

07:59 Changeset [179181] by cdumez@apple.com
  • 9 edits in trunk

HTMLElement.dir should only return known values
https://bugs.webkit.org/show_bug.cgi?id=140925

Reviewed by Darin Adler.

Source/WebCore:

HTMLElement.dir should only return known values according to the HTML
specification:
https://html.spec.whatwg.org/multipage/dom.html#dom-document-dir

Chrome and Firefox 28 match the specification. IE11's behavior is
slightly different:

  • When setting an unknown 'dir' value, an exception will be thrown.
  • Setting a known 'dir' value in a non-canonical case (e.g. "RTL"), the value will be directly converted to its canonical form (e.g. "rtl") before updating the DOM tree. (close to the spec but changing the case upon setting).

This patch is based on the following Blink revision by me:
https://src.chromium.org/viewvc/blink?view=rev&revision=171861

Test: fast/dom/document-dir-property.html

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir):
(WebCore::HTMLDocument::setDir):

  • html/HTMLDocument.h:
  • html/HTMLElement.cpp:

(WebCore::toValidDirValue):
(WebCore::HTMLElement::dir):
(WebCore::HTMLElement::setDir):

  • html/HTMLElement.h:
  • html/HTMLElement.idl:

LayoutTests:

Update fast/dom/document-dir-property.html to make sure HTMLDocument.dir
and HTMLElement.dir only return known values, as per the HTML
specification.

  • fast/dom/document-dir-property-expected.txt:
  • fast/dom/document-dir-property.html:
07:32 Changeset [179180] by dbates@webkit.org
  • 2 edits in trunk/Tools

REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
https://bugs.webkit.org/show_bug.cgi?id=140939

Reviewed by Eric Carlson.

Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."

  • Scripts/webkitdirs.pm:

(hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
and define a function called wanted.

07:16 Changeset [179179] by dbates@webkit.org
  • 2 edits in trunk/Tools

Teach run-webkit-app --simulator how to install custom built app
https://bugs.webkit.org/show_bug.cgi?id=140691

Fix inadvertent omission of directory test flag in expression to check for the
existence of the iOS simulator device-specific directory for user installed apps.

  • Scripts/webkitdirs.pm:

(hasUserInstalledAppInSimulatorDevice):

06:12 Changeset [179178] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] AX: Update test expectations for test related with AXRole.
https://bugs.webkit.org/show_bug.cgi?id=140933

Unreviewed EFL gardening.

roles-exposed.html's test expectation changed: for specified elements
AXRole value should NOT be equal AXUnknown but AXStatic because for ATK
version 2.15.2 there is new ATK_ROLE_STATIC role which should be used
instead of ATK_ROLE_UNKNOWN.

Patch by Michal Poteralski <m.poteralski@samsung.com> on 2015-01-27

  • platform/efl/accessibility/roles-exposed-expected.txt:
01:40 Changeset [179177] by ossy@webkit.org
  • 2 edits in trunk/PerformanceTests/SunSpider

[Win] JSC profiler tests asserts in debug mode
https://bugs.webkit.org/show_bug.cgi?id=140931

Unreviewed gardening, skip failing tests.

  • profiler-test.yaml:
01:26 Changeset [179176] by ossy@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[Win] Unreviewed gardening, skip failing tests.

  • tests/exceptionFuzz.yaml: Skip exception fuzz tests due to bug140928.
  • tests/mozilla/mozilla-tests.yaml: Skip ecma/Date/15.9.5.28-1.js due to bug140927.
00:19 Changeset [179175] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Remove remaining PLUGIN_ARCHITECTURE(WIN) code blocks from WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=140912

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-01-27
Reviewed by Anders Carlsson.

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):

  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

01/26/15:

23:40 Changeset [179174] by cdumez@apple.com
  • 5 edits in trunk/LayoutTests

Unreviewed, rebaseline several CSS tests after r179168.

Computed line-height is no longer 'normal' but the font's line
spacing.

  • fast/css/font-shorthand-line-height-expected.txt:
  • fast/css/font-shorthand-line-height.html:
  • platform/mac-mavericks/fast/css/css2-system-fonts-expected.txt:
  • platform/mac/fast/css/css2-system-fonts-expected.txt:
23:30 Changeset [179173] by bfulgham@apple.com
  • 7 edits
    26 adds in trunk/LayoutTests

[Win] Unskipping more tests after correcting baselines for Windows widgets.

  • platform/win/TestExpectations:
  • platform/win/fast/events/context-no-deselect-expected.png: Added.
  • platform/win/fast/events/context-no-deselect-expected.txt: Added.
  • platform/win/fast/events/dropzone-005-expected.txt: Added.
  • platform/win/fast/events/ime-composition-events-001-expected.txt:
  • platform/win/fast/events/key-events-in-input-button-expected.txt: Added.
  • platform/win/fast/events/mouseup-from-button2-expected.txt: Added.
  • platform/win/fast/flexbox: Added.
  • platform/win/fast/flexbox/clear-overflow-before-scroll-update-expected.txt: Added.
  • platform/win/fast/frames/flattening: Added.
  • platform/win/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
  • platform/win/fast/multicol/client-rects-expected.png: Added.
  • platform/win/fast/multicol/client-rects-expected.txt: Added.
  • platform/win/fast/multicol/client-rects-spanners-complex-expected.png: Added.
  • platform/win/fast/multicol/client-rects-spanners-complex-expected.txt: Added.
  • platform/win/fast/multicol/client-rects-spanners-expected.png: Added.
  • platform/win/fast/multicol/client-rects-spanners-expected.txt: Added.
  • platform/win/fast/multicol/newmulticol: Added.
  • platform/win/fast/multicol/newmulticol/client-rects-expected.png: Added.
  • platform/win/fast/multicol/newmulticol/client-rects-expected.txt: Added.
  • platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/win/fast/overflow/scrollRevealButton-expected.txt:
  • platform/win/fast/parser/bad-xml-slash-expected.txt: Added.
  • platform/win/fast/parser/document-write-option-expected.txt: Added.
  • platform/win/fast/repaint/control-clip-expected.txt:
  • platform/win/fast/replaced/object-with-embed-url-param-expected.txt: Added.
  • platform/win/fast/replaced/replaced-breaking-expected.txt: Added.
  • platform/win/fast/replaced/replaced-breaking-mixture-expected.txt: Added.
  • platform/win/fast/replaced/width100percent-button-expected.txt:
  • platform/win/fast/replaced/width100percent-checkbox-expected.txt: Added.
  • platform/win/fast/replaced/width100percent-menulist-expected.txt: Added.
  • platform/win/fast/replaced/width100percent-radio-expected.txt: Added.
23:05 Changeset [179172] by cdumez@apple.com
  • 16 edits in trunk/Source/WebCore

Introduce Document::body() for call sites interested in the <body> element
https://bugs.webkit.org/show_bug.cgi?id=140920

Reviewed by Darin Adler.

Introduce Document::body() method for call sites interested only in the
document's <body> element (not the <frameset>). Also clean up the call
sites of Document::bodyOrFrameset() to cache the return value when
suitable as this method does a tree traversal.

This patch does not change behavior, it merely ports calls sites that
were calling Document::bodyOrFrameset() then checking if the tag was
<body>, to call Document::body() instead. Doing so is more efficient
and clearer.

22:32 Changeset [179171] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Apply feTurbulence spec change to fix zero length vector generation
https://bugs.webkit.org/show_bug.cgi?id=140812
.:

Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2015-01-26
Reviewed by Darin Adler.

Recently a bug with the turbulence algorithm was corrected in the
Filter Effects specification.
For some seed values this bug allowed zero length vectors to be generated.
This resulted in large solid color squares being present in the generated image.
The feTurbulence algorithm was updated to reject zero length vectors. This patch
applies that change in WebCore.

Test: svg/filters/feTurbulence_bad_seeds.html

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::initPaint):
Added rejection sampling during vector generation to avoid zero length vectors.

LayoutTests:

Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2015-01-26
Reviewed by Darin Adler.

Ref test that generates a turbulence image which is then coloured black
and alpha min/maxxed (>0 becomes 1, 0 stays zero). This allows holes
caused by zero length vectors to be easily identified.

  • svg/filters/feTurbulence_bad_seeds-expected.html: Added.
  • svg/filters/feTurbulence_bad_seeds.html: Added.
22:24 Changeset [179170] by bfulgham@apple.com
  • 16 edits in trunk

[Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
https://bugs.webkit.org/show_bug.cgi?id=87426
<rdar://problem/11527899>

Reviewed by Darin Adler.

Source/WebCore:

Revise COMPtr to work better with our HashMap implementation:
(1) Add a specialization for IsSmartPtr.
(2) Remove PtrHash specialization.
(3) Refresh HashTrails specialization for COMPtr to match what we
do for RefPtr.

  • platform/win/COMPtr.h:

Source/WebKit/win:

Revise COMPtr to work better with our HashMap implementation. Use
modern loop syntax.

  • WebHistory.cpp:

(WebHistory::visitedURL): Adjust for new COMPtr changes.

  • WebPreferences.cpp:

(WebPreferences::getInstanceForIdentifier): Ditto.
(WebPreferences::removeReferenceForIdentifier): Ditto.

  • WebView.cpp:

(WebView::setEditable): Ditto.

Source/WTF:

Revise internal containers to use std::addressof in preference to
to using the '&' operator.

  • wtf/Deque.h:

(WTF::inlineCapacity>::append):
(WTF::inlineCapacity>::prepend):
(WTF::inlineCapacity>::removeFirst):
(WTF::inlineCapacity>::removeLast):
(WTF::inlineCapacity>::remove):
(WTF::inlineCapacity>::after):
(WTF::inlineCapacity>::before):

  • wtf/GetPtr.h:
  • wtf/HashTable.h:

(WTF::HashTableBucketInitializer<false>::initialize):

  • wtf/HashTraits.h:

(WTF::SimpleClassHashTraits::constructDeletedValue):
(WTF::CustomHashTraits::constructDeletedValue):

  • wtf/ListHashSet.h:

(WTF::ListHashSetConstIterator::get):

  • wtf/Vector.h:

(WTF::Vector::swap):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::insert):

Tools:

Revise COMPtr to work better with our HashMap implementation. Use
modern loop syntax.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::winNotificationReceived):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dumpBackForwardListForAllWindows):

22:14 Changeset [179169] by ossy@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Enable JSC stress tests by default
https://bugs.webkit.org/show_bug.cgi?id=128307

Unreviewed typo fix after r179165.

  • tests/mozilla/mozilla-tests.yaml:
22:12 Changeset [179168] by dino@apple.com
  • 36 edits in trunk

The computed value of line-height:normal is incorrect
https://bugs.webkit.org/show_bug.cgi?id=133744

Patch by Sylvain Galineau <galineau@adobe.com> on 2015-01-26
Reviewed by Dean Jackson.

Source/WebCore:

Use font's line spacing as computed line-height value when specified value is 'normal'.
This behavior is compatible with all other engines.

No new tests; all existing tests are updated to reflect the new computed value.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::lineHeightFromStyle): If line-height wasn't set, use the font's line spacing (same as Blink).

LayoutTests:

line-height:normal now computes to a length value.
This patch updates the tests to reflect the new computed value, as needed.

  • css3/calc/line-height-expected.txt:
  • editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt:
  • fast/css/font-calculated-value-expected.txt:
  • fast/css/font-calculated-value.html:
  • fast/css/font-shorthand-from-longhands-expected.txt:
  • fast/css/font-shorthand-from-longhands.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-font-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/script-tests/computed-style-font.js:
  • fast/css/line-height-text-autosizing-expected.txt:
  • fast/css/line-height-text-autosizing.html:
  • fast/ruby/ruby-line-height-expected.txt:
  • fast/ruby/script-tests/ruby-line-height.js:
  • media/track/track-cue-rendering-on-resize-expected.txt:
  • media/track/track-cue-rendering-on-resize.html:
  • platform/mac-mavericks/platform/mac/editing/attributed-string/anchor-element-expected.txt:
  • platform/mac-mavericks/platform/mac/editing/attributed-string/basic-expected.txt:
  • platform/mac-mavericks/platform/mac/editing/attributed-string/font-size-expected.txt:
  • platform/mac-mavericks/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt:
  • platform/mac-mavericks/platform/mac/editing/attributed-string/font-weight-expected.txt:
  • platform/mac-mavericks/platform/mac/editing/attributed-string/letter-spacing-expected.txt:
  • platform/mac-mavericks/platform/mac/editing/attributed-string/text-decorations-expected.txt:
  • platform/mac-mavericks/platform/mac/editing/attributed-string/vertical-align-expected.txt:
  • platform/mac/editing/attributed-string/anchor-element-expected.txt:
  • platform/mac/editing/attributed-string/basic-expected.txt:
  • platform/mac/editing/attributed-string/font-size-expected.txt:
  • platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt:
  • platform/mac/editing/attributed-string/font-weight-expected.txt:
  • platform/mac/editing/attributed-string/letter-spacing-expected.txt:
  • platform/mac/editing/attributed-string/text-decorations-expected.txt:
  • platform/mac/editing/attributed-string/vertical-align-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
22:04 Changeset [179167] by bfulgham@apple.com
  • 4 edits
    14 adds
    1 delete in trunk/LayoutTests

[Win] Windows gardening (removing more skips).

  • platform/win/TestExpectations:
  • platform/win/fast/block/basic/011-expected.png: Added.
  • platform/win/fast/block/basic/011-expected.txt: Added.
  • platform/win/fast/block/float/overhanging-tall-block-expected.png: Added.
  • platform/win/fast/block/float/overhanging-tall-block-expected.txt: Added.
  • platform/win/fast/borders/bidi-002-expected.png: Added.
  • platform/win/fast/borders/bidi-002-expected.txt: Added.
  • platform/win/fast/borders/bidi-009a-expected.png: Added.
  • platform/win/fast/borders/bidi-009a-expected.txt: Added.
  • platform/win/fast/borders/border-fit-expected.txt: Added.
  • platform/win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
  • platform/win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Added.
  • platform/win/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Removed property svn:executable.
  • platform/win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Removed property svn:executable.
  • platform/win/fast/dom/HTMLTableColElement: Added.
  • platform/win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
  • platform/win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
  • platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
21:54 Changeset [179166] by cdumez@apple.com
  • 6 edits in trunk

Document.dir should reflect the 'dir' attribute of the root html element
https://bugs.webkit.org/show_bug.cgi?id=140922

Reviewed by Darin Adler.

Source/WebCore:

Document.dir should reflect the 'dir' content attribute of the root
<html> element as per the specification:
https://html.spec.whatwg.org/multipage/dom.html#dom-document-dir

Previously, WebKit was reflecting the 'dir' content attribute of the
body element. This patch aligns WebKit with the specification and the
behavior of other browsers (tested Firefox 28, IE11 and Chrome).

This patch is based on the following Blink revision by me:
https://src.chromium.org/viewvc/blink?revision=171734&view=revision

Test: fast/dom/document-dir-property.html

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir):
(WebCore::HTMLDocument::setDir):

  • html/HTMLDocument.h:

LayoutTests:

Update fast/dom/document-dir-property.html to reflect the behavior
change.

  • fast/dom/document-dir-property-expected.txt:
  • fast/dom/document-dir-property.html:
21:01 Changeset [179165] by ossy@webkit.org
  • 8 edits in trunk

[Win] Enable JSC stress tests by default
https://bugs.webkit.org/show_bug.cgi?id=128307

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

  • tests/mozilla/mozilla-tests.yaml: Skipped on Windows.
  • tests/stress/ftl-arithcos.js: Skipped on Windows.

Tools:

  • Scripts/run-javascriptcore-tests:

LayoutTests:

  • js/script-tests/date-constructor.js: Skipped on Windows.
  • js/script-tests/sort-stability.js: Skipped on Windows.
20:50 Changeset [179164] by lforschler@apple.com
  • 8 edits
    4 copies in branches/safari-600.1.4.15-branch/Source

Merged r177328. rdar://problem/19445865

20:39 Changeset [179163] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r179101): SVGUseElement::expandUseElementsInShadowTree has an object lifetime mistake
https://bugs.webkit.org/show_bug.cgi?id=140921

Reviewed by Alexey Proskuryakov.

Bug found by running regression tests with Address Sanitizer.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::expandUseElementsInShadowTree): Use a Ref to protect
the original use element after it's been replaced in the tree; we use it for
one more thing after that.

20:06 Changeset [179162] by dbates@webkit.org
  • 4 edits in trunk/Tools

[iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
arguments for build and test scripts
https://bugs.webkit.org/show_bug.cgi?id=139748

Patch by Simon Fraser <simon.fraser@apple.com> on 2015-01-26
Reviewed by Daniel Bates.

There was much confusion resulting from the multitude of aliases used to build/test for
the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
tests directory.

This fixes an issue where run-api-tests and some other scripts failed when run with
--simulator.

  • Scripts/build-webkit:
  • Scripts/package-root:

(usage):

  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(determineXcodeSDK):

  • Scripts/webkitpy/port/factory.py:

(platform_options):

18:39 Changeset [179161] by simon.fraser@apple.com
  • 2 edits in trunk

[iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
https://bugs.webkit.org/show_bug.cgi?id=140203
rdar://problem/19198492

Reviewed by Sam Weinig.
Source/WebKit2:

When handling the OwnerWasInvalidated case in -[WKWebView evaluateJavaScript:completionHandler:],
the block passed to dispatch_async() needs to be retained. Fix by passing the RefPtr
to the lambda.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView evaluateJavaScript:completionHandler:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.

(TEST):

18:39 Changeset [179160] by simon.fraser@apple.com
  • 2 edits
    1 add in trunk

Need a short description (OOPS!).
Need the bug URL (OOPS!).

Reviewed by NOBODY (OOPS!).

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView evaluateJavaScript:completionHandler:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.

(TEST):

17:14 Changeset [179159] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Parse a function expression as a primary expression
https://bugs.webkit.org/show_bug.cgi?id=140908

Reviewed by Mark Lam.

Moved the code to generate an AST node for a function expression from parseMemberExpression
to parsePrimaryExpression to match the ES6 specification terminology:
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-primary-expression

There should be no behavior change from this change since parsePrimaryExpression is only
called in parseMemberExpression other than the fact failIfStackOverflow() is called.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):

16:55 Changeset [179158] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

WebGL 2.0: Actually allow for experimental-webgl2 context creation.

https://bugs.webkit.org/show_bug.cgi?id=140906
<rdar://problem/19606875>.

Reviewed by Brent Fulgham.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::is3dType): Include experimental-webgl2 in the list of acceptable 3d context types.
16:26 Changeset [179157] by cdumez@apple.com
  • 34 edits in trunk/Source

Rename Document::body() to Document::bodyOrFrameset() for clarity
https://bugs.webkit.org/show_bug.cgi?id=140902

Reviewed by Andreas Kling.

Rename Document::body() to Document::bodyOrFrameset() for clarity. This
method does not necessarily return an HTMLBodyElement, it can also
return a frameset as per the specification:
http://www.w3.org/TR/html5/dom.html#dom-tree-accessors

This method is often misused internally (the caller is only interested
in the <body> element). I will fix these instances in a follow-up patch,
this patch is only renaming mechanically.

16:19 Changeset [179156] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.4-branch/Source/WebKit2

Merge r179087. rdar://problem/19571057

16:19 Changeset [179155] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.4-branch/Source/WebCore

Merge r179086. rdar://problem/19566089

16:19 Changeset [179154] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.4-branch/Source/WebKit2

Merge r179023. rdar://problem/19573674

16:19 Changeset [179153] by matthew_hanson@apple.com
  • 10 edits in branches/safari-600.4-branch/Source

Merge r179014. rdar://problem/19573674

16:19 Changeset [179152] by matthew_hanson@apple.com
  • 4 edits in branches/safari-600.4-branch/Source

Merge r179013. rdar://problem/19571601

16:19 Changeset [179151] by matthew_hanson@apple.com
  • 6 edits in branches/safari-600.4-branch/Source

Merge r178938. rdar://problem/19558472

16:19 Changeset [179150] by matthew_hanson@apple.com
  • 4 edits in branches/safari-600.4-branch/Source

Merge r178858. rdar://problem/19540806

15:23 Changeset [179149] by bfulgham@apple.com
  • 2 edits in trunk/LayoutTests

[Win] More test gardening.

  • platform/win/TestExpectations:
15:20 Changeset [179148] by antti@apple.com
  • 5 edits in trunk/Source/WebKit2

Add a user default for disabling network cache
https://bugs.webkit.org/show_bug.cgi?id=140904

Reviewed by Andreas Kling

defaults write com.apple.Safari WebKitNetworkCacheEnabled -bool YES/NO

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::registerUserDefaultsIfNeeded):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):

14:59 Changeset [179147] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Fix Border-radius clipping issue on a composited descendants
Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=138551

Patch by Byungseon Shin <sun.shin@lge.com> on 2015-01-26
Reviewed by Simon Fraser.

Fix assertion in RenderLayerBacking::paintIntoLayer
by not checking out of sync with the GraphicsLayer heirarchy
in GraphicsLayerPaintChildClippingMask phase.

Test: compositing/clipping/border-radius-overflow-hidden-stacking-context.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

LayoutTests:

https://bugs.webkit.org/show_bug.cgi?id=138551

Patch by Byungseon Shin <sun.shin@lge.com> on 2015-01-26
Reviewed by Simon Fraser.

Ref test that clips composited descendant by stacking context with border-radius and overflow hidden element.

  • compositing/clipping/border-radius-overflow-hidden-stacking-context-expected.txt: Added.
  • compositing/clipping/border-radius-overflow-hidden-stacking-context.html: Added.
14:50 Changeset [179146] by ddkilzer@apple.com
  • 4 edits
    5 adds in branches/safari-600.1.4.15-branch

Merged r177927. rdar://problem/19565854

14:44 Changeset [179145] by cdumez@apple.com
  • 2 edits in trunk/Source/WebCore

Simplify RenderElement's shouldRepaintForImageAnimation()
https://bugs.webkit.org/show_bug.cgi?id=140890

Reviewed by Darin Adler.

Simplify RenderElement's shouldRepaintForImageAnimation() by
not calling rendererForRootBackground(). The previous code was
doing a null-check on Document::documentElement() but failing
to do a null-check on the renderer just after, which lead me
to refactor this code.

Instead of calling document().documentElement.renderer(), we
now call renderer.parent(). This is equivalent because we already
know that renderer.isBody() returns true. The parent of the <body>
has to be the <html> element, which has to be the documentElement.
There is also no need to do a null-check on renderer.parent(). We
already know that the <body> has a renderer (because |renderer| is
its renderer), thus its parent <html> element has to have a renderer
as well.

Finally, simply call !rootElement.hasBackground() instead of
rootElement.rendererForRootBackground() == &bodyRenderer to determine
if the background painted by the root. This is equivalent but more
efficient because:

  • We already know that the root renderer's is an <html> element. We can thus avoid the check in rendererForRootBackground().
  • We already have the <body>'s renderer so we don't need to do the DOM tree traversal in rendererForRootBackground() to get it.

No new tests, already covered by:
fast/images/animated-gif-body-delegated-background-image.html
fast/images/animated-gif-html-background-image.html

  • rendering/RenderElement.cpp:

(WebCore::shouldRepaintForImageAnimation):

14:40 Changeset [179144] by ddkilzer@apple.com
  • 4 edits
    2 adds in trunk/Tools

Add iOS EWS to build.webkit.org/dashboard
<http://webkit.org/b/140627>

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer): Add ios-ews queue info.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:

Add iOS8Device platform.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
iOS device logo.

14:36 Changeset [179143] by cdumez@apple.com
  • 80 edits in trunk/Source

First argument to DOM traversal functions should be a reference
https://bugs.webkit.org/show_bug.cgi?id=140895

Reviewed by Antti Koivisto.

First argument to DOM traversal functions should be a reference instead
of a pointer as it is dereferenced without null-check.

14:03 Changeset [179142] by roger_fong@apple.com
  • 6 edits in trunk/Source/WebCore

[WebGL2] Update IDL for WebGL2.
https://bugs.webkit.org/show_bug.cgi?id=126406
<rdar://problem/15002268>.

Reviewed by Brent Fulgham.

Update WebGL2RenderingContext idl to match spec. Create method stubs as necessary.

  • bindings/js/JSWebGL2RenderingContextCustom.cpp:

(WebCore::JSWebGL2RenderingContext::getFramebufferAttachmentParameter):
(WebCore::JSWebGL2RenderingContext::getInternalformatParameter):
(WebCore::JSWebGL2RenderingContext::getQueryParameter):
(WebCore::JSWebGL2RenderingContext::getSamplerParameter):
(WebCore::JSWebGL2RenderingContext::getSyncParameter):
(WebCore::JSWebGL2RenderingContext::getIndexedParameter):
(WebCore::JSWebGL2RenderingContext::getActiveUniformBlockParameter):
(WebCore::JSWebGL2RenderingContext::getActiveUniformBlockName):

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::copyBufferSubData):
(WebCore::WebGL2RenderingContext::getBufferSubData):
(WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGL2RenderingContext::blitFramebuffer):
(WebCore::WebGL2RenderingContext::framebufferTextureLayer):
(WebCore::WebGL2RenderingContext::getInternalformatParameter):
(WebCore::WebGL2RenderingContext::invalidateFramebuffer):
(WebCore::WebGL2RenderingContext::invalidateSubFramebuffer):
(WebCore::WebGL2RenderingContext::readBuffer):
(WebCore::WebGL2RenderingContext::renderbufferStorageMultisample):
(WebCore::WebGL2RenderingContext::texStorage2D):
(WebCore::WebGL2RenderingContext::texStorage3D):
(WebCore::WebGL2RenderingContext::texImage3D):
(WebCore::WebGL2RenderingContext::texSubImage3D):
(WebCore::WebGL2RenderingContext::copyTexSubImage3D):
(WebCore::WebGL2RenderingContext::compressedTexImage3D):
(WebCore::WebGL2RenderingContext::compressedTexSubImage3D):
(WebCore::WebGL2RenderingContext::getFragDataLocation):
(WebCore::WebGL2RenderingContext::uniform1ui):
(WebCore::WebGL2RenderingContext::uniform2ui):
(WebCore::WebGL2RenderingContext::uniform3ui):
(WebCore::WebGL2RenderingContext::uniform4ui):
(WebCore::WebGL2RenderingContext::uniform1uiv):
(WebCore::WebGL2RenderingContext::uniform2uiv):
(WebCore::WebGL2RenderingContext::uniform3uiv):
(WebCore::WebGL2RenderingContext::uniform4uiv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x3fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x3fv):
(WebCore::WebGL2RenderingContext::vertexAttribI4i):
(WebCore::WebGL2RenderingContext::vertexAttribI4iv):
(WebCore::WebGL2RenderingContext::vertexAttribI4ui):
(WebCore::WebGL2RenderingContext::vertexAttribI4uiv):
(WebCore::WebGL2RenderingContext::vertexAttribIPointer):
(WebCore::WebGL2RenderingContext::vertexAttribDivisor):
(WebCore::WebGL2RenderingContext::drawArraysInstanced):
(WebCore::WebGL2RenderingContext::drawElementsInstanced):
(WebCore::WebGL2RenderingContext::drawRangeElements):
(WebCore::WebGL2RenderingContext::drawBuffers):
(WebCore::WebGL2RenderingContext::clearBufferiv):
(WebCore::WebGL2RenderingContext::clearBufferuiv):
(WebCore::WebGL2RenderingContext::clearBufferfv):
(WebCore::WebGL2RenderingContext::clearBufferfi):
(WebCore::WebGL2RenderingContext::createQuery):
(WebCore::WebGL2RenderingContext::deleteQuery):
(WebCore::WebGL2RenderingContext::isQuery):
(WebCore::WebGL2RenderingContext::beginQuery):
(WebCore::WebGL2RenderingContext::endQuery):
(WebCore::WebGL2RenderingContext::getQuery):
(WebCore::WebGL2RenderingContext::getQueryParameter):
(WebCore::WebGL2RenderingContext::createSampler):
(WebCore::WebGL2RenderingContext::deleteSampler):
(WebCore::WebGL2RenderingContext::isSampler):
(WebCore::WebGL2RenderingContext::bindSampler):
(WebCore::WebGL2RenderingContext::samplerParameteri):
(WebCore::WebGL2RenderingContext::samplerParameterf):
(WebCore::WebGL2RenderingContext::getSamplerParameter):
(WebCore::WebGL2RenderingContext::fenceSync):
(WebCore::WebGL2RenderingContext::isSync):
(WebCore::WebGL2RenderingContext::deleteSync):
(WebCore::WebGL2RenderingContext::clientWaitSync):
(WebCore::WebGL2RenderingContext::waitSync):
(WebCore::WebGL2RenderingContext::getSyncParameter):
(WebCore::WebGL2RenderingContext::createTransformFeedback):
(WebCore::WebGL2RenderingContext::deleteTransformFeedback):
(WebCore::WebGL2RenderingContext::isTransformFeedback):
(WebCore::WebGL2RenderingContext::bindTransformFeedback):
(WebCore::WebGL2RenderingContext::beginTransformFeedback):
(WebCore::WebGL2RenderingContext::endTransformFeedback):
(WebCore::WebGL2RenderingContext::transformFeedbackVaryings):
(WebCore::WebGL2RenderingContext::getTransformFeedbackVarying):
(WebCore::WebGL2RenderingContext::pauseTransformFeedback):
(WebCore::WebGL2RenderingContext::resumeTransformFeedback):
(WebCore::WebGL2RenderingContext::bindBufferBase):
(WebCore::WebGL2RenderingContext::bindBufferRange):
(WebCore::WebGL2RenderingContext::getIndexedParameter):
(WebCore::WebGL2RenderingContext::getUniformIndices):
(WebCore::WebGL2RenderingContext::getActiveUniforms):
(WebCore::WebGL2RenderingContext::getUniformBlockIndex):
(WebCore::WebGL2RenderingContext::getActiveUniformBlockParameter):
(WebCore::WebGL2RenderingContext::getActiveUniformBlockName):
(WebCore::WebGL2RenderingContext::uniformBlockBinding):
(WebCore::WebGL2RenderingContext::createVertexArray):
(WebCore::WebGL2RenderingContext::deleteVertexArray):
(WebCore::WebGL2RenderingContext::isVertexArray):
(WebCore::WebGL2RenderingContext::bindVertexArray):

  • html/canvas/WebGL2RenderingContext.h:
  • html/canvas/WebGL2RenderingContext.idl:
  • platform/graphics/GraphicsTypes3D.h:
13:42 Changeset [179141] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Don't let the CSSValuePool's font family cache grow unbounded.
<https://webkit.org/b/140894>

Reviewed by Chris Dumez.

Darin pointed out to Chris who pointed out to me that the font family cache
in CSSValuePool can grow unbounded until we get a system memory pressure
notification. Put a limit on it like we did with the font face cache.

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

13:29 Changeset [179140] by ddkilzer@apple.com
  • 3 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r177404. rdar://problem/19419787

13:26 Changeset [179139] by ddkilzer@apple.com
  • 1 edit
    5 adds in branches/safari-600.1.4.15-branch/LayoutTests

Merged r177408. rdar://problem/19432686

13:26 Changeset [179138] by ddkilzer@apple.com
  • 38 edits in branches/safari-600.1.4.15-branch

Merged r177398. rdar://problem/19432686

12:57 Changeset [179137] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Plug leak in jsValueWithDictionaryInContext().
<https://webkit.org/b/140889>

Reviewed by Alexey Proskuryakov.

Add a missing JSStringRelease to plug leak that was showing up on leaks bot.

  • platform/mac/SerializedPlatformRepresentationMac.mm:

(WebCore::jsValueWithDictionaryInContext):

12:56 Changeset [179136] by fpizlo@apple.com
  • 2 edits in trunk/Tools

copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
https://bugs.webkit.org/show_bug.cgi?id=140896

Reviewed by Michael Saboff.

I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
makes our script do this.

Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
this would be harder given llvm's autoconf setup.

  • Scripts/copy-webkitlibraries-to-product-directory:
12:51 Changeset [179135] by ap@apple.com
  • 2 edits in trunk/Tools

Update bot assignments.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
12:41 Changeset [179134] by youenn.fablet@crf.canon.fr
  • 11 edits
    4 adds in trunk

Integrate WP python server into WebKit test framework
https://bugs.webkit.org/show_bug.cgi?id=127094

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Contains parameters of web platform test server.

  • resources/config.json: Added.

Tools:

This patch adds W3C web server (wptserver) as a new HTTP server.
wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.

Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockProcess.communicate):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.

(LayoutTestRunner.init):
(LayoutTestRunner.run_tests):
(LayoutTestRunner.start_servers):
(LayoutTestRunner.stop_servers):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.

(LayoutTestRunnerTests._run_tests):
(LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
(LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
(LayoutTestRunnerTests):
(LayoutTestRunnerTests.test_servers_started):

  • Scripts/webkitpy/layout_tests/controllers/manager.py: Updated to check whether a test is a wpt test and whether wpt server launch is needed.

(Manager.init):
(Manager._is_http_test):
(Manager._is_web_platform_test):
(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_needs_servers.get_wpt_doc_root):
(ManagerTest.test_needs_servers.get_manager):
(ManagerTest.test_needs_servers):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.

(parse_args):

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.

(main):

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.

(doc_root):
(base_url):
(WebPlatformTestServer):
(WebPlatformTestServer.init):
(WebPlatformTestServer._set_start_cmd):
(WebPlatformTestServer._copy_webkit_test_files):
(WebPlatformTestServer._clean_webkit_test_files):
(WebPlatformTestServer._prepare_config):
(WebPlatformTestServer._spawn_process):
(WebPlatformTestServer._stop_running_server):

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.

(TestWebPlatformTestServer):
(TestWebPlatformTestServer.test_start_cmd):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.to.start_web_platform_test_server):
(Port.to):
(Port.to.web_platform_test_server_doc_root):
(Port.to.web_platform_test_server_base_url):
(Port.to.stop_web_platform_test_server):

  • Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.

(Driver.init):
(Driver.is_web_platform_test):
(Driver.test_to_uri):
(Driver.uri_to_test):
(Driver._command_from_driver_input):

  • Scripts/webkitpy/port/driver_unittest.py: Updated tests according new conversion rules.

(DriverTest.test_test_to_uri):
(DriverTest.test_uri_to_test):

12:40 Changeset [179133] by ddkilzer@apple.com
  • 14 edits in branches/safari-600.1.4.15-branch

Merged r177377. rdar://problem/19419793

12:40 Changeset [179132] by benjamin@webkit.org
  • 15 edits
    32 adds in trunk

Fix CSS Selector's tag name matching when mixing HTML and XML
https://bugs.webkit.org/show_bug.cgi?id=140878

Reviewed by Darin Adler.

Source/WebCore:

Previsouly, WebKit was unable to match any XML element that had
any uppercase character if the stylesheet was in a HTML document.
This problem was most often reported due to the inability to style
SVG-in-HTML.

The reason was that the tag local name was incorrectly transformed
to lowercase at parsing time. Instead, we are supposed to only
do case-insensitive match for HTML elements in a HTML document.

This fix is very similar with how we handle attributes:
-Keep both the original and the lowercase versions of the name.
-When matching, chose which version to use depending on the element being matched.

There is one major difference in the way the names are stored.
Unlike attribute selectors, tag name selectors are common, and the uppercase
version is not that uncommon. I wanted to preserve the dense representation
so I specialized CSSSelector specifically for tag names.

To store the data, if the name is already lowercase, just use the m_data pointer
as usual.
If the name is not lowercase, allocate a new small structure in the union to store
both names.

Tests: fast/css/tagname-and-namespace-case-sensitivity-xml-in-html.html

fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml-expected.xhtml
fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml.xhtml
fast/css/tagname-case-sensitivity-svg-in-html.html
fast/css/tagname-case-sensitivity-svg-in-xhtml-expected.xhtml
fast/css/tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/css/tagname-case-sensitivity-xml-in-html.html
fast/css/tagname-case-sensitivity-xml-in-xhtml-expected.xhtml
fast/css/tagname-case-sensitivity-xml-in-xhtml.xhtml
fast/selectors/element-closest-tagname-case-sensitivity-svg-in-html.html
fast/selectors/element-closest-tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/selectors/element-matches-tagname-case-sensitivity-svg-in-html.html
fast/selectors/element-matches-tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/selectors/querySelector-tagname-case-sensitivity-svg-in-html.html
fast/selectors/querySelector-tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/selectors/querySelector-tagname-case-sensitivity-xml-in-html.html
fast/selectors/querySelector-tagname-case-sensitivity-xml-in-xhtml.xhtml
fast/selectors/tagname-adjacent-backtracking-case-sensitivity-html.html
fast/selectors/tagname-descendant-backtracking-case-sensitivity-html.html

  • css/CSSGrammar.y.in:

The parser is unaware of anything case related. CSSSelector takes care of that.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::createRareData):

  • css/CSSSelector.h:

(WebCore::CSSSelector::NameWithCase::NameWithCase):
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagQName):
(WebCore::CSSSelector::tagLowercaseLocalName):
The new representation stores both the original form and the lower case
form.

  • css/RuleSet.cpp:

(WebCore::RuleSet::addRule):
(WebCore::RuleSet::shrinkToFit):

  • css/RuleSet.h:

(WebCore::RuleSet::tagRules):

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRules):
The tag name partition is now split in two: lowercase and original case.
If the matched element is HTML, the lowercase partition is used.

  • css/SelectorFilter.cpp:

(WebCore::collectElementIdentifierHashes):
(WebCore::collectDescendantSelectorIdentifierHashes):
This is the most annoying part of the patch performance wise:
the bloom filter knows the case of the real elements but it cannot know
how selectors will match them.

To make it work, all names are now converted to lowercase.
That implies that we can filter less on XML and we may have to pay for
converting the tag name to lowercase.

I expect the performance hit to be small because:
-Having two XML elements with the same name but different case is uncommon.
-Most elements use lowercase names.

Still sad...that's the price to pay for correctness.

  • css/SelectorChecker.cpp:

(WebCore::tagMatches):
(WebCore::SelectorChecker::checkOne):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::tagMatches): Deleted.
Update the legacy matcher, nothing special.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment):
(WebCore::SelectorCompiler::TagNamePattern::TagNamePattern):
(WebCore::SelectorCompiler::constructFragmentsInternal):
(WebCore::SelectorCompiler::equalTagNames):
(WebCore::SelectorCompiler::equalTagNamePatterns):
(WebCore::SelectorCompiler::computeBacktrackingStartOffsetInChain):
(WebCore::SelectorCompiler::computeBacktrackingHeightFromDescendant):
(WebCore::SelectorCompiler::computeBacktrackingWidthFromIndirectAdjacent):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasTagName):
Tag names are used to optimize backtracking; this is quite common for descendant
(e.g. div > ul > li).
We have to differenciate one new case there: if two tag names are equal
when compared case-insensitively but strictly different, they may still
be equal if they don't match the same kind of elements or both matches
and HTML element.

  • dom/SelectorQuery.cpp:

(WebCore::localNameMatches):
(WebCore::elementsForLocalName):
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):
Update the inline versions of SelectorQuery.

LayoutTests:

We had very little coverage for XHTML and XML in HTML.
I added lots of new tests to cover the basics.

  • fast/dom/css-dom-read-2-expected.txt:
  • fast/dom/css-dom-read-expected.txt:

CSSOM now provide the tagname in the original case instead of lowercase,
which is actually what the spec defines:
"If the character is not handled by one of the above rules and is greater

than or equal to U+0080, is "-" (U+002D) or "_" (U+005F), or is in one
of the ranges [0-9] (U+0030 to U+0039), [A-Z] (U+0041 to U+005A),
or [a-z] (U+0061 to U+007A), then the character itself."

  • fast/css/tagname-and-namespace-case-sensitivity-xml-in-html-expected.html: Added.
  • fast/css/tagname-and-namespace-case-sensitivity-xml-in-html.html: Added.
  • fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml-expected.xhtml: Added.
  • fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml.xhtml: Added.
  • fast/css/tagname-case-sensitivity-svg-in-html-expected.html: Added.
  • fast/css/tagname-case-sensitivity-svg-in-html.html: Added.
  • fast/css/tagname-case-sensitivity-svg-in-xhtml-expected.xhtml: Added.
  • fast/css/tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
  • fast/css/tagname-case-sensitivity-xml-in-html-expected.html: Added.
  • fast/css/tagname-case-sensitivity-xml-in-html.html: Added.
  • fast/css/tagname-case-sensitivity-xml-in-xhtml-expected.xhtml: Added.
  • fast/css/tagname-case-sensitivity-xml-in-xhtml.xhtml: Added.
  • fast/selectors/element-closest-tagname-case-sensitivity-svg-in-html-expected.txt: Added.
  • fast/selectors/element-closest-tagname-case-sensitivity-svg-in-html.html: Added.
  • fast/selectors/element-closest-tagname-case-sensitivity-svg-in-xhtml-expected.txt: Added.
  • fast/selectors/element-closest-tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
  • fast/selectors/element-matches-tagname-case-sensitivity-svg-in-html-expected.txt: Added.
  • fast/selectors/element-matches-tagname-case-sensitivity-svg-in-html.html: Added.
  • fast/selectors/element-matches-tagname-case-sensitivity-svg-in-xhtml-expected.txt: Added.
  • fast/selectors/element-matches-tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
  • fast/selectors/querySelector-tagname-case-sensitivity-svg-in-html-expected.txt: Added.
  • fast/selectors/querySelector-tagname-case-sensitivity-svg-in-html.html: Added.
  • fast/selectors/querySelector-tagname-case-sensitivity-svg-in-xhtml-expected.txt: Added.
  • fast/selectors/querySelector-tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
  • fast/selectors/querySelector-tagname-case-sensitivity-xml-in-html-expected.txt: Added.
  • fast/selectors/querySelector-tagname-case-sensitivity-xml-in-html.html: Added.
  • fast/selectors/querySelector-tagname-case-sensitivity-xml-in-xhtml-expected.txt: Added.
  • fast/selectors/querySelector-tagname-case-sensitivity-xml-in-xhtml.xhtml: Added.
  • fast/selectors/tagname-adjacent-backtracking-case-sensitivity-html-expected.txt: Added.
  • fast/selectors/tagname-adjacent-backtracking-case-sensitivity-html.html: Added.
  • fast/selectors/tagname-descendant-backtracking-case-sensitivity-html-expected.txt: Added.
  • fast/selectors/tagname-descendant-backtracking-case-sensitivity-html.html: Added.
12:04 Changeset [179131] by cdumez@apple.com
  • 3 edits in trunk/Source/WebCore

Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value)
https://bugs.webkit.org/show_bug.cgi?id=140891

Reviewed by Anders Carlsson.

Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value)
to make sure the argument is not unexpectedly moved when it shouldn't (like I
experienced yesterday in Bug 140577):
<http://trac.webkit.org/changeset/179105>

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::create):

  • css/CSSValuePool.h:

(WebCore::CSSValuePool::createValue):

11:45 Changeset [179130] by dbates@webkit.org
  • 2 edits in trunk/Tools

Teach run-webkit-app --simulator how to install custom built app
https://bugs.webkit.org/show_bug.cgi?id=140691

Reviewed by David Kilzer.

We should teach run-webkit-app --simulator how to install a custom built app.

Currently run-webkit-app --simulator can only run a system app or an app that
was installed using the simctl command line tool. For convenience we should
teach run-webkit-app --simulator how to install a custom built app.

As a side effect of this change run-safari --simulator will install and run
a custom built of MobileSafari (if it exists).

  • Scripts/webkitdirs.pm:

(iOSSimulatorDevices): Added FIXME comment to decouple device representation in
Perl from the structure of the device.plist file.
(plistPathFromBundle): Fix if-statement condition so that we actually perform a
file system check to determine the plist path for a Mac app bundle.
(appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
it will complain that it cannot find the file: "Domain ... does not exist".
(appDisplayNameFromBundle): Ditto.
(waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
until a simulator device is the specified state.
(relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
(if it's open) before opening it again so as to ensure that the iOS Simulator boots
the specified device.
(quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
As implied by its name, this function will not return until the specified simulator
device UDID is in the shutdown state.
(iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
device with the specified UDID.
(isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
expression echo xcrun --sdk iphonesimulator --show-sdk-path/Applications/, contains a
symbolic link. Specifically, echo xcrun --sdk iphonesimulator --show-sdk-path returns
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
(hasUserInstalledAppInSimulatorDevice): Added.
(isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
"Booted" state.
(runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
switching between a system installed app and a custom built version of the same app (e.g.
custom build of MobileSafari) will erase all contents and settings in the simulator device.
(eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
as that was the only caller of this function.
(bootedIOSSimulatorDevice): Deleted.
(openIOSSimulator): Deleted.

11:44 Changeset [179129] by bdakin@apple.com
  • 6 edits in trunk/Source

Blacklist iBooks for WebKit's default immediate actions
https://bugs.webkit.org/show_bug.cgi?id=140854
-and corresponding-
rdar://problem/19489518

Reviewed by Tim Horton.

Source/WebCore:

Add a runtime check for iBooks.

  • WebCore.exp.in:
  • platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsIBooks):

  • platform/RuntimeApplicationChecks.h:

Source/WebKit2:

Blacklist iBooks.

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _updateImmediateActionItem]):

11:38 Changeset [179128] by ddkilzer@apple.com
  • 3 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r177360. rdar://problem/19432691

11:38 Changeset [179127] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176384. rdar://problem/19432691

11:38 Changeset [179126] by ddkilzer@apple.com
  • 11 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r172854. rdar://problem/19432691

10:33 Changeset [179125] by ddkilzer@apple.com
  • 6 edits
    6 adds in branches/safari-600.1.4.15-branch

Merged r177135. rdar://problem/19450110

10:33 Changeset [179124] by mmaxfield@apple.com
  • 8 edits in trunk/Source

[iOS] [SVG -> OTF Converter] Flip the switch off on iOS
https://bugs.webkit.org/show_bug.cgi?id=140860

Reviewed by Darin Adler.

Source/JavaScriptCore:

The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests because this simply reverts broken code.

The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)

  • Configurations/FeatureDefines.xcconfig:
10:31 Changeset [179123] by ap@apple.com
  • 2 edits in trunk/Tools

Update bot assignments.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
10:18 Changeset [179122] by ap@apple.com
  • 5 edits in trunk/Tools

Leaks bot shouldn't run JSC tests
https://bugs.webkit.org/show_bug.cgi?id=140877

Reviewed by Darin Adler.

Shaves off 48 minutes of time.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestLeaksFactory): Slim down the leaks queue.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.print_leaks_summary):

  • Scripts/webkitpy/port/mac.py:

(MacPort.print_leaks_summary):
Don't yell when leaks are detected.

10:03 Changeset [179121] by ossy@webkit.org
  • 2 edits in trunk

[cmake] Remove compiler version calculate cruft
https://bugs.webkit.org/show_bug.cgi?id=140885

Reviewed by Darin Adler.

  • Source/cmake/WebKitHelpers.cmake:
10:02 Changeset [179120] by ossy@webkit.org
  • 2 edits in trunk/Tools

Refactor run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=140824

Reviewed by Darin Adler.

Separated mozilla, stress test code paths and
determining skipped mozilla tests into subroutines.

  • Scripts/run-javascriptcore-tests:

(runMozillaTests):
(runJSCStressTests):
(defaultJsDriverArgsForMozillaTests):

09:52 Changeset [179119] by cdumez@apple.com
  • 4 edits in trunk/Source/WebCore

Demote 'line-height' to a low priority property.
https://bugs.webkit.org/show_bug.cgi?id=140817

Reviewed by Andreas Kling.

Our special handling of the 'line-height' property is no longer
required, since the 'font' shorthand is now expanded in the parser
in all cases (also for system fonts).

This patch is based on the following Blink revision:
https://src.chromium.org/viewvc/blink?revision=184629&view=revision

No new tests, already covered by:
fast/css/font-shorthand-line-height.html
fast/css/line-height-font-order.html

  • css/CSSPropertyNames.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::CascadedProperties::Property::apply):

  • css/StyleResolver.h:

(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::setLineHeightValue): Deleted.
(WebCore::StyleResolver::State::lineHeightValue): Deleted.

09:51 Changeset [179118] by ddkilzer@apple.com
  • 3 edits
    4 adds in branches/safari-600.1.4.15-branch

Merged r177292. rdar://problem/19419760

09:51 Changeset [179117] by ddkilzer@apple.com
  • 1 edit
    2 adds in branches/safari-600.1.4.15-branch/PerformanceTests

Merged r177051. rdar://problem/19419760

09:20 Changeset [179116] by ossy@webkit.org
  • 3 edits in trunk/Tools

[buildbot] Fix grammar of TestWithFailureCount
https://bugs.webkit.org/show_bug.cgi?id=140884

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestWithFailureCount):
(TestWithFailureCount.commandComplete):
(TestWithFailureCount.getText2):
(RunUnitTests):
(RunPythonTests):
(RunPerlTests):
(RunLLINTCLoopTests):
(Run32bitJSCTests):

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunLLINTCLoopTestsTest.test_failure):
(Run32bitJSCTestsTest.test_failure):
(RunUnitTestsTest.assertFailures):

08:25 Changeset [179115] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

AX: crash in accessibilityRootObjectWrapper method (WebPageAccessibilityObjectAtk.cpp)
<https://bugs.webkit.org/show_bug.cgi?id=140618>

Patch by Fabien Vallée <fvallee@connected-labs.com> on 2015-01-26
Reviewed by Chris Fleizach.

Check if document()->axObjectCache() is nullptr to fix the crash.
Similar patch has been applied on mac port:
<http://trac.webkit.org/changeset/167136>

Crash occured on <http://itv.mit-xperts.com/hbbtvtest/appmanager/>
(this page needs CEHTML / HbbTV extensions, conditions cannot
be reproduced using regression tests)

  • WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:

(accessibilityRootObjectWrapper):

07:51 Changeset [179114] by youenn.fablet@crf.canon.fr
  • 2 edits in trunk/Tools

Unreviewed. Moving myself to the committer section.

07:15 Changeset [179113] by ossy@webkit.org
  • 2 edits in trunk

[cmake] Stop compiling with -Wno-error=uninitialized and -Wno-error=literal-suffix
https://bugs.webkit.org/show_bug.cgi?id=140886

Reviewed by Žan Doberšek.

  • Source/cmake/WebKitHelpers.cmake:
05:49 Changeset [179112] by carlosgc@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Remove references to removed tests from GTK+ TestExpectations.

Shared workers are no longer supported and the layout tests were
removed.

  • platform/gtk/TestExpectations:
03:12 Changeset [179111] by commit-queue@webkit.org
  • 10 edits
    2 moves in trunk

[GTK] gtkdoc does not appear in DevHelp
https://bugs.webkit.org/show_bug.cgi?id=139369

.:

Patch by Michael Catanzaro <mcatanzaro@igalia.com> on 2015-01-26
Reviewed by Philippe Normand.

Expect the gtkdoc to be generated in folders named with the API version.

  • Source/PlatformGTK.cmake:

Source/WebCore:

Patch by Michael Catanzaro <mcatanzaro@igalia.com> on 2015-01-26
Reviewed by Philippe Normand.

  • PlatformGTK.cmake: Include the API version in the gtkdoc filenames.

Source/WebKit2:

Patch by Michael Catanzaro <mcatanzaro@igalia.com> on 2015-01-26
Reviewed by Philippe Normand.

  • PlatformGTK.cmake: Include the API version in the gtkdoc filenames.
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt.
  • UIProcess/API/gtk/docs/webkit2gtk-4.0.types: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk.types.

Tools:

Patch by Michael Catanzaro <mcatanzaro@igalia.com> and Carlos Garcia Campos <cgarcia@igalia.com> on 2015-01-26
Reviewed by Philippe Normand.

  • gtk/generate-gtkdoc: Create the generators in the main function

and use them to get the local cross renference dependencies. Also
pass the generator module name to webkitdom.write_doc_files().
(get_gtkdoc_module_paths): Receive a list of local cross reference
dependencies.
(get_generator_for_config): Set the main_sgml_file property of the
GtkDoc object from the configuration file.
(generate_documentation): Generate the documentation for the given
generator.
(generate_documentation_for_config): Deleted.

  • gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
  • gtk/webkitdom.py:

(write_doc_files): Receive the module name used to build the
-sections.txt filename.

01:42 Changeset [179110] by zandobersek@gmail.com
  • 3 edits in trunk

[EFL][GTK] Stop compiling with fno-omit-frame-pointer, -fno-tree-dce
https://bugs.webkit.org/show_bug.cgi?id=140609

Reviewed by Csaba Osztrogonác.

The latest releases of GCC versions 4.7, 4.8 and 4.9 all compile and
run JSC tests fine without the -fno-tree-dce and -fno-omit-frame-pointer
compilation flags. Those were added after the jsCStack branch merge, but
can now be removed since the -ftree-dce issues were fixed in GCC, and
changes in r173282 and r173298 again enable compiling with -fomit-frame-pointer.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
01:09 Changeset [179109] by commit-queue@webkit.org
  • 7 edits in trunk

Unreviewed, rolling out r179107.
https://bugs.webkit.org/show_bug.cgi?id=140880

The GCC in the bots doesn't support the AsyncTask
implementation (Requested by KaL on #webkit).

Reverted changeset:

"[GTK] Enable IndexedDB"
https://bugs.webkit.org/show_bug.cgi?id=98932
http://trac.webkit.org/changeset/179107

01:08 Changeset [179108] by ossy@webkit.org
  • 2 edits in trunk/Tools

[EFL] Bump libseccomp version to 2.1.1
https://bugs.webkit.org/show_bug.cgi?id=140357

Reviewed by Gyuyoung Kim.

  • efl/jhbuild.modules:
00:25 Changeset [179107] by carlosgc@webkit.org
  • 7 edits in trunk

[GTK] Enable IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=98932

Reviewed by Žan Doberšek.

.:

  • Source/cmake/OptionsGTK.cmake: Enable DATABASE_PROCESS and INDEXED_DATABASE.
  • Source/cmake/WebKitFeatures.cmake: Add ENABLE_DATABASE_PROCESS.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.

LayoutTests:

  • platform/gtk/TestExpectations: Update IndexedDB test expectations.

01/25/15:

23:59 Changeset [179106] by ap@apple.com
  • 8 edits
    1 add in trunk/Tools

Would like leaks bot results at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=122657

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
than necessary, could use the ones from buildbot in more places.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue): Reflect configuration option for leaks queues.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

Add leaks queues to performance column. First, leaks are about performance indeed,
and second, this is where we have some space to spare.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
least a year.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid td): Moved height from queue-view - we can now have more than one
queue view per cell. The heigt is needed to avoid ugly overlapping while loading
results - once the results are loaded, all rows are currently higher than that.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:

(.leaks-popover): Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:

Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:

Load BuildbotLeaksQueueView.js.

23:10 Changeset [179105] by cdumez@apple.com
  • 2 edits in trunk/Source/WebCore

Remove 'font' shorthand property special casing
https://bugs.webkit.org/show_bug.cgi?id=140577

Reviewed by Darin Adler.

Mark CSSPrimitiveValue::m_value.fontFamily as const as it is not
supposed to change. This also makes sure that m_value.fontFamily
gets copied instead of moved when constructing a clone in
CSSPrimitiveValue::cloneForCSSOM(). This was causing several tests
to fail on the bots.

  • css/CSSPrimitiveValue.h:
22:29 Changeset [179104] by dbates@webkit.org
  • 4 edits
    115 moves
    2518 adds in trunk/LayoutTests

[iOS] Update expected results and test expectations

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:

[...]

21:01 Changeset [179103] by ap@apple.com
  • 6 edits in trunk/LayoutTests

fast/html/marquee-scrollamount.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=140851

Reviewed by Darin Adler.

Updated the test to not have a zero delay timer race. Added many comments, because
what is being tested here is quite subtle.

  • fast/html/marquee-scrollamount.html:
  • platform/efl/fast/html/marquee-scrollamount-expected.txt:
  • platform/gtk/fast/html/marquee-scrollamount-expected.txt:
  • platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt:
  • platform/mac/fast/html/marquee-scrollamount-expected.txt:

The DOM changed slightly, because we now insert the marquee after load event.

20:04 Changeset [179102] by ap@apple.com
  • 3 edits
    2 adds in trunk

Setting HTMLMarqueeElement.trueSpeed doesn't work
https://bugs.webkit.org/show_bug.cgi?id=140863

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/html/marquee-set-truespeed.html

  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::minimumDelay):

Check the boolean attribute properly - an empty value is true.

LayoutTests:

Verify that setting scrollDelay to a value under 60 actually works when trueSpeed is set.

  • fast/html/marquee-set-truespeed-expected.html: Added.
  • fast/html/marquee-set-truespeed.html: Added.
19:22 Changeset [179101] by darin@apple.com
  • 7 edits in trunk/Source/WebCore

Streamline SVGUseElement shadow tree handling and make it use SVGElementInstance less
https://bugs.webkit.org/show_bug.cgi?id=140875

Reviewed by Anders Carlsson.

Refactoring of code that is pretty well covered by existing tests, so
not adding new tests.

Inspired by work Rob Buis did in Blink:

http://src.chromium.org/viewvc/blink?view=revision&revision=173273

Althgouh that is less than half of what ended up in this patch.

  • dom/ContainerNode.h: Fixed NoEventDispatchAssertion so it can be

copied without causing an underflow of NoEventDispatchAssertion::s_count.
Made the copy constructor call the default constructor. Also changed it
to be based on ASSERT_DISABLED rather than NDEBUG and tweaked it a bit.

  • dom/ElementIteratorAssertions.h: Removed an unnecessary include and

an unnecessary default constructor. Changed to use WTF::Optional instead
of WTF::OwnPtr to handle NoEventDispatchAssertion, which makes this class
copyable and assignable, which in turn makes the iterators based on this
copyable and assignable, which is what I needed in SVGUseElement code.
Also simplified code in a couple places.

  • dom/TypedElementDescendantIterator.h:

(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::from):
Fixed an error where the arguments to Traversal::next were passed backwards.
This led to incomplete iteration in SVGUseElement code, and an immediate
assertion failure. Probably could use some unit test coverage, too.
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::from):
Ditto.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::animatedInstanceRoot): Deleted.
(WebCore::SVGUseElement::transferSizeAttributesToShadowTreeTargetClone):
Removed the originalElement argument, since we can use the correspondingElement
to get back to it. Removed the useElement argument and changed this into a
member function.
(WebCore::SVGUseElement::svgAttributeChanged): Updated for above changes.
(WebCore::subtreeContainsDisallowedElement): Deleted this function, because
it was only used to optimize by not calling removeDisallowedElementsFromSubtree,
but that function is already similarly efficient when called to do nothing, so
the preflight was not useful.
(WebCore::SVGUseElement::clearResourceReferences): Call userAgentShadowRoot
instead of shadowRoot for clarity.
(WebCore::SVGUseElement::buildPendingResource): Pass a reference instead of
a pointer to buildShadowAndInstanceTree, since it's guaranteed to not be null.
(WebCore::SVGUseElement::shadowTreeTargetClone): Added. Returns the SVG element
inside the shadow tree that corresponds to the use element's target.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Changed argument type
to a reference instead of a pointer. Removed comments explaining why we have
an instance tree, since soon we will not have one. Removed many comments that
simply state the names of the functions they are commenting on and perhaps a tiny
bit more. Changed to not use m_targetElementInstance as much, dealing with the
shadow tree directly instead of through the instance tree.
(WebCore::SVGUseElement::toClipPath): Use shadowTreeTargetClone instead of
getting at the element through m_targetElementInstance.
(WebCore::SVGUseElement::rendererClipChild): Ditto.
(WebCore::removeDisallowedElementsFromSubtree): Removed the inline keyword,
since there's no good reason to inline thif function's body. Improved local
variable names and used a modern for loop. Also moved the comment about why
this function is used here inside the function instead of repeating it at
each call site.
(WebCore::SVGUseElement::buildShadowTree): Changed to take a reference
instead of a pointer. Moved the check to see if the target is disallowed
out of this function and into buildShadowAndInstanceTree, which needs to
handle that failure explicitly. Tightened up the code a bit, using Ref instead
of RefPtr, putting the comment about removeDisallowedElementsFromSubtree into
that function itself, and removing the unneeded subtreeContainsDisallowedElement
check entirely.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Removed the argument,
getting the shadow tree from the shadowTree function instead. Walk the tree
iteratively instead of recursively, using the descendantsOfType function.
Rearranged and streamlined the logic.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::transferEventListenersToShadowTree): Ditto.
(WebCore::SVGUseElement::transferAttributesToShadowTreeReplacement): Renamed
this to avoid the term "replaced element", which is not a reasonable way to
refer to the <g> element in the shadow tree that replaces the <use> element.
Changed the argument type to SVGGElement to make it harder to misuse this
function by accident, and made the use element be "this" instead of passing
it as an argument.
(WebCore::SVGUseElement::selfHasRelativeLengths): Call hasRelativeLengths
on the target inside the shadow tree rather than the original target, which
makes more sense anyway, and is straightforward now that we have the
shadowTreeTargetClone function. Removes use of m_targetElementInstance here.

  • svg/SVGUseElement.h: Updated for above changes.
  • svg/SVGUseElement.idl: Removed animatedInstanceRoot and tweaked formatting.
18:11 Changeset [179100] by cdumez@apple.com
  • 22 edits
    5 adds in trunk

Remove 'font' shorthand property special casing
https://bugs.webkit.org/show_bug.cgi?id=140577

Reviewed by Darin Adler.

Source/WebCore:

Expand system font values during 'font' property parsing. The 'font'
CSS property was the only shorthand that wasn't always expanded in
the CSS parser, so it needed a lot of special handling that we can
now get rid of.

This patch is inspired from the following Blink revision:
https://src.chromium.org/viewvc/blink?view=rev&revision=184449

Tests:

  • fast/css/css2-system-fonts.html (existing)
  • fast/css/CSSPrimitiveValue-font-family-primitiveType.html (new)
  • fast/css/font-systemFontID-parsing.html (new)
  • fast/css/font-shorthand-line-height.html (rebased)
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCalculationValue.cpp:

(WebCore::hasDoubleValue):
Handle CSS_FONT_FAMILY similarly to CSS_STRING in the switch.

  • css/CSSFontFamily.h: Added.

Introduce new CSSFontFamily class to store font families inside
CSSPrimitive, instead of using a simple String as previously. We need
an additional 'fromSystemFontID' flag in addition to the font family
name now that system font ID are expanded during parsing. This
information is needed later on by the StyleBuilder (see comment below).

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
Update code dealing with font family CSSPrimitiveValues now that they
hold a CSSFontFamily internally instead of a String.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSystemFont):
Expand system font values for the 'font' property by asking the
RenderTheme for the system font and using it to set the 'font'
longhand properties.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):
Handle CSS_FONT_FAMILY value in the switch.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::primitiveType):
Make sure we still expose font family CSSPrimitiveValues to the Web as
CSS_STRING, even though we are using a slightly different representation
internally. This is so that we don't change web-exposed behavior and I
added a new layout test to cover this.

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
Handle CSS_FONT_FAMILY type in switches.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isFontFamily):
Add method to test if a CSSPrimitiveValue holds a CSSFontFamily
internally.

(WebCore::CSSPrimitiveValue::fontFamily):
Add a getter to retrieve the internal CSSFontFamily object if the
primitive type is CSS_FONT_FAMILY.

  • css/CSSPropertyNames.in:

Treat 'font' as a regular shorthand property. Specify its longhand
properties so that makeprop.pl can generate the shorthand code for
us. Also demote 'font' to being a low-priority property as it is
now always expanded during parsing.

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

  • css/CSSValuePool.h:
  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueFontFamily):

  • Update the 'font-family' value setter in the StyleBuilder to reflect

the changes in the CSS parser. The CSSPrimitiveValues in the list now
have CSS_FONT_FAMILY type instead of CSS_STRING.

  • We also set the 'isGenericFamily' flag if the font-family was expanded from a system font ID (e.g. caption). The 'isGenericFamily' flag is used later on to property set the 'isSpecifiedFont' flag on the FontDescription object. If we don't do this, system font values will be treated as specified fonts, which means that we will no longer use the 'use backslash as Yen sign' hack for those. This is covered by the following layout tests:
    • fast/text/backslash-to-yen-sign-euc.html
    • editing/selection/find-yensign-and-backslash.html

(WebCore::StyleBuilderCustom::applyInitialFont): Deleted.
(WebCore::StyleBuilderCustom::applyInheritFont): Deleted.
(WebCore::StyleBuilderCustom::applyValueFont): Deleted.
Remove StyleBuilder code dealing with the 'font' property. Now that
the 'font' property is always expanded during parsing, this code can
never be reached.

  • css/StylePropertyShorthand.cpp:

(WebCore::isExpandedShorthand):
Stop returning false for 'font' as it is now expanded during parsing
as well. We should probably consider renaming this method to something
else now that all shorthands are expanded, maybe isCSSShorthand() or
isShorthandProperty().

(WebCore::fontShorthand): Deleted.

  • css/StylePropertyShorthand.h:

(WebCore::matchingCustomShorthandsForLonghand): Deleted.
Remove custom shorthand code for the 'font' property as it is now
generated by makeprop.pl, like other shorthands.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyFont): Deleted.
This is unused now that the StyleBuilder code for 'font' has been
removed.

  • css/makeprop.pl:

Remove custom shorthand code for 'font' as it no longer requires any
special handling.

LayoutTests:

  • fast/css/CSSPrimitiveValue-font-family-primitiveType-expected.txt: Added.
  • fast/css/CSSPrimitiveValue-font-family-primitiveType.html: Added.

Add layout test to make sure that the font-family is still exposed to the
Web as a CSSValueList of CSSPrimitiveValues whose primitiveType is
CSS_STRING. This is useful because we now use a slightly different
representation internally.

  • fast/css/font-shorthand-line-height-expected.txt:
  • fast/css/font-shorthand-line-height.html:

Rebaseline the test. This is a progression. Setting the 'font' property
to a system font ID is supposed to reset the line-height property to
'normal'. It previously did not because system font IDs were not
expanded at parsing time. The new behavior is consistent with Chrome and
Firefox as well.

  • fast/css/font-systemFontID-parsing-expected.txt: Added.
  • fast/css/font-systemFontID-parsing.html: Added.

Add a layout test to make sure that the CSS parser is rejecting a 'font'
property with more than one system font id.

16:14 Changeset [179099] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177449. rdar://problem/19419933

16:14 Changeset [179098] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177444. rdar://problem/19419933

16:14 Changeset [179097] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r177332. rdar://problem/19419933

16:14 Changeset [179096] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177306. rdar://problem/19419933

16:14 Changeset [179095] by ddkilzer@apple.com
  • 18 edits in branches/safari-600.1.4.15-branch/Source

Merged r177301. rdar://problem/19419933

16:14 Changeset [179094] by ddkilzer@apple.com
  • 5 edits
    8 adds in branches/safari-600.1.4.15-branch

Merged r177050. rdar://problem/19419933

16:14 Changeset [179093] by ddkilzer@apple.com
  • 1 edit in branches/safari-600.1.4.15-branch/Source/WebCore/ChangeLog

Merged r177041. rdar://problem/19419933

16:14 Changeset [179092] by ddkilzer@apple.com
  • 29 edits in branches/safari-600.1.4.15-branch

Merged r177035. rdar://problem/19419933

11:40 Changeset [179091] by bfulgham@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

Document a few more failures in the expectations file.

  • platform/win/TestExpectations:
11:28 Changeset [179090] by bfulgham@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Document some Debug crashes in Accessibility code.

  • platform/win/TestExpectations:
10:37 Changeset [179089] by bfulgham@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

Skip crashes and timeouts to speed up test runs.

  • platform/win/TestExpectations:
10:01 Changeset [179088] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

[Win] Add WebKit message loop interface.
https://bugs.webkit.org/show_bug.cgi?id=140857

Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-25
Reviewed by Brent Fulgham.

Added message loop interface which will run the message loop,
and perform required tasks (like calling CFRunLoopRunInMode)
on each iteration of the loop.

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKit.vcxproj: Added new files to project.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto.

Source/WebKit/win:

  • ForEachCoClass.h:
  • Interfaces/WebKit.idl:
  • Interfaces/WebKitMessageLoop.idl: Added.
  • WebKitClassFactory.cpp:
  • WebKitMessageLoop.cpp: Added.

(WebKitMessageLoop::WebKitMessageLoop):
(WebKitMessageLoop::~WebKitMessageLoop):
(WebKitMessageLoop::createInstance):
(WebKitMessageLoop::QueryInterface):
(WebKitMessageLoop::AddRef):
(WebKitMessageLoop::Release):
(WebKitMessageLoop::run):
(WebKitMessageLoop::performMessageLoopTasks):

  • WebKitMessageLoop.h: Added.

Tools:

  • WinLauncher/WinMain.cpp:

(wWinMain): Use new message loop interface.

00:20 Changeset [179087] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Unresponsive Web processes sometimes throw ObjC exceptions under didPerformActionMenuHitTest:
https://bugs.webkit.org/show_bug.cgi?id=140859
<rdar://problem/19571057>

Reviewed by Darin Adler.

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController didPerformActionMenuHitTest:userData:]):
If we've already given up on this gesture (either because it was canceled or the
willBeginAnimation timeout expired), we shouldn't build a new animationController for it.
This is true both because it wouldn't look good to swap animationControllers out
from under the gesture, but also because AppKit throws an exception when you do this
and that breaks a lot of things.

00:17 Changeset [179086] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Long spins under Frame::rangeForPoint when doing Lookup on feedly.com
https://bugs.webkit.org/show_bug.cgi?id=140862
<rdar://problem/19566089>

Reviewed by Dan Bernstein.

  • page/Frame.cpp:

(WebCore::Frame::rangeForPoint):
If there isn't a selectable text node at the given point, rangeForPoint
will eventually return null. However, we can make it fail much faster
by checking the initial position's text-ness and selectability.

00:02 Changeset [179085] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening for EFL port.

  • platform/efl/TestExpectations: media/media-fullscreen-inline.html has been passed since r19100.

01/24/15:

23:35 Changeset [179084] by bfulgham@apple.com
  • 16 edits
    13 adds in trunk/LayoutTests

[Win] More rebaselines. (Tables)

  • platform/win/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/win/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/win/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/win/tables/mozilla/bugs/bug2479-4-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/win/tables/mozilla/bugs/bug29326-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/win/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/win/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/win/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/win/tables/mozilla/core/margins-expected.png: Added.
  • platform/win/tables/mozilla/core/margins-expected.txt:
  • platform/win/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/win/tables/mozilla/other/move_row-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/core/captions2-expected.txt:
23:14 Changeset [179083] by bfulgham@apple.com
  • 67 edits
    43 adds in trunk/LayoutTests

[Win] Unreviewed rebaselining.

Second batch: Fast

  • platform/win/fast/block/float/float-avoidance-expected.png: Added.
  • platform/win/fast/block/margin-collapse/103-expected.png: Added.
  • platform/win/fast/canvas/fallback-content-expected.txt:
  • platform/win/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/win/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/win/fast/forms/001-expected.png:
  • platform/win/fast/forms/001-expected.txt:
  • platform/win/fast/forms/003-expected.png: Added.
  • platform/win/fast/forms/003-expected.txt:
  • platform/win/fast/forms/004-expected.png: Added.
  • platform/win/fast/forms/004-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/win/fast/forms/basic-inputs-expected.png:
  • platform/win/fast/forms/basic-inputs-expected.txt:
  • platform/win/fast/forms/basic-selects-expected.png:
  • platform/win/fast/forms/basic-selects-expected.txt:
  • platform/win/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/win/fast/forms/box-shadow-override-expected.png:
  • platform/win/fast/forms/box-shadow-override-expected.txt:
  • platform/win/fast/forms/control-clip-overflow-expected.png: Added.
  • platform/win/fast/forms/control-clip-overflow-expected.txt:
  • platform/win/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/win/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/win/fast/forms/disabled-select-change-index-expected.txt:
  • platform/win/fast/forms/file/file-input-disabled-expected.png:
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/forms/form-element-geometry-expected.png: Added.
  • platform/win/fast/forms/form-element-geometry-expected.txt:
  • platform/win/fast/forms/formmove-expected.png: Added.
  • platform/win/fast/forms/formmove-expected.txt:
  • platform/win/fast/forms/indeterminate-expected.png: Added.
  • platform/win/fast/forms/indeterminate-expected.txt:
  • platform/win/fast/forms/input-appearance-height-expected.png: Added.
  • platform/win/fast/forms/input-appearance-height-expected.txt:
  • platform/win/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/win/fast/forms/input-appearance-selection-expected.txt: Added.
  • platform/win/fast/forms/menulist-deselect-update-expected.txt:
  • platform/win/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/win/fast/forms/menulist-no-overflow-expected.txt:
  • platform/win/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/win/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/win/fast/forms/menulist-separator-painting-expected.txt:
  • platform/win/fast/forms/menulist-style-color-expected.png:
  • platform/win/fast/forms/menulist-style-color-expected.txt:
  • platform/win/fast/forms/menulist-width-change-expected.txt:
  • platform/win/fast/forms/option-script-expected.txt:
  • platform/win/fast/forms/option-strip-whitespace-expected.png: Added.
  • platform/win/fast/forms/option-strip-whitespace-expected.txt:
  • platform/win/fast/forms/option-text-clip-expected.png:
  • platform/win/fast/forms/option-text-clip-expected.txt:
  • platform/win/fast/forms/range/input-appearance-range-expected.png: Added.
  • platform/win/fast/forms/range/input-appearance-range-expected.txt:
  • platform/win/fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Added.
  • platform/win/fast/forms/range/slider-mouse-events-expected.txt:
  • platform/win/fast/forms/range/slider-onchange-event-expected.txt: Added.
  • platform/win/fast/forms/range/slider-padding-expected.txt:
  • platform/win/fast/forms/range/slider-thumb-shared-style-expected.png: Added.
  • platform/win/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/win/fast/forms/range/slider-zoomed-expected.txt: Added.
  • platform/win/fast/forms/select-align-expected.png: Added.
  • platform/win/fast/forms/select-align-expected.txt:
  • platform/win/fast/forms/select-background-none-expected.txt:
  • platform/win/fast/forms/select-baseline-expected.png: Added.
  • platform/win/fast/forms/select-baseline-expected.txt:
  • platform/win/fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • platform/win/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/win/fast/forms/select-change-popup-to-listbox-expected.png: Added.
  • platform/win/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
  • platform/win/fast/forms/select-disabled-appearance-expected.png: Added.
  • platform/win/fast/forms/select-disabled-appearance-expected.txt:
  • platform/win/fast/forms/select-initial-position-expected.png: Added.
  • platform/win/fast/forms/select-initial-position-expected.txt:
  • platform/win/fast/forms/select-selected-expected.png: Added.
  • platform/win/fast/forms/select-selected-expected.txt:
  • platform/win/fast/forms/select-size-expected.txt:
  • platform/win/fast/forms/select-style-expected.png: Added.
  • platform/win/fast/forms/select-style-expected.txt:
  • platform/win/fast/forms/select-visual-hebrew-expected.txt:
  • platform/win/fast/forms/select-writing-direction-natural-expected.png:
  • platform/win/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/win/fast/forms/select/optgroup-rendering-expected.png:
  • platform/win/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/win/fast/forms/selectlist-minsize-expected.txt:
  • platform/win/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/win/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/win/fast/invalid: Added.
  • platform/win/fast/invalid/014-expected.txt: Added.
  • platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt:
  • platform/win/fast/parser: Added.
  • platform/win/fast/parser/entity-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/parser/open-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/win/fast/replaced/three-selects-break-expected.txt:
  • platform/win/fast/text/international/bidi-menulist-expected.txt:
  • platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/win/fast/text/textIteratorNilRenderer-expected.txt:
21:46 Changeset [179082] by bfulgham@apple.com
  • 22 edits in trunk/LayoutTests

[Win] Unreviewed baseline update.

First batch: CSS updates.

  • platform/win/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/win/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/win/css3/selectors3/html/css3-modsel-161-expected.txt:
  • platform/win/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/win/css3/selectors3/html/css3-modsel-25-expected.txt:
  • platform/win/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/win/css3/selectors3/html/css3-modsel-70-expected.txt:
  • platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
  • platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
  • platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
  • platform/win/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/win/css3/selectors3/xml/css3-modsel-161-expected.txt:
  • platform/win/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/win/css3/selectors3/xml/css3-modsel-25-expected.txt:
  • platform/win/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/win/css3/selectors3/xml/css3-modsel-70-expected.txt:
  • platform/win/fast/block/float/float-avoidance-expected.txt:
  • platform/win/fast/block/margin-collapse/103-expected.txt:
20:36 Changeset [179081] by mitz@apple.com
  • 2 edits in trunk/Tools

update-webkit’s --internal option is unused
https://bugs.webkit.org/show_bug.cgi?id=140861

Reviewed by Anders Carlsson.

  • Scripts/update-webkit: Removed the option.
19:02 Changeset [179080] by cdumez@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2][Cocoa] Drop WKDiagnosticLoggingResultType defines
https://bugs.webkit.org/show_bug.cgi?id=140838

Reviewed by Sam Weinig.

Drop WKDiagnosticLoggingResultType defines in _WKDiagnosticLoggingDelegate.h
header now that the client-side is correctly using
_WKDiagnosticLoggingResultType instead.

  • UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
18:55 Changeset [179079] by bfulgham@apple.com
  • 26 edits
    81 adds in trunk/LayoutTests

[Win] Unreviewed gardening. Reactivating tests.

Re-enable a series of tests that work properly on Windows. New baselines will be needed.

  • platform/win/TestExpectations:
  • platform/win/css1/box_properties/acid_test-expected.png: Added.
  • platform/win/css1/box_properties/acid_test-expected.txt:
  • platform/win/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/win/fast/block/float/float-avoidance-expected.txt:
  • platform/win/fast/block/margin-collapse/103-expected.txt:
  • platform/win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/win/fast/dynamic/008-expected.txt: Added.
  • platform/win/fast/forms/001-expected.png: Added.
  • platform/win/fast/forms/001-expected.txt:
  • platform/win/fast/forms/003-expected.txt:
  • platform/win/fast/forms/004-expected.txt:
  • platform/win/fast/forms/006-expected.png: Added.
  • platform/win/fast/forms/007-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label01-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label02-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label03-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label04-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label05-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label06-expected.txt: Removed property svn:executable.
  • platform/win/fast/forms/HTMLOptionElement_label07-expected.txt: Added.
  • platform/win/fast/forms/basic-buttons-expected.png: Added.
  • platform/win/fast/forms/basic-buttons-expected.txt: Added.
  • platform/win/fast/forms/basic-inputs-expected.png: Added.
  • platform/win/fast/forms/basic-selects-expected.txt:
  • platform/win/fast/forms/basic-textareas-expected.png: Added.
  • platform/win/fast/forms/box-shadow-override-expected.png: Added.
  • platform/win/fast/forms/box-shadow-override-expected.txt: Added.
  • platform/win/fast/forms/button-positioned-expected.txt: Added.
  • platform/win/fast/forms/button-sizes-expected.txt: Added.
  • platform/win/fast/forms/button-style-color-expected.txt: Added.
  • platform/win/fast/forms/button-text-transform-expected.txt: Added.
  • platform/win/fast/forms/control-clip-overflow-expected.txt: Added.
  • platform/win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/win/fast/forms/disabled-select-change-index-expected.txt: Added.
  • platform/win/fast/forms/form-element-geometry-expected.txt: Added.
  • platform/win/fast/forms/hidden-listbox-expected.txt: Added.
  • platform/win/fast/forms/input-appearance-focus-expected.txt: Added.
  • platform/win/fast/forms/input-double-click-selection-gap-bug-expected.txt: Added.
  • platform/win/fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • platform/win/fast/forms/input-text-double-click-expected.txt: Added.
  • platform/win/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
  • platform/win/fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
  • platform/win/fast/forms/listbox-width-change-expected.txt: Added.
  • platform/win/fast/forms/menulist-deselect-update-expected.txt:
  • platform/win/fast/forms/menulist-no-overflow-expected.txt: Added.
  • platform/win/fast/forms/number/number-appearance-rtl-expected.txt: Added.
  • platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Added.
  • platform/win/fast/forms/option-strip-whitespace-expected.txt: Added.
  • platform/win/fast/forms/plaintext-mode-2-expected.txt: Added.
  • platform/win/fast/forms/search: Added.
  • platform/win/fast/forms/search/search-size-with-decorations-expected.txt: Added.
  • platform/win/fast/forms/select-align-expected.txt: Added.
  • platform/win/fast/forms/select-baseline-expected.txt: Added.
  • platform/win/fast/forms/select-block-background-expected.txt: Added.
  • platform/win/fast/forms/select-change-listbox-size-expected.txt: Added.
  • platform/win/fast/forms/select-change-listbox-to-popup-expected.txt: Added.
  • platform/win/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
  • platform/win/fast/forms/select-disabled-appearance-expected.txt: Added.
  • platform/win/fast/forms/select-initial-position-expected.txt: Added.
  • platform/win/fast/forms/select-item-background-clip-expected.txt: Added.
  • platform/win/fast/forms/select-list-box-with-height-expected.txt: Added.
  • platform/win/fast/forms/select-selected-expected.txt: Added.
  • platform/win/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/win/fast/forms/tabbing-input-iframe-expected.txt: Added.
  • platform/win/fast/frames: Added.
  • platform/win/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/win/fast/multicol/pagination: Added.
  • platform/win/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
  • platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
  • platform/win/fast/overflow/entity-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/overflow/open-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/overflow/overflow-x-y-expected.txt: Added.
  • platform/win/fast/table/003-expected.txt: Added.
  • platform/win/fast/table/colspanMinWidth-expected.txt: Added.
  • platform/win/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug103533-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug1188-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug12384-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug1318-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/win/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/win/tables/mozilla/bugs/bug29326-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/win/tables/mozilla/bugs/bug30692-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/win/tables/mozilla/bugs/bug4382-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/win/tables/mozilla/bugs/bug44505-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/win/tables/mozilla/bugs/bug55545-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug92647-2-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug96334-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug99948-expected.txt: Added.
  • platform/win/tables/mozilla/core: Added.
  • platform/win/tables/mozilla/core/bloomberg-expected.txt: Added.
  • platform/win/tables/mozilla/core/margins-expected.txt: Added.
  • platform/win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_align_justify-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
17:28 Changeset [179078] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176725. rdar://problem/19432746

17:28 Changeset [179077] by ddkilzer@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged 'resolvedURL' changes from r176108. rdar://problem/19432746

16:54 Changeset [179076] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176475. rdar://problem/19450119

16:54 Changeset [179075] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175251. rdar://problem/19450119

16:08 Changeset [179074] by bfulgham@apple.com
  • 2 edits in trunk/Tools

DumpRenderTree needs to run with Windows native controls on Windows
https://bugs.webkit.org/show_bug.cgi?id=25592

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
(prepareConsistentTestingEnvironment): Ditto.

12:36 Changeset [179073] by ddkilzer@apple.com
  • 4 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r176382. rdar://problem/19419810

12:30 Changeset [179072] by ddkilzer@apple.com
  • 3 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r176321. rdar://problem/19369495

12:16 Changeset [179071] by ddkilzer@apple.com
  • 8 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r176262. rdar://problem/19432679

12:16 Changeset [179070] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175260. rdar://problem/19432679

11:55 Changeset [179069] by darin@apple.com
  • 7 edits
    6 adds in trunk

Move height/width implementation for use element from RenderSVGViewportContainer to SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=140826

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: svg/animations/use-animate-width-and-height.html

svg/custom/use-attribute-invalidations.html
svg/custom/use-dynamic-attribute-setting.html

This is an adaptation of work Rob Buis did in Blink:

http://src.chromium.org/viewvc/blink?view=revision&revision=173258

The goal here is to reduce use of SVGElementInstance since we are going to
remove it. The tests Rob added to Blink (which I believe I improved a bit here)
meant we had to fix quite a few bugs in the implementation of the width/height
logic rather than just moving it. Even so, this could use even more test coverage
since there is separate logic for <symbol> and <svg>, three different code paths
(animation/attribute setting, initial creation, and one other), and also
distinct issues for attributes not set at all, attributes set to values that
can't be parsed, and attributes set with different units.

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport): Removed the old logic.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement): Use ASCIILiteral to more efficiently
create strings from ASCII literals here.
(WebCore::SVGSVGElement::parseAttribute): Default to 100%, not 0, when the
width or height property are either not set or not successfully parsed. Without
this change, one of the SVG tests starts failing.

  • svg/SVGUseElement.cpp:

(WebCore::updateWidthAndHeight): Added. The tricky part here is that we have
to copy width and height attributes only if they were successfully parsed, and
also we need to copy the current animating values, not the original attribute
strings. Kind of messy, but I wanted to adapt Rob's solution for the time being,
rather than inventing something new.
(WebCore::SVGUseElement::svgAttributeChanged): Call updateWidthAndHeight.
This is used both when actual attribute changes occur and also when animation
changes the current value.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateWidthAndHeight.
This is used when the shadow elements are first created.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Call updateWidthAndHeight.
This was in Rob's patch, but I am not sure we have sufficient test coverage.

LayoutTests:

  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Old test

result was expecting failure. New one expects success.

  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Ditto.
  • svg/animations/use-animate-width-and-height-expected.txt: Added.
  • svg/animations/use-animate-width-and-height.html: Added.
  • svg/custom/use-attribute-invalidations-expected.html: Added.
  • svg/custom/use-attribute-invalidations.html: Added.
  • svg/custom/use-dynamic-attribute-setting-expected.html: Added.
  • svg/custom/use-dynamic-attribute-setting.html: Added.
11:14 Changeset [179068] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175976. rdar://problem/19420064

10:57 Changeset [179067] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175585. rdar://problem/19419818

10:30 Changeset [179066] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged small change from r175549. rdar://problem/19433134

09:27 Changeset [179065] by ddkilzer@apple.com
  • 3 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r174860. rdar://problem/19419859

09:00 Changeset [179064] by ddkilzer@apple.com
  • 3 edits
    7 adds in branches/safari-600.1.4.15-branch

Merged r175085. rdar://problem/19419853

09:00 Changeset [179063] by ddkilzer@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r174356. rdar://problem/19419853

09:00 Changeset [179062] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged branch-only patch (r0). rdar://problem/19564738

08:28 Changeset [179061] by cdumez@apple.com
  • 4 edits in trunk/Source

Provide implementation for WTF::DefaultHash<bool>
https://bugs.webkit.org/show_bug.cgi?id=140848

Reviewed by Anders Carlsson.

Source/WebCore:

Use HashMap<std::pair<UChar32, bool>> type in Font.cpp for
CharacterFallbackMap instead of HashMap<std::pair<UChar32, unsigned>>.
It builds now that WTF::DefaultHash<bool> is defined in WTF.

  • platform/graphics/Font.cpp:

(WebCore::Font::removeFromSystemFallbackCache):

Source/WTF:

Provide implementation for WTF::DefaultHash<bool> so that we can use
HashMap<std::pair<XXX, bool>> in the code base. Right now, we need to
use some integer type to work around the issue.

  • wtf/HashFunctions.h:
Note: See TracTimeline for information about the timeline view.