⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changes in trunk [45431:45444] in webkit


Ignore:
Location:
trunk
Files:
18 added
36 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r45431 r45444  
     12009-07-01  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
     2
     3        Reviewed by George Staikos.
     4
     5        Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885
     6
     7        Add new WML testcases covering onenterforward/ontimer support.
     8
     9        * wml/onenterforward-event-expected.txt: Added.
     10        * wml/onenterforward-event.html: Added.
     11        * wml/onenterforward-inline-event-expected.txt: Added.
     12        * wml/onenterforward-inline-event.html: Added.
     13        * wml/ontimer-event-expected.txt: Added.
     14        * wml/ontimer-event.html: Added.
     15        * wml/resources/onenterforward-event.js: Added.
     16        (setupTestDocument):
     17        (prepareTest):
     18        (executeTest):
     19        * wml/resources/onenterforward-event.wml: Added.
     20        * wml/resources/onenterforward-inline-event.js: Added.
     21        (setupTestDocument):
     22        (prepareTest):
     23        (executeTest):
     24        * wml/resources/onenterforward-inline-event.wml: Added.
     25        * wml/resources/ontimer-event.js: Added.
     26        (setupTestDocument):
     27        (prepareTest):
     28        (executeTest):
     29        * wml/resources/ontimer-event.wml: Added.
     30        * wml/resources/ontimer-inline-event.js:
     31
     322009-07-01  David Hyatt  <hyatt@apple.com>
     33
     34        Reviewed by Simon Fraser.
     35
     36        Add layout test for being able to set attributes on dcol elements.
     37       
     38        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes-expected.txt: Added.
     39        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Added.
     40
     412009-07-01  Simon Fraser  <simon.fraser@apple.com>
     42
     43        Reviewed by Dimitri Glazkov.
     44       
     45        Add some missing pixel results for compositing tests.
     46
     47        * platform/mac/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
     48        * platform/mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
     49        * platform/mac/compositing/overflow/overflow-scroll-expected.checksum: Added.
     50        * platform/mac/compositing/overflow/overflow-scroll-expected.png: Added.
     51
     522009-07-01  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
     53
     54        Reviewed by George Staikos.
     55
     56        Fixes: https://bugs.webkit.org/show_bug.cgi?id=26884
     57
     58        WMLTestCase.js relies on timing-dependant hacks, making it difficult to predict results on slower machines.
     59        Fix by rewriting and simplifying the testing procedure, which contained unnecessary quirks working around older WML bugs.
     60
     61        * wml/resources/WMLTestCase.js:
     62        (createWMLTestCase.iframeElement.onload):
     63        (createWMLTestCase):
     64        (startTest):
     65
     662009-07-01  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
     67
     68        Reviewed by Holger Freyther.
     69
     70        Apply same cleanup to WML testcases living in http/tests/wml/. Forgot about them in my last commit.
     71
     72        * http/tests/wml/resources/go-task-get-method-accept-charset.js:
     73        (setupTestDocument):
     74        * http/tests/wml/resources/go-task-get-method.js:
     75        (setupTestDocument):
     76        * http/tests/wml/resources/go-task-post-method-accept-charset.js:
     77        (setupTestDocument):
     78        * http/tests/wml/resources/go-task-post-method.js:
     79        (setupTestDocument):
     80        * http/tests/wml/resources/post-data-to-server.js:
     81        (setupTestDocument):
     82
     832009-07-01  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
     84
     85        Reviewed by Holger Freyther.
     86
     87        Slightly cleanup some WML testcases:
     88        Use "anchorElement.textContent = '...'" instead of "anchorElement.appendChild(document.createTextNode('...'))"
     89
     90        * wml/resources/go-task-get-method-external-deck-with-href.js:
     91        (setupTestDocument):
     92        * wml/resources/go-task-get-method-external-deck.js:
     93        (setupTestDocument):
     94        * wml/resources/go-task-get-method-same-deck.js:
     95        (setupTestDocument):
     96        * wml/resources/input-format.js:
     97        (setupTestDocument):
     98        * wml/resources/variable-reference-invalid-character.js:
     99        (setupTestDocument):
     100        * wml/resources/variable-reference-valid.js:
     101        (setupTestDocument):
     102
    11032009-06-30  Xan Lopez  <xlopez@igalia.com>
    2104
  • trunk/LayoutTests/http/tests/wml/resources/go-task-get-method-accept-charset.js

    r45431 r45444  
    77
    88    var anchorElement = createWMLElement("anchor");
    9     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     9    anchorElement.textContent = "Start test";
    1010    cardElement.appendChild(anchorElement);
    1111
  • trunk/LayoutTests/http/tests/wml/resources/go-task-get-method.js

    r45431 r45444  
    77
    88    var anchorElement = createWMLElement("anchor");
    9     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     9    anchorElement.textContent = "Start test";
    1010    cardElement.appendChild(anchorElement);
    1111
  • trunk/LayoutTests/http/tests/wml/resources/go-task-post-method-accept-charset.js

    r45431 r45444  
    77
    88    var anchorElement = createWMLElement("anchor");
    9     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     9    anchorElement.textContent = "Start test";
    1010    cardElement.appendChild(anchorElement);
    1111
  • trunk/LayoutTests/http/tests/wml/resources/go-task-post-method.js

    r45431 r45444  
    77
    88    var anchorElement = createWMLElement("anchor");
    9     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     9    anchorElement.textContent = "Start test";
    1010    cardElement.appendChild(anchorElement);
    1111
  • trunk/LayoutTests/http/tests/wml/resources/post-data-to-server.js

    r45431 r45444  
    1212    var anchorElement = createWMLElement("anchor");
    1313    anchorElement.setAttribute("id", "top");
    14     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     14    anchorElement.textContent = "Start test";
    1515    cardElement.appendChild(anchorElement);
    1616
  • trunk/LayoutTests/wml/resources/WMLTestCase.js

    r45431 r45444  
    1010}
    1111
    12 function createWMLTestCase(desc, substituteVariables, testName) {
    13     if (substituteVariables == null)
    14         substituteVariables = true;
     12function createWMLTestCase(testDescription, substitutesVariables, testName) {
     13    // Setup default test options
     14    if (substitutesVariables == null) {
     15        substitutesVariables = true;
     16    }
    1517
    16     var defaultTest = true;
     18    // Setup default test name
     19    var usesDefaultTestDocument = false;
    1720    if (testName == null) {
    18         defaultTest = false;
     21        usesDefaultTestDocument = true;
    1922        testName = relativePathToLayoutTests + "/wml/resources/test-document.wml";
    2023    }
    2124
    22     description(desc);
     25    // Initialize JS test
     26    description(testDescription);
    2327    bodyElement = document.getElementsByTagName("body")[0];
    2428
     
    2630    document.resetWMLPageState();
    2731
     32    // Setup DRT specific settings
    2833    if (window.layoutTestController) {
    2934        layoutTestController.dumpChildFramesAsText();
     
    3136    }
    3237
     38    // Create container element to load the WML document
    3339    iframeElement = document.createElementNS(xhtmlNS, "iframe");
    3440    iframeElement.src = testName;
    3541
    36     var loaded = false;
    37     var executed = false;
     42    // Process load events, taking care of setting up the native WML testcase
     43    iframeElement.onload = function() {
     44        if (testDocument) {
     45            // Variable substitition mode: resetup test document, substituting all variables stored in the current WML page state.
     46            // Variable substitution only happens after the initial document has been loaded and after a reload was triggered.       
     47            if (substitutesVariables) {
     48                testDocument = iframeElement.contentDocument;
     49                setupTestDocument();
     50            }
    3851
    39     iframeElement.onload = function() {
    40         if (executed && !defaultTest)
    41             return;
    42 
    43         // External deck jumps
    44         if (testDocument != null && !substituteVariables) {
    45             delayExecuteTest();
     52            executeTest();
    4653            return;
    4754        }
     
    4956        testDocument = iframeElement.contentDocument;
    5057        setupTestDocument();
    51 
    52         // Variable refresh
    53         if (loaded && substituteVariables) {
    54             delayExecuteTest();
    55             return;
    56         }
    57 
    58         loaded = true;
    5958        prepareTest();
    6059
    61         // Internal deck jumps
    62         if (!substituteVariables) {
    63             executed = true;
    64             delayExecuteTest();
     60        // In a regular WML document, this would happen after the parsing finished.
     61        // Though as we dynamically create testcases, we have to take care of initializing WML variable state manually.
     62        testDocument.initializeWMLPageState();
     63
     64        // Handle the case of a special WML test document. That's always the case for static WML testcases
     65        //(which are NOT created manually using JS in prepareTest). Fire off test immediately for those.
     66        if (!usesDefaultTestDocument) {
     67            executeTest();
    6568        }
    6669    }
     
    8285
    8386function startTest(x, y) {
    84     // Initialize variable state
    85     // In a regular WML document, this would happen after the parsing finished.
    86     // Though as we dynamically create testcases, we have to take care of initializing WML variable state manually.
    87     testDocument.initializeWMLPageState();
    88 
    8987    // Assure first layout finished
    9088    window.setTimeout("triggerUpdate(" + x + ", " + y + ")", 0);
    91 }
    92 
    93 function delayExecuteTest() {
    94     // Assure first layout finished, after making changes
    95     window.setTimeout("executeTest()", 0);
    9689}
    9790
  • trunk/LayoutTests/wml/resources/go-task-get-method-external-deck-with-href.js

    r45431 r45444  
    77
    88    var anchorElement = createWMLElement("anchor");
    9     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     9    anchorElement.textContent = "Start test";
    1010    cardElement.appendChild(anchorElement);
    1111
  • trunk/LayoutTests/wml/resources/go-task-get-method-external-deck.js

    r45431 r45444  
    77
    88    var anchorElement = createWMLElement("anchor");
    9     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     9    anchorElement.textContent = "Start test";
    1010    cardElement.appendChild(anchorElement);
    1111
  • trunk/LayoutTests/wml/resources/go-task-get-method-same-deck.js

    r45431 r45444  
    77
    88    var anchorElement = createWMLElement("anchor");
    9     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     9    anchorElement.textContent = "Start test";
    1010    cardElement.appendChild(anchorElement);
    1111
  • trunk/LayoutTests/wml/resources/input-format.js

    r45431 r45444  
    2020
    2121    var anchorElement = createWMLElement("anchor");
    22     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     22    anchorElement.textContent = "Start test";
    2323    cardElement.appendChild(anchorElement);
    2424
  • trunk/LayoutTests/wml/resources/ontimer-inline-event.js

    r45431 r45444  
    11/// [Name] ontimer-inline-event.js
    22
    3 createWMLTestCase("Tests &lt;timer&gt; and &lt;go&gt; element combinations", false, "resources/ontimer-inline-event.wml");
     3createWMLTestCase("Tests ontimer inline event declarations", false, "resources/ontimer-inline-event.wml");
    44
    55var counter = 0;
  • trunk/LayoutTests/wml/resources/variable-reference-invalid-character.js

    r45431 r45444  
    1212
    1313    var anchorElement = createWMLElement("anchor");
    14     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     14    anchorElement.textContent = "Start test";
    1515    cardElement.appendChild(anchorElement);
    1616
  • trunk/LayoutTests/wml/resources/variable-reference-valid.js

    r45431 r45444  
    1212
    1313    var anchorElement = createWMLElement("anchor");
    14     anchorElement.appendChild(testDocument.createTextNode("Start test"));
     14    anchorElement.textContent = "Start test";
    1515    cardElement.appendChild(anchorElement);
    1616
  • trunk/WebCore/ChangeLog

    r45431 r45444  
     12009-07-01  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
     2
     3        Reviewed by George Staikos.
     4
     5        Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885
     6
     7        Correctly reset history length to '0', not '1'. Old relict from early WML days.
     8        Add some new WML testcases covering the use of history length (by onenterforward event handling)
     9
     10        Tests: wml/onenterforward-event.html
     11               wml/onenterforward-inline-event.html
     12               wml/ontimer-event.html
     13 
     14        * wml/WMLPageState.cpp:
     15        (WebCore::WMLPageState::reset):
     16
     172009-07-01  David Hyatt  <hyatt@apple.com>
     18
     19        Reviewed by Simon Fraser.
     20
     21        Make sure setting attributes on dcol elements properly updates the corresponding DataGridColumn object.
     22
     23        Added new test in fast/dom/HTMLDataGridElement.
     24
     25        * html/HTMLDataGridColElement.cpp:
     26        (WebCore::HTMLDataGridColElement::parseMappedAttribute):
     27        * html/HTMLDataGridColElement.h:
     28
     292009-07-01  David Hyatt  <hyatt@apple.com>
     30
     31        Reviewed by Tim Hatcher.
     32
     33        <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
     34        even though the field is not actually focused for keyboard input
     35       
     36        Add the concept of whether or not the Page is focused by adding a boolean to the focusController.  This allows the
     37        focused frame and focused node to both be cached and changed programmatically even when the Page itself doesn't
     38        actually happen to have focus at that time.
     39
     40        * WebCore.base.exp:
     41        * page/FocusController.cpp:
     42        (WebCore::FocusController::FocusController):
     43        (WebCore::FocusController::setFocusedFrame):
     44        (WebCore::FocusController::setFocused):
     45        (WebCore::FocusController::setActive):
     46        * page/FocusController.h:
     47        (WebCore::FocusController::isFocused):
     48
     492009-07-01  Jakub Wieczorek  <faw217@gmail.com>
     50
     51        Reviewed by Simon Hausmann.
     52
     53        [Qt] Move some API headers from WebCore.pro to headers.pri so that they
     54        get installed when running make install from the build directory.
     55
     56        * WebCore.pro:
     57
     582009-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
     59
     60        Rubber-stamped by Ariya Hidayat.
     61
     62        Ran WebKitTools/Scripts/generate-qt-inspector-resource to update the
     63        qrc file with new png files from the web inspector.
     64
     65        * inspector/front-end/WebKit.qrc:
     66
    1672009-06-30  Mark Rowe  <mrowe@apple.com>
    268
  • trunk/WebCore/WebCore.base.exp

    r45431 r45444  
    352352__ZN7WebCore15FocusController18focusedOrMainFrameEv
    353353__ZN7WebCore15FocusController9setActiveEb
     354__ZN7WebCore15FocusController10setFocusedEb
    354355__ZN7WebCore15GraphicsContext12setFillColorERKNS_5ColorE
    355356__ZN7WebCore15GraphicsContextC1EP9CGContext
  • trunk/WebCore/WebCore.pro

    r45431 r45444  
    11141114    $$PWD/platform/graphics/qt/StillImageQt.h \
    11151115    $$PWD/platform/qt/QWebPopup.h \
    1116     $$PWD/../WebKit/qt/Api/qwebpluginfactory.h \
    11171116    $$PWD/../WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h \
    11181117    $$PWD/platform/network/qt/QNetworkReplyHandler.h \
     
    11221121    $$PWD/rendering/style/StyleRareInheritedData.h \
    11231122    $$PWD/rendering/style/StyleRareNonInheritedData.h \
    1124     $$PWD/rendering/style/StyleReflection.h \
    1125     $$PWD/../WebKit/qt/Api/qwebsecurityorigin.h \
    1126     $$PWD/../WebKit/qt/Api/qwebdatabase.h
     1123    $$PWD/rendering/style/StyleReflection.h
    11271124
    11281125
  • trunk/WebCore/html/HTMLDataGridColElement.cpp

    r45431 r45444  
    3131#include "HTMLDataGridElement.h"
    3232#include "HTMLDataGridColElement.h"
    33 
    3433#include "HTMLNames.h"
     34#include "MappedAttribute.h"
    3535#include "Text.h"
    3636
     
    146146}
    147147
     148void HTMLDataGridColElement::parseMappedAttribute(MappedAttribute* attr)
     149{
     150    HTMLElement::parseMappedAttribute(attr);
     151     
     152    if (!column())
     153        return;
     154
     155    if (attr->name() == labelAttr)
     156        column()->setLabel(label());
     157    else if (attr->name() == typeAttr)
     158        column()->setType(type());
     159    else if (attr->name() == primaryAttr)
     160        column()->setPrimary(primary());
     161    else if (attr->name() == sortableAttr)
     162        column()->setSortable(sortable());
     163    else if (attr->name() == sortdirectionAttr)
     164        column()->setSortDirection(sortDirection());
     165    else if (attr->name() == idAttr)
     166        column()->setId(getAttribute(idAttr));
     167}
     168
    148169} // namespace WebCore
    149170
  • trunk/WebCore/html/HTMLDataGridColElement.h

    r45431 r45444  
    4444    virtual void insertedIntoTree(bool /*deep*/);
    4545    virtual void removedFromTree(bool /*deep*/);
     46    virtual void parseMappedAttribute(MappedAttribute*);
    4647
    4748    String label() const;
  • trunk/WebCore/inspector/front-end/WebKit.qrc

    r45431 r45444  
    110110    <file>Images/resourcePlainIconSmall.png</file>
    111111    <file>Images/resourcesIcon.png</file>
     112    <file>Images/resourcesSilhouette.png</file>
    112113    <file>Images/resourcesSizeGraphIcon.png</file>
    113114    <file>Images/resourcesTimeGraphIcon.png</file>
  • trunk/WebCore/page/FocusController.cpp

    r45431 r45444  
    5959    : m_page(page)
    6060    , m_isActive(false)
     61    , m_isFocused(false)
    6162{
    6263}
     
    7475    m_focusedFrame = frame;
    7576
    76     if (m_focusedFrame && m_focusedFrame->view()) {
     77    if (m_focusedFrame && m_focusedFrame->view() && isFocused()) {
    7778        m_focusedFrame->selection()->setFocused(true);
    7879        m_focusedFrame->document()->dispatchWindowEvent(eventNames().focusEvent, false, false);
     
    8586        return frame;
    8687    return m_page->mainFrame();
     88}
     89
     90void FocusController::setFocused(bool focused)
     91{
     92    if (isFocused() == focused)
     93        return;
     94   
     95    m_isFocused = focused;
     96   
     97    if (m_focusedFrame && m_focusedFrame->view()) {
     98        m_focusedFrame->selection()->setFocused(focused);
     99        m_focusedFrame->document()->dispatchWindowEvent(focused ? eventNames().focusEvent : eventNames().blurEvent, false, false);
     100    }
    87101}
    88102
     
    323337    focusedOrMainFrame()->selection()->pageActivationChanged();
    324338   
    325     if (m_focusedFrame)
     339    if (m_focusedFrame && isFocused())
    326340        m_focusedFrame->document()->dispatchWindowEvent(active ? eventNames().focusEvent : eventNames().blurEvent, false, false);
    327341}
  • trunk/WebCore/page/FocusController.h

    r45431 r45444  
    5454        bool isActive() const { return m_isActive; }
    5555
     56        void setFocused(bool);
     57        bool isFocused() const { return m_isFocused; }
     58
    5659    private:
    5760        Page* m_page;
    5861        RefPtr<Frame> m_focusedFrame;
    5962        bool m_isActive;
     63        bool m_isFocused;
    6064    };
    6165
  • trunk/WebCore/wml/WMLPageState.cpp

    r45431 r45444  
    5555
    5656    // reset implementation-specfic state if UA has
    57     m_historyLength = 1;
     57    m_historyLength = 0;
    5858}
    5959
  • trunk/WebKit/mac/ChangeLog

    r45431 r45444  
     12009-07-01  David Hyatt  <hyatt@apple.com>
     2
     3        Reviewed by Tim Hatcher.
     4
     5        <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
     6        even though the field is not actually focused for keyboard input
     7       
     8        Add the concept of whether or not the Page is focused by adding a boolean to the focusController.  This allows the
     9        focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
     10        have focus.
     11
     12        * WebView/WebHTMLView.mm:
     13        (-[WebHTMLView becomeFirstResponder]):
     14        (-[WebHTMLView resignFirstResponder]):
     15
    1162009-06-30  Adele Peterson  <adele@apple.com>
    217
  • trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm

    r45431 r45444  
    11021102       
    11031103    // If the WebHTMLView implicitly became first responder, make sure to set the focused frame properly.
    1104     if (usesDocumentViews && [[documentView window] firstResponder] == documentView)
     1104    if (usesDocumentViews && [[documentView window] firstResponder] == documentView) {
    11051105        page->focusController()->setFocusedFrame(coreFrame);
     1106        page->focusController()->setFocused(true);
     1107    }
    11061108}
    11071109
  • trunk/WebKit/mac/WebView/WebHTMLView.mm

    r45431 r45444  
    35873587        page->focusController()->setFocusedFrame(frame);
    35883588
     3589    page->focusController()->setFocused(true);
     3590
    35893591    if (direction == NSDirectSelection)
    35903592        return YES;
     
    36023604    if (resign) {
    36033605        [_private->completionController endRevertingChange:NO moveLeft:NO];
     3606        Frame* coreFrame = core([self _frame]);
     3607        if (!coreFrame)
     3608            return resign;
     3609        Page* page = coreFrame->page();
     3610        if (!page)
     3611            return resign;
    36043612        if (![self maintainsInactiveSelection]) {
    36053613            [self deselectAll];
    3606             if (![[self _webView] _isPerformingProgrammaticFocus]) {
     3614            if (![[self _webView] _isPerformingProgrammaticFocus])
    36073615                [self clearFocus];
    3608                 Frame* coreFrame = core([self _frame]);
    3609                 if (!coreFrame)
    3610                     return resign;
    3611                 Page* page = coreFrame->page();
    3612                 if (!page)
    3613                     return resign;
    3614                 page->focusController()->setFocusedFrame(0);
    3615             }
    36163616        }
     3617       
     3618        id nextResponder = [[self window] _newFirstResponderAfterResigning];
     3619        bool nextResponderIsInWebView = [nextResponder isKindOfClass:[NSView class]]
     3620            && [nextResponder isDescendantOf:[[[self _webView] mainFrame] frameView]];
     3621        if (!nextResponderIsInWebView)
     3622            page->focusController()->setFocused(false);
    36173623    }
    36183624    return resign;
  • trunk/WebKit/qt/Api/headers.pri

    r45431 r45444  
    77                     $$PWD/qwebdatabase.h \
    88                     $$PWD/qwebsecurityorigin.h \
    9                      $$PWD/qwebelement.h
     9                     $$PWD/qwebelement.h \
     10                     $$PWD/qwebpluginfactory.h \
     11                     $$PWD/qwebhistory.h
  • trunk/WebKit/qt/ChangeLog

    r45431 r45444  
     12009-07-01  Jakub Wieczorek  <faw217@gmail.com>
     2
     3        Reviewed by Simon Hausmann.
     4
     5        [Qt] Move some API headers from WebCore.pro to headers.pri so that they
     6        get installed when running make install from the build directory.
     7
     8        * Api/headers.pri:
     9
     102009-07-01  Balazs Kelemen  <kelemen.balazs.3@stud.u-szeged.hu>
     11
     12        Reviewed by Simon Hausmann.
     13
     14        Fixed robotized QtLauncher to work when there is no index.html in the user's home.
     15
     16        * QtLauncher/main.cpp:
     17        (main):
     18
    1192009-06-30  Brian Weinstein  <bweinstein@apple.com>
    220
  • trunk/WebKit/qt/QtLauncher/main.cpp

    r45431 r45444  
    407407    const QStringList args = app.arguments();
    408408
    409     // robotized
    410409    if (args.contains(QLatin1String("-r"))) {
     410        // robotized
    411411        QString listFile = args.at(2);
    412412        if (!(args.count() == 3) && QFile::exists(listFile)) {
     
    414414            exit(0);
    415415        }
    416         MainWindow window(url);
     416        MainWindow window;
    417417        QWebView *view = window.webView();
    418418        URLLoader loader(view, listFile);
    419419        QObject::connect(view, SIGNAL(loadFinished(bool)), &loader, SLOT(loadNext()));
     420        loader.loadNext();
    420421        window.show();
    421422        return app.exec();
  • trunk/WebKit/win/ChangeLog

    r45431 r45444  
     12009-07-01  David Hyatt  <hyatt@apple.com>
     2
     3        Reviewed by Tim Hatcher.
     4
     5        <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
     6        even though the field is not actually focused for keyboard input
     7       
     8        Add the concept of whether or not the Page is focused by adding a boolean to the focusController.  This allows the
     9        focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
     10        have focus.
     11
     12        * WebView.cpp:
     13        (WebViewWndProc):
     14
    1152009-06-29  David Hyatt  <hyatt@apple.com>
    216
  • trunk/WebKit/win/WebView.cpp

    r45431 r45444  
    19131913                // child of ours (for example a plugin).
    19141914                if (!IsChild(hWnd, reinterpret_cast<HWND>(wParam)))
    1915                     frame->selection()->setFocused(true);
     1915                    focusController->setFocused(true);
    19161916            } else
    19171917                focusController->setFocusedFrame(webView->page()->mainFrame());
     
    19311931            // Send blur events unless we're losing focus to a child of ours.
    19321932            if (!IsChild(hWnd, newFocusWnd))
    1933                 frame->selection()->setFocused(false);
     1933                focusController->setFocused(false);
    19341934            break;
    19351935        }
  • trunk/WebKitLibraries/ChangeLog

    r45431 r45444  
     12009-07-01  Eric Carlson  <eric.carlson@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Update WebKitSystemInterface for <rdar://problem/7014990>
     6
     7        * libWebKitSystemInterfaceLeopard.a:
     8        * libWebKitSystemInterfaceSnowLeopard.a:
     9        * libWebKitSystemInterfaceTiger.a:
     10
    1112009-06-29  Eric Carlson  <eric.carlson@apple.com>
    212
  • trunk/WebKitTools/Scripts/modules

    • Property svn:ignore set to
      *.pyc
Note: See TracChangeset for help on using the changeset viewer.