Changes in trunk [45431:45444] in webkit
- Location:
- trunk
- Files:
-
- 18 added
- 36 edited
-
LayoutTests/ChangeLog (modified) (1 diff)
-
LayoutTests/fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes-expected.txt (added)
-
LayoutTests/fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html (added)
-
LayoutTests/http/tests/wml/resources/go-task-get-method-accept-charset.js (modified) (1 diff)
-
LayoutTests/http/tests/wml/resources/go-task-get-method.js (modified) (1 diff)
-
LayoutTests/http/tests/wml/resources/go-task-post-method-accept-charset.js (modified) (1 diff)
-
LayoutTests/http/tests/wml/resources/go-task-post-method.js (modified) (1 diff)
-
LayoutTests/http/tests/wml/resources/post-data-to-server.js (modified) (1 diff)
-
LayoutTests/platform/mac/compositing/layers-inside-overflow-scroll-expected.checksum (added)
-
LayoutTests/platform/mac/compositing/layers-inside-overflow-scroll-expected.png (added)
-
LayoutTests/platform/mac/compositing/overflow/overflow-scroll-expected.checksum (added)
-
LayoutTests/platform/mac/compositing/overflow/overflow-scroll-expected.png (added)
-
LayoutTests/wml/onenterforward-event-expected.txt (added)
-
LayoutTests/wml/onenterforward-event.html (added)
-
LayoutTests/wml/onenterforward-inline-event-expected.txt (added)
-
LayoutTests/wml/onenterforward-inline-event.html (added)
-
LayoutTests/wml/ontimer-event-expected.txt (added)
-
LayoutTests/wml/ontimer-event.html (added)
-
LayoutTests/wml/resources/WMLTestCase.js (modified) (5 diffs)
-
LayoutTests/wml/resources/go-task-get-method-external-deck-with-href.js (modified) (1 diff)
-
LayoutTests/wml/resources/go-task-get-method-external-deck.js (modified) (1 diff)
-
LayoutTests/wml/resources/go-task-get-method-same-deck.js (modified) (1 diff)
-
LayoutTests/wml/resources/input-format.js (modified) (1 diff)
-
LayoutTests/wml/resources/onenterforward-event.js (added)
-
LayoutTests/wml/resources/onenterforward-event.wml (added)
-
LayoutTests/wml/resources/onenterforward-inline-event.js (added)
-
LayoutTests/wml/resources/onenterforward-inline-event.wml (added)
-
LayoutTests/wml/resources/ontimer-event.js (added)
-
LayoutTests/wml/resources/ontimer-event.wml (added)
-
LayoutTests/wml/resources/ontimer-inline-event.js (modified) (1 diff)
-
LayoutTests/wml/resources/variable-reference-invalid-character.js (modified) (1 diff)
-
LayoutTests/wml/resources/variable-reference-valid.js (modified) (1 diff)
-
WebCore/ChangeLog (modified) (1 diff)
-
WebCore/WebCore.base.exp (modified) (1 diff)
-
WebCore/WebCore.pro (modified) (2 diffs)
-
WebCore/html/HTMLDataGridColElement.cpp (modified) (2 diffs)
-
WebCore/html/HTMLDataGridColElement.h (modified) (1 diff)
-
WebCore/inspector/front-end/WebKit.qrc (modified) (1 diff)
-
WebCore/page/FocusController.cpp (modified) (4 diffs)
-
WebCore/page/FocusController.h (modified) (1 diff)
-
WebCore/wml/WMLPageState.cpp (modified) (1 diff)
-
WebKit/mac/ChangeLog (modified) (1 diff)
-
WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (modified) (1 diff)
-
WebKit/mac/WebView/WebHTMLView.mm (modified) (2 diffs)
-
WebKit/qt/Api/headers.pri (modified) (1 diff)
-
WebKit/qt/ChangeLog (modified) (1 diff)
-
WebKit/qt/QtLauncher/main.cpp (modified) (2 diffs)
-
WebKit/win/ChangeLog (modified) (1 diff)
-
WebKit/win/WebView.cpp (modified) (2 diffs)
-
WebKitLibraries/ChangeLog (modified) (1 diff)
-
WebKitLibraries/libWebKitSystemInterfaceLeopard.a (modified) ( previous)
-
WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a (modified) ( previous)
-
WebKitLibraries/libWebKitSystemInterfaceTiger.a (modified) ( previous)
-
WebKitTools/Scripts/modules (modified) (1 prop)
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r45431 r45444 1 2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com> 2 3 Reviewed by George Staikos. 4 5 Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885 6 7 Add new WML testcases covering onenterforward/ontimer support. 8 9 * wml/onenterforward-event-expected.txt: Added. 10 * wml/onenterforward-event.html: Added. 11 * wml/onenterforward-inline-event-expected.txt: Added. 12 * wml/onenterforward-inline-event.html: Added. 13 * wml/ontimer-event-expected.txt: Added. 14 * wml/ontimer-event.html: Added. 15 * wml/resources/onenterforward-event.js: Added. 16 (setupTestDocument): 17 (prepareTest): 18 (executeTest): 19 * wml/resources/onenterforward-event.wml: Added. 20 * wml/resources/onenterforward-inline-event.js: Added. 21 (setupTestDocument): 22 (prepareTest): 23 (executeTest): 24 * wml/resources/onenterforward-inline-event.wml: Added. 25 * wml/resources/ontimer-event.js: Added. 26 (setupTestDocument): 27 (prepareTest): 28 (executeTest): 29 * wml/resources/ontimer-event.wml: Added. 30 * wml/resources/ontimer-inline-event.js: 31 32 2009-07-01 David Hyatt <hyatt@apple.com> 33 34 Reviewed by Simon Fraser. 35 36 Add layout test for being able to set attributes on dcol elements. 37 38 * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes-expected.txt: Added. 39 * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Added. 40 41 2009-07-01 Simon Fraser <simon.fraser@apple.com> 42 43 Reviewed by Dimitri Glazkov. 44 45 Add some missing pixel results for compositing tests. 46 47 * platform/mac/compositing/layers-inside-overflow-scroll-expected.checksum: Added. 48 * platform/mac/compositing/layers-inside-overflow-scroll-expected.png: Added. 49 * platform/mac/compositing/overflow/overflow-scroll-expected.checksum: Added. 50 * platform/mac/compositing/overflow/overflow-scroll-expected.png: Added. 51 52 2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com> 53 54 Reviewed by George Staikos. 55 56 Fixes: https://bugs.webkit.org/show_bug.cgi?id=26884 57 58 WMLTestCase.js relies on timing-dependant hacks, making it difficult to predict results on slower machines. 59 Fix by rewriting and simplifying the testing procedure, which contained unnecessary quirks working around older WML bugs. 60 61 * wml/resources/WMLTestCase.js: 62 (createWMLTestCase.iframeElement.onload): 63 (createWMLTestCase): 64 (startTest): 65 66 2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com> 67 68 Reviewed by Holger Freyther. 69 70 Apply same cleanup to WML testcases living in http/tests/wml/. Forgot about them in my last commit. 71 72 * http/tests/wml/resources/go-task-get-method-accept-charset.js: 73 (setupTestDocument): 74 * http/tests/wml/resources/go-task-get-method.js: 75 (setupTestDocument): 76 * http/tests/wml/resources/go-task-post-method-accept-charset.js: 77 (setupTestDocument): 78 * http/tests/wml/resources/go-task-post-method.js: 79 (setupTestDocument): 80 * http/tests/wml/resources/post-data-to-server.js: 81 (setupTestDocument): 82 83 2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com> 84 85 Reviewed by Holger Freyther. 86 87 Slightly cleanup some WML testcases: 88 Use "anchorElement.textContent = '...'" instead of "anchorElement.appendChild(document.createTextNode('...'))" 89 90 * wml/resources/go-task-get-method-external-deck-with-href.js: 91 (setupTestDocument): 92 * wml/resources/go-task-get-method-external-deck.js: 93 (setupTestDocument): 94 * wml/resources/go-task-get-method-same-deck.js: 95 (setupTestDocument): 96 * wml/resources/input-format.js: 97 (setupTestDocument): 98 * wml/resources/variable-reference-invalid-character.js: 99 (setupTestDocument): 100 * wml/resources/variable-reference-valid.js: 101 (setupTestDocument): 102 1 103 2009-06-30 Xan Lopez <xlopez@igalia.com> 2 104 -
trunk/LayoutTests/http/tests/wml/resources/go-task-get-method-accept-charset.js
r45431 r45444 7 7 8 8 var anchorElement = createWMLElement("anchor"); 9 anchorElement. appendChild(testDocument.createTextNode("Start test"));9 anchorElement.textContent = "Start test"; 10 10 cardElement.appendChild(anchorElement); 11 11 -
trunk/LayoutTests/http/tests/wml/resources/go-task-get-method.js
r45431 r45444 7 7 8 8 var anchorElement = createWMLElement("anchor"); 9 anchorElement. appendChild(testDocument.createTextNode("Start test"));9 anchorElement.textContent = "Start test"; 10 10 cardElement.appendChild(anchorElement); 11 11 -
trunk/LayoutTests/http/tests/wml/resources/go-task-post-method-accept-charset.js
r45431 r45444 7 7 8 8 var anchorElement = createWMLElement("anchor"); 9 anchorElement. appendChild(testDocument.createTextNode("Start test"));9 anchorElement.textContent = "Start test"; 10 10 cardElement.appendChild(anchorElement); 11 11 -
trunk/LayoutTests/http/tests/wml/resources/go-task-post-method.js
r45431 r45444 7 7 8 8 var anchorElement = createWMLElement("anchor"); 9 anchorElement. appendChild(testDocument.createTextNode("Start test"));9 anchorElement.textContent = "Start test"; 10 10 cardElement.appendChild(anchorElement); 11 11 -
trunk/LayoutTests/http/tests/wml/resources/post-data-to-server.js
r45431 r45444 12 12 var anchorElement = createWMLElement("anchor"); 13 13 anchorElement.setAttribute("id", "top"); 14 anchorElement. appendChild(testDocument.createTextNode("Start test"));14 anchorElement.textContent = "Start test"; 15 15 cardElement.appendChild(anchorElement); 16 16 -
trunk/LayoutTests/wml/resources/WMLTestCase.js
r45431 r45444 10 10 } 11 11 12 function createWMLTestCase(desc, substituteVariables, testName) { 13 if (substituteVariables == null) 14 substituteVariables = true; 12 function createWMLTestCase(testDescription, substitutesVariables, testName) { 13 // Setup default test options 14 if (substitutesVariables == null) { 15 substitutesVariables = true; 16 } 15 17 16 var defaultTest = true; 18 // Setup default test name 19 var usesDefaultTestDocument = false; 17 20 if (testName == null) { 18 defaultTest = false;21 usesDefaultTestDocument = true; 19 22 testName = relativePathToLayoutTests + "/wml/resources/test-document.wml"; 20 23 } 21 24 22 description(desc); 25 // Initialize JS test 26 description(testDescription); 23 27 bodyElement = document.getElementsByTagName("body")[0]; 24 28 … … 26 30 document.resetWMLPageState(); 27 31 32 // Setup DRT specific settings 28 33 if (window.layoutTestController) { 29 34 layoutTestController.dumpChildFramesAsText(); … … 31 36 } 32 37 38 // Create container element to load the WML document 33 39 iframeElement = document.createElementNS(xhtmlNS, "iframe"); 34 40 iframeElement.src = testName; 35 41 36 var loaded = false; 37 var executed = false; 42 // Process load events, taking care of setting up the native WML testcase 43 iframeElement.onload = function() { 44 if (testDocument) { 45 // Variable substitition mode: resetup test document, substituting all variables stored in the current WML page state. 46 // Variable substitution only happens after the initial document has been loaded and after a reload was triggered. 47 if (substitutesVariables) { 48 testDocument = iframeElement.contentDocument; 49 setupTestDocument(); 50 } 38 51 39 iframeElement.onload = function() { 40 if (executed && !defaultTest) 41 return; 42 43 // External deck jumps 44 if (testDocument != null && !substituteVariables) { 45 delayExecuteTest(); 52 executeTest(); 46 53 return; 47 54 } … … 49 56 testDocument = iframeElement.contentDocument; 50 57 setupTestDocument(); 51 52 // Variable refresh53 if (loaded && substituteVariables) {54 delayExecuteTest();55 return;56 }57 58 loaded = true;59 58 prepareTest(); 60 59 61 // Internal deck jumps 62 if (!substituteVariables) { 63 executed = true; 64 delayExecuteTest(); 60 // In a regular WML document, this would happen after the parsing finished. 61 // Though as we dynamically create testcases, we have to take care of initializing WML variable state manually. 62 testDocument.initializeWMLPageState(); 63 64 // Handle the case of a special WML test document. That's always the case for static WML testcases 65 //(which are NOT created manually using JS in prepareTest). Fire off test immediately for those. 66 if (!usesDefaultTestDocument) { 67 executeTest(); 65 68 } 66 69 } … … 82 85 83 86 function startTest(x, y) { 84 // Initialize variable state85 // In a regular WML document, this would happen after the parsing finished.86 // Though as we dynamically create testcases, we have to take care of initializing WML variable state manually.87 testDocument.initializeWMLPageState();88 89 87 // Assure first layout finished 90 88 window.setTimeout("triggerUpdate(" + x + ", " + y + ")", 0); 91 }92 93 function delayExecuteTest() {94 // Assure first layout finished, after making changes95 window.setTimeout("executeTest()", 0);96 89 } 97 90 -
trunk/LayoutTests/wml/resources/go-task-get-method-external-deck-with-href.js
r45431 r45444 7 7 8 8 var anchorElement = createWMLElement("anchor"); 9 anchorElement. appendChild(testDocument.createTextNode("Start test"));9 anchorElement.textContent = "Start test"; 10 10 cardElement.appendChild(anchorElement); 11 11 -
trunk/LayoutTests/wml/resources/go-task-get-method-external-deck.js
r45431 r45444 7 7 8 8 var anchorElement = createWMLElement("anchor"); 9 anchorElement. appendChild(testDocument.createTextNode("Start test"));9 anchorElement.textContent = "Start test"; 10 10 cardElement.appendChild(anchorElement); 11 11 -
trunk/LayoutTests/wml/resources/go-task-get-method-same-deck.js
r45431 r45444 7 7 8 8 var anchorElement = createWMLElement("anchor"); 9 anchorElement. appendChild(testDocument.createTextNode("Start test"));9 anchorElement.textContent = "Start test"; 10 10 cardElement.appendChild(anchorElement); 11 11 -
trunk/LayoutTests/wml/resources/input-format.js
r45431 r45444 20 20 21 21 var anchorElement = createWMLElement("anchor"); 22 anchorElement. appendChild(testDocument.createTextNode("Start test"));22 anchorElement.textContent = "Start test"; 23 23 cardElement.appendChild(anchorElement); 24 24 -
trunk/LayoutTests/wml/resources/ontimer-inline-event.js
r45431 r45444 1 1 /// [Name] ontimer-inline-event.js 2 2 3 createWMLTestCase("Tests <timer> and <go> element combinations", false, "resources/ontimer-inline-event.wml");3 createWMLTestCase("Tests ontimer inline event declarations", false, "resources/ontimer-inline-event.wml"); 4 4 5 5 var counter = 0; -
trunk/LayoutTests/wml/resources/variable-reference-invalid-character.js
r45431 r45444 12 12 13 13 var anchorElement = createWMLElement("anchor"); 14 anchorElement. appendChild(testDocument.createTextNode("Start test"));14 anchorElement.textContent = "Start test"; 15 15 cardElement.appendChild(anchorElement); 16 16 -
trunk/LayoutTests/wml/resources/variable-reference-valid.js
r45431 r45444 12 12 13 13 var anchorElement = createWMLElement("anchor"); 14 anchorElement. appendChild(testDocument.createTextNode("Start test"));14 anchorElement.textContent = "Start test"; 15 15 cardElement.appendChild(anchorElement); 16 16 -
trunk/WebCore/ChangeLog
r45431 r45444 1 2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com> 2 3 Reviewed by George Staikos. 4 5 Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885 6 7 Correctly reset history length to '0', not '1'. Old relict from early WML days. 8 Add some new WML testcases covering the use of history length (by onenterforward event handling) 9 10 Tests: wml/onenterforward-event.html 11 wml/onenterforward-inline-event.html 12 wml/ontimer-event.html 13 14 * wml/WMLPageState.cpp: 15 (WebCore::WMLPageState::reset): 16 17 2009-07-01 David Hyatt <hyatt@apple.com> 18 19 Reviewed by Simon Fraser. 20 21 Make sure setting attributes on dcol elements properly updates the corresponding DataGridColumn object. 22 23 Added new test in fast/dom/HTMLDataGridElement. 24 25 * html/HTMLDataGridColElement.cpp: 26 (WebCore::HTMLDataGridColElement::parseMappedAttribute): 27 * html/HTMLDataGridColElement.h: 28 29 2009-07-01 David Hyatt <hyatt@apple.com> 30 31 Reviewed by Tim Hatcher. 32 33 <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused, 34 even though the field is not actually focused for keyboard input 35 36 Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the 37 focused frame and focused node to both be cached and changed programmatically even when the Page itself doesn't 38 actually happen to have focus at that time. 39 40 * WebCore.base.exp: 41 * page/FocusController.cpp: 42 (WebCore::FocusController::FocusController): 43 (WebCore::FocusController::setFocusedFrame): 44 (WebCore::FocusController::setFocused): 45 (WebCore::FocusController::setActive): 46 * page/FocusController.h: 47 (WebCore::FocusController::isFocused): 48 49 2009-07-01 Jakub Wieczorek <faw217@gmail.com> 50 51 Reviewed by Simon Hausmann. 52 53 [Qt] Move some API headers from WebCore.pro to headers.pri so that they 54 get installed when running make install from the build directory. 55 56 * WebCore.pro: 57 58 2009-07-01 Simon Hausmann <simon.hausmann@nokia.com> 59 60 Rubber-stamped by Ariya Hidayat. 61 62 Ran WebKitTools/Scripts/generate-qt-inspector-resource to update the 63 qrc file with new png files from the web inspector. 64 65 * inspector/front-end/WebKit.qrc: 66 1 67 2009-06-30 Mark Rowe <mrowe@apple.com> 2 68 -
trunk/WebCore/WebCore.base.exp
r45431 r45444 352 352 __ZN7WebCore15FocusController18focusedOrMainFrameEv 353 353 __ZN7WebCore15FocusController9setActiveEb 354 __ZN7WebCore15FocusController10setFocusedEb 354 355 __ZN7WebCore15GraphicsContext12setFillColorERKNS_5ColorE 355 356 __ZN7WebCore15GraphicsContextC1EP9CGContext -
trunk/WebCore/WebCore.pro
r45431 r45444 1114 1114 $$PWD/platform/graphics/qt/StillImageQt.h \ 1115 1115 $$PWD/platform/qt/QWebPopup.h \ 1116 $$PWD/../WebKit/qt/Api/qwebpluginfactory.h \1117 1116 $$PWD/../WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h \ 1118 1117 $$PWD/platform/network/qt/QNetworkReplyHandler.h \ … … 1122 1121 $$PWD/rendering/style/StyleRareInheritedData.h \ 1123 1122 $$PWD/rendering/style/StyleRareNonInheritedData.h \ 1124 $$PWD/rendering/style/StyleReflection.h \ 1125 $$PWD/../WebKit/qt/Api/qwebsecurityorigin.h \ 1126 $$PWD/../WebKit/qt/Api/qwebdatabase.h 1123 $$PWD/rendering/style/StyleReflection.h 1127 1124 1128 1125 -
trunk/WebCore/html/HTMLDataGridColElement.cpp
r45431 r45444 31 31 #include "HTMLDataGridElement.h" 32 32 #include "HTMLDataGridColElement.h" 33 34 33 #include "HTMLNames.h" 34 #include "MappedAttribute.h" 35 35 #include "Text.h" 36 36 … … 146 146 } 147 147 148 void HTMLDataGridColElement::parseMappedAttribute(MappedAttribute* attr) 149 { 150 HTMLElement::parseMappedAttribute(attr); 151 152 if (!column()) 153 return; 154 155 if (attr->name() == labelAttr) 156 column()->setLabel(label()); 157 else if (attr->name() == typeAttr) 158 column()->setType(type()); 159 else if (attr->name() == primaryAttr) 160 column()->setPrimary(primary()); 161 else if (attr->name() == sortableAttr) 162 column()->setSortable(sortable()); 163 else if (attr->name() == sortdirectionAttr) 164 column()->setSortDirection(sortDirection()); 165 else if (attr->name() == idAttr) 166 column()->setId(getAttribute(idAttr)); 167 } 168 148 169 } // namespace WebCore 149 170 -
trunk/WebCore/html/HTMLDataGridColElement.h
r45431 r45444 44 44 virtual void insertedIntoTree(bool /*deep*/); 45 45 virtual void removedFromTree(bool /*deep*/); 46 virtual void parseMappedAttribute(MappedAttribute*); 46 47 47 48 String label() const; -
trunk/WebCore/inspector/front-end/WebKit.qrc
r45431 r45444 110 110 <file>Images/resourcePlainIconSmall.png</file> 111 111 <file>Images/resourcesIcon.png</file> 112 <file>Images/resourcesSilhouette.png</file> 112 113 <file>Images/resourcesSizeGraphIcon.png</file> 113 114 <file>Images/resourcesTimeGraphIcon.png</file> -
trunk/WebCore/page/FocusController.cpp
r45431 r45444 59 59 : m_page(page) 60 60 , m_isActive(false) 61 , m_isFocused(false) 61 62 { 62 63 } … … 74 75 m_focusedFrame = frame; 75 76 76 if (m_focusedFrame && m_focusedFrame->view() ) {77 if (m_focusedFrame && m_focusedFrame->view() && isFocused()) { 77 78 m_focusedFrame->selection()->setFocused(true); 78 79 m_focusedFrame->document()->dispatchWindowEvent(eventNames().focusEvent, false, false); … … 85 86 return frame; 86 87 return m_page->mainFrame(); 88 } 89 90 void FocusController::setFocused(bool focused) 91 { 92 if (isFocused() == focused) 93 return; 94 95 m_isFocused = focused; 96 97 if (m_focusedFrame && m_focusedFrame->view()) { 98 m_focusedFrame->selection()->setFocused(focused); 99 m_focusedFrame->document()->dispatchWindowEvent(focused ? eventNames().focusEvent : eventNames().blurEvent, false, false); 100 } 87 101 } 88 102 … … 323 337 focusedOrMainFrame()->selection()->pageActivationChanged(); 324 338 325 if (m_focusedFrame )339 if (m_focusedFrame && isFocused()) 326 340 m_focusedFrame->document()->dispatchWindowEvent(active ? eventNames().focusEvent : eventNames().blurEvent, false, false); 327 341 } -
trunk/WebCore/page/FocusController.h
r45431 r45444 54 54 bool isActive() const { return m_isActive; } 55 55 56 void setFocused(bool); 57 bool isFocused() const { return m_isFocused; } 58 56 59 private: 57 60 Page* m_page; 58 61 RefPtr<Frame> m_focusedFrame; 59 62 bool m_isActive; 63 bool m_isFocused; 60 64 }; 61 65 -
trunk/WebCore/wml/WMLPageState.cpp
r45431 r45444 55 55 56 56 // reset implementation-specfic state if UA has 57 m_historyLength = 1;57 m_historyLength = 0; 58 58 } 59 59 -
trunk/WebKit/mac/ChangeLog
r45431 r45444 1 2009-07-01 David Hyatt <hyatt@apple.com> 2 3 Reviewed by Tim Hatcher. 4 5 <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused, 6 even though the field is not actually focused for keyboard input 7 8 Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the 9 focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't 10 have focus. 11 12 * WebView/WebHTMLView.mm: 13 (-[WebHTMLView becomeFirstResponder]): 14 (-[WebHTMLView resignFirstResponder]): 15 1 16 2009-06-30 Adele Peterson <adele@apple.com> 2 17 -
trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
r45431 r45444 1102 1102 1103 1103 // If the WebHTMLView implicitly became first responder, make sure to set the focused frame properly. 1104 if (usesDocumentViews && [[documentView window] firstResponder] == documentView) 1104 if (usesDocumentViews && [[documentView window] firstResponder] == documentView) { 1105 1105 page->focusController()->setFocusedFrame(coreFrame); 1106 page->focusController()->setFocused(true); 1107 } 1106 1108 } 1107 1109 -
trunk/WebKit/mac/WebView/WebHTMLView.mm
r45431 r45444 3587 3587 page->focusController()->setFocusedFrame(frame); 3588 3588 3589 page->focusController()->setFocused(true); 3590 3589 3591 if (direction == NSDirectSelection) 3590 3592 return YES; … … 3602 3604 if (resign) { 3603 3605 [_private->completionController endRevertingChange:NO moveLeft:NO]; 3606 Frame* coreFrame = core([self _frame]); 3607 if (!coreFrame) 3608 return resign; 3609 Page* page = coreFrame->page(); 3610 if (!page) 3611 return resign; 3604 3612 if (![self maintainsInactiveSelection]) { 3605 3613 [self deselectAll]; 3606 if (![[self _webView] _isPerformingProgrammaticFocus]) {3614 if (![[self _webView] _isPerformingProgrammaticFocus]) 3607 3615 [self clearFocus]; 3608 Frame* coreFrame = core([self _frame]);3609 if (!coreFrame)3610 return resign;3611 Page* page = coreFrame->page();3612 if (!page)3613 return resign;3614 page->focusController()->setFocusedFrame(0);3615 }3616 3616 } 3617 3618 id nextResponder = [[self window] _newFirstResponderAfterResigning]; 3619 bool nextResponderIsInWebView = [nextResponder isKindOfClass:[NSView class]] 3620 && [nextResponder isDescendantOf:[[[self _webView] mainFrame] frameView]]; 3621 if (!nextResponderIsInWebView) 3622 page->focusController()->setFocused(false); 3617 3623 } 3618 3624 return resign; -
trunk/WebKit/qt/Api/headers.pri
r45431 r45444 7 7 $$PWD/qwebdatabase.h \ 8 8 $$PWD/qwebsecurityorigin.h \ 9 $$PWD/qwebelement.h 9 $$PWD/qwebelement.h \ 10 $$PWD/qwebpluginfactory.h \ 11 $$PWD/qwebhistory.h -
trunk/WebKit/qt/ChangeLog
r45431 r45444 1 2009-07-01 Jakub Wieczorek <faw217@gmail.com> 2 3 Reviewed by Simon Hausmann. 4 5 [Qt] Move some API headers from WebCore.pro to headers.pri so that they 6 get installed when running make install from the build directory. 7 8 * Api/headers.pri: 9 10 2009-07-01 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu> 11 12 Reviewed by Simon Hausmann. 13 14 Fixed robotized QtLauncher to work when there is no index.html in the user's home. 15 16 * QtLauncher/main.cpp: 17 (main): 18 1 19 2009-06-30 Brian Weinstein <bweinstein@apple.com> 2 20 -
trunk/WebKit/qt/QtLauncher/main.cpp
r45431 r45444 407 407 const QStringList args = app.arguments(); 408 408 409 // robotized410 409 if (args.contains(QLatin1String("-r"))) { 410 // robotized 411 411 QString listFile = args.at(2); 412 412 if (!(args.count() == 3) && QFile::exists(listFile)) { … … 414 414 exit(0); 415 415 } 416 MainWindow window (url);416 MainWindow window; 417 417 QWebView *view = window.webView(); 418 418 URLLoader loader(view, listFile); 419 419 QObject::connect(view, SIGNAL(loadFinished(bool)), &loader, SLOT(loadNext())); 420 loader.loadNext(); 420 421 window.show(); 421 422 return app.exec(); -
trunk/WebKit/win/ChangeLog
r45431 r45444 1 2009-07-01 David Hyatt <hyatt@apple.com> 2 3 Reviewed by Tim Hatcher. 4 5 <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused, 6 even though the field is not actually focused for keyboard input 7 8 Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the 9 focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't 10 have focus. 11 12 * WebView.cpp: 13 (WebViewWndProc): 14 1 15 2009-06-29 David Hyatt <hyatt@apple.com> 2 16 -
trunk/WebKit/win/WebView.cpp
r45431 r45444 1913 1913 // child of ours (for example a plugin). 1914 1914 if (!IsChild(hWnd, reinterpret_cast<HWND>(wParam))) 1915 f rame->selection()->setFocused(true);1915 focusController->setFocused(true); 1916 1916 } else 1917 1917 focusController->setFocusedFrame(webView->page()->mainFrame()); … … 1931 1931 // Send blur events unless we're losing focus to a child of ours. 1932 1932 if (!IsChild(hWnd, newFocusWnd)) 1933 f rame->selection()->setFocused(false);1933 focusController->setFocused(false); 1934 1934 break; 1935 1935 } -
trunk/WebKitLibraries/ChangeLog
r45431 r45444 1 2009-07-01 Eric Carlson <eric.carlson@apple.com> 2 3 Reviewed by Simon Fraser. 4 5 Update WebKitSystemInterface for <rdar://problem/7014990> 6 7 * libWebKitSystemInterfaceLeopard.a: 8 * libWebKitSystemInterfaceSnowLeopard.a: 9 * libWebKitSystemInterfaceTiger.a: 10 1 11 2009-06-29 Eric Carlson <eric.carlson@apple.com> 2 12 -
trunk/WebKitTools/Scripts/modules
-
Property svn:ignore
set to
*.pyc
-
Property svn:ignore
set to
Note:
See TracChangeset
for help on using the changeset viewer.