Changeset 100033 in webkit

Timestamp:

Nov 11, 2011, 3:06:35 PM (15 years ago)

Author:

ap@apple.com

Message:

WebProcess should use AppSandbox style quarantine
​https://bugs.webkit.org/show_bug.cgi?id=72168
<rdar://problem/10434292>

Reviewed by Darin Adler.

• WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Just enable it.

Location:

trunk

Files:

• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/WebProcess/mac/WebProcessMac.mm (modified) (1 diff)
• WebKitLibraries/ChangeLog (modified) (1 diff)
• WebKitLibraries/WebKitSystemInterface.h (modified) (1 diff)
• WebKitLibraries/libWebKitSystemInterfaceLeopard.a (modified) ( previous)
• WebKitLibraries/libWebKitSystemInterfaceLion.a (modified) ( previous)
• WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a (modified) ( previous)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-11-11  Alexey Proskuryakov  <ap@apple.com>
+
+        WebProcess should use AppSandbox style quarantine
+        https://bugs.webkit.org/show_bug.cgi?id=72168
+        <rdar://problem/10434292>
+
+        Reviewed by Darin Adler.
+
+        * WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Just enable it.
+
 2011-11-11  Darin Adler  <darin@apple.com>
 

trunk/Source/WebKit2/WebProcess/mac/WebProcessMac.mm

@@ -212 +212 @@
     for (size_t i = 0; sandboxParameters[i]; i += 2)
         fastFree(const_cast<char*>(sandboxParameters[i + 1]));
+
+    // This will override LSFileQuarantineEnabled from Info.plist unless sandbox quarantine is globally disabled.
+    OSStatus error = WKEnableSandboxStyleFileQuarantine();
+    if (error) {
+        fprintf(stderr, "WebProcess: couldn't enable sandbox style file quarantine: %d\n", error);
+        exit(EX_NOPERM);
+    }
 #endif
 }

trunk/WebKitLibraries/ChangeLog

@@ +1 @@
+2011-11-11  Alexey Proskuryakov  <ap@apple.com>
+
+        WebProcess should use AppSandbox style quarantine
+        https://bugs.webkit.org/show_bug.cgi?id=72168
+        <rdar://problem/10434292>
+
+        Reviewed by Darin Adler.
+
+        * WebKitSystemInterface.h:
+        * libWebKitSystemInterfaceLion.a:
+        Added WKEnableSandboxStyleFileQuarantine().
+
+        * libWebKitSystemInterfaceLeopard.a:
+        * libWebKitSystemInterfaceSnowLeopard.a:
+        Not sure why these also changed, but updating to match most recent build.
+
 2011-11-02  Dean Jackson  <dino@apple.com>
 

trunk/WebKitLibraries/WebKitSystemInterface.h

@@ -430 +430 @@
 WKSandboxExtensionRef WKSandboxExtensionCreateFromSerializedFormat(const char* serializationFormat, size_t length);
 
+OSStatus WKEnableSandboxStyleFileQuarantine(void);
+
 int WKRecommendedScrollerStyle(void);