Changeset 100061 in webkit

Timestamp:

Nov 11, 2011, 6:58:11 PM (15 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=72193

Patch by Luiz Agostini <​luiz.agostini@palm.com> on 2011-11-11
Reviewed by Noam Rosenthal.

Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
code is not related to the class QComboBox.

• WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

Location:

trunk/Source/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/PopupMenuQt.cpp (modified) (3 diffs)

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2011-11-11  Luiz Agostini  <luiz.agostini@palm.com>
+
+        [Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=72193
+
+        Reviewed by Noam Rosenthal.
+
+        Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
+        code is not related to the class QComboBox.
+
+        * WebCoreSupport/PopupMenuQt.cpp:
+        (WebCore::PopupMenuQt::show):
+
 2011-11-11  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
 

trunk/Source/WebKit/qt/WebCoreSupport/PopupMenuQt.cpp

@@ -30 +30 @@
 #include "FrameView.h"
 #include "PopupMenuClient.h"
-#include "QtFallbackWebPopup.h"
 
 #include "qwebkitplatformplugin.h"
@@ -98 +97 @@
 void PopupMenuQt::show(const IntRect& rect, FrameView* view, int index)
 {
-#ifndef QT_NO_COMBOBOX
     if (!m_popupClient)
         return;
@@ -115 +113 @@
     m_selectData = adoptPtr(new SelectData(m_popupClient));
     m_popup->show(*m_selectData.get());
-#endif
 }