Changeset 100065 in webkit

Timestamp:

Nov 11, 2011, 8:23:59 PM (15 years ago)

Author:

dmazzoni@google.com

Message:

Source/WebCore: Fix a crash when an anonymous render block is in a continuation.
​https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

Test: accessibility/anonymous-render-block-in-continuation-causes-crash.html

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderParentObject):

LayoutTests: Add test to ensure that an anonymous render block in a continuation doesn't crash.
​https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

• accessibility/anonymous-render-block-in-continuation-causes-crash.html: Added.
• accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt (added)
• LayoutTests/accessibility/anonymous-render-block-in-continuation-causes-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-11-11  Dominic Mazzoni  <dmazzoni@google.com>
+
+        Add test to ensure that an anonymous render block in a continuation doesn't crash.
+        https://bugs.webkit.org/show_bug.cgi?id=70994
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/anonymous-render-block-in-continuation-causes-crash.html: Added.
+        * accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt: Added.
+
 2011-11-11  Anna Cavender  <annacc@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-11  Dominic Mazzoni  <dmazzoni@google.com>
+
+        Fix a crash when an anonymous render block is in a continuation.
+        https://bugs.webkit.org/show_bug.cgi?id=70994
+
+        Reviewed by Chris Fleizach.
+
+        Test: accessibility/anonymous-render-block-in-continuation-causes-crash.html
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::renderParentObject):
+
 2011-11-11  Anna Cavender  <annacc@chromium.org>
 

trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -427 +427 @@
                 break;
             firstChild = parent->firstChild();
+            if (!firstChild->node())
+                break;
             nodeRenderFirstChild = firstChild->node()->renderer();
         }