Changeset 10008 in webkit


Ignore:
Timestamp:
Aug 2, 2005, 10:14:41 AM (20 years ago)
Author:
sullivan
Message:

Reviewed by Darin Adler.

Preemptively moved some WebMenuItemTag values from SPI to API, in anticipation of
approval from macosx-api-reviewers. Retitled one of them in response to API reviewers feedback:
WebMenuItemSearchInGoogle -> WebMenuItemSearchWeb

Note that as a side effect of this change, the actual numbers used for these WebMenuItemTags has
changed from what it was in Tiger. This causes "Search in Spotlight", "Search in Google", and
"Look Up in Dictionary" to not appear in Tiger Safari if running on tip of tree WebKit.

  • WebView.subproj/WebUIDelegatePrivate.h: removed WebMenuItemTagSearchInSpotlight, WebMenuItemTagSearchInGoogle, and WebMenuItemTagLookUpInDictionary
  • WebView.subproj/WebUIDelegate.h: added WebMenuItemTagSearchInSpotlight, WebMenuItemTagSearchWeb, and WebMenuItemTagLookUpInDictionary
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]): updated for rename (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): ditto (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): ditto
Location:
trunk/WebKit
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit/ChangeLog

    r10003 r10008  
     12005-08-02  John Sullivan  <sullivan@apple.com>
     2
     3        Reviewed by Darin Adler.
     4       
     5        Preemptively moved some WebMenuItemTag values from SPI to API, in anticipation of
     6        approval from macosx-api-reviewers. Retitled one of them in response to API reviewers feedback:
     7        WebMenuItemSearchInGoogle -> WebMenuItemSearchWeb
     8       
     9        Note that as a side effect of this change, the actual numbers used for these WebMenuItemTags has
     10        changed from what it was in Tiger. This causes "Search in Spotlight", "Search in Google", and
     11        "Look Up in Dictionary" to not appear in Tiger Safari if running on tip of tree WebKit.
     12
     13        * WebView.subproj/WebUIDelegatePrivate.h:
     14        removed WebMenuItemTagSearchInSpotlight, WebMenuItemTagSearchInGoogle, and WebMenuItemTagLookUpInDictionary
     15
     16        * WebView.subproj/WebUIDelegate.h:
     17        added WebMenuItemTagSearchInSpotlight, WebMenuItemTagSearchWeb, and WebMenuItemTagLookUpInDictionary
     18
     19        * WebView.subproj/WebDefaultContextMenuDelegate.m:
     20        (-[WebDefaultUIDelegate menuItemWithTag:]):
     21        updated for rename
     22        (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
     23        ditto
     24        (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
     25        ditto
     26       
    1272005-08-01  Geoffrey Garen  <ggaren@apple.com>
    228

  • trunk/WebKit/WebView.subproj/WebDefaultContextMenuDelegate.m

    r9826 r10008  
    160160            action = @selector(_searchWithSpotlightFromMenu:);
    161161            break;
    162         case WebMenuItemTagSearchInGoogle:
     162        case WebMenuItemTagSearchWeb:
    163163            // FIXME: Perhaps move this string into WebKit directly when we're not in localization freeze
    164164            title = localizedMenuTitleFromAppKit(@"Search in Google", @"Search in Google menu title.");
    … …  
    240240            ASSERT([[[webFrame frameView] documentView] conformsToProtocol:@protocol(WebDocumentText)]);
    241241            [menuItems addObject:[self menuItemWithTag:WebMenuItemTagSearchInSpotlight]];
    242             [menuItems addObject:[self menuItemWithTag:WebMenuItemTagSearchInGoogle]];
     242            [menuItems addObject:[self menuItemWithTag:WebMenuItemTagSearchWeb]];
    243243            [menuItems addObject:[NSMenuItem separatorItem]];
    244244
    … …  
    313313    // FIXME: When we're not building for Panther anymore we should update the nib to include these.
    314314    [menuItems addObject:[self menuItemWithTag:WebMenuItemTagSearchInSpotlight]];
    315     [menuItems addObject:[self menuItemWithTag:WebMenuItemTagSearchInGoogle]];
     315    [menuItems addObject:[self menuItemWithTag:WebMenuItemTagSearchWeb]];
    316316    [menuItems addObject:[NSMenuItem separatorItem]];
    317317    // FIXME: The NSTextView behavior for looking text up in the dictionary is different if

  • trunk/WebKit/WebView.subproj/WebUIDelegate.h

    r9471 r10008  
    5757    WebMenuItemTagLearnSpelling,
    5858    WebMenuItemTagOther,
     59    WebMenuItemTagSearchInSpotlight,
     60    WebMenuItemTagSearchWeb,
     61    WebMenuItemTagLookUpInDictionary,
    5962    WebMenuItemTagOpenWithDefaultApplication,
    6063    WebMenuItemPDFActualSize,

  • trunk/WebKit/WebView.subproj/WebUIDelegatePrivate.h

    r9276 r10008  
    2929#import <WebKit/WebUIDelegate.h>
    3030
    31 // FIXME: These should move to WebUIDelegate.h as part of the WebMenuItemTag enum there, when we're not in API freeze
    32 enum {
    33     WebMenuItemTagSearchInSpotlight=1000,
    34     WebMenuItemTagSearchInGoogle,
    35     WebMenuItemTagLookUpInDictionary,
    36 };
    37 
    3831@interface NSObject (WebUIDelegatePrivate)
    3932
Note: See TracChangeset for help on using the changeset viewer.