⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 100180 in webkit


Ignore:
Timestamp:
Nov 14, 2011, 12:50:14 PM (15 years ago)
Author:
scheib@chromium.org
Message:

Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
​https://bugs.webkit.org/show_bug.cgi?id=72286

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:
  • page/MouseLockable.cpp:
  • page/MouseLockable.h:
  • page/MouseLockable.idl:
  • page/Navigator.cpp:
  • page/Navigator.h:
  • page/Navigator.idl:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMouseLockAPI):
(WebKit::WebRuntimeFeatures::isMouseLockAPIEnabled):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMouseLockEnabled):

Location:
trunk/Source
Files:
19 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r100175 r100180  
     12011-11-14  Vincent Scheib  <scheib@chromium.org>
     2
     3        Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
     4        https://bugs.webkit.org/show_bug.cgi?id=72286
     5
     6        Reviewed by Adam Barth.
     7
     8        * wtf/Platform.h:
     9
    1102011-11-14  Gavin Barraclough  <barraclough@apple.com>
    211

  • trunk/Source/JavaScriptCore/wtf/Platform.h

    r100159 r100180  
    864864#endif
    865865
    866 #if !defined(ENABLE_MOUSE_LOCK_API)
    867 #define ENABLE_MOUSE_LOCK_API 0
     866#if !defined(ENABLE_POINTER_LOCK)
     867#define ENABLE_POINTER_LOCK 0
    868868#endif
    869869

  • trunk/Source/WebCore/ChangeLog

    r100178 r100180  
     12011-11-14  Vincent Scheib  <scheib@chromium.org>
     2
     3        Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
     4        https://bugs.webkit.org/show_bug.cgi?id=72286
     5
     6        Reviewed by Adam Barth.
     7
     8        * bindings/generic/RuntimeEnabledFeatures.cpp:
     9        * bindings/generic/RuntimeEnabledFeatures.h:
     10        * dom/MouseEvent.idl:
     11        * dom/MouseRelatedEvent.h:
     12        * page/MouseLockable.cpp:
     13        * page/MouseLockable.h:
     14        * page/MouseLockable.idl:
     15        * page/Navigator.cpp:
     16        * page/Navigator.h:
     17        * page/Navigator.idl:
     18        * page/Settings.cpp:
     19        (WebCore::Settings::Settings):
     20        * page/Settings.h:
     21
    1222011-11-14  Anna Cavender  <annacc@chromium.org>
    223

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

    r100159 r100180  
    165165#endif
    166166
    167 #if ENABLE(MOUSE_LOCK_API)
     167#if ENABLE(POINTER_LOCK)
    168168bool RuntimeEnabledFeatures::isMouseLockAPIEnabled = false;
    169169#endif

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r100159 r100180  
    8181#endif
    8282
    83 #if ENABLE(MOUSE_LOCK_API)
     83#if ENABLE(POINTER_LOCK)
    8484    static bool webkitMouseLockAPIEnabled() { return isMouseLockAPIEnabled; }
    8585    static void setWebkitMouseLockAPIEnabled(bool isEnabled) { isMouseLockAPIEnabled = isEnabled; }
    … …  
    235235#endif
    236236
    237 #if ENABLE(MOUSE_LOCK_API)
     237#if ENABLE(POINTER_LOCK)
    238238    static bool isMouseLockAPIEnabled;
    239239#endif

  • trunk/Source/WebCore/dom/MouseEvent.idl

    r100093 r100180  
    2626        readonly attribute long             clientX;
    2727        readonly attribute long             clientY;
    28 #if defined(ENABLE_MOUSE_LOCK_API) && ENABLE_MOUSE_LOCK_API
     28#if defined(ENABLE_POINTER_LOCK) && ENABLE_POINTER_LOCK
    2929        readonly attribute long             movementX;
    3030        readonly attribute long             movementY;

  • trunk/Source/WebCore/dom/MouseRelatedEvent.h

    r100093 r100180  
    4040        int clientX() const { return m_clientLocation.x(); }
    4141        int clientY() const { return m_clientLocation.y(); }
    42 #if ENABLE(MOUSE_LOCK_API)
     42#if ENABLE(POINTER_LOCK)
    4343        int movementX() const { return m_movementDelta.x(); }
    4444        int movementY() const { return m_movementDelta.y(); }
    … …  
    7777        IntPoint m_screenLocation;
    7878        LayoutPoint m_clientLocation;
    79 #if ENABLE(MOUSE_LOCK_API)
     79#if ENABLE(POINTER_LOCK)
    8080        LayoutPoint m_movementDelta;
    8181#endif

  • trunk/Source/WebCore/page/MouseLockable.cpp

    r100091 r100180  
    2626#include "MouseLockable.h"
    2727
    28 #if ENABLE(MOUSE_LOCK_API)
     28#if ENABLE(POINTER_LOCK)
    2929
    3030namespace WebCore {
    … …  
    5656}
    5757
    58 #endif // ENABLE(MOUSE_LOCK_API)
     58#endif // ENABLE(POINTER_LOCK)

  • trunk/Source/WebCore/page/MouseLockable.h

    r100091 r100180  
    2626#define MouseLockable_h
    2727
    28 #if ENABLE(MOUSE_LOCK_API)
     28#if ENABLE(POINTER_LOCK)
    2929
    3030#include "VoidCallback.h"
    … …  
    5252} // namespace WebCore
    5353
    54 #endif // ENABLE(MOUSE_LOCK_API)
     54#endif // ENABLE(POINTER_LOCK)
    5555
    5656#endif // MouseLockable_h

  • trunk/Source/WebCore/page/MouseLockable.idl

    r100091 r100180  
    2626
    2727    interface [
    28         Conditional=MOUSE_LOCK_API,
     28        Conditional=POINTER_LOCK,
    2929        OmitConstructor
    3030    ] MouseLockable {

  • trunk/Source/WebCore/page/Navigator.cpp

    r100091 r100180  
    172172}
    173173
    174 #if ENABLE(MOUSE_LOCK_API)
     174#if ENABLE(POINTER_LOCK)
    175175MouseLockable* Navigator::webkitPointer() const
    176176{

  • trunk/Source/WebCore/page/Navigator.h

    r100091 r100180  
    6060    Geolocation* geolocation() const;
    6161
    62 #if ENABLE(MOUSE_LOCK_API)
     62#if ENABLE(POINTER_LOCK)
    6363    MouseLockable* webkitPointer() const;
    6464#endif
    … …  
    8181    mutable RefPtr<DOMMimeTypeArray> m_mimeTypes;
    8282    mutable RefPtr<Geolocation> m_geolocation;
    83 #if ENABLE(MOUSE_LOCK_API)
     83#if ENABLE(POINTER_LOCK)
    8484    mutable RefPtr<MouseLockable> m_pointer;
    8585#endif

  • trunk/Source/WebCore/page/Navigator.idl

    r100091 r100180  
    4545#endif
    4646
    47 #if defined(ENABLE_MOUSE_LOCK_API) && ENABLE_MOUSE_LOCK_API
     47#if defined(ENABLE_POINTER_LOCK) && ENABLE_POINTER_LOCK
    4848        readonly attribute [EnabledAtRuntime] MouseLockable webkitPointer;
    4949#endif

  • trunk/Source/WebCore/page/Settings.cpp

    r99485 r100180  
    199199    , m_fullScreenAPIEnabled(false)
    200200#endif
    201 #if ENABLE(MOUSE_LOCK_API)
     201#if ENABLE(POINTER_LOCK)
    202202    , m_mouseLockAPIEnabled(false)
    203203#endif

  • trunk/Source/WebCore/page/Settings.h

    r99485 r100180  
    383383#endif
    384384
    385 #if ENABLE(MOUSE_LOCK_API)
     385#if ENABLE(POINTER_LOCK)
    386386        void setMouseLockEnabled(bool flag) { m_mouseLockAPIEnabled = flag; }
    387387        bool mouseLockEnabled() const  { return m_mouseLockAPIEnabled; }
    … …  
    594594        bool m_fullScreenAPIEnabled : 1;
    595595#endif
    596 #if ENABLE(MOUSE_LOCK_API)
     596#if ENABLE(POINTER_LOCK)
    597597        bool m_mouseLockAPIEnabled : 1;
    598598#endif

  • trunk/Source/WebKit/chromium/ChangeLog

    r100176 r100180  
     12011-11-14  Vincent Scheib  <scheib@chromium.org>
     2
     3        Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
     4        https://bugs.webkit.org/show_bug.cgi?id=72286
     5
     6        Reviewed by Adam Barth.
     7
     8        * features.gypi:
     9        * src/WebRuntimeFeatures.cpp:
     10        (WebKit::WebRuntimeFeatures::enableMouseLockAPI):
     11        (WebKit::WebRuntimeFeatures::isMouseLockAPIEnabled):
     12        * src/WebSettingsImpl.cpp:
     13        (WebKit::WebSettingsImpl::setMouseLockEnabled):
     14
    1152011-11-14  Gregg Tavares  <gman@google.com>
    216

  • trunk/Source/WebKit/chromium/features.gypi

    r98562 r100180  
    7070      'ENABLE_MHTML=1',
    7171      'ENABLE_MICRODATA=0',
    72       'ENABLE_MOUSE_LOCK_API=1',
    7372      'ENABLE_MUTATION_OBSERVERS=<(enable_mutation_observers)',
    7473      'ENABLE_NOTIFICATIONS=1',
    7574      'ENABLE_ORIENTATION_EVENTS=0',
    7675      'ENABLE_PAGE_VISIBILITY_API=1',
     76      'ENABLE_POINTER_LOCK=1',
    7777      'ENABLE_PROGRESS_TAG=1',
    7878      'ENABLE_QUOTA=1',

  • trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp

    r98016 r100180  
    363363void WebRuntimeFeatures::enableMouseLockAPI(bool enable)
    364364{
    365 #if ENABLE(MOUSE_LOCK_API)
     365#if ENABLE(POINTER_LOCK)
    366366    RuntimeEnabledFeatures::setWebkitMouseLockAPIEnabled(enable);
    367367#else
    … …  
    372372bool WebRuntimeFeatures::isMouseLockAPIEnabled()
    373373{
    374 #if ENABLE(MOUSE_LOCK_API)
     374#if ENABLE(POINTER_LOCK)
    375375    return RuntimeEnabledFeatures::webkitMouseLockAPIEnabled();
    376376#else

  • trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp

    r99255 r100180  
    426426void WebSettingsImpl::setMouseLockEnabled(bool enabled)
    427427{
    428 #if ENABLE(MOUSE_LOCK_API)
     428#if ENABLE(POINTER_LOCK)
    429429    m_settings->setMouseLockEnabled(enabled);
    430430#else
Note: See TracChangeset for help on using the changeset viewer.