Changeset 100184 in webkit

Timestamp:

Nov 14, 2011, 1:45:52 PM (15 years ago)

Author:

jchaffraix@webkit.org

Message:

[Chromium] build-webkit silently drops the features flags
​https://bugs.webkit.org/show_bug.cgi?id=72293

Reviewed by Tony Chang.

Chromium still ignores @features but now we give a warning!

• Scripts/build-webkit: Check if one of the features is different

from the default and print a warning in this case.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/build-webkit (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        [Chromium] build-webkit silently drops the features flags
+        https://bugs.webkit.org/show_bug.cgi?id=72293
+
+        Reviewed by Tony Chang.
+
+        Chromium still ignores @features but now we give a warning!
+
+        * Scripts/build-webkit: Check if one of the features is different
+        from the default and print a warning in this case.
+
 2011-11-14  David Kilzer  <ddkilzer@apple.com>
 

trunk/Tools/Scripts/build-webkit

@@ -595 +595 @@
 
 if (isChromium()) {
+    # Currently chromium does not honour the features passed to build-webkit.
+    # Until this is solved, we issue a warning about that.
+    foreach (@features) {
+        if (${$_->{value}} ne $_->{default}) {
+            print "\n";
+            print "===========================================================\n";
+            print " Chromium does not honor the features passed to build-webkit.\n";
+            print " The preferred way is to set up your overrides in ~/.gyp/include.gypi.\n";
+            print " See https://trac.webkit.org/wiki/Chromium#Buildingwithfeaturedefines\n";
+            print " on how to do that.\n";
+            print "===========================================================\n";
+            last;
+        }
+    }
+
     @options = @ARGV;
     # Chromium doesn't build by project directories.