Changeset 100192 in webkit

Timestamp:

Nov 14, 2011, 2:29:04 PM (15 years ago)

Author:

commit-queue@webkit.org

Message:

new-run-webkit-tests should not be locale dependent ​https://bugs.webkit.org/show_bug.cgi?id=68691
Override LOCALE to en_US.

Patch by John Yani <​vanuan@gmail.com> on 2011-11-14
Reviewed by Eric Seidel.

• Scripts/webkitpy/layout_tests/port/base.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/base.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/base_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-11-14  John Yani  <vanuan@gmail.com>
+
+        new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
+        Override LOCALE to en_US.
+
+        Reviewed by Eric Seidel.
+
+        * Scripts/webkitpy/layout_tests/port/base.py:
+
 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -655 +655 @@
            Operating-system's environment.
         """
-        return os.environ.copy()
+        env = os.environ.copy()
+        # FIXME: This is a hack.  Tests shouldn't be locale dependent.
+        # This works only in unix environments.
+        env['LANGUAGE'] = 'en'
+        env['LC_MESSAGES'] = 'en_US.utf8'
+        env['LANG'] = 'en_US.UTF-8'
+        return env
 
     def show_results_html_file(self, results_filename):

trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

@@ -195 +195 @@
         port.setup_test_run()
 
+    def test_setup_environ_for_server(self):
+        port = self.make_port()
+        env = port.setup_environ_for_server()
+        self.assertEquals(env['LANGUAGE'], 'en')
+        self.assertEquals(env['LC_MESSAGES'], 'en_US.utf8')
+        self.assertEquals(env['LANG'], 'en_US.UTF-8')
+
     def test_test_dirs(self):
         filesystem = MockFileSystem({