⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 100194 in webkit


Ignore:
Timestamp:
Nov 14, 2011, 2:39:48 PM (15 years ago)
Author:
scheib@chromium.org
Message:

Mouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
​https://bugs.webkit.org/show_bug.cgi?id=72303

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setPointerLockEnabled):
(WebCore::Settings::PointerLockEnabled):

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • public/WebSettings.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPointerLockEnabled):

  • src/WebSettingsImpl.h:
Location:
trunk/Source
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r100191 r100194  
     12011-11-14  Vincent Scheib  <scheib@chromium.org>
     2
     3        Mouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
     4        https://bugs.webkit.org/show_bug.cgi?id=72303
     5
     6        Reviewed by Darin Fisher.
     7
     8        * bindings/generic/RuntimeEnabledFeatures.cpp:
     9        * bindings/generic/RuntimeEnabledFeatures.h:
     10        (WebCore::RuntimeEnabledFeatures::webkitPointerLockEnabled):
     11        (WebCore::RuntimeEnabledFeatures::setWebkitPointerLockEnabled):
     12        (WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):
     13        * page/Settings.cpp:
     14        (WebCore::Settings::Settings):
     15        * page/Settings.h:
     16        (WebCore::Settings::setPointerLockEnabled):
     17        (WebCore::Settings::PointerLockEnabled):
     18
    1192011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
    220

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

    r100180 r100194  
    166166
    167167#if ENABLE(POINTER_LOCK)
    168 bool RuntimeEnabledFeatures::isMouseLockAPIEnabled = false;
     168bool RuntimeEnabledFeatures::isPointerLockEnabled = false;
    169169#endif
    170170

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r100180 r100194  
    8282
    8383#if ENABLE(POINTER_LOCK)
    84     static bool webkitMouseLockAPIEnabled() { return isMouseLockAPIEnabled; }
    85     static void setWebkitMouseLockAPIEnabled(bool isEnabled) { isMouseLockAPIEnabled = isEnabled; }
    86     static bool webkitPointerEnabled() { return isMouseLockAPIEnabled; }
     84    static bool webkitPointerLockEnabled() { return isPointerLockEnabled; }
     85    static void setWebkitPointerLockEnabled(bool isEnabled) { isPointerLockEnabled = isEnabled; }
     86    static bool webkitPointerEnabled() { return isPointerLockEnabled; }
    8787#endif
    8888
    … …  
    236236
    237237#if ENABLE(POINTER_LOCK)
    238     static bool isMouseLockAPIEnabled;
     238    static bool isPointerLockEnabled;
    239239#endif
    240240

  • trunk/Source/WebCore/page/Settings.cpp

    r100180 r100194  
    200200#endif
    201201#if ENABLE(POINTER_LOCK)
    202     , m_mouseLockAPIEnabled(false)
     202    , m_pointerLockEnabled(false)
    203203#endif
    204204    , m_asynchronousSpellCheckingEnabled(false)

  • trunk/Source/WebCore/page/Settings.h

    r100180 r100194  
    384384
    385385#if ENABLE(POINTER_LOCK)
    386         void setMouseLockEnabled(bool flag) { m_mouseLockAPIEnabled = flag; }
    387         bool mouseLockEnabled() const  { return m_mouseLockAPIEnabled; }
     386        void setPointerLockEnabled(bool flag) { m_pointerLockEnabled = flag; }
     387        bool PointerLockEnabled() const  { return m_pointerLockEnabled; }
    388388#endif
    389389
    … …  
    595595#endif
    596596#if ENABLE(POINTER_LOCK)
    597         bool m_mouseLockAPIEnabled : 1;
     597        bool m_pointerLockEnabled : 1;
    598598#endif
    599599        bool m_asynchronousSpellCheckingEnabled: 1;

  • trunk/Source/WebKit/chromium/ChangeLog

    r100191 r100194  
     12011-11-14  Vincent Scheib  <scheib@chromium.org>
     2
     3        Mouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
     4        https://bugs.webkit.org/show_bug.cgi?id=72303
     5
     6        Reviewed by Darin Fisher.
     7
     8        * public/WebRuntimeFeatures.h:
     9        * public/WebSettings.h:
     10        * src/WebRuntimeFeatures.cpp:
     11        (WebKit::WebRuntimeFeatures::enablePointerLock):
     12        (WebKit::WebRuntimeFeatures::isPointerLockEnabled):
     13        * src/WebSettingsImpl.cpp:
     14        (WebKit::WebSettingsImpl::setPointerLockEnabled):
     15        * src/WebSettingsImpl.h:
     16
    1172011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
    218

  • trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h

    r98016 r100194  
    110110    WEBKIT_EXPORT static bool isFullScreenAPIEnabled();
    111111
    112     WEBKIT_EXPORT static void enableMouseLockAPI(bool);
    113     WEBKIT_EXPORT static bool isMouseLockAPIEnabled();
     112    WEBKIT_EXPORT static void enablePointerLock(bool);
     113    WEBKIT_EXPORT static bool isPointerLockEnabled();
    114114
    115115    WEBKIT_EXPORT static void enableMediaSource(bool);

  • trunk/Source/WebKit/chromium/public/WebSettings.h

    r99255 r100194  
    127127    virtual void setMinimumTimerInterval(double) = 0;
    128128    virtual void setFullScreenEnabled(bool) = 0;
    129     virtual void setMouseLockEnabled(bool) = 0;
     129    virtual void setPointerLockEnabled(bool) = 0;
    130130    virtual void setAllowDisplayOfInsecureContent(bool) = 0;
    131131    virtual void setAllowRunningOfInsecureContent(bool) = 0;

  • trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp

    r100180 r100194  
    361361}
    362362
    363 void WebRuntimeFeatures::enableMouseLockAPI(bool enable)
     363void WebRuntimeFeatures::enablePointerLock(bool enable)
    364364{
    365365#if ENABLE(POINTER_LOCK)
    366     RuntimeEnabledFeatures::setWebkitMouseLockAPIEnabled(enable);
     366    RuntimeEnabledFeatures::setWebkitPointerLockEnabled(enable);
    367367#else
    368368    UNUSED_PARAM(enable);
    … …  
    370370}
    371371
    372 bool WebRuntimeFeatures::isMouseLockAPIEnabled()
     372bool WebRuntimeFeatures::isPointerLockEnabled()
    373373{
    374374#if ENABLE(POINTER_LOCK)
    375     return RuntimeEnabledFeatures::webkitMouseLockAPIEnabled();
     375    return RuntimeEnabledFeatures::webkitPointerLockEnabled();
    376376#else
    377377    return false;

  • trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp

    r100180 r100194  
    424424}
    425425
    426 void WebSettingsImpl::setMouseLockEnabled(bool enabled)
     426void WebSettingsImpl::setPointerLockEnabled(bool enabled)
    427427{
    428428#if ENABLE(POINTER_LOCK)
    429     m_settings->setMouseLockEnabled(enabled);
     429    m_settings->setPointerLockEnabled(enabled);
    430430#else
    431431    UNUSED_PARAM(enabled);

  • trunk/Source/WebKit/chromium/src/WebSettingsImpl.h

    r99255 r100194  
    119119    virtual void setMinimumTimerInterval(double);
    120120    virtual void setFullScreenEnabled(bool);
    121     virtual void setMouseLockEnabled(bool);
     121    virtual void setPointerLockEnabled(bool);
    122122    virtual void setAllowDisplayOfInsecureContent(bool);
    123123    virtual void setAllowRunningOfInsecureContent(bool);
Note: See TracChangeset for help on using the changeset viewer.