Changeset 100214 in webkit

Timestamp:

Nov 14, 2011, 4:34:35 PM (15 years ago)

Author:

Simon Fraser

Message:

div with webkit-transform + webkit-box-reflect disappears when switching tabs
​https://bugs.webkit.org/show_bug.cgi?id=53355

Reviewed by Dean Jackson.

Tickle Core Animation into updating the layer's content property when
switching back to a tab which has composited reflections. This hack is
needed becuase reflections involve sharing layer contents between layers.

• platform/graphics/mac/WebLayer.mm:

(-[WebLayer actionForKey:]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/mac/WebLayer.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-14  Simon Fraser  <simon.fraser@apple.com>
+
+        div with webkit-transform + webkit-box-reflect disappears when switching tabs
+        https://bugs.webkit.org/show_bug.cgi?id=53355
+
+        Reviewed by Dean Jackson.
+
+        Tickle Core Animation into updating the layer's content property when
+        switching back to a tab which has composited reflections. This hack is
+        needed becuase reflections involve sharing layer contents between layers.
+
+        * platform/graphics/mac/WebLayer.mm:
+        (-[WebLayer actionForKey:]):
+
 2011-11-14  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm

@@ -37 +37 @@
 #import <wtf/UnusedParam.h>
 
+@interface CALayer(WebCoreCALayerPrivate)
+- (void)reloadValueForKeyPath:(NSString *)keyPath;
+@end
+
 using namespace WebCore;
 
@@ -147 +151 @@
 }
 
-// Disable default animations
 - (id<CAAction>)actionForKey:(NSString *)key
 {
-    UNUSED_PARAM(key);
+    // Fix for <rdar://problem/9015675>: Force the layer content to be updated when the tree is reparented.
+    if ([key isEqualToString:@"onOrderIn"])
+        [self reloadValueForKeyPath:@"contents"];
+
     return nil;
 }