Changeset 100225 in webkit

Timestamp:

Nov 14, 2011, 5:43:16 PM (15 years ago)

Author:

commit-queue@webkit.org

Message:

Remove unnecessary #include SVGResourcesCache.h in SVGDocumentExtensions.h; use forward declaration
​https://bugs.webkit.org/show_bug.cgi?id=72335

Patch by Daniel Bates <​dbates@rim.com> on 2011-11-14
Reviewed by Eric Seidel.

It's sufficient to forward declare SVGResourcesCache in SVGDocumentExtensions.h and #include SVGResourcesCache.h
in SVGDocumentExtensions.cpp. This will reduce the number of files we need to re-compile after the file
SVGResourcesCache.h has been modified. Currently we #include SVGResourcesCache.h in SVGDocumentExtensions.h.

• rendering/svg/RenderSVGBlock.cpp: Include SVGResourcesCache.h.
• rendering/svg/RenderSVGContainer.cpp: Ditto.
• rendering/svg/RenderSVGForeignObject.cpp: Ditto.
• rendering/svg/RenderSVGImage.cpp: Ditto.
• rendering/svg/RenderSVGInline.cpp: Ditto.
• rendering/svg/RenderSVGModelObject.cpp: Ditto.
• rendering/svg/RenderSVGPath.cpp: Ditto.
• rendering/svg/RenderSVGResource.cpp: Ditto.
• rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
• rendering/svg/RenderSVGResourceContainer.cpp: Ditto.
• rendering/svg/RenderSVGRoot.cpp: Ditto.
• rendering/svg/RenderSVGText.cpp: Ditto.
• rendering/svg/SVGInlineTextBox.cpp: Ditto.
• rendering/svg/SVGRenderSupport.cpp: Ditto.
• svg/SVGDocumentExtensions.cpp: Ditto.
• svg/SVGDocumentExtensions.h: Forward declare SVGResourcesCache.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/svg/RenderSVGBlock.cpp (modified) (1 diff)
• rendering/svg/RenderSVGContainer.cpp (modified) (1 diff)
• rendering/svg/RenderSVGForeignObject.cpp (modified) (1 diff)
• rendering/svg/RenderSVGImage.cpp (modified) (1 diff)
• rendering/svg/RenderSVGInline.cpp (modified) (1 diff)
• rendering/svg/RenderSVGModelObject.cpp (modified) (1 diff)
• rendering/svg/RenderSVGPath.cpp (modified) (1 diff)
• rendering/svg/RenderSVGResource.cpp (modified) (1 diff)
• rendering/svg/RenderSVGResourceClipper.cpp (modified) (1 diff)
• rendering/svg/RenderSVGResourceContainer.cpp (modified) (1 diff)
• rendering/svg/RenderSVGRoot.cpp (modified) (1 diff)
• rendering/svg/RenderSVGText.cpp (modified) (1 diff)
• rendering/svg/SVGInlineTextBox.cpp (modified) (1 diff)
• rendering/svg/SVGRenderSupport.cpp (modified) (1 diff)
• svg/SVGDocumentExtensions.cpp (modified) (1 diff)
• svg/SVGDocumentExtensions.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-14  Daniel Bates  <dbates@rim.com>
+
+        Remove unnecessary #include SVGResourcesCache.h in SVGDocumentExtensions.h; use forward declaration
+        https://bugs.webkit.org/show_bug.cgi?id=72335
+
+        Reviewed by Eric Seidel.
+
+        It's sufficient to forward declare SVGResourcesCache in SVGDocumentExtensions.h and #include SVGResourcesCache.h
+        in SVGDocumentExtensions.cpp. This will reduce the number of files we need to re-compile after the file
+        SVGResourcesCache.h has been modified. Currently we #include SVGResourcesCache.h in SVGDocumentExtensions.h.
+
+        * rendering/svg/RenderSVGBlock.cpp: Include SVGResourcesCache.h.
+        * rendering/svg/RenderSVGContainer.cpp: Ditto.
+        * rendering/svg/RenderSVGForeignObject.cpp: Ditto.
+        * rendering/svg/RenderSVGImage.cpp: Ditto.
+        * rendering/svg/RenderSVGInline.cpp: Ditto.
+        * rendering/svg/RenderSVGModelObject.cpp: Ditto.
+        * rendering/svg/RenderSVGPath.cpp: Ditto.
+        * rendering/svg/RenderSVGResource.cpp: Ditto.
+        * rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
+        * rendering/svg/RenderSVGResourceContainer.cpp: Ditto.
+        * rendering/svg/RenderSVGRoot.cpp: Ditto.
+        * rendering/svg/RenderSVGText.cpp: Ditto.
+        * rendering/svg/SVGInlineTextBox.cpp: Ditto.
+        * rendering/svg/SVGRenderSupport.cpp: Ditto.
+        * svg/SVGDocumentExtensions.cpp: Ditto.
+        * svg/SVGDocumentExtensions.h: Forward declare SVGResourcesCache.
+
 2011-11-14  Rafael Weinstein  <rafaelw@chromium.org>
 

trunk/Source/WebCore/rendering/svg/RenderSVGBlock.cpp

@@ -27 +27 @@
 #include "RenderSVGResource.h"
 #include "SVGElement.h"
+#include "SVGResourcesCache.h"
 
 namespace WebCore {

trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp

@@ -34 +34 @@
 #include "SVGRenderSupport.h"
 #include "SVGResources.h"
+#include "SVGResourcesCache.h"
 #include "SVGStyledElement.h"
 

trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp

@@ -31 +31 @@
 #include "SVGForeignObjectElement.h"
 #include "SVGRenderSupport.h"
+#include "SVGResourcesCache.h"
 #include "SVGSVGElement.h"
 #include "TransformState.h"

trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp

@@ -44 +44 @@
 #include "SVGRenderSupport.h"
 #include "SVGResources.h"
+#include "SVGResourcesCache.h"
 
 namespace WebCore {

trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp

@@ -28 +28 @@
 #include "RenderSVGText.h"
 #include "SVGInlineFlowBox.h"
+#include "SVGResourcesCache.h"
 
 namespace WebCore {

trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp

@@ -35 +35 @@
 
 #include "RenderSVGResource.h"
+#include "SVGResourcesCache.h"
 #include "SVGStyledElement.h"
 

trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp

@@ -41 +41 @@
 #include "SVGRenderSupport.h"
 #include "SVGResources.h"
+#include "SVGResourcesCache.h"
 #include "SVGStyledTransformableElement.h"
 #include "SVGTransformList.h"

trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp

@@ -29 +29 @@
 #include "RenderSVGResourceSolidColor.h"
 #include "SVGResources.h"
+#include "SVGResourcesCache.h"
 #include "SVGURIReference.h"
 

trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp

@@ -42 +42 @@
 #include "SVGRenderSupport.h"
 #include "SVGResources.h"
+#include "SVGResourcesCache.h"
 #include "SVGStyledElement.h"
 #include "SVGStyledTransformableElement.h"

trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp

@@ -24 +24 @@
 
 #include "RenderSVGShadowTreeRootContainer.h"
+#include "SVGResourcesCache.h"
 #include "SVGStyledTransformableElement.h"
 

trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp

@@ -41 +41 @@
 #include "SVGRenderSupport.h"
 #include "SVGResources.h"
+#include "SVGResourcesCache.h"
 #include "SVGSVGElement.h"
 #include "SVGStyledElement.h"

trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp

@@ -40 +40 @@
 #include "SVGLengthList.h"
 #include "SVGRenderSupport.h"
+#include "SVGResourcesCache.h"
 #include "SVGRootInlineBox.h"
 #include "SVGTextElement.h"

trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp

@@ -35 +35 @@
 #include "RenderSVGResourceSolidColor.h"
 #include "SVGImageBufferTools.h"
+#include "SVGResourcesCache.h"
 #include "SVGRootInlineBox.h"
 #include "SVGTextRunRenderingContext.h"

trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp

@@ -40 +40 @@
 #include "RenderSVGRoot.h"
 #include "SVGResources.h"
+#include "SVGResourcesCache.h"
 #include "SVGStyledElement.h"
 #include "TransformState.h"

trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp

@@ -34 +34 @@
 #include "SMILTimeContainer.h"
 #include "SVGElement.h"
+#include "SVGResourcesCache.h"
 #include "SVGSMILElement.h"
 #include "SVGSVGElement.h"

trunk/Source/WebCore/svg/SVGDocumentExtensions.h

@@ -23 +23 @@
 
 #if ENABLE(SVG)
-#include "SVGResourcesCache.h"
 #include <wtf/Forward.h>
 #include <wtf/HashMap.h>
@@ -36 +35 @@
 class RenderSVGResourceContainer;
 class SVGElement;
-class SVGStyledElement;
+class SVGResourcesCache;
 class SVGSMILElement;
 class SVGSVGElement;
+class SVGStyledElement;
 
 class SVGDocumentExtensions {