Changeset 101157 in webkit

Timestamp:

Nov 25, 2011, 1:31:20 AM (15 years ago)

Author:

haraken@chromium.org

Message:

Remove WebCore.gyp/scripts/rule_binding.py
​https://bugs.webkit.org/show_bug.cgi?id=73109

Reviewed by Adam Barth.

rule_binding.py is used by WebCore.gyp only. rule_binding.py is just a wrapper
of generate-bindings.pl and thus we can remove it.

No new tests. No change in behavior.

• WebCore.gyp/WebCore.gyp: Replaces rule_binding.py with generate-bindings.pl.
• WebCore.gyp/scripts/rule_binding.py: Removed.
• bindings/scripts/preprocessor.pm: When '"ENABLE_SOMETHING=1" "ENABLE_OTHERS=0"' is passed as a define macro, the string is passed to our perl scripts without the double-quotations (") omitted. We need to omit the double quatations here.

(applyPreprocessor):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gyp/WebCore.gyp (modified) (1 diff)
• WebCore.gyp/scripts/rule_binding.py (deleted)
• bindings/scripts/preprocessor.pm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-25  Kentaro Hara  <haraken@chromium.org>
+
+        Remove WebCore.gyp/scripts/rule_binding.py
+        https://bugs.webkit.org/show_bug.cgi?id=73109
+
+        Reviewed by Adam Barth.
+
+        rule_binding.py is used by WebCore.gyp only. rule_binding.py is just a wrapper
+        of generate-bindings.pl and thus we can remove it.
+
+        No new tests. No change in behavior.
+
+        * WebCore.gyp/WebCore.gyp: Replaces rule_binding.py with generate-bindings.pl.
+        * WebCore.gyp/scripts/rule_binding.py: Removed.
+        * bindings/scripts/preprocessor.pm: When '"ENABLE_SOMETHING=1" "ENABLE_OTHERS=0"' is passed as a define macro, the string is passed to our perl scripts without the double-quotations (") omitted. We need to omit the double quatations here.
+        (applyPreprocessor):
+
 2011-11-24  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

@@ -963 +963 @@
           # behavior, change the output location.
           'action': [
-            'python',
-            'scripts/rule_binding.py',
+            'perl',
+            '-w',
+            '-I../bindings/scripts',
+            '../bindings/scripts/generate-bindings.pl',
+            '--outputHeadersDir',
+            '<(SHARED_INTERMEDIATE_DIR)/webkit/bindings',
+            '--outputDir',
+            '<(SHARED_INTERMEDIATE_DIR)/webcore/bindings',
+            '--defines',
+            '<(feature_defines) LANGUAGE_JAVASCRIPT V8_BINDING',
+            '--generator',
+            'V8',
+            '<@(generator_include_dirs)',
             '<(RULE_INPUT_PATH)',
-            '<(SHARED_INTERMEDIATE_DIR)/webcore/bindings',
-            '<(SHARED_INTERMEDIATE_DIR)/webkit/bindings',
-            '--',
-            '<@(_inputs)',
-            '--',
-            '--defines', '<(feature_defines) LANGUAGE_JAVASCRIPT V8_BINDING',
-            '--generator', 'V8',
-            '<@(generator_include_dirs)'
           ],
           'message': 'Generating binding from <(RULE_INPUT_PATH)',

trunk/Source/WebCore/bindings/scripts/preprocessor.pm

@@ -58 +58 @@
     }
 
-    my $pid = open2(\*PP_OUT, \*PP_IN, split(' ', $preprocessor), (map { "-D$_" } split(' ', $defines)), $fileName);
+    my $pid = open2(\*PP_OUT, \*PP_IN, split(' ', $preprocessor), (map { $_ =~ s/^\"|\"$//g; "-D$_" if $_ } split(' ', $defines)), $fileName);
     close PP_IN;
     my @documentContent = <PP_OUT>;