Changeset 101175 in webkit

Timestamp:

Nov 25, 2011, 8:46:42 AM (15 years ago)

Author:

andreas.kling@nokia.com

Message:

Remove redundant setStrictParsing(false) calls on CSSMappedAttributeDeclarations.
<​http://webkit.org/b/73134>

Reviewed by Antti Koivisto.

CSSMappedAttributeDeclarations always use non-strict parsing since they use
the argument-less CSSMutableStyleDeclaration constructor.

• dom/StyledElement.cpp:

(WebCore::StyledElement::createMappedDecl):

• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/StyledElement.cpp (modified) (1 diff)
• html/HTMLTableElement.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-25  Andreas Kling  <kling@webkit.org>
+
+        Remove redundant setStrictParsing(false) calls on CSSMappedAttributeDeclarations.
+        <http://webkit.org/b/73134>
+
+        Reviewed by Antti Koivisto.
+
+        CSSMappedAttributeDeclarations always use non-strict parsing since they use
+        the argument-less CSSMutableStyleDeclaration constructor.
+
+        * dom/StyledElement.cpp:
+        (WebCore::StyledElement::createMappedDecl):
+        * html/HTMLTableElement.cpp:
+        (WebCore::HTMLTableElement::additionalAttributeStyleDecls):
+        (WebCore::HTMLTableElement::addSharedCellBordersDecl):
+        (WebCore::HTMLTableElement::addSharedCellPaddingDecl):
+        (WebCore::HTMLTableElement::addSharedGroupDecls):
+
 2011-11-25  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/dom/StyledElement.cpp

@@ -408 +408 @@
     decl->setParentStyleSheet(document()->elementSheet());
     decl->setElement(this);
-    decl->setStrictParsing(false); // Mapped attributes are just always quirky.
 }
 

trunk/Source/WebCore/html/HTMLTableElement.cpp

@@ -458 +458 @@
         decl->setParentStyleSheet(document()->elementSheet());
         decl->setElement(this);
-        decl->setStrictParsing(false); // Mapped attributes are just always quirky.
         
         int v = m_borderColorAttr ? CSSValueSolid : CSSValueOutset;
@@ -516 +515 @@
         decl->setParentStyleSheet(document()->elementSheet());
         decl->setElement(this);
-        decl->setStrictParsing(false); // Mapped attributes are just always quirky.
         
         switch (borders) {
@@ -575 +573 @@
             m_paddingDecl->setParentStyleSheet(document()->elementSheet());
             m_paddingDecl->setElement(this);
-            m_paddingDecl->setStrictParsing(false); // Mapped attributes are just always quirky.
             
             m_paddingDecl->setProperty(CSSPropertyPaddingTop, paddingValue, false);
@@ -602 +599 @@
         decl->setParentStyleSheet(document()->elementSheet());
         decl->setElement(this);
-        decl->setStrictParsing(false); // Mapped attributes are just always quirky.
         
         if (rows) {