Changeset 101176 in webkit

Timestamp:

Nov 25, 2011, 9:47:56 AM (15 years ago)

Author:

yurys@chromium.org

Message:

[Chromium] Web Inspector: assertion failure in InspectorController::restoreInspectorStateFromCookie
​https://bugs.webkit.org/show_bug.cgi?id=73136

Don't call connectFrontend twice on reattach.

Reviewed by Pavel Feldman.

• src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::reattach):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebDevToolsAgentImpl.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
+
+        [Chromium] Web Inspector: assertion failure in InspectorController::restoreInspectorStateFromCookie
+        https://bugs.webkit.org/show_bug.cgi?id=73136
+
+        Don't call connectFrontend twice on reattach.
+
+        Reviewed by Pavel Feldman.
+
+        * src/WebDevToolsAgentImpl.cpp:
+        (WebKit::WebDevToolsAgentImpl::reattach):
+
 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp

@@ -202 +202 @@
 void WebDevToolsAgentImpl::reattach(const WebString& savedState)
 {
-    attach();
+    if (m_attached)
+        return;
+
+    ClientMessageLoopAdapter::ensureClientMessageLoopCreated(m_client);
     inspectorController()->restoreInspectorStateFromCookie(savedState);
+    m_attached = true;
 }