Changeset 101181 in webkit

Timestamp:

Nov 25, 2011, 1:52:58 PM (15 years ago)

Author:

commit-queue@webkit.org

Message:

[Chromium] The DrawingBuffer::bind method was incorrectly resetting the
GL viewport parameters. This was unnecessary, and resulted in the corruption
of the WebGL context's state.
​https://bugs.webkit.org/show_bug.cgi?id=73091

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-11-25
Reviewed by Stephen White.

Tests: fast/canvas/webgl/webgl-viewport-parameters-preserved.html

Source/WebCore:

• platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::bind):

LayoutTests:

• fast/canvas/webgl/webgl-viewport-parameters-preserved-expected.txt: Added.
• fast/canvas/webgl/webgl-viewport-parameters-preserved.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/webgl/webgl-viewport-parameters-preserved-expected.txt (added)
• LayoutTests/fast/canvas/webgl/webgl-viewport-parameters-preserved.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-11-25  Jeff Timanus  <twiz@chromium.org>
+
+        [Chromium] The DrawingBuffer::bind method was incorrectly resetting the
+        GL viewport parameters. This was unnecessary, and resulted in the corruption
+        of the WebGL context's state.
+        https://bugs.webkit.org/show_bug.cgi?id=73091
+
+        Reviewed by Stephen White.
+
+        Tests: fast/canvas/webgl/webgl-viewport-parameters-preserved.html
+
+        * fast/canvas/webgl/webgl-viewport-parameters-preserved-expected.txt: Added.
+        * fast/canvas/webgl/webgl-viewport-parameters-preserved.html: Added.
+
 2011-11-25  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-25  Jeff Timanus  <twiz@chromium.org>
+
+        [Chromium] The DrawingBuffer::bind method was incorrectly resetting the
+        GL viewport parameters. This was unnecessary, and resulted in the corruption
+        of the WebGL context's state.
+        https://bugs.webkit.org/show_bug.cgi?id=73091
+
+        Reviewed by Stephen White.
+
+        Tests: fast/canvas/webgl/webgl-viewport-parameters-preserved.html
+
+        * platform/graphics/gpu/DrawingBuffer.cpp:
+        (WebCore::DrawingBuffer::bind):
+
 2011-11-25  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp

@@ -369 +369 @@
     if (!m_context)
         return;
-        
+
     m_context->bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, m_multisampleFBO ? m_multisampleFBO : m_fbo);
-    m_context->viewport(0, 0, m_size.width(), m_size.height());
 }