⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 101184 in webkit


Ignore:
Timestamp:
Nov 25, 2011, 4:34:33 PM (15 years ago)
Author:
haraken@chromium.org
Message:

Refactoring CodeGenerator*.pm for bug 72138
​https://bugs.webkit.org/show_bug.cgi?id=73115

Reviewed by Adam Barth.

Tests: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorGObject.pm: Added "1;" at the end since this perl script is loaded as a package.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto. Removed unnecessary variable names from method declarations in order to supress style check errors when a new run-bindings-tests IDL is added.

(GenerateHeaderCustomCall):

  • bindings/scripts/test/V8/V8TestObj.h: Updated a run-bindings-tests result.
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r101183 r101184  
     12011-11-25  Kentaro Hara  <haraken@chromium.org>
     2
     3        Refactoring CodeGenerator*.pm for bug 72138
     4        https://bugs.webkit.org/show_bug.cgi?id=73115
     5
     6        Reviewed by Adam Barth.
     7
     8        Tests: bindings/scripts/test/TestObj.idl
     9
     10        * bindings/scripts/CodeGeneratorGObject.pm: Added "1;" at the end since this perl script is loaded as a package.
     11        * bindings/scripts/CodeGeneratorV8.pm: Ditto. Removed unnecessary variable names from method declarations in order to supress style check errors when a new run-bindings-tests IDL is added.
     12        (GenerateHeaderCustomCall):
     13        * bindings/scripts/test/V8/V8TestObj.h: Updated a run-bindings-tests result.
     14
    1152011-11-25  Kentaro Hara  <haraken@chromium.org>
    216

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm

    r98715 r101184  
    13811381    $object->WriteData($fname);
    13821382}
     1383
     13841;

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r101118 r101184  
    396396            || $attrExt->{"V8Custom"} || $attrExt->{"Custom"}) {
    397397            push(@headerContent, <<END);
    398     static v8::Handle<v8::Value> ${name}AccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);
     398    static v8::Handle<v8::Value> ${name}AccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);
    399399END
    400400        }
    … …  
    402402            || $attrExt->{"V8Custom"} || $attrExt->{"Custom"}) {
    403403            push(@headerContent, <<END);
    404     static void ${name}AccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info);
     404    static void ${name}AccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value>, const v8::AccessorInfo&);
    405405END
    406406        }
    … …  
    640640    }
    641641    if ($dataNode->name eq "Event") {
    642         push(@headerContent, "    static v8::Handle<v8::Value> dataTransferAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
    643         push(@headerContent, "    static void valueAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info);\n");
     642        push(@headerContent, "    static v8::Handle<v8::Value> dataTransferAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
     643        push(@headerContent, "    static void valueAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value>, const v8::AccessorInfo&);\n");
    644644    }
    645645    if ($dataNode->name eq "Location") {
    646         push(@headerContent, "    static v8::Handle<v8::Value> assignAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
    647         push(@headerContent, "    static v8::Handle<v8::Value> reloadAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
    648         push(@headerContent, "    static v8::Handle<v8::Value> replaceAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
     646        push(@headerContent, "    static v8::Handle<v8::Value> assignAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
     647        push(@headerContent, "    static v8::Handle<v8::Value> reloadAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
     648        push(@headerContent, "    static v8::Handle<v8::Value> replaceAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
    649649    }
    650650}
    … …  
    38243824    print "\n";
    38253825}
     3826
     38271;

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h

    r99900 r101184  
    4747    static v8::Handle<v8::Value> customMethodWithArgsCallback(const v8::Arguments&);
    4848    static v8::Handle<v8::Value> constructorCallback(const v8::Arguments&);
    49     static v8::Handle<v8::Value> customAttrAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);
    50     static void customAttrAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info);
     49    static v8::Handle<v8::Value> customAttrAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);
     50    static void customAttrAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value>, const v8::AccessorInfo&);
    5151    static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 0;
    5252    static v8::Handle<v8::Object> existingWrapper(TestObj*);
Note: See TracChangeset for help on using the changeset viewer.