Changeset 101208 in webkit

Timestamp:

Nov 27, 2011, 12:34:10 PM (15 years ago)

Author:

commit-queue@webkit.org

Message:

CSSMutableStyleDeclaration: setCssText() mostly duplicates parseDeclaration().
<​http://webkit.org/b/73171>

Patch by Andreas Kling <​kling@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.

Let setCssText() call parseDeclaration() instead of duplicating the functionality.

• css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setCssText):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSMutableStyleDeclaration.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-27  Andreas Kling  <kling@webkit.org>
+
+        CSSMutableStyleDeclaration: setCssText() mostly duplicates parseDeclaration().
+        <http://webkit.org/b/73171>
+
+        Reviewed by Antti Koivisto.
+
+        Let setCssText() call parseDeclaration() instead of duplicating the functionality.
+
+        * css/CSSMutableStyleDeclaration.cpp:
+        (WebCore::CSSMutableStyleDeclaration::setCssText):
+
 2011-11-27  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp

@@ -895 +895 @@
 void CSSMutableStyleDeclaration::setCssText(const String& text, ExceptionCode& ec)
 {
-    ASSERT(!m_iteratorCount);
-
-#if ENABLE(MUTATION_OBSERVERS)
-    StyleAttributeMutationScope mutationScope(this);
-#endif
-
     ec = 0;
-    m_properties.clear();
-    CSSParser parser(useStrictParsing());
-    parser.parseDeclaration(this, text);
-
-#if ENABLE(MUTATION_OBSERVERS)
-    mutationScope.enqueueMutationRecord();
-#endif
-
     // FIXME: Detect syntax errors and set ec.
-    setNeedsStyleRecalc();
+    parseDeclaration(text);
 }