Changeset 101210 in webkit

Timestamp:

Nov 27, 2011, 1:13:47 PM (15 years ago)

Author:

annacc@chromium.org

Message:

Don't allow attribute changes on <track> if feature is not enabled.
​https://bugs.webkit.org/show_bug.cgi?id=73046

Reviewed by Eric Carlson.

No new tests. This fixes a problem when --enable-video-track is not used,
but the tests use this flag.

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::attributeChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLTrackElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-27  Anna Cavender  <annacc@chromium.org>
+
+        Don't allow attribute changes on <track> if feature is not enabled.
+        https://bugs.webkit.org/show_bug.cgi?id=73046
+
+        Reviewed by Eric Carlson.
+
+        No new tests. This fixes a problem when --enable-video-track is not used,
+        but the tests use this flag.
+
+        * html/HTMLTrackElement.cpp:
+        (WebCore::HTMLTrackElement::attributeChanged):
+
 2011-11-27  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/html/HTMLTrackElement.cpp

@@ -92 +92 @@
     HTMLElement::attributeChanged(attr, preserveDecls);
 
+    if (!RuntimeEnabledFeatures::webkitVideoTrackEnabled())
+        return;
+
     const QualifiedName& attrName = attr->name();
     if (attrName == srcAttr) {