Changeset 101300 in webkit

Timestamp:

Nov 28, 2011, 4:16:58 PM (15 years ago)

Author:

commit-queue@webkit.org

Message:

FloatQuad::isRectilinear() returns false for 180degree rotations
​https://bugs.webkit.org/show_bug.cgi?id=73040

Patch by Dana Jansens <​danakj@chromium.org> on 2011-11-28
Reviewed by James Robinson.

Source/WebCore:

Added unit test FloatQuadTest.cpp.

• platform/graphics/FloatQuad.cpp:

(WebCore::withinEpsilon): Check two values are as close as can be represented by floats.
(WebCore::FloatQuad::isRectilinear): Use withinEpsilon().

Source/WebKit/chromium:

• WebKit.gypi:
• tests/FloatQuadTest.cpp: Added.

(WebCore::TEST):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/FloatQuad.cpp (modified) (2 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/WebKit.gypi (modified) (1 diff)
• WebKit/chromium/tests/FloatQuadTest.cpp (added)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-28  Dana Jansens  <danakj@chromium.org>
+
+        FloatQuad::isRectilinear() returns false for 180degree rotations
+        https://bugs.webkit.org/show_bug.cgi?id=73040
+
+        Reviewed by James Robinson.
+
+        Added unit test FloatQuadTest.cpp.
+
+        * platform/graphics/FloatQuad.cpp:
+        (WebCore::withinEpsilon): Check two values are as close as can be represented by floats.
+        (WebCore::FloatQuad::isRectilinear): Use withinEpsilon().
+
 2011-11-28  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebCore/platform/graphics/FloatQuad.cpp

@@ -31 +31 @@
 
 #include <algorithm>
+#include <limits>
 
-using std::max;
-using std::min;
+using namespace std;
 
 namespace WebCore {
@@ -86 +86 @@
 }
 
+static inline bool withinEpsilon(float a, float b)
+{
+    return fabs(a - b) < numeric_limits<float>::epsilon();
+}
+
 bool FloatQuad::isRectilinear() const
 {
-    return (m_p1.x() == m_p2.x() && m_p2.y() == m_p3.y() && m_p3.x() == m_p4.x() && m_p4.y() == m_p1.y())
-        || (m_p1.y() == m_p2.y() && m_p2.x() == m_p3.x() && m_p3.y() == m_p4.y() && m_p4.x() == m_p1.x());
+    return (withinEpsilon(m_p1.x(), m_p2.x()) && withinEpsilon(m_p2.y(), m_p3.y()) && withinEpsilon(m_p3.x(), m_p4.x()) && withinEpsilon(m_p4.y(), m_p1.y()))
+        || (withinEpsilon(m_p1.y(), m_p2.y()) && withinEpsilon(m_p2.x(), m_p3.x()) && withinEpsilon(m_p3.y(), m_p4.y()) && withinEpsilon(m_p4.x(), m_p1.x()));
 }
 

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-11-28  Dana Jansens  <danakj@chromium.org>
+
+        FloatQuad::isRectilinear() returns false for 180degree rotations
+        https://bugs.webkit.org/show_bug.cgi?id=73040
+
+        Reviewed by James Robinson.
+
+        * WebKit.gypi:
+        * tests/FloatQuadTest.cpp: Added.
+        (WebCore::TEST):
+
 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit/chromium/WebKit.gypi

@@ -67 +67 @@
             'tests/CCSchedulerTestCommon.h',
             'tests/CCThreadTaskTest.cpp',
+            'tests/FloatQuadTest.cpp',
             'tests/FrameTestHelpers.cpp',
             'tests/FrameTestHelpers.h',