Changeset 102060 in webkit

Timestamp:

Dec 5, 2011, 3:57:28 PM (15 years ago)

Author:

rniwa@webkit.org

Message:

REGRESSION(r101949): css3/bdi-element.html fails on Lion
​https://bugs.webkit.org/show_bug.cgi?id=73859

Reviewed by Dan Bernstein.

The failure was caused by span that contains the text inside bdi in the reference file
was using display: inline-block. Because the width of an inline-block is always rounded up
like any other inline element, it causes the text in the reference file to be one pixel
longer than the one in the test file in certain cases.

Fixed the bug by using unicode-bidi: override instead of display: inline-block in
the reference file.

• css3/bdi-element-expected.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• css3/bdi-element-expected.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r101949): css3/bdi-element.html fails on Lion
+        https://bugs.webkit.org/show_bug.cgi?id=73859
+
+        Reviewed by Dan Bernstein.
+
+        The failure was caused by span that contains the text inside bdi in the reference file
+        was using display: inline-block. Because the width of an inline-block is always rounded up
+        like any other inline element, it causes the text in the reference file to be one pixel
+        longer than the one in the test file in certain cases.
+
+        Fixed the bug by using unicode-bidi: override instead of display: inline-block in
+        the reference file.
+
+        * css3/bdi-element-expected.html:
+
 2011-12-05  Adam Barth  <abarth@webkit.org>
 

trunk/LayoutTests/css3/bdi-element-expected.html

@@ -14 +14 @@
  <li>User jcranmer: 12 posts.
  <li>User hober: 5 posts.
- <li>User <span style="display: inline-block;">إيان</span><span dir="ltr">: 3 posts.</span></span>
+ <li>User <span style="unicode-bidi: embed;">إيان</span><span style="direction: ltr; unicode-bidi: override;">: 3 posts.</span></span>
 </ul>
 </body>