Changeset 102413 in webkit

Timestamp:

Dec 8, 2011 6:28:27 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Caret keeps blinking during forward-delete
​https://bugs.webkit.org/show_bug.cgi?id=38564

Patch by Van Lam <​vanlam@google.com> on 2011-12-08
Reviewed by Darin Adler.

Currently updateAppearance determines if the caret should stop blinking
based on whether or not the editing operation changed the position of
the caret; so the caret stops blinking in case of typing text and
backwards delete (which always displace the caret) but does not stop
blinking in the case of forward delete (which does not displace the
caret).

Added a boolean member function shouldStopCaretBlinking in EditCommand
which will return true if the object is a TypingCommand (my
understanding here is that all TypingCommands should stop the caret
from blinking for a cycle, currently 0.5 seconds). Then used this
function to stop the caret from blinking if the last editing command
is a TypingCommand.

• editing/EditCommand.h:

(WebCore::EditCommand::shouldStopCaretBlinking):

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance):

• editing/TypingCommand.h:

(WebCore::TypingCommand::shouldStopCaretBlinking):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/EditCommand.h (modified) (1 diff)
• editing/FrameSelection.cpp (modified) (1 diff)
• editing/TypingCommand.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-08  Van Lam  <vanlam@google.com>
+
+        Caret keeps blinking during forward-delete
+        https://bugs.webkit.org/show_bug.cgi?id=38564
+
+        Reviewed by Darin Adler.
+
+        Currently updateAppearance determines if the caret should stop blinking
+        based on whether or not the editing operation changed the position of
+        the caret; so the caret stops blinking in case of typing text and
+        backwards delete (which always displace the caret) but does not stop
+        blinking in the case of forward delete (which does not displace the
+        caret).
+
+        Added a boolean member function shouldStopCaretBlinking in EditCommand
+        which will return true if the object is a TypingCommand (my
+        understanding here is that all TypingCommands should stop the caret
+        from blinking for a cycle, currently 0.5 seconds). Then used this
+        function to stop the caret from blinking if the last editing command
+        is a TypingCommand.
+
+        * editing/EditCommand.h:
+        (WebCore::EditCommand::shouldStopCaretBlinking):
+        * editing/FrameSelection.cpp:
+        (WebCore::FrameSelection::updateAppearance):
+        * editing/TypingCommand.h:
+        (WebCore::TypingCommand::shouldStopCaretBlinking):
+
 2011-12-08  Adam Klein  <adamk@chromium.org>
 

trunk/Source/WebCore/editing/EditCommand.h

@@ -66 +66 @@
     virtual bool shouldRetainAutocorrectionIndicator() const;
     virtual void setShouldRetainAutocorrectionIndicator(bool);
+    virtual bool shouldStopCaretBlinking() const { return false; }
 
 protected:

trunk/Source/WebCore/editing/FrameSelection.cpp

@@ -1657 +1657 @@
     bool caretBrowsing = m_frame->settings() && m_frame->settings()->caretBrowsingEnabled();
     bool shouldBlink = caretIsVisible() && isCaret() && (isContentEditable() || caretBrowsing);
+    
+    EditCommand* lastEditCommand = m_frame ? m_frame->editor()->lastEditCommand() : 0;
+    bool shouldStopBlinkingDueToTypingCommand = lastEditCommand && lastEditCommand->shouldStopCaretBlinking();
 
     // If the caret moved, stop the blink timer so we can restart with a
     // black caret in the new location.
-    if (caretRectChanged || !shouldBlink)
+    if (caretRectChanged || !shouldBlink || shouldStopBlinkingDueToTypingCommand)
         m_caretBlinkTimer.stop();
 

trunk/Source/WebCore/editing/TypingCommand.h

@@ -104 +104 @@
     virtual bool shouldRetainAutocorrectionIndicator() const { return m_shouldRetainAutocorrectionIndicator; }
     virtual void setShouldRetainAutocorrectionIndicator(bool retain) { m_shouldRetainAutocorrectionIndicator = retain; }
+    virtual bool shouldStopCaretBlinking() const { return true; }
     void setShouldPreventSpellChecking(bool prevent) { m_shouldPreventSpellChecking = prevent; }