Changeset 105401 in webkit

Timestamp:

Jan 19, 2012, 4:17:09 AM (15 years ago)

Author:

Nikolas Zimmermann

Message:

RenderSVGRoot should inherit from RenderReplaced
​https://bugs.webkit.org/show_bug.cgi?id=76446

Reviewed by Pavel Feldman.

Fix Chromium specific problem with svg/text/select-x-list-4.svg, making it fail on the bots.
After transforming the endPos.x + 1 -> absEndPos.x, subtract -1 again, to be sure we don't
select text too far after the end position, making the selection currently disappear, which
is a bug, but can be avoided in this testcase.

• platform/chromium/test_expectations.txt: Unskip test.
• svg/text/resources/SelectionTestCase.js:

(selectRange): Subtract -1 from absEndPos.x.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/chromium/test_expectations.txt (modified) (1 diff)
• svg/text/resources/SelectionTestCase.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-01-19  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        RenderSVGRoot should inherit from RenderReplaced
+        https://bugs.webkit.org/show_bug.cgi?id=76446
+
+        Reviewed by Pavel Feldman.
+
+        Fix Chromium specific problem with svg/text/select-x-list-4.svg, making it fail on the bots.
+        After transforming the endPos.x + 1 -> absEndPos.x, subtract -1 again, to be sure we don't
+        select text too far after the end position, making the selection currently disappear, which
+        is a bug, but can be avoided in this testcase.
+
+        * platform/chromium/test_expectations.txt: Unskip test.
+        * svg/text/resources/SelectionTestCase.js:
+        (selectRange): Subtract -1 from absEndPos.x.
+
 2012-01-19  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -3857 +3857 @@
 BUGWK76562 : fast/canvas/webgl/drawingbuffer-test.html = TEXT
 
-BUGWK76446 : svg/text/select-x-list-4.svg = IMAGE+TEXT
-
 // This test is passing, but it doesn't seem possible to add GPU+Leopard specific baselines.
 BUGJAMESR LEOPARD GPU : fast/canvas/quadraticCurveTo.xml = IMAGE

trunk/LayoutTests/svg/text/resources/SelectionTestCase.js

@@ -67 +67 @@
         var absStartPos = toAbsoluteCoordinates(startPos, element);
         var absEndPos = toAbsoluteCoordinates(endPos, element);
+        absEndPos.x -= 1;
 
         // Move to selection origin and hold down mouse