Changeset 105549 in webkit


Ignore:
Timestamp:
Jan 20, 2012 3:23:56 PM (12 years ago)
Author:
timothy_horton@apple.com
Message:

Crash in RenderSVGResourceContainer::markAllClientsForInvalidation
​https://bugs.webkit.org/show_bug.cgi?id=76606
<rdar://problem/10720970>

Reviewed by Dirk Schulze.

Notify SVGResourcesCache and superclass when RenderSVGInline is about
to be destroyed, preventing a crash.

Test: svg/custom/crash-inline-container-client.html

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::willBeDestroyed):

  • rendering/svg/RenderSVGInline.h:
  • svg/custom/crash-inline-container-client-expected.txt: Added.
  • svg/custom/crash-inline-container-client.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r105548 r105549  
     12012-01-20  Tim Horton  <timothy_horton@apple.com>
     2
     3        Crash in RenderSVGResourceContainer::markAllClientsForInvalidation
     4        https://bugs.webkit.org/show_bug.cgi?id=76606
     5        <rdar://problem/10720970>
     6
     7        Reviewed by Dirk Schulze.
     8
     9        * svg/custom/crash-inline-container-client-expected.txt: Added.
     10        * svg/custom/crash-inline-container-client.html: Added.
     11
    1122012-01-20  Alexey Proskuryakov  <ap@apple.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r105548 r105549  
     12012-01-20  Tim Horton  <timothy_horton@apple.com>
     2
     3        Crash in RenderSVGResourceContainer::markAllClientsForInvalidation
     4        https://bugs.webkit.org/show_bug.cgi?id=76606
     5        <rdar://problem/10720970>
     6
     7        Reviewed by Dirk Schulze.
     8
     9        Notify SVGResourcesCache and superclass when RenderSVGInline is about
     10        to be destroyed, preventing a crash.
     11
     12        Test: svg/custom/crash-inline-container-client.html
     13
     14        * rendering/svg/RenderSVGInline.cpp:
     15        (WebCore::RenderSVGInline::willBeDestroyed):
     16        * rendering/svg/RenderSVGInline.h:
     17
    1182012-01-20  Alexey Proskuryakov  <ap@apple.com>
    219

  • trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp

    r105143 r105549  
    9696}
    9797
     98void RenderSVGInline::willBeDestroyed()
     99{
     100    SVGResourcesCache::clientDestroyed(this);
     101    RenderInline::willBeDestroyed();
     102}
     103
    98104void RenderSVGInline::styleWillChange(StyleDifference diff, const RenderStyle* newStyle)
    99105{

  • trunk/Source/WebCore/rendering/svg/RenderSVGInline.h

    r105143 r105549  
    5454    virtual InlineFlowBox* createInlineFlowBox();
    5555
     56    virtual void willBeDestroyed();
    5657    virtual void styleWillChange(StyleDifference, const RenderStyle* newStyle);
    5758    virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
Note: See TracChangeset for help on using the changeset viewer.