Changeset 105652 in webkit

Timestamp:

Jan 23, 2012, 4:01:23 PM (15 years ago)

Author:

eae@chromium.org

Message:

check-webkit-style whitespace/operators triggers on overloaded division operator
​https://bugs.webkit.org/show_bug.cgi?id=76650

Reviewed by Darin Adler.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_operator_methods):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp.py (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-01-23  Emil A Eklund  <eae@chromium.org>
+
+        check-webkit-style whitespace/operators triggers on overloaded division operator
+        https://bugs.webkit.org/show_bug.cgi?id=76650
+
+        Reviewed by Darin Adler.
+
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_spacing):
+        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+        (CppStyleTest.test_operator_methods):
+
 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py

@@ -1809 +1809 @@
 
     # Don't try to do spacing checks for operator methods
-    line = sub(r'operator(==|!=|<|<<|<=|>=|>>|>|\+=|-=|\*=|/=|%=|&=|\|=|^=|<<=|>>=)\(', 'operator\(', line)
+    line = sub(r'operator(==|!=|<|<<|<=|>=|>>|>|\+=|-=|\*=|/=|%=|&=|\|=|^=|<<=|>>=|/)\(', 'operator\(', line)
     # Don't try to do spacing checks for #include or #import statements at
     # minimum because it messes up checks for spacing around /

trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

@@ -1716 +1716 @@
     def test_operator_methods(self):
         self.assert_lint('String operator+(const String&, const String&);', '')
+        self.assert_lint('String operator/(const String&, const String&);', '')
         self.assert_lint('bool operator==(const String&, const String&);', '')
         self.assert_lint('String& operator-=(const String&, const String&);', '')