Changeset 106610 in webkit

Timestamp:

Feb 2, 2012, 6:13:25 PM (15 years ago)

Author:

commit-queue@webkit.org

Message:

Avoid crashing renderer when GPU process dies by not caching textures between video frames.
​https://bugs.webkit.org/show_bug.cgi?id=77654

Patch by Ami Fischman <​fischman@chromium.org> on 2012-02-02
Reviewed by James Robinson.

• platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/cc/CCVideoLayerImpl.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-02  Ami Fischman  <fischman@chromium.org>
+
+        Avoid crashing renderer when GPU process dies by not caching textures between video frames.
+        https://bugs.webkit.org/show_bug.cgi?id=77654
+
+        Reviewed by James Robinson.
+
+        * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
+        (WebCore::CCVideoLayerImpl::draw):
+
 2012-02-02  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp

@@ -151 +151 @@
     }
 
-    for (unsigned plane = 0; plane < frame->planes(); ++plane)
+    for (unsigned plane = 0; plane < frame->planes(); ++plane) {
         m_textures[plane].m_texture->unreserve();
+        // FIXME: ManagedTexture's store a raw pointer to their TextureManager,
+        // and the textures we create use layerRenderer->renderSurfaceTextureManager().
+        // Since there is no guarantee layerRenderer will still be alive the
+        // next time we are called, we clear the texture reference. It would
+        // be nice if instead we could rely on textures being invalidated when
+        // their manager was deleted so that new textures didn't always have to
+        // be recreated for each frame.
+        m_textures[plane].m_texture.clear();
+    }
     m_provider->putCurrentFrame(frame);
 }