Changeset 106727 in webkit

Timestamp:

Feb 3, 2012, 7:59:10 PM (15 years ago)

Author:

abarth@webkit.org

Message:

List of all failures in garden-o-matic should actually list all the failures
​https://bugs.webkit.org/show_bug.cgi?id=77796

Reviewed by Eric Seidel.

This patch wires a bit more data into the new "All Failures" tab. I've
also iterated on how we enable this experimental feature. The tab is
still just a dumb list, but we'll make it smarter.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js (modified) (4 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (modified) (3 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js

@@ -95 +95 @@
 });
 
+controllers.ExpectedFailures = base.extends(Object, {
+    init: function(model, view, delegate)
+    {
+        this._model = model;
+        this._view = view;
+        this._delegate = delegate;
+    },
+    update: function()
+    {
+        var expectedOrUnexpectedFailures = results.expectedOrUnexpectedFailuresByTest(this._model.resultsByBuilder);
+        this._view.setFailingTests(Object.keys(expectedOrUnexpectedFailures));
+    }
+});
+
 var FailureStreamController = base.extends(Object, {
     _resultsFilter: null,

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js

@@ -33 +33 @@
 
 var g_unexpectedFailuresController = null;
+var g_failuresController = null;
 
 var g_losingTestCoverageBuilders = null;
@@ -50 +51 @@
 
     base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
+        if (g_failuresController)
+            g_failuresController.update();
 
         updating.update('Analyzing test failures ...');
@@ -84 +87 @@
         {
             var resultsContainer = onebar.results();
+            console.log(resultsContainer);
             $(resultsContainer).empty().append(resultsView);
             onebar.select('results');
@@ -105 +109 @@
     unexpected.appendChild(unexpectedFailuresView);
 
-    var expected = onebar.expected();
-    if (expected) {
-        var expectedFailuresView = new ui.failures.List();
-        expected.appendChild(expectedFailuresView);
+    var failures = onebar.failures();
+    if (failures) {
+        var failuresView = new ui.failures.List();
+        g_failuresController = new controllers.ExpectedFailures(model.state, failuresView, onebarController);
+        failures.appendChild(failuresView);
     }
 

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js

@@ -65 +65 @@
             '<ul>' +
                 '<li><a href="#unexpected">Unexpected Failures</a></li>' +
-                '<li><a href="#expected">Expected Failures</a></li>' +
                 '<li><a href="#results">Results</a></li>' +
             '</ul>' +
             '<div id="unexpected"></div>' +
-            '<div id="expected"></div>' +
+            '<div id="failures"></div>' +
             '<div id="results"></div>';
         this._tabNames = [
             'unexpected',
-            'expected',
             'results',
         ]
         this._tabs = $(this).tabs({
-            disabled: [2],
+            disabled: [1],
         });
-        if (!config.kExperimentalFeatures)
-            this._tabs.tabs('remove', 1);
+        if (config.kExperimentalFeatures) {
+            this._tabs.tabs('add', '#failures', 'All Failures (experimental)');
+            this._tabNames.push('failures');
+        }
     },
     attach: function()
@@ -88 +88 @@
     tabNamed: function(tabName)
     {
+        if (this._tabNames.indexOf(tabName) == -1)
+            return null;
         tab = document.getElementById(tabName);
-        if (!tab)
-            return null;
         // We perform this sanity check below to make sure getElementById
         // hasn't given us a node in some other unrelated part of the document.
@@ -103 +103 @@
         return this.tabNamed('unexpected');
     },
-    expected: function()
+    failures: function()
     {
-        return this.tabNamed('expected');
+        return this.tabNamed('failures');
     },
     results: function()

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js

@@ -131 +131 @@
     init: function()
     {
-        this.textContent = "TODO: List failures here.";
+        this.textContent = 'Loading...';
+    },
+    setFailingTests: function(failingTestsList)
+    {
+        $(this).empty();
+        var list = this.appendChild(document.createElement('ul'));
+        failingTestsList.sort().forEach(function(failingTest) {
+            list.appendChild(document.createElement('li')).textContent = failingTest;
+        });
     }
 });

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-03  Adam Barth  <abarth@webkit.org>
+
+        List of all failures in garden-o-matic should actually list all the failures
+        https://bugs.webkit.org/show_bug.cgi?id=77796
+
+        Reviewed by Eric Seidel.
+
+        This patch wires a bit more data into the new "All Failures" tab.  I've
+        also iterated on how we enable this experimental feature.  The tab is
+        still just a dumb list, but we'll make it smarter.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
+
 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>