⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 106880 in webkit


Ignore:
Timestamp:
Feb 6, 2012, 5:07:59 PM (15 years ago)
Author:
eae@chromium.org
Message:

Convert PopupMenuClient::clientPadding over to new layout abstraction
​https://bugs.webkit.org/show_bug.cgi?id=77798

Reviewed by Eric Seidel.

Change PopupMenuClient and all classes inheriting from it to use the new
layout types for padding.

Source/WebCore:

No new tests.

  • platform/PopupMenuClient.h:

(PopupMenuClient):

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

  • rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::clientPaddingLeft):
(WebKit::AutofillPopupMenuClient::clientPaddingRight):

  • src/AutofillPopupMenuClient.h:

(AutofillPopupMenuClient):

  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::clientPaddingLeft):
(WebKit::TestPopupMenuClient::clientPaddingRight):

Location:
trunk/Source
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r106878 r106880  
     12012-02-06  Emil A Eklund  <eae@chromium.org>
     2
     3        Convert PopupMenuClient::clientPadding over to new layout abstraction
     4        https://bugs.webkit.org/show_bug.cgi?id=77798
     5
     6        Reviewed by Eric Seidel.
     7
     8        Change PopupMenuClient and all classes inheriting from it to use the new
     9        layout types for padding.
     10
     11        No new tests.
     12
     13        * platform/PopupMenuClient.h:
     14        (PopupMenuClient):
     15        * rendering/RenderMenuList.h:
     16        * rendering/RenderTextControlSingleLine.cpp:
     17        (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
     18        (WebCore::RenderTextControlSingleLine::clientPaddingRight):
     19        * rendering/RenderTextControlSingleLine.h:
     20
    1212012-02-06  Philip Rogers  <pdr@google.com>
    222

  • trunk/Source/WebCore/platform/PopupMenuClient.h

    r105570 r106880  
    2323#define PopupMenuClient_h
    2424
     25#include "LayoutTypes.h"
    2526#include "PopupMenuStyle.h"
    2627#include "ScrollTypes.h"
    … …  
    5253    virtual int clientInsetLeft() const = 0;
    5354    virtual int clientInsetRight() const = 0;
    54     virtual int clientPaddingLeft() const = 0;
    55     virtual int clientPaddingRight() const = 0;
     55    virtual LayoutUnit clientPaddingLeft() const = 0;
     56    virtual LayoutUnit clientPaddingRight() const = 0;
    5657    virtual int listSize() const = 0;
    5758    virtual int selectedIndex() const = 0;

  • trunk/Source/WebCore/rendering/RenderMenuList.h

    r105637 r106880  
    9292    virtual int clientInsetLeft() const OVERRIDE;
    9393    virtual int clientInsetRight() const OVERRIDE;
    94     virtual int clientPaddingLeft() const OVERRIDE;
    95     virtual int clientPaddingRight() const OVERRIDE;
     94    virtual LayoutUnit clientPaddingLeft() const OVERRIDE;
     95    virtual LayoutUnit clientPaddingRight() const OVERRIDE;
    9696    virtual int listSize() const OVERRIDE;
    9797    virtual int selectedIndex() const OVERRIDE;

  • trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp

    r105451 r106880  
    639639}
    640640
    641 int RenderTextControlSingleLine::clientPaddingLeft() const
    642 {
    643     int padding = paddingLeft();
     641LayoutUnit RenderTextControlSingleLine::clientPaddingLeft() const
     642{
     643    LayoutUnit padding = paddingLeft();
    644644
    645645    HTMLElement* resultsButton = resultsButtonElement();
    … …  
    650650}
    651651
    652 int RenderTextControlSingleLine::clientPaddingRight() const
    653 {
    654     int padding = paddingRight();
     652LayoutUnit RenderTextControlSingleLine::clientPaddingRight() const
     653{
     654    LayoutUnit padding = paddingRight();
    655655
    656656    HTMLElement* cancelButton = cancelButtonElement();

  • trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h

    r105637 r106880  
    104104    virtual int clientInsetLeft() const OVERRIDE;
    105105    virtual int clientInsetRight() const OVERRIDE;
    106     virtual int clientPaddingLeft() const OVERRIDE;
    107     virtual int clientPaddingRight() const OVERRIDE;
     106    virtual LayoutUnit clientPaddingLeft() const OVERRIDE;
     107    virtual LayoutUnit clientPaddingRight() const OVERRIDE;
    108108    virtual int listSize() const OVERRIDE;
    109109    virtual int selectedIndex() const OVERRIDE;

  • trunk/Source/WebKit/chromium/ChangeLog

    r106870 r106880  
     12012-02-06  Emil A Eklund  <eae@chromium.org>
     2
     3        Convert PopupMenuClient::clientPadding over to new layout abstraction
     4        https://bugs.webkit.org/show_bug.cgi?id=77798
     5
     6        Reviewed by Eric Seidel.
     7
     8        Change PopupMenuClient and all classes inheriting from it to use the new
     9        layout types for padding.
     10
     11        * src/AutofillPopupMenuClient.cpp:
     12        (WebKit::AutofillPopupMenuClient::clientPaddingLeft):
     13        (WebKit::AutofillPopupMenuClient::clientPaddingRight):
     14        * src/AutofillPopupMenuClient.h:
     15        (AutofillPopupMenuClient):
     16        * tests/PopupMenuTest.cpp:
     17        (WebKit::TestPopupMenuClient::clientPaddingLeft):
     18        (WebKit::TestPopupMenuClient::clientPaddingRight):
     19
    1202012-02-06  James Robinson  <jamesr@chromium.org>
    221

  • trunk/Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp

    r102044 r106880  
    197197}
    198198
    199 int AutofillPopupMenuClient::clientPaddingLeft() const
     199WebCore::LayoutUnit AutofillPopupMenuClient::clientPaddingLeft() const
    200200{
    201201    // Bug http://crbug.com/7708 seems to indicate the style can be 0.
    … …  
    207207}
    208208
    209 int AutofillPopupMenuClient::clientPaddingRight() const
     209WebCore::LayoutUnit AutofillPopupMenuClient::clientPaddingRight() const
    210210{
    211211    // Bug http://crbug.com/7708 seems to indicate the style can be 0.

  • trunk/Source/WebKit/chromium/src/AutofillPopupMenuClient.h

    r97220 r106880  
    8585    virtual int clientInsetLeft() const { return 0; }
    8686    virtual int clientInsetRight() const { return 0; }
    87     virtual int clientPaddingLeft() const;
    88     virtual int clientPaddingRight() const;
     87    virtual WebCore::LayoutUnit clientPaddingLeft() const;
     88    virtual WebCore::LayoutUnit clientPaddingRight() const;
    8989    virtual int listSize() const { return getSuggestionsCount(); }
    9090    virtual int selectedIndex() const { return m_selectedIndex; }

  • trunk/Source/WebKit/chromium/tests/PopupMenuTest.cpp

    r103112 r106880  
    101101    virtual int clientInsetLeft() const { return 0; }
    102102    virtual int clientInsetRight() const { return 0; }
    103     virtual int clientPaddingLeft() const { return 0; }
    104     virtual int clientPaddingRight() const { return 0; }
     103    virtual LayoutUnit clientPaddingLeft() const { return 0; }
     104    virtual LayoutUnit clientPaddingRight() const { return 0; }
    105105    virtual int listSize() const { return 10; }
    106106    virtual int selectedIndex() const { return m_selectIndex; }
Note: See TracChangeset for help on using the changeset viewer.