Changeset 107148 in webkit

Timestamp:

Feb 8, 2012, 4:21:20 PM (15 years ago)

Author:

haraken@chromium.org

Message:

Remove [ConvertToString] from CodeGeneratorCPP.pm and rename
it to [ObjCImplementedAsUnsignedLong]
​https://bugs.webkit.org/show_bug.cgi?id=78100

Reviewed by Eric Seidel.

Now [ConvertToString] is used by ObjC's HTMLElement.size only.
This patch removes [ConvertToString] code from CodeGeneratorCPP.pm,
and renames [ConvertToString] to [ObjCImplementedAsUnsignedLong].

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

• html/HTMLInputElement.idl: Removed FIXME comment, because the latest spec

says HTMLInputElement.size should be unsigned long.
(​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#the-input-element)

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorCPP.pm (modified) (1 diff)
• bindings/scripts/CodeGeneratorObjC.pm (modified) (2 diffs)
• html/HTMLInputElement.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-08  Kentaro Hara  <haraken@chromium.org>
+
+        Remove [ConvertToString] from CodeGeneratorCPP.pm and rename
+        it to [ObjCImplementedAsUnsignedLong]
+        https://bugs.webkit.org/show_bug.cgi?id=78100
+
+        Reviewed by Eric Seidel.
+
+        Now [ConvertToString] is used by ObjC's HTMLElement.size only.
+        This patch removes [ConvertToString] code from CodeGeneratorCPP.pm,
+        and renames [ConvertToString] to [ObjCImplementedAsUnsignedLong].
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorCPP.pm:
+        (GenerateImplementation):
+        * bindings/scripts/CodeGeneratorObjC.pm:
+        (GenerateImplementation):
+        * html/HTMLInputElement.idl: Removed FIXME comment, because the latest spec
+        says HTMLInputElement.size should be unsigned long.
+        (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#the-input-element)
+
 2012-02-08  Leo Yang  <leo.yang@torchmobile.com.cn>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm

@@ -749 +749 @@
                 my $arg = GetCPPTypeGetter($argName, $idlType);
 
-                # The definition of ConvertToString is flipped for the setter
-                if ($attribute->signature->extendedAttributes->{"ConvertToString"}) {
-                    $arg = "WTF::String($arg).toInt()";
-                }
-
                 my $attributeType = GetCPPType($attribute->signature->type, 1);
                 push(@implContent, "void $className\:\:$setterName($attributeType $argName)\n");

trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm

@@ -1258 +1258 @@
                 }
                 $implIncludes{"DOMPrivate.h"} = 1;
-            } elsif ($attribute->signature->extendedAttributes->{"ConvertToString"}) {
+            } elsif ($attribute->signature->extendedAttributes->{"ObjCImplementedAsUnsignedLong"}) {
                 $getterContentHead = "WTF::String::number(" . $getterContentHead;
                 $getterContentTail .= ")";
@@ -1385 +1385 @@
                 my $arg = GetObjCTypeGetter($argName, $idlType);
 
-                # The definition of ConvertToString is flipped for the setter
-                if ($attribute->signature->extendedAttributes->{"ConvertToString"}) {
+                # The definition of ObjCImplementedAsUnsignedLong is flipped for the setter
+                if ($attribute->signature->extendedAttributes->{"ObjCImplementedAsUnsignedLong"}) {
                     $arg = "WTF::String($arg).toInt()";
                 }

trunk/Source/WebCore/html/HTMLInputElement.idl

@@ -51 +51 @@
         attribute [Reflect] boolean required;
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
-        attribute [ConvertToString] DOMString size; // DOM level 2 changed this to a long, but our existing API is a string
+        attribute [ObjCImplementedAsUnsignedLong] DOMString size; // DOM level 2 changed this to a long, but ObjC API is a string
 #else
-        // FIXME: The spec says this should be a long, not an unsigned long.
-        attribute unsigned long size; // Changed string -> long as part of DOM level 2
+        attribute unsigned long size; // Changed string -> long -> unsigned long
 #endif
         attribute [Reflect, URL] DOMString src;