Changeset 107153 in webkit

Timestamp:

Feb 8, 2012, 4:32:08 PM (15 years ago)

Author:

abarth@webkit.org

Message:

test_configuration.py shouldn't re-implement itertools
​https://bugs.webkit.org/show_bug.cgi?id=78178

Reviewed by Eric Seidel.

• Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.to_specifiers_list):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):
(TestConfigurationConverter):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/models/test_configuration.py (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-08  Adam Barth  <abarth@webkit.org>
+
+        test_configuration.py shouldn't re-implement itertools
+        https://bugs.webkit.org/show_bug.cgi?id=78178
+
+        Reviewed by Eric Seidel.
+
+        * Scripts/webkitpy/layout_tests/models/test_configuration.py:
+        (TestConfigurationConverter.to_specifiers_list):
+        (TestConfigurationConverter.to_specifiers_list.try_collapsing):
+        (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
+        (TestConfigurationConverter):
+
 2012-02-08  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py

@@ -26 +26 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-"""Representation of a layout test configuration."""
-
+
+import itertools
 
 class TestConfiguration(object):
@@ -190 +190 @@
             specifiers_list.append(frozenset(values))
 
-        # FIXME: Replace with iteritools.combinations when we obsolete Python 2.5.
-        def combinations(iterable, r):
-            """This function is borrowed verbatim from http://docs.python.org/library/itertools.html#itertools.combinations."""
-            pool = tuple(iterable)
-            n = len(pool)
-            if r > n:
-                return
-            indices = range(r)
-            yield tuple(pool[i] for i in indices)
-            while True:
-                for i in reversed(range(r)):
-                    if indices[i] != i + n - r:
-                        break
-                else:
-                    return
-                indices[i] += 1
-                for j in range(i + 1, r):
-                    indices[j] = indices[j - 1] + 1
-                yield tuple(pool[i] for i in indices)
-
         def intersect_combination(combination):
             return reduce(set.intersection, [set(specifiers) for specifiers in combination])
@@ -219 +199 @@
             if len(specifiers_list) < size:
                 return False
-            for combination in combinations(specifiers_list, size):
+            for combination in itertools.combinations(specifiers_list, size):
                 if symmetric_difference(combination) in collapsing_sets:
                     for item in combination:
@@ -236 +216 @@
             if len(specifiers_list) < 2:
                 return False
-            for combination in combinations(specifiers_list, 2):
+            for combination in itertools.combinations(specifiers_list, 2):
                 for collapsing_set in collapsing_sets:
                     diff = symmetric_difference(combination)