Changeset 107282 in webkit

Timestamp:

Feb 9, 2012, 1:20:49 PM (15 years ago)

Author:

enne@google.com

Message:

[chromium] Correct potential double reserveTextures() in CCLayerTreeHost
​https://bugs.webkit.org/show_bug.cgi?id=78258

Reviewed by James Robinson.

This isn't a problem currently, because scrollbar layers don't create
render surfaces. However, if this ever got used for other layers, we
could call reserve on them twice needlessly. It's also just bad form
to have an iterator doing the wrong thing.

• platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::reserveTextures):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/cc/CCLayerTreeHost.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-09  Adrienne Walker  <enne@google.com>
+
+        [chromium] Correct potential double reserveTextures() in CCLayerTreeHost
+        https://bugs.webkit.org/show_bug.cgi?id=78258
+
+        Reviewed by James Robinson.
+
+        This isn't a problem currently, because scrollbar layers don't create
+        render surfaces. However, if this ever got used for other layers, we
+        could call reserve on them twice needlessly. It's also just bad form
+        to have an iterator doing the wrong thing.
+
+        * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+        (WebCore::CCLayerTreeHost::reserveTextures):
+
 2012-02-09  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp

@@ -448 +448 @@
     CCLayerIteratorType end = CCLayerIteratorType::end(&m_updateList);
     for (CCLayerIteratorType it = CCLayerIteratorType::begin(&m_updateList); it != end; ++it) {
-        if (it.representsTargetRenderSurface() || !it->alwaysReserveTextures())
+        if (!it.representsItself() || !it->alwaysReserveTextures())
             continue;
         it->reserveTextures();