⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 107329 in webkit


Ignore:
Timestamp:
Feb 9, 2012, 5:45:39 PM (15 years ago)
Author:
jamesr@google.com
Message:

[chromium] Enable mock scrollbars for compositing layout tests
​https://bugs.webkit.org/show_bug.cgi?id=78299

Reviewed by Dirk Pranke.

Tools:

This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

LayoutTests:

  • platform/chromium-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
  • platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png: Removed.
  • platform/chromium-linux/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/chromium-linux/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
  • platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-linux/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/scrollbar-painting-expected.png:
  • platform/chromium-mac/compositing/geometry/tall-page-composited-expected.png: Removed.
  • platform/chromium-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
  • platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
  • platform/chromium-win/compositing/geometry/tall-page-composited-expected.png: Removed.
  • platform/chromium-win/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium/compositing/geometry/tall-page-composited-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium/test_expectations.txt:
Location:
trunk
Files:
1 added
9 deleted
16 edited
1 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r107309 r107329  
     12012-02-09  James Robinson  <jamesr@chromium.org>
     2
     3        [chromium] Enable mock scrollbars for compositing layout tests
     4        https://bugs.webkit.org/show_bug.cgi?id=78299
     5
     6        Reviewed by Dirk Pranke.
     7
     8        * platform/chromium-linux/compositing/direct-image-compositing-expected.png:
     9        * platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
     10        * platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
     11        * platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png: Removed.
     12        * platform/chromium-linux/compositing/iframes/iframe-copy-on-scroll-expected.png:
     13        * platform/chromium-linux/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
     14        * platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
     15        * platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
     16        * platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
     17        * platform/chromium-linux/compositing/overflow/overflow-scroll-expected.png:
     18        * platform/chromium-linux/compositing/overflow/scrollbar-painting-expected.png:
     19        * platform/chromium-mac/compositing/geometry/tall-page-composited-expected.png: Removed.
     20        * platform/chromium-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
     21        * platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
     22        * platform/chromium-win/compositing/geometry/tall-page-composited-expected.png: Removed.
     23        * platform/chromium-win/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
     24        * platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
     25        * platform/chromium/compositing/geometry/ancestor-overflow-change-expected.png:
     26        * platform/chromium/compositing/geometry/tall-page-composited-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png.
     27        * platform/chromium/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
     28        * platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png:
     29        * platform/chromium/test_expectations.txt:
     30
    1312012-02-09  Julien Chaffraix  <jchaffraix@webkit.org>
    232

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r107309 r107329  
    39083908BUGWK77526 WIN LINUX : svg/text/text-align-04-b.svg = PASS IMAGE
    39093909
     3910// Will need rebaselines for mock scrollbars
     3911BUGJAMESR WIN MAC : compositing/direct-image-compositing.html = IMAGE
     3912BUGJAMESR WIN MAC : compositing/geometry/fixed-in-composited.html = IMAGE
     3913BUGJAMESR WIN MAC : compositing/iframes/iframe-copy-on-scroll.html = IMAGE
     3914BUGJAMESR WIN MAC: compositing/masks/masked-ancestor.html = IMAGE
     3915BUGJAMESR WIN MAC : compositing/masks/multiple-masks.html = IMAGE
     3916BUGJAMESR WIN MAC: compositing/masks/simple-composited-mask.html = IMAGE
     3917BUGJAMESR WIN MAC : compositing/overflow/overflow-scroll.html = IMAGE
     3918BUGJAMESR WIN MAC : compositing/overflow/scrollbar-painting.html = IMAGE
     3919
    39103920BUGWK77534 LINUX : plugins/createScriptableObject-before-start.html = PASS MISSING
    39113921

  • trunk/Tools/ChangeLog

    r107302 r107329  
     12012-02-09  James Robinson  <jamesr@chromium.org>
     2
     3        [chromium] Enable mock scrollbars for compositing layout tests
     4        https://bugs.webkit.org/show_bug.cgi?id=78299
     5
     6        Reviewed by Dirk Pranke.
     7
     8        This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
     9        compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
     10        more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
     11
     12        * DumpRenderTree/chromium/TestShell.cpp:
     13        (TestShell::runFileTest):
     14        * DumpRenderTree/chromium/WebPreferences.cpp:
     15        (WebPreferences::reset):
     16        (WebPreferences::applyTo):
     17        * DumpRenderTree/chromium/WebPreferences.h:
     18        (WebPreferences):
     19
    1202012-02-09  Eric Seidel  <eric@webkit.org>
    221

  • trunk/Tools/DumpRenderTree/chromium/TestShell.cpp

    r107022 r107329  
    241241        m_prefs.accelerated2dCanvasEnabled = true;
    242242        m_prefs.deferred2dCanvasEnabled = true;
     243        m_prefs.mockScrollbarsEnabled = true;
    243244        m_prefs.applyTo(m_webView);
    244245    }

  • trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp

    r107022 r107329  
    118118    hixie76WebSocketProtocolEnabled = true;
    119119    perTilePaintingEnabled = false;
     120    mockScrollbarsEnabled = false;
    120121}
    121122
    … …  
    223224    settings->setHixie76WebSocketProtocolEnabled(hixie76WebSocketProtocolEnabled);
    224225    settings->setPerTilePaintingEnabled(perTilePaintingEnabled);
     226    settings->setMockScrollbarsEnabled(mockScrollbarsEnabled);
    225227
    226228    // Fixed values.
    … …  
    232234    settings->setEnableScrollAnimator(false);
    233235    settings->setFontRenderingModeNormal();
    234     settings->setMockScrollbarsEnabled(false);
    235236    settings->setTextDirectionSubmenuInclusionBehaviorNeverIncluded();
    236237    settings->setUsesEncodingDetector(false);

  • trunk/Tools/DumpRenderTree/chromium/WebPreferences.h

    r107022 r107329  
    111111    bool hixie76WebSocketProtocolEnabled;
    112112    bool perTilePaintingEnabled;
     113    bool mockScrollbarsEnabled;
    113114
    114115    WebPreferences() { reset(); }
Note: See TracChangeset for help on using the changeset viewer.