Changeset 107332 in webkit

Timestamp:

Feb 9, 2012, 5:54:43 PM (15 years ago)

Author:

andersca@apple.com

Message:

FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
​https://bugs.webkit.org/show_bug.cgi?id=78291

Reviewed by Dan Bernstein.

m_slowRepaintObjectCount needs to be incremented before calling updateCanBlitOnScrollRecursively(),
because otherwise useSlowRepaints() will return false even though we have to use slow repaints.

I was unable to make a layout test for this because it requires that updateCanBlitOnScrollRecursively() isn't
called again after m_slowRepaintObjectCount has been incremented.

• page/FrameView.cpp:

(WebCore::FrameView::addSlowRepaintObject):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-09  Anders Carlsson  <andersca@apple.com>
+
+        FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
+        https://bugs.webkit.org/show_bug.cgi?id=78291
+
+        Reviewed by Dan Bernstein.
+
+        m_slowRepaintObjectCount needs to be incremented before calling updateCanBlitOnScrollRecursively(),
+        because otherwise useSlowRepaints() will return false even though we have to use slow repaints.
+
+        I was unable to make a layout test for this because it requires that updateCanBlitOnScrollRecursively() isn't
+        called again after m_slowRepaintObjectCount has been incremented.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::addSlowRepaintObject):
+
 2012-02-09  Ojan Vafai  <ojan@chromium.org>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -1329 +1329 @@
 void FrameView::addSlowRepaintObject()
 {
-    if (!m_slowRepaintObjectCount)
+    if (!m_slowRepaintObjectCount++)
         updateCanBlitOnScrollRecursively();
-    m_slowRepaintObjectCount++;
 }