Changeset 107346 in webkit

Timestamp:

Feb 9, 2012, 7:34:21 PM (15 years ago)

Author:

rniwa@webkit.org

Message:

CachedResourceLoader is destroyed before CSSFontSelector is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=77817

Reviewed by Adam Barth.

Explicitly clear style selector before destorying the cached resource loader.

No new tests but PerformanceTests/Parser/html5-full-render.html was crashing
on performance bots due to this bug.

• dom/Document.cpp:

(WebCore::Document::~Document):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
+
+        CachedResourceLoader is destroyed before CSSFontSelector is destroyed
+        https://bugs.webkit.org/show_bug.cgi?id=77817
+
+        Reviewed by Adam Barth.
+
+        Explicitly clear style selector before destorying the cached resource loader.
+
+        No new tests but PerformanceTests/Parser/html5-full-render.html was crashing
+        on performance bots due to this bug.
+
+        * dom/Document.cpp:
+        (WebCore::Document::~Document):
+
 2012-02-09  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -546 +546 @@
     detachParser();
     m_document = 0;
-    m_cachedResourceLoader.clear();
 
     m_renderArena.clear();
@@ -578 +577 @@
     if (m_mediaQueryMatcher)
         m_mediaQueryMatcher->documentDestroyed();
+
+    clearStyleSelector(); // We need to destory CSSFontSelector before destroying m_cachedResourceLoader.
+    m_cachedResourceLoader.clear();
 
     // We must call clearRareData() here since a Document class inherits TreeScope