Changeset 110951 in webkit

Timestamp:

Mar 15, 2012, 11:56:11 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Expose attack, release as DynamicsCompressorNode's attributes.
​https://bugs.webkit.org/show_bug.cgi?id=81221

Patch by Gao Chun <​chun.gao@intel.com> on 2012-03-15
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/dynamicscompressor-basic.html

• platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

• webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):

• webaudio/DynamicsCompressorNode.h:

(WebCore::DynamicsCompressorNode::attack):
(WebCore::DynamicsCompressorNode::release):
(DynamicsCompressorNode):

• webaudio/DynamicsCompressorNode.idl:

LayoutTests:

• webaudio/dynamicscompressor-basic-expected.txt:
• webaudio/dynamicscompressor-basic.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webaudio/dynamicscompressor-basic-expected.txt (modified) (1 diff)
• LayoutTests/webaudio/dynamicscompressor-basic.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/audio/DynamicsCompressor.h (modified) (1 diff)
• Source/WebCore/webaudio/DynamicsCompressorNode.cpp (modified) (3 diffs)
• Source/WebCore/webaudio/DynamicsCompressorNode.h (modified) (2 diffs)
• Source/WebCore/webaudio/DynamicsCompressorNode.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-15  Gao Chun  <chun.gao@intel.com>
+
+        Expose attack, release as DynamicsCompressorNode's attributes.
+        https://bugs.webkit.org/show_bug.cgi?id=81221
+
+        Reviewed by Chris Rogers.
+
+        * webaudio/dynamicscompressor-basic-expected.txt:
+        * webaudio/dynamicscompressor-basic.html:
+
 2012-03-15  Hans Wennborg  <hans@chromium.org>
 

trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt

@@ -6 +6 @@
 PASS knee attribute has correct default value.
 PASS ratio attribute has correct default value.
+PASS attack attribute has correct default value.
+PASS release attribute has correct default value.
 PASS successfullyParsed is true
 

trunk/LayoutTests/webaudio/dynamicscompressor-basic.html

@@ -44 +44 @@
             testFailed("ratio attribute has incorrect default value.");
         
+        if (compressor.attack.value - 0.003 < 1e-7)
+            testPassed("attack attribute has correct default value.");
+        else
+            testFailed("attack attribute has incorrect default value.");
+
+        if (compressor.release.value - 0.25 < 1e-7)
+            testPassed("release attribute has correct default value.");
+        else
+            testFailed("release attribute has incorrect default value.");
+
     } catch(e) {
         testFailed("Exception thrown when accessing DynamicsCompressorNode attributes.");

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-15  Gao Chun  <chun.gao@intel.com>
+
+        Expose attack, release as DynamicsCompressorNode's attributes.
+        https://bugs.webkit.org/show_bug.cgi?id=81221
+
+        Reviewed by Chris Rogers.
+
+        Test: webaudio/dynamicscompressor-basic.html
+
+        * platform/audio/DynamicsCompressor.h:
+        (DynamicsCompressor):
+        * webaudio/DynamicsCompressorNode.cpp:
+        (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
+        (WebCore::DynamicsCompressorNode::process):
+        * webaudio/DynamicsCompressorNode.h:
+        (WebCore::DynamicsCompressorNode::attack):
+        (WebCore::DynamicsCompressorNode::release):
+        (DynamicsCompressorNode):
+        * webaudio/DynamicsCompressorNode.idl:
+
 2012-03-15  Hans Wennborg  <hans@chromium.org>
 

trunk/Source/WebCore/platform/audio/DynamicsCompressor.h

@@ -86 +86 @@
 
     // m_parameters holds the tweakable compressor parameters.
-    // FIXME: expose some of the most important ones (such as threshold, attack, release)
-    // as DynamicsCompressorNode attributes.
     float m_parameters[ParamLast];
     void initializeParameters();

trunk/Source/WebCore/webaudio/DynamicsCompressorNode.cpp

@@ -51 +51 @@
     m_ratio = AudioParam::create("ratio", 12, 1, 20);
     m_reduction = AudioParam::create("reduction", 0, -20, 0);
+    m_attack = AudioParam::create("attack", 0.003, 0, 1);
+    m_release = AudioParam::create("release", 0.250, 0, 1);
 
     m_threshold->setContext(context);
@@ -56 +58 @@
     m_ratio->setContext(context);
     m_reduction->setContext(context);
+    m_attack->setContext(context);
+    m_release->setContext(context);
 
     initialize();
@@ -73 +77 @@
     float knee = m_knee->value();
     float ratio = m_ratio->value();
+    float attack = m_attack->value();
+    float release = m_release->value();
 
     m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamThreshold, threshold);
     m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamKnee, knee);
     m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamRatio, ratio);
+    m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamAttack, attack);
+    m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamRelease, release);
 
     m_dynamicsCompressor->process(input(0)->bus(), outputBus, framesToProcess);

trunk/Source/WebCore/webaudio/DynamicsCompressorNode.h

@@ -53 +53 @@
     AudioParam* knee() { return m_knee.get(); }
     AudioParam* ratio() { return m_ratio.get(); }
+    AudioParam* attack() { return m_attack.get(); }
+    AudioParam* release() { return m_release.get(); }
 
     // Amount by which the compressor is currently compressing the signal in decibels.
@@ -68 +70 @@
     RefPtr<AudioParam> m_ratio;
     RefPtr<AudioParam> m_reduction;
+    RefPtr<AudioParam> m_attack;
+    RefPtr<AudioParam> m_release;
 };
 

trunk/Source/WebCore/webaudio/DynamicsCompressorNode.idl

@@ -32 +32 @@
         readonly attribute AudioParam ratio; // unit-less
         readonly attribute AudioParam reduction; // in Decibels
+        readonly attribute AudioParam attack; // in Seconds
+        readonly attribute AudioParam release; // in Seconds
     };
 }