Changeset 112483 in webkit

Timestamp:

Mar 28, 2012 6:02:28 PM (12 years ago)

Author:

Stephanie Lewis

Message:

Unreviewed, rolling out r110064.
​http://trac.webkit.org/changeset/110064
​https://bugs.webkit.org/show_bug.cgi?id=82537

The patch leaks the DOM when audio elements are used
(Requested by sundiamonde on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-28

Source/WebCore:

• bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

LayoutTests:

• platform/gtk/test_expectations.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/test_expectations.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/js/JSNodeCustom.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-28  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r110064.
+        http://trac.webkit.org/changeset/110064
+        https://bugs.webkit.org/show_bug.cgi?id=82537
+
+        The patch leaks the DOM when audio elements are used
+        (Requested by sundiamonde on #webkit).
+
+        * platform/gtk/test_expectations.txt:
+
 2012-03-28  Enrica Casucci  <enrica@apple.com>
 

trunk/LayoutTests/platform/gtk/test_expectations.txt

@@ -69 +69 @@
 BUGWK80129 : fast/frames/flattening/frameset-flattening-subframesets.html = PASS TEXT
 
+BUGWK72698 : media/audio-garbage-collect.html = PASS TEXT
 BUGWK79760 : media/video-poster-blocked-by-willsendrequest.html = PASS TEXT
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-28  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r110064.
+        http://trac.webkit.org/changeset/110064
+        https://bugs.webkit.org/show_bug.cgi?id=82537
+
+        The patch leaks the DOM when audio elements are used
+        (Requested by sundiamonde on #webkit).
+
+        * bindings/js/JSNodeCustom.cpp:
+        (WebCore::isReachableFromDOM):
+
 2012-03-28  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp

@@ -117 +117 @@
     #if ENABLE(VIDEO)
         else if (node->hasTagName(audioTag)) {
-            if (!static_cast<HTMLAudioElement*>(node)->hasPendingActivity())
+            if (!static_cast<HTMLAudioElement*>(node)->paused())
                 return true;
         }