Changeset 113139 in webkit

Timestamp:

Apr 3, 2012, 10:05:37 PM (14 years ago)

Author:

macpherson@chromium.org

Message:

Don't parse "show" and "hide" as valid values for display property.
​https://bugs.webkit.org/show_bug.cgi?id=83115

Reviewed by Adam Barth.

No new tests.

• css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

Location:

trunk

Files:

• LayoutTests/fast/css/display-no-show-hide-expected.html (added)
• LayoutTests/fast/css/display-no-show-hide.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-03  Luke Macpherson  <macpherson@chromium.org>
+
+        Don't parse "show" and "hide" as valid values for display property.
+        https://bugs.webkit.org/show_bug.cgi?id=83115
+
+        Reviewed by Adam Barth.
+
+        No new tests.
+
+        * css/CSSParser.cpp:
+        (WebCore::isValidKeywordPropertyAndValue):
+
 2012-04-03  Yuta Kitamura  <yutak@chromium.org>
 

trunk/Source/WebCore/css/CSSParser.cpp

@@ -532 +532 @@
         if (valueID == CSSValueWebkitGrid || valueID == CSSValueWebkitInlineGrid)
             return true;
-        break;
 #endif
+        break;
     case CSSPropertyEmptyCells: // show | hide | inherit
         if (valueID == CSSValueShow || valueID == CSSValueHide)