Changeset 113307 in webkit


Ignore:
Timestamp:
Apr 5, 2012, 3:14:43 AM (13 years ago)
Author:
hans@chromium.org
Message:

webkit_unit_tests build fix.
​https://bugs.webkit.org/show_bug.cgi?id=83261

Unreviewed, webkit_unit_tests buildfix.

The CCLayerTreeHostTestEmptyContentsShouldNotDraw.runMultiThread test
stopped working after r113254.

Disable it for now.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(WTF::TEST_F):

Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r113300 r113307  
     12012-04-05  Hans Wennborg  <hans@chromium.org>
     2
     3        webkit_unit_tests build fix.
     4        https://bugs.webkit.org/show_bug.cgi?id=83261
     5
     6        Unreviewed, webkit_unit_tests buildfix.
     7
     8        The CCLayerTreeHostTestEmptyContentsShouldNotDraw.runMultiThread test
     9        stopped working after r113254.
     10
     11        Disable it for now.
     12
     13        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
     14        (WebCore::CCLayerTreeHostImpl::canDraw):
     15
    1162012-04-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
    217

  • trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp

    r113254 r113307  
    145145    // FIXME: Reenable after figuring out why this causes the gpu_test
    146146    // ThreadedCompositorTest.ThreadedCompositor to fail.
     147    // Also reenable CCLayerTreeHostTestEmptyContentsShouldNotDraw.runMultiThread
     148    // in webkit_unit_tests.
    147149    if (!rootLayer())  // || rootLayer()->bounds().isEmpty())
    148150        return false;

  • trunk/Source/WebKit/chromium/ChangeLog

    r113301 r113307  
     12012-04-05  Hans Wennborg  <hans@chromium.org>
     2
     3        webkit_unit_tests build fix.
     4        https://bugs.webkit.org/show_bug.cgi?id=83261
     5
     6        Unreviewed, webkit_unit_tests buildfix.
     7
     8        The CCLayerTreeHostTestEmptyContentsShouldNotDraw.runMultiThread test
     9        stopped working after r113254.
     10
     11        Disable it for now.
     12
     13        * tests/CCLayerTreeHostTest.cpp:
     14        (WTF):
     15        (WTF::TEST_F):
     16
    1172012-04-05  Jochen Eisinger  <jochen@chromium.org>
    218

  • trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp

    r113241 r113307  
    871871};
    872872
    873 TEST_F(CCLayerTreeHostTestEmptyContentsShouldNotDraw, runMultiThread)
     873// FIXME: This was disabled after r113254, which made a temporary change to
     874// CCLayerTreeHostImpl::canDraw().
     875TEST_F(CCLayerTreeHostTestEmptyContentsShouldNotDraw, FAILS_runMultiThread)
    874876{
    875877    runTestThreaded();
Note: See TracChangeset for help on using the changeset viewer.